November 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: cmipci: Drop stale variable assignment
by Takashi Iwai 12 Nov '21

12 Nov '21

Since the recent code refactoring using devres, the variable cm in snd_cmipci_probe() is no longer referred. Fixes: 87e082ad84a7 ("ALSA: cmipci: Allocate resources with device-managed APIs") Reported-by: kernel test robot <lkp(a)intel.com> Link: https://lore.kernel.org/r/cc6383a2-cafb-ffe7-0b4f-27a310a1005c@intel.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/cmipci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c index ea20236f35db..9a678b5cf285 100644 --- a/sound/pci/cmipci.c +++ b/sound/pci/cmipci.c @@ -3218,7 +3218,6 @@ static int snd_cmipci_probe(struct pci_dev *pci, { static int dev; struct snd_card *card; - struct cmipci *cm; int err; if (dev >= SNDRV_CARDS) @@ -3229,10 +3228,9 @@ static int snd_cmipci_probe(struct pci_dev *pci, } err = snd_devm_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, - sizeof(*cm), &card); + sizeof(struct cmipci), &card); if (err < 0) return err; - cm = card->private_data; switch (pci->device) { case PCI_DEVICE_ID_CMEDIA_CM8738: -- 2.31.1

1 0

Re: [PATCH v3 2/5] dt-bindings: mfd: timers: Update maintainers for st,stm32-timers
by Lee Jones 12 Nov '21

12 Nov '21

On Wed, 10 Nov 2021, Rob Herring wrote: > On Wed, 10 Nov 2021 16:01:41 +0100, patrice.chotard(a)foss.st.com wrote: > > From: Patrice Chotard <patrice.chotard(a)foss.st.com> > > > > Benjamin has left the company, remove his name from maintainers. > > > > Signed-off-by: Patrice Chotard <patrice.chotard(a)foss.st.com> > > --- > > Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > Lee indicated he was going to pick this one up, so: > > Acked-by: Rob Herring <robh(a)kernel.org> Since you already merged the treewide patch, you may as well take this too. We'll work through any conflicts that may occur as a result. Acked-by: Lee Jones <lee.jones(a)linaro.org> -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

1 0

UCM can't match the USB device ID in Ubuntu 20.04
by GitHub issues - opened 12 Nov '21

12 Nov '21

alsa-project/alsa-ucm-conf issue #119 was opened from shumingfan: We created the UCM2 conf files and used the 'components' string to match the right UCM config. Unfortunately, the system can't apply the right UCM config. The test files and alsa-lib version shows below. USB-Audio.conf https://github.com/perexg/alsa-ucm-conf/commit/e3517b1cbb4ac0c69496329eeb15… Dell-Desktop UCM2 files https://github.com/shumingfan/alsa-ucm-conf/commit/16dce692843b05d9cd720dda… $ alsaucm --version alsaucm: version 1.2.2 Is it possible to resolve this problem when using alsa-lib-1.2.2? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/119 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

speaker-test fails with message "Unknown field hint" on Scarlett 8i6
by GitHub issues - opened 11 Nov '21

11 Nov '21

alsa-project/alsa-plugins issue #40 was opened from montemedio: I am using a Scarlett 8i6 Gen1. It used to work fine, but with the newest version of `speaker-test`, I get this error message: ``` $ speaker-test -Dusbstream:CARD=USB speaker-test 1.2.5.1 Playback device is usbstream:CARD=USB Stream parameters are 48000Hz, S16_LE, 1 channels Using 16 octaves of pink noise ALSA lib pcm_usb_stream.c:503:(_snd_pcm_usb_stream_open) Unknown field hint Playback open error: -22,Invalid argument ``` ``` $ cat /proc/asound/cards 0 [PCH ]: HDA-Intel - HDA Intel PCH HDA Intel PCH at 0xd3a10000 irq 35 1 [NVidia ]: HDA-Intel - HDA NVidia HDA NVidia at 0xd3000000 irq 17 2 [USB ]: USB-Audio - Scarlett 8i6 USB Focusrite Scarlett 8i6 USB at usb-0000:00:1a.0-1.2, high speed ``` Issue URL : https://github.com/alsa-project/alsa-plugins/issues/40 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[PATCH] ALSA: fireworks: add support for Loud Onyx 1200f quirk
by Takashi Sakamoto 11 Nov '21

11 Nov '21

Loud Technologies shipped Onyx 1200f 2008 in its Mackie brand and already discontinued. The model uses component of Fireworks board module as its communication and DSP function. The latest firmware (v4.6.0) has a quirk that tx packet includes wrong value (0x1f) in its dbs field at middle and higher sampling transfer frequency. It brings ALSA fireworks driver discontinuity of data block counter. This commit fixes it by assuming it as a quirk of firmware version 4.6.0. $ cd linux-firewire-tools/src $ python crpp < /sys/bus/firewire/devices/fw1/config_rom ROM header and bus information block ----------------------------------------------------------------- 400 0404b9ef bus_info_length 4, crc_length 4, crc 47599 404 31333934 bus_name "1394" 408 e064a212 irmc 1, cmc 1, isc 1, bmc 0, pmc 0, cyc_clk_acc 100, max_rec 10 (2048), max_rom 2, gen 1, spd 2 (S400) 40c 000ff209 company_id 000ff2 | 410 62550ce0 device_id 0962550ce0 | EUI-64 000ff20962550ce0 root directory ----------------------------------------------------------------- 414 0008088e directory_length 8, crc 2190 418 03000ff2 vendor 41c 8100000f --> descriptor leaf at 458 420 1701200f model 424 81000018 --> descriptor leaf at 484 428 0c008380 node capabilities 42c 8d000003 --> eui-64 leaf at 438 430 d1000005 --> unit directory at 444 434 08000ff2 (immediate value) eui-64 leaf at 438 ----------------------------------------------------------------- 438 000281ae leaf_length 2, crc 33198 43c 000ff209 company_id 000ff2 | 440 62550ce0 device_id 0962550ce0 | EUI-64 000ff20962550ce0 unit directory at 444 ----------------------------------------------------------------- 444 00045d94 directory_length 4, crc 23956 448 1200a02d specifier id: 1394 TA 44c 13010000 version 450 1701200f model 454 8100000c --> descriptor leaf at 484 descriptor leaf at 458 ----------------------------------------------------------------- 458 000a199d leaf_length 10, crc 6557 45c 00000000 textual descriptor 460 00000000 minimal ASCII 464 4d61636b "Mack" 468 69650000 "ie" 46c 00000000 470 00000000 474 00000000 478 00000000 47c 00000000 480 00000000 descriptor leaf at 484 ----------------------------------------------------------------- 484 000a0964 leaf_length 10, crc 2404 488 00000000 textual descriptor 48c 00000000 minimal ASCII 490 4f6e7978 "Onyx" 494 20313230 " 120" 498 30460000 "0F" 49c 00000000 4a0 00000000 4a4 00000000 4a8 00000000 4ac 00000000 Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/fireworks/fireworks_stream.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/firewire/fireworks/fireworks_stream.c b/sound/firewire/fireworks/fireworks_stream.c index ac66f08acd6b..53dbd4d4b0d0 100644 --- a/sound/firewire/fireworks/fireworks_stream.c +++ b/sound/firewire/fireworks/fireworks_stream.c @@ -50,8 +50,9 @@ static int init_stream(struct snd_efw *efw, struct amdtp_stream *stream) efw->firmware_version == 0x5070300 || efw->firmware_version == 0x5080000)) efw->tx_stream.flags |= CIP_UNALIGHED_DBC; - // AudioFire9 always reports wrong dbs. - if (efw->is_af9) + // AudioFire9 always reports wrong dbs. Onyx 1200F with the latest firmware (v4.6.0) + // also report wrong dbs at 88.2 kHz or greater. + if (efw->is_af9 || efw->firmware_version == 0x4060000) efw->tx_stream.flags |= CIP_WRONG_DBS; // Firmware version 5.5 reports fixed interval for dbc. if (efw->firmware_version == 0x5050000) -- 2.32.0

2 1

[PATCH] ALSA: usb-audio: add the profile name of Dell desktop
by shumingf＠realtek.com 11 Nov '21

11 Nov '21

From: Shuming Fan <shumingf(a)realtek.com> Add the profile name to let userspace pick correct UCM profile Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- sound/usb/card.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/usb/card.c b/sound/usb/card.c index 1764b9302d46..9c67ecbe710e 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -398,6 +398,10 @@ static const struct usb_audio_device_name usb_audio_names[] = { PROFILE_NAME(0x0bda, 0x4014, "Dell", "WD15 Dock", "Dell-WD15-Dock"), /* Dell WD19 Dock */ PROFILE_NAME(0x0bda, 0x402e, "Dell", "WD19 Dock", "Dell-WD15-Dock"), + /* Dell Desktop - Front */ + PROFILE_NAME(0x0bda, 0x4c54, "Dell", "Desktop", "Dell-Desktop-Front"), + /* Dell Desktop - Rear */ + PROFILE_NAME(0x0bda, 0x4c55, "Dell", "Desktop", "Dell-Desktop-Rear"), DEVICE_NAME(0x0ccd, 0x0028, "TerraTec", "Aureon5.1MkII"), -- 2.33.0

5 8

[PATCH] ALSA: hda: Free card instance properly at probe errors
by Takashi Iwai 10 Nov '21

10 Nov '21

The recent change in hda-intel driver to allow repeated probes surfaced a problem that has been hidden until; the probe process in the work calls azx_free() at the error path, and this skips the card free process that eventually releases codec instances. As a result, we get a kernel WARNING like: snd_hda_intel 0000:00:1f.3: Cannot probe codecs, giving up ------------[ cut here ]------------ WARNING: CPU: 14 PID: 186 at sound/hda/hdac_bus.c:73 .... For fixing this, we need to call snd_card_free() instead of azx_free(). Additionally, the device drvdata has to be cleared, as the driver binding itself is still active. Then the PM and other driver callbacks will ignore the procedure. Fixes: c0f1886de7e1 ("ALSA: hda: intel: Allow repeatedly probing on codec configuration errors") Reported-and-tested-by: Scott Branden <scott.branden(a)broadcom.com> Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/063e2397-7edb-5f48-7b0d-618b938d9dd8@broadcom.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 7762718cf429..90e9263ac0bd 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2327,7 +2327,8 @@ static int azx_probe_continue(struct azx *chip) out_free: if (err < 0) { - azx_free(chip); + pci_set_drvdata(pci, NULL); + snd_card_free(chip->card); return err; } -- 2.26.2

1 0

5.15 Linux Regression in sound hda
by Scott Branden 10 Nov '21

10 Nov '21

I'm reporting a new WARN_ON in sound/hda/hdac_bus.c that was not present in 5.15. Sorry, I don't have time to bisect this right now but report is below. dmesg in 5.14 kernel was: snd_hda_intel 0000:00:1f.3: bound 0000:00:02.0 (ops 0xffffffffaa2ac520) GACT probability on Mirror/redirect action on Simple TC action Loaded u32 classifier Performance counters on input device check on Actions configured hdaudio hdaudioC0D0: Unable to bind the codec hdaudio hdaudioC0D2: Unable to bind the codec dmesg in 5.15 kernel produces WARN_ON in sound/hda/hdac_bus.c snd_hda_intel 0000:00:1f.3: bound 0000:00:02.0 (ops 0xffffffffad8b02a0) GACT probability on Mirror/redirect action on Simple TC action Loaded u32 classifier Performance counters on input device check on Actions configured snd_hda_intel 0000:00:1f.3: Cannot probe codecs, giving up Initializing XFRM netlink socket ------------[ cut here ]------------ NET: Registered PF_INET6 protocol family WARNING: CPU: 14 PID: 186 at sound/hda/hdac_bus.c:73 snd_hdac_bus_exit+0x40/0x50 Segment Routing with IPv6 Modules linked in: CPU: 14 PID: 186 Comm: kworker/14:2 Tainted: G I 5.15.0 #1 Hardware name: ASUSTeK COMPUTER INC. System Product Name/WS C246 PRO, BIOS 1401 08/13/2020 In-situ OAM (IOAM) with IPv6 Workqueue: events azx_probe_work sit: IPv6, IPv4 and MPLS over IPv4 tunneling driver RIP: 0010:snd_hdac_bus_exit+0x40/0x50 NET: Registered PF_PACKET protocol family Code: 75 19 48 8b 57 58 48 8d 47 58 48 39 c2 75 1b 48 81 c7 f8 02 00 00 e9 ff 97 57 ff 0f 0b 48 8b 57 58 48 8d 47 58 48 39 c2 74 e5 <0f> 0b 48 81 c7 f8 02 00 00 e9 e2 97 57 ff 66 90 0f 1f 44 00 00 41 RPC: Registered rdma transport module. RSP: 0000:ffffa545007b7e88 EFLAGS: 00010202 RPC: Registered rdma backchannel transport module. Key type dns_resolver registered RAX: ffff89f483078880 RBX: ffff89f483078828 RCX: 0000000080200010 RDX: ffff89f4830792f0 RSI: 0000000000000001 RDI: ffff89f483078828 RBP: ffff89f483078e70 R08: 0000000000000000 R09: ffffffffacf094a4 R10: 0000000000000004 R11: 0000000000000032 R12: ffff89f7dbda50c0 R13: ffff89f7dbda9100 R14: 0000000000000000 R15: ffff89f7dbda9105 FS: 0000000000000000(0000) GS:ffff89f7dbd80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 0000000194a0c001 CR4: 00000000003706e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: azx_free+0xba/0x170 process_one_work+0x1db/0x380 worker_thread+0x4d/0x3e0 ? rescuer_thread+0x370/0x370 kthread+0x124/0x150 ? set_kthread_struct+0x40/0x40 ret_from_fork+0x1f/0x30 ---[ end trace 9779b9e2ef53104c ]---

2 3

[PATCH] ALSA: hda/realtek: Add quirk for HP EliteBook 840 G7 mute LED
by Kai-Heng Feng 10 Nov '21

10 Nov '21

The mute and micmute LEDs don't work on HP EliteBook 840 G7. The same quirk for other HP laptops can let LEDs work, so apply it. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index a6098c942aeb5..2f1727faec698 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8636,6 +8636,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8716, "HP Elite Dragonfly G2 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8720, "HP EliteBook x360 1040 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8728, "HP EliteBook 840 G7", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT), -- 2.32.0

2 1

ucm2: Add support for SC7180 Trogdor Lazor Chromebooks
by GitHub pull_request - edited 10 Nov '21

10 Nov '21

alsa-project/alsa-ucm-conf pull request #118 was edited from kholk: Almost all Trogdor Chromebooks are using RT5682 for headphones/headset on 3.5mm jack, internal microphone and headset microphone, and MAX98357A for the internal speakers (Lazor and Limozeen). This adds support for the sc7180-rt5682-max98357a-1mic sound card found on the aforementioned Chromebooks. `Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com>` Tested on sc7180-trogdor-lazor-limozeen-nots. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/118 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/118.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0