July 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH v3 00/10] topology: decode: Various fixes
by Piotr Maziarz 15 Jul '20

15 Jul '20

This series fixes various problems with topology decoding mechanism. Some of the problems were critical like improper memory management or infinite loops that were causing undefined behaviour or program crashes, while other resulted in losing some data during conversion. Bugs found while testing with Intel SST topologies. Changelog: v2: -Divide into more patches, critical fixes are in separate patches now -More specific descriptions -Fix a typo UML to UCM -Add error reporting in topology: decode: fix channel map memory allocation -Remove goto again in topology: Make buffer for saving dynamic size for better readability v3: -No functional changes -Changed UCM to more descriptive standard ALSA configuration files -removed Gerrit's Change-Id -Added missing signed-offs Piotr Maziarz (10): topology: decode: Fix channel map memory allocation topology: decode: Fix infinite loop in decoding enum control topology: decode: Remove decoding values for enum control topology: decode: Add enum control texts as separate element topology: decode: Fix printing texts section topology: decode: Change declaration of enum decoding function topology: decode: Fix decoding PCM formats and rates topology: decode: Print sig_bits field in PCM capabilities section topology: decode: Add DAI name printing topology: Make buffer for saving dynamic size src/topology/ctl.c | 51 ++++++++++++++++++++++------------------------- src/topology/dapm.c | 3 +-- src/topology/pcm.c | 11 +++++++--- src/topology/save.c | 34 ++++++++++++++++++++++++++----- src/topology/text.c | 2 +- src/topology/tplg_local.h | 2 +- 6 files changed, 64 insertions(+), 39 deletions(-) -- 2.7.4

3 16

[PATCH 0/9] soundwire: intel: revisit SHIM programming
by Bard Liao 15 Jul '20

15 Jul '20

This series does some cleanup, revisits SHIM programming sequences, and merges Soundwire interrupt handlers/threads. Bard Liao (2): soundwire: intel/cadence: merge Soundwire interrupt handlers/threads Soundwire: intel_init: save Slave(s) _ADR info in sdw_intel_ctx Pierre-Louis Bossart (6): soundwire: intel: reuse code for wait loops to set/clear bits soundwire: intel: revisit SHIM programming sequences. soundwire: intel: introduce a helper to arm link synchronization soundwire: intel: introduce helper for link synchronization soundwire: intel_init: add implementation of sdw_intel_enable_irq() soundwire: intel_init: use EXPORT_SYMBOL_NS Rander Wang (1): soundwire: intel: add wake interrupt support drivers/soundwire/cadence_master.c | 18 +- drivers/soundwire/cadence_master.h | 4 + drivers/soundwire/intel.c | 389 ++++++++++++++++++++++------ drivers/soundwire/intel.h | 9 + drivers/soundwire/intel_init.c | 101 +++++++- include/linux/soundwire/sdw_intel.h | 2 + 6 files changed, 425 insertions(+), 98 deletions(-) -- 2.17.1

4 22

[DMIX Plugin] Using Different bindings for same Alsa card
by Vijay Palaniswamy (RBEI/ECF3) 15 Jul '20

15 Jul '20

Hi All, I have two virtual device pointing to same Alsa card ,with different bindings When audio played on both device [dmix_4_channels and dmix_2_channels] in parallel. Audio played on dmix_2_channels is getting corrupted. Validated with alsa versio : 1.2.3 Please let me know how to make it work with below configuration. Alsa configuration used for testing: ************************************************* pcm.dmix_4_channels { type dmix ipc_key 5678293 ipc_perm 0660 ipc_gid audio bindings [0 1 2 3] slave { pcm "hardware" channels 4 periods 4 period_time 40000 } } pcm.dmix_2_channels { type dmix ipc_key 5678293 ipc_perm 0660 ipc_gid audio bindings [0 1] slave { pcm "hardware" channels 2 periods 4 period_time 40000 } } pcm.hardware { type hw card 0 channels 4 rate 48000 format S16_LE } ************************************************* Best regards Palaniswamy Vijay

1 0

[PATCH 0/2] soundwire: sdw.h: fix PRBS/Static_1 swapped
by Bard Liao 15 Jul '20

15 Jul '20

Fix PRBS/Static_1 swapped definitions and indentation in sdw.h Pierre-Louis Bossart (2): soundwire: sdw.h: fix PRBS/Static_1 swapped definitions soundwire: sdw.h: fix indentation include/linux/soundwire/sdw.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 2.17.1

2 3

[PATCH 0/3] ASoC: fsl-asoc-card: Support hp and mic detection
by Shengjiu Wang 15 Jul '20

15 Jul '20

Support hp and mic detection. Add a parameter for asoc_simple_init_jack. Shengjiu Wang (3): ASoC: simple-card-utils: Support configure pin_name for asoc_simple_init_jack ASoC: bindings: fsl-asoc-card: Support hp-det-gpio and mic-det-gpio ASoC: fsl-asoc-card: Support Headphone and Microphone Jack detection .../bindings/sound/fsl-asoc-card.txt | 3 + include/sound/simple_card_utils.h | 6 +- sound/soc/fsl/Kconfig | 1 + sound/soc/fsl/fsl-asoc-card.c | 69 ++++++++++++++++++- sound/soc/generic/simple-card-utils.c | 7 +- 5 files changed, 78 insertions(+), 8 deletions(-) -- 2.27.0

3 6

[PATCH v2 0/5] soundwire: handle stream at the dailink level
by Bard Liao 15 Jul '20

15 Jul '20

Currently, stream is handled at the dai level. But we have to handle stream at the dailink level in the multi-cpu dailink usage. changes in v2: - Add kernel doc - Use single line trace log Pierre-Louis Bossart (5): soundwire: intel: implement get_sdw_stream() operations soundwire: stream: add helper to startup/shutdown streams soundwire: intel: remove stream allocation/free soundwire: cadence: allocate/free dma_data in set_sdw_stream soundwire: intel: don't free dma_data in DAI shutdown Documentation/driver-api/soundwire/stream.rst | 11 ++- drivers/soundwire/cadence_master.c | 52 +++++++--- drivers/soundwire/intel.c | 82 ++++------------ drivers/soundwire/stream.c | 98 +++++++++++++++++++ include/linux/soundwire/sdw.h | 2 + 5 files changed, 167 insertions(+), 78 deletions(-) -- 2.17.1

2 6

[PATCH 1/1] MAINTAINERS: change SoundWire maintainer
by Sanyog Kale 15 Jul '20

15 Jul '20

Add Bard as SoundWire maintainer from Intel and change Sanyog's role as reviewer. Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Signed-off-by: Sanyog Kale <sanyog.r.kale(a)intel.com> --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1c1527a34d99..9559e947bf67 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16012,8 +16012,9 @@ F: sound/soc/sof/ SOUNDWIRE SUBSYSTEM M: Vinod Koul <vkoul(a)kernel.org> -M: Sanyog Kale <sanyog.r.kale(a)intel.com> +M: Bard Liao <yung-chuan.liao(a)linux.intel.com> R: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> +R: Sanyog Kale <sanyog.r.kale(a)intel.com> L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) S: Supported F: Documentation/driver-api/soundwire/ -- 2.17.1

3 4

[RFT] ALSA control service programs for Digidesign Digi 002/003 family and Tascam FireWire series
by Takashi Sakamoto 15 Jul '20

15 Jul '20

Hi, This is request-for-test (RFT) to the ALSA control service programs for Digidesign Digi 002/003 family and Tascam FireWire series. The programs are available in 'topic/services-for-dg00x-tascam' of below repository, and the RFT is corresponding to Pull Request #1: * https://github.com/alsa-project/snd-firewire-ctl-services/ Background ---------- The models in above family and series are already supported by drivers in ALSA firewire stack for their isochronous packet stream functionality. Although the drivers allow userspace applications to process PCM frames and MIDI messages in the packet streaming, they doesn't support the other functionalities such as volume control since it can be achieved by any usespace applications of Linux firewire subsystem. The service programs added by this patchset are for the supplemental functionality to control the models by asynchronous packet transaction or to process a part of data transferred by the isochronous packet stream. In detail, please read README.rst in the repository[1]. You can see some illustrations. How to build ------------- The project depends on several libraries in below repositories: * glib[2] * alsa-gobject v0.1.0[3] * libhinawa v2.0.0[4] Before building it, please install them with gobject-introspection support. The project is written by Rust programming language[5] and packaged by cargo[6]. To build, just run below commands in the environment to connect to internet: ``` $ git clone https://github.com/alsa-project/snd-firewire-ctl-services.git -b topic/services-for-dg00x-tascam $ cd snd-firewire-ctl-services $ cargo build ``` All of required crates are downloaded automatically, then start build. Executables ----------- The added executables are listed below: * snd-firewire-digi00x-ctl-service * snd-firewire-tascam-ctl-service When running, the programs add and maintain control elements, then enter event loop to dispatch events. Thes elements are visible and manipulable for any userspace applications. The program dispatch any manipulation event for transactions to control actual device. For console model and FE-8 in Tascam FireWire series, the program adds and maintains port in ALSA Sequencer. They have command line options. For all models of Digi 002/003 family, the executable has an option for the numerical ID of sound card. ``` Usage: snd-firewire-digi00x-ctl-service CARD_ID where: CARD_ID: The numerical ID of sound card. ``` For models of Tascam FireWire series except for FE-8, the executable should run with 'snd' as its first option and the numerical ID of sound card as second option. Tascam FE-8 is supported by the service program but not supported by ALSA firewire stack since it doesn't handle isochronous packet streaming. For FE-8, the executable should run with 'fw' as its first option and the numerical ID of firewire character device. ``` Usage: snd-firewire-tascam-ctl-service SUBSYSTEM ID where: SUBSYSTEM: The name of subsystem; 'snd' or 'fw' ID: The numerical ID of sound card or fw character device ``` It's easy to run the executables by cargo, like: ``` $ cargo run --bin snd-firewire-digi00x-ctl-service 2 ``` Receiving SIGTERM signal terminates the event loop, then the program finishes. Access permissions for relevant character devices -------------------------------------------------- The executables manipulate below character devices to dispatch, convert, and emit event from end to end. The '%u' is the numerical number in each subsystem: * ALSA control character device (/dev/snd/controlC%u) * ALSA hwdep character device (/dev/snd/hwC%uD%u) * Linux firewire character device (/dev/fw%u) Additionally, the service program for Tascam FireWire series manipulates ALSA sequencer character device (/dev/snd/seq) to handle events of control surface for console model. Users should pay enough attention to access permission for the above character devices when running the service program. Feedback -------- Any feedback is welcome. For questions, please use mailing list in alsa-devel or alsa-users[7]. For issues, please use service of github.com[8]. Issues ------ The name of control elements are not fixed yet since the convention of name for element set is not clear yet for recording equipment. Users may feel inconvenience to which channel corresponds to which physical port. Furthermore, in the case that element set includes several elements, it's unclear that which element corresponds to which physical port as well. ALSA control core has no feature for the above issues at present. [1] https://github.com/alsa-project/snd-firewire-ctl-services [2] https://gitlab.gnome.org/GNOME/glib [3] https://github.com/alsa-project/alsa-gobject/ [4] https://github.com/alsa-project/libhinawa [5] https://www.rust-lang.org/ [6] https://doc.rust-lang.org/cargo/ [7] https://www.alsa-project.org/wiki/Mailing-lists [8] https://github.com/alsa-project/snd-firewire-ctl-services/issues Regards Takashi Sakamoto

2 4

[PATCH v2] dt-bindings: ASoC: Convert UniPhier EVEA codec to json-schema
by Masahiro Yamada 14 Jul '20

14 Jul '20

Convert the UniPhier EVEA sound codec binding to DT schema format. Signed-off-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> --- Changes in v2: - Add schema for subnode 'port' .../sound/socionext,uniphier-evea.yaml | 70 +++++++++++++++++++ .../bindings/sound/uniphier,evea.txt | 26 ------- 2 files changed, 70 insertions(+), 26 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml delete mode 100644 Documentation/devicetree/bindings/sound/uniphier,evea.txt diff --git a/Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml b/Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml new file mode 100644 index 000000000000..228168f685cf --- /dev/null +++ b/Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/socionext,uniphier-evea.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: UniPhier EVEA SoC-internal sound codec + +maintainers: + - <alsa-devel(a)alsa-project.org> + +properties: + compatible: + const: socionext,uniphier-evea + + reg: + maxItems: 1 + + clock-names: + items: + - const: evea + - const: exiv + + clocks: + minItems: 2 + maxItems: 2 + + reset-names: + items: + - const: evea + - const: exiv + - const: adamv + + resets: + minItems: 3 + maxItems: 3 + + "#sound-dai-cells": + const: 1 + +patternProperties: + "^port@[0-9]$": + type: object + properties: + endpoint: true + required: + - endpoint + +additionalProperties: false + +required: + - compatible + - reg + - clock-names + - clocks + - reset-names + - resets + - "#sound-dai-cells" + +examples: + - | + codec@57900000 { + compatible = "socionext,uniphier-evea"; + reg = <0x57900000 0x1000>; + clock-names = "evea", "exiv"; + clocks = <&sys_clk 41>, <&sys_clk 42>; + reset-names = "evea", "exiv", "adamv"; + resets = <&sys_rst 41>, <&sys_rst 42>, <&adamv_rst 0>; + #sound-dai-cells = <1>; + }; diff --git a/Documentation/devicetree/bindings/sound/uniphier,evea.txt b/Documentation/devicetree/bindings/sound/uniphier,evea.txt deleted file mode 100644 index 3f31b235f18b..000000000000 --- a/Documentation/devicetree/bindings/sound/uniphier,evea.txt +++ /dev/null @@ -1,26 +0,0 @@ -Socionext EVEA - UniPhier SoC internal codec driver - -Required properties: -- compatible : should be "socionext,uniphier-evea". -- reg : offset and length of the register set for the device. -- clock-names : should include following entries: - "evea", "exiv" -- clocks : a list of phandle, should contain an entry for each - entries in clock-names. -- reset-names : should include following entries: - "evea", "exiv", "adamv" -- resets : a list of phandle, should contain reset entries of - reset-names. -- #sound-dai-cells: should be 1. - -Example: - - codec { - compatible = "socionext,uniphier-evea"; - reg = <0x57900000 0x1000>; - clock-names = "evea", "exiv"; - clocks = <&sys_clk 41>, <&sys_clk 42>; - reset-names = "evea", "exiv", "adamv"; - resets = <&sys_rst 41>, <&sys_rst 42>, <&adamv_rst 0>; - #sound-dai-cells = <1>; - }; -- 2.25.1

4 7

[PATCH v2 0/5] ASoC: sh: remove discriminatory terms
by Kuninori Morimoto 14 Jul '20

14 Jul '20

Renesas SH drivers are using discriminatory terms. This patch-set removes or changes it as much as possible. But, because DMA related API function name, it still exists. I hope all these are removed someday. v1 -> v2 - use "secondary" instead of "follower" - care siu/ssi drivers - tidyup git-log Link: https://lore.kernel.org/r/87r1tg3swv.wl-kuninori.morimoto.gx@renesas.com Kuninori Morimoto (5): ASoC: rsnd: don't use discriminatory terms for function names ASoC: rsnd: don't use discriminatory terms for comment ASoC: fsi: don't use discriminatory terms for comment ASoC: siu: don't use discriminatory terms for parameter ASoC: ssi: don't use discriminatory terms for debug log sound/soc/sh/fsi.c | 4 ++-- sound/soc/sh/rcar/core.c | 4 ++-- sound/soc/sh/rcar/rsnd.h | 2 +- sound/soc/sh/rcar/ssi.c | 28 ++++++++++++++-------------- sound/soc/sh/rcar/ssiu.c | 6 +++--- sound/soc/sh/siu_pcm.c | 6 +++--- sound/soc/sh/ssi.c | 2 +- 7 files changed, 26 insertions(+), 26 deletions(-) -- 2.25.1

2 6