July 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: hda/realtek: Serialize setting GPIO LED
by Kai-Heng Feng 01 Jul '20

01 Jul '20

If a system has two GPIO controlled LED, one for mute and another one for micmute, and both of them are on before system suspend, sometimes one of them won't be turned off by system suspend. The codec doesn't seem to be able to control multiple GPIO LEDs at the same time, so introduce a new mutex to serialize setting the LED, to prevent the issue from happening. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- include/sound/hda_codec.h | 1 + sound/pci/hda/hda_codec.c | 1 + sound/pci/hda/patch_realtek.c | 3 +++ 3 files changed, 5 insertions(+) diff --git a/include/sound/hda_codec.h b/include/sound/hda_codec.h index d16a4229209b..3a1792bbb7ac 100644 --- a/include/sound/hda_codec.h +++ b/include/sound/hda_codec.h @@ -206,6 +206,7 @@ struct hda_codec { struct mutex spdif_mutex; struct mutex control_mutex; + struct mutex led_mutex; struct snd_array spdif_out; unsigned int spdif_in_enable; /* SPDIF input enable? */ const hda_nid_t *slave_dig_outs; /* optional digital out slave widgets */ diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 7e3ae4534df9..ec477cd8afed 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -946,6 +946,7 @@ int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card, codec->addr = codec_addr; mutex_init(&codec->spdif_mutex); mutex_init(&codec->control_mutex); + mutex_init(&codec->led_mutex); snd_array_init(&codec->mixers, sizeof(struct hda_nid_item), 32); snd_array_init(&codec->nids, sizeof(struct hda_nid_item), 32); snd_array_init(&codec->init_pins, sizeof(struct hda_pincfg), 16); diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 53e0eef8b042..96dac365fbb8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4101,7 +4101,10 @@ static void alc_update_gpio_led(struct hda_codec *codec, unsigned int mask, { if (polarity) enabled = !enabled; + + mutex_lock(&codec->led_mutex); alc_update_gpio_data(codec, mask, !enabled); /* muted -> LED on */ + mutex_unlock(&codec->led_mutex); } /* turn on/off mute LED via GPIO per vmaster hook */ -- 2.17.1

2 2

[PATCH] ASoC: rt1015: DAC volume range modification.
by jack.yu＠realtek.com 01 Jul '20

01 Jul '20

From: Jack Yu <jack.yu(a)realtek.com> RT1015 dac volume range modification. Signed-off-by: Jack Yu <jack.yu(a)realtek.com> --- sound/soc/codecs/rt1015.c | 4 ++-- sound/soc/codecs/rt1015.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt1015.c b/sound/soc/codecs/rt1015.c index 548f68649064..90bd7e22ec3b 100644 --- a/sound/soc/codecs/rt1015.c +++ b/sound/soc/codecs/rt1015.c @@ -401,7 +401,7 @@ static bool rt1015_readable_register(struct device *dev, unsigned int reg) } } -static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -9525, 75, 0); +static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -95625, 375, 0); static const char * const rt1015_din_source_select[] = { "Left", @@ -517,7 +517,7 @@ static int rt1015_bypass_boost_put(struct snd_kcontrol *kcontrol, static const struct snd_kcontrol_new rt1015_snd_controls[] = { SOC_SINGLE_TLV("DAC Playback Volume", RT1015_DAC1, RT1015_DAC_VOL_SFT, - 127, 0, dac_vol_tlv), + 255, 0, dac_vol_tlv), SOC_DOUBLE("DAC Playback Switch", RT1015_DAC3, RT1015_DA_MUTE_SFT, RT1015_DVOL_MUTE_FLAG_SFT, 1, 1), SOC_ENUM_EXT("Boost Mode", rt1015_boost_mode_enum, diff --git a/sound/soc/codecs/rt1015.h b/sound/soc/codecs/rt1015.h index 7bd159e8f958..cc1ae33ca753 100644 --- a/sound/soc/codecs/rt1015.h +++ b/sound/soc/codecs/rt1015.h @@ -214,8 +214,8 @@ #define RT1015_ID_VERB 0x1 /* 0x0102 */ -#define RT1015_DAC_VOL_MASK (0x7f << 9) -#define RT1015_DAC_VOL_SFT 9 +#define RT1015_DAC_VOL_MASK (0xff << 8) +#define RT1015_DAC_VOL_SFT 8 /* 0x0104 */ #define RT1015_DAC_CLK (0x1 << 13) -- 2.27.0

1 0

Sof hda dsp fixup
by GitHub pull_request - opened 01 Jul '20

01 Jul '20

alsa-project/alsa-ucm-conf pull request #38 was opened from libinyang: This PR does such fixup: fixup typo "codec" => "codecs" sof-hda-dsp should include sof-hda-dsp/Hdmi.conf not HDA-Intel/Hdmi.conf Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/38 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/38.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 0/5] soundwire: handle stream at the dailink level
by Bard Liao 01 Jul '20

01 Jul '20

Currently, stream is handled at the dai level. But we have to handle stream at the dailink level in the multi-cpu dailink usage. Pierre-Louis Bossart (5): soundwire: intel: implement get_sdw_stream() operations soundwire: stream: add helper to startup/shutdown streams soundwire: intel: remove stream allocation/free soundwire: cadence: allocate/free dma_data in set_sdw_stream soundwire: intel: don't free dma_data in DAI shutdown drivers/soundwire/cadence_master.c | 52 ++++++++++++----- drivers/soundwire/intel.c | 82 +++++++-------------------- drivers/soundwire/stream.c | 90 ++++++++++++++++++++++++++++++ include/linux/soundwire/sdw.h | 2 + 4 files changed, 149 insertions(+), 77 deletions(-) -- 2.17.1

3 8