December 2020 - Alsa-devel - mailman.alsa-project.org

Re: wm8960: add DAC Slope switch
by Charles Keepax 07 Dec '20

07 Dec '20

On Tue, Nov 24, 2020 at 06:23:13PM +0100, Lukas F. Hartmann wrote: > The WM8960 DAC has a "DAC Slope" switch that can toggle between two > different output filter curves. This patch adds support for it. > > Signed-off-by: Lukas F. Hartmann <lukas(a)mntre.com> > --- > +static int wm8960_put_dacslope(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); > + struct wm8960_priv *wm8960 = snd_soc_component_get_drvdata(component); > + unsigned int val = ucontrol->value.integer.value[0]; > + > + if (val > 1) > + return -EINVAL; > + > + wm8960->dacslope = val; > + > + return snd_soc_component_update_bits(component, WM8960_DACCTL1, > + 0x2, val<<1); Is the DAC Slope switch not in DACCTL2? Thanks, Charles

1 0

snd-rn-pci-acp3x - auto dmic detection unreliable
by Jaroslav Kysela 07 Dec '20

07 Dec '20

Hi, it seems that the ACPI auto-detection of the presence the digital microphone connected to AMD Renoir audio bridge is unreliable. It may be that hardware vendors do not provide the correct ACPI tables. Could you clarify the usage of _WOV integer value? It seems that this value is set on those plaforms which do not have the digital microphone (the microphone is connected to the HDA codec): Lenovo IdeaPad 5 (15ARE05) Lenovo Thinkpad X395 In any case, we should probably improve the auto-detection using DMI or other platform info. Jaroslav BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1892115 -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

3 6

[PATCH] ALSA: hda/realtek - Enable headset mic of ASUS X430UN with ALC256
by Chris Chiu 07 Dec '20

07 Dec '20

The ASUS laptop X430UN with ALC256 can't detect the headset microphone until ALC256_FIXUP_ASUS_MIC_NO_PRESENCE quirk applied. Signed-off-by: Chris Chiu <chiu(a)endlessos.org> Signed-off-by: Jian-Hong Pan <jhp(a)endlessos.org> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f2398721ac1e..d5e4d0ba1008 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7827,6 +7827,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x10d0, "ASUS X540LA/X540LJ", ALC255_FIXUP_ASUS_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1043, 0x115d, "Asus 1015E", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x1043, 0x11c0, "ASUS X556UR", ALC255_FIXUP_ASUS_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1043, 0x1271, "ASUS X430UN", ALC256_FIXUP_ASUS_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1043, 0x1290, "ASUS X441SA", ALC233_FIXUP_EAPD_COEF_AND_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1043, 0x12a0, "ASUS X441UV", ALC233_FIXUP_EAPD_COEF_AND_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1043, 0x12f0, "ASUS X541UV", ALC256_FIXUP_ASUS_MIC), -- 2.20.1

2 1

rt715: init: setup ADC07 to a proper volume
by GitHub pull_request - opened 07 Dec '20

07 Dec '20

alsa-project/alsa-ucm-conf pull request #65 was opened from libinyang: This patch initiates 'rt715 ADC 07 Capture Volume' to a proper volume. Signed-off-by: Libin Yang <libin.yang(a)intel.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/65 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/65.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ALSA: rawmidi: Access runtime->avail always in spinlock
by Takashi Iwai 06 Dec '20

06 Dec '20

The runtime->avail field may be accessed concurrently while some places refer to it without taking the runtime->lock spinlock, as detected by KCSAN. Usually this isn't a big problem, but for consistency and safety, we should take the spinlock at each place referencing this field. Reported-by: syzbot+a23a6f1215c84756577c(a)syzkaller.appspotmail.com Reported-by: syzbot+3d367d1df1d2b67f5c19(a)syzkaller.appspotmail.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/rawmidi.c | 49 +++++++++++++++++++++++++++++++------------- 1 file changed, 35 insertions(+), 14 deletions(-) diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c index c78720a3299c..257ad5206240 100644 --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -95,11 +95,21 @@ static inline unsigned short snd_rawmidi_file_flags(struct file *file) } } -static inline int snd_rawmidi_ready(struct snd_rawmidi_substream *substream) +static inline bool __snd_rawmidi_ready(struct snd_rawmidi_runtime *runtime) +{ + return runtime->avail >= runtime->avail_min; +} + +static bool snd_rawmidi_ready(struct snd_rawmidi_substream *substream) { struct snd_rawmidi_runtime *runtime = substream->runtime; + unsigned long flags; + bool ready; - return runtime->avail >= runtime->avail_min; + spin_lock_irqsave(&runtime->lock, flags); + ready = __snd_rawmidi_ready(runtime); + spin_unlock_irqrestore(&runtime->lock, flags); + return ready; } static inline int snd_rawmidi_ready_append(struct snd_rawmidi_substream *substream, @@ -1019,7 +1029,7 @@ int snd_rawmidi_receive(struct snd_rawmidi_substream *substream, if (result > 0) { if (runtime->event) schedule_work(&runtime->event_work); - else if (snd_rawmidi_ready(substream)) + else if (__snd_rawmidi_ready(runtime)) wake_up(&runtime->sleep); } spin_unlock_irqrestore(&runtime->lock, flags); @@ -1098,7 +1108,7 @@ static ssize_t snd_rawmidi_read(struct file *file, char __user *buf, size_t coun result = 0; while (count > 0) { spin_lock_irq(&runtime->lock); - while (!snd_rawmidi_ready(substream)) { + while (!__snd_rawmidi_ready(runtime)) { wait_queue_entry_t wait; if ((file->f_flags & O_NONBLOCK) != 0 || result > 0) { @@ -1115,9 +1125,11 @@ static ssize_t snd_rawmidi_read(struct file *file, char __user *buf, size_t coun return -ENODEV; if (signal_pending(current)) return result > 0 ? result : -ERESTARTSYS; - if (!runtime->avail) - return result > 0 ? result : -EIO; spin_lock_irq(&runtime->lock); + if (!runtime->avail) { + spin_unlock_irq(&runtime->lock); + return result > 0 ? result : -EIO; + } } spin_unlock_irq(&runtime->lock); count1 = snd_rawmidi_kernel_read1(substream, @@ -1255,7 +1267,7 @@ int __snd_rawmidi_transmit_ack(struct snd_rawmidi_substream *substream, int coun runtime->avail += count; substream->bytes += count; if (count > 0) { - if (runtime->drain || snd_rawmidi_ready(substream)) + if (runtime->drain || __snd_rawmidi_ready(runtime)) wake_up(&runtime->sleep); } return count; @@ -1444,9 +1456,11 @@ static ssize_t snd_rawmidi_write(struct file *file, const char __user *buf, return -ENODEV; if (signal_pending(current)) return result > 0 ? result : -ERESTARTSYS; - if (!runtime->avail && !timeout) - return result > 0 ? result : -EIO; spin_lock_irq(&runtime->lock); + if (!runtime->avail && !timeout) { + spin_unlock_irq(&runtime->lock); + return result > 0 ? result : -EIO; + } } spin_unlock_irq(&runtime->lock); count1 = snd_rawmidi_kernel_write1(substream, buf, NULL, count); @@ -1526,6 +1540,7 @@ static void snd_rawmidi_proc_info_read(struct snd_info_entry *entry, struct snd_rawmidi *rmidi; struct snd_rawmidi_substream *substream; struct snd_rawmidi_runtime *runtime; + unsigned long buffer_size, avail, xruns; rmidi = entry->private_data; snd_iprintf(buffer, "%s\n\n", rmidi->name); @@ -1544,13 +1559,16 @@ static void snd_rawmidi_proc_info_read(struct snd_info_entry *entry, " Owner PID : %d\n", pid_vnr(substream->pid)); runtime = substream->runtime; + spin_lock_irq(&runtime->lock); + buffer_size = runtime->buffer_size; + avail = runtime->avail; + spin_unlock_irq(&runtime->lock); snd_iprintf(buffer, " Mode : %s\n" " Buffer size : %lu\n" " Avail : %lu\n", runtime->oss ? "OSS compatible" : "native", - (unsigned long) runtime->buffer_size, - (unsigned long) runtime->avail); + buffer_size, avail); } } } @@ -1568,13 +1586,16 @@ static void snd_rawmidi_proc_info_read(struct snd_info_entry *entry, " Owner PID : %d\n", pid_vnr(substream->pid)); runtime = substream->runtime; + spin_lock_irq(&runtime->lock); + buffer_size = runtime->buffer_size; + avail = runtime->avail; + xruns = runtime->xruns; + spin_unlock_irq(&runtime->lock); snd_iprintf(buffer, " Buffer size : %lu\n" " Avail : %lu\n" " Overruns : %lu\n", - (unsigned long) runtime->buffer_size, - (unsigned long) runtime->avail, - (unsigned long) runtime->xruns); + buffer_size, avail, xruns); } } } -- 2.26.2

1 0

[PATCH] ALSA: seq: Use bool for snd_seq_queue internal flags
by Takashi Iwai 06 Dec '20

06 Dec '20

The snd_seq_queue struct contains various flags in the bit fields. Those are categorized to two different use cases, both of which are protected by different spinlocks. That implies that there are still potential risks of the bad operations for bit fields by concurrent accesses. For addressing the problem, this patch rearranges those flags to be a standard bool instead of a bit field. Reported-by: syzbot+63cbe31877bb80ef58f5(a)syzkaller.appspotmail.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/seq/seq_queue.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/core/seq/seq_queue.h b/sound/core/seq/seq_queue.h index 1c3a8d3254d9..c69105dc1a10 100644 --- a/sound/core/seq/seq_queue.h +++ b/sound/core/seq/seq_queue.h @@ -26,10 +26,10 @@ struct snd_seq_queue { struct snd_seq_timer *timer; /* time keeper for this queue */ int owner; /* client that 'owns' the timer */ - unsigned int locked:1, /* timer is only accesibble by owner if set */ - klocked:1, /* kernel lock (after START) */ - check_again:1, - check_blocked:1; + bool locked; /* timer is only accesibble by owner if set */ + bool klocked; /* kernel lock (after START) */ + bool check_again; /* concurrent access happened during check */ + bool check_blocked; /* queue being checked */ unsigned int flags; /* status flags */ unsigned int info_flags; /* info for sync */ -- 2.26.2

1 0

[PATCH 0/1] dt-bindings: eliminate yamllint warnings
by Zhen Lei 06 Dec '20

06 Dec '20

There're too many people, I just send to the maintainer, reviewer, supporter. Eliminate below warnings: ./Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml:32:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/display/intel,keembay-msscam.yaml:21:6: [warning] wrong indentation: expected 6 but found 5 (indentation) ./Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml:52:9: [warning] wrong indentation: expected 6 but found 8 (indentation) ./Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml:42:8: [warning] wrong indentation: expected 8 but found 7 (indentation) ./Documentation/devicetree/bindings/display/bridge/intel,keembay-dsi.yaml:45:8: [warning] wrong indentation: expected 8 but found 7 (indentation) ./Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml:25:10: [warning] wrong indentation: expected 10 but found 9 (indentation) ./Documentation/devicetree/bindings/media/i2c/adv7604.yaml:24:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml:4:1: [error] missing document start "---" (document-start) ./Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml:29:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml:32:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml:79:17: [warning] wrong indentation: expected 14 but found 16 (indentation) ./Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml:88:17: [warning] wrong indentation: expected 14 but found 16 (indentation) ./Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml:72:17: [warning] wrong indentation: expected 18 but found 16 (indentation) ./Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml:75:17: [warning] wrong indentation: expected 18 but found 16 (indentation) ./Documentation/devicetree/bindings/mmc/mtk-sd.yaml:20:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/mmc/mtk-sd.yaml:30:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/mmc/mtk-sd.yaml:33:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml:10:4: [warning] wrong indentation: expected 2 but found 3 (indentation) Zhen Lei (1): dt-bindings: eliminate yamllint warnings .../devicetree/bindings/clock/imx8qxp-lpcg.yaml | 20 ++++++++--------- .../bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- .../bindings/display/bridge/intel,keembay-dsi.yaml | 4 ++-- .../bindings/display/intel,keembay-msscam.yaml | 4 ++-- .../bindings/display/panel/novatek,nt36672a.yaml | 2 +- .../devicetree/bindings/media/i2c/adv7604.yaml | 4 ++-- .../devicetree/bindings/media/i2c/mipi-ccs.yaml | 11 ++++----- .../devicetree/bindings/media/i2c/ovti,ov772x.yaml | 12 +++++----- .../devicetree/bindings/media/i2c/sony,imx214.yaml | 12 +++++----- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 26 +++++++++++----------- .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 4 ++-- 11 files changed, 52 insertions(+), 51 deletions(-) -- 1.8.3

4 5

thinkpad t14s amd: unable to control built-in mic and headphones mic independently
by GitHub issues - opened 05 Dec '20

05 Dec '20

alsa-project/alsa-ucm-conf issue #64 was opened from tanuk: I did some investigation on a [pulseaudio bug report](https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1067), and found that the UCM configuration for the internal mic and headset mic both use "Capture" as the CaptureMixerElem. This means that muting one device mutes also the other (and I guess volume control is shared too). In amixer output I don't see a separate control for the headset mic, but for the internal mic volume I guess "Digital" can be used (there's no switch, though). So it seems that these changes are needed: - don't set CaptureMixerElem, CaptureSwitch or CaptureVolume for the headset mic - set the internal mic CaptureMixerElem and CaptureVolume to Digital - you may want to also set CaptureMasterElem for both both mics to Capture Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/64 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Re: Behringer WING usb audio - cyclic xruns dependent on periods/buffers
by Takashi Iwai 05 Dec '20

05 Dec '20

On Thu, 03 Dec 2020 21:06:24 +0100, Ben Bell wrote: > > On Sat, Nov 28, 2020 at 09:36:00AM +0000, Ben Bell wrote: > > > In general you should avoid 44.1kHz if you want a small period size > > > for a realtime process on USB-audio. With 44.1kHz, the packet size > > > can't be fixed in integer, and the ISO transfer requires variable > > > packet sizes. OTOH, ALSA API requires the fixed period size, hence > > > it'll lead to inconsistencies occasionally. > > So changing to 48kHz had no appreciable effect, but I'm working at that > rate for now to eliminate the 44.1kHz weirdness from investigations. > Using a USB2 card, also had no effect. Testing with a different USB audio > interface (albeit a simple stereo one) didn't exhibit the behaviour, even > when I took buffer sizes right down. > > I'm not sure where to go to get more information or where's the best place > to ask for help. I'm happy to do the leg work, but I don't know enough > about the kernel, alsa or USB to figure it out without some help. > > Current question: what is the delay in /proc/asound/card1/pcm0c/sub0/status > actually measuring? I'm assuming it's measured in samples? I've written > something to scrape the stats out in a tight loop and report. > > What I see is a cycle where the delay rises and then a chunk equal to the > frames per period (or sometimes, earlier on fpp-48) is removed. That feels > like chunks being read out of a buffer. All fine. > > After a while though, the maximum delay we reach with each cycle is creeping > up. It increases by one every few cycles (usually two or three, or three or > four -- always oscillating between two values) but of it's still only being > emptied by a full period's worth of samples each cycle. So the overall effect > is the delay creeps up and up until it hits the buffer size and then we get > an xrun. > > Like I said in the initial email, it feels like some sort of clock drift > problem, where we're managing very slowly to collect more samples than > we're reading -- to the tune of about 1 extra every few cycles -- and > nothing on the consumer side is ever managing to compensate for that. > I'm not even sure how that sort of drift would be possible though. Seems > surprising. > > Does any of this sound suspicious, or for that matter completely normal? > Any suggestions where should I be looking next? At least you can try the latest patch set destined for 5.11, which should improve the cases for the implicit feedback. The patches are either in linux-next tree or the topic/usb-audio-refactoring branch of my sound.git tree. It's based on 5.10-rc, so should be cleanly mergeable to the latest Linus tree. Takashi

2 1

[PATCH] slimbus: qcom-ngd-ctrl: Fix error handling to keep reference balanced
by Zhang Qilong 05 Dec '20

05 Dec '20

In the error branch, we should call pm_runtime_put_noidle and pm_runtime_disable to decrease usage counter and increase the power disable depth to avoid reference leaks. Fixes: 917809e2280bb ("slimbus: ngd: Add qcom SLIMBus NGD driver") Signed-off-by: Zhang Qilong <zhangqilong3(a)huawei.com> --- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index c054e83ab636..a9b4a1d95045 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1483,7 +1483,7 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) ret = qcom_slim_ngd_qmi_svc_event_init(ctrl); if (ret) { dev_err(&pdev->dev, "QMI service registration failed:%d", ret); - return ret; + goto pm_err; } INIT_WORK(&ctrl->m_work, qcom_slim_ngd_master_worker); @@ -1500,6 +1500,9 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) qcom_slim_ngd_qmi_svc_event_deinit(&ctrl->qmi); if (ctrl->mwq) destroy_workqueue(ctrl->mwq); +pm_err: + pm_runtime_put_noidle(dev); + pm_runtime_disable(dev); return ret; } -- 2.25.4

1 0