January 2020 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] soundwire: intel: fix factor of two in MCLK handling
by Pierre-Louis Bossart 14 Jan '20

14 Jan '20

From: Bard Liao <yung-chuan.liao(a)linux.intel.com> Somehow Intel folks were confused, the property is 2x what the mclk frequency actually is (checked the actual bus frequency with a scope) Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- drivers/soundwire/intel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 0371d3d5501a..06ef3a3ac080 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -880,6 +880,9 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus) "intel-sdw-ip-clock", &prop->mclk_freq); + /* the values reported by BIOS are the 2x clock, not the bus clock */ + prop->mclk_freq /= 2; + fwnode_property_read_u32(link, "intel-quirk-mask", &quirk_mask); -- 2.20.1

2 1

[alsa-devel] [PATCH 0/2] soundwire: cadence: remove warnings
by Pierre-Louis Bossart 14 Jan '20

14 Jan '20

Fix warnings reported by cppcheck and make W=1 Pierre-Louis Bossart (2): soundwire: cadence: update kernel-doc parameter descriptions soundwire: cadence: remove useless variable incrementation drivers/soundwire/cadence_master.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.20.1

2 3

[alsa-devel] [PATCH v6 0/2] soundwire: Add support to Qualcomm SoundWire master
by Srinivas Kandagatla 14 Jan '20

14 Jan '20

Thanks for reviewing the v5 patchset. Here is new patchset addressing all the comments from v5 This patchset adds support for Qualcomm SoundWire Master Controller found in most of Qualcomm SoCs and WCD audio codecs. This driver along with WCD934x codec and WSA881x Class-D Smart Speaker Amplifier drivers is tested on on DragonBoard DB845c based of SDM845 SoC and Lenovo YOGA C630 Laptop based on SDM850. SoundWire controller on SDM845 is integrated in WCD934x audio codec via SlimBus interface. Currently this driver is very minimal and only supports PDM. Most of the code in this driver is rework of Qualcomm downstream drivers used in Andriod. Credits to Banajit Goswami and Patrick Lai's Team. TODO: Test and add PCM support. Thanks, srini Changes since v5: -No code changes. -Add extra comment in interrupt handler as suggested by Pierre Srinivas Kandagatla (2): dt-bindings: soundwire: add bindings for Qcom controller soundwire: qcom: add support for SoundWire controller .../bindings/soundwire/qcom,sdw.txt | 167 ++++ drivers/soundwire/Kconfig | 9 + drivers/soundwire/Makefile | 4 + drivers/soundwire/qcom.c | 861 ++++++++++++++++++ 4 files changed, 1041 insertions(+) create mode 100644 Documentation/devicetree/bindings/soundwire/qcom,sdw.txt create mode 100644 drivers/soundwire/qcom.c -- 2.21.0

2 3

[alsa-devel] [PATCH 0/6] soundwire: cadence: better logs and error handling
by Pierre-Louis Bossart 14 Jan '20

14 Jan '20

This is a stand-alone set of patches to improve error handling and provide better information to the platform integrator. As suggested by Vinod, these patches are shared first - with the risk that they are separated from the actual steps where they are needed. For reference, the complete set of 100+ patches required for SoundWire on Intel platforms is available here: https://github.com/thesofproject/linux/pull/1692 Pierre-Louis Bossart (4): soundwire: cadence_master: filter out bad interrupts soundwire: cadence_master: log more useful information during timeouts soundwire: cadence_master: handle multiple status reports per Slave soundwire: bus: check first if Slaves become UNATTACHED Rander Wang (2): soundwire: cadence_master: clear interrupt status before enabling interrupt soundwire: cadence_master: remove config update for interrupt setting drivers/soundwire/bus.c | 18 +++++++++ drivers/soundwire/cadence_master.c | 60 +++++++++++++++++++++++++----- 2 files changed, 68 insertions(+), 10 deletions(-) base-commit: b637124800a157c4df3699d1137d8533394f7678 -- 2.20.1

2 7

[alsa-devel] MIDI 2.0 universal packet protocol
by GitHub issues - edited 14 Jan '20

14 Jan '20

alsa-project/alsa-lib issue #24 was edited from symdeb: Since MIDI 2.0 only support USB and not over DIN (for now), will MIDI 2.0 need a new or updated OS class driver for the 32/64 bit universal packet interface and device descriptor for devices ? Page 16 of the USB MIDI class driver spec defines support for 1,2 or 3 bytes transfers only, How will this have to be implemented by MIDI USB device manufacturers and well as on the Linux OSes side ? How will this impact Linux ALSA ? Would the first byte of the message with b7=0 not confuse the driver of running status ? Link universal packet format https://www.midi.org/articles-old/details-about-midi-2-0-midi-ci-profiles-a…) Link first MIDI 2.0 Ready product: Roland A-88MKII https://www.midi.org/articles-old/roland-announces Issue URL : https://github.com/alsa-project/alsa-lib/issues/24 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[alsa-devel] MIDI 2.0 universal packet protocol
by GitHub issues - edited 14 Jan '20

14 Jan '20

alsa-project/alsa-lib issue #24 was edited from symdeb: Since MIDI 2.0 only support USB and not over DIN (for now), will MIDI 2.0 need a new or updated OS class driver for the 32/64 bit universal packet interface and device descriptor for devices ? Page 16 of the USB MIDI class driver spec defines support for 1,2 or 3 bytes transfers only, How will this have to be implemented by MIDI USB device manufacturers and well as on the Linux OSes side ? How will this impact Linux ALSA ? Would the first byte of the message with b7=0 not confuse the driver of running status ? Reference for packet format : [https://www.midi.org/articles-old/details-about-midi-2-0-midi-ci-profiles-a… Issue URL : https://github.com/alsa-project/alsa-lib/issues/24 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[alsa-devel] MIDI 2.0 universal packet protocol
by GitHub issues - opened 14 Jan '20

14 Jan '20

alsa-project/alsa-lib issue #24 was opened from symdeb: Since MIDI 2.0 only support USB and non MIDI DIN (for now), will MIDI 2.0 need a new or updated OS class driver for the 32/64 bit universal packet interface and device descriptor for devices ? Page 16 of the USB MIDI class driver spec defines support for 1,2 or 3 bytes transfers only, How will this have to be implemented by MIDI USB device manufacturers and well as on the Linux OSes side ? How will this impact Linux ALSA ? Would the first byte of the message with b7=0 not confuse the driver of running status ? Reference for packet format : [https://www.midi.org/articles-old/details-about-midi-2-0-midi-ci-profiles-a… Issue URL : https://github.com/alsa-project/alsa-lib/issues/24 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Re: [alsa-devel] Github MOTU PCI 324; Motu 2408; Motu 1224
by Takashi Sakamoto 14 Jan '20

14 Jan '20

Hi Yan, (CCed to alsa-devel) On Tue, Jan 14, 2020, at 02:07, Yannic Korten wrote: > Hey Mr. Takashi, > I'm new to Linux and new to Github. If you think this is spam or you > wanted to be in private: See this mail as spam - ignore and just delete > it. I'm sorry then. > But I have a problem and don't know whom to contact. It seems like you > have much experience with coding and the usage of ALSA (which seems to > be your project). > So, my setup is the following: > Ubuntu Studio 19.10 > MOTU 324 PCI Card (detected as 'Multimedia audio controller: Mark of > the Unicorn Inc PCI-324 Audiowire Interface (rev 0a)') > MOTU 1224 > MOTU 2408 > So I tried to install your files from github but it seems not to be > working. Either it's because it's just the support for some newer MOTU > devices or I'm to dumb. > Is it possible to get the above devices fully running on linux with > your "drivers"? Or are they not supporting? > Will it be possible to insert them to the code (easily)? Or is it way > to much expenditure for that old devices? > > Thanks for help > Greetings from Germany > Yan I'm an author/maintainer of ALSA firewire stack which includes snd-firewire-motu driver. The driver can handle MOTU's FireWire series for IEEE 1394 bus; e.g. MOTU 828mkII. Unfortunately, the driver is unavailable for your model. Your model is not compliant to IEEE 1394. It's for 'AudioWire', which is proprietary protocol developed by MOTU. Like 1394 OHCI card is for IEEE 1394 bus, PCI-324/424 ASIC card is for 'AudioWire'. The ASIC is designed by MOTU itself (Precisely S&S Research, Inc.) and the detail is closed. Although PCI-324/424 card has physical ports into which IEEE 1394 cables can connect, and actually AudioWire uses the same cable of IEEE 1394a, signals in the cable is completely different from IEEE 1394. In the summer of 2015, I bought AudioWire-based model (it's really cheep in used market) and attempted to connect it to my IEEE 1394 bus analyzer. As I expected, nothing can be detected. I guess that PCI-324/424 ASIC integrates a sort of computing core (e.g. ARM7TDMI) with PCI interface for AudioWire protocol. For this kind of device, people need to work for reverse-engineering by analyze MOTU driver's behaviour in memory space mapped to host system, and write new driver to emulate the behaviour. However, this is a kind of 'adventure' and no guarantee to achieve. On the other hand, it certainly consumes the batch of developer's resources, unless getting enough assists by vendors. This is a reason that you cannot see AudioWire compliant drivers as Open Source Software. Regards Takashi Sakamoto

1 0

Re: [alsa-devel] [PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m
by Codrin.Ciubotariu＠microchip.com 13 Jan '20

13 Jan '20

On 13.01.2020 15:32, Chen Zhou wrote: > If CONFIG_SND_ATMEL_SOC_DMA=m, build error: > > sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': > (.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register' > > Function atmel_pcm_dma_platform_register is defined under > CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in > CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC. Arnd sent a more complete patch for this issue: https://lkml.org/lkml/2019/10/1/620 It wasn't merged due to some integration issues. Could you please try it and let us know if it fixes your issue? Thanks and best regards, Codrin > > Reported-by: Hulk Robot <hulkci(a)huawei.com> > Signed-off-by: Chen Zhou <chenzhou10(a)huawei.com> > --- > sound/soc/atmel/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > index f118c22..d1dc8e6 100644 > --- a/sound/soc/atmel/Kconfig > +++ b/sound/soc/atmel/Kconfig > @@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA > > config SND_ATMEL_SOC_SSC > tristate > + select SND_ATMEL_SOC_DMA > + select SND_ATMEL_SOC_PDC > > config SND_ATMEL_SOC_SSC_PDC > tristate "SoC PCM DAI support for AT91 SSC controller using PDC" > -- > 2.7.4 >

1 0

[alsa-devel] Applied "ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m" to the asoc tree
by Mark Brown 13 Jan '20

13 Jan '20

The patch ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 8fea78029f5e6ed734ae1957bef23cfda1af4354 Mon Sep 17 00:00:00 2001 From: Chen Zhou <chenzhou10(a)huawei.com> Date: Mon, 13 Jan 2020 21:32:42 +0800 Subject: [PATCH] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m If CONFIG_SND_ATMEL_SOC_DMA=m, build error: sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': (.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register' Function atmel_pcm_dma_platform_register is defined under CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Chen Zhou <chenzhou10(a)huawei.com> Link: https://lore.kernel.org/r/20200113133242.144550-1-chenzhou10@huawei.com Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/atmel/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index f118c229ed82..d1dc8e6366dc 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA config SND_ATMEL_SOC_SSC tristate + select SND_ATMEL_SOC_DMA + select SND_ATMEL_SOC_PDC config SND_ATMEL_SOC_SSC_PDC tristate "SoC PCM DAI support for AT91 SSC controller using PDC" -- 2.20.1

1 0