January 2020 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: control: potential uninitialized return value
by Dan Carpenter 08 Jan '20

08 Jan '20

Smatch complains that "ret" might be uninitialized. Fixes: fbd3eb7f66c5 ("ALSA: control: Add verification for kctl accesses") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/core/control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/control.c b/sound/core/control.c index d06033d418a8..aa0c0cf182af 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -896,7 +896,7 @@ static int sanity_check_elem_value(struct snd_card *card, u32 pattern) { size_t offset; - int i, ret; + int i, ret = 0; u32 *p; switch (info->type) { -- 2.11.0

2 1

[alsa-devel] [PATCH -next] ASoC: amd: acp3x: Fix return value check in acp3x_dai_probe()
by Wei Yongjun 08 Jan '20

08 Jan '20

In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: c9fe7db6e884 ("ASoC: amd: Refactoring of DAI from DMA driver") Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- sound/soc/amd/raven/acp3x-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c index d9b287b8396c..bf51cadf8682 100644 --- a/sound/soc/amd/raven/acp3x-i2s.c +++ b/sound/soc/amd/raven/acp3x-i2s.c @@ -321,8 +321,8 @@ static int acp3x_dai_probe(struct platform_device *pdev) } adata->acp3x_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); - if (IS_ERR(adata->acp3x_base)) - return PTR_ERR(adata->acp3x_base); + if (!adata->acp3x_base) + return -ENOMEM; adata->i2s_irq = res->start; dev_set_drvdata(&pdev->dev, adata);

1 0

[alsa-devel] [PATCH 00/10] mfd: Add support for Analog Devices A2B transceiver
by Daniel Mack 08 Jan '20

08 Jan '20

This patch series adds support for Analog Device's AD242x A2B transceivers. https://www.analog.com/media/en/technical-documentation/user-guides/AD242x_… These transceivers are used to form an audio network by connecting the parts in a daisy-chain. On top of audio, the devices expose some other functions such as GPIO, programmable clock outputs and remote-side I2C bus master. The first node in the chain is called the master node, and all other devices are called slave nodes. Up to 15 such devices can be connected this way. The master device responds on two addresses on the I2C bus. The primary one is used to access all registers in the master node itself, the secondary is for accessing remote nodes after prior setup through the master node. In the driver stack, these details are hidden behind specific regmap configs. The driver stack is implemented as MFD core and companion drivers that can be registered as sub-devices in DT. Drivers for these sub-devices can be used for both master and slave nodes, as they just interface with the node's regmap. The master node is responsible for discovering all the slave nodes at probe time, and it needs to take the used audio and routing modes in each of the slave devices into account in order to pre-calculate the bus-timings correctly. Hence, this bus is not hot-pluggable. Transceivers can both receive and provide audio, and streams can be routed from one node to any other, including many others. The tricky bit is how to expose the audio routing in DT in a sane way. The way it is implemented here, the slave nodes specify the number of slots they each consume and generate, and which thereof they forward from one side to the other. This mimics the internal register structure and should allow for even exotic setups. Please let me know what you think and what could be improved. Thanks, Daniel Daniel Mack (10): dt-bindings: mfd: Add documentation for ad242x dt-bindings: i2c: Add documentation for ad242x i2c controllers dt-bindings: gpio: Add documentation for AD242x GPIO controllers dt-bindings: clock: Add documentation for AD242x clock providers dt-bindings: sound: Add documentation for AD242x codecs mfd: Add core driver for AD242x A2B transceivers i2c: Add driver for AD242x bus controller gpio: Add driver for AD242x GPIO controllers clk: Add support for AD242x clock output providers ASoC: Add codec component for AD242x nodes .../bindings/clock/adi,ad242x-clk.yaml | 32 + .../bindings/gpio/adi,ad242x-gpio.yaml | 65 ++ .../bindings/i2c/adi,ad242x-i2c.yaml | 31 + .../bindings/mfd/adi,ad242x-bus.yaml | 29 + .../bindings/mfd/adi,ad242x-master.yaml | 235 +++++++ .../bindings/mfd/adi,ad242x-slave.yaml | 108 ++++ .../bindings/sound/adi,ad242x-codec.yaml | 31 + drivers/clk/Kconfig | 6 + drivers/clk/Makefile | 1 + drivers/clk/clk-ad242x.c | 231 +++++++ drivers/gpio/Kconfig | 6 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-ad242x.c | 229 +++++++ drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-ad242x.c | 178 +++++ drivers/mfd/Kconfig | 11 + drivers/mfd/Makefile | 1 + drivers/mfd/ad242x-bus.c | 42 ++ drivers/mfd/ad242x-master.c | 611 ++++++++++++++++++ drivers/mfd/ad242x-node.c | 262 ++++++++ drivers/mfd/ad242x-slave.c | 234 +++++++ include/dt-bindings/clock/adi,ad242x.h | 9 + include/linux/mfd/ad242x.h | 400 ++++++++++++ sound/soc/codecs/Kconfig | 5 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ad242x.c | 338 ++++++++++ 27 files changed, 3109 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/adi,ad242x-clk.yaml create mode 100644 Documentation/devicetree/bindings/gpio/adi,ad242x-gpio.yaml create mode 100644 Documentation/devicetree/bindings/i2c/adi,ad242x-i2c.yaml create mode 100644 Documentation/devicetree/bindings/mfd/adi,ad242x-bus.yaml create mode 100644 Documentation/devicetree/bindings/mfd/adi,ad242x-master.yaml create mode 100644 Documentation/devicetree/bindings/mfd/adi,ad242x-slave.yaml create mode 100644 Documentation/devicetree/bindings/sound/adi,ad242x-codec.yaml create mode 100644 drivers/clk/clk-ad242x.c create mode 100644 drivers/gpio/gpio-ad242x.c create mode 100644 drivers/i2c/busses/i2c-ad242x.c create mode 100644 drivers/mfd/ad242x-bus.c create mode 100644 drivers/mfd/ad242x-master.c create mode 100644 drivers/mfd/ad242x-node.c create mode 100644 drivers/mfd/ad242x-slave.c create mode 100644 include/dt-bindings/clock/adi,ad242x.h create mode 100644 include/linux/mfd/ad242x.h create mode 100644 sound/soc/codecs/ad242x.c -- 2.23.0

8 35

[alsa-devel] [PATCH 0/7] ALSA: hda: Enable HDAudio compress
by Cezary Rojewski 07 Jan '20

07 Jan '20

This set of patches provides new interfaces - page allocation - and runtime flow adjustments - PM support - for compress operations. For HDA part, work has been done to account for compress streams when servicing IRQs, setting up BDLs and assigning DMAs. End goal is to make room for one of DSP debug features: data probing. It takes advantage of compress streams when extracting data from running audio pipeline. Initial review and development of probes can be found under: https://github.com/thesofproject/linux/pull/1276 with this very set of patches being separated and reviewed on: https://github.com/thesofproject/linux/pull/1571 Cezary Rojewski (7): ALSA: hda: Allow for compress stream to hdac_ext_stream assignment ALSA: hda: Prepare for compress stream support ALSA: hda: Interrupt servicing and BDL setup for compress streams ALSA: core: Expand DMA buffer information ALSA: core: Implement compress page allocation and free routines ASoC: compress: Add pm_runtime support ASoC: SOF: Intel: Account for compress streams when servicing IRQs include/sound/compress_driver.h | 40 ++++++++++++++++++------ include/sound/hdaudio.h | 2 ++ include/sound/hdaudio_ext.h | 2 ++ sound/core/compress_offload.c | 42 ++++++++++++++++++++++++++ sound/hda/ext/hdac_ext_stream.c | 46 +++++++++++++++++++++++++--- sound/hda/hdac_controller.c | 4 +-- sound/hda/hdac_stream.c | 52 ++++++++++++++++++++------------ sound/soc/soc-compress.c | 29 +++++++++++++++++- sound/soc/sof/intel/hda-stream.c | 26 ++++++++++++++-- 9 files changed, 205 insertions(+), 38 deletions(-) -- 2.17.1

4 18

[alsa-devel] [PATCH] mixer: Fix memory leak for more than 16 file descriptor case
by David Fries 07 Jan '20

07 Jan '20

--- I saw this when digging through the source code, wrote up a test case, and verified with valgrind. I don't have that many sound cards so I modified mixer.c to always take the conditional. alloca seemed like the least effort way to fix this. Other thoughts were to test pfds != spfds and free, but given how little bytes would be allocated putting on the stack seems reasonable. I also created the github pull request 20. https://github.com/alsa-project/alsa-lib/pull/20 src/mixer/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mixer/mixer.c b/src/mixer/mixer.c index 82056474..b1af9945 100644 --- a/src/mixer/mixer.c +++ b/src/mixer/mixer.c @@ -767,7 +767,7 @@ int snd_mixer_wait(snd_mixer_t *mixer, int timeout) if (count < 0) return count; if ((unsigned int) count > sizeof(spfds) / sizeof(spfds[0])) { - pfds = malloc(count * sizeof(*pfds)); + pfds = alloca(count * sizeof(*pfds)); if (!pfds) return -ENOMEM; err = snd_mixer_poll_descriptors(mixer, pfds, -- 2.11.0

2 2

[alsa-devel] [PATCH alsa-utils 00/11] alsa-info.sh: Improve output and fix file upload issues
by David Ward 07 Jan '20

07 Jan '20

David Ward (11): alsa-info.sh: Consolidate PCI device output alsa-info.sh: Read from /proc/modules and sort the result alsa-info.sh: Simplify iteration over cards when calling amixer alsa-info.sh: Use existing function to print ALSA configuration files alsa-info.sh: Exit script after writing information to stdout alsa-info.sh: Replace gauge with infobox for upload dialog alsa-info.sh: Remove progress spinner during upload without dialog alsa-info.sh: Condense nested commands for file upload alsa-info.sh: Condense nested commands for formatting upload result alsa-info.sh: Perform test for wget earlier alsa-info.sh: Warn after actual upload failure; do not ping server alsa-info/alsa-info.sh | 251 ++++++++++++++++++------------------------------- 1 file changed, 90 insertions(+), 161 deletions(-) -- 1.8.3.1

2 12

[alsa-devel] [PATCH] pinctrl: lochnagar: select GPIOLIB
by Arnd Bergmann 07 Jan '20

07 Jan '20

In a rare randconfig build I came across one configuration that does not enable CONFIG_GPIOLIB, which is needed by lochnagar: ERROR: "devm_gpiochip_add_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_generic_free" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_generic_request" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_get_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! Add another 'select' like all other pinctrl drivers have. Fixes: 0548448b719a ("pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- I wonder if GPIOLIB should just become mandatory when enabling the pinctrl subsystem, or if there are still good reasons for leaving it disabled on any machine that uses CONFIG_PINCTRL. --- drivers/pinctrl/cirrus/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/cirrus/Kconfig b/drivers/pinctrl/cirrus/Kconfig index f1806fd781a0..530426a74f75 100644 --- a/drivers/pinctrl/cirrus/Kconfig +++ b/drivers/pinctrl/cirrus/Kconfig @@ -2,6 +2,7 @@ config PINCTRL_LOCHNAGAR tristate "Cirrus Logic Lochnagar pinctrl driver" depends on MFD_LOCHNAGAR + select GPIOLIB select PINMUX select PINCONF select GENERIC_PINCONF -- 2.20.0

4 6

[alsa-devel] [PATCH] ASoC: rt5677: add SPI_MASTER dependency
by Arnd Bergmann 07 Jan '20

07 Jan '20

When CONFIG_SPI is disabled, the newly added code for the DSP firmware loading fails to link: ERROR: "rt5677_spi_hotword_detected" [sound/soc/codecs/snd-soc-rt5677.ko] undefined! ERROR: "rt5677_spi_write" [sound/soc/codecs/snd-soc-rt5677.ko] undefined! Add a dependency to prevent this configuration. Note: the does not work with the DT probing, as there is no binding for the SPI half of the driver, but nothing seems to be using that with the mainline kernel anyway. Fixes: 461c623270e4 ("ASoC: rt5677: Load firmware via SPI using delayed work") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/codecs/Kconfig | 1 + sound/soc/intel/boards/Kconfig | 1 + sound/soc/mediatek/Kconfig | 2 +- sound/soc/tegra/Kconfig | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 71b7286d14f2..8e9c461a84f8 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1047,6 +1047,7 @@ config SND_SOC_RT5670 config SND_SOC_RT5677 tristate + depends on SPI_MASTER select REGMAP_I2C select REGMAP_IRQ diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig index ef20316e83d1..da7f9111f3d3 100644 --- a/sound/soc/intel/boards/Kconfig +++ b/sound/soc/intel/boards/Kconfig @@ -34,6 +34,7 @@ if SND_SOC_INTEL_HASWELL || SND_SOC_SOF_BROADWELL config SND_SOC_INTEL_BDW_RT5677_MACH tristate "Broadwell with RT5677 codec" depends on I2C + depends on SPI_MASTER depends on I2C_DESIGNWARE_PLATFORM || COMPILE_TEST depends on GPIOLIB || COMPILE_TEST depends on X86_INTEL_LPSS || COMPILE_TEST diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig index a656d2014127..4699787c93ed 100644 --- a/sound/soc/mediatek/Kconfig +++ b/sound/soc/mediatek/Kconfig @@ -97,7 +97,7 @@ config SND_SOC_MT8173_RT5650_RT5514 config SND_SOC_MT8173_RT5650_RT5676 tristate "ASoC Audio driver for MT8173 with RT5650 RT5676 codecs" - depends on SND_SOC_MT8173 && I2C + depends on SND_SOC_MT8173 && I2C && SPI_MASTER select SND_SOC_RT5645 select SND_SOC_RT5677 select SND_SOC_HDMI_CODEC diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig index addadc827b91..df36e84c0116 100644 --- a/sound/soc/tegra/Kconfig +++ b/sound/soc/tegra/Kconfig @@ -122,7 +122,7 @@ config SND_SOC_TEGRA_MAX98090 config SND_SOC_TEGRA_RT5677 tristate "SoC Audio support for Tegra boards using a RT5677 codec" - depends on SND_SOC_TEGRA && I2C && GPIOLIB + depends on SND_SOC_TEGRA && I2C && GPIOLIB && SPI_MASTER select SND_SOC_RT5677 help Say Y or M here if you want to add support for SoC audio on Tegra -- 2.20.0

4 4

[alsa-devel] [PATCH v5 00/11] ASoC: Add support to WCD9340/WCD9341 codec
by Srinivas Kandagatla 07 Jan '20

07 Jan '20

This patchset adds support to Qualcomm WCD9340/WCD9341 Codec which is a standalone Hi-Fi audio codec IC. This codec supports both I2S/I2C and SLIMbus audio interfaces. On slimbus interface it supports two data lanes; 16 Tx ports and 8 Rx ports. It has Five DACs and seven dedicated interpolators, Multibutton headset control (MBHC), Active noise cancellation, Sidetone paths, MAD (mic activity detection) and codec processing engine. It supports Class-H differential earpiece out and stereo single ended headphones out. This codec also has integrated SoundWire controller. Patchset for this is already sent for review at https://patchwork.kernel.org/cover/11185769/ This patchset has been tested on SDM845 based DragonBoard DB845c and Lenovo Yoga C630 laptop with WSA881x smart speaker amplifiers via soundwire and 4 DMICs. gpio controller patch does not have any link dependency, it can go by its own. Most of the code in this driver is rework of Qualcomm downstream drivers used in Andriod. Credits to Banajit Goswami and Patrick Lai's Team. Thanks, srini Changes since v4: - updated microvolt bindings as suggested by Rob. - slimbus optional property patch already applied. Srinivas Kandagatla (11): ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec mfd: wcd934x: add support to wcd9340/wcd9341 codec ASoC: wcd934x: add support to wcd9340/wcd9341 codec ASoC: wcd934x: add basic controls ASoC: wcd934x: add playback dapm widgets ASoC: wcd934x: add capture dapm widgets ASoC: wcd934x: add audio routings dt-bindings: gpio: wcd934x: Add bindings for gpio gpio: wcd934x: Add support to wcd934x gpio controller ASoC: qcom: dt-bindings: Add compatible for DB845c and Lenovo Yoga ASoC: qcom: sdm845: add support to DB845c and Lenovo Yoga .../bindings/gpio/qcom,wcd934x-gpio.yaml | 47 + .../devicetree/bindings/sound/qcom,sdm845.txt | 5 +- .../bindings/sound/qcom,wcd934x.yaml | 175 + drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-wcd934x.c | 104 + drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile | 1 + drivers/mfd/wcd934x.c | 306 + include/linux/mfd/wcd934x/registers.h | 531 ++ include/linux/mfd/wcd934x/wcd934x.h | 31 + sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/wcd934x.c | 5084 +++++++++++++++++ sound/soc/qcom/sdm845.c | 86 +- 15 files changed, 6401 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml create mode 100644 drivers/gpio/gpio-wcd934x.c create mode 100644 drivers/mfd/wcd934x.c create mode 100644 include/linux/mfd/wcd934x/registers.h create mode 100644 include/linux/mfd/wcd934x/wcd934x.h create mode 100644 sound/soc/codecs/wcd934x.c -- 2.21.0

4 16

[alsa-devel] Right place for defining ACPI GPIO mapping for codec
by Yauhen Kharuzhy 06 Jan '20

06 Jan '20

Hello, I am working now to get sound working at Lenovo Yoga Book tablet. It is Intel CherryTrail-based device and has RT5677 sound codec. The RT5677 codec driver uses two GPIOs to reset and enable the codec, with names 'realtek,reset' and 'realtek,pow-ldo2'. The ACPI definition lacks a _DSD section with GPIO name->CRS ID definition, so I need to manually define this mapping somewhere using existing devm_acpi_dev_add_driver_gpios() method (various devices has various _CRS definitions order and content, so this is cannot be placed into rt5677.c codec driver). The most obvious place for this is ASoC machine driver for my device, but the codec driver is binded to the ACPI device and initializes before machine driver. Can somebody advice how to define such GPIOs mapping for codec in my case? The ACPI definition of sound device is below. Second I2C address definition is for TS3A277E jack detector. The first GPIO in the _CRS is codec reset, the second is pow-ldo2. Device (RTEK) { Name (_ADR, Zero) // _ADR: Address Name (_HID, "10EC5677") // _HID: Hardware ID Name (_CID, "10EC5677") // _CID: Compatible ID Name (_DDN, "Realtek IIS Audio Codec") // _DDN: DOS Device Name Name (_SUB, "17AA7005") // _SUB: Subsystem ID Name (_UID, One) // _UID: Unique ID Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 { CLK3 }) Name (CHAN, Package (0x02) { One, 0x0124F800 }) Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { Name (SBUF, ResourceTemplate () { I2cSerialBusV2 (0x002C, ControllerInitiated, 0x000186A0, AddressingMode7Bit, "\\_SB.PCI0.I2C1", 0x00, ResourceConsumer, , Exclusive, ) I2cSerialBusV2 (0x003B, ControllerInitiated, 0x000186A0, AddressingMode7Bit, "\\_SB.PCI0.I2C1", 0x00, ResourceConsumer, , Exclusive, ) GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x0019 } GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x0012 } GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly, "\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x0030 } GpioInt (Edge, ActiveLow, Exclusive, PullNone, 0x0000, "\\_SB.GPO0", 0x00, ResourceConsumer, , ) { // Pin list 0x005B } GpioInt (Edge, ActiveLow, Exclusive, PullNone, 0x0000, "\\_SB.GPO0", 0x00, ResourceConsumer, , ) { // Pin list 0x004D } SpiSerialBusV2 (0x0001, PolarityLow, FourWireMode, 0x08, ControllerInitiated, 0x003D0900, ClockPolarityHigh, ClockPhaseSecond, "\\_SB.PCI0.SPI1", 0x00, ResourceConsumer, , Exclusive, ) }) Return (SBUF) /* \_SB_.PCI0.I2C1.RTEK._CRS.SBUF */ } Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) } Method (_DIS, 0, NotSerialized) // _DIS: Disable Device { } } -- Yauhen Kharuzhy

2 2