January 2020 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: hda: enable regmap internal locking
by Kai Vehmanen 08 Jan '20

08 Jan '20

This reverts commit 42ec336f1f9d ("ALSA: hda: Disable regmap internal locking"). Without regmap locking, there is a race between snd_hda_codec_amp_init() and PM callbacks issuing regcache_sync(). This was caught by following kernel warning trace: <4> [358.080081] WARNING: CPU: 2 PID: 4157 at drivers/base/regmap/regcache.c:498 regcache_cache_only+0xf5/0x130 [...] <4> [358.080148] Call Trace: <4> [358.080158] snd_hda_codec_amp_init+0x4e/0x100 [snd_hda_codec] <4> [358.080169] snd_hda_codec_amp_init_stereo+0x40/0x80 [snd_hda_codec] Suggested-by: Takashi Iwai <tiwai(a)suse.de> BugLink: https://gitlab.freedesktop.org/drm/intel/issues/592 Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/hda/hdac_regmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c index 906b1e20bae0..286361ecd640 100644 --- a/sound/hda/hdac_regmap.c +++ b/sound/hda/hdac_regmap.c @@ -363,7 +363,6 @@ static const struct regmap_config hda_regmap_cfg = { .reg_write = hda_reg_write, .use_single_read = true, .use_single_write = true, - .disable_locking = true, }; /** -- 2.17.1

2 1

[alsa-devel] [PATCH] ASoC: Fix NULL dereference at freeing
by Takashi Iwai 08 Jan '20

08 Jan '20

When an ASoC driver with pcm_destruct component ops is freed before the PCM object instantiation (e.g. deferring the probe), it hits an Oops at snd_soc_pcm_component_free() that calls the pcm_destruct ops unconditionally. Fix it by adding a NULL-check of rtd->pcm before calling callbacks. Fixes: c64bfc906600 ("ASoC: soc-core: add new pcm_construct/pcm_destruct") Reported-by: Matthias Brugger <matthias.bgg(a)gmail.com> Tested-by: Ben Ho <ben.ho(a)mediatek.com> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/soc/soc-component.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c index 9054558ce386..b94680fb26fa 100644 --- a/sound/soc/soc-component.c +++ b/sound/soc/soc-component.c @@ -539,6 +539,9 @@ void snd_soc_pcm_component_free(struct snd_soc_pcm_runtime *rtd) struct snd_soc_rtdcom_list *rtdcom; struct snd_soc_component *component; + if (!rtd->pcm) + return; + for_each_rtd_components(rtd, rtdcom, component) if (component->driver->pcm_destruct) component->driver->pcm_destruct(component, rtd->pcm); -- 2.16.4

2 1

[alsa-devel] [PATCH 0/2] ASoC: SOF: Intel: update paths to reflect linux-firmware tree
by Pierre-Louis Bossart 08 Jan '20

08 Jan '20

Since we have unfortunately no API to query which firmware signature is required for a given platform, by default the firmware signed with the production key is selected (under intel/sof). DMI quirks are added to deal with platforms using the community key (under intel/sof/community) Pierre-Louis Bossart (2): ASoC: SOF: pci: change the default firmware path when the community key is used ASoC: SOF: loader: add dynamic debug trace sound/soc/sof/loader.c | 3 +++ sound/soc/sof/sof-pci-dev.c | 44 +++++++++++++++++++++++++++++++++++-- 2 files changed, 45 insertions(+), 2 deletions(-) -- 2.20.1

2 4

[alsa-devel] [PATCH] ASoC: gtm601: fix build warning
by Arnd Bergmann 08 Jan '20

08 Jan '20

The driver produces warnings without CONFIG_OF, and makes no sense without it either: sound/soc/codecs/gtm601.c:50:34: error: 'bm818_dai' defined but not used [-Werror=unused-variable] static struct snd_soc_dai_driver bm818_dai = { ^~~~~~~~~ sound/soc/codecs/gtm601.c:32:34: error: 'gtm601_dai' defined but not used [-Werror=unused-variable] static struct snd_soc_dai_driver gtm601_dai = { ^~~~~~~~~~ Remove the #ifdef check to avoid the warning. Fixes: 057a317a8d94 ("ASoC: gtm601: add Broadmobi bm818 sound profile") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/codecs/gtm601.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/gtm601.c b/sound/soc/codecs/gtm601.c index 7f05ebcb88d1..ae9e1c70ca57 100644 --- a/sound/soc/codecs/gtm601.c +++ b/sound/soc/codecs/gtm601.c @@ -87,14 +87,12 @@ static int gtm601_platform_probe(struct platform_device *pdev) (struct snd_soc_dai_driver *)dai_driver, 1); } -#if defined(CONFIG_OF) static const struct of_device_id gtm601_codec_of_match[] = { { .compatible = "option,gtm601", .data = (void *)&gtm601_dai }, { .compatible = "broadmobi,bm818", .data = (void *)&bm818_dai }, {}, }; MODULE_DEVICE_TABLE(of, gtm601_codec_of_match); -#endif static struct platform_driver gtm601_codec_driver = { .driver = { -- 2.20.0

2 1

[alsa-devel] [PATCH] ALSA: hda: Fix a typo in comments
by Takashi Iwai 08 Jan '20

08 Jan '20

Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/hda/hdac_regmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c index 286361ecd640..0c8188a48a00 100644 --- a/sound/hda/hdac_regmap.c +++ b/sound/hda/hdac_regmap.c @@ -508,7 +508,7 @@ int snd_hdac_regmap_read_raw_uncached(struct hdac_device *codec, * snd_hdac_regmap_update_raw - update a pseudo register with power mgmt * @codec: the codec object * @reg: pseudo register - * @mask: bit mask to udpate + * @mask: bit mask to update * @val: value to update * * Returns zero if successful or a negative error code. -- 2.16.4

1 0

[alsa-devel] [PATCH -next] ALSA: pci: echoaudio: remove set but not used variable 'chip'
by YueHaibing 08 Jan '20

08 Jan '20

sound/pci/echoaudio/echoaudio.c: In function snd_echo_mixer_info: sound/pci/echoaudio/echoaudio.c:1233:20: warning: variable chip set but not used [-Wunused-but-set-variable] sound/pci/echoaudio/echoaudio.c: In function 'snd_echo_vmixer_info': sound/pci/echoaudio/echoaudio.c:1300:20: warning: variable 'chip' set but not used [-Wunused-but-set-variable] commit e67c3f0fd44c ("ALSA: pci: echoaudio: remove usage of dimen menber of elem_value structure") left behind this unused variable. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- sound/pci/echoaudio/echoaudio.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c index 07fe0b3..0941a7a 100644 --- a/sound/pci/echoaudio/echoaudio.c +++ b/sound/pci/echoaudio/echoaudio.c @@ -1230,9 +1230,6 @@ static const struct snd_kcontrol_new snd_echo_intput_nominal_level = { static int snd_echo_mixer_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo) { - struct echoaudio *chip; - - chip = snd_kcontrol_chip(kcontrol); uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; uinfo->count = 1; uinfo->value.integer.min = ECHOGAIN_MINOUT; @@ -1300,9 +1297,6 @@ static struct snd_kcontrol_new snd_echo_monitor_mixer = { static int snd_echo_vmixer_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo) { - struct echoaudio *chip; - - chip = snd_kcontrol_chip(kcontrol); uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; uinfo->count = 1; uinfo->value.integer.min = ECHOGAIN_MINOUT; -- 2.7.4

2 1

Re: [alsa-devel] Tascam Coding Inquiry
by Takashi Sakamoto 08 Jan '20

08 Jan '20

Hi, On Wed, Jan 08, 2020 at 01:36:36AM -0700, The Dream Master Solo wrote: > Hello and good day to you. I am reaching out in regards to code I've > found online. I looks like you are the author. > [1]https://elixir.bootlin.com/linux/v5.5-rc5/source/sound/firewire/tascam > I am interested in using this code in creating a 64 bit driver for OSX > 10.13 or newer. I've just begun to learn coding a few weeks ago. Any > help that you can give me towards accomplishing this goal would be > greatly appreciated! It's my pleasure to help developers ;) You can freely utilize the idea written in the source of ALSA firewire-tascam driver with respect for the modern framework of copyright treaty and law. (This is one of my aim to publish the result of my reverse engineering work for the series of device; FW-1884, FW-1082, FW-1804 and FE-8.) I notice that it's better for you to have enough care of software licensing itself. The source of driver is licensed under GNU General Public License version 2.0 (GPLv2)[1]. Roughly speaking, when you just copy any code from the source of driver to your software and distribute your software to the others, your software should be licensed by GPLv2 or compatible ones because it includes lines in the source of driver. On the other hand, as long as you write your software by your hand at first place, you can freely license your software because the borrowing of idea is free from the license on the copyright treaty and law. Well, ALSA firewire-tascam driver uses controllers compliant to 1394 OHCI specification to communicate to the devices. For this purpose, the driver uses kernel implementation of Linux FireWire subsystem. I think that MacOS still includes the similar implementation and as a first step you start study for it. Additionally the specification of 1394 OHCI will help your work: * 1394 Open Host Controller Interface Specification Release 1.00 (October 20, 1997, Promoters of the 1394 Open HCI) * 1394 Open Host Controller Interface Specification Release 1.1 (January 6, 2000, Promoters of the 1394 Open HCI) [1] https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html Regards Takashi Sakamoto

1 0

[alsa-devel] Add quirk for Lenovo X1 Yoga
by Kailang 08 Jan '20

08 Jan '20

Hi Takashi, Attach patch was for Lenovo X1 Yoga. BR, Kailang

3 4

[alsa-devel] Set EAPD control to default for ALC222
by Kailang 08 Jan '20

08 Jan '20

Hi Takashi, Add Set EAPD control to default for ALC222. Many Thanks. BR, Kailang

2 1

[alsa-devel] [PATCH] mixer: Fix memory leak for more than 16 file descriptor case
by David Fries 08 Jan '20

08 Jan '20

Signed-off-by: David Fries <David(a)Fries.net> Reviewed-by: Takashi Iwai <tiwai(a)suse.de> --- Added signed off. I saw this when digging through the source code, wrote up a test case, and verified with valgrind. I don't have that many sound cards so I modified mixer.c to always take the conditional. alloca seemed like the least effort way to fix this. Other thoughts were to test pfds != spfds and free, but given how little bytes would be allocated putting on the stack seems reasonable. I also created the github pull request 20. https://github.com/alsa-project/alsa-lib/pull/20 src/mixer/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mixer/mixer.c b/src/mixer/mixer.c index 82056474..b1af9945 100644 --- a/src/mixer/mixer.c +++ b/src/mixer/mixer.c @@ -767,7 +767,7 @@ int snd_mixer_wait(snd_mixer_t *mixer, int timeout) if (count < 0) return count; if ((unsigned int) count > sizeof(spfds) / sizeof(spfds[0])) { - pfds = malloc(count * sizeof(*pfds)); + pfds = alloca(count * sizeof(*pfds)); if (!pfds) return -ENOMEM; err = snd_mixer_poll_descriptors(mixer, pfds, -- 2.11.0

2 1