May 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document
by S.j. Wang 16 May '19

16 May '19

Add reset-gpio property, which is an optional option Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- Changes in RESEND v3 - send updated binding document only Changes in v3 - update binding document. Changes in v2 - use devm_gpiod_get_optional instead of of_get_named_gpio Documentation/devicetree/bindings/sound/cs42xx8.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cs42xx8.txt b/Documentation/devicetree/bindings/sound/cs42xx8.txt index 8619a156d038..ab8f54095269 100644 --- a/Documentation/devicetree/bindings/sound/cs42xx8.txt +++ b/Documentation/devicetree/bindings/sound/cs42xx8.txt @@ -14,6 +14,11 @@ Required properties: - VA-supply, VD-supply, VLS-supply, VLC-supply: power supplies for the device, as covered in Documentation/devicetree/bindings/regulator/regulator.txt +Optional properties: + + - reset-gpio : a GPIO spec to define which pin is connected to the chip's + !RESET pin + Example: cs42888: codec@48 { @@ -25,4 +30,5 @@ cs42888: codec@48 { VD-supply = <&reg_audio>; VLS-supply = <&reg_audio>; VLC-supply = <&reg_audio>; + reset-gpio = <&pca9557_b 1 1>; }; -- 2.21.0

3 3

Re: [alsa-devel] [PATCH V2] ASoC: cs42xx8: Add reset gpio handling
by S.j. Wang 16 May '19

16 May '19

Hi > > On Thu, May 16, 2019 at 06:04:58AM +0000, S.j. Wang wrote: > > > + cs42xx8->gpiod_reset = devm_gpiod_get_optional(dev, "reset", > > + GPIOD_OUT_HIGH); > > + if (IS_ERR(cs42xx8->gpiod_reset)) > > + return PTR_ERR(cs42xx8->gpiod_reset); > > You also need a binding document update for this. ok, will send v3 best regards wang shengjiu

2 2

[alsa-devel] [PATCH 0/5] ASoC: meson: add hdmitx glue support
by Jerome Brunet 16 May '19

16 May '19

On the Amlogic SoC, there is a glue between the SoC audio outputs and the input of the embedded Synopsys HDMI controller. On the g12a, this glue is mostly a couple of muxes to select the i2s and spdif inputs of the hdmi controller. Each of these inputs may have different hw_params and fmt which makes our life a little bit more interesting, especially when switching between to active inputs. This glue is modeled as codec driver and uses codec-to-codec links to connect to the Synopsys controller. This allows to use the regular hdmi-codec driver (used by dw-hdmi i2s). To avoid glitches while switching input, the trick is to temporarily force a disconnection of the mux output, which shutdowns the output dai link. This also ensure that the stream parameters and fmt are updated when the output is connected back. Jerome Brunet (5): ASoC: meson: axg-card: set link name based on link node name ASoC: dapm: allow muxes to force a disconnect ASoC: meson: add tohdmitx DT bindings ASoC: meson: axg-card: add basic codec-to-codec link support ASoC: meson: add g12a tohdmitx control .../bindings/sound/amlogic,g12a-tohdmitx.txt | 55 +++ .../dt-bindings/sound/meson-g12a-tohdmitx.h | 13 + sound/soc/meson/Kconfig | 8 + sound/soc/meson/Makefile | 2 + sound/soc/meson/axg-card.c | 31 +- sound/soc/meson/g12a-tohdmitx.c | 413 ++++++++++++++++++ sound/soc/soc-dapm.c | 2 +- 7 files changed, 518 insertions(+), 6 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt create mode 100644 include/dt-bindings/sound/meson-g12a-tohdmitx.h create mode 100644 sound/soc/meson/g12a-tohdmitx.c -- 2.20.1

4 12

[alsa-devel] [PATCH V3] ASoC: cs42xx8: Add reset gpio handling
by S.j. Wang 16 May '19

16 May '19

Handle the reset GPIO and reset the device every time we start it. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- Changes in v3 - update binding document. Changes in v2 - use devm_gpiod_get_optional instead of of_get_named_gpio Documentation/devicetree/bindings/sound/cs42xx8.txt | 6 ++++++ sound/soc/codecs/cs42xx8.c | 13 +++++++++++++ 2 files changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cs42xx8.txt b/Documentation/devicetree/bindings/sound/cs42xx8.txt index 8619a156d038..ab8f54095269 100644 --- a/Documentation/devicetree/bindings/sound/cs42xx8.txt +++ b/Documentation/devicetree/bindings/sound/cs42xx8.txt @@ -14,6 +14,11 @@ Required properties: - VA-supply, VD-supply, VLS-supply, VLC-supply: power supplies for the device, as covered in Documentation/devicetree/bindings/regulator/regulator.txt +Optional properties: + + - reset-gpio : a GPIO spec to define which pin is connected to the chip's + !RESET pin + Example: cs42888: codec@48 { @@ -25,4 +30,5 @@ cs42888: codec@48 { VD-supply = <&reg_audio>; VLS-supply = <&reg_audio>; VLC-supply = <&reg_audio>; + reset-gpio = <&pca9557_b 1 1>; }; diff --git a/sound/soc/codecs/cs42xx8.c b/sound/soc/codecs/cs42xx8.c index 28a4ac36c4f8..b377cddaf2e6 100644 --- a/sound/soc/codecs/cs42xx8.c +++ b/sound/soc/codecs/cs42xx8.c @@ -14,6 +14,7 @@ #include <linux/delay.h> #include <linux/module.h> #include <linux/of_device.h> +#include <linux/of_gpio.h> #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> #include <sound/pcm_params.h> @@ -45,6 +46,7 @@ struct cs42xx8_priv { bool slave_mode; unsigned long sysclk; u32 tx_channels; + struct gpio_desc *gpiod_reset; }; /* -127.5dB to 0dB with step of 0.5dB */ @@ -467,6 +469,13 @@ int cs42xx8_probe(struct device *dev, struct regmap *regmap) return -EINVAL; } + cs42xx8->gpiod_reset = devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_HIGH); + if (IS_ERR(cs42xx8->gpiod_reset)) + return PTR_ERR(cs42xx8->gpiod_reset); + + gpiod_set_value_cansleep(cs42xx8->gpiod_reset, 0); + cs42xx8->clk = devm_clk_get(dev, "mclk"); if (IS_ERR(cs42xx8->clk)) { dev_err(dev, "failed to get the clock: %ld\n", @@ -547,6 +556,8 @@ static int cs42xx8_runtime_resume(struct device *dev) return ret; } + gpiod_set_value_cansleep(cs42xx8->gpiod_reset, 0); + ret = regulator_bulk_enable(ARRAY_SIZE(cs42xx8->supplies), cs42xx8->supplies); if (ret) { @@ -586,6 +597,8 @@ static int cs42xx8_runtime_suspend(struct device *dev) regulator_bulk_disable(ARRAY_SIZE(cs42xx8->supplies), cs42xx8->supplies); + gpiod_set_value_cansleep(cs42xx8->gpiod_reset, 1); + clk_disable_unprepare(cs42xx8->clk); return 0; -- 2.21.0

1 0

[alsa-devel] ASoc : cs42xx8 : merge cs42xx8-i2c.c into cs42xx8.c
by Matt Flax 16 May '19

16 May '19

Do you think it would be a good idea to merge cs42xx8-i2c.c into cs42xx8.c ? Is there a reason to keep these two related driver functions separate ? Here is their source code : https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs42xx8-i2c.c https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs42xx8.c Matt

3 3

[alsa-devel] [PATCH 0/2] ASoC: Mediatek: MT8183: support both S32_LE and S24_LE
by Shunli Wang 16 May '19

16 May '19

This patch adds support both S32_LE and S24_LE. The patch is based on broonie tree "for-next" branch. Shunli Wang (2): ASoC: Mediatek: add memory interface data align ASoC: Mediatek: MT8183: set data align sound/soc/mediatek/common/mtk-afe-fe-dai.c | 7 +++++++ sound/soc/mediatek/common/mtk-base-afe.h | 2 ++ sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 18 ++++++++++++++++++ 3 files changed, 27 insertions(+) -- 2.18.0

2 4

Re: [alsa-devel] [PATCH] ASoC: cs42xx8: Add reset gpio handling
by S.j. Wang 16 May '19

16 May '19

Hi Mark > > On Mon, Apr 29, 2019 at 10:46:03AM +0000, S.j. Wang wrote: > > > + cs42xx8->gpio_reset = of_get_named_gpio(dev->of_node, "gpio- > reset", 0); > > + if (gpio_is_valid(cs42xx8->gpio_reset)) { > > + ret = devm_gpio_request_one(dev, cs42xx8->gpio_reset, > > + GPIOF_OUT_INIT_LOW, "cs42xx8 reset"); > > You should just be able to request the GPIO by name without going > through of_get_named_gpio() using devm_gpio_get(). > Will send v2. > > @@ -559,6 +577,7 @@ static int cs42xx8_runtime_resume(struct device > > *dev) > > > > regcache_cache_only(cs42xx8->regmap, false); > > > > + regcache_mark_dirty(cs42xx8->regmap); > > ret = regcache_sync(cs42xx8->regmap); > > if (ret) { > > dev_err(dev, "failed to sync regmap: %d\n", ret); > > This looks like an unrelated bugfix. Will separate it to another patch. Best regards Wang shengjiu

1 0

[alsa-devel] [PATCH v1 0/2] Huawei WMI laptop extras driver
by Ayman Bagabas 15 May '19

15 May '19

Using the WMI BIOS management interface found on Huawei laptops, extra features such as micmute LED, charging thresholds, and fn-lock can be controlled. A platform driver has been implemented along with the existing WMI driver. The platform driver controls the LED, battery charging thresholds, and fn-lock. We enable sound micmute hooks to platform driver on Huawei laptops to get the LED to work. Ayman Bagabas (2): platform/x86: Huawei WMI laptop extras driver update sound: Enable micmute led for Huawei laptops drivers/platform/x86/Kconfig | 8 +- drivers/platform/x86/huawei-wmi.c | 578 +++++++++++++++++++++++++----- sound/pci/hda/patch_realtek.c | 9 +- 3 files changed, 504 insertions(+), 91 deletions(-) -- 2.20.1

2 4

[alsa-devel] WARNING in snd_info_free_entry
by syzbot 15 May '19

15 May '19

Hello, syzbot found the following crash on: HEAD commit: 43151d6c usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=16ae9974a00000 kernel config: https://syzkaller.appspot.com/x/.config?x=95aff7278e7ff25e dashboard link: https://syzkaller.appspot.com/bug?extid=131dee8780c719bc6afb compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=173f3574a00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+131dee8780c719bc6afb(a)syzkaller.appspotmail.com snd_usb_toneport 6-1:0.0: set_interface failed snd_usb_toneport 6-1:0.0: Line 6 POD Studio UX2 now disconnected ------------[ cut here ]------------ list_del corruption. prev->next should be ffff8881d13fa728, but was ffff8881d82ebd68 WARNING: CPU: 1 PID: 1477 at lib/list_debug.c:51 __list_del_entry_valid+0x101/0x170 lib/list_debug.c:51 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 1477 Comm: kworker/1:2 Not tainted 5.1.0-rc3+ #8 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 panic+0x292/0x5e1 kernel/panic.c:214 __warn.cold+0x20/0x53 kernel/panic.c:571 report_bug+0x262/0x2a0 lib/bug.c:186 fixup_bug arch/x86/kernel/traps.c:179 [inline] fixup_bug arch/x86/kernel/traps.c:174 [inline] do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:272 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:291 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:973 RIP: 0010:__list_del_entry_valid+0x101/0x170 lib/list_debug.c:51 Code: c4 08 31 c0 41 5c 41 5d c3 4c 89 e2 48 c7 c7 20 f7 d8 85 e8 1c 2a 35 ff 0f 0b 31 c0 eb c6 48 c7 c7 80 f7 d8 85 e8 0a 2a 35 ff <0f> 0b 31 c0 eb b4 48 c7 c7 e0 f7 d8 85 e8 f8 29 35 ff 0f 0b 31 c0 RSP: 0018:ffff8881d7a1f078 EFLAGS: 00010282 RAX: 0000000000000000 RBX: ffff8881d13fa630 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff8127bbcd RDI: ffffed103af43e01 RBP: ffff8881d13fa640 R08: ffff8881d7a10000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffff8881d13fad68 R13: ffff8881d7f1d858 R14: ffff8881d13fa630 R15: ffff8881d13fa718 __list_del_entry include/linux/list.h:117 [inline] list_del include/linux/list.h:125 [inline] snd_info_free_entry+0x132/0x340 sound/core/info.c:795 snd_info_card_free+0x3e/0x80 sound/core/info.c:606 snd_card_do_free sound/core/init.c:469 [inline] release_card_device+0x63/0xd0 sound/core/init.c:156 device_release+0x78/0x210 drivers/base/core.c:1064 kobject_cleanup lib/kobject.c:662 [inline] kobject_release lib/kobject.c:691 [inline] kref_put include/linux/kref.h:67 [inline] kobject_put+0x17d/0x270 lib/kobject.c:708 put_device+0x1c/0x30 drivers/base/core.c:2205 snd_card_free_when_closed+0x35/0x50 sound/core/init.c:493 line6_disconnect.cold+0xa3/0xbc sound/usb/line6/driver.c:833 line6_probe+0xb1e/0x1140 sound/usb/line6/driver.c:799 usb_probe_interface+0x30d/0x7b0 drivers/usb/core/driver.c:361 really_probe+0x296/0x680 drivers/base/dd.c:509 driver_probe_device+0xf9/0x200 drivers/base/dd.c:671 __device_attach_driver+0x1c4/0x230 drivers/base/dd.c:778 bus_for_each_drv+0x15e/0x1e0 drivers/base/bus.c:454 __device_attach+0x21e/0x360 drivers/base/dd.c:844 bus_probe_device+0x1ec/0x2a0 drivers/base/bus.c:514 device_add+0xaf4/0x1700 drivers/base/core.c:2106 usb_set_configuration+0xdf2/0x1670 drivers/usb/core/message.c:2023 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 usb_probe_device+0xa8/0x110 drivers/usb/core/driver.c:266 really_probe+0x296/0x680 drivers/base/dd.c:509 driver_probe_device+0xf9/0x200 drivers/base/dd.c:671 __device_attach_driver+0x1c4/0x230 drivers/base/dd.c:778 bus_for_each_drv+0x15e/0x1e0 drivers/base/bus.c:454 __device_attach+0x21e/0x360 drivers/base/dd.c:844 bus_probe_device+0x1ec/0x2a0 drivers/base/bus.c:514 device_add+0xaf4/0x1700 drivers/base/core.c:2106 usb_new_device.cold+0x8b8/0x1030 drivers/usb/core/hub.c:2534 hub_port_connect drivers/usb/core/hub.c:5089 [inline] hub_port_connect_change drivers/usb/core/hub.c:5204 [inline] port_event drivers/usb/core/hub.c:5350 [inline] hub_event+0x1ac9/0x35a0 drivers/usb/core/hub.c:5432 process_one_work+0x90a/0x1580 kernel/workqueue.c:2269 process_scheduled_works kernel/workqueue.c:2331 [inline] worker_thread+0x7ab/0xe20 kernel/workqueue.c:2417 kthread+0x30e/0x420 kernel/kthread.c:253 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352 Kernel Offset: disabled Rebooting in 86400 seconds.. --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

2 1

[alsa-devel] [PATCH v2] ACPI / device_sysfs: change _ADR representation to 64 bits
by Pierre-Louis Bossart 14 May '19

14 May '19

Standards such as the MIPI DisCo for SoundWire 1.0 specification assume the _ADR field is 64 bits. _ADR is defined as an "Integer" represented as 64 bits since ACPI 2.0 released in 2002. The low levels already use _ADR as 64 bits, e.g. in struct acpi_device_info. This patch bumps the representation used for sysfs to 64 bits. To avoid any compatibility/ABI issues, the printf format is only extended to 16 characters when the actual _ADR value exceeds the 32 bit maximum. Example with a SoundWire device, the results show the complete vendorID and linkID which were omitted before: Before: $ more /sys/bus/acpi/devices/device\:38/adr 0x5d070000 After: $ more /sys/bus/acpi/devices/device\:38/adr 0x000010025d070000 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- v2: only use 64 bits when required to avoid compatibility issues (feedback from Vinod and Rafael) drivers/acpi/device_sysfs.c | 6 ++++-- include/acpi/acpi_bus.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c index 8940054d6250..7dda0ee05cd1 100644 --- a/drivers/acpi/device_sysfs.c +++ b/drivers/acpi/device_sysfs.c @@ -428,8 +428,10 @@ static ssize_t acpi_device_adr_show(struct device *dev, { struct acpi_device *acpi_dev = to_acpi_device(dev); - return sprintf(buf, "0x%08x\n", - (unsigned int)(acpi_dev->pnp.bus_address)); + if (acpi_dev->pnp.bus_address > 0xFFFFFFFF) + return sprintf(buf, "0x%016llx\n", acpi_dev->pnp.bus_address); + else + return sprintf(buf, "0x%08llx\n", acpi_dev->pnp.bus_address); } static DEVICE_ATTR(adr, 0444, acpi_device_adr_show, NULL); diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index f7981751ac77..9075e28ea60a 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -230,7 +230,7 @@ struct acpi_device_dir { /* Plug and Play */ typedef char acpi_bus_id[8]; -typedef unsigned long acpi_bus_address; +typedef u64 acpi_bus_address; typedef char acpi_device_name[40]; typedef char acpi_device_class[20]; -- 2.17.1

5 5