May 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [asoc:for-5.3 34/40] sound/soc/mediatek/common/mtk-afe-fe-dai.c:268:2: error: too few arguments to function 'mtk_regmap_update_bits'
by kbuild test robot 16 May '19

16 May '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3 head: c8609f3870f7078fc7922eb816ed4908a9bd44f3 commit: 1628fc3f47717fc3c8d9cd5fd6c7bc7d3796927d [34/40] ASoC: Mediatek: add memory interface data align config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 1628fc3f47717fc3c8d9cd5fd6c7bc7d3796927d # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): sound/soc/mediatek/common/mtk-afe-fe-dai.c: In function 'mtk_afe_fe_prepare': >> sound/soc/mediatek/common/mtk-afe-fe-dai.c:268:2: error: too few arguments to function 'mtk_regmap_update_bits' mtk_regmap_update_bits(afe->regmap, memif->data->hd_align_reg, ^~~~~~~~~~~~~~~~~~~~~~ sound/soc/mediatek/common/mtk-afe-fe-dai.c:19:12: note: declared here static int mtk_regmap_update_bits(struct regmap *map, int reg, ^~~~~~~~~~~~~~~~~~~~~~ vim +/mtk_regmap_update_bits +268 sound/soc/mediatek/common/mtk-afe-fe-dai.c 236 237 int mtk_afe_fe_prepare(struct snd_pcm_substream *substream, 238 struct snd_soc_dai *dai) 239 { 240 struct snd_soc_pcm_runtime *rtd = substream->private_data; 241 struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); 242 struct mtk_base_afe_memif *memif = &afe->memif[rtd->cpu_dai->id]; 243 int hd_audio = 0; 244 int hd_align = 1; 245 246 /* set hd mode */ 247 switch (substream->runtime->format) { 248 case SNDRV_PCM_FORMAT_S16_LE: 249 hd_audio = 0; 250 break; 251 case SNDRV_PCM_FORMAT_S32_LE: 252 hd_audio = 1; 253 hd_align = 1; 254 break; 255 case SNDRV_PCM_FORMAT_S24_LE: 256 hd_audio = 1; 257 hd_align = 0; 258 break; 259 default: 260 dev_err(afe->dev, "%s() error: unsupported format %d\n", 261 __func__, substream->runtime->format); 262 break; 263 } 264 265 mtk_regmap_update_bits(afe->regmap, memif->data->hd_reg, 266 1, hd_audio, memif->data->hd_shift); 267 > 268 mtk_regmap_update_bits(afe->regmap, memif->data->hd_align_reg, 269 memif->data->hd_align_mshift, 270 hd_align ? memif->data->hd_align_mshift : 0); 271 272 return 0; 273 } 274 EXPORT_SYMBOL_GPL(mtk_afe_fe_prepare); 275 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

Re: [alsa-devel] [PATCH V4] ASoC: cs42xx8: add reset-gpios in binding document
by S.j. Wang 16 May '19

16 May '19

Hi > On Thu, May 16, 2019 at 8:36 AM S.j. Wang <shengjiu.wang(a)nxp.com> > wrote: > > > cs42888: codec@48 { > > @@ -25,4 +30,5 @@ cs42888: codec@48 { > > VD-supply = <&reg_audio>; > > VLS-supply = <&reg_audio>; > > VLC-supply = <&reg_audio>; > > + reset-gpios = <&pca9557_b 1 1>; > > reset-gpios = <&pca9557_b 1 GPIO_ACTIVE_LOW>; please Ok, sent v5. Best regards Wang shengjiu

1 0

[alsa-devel] [PATCH V4] ASoC: cs42xx8: add reset-gpios in binding document
by S.j. Wang 16 May '19

16 May '19

Add reset-gpios property, which is optional. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- Changes in V4 - use gpios instead of gpio Changes in RESEND v3 - send updated binding document only Changes in v3 - update binding document. Changes in v2 - use devm_gpiod_get_optional instead of of_get_named_gpio Documentation/devicetree/bindings/sound/cs42xx8.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cs42xx8.txt b/Documentation/devicetree/bindings/sound/cs42xx8.txt index 8619a156d038..0138ef559cc4 100644 --- a/Documentation/devicetree/bindings/sound/cs42xx8.txt +++ b/Documentation/devicetree/bindings/sound/cs42xx8.txt @@ -14,6 +14,11 @@ Required properties: - VA-supply, VD-supply, VLS-supply, VLC-supply: power supplies for the device, as covered in Documentation/devicetree/bindings/regulator/regulator.txt +Optional properties: + + - reset-gpios : a GPIO spec to define which pin is connected to the chip's + !RESET pin + Example: cs42888: codec@48 { @@ -25,4 +30,5 @@ cs42888: codec@48 { VD-supply = <&reg_audio>; VLS-supply = <&reg_audio>; VLC-supply = <&reg_audio>; + reset-gpios = <&pca9557_b 1 1>; }; -- 2.21.0

2 1

[alsa-devel] [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document
by S.j. Wang 16 May '19

16 May '19

Add reset-gpio property, which is an optional option Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- Changes in RESEND v3 - send updated binding document only Changes in v3 - update binding document. Changes in v2 - use devm_gpiod_get_optional instead of of_get_named_gpio Documentation/devicetree/bindings/sound/cs42xx8.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cs42xx8.txt b/Documentation/devicetree/bindings/sound/cs42xx8.txt index 8619a156d038..ab8f54095269 100644 --- a/Documentation/devicetree/bindings/sound/cs42xx8.txt +++ b/Documentation/devicetree/bindings/sound/cs42xx8.txt @@ -14,6 +14,11 @@ Required properties: - VA-supply, VD-supply, VLS-supply, VLC-supply: power supplies for the device, as covered in Documentation/devicetree/bindings/regulator/regulator.txt +Optional properties: + + - reset-gpio : a GPIO spec to define which pin is connected to the chip's + !RESET pin + Example: cs42888: codec@48 { @@ -25,4 +30,5 @@ cs42888: codec@48 { VD-supply = <&reg_audio>; VLS-supply = <&reg_audio>; VLC-supply = <&reg_audio>; + reset-gpio = <&pca9557_b 1 1>; }; -- 2.21.0

3 3

Re: [alsa-devel] [PATCH V2] ASoC: cs42xx8: Add reset gpio handling
by S.j. Wang 16 May '19

16 May '19

Hi > > On Thu, May 16, 2019 at 06:04:58AM +0000, S.j. Wang wrote: > > > + cs42xx8->gpiod_reset = devm_gpiod_get_optional(dev, "reset", > > + GPIOD_OUT_HIGH); > > + if (IS_ERR(cs42xx8->gpiod_reset)) > > + return PTR_ERR(cs42xx8->gpiod_reset); > > You also need a binding document update for this. ok, will send v3 best regards wang shengjiu

2 2

[alsa-devel] [PATCH 0/5] ASoC: meson: add hdmitx glue support
by Jerome Brunet 16 May '19

16 May '19

On the Amlogic SoC, there is a glue between the SoC audio outputs and the input of the embedded Synopsys HDMI controller. On the g12a, this glue is mostly a couple of muxes to select the i2s and spdif inputs of the hdmi controller. Each of these inputs may have different hw_params and fmt which makes our life a little bit more interesting, especially when switching between to active inputs. This glue is modeled as codec driver and uses codec-to-codec links to connect to the Synopsys controller. This allows to use the regular hdmi-codec driver (used by dw-hdmi i2s). To avoid glitches while switching input, the trick is to temporarily force a disconnection of the mux output, which shutdowns the output dai link. This also ensure that the stream parameters and fmt are updated when the output is connected back. Jerome Brunet (5): ASoC: meson: axg-card: set link name based on link node name ASoC: dapm: allow muxes to force a disconnect ASoC: meson: add tohdmitx DT bindings ASoC: meson: axg-card: add basic codec-to-codec link support ASoC: meson: add g12a tohdmitx control .../bindings/sound/amlogic,g12a-tohdmitx.txt | 55 +++ .../dt-bindings/sound/meson-g12a-tohdmitx.h | 13 + sound/soc/meson/Kconfig | 8 + sound/soc/meson/Makefile | 2 + sound/soc/meson/axg-card.c | 31 +- sound/soc/meson/g12a-tohdmitx.c | 413 ++++++++++++++++++ sound/soc/soc-dapm.c | 2 +- 7 files changed, 518 insertions(+), 6 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/amlogic,g12a-tohdmitx.txt create mode 100644 include/dt-bindings/sound/meson-g12a-tohdmitx.h create mode 100644 sound/soc/meson/g12a-tohdmitx.c -- 2.20.1

4 12

[alsa-devel] [PATCH V3] ASoC: cs42xx8: Add reset gpio handling
by S.j. Wang 16 May '19

16 May '19

Handle the reset GPIO and reset the device every time we start it. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- Changes in v3 - update binding document. Changes in v2 - use devm_gpiod_get_optional instead of of_get_named_gpio Documentation/devicetree/bindings/sound/cs42xx8.txt | 6 ++++++ sound/soc/codecs/cs42xx8.c | 13 +++++++++++++ 2 files changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/cs42xx8.txt b/Documentation/devicetree/bindings/sound/cs42xx8.txt index 8619a156d038..ab8f54095269 100644 --- a/Documentation/devicetree/bindings/sound/cs42xx8.txt +++ b/Documentation/devicetree/bindings/sound/cs42xx8.txt @@ -14,6 +14,11 @@ Required properties: - VA-supply, VD-supply, VLS-supply, VLC-supply: power supplies for the device, as covered in Documentation/devicetree/bindings/regulator/regulator.txt +Optional properties: + + - reset-gpio : a GPIO spec to define which pin is connected to the chip's + !RESET pin + Example: cs42888: codec@48 { @@ -25,4 +30,5 @@ cs42888: codec@48 { VD-supply = <&reg_audio>; VLS-supply = <&reg_audio>; VLC-supply = <&reg_audio>; + reset-gpio = <&pca9557_b 1 1>; }; diff --git a/sound/soc/codecs/cs42xx8.c b/sound/soc/codecs/cs42xx8.c index 28a4ac36c4f8..b377cddaf2e6 100644 --- a/sound/soc/codecs/cs42xx8.c +++ b/sound/soc/codecs/cs42xx8.c @@ -14,6 +14,7 @@ #include <linux/delay.h> #include <linux/module.h> #include <linux/of_device.h> +#include <linux/of_gpio.h> #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> #include <sound/pcm_params.h> @@ -45,6 +46,7 @@ struct cs42xx8_priv { bool slave_mode; unsigned long sysclk; u32 tx_channels; + struct gpio_desc *gpiod_reset; }; /* -127.5dB to 0dB with step of 0.5dB */ @@ -467,6 +469,13 @@ int cs42xx8_probe(struct device *dev, struct regmap *regmap) return -EINVAL; } + cs42xx8->gpiod_reset = devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_HIGH); + if (IS_ERR(cs42xx8->gpiod_reset)) + return PTR_ERR(cs42xx8->gpiod_reset); + + gpiod_set_value_cansleep(cs42xx8->gpiod_reset, 0); + cs42xx8->clk = devm_clk_get(dev, "mclk"); if (IS_ERR(cs42xx8->clk)) { dev_err(dev, "failed to get the clock: %ld\n", @@ -547,6 +556,8 @@ static int cs42xx8_runtime_resume(struct device *dev) return ret; } + gpiod_set_value_cansleep(cs42xx8->gpiod_reset, 0); + ret = regulator_bulk_enable(ARRAY_SIZE(cs42xx8->supplies), cs42xx8->supplies); if (ret) { @@ -586,6 +597,8 @@ static int cs42xx8_runtime_suspend(struct device *dev) regulator_bulk_disable(ARRAY_SIZE(cs42xx8->supplies), cs42xx8->supplies); + gpiod_set_value_cansleep(cs42xx8->gpiod_reset, 1); + clk_disable_unprepare(cs42xx8->clk); return 0; -- 2.21.0

1 0

[alsa-devel] ASoc : cs42xx8 : merge cs42xx8-i2c.c into cs42xx8.c
by Matt Flax 16 May '19

16 May '19

Do you think it would be a good idea to merge cs42xx8-i2c.c into cs42xx8.c ? Is there a reason to keep these two related driver functions separate ? Here is their source code : https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs42xx8-i2c.c https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs42xx8.c Matt

3 3

[alsa-devel] [PATCH 0/2] ASoC: Mediatek: MT8183: support both S32_LE and S24_LE
by Shunli Wang 16 May '19

16 May '19

This patch adds support both S32_LE and S24_LE. The patch is based on broonie tree "for-next" branch. Shunli Wang (2): ASoC: Mediatek: add memory interface data align ASoC: Mediatek: MT8183: set data align sound/soc/mediatek/common/mtk-afe-fe-dai.c | 7 +++++++ sound/soc/mediatek/common/mtk-base-afe.h | 2 ++ sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 18 ++++++++++++++++++ 3 files changed, 27 insertions(+) -- 2.18.0

2 4

Re: [alsa-devel] [PATCH] ASoC: cs42xx8: Add reset gpio handling
by S.j. Wang 16 May '19

16 May '19

Hi Mark > > On Mon, Apr 29, 2019 at 10:46:03AM +0000, S.j. Wang wrote: > > > + cs42xx8->gpio_reset = of_get_named_gpio(dev->of_node, "gpio- > reset", 0); > > + if (gpio_is_valid(cs42xx8->gpio_reset)) { > > + ret = devm_gpio_request_one(dev, cs42xx8->gpio_reset, > > + GPIOF_OUT_INIT_LOW, "cs42xx8 reset"); > > You should just be able to request the GPIO by name without going > through of_get_named_gpio() using devm_gpio_get(). > Will send v2. > > @@ -559,6 +577,7 @@ static int cs42xx8_runtime_resume(struct device > > *dev) > > > > regcache_cache_only(cs42xx8->regmap, false); > > > > + regcache_mark_dirty(cs42xx8->regmap); > > ret = regcache_sync(cs42xx8->regmap); > > if (ret) { > > dev_err(dev, "failed to sync regmap: %d\n", ret); > > This looks like an unrelated bugfix. Will separate it to another patch. Best regards Wang shengjiu

1 0