April 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] Documentation: soundwire: Ensure that code is inside the code blocks
by Jonathan Neuschäfer 02 Apr '19

02 Apr '19

The way the document is written now, Sphinx renders empty code blocks followed by the lines that should be inside them. Unindent the code-block directives to fix this. Fixes: 502c00d9c315 ("Documentation: soundwire: fix stream.rst markup warnings") Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- Documentation/driver-api/soundwire/stream.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/driver-api/soundwire/stream.rst b/Documentation/driver-api/soundwire/stream.rst index 26a6064503fd..5351bd2f34a8 100644 --- a/Documentation/driver-api/soundwire/stream.rst +++ b/Documentation/driver-api/soundwire/stream.rst @@ -201,7 +201,7 @@ Bus implements below API for allocate a stream which needs to be called once per stream. From ASoC DPCM framework, this stream state maybe linked to .startup() operation. - .. code-block:: c +.. code-block:: c int sdw_alloc_stream(char * stream_name); @@ -228,7 +228,7 @@ the respective Master(s) and Slave(s) associated with stream. These APIs can only be invoked once by respective Master(s) and Slave(s). From ASoC DPCM framework, this stream state is linked to .hw_params() operation. - .. code-block:: c +.. code-block:: c int sdw_stream_add_master(struct sdw_bus * bus, struct sdw_stream_config * stream_config, @@ -274,7 +274,7 @@ Bus implements below API for PREPARE state which needs to be called once per stream. From ASoC DPCM framework, this stream state is linked to .prepare() operation. - .. code-block:: c +.. code-block:: c int sdw_prepare_stream(struct sdw_stream_runtime * stream); @@ -304,7 +304,7 @@ Bus implements below API for ENABLE state which needs to be called once per stream. From ASoC DPCM framework, this stream state is linked to .trigger() start operation. - .. code-block:: c +.. code-block:: c int sdw_enable_stream(struct sdw_stream_runtime * stream); @@ -332,7 +332,7 @@ Bus implements below API for DISABLED state which needs to be called once per stream. From ASoC DPCM framework, this stream state is linked to .trigger() stop operation. - .. code-block:: c +.. code-block:: c int sdw_disable_stream(struct sdw_stream_runtime * stream); @@ -357,7 +357,7 @@ Bus implements below API for DEPREPARED state which needs to be called once per stream. From ASoC DPCM framework, this stream state is linked to .trigger() stop operation. - .. code-block:: c +.. code-block:: c int sdw_deprepare_stream(struct sdw_stream_runtime * stream); @@ -382,7 +382,7 @@ Bus implements below APIs for RELEASE state which needs to be called by all the Master(s) and Slave(s) associated with stream. From ASoC DPCM framework, this stream state is linked to .hw_free() operation. - .. code-block:: c +.. code-block:: c int sdw_stream_remove_master(struct sdw_bus * bus, struct sdw_stream_runtime * stream); @@ -395,7 +395,7 @@ stream assigned as part of ALLOCATED state. In .shutdown() the data structure maintaining stream state are freed up. - .. code-block:: c +.. code-block:: c void sdw_release_stream(struct sdw_stream_runtime * stream); -- 2.20.1

2 2

[alsa-devel] [asoc:for-5.2 92/97] sound/soc//mediatek/mt8183/mt8183-da7219-max98357.c:413:13: error: 'struct snd_soc_dai_link' has no member named 'platform'; did you mean 'platforms'?
by kbuild test robot 01 Apr '19

01 Apr '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2 head: 35146467bd43704c52d1d5760af9839a10ad5b12 commit: ebbddc75bbe8d8eab64d3285b0480f5ae9232b2e [92/97] ASoC: Mediatek: MT8183: Add machine driver with DA7219 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout ebbddc75bbe8d8eab64d3285b0480f5ae9232b2e # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All errors (new ones prefixed by >>): sound/soc//mediatek/mt8183/mt8183-da7219-max98357.c: In function 'mt8183_da7219_max98357_dev_probe': >> sound/soc//mediatek/mt8183/mt8183-da7219-max98357.c:413:13: error: 'struct snd_soc_dai_link' has no member named 'platform'; did you mean 'platforms'? dai_link->platform = NULL; ^~~~~~~~ platforms vim +413 sound/soc//mediatek/mt8183/mt8183-da7219-max98357.c 387 388 static int mt8183_da7219_max98357_dev_probe(struct platform_device *pdev) 389 { 390 struct snd_soc_card *card = &mt8183_da7219_max98357_card; 391 struct device_node *platform_node; 392 struct snd_soc_dai_link *dai_link; 393 struct pinctrl *default_pins; 394 int ret, i; 395 396 card->dev = &pdev->dev; 397 398 platform_node = of_parse_phandle(pdev->dev.of_node, 399 "mediatek,platform", 0); 400 if (!platform_node) { 401 dev_err(&pdev->dev, "Property 'platform' missing or invalid\n"); 402 return -EINVAL; 403 } 404 405 for_each_card_prelinks(card, i, dai_link) { 406 /* In the alsa soc-core, the "platform" will be 407 * allocated by devm_kzalloc if null. 408 * There is a special case that registerring 409 * sound card is failed at the first time, but 410 * the "platform" will not null when probe is trying 411 * again. It's not expected normally. 412 */ > 413 dai_link->platform = NULL; 414 415 if (dai_link->platform_name) 416 continue; 417 dai_link->platform_of_node = platform_node; 418 } 419 420 mt8183_da7219_max98357_headset_dev.codec_of_node = 421 of_parse_phandle(pdev->dev.of_node, 422 "mediatek,headset-codec", 0); 423 if (!mt8183_da7219_max98357_headset_dev.codec_of_node) { 424 dev_err(&pdev->dev, 425 "Property 'mediatek,headset-codec' missing/invalid\n"); 426 return -EINVAL; 427 } 428 429 ret = devm_snd_soc_register_card(&pdev->dev, card); 430 if (ret) { 431 dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n", 432 __func__, ret); 433 return ret; 434 } 435 436 default_pins = 437 devm_pinctrl_get_select(&pdev->dev, PINCTRL_STATE_DEFAULT); 438 if (IS_ERR(default_pins)) { 439 dev_err(&pdev->dev, "%s set pins failed\n", 440 __func__); 441 return PTR_ERR(default_pins); 442 } 443 444 return ret; 445 } 446 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH v14 0/6] Media Device Allocator API
by Shuah Khan 01 Apr '19

01 Apr '19

Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Video class, two or more independent drivers will share a single physical USB bridge. In such cases, it is necessary to coordinate access to the shared resource. Using this API, drivers can allocate a media device with the shared struct device as the key. Once the media device is allocated by a driver, other drivers can get a reference to it. The media device is released when all the references are released. The primary focus for testing The patch series is making sure media device is released when both drivers release the media device with a series of unbind/binds on both drivers. - both au0828 and snd-usb-aduio as built-in - both au0828 and snd-usb-aduio as modules - au0828 as module and snd-usb-aduio as built-in - au0828 as built-in and snd-usb-aduio as module Test results can be found at: https://docs.google.com/document/d/1RMF8Rwj7xHJEoOx6_K2f-REgZJ63BMeAVEf-CV-… Changes since v13: - Minor changes to variable names and other minor changes to copyright and typos suggested by Hans Verkuil. Changes since v12: - Patch 1: Fixed prototype warns from media_dev_allocator.c. Removed dependency on find_module() by adding struct module to input args. Still need module name to pass into media_device API. - Patch 2 & 4: Update media dev allocator api calls to pass in struct module pointer. - No changes to Patches 3 & 5. - Added patch 6 with a test. It can go in separately. Changes since v11: - Patch 1: Add CONFIG_MODULES dependency in media_dev_allocator files. to fix compile errors when CONFIG_MODULES is disabled. - Patch 2, 3: No changes. - Patch 4: Fix sparse error reported by Dan Carpenter. - Patch 5: Fix warns found by Hans Verkuil. - v11 was tested on 5.0-rc7 and addresses comments on v10 series from Hans Verkuil. Fixed problems found in resource sharing logic in au0828 adding a patch 5 to this series. The test plan used for testing resource sharing could serve as a regression test plan and the test results can be found at: - v10 was tested on 5.0-rc3 and addresses comments on v9 series from Hans Verkuil. Changes since v10: - Patch 1: Fixed SPDX tag and removed redundant IS_ENABLED(CONFIG_USB) around media_device_usb_allocate() - Sakari Ailus's review comment. - Patch 2 and 3: No changes - Patch 4: Fixed SPDX tag - Sakari Ailus's review comment. - Carried Reviewed-by tag from Takashi Iwai for the sound from v9. - Patch 5: This is a new patch added to fix resource sharing inconsistencies and problem found during testing using Han's tests. Changes since v9: - Patch 1: Fix mutex assert warning from find_module() calls. This code was written before the change to find_module() that requires callers to hold module_mutex. I missed this during my testing on 4.20-rc6. Hans Verkuil reported the problem. - Patch 4: sound/usb: Initializes all the entities it can before registering the device based on comments from Hans Verkuil - Carried Reviewed-by tag from Takashi Iwai for the sound from v9. - No changes to Patches 2 and 3. References: https://lkml.org/lkml/2018/11/2/169 https://www.mail-archive.com/linux-media@vger.kernel.org/msg105854.html Shuah Khan (6): media: Media Device Allocator API media: change au0828 to use Media Device Allocator API media: media.h: Enable ALSA MEDIA_INTF_T* interface types sound/usb: Use Media Controller API to share media resources au0828: fix enable and disable source audio and video inconsistencies selftests: media_dev_allocator api test Documentation/media/kapi/mc-core.rst | 41 +++ drivers/media/Makefile | 6 + drivers/media/media-dev-allocator.c | 135 ++++++++ drivers/media/usb/au0828/Kconfig | 2 + drivers/media/usb/au0828/au0828-core.c | 195 ++++++++--- drivers/media/usb/au0828/au0828.h | 6 +- include/media/media-dev-allocator.h | 63 ++++ include/uapi/linux/media.h | 25 +- sound/usb/Kconfig | 4 + sound/usb/Makefile | 2 + sound/usb/card.c | 14 + sound/usb/card.h | 3 + sound/usb/media.c | 327 ++++++++++++++++++ sound/usb/media.h | 74 ++++ sound/usb/mixer.h | 3 + sound/usb/pcm.c | 29 +- sound/usb/quirks-table.h | 1 + sound/usb/stream.c | 2 + sound/usb/usbaudio.h | 6 + .../media_tests/media_dev_allocator.sh | 85 +++++ 20 files changed, 962 insertions(+), 61 deletions(-) create mode 100644 drivers/media/media-dev-allocator.c create mode 100644 include/media/media-dev-allocator.h create mode 100644 sound/usb/media.c create mode 100644 sound/usb/media.h create mode 100755 tools/testing/selftests/media_tests/media_dev_allocator.sh -- 2.17.1

3 8

[alsa-devel] [PATCH v4] ASoC: Intel: boards: kbl_da7219_max98927: add dai_trigger function
by Jenny TC 01 Apr '19

01 Apr '19

From: Mac Chiang <mac.chiang(a)intel.com> amplifier feedback is not modeled as being dependent on any active output. Even when there is no playback happening, parts of the graph, specifically the IV sense->speaker protection->output remains active and this prevents the DSP from entering low-power states. This patch suggest a machine driver level approach where the speaker pins are enabled/disabled dynamically depending on stream start/stop events. DPAM graph representations show the feedback loop is indeed disabled and low-power states can be reached. Signed-off-by: Jenny TC <jenny.tc(a)intel.com> Signed-off-by: Harshapriya.n <harshapriya.n(a)intel.com> Signed-off-by: Mac Chiang <mac.chiang(a)intel.com> --- Changelog: v4: - Changed device name in in kabylake_ssp0_trigger to address a conflict with recently merged patch MAXIM_DEV0_NAME -> MAX98927_DEV0_NAME ... v3: - fixed the return logic at the end of kabylake_card_late_probe() v2: - described clearly in commit message - added snd_soc_dapm_disable_pin in kabylake_card_late_probe() --- --- sound/soc/intel/boards/kbl_da7219_max98927.c | 73 +++++++++++++++++++++++++++- 1 file changed, 71 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/boards/kbl_da7219_max98927.c b/sound/soc/intel/boards/kbl_da7219_max98927.c index 2768a57..a04a6bb 100644 --- a/sound/soc/intel/boards/kbl_da7219_max98927.c +++ b/sound/soc/intel/boards/kbl_da7219_max98927.c @@ -219,8 +219,60 @@ static int kabylake_ssp0_hw_params(struct snd_pcm_substream *substream, return 0; } +static int kabylake_ssp0_trigger(struct snd_pcm_substream *substream, int cmd) +{ + struct snd_soc_pcm_runtime *rtd = substream->private_data; + int j, ret; + + for (j = 0; j < rtd->num_codecs; j++) { + struct snd_soc_dai *codec_dai = rtd->codec_dais[j]; + const char *name = codec_dai->component->name; + struct snd_soc_component *component = codec_dai->component; + struct snd_soc_dapm_context *dapm = + snd_soc_component_get_dapm(component); + char pin_name[20]; + + if (strcmp(name, MAX98927_DEV0_NAME) && + strcmp(name, MAX98927_DEV1_NAME) && + strcmp(name, MAX98373_DEV0_NAME) && + strcmp(name, MAX98373_DEV1_NAME)) + continue; + + snprintf(pin_name, ARRAY_SIZE(pin_name), "%s Spk", + codec_dai->component->name_prefix); + + switch (cmd) { + case SNDRV_PCM_TRIGGER_START: + case SNDRV_PCM_TRIGGER_RESUME: + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: + ret = snd_soc_dapm_enable_pin(dapm, pin_name); + if (ret) { + dev_err(rtd->dev, "failed to enable %s: %d\n", + pin_name, ret); + return ret; + } + snd_soc_dapm_sync(dapm); + break; + case SNDRV_PCM_TRIGGER_STOP: + case SNDRV_PCM_TRIGGER_SUSPEND: + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: + ret = snd_soc_dapm_disable_pin(dapm, pin_name); + if (ret) { + dev_err(rtd->dev, "failed to disable %s: %d\n", + pin_name, ret); + return ret; + } + snd_soc_dapm_sync(dapm); + break; + } + } + + return 0; +} + static struct snd_soc_ops kabylake_ssp0_ops = { .hw_params = kabylake_ssp0_hw_params, + .trigger = kabylake_ssp0_trigger, }; static int kabylake_ssp_fixup(struct snd_soc_pcm_runtime *rtd, @@ -956,6 +1008,7 @@ static int kabylake_card_late_probe(struct snd_soc_card *card) { struct kbl_codec_private *ctx = snd_soc_card_get_drvdata(card); struct kbl_hdmi_pcm *pcm; + struct snd_soc_dapm_context *dapm = &card->dapm; struct snd_soc_component *component = NULL; int err, i = 0; char jack_name[NAME_SIZE]; @@ -982,9 +1035,25 @@ static int kabylake_card_late_probe(struct snd_soc_card *card) if (!component) return -EINVAL; - return hdac_hdmi_jack_port_init(component, &card->dapm); - return 0; + err = hdac_hdmi_jack_port_init(component, &card->dapm); + + if (err < 0) + return err; + + err = snd_soc_dapm_disable_pin(dapm, "Left Spk"); + if (err) { + dev_err(card->dev, "failed to disable Left Spk: %d\n", err); + return err; + } + + err = snd_soc_dapm_disable_pin(dapm, "Right Spk"); + if (err) { + dev_err(card->dev, "failed to disable Right Spk: %d\n", err); + return err; + } + + return snd_soc_dapm_sync(dapm); } /* kabylake audio machine driver for SPT + DA7219 */ -- 1.9.1

1 0

[alsa-devel] [asoc:for-5.2 90/97] sound/soc//mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c:325:13: error: 'struct snd_soc_dai_link' has no member named 'platform'; did you mean 'platforms'?
by kbuild test robot 01 Apr '19

01 Apr '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2 head: 35146467bd43704c52d1d5760af9839a10ad5b12 commit: 11c0269017b212fd47c593307d2dc3eb9713b2d0 [90/97] ASoC: Mediatek: MT8183: Add machine driver with TS3A227 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 11c0269017b212fd47c593307d2dc3eb9713b2d0 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All errors (new ones prefixed by >>): sound/soc//mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c: In function 'mt8183_mt6358_ts3a227_max98357_dev_probe': >> sound/soc//mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c:325:13: error: 'struct snd_soc_dai_link' has no member named 'platform'; did you mean 'platforms'? dai_link->platform = NULL; ^~~~~~~~ platforms vim +325 sound/soc//mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c 298 299 static int 300 mt8183_mt6358_ts3a227_max98357_dev_probe(struct platform_device *pdev) 301 { 302 struct snd_soc_card *card = &mt8183_mt6358_ts3a227_max98357_card; 303 struct device_node *platform_node; 304 struct snd_soc_dai_link *dai_link; 305 struct pinctrl *default_pins; 306 int ret, i; 307 308 card->dev = &pdev->dev; 309 310 platform_node = of_parse_phandle(pdev->dev.of_node, 311 "mediatek,platform", 0); 312 if (!platform_node) { 313 dev_err(&pdev->dev, "Property 'platform' missing or invalid\n"); 314 return -EINVAL; 315 } 316 317 for_each_card_prelinks(card, i, dai_link) { 318 /* In the alsa soc-core, the "platform" will be 319 * allocated by devm_kzalloc if null. 320 * There is a special case that registerring 321 * sound card is failed at the first time, but 322 * the "platform" will not null when probe is trying 323 * again. It's not expected normally. 324 */ > 325 dai_link->platform = NULL; 326 327 if (dai_link->platform_name) 328 continue; 329 dai_link->platform_of_node = platform_node; 330 } 331 332 mt8183_mt6358_ts3a227_max98357_headset_dev.codec_of_node = 333 of_parse_phandle(pdev->dev.of_node, 334 "mediatek,headset-codec", 0); 335 if (!mt8183_mt6358_ts3a227_max98357_headset_dev.codec_of_node) { 336 dev_err(&pdev->dev, 337 "Property 'mediatek,headset-codec' missing/invalid\n"); 338 return -EINVAL; 339 } 340 341 ret = devm_snd_soc_register_card(&pdev->dev, card); 342 if (ret) 343 dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n", 344 __func__, ret); 345 346 default_pins = 347 devm_pinctrl_get_select(&pdev->dev, PINCTRL_STATE_DEFAULT); 348 if (IS_ERR(default_pins)) { 349 dev_err(&pdev->dev, "%s set pins failed\n", 350 __func__); 351 return PTR_ERR(default_pins); 352 } 353 354 return ret; 355 } 356 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ALSA: uapi: #include <time.h> in asound.h
by Daniel Mentz 01 Apr '19

01 Apr '19

The uapi header asound.h defines types based on struct timespec. We need to #include <time.h> to get access to the definition of this struct. Previously, we encountered the following error message when building applications with a clang/bionic toolchain: kernel-headers/sound/asound.h:350:19: error: field has incomplete type 'struct timespec' struct timespec trigger_tstamp; ^ The absence of the time.h #include statement does not cause build errors with glibc, because its version of stdlib.h indirectly includes time.h. Signed-off-by: Daniel Mentz <danielmentz(a)google.com> --- include/uapi/sound/asound.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h index 404d4b9ffe76..df1153cea0b7 100644 --- a/include/uapi/sound/asound.h +++ b/include/uapi/sound/asound.h @@ -32,6 +32,7 @@ #ifndef __KERNEL__ #include <stdlib.h> +#include <time.h> #endif /* -- 2.21.0.392.gf8f6787159e-goog

2 1

[alsa-devel] Applied "ASoC: tlv320aic32x4: Fix Common Pins" to the asoc tree
by Mark Brown 01 Apr '19

01 Apr '19

The patch ASoC: tlv320aic32x4: Fix Common Pins has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From c63adb28f6d913310430f14c69f0a2ea55eed0cc Mon Sep 17 00:00:00 2001 From: Annaliese McDermond <nh6z(a)nh6z.net> Date: Sat, 30 Mar 2019 09:02:02 -0700 Subject: [PATCH] ASoC: tlv320aic32x4: Fix Common Pins The common pins were mistakenly not added to the DAPM graph. Adding these pins will allow valid graphs to be created. Signed-off-by: Annaliese McDermond <nh6z(a)nh6z.net> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/tlv320aic32x4.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index 96f1526cb258..5520044929f4 100644 --- a/sound/soc/codecs/tlv320aic32x4.c +++ b/sound/soc/codecs/tlv320aic32x4.c @@ -490,6 +490,8 @@ static const struct snd_soc_dapm_widget aic32x4_dapm_widgets[] = { SND_SOC_DAPM_INPUT("IN2_R"), SND_SOC_DAPM_INPUT("IN3_L"), SND_SOC_DAPM_INPUT("IN3_R"), + SND_SOC_DAPM_INPUT("CM_L"), + SND_SOC_DAPM_INPUT("CM_R"), }; static const struct snd_soc_dapm_route aic32x4_dapm_routes[] = { -- 2.20.1

1 0

[alsa-devel] [PATCH] ASoC: cs42l51: add multi endpoint support
by Olivier Moysan 01 Apr '19

01 Apr '19

Support multiple endpoints on cs42L51 codec port when used in of_graph context. This patch allows to share the codec port between two CPU DAIs. Example: STM32MP157C-DK2 board uses CS42L51 audio codec. This codec is connected to two serial audio interfaces, which are configured either as rx or tx. >From AsoC point of view the topolgy is the following: // 2 CPU DAIs (SAI2A/B), 1 Codec (CS42L51) Playback: CPU-A-DAI(slave) -> (master)CODEC-DAI/port0 Record: CPU-B-DAI(slave) <- (master)CODEC-DAI/port0 In the DT two endpoints have to be associated to the codec port: cs42l51_port: port { cs42l51_tx_endpoint: endpoint@0 { remote-endpoint = <&sai2a_endpoint>; }; cs42l51_rx_endpoint: endpoint@1 { remote-endpoint = <&sai2b_endpoint>; }; }; However, when the audio graph card parses the codec nodes, it expects to find DAI interface indexes matching the endpoints indexes. The current patch forces the use of DAI id 0 for both endpoints, which allows to share the codec DAI between the two CPU DAIs for playback and capture streams respectively. Signed-off-by: Olivier Moysan <olivier.moysan(a)st.com> --- sound/soc/codecs/cs42l51.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/cs42l51.c b/sound/soc/codecs/cs42l51.c index fd2bd74024c1..80da3cd73e04 100644 --- a/sound/soc/codecs/cs42l51.c +++ b/sound/soc/codecs/cs42l51.c @@ -464,6 +464,13 @@ static int cs42l51_dai_mute(struct snd_soc_dai *dai, int mute) return snd_soc_component_write(component, CS42L51_DAC_OUT_CTL, reg); } +static int cs42l51_of_xlate_dai_id(struct snd_soc_component *component, + struct device_node *endpoint) +{ + /* return dai id 0, whatever the endpoint index */ + return 0; +} + static const struct snd_soc_dai_ops cs42l51_dai_ops = { .hw_params = cs42l51_hw_params, .set_sysclk = cs42l51_set_dai_sysclk, @@ -526,6 +533,7 @@ static const struct snd_soc_component_driver soc_component_device_cs42l51 = { .num_dapm_widgets = ARRAY_SIZE(cs42l51_dapm_widgets), .dapm_routes = cs42l51_routes, .num_dapm_routes = ARRAY_SIZE(cs42l51_routes), + .of_xlate_dai_id = cs42l51_of_xlate_dai_id, .idle_bias_on = 1, .use_pmdown_time = 1, .endianness = 1, -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: rt5677-spi: Add ACPI ID
by Oder Chiou 01 Apr '19

01 Apr '19

Add the ACPI ID for the product "chromebook pixel 2015" to match the coreboot settings. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/codecs/rt5677-spi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c index 84501c2020c7..167a02773a0b 100644 --- a/sound/soc/codecs/rt5677-spi.c +++ b/sound/soc/codecs/rt5677-spi.c @@ -25,6 +25,7 @@ #include <linux/sysfs.h> #include <linux/clk.h> #include <linux/firmware.h> +#include <linux/acpi.h> #include "rt5677-spi.h" @@ -226,9 +227,16 @@ static int rt5677_spi_probe(struct spi_device *spi) return 0; } +static const struct acpi_device_id rt5677_spi_acpi_id[] = { + { "RT5677AA", 0 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, rt5677_spi_acpi_id); + static struct spi_driver rt5677_spi_driver = { .driver = { .name = "rt5677", + .acpi_match_table = ACPI_PTR(rt5677_spi_acpi_id), }, .probe = rt5677_spi_probe, }; -- 2.21.0

2 1

[alsa-devel] [PATCH 0/4] ASoC: Mediatek: MT8183: Add support for machine driver with DA7219 or TS3A227
by Shunli Wang 01 Apr '19

01 Apr '19

ASoC: Mediatek: MT8183: Add support for machine driver with DA7219 or TS3A227 Shunli Wang (4): ASoC: Mediatek: MT8183: Add machine driver with TS3A227 ASoC: Mediatek: Add document for mt8183-mt6358-ts3a227-max98357 ASoC: Mediatek: MT8183: Add machine driver with DA7219 ASoC: Mediatek: Add document for mt8183-da7219-max98357 .../bindings/sound/mt8183-da7219-max98357.txt | 15 + .../sound/mt8183-mt6358-ts3a227-max98357.txt | 15 + sound/soc/mediatek/Kconfig | 26 ++ sound/soc/mediatek/mt8183/Makefile | 2 + sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 472 +++++++++++++++++++++ .../mt8183/mt8183-mt6358-ts3a227-max98357.c | 382 +++++++++++++++++ 6 files changed, 912 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mt8183-da7219-max98357.txt create mode 100644 Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt create mode 100644 sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c create mode 100644 sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c -- 1.9.1

2 8