April 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] soundwire: fix pm_runtime_get_sync return code checks
by Jan Kotas 14 Apr '19

14 Apr '19

When PM is disabled it returns -EACCES, which is currently threated as an error, and prevents accessing the slave's registers. This patch ignores the -EACCES return value from pm_runtime_get_sync() to let the SoundWire work in systems without runtime PM. Signed-off-by: Jan Kotas <jank(a)cadence.com> --- drivers/soundwire/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 1cbfedfc2..6567ff439 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -328,7 +328,7 @@ int sdw_nread(struct sdw_slave *slave, u32 addr, size_t count, u8 *val) return ret; ret = pm_runtime_get_sync(slave->bus->dev); - if (ret < 0) + if (ret < 0 && ret != -EACCES) return ret; ret = sdw_transfer(slave->bus, &msg); @@ -356,7 +356,7 @@ int sdw_nwrite(struct sdw_slave *slave, u32 addr, size_t count, u8 *val) return ret; ret = pm_runtime_get_sync(slave->bus->dev); - if (ret < 0) + if (ret < 0 && ret != -EACCES) return ret; ret = sdw_transfer(slave->bus, &msg); -- 2.15.0

3 5

[alsa-devel] [PATCH] ALSA: hda: Initialize ext-bus-specific fields in snd_hdac_bus_init(), too
by Takashi Iwai 13 Apr '19

13 Apr '19

Some fields in snd_hdac_bus are ext-bus specific, but they still should be initialized in snd_hdac_bus_init() for consistency, at least, for the ones that do need the explicit initialization like the list head. Also move the lock field to the more appropriate place and correct the comment to reflect the recent change where it serves for both the display power and the link management. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- include/sound/hdaudio.h | 7 +++---- sound/hda/ext/hdac_ext_bus.c | 2 -- sound/hda/hdac_bus.c | 1 + 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h index 45f944d57982..ca1d9a70d026 100644 --- a/include/sound/hdaudio.h +++ b/include/sound/hdaudio.h @@ -297,7 +297,7 @@ struct hdac_rb { * @num_streams: streams supported * @idx: HDA link index * @hlink_list: link list of HDA links - * @lock: lock for link mgmt + * @lock: lock for link and display power mgmt * @cmd_dma_state: state of cmd DMAs: CORB and RIRB */ struct hdac_bus { @@ -363,6 +363,7 @@ struct hdac_bus { /* locks */ spinlock_t reg_lock; struct mutex cmd_mutex; + struct mutex lock; /* DRM component interface */ struct drm_audio_component *audio_component; @@ -373,11 +374,9 @@ struct hdac_bus { int num_streams; int idx; + /* link management */ struct list_head hlink_list; - - struct mutex lock; bool cmd_dma_state; - }; int snd_hdac_bus_init(struct hdac_bus *bus, struct device *dev, diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c index ec7715c6b0c0..c203af71a099 100644 --- a/sound/hda/ext/hdac_ext_bus.c +++ b/sound/hda/ext/hdac_ext_bus.c @@ -104,9 +104,7 @@ int snd_hdac_ext_bus_init(struct hdac_bus *bus, struct device *dev, return ret; bus->ext_ops = ext_ops; - INIT_LIST_HEAD(&bus->hlink_list); bus->idx = idx++; - bus->cmd_dma_state = true; return 0; diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c index ad8eee08013f..10e5d261fde1 100644 --- a/sound/hda/hdac_bus.c +++ b/sound/hda/hdac_bus.c @@ -39,6 +39,7 @@ int snd_hdac_bus_init(struct hdac_bus *bus, struct device *dev, spin_lock_init(&bus->reg_lock); mutex_init(&bus->cmd_mutex); mutex_init(&bus->lock); + INIT_LIST_HEAD(&bus->hlink_list); bus->irq = -1; return 0; } -- 2.16.4

1 0

[alsa-devel] [PATCH] ALSA: hda: Initialize power_state field properly
by Takashi Iwai 13 Apr '19

13 Apr '19

The recent commit 98081ca62cba ("ALSA: hda - Record the current power state before suspend/resume calls") made the HD-audio driver to store the PM state in power_state field. This forgot, however, the initialization at power up. Although the codec drivers usually don't need to refer to this field in the normal operation, let's initialize it properly for consistency. Fixes: 98081ca62cba ("ALSA: hda - Record the current power state before suspend/resume calls") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_codec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index ec0b8595eb4d..701a69d856f5 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -969,6 +969,7 @@ int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card, /* power-up all before initialization */ hda_set_power_state(codec, AC_PWRST_D0); + codec->core.dev.power.power_state = PMSG_ON; snd_hda_codec_proc_new(codec); -- 2.16.4

1 0

[alsa-devel] [PATCH] ASoC: codec: hdac_hdmi add device_link to card device
by libin.yang＠intel.com 13 Apr '19

13 Apr '19

From: Libin Yang <libin.yang(a)intel.com> In resume from S3, HDAC HDMI codec driver dapm event callback may be operated before HDMI codec driver turns on the display audio power domain because of the contest between display driver and hdmi codec driver. This patch adds the device_link between soc card device (consumer) and hdmi codec device (supplier) to make sure the sequence is always correct. Signed-off-by: Libin Yang <libin.yang(a)intel.com> --- sound/soc/codecs/hdac_hdmi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 5eeb0fe..8bb883e 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -1855,6 +1855,15 @@ static int hdmi_codec_probe(struct snd_soc_component *component) hdmi->card = dapm->card->snd_card; /* + * Setup a device_link between card device and HDMI codec device. + * The card device is the consumer and the HDMI codec device is + * the supplier. With this setting, we can make sure that the audio + * domain in display power will be always turned on before operating + * on the HDMI audio codec registers. + */ + device_link_add(component->card->dev, &hdev->dev, DL_FLAG_RPM_ACTIVE | + DL_FLAG_AUTOREMOVE_CONSUMER); + /* * hdac_device core already sets the state to active and calls * get_noresume. So enable runtime and set the device to suspend. */ -- 2.7.4

4 8

[alsa-devel] [asoc:for-next 251/253] sound/soc//intel/boards/bxt_da7219_max98357a.c:19:10: fatal error: asm/cpu_device_id.h: No such file or directory
by kbuild test robot 12 Apr '19

12 Apr '19

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next head: 3e683b839e7a2c4588874499fb033588082cde4e commit: 89a7bfa3ede49fb3c38bfe6854a391553ff9132c [251/253] ASoC: Intel: Make boards more available for compile test config: ia64-allyesconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 89a7bfa3ede49fb3c38bfe6854a391553ff9132c # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=ia64 All error/warnings (new ones prefixed by >>): >> sound/soc//intel/boards/bxt_da7219_max98357a.c:19:10: fatal error: asm/cpu_device_id.h: No such file or directory #include <asm/cpu_device_id.h> ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. -- >> sound/soc//intel/skylake/skl-ssp-clk.c:26:16: error: field 'hw' has incomplete type struct clk_hw hw; ^~ In file included from include/linux/kernel.h:11, from sound/soc//intel/skylake/skl-ssp-clk.c:8: sound/soc//intel/skylake/skl-ssp-clk.c: In function 'skl_clk_prepare': >> include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type 'struct clk_hw' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~~~ include/linux/compiler.h:324:9: note: in definition of macro '__compiletime_assert' if (!(condition)) \ ^~~~~~~~~ include/linux/compiler.h:344:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:979:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~~~~~~~~~~~~~ include/linux/kernel.h:979:20: note: in expansion of macro '__same_type' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:18:25: note: in expansion of macro 'container_of' #define to_skl_clk(_hw) container_of(_hw, struct skl_clk, hw) ^~~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:201:27: note: in expansion of macro 'to_skl_clk' struct skl_clk *clkdev = to_skl_clk(hw); ^~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c: At top level: >> sound/soc//intel/skylake/skl-ssp-clk.c:260:21: error: variable 'skl_clk_ops' has initializer but incomplete type static const struct clk_ops skl_clk_ops = { ^~~~~~~ >> sound/soc//intel/skylake/skl-ssp-clk.c:261:3: error: 'const struct clk_ops' has no member named 'prepare' .prepare = skl_clk_prepare, ^~~~~~~ >> sound/soc//intel/skylake/skl-ssp-clk.c:261:13: warning: excess elements in struct initializer .prepare = skl_clk_prepare, ^~~~~~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:261:13: note: (near initialization for 'skl_clk_ops') >> sound/soc//intel/skylake/skl-ssp-clk.c:262:3: error: 'const struct clk_ops' has no member named 'unprepare' .unprepare = skl_clk_unprepare, ^~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:262:15: warning: excess elements in struct initializer .unprepare = skl_clk_unprepare, ^~~~~~~~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:262:15: note: (near initialization for 'skl_clk_ops') >> sound/soc//intel/skylake/skl-ssp-clk.c:263:3: error: 'const struct clk_ops' has no member named 'set_rate' .set_rate = skl_clk_set_rate, ^~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:263:14: warning: excess elements in struct initializer .set_rate = skl_clk_set_rate, ^~~~~~~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:263:14: note: (near initialization for 'skl_clk_ops') >> sound/soc//intel/skylake/skl-ssp-clk.c:264:3: error: 'const struct clk_ops' has no member named 'round_rate' .round_rate = skl_clk_round_rate, ^~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:264:16: warning: excess elements in struct initializer .round_rate = skl_clk_round_rate, ^~~~~~~~~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:264:16: note: (near initialization for 'skl_clk_ops') >> sound/soc//intel/skylake/skl-ssp-clk.c:265:3: error: 'const struct clk_ops' has no member named 'recalc_rate' .recalc_rate = skl_clk_recalc_rate, ^~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:265:17: warning: excess elements in struct initializer .recalc_rate = skl_clk_recalc_rate, ^~~~~~~~~~~~~~~~~~~ sound/soc//intel/skylake/skl-ssp-clk.c:265:17: note: (near initialization for 'skl_clk_ops') sound/soc//intel/skylake/skl-ssp-clk.c: In function 'unregister_parent_src_clk': >> sound/soc//intel/skylake/skl-ssp-clk.c:273:3: error: implicit declaration of function 'clk_hw_unregister_fixed_rate'; did you mean 'clk_hw_register_clkdev'? [-Werror=implicit-function-declaration] clk_hw_unregister_fixed_rate(pclk[id].hw); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ clk_hw_register_clkdev sound/soc//intel/skylake/skl-ssp-clk.c: In function 'skl_register_parent_clks': >> sound/soc//intel/skylake/skl-ssp-clk.c:294:18: error: implicit declaration of function 'clk_hw_register_fixed_rate'; did you mean 'clk_hw_register_clkdev'? [-Werror=implicit-function-declaration] parent[i].hw = clk_hw_register_fixed_rate(dev, pclk[i].name, ^~~~~~~~~~~~~~~~~~~~~~~~~~ clk_hw_register_clkdev >> sound/soc//intel/skylake/skl-ssp-clk.c:294:16: warning: assignment to 'struct clk_hw *' from 'int' makes pointer from integer without a cast [-Wint-conversion] parent[i].hw = clk_hw_register_fixed_rate(dev, pclk[i].name, ^ sound/soc//intel/skylake/skl-ssp-clk.c: In function 'register_skl_clk': >> sound/soc//intel/skylake/skl-ssp-clk.c:321:23: error: storage size of 'init' isn't known struct clk_init_data init; ^~~~ >> sound/soc//intel/skylake/skl-ssp-clk.c:331:15: error: 'CLK_SET_RATE_GATE' undeclared (first use in this function); did you mean 'DL_STATE_NONE'? init.flags = CLK_SET_RATE_GATE; ^~~~~~~~~~~~~~~~~ DL_STATE_NONE sound/soc//intel/skylake/skl-ssp-clk.c:331:15: note: each undeclared identifier is reported only once for each function it appears in >> sound/soc//intel/skylake/skl-ssp-clk.c:338:8: error: implicit declaration of function 'devm_clk_hw_register'; did you mean 'devm_clk_hw_register_clkdev'? [-Werror=implicit-function-declaration] ret = devm_clk_hw_register(dev, &clkdev->hw); ^~~~~~~~~~~~~~~~~~~~ devm_clk_hw_register_clkdev sound/soc//intel/skylake/skl-ssp-clk.c:321:23: warning: unused variable 'init' [-Wunused-variable] struct clk_init_data init; ^~~~ sound/soc//intel/skylake/skl-ssp-clk.c: At top level: >> sound/soc//intel/skylake/skl-ssp-clk.c:260:29: error: storage size of 'skl_clk_ops' isn't known static const struct clk_ops skl_clk_ops = { ^~~~~~~~~~~ cc1: some warnings being treated as errors -- sound/soc/intel/skylake/skl-ssp-clk.c:26:16: error: field 'hw' has incomplete type struct clk_hw hw; ^~ In file included from include/linux/kernel.h:11, from sound/soc/intel/skylake/skl-ssp-clk.c:8: sound/soc/intel/skylake/skl-ssp-clk.c: In function 'skl_clk_prepare': >> include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type 'struct clk_hw' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~~~ include/linux/compiler.h:324:9: note: in definition of macro '__compiletime_assert' if (!(condition)) \ ^~~~~~~~~ include/linux/compiler.h:344:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:979:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~~~~~~~~~~~~~ include/linux/kernel.h:979:20: note: in expansion of macro '__same_type' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:18:25: note: in expansion of macro 'container_of' #define to_skl_clk(_hw) container_of(_hw, struct skl_clk, hw) ^~~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:201:27: note: in expansion of macro 'to_skl_clk' struct skl_clk *clkdev = to_skl_clk(hw); ^~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c: At top level: sound/soc/intel/skylake/skl-ssp-clk.c:260:21: error: variable 'skl_clk_ops' has initializer but incomplete type static const struct clk_ops skl_clk_ops = { ^~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:261:3: error: 'const struct clk_ops' has no member named 'prepare' .prepare = skl_clk_prepare, ^~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:261:13: warning: excess elements in struct initializer .prepare = skl_clk_prepare, ^~~~~~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:261:13: note: (near initialization for 'skl_clk_ops') sound/soc/intel/skylake/skl-ssp-clk.c:262:3: error: 'const struct clk_ops' has no member named 'unprepare' .unprepare = skl_clk_unprepare, ^~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:262:15: warning: excess elements in struct initializer .unprepare = skl_clk_unprepare, ^~~~~~~~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:262:15: note: (near initialization for 'skl_clk_ops') sound/soc/intel/skylake/skl-ssp-clk.c:263:3: error: 'const struct clk_ops' has no member named 'set_rate' .set_rate = skl_clk_set_rate, ^~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:263:14: warning: excess elements in struct initializer .set_rate = skl_clk_set_rate, ^~~~~~~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:263:14: note: (near initialization for 'skl_clk_ops') sound/soc/intel/skylake/skl-ssp-clk.c:264:3: error: 'const struct clk_ops' has no member named 'round_rate' .round_rate = skl_clk_round_rate, ^~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:264:16: warning: excess elements in struct initializer .round_rate = skl_clk_round_rate, ^~~~~~~~~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:264:16: note: (near initialization for 'skl_clk_ops') sound/soc/intel/skylake/skl-ssp-clk.c:265:3: error: 'const struct clk_ops' has no member named 'recalc_rate' .recalc_rate = skl_clk_recalc_rate, ^~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:265:17: warning: excess elements in struct initializer .recalc_rate = skl_clk_recalc_rate, ^~~~~~~~~~~~~~~~~~~ sound/soc/intel/skylake/skl-ssp-clk.c:265:17: note: (near initialization for 'skl_clk_ops') sound/soc/intel/skylake/skl-ssp-clk.c: In function 'unregister_parent_src_clk': sound/soc/intel/skylake/skl-ssp-clk.c:273:3: error: implicit declaration of function 'clk_hw_unregister_fixed_rate'; did you mean 'clk_hw_register_clkdev'? [-Werror=implicit-function-declaration] clk_hw_unregister_fixed_rate(pclk[id].hw); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ clk_hw_register_clkdev sound/soc/intel/skylake/skl-ssp-clk.c: In function 'skl_register_parent_clks': sound/soc/intel/skylake/skl-ssp-clk.c:294:18: error: implicit declaration of function 'clk_hw_register_fixed_rate'; did you mean 'clk_hw_register_clkdev'? [-Werror=implicit-function-declaration] parent[i].hw = clk_hw_register_fixed_rate(dev, pclk[i].name, ^~~~~~~~~~~~~~~~~~~~~~~~~~ clk_hw_register_clkdev sound/soc/intel/skylake/skl-ssp-clk.c:294:16: warning: assignment to 'struct clk_hw *' from 'int' makes pointer from integer without a cast [-Wint-conversion] parent[i].hw = clk_hw_register_fixed_rate(dev, pclk[i].name, ^ sound/soc/intel/skylake/skl-ssp-clk.c: In function 'register_skl_clk': sound/soc/intel/skylake/skl-ssp-clk.c:321:23: error: storage size of 'init' isn't known struct clk_init_data init; ^~~~ sound/soc/intel/skylake/skl-ssp-clk.c:331:15: error: 'CLK_SET_RATE_GATE' undeclared (first use in this function); did you mean 'DL_STATE_NONE'? init.flags = CLK_SET_RATE_GATE; ^~~~~~~~~~~~~~~~~ DL_STATE_NONE sound/soc/intel/skylake/skl-ssp-clk.c:331:15: note: each undeclared identifier is reported only once for each function it appears in sound/soc/intel/skylake/skl-ssp-clk.c:338:8: error: implicit declaration of function 'devm_clk_hw_register'; did you mean 'devm_clk_hw_register_clkdev'? [-Werror=implicit-function-declaration] ret = devm_clk_hw_register(dev, &clkdev->hw); ^~~~~~~~~~~~~~~~~~~~ devm_clk_hw_register_clkdev sound/soc/intel/skylake/skl-ssp-clk.c:321:23: warning: unused variable 'init' [-Wunused-variable] struct clk_init_data init; ^~~~ sound/soc/intel/skylake/skl-ssp-clk.c: At top level: sound/soc/intel/skylake/skl-ssp-clk.c:260:29: error: storage size of 'skl_clk_ops' isn't known static const struct clk_ops skl_clk_ops = { ^~~~~~~~~~~ cc1: some warnings being treated as errors vim +19 sound/soc//intel/boards/bxt_da7219_max98357a.c c011245a Yong Zhi 2019-02-13 @19 #include <asm/cpu_device_id.h> 9dd9b210 Yong Zhi 2019-02-13 20 #include <linux/input.h> 723bad3f Sathyanarayana Nujella 2016-05-31 21 #include <linux/module.h> 723bad3f Sathyanarayana Nujella 2016-05-31 22 #include <linux/platform_device.h> 723bad3f Sathyanarayana Nujella 2016-05-31 23 #include <sound/core.h> 723bad3f Sathyanarayana Nujella 2016-05-31 24 #include <sound/jack.h> 723bad3f Sathyanarayana Nujella 2016-05-31 25 #include <sound/pcm.h> 723bad3f Sathyanarayana Nujella 2016-05-31 26 #include <sound/pcm_params.h> 723bad3f Sathyanarayana Nujella 2016-05-31 27 #include <sound/soc.h> 7ebf2528 Pierre-Louis Bossart 2019-01-25 28 #include <sound/soc-acpi.h> 723bad3f Sathyanarayana Nujella 2016-05-31 29 #include "../../codecs/hdac_hdmi.h" 723bad3f Sathyanarayana Nujella 2016-05-31 30 #include "../../codecs/da7219.h" 723bad3f Sathyanarayana Nujella 2016-05-31 31 #include "../../codecs/da7219-aad.h" 723bad3f Sathyanarayana Nujella 2016-05-31 32 :::::: The code at line 19 was first introduced by commit :::::: c011245a197017f8e9e9d140b658bdb2b702a0c5 ASoC: Intel: Add Geminilake Dialog Maxim machine driver :::::: TO: Yong Zhi <yong.zhi(a)intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] WARNING: proc registration bug in snd_info_card_register
by syzbot 12 Apr '19

12 Apr '19

Hello, syzbot found the following crash on: HEAD commit: 9a33b369 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan/tree/usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1738acd3200000 kernel config: https://syzkaller.appspot.com/x/.config?x=23e37f59d94ddd15 dashboard link: https://syzkaller.appspot.com/bug?extid=2e782bf6a60d0fcb932d compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=140ef0f3200000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=102c7c2d200000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+2e782bf6a60d0fcb932d(a)syzkaller.appspotmail.com usb 1-1: send failed (error -71) usb 6-1: send failed (error -71) usb 5-1: USB disconnect, device number 3 ------------[ cut here ]------------ proc_dir_entry 'asound/PODStudioUX2' already registered WARNING: CPU: 1 PID: 534 at fs/proc/generic.c:359 proc_register+0x3d9/0x550 fs/proc/generic.c:359 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 534 Comm: kworker/1:2 Not tainted 5.1.0-rc4-319354-g9a33b36 #3 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xe8/0x16e lib/dump_stack.c:113 panic+0x29d/0x5f2 kernel/panic.c:214 __warn.cold+0x20/0x48 kernel/panic.c:571 report_bug+0x262/0x2a0 lib/bug.c:186 fixup_bug arch/x86/kernel/traps.c:179 [inline] fixup_bug arch/x86/kernel/traps.c:174 [inline] do_error_trap+0x130/0x1f0 arch/x86/kernel/traps.c:272 do_invalid_op+0x37/0x40 arch/x86/kernel/traps.c:291 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:973 RIP: 0010:proc_register+0x3d9/0x550 fs/proc/generic.c:359 Code: ff df 48 89 f9 48 c1 e9 03 80 3c 01 00 0f 85 61 01 00 00 48 8b 04 24 48 c7 c7 e0 a0 79 8e 48 8b b0 d0 00 00 00 e8 a7 9e 71 ff <0f> 0b 48 c7 c7 a0 90 91 91 e8 b9 10 34 0c 48 8b 4c 24 28 48 b8 00 RSP: 0018:ffff88809fb9f000 EFLAGS: 00010282 RAX: 0000000000000000 RBX: ffff88809d2df840 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff815b1e42 RDI: ffffed1013f73df2 RBP: ffff888096382a00 R08: ffff88809f9cc980 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: dffffc0000000000 R14: ffff8880a594cd38 R15: 000000000000000c proc_symlink+0x147/0x1c0 fs/proc/generic.c:451 snd_info_card_register+0x14b/0x1e0 sound/core/info.c:558 snd_card_register sound/core/init.c:772 [inline] snd_card_register+0x432/0x5f0 sound/core/init.c:736 toneport_init sound/usb/line6/toneport.c:457 [inline] toneport_init+0x256/0x63c sound/usb/line6/toneport.c:412 line6_probe+0xb01/0x1150 sound/usb/line6/driver.c:784 usb_probe_interface+0x31d/0x820 drivers/usb/core/driver.c:361 really_probe+0x2da/0xb10 drivers/base/dd.c:509 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 __device_attach+0x223/0x3a0 drivers/base/dd.c:844 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 device_add+0xad2/0x16e0 drivers/base/core.c:2106 usb_set_configuration+0xdf7/0x1740 drivers/usb/core/message.c:2021 generic_probe+0xa2/0xda drivers/usb/core/generic.c:210 usb_probe_device+0xc0/0x150 drivers/usb/core/driver.c:266 really_probe+0x2da/0xb10 drivers/base/dd.c:509 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 __device_attach+0x223/0x3a0 drivers/base/dd.c:844 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 device_add+0xad2/0x16e0 drivers/base/core.c:2106 usb_new_device.cold+0x537/0xccf drivers/usb/core/hub.c:2534 hub_port_connect drivers/usb/core/hub.c:5089 [inline] hub_port_connect_change drivers/usb/core/hub.c:5204 [inline] port_event drivers/usb/core/hub.c:5350 [inline] hub_event+0x138e/0x3b00 drivers/usb/core/hub.c:5432 process_one_work+0x90f/0x1580 kernel/workqueue.c:2269 process_scheduled_works kernel/workqueue.c:2331 [inline] worker_thread+0x7b0/0xe20 kernel/workqueue.c:2417 kthread+0x313/0x420 kernel/kthread.c:253 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352 Kernel Offset: disabled Rebooting in 86400 seconds.. --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

1 0

[alsa-devel] [PATCH v3 00/12] ASoC: intel: add device_link to HDMI audio
by libin.yang＠intel.com 12 Apr '19

12 Apr '19

From: Libin Yang <libin.yang(a)intel.com> This patchset add the device_link between the machine devices of intel boards and HDMI audio codec. This can make sure that display audio power domain is always turned on before operating on the HDMI audio codecs. Libin Yang (12): ASoC: intel: skl_hda_dsp_generic: add device_link to HDMI audio ASoC: intel: boards: define some general functions for hdac_hdmi ASoC: intel: bxt_da7219_max98357a: add device_link to HDMI audio ASoC: intel: bxt_rt298: add device_link to HDMI audio ASoC: intel: glk_rt5682_max98357a: add device_link to HDMI audio ASoC: intel: kbl_da7219_max98357a: add device_link to HDMI audio ASoC: intel: kbl_da7219_max98927: add device_link to HDMI audio ASoC: intel: kbl_rt5660: add device_link to HDMI audio ASoC: intel: kbl_rt5663_max98927 add device_link to HDMI audio ASoC: intel: kbl_rt5663_rt5514_max98927 add device_link to HDMI audio ASoC: intel: skl_nau88l25_max98357a add device_link to HDMI audio ASoC: intel: skl_nau88l25_ssm4567 add device_link to HDMI audio sound/soc/intel/boards/bxt_da7219_max98357a.c | 14 +++++++ sound/soc/intel/boards/bxt_rt298.c | 14 ++++++- sound/soc/intel/boards/glk_rt5682_max98357a.c | 14 +++++++ sound/soc/intel/boards/hdac_hdmi_common.h | 46 ++++++++++++++++++++++ sound/soc/intel/boards/kbl_da7219_max98357a.c | 14 +++++++ sound/soc/intel/boards/kbl_da7219_max98927.c | 14 +++++++ sound/soc/intel/boards/kbl_rt5660.c | 14 ++++++- sound/soc/intel/boards/kbl_rt5663_max98927.c | 14 ++++++- .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 14 ++++++- sound/soc/intel/boards/skl_hda_dsp_common.c | 22 +++++++++++ sound/soc/intel/boards/skl_hda_dsp_common.h | 1 + sound/soc/intel/boards/skl_hda_dsp_generic.c | 12 ++++++ sound/soc/intel/boards/skl_nau88l25_max98357a.c | 36 ++++++++++++++++- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 36 ++++++++++++++++- 14 files changed, 259 insertions(+), 6 deletions(-) create mode 100644 sound/soc/intel/boards/hdac_hdmi_common.h -- 2.7.4

3 14

[alsa-devel] [PATCH V2 0/2] Support more sample rate in asrc
by S.j. Wang 11 Apr '19

11 Apr '19

Support more sample rate in asrc Shengjiu Wang (2): ASoC: fsl_asrc: replace the process_option table with function ASoC: fsl_asrc: Unify the supported input and output rate Changes in v2 - add more comments in code - add commit "Unify the supported input and output rate" sound/soc/fsl/fsl_asrc.c | 116 ++++++++++++++++++++++++++++++++++------------- 1 file changed, 85 insertions(+), 31 deletions(-) -- 1.9.1

3 5

[alsa-devel] INFO: task hung in snd_seq_kernel_client_ctl
by syzbot 11 Apr '19

11 Apr '19

Hello, syzbot found the following crash on: HEAD commit: 2f4c4d83 Add linux-next specific files for 20190411 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1261f42d200000 kernel config: https://syzkaller.appspot.com/x/.config?x=bfc6a0294e6babef dashboard link: https://syzkaller.appspot.com/bug?extid=47ded6c0f23016cde310 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=130cecb7200000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13c0efab200000 The bug was bisected to: commit feb689025fbb6f0aa6297d3ddf97de945ea4ad32 Author: Takashi Iwai <tiwai(a)suse.de> Date: Tue Apr 9 15:35:22 2019 +0000 ALSA: seq: Protect in-kernel ioctl calls with mutex bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=178552b7200000 final crash: https://syzkaller.appspot.com/x/report.txt?x=144552b7200000 console output: https://syzkaller.appspot.com/x/log.txt?x=104552b7200000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+47ded6c0f23016cde310(a)syzkaller.appspotmail.com Fixes: feb689025fbb ("ALSA: seq: Protect in-kernel ioctl calls with mutex") INFO: task syz-executor971:9265 blocked for more than 143 seconds. Not tainted 5.1.0-rc4-next-20190411 #23 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor971 D28264 9265 9263 0x80000002 Call Trace: context_switch kernel/sched/core.c:2877 [inline] __schedule+0x817/0x1cc0 kernel/sched/core.c:3518 schedule+0x92/0x180 kernel/sched/core.c:3562 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:3620 __mutex_lock_common kernel/locking/mutex.c:1002 [inline] __mutex_lock+0x726/0x1310 kernel/locking/mutex.c:1072 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1087 snd_seq_kernel_client_ctl+0xe5/0x170 sound/core/seq/seq_clientmgr.c:2345 snd_seq_oss_control sound/core/seq/oss/seq_oss_device.h:157 [inline] snd_seq_oss_writeq_clear+0xe0/0x140 sound/core/seq/oss/seq_oss_writeq.c:85 snd_seq_oss_writeq_delete+0x20/0x40 sound/core/seq/oss/seq_oss_writeq.c:69 free_devinfo+0x66/0xc0 sound/core/seq/oss/seq_oss_init.c:406 port_delete+0xe8/0x1c0 sound/core/seq/seq_ports.c:272 snd_seq_delete_port+0x266/0x330 sound/core/seq/seq_ports.c:301 snd_seq_ioctl_delete_port+0xba/0x190 sound/core/seq/seq_clientmgr.c:1321 snd_seq_kernel_client_ctl+0x112/0x170 sound/core/seq/seq_clientmgr.c:2346 snd_seq_event_port_detach+0xba/0x100 sound/core/seq/seq_ports.c:705 delete_port+0x87/0xd0 sound/core/seq/oss/seq_oss_init.c:354 snd_seq_oss_release+0xf5/0x150 sound/core/seq/oss/seq_oss_init.c:433 odev_release+0x54/0x80 sound/core/seq/oss/seq_oss.c:153 __fput+0x2e5/0x8d0 fs/file_table.c:278 ____fput+0x16/0x20 fs/file_table.c:309 task_work_run+0x14a/0x1c0 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0x90a/0x2fa0 kernel/exit.c:876 do_group_exit+0x135/0x370 kernel/exit.c:980 __do_sys_exit_group kernel/exit.c:991 [inline] __se_sys_exit_group kernel/exit.c:989 [inline] __x64_sys_exit_group+0x44/0x50 kernel/exit.c:989 do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x43ed98 Code: Bad RIP value. RSP: 002b:00007fff4f4de2a8 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000000000043ed98 RDX: 0000000000000000 RSI: 000000000000003c RDI: 0000000000000000 RBP: 00000000004be5a8 R08: 00000000000000e7 R09: ffffffffffffffd0 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001 R13: 00000000006d0180 R14: 0000000000000000 R15: 0000000000000000 INFO: lockdep is turned off. NMI backtrace for cpu 1 CPU: 1 PID: 1038 Comm: khungtaskd Not tainted 5.1.0-rc4-next-20190411 #23 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 lib/dump_stack.c:113 nmi_cpu_backtrace.cold+0x63/0xa4 lib/nmi_backtrace.c:101 nmi_trigger_cpumask_backtrace+0x1be/0x236 lib/nmi_backtrace.c:62 arch_trigger_cpumask_backtrace+0x14/0x20 arch/x86/kernel/apic/hw_nmi.c:38 trigger_all_cpu_backtrace include/linux/nmi.h:146 [inline] check_hung_uninterruptible_tasks kernel/hung_task.c:204 [inline] watchdog+0x9b7/0xec0 kernel/hung_task.c:288 kthread+0x357/0x430 kernel/kthread.c:254 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352 Sending NMI from CPU 1 to CPUs 0: --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

1 0

[alsa-devel] [PATCH v2 00/12] ASoC: intel: add device_link to HDMI audio
by libin.yang＠intel.com 11 Apr '19

11 Apr '19

From: Libin Yang <libin.yang(a)intel.com> This patchset add the device_link between the machine devices of intel boards and HDMI audio codec. This can make sure that display audio power domain is always turned on before operating on the HDMI audio codecs. Libin Yang (12): ASoC: intel: skl_hda_dsp_generic: add device_link to HDMI audio ASoC: intel: boards: define some general functions for hdac_hdmi ASoC: intel: bxt_da7219_max98357a: add device_link to HDMI audio ASoC: intel: bxt_rt298: add device_link to HDMI audio ASoC: intel: glk_rt5682_max98357a: add device_link to HDMI audio ASoC: intel: kbl_da7219_max98357a: add device_link to HDMI audio ASoC: intel: kbl_da7219_max98927: add device_link to HDMI audio ASoC: intel: kbl_rt5660: add device_link to HDMI audio ASoC: intel: kbl_rt5663_max98927 add device_link to HDMI audio ASoC: intel: kbl_rt5663_rt5514_max98927 add device_link to HDMI audio ASoC: intel: skl_nau88l25_max98357a add device_link to HDMI audio ASoC: intel: skl_nau88l25_ssm4567 add device_link to HDMI audio sound/soc/intel/boards/bxt_da7219_max98357a.c | 14 +++++++ sound/soc/intel/boards/bxt_rt298.c | 14 ++++++- sound/soc/intel/boards/glk_rt5682_max98357a.c | 14 +++++++ sound/soc/intel/boards/hdac_hdmi_common.h | 46 ++++++++++++++++++++++ sound/soc/intel/boards/kbl_da7219_max98357a.c | 14 +++++++ sound/soc/intel/boards/kbl_da7219_max98927.c | 14 +++++++ sound/soc/intel/boards/kbl_rt5660.c | 14 ++++++- sound/soc/intel/boards/kbl_rt5663_max98927.c | 14 ++++++- .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 14 ++++++- sound/soc/intel/boards/skl_hda_dsp_common.c | 22 +++++++++++ sound/soc/intel/boards/skl_hda_dsp_common.h | 1 + sound/soc/intel/boards/skl_hda_dsp_generic.c | 12 ++++++ sound/soc/intel/boards/skl_nau88l25_max98357a.c | 36 ++++++++++++++++- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 36 ++++++++++++++++- 14 files changed, 259 insertions(+), 6 deletions(-) create mode 100644 sound/soc/intel/boards/hdac_hdmi_common.h -- 2.7.4

1 12