April 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] snd_hdac_device_unregister is called twice on ASoC driver
by Liao, Bard 28 Apr '19

28 Apr '19

Hi Takashi and all, We meet a problem that snd_hdac_device_unregister will be called twice on ASoC driver. We will call snd_hdac_ext_bus_device_init -> snd_hdac_device_register and snd_hdac_ext_bus_device_remove -> snd_hdac_device_unregister on ASoC driver. It looks even to me. However, hdac_hda_codec_probe will call snd_hda_codec_device_new to create a hda codec device. And it will assign snd_hda_codec_dev_free to the .dev_free ops where snd_hdac_device_unregister will be called. That's why snd_hdac_device_unregister will be call twice on ASoC driver. Below patch can "fix" this issue, but I don't know if it is the right way to fix it. Could you take a look and give me some advice? --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -841,7 +841,13 @@ static int snd_hda_codec_dev_free(struct snd_device *device) struct hda_codec *codec = device->device_data; codec->in_freeing = 1; - snd_hdac_device_unregister(&codec->core); + /* + * snd_hda_codec_device_new() is used by legacy HDA and ASoC driver. + * We can't unregister ASoC device since it will be unregistered in + * snd_hdac_ext_bus_device_remove(). + */ + if (codec->core.type == HDA_DEV_LEGACY) + snd_hdac_device_unregister(&codec->core); codec_display_power(codec, false); put_device(hda_codec_dev(codec)); return 0; --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -328,6 +328,12 @@ static int hdac_hda_codec_probe(struct snd_soc_component *component) dev_err(&hdev->dev, "failed to create hda codec %d\n", ret); goto error_no_pm; } + /* + * Overwrite type to HDA_DEV_ASOC since it is a ASoC driver + * hda_codec.c will check this flag to determine if unregister + * device is needed. + */ + hdev->type = HDA_DEV_ASOC; /* * snd_hda_codec_device_new decrements the usage count so call get pm

2 1

Re: [alsa-devel] [PATCH V3] ASoC: fsl_esai: Add pm runtime function
by S.j. Wang 28 Apr '19

28 Apr '19

Hi Mark > On Fri, Apr 26, 2019 at 10:51:15AM +0000, S.j. Wang wrote: > > > On Mon, Apr 22, 2019 at 02:31:55AM +0000, S.j. Wang wrote: > > > > Add pm runtime support and move clock handling there. > > > > Close the clocks at suspend to reduce the power consumption. > > > > > fsl_esai_suspend is replaced by pm_runtime_force_suspend. > > > > fsl_esai_resume is replaced by pm_runtime_force_resume. > > > > This doesn't apply against current code, please check and resend. > > > Which branch are you using? I tried for-next and for-linus, both Are > > successful applied. > > I'm applying against for-5.2, though if it depends on a patch queued for > 5.1 that's fine, I can just merge that up - please just resend. I think I did try > merging 5.1 though... I think may be caused by the patch " ASoC: fsl_esai: Fix missing break in switch statement", so I resend them both base on for-5.2. best regards wang shengjiu

1 0

[alsa-devel] no sound in laptop ASUS UX362FA - repair
by Petr Nosek 27 Apr '19

27 Apr '19

Hi, I bought laptop ASUS UX362FA: https://www.asus.com/2-in-1-PCs/ASUS-ZenBook-Flip-13-UX362FA/ The sound didn't work. I was looking for solution and I found this article: https://forum.manjaro.org/t/alc294-analog-audio-card-detected-but-no-sound-… So I added this line into ( https://github.com/torvalds/linux/blob/master/sound/pci/hda/patch_realtek.c ): SND_PCI_QUIRK(0x1043, 0x13e1, "ASUS UX362FA", ALC294_FIXUP_ASUS_SPK), behind this line: SND_PCI_QUIRK(0x1043, 0x10a1, "ASUS UX391UA", ALC294_FIXUP_ASUS_SPK) And recompile kernel and it works. I'm sending this report for others, who have the same problem with this laptop version. Please add this repair to kernel for the others. Thank you. my hwinfo: root@zenbook:~$ hwinfo --sound 15: PCI 1f.3: 0403 Audio device [Created at pci.378] Unique ID: nS1_.jsQALdVXpeB SysFS ID: /devices/pci0000:00/0000:00:1f.3 SysFS BusID: 0000:00:1f.3 Hardware Class: sound Model: "Intel Audio device" Vendor: pci 0x8086 "Intel Corporation" Device: pci 0x9dc8 SubVendor: pci 0x1043 "ASUSTeK Computer Inc." SubDevice: pci 0x13e1 Revision: 0x30 Driver: "snd_hda_intel" Driver Modules: "snd_hda_intel" Memory Range: 0xb1218000-0xb121bfff (rw,non-prefetchable) Memory Range: 0xb1000000-0xb10fffff (rw,non-prefetchable) IRQ: 127 (100 events) Module Alias: "pci:v00008086d00009DC8sv00001043sd000013E1bc04sc03i80" Driver Info #0: Driver Status: snd_hda_intel is active Driver Activation Cmd: "modprobe snd_hda_intel" Driver Info #1: Driver Status: snd_soc_skl is active Driver Activation Cmd: "modprobe snd_soc_skl" Config Status: cfg=new, avail=yes, need=no, active=unknown For repairing it is neccessary to compile kernel. I'm sending solution for other and if is it possible, please add it in ubuntu kernel. I reported bug (and solution) also there: https://bugzilla.kernel.org/show_bug.cgi?id=203443 additional information: root@zenbook:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 18.10 Release: 18.10 Codename: cosmic root@zenbook:~$ uname -a Linux zenbook 4.20.10-custom #1 SMP Sat Apr 6 21:21:30 CEST 2019 x86_64 x86_64 x86_64 GNU/Linux kernel compiled and patched from this source: https://kernel.ubuntu.com/~kernel-ppa/mainline/v4.20/ and added line: SND_PCI_QUIRK(0x1043, 0x13e1, "ASUS UX362FA", ALC294_FIXUP_ASUS_SPK), into /sound/pci/hda/patch_realtek.c file Petr

2 1

[alsa-devel] [PATCH v6 00/14] ASoC: Sound Open Firmware (SOF) core
by Pierre-Louis Bossart 27 Apr '19

27 Apr '19

Sound Open Firmware (SOF) is a host and DSP architecture agnostic audio DSP firmware. SOF is not tied to any specific host architecture or any specific physical IO communication type (it will work with on SoC DSPs, or DSP connected via SPI/I2C). SOF is also not coupled to any particular DSP architecture and has abstraction similar to Linux to allow porting to other DSP architectures. https://www.sofproject.org/ This patch series introduces the SOF core and utilities. Support for Intel devices is provided as a follow-up series. The SOF core manages all the core DSP services and ALSA/ASoC IO. The core is responsible for loading firmware, parsing topology, exposing PCMs and kcontrols, providing debug and trace mechanisms and performing IPC between host and DSP. The SOF core also has logic to allow reuse of existing machine drivers for other platforms/machines without any code modification. i.e. DAI links can be modified at runtime to bind with SOF and SOF topologies instead of existing hard coded DAI links and topology. Changes since v5: In addition to addressing feedback from Takashi, the major change in this series is the IPC rework. We reverted some optimizations to help Daniel Baluta @ NXP submit support for i.MX platforms, additional IPC core refactorization will start once we have two platforms supported on github. Hopefully by then the code will be accepted in the ASoC tree and we can submit delta patches, hint hint wink wink. All feedback from Takashi addressed: Tabify/align Kconfigs Remove INFO_RESUME flag Add const char* for core prototypes Fix snd_sof_get_status return value Use smd_pcm_format_physical_width() Fix hw_constraints and BUFFER_BYTES/SIZE confusion Remove useless fallthrough statements Fix typos and duplicate words in comments and commit messages Remove unnecessary casts, use container_of Remove superfluous initializations Fix potential race condition in debugfs Check for wrap-arounds in loader Fix alignment in debugfs read Don't use devm_kasprintf for firmware name string. Other updates: Major refactor of IPC handling (support for large messages, code optimization, better abstraction to push Intel-specific code out of the core). Regenerate compressed page table only if needed Support for multiple DAI hw_config (from <dragos_tarcatu(a)mentor.com>) Use iopoll macros (with small change due to indirection) Fix PM refcount handling on errors Rename/unify all definitions for effects (now 'process') Added basic support for keyword/hotword detection and binding widgets with external events Fix release of topology resources Support new IPC_PANIC message Clean-up mandatory/optional callbacks, simplify wrappers Add topology ABI check Fix acpi/machine driver handling Fix memory leak in debugfs error handling Alignment with firmware header files Fixed topology endianness issues Changes since v4: feedback from Mark: Removed need for private field in soc_runtime Completely reworked IPC, now much simpler and robust. IPC refactoring work will continue to e.g. allow for different types of IPC hardware and a better split between core and platform-specific drivers. Feedback from Takashi: Clarified endianness and alignment issues for page tables Removed useless mutexes Removed unneeded initializations, return types and wrappers Use snd_mask_set_format() Trace code flow optimization Removed checks on preallocate_pages() Test status of open/close functions. Released reference when pm_runtime_get_sync fails Fixed multiple memory allocation issues Fixed static analysis warnings Fixed error checks with copy_to_user() Added support for multi-core DSPs Fixed leaked references with firmware handling on resume Multiple topology fixes/improvements (enum/switch, mux, removal of duplicate connections, widget power not reported as ON) Code simplifications (removed set-but-unused, typecasts, etc). Changes since v3: Addressed dozens ofcomments from Takashi Iwai, Mark Brown, Andy Shevchenko, Daniel Baluta (Thanks!) Hardened memory allocation, fixed module load/unload oops or errors (now at hundreds of cycles on ApolloLake devices) Fixed suspend/resume and removed use of suspend_late, now using snd_soc_pm_ops and standard flow Fixed topology free (multiple patches already contributed for ASoC-core) Fixed debugfs/pm_runtime interaction Removed error checks on debugfs, changed to EXPORT_SYMBOL_GPL Added filenames in debug messages, ues hex_dump_to_buffer Removed "sof-audio" platform device and added better error checks on probe Reworked data structures to remove mix of const/variable fields and duplication of pointers for platform-specific changes Removed redundant ops tables Fixed trace/logger issues Fixed issues with loader (alignment and block size errors) Fixed release_firmware handling (was all over the place) Simplified PCI handling Added comments on non-atomic triggers Removed enum controls (not supported in topology) Simplified include file dependencies Fix cppcheck warnings Fixed Kconfigs to deal with Kbuild warnings on exotic architectures Precisions: The code in this patchset is directly squashed from the SOF development branch [1], which tracks Mark Brown's for-next branch on a weekly basis and the configurations used for testing are based on the defconfigs at [2]. The patches are also used backported for Chromebook devices. Full disclosure on known limitation and issues (full list at [3]) a) the interaction with ASoC is not always perfect, there are a couple of points where a better solution is desired (use of private data, support for link DMA, etc). The known points are explicitly documented in the code and will be updated. To be clearer, it's our belief that SOF does not cripple ASoC in any way, and that merging this SOF core does not harm others. It's just complicated to get things right, especially on a couple of cases where the topology and DPCM frameworks generate complex flows that very few people understand. b) The get/put methods for controls generate an IPC and possibly a wake-up. This is not optimal and is being fixed. c) runtime_pm is being hardened and the use of SMART_SUSPEND was suggested. Thank you for reviews and comments, we appreciate the time spent commenting on this large patchset. Thanks in particular to Alan Cox and Andy Shevchenko for their comments on an earlier version. This patchset also includes contributions from Daniel Baluta for loading code on non-Intel platforms. Pierre [1] https://github.com/thesofproject/linux [2] https://github.com/thesofproject/kconfig [3] https://github.com/thesofproject/linux/issues Liam Girdwood (12): ASoC: SOF: Add Sound Open Firmware driver core ASoC: SOF: Add Sound Open Firmware KControl support ASoC: SOF: Add driver debug support. ASoC: SOF: Add support for IPC IO between DSP and Host ASoC: SOF: Add PCM operations support ASoC: SOF: Add support for loading topologies ASoC: SOF: Add DSP firmware logger support ASoC: SOF: Add DSP HW abstraction operations ASoC: SOF: Add firmware loader support ASoC: SOF: Add userspace ABI support ASoC: SOF: Add PM support ASoC: SOF: Add Nocodec machine driver support Pierre-Louis Bossart (2): ASoC: SOF: Add xtensa support ASoC: SOF: Add utils include/sound/sof.h | 100 + include/sound/sof/control.h | 158 ++ include/sound/sof/dai-intel.h | 178 ++ include/sound/sof/dai.h | 75 + include/sound/sof/header.h | 158 ++ include/sound/sof/info.h | 118 ++ include/sound/sof/pm.h | 48 + include/sound/sof/stream.h | 148 ++ include/sound/sof/topology.h | 256 +++ include/sound/sof/trace.h | 67 + include/sound/sof/xtensa.h | 44 + include/uapi/sound/sof/abi.h | 62 + include/uapi/sound/sof/eq.h | 172 ++ include/uapi/sound/sof/fw.h | 78 + include/uapi/sound/sof/header.h | 27 + include/uapi/sound/sof/manifest.h | 188 ++ include/uapi/sound/sof/tokens.h | 107 + include/uapi/sound/sof/tone.h | 21 + include/uapi/sound/sof/trace.h | 66 + sound/soc/sof/control.c | 552 +++++ sound/soc/sof/core.c | 506 +++++ sound/soc/sof/debug.c | 232 +++ sound/soc/sof/ipc.c | 832 ++++++++ sound/soc/sof/loader.c | 400 ++++ sound/soc/sof/nocodec.c | 109 + sound/soc/sof/ops.c | 163 ++ sound/soc/sof/ops.h | 399 ++++ sound/soc/sof/pcm.c | 719 +++++++ sound/soc/sof/pm.c | 385 ++++ sound/soc/sof/sof-priv.h | 632 ++++++ sound/soc/sof/topology.c | 3164 +++++++++++++++++++++++++++++ sound/soc/sof/trace.c | 297 +++ sound/soc/sof/utils.c | 112 + sound/soc/sof/xtensa/Kconfig | 2 + sound/soc/sof/xtensa/Makefile | 5 + sound/soc/sof/xtensa/core.c | 138 ++ 36 files changed, 10718 insertions(+) create mode 100644 include/sound/sof.h create mode 100644 include/sound/sof/control.h create mode 100644 include/sound/sof/dai-intel.h create mode 100644 include/sound/sof/dai.h create mode 100644 include/sound/sof/header.h create mode 100644 include/sound/sof/info.h create mode 100644 include/sound/sof/pm.h create mode 100644 include/sound/sof/stream.h create mode 100644 include/sound/sof/topology.h create mode 100644 include/sound/sof/trace.h create mode 100644 include/sound/sof/xtensa.h create mode 100644 include/uapi/sound/sof/abi.h create mode 100644 include/uapi/sound/sof/eq.h create mode 100644 include/uapi/sound/sof/fw.h create mode 100644 include/uapi/sound/sof/header.h create mode 100644 include/uapi/sound/sof/manifest.h create mode 100644 include/uapi/sound/sof/tokens.h create mode 100644 include/uapi/sound/sof/tone.h create mode 100644 include/uapi/sound/sof/trace.h create mode 100644 sound/soc/sof/control.c create mode 100644 sound/soc/sof/core.c create mode 100644 sound/soc/sof/debug.c create mode 100644 sound/soc/sof/ipc.c create mode 100644 sound/soc/sof/loader.c create mode 100644 sound/soc/sof/nocodec.c create mode 100644 sound/soc/sof/ops.c create mode 100644 sound/soc/sof/ops.h create mode 100644 sound/soc/sof/pcm.c create mode 100644 sound/soc/sof/pm.c create mode 100644 sound/soc/sof/sof-priv.h create mode 100644 sound/soc/sof/topology.c create mode 100644 sound/soc/sof/trace.c create mode 100644 sound/soc/sof/utils.c create mode 100644 sound/soc/sof/xtensa/Kconfig create mode 100644 sound/soc/sof/xtensa/Makefile create mode 100644 sound/soc/sof/xtensa/core.c base-commit: 5f2ab35fe853f4886da490de8bc47637f5fc2921 -- 2.17.1

3 32

[alsa-devel] [PATCH v5 00/21] ASoC: Sound Open Firmware (SOF) - Intel support
by Pierre-Louis Bossart 27 Apr '19

27 Apr '19

This patch series introduces the support for Intel devices (Baytrail, CherryTrail, Broadwell, ApolloLake, GeminiLake, CannonLake, IceLake). Support for Haswell, Skylake and KabyLake is incomplete at the moment and is not shared for now. The series starts with the 'legacy' devices, then all the more recent ones and concludes with ACPI/PCI hooks. SKL+ platforms can be compiled without HDaudio link/codec support, in which case the hdac library is not used. When support for HDMI or HDaudio codecs is selected, parts of this library are used. A small set of machine drivers supported by SOF is now provided as part of this series, more to follow. Support for SPI-based devices, compressed streams is also not provided for now since it's not ready for upstream just yet. Thank you for reviews and comments, we appreciate the time spent commenting on this large patchset. Thanks in particular to Alan Cox and Andy Shevchenko for their comments on an earlier version. Changes since v4: Feedback from Andy: Rename EDISON as MERRIFIELD, byt_pci_probe as tng_pci_probe Feedback from Takashi: Remove superfluous initializations and casts Tabify Kconfigs Fix dependency on SND_DMA_SGBUFF Other updates: Major IPC rework (Intel-specific parts moved out of the core) Fix NOCODEC/HDA compatibility Fix period bytes calculation Fix CTX_SAVE handling (do not read mailbox which can be powered off) Fix ROM message handling Drop unexpected IPC replies Add prepare for BE dailink Fix typos in comments Changes since v3: Removed Haswell, Skylake and Kabylake support (code is not tested or is still under development). These devices will be re-added when there is functional firmware and for Skylake/Kabylake a signed version of the firmware usable on existing platforms. Added support for existing machine drivers when relevant (more machine drivers will be added in next batch) Fixed hardware programming sequences (ROM init timeout, HDaudio capture, simultaneous capture and playback, DMA preload) Avoid reading IPC reply on CTX_SAVE reply since memory windows might be powered off. Simplified NOCODEC support, now mutually exclusive with HDaudio link to avoid suspend/resume issues. Changes since v2: Addressed dozens of comments from Takashi Iwai, Mark Brown, Andy Shevchenko, Daniel Baluta (Thanks!) Transition to new display power management Fixed suspend issues Optimized register polling, better handling of timeouts and firmware download retries Detect number of HDaudio codec and select machine driver accordingly Added workqueue based probe for HDaudio (dependency on modules) Fixed platform name override and conflicts with DT deferred probe changes Added prefix for firmware and topology files and module arguments Split Baytrail and Edison Fixed warnings (smatch, cppcheck) Guennadi Liakhovetski (1): ASoC: SOF: Intel: Add legacy IPC support Keyon Jie (2): ASoC: SOF: Intel: Add hda-bus support and initialization ASoC: SOF: Intel: add SKL+ platform DAIs Liam Girdwood (15): ASoC: SOF: Intel: Add BYT, CHT and BSW DSP HW support. ASoC: SOF: Intel: Add BDW HW DSP support ASoC: SOF: Intel: Add APL/CNL HW DSP support ASoC: SOF: Intel: Add HDA controller for Intel DSP ASoC: SOF: Intel: Add Intel specific HDA DSP HW operations ASoC: SOF: Intel: Add Intel specific HDA IPC mechanisms. ASoC: SOF: Intel: Add Intel specific HDA firmware loader ASoC: SOF: Intel: Add Intel specific HDA PCM operations ASoC: SOF: Intel: Add Intel specific HDA stream operations ASoC: SOF: Intel: Add Intel specific HDA trace operations ASoC: SOF: Intel: Add platform differentiation for APL and CNL ASoC: SOF: Add ACPI device support ASoC: SOF: Add PCI device support ASoC: SOF: Add Build support for SOF core and Intel drivers ASoC: Intel: Make sure BDW based machine drivers build for SOF Pierre-Louis Bossart (3): ASoC: SOF: Intel: Add support for HDAudio codecs ASoC: Intel: Kconfig: expose common option between SST and SOF drivers ASoC: Intel: select relevant machine drivers for SOF sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/intel/Kconfig | 7 +- sound/soc/intel/boards/Kconfig | 22 +- sound/soc/intel/boards/bdw-rt5677.c | 4 + sound/soc/intel/boards/broadwell.c | 4 + sound/soc/sof/Kconfig | 141 +++++ sound/soc/sof/Makefile | 18 + sound/soc/sof/intel/Kconfig | 230 ++++++++ sound/soc/sof/intel/Makefile | 19 + sound/soc/sof/intel/apl.c | 109 ++++ sound/soc/sof/intel/bdw.c | 713 +++++++++++++++++++++++ sound/soc/sof/intel/byt.c | 874 ++++++++++++++++++++++++++++ sound/soc/sof/intel/cnl.c | 249 ++++++++ sound/soc/sof/intel/hda-bus.c | 108 ++++ sound/soc/sof/intel/hda-codec.c | 171 ++++++ sound/soc/sof/intel/hda-ctrl.c | 181 ++++++ sound/soc/sof/intel/hda-dai.c | 351 +++++++++++ sound/soc/sof/intel/hda-dsp.c | 455 +++++++++++++++ sound/soc/sof/intel/hda-ipc.c | 458 +++++++++++++++ sound/soc/sof/intel/hda-loader.c | 371 ++++++++++++ sound/soc/sof/intel/hda-pcm.c | 240 ++++++++ sound/soc/sof/intel/hda-stream.c | 692 ++++++++++++++++++++++ sound/soc/sof/intel/hda-trace.c | 94 +++ sound/soc/sof/intel/hda.c | 671 +++++++++++++++++++++ sound/soc/sof/intel/hda.h | 560 ++++++++++++++++++ sound/soc/sof/intel/intel-ipc.c | 92 +++ sound/soc/sof/intel/shim.h | 183 ++++++ sound/soc/sof/sof-acpi-dev.c | 312 ++++++++++ sound/soc/sof/sof-pci-dev.c | 373 ++++++++++++ 30 files changed, 7696 insertions(+), 8 deletions(-) create mode 100644 sound/soc/sof/Kconfig create mode 100644 sound/soc/sof/Makefile create mode 100644 sound/soc/sof/intel/Kconfig create mode 100644 sound/soc/sof/intel/Makefile create mode 100644 sound/soc/sof/intel/apl.c create mode 100644 sound/soc/sof/intel/bdw.c create mode 100644 sound/soc/sof/intel/byt.c create mode 100644 sound/soc/sof/intel/cnl.c create mode 100644 sound/soc/sof/intel/hda-bus.c create mode 100644 sound/soc/sof/intel/hda-codec.c create mode 100644 sound/soc/sof/intel/hda-ctrl.c create mode 100644 sound/soc/sof/intel/hda-dai.c create mode 100644 sound/soc/sof/intel/hda-dsp.c create mode 100644 sound/soc/sof/intel/hda-ipc.c create mode 100644 sound/soc/sof/intel/hda-loader.c create mode 100644 sound/soc/sof/intel/hda-pcm.c create mode 100644 sound/soc/sof/intel/hda-stream.c create mode 100644 sound/soc/sof/intel/hda-trace.c create mode 100644 sound/soc/sof/intel/hda.c create mode 100644 sound/soc/sof/intel/hda.h create mode 100644 sound/soc/sof/intel/intel-ipc.c create mode 100644 sound/soc/sof/intel/shim.h create mode 100644 sound/soc/sof/sof-acpi-dev.c create mode 100644 sound/soc/sof/sof-pci-dev.c -- 2.17.1

3 43

[alsa-devel] [PATCH 0/3] Add runtime PM for SAI digital audio interface
by Daniel Baluta 27 Apr '19

27 Apr '19

First patch fixes a bug by correctly setting is_slave_mode, then second patch adds support for runtime PM and finally 3rd patch moves clock handling from startup/shtudown function to runtime PM handlers. Changes since v1: - added patch 1 - added fsl_sai_remove in order to call pm_runtime_disable - only disable/enable mclk when SAI in master mode. Daniel Baluta (2): ASoC: fsl_sai: Update is_slave_mode with correct value ASoC: fsl_sai: Add support for runtime pm Shengjiu Wang (1): ASoC: fsl_sai: Move clock operation to PM runtime sound/soc/fsl/fsl_sai.c | 84 +++++++++++++++++++++++++++++++++-------- 1 file changed, 69 insertions(+), 15 deletions(-) -- 2.17.1

5 13

Re: [alsa-devel] [PATCH V3] ASoC: fsl_esai: Add pm runtime function
by S.j. Wang 27 Apr '19

27 Apr '19

Hi Mark > > On Mon, Apr 22, 2019 at 02:31:55AM +0000, S.j. Wang wrote: > > Add pm runtime support and move clock handling there. > > Close the clocks at suspend to reduce the power consumption. > > > > fsl_esai_suspend is replaced by pm_runtime_force_suspend. > > fsl_esai_resume is replaced by pm_runtime_force_resume. > > This doesn't apply against current code, please check and resend. Which branch are you using? I tried for-next and for-linus, both Are successful applied. Best regards Wang shengjiu

2 1

[alsa-devel] Help with cross compilation of alsa-lib.
by Mathias Nielsen 27 Apr '19

27 Apr '19

Hi. I have made a small Go app (https://github.com/Lynges/susimup). It is a simple music player for the console and one of the libraries I use has alsa as a dependency on linux. I would really like to have cross compilation working so that I might provide binaries for the various platforms. I have tried getting it working using xgo (https://github.com/karalabe/xgo) and it solves the problem for both windows and macos, but on linux I have to get alsa-lib injected and compiled. I have created an SO question with some more details here: ( https://stackoverflow.com/questions/55656194/xgo-cross-compile-not-working-… ) I realize that I am asking no small thing unless someone on this list is very familiar with both xgo and alsa, but I could really use some help getting this working and I have spent quite a lot of time searching for other solutions and found nothing so I guess it would be helpful to others as well as my self. I do not have a whole lot of experience getting cross compilation for C working and the fact that the process is somewhat obscured by xgo does not make it any easier. One thing I have not tried yet is just forking xgo and using a different version of their docker image that then has the alsa packages installed with multiarch, but I have no idea how to make that work or if it even could work. Any more information I can provide, please dont hold back. -- Best regards Mathias Nielsen

1 0

[alsa-devel] Will we ever see a low latency/high performance PCM api for usb, firewire, avb ?
by Ralf Beck 26 Apr '19

26 Apr '19

Subject says it all. During the Dec/Jan period i did some USB patches for the Motu AVB series and a trivial alsa driver to connect my Motu via AVB for a single i/o stream. So i discovered how totally unsuitable the mmapped ringbuffer model of alsa is for the above types of interfaces. Is there any intention to change this ? I've read that this has already been discussed during miniconf 2017 (USB) and 2018 (AVB). Any results?

3 3

[alsa-devel] [PATCH] ASoC: da7213: fix DAI_CLK_EN register bit overwrite
by Logesh Kolandavel 26 Apr '19

26 Apr '19

From: Logesh <logesh.kolandavel(a)timesys.com> If the da7213 codec is configured as Master with the DAPM power down delay time set, 'snd_soc_component_write' function overwrites the DAI_CLK_EN bit of DAI_CLK_MODE register which leads to audio play only once until it re-initialize after codec power up. Signed-off-by: Logesh <logesh.kolandavel(a)timesys.com> --- sound/soc/codecs/da7213.c | 4 +++- sound/soc/codecs/da7213.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index 92d006a5283e..306e01684bda 100644 --- a/sound/soc/codecs/da7213.c +++ b/sound/soc/codecs/da7213.c @@ -1305,7 +1305,9 @@ static int da7213_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) /* By default only 64 BCLK per WCLK is supported */ dai_clk_mode |= DA7213_DAI_BCLKS_PER_WCLK_64; - snd_soc_component_write(component, DA7213_DAI_CLK_MODE, dai_clk_mode); + snd_soc_component_update_bits(component, DA7213_DAI_CLK_MODE, + DA7213_DAI_CLK_POL_MASK | DA7213_DAI_WCLK_POL_MASK, + dai_clk_mode); snd_soc_component_update_bits(component, DA7213_DAI_CTRL, DA7213_DAI_FORMAT_MASK, dai_ctrl); snd_soc_component_write(component, DA7213_DAI_OFFSET, dai_offset); diff --git a/sound/soc/codecs/da7213.h b/sound/soc/codecs/da7213.h index 5a78dba1dcb5..9d31efc3cfe5 100644 --- a/sound/soc/codecs/da7213.h +++ b/sound/soc/codecs/da7213.h @@ -181,7 +181,9 @@ #define DA7213_DAI_BCLKS_PER_WCLK_256 (0x3 << 0) #define DA7213_DAI_BCLKS_PER_WCLK_MASK (0x3 << 0) #define DA7213_DAI_CLK_POL_INV (0x1 << 2) +#define DA7213_DAI_CLK_POL_MASK (0x1 << 2) #define DA7213_DAI_WCLK_POL_INV (0x1 << 3) +#define DA7213_DAI_WCLK_POL_MASK (0x1 << 3) #define DA7213_DAI_CLK_EN_MASK (0x1 << 7) /* DA7213_DAI_CTRL = 0x29 */ -- 2.21.0

2 1