November 2019 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH] ASoC: wm8524: Add support S32_LE
by S.j. Wang 05 Nov '19

05 Nov '19

Hi > On Fri, Nov 01, 2019 at 06:34:54AM +0000, S.j. Wang wrote: > > Allow 32bit sample with this codec. > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> > > --- > > sound/soc/codecs/wm8524.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/sound/soc/codecs/wm8524.c b/sound/soc/codecs/wm8524.c > > index 91e3d1570c45..4e9ab542f648 100644 > > --- a/sound/soc/codecs/wm8524.c > > +++ b/sound/soc/codecs/wm8524.c > > @@ -159,7 +159,9 @@ static int wm8524_mute_stream(struct > snd_soc_dai > > *dai, int mute, int stream) > > > > #define WM8524_RATES SNDRV_PCM_RATE_8000_192000 > > > > -#define WM8524_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | > > SNDRV_PCM_FMTBIT_S24_LE) > > +#define WM8524_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\ > > + SNDRV_PCM_FMTBIT_S24_LE |\ > > + SNDRV_PCM_FMTBIT_S32_LE) > > > > The device doesn't actually support 32bit though, I guess it will ignore the > extra LSBs so it should work. But is that really supporting 32 bit? > I also think it may ignore the extra LSBs just as you said, but don't really Support 32bit. This change is to make driver accept S32_LE format. Best regards Wang shengjiu

1 0

[alsa-devel] [PATCH v4 0/2] soundwire: Add support to Qualcomm SoundWire master
by Srinivas Kandagatla 05 Nov '19

05 Nov '19

Thanks for reviewing the v3 patchset. Here is new patchset addressing all the comments from v3 This patchset adds support for Qualcomm SoundWire Master Controller found in most of Qualcomm SoCs and WCD audio codecs. This driver along with WCD934x codec and WSA881x Class-D Smart Speaker Amplifier drivers is tested on on DragonBoard DB845c based of SDM845 SoC and Lenovo YOGA C630 Laptop based on SDM850. SoundWire controller on SDM845 is integrated in WCD934x audio codec via SlimBus interface. Currently this driver is very minimal and only supports PDM. Most of the code in this driver is rework of Qualcomm downstream drivers used in Andriod. Credits to Banajit Goswami and Patrick Lai's Team. TODO: Test and add PCM support. Thanks, srini Changes since v3: - Updated bindings as suggested by Rob. - Fixed sdw_disable/unprepare order. - removed setting stream_name as suggested by Pierre - removed v1.5.0 controller support for now, will be added after testing. Srinivas Kandagatla (2): dt-bindings: soundwire: add bindings for Qcom controller soundwire: qcom: add support for SoundWire controller .../bindings/soundwire/qcom,sdw.txt | 179 ++++ drivers/soundwire/Kconfig | 9 + drivers/soundwire/Makefile | 4 + drivers/soundwire/qcom.c | 904 ++++++++++++++++++ 4 files changed, 1096 insertions(+) create mode 100644 Documentation/devicetree/bindings/soundwire/qcom,sdw.txt create mode 100644 drivers/soundwire/qcom.c -- 2.21.0

3 8

[alsa-devel] [PATCH] slimbus: qcom: add missed clk_disable_unprepare in remove
by Chuhong Yuan 04 Nov '19

04 Nov '19

The remove misses to disable and unprepare rclk and hclk. Add calls to clk_disable_unprepare to fix it. Signed-off-by: Chuhong Yuan <hslester96(a)gmail.com> --- drivers/slimbus/qcom-ctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index a444badd8df5..4aad2566f52d 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -641,6 +641,8 @@ static int qcom_slim_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); slim_unregister_controller(&ctrl->ctrl); + clk_disable_unprepare(ctrl->rclk); + clk_disable_unprepare(ctrl->hclk); destroy_workqueue(ctrl->rxwq); return 0; } -- 2.23.0

1 0

[alsa-devel] [PATCH] ASoC: max98373: Fix calls to free_gpio()
by Yong Zhi 04 Nov '19

04 Nov '19

Don't Call free_gpio() when request_gpio() fails, call it at error paths to avoid resource leak. Signed-off-by: Yong Zhi <yong.zhi(a)intel.com> --- sound/soc/codecs/max98373.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index eb709d528259..83984b5244c5 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -964,7 +964,6 @@ static int max98373_i2c_probe(struct i2c_client *i2c, if (ret) { dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", __func__, max98373->reset_gpio); - gpio_free(max98373->reset_gpio); return -EINVAL; } gpio_direction_output(max98373->reset_gpio, 0); @@ -979,16 +978,23 @@ static int max98373_i2c_probe(struct i2c_client *i2c, if (ret < 0) { dev_err(&i2c->dev, "Failed to read: 0x%02X\n", MAX98373_R21FF_REV_ID); - return ret; + goto err_gpio_free; } dev_info(&i2c->dev, "MAX98373 revisionID: 0x%02X\n", reg); /* codec registeration */ ret = devm_snd_soc_register_component(&i2c->dev, &soc_codec_dev_max98373, max98373_dai, ARRAY_SIZE(max98373_dai)); - if (ret < 0) + if (ret < 0) { dev_err(&i2c->dev, "Failed to register codec: %d\n", ret); + goto err_gpio_free; + } + + return 0; +err_gpio_free: + if (gpio_is_valid(max98373->reset_gpio)) + gpio_free(max98373->reset_gpio); return ret; } -- 2.7.4

5 4

[alsa-devel] Applied "ASoC: ux500: Remove redundant variable "status"" to the asoc tree
by Mark Brown 04 Nov '19

04 Nov '19

The patch ASoC: ux500: Remove redundant variable "status" has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From e0859710516c98b189879966b48ea1c77e0cd979 Mon Sep 17 00:00:00 2001 From: zhong jiang <zhongjiang(a)huawei.com> Date: Thu, 31 Oct 2019 21:34:15 +0800 Subject: [PATCH] ASoC: ux500: Remove redundant variable "status" local variable "status" is not used. hence it is safe to remove and just return 0. Signed-off-by: zhong jiang <zhongjiang(a)huawei.com> Link: https://lore.kernel.org/r/1572528855-25990-1-git-send-email-zhongjiang@huaw… Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/ux500/ux500_msp_i2s.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c index a90e0d7f0b73..394d8b2a4a16 100644 --- a/sound/soc/ux500/ux500_msp_i2s.c +++ b/sound/soc/ux500/ux500_msp_i2s.c @@ -533,7 +533,6 @@ static void disable_msp_tx(struct ux500_msp *msp) static int disable_msp(struct ux500_msp *msp, unsigned int dir) { u32 reg_val_GCR; - int status = 0; unsigned int disable_tx, disable_rx; reg_val_GCR = readl(msp->registers + MSP_GCR); @@ -566,7 +565,7 @@ static int disable_msp(struct ux500_msp *msp, unsigned int dir) else if (disable_rx) disable_msp_rx(msp); - return status; + return 0; } int ux500_msp_i2s_trigger(struct ux500_msp *msp, int cmd, int direction) -- 2.20.1

1 0

[alsa-devel] [PATCH] ASoC: hdac_hda: fix race in device removal
by Pierre-Louis Bossart 04 Nov '19

04 Nov '19

From: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> When ASoC card instance is removed containing a HDA codec, hdac_hda_codec_remove() may run in parallel with codec resume. This will cause problems if the HDA link is freed with snd_hdac_ext_bus_link_put() while the codec is still in middle of its resume process. To fix this, change the order such that pm_runtime_disable() is called before the link is freed. This will ensure any pending runtime PM action is completed before proceeding to free the link. This issue can be easily hit with e.g. SOF driver by loading and unloading the drivers. Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/codecs/hdac_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdac_hda.c b/sound/soc/codecs/hdac_hda.c index 298761a26180..6803d39e09a5 100644 --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -500,8 +500,8 @@ static void hdac_hda_codec_remove(struct snd_soc_component *component) return; } - snd_hdac_ext_bus_link_put(hdev->bus, hlink); pm_runtime_disable(&hdev->dev); + snd_hdac_ext_bus_link_put(hdev->bus, hlink); } static const struct snd_soc_dapm_route hdac_hda_dapm_routes[] = { -- 2.20.1

2 1

[alsa-devel] [PATCH v5 0/2] ASoC: Intel: boards: Add CML M/C for RT5682 and RT1011
by Pierre-Louis Bossart 04 Nov '19

04 Nov '19

The series adds CML m/c driver with RT5682 on SSP0 and RT1011 on SSP1. The RT1011 is smart AMP which supports 2 Whoofers and 2 tweeter support. RT5682 is headset codec supporting playback and record. The m/c supports HDMI playback and DMIC record. Changes since v4 (from Kai Vehmanen) added prefix for series, reformatted changes fixed bad filename in Makefile Support for hdmi common codec Changes since v3 Acked-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> repost with more recipients and edits to commit messages Changes since v2: re ordered match table to ensure non i2c device matches are at the end Changes since V1: Addressed comments on ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682 Naveen Manohar (2): ASoC: Intel: Add acpi match for rt1011 based m/c driver ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682 sound/soc/intel/boards/Kconfig | 14 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/cml_rt1011_rt5682.c | 487 ++++++++++++++++++ .../intel/common/soc-acpi-intel-cnl-match.c | 7 + 4 files changed, 510 insertions(+) create mode 100644 sound/soc/intel/boards/cml_rt1011_rt5682.c -- 2.20.1

2 4

[alsa-devel] [PATCH] dt-bindings: sound: adau7118: Fix example warning
by Maxime Ripard 04 Nov '19

04 Nov '19

The ADAU7118 has an example where the codec has an i2c address of 14, and the unit address set to 14 as well. However, while the address is expressed in decimal, the unit-address is supposed to be in hexadecimal, which ends up with two different addresses that trigger a DTC warning. Fix this by setting the unit address to (0x)e. Cc: Nuno Sá <nuno.sa(a)analog.com> Fixes: 969d49b2cdc8 ("dt-bindings: asoc: Add ADAU7118 documentation") Signed-off-by: Maxime Ripard <maxime(a)cerno.tech> --- Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml index c3f10afbdd6f..65f6844a0c6d 100644 --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml @@ -65,7 +65,7 @@ examples: /* example with i2c support */ #address-cells = <1>; #size-cells = <0>; - adau7118_codec: audio-codec@14 { + adau7118_codec: audio-codec@e { compatible = "adi,adau7118"; reg = <14>; #sound-dai-cells = <0>; -- 2.23.0

2 1

[alsa-devel] [PATCH] ASoC: wm8524: Add support S32_LE
by S.j. Wang 04 Nov '19

04 Nov '19

Allow 32bit sample with this codec. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/codecs/wm8524.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm8524.c b/sound/soc/codecs/wm8524.c index 91e3d1570c45..4e9ab542f648 100644 --- a/sound/soc/codecs/wm8524.c +++ b/sound/soc/codecs/wm8524.c @@ -159,7 +159,9 @@ static int wm8524_mute_stream(struct snd_soc_dai *dai, int mute, int stream) #define WM8524_RATES SNDRV_PCM_RATE_8000_192000 -#define WM8524_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE) +#define WM8524_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\ + SNDRV_PCM_FMTBIT_S24_LE |\ + SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops wm8524_dai_ops = { .startup = wm8524_startup, -- 2.21.0

2 1

[alsa-devel] [PATCH] ALSA: pcm: Fix missing check of the new non-cached buffer type
by Takashi Iwai 04 Nov '19

04 Nov '19

The check for the mmap support via hw_support_mmap() function misses the case where the device is with SNDRV_DMA_TYPE_DEV_UC, which should have been treated equally as SNDRV_DMA_TYPE_DEV. Let's fix it. Note that this bug doesn't hit any practical problem, because SNDRV_DMA_TYPE_DEV_UC is used only for x86-specific drivers (snd-hda-intel and snd-intel8x0) for the specific platforms that need the non-cached buffers. And, on such platforms, hw_support_mmap() already returns true in anyway. That's the reason I didn't put Cc-to-stable mark here. This is only for any theoretical future extension. Fixes: 425da159707b ("ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_*") Fixes: 42e748a0b325 ("ALSA: memalloc: Add non-cached buffer type") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/pcm_native.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 91c6ad58729f..c3a139436ac2 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -222,7 +222,8 @@ static bool hw_support_mmap(struct snd_pcm_substream *substream) return false; if (substream->ops->mmap || - substream->dma_buffer.dev.type != SNDRV_DMA_TYPE_DEV) + (substream->dma_buffer.dev.type != SNDRV_DMA_TYPE_DEV && + substream->dma_buffer.dev.type != SNDRV_DMA_TYPE_DEV_UC)) return true; return dma_can_mmap(substream->dma_buffer.dev.dev); -- 2.16.4

1 0