November 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] INFO: task hung in snd_timer_close
by syzbot 06 Nov '19

06 Nov '19

Hello, syzbot found the following crash on: HEAD commit: a99d8080 Linux 5.4-rc6 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10afae68e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=8c5e2eca3f31f9bf dashboard link: https://syzkaller.appspot.com/bug?extid=f1048ebddb93befb085f compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=126bc658e00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+f1048ebddb93befb085f(a)syzkaller.appspotmail.com INFO: task syz-executor.0:12251 blocked for more than 143 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.0 D28160 12251 8868 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_close+0x7e/0x100 sound/core/timer.c:422 snd_timer_user_release+0x98/0x130 sound/core/timer.c:1478 __fput+0x2ff/0x890 fs/file_table.c:280 ____fput+0x16/0x20 fs/file_table.c:313 task_work_run+0x145/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x316/0x380 arch/x86/entry/common.c:163 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline] syscall_return_slowpath arch/x86/entry/common.c:274 [inline] do_syscall_64+0x65f/0x760 arch/x86/entry/common.c:300 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x413db1 Code: c0 c3 0f 1f 80 00 00 00 00 c7 07 00 00 00 00 31 c0 c3 0f 1f 80 00 00 00 00 31 c0 c3 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 b8 <2d> f8 ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 31 c0 c3 66 66 66 66 RSP: 002b:00007ffdda4a34b0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000413db1 RDX: 0000001b2dd20000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 0000000000000001 R08: ffffffffffffffff R09: ffffffffffffffff R10: 00007ffdda4a3590 R11: 0000000000000293 R12: 000000000075c9a0 R13: 000000000075c9a0 R14: 0000000000760a90 R15: 000000000075bf2c INFO: task syz-executor.2:12256 blocked for more than 143 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.2 D28160 12256 8864 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_close+0x7e/0x100 sound/core/timer.c:422 snd_timer_user_release+0x98/0x130 sound/core/timer.c:1478 __fput+0x2ff/0x890 fs/file_table.c:280 ____fput+0x16/0x20 fs/file_table.c:313 task_work_run+0x145/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x316/0x380 arch/x86/entry/common.c:163 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline] syscall_return_slowpath arch/x86/entry/common.c:274 [inline] do_syscall_64+0x65f/0x760 arch/x86/entry/common.c:300 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x413db1 Code: c0 c3 0f 1f 80 00 00 00 00 c7 07 00 00 00 00 31 c0 c3 0f 1f 80 00 00 00 00 31 c0 c3 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 b8 <2d> f8 ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 31 c0 c3 66 66 66 66 RSP: 002b:00007ffe078ed7d0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000413db1 RDX: 0000001b2da20000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 0000000000000001 R08: ffffffffffffffff R09: ffffffffffffffff R10: 00007ffe078ed8b0 R11: 0000000000000293 R12: 000000000075c9a0 R13: 000000000075c9a0 R14: 0000000000760a90 R15: 000000000075bf2c INFO: task syz-executor.4:12266 blocked for more than 144 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.4 D28480 12266 8871 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_open+0x98/0x1860 sound/core/timer.c:245 snd_timer_user_tselect sound/core/timer.c:1728 [inline] __snd_timer_user_ioctl.isra.0+0x68b/0x1fd0 sound/core/timer.c:2003 snd_timer_user_ioctl+0x7a/0xa7 sound/core/timer.c:2033 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0xdb6/0x13e0 fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a219 Code: Bad RIP value. RSP: 002b:00007f2806975c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 000000000045a219 RDX: 0000000020029fcc RSI: 0000000040345410 RDI: 0000000000000003 RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f28069766d4 R13: 00000000004cf428 R14: 00000000004d9760 R15: 00000000ffffffff INFO: task syz-executor.4:12269 blocked for more than 144 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.4 D29712 12269 8871 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0xdb6/0x13e0 fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a219 Code: Bad RIP value. RSP: 002b:00007f2806954c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 000000000045a219 RDX: 0000000000000000 RSI: 00000000000054a0 RDI: 0000000000000003 RBP: 000000000075bfc8 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f28069556d4 R13: 00000000004c4ae8 R14: 00000000004d9778 R15: 00000000ffffffff INFO: task syz-executor.4:12271 blocked for more than 144 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.4 D28000 12271 8871 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_open+0x98/0x1860 sound/core/timer.c:245 snd_seq_timer_open+0x240/0x590 sound/core/seq/seq_timer.c:275 queue_use+0xf1/0x270 sound/core/seq/seq_queue.c:489 snd_seq_queue_alloc+0x2c5/0x4d0 sound/core/seq/seq_queue.c:176 snd_seq_ioctl_create_queue+0xb0/0x330 sound/core/seq/seq_clientmgr.c:1548 snd_seq_kernel_client_ctl+0xf8/0x140 sound/core/seq/seq_clientmgr.c:2353 alloc_seq_queue.isra.0+0xdc/0x180 sound/core/seq/oss/seq_oss_init.c:357 snd_seq_oss_open+0x2ff/0x960 sound/core/seq/oss/seq_oss_init.c:215 odev_open+0x70/0x90 sound/core/seq/oss/seq_oss.c:125 soundcore_open+0x453/0x610 sound/sound_core.c:593 chrdev_open+0x245/0x6b0 fs/char_dev.c:414 do_dentry_open+0x4e6/0x1380 fs/open.c:797 vfs_open+0xa0/0xd0 fs/open.c:914 do_last fs/namei.c:3408 [inline] path_openat+0x10e9/0x46d0 fs/namei.c:3525 do_filp_open+0x1a1/0x280 fs/namei.c:3555 do_sys_open+0x3fe/0x5d0 fs/open.c:1097 __do_sys_openat fs/open.c:1124 [inline] __se_sys_openat fs/open.c:1118 [inline] __x64_sys_openat+0x9d/0x100 fs/open.c:1118 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a219 Code: Bad RIP value. RSP: 002b:00007f2806933c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 000000000045a219 RDX: 0000000000000001 RSI: 0000000020000000 RDI: ffffffffffffff9c RBP: 000000000075c070 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f28069346d4 R13: 00000000004c734a R14: 00000000004dcf88 R15: 00000000ffffffff INFO: task syz-executor.4:12273 blocked for more than 145 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.4 D28552 12273 8871 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0xdb6/0x13e0 fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a219 Code: Bad RIP value. RSP: 002b:00007f2806912c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 000000000045a219 RDX: 0000000000000000 RSI: 00000000000054a0 RDI: 0000000000000003 RBP: 000000000075c118 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f28069136d4 R13: 00000000004c4ae8 R14: 00000000004d9778 R15: 00000000ffffffff INFO: task syz-executor.4:12275 blocked for more than 145 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.4 D29312 12275 8871 0x00004004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_open+0x98/0x1860 sound/core/timer.c:245 snd_timer_user_tselect sound/core/timer.c:1728 [inline] __snd_timer_user_ioctl.isra.0+0x68b/0x1fd0 sound/core/timer.c:2003 snd_timer_user_ioctl+0x7a/0xa7 sound/core/timer.c:2033 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0xdb6/0x13e0 fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a219 Code: Bad RIP value. RSP: 002b:00007f28068f1c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 000000000045a219 RDX: 0000000020029fcc RSI: 0000000040345410 RDI: 0000000000000003 RBP: 000000000075c1c0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f28068f26d4 R13: 00000000004cf428 R14: 00000000004d9760 R15: 00000000ffffffff INFO: task syz-executor.4:12276 blocked for more than 146 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.4 D28536 12276 8871 0x00004004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 odev_open+0x5f/0x90 sound/core/seq/oss/seq_oss.c:124 soundcore_open+0x453/0x610 sound/sound_core.c:593 chrdev_open+0x245/0x6b0 fs/char_dev.c:414 do_dentry_open+0x4e6/0x1380 fs/open.c:797 vfs_open+0xa0/0xd0 fs/open.c:914 do_last fs/namei.c:3408 [inline] path_openat+0x10e9/0x46d0 fs/namei.c:3525 do_filp_open+0x1a1/0x280 fs/namei.c:3555 do_sys_open+0x3fe/0x5d0 fs/open.c:1097 __do_sys_openat fs/open.c:1124 [inline] __se_sys_openat fs/open.c:1118 [inline] __x64_sys_openat+0x9d/0x100 fs/open.c:1118 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a219 Code: Bad RIP value. RSP: 002b:00007f28068d0c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 000000000045a219 RDX: 0000000000000001 RSI: 0000000020000000 RDI: ffffffffffffff9c RBP: 000000000075c268 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f28068d16d4 R13: 00000000004c734a R14: 00000000004dcf88 R15: 00000000ffffffff INFO: task syz-executor.1:12261 blocked for more than 146 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.1 D28160 12261 8866 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_close+0x7e/0x100 sound/core/timer.c:422 snd_timer_user_release+0x98/0x130 sound/core/timer.c:1478 __fput+0x2ff/0x890 fs/file_table.c:280 ____fput+0x16/0x20 fs/file_table.c:313 task_work_run+0x145/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x316/0x380 arch/x86/entry/common.c:163 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline] syscall_return_slowpath arch/x86/entry/common.c:274 [inline] do_syscall_64+0x65f/0x760 arch/x86/entry/common.c:300 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x413db1 Code: c0 c3 0f 1f 80 00 00 00 00 c7 07 00 00 00 00 31 c0 c3 0f 1f 80 00 00 00 00 31 c0 c3 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 b8 <2d> f8 ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 31 c0 c3 66 66 66 66 RSP: 002b:00007ffe3503b380 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000413db1 RDX: 0000001b2db20000 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 0000000000000001 R08: ffffffffffffffff R09: ffffffffffffffff R10: 00007ffe3503b460 R11: 0000000000000293 R12: 000000000075c9a0 R13: 000000000075c9a0 R14: 0000000000760a90 R15: 000000000075bf2c INFO: task syz-executor.5:12267 blocked for more than 147 seconds. Not tainted 5.4.0-rc6 #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-executor.5 D28552 12267 8870 0x00000004 Call Trace: context_switch kernel/sched/core.c:3384 [inline] __schedule+0x94f/0x1e70 kernel/sched/core.c:4069 schedule+0xd9/0x260 kernel/sched/core.c:4136 schedule_preempt_disabled+0x13/0x20 kernel/sched/core.c:4195 __mutex_lock_common kernel/locking/mutex.c:1033 [inline] __mutex_lock+0x7b0/0x13c0 kernel/locking/mutex.c:1103 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1118 snd_timer_open+0x98/0x1860 sound/core/timer.c:245 snd_timer_user_tselect sound/core/timer.c:1728 [inline] __snd_timer_user_ioctl.isra.0+0x68b/0x1fd0 sound/core/timer.c:2003 snd_timer_user_ioctl+0x7a/0xa7 sound/core/timer.c:2033 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0xdb6/0x13e0 fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a219 Code: Bad RIP value. RSP: 002b:00007ff76c742c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 000000000045a219 RDX: 0000000020029fcc RSI: 0000000040345410 RDI: 0000000000000003 RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007ff76c7436d4 R13: 00000000004cf428 R14: 00000000004d9760 R15: 00000000ffffffff Showing all locks held in the system: 1 lock held by khungtaskd/1070: #0: ffffffff88fab340 (rcu_read_lock){....}, at: debug_show_all_locks+0x5f/0x27e kernel/locking/lockdep.c:5337 1 lock held by rsyslogd/8724: #0: ffff88809ae4bd60 (&f->f_pos_lock){+.+.}, at: __fdget_pos+0xee/0x110 fs/file.c:801 2 locks held by getty/8813: #0: ffff8880a459b090 (&tty->ldisc_sem){++++}, at: ldsem_down_read+0x33/0x40 drivers/tty/tty_ldsem.c:340 #1: ffffc90005f152e0 (&ldata->atomic_read_lock){+.+.}, at: n_tty_read+0x232/0x1c10 drivers/tty/n_tty.c:2156 2 locks held by getty/8814: #0: ffff8880a9021090 (&tty->ldisc_sem){++++}, at: ldsem_down_read+0x33/0x40 drivers/tty/tty_ldsem.c:340 #1: ffffc90005f212e0 (&ldata->atomic_read_lock){+.+.}, at: n_tty_read+0x232/0x1c10 drivers/tty/n_tty.c:2156 2 locks held by getty/8815: #0: ffff8880a818a090 (&tty->ldisc_sem){++++}, at: ldsem_down_read+0x33/0x40 drivers/tty/tty_ldsem.c:340 #1: ffffc90005f192e0 (&ldata->atomic_read_lock){+.+.}, at: n_tty_read+0x232/0x1c10 drivers/tty/n_tty.c:2156 2 locks held by getty/8816: #0: ffff8880a843a090 (&tty->ldisc_sem){++++}, at: ldsem_down_read+0x33/0x40 drivers/tty/tty_ldsem.c:340 #1: ffffc90005f1d2e0 (&ldata->atomic_read_lock){+.+.}, at: n_tty_read+0x232/0x1c10 drivers/tty/n_tty.c:2156 2 locks held by getty/8817: #0: ffff8880a2834090 (&tty->ldisc_sem){++++}, at: ldsem_down_read+0x33/0x40 drivers/tty/tty_ldsem.c:340 #1: ffffc90005f252e0 (&ldata->atomic_read_lock){+.+.}, at: n_tty_read+0x232/0x1c10 drivers/tty/n_tty.c:2156 2 locks held by getty/8818: #0: ffff88809aafe090 (&tty->ldisc_sem){++++}, at: ldsem_down_read+0x33/0x40 drivers/tty/tty_ldsem.c:340 #1: ffffc90005f292e0 (&ldata->atomic_read_lock){+.+.}, at: n_tty_read+0x232/0x1c10 drivers/tty/n_tty.c:2156 2 locks held by getty/8819: #0: ffff8880a514a090 (&tty->ldisc_sem){++++}, at: ldsem_down_read+0x33/0x40 drivers/tty/tty_ldsem.c:340 #1: ffffc90005ef12e0 (&ldata->atomic_read_lock){+.+.}, at: n_tty_read+0x232/0x1c10 drivers/tty/n_tty.c:2156 2 locks held by syz-executor.3/12245: 2 locks held by syz-executor.0/12251: #0: ffff888082e84550 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_release+0x67/0x130 sound/core/timer.c:1476 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_close+0x7e/0x100 sound/core/timer.c:422 2 locks held by syz-executor.2/12256: #0: ffff88809c005150 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_release+0x67/0x130 sound/core/timer.c:1476 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_close+0x7e/0x100 sound/core/timer.c:422 2 locks held by syz-executor.4/12266: #0: ffff8880a9b93950 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_open+0x98/0x1860 sound/core/timer.c:245 1 lock held by syz-executor.4/12269: #0: ffff8880a9b93950 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 2 locks held by syz-executor.4/12271: #0: ffffffff89924320 (register_mutex#4){+.+.}, at: odev_open+0x5f/0x90 sound/core/seq/oss/seq_oss.c:124 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_open+0x98/0x1860 sound/core/timer.c:245 1 lock held by syz-executor.4/12273: #0: ffff888096c8d550 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 2 locks held by syz-executor.4/12275: #0: ffff888096c8d550 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_open+0x98/0x1860 sound/core/timer.c:245 1 lock held by syz-executor.4/12276: #0: ffffffff89924320 (register_mutex#4){+.+.}, at: odev_open+0x5f/0x90 sound/core/seq/oss/seq_oss.c:124 2 locks held by syz-executor.1/12261: #0: ffff88809a826950 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_release+0x67/0x130 sound/core/timer.c:1476 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_close+0x7e/0x100 sound/core/timer.c:422 2 locks held by syz-executor.5/12267: #0: ffff8880970f0950 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_open+0x98/0x1860 sound/core/timer.c:245 1 lock held by syz-executor.5/12270: #0: ffff8880970f0950 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 1 lock held by syz-executor.5/12272: #0: ffffffff89924320 (register_mutex#4){+.+.}, at: odev_open+0x5f/0x90 sound/core/seq/oss/seq_oss.c:124 1 lock held by syz-executor.5/12274: #0: ffff8880a0113d50 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 2 locks held by syz-executor.5/12277: #0: ffff8880a0113d50 (&tu->ioctl_lock){+.+.}, at: snd_timer_user_ioctl+0x51/0xa7 sound/core/timer.c:2032 #1: ffffffff89914b00 (register_mutex){+.+.}, at: snd_timer_open+0x98/0x1860 sound/core/timer.c:245 1 lock held by syz-executor.5/12279: #0: ffffffff89924320 (register_mutex#4){+.+.}, at: odev_open+0x5f/0x90 sound/core/seq/oss/seq_oss.c:124 ============================================= NMI backtrace for cpu 1 CPU: 1 PID: 1070 Comm: khungtaskd Not tainted 5.4.0-rc6 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 lib/dump_stack.c:113 nmi_cpu_backtrace.cold+0x70/0xb2 lib/nmi_backtrace.c:101 nmi_trigger_cpumask_backtrace+0x23b/0x28b lib/nmi_backtrace.c:62 arch_trigger_cpumask_backtrace+0x14/0x20 arch/x86/kernel/apic/hw_nmi.c:38 trigger_all_cpu_backtrace include/linux/nmi.h:146 [inline] check_hung_uninterruptible_tasks kernel/hung_task.c:205 [inline] watchdog+0x9d0/0xef0 kernel/hung_task.c:289 kthread+0x361/0x430 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Sending NMI from CPU 1 to CPUs 0: NMI backtrace for cpu 0 CPU: 0 PID: 12245 Comm: syz-executor.3 Not tainted 5.4.0-rc6 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:rdtsc_ordered arch/x86/include/asm/msr.h:236 [inline] RIP: 0010:delay_tsc+0x4a/0xc0 arch/x86/lib/delay.c:61 Code: 0f 01 f9 66 90 48 c1 e2 20 48 09 c2 49 89 d4 eb 16 f3 90 bf 01 00 00 00 e8 03 c2 01 fa e8 de cd f9 fb 44 39 e8 75 36 0f 01 f9 <66> 90 48 c1 e2 20 48 89 d3 48 09 c3 48 89 d8 4c 29 e0 4c 39 f0 73 RSP: 0018:ffff88808034fc70 EFLAGS: 00000246 RAX: 000000004e0d2263 RBX: 000002d24e0d2178 RCX: 0000000000000000 RDX: 00000000000002d2 RSI: ffffffff8347345c RDI: 0000000000000005 RBP: ffff88808034fc90 R08: ffff8880998302c0 R09: fffffbfff14efd42 R10: fffffbfff14efd41 R11: ffffffff8a77ea0f R12: 000002d24e0d173d R13: 0000000000000000 R14: 00000000000059d9 R15: ffff88809ccb0108 FS: 0000000000fa4940(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffff600400 CR3: 0000000095a99000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __delay arch/x86/lib/delay.c:161 [inline] __const_udelay+0x59/0x80 arch/x86/lib/delay.c:175 snd_timer_close_locked+0x22a/0xda0 sound/core/timer.c:369 snd_timer_close+0x8a/0x100 sound/core/timer.c:423 snd_timer_user_release+0x98/0x130 sound/core/timer.c:1478 __fput+0x2ff/0x890 fs/file_table.c:280 ____fput+0x16/0x20 fs/file_table.c:313 task_work_run+0x145/0x1c0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:188 [inline] exit_to_usermode_loop+0x316/0x380 arch/x86/entry/common.c:163 prepare_exit_to_usermode arch/x86/entry/common.c:194 [inline] syscall_return_slowpath arch/x86/entry/common.c:274 [inline] do_syscall_64+0x65f/0x760 arch/x86/entry/common.c:300 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x413db1 Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 04 1b 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01 RSP: 002b:00007fff58da8ec0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000413db1 RDX: 0000000000000000 RSI: 0000000000000081 RDI: 0000000000000003 RBP: 0000000000000000 R08: 0000000000760a88 R09: ffffffffffffffff R10: 00007fff58da8f90 R11: 0000000000000293 R12: 000000000075bf20 R13: 0000000000000003 R14: 0000000000760a90 R15: 000000000075bf2c --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

2 2

Re: [alsa-devel] [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
by S.j. Wang 06 Nov '19

06 Nov '19

Hi Rob > > Hi > > > > On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote: > > > In order to support the two asrc modules in imx8qm, we need to add > > > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1" > > > > Are the blocks different in some way? > > > > If not, why do you need to distinguish them? > > > The internal clock mapping is different for each module. > Or we can use one compatible string, but need add another property "fsl,asrc-clk-map" to distinguish the different clock map. The change is in below. Which one do you think is better? Required properties: - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc". + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc", + "fsl,imx8qm-asrc". - reg : Offset and length of the register set for the device. @@ -35,6 +36,11 @@ Required properties: - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. + - fsl,asrc-clk-map : Defines clock map used in driver. which is required + by imx8qm + <0> - select the map for asrc0 + <1> - select the map for asrc1 + Optional properties: Best regards Wang shengjiu

1 0

[alsa-devel] broonie-sound/for-next boot bisection: v5.4-rc6-292-gc1efaea10be0 on sun8i-h3-libretech-all-h3-cc
by kernelci.org bot 06 Nov '19

06 Nov '19

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" <bot(a)kernelci.org> * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * broonie-sound/for-next boot bisection: v5.4-rc6-292-gc1efaea10be0 on sun8i-h3-libretech-all-h3-cc Summary: Start: c1efaea10be0 Merge branch 'asoc-5.5' into asoc-next Details: https://kernelci.org/boot/id/5dc218e159b5142346138dff Plain log: https://storage.kernelci.org//broonie-sound/for-next/v5.4-rc6-292-gc1efaea1… HTML log: https://storage.kernelci.org//broonie-sound/for-next/v5.4-rc6-292-gc1efaea1… Result: ac6a4dd3e9f0 ASoC: soc-core: use snd_soc_lookup_component() at snd_soc_unregister_component() Checks: revert: PASS verify: PASS Parameters: Tree: broonie-sound URL: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git Branch: for-next Target: sun8i-h3-libretech-all-h3-cc CPU arch: arm Lab: lab-baylibre Compiler: gcc-8 Config: sunxi_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit ac6a4dd3e9f09697ab6a1774d7ab6a34e7ab36fa Author: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Date: Tue Nov 5 15:46:51 2019 +0900 ASoC: soc-core: use snd_soc_lookup_component() at snd_soc_unregister_component() snd_soc_unregister_component() is now finding component manually, but we already have snd_soc_lookup_component() to find component; Let's use existing function. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Link: https://lore.kernel.org/r/87zhha252c.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie(a)kernel.org> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index bb0592159414..0ce333669138 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -2876,29 +2876,19 @@ EXPORT_SYMBOL_GPL(snd_soc_register_component); * * @dev: The device to unregister */ -static int __snd_soc_unregister_component(struct device *dev) +void snd_soc_unregister_component(struct device *dev) { struct snd_soc_component *component; - int found = 0; mutex_lock(&client_mutex); - for_each_component(component) { - if (dev != component->dev) - continue; + while (1) { + component = snd_soc_lookup_component(dev, NULL); + if (!component) + break; snd_soc_del_component_unlocked(component); - found = 1; - break; } mutex_unlock(&client_mutex); - - return found; -} - -void snd_soc_unregister_component(struct device *dev) -{ - while (__snd_soc_unregister_component(dev)) - ; } EXPORT_SYMBOL_GPL(snd_soc_unregister_component); ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [a99d8080aaf358d5d23581244e5da23b35e340b9] Linux 5.4-rc6 git bisect good a99d8080aaf358d5d23581244e5da23b35e340b9 # bad: [c1efaea10be0d91b6986af5c14cd3482ab160981] Merge branch 'asoc-5.5' into asoc-next git bisect bad c1efaea10be0d91b6986af5c14cd3482ab160981 # good: [1092b09708882e3c216f0b9c02e606b3c0942c5b] ASoC: tlv320aic32x4: add a check for devm_clk_get git bisect good 1092b09708882e3c216f0b9c02e606b3c0942c5b # good: [f03412b78a947857bbd20899e1423482fba55761] ASoC: rockchip-max98090: Support usage with and without HDMI git bisect good f03412b78a947857bbd20899e1423482fba55761 # good: [acbf27746ecfa96b290b54cc7f05273482ea128a] ASoC: pcm: update FE/BE trigger order based on the command git bisect good acbf27746ecfa96b290b54cc7f05273482ea128a # bad: [e443c20593de9f8efd9b2935ed40eb0bbacce30b] ASoC: soc-core: don't call snd_soc_dapm_new_dai_widgets() at snd_soc_register_dai() git bisect bad e443c20593de9f8efd9b2935ed40eb0bbacce30b # good: [b8132657990b5a09ad8e1c9e2c8efc20b5f9372a] ASoC: soc-core: move snd_soc_lookup_component() git bisect good b8132657990b5a09ad8e1c9e2c8efc20b5f9372a # bad: [ac6a4dd3e9f09697ab6a1774d7ab6a34e7ab36fa] ASoC: soc-core: use snd_soc_lookup_component() at snd_soc_unregister_component() git bisect bad ac6a4dd3e9f09697ab6a1774d7ab6a34e7ab36fa # good: [486c7978ff665eb763f70cc9477e0de6326e1c41] ASoC: soc-core: add snd_soc_del_component_unlocked() git bisect good 486c7978ff665eb763f70cc9477e0de6326e1c41 # good: [b18768f56162964f70bbb9119dba59a947d7d577] ASoC: soc-core: remove snd_soc_component_add/del() git bisect good b18768f56162964f70bbb9119dba59a947d7d577 # first bad commit: [ac6a4dd3e9f09697ab6a1774d7ab6a34e7ab36fa] ASoC: soc-core: use snd_soc_lookup_component() at snd_soc_unregister_component() -------------------------------------------------------------------------------

2 1

[alsa-devel] [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
by Shengjiu Wang 06 Nov '19

06 Nov '19

In order to support the two asrc modules in imx8qm, we need to add compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1" Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- Documentation/devicetree/bindings/sound/fsl,asrc.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt index 1d4d9f938689..cd2bd3daa7e1 100644 --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt @@ -8,7 +8,8 @@ three substreams within totally 10 channels. Required properties: - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc". + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc", + "fsl,imx8qm-asrc0" or "fsl,imx8qm-asrc1". - reg : Offset and length of the register set for the device. -- 2.21.0

3 3

[alsa-devel] [PATCH v3 00/11] Add Samus Hotwording for RT5677
by Curtis Malainey 06 Nov '19

06 Nov '19

This patch series adds the hotwording implementation used in the Pixelbook on the RT5677 driver. Known Issues: There is a known issue where the system will fail to detect a hotword if suspended while the stream is open. This is due to the fact that the haswell-dsp suspends its I2S MCLK before the RT5677 suspends which causes the writes and reads to become corrupted as a result. Any recommendations to correct this behaviour would be appreciated. Changes since v1: * Addressed Mark's and Kuninori's comments * Adjusted DAI Links * Squashed related patches * Removed all kcontrol writes * Addressed race condition with dapm * Added firmware boot check * Moved all clocking to driver API * Moved DAPM routes that spanned drivers to machine driver Changes since v2: * Updated and removed necessary dapm forced power on * Addressed Cexzary's comments Cc: Dylan Reid <dgreid(a)chromium.org> Cc: Ben Zhang <benzh(a)chromium.org> Ben Zhang (7): ASoC: rt5677: Load firmware via SPI using delayed work ASoC: bdw-rt5677: Add a DAI link for rt5677 SPI PCM device ASoC: rt5677: Enable jack detect while DSP is running ASoC: rt5677: Add DAPM audio path for hotword stream ASoC: rt5677: Mark reg RT5677_PWR_ANLG2 as volatile ASoC: rt5677: Stop and restart DSP over suspend/resume ASoC: rt5677: Disable irq at suspend Curtis Malainey (4): ASoC: rt5677: Allow VAD to be shut on/off at all times ASoC: bdw-rt5677: Turn on MCLK1 for DSP via DAPM ASoC: rt5677: Set ADC clock to use PLL and enable ASRC ASoC: rt5677: Wait for DSP to boot before loading firmware sound/soc/codecs/rt5677-spi.c | 13 + sound/soc/codecs/rt5677.c | 445 +++++++++++++++++++++++----- sound/soc/codecs/rt5677.h | 11 +- sound/soc/intel/boards/bdw-rt5677.c | 51 ++++ 4 files changed, 447 insertions(+), 73 deletions(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog

2 12

[alsa-devel] [PATCH] ALSA: hda: hdmi - add Tigerlake support
by Kai Vehmanen 05 Nov '19

05 Nov '19

Add Tigerlake HDMI codec support. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205379 BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=112171 Cc: Pan Xiuli <xiuli.pan(a)linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/pci/hda/patch_hdmi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index b72553710ffb..3c720703ebb8 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -2851,6 +2851,18 @@ static int patch_i915_icl_hdmi(struct hda_codec *codec) return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map)); } +static int patch_i915_tgl_hdmi(struct hda_codec *codec) +{ + /* + * pin to port mapping table where the value indicate the pin number and + * the index indicate the port number with 1 base. + */ + static const int map[] = {0x4, 0x6, 0x8, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf}; + + return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map)); +} + + /* Intel Baytrail and Braswell; with eld notifier */ static int patch_i915_byt_hdmi(struct hda_codec *codec) { @@ -4153,6 +4165,7 @@ HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi), HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280f, "Icelake HDMI", patch_i915_icl_hdmi), +HDA_CODEC_ENTRY(0x80862812, "Tigerlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi), HDA_CODEC_ENTRY(0x80862882, "Valleyview2 HDMI", patch_i915_byt_hdmi), HDA_CODEC_ENTRY(0x80862883, "Braswell HDMI", patch_i915_byt_hdmi), -- 2.17.1

3 3

[alsa-devel] [PATCH 0/2] ALSA: pcm: minor enhancements
by Takashi Iwai 05 Nov '19

05 Nov '19

Hi, here are a couple of more small enhnacements on PCM memory allocation stuff. Takashi === Takashi Iwai (2): ALSA: pcm: Warn if doubly preallocated ALSA: pcm: Create proc files only for non-empty preallocations sound/core/pcm_memory.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.16.4

1 2

[alsa-devel] [PATCH v2] ASoC: max98373: replace gpio_request with devm_gpio_request
by Yong Zhi 05 Nov '19

05 Nov '19

Use devm_gpio_request() to automatic unroll when fails and avoid resource leaks at error paths. Signed-off-by: Yong Zhi <yong.zhi(a)intel.com> --- v2 change: - use devm_gpio_request to avoid the goto statement based on review comments. sound/soc/codecs/max98373.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index eb709d528259..cae1def8902d 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -960,11 +960,11 @@ static int max98373_i2c_probe(struct i2c_client *i2c, /* Power on device */ if (gpio_is_valid(max98373->reset_gpio)) { - ret = gpio_request(max98373->reset_gpio, "MAX98373_RESET"); + ret = devm_gpio_request(&i2c->dev, max98373->reset_gpio, + "MAX98373_RESET"); if (ret) { dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", __func__, max98373->reset_gpio); - gpio_free(max98373->reset_gpio); return -EINVAL; } gpio_direction_output(max98373->reset_gpio, 0); -- 2.7.4

3 2

[alsa-devel] [PATCH] ASoC: stm32: sai: add restriction on mmap support
by Olivier Moysan 05 Nov '19

05 Nov '19

Do not support mmap in S/PDIF mode. In S/PDIF mode the buffer has to be copied, to allow the channel status bits insertion. Signed-off-by: Olivier Moysan <olivier.moysan(a)st.com> --- sound/soc/stm/stm32_sai_sub.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index a4060813bc74..48e629ac2d88 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -1218,6 +1218,16 @@ static int stm32_sai_pcm_process_spdif(struct snd_pcm_substream *substream, return 0; } +/* No support of mmap in S/PDIF mode */ +static const struct snd_pcm_hardware stm32_sai_pcm_hw_spdif = { + .info = SNDRV_PCM_INFO_INTERLEAVED, + .buffer_bytes_max = 8 * PAGE_SIZE, + .period_bytes_min = 1024, + .period_bytes_max = PAGE_SIZE, + .periods_min = 2, + .periods_max = 8, +}; + static const struct snd_pcm_hardware stm32_sai_pcm_hw = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_MMAP, .buffer_bytes_max = 8 * PAGE_SIZE, @@ -1270,7 +1280,7 @@ static const struct snd_dmaengine_pcm_config stm32_sai_pcm_config = { }; static const struct snd_dmaengine_pcm_config stm32_sai_pcm_config_spdif = { - .pcm_hardware = &stm32_sai_pcm_hw, + .pcm_hardware = &stm32_sai_pcm_hw_spdif, .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config, .process = stm32_sai_pcm_process_spdif, }; -- 2.17.1

2 1

[alsa-devel] Incorrect buffer handling in dw-hdmi bridge audio
by Takashi Iwai 05 Nov '19

05 Nov '19

Hi, while recently working on the ALSA memory allocator API cleanup, I noticed that dw-hdmi bridge driver seems doing weird about the buffer management. It pre-allocates the usual device buffers fully at the probe time, while each stream allocates the buffer via the vmalloc helpers and replaces with it at each open. I guess it's no expected behavior? It's basically a full waste of resources, and the vmalloc buffer isn't guaranteed to work well for mmap on every architecture. Below is the patch to address it. Can anyone check whether this still works? Since I have a cleanup series and this is involved, I'd like to take the fix through my tree once after it's confirmed (and get ACK if possible). Thanks! Takashi -- 8< -- From: Takashi Iwai <tiwai(a)suse.de> Subject: [PATCH] drm/bridge: dw-hdmi: Fix the incorrect buffer allocations The driver sets up the buffer preallocation with SNDRV_DMA_TYPE_DEV, while it re-allocates and releases vmalloc pages. This is not only a lot of waste resources but also causes the mmap malfunction. Change / drop the vmalloc-related code and use the standard buffer allocation / release code instead. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index 2b7539701b42..8fe7a6e8ff94 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c @@ -384,15 +384,14 @@ static int dw_hdmi_close(struct snd_pcm_substream *substream) static int dw_hdmi_hw_free(struct snd_pcm_substream *substream) { - return snd_pcm_lib_free_vmalloc_buffer(substream); + return snd_pcm_lib_free_pages(substream); } static int dw_hdmi_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { /* Allocate the PCM runtime buffer, which is exposed to userspace. */ - return snd_pcm_lib_alloc_vmalloc_buffer(substream, - params_buffer_bytes(params)); + return snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params)); } static int dw_hdmi_prepare(struct snd_pcm_substream *substream) @@ -511,7 +510,6 @@ static const struct snd_pcm_ops snd_dw_hdmi_ops = { .prepare = dw_hdmi_prepare, .trigger = dw_hdmi_trigger, .pointer = dw_hdmi_pointer, - .page = snd_pcm_lib_get_vmalloc_page, }; static int snd_dw_hdmi_probe(struct platform_device *pdev) -- 2.16.4

3 6