November 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3 00/11] Add Samus Hotwording for RT5677
by Curtis Malainey 06 Nov '19

06 Nov '19

This patch series adds the hotwording implementation used in the Pixelbook on the RT5677 driver. Known Issues: There is a known issue where the system will fail to detect a hotword if suspended while the stream is open. This is due to the fact that the haswell-dsp suspends its I2S MCLK before the RT5677 suspends which causes the writes and reads to become corrupted as a result. Any recommendations to correct this behaviour would be appreciated. Changes since v1: * Addressed Mark's and Kuninori's comments * Adjusted DAI Links * Squashed related patches * Removed all kcontrol writes * Addressed race condition with dapm * Added firmware boot check * Moved all clocking to driver API * Moved DAPM routes that spanned drivers to machine driver Changes since v2: * Updated and removed necessary dapm forced power on * Addressed Cexzary's comments Cc: Dylan Reid <dgreid(a)chromium.org> Cc: Ben Zhang <benzh(a)chromium.org> Ben Zhang (7): ASoC: rt5677: Load firmware via SPI using delayed work ASoC: bdw-rt5677: Add a DAI link for rt5677 SPI PCM device ASoC: rt5677: Enable jack detect while DSP is running ASoC: rt5677: Add DAPM audio path for hotword stream ASoC: rt5677: Mark reg RT5677_PWR_ANLG2 as volatile ASoC: rt5677: Stop and restart DSP over suspend/resume ASoC: rt5677: Disable irq at suspend Curtis Malainey (4): ASoC: rt5677: Allow VAD to be shut on/off at all times ASoC: bdw-rt5677: Turn on MCLK1 for DSP via DAPM ASoC: rt5677: Set ADC clock to use PLL and enable ASRC ASoC: rt5677: Wait for DSP to boot before loading firmware sound/soc/codecs/rt5677-spi.c | 13 + sound/soc/codecs/rt5677.c | 445 +++++++++++++++++++++++----- sound/soc/codecs/rt5677.h | 11 +- sound/soc/intel/boards/bdw-rt5677.c | 51 ++++ 4 files changed, 447 insertions(+), 73 deletions(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog

2 12

[alsa-devel] [PATCH] ALSA: hda: hdmi - add Tigerlake support
by Kai Vehmanen 05 Nov '19

05 Nov '19

Add Tigerlake HDMI codec support. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205379 BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=112171 Cc: Pan Xiuli <xiuli.pan(a)linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/pci/hda/patch_hdmi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index b72553710ffb..3c720703ebb8 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -2851,6 +2851,18 @@ static int patch_i915_icl_hdmi(struct hda_codec *codec) return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map)); } +static int patch_i915_tgl_hdmi(struct hda_codec *codec) +{ + /* + * pin to port mapping table where the value indicate the pin number and + * the index indicate the port number with 1 base. + */ + static const int map[] = {0x4, 0x6, 0x8, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf}; + + return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map)); +} + + /* Intel Baytrail and Braswell; with eld notifier */ static int patch_i915_byt_hdmi(struct hda_codec *codec) { @@ -4153,6 +4165,7 @@ HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi), HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280f, "Icelake HDMI", patch_i915_icl_hdmi), +HDA_CODEC_ENTRY(0x80862812, "Tigerlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi), HDA_CODEC_ENTRY(0x80862882, "Valleyview2 HDMI", patch_i915_byt_hdmi), HDA_CODEC_ENTRY(0x80862883, "Braswell HDMI", patch_i915_byt_hdmi), -- 2.17.1

3 3

[alsa-devel] [PATCH 0/2] ALSA: pcm: minor enhancements
by Takashi Iwai 05 Nov '19

05 Nov '19

Hi, here are a couple of more small enhnacements on PCM memory allocation stuff. Takashi === Takashi Iwai (2): ALSA: pcm: Warn if doubly preallocated ALSA: pcm: Create proc files only for non-empty preallocations sound/core/pcm_memory.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.16.4

1 2

[alsa-devel] [PATCH v2] ASoC: max98373: replace gpio_request with devm_gpio_request
by Yong Zhi 05 Nov '19

05 Nov '19

Use devm_gpio_request() to automatic unroll when fails and avoid resource leaks at error paths. Signed-off-by: Yong Zhi <yong.zhi(a)intel.com> --- v2 change: - use devm_gpio_request to avoid the goto statement based on review comments. sound/soc/codecs/max98373.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index eb709d528259..cae1def8902d 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -960,11 +960,11 @@ static int max98373_i2c_probe(struct i2c_client *i2c, /* Power on device */ if (gpio_is_valid(max98373->reset_gpio)) { - ret = gpio_request(max98373->reset_gpio, "MAX98373_RESET"); + ret = devm_gpio_request(&i2c->dev, max98373->reset_gpio, + "MAX98373_RESET"); if (ret) { dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", __func__, max98373->reset_gpio); - gpio_free(max98373->reset_gpio); return -EINVAL; } gpio_direction_output(max98373->reset_gpio, 0); -- 2.7.4

3 2

[alsa-devel] [PATCH] ASoC: stm32: sai: add restriction on mmap support
by Olivier Moysan 05 Nov '19

05 Nov '19

Do not support mmap in S/PDIF mode. In S/PDIF mode the buffer has to be copied, to allow the channel status bits insertion. Signed-off-by: Olivier Moysan <olivier.moysan(a)st.com> --- sound/soc/stm/stm32_sai_sub.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index a4060813bc74..48e629ac2d88 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -1218,6 +1218,16 @@ static int stm32_sai_pcm_process_spdif(struct snd_pcm_substream *substream, return 0; } +/* No support of mmap in S/PDIF mode */ +static const struct snd_pcm_hardware stm32_sai_pcm_hw_spdif = { + .info = SNDRV_PCM_INFO_INTERLEAVED, + .buffer_bytes_max = 8 * PAGE_SIZE, + .period_bytes_min = 1024, + .period_bytes_max = PAGE_SIZE, + .periods_min = 2, + .periods_max = 8, +}; + static const struct snd_pcm_hardware stm32_sai_pcm_hw = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_MMAP, .buffer_bytes_max = 8 * PAGE_SIZE, @@ -1270,7 +1280,7 @@ static const struct snd_dmaengine_pcm_config stm32_sai_pcm_config = { }; static const struct snd_dmaengine_pcm_config stm32_sai_pcm_config_spdif = { - .pcm_hardware = &stm32_sai_pcm_hw, + .pcm_hardware = &stm32_sai_pcm_hw_spdif, .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config, .process = stm32_sai_pcm_process_spdif, }; -- 2.17.1

2 1

[alsa-devel] Incorrect buffer handling in dw-hdmi bridge audio
by Takashi Iwai 05 Nov '19

05 Nov '19

Hi, while recently working on the ALSA memory allocator API cleanup, I noticed that dw-hdmi bridge driver seems doing weird about the buffer management. It pre-allocates the usual device buffers fully at the probe time, while each stream allocates the buffer via the vmalloc helpers and replaces with it at each open. I guess it's no expected behavior? It's basically a full waste of resources, and the vmalloc buffer isn't guaranteed to work well for mmap on every architecture. Below is the patch to address it. Can anyone check whether this still works? Since I have a cleanup series and this is involved, I'd like to take the fix through my tree once after it's confirmed (and get ACK if possible). Thanks! Takashi -- 8< -- From: Takashi Iwai <tiwai(a)suse.de> Subject: [PATCH] drm/bridge: dw-hdmi: Fix the incorrect buffer allocations The driver sets up the buffer preallocation with SNDRV_DMA_TYPE_DEV, while it re-allocates and releases vmalloc pages. This is not only a lot of waste resources but also causes the mmap malfunction. Change / drop the vmalloc-related code and use the standard buffer allocation / release code instead. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index 2b7539701b42..8fe7a6e8ff94 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c @@ -384,15 +384,14 @@ static int dw_hdmi_close(struct snd_pcm_substream *substream) static int dw_hdmi_hw_free(struct snd_pcm_substream *substream) { - return snd_pcm_lib_free_vmalloc_buffer(substream); + return snd_pcm_lib_free_pages(substream); } static int dw_hdmi_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { /* Allocate the PCM runtime buffer, which is exposed to userspace. */ - return snd_pcm_lib_alloc_vmalloc_buffer(substream, - params_buffer_bytes(params)); + return snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params)); } static int dw_hdmi_prepare(struct snd_pcm_substream *substream) @@ -511,7 +510,6 @@ static const struct snd_pcm_ops snd_dw_hdmi_ops = { .prepare = dw_hdmi_prepare, .trigger = dw_hdmi_trigger, .pointer = dw_hdmi_pointer, - .page = snd_pcm_lib_get_vmalloc_page, }; static int snd_dw_hdmi_probe(struct platform_device *pdev) -- 2.16.4

3 6

[alsa-devel] [PATCH v2] dt-bindings: sound: adau7118: Fix example warning
by Maxime Ripard 05 Nov '19

05 Nov '19

The ADAU7118 has an example where the codec has an i2c address of 14, and the unit address set to 14 as well. However, while the address is expressed in decimal, the unit-address is supposed to be in hexadecimal, which ends up with two different addresses that trigger a DTC warning. Fix this by setting the address to 0x14. Cc: Nuno Sá <nuno.sa(a)analog.com> Cc: Lars-Peter Clausen <lars(a)metafoo.de> Fixes: 969d49b2cdc8 ("dt-bindings: asoc: Add ADAU7118 documentation") Signed-off-by: Maxime Ripard <maxime(a)cerno.tech> --- Changes from v1: - Fix the address instead of the unit-address. --- Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml index c3f10afbdd6f..75e0cbe6be70 100644 --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml @@ -67,7 +67,7 @@ examples: #size-cells = <0>; adau7118_codec: audio-codec@14 { compatible = "adi,adau7118"; - reg = <14>; + reg = <0x14>; #sound-dai-cells = <0>; iovdd-supply = <&supply>; dvdd-supply = <&supply>; -- 2.23.0

2 1

[alsa-devel] [PATCH 00/24] Clean up memalloc callers
by Takashi Iwai 05 Nov '19

05 Nov '19

Hi, this is a trivial cleanup series corresponding to the recent ALSA memalloc API enhancement[1]. Most of patches do simple and systematic changes: either convert to the new way of vmalloc buffer handling, replacing the superfluous snd_dma_continous_data() macro with NULL, or replacing the snd_dma_pci_data() with the direct device pointer assignment. Some have a slightly more changes but they are straightforward enough. Also, a few document updates are provided. There are still a few reminders (noticeably ASoC), and I'll post the patches for them later. Once after all conversions done, we can drop the superfluous API functions and macros. thanks, Takashi [1] https://lore.kernel.org/r/20191105080138.1260-1-tiwai@suse.de === Takashi Iwai (24): ALSA: drivers: Remove superfluous snd_dma_continuous_data() ALSA: mips: Remove superfluous snd_dma_continuous_data() ALSA: rme32: Remove superfluous snd_dma_continuous_data() ALSA: sh: Remove superfluous snd_dma_continuous_data() ALSA: sparc: Remove superfluous snd_dma_continuous_data() ALSA: usb: Remove superfluous snd_dma_continuous_data() ALSA: 6fire: Drop the dead code ALSA: usb-audio: Convert to the common vmalloc memalloc ALSA: aloop: Convert to the common vmalloc memalloc ALSA: firewire: Convert to the common vmalloc memalloc ALSA: 6fire: Convert to the common vmalloc memalloc ALSA: caiaq: Convert to the common vmalloc memalloc ALSA: hiface: Convert to the common vmalloc memalloc ALSA: ua101: Convert to the common vmalloc memalloc ALSA: vx: Convert to the common vmalloc memalloc ALSA: pdaudiocf: Convert to the common vmalloc memalloc ALSA: mips: Convert to the common vmalloc memalloc ALSA: pci: Drop superfluous snd_pcm_sgbuf_ops_page ALSA: aoa: Avoid non-standard macro usage ALSA: echoaudio: Avoid non-standard macro usage ALSA: es1968: Avoid non-standard macro usage ALSA: rme: Avoid non-standard macro usage ALSA: pci: Avoid non-standard macro usage ALSA: docs: Remove snd_dma_pci_data() usage in documentation .../sound/kernel-api/writing-an-alsa-driver.rst | 8 ++-- sound/aoa/soundbus/i2sbus/pcm.c | 2 +- sound/drivers/aloop.c | 8 ++-- sound/drivers/dummy.c | 2 +- sound/drivers/ml403-ac97cr.c | 2 +- sound/drivers/pcsp/pcsp_lib.c | 4 +- sound/drivers/vx/vx_pcm.c | 10 ++--- sound/firewire/bebob/bebob_pcm.c | 9 ++-- sound/firewire/dice/dice-pcm.c | 11 ++--- sound/firewire/digi00x/digi00x-pcm.c | 9 ++-- sound/firewire/fireface/ff-pcm.c | 9 ++-- sound/firewire/fireworks/fireworks_pcm.c | 9 ++-- sound/firewire/isight.c | 8 ++-- sound/firewire/motu/motu-pcm.c | 9 ++-- sound/firewire/oxfw/oxfw-pcm.c | 14 +++--- sound/firewire/tascam/tascam-pcm.c | 9 ++-- sound/mips/hal2.c | 3 +- sound/mips/sgio2audio.c | 12 +++--- sound/pci/ad1889.c | 6 +-- sound/pci/ali5451/ali5451.c | 2 +- sound/pci/als300.c | 3 +- sound/pci/als4000.c | 3 +- sound/pci/asihpi/asihpi.c | 4 +- sound/pci/atiixp.c | 6 +-- sound/pci/atiixp_modem.c | 4 +- sound/pci/au88x0/au88x0_pcm.c | 3 +- sound/pci/aw2/aw2-alsa.c | 6 +-- sound/pci/azt3328.c | 8 ++-- sound/pci/bt87x.c | 5 +-- sound/pci/ca0106/ca0106_main.c | 6 +-- sound/pci/cmipci.c | 6 +-- sound/pci/cs4281.c | 3 +- sound/pci/cs46xx/cs46xx_lib.c | 16 ++++--- sound/pci/cs5535audio/cs5535audio_pcm.c | 6 +-- sound/pci/ctxfi/ctpcm.c | 5 +-- sound/pci/ctxfi/ctvmem.c | 2 +- sound/pci/echoaudio/echoaudio.c | 24 +++-------- sound/pci/emu10k1/emu10k1.c | 5 ++- sound/pci/emu10k1/emu10k1x.c | 6 +-- sound/pci/emu10k1/emufx.c | 2 +- sound/pci/emu10k1/emupcm.c | 12 +++--- sound/pci/emu10k1/memory.c | 4 +- sound/pci/emu10k1/p16v.c | 4 +- sound/pci/ens1370.c | 8 ++-- sound/pci/es1938.c | 3 +- sound/pci/es1968.c | 4 +- sound/pci/fm801.c | 2 +- sound/pci/hda/hda_controller.c | 1 - sound/pci/ice1712/ice1712.c | 9 ++-- sound/pci/ice1712/ice1724.c | 6 +-- sound/pci/intel8x0.c | 4 +- sound/pci/intel8x0m.c | 4 +- sound/pci/korg1212/korg1212.c | 8 ++-- sound/pci/lola/lola.c | 2 +- sound/pci/lola/lola_pcm.c | 5 +-- sound/pci/lx6464es/lx6464es.c | 2 +- sound/pci/maestro3.c | 3 +- sound/pci/mixart/mixart.c | 7 +-- sound/pci/oxygen/oxygen_pcm.c | 10 ++--- sound/pci/pcxhr/pcxhr.c | 4 +- sound/pci/riptide/riptide.c | 6 +-- sound/pci/rme32.c | 4 +- sound/pci/rme9652/hdsp.c | 7 +-- sound/pci/rme9652/hdspm.c | 3 +- sound/pci/rme9652/rme9652.c | 7 +-- sound/pci/sis7019.c | 3 +- sound/pci/sonicvibes.c | 3 +- sound/pci/trident/trident_main.c | 24 ++++++----- sound/pci/via82xx.c | 17 +++----- sound/pci/via82xx_modem.c | 6 +-- sound/pci/ymfpci/ymfpci_main.c | 16 ++++--- sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c | 9 ++-- sound/sh/aica.c | 2 +- sound/sh/sh_dac_audio.c | 2 +- sound/sparc/amd7930.c | 2 +- sound/sparc/dbri.c | 2 +- sound/usb/6fire/pcm.c | 16 +++---- sound/usb/caiaq/audio.c | 8 ++-- sound/usb/hiface/pcm.c | 9 ++-- sound/usb/line6/pcm.c | 4 +- sound/usb/misc/ua101.c | 14 +++--- sound/usb/pcm.c | 50 ++++------------------ sound/usb/usx2y/usbusx2yaudio.c | 4 +- sound/usb/usx2y/usx2yhwdeppcm.c | 4 +- 84 files changed, 266 insertions(+), 327 deletions(-) -- 2.16.4

1 24

[alsa-devel] [PATCH 00/62] Add definition for GPIO direction
by Matti Vaittinen 05 Nov '19

05 Nov '19

The patch series adds definitions for GPIO line directions. For occasional GPIO contributor like me it is always a pain to remember whether 1 or 0 was used for GPIO direction INPUT/OUTPUT. Judging the fact that I removed few comments like: /* Return 0 if output, 1 if input */ /* This means "out" */ return 1; /* input */ return 0; /* output */ it seems at least some others may find it hard to remember too. Adding defines for these values helps us who really have good - but short duration - memory :] Please also see the last patch. It adds warning prints to be emitted from gpiolib if other than defined values are used. This patch can be dropped out if there is a reason for that to still be allowed. This idea comes from RFC series for ROHM BD71828 PMIC and was initially discussed with Linus Walleij here: https://lore.kernel.org/lkml/c06725c3dd34118a324907137758d8b85b3d4043.camel… but as this has no dependencies to BD71828 work (which probably takes a while) I decided to make it independent series. Patches are compile-tested only. I have no HW to really test them. Thus I'd appreciate carefull review. This work is mainly about converting zeros and ones to the new defines but it wouldn't be first time I get it wrong in one of the patches :) Patch 1: - adds the defines Patches 2 - 61: - convert drivers to use new defines Patch 62: - Add warning print if values other than the defines is used for direction. Patches are created on top of Linux v5.4-rc6. -- Matti Vaittinen (62): gpio: Add definition for GPIO direction gpio: gpio-104-dio-48e: Use new GPIO_LINE_DIRECTION gpio: add gpio-104-idi-48: Use new GPIO_LINE_DIRECTION gpio: gpio-104-idio-16: Use new GPIO_LINE_DIRECTION gpio: gpio-74xx-mmio: Use new GPIO_LINE_DIRECTION gpio: gpio-amd-fch: Use new GPIO_LINE_DIRECTION gpio: gpio-aspeed: Use new GPIO_LINE_DIRECTION gpio: gpio-bcm-kona: Use new GPIO_LINE_DIRECTION gpio: gpio-bd70528: Use new GPIO_LINE_DIRECTION gpio: gpio-bd9571mwv: Use new GPIO_LINE_DIRECTION gpio: gpio-dln2: Use new GPIO_LINE_DIRECTION gpio: gpio-exar: Use new GPIO_LINE_DIRECTION gpio: gpio-f7188x: Use new GPIO_LINE_DIRECTION gpio: gpio-gpio-mm: Use new GPIO_LINE_DIRECTION gpio: gpio-htc-egpio: Use new GPIO_LINE_DIRECTION gpio: gpio-ich: Use new GPIO_LINE_DIRECTION gpio: gpio-kempld: Use new GPIO_LINE_DIRECTION gpio: gpio-lp873x: Use new GPIO_LINE_DIRECTION gpio: gpio-lp87565: Use new GPIO_LINE_DIRECTION gpio: gpio-madera: Use new GPIO_LINE_DIRECTION gpio: gpio-max3191x: Use new GPIO_LINE_DIRECTION gpio: gpio-mmio: Use new GPIO_LINE_DIRECTION gpio: gpio-merrifield: Use new GPIO_LINE_DIRECTION gpio: gpio-mockup: Use new GPIO_LINE_DIRECTION gpio: gpio-moxtet: Use new GPIO_LINE_DIRECTION gpio: gpio-mvebu: Use new GPIO_LINE_DIRECTION gpio: gpio-mxs: Use new GPIO_LINE_DIRECTION gpio: gpio-omap: Use new GPIO_LINE_DIRECTION gpio: gpio-pca953x: Use new GPIO_LINE_DIRECTION gpio: gpio-pcie-idio-24: Use new GPIO_LINE_DIRECTION gpio: gpio-pci-idio-16: Use new GPIO_LINE_DIRECTION gpio: gpio-pisosr: Use new GPIO_LINE_DIRECTION gpio: gpio-pl061: Use new GPIO_LINE_DIRECTION gpio: gpio-raspberrypi-exp: Use new GPIO_LINE_DIRECTION gpio: gpio-rcar: Use new GPIO_LINE_DIRECTION gpio: gpio-reg: Use new GPIO_LINE_DIRECTION gpio: gpio-sama5d2-piobu: Use new GPIO_LINE_DIRECTION gpio: gpio-sch311x: Use new GPIO_LINE_DIRECTION gpio: gpio-sch: Use new GPIO_LINE_DIRECTION gpio: gpio-siox: Use new GPIO_LINE_DIRECTION gpio: gpio-stmpe: Use new GPIO_LINE_DIRECTION gpio: gpio-tc3589x: Use new GPIO_LINE_DIRECTION gpio: gpio-tegra186: Use new GPIO_LINE_DIRECTION gpio: gpio-tegra: Use new GPIO_LINE_DIRECTION gpio: gpio-thunderx: Use new GPIO_LINE_DIRECTION gpio: gpio-tpic2810: Use new GPIO_LINE_DIRECTION gpio: gpio-tps65086: Use new GPIO_LINE_DIRECTION gpio: gpio-tps65912: Use new GPIO_LINE_DIRECTION gpio: gpio-tps68470: Use new GPIO_LINE_DIRECTION gpio: gpio-tqmx86: Use new GPIO_LINE_DIRECTION gpio: gpio-ts4900: Use new GPIO_LINE_DIRECTION gpio: gpio-twl4030: Use new GPIO_LINE_DIRECTION gpio: gpio-twl6040: Use new GPIO_LINE_DIRECTION gpio: gpio-uniphier: Use new GPIO_LINE_DIRECTION gpio: gpio-wcove: Use new GPIO_LINE_DIRECTION gpio: gpio-ws16c48: Use new GPIO_LINE_DIRECTION gpio: gpio-xgene: Use new GPIO_LINE_DIRECTION gpio: gpio-xra1403: Use new GPIO_LINE_DIRECTION gpio: gpio-xtensa: Use new GPIO_LINE_DIRECTION gpio: gpio-zynq: Use new GPIO_LINE_DIRECTION gpio: gpio-sa1100: Use new GPIO_LINE_DIRECTION gpiolib: Nag for INPUT direction values other than GPIO_LINE_DIRECTION_IN drivers/gpio/gpio-104-dio-48e.c | 5 ++++- drivers/gpio/gpio-104-idi-48.c | 2 +- drivers/gpio/gpio-104-idio-16.c | 4 ++-- drivers/gpio/gpio-74xx-mmio.c | 5 ++++- drivers/gpio/gpio-amd-fch.c | 2 +- drivers/gpio/gpio-aspeed.c | 7 +++---- drivers/gpio/gpio-bcm-kona.c | 6 +++--- drivers/gpio/gpio-bd70528.c | 8 +++++--- drivers/gpio/gpio-bd9571mwv.c | 4 +++- drivers/gpio/gpio-dln2.c | 6 +++--- drivers/gpio/gpio-exar.c | 5 ++++- drivers/gpio/gpio-f7188x.c | 5 ++++- drivers/gpio/gpio-gpio-mm.c | 5 ++++- drivers/gpio/gpio-htc-egpio.c | 5 ++++- drivers/gpio/gpio-ich.c | 5 ++++- drivers/gpio/gpio-kempld.c | 5 ++++- drivers/gpio/gpio-lp873x.c | 2 +- drivers/gpio/gpio-lp87565.c | 5 ++++- drivers/gpio/gpio-madera.c | 5 ++++- drivers/gpio/gpio-max3191x.c | 2 +- drivers/gpio/gpio-merrifield.c | 5 ++++- drivers/gpio/gpio-mmio.c | 21 +++++++++++++++------ drivers/gpio/gpio-mockup.c | 11 +++-------- drivers/gpio/gpio-moxtet.c | 4 ++-- drivers/gpio/gpio-mvebu.c | 5 ++++- drivers/gpio/gpio-mxs.c | 5 ++++- drivers/gpio/gpio-omap.c | 6 ++++-- drivers/gpio/gpio-pca953x.c | 5 ++++- drivers/gpio/gpio-pci-idio-16.c | 4 ++-- drivers/gpio/gpio-pcie-idio-24.c | 9 ++++++--- drivers/gpio/gpio-pisosr.c | 2 +- drivers/gpio/gpio-pl061.c | 5 ++++- drivers/gpio/gpio-raspberrypi-exp.c | 5 ++++- drivers/gpio/gpio-rcar.c | 5 ++++- drivers/gpio/gpio-reg.c | 3 ++- drivers/gpio/gpio-sa1100.c | 5 ++++- drivers/gpio/gpio-sama5d2-piobu.c | 7 ++++--- drivers/gpio/gpio-sch.c | 5 ++++- drivers/gpio/gpio-sch311x.c | 5 ++++- drivers/gpio/gpio-siox.c | 4 ++-- drivers/gpio/gpio-stmpe.c | 5 ++++- drivers/gpio/gpio-tc3589x.c | 5 ++++- drivers/gpio/gpio-tegra.c | 5 ++++- drivers/gpio/gpio-tegra186.c | 4 ++-- drivers/gpio/gpio-thunderx.c | 5 ++++- drivers/gpio/gpio-tpic2810.c | 2 +- drivers/gpio/gpio-tps65086.c | 2 +- drivers/gpio/gpio-tps65912.c | 4 ++-- drivers/gpio/gpio-tps68470.c | 6 +++--- drivers/gpio/gpio-tqmx86.c | 5 ++++- drivers/gpio/gpio-ts4900.c | 5 ++++- drivers/gpio/gpio-twl4030.c | 10 +++++----- drivers/gpio/gpio-twl6040.c | 3 +-- drivers/gpio/gpio-uniphier.c | 5 ++++- drivers/gpio/gpio-wcove.c | 7 +++++-- drivers/gpio/gpio-ws16c48.c | 5 ++++- drivers/gpio/gpio-xgene.c | 5 ++++- drivers/gpio/gpio-xra1403.c | 5 ++++- drivers/gpio/gpio-xtensa.c | 4 ++-- drivers/gpio/gpio-zynq.c | 7 +++++-- drivers/gpio/gpiolib.c | 16 ++++++++++++++-- include/linux/gpio/driver.h | 3 +++ 62 files changed, 228 insertions(+), 104 deletions(-) -- 2.21.0 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]

5 18

[alsa-devel] [PATCH] ALSA: hda/ca0132 - Fix possible workqueue stall
by Takashi Iwai 05 Nov '19

05 Nov '19

The unsolicited event handler for the headphone jack on CA0132 codec driver tries to reschedule the another delayed work with cancel_delayed_work_sync(). It's no good idea, unfortunately, especially after we changed the work queue to the standard global one; this may lead to a stall because both works are using the same global queue. Fix it by dropping the _sync but does call cancel_delayed_work() instead. Fixes: 993884f6a26c ("ALSA: hda/ca0132 - Delay HP amp turnon.") BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1155836 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_ca0132.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 6d1fb7c11f17..b7a1abb3e231 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -7604,7 +7604,7 @@ static void hp_callback(struct hda_codec *codec, struct hda_jack_callback *cb) /* Delay enabling the HP amp, to let the mic-detection * state machine run. */ - cancel_delayed_work_sync(&spec->unsol_hp_work); + cancel_delayed_work(&spec->unsol_hp_work); schedule_delayed_work(&spec->unsol_hp_work, msecs_to_jiffies(500)); tbl = snd_hda_jack_tbl_get(codec, cb->nid); if (tbl) -- 2.16.4

1 0