November 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v2] dt-bindings: sound: adau7118: Fix example warning
by Maxime Ripard 05 Nov '19

05 Nov '19

The ADAU7118 has an example where the codec has an i2c address of 14, and the unit address set to 14 as well. However, while the address is expressed in decimal, the unit-address is supposed to be in hexadecimal, which ends up with two different addresses that trigger a DTC warning. Fix this by setting the address to 0x14. Cc: Nuno Sá <nuno.sa(a)analog.com> Cc: Lars-Peter Clausen <lars(a)metafoo.de> Fixes: 969d49b2cdc8 ("dt-bindings: asoc: Add ADAU7118 documentation") Signed-off-by: Maxime Ripard <maxime(a)cerno.tech> --- Changes from v1: - Fix the address instead of the unit-address. --- Documentation/devicetree/bindings/sound/adi,adau7118.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml index c3f10afbdd6f..75e0cbe6be70 100644 --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml @@ -67,7 +67,7 @@ examples: #size-cells = <0>; adau7118_codec: audio-codec@14 { compatible = "adi,adau7118"; - reg = <14>; + reg = <0x14>; #sound-dai-cells = <0>; iovdd-supply = <&supply>; dvdd-supply = <&supply>; -- 2.23.0

2 1

[alsa-devel] [PATCH 00/24] Clean up memalloc callers
by Takashi Iwai 05 Nov '19

05 Nov '19

Hi, this is a trivial cleanup series corresponding to the recent ALSA memalloc API enhancement[1]. Most of patches do simple and systematic changes: either convert to the new way of vmalloc buffer handling, replacing the superfluous snd_dma_continous_data() macro with NULL, or replacing the snd_dma_pci_data() with the direct device pointer assignment. Some have a slightly more changes but they are straightforward enough. Also, a few document updates are provided. There are still a few reminders (noticeably ASoC), and I'll post the patches for them later. Once after all conversions done, we can drop the superfluous API functions and macros. thanks, Takashi [1] https://lore.kernel.org/r/20191105080138.1260-1-tiwai@suse.de === Takashi Iwai (24): ALSA: drivers: Remove superfluous snd_dma_continuous_data() ALSA: mips: Remove superfluous snd_dma_continuous_data() ALSA: rme32: Remove superfluous snd_dma_continuous_data() ALSA: sh: Remove superfluous snd_dma_continuous_data() ALSA: sparc: Remove superfluous snd_dma_continuous_data() ALSA: usb: Remove superfluous snd_dma_continuous_data() ALSA: 6fire: Drop the dead code ALSA: usb-audio: Convert to the common vmalloc memalloc ALSA: aloop: Convert to the common vmalloc memalloc ALSA: firewire: Convert to the common vmalloc memalloc ALSA: 6fire: Convert to the common vmalloc memalloc ALSA: caiaq: Convert to the common vmalloc memalloc ALSA: hiface: Convert to the common vmalloc memalloc ALSA: ua101: Convert to the common vmalloc memalloc ALSA: vx: Convert to the common vmalloc memalloc ALSA: pdaudiocf: Convert to the common vmalloc memalloc ALSA: mips: Convert to the common vmalloc memalloc ALSA: pci: Drop superfluous snd_pcm_sgbuf_ops_page ALSA: aoa: Avoid non-standard macro usage ALSA: echoaudio: Avoid non-standard macro usage ALSA: es1968: Avoid non-standard macro usage ALSA: rme: Avoid non-standard macro usage ALSA: pci: Avoid non-standard macro usage ALSA: docs: Remove snd_dma_pci_data() usage in documentation .../sound/kernel-api/writing-an-alsa-driver.rst | 8 ++-- sound/aoa/soundbus/i2sbus/pcm.c | 2 +- sound/drivers/aloop.c | 8 ++-- sound/drivers/dummy.c | 2 +- sound/drivers/ml403-ac97cr.c | 2 +- sound/drivers/pcsp/pcsp_lib.c | 4 +- sound/drivers/vx/vx_pcm.c | 10 ++--- sound/firewire/bebob/bebob_pcm.c | 9 ++-- sound/firewire/dice/dice-pcm.c | 11 ++--- sound/firewire/digi00x/digi00x-pcm.c | 9 ++-- sound/firewire/fireface/ff-pcm.c | 9 ++-- sound/firewire/fireworks/fireworks_pcm.c | 9 ++-- sound/firewire/isight.c | 8 ++-- sound/firewire/motu/motu-pcm.c | 9 ++-- sound/firewire/oxfw/oxfw-pcm.c | 14 +++--- sound/firewire/tascam/tascam-pcm.c | 9 ++-- sound/mips/hal2.c | 3 +- sound/mips/sgio2audio.c | 12 +++--- sound/pci/ad1889.c | 6 +-- sound/pci/ali5451/ali5451.c | 2 +- sound/pci/als300.c | 3 +- sound/pci/als4000.c | 3 +- sound/pci/asihpi/asihpi.c | 4 +- sound/pci/atiixp.c | 6 +-- sound/pci/atiixp_modem.c | 4 +- sound/pci/au88x0/au88x0_pcm.c | 3 +- sound/pci/aw2/aw2-alsa.c | 6 +-- sound/pci/azt3328.c | 8 ++-- sound/pci/bt87x.c | 5 +-- sound/pci/ca0106/ca0106_main.c | 6 +-- sound/pci/cmipci.c | 6 +-- sound/pci/cs4281.c | 3 +- sound/pci/cs46xx/cs46xx_lib.c | 16 ++++--- sound/pci/cs5535audio/cs5535audio_pcm.c | 6 +-- sound/pci/ctxfi/ctpcm.c | 5 +-- sound/pci/ctxfi/ctvmem.c | 2 +- sound/pci/echoaudio/echoaudio.c | 24 +++-------- sound/pci/emu10k1/emu10k1.c | 5 ++- sound/pci/emu10k1/emu10k1x.c | 6 +-- sound/pci/emu10k1/emufx.c | 2 +- sound/pci/emu10k1/emupcm.c | 12 +++--- sound/pci/emu10k1/memory.c | 4 +- sound/pci/emu10k1/p16v.c | 4 +- sound/pci/ens1370.c | 8 ++-- sound/pci/es1938.c | 3 +- sound/pci/es1968.c | 4 +- sound/pci/fm801.c | 2 +- sound/pci/hda/hda_controller.c | 1 - sound/pci/ice1712/ice1712.c | 9 ++-- sound/pci/ice1712/ice1724.c | 6 +-- sound/pci/intel8x0.c | 4 +- sound/pci/intel8x0m.c | 4 +- sound/pci/korg1212/korg1212.c | 8 ++-- sound/pci/lola/lola.c | 2 +- sound/pci/lola/lola_pcm.c | 5 +-- sound/pci/lx6464es/lx6464es.c | 2 +- sound/pci/maestro3.c | 3 +- sound/pci/mixart/mixart.c | 7 +-- sound/pci/oxygen/oxygen_pcm.c | 10 ++--- sound/pci/pcxhr/pcxhr.c | 4 +- sound/pci/riptide/riptide.c | 6 +-- sound/pci/rme32.c | 4 +- sound/pci/rme9652/hdsp.c | 7 +-- sound/pci/rme9652/hdspm.c | 3 +- sound/pci/rme9652/rme9652.c | 7 +-- sound/pci/sis7019.c | 3 +- sound/pci/sonicvibes.c | 3 +- sound/pci/trident/trident_main.c | 24 ++++++----- sound/pci/via82xx.c | 17 +++----- sound/pci/via82xx_modem.c | 6 +-- sound/pci/ymfpci/ymfpci_main.c | 16 ++++--- sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c | 9 ++-- sound/sh/aica.c | 2 +- sound/sh/sh_dac_audio.c | 2 +- sound/sparc/amd7930.c | 2 +- sound/sparc/dbri.c | 2 +- sound/usb/6fire/pcm.c | 16 +++---- sound/usb/caiaq/audio.c | 8 ++-- sound/usb/hiface/pcm.c | 9 ++-- sound/usb/line6/pcm.c | 4 +- sound/usb/misc/ua101.c | 14 +++--- sound/usb/pcm.c | 50 ++++------------------ sound/usb/usx2y/usbusx2yaudio.c | 4 +- sound/usb/usx2y/usx2yhwdeppcm.c | 4 +- 84 files changed, 266 insertions(+), 327 deletions(-) -- 2.16.4

1 24

[alsa-devel] [PATCH 00/62] Add definition for GPIO direction
by Matti Vaittinen 05 Nov '19

05 Nov '19

The patch series adds definitions for GPIO line directions. For occasional GPIO contributor like me it is always a pain to remember whether 1 or 0 was used for GPIO direction INPUT/OUTPUT. Judging the fact that I removed few comments like: /* Return 0 if output, 1 if input */ /* This means "out" */ return 1; /* input */ return 0; /* output */ it seems at least some others may find it hard to remember too. Adding defines for these values helps us who really have good - but short duration - memory :] Please also see the last patch. It adds warning prints to be emitted from gpiolib if other than defined values are used. This patch can be dropped out if there is a reason for that to still be allowed. This idea comes from RFC series for ROHM BD71828 PMIC and was initially discussed with Linus Walleij here: https://lore.kernel.org/lkml/c06725c3dd34118a324907137758d8b85b3d4043.camel… but as this has no dependencies to BD71828 work (which probably takes a while) I decided to make it independent series. Patches are compile-tested only. I have no HW to really test them. Thus I'd appreciate carefull review. This work is mainly about converting zeros and ones to the new defines but it wouldn't be first time I get it wrong in one of the patches :) Patch 1: - adds the defines Patches 2 - 61: - convert drivers to use new defines Patch 62: - Add warning print if values other than the defines is used for direction. Patches are created on top of Linux v5.4-rc6. -- Matti Vaittinen (62): gpio: Add definition for GPIO direction gpio: gpio-104-dio-48e: Use new GPIO_LINE_DIRECTION gpio: add gpio-104-idi-48: Use new GPIO_LINE_DIRECTION gpio: gpio-104-idio-16: Use new GPIO_LINE_DIRECTION gpio: gpio-74xx-mmio: Use new GPIO_LINE_DIRECTION gpio: gpio-amd-fch: Use new GPIO_LINE_DIRECTION gpio: gpio-aspeed: Use new GPIO_LINE_DIRECTION gpio: gpio-bcm-kona: Use new GPIO_LINE_DIRECTION gpio: gpio-bd70528: Use new GPIO_LINE_DIRECTION gpio: gpio-bd9571mwv: Use new GPIO_LINE_DIRECTION gpio: gpio-dln2: Use new GPIO_LINE_DIRECTION gpio: gpio-exar: Use new GPIO_LINE_DIRECTION gpio: gpio-f7188x: Use new GPIO_LINE_DIRECTION gpio: gpio-gpio-mm: Use new GPIO_LINE_DIRECTION gpio: gpio-htc-egpio: Use new GPIO_LINE_DIRECTION gpio: gpio-ich: Use new GPIO_LINE_DIRECTION gpio: gpio-kempld: Use new GPIO_LINE_DIRECTION gpio: gpio-lp873x: Use new GPIO_LINE_DIRECTION gpio: gpio-lp87565: Use new GPIO_LINE_DIRECTION gpio: gpio-madera: Use new GPIO_LINE_DIRECTION gpio: gpio-max3191x: Use new GPIO_LINE_DIRECTION gpio: gpio-mmio: Use new GPIO_LINE_DIRECTION gpio: gpio-merrifield: Use new GPIO_LINE_DIRECTION gpio: gpio-mockup: Use new GPIO_LINE_DIRECTION gpio: gpio-moxtet: Use new GPIO_LINE_DIRECTION gpio: gpio-mvebu: Use new GPIO_LINE_DIRECTION gpio: gpio-mxs: Use new GPIO_LINE_DIRECTION gpio: gpio-omap: Use new GPIO_LINE_DIRECTION gpio: gpio-pca953x: Use new GPIO_LINE_DIRECTION gpio: gpio-pcie-idio-24: Use new GPIO_LINE_DIRECTION gpio: gpio-pci-idio-16: Use new GPIO_LINE_DIRECTION gpio: gpio-pisosr: Use new GPIO_LINE_DIRECTION gpio: gpio-pl061: Use new GPIO_LINE_DIRECTION gpio: gpio-raspberrypi-exp: Use new GPIO_LINE_DIRECTION gpio: gpio-rcar: Use new GPIO_LINE_DIRECTION gpio: gpio-reg: Use new GPIO_LINE_DIRECTION gpio: gpio-sama5d2-piobu: Use new GPIO_LINE_DIRECTION gpio: gpio-sch311x: Use new GPIO_LINE_DIRECTION gpio: gpio-sch: Use new GPIO_LINE_DIRECTION gpio: gpio-siox: Use new GPIO_LINE_DIRECTION gpio: gpio-stmpe: Use new GPIO_LINE_DIRECTION gpio: gpio-tc3589x: Use new GPIO_LINE_DIRECTION gpio: gpio-tegra186: Use new GPIO_LINE_DIRECTION gpio: gpio-tegra: Use new GPIO_LINE_DIRECTION gpio: gpio-thunderx: Use new GPIO_LINE_DIRECTION gpio: gpio-tpic2810: Use new GPIO_LINE_DIRECTION gpio: gpio-tps65086: Use new GPIO_LINE_DIRECTION gpio: gpio-tps65912: Use new GPIO_LINE_DIRECTION gpio: gpio-tps68470: Use new GPIO_LINE_DIRECTION gpio: gpio-tqmx86: Use new GPIO_LINE_DIRECTION gpio: gpio-ts4900: Use new GPIO_LINE_DIRECTION gpio: gpio-twl4030: Use new GPIO_LINE_DIRECTION gpio: gpio-twl6040: Use new GPIO_LINE_DIRECTION gpio: gpio-uniphier: Use new GPIO_LINE_DIRECTION gpio: gpio-wcove: Use new GPIO_LINE_DIRECTION gpio: gpio-ws16c48: Use new GPIO_LINE_DIRECTION gpio: gpio-xgene: Use new GPIO_LINE_DIRECTION gpio: gpio-xra1403: Use new GPIO_LINE_DIRECTION gpio: gpio-xtensa: Use new GPIO_LINE_DIRECTION gpio: gpio-zynq: Use new GPIO_LINE_DIRECTION gpio: gpio-sa1100: Use new GPIO_LINE_DIRECTION gpiolib: Nag for INPUT direction values other than GPIO_LINE_DIRECTION_IN drivers/gpio/gpio-104-dio-48e.c | 5 ++++- drivers/gpio/gpio-104-idi-48.c | 2 +- drivers/gpio/gpio-104-idio-16.c | 4 ++-- drivers/gpio/gpio-74xx-mmio.c | 5 ++++- drivers/gpio/gpio-amd-fch.c | 2 +- drivers/gpio/gpio-aspeed.c | 7 +++---- drivers/gpio/gpio-bcm-kona.c | 6 +++--- drivers/gpio/gpio-bd70528.c | 8 +++++--- drivers/gpio/gpio-bd9571mwv.c | 4 +++- drivers/gpio/gpio-dln2.c | 6 +++--- drivers/gpio/gpio-exar.c | 5 ++++- drivers/gpio/gpio-f7188x.c | 5 ++++- drivers/gpio/gpio-gpio-mm.c | 5 ++++- drivers/gpio/gpio-htc-egpio.c | 5 ++++- drivers/gpio/gpio-ich.c | 5 ++++- drivers/gpio/gpio-kempld.c | 5 ++++- drivers/gpio/gpio-lp873x.c | 2 +- drivers/gpio/gpio-lp87565.c | 5 ++++- drivers/gpio/gpio-madera.c | 5 ++++- drivers/gpio/gpio-max3191x.c | 2 +- drivers/gpio/gpio-merrifield.c | 5 ++++- drivers/gpio/gpio-mmio.c | 21 +++++++++++++++------ drivers/gpio/gpio-mockup.c | 11 +++-------- drivers/gpio/gpio-moxtet.c | 4 ++-- drivers/gpio/gpio-mvebu.c | 5 ++++- drivers/gpio/gpio-mxs.c | 5 ++++- drivers/gpio/gpio-omap.c | 6 ++++-- drivers/gpio/gpio-pca953x.c | 5 ++++- drivers/gpio/gpio-pci-idio-16.c | 4 ++-- drivers/gpio/gpio-pcie-idio-24.c | 9 ++++++--- drivers/gpio/gpio-pisosr.c | 2 +- drivers/gpio/gpio-pl061.c | 5 ++++- drivers/gpio/gpio-raspberrypi-exp.c | 5 ++++- drivers/gpio/gpio-rcar.c | 5 ++++- drivers/gpio/gpio-reg.c | 3 ++- drivers/gpio/gpio-sa1100.c | 5 ++++- drivers/gpio/gpio-sama5d2-piobu.c | 7 ++++--- drivers/gpio/gpio-sch.c | 5 ++++- drivers/gpio/gpio-sch311x.c | 5 ++++- drivers/gpio/gpio-siox.c | 4 ++-- drivers/gpio/gpio-stmpe.c | 5 ++++- drivers/gpio/gpio-tc3589x.c | 5 ++++- drivers/gpio/gpio-tegra.c | 5 ++++- drivers/gpio/gpio-tegra186.c | 4 ++-- drivers/gpio/gpio-thunderx.c | 5 ++++- drivers/gpio/gpio-tpic2810.c | 2 +- drivers/gpio/gpio-tps65086.c | 2 +- drivers/gpio/gpio-tps65912.c | 4 ++-- drivers/gpio/gpio-tps68470.c | 6 +++--- drivers/gpio/gpio-tqmx86.c | 5 ++++- drivers/gpio/gpio-ts4900.c | 5 ++++- drivers/gpio/gpio-twl4030.c | 10 +++++----- drivers/gpio/gpio-twl6040.c | 3 +-- drivers/gpio/gpio-uniphier.c | 5 ++++- drivers/gpio/gpio-wcove.c | 7 +++++-- drivers/gpio/gpio-ws16c48.c | 5 ++++- drivers/gpio/gpio-xgene.c | 5 ++++- drivers/gpio/gpio-xra1403.c | 5 ++++- drivers/gpio/gpio-xtensa.c | 4 ++-- drivers/gpio/gpio-zynq.c | 7 +++++-- drivers/gpio/gpiolib.c | 16 ++++++++++++++-- include/linux/gpio/driver.h | 3 +++ 62 files changed, 228 insertions(+), 104 deletions(-) -- 2.21.0 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]

5 18

[alsa-devel] [PATCH] ALSA: hda/ca0132 - Fix possible workqueue stall
by Takashi Iwai 05 Nov '19

05 Nov '19

The unsolicited event handler for the headphone jack on CA0132 codec driver tries to reschedule the another delayed work with cancel_delayed_work_sync(). It's no good idea, unfortunately, especially after we changed the work queue to the standard global one; this may lead to a stall because both works are using the same global queue. Fix it by dropping the _sync but does call cancel_delayed_work() instead. Fixes: 993884f6a26c ("ALSA: hda/ca0132 - Delay HP amp turnon.") BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1155836 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_ca0132.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 6d1fb7c11f17..b7a1abb3e231 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -7604,7 +7604,7 @@ static void hp_callback(struct hda_codec *codec, struct hda_jack_callback *cb) /* Delay enabling the HP amp, to let the mic-detection * state machine run. */ - cancel_delayed_work_sync(&spec->unsol_hp_work); + cancel_delayed_work(&spec->unsol_hp_work); schedule_delayed_work(&spec->unsol_hp_work, msecs_to_jiffies(500)); tbl = snd_hda_jack_tbl_get(codec, cb->nid); if (tbl) -- 2.16.4

1 0

[alsa-devel] [PATCH] ASoC: bdw-rt5677: enable runtime channel merge
by Brent Lu 05 Nov '19

05 Nov '19

In the DAI link "Capture PCM", the FE DAI "Capture Pin" supports 4-channel capture but the BE DAI supports only 2-channel capture. To fix the channel mismatch, we need to enable the runtime channel merge for this DAI link. Signed-off-by: Brent Lu <brent.lu(a)intel.com> --- sound/soc/intel/boards/bdw-rt5677.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/bdw-rt5677.c b/sound/soc/intel/boards/bdw-rt5677.c index 4a4d335..8d07038 100644 --- a/sound/soc/intel/boards/bdw-rt5677.c +++ b/sound/soc/intel/boards/bdw-rt5677.c @@ -273,6 +273,7 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = { }, .dpcm_capture = 1, .dpcm_playback = 1, + .dpcm_merged_chan = 1, SND_SOC_DAILINK_REG(fe, dummy, platform), }, -- 2.7.4

3 4

[alsa-devel] amixer: "5%-" or "5%+" doesn't work with cset
by GitHub issues - opened 05 Nov '19

05 Nov '19

alsa-project/alsa-utils issue #32 was opened from MarioMey: I want to raise and low volume with keys. This works, this rise the volume 20%: `amixer set Master 20%+` And every time I run this command, it rise 20% more. But, when I want to use the card (because I need to do this): `amixer -c 0 cset name='Master Playback Volume' 20%+` It doesn't work. It seems that amixer takes only "20%" value and doesn't care about "+" or "-". I have Debian Buster, Mate desktop. ``` mario@debian:~/$ apt-cache showpkg alsa-tools Package: alsa-tools Versions: 1.1.7-1 (/var/lib/apt/lists/ftp.us.debian.org_debian_dists_buster_main_binary-amd64_Packages) Description Language: File: /var/lib/apt/lists/ftp.us.debian.org_debian_dists_buster_main_binary-amd64_Packages MD5: 4d64eace7e51fb1fc1a18ed780ee5e62 Description Language: en File: /var/lib/apt/lists/ftp.us.debian.org_debian_dists_buster_main_i18n_Translation-en MD5: 4d64eace7e51fb1fc1a18ed780ee5e62 Reverse Depends: ld10k1,alsa-tools multimedia-jack,alsa-tools Dependencies: 1.1.7-1 - libasound2 (2 1.0.16) libc6 (2 2.7) libgcc1 (2 1:3.0) libglib2.0-0 (2 2.12.0) libstdc++6 (2 5) as10k1 (0 (null)) as10k1 (0 (null)) Provides: 1.1.7-1 - as10k1 (= ) Reverse Provides: ``` Issue URL : https://github.com/alsa-project/alsa-utils/issues/32 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[alsa-devel] tegra30 tdm support
by Ben Dooks 05 Nov '19

05 Nov '19

New series for TDM audio support on tegra30 v2: - moved edge-control and data-offset to the set_fmt callbacks - fixed dev_dbg in set_tdm callback - fixed dev_dbg message contents in set_tdm callback - changed fsync width to be permanently 1 clock v3: - cleanup fsync patch - fix rebase issue with tdm patch v4: - fix comment style issues - change tdm-a to data-offset 1

3 12

[alsa-devel] [PATCH 20/62] gpio: gpio-madera: Use new GPIO_LINE_DIRECTION
by Matti Vaittinen 05 Nov '19

05 Nov '19

It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen <matti.vaittinen(a)fi.rohmeurope.com> --- drivers/gpio/gpio-madera.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-madera.c b/drivers/gpio/gpio-madera.c index 7086f8b5388f..8f38303fcbc4 100644 --- a/drivers/gpio/gpio-madera.c +++ b/drivers/gpio/gpio-madera.c @@ -34,7 +34,10 @@ static int madera_gpio_get_direction(struct gpio_chip *chip, if (ret < 0) return ret; - return !!(val & MADERA_GP1_DIR_MASK); + if (val & MADERA_GP1_DIR_MASK) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; } static int madera_gpio_direction_in(struct gpio_chip *chip, unsigned int offset) -- 2.21.0 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]

1 0

[alsa-devel] [PATCH] ALSA: hda: Disable regmap internal locking
by Takashi Iwai 05 Nov '19

05 Nov '19

Since we apply the own mutex (bus->cmd_mutex) in HDA core side, the internal locking in regmap is superfluous. This patch adds the flag to indicate that. Also, an infamous side-effect by this change is that it disables the regmap debugfs, too, and this is seen rather good; the regmap debugfs isn't quite useful for HD-audio as it provides the very sparse registers and its debugfs access tends to lead to the way too high resource usages or sometimes hang up. So it'd be rather safe to disable it altogether. Link: https://lore.kernel.org/r/2029139028.10333037.1572874551626.JavaMail.zimbra… Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/hda/hdac_regmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c index 286361ecd640..906b1e20bae0 100644 --- a/sound/hda/hdac_regmap.c +++ b/sound/hda/hdac_regmap.c @@ -363,6 +363,7 @@ static const struct regmap_config hda_regmap_cfg = { .reg_write = hda_reg_write, .use_single_read = true, .use_single_write = true, + .disable_locking = true, }; /** -- 2.16.4

1 0

[alsa-devel] [PATCH v2 resend 00/18] ASoC: soc-core cleanup - step 4
by Kuninori Morimoto 05 Nov '19

05 Nov '19

Hi Mark These are resend of soc-core cleanup step4. These are based on mark/for-5.5 branch. I already got report from Intel that these had no issue on Intel CI machine. Kuninori Morimoto (18): ASoC: soc-core: remove unneeded snd_soc_tplg_component_remove() ASoC: soc-core: move soc_init_dai_link() ASoC: soc-core: tidyup soc_init_dai_link() ASoC: soc-core: remove duplicated soc_is_dai_link_bound() ASoC: soc-core: call soc_bind_dai_link() under snd_soc_add_dai_link() ASoC: soc-core: add soc_unbind_dai_link() ASoC: soc-core: move snd_soc_lookup_component() ASoC: soc-core: add snd_soc_del_component_unlocked() ASoC: soc-core: remove snd_soc_component_add/del() ASoC: soc-core: use snd_soc_lookup_component() at snd_soc_unregister_component() ASoC: soc-core: move snd_soc_register_dai() ASoC: soc-core: move snd_soc_unregister_dais() ASoC: soc-core: add snd_soc_unregister_dai() ASoC: soc-core: have legacy_dai_naming at snd_soc_register_dai() ASoC: soc-core: don't call snd_soc_dapm_new_dai_widgets() at snd_soc_register_dai() ASoC: soc-core: call snd_soc_register_dai() from snd_soc_register_dais() ASoC: soc-core: remove topology specific operation ASoC: soc.h: dobj is used only when SND_SOC_TOPOLOGY include/sound/soc.h | 15 +- sound/soc/soc-core.c | 536 +++++++++++++++++++++-------------------------- sound/soc/soc-topology.c | 17 +- 3 files changed, 263 insertions(+), 305 deletions(-) -- 2.7.4

5 35