October 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] axfer: call of polling system call never return when driver fails to queue no period-wakeup event due to the lack of hw IRQ context
by GitHub issues - edited 29 Oct '19

29 Oct '19

alsa-project/alsa-utils issue #30 was edited from takaswie: Axfer calls polling system call(i.e. poll(2), epoll(7), select(7)) without explicit timeout when running for IRQ-based scheduling model. In a case that driver achieves to control sound hardware for periodical hardware IRQ, the call can return due to any event queued by the driver in hardware IRQ context. However, in a case that driver fails to control it, the call cannot return. Especially, this situation easily occurs when developers work to support hardware newly. It's better to care for the situation. How to reproduce: 1. prepare sound hardware which driver fail to control for periodical hardware IRQ. 2. execute axfer for the driver/hardware with options to: * use IRQ-based scheduling model: `--sched-model=irq` * use polling system call: without `--test-nowait` 3. the running process blocks as a call of polling system call (defaultly poll(2) by snd_pcm_wait()) Issue URL : https://github.com/alsa-project/alsa-utils/issues/30 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[alsa-devel] axfer: call of polling system call never return when driver fails to queue any events due to the lack of hw IRQ context
by GitHub issues - opened 29 Oct '19

29 Oct '19

alsa-project/alsa-utils issue #30 was opened from takaswie: Axfer calls polling system call(i.e. poll(2), epoll(7), select(7)) without explicit timeout when running for IRQ-based scheduling model. In a case that driver achieves to control sound hardware for periodical hardware IRQ, the call can return due to any event queued by the driver in hardware IRQ context. However, in a case that driver fails to control it, the call cannot return. Especially, this situation easily occurs when developers work to support hardware newly. It's better to care for the situation. How to reproduce: 1. prepare sound hardware which driver fail to control for periodical hardware IRQ. 2. execute axfer for the driver/hardware with options to: * use IRQ-based scheduling model: `--sched-model=irq` * use polling system call: without `--test-nowait` 3. the running process blocks as a call of polling system call (defaultly poll(2) by snd_pcm_wait()) Issue URL : https://github.com/alsa-project/alsa-utils/issues/30 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[alsa-devel] [PATCH v8 0/6] Add HDMI jack support on RK3288
by Cheng-Yi Chiang 29 Oct '19

29 Oct '19

This patch series supports HDMI jack reporting on RK3288, which uses DRM dw-hdmi driver and hdmi-codec codec driver. The previous discussion about reporting jack status using hdmi-notifier and drm_audio_component is at https://lore.kernel.org/patchwork/patch/1083027/ The new approach is to use a callback mechanism that is specific to hdmi-codec. The dependent change on hdmi-codec.c 6fa5963c37a2 ASoC: hdmi-codec: Add an op to set callback function for plug event has been merged to upstream. Changes from v7 to v8: 1. rockchip_max98090: Allow three different use cases: max98090-only: For backward compatibility where DTS does not specify HDMI node. HDMI-only: For HDMI-only board like veyron-mickey. max98090 + HDMI: For other veyron boards. Pass different compatible string to specify the use case. 2. Add more maintainers to cc-list for new device property reviewing. Cheng-Yi Chiang (6): drm: bridge: dw-hdmi: Report connector status using callback ASoC: rockchip-max98090: Support usage with and without HDMI ASoC: rockchip_max98090: Optionally support HDMI use case ASoC: rockchip_max98090: Add HDMI jack support ARM: dts: rockchip: Add HDMI support to rk3288-veyron-analog-audio ARM: dts: rockchip: Add HDMI audio support to rk3288-veyron-mickey.dts .../bindings/sound/rockchip-max98090.txt | 38 +- .../boot/dts/rk3288-veyron-analog-audio.dtsi | 3 +- arch/arm/boot/dts/rk3288-veyron-mickey.dts | 7 + .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 11 + drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 41 +- include/drm/bridge/dw_hdmi.h | 4 + sound/soc/rockchip/Kconfig | 3 +- sound/soc/rockchip/rockchip_max98090.c | 392 +++++++++++++++--- 8 files changed, 425 insertions(+), 74 deletions(-) -- 2.24.0.rc0.303.g954a862665-goog

3 12

[alsa-devel] [PATCH 0/2] Update adau7118 dt-bindings
by Nuno Sá 29 Oct '19

29 Oct '19

This is a follow-up patch as requested by Rob. The dt-bindings patch for this device was applied before Rob's review. Here is the link to the review: https://lore.kernel.org/alsa-devel/20191010210850.GA20184@bogus/ Nuno Sá (2): dt-bindings: asoc: adau7118: Cleanup ASOC: adau7118: Change regulators id .../bindings/sound/adi,adau7118.yaml | 25 ++++++++----------- sound/soc/codecs/adau7118.c | 4 +-- 2 files changed, 12 insertions(+), 17 deletions(-) -- 2.23.0

4 5

[alsa-devel] [PATCH] Revert "ALSA: hda: Flush interrupts on disabling"
by Takashi Iwai 28 Oct '19

28 Oct '19

This reverts commit caa8422d01e983782548648e125fd617cadcec3f. It turned out that this commit caused a regression at shutdown / reboot, as the synchronize_irq() calls seems blocking the whole shutdown. Also another part of the change about shuffling the call order looks suspicious; the azx_stop_chip() call disables the CORB / RIRB while the others may still need the CORB/RIRB update. Since the original commit itself was a cargo-fix, let's revert the whole patch. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205333 Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/hda/hdac_controller.c | 2 -- sound/pci/hda/hda_intel.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c index d3999e7b0705..7e7be8e4dcf9 100644 --- a/sound/hda/hdac_controller.c +++ b/sound/hda/hdac_controller.c @@ -447,8 +447,6 @@ static void azx_int_disable(struct hdac_bus *bus) list_for_each_entry(azx_dev, &bus->stream_list, list) snd_hdac_stream_updateb(azx_dev, SD_CTL, SD_INT_MASK, 0); - synchronize_irq(bus->irq); - /* disable SIE for all streams */ snd_hdac_chip_writeb(bus, INTCTL, 0); diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index a815bc811799..cf53fbd872ee 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1348,9 +1348,9 @@ static int azx_free(struct azx *chip) } if (bus->chip_init) { - azx_stop_chip(chip); azx_clear_irq_pending(chip); azx_stop_all_streams(chip); + azx_stop_chip(chip); } if (bus->irq >= 0) -- 2.16.4

3 4

[alsa-devel] [PATCH v7 0/9] adapt SOF to use snd-hda-codec-hdmi
by Kai Vehmanen 28 Oct '19

28 Oct '19

Hey, here's the 7th round for this series that adapts SOF to use snd-hda-codec-hdmi (patch_hdmi.c) codec driver instead of hdac_hdmi (soc/codecs/hdac_hdmi.c). The primary goal is to unify the HDMI codec implementation between DSP and non-DSP HDA configurations, offer same interface to user-space and reduce maintenance load for all. v7 changes: - Only change since v6 is moving inlined logic from hda_dsp_common.h to hda_dsp_common.c and related changes to machine driver make rules. This is to address Takashi's feedback. - Rebased on top of Mark's tree (agreed with Takashi and Pierre to submit via Mark's ASoC tree). Feature and testing info: - Tested on multiple Intel platforms supported by SOF. - Tested with ALSA console tools as well as with Pulseaudio. - requires Pulseaudio 12.x or newer, see https://lists.freedesktop.org/archives/pulseaudio-discuss/2019-August/03135… - HDMI, DP, DP-MST with multi-monitor use-scenarios work ok. - New feature for SOF: ELD /proc fs works just like in DSP-less mode. - New feature for SOF: jack detection works out-of-the-box with Pulseaudio (no need for card specific UCM for HDMI) Kai Vehmanen (9): ALSA: hda/hdmi - implement mst_no_extra_pcms flag ASoC: hdac_hda: add support for HDMI/DP as a HDA codec ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi ASoC: Intel: skl-hda-dsp-generic: fix include guard name ASoC: SOF: Intel: add support for snd-hda-codec-hdmi ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support ASoC: Intel: glk_rt5682_max98357a: common hdmi codec support ASoC: intel: sof_rt5682: common hdmi codec support ASoC: Intel: bxt_rt298: common hdmi codec support include/sound/hda_codec.h | 1 + include/sound/soc-acpi.h | 2 + sound/pci/hda/patch_hdmi.c | 19 ++- sound/soc/codecs/hdac_hda.c | 114 ++++++++++++++++-- sound/soc/codecs/hdac_hda.h | 13 +- sound/soc/intel/boards/Makefile | 10 +- sound/soc/intel/boards/bxt_da7219_max98357a.c | 11 ++ sound/soc/intel/boards/bxt_rt298.c | 11 ++ sound/soc/intel/boards/glk_rt5682_max98357a.c | 11 ++ sound/soc/intel/boards/hda_dsp_common.c | 85 +++++++++++++ sound/soc/intel/boards/hda_dsp_common.h | 32 +++++ sound/soc/intel/boards/skl_hda_dsp_common.c | 10 +- sound/soc/intel/boards/skl_hda_dsp_common.h | 27 ++++- sound/soc/intel/boards/skl_hda_dsp_generic.c | 1 + sound/soc/intel/boards/sof_rt5682.c | 11 ++ sound/soc/sof/intel/Kconfig | 10 ++ sound/soc/sof/intel/hda-codec.c | 22 +++- sound/soc/sof/intel/hda.c | 6 + sound/soc/sof/intel/hda.h | 6 +- 19 files changed, 370 insertions(+), 32 deletions(-) create mode 100644 sound/soc/intel/boards/hda_dsp_common.c create mode 100644 sound/soc/intel/boards/hda_dsp_common.h -- 2.17.1

3 15

[alsa-devel] [PATCH] ASoC: intel - fix the card names
by Jaroslav Kysela 28 Oct '19

28 Oct '19

Those strings are exposed to the user space as the card name thus used in the GUIs. The common standard is to avoid '_' here. The worst case is 'sof-skl_hda_card' string. Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> Cc: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Cc: Mark Brown <broonie(a)kernel.org> --- sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 +- sound/soc/intel/boards/skl_hda_dsp_generic.c | 2 +- sound/soc/intel/boards/sof_rt5682.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c index 74dda8784f1a..d14ca327c684 100644 --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c @@ -623,7 +623,7 @@ static int kabylake_card_late_probe(struct snd_soc_card *card) * kabylake audio machine driver for MAX98927 + RT5514 + RT5663 */ static struct snd_soc_card kabylake_audio_card = { - .name = "kbl_r5514_5663_max", + .name = "kbl-r5514-5663-max", .owner = THIS_MODULE, .dai_link = kabylake_dais, .num_links = ARRAY_SIZE(kabylake_dais), diff --git a/sound/soc/intel/boards/skl_hda_dsp_generic.c b/sound/soc/intel/boards/skl_hda_dsp_generic.c index 1778acdc367c..5261f7bf0b3b 100644 --- a/sound/soc/intel/boards/skl_hda_dsp_generic.c +++ b/sound/soc/intel/boards/skl_hda_dsp_generic.c @@ -90,7 +90,7 @@ skl_hda_add_dai_link(struct snd_soc_card *card, struct snd_soc_dai_link *link) } static struct snd_soc_card hda_soc_card = { - .name = "skl_hda_card", + .name = "skl-hda", .owner = THIS_MODULE, .dai_link = skl_hda_be_dai_links, .dapm_widgets = skl_hda_widgets, diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c index 4f6e58c3954a..fc4638b8e03b 100644 --- a/sound/soc/intel/boards/sof_rt5682.c +++ b/sound/soc/intel/boards/sof_rt5682.c @@ -370,7 +370,7 @@ static int dmic_init(struct snd_soc_pcm_runtime *rtd) /* sof audio machine driver for rt5682 codec */ static struct snd_soc_card sof_audio_card_rt5682 = { - .name = "sof_rt5682", + .name = "sof-rt5682", .owner = THIS_MODULE, .controls = sof_controls, .num_controls = ARRAY_SIZE(sof_controls), -- 2.20.1

2 2

[alsa-devel] [PATCH] ALSA: usb-audio: Fix memory leak in __snd_usbmidi_create
by Navid Emamdoost 28 Oct '19

28 Oct '19

In the implementation of __snd_usbmidi_create() there is a memory leak caused by incorrect goto destination. Go to free_midi if snd_usbmidi_create_endpoints_midiman() or snd_usbmidi_create_endpoints() fail. Fixes: 731209cc0417 ("ALSA: usb-midi: Use common error handling code in __snd_usbmidi_create()") Signed-off-by: Navid Emamdoost <navid.emamdoost(a)gmail.com> --- sound/usb/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/midi.c b/sound/usb/midi.c index b737f0ec77d0..22db37fbfbbd 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card, else err = snd_usbmidi_create_endpoints(umidi, endpoints); if (err < 0) - goto exit; + goto free_midi; usb_autopm_get_interface_no_resume(umidi->iface); -- 2.17.1

3 5

[alsa-devel] [PATCH] ASoC: SOF: ipc: Fix memory leak in sof_set_get_large_ctrl_data
by Navid Emamdoost 28 Oct '19

28 Oct '19

In the implementation of sof_set_get_large_ctrl_data() there is a memory leak in case an error. Release partdata if sof_get_ctrl_copy_params() fails. Fixes: 54d198d5019d ("ASoC: SOF: Propagate sof_get_ctrl_copy_params() error properly") Signed-off-by: Navid Emamdoost <navid.emamdoost(a)gmail.com> --- sound/soc/sof/ipc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/ipc.c b/sound/soc/sof/ipc.c index b2f359d2f7e5..086eeeab8679 100644 --- a/sound/soc/sof/ipc.c +++ b/sound/soc/sof/ipc.c @@ -572,8 +572,10 @@ static int sof_set_get_large_ctrl_data(struct snd_sof_dev *sdev, else err = sof_get_ctrl_copy_params(cdata->type, partdata, cdata, sparams); - if (err < 0) + if (err < 0) { + kfree(partdata); return err; + } msg_bytes = sparams->msg_bytes; pl_size = sparams->pl_size; -- 2.17.1

3 3

[alsa-devel] [PATCH] ASoC: SOF: Fix memory leak in sof_dfsentry_write
by Navid Emamdoost 28 Oct '19

28 Oct '19

In the implementation of sof_dfsentry_write() memory allocated for string is leaked in case of an error. Go to error handling path if the d_name.name is not valid. Fixes: 091c12e1f50c ("ASoC: SOF: debug: add new debugfs entries for IPC flood test") Signed-off-by: Navid Emamdoost <navid.emamdoost(a)gmail.com> --- sound/soc/sof/debug.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c index 54cd431faab7..5529e8eeca46 100644 --- a/sound/soc/sof/debug.c +++ b/sound/soc/sof/debug.c @@ -152,8 +152,10 @@ static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer, */ dentry = file->f_path.dentry; if (strcmp(dentry->d_name.name, "ipc_flood_count") && - strcmp(dentry->d_name.name, "ipc_flood_duration_ms")) - return -EINVAL; + strcmp(dentry->d_name.name, "ipc_flood_duration_ms")) { + ret = -EINVAL; + goto out; + } if (!strcmp(dentry->d_name.name, "ipc_flood_duration_ms")) flood_duration_test = true; -- 2.17.1

3 2