January 2019 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3 0/5] Stripe control functionality
by Sameer Pujar 14 Jan '19

14 Jan '19

Background ========== Azalia Controller fetches command and audio data via DMA and send them to codec through SDO(Serial Data Out) lines. SDO is for outboung and it broadcasts to all codecs. There is atleast one SDO line present, but there can be multiple SDO lines supported for extended bandwidth. This is essential when a platform supports multiple hdmi/dp sinks and there is a requirement for higher resolution audio playback. In such cases simultaneous audio playback data can be striped across multiple SDOs. Global Capabilities(GCAP) Register indicates the capabilities of the controller. Bits 2:1 of GCAP can be read to know the number of supported SDO lines (below is from HD audio spec) 00: 1 SDO 01: 2 SDO 10: 4 SDO 11: Reserved Stripe control verb reports and controls the stripe capability of an Audio Output Converter. This verb needs to be implemented only for an audio output converter and only if the stripe bit of the Audio Widget Capabilities parameter is 1. Stripe control: get code(0xf24) and set code(0x724) Change log ========== v1-->v2: -------- Patch 1: "ALSA: hda: add verbs for stripe control" * no change Patch 2: "ALSA: hda: Add api to program stripe control bits" * no change Patch 3: "ALSA: hda: add register offset for stripe control" * added mask for stripe control programming Patch 4: "ALSA: hda: program stripe bits for controller" * used stripe control mask instead of hard coded value Patch 5: "ALSA: hda: program stripe control for codec" * added conditional check to know if striping is supported. If supported, then only stripe verb is implemented. v2-->v3: -------- Patch 1: "ALSA: hda: add verbs for stripe control" * no change Patch 2: "ALSA: hda: Add api to program stripe control bits" * added braces around stripe value calucation as per spec Patch 3: "ALSA: hda: add register offset for stripe control" * no change Patch 4: "ALSA: hda: program stripe bits for controller" * no change Patch 5: "ALSA: hda: program stripe control for codec" * no change =========== Sameer Pujar (5): ALSA: hda: add verbs for stripe control ALSA: hda: Add api to program stripe control bits ALSA: hda: add register offset for stripe control ALSA: hda: program stripe bits for controller ALSA: hda: program stripe control for codec include/sound/hda_register.h | 2 ++ include/sound/hda_verbs.h | 2 ++ include/sound/hdaudio.h | 3 +++ sound/hda/hdac_stream.c | 40 ++++++++++++++++++++++++++++++++++++++++ sound/pci/hda/patch_hdmi.c | 10 +++++++++- 5 files changed, 56 insertions(+), 1 deletion(-) -- 2.7.4 ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------

2 6

[alsa-devel] [PATCH 1/3] drm/i915/audio: Track temporary rpm wakerefs
by Chris Wilson 14 Jan '19

14 Jan '19

Track the temporary rpm wakerefs used within audio so that they may be marked as complete and the tracking cancelled upon release. Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> --- drivers/gpu/drm/i915/intel_audio.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index de26cd0a5497..92e27359c2e3 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c @@ -756,12 +756,13 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, bool enable) { struct drm_i915_private *dev_priv = kdev_to_i915(kdev); + intel_wakeref_t wakeref; u32 tmp; if (!IS_GEN(dev_priv, 9)) return; - i915_audio_component_get_power(kdev); + wakeref = intel_display_power_get(dev_priv, POWER_DOMAIN_AUDIO); /* * Enable/disable generating the codec wake signal, overriding the @@ -779,7 +780,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, usleep_range(1000, 1500); } - i915_audio_component_put_power(kdev); + intel_display_power_put(dev_priv, POWER_DOMAIN_AUDIO, wakeref); } /* Get CDCLK in kHz */ @@ -850,12 +851,13 @@ static int i915_audio_component_sync_audio_rate(struct device *kdev, int port, struct i915_audio_component *acomp = dev_priv->audio_component; struct intel_encoder *encoder; struct intel_crtc *crtc; + intel_wakeref_t wakeref; int err = 0; if (!HAS_DDI(dev_priv)) return 0; - i915_audio_component_get_power(kdev); + wakeref = intel_display_power_get(dev_priv, POWER_DOMAIN_AUDIO); mutex_lock(&dev_priv->av_mutex); /* 1. get the pipe */ @@ -875,7 +877,7 @@ static int i915_audio_component_sync_audio_rate(struct device *kdev, int port, unlock: mutex_unlock(&dev_priv->av_mutex); - i915_audio_component_put_power(kdev); + intel_display_power_put(dev_priv, POWER_DOMAIN_AUDIO, wakeref); return err; } -- 2.20.1

3 10

[alsa-devel] [PATCH v2 0/5] Stripe control functionality
by Sameer Pujar 14 Jan '19

14 Jan '19

Background ========== Azalia Controller fetches command and audio data via DMA and send them to codec through SDO(Serial Data Out) lines. SDO is for outboung and it broadcasts to all codecs. There is atleast one SDO line present, but there can be multiple SDO lines supported for extended bandwidth. This is essential when a platform supports multiple hdmi/dp sinks and there is a requirement for higher resolution audio playback. In such cases simultaneous audio playback data can be striped across multiple SDOs. Global Capabilities(GCAP) Register indicates the capabilities of the controller. Bits 2:1 of GCAP can be read to know the number of supported SDO lines (below is from HD audio spec) 00: 1 SDO 01: 2 SDO 10: 4 SDO 11: Reserved Stripe control verb reports and controls the stripe capability of an Audio Output Converter. This verb needs to be implemented only for an audio output converter and only if the stripe bit of the Audio Widget Capabilities parameter is 1. Stripe control: get code(0xf24) and set code(0x724) Change log ========== v1-->v2: -------- Patch 1: "ALSA: hda: add verbs for stripe control" * no change Patch 2: "ALSA: hda: Add api to program stripe control bits" * no change Patch 3: "ALSA: hda: add register offset for stripe control" * added mask for stripe control programming Patch 4: "ALSA: hda: program stripe bits for controller" * used stripe control mask instead of hard coded value Patch 5: "ALSA: hda: program stripe control for codec" * added conditional check to know if striping is supported. If supported, then only stripe verb is implemented. =========== Sameer Pujar (5): ALSA: hda: add verbs for stripe control ALSA: hda: Add api to program stripe control bits ALSA: hda: add register offset for stripe control ALSA: hda: program stripe bits for controller ALSA: hda: program stripe control for codec include/sound/hda_register.h | 2 ++ include/sound/hda_verbs.h | 2 ++ include/sound/hdaudio.h | 3 +++ sound/hda/hdac_stream.c | 40 ++++++++++++++++++++++++++++++++++++++++ sound/pci/hda/patch_hdmi.c | 10 +++++++++- 5 files changed, 56 insertions(+), 1 deletion(-) -- 2.7.4 ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------

2 11

[alsa-devel] [PATCH 0/4] slimbus: minor fixes.
by Srinivas Kandagatla 14 Jan '19

14 Jan '19

Here are some minor fixes to slimbus core for issues found while testing wcd9335. First one is make the slimbus core match full device id, second one is to avoid using big lock in status callback function, third one is to use status function rather than directly invoking the status ops. finally last one is to fix missing spinlock init. Thanks, srini Srinivas Kandagatla (4): slimbus: core: match full device id slimbus: core: do not call device_status under a lock slimbus: core: use slim_device_update_status() to update status slimbus: core: add missing spin_lock_init on txn_lock drivers/slimbus/core.c | 45 +++++++++++++++++++++++------------------- 1 file changed, 25 insertions(+), 20 deletions(-) -- 2.20.1

2 6

[alsa-devel] next/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on bcm2837-rpi-3-b-32
by kernelci.org bot 14 Jan '19

14 Jan '19

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on bcm2837-rpi-3-b-32 Summary: Start: 727b373740d1 Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes' Details: https://kernelci.org/boot/id/5c3c42c459b5145f216edd41 Plain log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1… HTML log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1… Result: 8780cf1142a5 ASoC: soc-core: defer card probe until all component is added to list Checks: revert: PASS verify: PASS Parameters: Tree: next URL: http://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: pending-fixes Target: bcm2837-rpi-3-b-32 CPU arch: arm Lab: lab-baylibre Config: bcm2835_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81 Author: Ajit Pandey <ajitp(a)codeaurora.org> Date: Wed Jan 9 14:17:07 2019 +0530 ASoC: soc-core: defer card probe until all component is added to list DAI component probe is not called if it is not present in component list during sound card registration. Check if component is available in component list for platform and cpu dai before soundcard registration. Signed-off-by: Ajit Pandey <ajitp(a)codeaurora.org> Signed-off-by: Rohit kumar <rohitkr(a)codeaurora.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 0462b3ec977a..eec92f17dd15 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card, struct snd_soc_dai_link *dai_link) { struct snd_soc_dai_link_component *platform = dai_link->platform; - /* * FIXME * @@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if platform dai component is not added to + * component list. + */ + if (!soc_find_component(link->platform->of_node, link->platform->name)) + return -EPROBE_DEFER; + /* * CPU device may be specified by either name or OF node, but * can be left unspecified, and will be matched based on DAI @@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if cpu dai component is not added to + * component list. + */ + if (!soc_find_component(link->cpu_of_node, link->cpu_name)) + return -EPROBE_DEFER; + /* * At least one of CPU DAI name or CPU device name/node must be * specified ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [6b529fb0a3eabf9c4cc3e94c11477250379ce6d8] Merge tag 'for-5.0-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux git bisect good 6b529fb0a3eabf9c4cc3e94c11477250379ce6d8 # bad: [727b373740d1d3c6d3273cfc6e81d5e9a229b12d] Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes' git bisect bad 727b373740d1d3c6d3273cfc6e81d5e9a229b12d # good: [34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d] Merge remote-tracking branch 'net/master' git bisect good 34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d # bad: [52bb35a9520ac1746fb34687c5582695813aa00a] Merge remote-tracking branch 'char-misc.current/char-misc-linus' git bisect bad 52bb35a9520ac1746fb34687c5582695813aa00a # bad: [4baf5101d553aae944fa7dc7bd13772eb559d78b] Merge remote-tracking branch 'sound-asoc-fixes/for-linus' git bisect bad 4baf5101d553aae944fa7dc7bd13772eb559d78b # good: [49ff71f99a8826eda5cee76b69f15600d1cbf4b2] Merge remote-tracking branch 'rdma-fixes/for-rc' git bisect good 49ff71f99a8826eda5cee76b69f15600d1cbf4b2 # good: [678e2b44c8e3fec3afc7202f1996a4500a50be93] ALSA: compress: prevent potential divide by zero bugs git bisect good 678e2b44c8e3fec3afc7202f1996a4500a50be93 # good: [667e9334fa64da2273e36ce131b05ac9e47c5769] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode git bisect good 667e9334fa64da2273e36ce131b05ac9e47c5769 # bad: [239b8b34a856777e562373ae0de605536a7ccade] ASoC: Intel: Boards: move the codec PLL configuration to _init git bisect bad 239b8b34a856777e562373ae0de605536a7ccade # bad: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list git bisect bad 8780cf1142a59568a3aa77959cbd76b2edb6fd81 # good: [44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages git bisect good 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 # first bad commit: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list -------------------------------------------------------------------------------

1 0

[alsa-devel] next/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on sun8i-h3-libretech-all-h3-cc
by kernelci.org bot 14 Jan '19

14 Jan '19

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on sun8i-h3-libretech-all-h3-cc Summary: Start: 727b373740d1 Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes' Details: https://kernelci.org/boot/id/5c3c423359b5145dde6edd37 Plain log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1… HTML log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1… Result: 8780cf1142a5 ASoC: soc-core: defer card probe until all component is added to list Checks: revert: PASS verify: PASS Parameters: Tree: next URL: http://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: pending-fixes Target: sun8i-h3-libretech-all-h3-cc CPU arch: arm Lab: lab-baylibre Config: sunxi_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81 Author: Ajit Pandey <ajitp(a)codeaurora.org> Date: Wed Jan 9 14:17:07 2019 +0530 ASoC: soc-core: defer card probe until all component is added to list DAI component probe is not called if it is not present in component list during sound card registration. Check if component is available in component list for platform and cpu dai before soundcard registration. Signed-off-by: Ajit Pandey <ajitp(a)codeaurora.org> Signed-off-by: Rohit kumar <rohitkr(a)codeaurora.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 0462b3ec977a..eec92f17dd15 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card, struct snd_soc_dai_link *dai_link) { struct snd_soc_dai_link_component *platform = dai_link->platform; - /* * FIXME * @@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if platform dai component is not added to + * component list. + */ + if (!soc_find_component(link->platform->of_node, link->platform->name)) + return -EPROBE_DEFER; + /* * CPU device may be specified by either name or OF node, but * can be left unspecified, and will be matched based on DAI @@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if cpu dai component is not added to + * component list. + */ + if (!soc_find_component(link->cpu_of_node, link->cpu_name)) + return -EPROBE_DEFER; + /* * At least one of CPU DAI name or CPU device name/node must be * specified ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [6b529fb0a3eabf9c4cc3e94c11477250379ce6d8] Merge tag 'for-5.0-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux git bisect good 6b529fb0a3eabf9c4cc3e94c11477250379ce6d8 # bad: [727b373740d1d3c6d3273cfc6e81d5e9a229b12d] Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes' git bisect bad 727b373740d1d3c6d3273cfc6e81d5e9a229b12d # good: [34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d] Merge remote-tracking branch 'net/master' git bisect good 34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d # bad: [52bb35a9520ac1746fb34687c5582695813aa00a] Merge remote-tracking branch 'char-misc.current/char-misc-linus' git bisect bad 52bb35a9520ac1746fb34687c5582695813aa00a # bad: [4baf5101d553aae944fa7dc7bd13772eb559d78b] Merge remote-tracking branch 'sound-asoc-fixes/for-linus' git bisect bad 4baf5101d553aae944fa7dc7bd13772eb559d78b # good: [49ff71f99a8826eda5cee76b69f15600d1cbf4b2] Merge remote-tracking branch 'rdma-fixes/for-rc' git bisect good 49ff71f99a8826eda5cee76b69f15600d1cbf4b2 # good: [678e2b44c8e3fec3afc7202f1996a4500a50be93] ALSA: compress: prevent potential divide by zero bugs git bisect good 678e2b44c8e3fec3afc7202f1996a4500a50be93 # good: [667e9334fa64da2273e36ce131b05ac9e47c5769] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode git bisect good 667e9334fa64da2273e36ce131b05ac9e47c5769 # bad: [239b8b34a856777e562373ae0de605536a7ccade] ASoC: Intel: Boards: move the codec PLL configuration to _init git bisect bad 239b8b34a856777e562373ae0de605536a7ccade # bad: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list git bisect bad 8780cf1142a59568a3aa77959cbd76b2edb6fd81 # good: [44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages git bisect good 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 # first bad commit: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list -------------------------------------------------------------------------------

1 0

[alsa-devel] next/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on sun8i-h2-plus-libretech-all-h3-cc
by kernelci.org bot 14 Jan '19

14 Jan '19

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on sun8i-h2-plus-libretech-all-h3-cc Summary: Start: 727b373740d1 Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes' Details: https://kernelci.org/boot/id/5c3c41f159b5145bec6edd6d Plain log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1… HTML log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1… Result: 8780cf1142a5 ASoC: soc-core: defer card probe until all component is added to list Checks: revert: PASS verify: PASS Parameters: Tree: next URL: http://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: pending-fixes Target: sun8i-h2-plus-libretech-all-h3-cc CPU arch: arm Lab: lab-baylibre Config: sunxi_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81 Author: Ajit Pandey <ajitp(a)codeaurora.org> Date: Wed Jan 9 14:17:07 2019 +0530 ASoC: soc-core: defer card probe until all component is added to list DAI component probe is not called if it is not present in component list during sound card registration. Check if component is available in component list for platform and cpu dai before soundcard registration. Signed-off-by: Ajit Pandey <ajitp(a)codeaurora.org> Signed-off-by: Rohit kumar <rohitkr(a)codeaurora.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 0462b3ec977a..eec92f17dd15 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card, struct snd_soc_dai_link *dai_link) { struct snd_soc_dai_link_component *platform = dai_link->platform; - /* * FIXME * @@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if platform dai component is not added to + * component list. + */ + if (!soc_find_component(link->platform->of_node, link->platform->name)) + return -EPROBE_DEFER; + /* * CPU device may be specified by either name or OF node, but * can be left unspecified, and will be matched based on DAI @@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if cpu dai component is not added to + * component list. + */ + if (!soc_find_component(link->cpu_of_node, link->cpu_name)) + return -EPROBE_DEFER; + /* * At least one of CPU DAI name or CPU device name/node must be * specified ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [6b529fb0a3eabf9c4cc3e94c11477250379ce6d8] Merge tag 'for-5.0-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux git bisect good 6b529fb0a3eabf9c4cc3e94c11477250379ce6d8 # bad: [727b373740d1d3c6d3273cfc6e81d5e9a229b12d] Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes' git bisect bad 727b373740d1d3c6d3273cfc6e81d5e9a229b12d # good: [34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d] Merge remote-tracking branch 'net/master' git bisect good 34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d # bad: [52bb35a9520ac1746fb34687c5582695813aa00a] Merge remote-tracking branch 'char-misc.current/char-misc-linus' git bisect bad 52bb35a9520ac1746fb34687c5582695813aa00a # bad: [4baf5101d553aae944fa7dc7bd13772eb559d78b] Merge remote-tracking branch 'sound-asoc-fixes/for-linus' git bisect bad 4baf5101d553aae944fa7dc7bd13772eb559d78b # good: [49ff71f99a8826eda5cee76b69f15600d1cbf4b2] Merge remote-tracking branch 'rdma-fixes/for-rc' git bisect good 49ff71f99a8826eda5cee76b69f15600d1cbf4b2 # good: [678e2b44c8e3fec3afc7202f1996a4500a50be93] ALSA: compress: prevent potential divide by zero bugs git bisect good 678e2b44c8e3fec3afc7202f1996a4500a50be93 # good: [667e9334fa64da2273e36ce131b05ac9e47c5769] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode git bisect good 667e9334fa64da2273e36ce131b05ac9e47c5769 # bad: [239b8b34a856777e562373ae0de605536a7ccade] ASoC: Intel: Boards: move the codec PLL configuration to _init git bisect bad 239b8b34a856777e562373ae0de605536a7ccade # bad: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list git bisect bad 8780cf1142a59568a3aa77959cbd76b2edb6fd81 # good: [44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages git bisect good 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 # first bad commit: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list -------------------------------------------------------------------------------

1 0

[alsa-devel] next/master boot bisection: next-20190114 on sun8i-h2-plus-libretech-all-h3-cc
by kernelci.org bot 14 Jan '19

14 Jan '19

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/master boot bisection: next-20190114 on sun8i-h2-plus-libretech-all-h3-cc Summary: Start: 8ce4d582f564 Add linux-next specific files for 20190114 Details: https://kernelci.org/boot/id/5c3c411659b51457a76edd34 Plain log: https://storage.kernelci.org//next/master/next-20190114/arm/sunxi_defconfig… HTML log: https://storage.kernelci.org//next/master/next-20190114/arm/sunxi_defconfig… Result: 8780cf1142a5 ASoC: soc-core: defer card probe until all component is added to list Checks: revert: PASS verify: PASS Parameters: Tree: next URL: http://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: master Target: sun8i-h2-plus-libretech-all-h3-cc CPU arch: arm Lab: lab-baylibre Config: sunxi_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81 Author: Ajit Pandey <ajitp(a)codeaurora.org> Date: Wed Jan 9 14:17:07 2019 +0530 ASoC: soc-core: defer card probe until all component is added to list DAI component probe is not called if it is not present in component list during sound card registration. Check if component is available in component list for platform and cpu dai before soundcard registration. Signed-off-by: Ajit Pandey <ajitp(a)codeaurora.org> Signed-off-by: Rohit kumar <rohitkr(a)codeaurora.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 0462b3ec977a..eec92f17dd15 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card, struct snd_soc_dai_link *dai_link) { struct snd_soc_dai_link_component *platform = dai_link->platform; - /* * FIXME * @@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if platform dai component is not added to + * component list. + */ + if (!soc_find_component(link->platform->of_node, link->platform->name)) + return -EPROBE_DEFER; + /* * CPU device may be specified by either name or OF node, but * can be left unspecified, and will be matched based on DAI @@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if cpu dai component is not added to + * component list. + */ + if (!soc_find_component(link->cpu_of_node, link->cpu_name)) + return -EPROBE_DEFER; + /* * At least one of CPU DAI name or CPU device name/node must be * specified ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [6b529fb0a3eabf9c4cc3e94c11477250379ce6d8] Merge tag 'for-5.0-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux git bisect good 6b529fb0a3eabf9c4cc3e94c11477250379ce6d8 # bad: [8ce4d582f5647052b86f364a070aa26268810d7e] Add linux-next specific files for 20190114 git bisect bad 8ce4d582f5647052b86f364a070aa26268810d7e # bad: [bb937d2e6697b49f6e3fa55ec09951ebbc8717ac] Merge remote-tracking branch 'crypto/master' git bisect bad bb937d2e6697b49f6e3fa55ec09951ebbc8717ac # bad: [04bab95e799a00ffe1b2980e1c786ac9a94f8026] Merge remote-tracking branch 'renesas/next' git bisect bad 04bab95e799a00ffe1b2980e1c786ac9a94f8026 # bad: [5726796d7b631fe9af2202c1ce66232a79984a19] Merge remote-tracking branch 'devicetree-fixes/dt/linus' git bisect bad 5726796d7b631fe9af2202c1ce66232a79984a19 # good: [34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d] Merge remote-tracking branch 'net/master' git bisect good 34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d # bad: [e1faf5c97ee3194c3f3e0b5dc86b3e1490c323d9] Merge remote-tracking branch 'usb-serial-fixes/usb-linus' git bisect bad e1faf5c97ee3194c3f3e0b5dc86b3e1490c323d9 # good: [49ff71f99a8826eda5cee76b69f15600d1cbf4b2] Merge remote-tracking branch 'rdma-fixes/for-rc' git bisect good 49ff71f99a8826eda5cee76b69f15600d1cbf4b2 # bad: [04eb1efcd614d6f067b76a355b3a3599667959dc] ASoC: soc-core: Hold client_mutex around soc_init_dai_link() git bisect bad 04eb1efcd614d6f067b76a355b3a3599667959dc # good: [a41d9dbf5dac5b6a1283ee8001f22807d18352ea] ASoC: qdsp6: q6asm-dai: Fix a small memory leak git bisect good a41d9dbf5dac5b6a1283ee8001f22807d18352ea # good: [6175471755075d256c1c654151fc1cad183c1e33] ASoC: ti: davinci-mcasp: Move context save/restore to runtime_pm callbacks git bisect good 6175471755075d256c1c654151fc1cad183c1e33 # good: [44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages git bisect good 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 # bad: [239b8b34a856777e562373ae0de605536a7ccade] ASoC: Intel: Boards: move the codec PLL configuration to _init git bisect bad 239b8b34a856777e562373ae0de605536a7ccade # bad: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list git bisect bad 8780cf1142a59568a3aa77959cbd76b2edb6fd81 # first bad commit: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list -------------------------------------------------------------------------------

2 1

[alsa-devel] next/master boot bisection: next-20190114 on sun8i-h3-libretech-all-h3-cc
by kernelci.org bot 14 Jan '19

14 Jan '19

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/master boot bisection: next-20190114 on sun8i-h3-libretech-all-h3-cc Summary: Start: 8ce4d582f564 Add linux-next specific files for 20190114 Details: https://kernelci.org/boot/id/5c3c41ac59b5145b496edd2a Plain log: https://storage.kernelci.org//next/master/next-20190114/arm/sunxi_defconfig… HTML log: https://storage.kernelci.org//next/master/next-20190114/arm/sunxi_defconfig… Result: 8780cf1142a5 ASoC: soc-core: defer card probe until all component is added to list Checks: revert: PASS verify: PASS Parameters: Tree: next URL: http://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: master Target: sun8i-h3-libretech-all-h3-cc CPU arch: arm Lab: lab-baylibre Config: sunxi_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81 Author: Ajit Pandey <ajitp(a)codeaurora.org> Date: Wed Jan 9 14:17:07 2019 +0530 ASoC: soc-core: defer card probe until all component is added to list DAI component probe is not called if it is not present in component list during sound card registration. Check if component is available in component list for platform and cpu dai before soundcard registration. Signed-off-by: Ajit Pandey <ajitp(a)codeaurora.org> Signed-off-by: Rohit kumar <rohitkr(a)codeaurora.org> Signed-off-by: Mark Brown <broonie(a)kernel.org> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 0462b3ec977a..eec92f17dd15 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card, struct snd_soc_dai_link *dai_link) { struct snd_soc_dai_link_component *platform = dai_link->platform; - /* * FIXME * @@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if platform dai component is not added to + * component list. + */ + if (!soc_find_component(link->platform->of_node, link->platform->name)) + return -EPROBE_DEFER; + /* * CPU device may be specified by either name or OF node, but * can be left unspecified, and will be matched based on DAI @@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card, link->name); return -EINVAL; } + + /* + * Defer card registartion if cpu dai component is not added to + * component list. + */ + if (!soc_find_component(link->cpu_of_node, link->cpu_name)) + return -EPROBE_DEFER; + /* * At least one of CPU DAI name or CPU device name/node must be * specified ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [6b529fb0a3eabf9c4cc3e94c11477250379ce6d8] Merge tag 'for-5.0-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux git bisect good 6b529fb0a3eabf9c4cc3e94c11477250379ce6d8 # bad: [8ce4d582f5647052b86f364a070aa26268810d7e] Add linux-next specific files for 20190114 git bisect bad 8ce4d582f5647052b86f364a070aa26268810d7e # bad: [bb937d2e6697b49f6e3fa55ec09951ebbc8717ac] Merge remote-tracking branch 'crypto/master' git bisect bad bb937d2e6697b49f6e3fa55ec09951ebbc8717ac # bad: [04bab95e799a00ffe1b2980e1c786ac9a94f8026] Merge remote-tracking branch 'renesas/next' git bisect bad 04bab95e799a00ffe1b2980e1c786ac9a94f8026 # bad: [5726796d7b631fe9af2202c1ce66232a79984a19] Merge remote-tracking branch 'devicetree-fixes/dt/linus' git bisect bad 5726796d7b631fe9af2202c1ce66232a79984a19 # good: [34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d] Merge remote-tracking branch 'net/master' git bisect good 34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d # bad: [e1faf5c97ee3194c3f3e0b5dc86b3e1490c323d9] Merge remote-tracking branch 'usb-serial-fixes/usb-linus' git bisect bad e1faf5c97ee3194c3f3e0b5dc86b3e1490c323d9 # good: [49ff71f99a8826eda5cee76b69f15600d1cbf4b2] Merge remote-tracking branch 'rdma-fixes/for-rc' git bisect good 49ff71f99a8826eda5cee76b69f15600d1cbf4b2 # bad: [04eb1efcd614d6f067b76a355b3a3599667959dc] ASoC: soc-core: Hold client_mutex around soc_init_dai_link() git bisect bad 04eb1efcd614d6f067b76a355b3a3599667959dc # good: [a41d9dbf5dac5b6a1283ee8001f22807d18352ea] ASoC: qdsp6: q6asm-dai: Fix a small memory leak git bisect good a41d9dbf5dac5b6a1283ee8001f22807d18352ea # good: [6175471755075d256c1c654151fc1cad183c1e33] ASoC: ti: davinci-mcasp: Move context save/restore to runtime_pm callbacks git bisect good 6175471755075d256c1c654151fc1cad183c1e33 # good: [44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages git bisect good 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 # bad: [239b8b34a856777e562373ae0de605536a7ccade] ASoC: Intel: Boards: move the codec PLL configuration to _init git bisect bad 239b8b34a856777e562373ae0de605536a7ccade # bad: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list git bisect bad 8780cf1142a59568a3aa77959cbd76b2edb6fd81 # first bad commit: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list -------------------------------------------------------------------------------

1 0

[alsa-devel] Fix model typo
by Kailang 14 Jan '19

14 Jan '19

Hi Takashi, Attach patch was fix typo for alc225 model name. BR, Kailang

2 1