March 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] linux-next on n900: oops in codec_reg_show() when grepping sysfs
by Pavel Machek 08 Mar '18

08 Mar '18

Hi! pavel@n900:/sys$ uname -a Linux n900 4.16.0-rc4-next-20180308 #71 Thu Mar 8 15:27:49 CET 2018 armv7l GNU/Linux pavel@n900:/sys$ grep -ri fasdfasdf . leads to an oops: [ 2278.331878] DSS: context saved [ 2278.820343] Unable to handle kernel NULL pointer dereference at virtual address 00000004 [ 2278.828948] pgd = c36040a2 [ 2278.831787] [00000004] *pgd=876c4831, *pte=00000000, *ppte=00000000 [ 2278.838439] Internal error: Oops: 17 [#1] ARM [ 2278.843017] Modules linked in: [ 2278.846221] CPU: 0 PID: 16337 Comm: grep Tainted: G W 4.16.0-rc4-next-20180308 #71 [ 2278.855529] Hardware name: Nokia RX-51 board [ 2278.860015] PC is at soc_codec_reg_show+0x8/0x19c [ 2278.864959] LR is at codec_reg_show+0x28/0x30 [ 2278.869506] pc : [<c0598f84>] lr : [<c0599140>] psr: a0000013 [ 2278.876098] sp : ce063e10 ip : cd7a9000 fp : 00000001 [ 2278.881561] r10: cd7a8000 r9 : c0842a04 r8 : 00001000 [ 2278.887023] r7 : 00000fff r6 : ce69fd80 r5 : 00000000 r4 : 00000000 [ 2278.893890] r3 : ce5d2000 r2 : 00001000 r1 : cd7a8000 r0 : 00000000 [ 2278.900726] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 2278.908203] Control: 10c5387d Table: 87664019 DAC: 00000051 [ 2278.914215] Process grep (pid: 16337, stack limit = 0x2c91d92b) [ 2278.920410] Stack: (0xce063e10 to 0xce064000) [ 2278.924987] 3e00: ce063ed0 00000000 00000000 ce063ed0 [ 2278.933563] 3e20: 00000000 00000000 00000000 c01e113c 00000000 ce063ed0 ce063f74 c01e5068 [ 2278.942138] 3e40: c059c388 00000000 00000000 ce69fd80 00000fff 00001000 c0842a04 cd7a8000 [ 2278.950714] 3e60: 00000001 c0599140 00000000 00000000 00000040 c7699200 c0c4a0c8 c0412f14 [ 2278.959289] 3e80: c0412ef8 c7699200 ce597008 c023d598 ce063ec0 00008000 cd7a6000 ce063f80 [ 2278.967895] 3ea0: c7699200 c7699230 00000001 c023bf90 c023bf6c c01fab30 00042000 00000000 [ 2278.976470] 3ec0: 00000000 00000000 00000000 00000000 00000000 c080f7c4 00042000 cd7a6000 [ 2278.985046] 3ee0: ce063f80 00008000 ce062000 00042000 00041f90 c01d82e8 5aa1523b 34732c66 [ 2278.993621] 3f00: 5aa1523b 34732c66 00004024 00000000 00000000 00000000 0003520c c718eaf0 [ 2279.002197] 3f20: 00020000 cd7a6008 00000004 ce063f80 ce062000 00042000 00041f90 c02fad9c [ 2279.010772] 3f40: 00000000 00008000 cd7a6000 00042000 00000000 ce063f80 00042000 c01d8464 [ 2279.019348] 3f60: 00000010 cd7a6000 00000000 00000000 cd7a6000 cd7a6000 00008000 c01d88ec [ 2279.027923] 3f80: 00000000 00000000 beaa2744 00035330 00042000 00008000 00000003 c01011e4 [ 2279.036499] 3fa0: 00000000 c0101000 00035330 00042000 00000004 00042000 00008000 00008000 [ 2279.045074] 3fc0: 00035330 00042000 00008000 00000003 00001000 00000000 7fffffff 00041f90 [ 2279.053649] 3fe0: 00000000 beaa2748 0000d350 b6eb78dc 40000010 00000004 00000000 00000000 [ 2279.062255] [<c0598f84>] (soc_codec_reg_show) from [<c0599140>] (codec_reg_show+0x28/0x30) [ 2279.070922] [<c0599140>] (codec_reg_show) from [<c0412f14>] (dev_attr_show+0x1c/0x4c) [ 2279.079162] [<c0412f14>] (dev_attr_show) from [<c023d598>] (sysfs_kf_seq_show+0x90/0x108) [ 2279.087738] [<c023d598>] (sysfs_kf_seq_show) from [<c023bf90>] (kernfs_seq_show+0x24/0x28) [ 2279.096435] [<c023bf90>] (kernfs_seq_show) from [<c01fab30>] (seq_read+0x1dc/0x500) [ 2279.104461] [<c01fab30>] (seq_read) from [<c01d82e8>] (__vfs_read+0x2c/0x120) [ 2279.111968] [<c01d82e8>] (__vfs_read) from [<c01d8464>] (vfs_read+0x88/0x114) [ 2279.119445] [<c01d8464>] (vfs_read) from [<c01d88ec>] (SyS_read+0x40/0x8c) [ 2279.126678] [<c01d88ec>] (SyS_read) from [<c0101000>] (ret_fast_syscall+0x0/0x54) [ 2279.134521] Exception stack(0xce063fa8 to 0xce063ff0) [ 2279.139801] 3fa0: 00035330 00042000 00000004 00042000 00008000 00008000 [ 2279.148376] 3fc0: 00035330 00042000 00008000 00000003 00001000 00000000 7fffffff 00041f90 [ 2279.156951] 3fe0: 00000000 beaa2748 0000d350 b6eb78dc [ 2279.162261] Code: ea05f08a c09c66ec e92d4ff0 e24dd034 (e5905004) [ 2279.168792] ---[ end trace cbbe0b4a3061a0e7 ]--- -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2 1

[alsa-devel] [PATCH] ASoC: uniphier: remove superfluous <linux/mfd/syscon.h> inclusion
by Masahiro Yamada 08 Mar '18

08 Mar '18

None of aio-compress.c depends on the syscon header. Signed-off-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> Acked-by: Katsuhiro Suzuki <suzuki.katsuhiro(a)socionext.com> --- sound/soc/uniphier/aio-compress.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/uniphier/aio-compress.c b/sound/soc/uniphier/aio-compress.c index 4751c8b..4c1027a 100644 --- a/sound/soc/uniphier/aio-compress.c +++ b/sound/soc/uniphier/aio-compress.c @@ -22,7 +22,6 @@ #include <linux/dma-mapping.h> #include <linux/errno.h> #include <linux/kernel.h> -#include <linux/mfd/syscon.h> #include <linux/module.h> #include <sound/core.h> #include <sound/pcm.h> -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: Use proper DT compatible string for Hardkernel Odroid boards
by Sylwester Nawrocki 08 Mar '18

08 Mar '18

The Odroid boards are manufactured by Hardkernel, not Samsung. New compatible string entries are added, with "hardkernel," instead of "samsung," vendor prefix. Support for the old compatible strings is going to be removed after some time. Signed-off-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> --- Documentation/devicetree/bindings/sound/samsung,odroid.txt | 6 +++--- sound/soc/samsung/odroid.c | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/samsung,odroid.txt b/Documentation/devicetree/bindings/sound/samsung,odroid.txt index 625b1b18fd02..f35a2694eb04 100644 --- a/Documentation/devicetree/bindings/sound/samsung,odroid.txt +++ b/Documentation/devicetree/bindings/sound/samsung,odroid.txt @@ -2,8 +2,8 @@ Samsung Exynos Odroid XU3/XU4 audio complex with MAX98090 codec Required properties: - - compatible - "samsung,odroidxu3-audio" - for Odroid XU3 board, - "samsung,odroidxu4-audio" - for Odroid XU4 board + - compatible - "hardkernel,odroid-xu3-audio" - for Odroid XU3 board, + "hardkernel,odroid-xu4-audio" - for Odroid XU4 board - model - the user-visible name of this sound complex - clocks - should contain entries matching clock names in the clock-names property @@ -35,7 +35,7 @@ Required sub-nodes: Example: sound { - compatible = "samsung,odroidxu3-audio"; + compatible = "hardkernel,odroid-xu3-audio"; model = "Odroid-XU3"; samsung,audio-routing = "Headphone Jack", "HPL", diff --git a/sound/soc/samsung/odroid.c b/sound/soc/samsung/odroid.c index 44b6de5a331a..92d750806d1d 100644 --- a/sound/soc/samsung/odroid.c +++ b/sound/soc/samsung/odroid.c @@ -213,8 +213,10 @@ static int odroid_audio_remove(struct platform_device *pdev) } static const struct of_device_id odroid_audio_of_match[] = { + { .compatible = "hardkernel,odroid-xu3-audio" }, + { .compatible = "hardkernel,odroid-xu4-audio" }, { .compatible = "samsung,odroid-xu3-audio" }, - { .compatible = "samsung,odroid-xu4-audio"}, + { .compatible = "samsung,odroid-xu4-audio" }, { }, }; MODULE_DEVICE_TABLE(of, odroid_audio_of_match); -- 2.14.2

4 5

[alsa-devel] [PATCH 2/2] ALSA: hda: add dock and led support for HP ProBook 640 G2
by Dennis Wassenberg 08 Mar '18

08 Mar '18

This patch adds missing initialisation for HP 2013 UltraSlim Dock Line-In/Out PINs and activates keyboard mute/micmute leds for HP ProBook 640 G2 Signed-off-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index d5c9b88..5b4dbce 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -958,6 +958,7 @@ static void cxt_fixup_mute_led_gpio(struct hda_codec *codec, SND_PCI_QUIRK(0x1025, 0x054f, "Acer Aspire 4830T", CXT_FIXUP_ASPIRE_DMIC), SND_PCI_QUIRK(0x103c, 0x8079, "HP EliteBook 840 G3", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x807C, "HP EliteBook 820 G3", CXT_FIXUP_HP_DOCK), + SND_PCI_QUIRK(0x103c, 0x80FD, "HP ProBook 640 G2", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE), SND_PCI_QUIRK(0x103c, 0x8115, "HP Z1 Gen3", CXT_FIXUP_HP_GATE_MIC), SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO), -- 1.9.1

2 1

[alsa-devel] [PATCH 1/2] ALSA: hda: add dock and led support for HP EliteBook 820 G3
by Dennis Wassenberg 08 Mar '18

08 Mar '18

This patch adds missing initialisation for HP 2013 UltraSlim Dock Line-In/Out PINs and activates keyboard mute/micmute leds for HP EliteBook 820 G3 Signed-off-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 37e1cf8..d5c9b88 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -957,6 +957,7 @@ static void cxt_fixup_mute_led_gpio(struct hda_codec *codec, SND_PCI_QUIRK(0x1025, 0x054c, "Acer Aspire 3830TG", CXT_FIXUP_ASPIRE_DMIC), SND_PCI_QUIRK(0x1025, 0x054f, "Acer Aspire 4830T", CXT_FIXUP_ASPIRE_DMIC), SND_PCI_QUIRK(0x103c, 0x8079, "HP EliteBook 840 G3", CXT_FIXUP_HP_DOCK), + SND_PCI_QUIRK(0x103c, 0x807C, "HP EliteBook 820 G3", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE), SND_PCI_QUIRK(0x103c, 0x8115, "HP Z1 Gen3", CXT_FIXUP_HP_GATE_MIC), SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO), -- 1.9.1

2 1

[alsa-devel] [PATCH] hda: realtek: Make dock sound work on ThinkPad L570
by Dennis Wassenberg 08 Mar '18

08 Mar '18

One version of Lenovo Thinkpad T570 did not use ALC298 (like other Kaby Lake devices). Instead it uses ALC292. In order to make the Lenovo dock working with that codec the dock quirk for ALC292 will be used. Signed-off-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b9c93fa..b5d0f8c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6508,6 +6508,7 @@ enum { SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), + SND_PCI_QUIRK(0x17aa, 0x2249, "Thinkpad", ALC292_FIXUP_TPT460), SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), -- 1.9.1

2 3

[alsa-devel] [PATCH 6/6] ASoC: samsung: Add HDMI audio support for Chromebook Snow
by Sylwester Nawrocki 08 Mar '18

08 Mar '18

This patch updates the driver so, in addition to current DT bindings, it also handles the new DT bindings with cpu, codec subnodes which allow for sound support on the HDMI interface. Signed-off-by: Sylwester Nawrocki <s.nawrocki(a)samsung.com> --- sound/soc/samsung/snow.c | 225 +++++++++++++++++++++++++++++++++++++---------- 1 file changed, 177 insertions(+), 48 deletions(-) diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c index fc62110f500f..d10fd578b60d 100644 --- a/sound/soc/samsung/snow.c +++ b/sound/soc/samsung/snow.c @@ -11,92 +11,207 @@ * General Public License for more details. */ +#include <linux/clk.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/of.h> #include <linux/of_device.h> - +#include <sound/pcm_params.h> #include <sound/soc.h> #include "i2s.h" -#define FIN_PLL_RATE 24000000 +#define FIN_PLL_RATE 24000000UL -static struct snd_soc_dai_link snow_dai[] = { - { - .name = "Primary", - .stream_name = "Primary", - .codec_dai_name = "HiFi", - .dai_fmt = SND_SOC_DAIFMT_I2S | - SND_SOC_DAIFMT_NB_NF | - SND_SOC_DAIFMT_CBS_CFS, - }, +struct snow_priv { + struct snd_soc_dai_link dai_link; + struct clk *clk_i2s_bus; +}; + +static int snow_card_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params) +{ + static const unsigned int pll_rate[] = { + 73728000U, 67737602U, 49152000U, 45158401U, 32768001U + }; + struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snow_priv *priv = snd_soc_card_get_drvdata(rtd->card); + int bfs, psr, rfs, bitwidth; + unsigned long int rclk; + long int freq = -EINVAL; + int ret, i; + + bitwidth = snd_pcm_format_width(params_format(params)); + if (bitwidth < 0) { + dev_err(rtd->card->dev, "Invalid bit-width: %d\n", bitwidth); + return bitwidth; + } + + if (bitwidth != 16 && bitwidth != 24) { + dev_err(rtd->card->dev, "Unsupported bit-width: %d\n", bitwidth); + return -EINVAL; + } + + bfs = 2 * bitwidth; + + switch (params_rate(params)) { + case 16000: + case 22050: + case 24000: + case 32000: + case 44100: + case 48000: + case 88200: + case 96000: + rfs = 8 * bfs; + break; + case 64000: + rfs = 384; + break; + case 8000: + case 11025: + case 12000: + rfs = 16 * bfs; + break; + default: + return -EINVAL; + } + + rclk = params_rate(params) * rfs; + + for (psr = 8; psr > 0; psr /= 2) { + for (i = 0; i < ARRAY_SIZE(pll_rate); i++) { + if ((pll_rate[i] - rclk * psr) <= 2) { + freq = pll_rate[i]; + break; + } + } + } + if (freq < 0) { + dev_err(rtd->card->dev, "Unsupported RCLK rate: %lu\n", rclk); + return -EINVAL; + } + + ret = clk_set_rate(priv->clk_i2s_bus, freq); + if (ret < 0) { + dev_err(rtd->card->dev, "I2S bus clock rate set failed\n"); + return ret; + } + + return 0; +} + +static const struct snd_soc_ops snow_card_ops = { + .hw_params = snow_card_hw_params, }; static int snow_late_probe(struct snd_soc_card *card) { struct snd_soc_pcm_runtime *rtd; struct snd_soc_dai *codec_dai; - struct snd_soc_dai *cpu_dai; - int ret; rtd = snd_soc_get_pcm_runtime(card, card->dai_link[0].name); - codec_dai = rtd->codec_dai; - cpu_dai = rtd->cpu_dai; - - /* Set the MCLK rate for the codec */ - ret = snd_soc_dai_set_sysclk(codec_dai, 0, - FIN_PLL_RATE, SND_SOC_CLOCK_IN); - if (ret < 0) - return ret; + /* In the multi-codec case codec_dai 0 is HDMI and 1 is MAX98095. */ + if (rtd->num_codecs > 1) + codec_dai = rtd->codec_dais[1]; + else + codec_dai = rtd->codec_dai; - return 0; + /* Set the MCLK rate for the codec */ + return snd_soc_dai_set_sysclk(codec_dai, 0, + FIN_PLL_RATE, SND_SOC_CLOCK_IN); } static struct snd_soc_card snow_snd = { .name = "Snow-I2S", .owner = THIS_MODULE, - .dai_link = snow_dai, - .num_links = ARRAY_SIZE(snow_dai), - .late_probe = snow_late_probe, }; static int snow_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct snd_soc_card *card = &snow_snd; - struct device_node *i2s_node, *codec_node; - int i, ret; - - i2s_node = of_parse_phandle(pdev->dev.of_node, - "samsung,i2s-controller", 0); - if (!i2s_node) { - dev_err(&pdev->dev, - "Property 'i2s-controller' missing or invalid\n"); - return -EINVAL; - } + struct device_node *cpu, *codec; + struct snd_soc_dai_link *link; + struct snow_priv *priv; + int ret; - codec_node = of_parse_phandle(pdev->dev.of_node, - "samsung,audio-codec", 0); - if (!codec_node) { - dev_err(&pdev->dev, - "Property 'audio-codec' missing or invalid\n"); - return -EINVAL; - } + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + link = &priv->dai_link; + + link->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | + SND_SOC_DAIFMT_CBS_CFS; + + link->name = "Primary"; + link->stream_name = link->name; + + card->dai_link = link; + card->num_links = 1; + card->dev = dev; + + /* Try new DT bindings with HDMI support first. */ + cpu = of_get_child_by_name(dev->of_node, "cpu"); + + if (cpu) { + link->ops = &snow_card_ops; - for (i = 0; i < ARRAY_SIZE(snow_dai); i++) { - snow_dai[i].codec_of_node = codec_node; - snow_dai[i].cpu_of_node = i2s_node; - snow_dai[i].platform_of_node = i2s_node; + link->cpu_of_node = of_parse_phandle(cpu, "sound-dai", 0); + of_node_put(cpu); + + if (!link->cpu_of_node) { + dev_err(dev, "Failed parsing cpu/sound-dai property\n"); + return -EINVAL; + } + + codec = of_get_child_by_name(dev->of_node, "codec"); + ret = snd_soc_of_get_dai_link_codecs(dev, codec, link); + of_node_put(codec); + + if (ret < 0) { + of_node_put(link->cpu_of_node); + dev_err(dev, "Failed parsing codec node\n"); + return ret; + } + + priv->clk_i2s_bus = of_clk_get_by_name(link->cpu_of_node, + "i2s_opclk0"); + if (IS_ERR(priv->clk_i2s_bus)) { + snd_soc_of_put_dai_link_codecs(link); + of_node_put(link->cpu_of_node); + return PTR_ERR(priv->clk_i2s_bus); + } + } else { + link->codec_dai_name = "HiFi", + + link->cpu_of_node = of_parse_phandle(dev->of_node, + "samsung,i2s-controller", 0); + if (!link->cpu_of_node) { + dev_err(dev, "i2s-controller property parse error\n"); + return -EINVAL; + } + + link->codec_of_node = of_parse_phandle(dev->of_node, + "samsung,audio-codec", 0); + if (!link->codec_of_node) { + of_node_put(link->cpu_of_node); + dev_err(dev, "audio-codec property parse error\n"); + return -EINVAL; + } } - card->dev = &pdev->dev; + link->platform_of_node = link->cpu_of_node; /* Update card-name if provided through DT, else use default name */ snd_soc_of_parse_card_name(card, "samsung,model"); - ret = devm_snd_soc_register_card(&pdev->dev, card); + snd_soc_card_set_drvdata(card, priv); + + ret = devm_snd_soc_register_card(dev, card); if (ret) { dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret); return ret; @@ -105,6 +220,19 @@ static int snow_probe(struct platform_device *pdev) return ret; } +static int snow_remove(struct platform_device *pdev) +{ + struct snow_priv *priv = platform_get_drvdata(pdev); + + of_node_put(priv->dai_link.cpu_of_node); + of_node_put(link->codec_of_node); + snd_soc_of_put_dai_link_codecs(&priv->dai_link); + + clk_put(priv->clk_i2s_bus); + + return 0; +} + static const struct of_device_id snow_of_match[] = { { .compatible = "google,snow-audio-max98090", }, { .compatible = "google,snow-audio-max98091", }, @@ -120,6 +248,7 @@ static struct platform_driver snow_driver = { .of_match_table = snow_of_match, }, .probe = snow_probe, + .remove = snow_remove, }; module_platform_driver(snow_driver); -- 2.14.2

1 1

[alsa-devel] [PATCH] ALSA: seq: Remove superfluous snd_seq_queue_client_leave_cells() call
by Takashi Iwai 08 Mar '18

08 Mar '18

With the previous two fixes for the write / ioctl races: ALSA: seq: Don't allow resizing pool in use ALSA: seq: More protection for concurrent write and ioctl races the cells aren't any longer in queues at the point calling snd_seq_pool_done() in snd_seq_ioctl_set_client_pool(). Hence the function call snd_seq_queue_client_leave_cells() can be dropped safely from there. Suggested-by: Nicolai Stange <nstange(a)suse.de> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/seq/seq_clientmgr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c index 1b62421dadd1..918338dea5b9 100644 --- a/sound/core/seq/seq_clientmgr.c +++ b/sound/core/seq/seq_clientmgr.c @@ -1846,7 +1846,6 @@ static int snd_seq_ioctl_set_client_pool(struct snd_seq_client *client, return -EBUSY; /* remove all existing cells */ snd_seq_pool_mark_closing(client->pool); - snd_seq_queue_client_leave_cells(client->number); snd_seq_pool_done(client->pool); } client->pool->size = info->output_pool; -- 2.16.2

1 0

[alsa-devel] [PATCH 0/2] More hardening for ALSA sequencer write/ioctl races
by Takashi Iwai 08 Mar '18

08 Mar '18

Hi, here is two patches to paper over the still remaining races in ALSA sequencer write and ioctl that have been leaked in the previous fix for CVE-2018-1000004. The reports came up totally individually, so both people are put as Reported-by tag here. thanks, Takashi === Takashi Iwai (2): ALSA: seq: Don't allow resizing pool in use ALSA: seq: More protection for concurrent write and ioctl races sound/core/seq/seq_clientmgr.c | 21 ++++++++++++++------- sound/core/seq/seq_fifo.c | 2 +- sound/core/seq/seq_memory.c | 14 ++++++++++---- sound/core/seq/seq_memory.h | 3 ++- 4 files changed, 27 insertions(+), 13 deletions(-) -- 2.16.2

2 5

[alsa-devel] [PATCH v2 0/2] ASoC: Add support for DAC PCM1789
by Mylène Josserand 08 Mar '18

08 Mar '18

Hello everyone, The current series is the second version to add the support of Texas Instrument's DAC PCM1789. This DAC is very minimalist and does not have many registers. It is important to notice that this DAC needs to always have clocks enabled (even without any data) otherwise it will be in a "desynchronized" state and can not send data correctly. This issue has been solved by performing a reset each time a sound is played. This reset can produce a "pop" noise. Depending on your DAI, you will need to provide and enable the MCLK to be able to communicate with this codec throught i2c. Changes since v1: - Create a new file to support pcm1789 instead of converting the existing pcm179x driver. All the patches are merged into one patch. - Update the code to use gpiod for the reset. - Add some fixes according to Thomas Petazzoni's reviews - Create a new patch to add device-tree bindings for this new DAC. Thank you in advance for any review. Best regards, Mylène Mylène Josserand (2): ASoC: codecs: Add support for PCM1789 ASoC: Add bindings for PCM1789 .../devicetree/bindings/sound/pcm1789.txt | 21 ++ sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/pcm1789-i2c.c | 76 ++++++ sound/soc/codecs/pcm1789.c | 288 +++++++++++++++++++++ sound/soc/codecs/pcm1789.h | 28 ++ 6 files changed, 429 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/pcm1789.txt create mode 100644 sound/soc/codecs/pcm1789-i2c.c create mode 100644 sound/soc/codecs/pcm1789.c create mode 100644 sound/soc/codecs/pcm1789.h -- 2.11.0

4 8