Alsa-devel March 2018

alsa-devel@alsa-project.org

144 participants
294 discussions

[alsa-devel] [PATCH - THREAD_SAFE_API 1/1] pcm: Do not access lock_enabled if thread safe API
by twischer＠de.adit-jv.com 01 Mar '18

01 Mar '18

From: Timo Wischer <twischer(a)de.adit-jv.com> is not enabled. Without this commit compiling fails when THREAD_SAFE_API is not enabled Signed-off-by: Timo Wischer <twischer(a)de.adit-jv.com> diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c index 1be3833..d53ed98 100644 --- a/src/pcm/pcm.c +++ b/src/pcm/pcm.c @@ -823,8 +823,11 @@ int snd_pcm_async(snd_pcm_t *pcm, int sig, pid_t pid) sig = SIGIO; if (pid == 0) pid = getpid(); + +#ifdef THREAD_SAFE_API /* async handler may lead to a deadlock; suppose no multi thread */ pcm->lock_enabled = 0; +#endif return pcm->ops->async(pcm->op_arg, sig, pid); } #endif -- 2.7.4

2 1

[alsa-devel] [PATCH] sound/pci/ice1712: replace strcpy() with scnprintf()
by Joey Pabalinas 01 Mar '18

01 Mar '18

Replace unsafe uses of strcpy() to copy the name argument into the sid.name buffer with scnprintf() to guard against possible buffer overflows. Even though we don't actually care about the return value in this specific case, scnprintf() is still preferred over snprintf() due to scnprintf() returning the much more logical length of what was *actually* encoded into the destination array instead of returning length the resulting string *would* be, assuming it all fit into the destination array as snprintf() does. Maybe one day someone will use the return value, and since the behavior is exactly the same apart from the return value it would be better to account for that possibility and program defensively. Signed-off-by: Joey Pabalinas <joeypabalinas(a)gmail.com> 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/pci/ice1712/juli.c b/sound/pci/ice1712/juli.c index 0dbaccf61f33270608..0abacc64168f895d53 100644 --- a/sound/pci/ice1712/juli.c +++ b/sound/pci/ice1712/juli.c @@ -26,6 +26,7 @@ #include <linux/delay.h> #include <linux/interrupt.h> #include <linux/init.h> +#include <linux/kernel.h> #include <linux/slab.h> #include <sound/core.h> #include <sound/tlv.h> @@ -425,10 +426,9 @@ DECLARE_TLV_DB_SCALE(juli_master_db_scale, -6350, 50, 1); static struct snd_kcontrol *ctl_find(struct snd_card *card, const char *name) { - struct snd_ctl_elem_id sid; - memset(&sid, 0, sizeof(sid)); - /* FIXME: strcpy is bad. */ - strcpy(sid.name, name); + struct snd_ctl_elem_id sid = {0}; + + scnprintf(sid.name, sizeof(sid.name), "%s", name); sid.iface = SNDRV_CTL_ELEM_IFACE_MIXER; return snd_ctl_find_id(card, &sid); } diff --git a/sound/pci/ice1712/quartet.c b/sound/pci/ice1712/quartet.c index d145b5eb7ff86d978d..332f6226548c6a089a 100644 --- a/sound/pci/ice1712/quartet.c +++ b/sound/pci/ice1712/quartet.c @@ -25,6 +25,7 @@ #include <linux/delay.h> #include <linux/interrupt.h> #include <linux/init.h> +#include <linux/kernel.h> #include <linux/slab.h> #include <sound/core.h> #include <sound/tlv.h> @@ -785,10 +786,9 @@ DECLARE_TLV_DB_SCALE(qtet_master_db_scale, -6350, 50, 1); static struct snd_kcontrol *ctl_find(struct snd_card *card, const char *name) { - struct snd_ctl_elem_id sid; - memset(&sid, 0, sizeof(sid)); - /* FIXME: strcpy is bad. */ - strcpy(sid.name, name); + struct snd_ctl_elem_id sid = {0}; + + scnprintf(sid.name, sizeof(sid.name), "%s", name); sid.iface = SNDRV_CTL_ELEM_IFACE_MIXER; return snd_ctl_find_id(card, &sid); } -- 2.16.2

3 6

[alsa-devel] [PATCH v1 0/4] ASoC: Add support for DAC PCM1789
by Mylène Josserand 01 Mar '18

01 Mar '18

Hello everyone, You will find in this series the support of Texas Instrument's DAC PCM1789. This DAC is very minimalist and is similar to PCM1792a except for some differences in registers. Series based on asoc tree, "for-next" branch (last commit 130c3888dfdc). It is important to notice that this DAC needs to always have clocks enabled (even without any data) otherwise it will be in a "desynchronized" state and can not send data correctly. This issue has been solved by performing a reset each time a sound is played (see patch 04). This reset can produce a "pop" noise. Thank you in advance for any review. Best regards, Mylène Mylène Josserand (4): ASoC: codecs: pcm179x: Add PCM1789 id ASoC: codecs: pcm179x: Add support for PCM1789 ASoC: codecs: pcm179x: Add reset gpio ASoC: codecs: pcm179x: Add trigger function to perform a reset .../devicetree/bindings/sound/pcm179x.txt | 2 +- sound/soc/codecs/pcm179x-i2c.c | 17 +- sound/soc/codecs/pcm179x.c | 242 ++++++++++++++++++++- sound/soc/codecs/pcm179x.h | 10 +- 4 files changed, 264 insertions(+), 7 deletions(-) -- 2.11.0

4 14

[alsa-devel] [PATCH v2] ASoC: atmel: Remove redundant dev_err() call in probe function
by Ladislav Michl 01 Mar '18

01 Mar '18

There is an error message within devm_ioremap_resource already, so remove the redundant dev_err() call. Signed-off-by: Ladislav Michl <ladis(a)linux-mips.org> Acked-by: Nicolas Ferre <nicolas.ferre(a)microchip.com> --- Changes: - v2: None, just added Ack. sound/soc/atmel/atmel-classd.c | 7 ++----- sound/soc/atmel/atmel-pdmic.c | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c index 9baaf6bc5fbd..3d70061901a0 100644 --- a/sound/soc/atmel/atmel-classd.c +++ b/sound/soc/atmel/atmel-classd.c @@ -583,11 +583,8 @@ static int atmel_classd_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); io_base = devm_ioremap_resource(dev, res); - if (IS_ERR(io_base)) { - ret = PTR_ERR(io_base); - dev_err(dev, "failed to remap register memory: %d\n", ret); - return ret; - } + if (IS_ERR(io_base)) + return PTR_ERR(io_base); dd->phy_base = res->start; dd->dev = dev; diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c index 94f852574a44..915c2b064de1 100644 --- a/sound/soc/atmel/atmel-pdmic.c +++ b/sound/soc/atmel/atmel-pdmic.c @@ -633,11 +633,8 @@ static int atmel_pdmic_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); io_base = devm_ioremap_resource(dev, res); - if (IS_ERR(io_base)) { - ret = PTR_ERR(io_base); - dev_err(dev, "failed to remap register memory: %d\n", ret); - return ret; - } + if (IS_ERR(io_base)) + return PTR_ERR(io_base); dd->phy_base = res->start; -- 2.16.2

2 1

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

Alsa-devel March 2018