September 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3 0/5] This series of patches fix the boot time dapm route warnings(without rt5514):
by Jeffy Chen 19 Sep '17

19 Sep '17

[ 2.475501] rk3399-gru-sound sound: ASoC: no sink widget found for DMIC1L [ 2.475503] rk3399-gru-sound sound: ASoC: Failed to add route Int Mic -> direct -> DMIC1L [ 2.475505] rk3399-gru-sound sound: ASoC: no sink widget found for DMIC1R [ 2.475507] rk3399-gru-sound sound: ASoC: Failed to add route Int Mic -> direct -> DMIC1R And support detect rt5514-dsp codec and rt5514 codec by checking bus_type. Changes in v3: Rebase onto for-next 20170919 Changes in v2: Separate HDMI/DMIC patches. Fix DMic typo. Jeffy Chen (5): ASoC: rockchip: Add dapm route for HDMI ASoC: rockchip: Add dapm route for DMic ASoC: rockchip: Init dapm routes dynamically ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec ASoC: rt5514: Add devicetree binding support for rt5514-spi Documentation/devicetree/bindings/sound/rt5514.txt | 13 +- sound/soc/rockchip/rk3399_gru_sound.c | 149 +++++++++++++++++---- 2 files changed, 132 insertions(+), 30 deletions(-) -- 2.11.0

2 6

[alsa-devel] [PATCH 0/5] BYT/CHT-Realtek remaining fixes
by Pierre-Louis Bossart 19 Sep '17

19 Sep '17

This last batch for the week is about simplification of the MCLK-related code for byt/cht-realtek machine drivers and fixes for rt5651. This is mostly a v2 of patches I submitted earlier, with improvements suggested by Andy Shevchenko, a fixed mistake on quirk management flagged by Vinod Koul and better commit messages. No new functionality otherwise. Pierre-Louis Bossart (5): ASoC: Intel: boards: use devm_clk_get() unconditionally ASoC: Intel: bytcr-rt5651: fix capture routes ASoC: Intel: bytcr_rt5651: add MCLK support and fix quirks ASoC: Intel: bytcr_rt5651: filter codec name ASoC: Intel: bytcr_rt5640: simplify MCLK quirk tests sound/soc/intel/boards/bytcr_rt5640.c | 8 +- sound/soc/intel/boards/bytcr_rt5651.c | 277 ++++++++++++++++++++++++++++---- sound/soc/intel/boards/cht_bsw_rt5645.c | 14 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 27 +--- 4 files changed, 265 insertions(+), 61 deletions(-) -- 2.9.3

4 11

[alsa-devel] [PATCH] ASoC: fsl-asoc-card: Don't error out if ENOTSUPP
by Nicolin Chen 19 Sep '17

19 Sep '17

The snd_soc_component_set_sysclk() and snd_soc_dai_set_tdm_slot() in the soc-core.c will return -ENOTSUPP if there is no function implementation for them in the dai and component drivers. So this patch tries to ignore this errno. Signed-off-by: Nicolin Chen <nicoleotsuka(a)gmail.com> --- sound/soc/fsl/fsl-asoc-card.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 2db4d0c..3772abb 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -166,7 +166,7 @@ static int fsl_asoc_card_hw_params(struct snd_pcm_substream *substream, ret = snd_soc_dai_set_sysclk(rtd->cpu_dai, cpu_priv->sysclk_id[tx], cpu_priv->sysclk_freq[tx], cpu_priv->sysclk_dir[tx]); - if (ret) { + if (ret && ret != -ENOTSUPP) { dev_err(dev, "failed to set sysclk for cpu dai\n"); return ret; } @@ -174,7 +174,7 @@ static int fsl_asoc_card_hw_params(struct snd_pcm_substream *substream, if (cpu_priv->slot_width) { ret = snd_soc_dai_set_tdm_slot(rtd->cpu_dai, 0x3, 0x3, 2, cpu_priv->slot_width); - if (ret) { + if (ret && ret != -ENOTSUPP) { dev_err(dev, "failed to set TDM slot for cpu dai\n"); return ret; } @@ -270,7 +270,7 @@ static int fsl_asoc_card_set_bias_level(struct snd_soc_card *card, ret = snd_soc_dai_set_sysclk(codec_dai, codec_priv->fll_id, pll_out, SND_SOC_CLOCK_IN); - if (ret) { + if (ret && ret != -ENOTSUPP) { dev_err(dev, "failed to set SYSCLK: %d\n", ret); return ret; } @@ -283,7 +283,7 @@ static int fsl_asoc_card_set_bias_level(struct snd_soc_card *card, ret = snd_soc_dai_set_sysclk(codec_dai, codec_priv->mclk_id, codec_priv->mclk_freq, SND_SOC_CLOCK_IN); - if (ret) { + if (ret && ret != -ENOTSUPP) { dev_err(dev, "failed to switch away from FLL: %d\n", ret); return ret; } @@ -459,7 +459,7 @@ static int fsl_asoc_card_late_probe(struct snd_soc_card *card) ret = snd_soc_dai_set_sysclk(codec_dai, codec_priv->mclk_id, codec_priv->mclk_freq, SND_SOC_CLOCK_IN); - if (ret) { + if (ret && ret != -ENOTSUPP) { dev_err(dev, "failed to set sysclk in %s\n", __func__); return ret; } -- 2.7.4

2 1

[alsa-devel] [PATCH 0/7] BYT/CHT clocks/max98090 updates
by Pierre-Louis Bossart 19 Sep '17

19 Sep '17

This patchset corrects issues with an earlier submission (missing signoffs, error case not consistent) and enables the cht_bsw_max98090 machine driver on Baytrail. This should help distributions solve problems with Baytrail Chromebooks which required a specific build. These patches were tested on Lenovo 100s ('orco'/Baytrail) and Acer R11 ('cyan'/Cherrytrail), using the same build based on CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH=m. Playback on speakers/headphone and capture from internal mic work fine. UCM files are available at https://github.com/plbossart/UCM/tree/master/byt-max98090 Thanks to Jarkko Nikula and Andy Shevchenko for their comments on an initial version reviewed internally at Intel. Fang, Yang A (1): ASoC: ts3a227e: add acpi table Pierre-Louis Bossart (5): ASoC: max98090: reduce verbosity on PLL unlock ASoC: Intel: cht_bsw_max98090: Fix I2S config + unused code ASoC: Intel: cht_bsw_max98090: add support for Baytrail ASoC: Intel: atom: use cht_bsw_max98090 for Baytrail Chromebooks ASoC: Intel: cht_bsw_max98090: add gpio-based jack detection Thierry Escande (1): ASoc: Intel: cht_bsw_max98090_ti: Fix jack initialization sound/soc/codecs/max98090.c | 2 +- sound/soc/codecs/ts3a227e.c | 10 ++ sound/soc/intel/atom/sst/sst_acpi.c | 8 ++ sound/soc/intel/boards/cht_bsw_max98090_ti.c | 185 ++++++++++++++++++++++++--- 4 files changed, 186 insertions(+), 19 deletions(-) -- 2.9.3

4 19

[alsa-devel] [PATCH 0/2] Add ACPI table for the ts3a227e driver
by Thierry Escande 19 Sep '17

19 Sep '17

Hi, This series adds ACPI match table for the ts3a227e driver. The ts3a227e is an Autonomous Audio Accessory Detection and Configuration Switch used to detect audio accessory features like jack plugging and unplugging, mic presence, and button pressed events. This series also fixes a null pointer dereference occurring in the TI max9890 driver when the ts3a227e hardware is present and its driver probed. The jack detection was enabled in the ts3a227e driver before the jack structure was allocated, causing the null pointer access. Regards, Thierry Fang, Yang A (1): ASoC: ts3a227e: add acpi table Thierry Escande (1): ASoc: cht_bsw_max98090_ti: Fix jack initialization sound/soc/codecs/ts3a227e.c | 10 ++++++ sound/soc/intel/boards/cht_bsw_max98090_ti.c | 52 +++++++++++++++++----------- 2 files changed, 41 insertions(+), 21 deletions(-) -- 2.7.4

3 6

[alsa-devel] [PATCH v12 1/2] ASoC: rt5514: Add devicetree binding support for rt5514-spi
by Jeffy Chen 19 Sep '17

19 Sep '17

Add devicetree binding support for rt5514 spi dsp codec. Signed-off-by: Jeffy Chen <jeffy.chen(a)rock-chips.com> --- Changes in v12: None Changes in v11: Use same compatible for rt5514-i2c & rt5514-spi. Changes in v10: Put rt5514-i2c doc & rt5514-spi doc together. Changes in v9: Address comments from Brian. Documentation/devicetree/bindings/sound/rt5514.txt | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt index 929ca6756b02..4f33b0d96afe 100644 --- a/Documentation/devicetree/bindings/sound/rt5514.txt +++ b/Documentation/devicetree/bindings/sound/rt5514.txt @@ -1,22 +1,27 @@ RT5514 audio CODEC -This device supports I2C only. +This device supports both I2C and SPI. Required properties: - compatible : "realtek,rt5514". -- reg : The I2C address of the device. +- reg : the I2C address of the device for I2C, the chip select + number for SPI. Optional properties: - clocks: The phandle of the master clock to the CODEC - clock-names: Should be "mclk" +- interrupt-parent: The phandle for the interrupt controller. +- interrupts: The interrupt number to the cpu. The interrupt specifier format + depends on the interrupt controller. + - realtek,dmic-init-delay-ms - Set the DMIC initial delay (ms) to wait it ready. + Set the DMIC initial delay (ms) to wait it ready for I2C. -Pins on the device (for linking into audio routes) for RT5514: +Pins on the device (for linking into audio routes) for I2C: * DMIC1L * DMIC1R -- 2.11.0

3 3

[alsa-devel] [RESEND PATCH v2 1/3] ASoC: rockchip: Add dapm route for HDMI
by Jeffy Chen 19 Sep '17

19 Sep '17

Add dapm route for DP codec. Signed-off-by: Jeffy Chen <jeffy.chen(a)rock-chips.com> --- Changes in v2: Separate HDMI/DMIC patches. sound/soc/rockchip/rk3399_gru_sound.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 0513fe480353..b050510be65f 100644 --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -47,6 +47,7 @@ static const struct snd_soc_dapm_widget rockchip_dapm_widgets[] = { SND_SOC_DAPM_SPK("Speakers", NULL), SND_SOC_DAPM_MIC("Headset Mic", NULL), SND_SOC_DAPM_MIC("Int Mic", NULL), + SND_SOC_DAPM_LINE("HDMI", NULL), }; static const struct snd_soc_dapm_route rockchip_dapm_routes[] = { @@ -59,6 +60,7 @@ static const struct snd_soc_dapm_route rockchip_dapm_routes[] = { {"Headphones", NULL, "HPL"}, {"Headphones", NULL, "HPR"}, {"Speakers", NULL, "Speaker"}, + {"HDMI", NULL, "TX"}, }; static const struct snd_kcontrol_new rockchip_controls[] = { @@ -66,6 +68,7 @@ static const struct snd_kcontrol_new rockchip_controls[] = { SOC_DAPM_PIN_SWITCH("Speakers"), SOC_DAPM_PIN_SWITCH("Headset Mic"), SOC_DAPM_PIN_SWITCH("Int Mic"), + SOC_DAPM_PIN_SWITCH("HDMI"), }; static int rockchip_sound_max98357a_hw_params(struct snd_pcm_substream *substream, -- 2.11.0

3 6

[alsa-devel] [PATCH 2/4] ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm
by anish kumar 19 Sep '17

19 Sep '17

From: anish kumar <yesanishhere(a)gmail.com> refactor snd_soc_dapm_new_pcm to reduce the size of this function to facilitate further refactoring. Signed-off-by: anish kumar <yesanishhere(a)gmail.com> --- sound/soc/soc-dapm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index f51f613..d55cac6 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3821,19 +3821,15 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, devm_kasprintf(card->dev, GFP_KERNEL, "Anonymous Configuration %d", count); - if (!w_param_text[count]) { - ret = -ENOMEM; - goto outfree_link_name; - } } else { w_param_text[count] = devm_kmemdup(card->dev, config->stream_name, strlen(config->stream_name) + 1, GFP_KERNEL); - if (!w_param_text[count]) { - ret = -ENOMEM; - goto outfree_link_name; - } + } + if (!w_param_text[count]) { + ret = -ENOMEM; + goto outfree_link_name; } config++; } -- 2.5.4 (Apple Git-61)

2 1

[alsa-devel] Resend: [PATCH 1/4] ASoC: dapm: fix error path in snd_soc_dapm_new_pcm
by anish kumar 19 Sep '17

19 Sep '17

From: anish kumar <yesanishhere(a)gmail.com> Before freeing the memory, check if it was allcoated. Signed-off-by: anish kumar <yesanishhere(a)gmail.com> --- sound/soc/soc-dapm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index dcef67a..f51f613 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3907,9 +3907,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, devm_kfree(card->dev, (void *)private_value); outfree_link_name: devm_kfree(card->dev, link_name); -outfree_w_param: for (count = 0 ; count < num_params; count++) devm_kfree(card->dev, (void *)w_param_text[count]); +outfree_w_param: devm_kfree(card->dev, w_param_text); return ret; -- 2.5.4 (Apple Git-61)

2 1

[alsa-devel] [RFCv2][PATCH 00/38] alsa-utils: axfer: rewrite aplay
by Takashi Sakamoto 19 Sep '17

19 Sep '17

Hi, This large patchset is to introduce a new command, named as 'axfer' (ALSA transfer). This comes from my work to rewrite aplay. Initial patchset was already posted as RFCv1. [alsa-devel][PATCH 00/23] alsa-utils: rewrite aplay http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/124132.html Unlike the initial patchset, this patchset includes support for the most of options in aplay, and simple unit tests for functionalities to handle data frames for files. At patch 17, transmission of data frame with blocking mode is supported. You can actually test playback/capture. * axfer: add a sub-command to transfer data frames At patch 24, transmission with non-blocking mode is supported. * axfer: add support for non-blocking operation At patch 25, transmission by MMAP operation is supported. * axfer: add support for MMAP PCM operation Between patch 30-36, some minor features are supported, but they includes own issues. I'd like to abandon them in future patchset. * axfer: add an option to support volume unit meter * axfer: add a unit test for vumeter calculation * axfer: add an option for formatted filename * axfer: add an option to handle key events * axfer: add a parser for channel map API * axfer: add a feature to generate a file for process id * axfer: obsolete some test options At patch 37/38, an integration to select waiter type is added. You can select one of poll(2) and epoll(2) to wait for I/O event notification. At present, I found some problems of this program: * When MMAP operation is used for PCM nodes with 'plug' plugin, XRUN occurs for capture and noisy sound for playback. I don't found this in the other operations such as blocking. * When using two axfer processes for capture/playback with pipe, some frames are truncated in the end of playback. I leave some tasks such as documentation and localization, but this patchset covers major use cases, I think. Regards Takashi Sakamoto (38): axfer: add an entry point for this command axfer: add a sub-command to print list of PCMs/devices axfer: add a common interface to handle a file with audio-specific data format axfer: add support for a container of Microsoft/IBM RIFF/Wave format axfer: add support for a container of Sparc AU format axfer: add support for a container of Creative Tech. voice format axfer: add support for a container of raw data axfer: add unit test for container interface axfer: add a common interface to align data frames on different layout axfer: add support for a mapper for single target axfer: add support for a mapper for multiple target axfer: add a unit test for mapper interface axfer: add a parser for command-line options axfer: add a common interface to transfer data frames axfer: add support to transfer data frames by alsa-lib PCM APIs axfer: add support for blocking data transmission operation of alsa-lib PCM API axfer: add a sub-command to transfer data frames axfer: add informative output and an option to suppress it axfer: add an option to dump available hardware parameters axfer: add options related to duration and obsolete '--max-file-size' option axfer: add an option to finish transmission at XRUN axfer: add a common interface of waiter for I/O event notification axfer: add support of waiter for poll(2) axfer: add support for non-blocking operation axfer: add support for MMAP PCM operation axfer: add an option to suppress event waiting axfer: add options for buffer arrangement axfer: add options for software parameters of PCM substream axfer: add options for plugins in alsa-lib axfer: add an option to support volume unit meter axfer: add a unit test for vumeter calculation axfer: add an option for formatted filename axfer: add an option to handle key events axfer: add a parser for channel map API axfer: add a feature to generate a file for process id axfer: obsolete some test options axfer: add an implementation of waiter for epoll(7) axfer: add an option for waiter type Makefile.am | 2 +- axfer/Makefile.am | 60 +++ axfer/container-au.c | 207 +++++++++ axfer/container-raw.c | 66 +++ axfer/container-riff-wave.c | 581 ++++++++++++++++++++++++ axfer/container-voc.c | 843 +++++++++++++++++++++++++++++++++++ axfer/container.c | 470 ++++++++++++++++++++ axfer/container.h | 126 ++++++ axfer/key-event.c | 121 +++++ axfer/key-event.h | 19 + axfer/main.c | 194 ++++++++ axfer/mapper-multiple.c | 271 +++++++++++ axfer/mapper-single.c | 195 ++++++++ axfer/mapper.c | 152 +++++++ axfer/mapper.h | 87 ++++ axfer/misc.h | 16 + axfer/options.c | 963 ++++++++++++++++++++++++++++++++++++++++ axfer/options.h | 83 ++++ axfer/subcmd-list.c | 234 ++++++++++ axfer/subcmd-transfer.c | 520 ++++++++++++++++++++++ axfer/subcmd.h | 18 + axfer/test/Makefile.am | 39 ++ axfer/test/container-test.c | 299 +++++++++++++ axfer/test/generator.c | 260 +++++++++++ axfer/test/generator.h | 47 ++ axfer/test/mapper-test.c | 491 ++++++++++++++++++++ axfer/test/vumeter-test.c | 128 ++++++ axfer/vumeter.c | 565 +++++++++++++++++++++++ axfer/vumeter.h | 56 +++ axfer/waiter-epoll.c | 81 ++++ axfer/waiter-poll.c | 68 +++ axfer/waiter.c | 84 ++++ axfer/waiter.h | 52 +++ axfer/xfer-libasound-irq-mmap.c | 224 ++++++++++ axfer/xfer-libasound-irq-rw.c | 518 +++++++++++++++++++++ axfer/xfer-libasound.c | 682 ++++++++++++++++++++++++++++ axfer/xfer-libasound.h | 57 +++ axfer/xfer.c | 191 ++++++++ axfer/xfer.h | 76 ++++ configure.ac | 3 +- 40 files changed, 9147 insertions(+), 2 deletions(-) create mode 100644 axfer/Makefile.am create mode 100644 axfer/container-au.c create mode 100644 axfer/container-raw.c create mode 100644 axfer/container-riff-wave.c create mode 100644 axfer/container-voc.c create mode 100644 axfer/container.c create mode 100644 axfer/container.h create mode 100644 axfer/key-event.c create mode 100644 axfer/key-event.h create mode 100644 axfer/main.c create mode 100644 axfer/mapper-multiple.c create mode 100644 axfer/mapper-single.c create mode 100644 axfer/mapper.c create mode 100644 axfer/mapper.h create mode 100644 axfer/misc.h create mode 100644 axfer/options.c create mode 100644 axfer/options.h create mode 100644 axfer/subcmd-list.c create mode 100644 axfer/subcmd-transfer.c create mode 100644 axfer/subcmd.h create mode 100644 axfer/test/Makefile.am create mode 100644 axfer/test/container-test.c create mode 100644 axfer/test/generator.c create mode 100644 axfer/test/generator.h create mode 100644 axfer/test/mapper-test.c create mode 100644 axfer/test/vumeter-test.c create mode 100644 axfer/vumeter.c create mode 100644 axfer/vumeter.h create mode 100644 axfer/waiter-epoll.c create mode 100644 axfer/waiter-poll.c create mode 100644 axfer/waiter.c create mode 100644 axfer/waiter.h create mode 100644 axfer/xfer-libasound-irq-mmap.c create mode 100644 axfer/xfer-libasound-irq-rw.c create mode 100644 axfer/xfer-libasound.c create mode 100644 axfer/xfer-libasound.h create mode 100644 axfer/xfer.c create mode 100644 axfer/xfer.h -- 2.11.0

1 38