September 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH RESEND 0/3] Intel-rt5670 updates
by Pierre-Louis Bossart 20 Sep '17

20 Sep '17

[when I started cleaning-up some patches reviewed by Andy Shevchenko, I realized this initial batch has not been merged, although both Takashi and Vinod reviewed them, see http://mailman.alsa-project.org/pipermail/alsa-devel/2017-September/125331.… no change except for the addition of Takashi's Reviewed-by and Vinod's Acked-by. I don't mean to be pushy or anything, just checking if something is missing ] Instead of submitting all my patches at ones, I broke them by platforms/codecs. This series is only for Intel-rt5670 platforms. It fixes a mistake on the Dell Venue 5585 - corrected with the help from Realtek and Dell who kindly provided schematics and data sheet information needed to fix non-working DMIC capture. Since there are still some reports of non-functional audio on some platforms, I added quirks that can be changed from the kernel command line (and later added as DMI-based quirks). The last two patches are minor corrections to fix ACPI HID naming issues and use a more meaningful card name. Pierre-Louis Bossart (3): ASoC: rt5670: refactor DMI quirks and fix Dell Venue settings ASoC: Intel: cht_bsw_rt5672: use actual HID in suspend/resume ASoC: Intel: cht_bsw_rt5672: fix card name sound/soc/codecs/rt5670.c | 124 +++++++++++++++++++++++++++----- sound/soc/intel/boards/cht_bsw_rt5672.c | 10 ++- 2 files changed, 112 insertions(+), 22 deletions(-) -- 2.11.0

2 6

[alsa-devel] [asoc:topic/wm97xx 5/8] sound/soc/codecs/wm9712.c:23:30: fatal error: sound/ac97/codec.h: No such file or directory
by kbuild test robot 20 Sep '17

20 Sep '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/wm97xx head: 5aa3b03ad0712e3964a0ae2788f61f08da814bfe commit: 2ed1a8e0ce8db6d36f849526db61ce3c85a9f8d1 [5/8] ASoC: wm9712: add ac97 new bus support config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 2ed1a8e0ce8db6d36f849526db61ce3c85a9f8d1 # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): >> sound/soc/codecs/wm9712.c:23:30: fatal error: sound/ac97/codec.h: No such file or directory #include <sound/ac97/codec.h> ^ compilation terminated. vim +23 sound/soc/codecs/wm9712.c > 23 #include <sound/ac97/codec.h> 24 #include <sound/ac97/compat.h> 25 #include <sound/initval.h> 26 #include <sound/soc.h> 27 #include <sound/tlv.h> 28 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH 0/3] ASoC: Kill BUG_ON() usages
by Takashi Iwai 20 Sep '17

20 Sep '17

Hi, I found a few stupid BUG_ON() usages in the code, let's kill or replace them. Takashi === Takashi Iwai (3): ASoC: tas571x: Kill BUG_ON() usage ASoC: davinci: Kill BUG_ON() usage ASoC: intel: Kill BUG_ON() usage sound/soc/codecs/tas571x.c | 3 ++- sound/soc/davinci/davinci-mcasp.c | 3 ++- sound/soc/intel/atom/sst/sst_loader.c | 1 - sound/soc/intel/atom/sst/sst_stream.c | 1 - 4 files changed, 4 insertions(+), 4 deletions(-) -- 2.14.1

3 7

[alsa-devel] [Resend] [PATCH 0/4] ASoC: dapm: Avoid creating kcontrol for params
by yesanishhere＠gmail.com 20 Sep '17

20 Sep '17

From: anish kumar <yesanishhere(a)gmail.com> Currently in codec to codec dai link if there are multiple params defined then dapm can use created kcontrol to decide which param to apply at runtime. However, in case there is only single param configuration then there is no point in creating the kcontrol and also there is no point in allocating memory for kcontrol. In the snd_soc_dapm_new_pcm function, there is memory allocation happening for kcontrol which is later used or not used based on num_param. It is better to not allocate memory when there is only a single configuration. This change is to remedy that anomaly. This code change doesn't do much except just refactor snd_soc_dapm_new_pcm function. Now the part of allocating memory for kcontrol is allocated to a new function and it is called only in the case it is needed. anish kumar (4): ASoC: dapm: fix error path in snd_soc_dapm_new_pcm ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm ASoC: dapm: Avoid creating kcontrol for params ASoC: dapm: Remove the redundant check sound/soc/soc-dapm.c | 122 ++++++++++++++++++++++++++++----------------------- 1 file changed, 66 insertions(+), 56 deletions(-) -- 2.5.4 (Apple Git-61)

3 8

[alsa-devel] [patch 2/4] ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm
by anish kumar 20 Sep '17

20 Sep '17

refactor snd_soc_dapm_new_pcm to reduce the size of this function to facilitate further refactoring. Signed-off-by: anish kumar <yesanishhere(a)gmail.com> --- sound/soc/soc-dapm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 6e10a9a..1687c8a 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3821,19 +3821,15 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card, devm_kasprintf(card->dev, GFP_KERNEL, "Anonymous Configuration %d", count); - if (!w_param_text[count]) { - ret = -ENOMEM; - goto outfree_link_name; - } } else { w_param_text[count] = devm_kmemdup(card->dev, config->stream_name, strlen(config->stream_name) + 1, GFP_KERNEL); - if (!w_param_text[count]) { - ret = -ENOMEM; - goto outfree_link_name; - } + } + if (!w_param_text[count]) { + ret = -ENOMEM; + goto outfree_link_name; } config++; } -- 2.10.1 (Apple Git-78)

2 1

[alsa-devel] [PATCH] ASoC: tfa9879: Add device tree bindings
by Fabio Estevam 20 Sep '17

20 Sep '17

From: Fabio Estevam <fabio.estevam(a)nxp.com> Even though the tfa9879 driver can probe via device tree trough the I2C core code, it is preferable to have explicit device tree bindings instead [1], so add this support. [1] https://www.spinics.net/lists/devicetree/msg195176.html Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- Hi Lukasz, Could you please test this on your hardware? .../devicetree/bindings/sound/tfa9879.txt | 23 ++++++++++++++++++++++ sound/soc/codecs/tfa9879.c | 6 ++++++ 2 files changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt new file mode 100644 index 0000000..731ffe8 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/tfa9879.txt @@ -0,0 +1,23 @@ +NXP TFA9879 class-D audio amplifier + +Required properties: + +- compatible : "nxp,tfa9879" + +- reg : the I2C address of the device + +Example: + +&i2c1 { + clock-frequency = <100000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1>; + status = "okay"; + + codec: tfa9879@6c { + #sound-dai-cells = <0>; + compatible = "nxp,tfa9879"; + reg = <0x6c>; + }; +}; + diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c index 95e0a7a..f8dd67c 100644 --- a/sound/soc/codecs/tfa9879.c +++ b/sound/soc/codecs/tfa9879.c @@ -312,9 +312,15 @@ static const struct i2c_device_id tfa9879_i2c_id[] = { }; MODULE_DEVICE_TABLE(i2c, tfa9879_i2c_id); +static const struct of_device_id tfa9879_of_match[] = { + { .compatible = "nxp,tfa9879", }, + { } +}; + static struct i2c_driver tfa9879_i2c_driver = { .driver = { .name = "tfa9879", + .of_match_table = tfa9879_of_match, }, .probe = tfa9879_i2c_probe, .remove = tfa9879_i2c_remove, -- 2.7.4

3 2

[alsa-devel] [PATCH] ASoC: add missing snd_soc_component_set_jack
by Kuninori Morimoto 20 Sep '17

20 Sep '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> This patch adds missing definition of snd_soc_component_set_jack(). Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- include/sound/soc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/sound/soc.h b/include/sound/soc.h index d22de97..996bdbc 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -1487,6 +1487,8 @@ int snd_soc_component_set_sysclk(struct snd_soc_component *component, int snd_soc_component_set_pll(struct snd_soc_component *component, int pll_id, int source, unsigned int freq_in, unsigned int freq_out); +int snd_soc_component_set_jack(struct snd_soc_component *component, + struct snd_soc_jack *jack, void *data); #ifdef CONFIG_REGMAP -- 1.9.1

2 1

[alsa-devel] [PATCH 1/1] soc-pcm: check symmetry after hw_params
by Jiada Wang 20 Sep '17

20 Sep '17

hw_params may be fixup by be_hw_params_fixup, calling soc_pcm_params_symmetry() before hw_params will have issue if there is hw_params changes in be_hw_params_fixup. For example, with following use case 1. a dai-link which is able to convert sample rate on BE side 2. set BE playback and capture sample rate to 44100Hz 3. play a 48000Hz audio stream with this dai-link 4. record from this dai-link with 44100Hz sample rate Got following error message when record starts [ 495.013527] be_link_ak4613: ASoC: unmatched rate symmetry: 48000 - 44100 [ 495.021729] be_link_ak4613: ASoC: hw_params BE failed -22 [ 495.028589] rsnd_link0: ASoC: hw_params BE failed -22 Because in soc_pcm_hw_params(), FE rate is still having value before it is fixup by be_hw_params_fixup(), when soc_pcm_params_symmetry() checks symmetry, thus soc_pcm_params_symmetry() complains about the unmatched rate between the active stream and the new stream tries to start. This patch moves soc_pcm_params_symmetry() after hw_params to resolve the above issue. Signed-off-by: Jiada Wang <jiada_wang(a)mentor.com> --- sound/soc/soc-pcm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 94b88b8..f11421f 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -855,11 +855,6 @@ static int soc_pcm_hw_params(struct snd_pcm_substream *substream, int i, ret = 0; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); - - ret = soc_pcm_params_symmetry(substream, params); - if (ret) - goto out; - if (rtd->dai_link->ops && rtd->dai_link->ops->hw_params) { ret = rtd->dai_link->ops->hw_params(substream, params); if (ret < 0) { @@ -930,6 +925,10 @@ static int soc_pcm_hw_params(struct snd_pcm_substream *substream, cpu_dai->sample_bits = snd_pcm_format_physical_width(params_format(params)); + + ret = soc_pcm_params_symmetry(substream, params); + if (ret) + goto platform_err; out: mutex_unlock(&rtd->pcm_mutex); return ret; -- 2.9.3

2 2

[alsa-devel] [PATCH v7 0/8] AC97 device/driver model revamp
by Robert Jarzmik 20 Sep '17

20 Sep '17

Hi Lars, Mark, Charles, Lee, This is a revision for Lee and Charles, only targetted at wm97xx-core changes (second round) suggested by Lee and codecs remove path for Charles. I removed the leading 4 patches as Mark has already scheduled them. For easier spotting, I included in [1] the diff from the last serie. As before Charles, I think your ack is not granted anymore for codecs, could you have a look please ? Cheers. -- Robert Robert Jarzmik (8): Input: wm97xx: split out touchscreen registering mfd: wm97xx-core: core support for wm97xx Codec Input: wm97xx: add new AC97 bus support ASoC: wm9713: add ac97 new bus support ASoC: wm9712: add ac97 new bus support ASoC: wm9705: add private structure ASoC: wm9705: add ac97 new bus support ASoC: pxa: switch to new ac97 bus support drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/wm97xx-core.c | 252 +++++++++++++++------- drivers/mfd/Kconfig | 14 ++ drivers/mfd/Makefile | 1 + drivers/mfd/wm97xx-core.c | 366 ++++++++++++++++++++++++++++++++ include/linux/mfd/wm97xx.h | 25 +++ sound/arm/Kconfig | 1 - sound/soc/codecs/Kconfig | 9 +- sound/soc/codecs/wm9705.c | 66 ++++-- sound/soc/codecs/wm9712.c | 44 ++-- sound/soc/codecs/wm9713.c | 39 ++-- sound/soc/pxa/Kconfig | 5 +- sound/soc/pxa/pxa2xx-ac97.c | 46 ++-- 13 files changed, 712 insertions(+), 158 deletions(-) create mode 100644 drivers/mfd/wm97xx-core.c create mode 100644 include/linux/mfd/wm97xx.h -- 2.11.0 [1] Diff from the previous serie ---8>--- diff --git a/drivers/mfd/wm97xx-core.c b/drivers/mfd/wm97xx-core.c index 66e477fffd43..4141ee52a70b 100644 --- a/drivers/mfd/wm97xx-core.c +++ b/drivers/mfd/wm97xx-core.c @@ -109,12 +109,8 @@ static const struct regmap_config wm9705_regmap_config = { }; static struct mfd_cell wm9705_cells[] = { - { - .name = "wm9705-codec", - }, - { - .name = "wm97xx-ts", - }, + { .name = "wm9705-codec", }, + { .name = "wm97xx-ts", }, }; static bool wm9712_volatile_reg(struct device *dev, unsigned int reg) @@ -181,12 +177,8 @@ static const struct regmap_config wm9712_regmap_config = { }; static struct mfd_cell wm9712_cells[] = { - { - .name = "wm9712-codec", - }, - { - .name = "wm97xx-ts", - }, + { .name = "wm9712-codec", }, + { .name = "wm97xx-ts", }, }; static const struct reg_default wm9713_reg_defaults[] = { @@ -256,12 +248,8 @@ static const struct regmap_config wm9713_regmap_config = { }; static struct mfd_cell wm9713_cells[] = { - { - .name = "wm9713-codec", - }, - { - .name = "wm97xx-ts", - }, + { .name = "wm9713-codec", }, + { .name = "wm97xx-ts", }, }; static int wm97xx_ac97_probe(struct ac97_codec_device *adev) @@ -270,7 +258,7 @@ static int wm97xx_ac97_probe(struct ac97_codec_device *adev) const struct regmap_config *config; struct wm97xx_platform_data *codec_pdata; struct mfd_cell *cells; - int ret = 0, nb_cells, i; + int ret = -ENODEV, nb_cells, i; struct wm97xx_pdata *pdata = snd_ac97_codec_get_platdata(adev); wm97xx = devm_kzalloc(ac97_codec_dev2dev(adev), @@ -309,7 +297,7 @@ static int wm97xx_ac97_probe(struct ac97_codec_device *adev) nb_cells = ARRAY_SIZE(wm9713_cells); break; default: - config = NULL; + goto err_free_compat; } for (i = 0; i < nb_cells; i++) { @@ -317,23 +305,22 @@ static int wm97xx_ac97_probe(struct ac97_codec_device *adev) cells[i].pdata_size = sizeof(*codec_pdata); } - if (config) { - codec_pdata->regmap = - devm_regmap_init_ac97(wm97xx->ac97, config); - if (IS_ERR(codec_pdata->regmap)) - ret = PTR_ERR(codec_pdata->regmap); - } else { - ret = -ENODEV; + codec_pdata->regmap = devm_regmap_init_ac97(wm97xx->ac97, config); + if (IS_ERR(codec_pdata->regmap)) { + ret = PTR_ERR(codec_pdata->regmap); + goto err_free_compat; } - if (!ret) - ret = devm_mfd_add_devices(wm97xx->dev, PLATFORM_DEVID_NONE, - cells, nb_cells, NULL, 0, NULL); - + ret = devm_mfd_add_devices(wm97xx->dev, PLATFORM_DEVID_NONE, + cells, nb_cells, NULL, 0, NULL); if (ret) - snd_ac97_compat_release(wm97xx->ac97); + goto err_free_compat; return ret; + +err_free_compat: + snd_ac97_compat_release(wm97xx->ac97); + return ret; } static int wm97xx_ac97_remove(struct ac97_codec_device *adev) diff --git a/sound/soc/codecs/wm9705.c b/sound/soc/codecs/wm9705.c index 46b5a77c53e4..68c204e3599f 100644 --- a/sound/soc/codecs/wm9705.c +++ b/sound/soc/codecs/wm9705.c @@ -354,11 +354,14 @@ static int wm9705_soc_probe(struct snd_soc_codec *codec) static int wm9705_soc_remove(struct snd_soc_codec *codec) { +#ifdef CONFIG_SND_SOC_AC97_BUS struct wm9705_priv *wm9705 = snd_soc_codec_get_drvdata(codec); - snd_soc_codec_exit_regmap(codec); - if (!wm9705->mfd_pdata) + if (!wm9705->mfd_pdata) { + snd_soc_codec_exit_regmap(codec); snd_soc_free_ac97_codec(wm9705->ac97); + } +#endif return 0; } diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c index 7ebbb48b18c5..1e228bf9f1ae 100644 --- a/sound/soc/codecs/wm9712.c +++ b/sound/soc/codecs/wm9712.c @@ -674,11 +674,14 @@ static int wm9712_soc_probe(struct snd_soc_codec *codec) static int wm9712_soc_remove(struct snd_soc_codec *codec) { +#ifdef CONFIG_SND_SOC_AC97_BUS struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec); - snd_soc_codec_exit_regmap(codec); - if (!wm9712->mfd_pdata) + if (!wm9712->mfd_pdata) { + snd_soc_codec_exit_regmap(codec); snd_soc_free_ac97_codec(wm9712->ac97); + } +#endif return 0; } diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c index 3df2c01d751d..df7220656d98 100644 --- a/sound/soc/codecs/wm9713.c +++ b/sound/soc/codecs/wm9713.c @@ -1238,14 +1238,14 @@ static int wm9713_soc_probe(struct snd_soc_codec *codec) static int wm9713_soc_remove(struct snd_soc_codec *codec) { +#ifdef CONFIG_SND_SOC_AC97_BUS struct wm9713_priv *wm9713 = snd_soc_codec_get_drvdata(codec); if (!wm9713->mfd_pdata) { snd_soc_codec_exit_regmap(codec); -#ifdef CONFIG_SND_SOC_AC97_BUS snd_soc_free_ac97_codec(wm9713->ac97); -#endif } +#endif return 0; }

3 23

[alsa-devel] [RESEND][PATCH] ASoC: rsnd: add rsnd_dma_alloc()
by Kuninori Morimoto 20 Sep '17

20 Sep '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> R-Car sound DMA will be used from SSI/SRC. dma.c doesn't alloc DMA handler in .probe timing, because we don't know what kind of DMA transfer will be used then. Thus, SSI/SRC have *rsnd_mod for DMA. rsnd_dma_attach() will allocate it and attach it to system. It will be PIO mode if it can't alloc DMA handler. In case of MIX is used, rsnd_dma_attach() will be called twice from SSI. To avoid duplicate allocation, current rsnd_dma_attach() is checking allocated DMA handler. This DMA related operation is a little bit difficult to understand. This patch adds new rsnd_dma_alloc() and separates allocation and attach for readable code. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/dma.c | 60 +++++++++++++++++++++++++++---------------------- 1 file changed, 33 insertions(+), 27 deletions(-) diff --git a/sound/soc/sh/rcar/dma.c b/sound/soc/sh/rcar/dma.c index 041ec10..17220c9 100644 --- a/sound/soc/sh/rcar/dma.c +++ b/sound/soc/sh/rcar/dma.c @@ -753,14 +753,15 @@ static void rsnd_dma_of_path(struct rsnd_mod *this, } } -int rsnd_dma_attach(struct rsnd_dai_stream *io, struct rsnd_mod *mod, - struct rsnd_mod **dma_mod) +static int rsnd_dma_alloc(struct rsnd_dai_stream *io, struct rsnd_mod *mod, + struct rsnd_mod **dma_mod) { struct rsnd_mod *mod_from = NULL; struct rsnd_mod *mod_to = NULL; struct rsnd_priv *priv = rsnd_io_to_priv(io); struct rsnd_dma_ctrl *dmac = rsnd_priv_to_dmac(priv); struct device *dev = rsnd_priv_to_dev(priv); + struct rsnd_dma *dma; struct rsnd_mod_ops *ops; enum rsnd_mod_type type; int (*attach)(struct rsnd_dai_stream *io, struct rsnd_dma *dma, @@ -800,40 +801,45 @@ int rsnd_dma_attach(struct rsnd_dai_stream *io, struct rsnd_mod *mod, type = RSND_MOD_AUDMA; } - if (!(*dma_mod)) { - struct rsnd_dma *dma; + dma = devm_kzalloc(dev, sizeof(*dma), GFP_KERNEL); + if (!dma) + return -ENOMEM; - dma = devm_kzalloc(dev, sizeof(*dma), GFP_KERNEL); - if (!dma) - return -ENOMEM; + *dma_mod = rsnd_mod_get(dma); - *dma_mod = rsnd_mod_get(dma); + ret = rsnd_mod_init(priv, *dma_mod, ops, NULL, + rsnd_mod_get_status, type, dma_id); + if (ret < 0) + return ret; - ret = rsnd_mod_init(priv, *dma_mod, ops, NULL, - rsnd_mod_get_status, type, dma_id); - if (ret < 0) - return ret; + dev_dbg(dev, "%s[%d] %s[%d] -> %s[%d]\n", + rsnd_mod_name(*dma_mod), rsnd_mod_id(*dma_mod), + rsnd_mod_name(mod_from), rsnd_mod_id(mod_from), + rsnd_mod_name(mod_to), rsnd_mod_id(mod_to)); + + ret = attach(io, dma, mod_from, mod_to); + if (ret < 0) + return ret; - dev_dbg(dev, "%s[%d] %s[%d] -> %s[%d]\n", - rsnd_mod_name(*dma_mod), rsnd_mod_id(*dma_mod), - rsnd_mod_name(mod_from), rsnd_mod_id(mod_from), - rsnd_mod_name(mod_to), rsnd_mod_id(mod_to)); + dma->src_addr = rsnd_dma_addr(io, mod_from, is_play, 1); + dma->dst_addr = rsnd_dma_addr(io, mod_to, is_play, 0); + dma->mod_from = mod_from; + dma->mod_to = mod_to; + + return 0; +} + +int rsnd_dma_attach(struct rsnd_dai_stream *io, struct rsnd_mod *mod, + struct rsnd_mod **dma_mod) +{ + if (!(*dma_mod)) { + int ret = rsnd_dma_alloc(io, mod, dma_mod); - ret = attach(io, dma, mod_from, mod_to); if (ret < 0) return ret; - - dma->src_addr = rsnd_dma_addr(io, mod_from, is_play, 1); - dma->dst_addr = rsnd_dma_addr(io, mod_to, is_play, 0); - dma->mod_from = mod_from; - dma->mod_to = mod_to; } - ret = rsnd_dai_connect(*dma_mod, io, type); - if (ret < 0) - return ret; - - return 0; + return rsnd_dai_connect(*dma_mod, io, (*dma_mod)->type); } int rsnd_dma_probe(struct rsnd_priv *priv) -- 1.9.1

1 0