March 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3] ASoC: STI: Fix null ptr deference in IRQ handler
by Arnaud Pouliquen 06 Apr '17

06 Apr '17

With RTlinux a race condition has been found that leads to NULL ptr crash: - On CPU 0: uni_player_irq_handler is called to treat XRUN "(player->state == UNIPERIF_STATE_STOPPED)" is FALSE so status is checked, dev_err(player->dev, "FIFO underflow error detected") is printed and then snd_pcm_stream_lock should be called to lock stream for stopping. - On CPU 1: application stop and close the stream. Issue is that the stop and shutdown functions are executed while "FIFO underflow error detected" is printed. So when CPU 0 calls snd_pcm_stream_lock, player->substream is already null. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen(a)st.com> --- V3: - Lower case for labels, - Fix lock-unlock balance. V2: Add spinlock to protect player/reader->substream --- sound/soc/sti/uniperif.h | 1 + sound/soc/sti/uniperif_player.c | 35 ++++++++++++++++++++++++----------- sound/soc/sti/uniperif_reader.c | 24 ++++++++++++++++++++---- 3 files changed, 45 insertions(+), 15 deletions(-) diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index d487dd2..cfcb0ea 100644 --- a/sound/soc/sti/uniperif.h +++ b/sound/soc/sti/uniperif.h @@ -1299,6 +1299,7 @@ struct uniperif { int ver; /* IP version, used by register access macros */ struct regmap_field *clk_sel; struct regmap_field *valid_sel; + spinlock_t irq_lock; /* use to prevent race condition with IRQ */ /* capabilities */ const struct snd_pcm_hardware *hw; diff --git a/sound/soc/sti/uniperif_player.c b/sound/soc/sti/uniperif_player.c index 60ae31a..d7e8dd4 100644 --- a/sound/soc/sti/uniperif_player.c +++ b/sound/soc/sti/uniperif_player.c @@ -65,10 +65,13 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id) unsigned int status; unsigned int tmp; - if (player->state == UNIPERIF_STATE_STOPPED) { - /* Unexpected IRQ: do nothing */ - return IRQ_NONE; - } + spin_lock(&player->irq_lock); + if (!player->substream) + goto irq_spin_unlock; + + snd_pcm_stream_lock(player->substream); + if (player->state == UNIPERIF_STATE_STOPPED) + goto stream_unlock; /* Get interrupt status & clear them immediately */ status = GET_UNIPERIF_ITS(player); @@ -88,9 +91,7 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id) SET_UNIPERIF_ITM_BCLR_FIFO_ERROR(player); /* Stop the player */ - snd_pcm_stream_lock(player->substream); snd_pcm_stop(player->substream, SNDRV_PCM_STATE_XRUN); - snd_pcm_stream_unlock(player->substream); } ret = IRQ_HANDLED; @@ -104,9 +105,7 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id) SET_UNIPERIF_ITM_BCLR_DMA_ERROR(player); /* Stop the player */ - snd_pcm_stream_lock(player->substream); snd_pcm_stop(player->substream, SNDRV_PCM_STATE_XRUN); - snd_pcm_stream_unlock(player->substream); ret = IRQ_HANDLED; } @@ -116,7 +115,8 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id) if (!player->underflow_enabled) { dev_err(player->dev, "unexpected Underflow recovering\n"); - return -EPERM; + ret = -EPERM; + goto stream_unlock; } /* Read the underflow recovery duration */ tmp = GET_UNIPERIF_STATUS_1_UNDERFLOW_DURATION(player); @@ -138,13 +138,16 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id) dev_err(player->dev, "Underflow recovery failed\n"); /* Stop the player */ - snd_pcm_stream_lock(player->substream); snd_pcm_stop(player->substream, SNDRV_PCM_STATE_XRUN); - snd_pcm_stream_unlock(player->substream); ret = IRQ_HANDLED; } +stream_unlock: + snd_pcm_stream_unlock(player->substream); +irq_spin_unlock: + spin_unlock(&player->irq_lock); + return ret; } @@ -588,6 +591,7 @@ static int uni_player_ctl_iec958_put(struct snd_kcontrol *kcontrol, struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct uniperif *player = priv->dai_data.uni; struct snd_aes_iec958 *iec958 = &player->stream_settings.iec958; + unsigned long flags; mutex_lock(&player->ctrl_lock); iec958->status[0] = ucontrol->value.iec958.status[0]; @@ -596,12 +600,14 @@ static int uni_player_ctl_iec958_put(struct snd_kcontrol *kcontrol, iec958->status[3] = ucontrol->value.iec958.status[3]; mutex_unlock(&player->ctrl_lock); + spin_lock_irqsave(&player->irq_lock, flags); if (player->substream && player->substream->runtime) uni_player_set_channel_status(player, player->substream->runtime); else uni_player_set_channel_status(player, NULL); + spin_unlock_irqrestore(&player->irq_lock, flags); return 0; } @@ -686,9 +692,12 @@ static int uni_player_startup(struct snd_pcm_substream *substream, { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct uniperif *player = priv->dai_data.uni; + unsigned long flags; int ret; + spin_lock_irqsave(&player->irq_lock, flags); player->substream = substream; + spin_unlock_irqrestore(&player->irq_lock, flags); player->clk_adj = 0; @@ -986,12 +995,15 @@ static void uni_player_shutdown(struct snd_pcm_substream *substream, { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct uniperif *player = priv->dai_data.uni; + unsigned long flags; + spin_lock_irqsave(&player->irq_lock, flags); if (player->state != UNIPERIF_STATE_STOPPED) /* Stop the player */ uni_player_stop(player); player->substream = NULL; + spin_unlock_irqrestore(&player->irq_lock, flags); } static int uni_player_parse_dt_audio_glue(struct platform_device *pdev, @@ -1096,6 +1108,7 @@ int uni_player_init(struct platform_device *pdev, } mutex_init(&player->ctrl_lock); + spin_lock_init(&player->irq_lock); /* Ensure that disabled by default */ SET_UNIPERIF_CONFIG_BACK_STALL_REQ_DISABLE(player); diff --git a/sound/soc/sti/uniperif_reader.c b/sound/soc/sti/uniperif_reader.c index 93a8df6..ee0055e 100644 --- a/sound/soc/sti/uniperif_reader.c +++ b/sound/soc/sti/uniperif_reader.c @@ -46,10 +46,15 @@ static irqreturn_t uni_reader_irq_handler(int irq, void *dev_id) struct uniperif *reader = dev_id; unsigned int status; + spin_lock(&reader->irq_lock); + if (!reader->substream) + goto irq_spin_unlock; + + snd_pcm_stream_lock(reader->substream); if (reader->state == UNIPERIF_STATE_STOPPED) { /* Unexpected IRQ: do nothing */ dev_warn(reader->dev, "unexpected IRQ\n"); - return IRQ_HANDLED; + goto stream_unlock; } /* Get interrupt status & clear them immediately */ @@ -60,13 +65,16 @@ static irqreturn_t uni_reader_irq_handler(int irq, void *dev_id) if (unlikely(status & UNIPERIF_ITS_FIFO_ERROR_MASK(reader))) { dev_err(reader->dev, "FIFO error detected\n"); - snd_pcm_stream_lock(reader->substream); snd_pcm_stop(reader->substream, SNDRV_PCM_STATE_XRUN); - snd_pcm_stream_unlock(reader->substream); - return IRQ_HANDLED; + ret = IRQ_HANDLED; } +stream_unlock: + snd_pcm_stream_unlock(reader->substream); +irq_spin_unlock: + spin_unlock(&reader->irq_lock); + return ret; } @@ -347,9 +355,12 @@ static int uni_reader_startup(struct snd_pcm_substream *substream, { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct uniperif *reader = priv->dai_data.uni; + unsigned long flags; int ret; + spin_lock_irqsave(&reader->irq_lock, flags); reader->substream = substream; + spin_unlock_irqrestore(&reader->irq_lock, flags); if (!UNIPERIF_TYPE_IS_TDM(reader)) return 0; @@ -375,12 +386,15 @@ static void uni_reader_shutdown(struct snd_pcm_substream *substream, { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct uniperif *reader = priv->dai_data.uni; + unsigned long flags; + spin_lock_irqsave(&reader->irq_lock, flags); if (reader->state != UNIPERIF_STATE_STOPPED) { /* Stop the reader */ uni_reader_stop(reader); } reader->substream = NULL; + spin_unlock_irqrestore(&reader->irq_lock, flags); } static const struct snd_soc_dai_ops uni_reader_dai_ops = { @@ -415,6 +429,8 @@ int uni_reader_init(struct platform_device *pdev, return -EBUSY; } + spin_lock_init(&reader->irq_lock); + return 0; } EXPORT_SYMBOL_GPL(uni_reader_init); -- 1.9.1

2 1

[alsa-devel] [PATCH 00/14] ALSA: fireface: new driver for RME Fireface series
by Takashi Sakamoto 05 Apr '17

05 Apr '17

Hi, This patchset updates my previous RFCv3, and go for ALSA upstream. [alsa-devel] [RFC v3][PATCH 00/13] ALSA: fireface: new driver for RME Fireface series http://mailman.alsa-project.org/pipermail/alsa-devel/2017-February/117811.h… This patchset newly adds a driver into ALSA firewire stack, to support for Fireface 400 in RME FireWire series. Unfortunately, units on this series are completely against IEC 61883-1/6. This brings much commits and descriptions into this patchset. I'd ask you to review much amount of codes, as well as MOTU FireWire series, to finish my work for AMDTP variants[0]. As I noted to my former patchset, units of the series have unique feature; resampling between packet/data block processing layer and sample processing layer. This patchset relies on this layer, in short the driver doesn't handle sampling clock frequency, just handle sampling transmission frequency and expects units to generates audio from resampled data. Users should use proper application to configure sampling clock frequency when they want to match the frequency and sampling transmission frequency. Changes from RFCv3: * Add function pointer to AMDTP structure to reduce branching on packet processing. * Improve commit description. [0]: [alsa-devel] [RFC][PATCH 00/37] ALSA: firewire: support AMDTP variants [alsa-devel] [RFC][PATCH 00/37] ALSA: firewire: support AMDTP variants Takashi Sakamoto (14): ALSA: fireface: add skeleton for RME Fireface series ALSA: fireface: postpone sound card registration ALSA: fireface: add model specific structure ALSA: fireface: add an abstraction layer for model-specific protocols ALSA: fireface: add transaction support ALSA: fireface: add support for MIDI functionality ALSA: fireface: add proc node to help debugging ALSA: firewire-lib: use the same prototype for functions to handle packet ALSA: firewire-lib: add no-header packet processing ALSA: fireface: add unique data processing layer ALSA: fireface: add stream management functionality ALSA: fireface: add support for PCM functionality ALSA: fireface: add hwdep interface ALSA: fireface: add support for Fireface 400 include/uapi/sound/asound.h | 3 +- include/uapi/sound/firewire.h | 2 +- sound/firewire/Kconfig | 8 + sound/firewire/Makefile | 1 + sound/firewire/amdtp-stream-trace.h | 6 +- sound/firewire/amdtp-stream.c | 107 ++++++-- sound/firewire/amdtp-stream.h | 6 + sound/firewire/fireface/Makefile | 3 + sound/firewire/fireface/amdtp-ff.c | 155 +++++++++++ sound/firewire/fireface/ff-hwdep.c | 191 +++++++++++++ sound/firewire/fireface/ff-midi.c | 131 +++++++++ sound/firewire/fireface/ff-pcm.c | 409 ++++++++++++++++++++++++++++ sound/firewire/fireface/ff-proc.c | 63 +++++ sound/firewire/fireface/ff-protocol-ff400.c | 371 +++++++++++++++++++++++++ sound/firewire/fireface/ff-stream.c | 282 +++++++++++++++++++ sound/firewire/fireface/ff-transaction.c | 295 ++++++++++++++++++++ sound/firewire/fireface/ff.c | 209 ++++++++++++++ sound/firewire/fireface/ff.h | 146 ++++++++++ 18 files changed, 2365 insertions(+), 23 deletions(-) create mode 100644 sound/firewire/fireface/Makefile create mode 100644 sound/firewire/fireface/amdtp-ff.c create mode 100644 sound/firewire/fireface/ff-hwdep.c create mode 100644 sound/firewire/fireface/ff-midi.c create mode 100644 sound/firewire/fireface/ff-pcm.c create mode 100644 sound/firewire/fireface/ff-proc.c create mode 100644 sound/firewire/fireface/ff-protocol-ff400.c create mode 100644 sound/firewire/fireface/ff-stream.c create mode 100644 sound/firewire/fireface/ff-transaction.c create mode 100644 sound/firewire/fireface/ff.c create mode 100644 sound/firewire/fireface/ff.h -- 2.9.3

2 15

[alsa-devel] Create a general function for codec jack detection
by Bard Liao 05 Apr '17

05 Apr '17

Mark, There are many codecs with the capability of jack detection. Usually, we create a jack on machine driver and call an exported codec function, like rt5670_set_jack_detect, to use the jack and report the jack type. Could we create a general function for such exported functions? The benefit is we don't need to use different function names for each codecs. So we can have a general machine driver with jack detection function. Below is what I am thinking the patch will look like. diff --git a/include/sound/soc.h b/include/sound/soc.h index cdfb55f..e5a863a 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -434,6 +434,8 @@ int snd_soc_codec_set_sysclk(struct snd_soc_codec *codec, int clk_id, int source, unsigned int freq, int dir); int snd_soc_codec_set_pll(struct snd_soc_codec *codec, int pll_id, int source, unsigned int freq_in, unsigned int freq_out); +int snd_soc_codec_set_jack(struct snd_soc_codec *codec, + struct snd_soc_jack *jack); int snd_soc_register_card(struct snd_soc_card *card); int snd_soc_unregister_card(struct snd_soc_card *card); @@ -913,6 +915,7 @@ struct snd_soc_codec_driver { int clk_id, int source, unsigned int freq, int dir); int (*set_pll)(struct snd_soc_codec *codec, int pll_id, int source, unsigned int freq_in, unsigned int freq_out); + int (*set_jack)(struct snd_soc_codec *codec, struct snd_soc_jack *jack); /* codec IO */ struct regmap *(*get_regmap)(struct device *); diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index fbaa1bb..ec49577 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -22,6 +22,23 @@ #include <trace/events/asoc.h> /** + * snd_soc_codec_set_jack - configure codec jack. + * @codec: CODEC + * @jack: structure to use for the jack + * + * Configures and enables jack detection function. + */ +int snd_soc_codec_set_jack(struct snd_soc_codec *codec, + struct snd_soc_jack *jack) +{ + if (codec->driver->set_jack) + return codec->driver->set_jack(codec, jack); + else + return -EINVAL; +} +EXPORT_SYMBOL_GPL(snd_soc_codec_set_jack); + +/** * snd_soc_card_jack_new - Create a new jack * @card: ASoC card * @id: an identifying string for this jack -- Thanks. Bard Liao

2 1

[alsa-devel] PROBLEM: Internal microphone (& combined headset jack, in default config) not working on Acer VN7-592G (Skylake)
by Ralf Jung 04 Apr '17

04 Apr '17

Hi all, (This is my first bugreport to a mailing list, so I hope I'm filling out everything properly here...) [1.] Internal microphone (& combined headset jack, in default config) not working on Acer VN7-592G (Skylake) [2.] The internal microphone of my new laptop, an Acer Aspire V Nitro Black Edition (VN7-592G) with Skylake, is not working. The machine has a single "headset" jack which is supposed to support both speakers, microphones, and "combined jacks" that carry both audio-in and audio-out (like they are common on smartphones). Without any further configuration, the jack works only for external speakers. A plugged-in microphone doesn't seem to do anything, for a combined headset (i.e. sth. with both microphone and speaker in one jack), only the speaker part works. I tried all combinations of settings in pavucontrol, i.e., "Speakers" (that's the internal ones) vs. "Headphones" for audio output and "Microphone" vs. "Headset Microhpone" for the audio input. I was able to improve the situation by adding this to modprobe.d: options snd-hda-intel model=dell-headset-multi Now, mics and external speakers plugged in work fine (where for mics, I need to manually configure them in pacuvontrol: "Speakers" and "Microphone"). Combined headsets also work (with "Headphones" and "Headset Microphone"), i.e. I get audio in and audio out, but the audio in from the microphone is fairly noisy. I am not sure whether this is due to the headset or the laptop; I am using the same headset with my phone and people I called did not complain about noise. Furthermore, there is a weird effect: I have a headset with *separate* plugs for speaker and mic (which I used above to test the speaker vs. mic functionality). If I plug in the speaker part, but configure it as a microhpone (out: "Speakers", in: "Microphone"), then I actually get a (rather noisy) input signal. Not sure what is going on there, but I'm reasonably sure it is getting that signal from the headset, not the internal mic of the laptop. Even with this configuration, the internal microphone of the laptop dos not work. The system seems entirely unaware that there even is an internal microphone. Here's a Ubuntu bugreport with other folks having the same problem: <https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/1523100> [3.] Keywords: audio microphone skylake combined-jack [4.] Kernel information [4.1.] Kernel version (from /proc/version): Linux version 4.9.1 (r@r-schwarzschild) (gcc version 6.2.1 20161124 (Debian 6.2.1-5) ) #1 SMP Sun Jan 8 11:40:58 CET 2017 This is a vanilla kernel compiled myself; I'm otherwise on Debian testing amd64. [4.2.] Kernel .config file: attached [8.] Environment [8.1.] Software > Linux r-schwarzschild 4.9.1 #1 SMP Sun Jan 8 11:40:58 CET 2017 x86_64 GNU/Linux > > GNU C 6.2.1 > GNU Make 4.1 > Binutils 2.27.51.20161220 > Util-linux 2.29 > Mount 2.29 > Linux C Library 2.24 > Dynamic linker (ldd) 2.24 > readlink: missing operand > Try 'readlink --help' for more information. > Procps 3.3.12 > Kbd 2.0.3 > Console-tools 2.0.3 > Sh-utils 8.26 > Udev 232 > Modules Loaded ablk_helper ac acer_wmi acpi_pad aesni_intel aes_x86_64 af_alg ahci algif_skcipher arc4 ath10k_core ath10k_pci ath autofs4 battery bbswitch bluetooth bnep bridge btbcm btintel btrtl btusb button cfg80211 cmac coretemp crc16 crc32c_intel crc32_pclmul crct10dif_pclmul cryptd cuse dm_crypt dm_mod drm drm_kms_helper ebtable_broute ebtable_filter ebtable_nat ebtables efi_pstore efivarfs efivars evdev ext4 fat fjes fscrypto fuse gf128mul ghash_clmulni_intel glue_helper hid hid_generic hid_multitouch i2c_algo_bit i2c_designware_core i2c_designware_platform i2c_hid i2c_i801 i2c_smbus i915 idma64 intel_lpss intel_lpss_acpi intel_lpss_pci intel_powerclamp intel_rapl ip6table_filter ip6table_mangle ip6table_nat ip6table_raw ip6_tables ip6table_security ip6t_REJECT ip6t_rpfilter ip_set iptable_filter iptable_mangle iptable_nat iptable_raw ip_tables iptable_security ipt_REJECT irqbypass iTCO_vendor_support iTCO_wdt jbd2 joydev kvm kvm_intel libahci libata llc lp lrw mac80211 mbcache media mei mei_me memstick mfd_core mii mmc_core nf_conntrack nf_conntrack_ipv4 nf_conntrack_ipv6 nf_defrag_ipv4 nf_defrag_ipv6 nf_nat nf_nat_ipv4 nf_nat_ipv6 nfnetlink nf_reject_ipv4 nf_reject_ipv6 nls_ascii nls_cp437 parport parport_pc pci_stub pcspkr ppdev r8169 rfkill rtsx_usb rtsx_usb_ms rtsx_usb_sdmmc scsi_mod sd_mod serio_raw sg shpchp snd snd_hda_codec snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_core snd_hda_intel snd_hwdep snd_pcm snd_timer soundcore sparse_keymap stp thermal tpm tpm_crb tpm_tis tpm_tis_core usbcore usbhid uvcvideo vboxdrv vboxnetadp vboxnetflt vboxpci vfat video videobuf2_core videobuf2_memops videobuf2_v4l2 videobuf2_vmalloc videodev virt_dma wmi x86_pkg_temp_thermal xhci_hcd xhci_pci x_tables xt_conntrack xt_tcpudp [8.2.] Processor information (from /proc/cpuinfo): > vendor_id : GenuineIntel > cpu family : 6 > model : 94 > model name : Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz > stepping : 3 > microcode : 0x9e [8.3.] Module information (from /proc/modules): > pci_stub 16384 1 - Live 0xffffffffc0d1a000 (E) > vboxpci 24576 0 - Live 0xffffffffc0d0f000 (OE) > vboxnetadp 28672 0 - Live 0xffffffffc0d07000 (OE) > vboxnetflt 28672 0 - Live 0xffffffffc0cfb000 (OE) > vboxdrv 454656 3 vboxpci,vboxnetadp,vboxnetflt, Live 0xffffffffc0c6d000 (OE) > arc4 16384 2 - Live 0xffffffffc0c68000 (E) > xt_tcpudp 16384 3 - Live 0xffffffffc0c63000 (E) > ip6t_rpfilter 16384 1 - Live 0xffffffffc0c5e000 (E) > ip6t_REJECT 16384 2 - Live 0xffffffffc0c59000 (E) > nf_reject_ipv6 16384 1 ip6t_REJECT, Live 0xffffffffc0c54000 (E) > ipt_REJECT 16384 2 - Live 0xffffffffc0c44000 (E) > nf_reject_ipv4 16384 1 ipt_REJECT, Live 0xffffffffc0c3f000 (E) > xt_conntrack 16384 11 - Live 0xffffffffc08cc000 (E) > ip_set 45056 0 - Live 0xffffffffc08d1000 (E) > nfnetlink 16384 1 ip_set, Live 0xffffffffc08a7000 (E) > ebtable_nat 16384 1 - Live 0xffffffffc0c4f000 (E) > ebtable_broute 16384 1 - Live 0xffffffffc0c4a000 (E) > bridge 131072 1 ebtable_broute, Live 0xffffffffc0b50000 (E) > stp 16384 1 bridge, Live 0xffffffffc0b4b000 (E) > llc 16384 2 bridge,stp, Live 0xffffffffc0b42000 (E) > ip6table_raw 16384 1 - Live 0xffffffffc0b3d000 (E) > ip6table_nat 16384 1 - Live 0xffffffffc0b38000 (E) > nf_conntrack_ipv6 20480 7 - Live 0xffffffffc0b1d000 (E) > nf_defrag_ipv6 36864 1 nf_conntrack_ipv6, Live 0xffffffffc0b2a000 (E) > nf_nat_ipv6 16384 1 ip6table_nat, Live 0xffffffffc0b14000 (E) > ip6table_mangle 16384 1 - Live 0xffffffffc0b0f000 (E) > ip6table_security 16384 1 - Live 0xffffffffc0b0a000 (E) > iptable_raw 16384 1 - Live 0xffffffffc0b05000 (E) > iptable_nat 16384 1 - Live 0xffffffffc0b00000 (E) > nf_conntrack_ipv4 16384 6 - Live 0xffffffffc0af7000 (E) > nf_defrag_ipv4 16384 1 nf_conntrack_ipv4, Live 0xffffffffc0a37000 (E) > nf_nat_ipv4 16384 1 iptable_nat, Live 0xffffffffc08b4000 (E) > nf_nat 28672 2 nf_nat_ipv6,nf_nat_ipv4, Live 0xffffffffc0a2f000 (E) > nf_conntrack 114688 6 xt_conntrack,nf_conntrack_ipv6,nf_nat_ipv6,nf_conntrack_ipv4,nf_nat_ipv4,nf_nat, Live 0xffffffffc0930000 (E) > iptable_mangle 16384 1 - Live 0xffffffffc0890000 (E) > iptable_security 16384 1 - Live 0xffffffffc088b000 (E) > ebtable_filter 16384 1 - Live 0xffffffffc070e000 (E) > ebtables 36864 3 ebtable_nat,ebtable_broute,ebtable_filter, Live 0xffffffffc0746000 (E) > ip6table_filter 16384 1 - Live 0xffffffffc06b1000 (E) > ip6_tables 28672 5 ip6table_raw,ip6table_nat,ip6table_mangle,ip6table_security,ip6table_filter, Live 0xffffffffc0719000 (E) > iptable_filter 16384 1 - Live 0xffffffffc0698000 (E) > cmac 16384 1 - Live 0xffffffffc0693000 (E) > bbswitch 16384 0 - Live 0xffffffffc0642000 (OE) > bnep 20480 2 - Live 0xffffffffc062e000 (E) > hid_multitouch 20480 0 - Live 0xffffffffc063c000 (E) > joydev 20480 0 - Live 0xffffffffc07a3000 (E) > snd_hda_codec_hdmi 45056 1 - Live 0xffffffffc0924000 (E) > nls_ascii 16384 1 - Live 0xffffffffc0663000 (E) > ath10k_pci 45056 0 - Live 0xffffffffc08e7000 (E) > nls_cp437 20480 1 - Live 0xffffffffc07f9000 (E) > ath10k_core 245760 1 ath10k_pci, Live 0xffffffffc09e2000 (E) > vfat 20480 1 - Live 0xffffffffc07f3000 (E) > ath 32768 1 ath10k_core, Live 0xffffffffc07aa000 (E) > acer_wmi 20480 0 - Live 0xffffffffc06d5000 (E) > i2c_designware_platform 16384 0 - Live 0xffffffffc052b000 (E) > fat 69632 1 vfat, Live 0xffffffffc08ba000 (E) > snd_hda_codec_realtek 86016 1 - Live 0xffffffffc090e000 (E) > efi_pstore 16384 0 - Live 0xffffffffc0497000 (E) > i2c_designware_core 20480 1 i2c_designware_platform, Live 0xffffffffc08ae000 (E) > snd_hda_codec_generic 69632 1 snd_hda_codec_realtek, Live 0xffffffffc0895000 (E) > intel_rapl 20480 0 - Live 0xffffffffc069f000 (E) > sparse_keymap 16384 1 acer_wmi, Live 0xffffffffc0526000 (E) > mac80211 663552 1 ath10k_core, Live 0xffffffffc0b9c000 (E) > x86_pkg_temp_thermal 16384 0 - Live 0xffffffffc0b25000 (E) > cfg80211 552960 3 ath10k_core,ath,mac80211, Live 0xffffffffc0a6f000 (E) > snd_hda_intel 36864 6 - Live 0xffffffffc08dd000 (E) > intel_powerclamp 16384 0 - Live 0xffffffffc06ac000 (E) > btusb 45056 0 - Live 0xffffffffc0a23000 (E) > coretemp 16384 0 - Live 0xffffffffc0647000 (E) > btrtl 16384 1 btusb, Live 0xffffffffc07ee000 (E) > snd_hda_codec 135168 4 snd_hda_codec_hdmi,snd_hda_codec_realtek,snd_hda_codec_generic,snd_hda_intel, Live 0xffffffffc0b7a000 (E) > uvcvideo 90112 0 - Live 0xffffffffc08f7000 (E) > snd_hda_core 81920 5 snd_hda_codec_hdmi,snd_hda_codec_realtek,snd_hda_codec_generic,snd_hda_intel,snd_hda_codec, Live 0xffffffffc07d9000 (E) > btbcm 16384 1 btusb, Live 0xffffffffc07d4000 (E) > videobuf2_vmalloc 16384 1 uvcvideo, Live 0xffffffffc0764000 (E) > btintel 16384 1 btusb, Live 0xffffffffc075f000 (E) > videobuf2_memops 16384 1 videobuf2_vmalloc, Live 0xffffffffc07cf000 (E) > snd_hwdep 16384 1 snd_hda_codec, Live 0xffffffffc0b71000 (E) > videobuf2_v4l2 24576 1 uvcvideo, Live 0xffffffffc06a5000 (E) > kvm_intel 192512 0 - Live 0xffffffffc0a3f000 (E) > videobuf2_core 36864 2 uvcvideo,videobuf2_v4l2, Live 0xffffffffc0668000 (E) > kvm 589824 1 kvm_intel, Live 0xffffffffc0951000 (E) > bluetooth 552960 26 bnep,btusb,btrtl,btbcm,btintel, Live 0xffffffffc0803000 (E) > snd_pcm 110592 6 snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec,snd_hda_core, Live 0xffffffffc07b3000 (E) > videodev 176128 3 uvcvideo,videobuf2_v4l2,videobuf2_core, Live 0xffffffffc0777000 (E) > rtsx_usb_ms 20480 0 - Live 0xffffffffc076d000 (E) > irqbypass 16384 1 kvm, Live 0xffffffffc0677000 (E) > efivars 20480 1 efi_pstore, Live 0xffffffffc0680000 (E) > media 40960 2 uvcvideo,videodev, Live 0xffffffffc073b000 (E) > snd_timer 32768 1 snd_pcm, Live 0xffffffffc0756000 (E) > mei_me 36864 0 - Live 0xffffffffc06ec000 (E) > pcspkr 16384 0 - Live 0xffffffffc0629000 (E) > serio_raw 16384 0 - Live 0xffffffffc0624000 (E) > snd 86016 18 snd_hda_codec_hdmi,snd_hda_codec_realtek,snd_hda_codec_generic,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_pcm,snd_timer, Live 0xffffffffc0725000 (E) > idma64 20480 0 - Live 0xffffffffc0510000 (E) > iTCO_wdt 16384 0 - Live 0xffffffffc0751000 (E) > memstick 20480 1 rtsx_usb_ms, Live 0xffffffffc0713000 (E) > rfkill 24576 8 acer_wmi,cfg80211,bluetooth, Live 0xffffffffc0707000 (E) > iTCO_vendor_support 16384 1 iTCO_wdt, Live 0xffffffffc0702000 (E) > soundcore 16384 1 snd, Live 0xffffffffc06f9000 (E) > sg 32768 0 - Live 0xffffffffc06df000 (E) > mei 102400 1 mei_me, Live 0xffffffffc06bb000 (E) > virt_dma 16384 1 idma64, Live 0xffffffffc06b6000 (E) > shpchp 36864 0 - Live 0xffffffffc0659000 (E) > intel_lpss_pci 16384 0 - Live 0xffffffffc0650000 (E) > battery 16384 0 - Live 0xffffffffc0519000 (E) > ac 16384 0 - Live 0xffffffffc010e000 (E) > intel_lpss_acpi 16384 0 - Live 0xffffffffc068e000 (E) > wmi 16384 1 acer_wmi, Live 0xffffffffc0672000 (E) > intel_lpss 16384 2 intel_lpss_pci,intel_lpss_acpi, Live 0xffffffffc031f000 (E) > evdev 24576 18 - Live 0xffffffffc061d000 (E) > acpi_pad 24576 0 - Live 0xffffffffc0616000 (E) > tpm_crb 16384 0 - Live 0xffffffffc0637000 (E) > tpm_tis 16384 0 - Live 0xffffffffc0492000 (E) > tpm_tis_core 20480 1 tpm_tis, Live 0xffffffffc0688000 (E) > tpm 45056 3 tpm_crb,tpm_tis,tpm_tis_core, Live 0xffffffffc0532000 (E) > cuse 16384 3 - Live 0xffffffffc02b5000 (E) > fuse 98304 2 cuse, Live 0xffffffffc04b7000 (E) > parport_pc 28672 0 - Live 0xffffffffc048a000 (E) > ppdev 20480 0 - Live 0xffffffffc0484000 (E) > lp 20480 0 - Live 0xffffffffc0335000 (E) > parport 49152 3 parport_pc,ppdev,lp, Live 0xffffffffc02fe000 (E) > efivarfs 16384 1 - Live 0xffffffffc02f9000 (E) > ip_tables 24576 5 iptable_raw,iptable_nat,iptable_mangle,iptable_security,iptable_filter, Live 0xffffffffc02ba000 (E) > x_tables 36864 16 xt_tcpudp,ip6t_rpfilter,ip6t_REJECT,ipt_REJECT,xt_conntrack,ip6table_raw,ip6table_mangle,ip6table_security,iptable_raw,iptable_mangle,iptable_security,ebtables,ip6table_filter,ip6_tables,iptable_filter,ip_tables, Live 0xffffffffc025a000 (E) > autofs4 40960 2 - Live 0xffffffffc02aa000 (E) > ext4 581632 4 - Live 0xffffffffc0587000 (E) > crc16 16384 2 bluetooth,ext4, Live 0xffffffffc0265000 (E) > jbd2 106496 1 ext4, Live 0xffffffffc0469000 (E) > fscrypto 28672 1 ext4, Live 0xffffffffc01cf000 (E) > mbcache 16384 5 ext4, Live 0xffffffffc01c6000 (E) > algif_skcipher 20480 0 - Live 0xffffffffc0108000 (E) > af_alg 16384 1 algif_skcipher, Live 0xffffffffc00f5000 (E) > dm_crypt 24576 2 - Live 0xffffffffc011d000 (E) > dm_mod 114688 14 dm_crypt, Live 0xffffffffc056a000 (E) > rtsx_usb_sdmmc 28672 0 - Live 0xffffffffc0115000 (E) > mmc_core 143360 1 rtsx_usb_sdmmc, Live 0xffffffffc04e5000 (E) > rtsx_usb 24576 2 rtsx_usb_ms,rtsx_usb_sdmmc, Live 0xffffffffc00ee000 (E) > mfd_core 16384 2 intel_lpss,rtsx_usb, Live 0xffffffffc00e9000 (E) > hid_generic 16384 0 - Live 0xffffffffc00df000 (E) > usbhid 53248 0 - Live 0xffffffffc00fa000 (E) > sd_mod 45056 6 - Live 0xffffffffc009a000 (E) > crct10dif_pclmul 16384 0 - Live 0xffffffffc0521000 (E) > crc32_pclmul 16384 0 - Live 0xffffffffc04b2000 (E) > crc32c_intel 24576 8 - Live 0xffffffffc0509000 (E) > ghash_clmulni_intel 16384 0 - Live 0xffffffffc04d7000 (E) > aesni_intel 167936 8 - Live 0xffffffffc0540000 (E) > aes_x86_64 20480 1 aesni_intel, Live 0xffffffffc04df000 (E) > lrw 16384 1 aesni_intel, Live 0xffffffffc04aa000 (E) > gf128mul 16384 1 lrw, Live 0xffffffffc04d2000 (E) > glue_helper 16384 1 aesni_intel, Live 0xffffffffc00e4000 (E) > ablk_helper 16384 1 aesni_intel, Live 0xffffffffc00b5000 (E) > cryptd 24576 5 ghash_clmulni_intel,aesni_intel,ablk_helper, Live 0xffffffffc049f000 (E) > i915 1228800 29 - Live 0xffffffffc033c000 (E) > ahci 36864 4 - Live 0xffffffffc032b000 (E) > i2c_algo_bit 16384 1 i915, Live 0xffffffffc0324000 (E) > libahci 32768 1 ahci, Live 0xffffffffc0316000 (E) > i2c_i801 24576 0 - Live 0xffffffffc030b000 (E) > drm_kms_helper 155648 1 i915, Live 0xffffffffc02d2000 (E) > xhci_pci 16384 0 - Live 0xffffffffc02c9000 (E) > i2c_smbus 16384 1 i2c_i801, Live 0xffffffffc02c1000 (E) > libata 249856 2 ahci,libahci, Live 0xffffffffc026c000 (E) > xhci_hcd 188416 1 xhci_pci, Live 0xffffffffc0216000 (E) > r8169 81920 0 - Live 0xffffffffc0245000 (E) > mii 16384 1 r8169, Live 0xffffffffc020f000 (E) > scsi_mod 225280 3 sg,sd_mod,libata, Live 0xffffffffc01d7000 (E) > usbcore 249856 6 btusb,uvcvideo,rtsx_usb,usbhid,xhci_pci,xhci_hcd, Live 0xffffffffc0184000 (E) > drm 360448 9 i915,drm_kms_helper, Live 0xffffffffc012b000 (E) > thermal 20480 0 - Live 0xffffffffc00d9000 (E) > i2c_hid 20480 0 - Live 0xffffffffc0125000 (E) > hid 122880 4 hid_multitouch,hid_generic,usbhid,i2c_hid, Live 0xffffffffc00ba000 (E) > video 40960 2 acer_wmi,i915, Live 0xffffffffc00aa000 (E) > fjes 28672 0 - Live 0xffffffffc0092000 (E) > button 16384 1 i915, Live 0xffffffffc0089000 (E) [8.4.] Loaded driver and hardware information /proc/ioports: > 0000-0000 : PCI Bus 0000:00 > 0000-0000 : dma1 > 0000-0000 : pic1 > 0000-0000 : timer0 > 0000-0000 : timer1 > 0000-0000 : keyboard > 0000-0000 : PNP0C09:00 > 0000-0000 : EC data > 0000-0000 : keyboard > 0000-0000 : PNP0C09:00 > 0000-0000 : EC cmd > 0000-0000 : rtc0 > 0000-0000 : dma page reg > 0000-0000 : pic2 > 0000-0000 : dma2 > 0000-0000 : fpu > 0000-0000 : PNP0C04:00 > 0000-0000 : iTCO_wdt > 0000-0000 : iTCO_wdt > 0000-0000 : pnp 00:03 > 0000-0000 : PCI conf1 > 0000-0000 : PCI Bus 0000:00 > 0000-0000 : pnp 00:02 > 0000-0000 : ACPI PM1a_EVT_BLK > 0000-0000 : ACPI PM1a_CNT_BLK > 0000-0000 : ACPI PM_TMR > 0000-0000 : ACPI CPU throttle > 0000-0000 : iTCO_wdt > 0000-0000 : iTCO_wdt > 0000-0000 : ACPI PM2_CNT_BLK > 0000-0000 : pnp 00:05 > 0000-0000 : ACPI GPE0_BLK > 0000-0000 : pnp 00:01 > 0000-0000 : PCI Bus 0000:07 > 0000-0000 : 0000:07:00.0 > 0000-0000 : r8169 > 0000-0000 : PCI Bus 0000:01 > 0000-0000 : 0000:01:00.0 > 0000-0000 : 0000:00:02.0 > 0000-0000 : 0000:00:1f.4 > 0000-0000 : i801_smbus > 0000-0000 : 0000:00:17.0 > 0000-0000 : ahci > 0000-0000 : 0000:00:17.0 > 0000-0000 : ahci > 0000-0000 : 0000:00:17.0 > 0000-0000 : ahci > 0000-0000 : PCI Bus 0000:08 > 0000-0000 : pnp 00:02 > 0000-0000 : pnp 00:02 > 0000-0000 : pnp 00:02 /proc/iomem: > 00000000-00000000 : reserved > 00000000-00000000 : System RAM > 00000000-00000000 : reserved > 00000000-00000000 : System RAM > 00000000-00000000 : reserved > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : System ROM > 00000000-00000000 : System RAM > 00000000-00000000 : ACPI Non-volatile Storage > 00000000-00000000 : reserved > 00000000-00000000 : System RAM > 00000000-00000000 : reserved > 00000000-00000000 : System RAM > 00000000-00000000 : reserved > 00000000-00000000 : reserved > 00000000-00000000 : ACPI Non-volatile Storage > 00000000-00000000 : ACPI Tables > 00000000-00000000 : System RAM > 00000000-00000000 : reserved > 00000000-00000000 : Graphics Stolen Memory > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : pnp 00:08 > 00000000-00000000 : PCI Bus 0000:01 > 00000000-00000000 : 0000:01:00.0 > 00000000-00000000 : 0000:01:00.0 > 00000000-00000000 : PCI Bus 0000:08 > 00000000-00000000 : 0000:00:02.0 > 00000000-00000000 : PCI Bus 0000:01 > 00000000-00000000 : 0000:01:00.0 > 00000000-00000000 : PCI Bus 0000:06 > 00000000-00000000 : 0000:06:00.0 > 00000000-00000000 : ath > 00000000-00000000 : PCI Bus 0000:07 > 00000000-00000000 : 0000:07:00.0 > 00000000-00000000 : r8169 > 00000000-00000000 : 0000:07:00.0 > 00000000-00000000 : r8169 > 00000000-00000000 : 0000:00:14.0 > 00000000-00000000 : xhci-hcd > 00000000-00000000 : 0000:00:1f.3 > 00000000-00000000 : ICH HD audio > 00000000-00000000 : 0000:00:1f.3 > 00000000-00000000 : ICH HD audio > 00000000-00000000 : 0000:00:1f.2 > 00000000-00000000 : 0000:00:17.0 > 00000000-00000000 : ahci > 00000000-00000000 : 0000:00:15.0 > 00000000-00000000 : lpss_dev > 00000000-00000000 : lpss_dev > 00000000-00000000 : lpss_priv > 00000000-00000000 : idma64.0 > 00000000-00000000 : idma64.0 > 00000000-00000000 : 0000:00:15.1 > 00000000-00000000 : lpss_dev > 00000000-00000000 : lpss_dev > 00000000-00000000 : lpss_priv > 00000000-00000000 : idma64.1 > 00000000-00000000 : idma64.1 > 00000000-00000000 : 0000:00:16.0 > 00000000-00000000 : mei_me > 00000000-00000000 : 0000:00:17.0 > 00000000-00000000 : ahci > 00000000-00000000 : 0000:00:1f.4 > 00000000-00000000 : 0000:00:17.0 > 00000000-00000000 : ahci > 00000000-00000000 : 0000:00:02.0 > 00000000-00000000 : PCI Bus 0000:08 > 00000000-00000000 : PCI MMCONFIG 0000 [bus 00-ff] > 00000000-00000000 : reserved > 00000000-00000000 : pnp 00:08 > 00000000-00000000 : reserved > 00000000-00000000 : PCI Bus 0000:00 > 00000000-00000000 : pnp 00:00 > 00000000-00000000 : pnp 00:07 > 00000000-00000000 : pnp 00:00 > 00000000-00000000 : pnp 00:07 > 00000000-00000000 : pnp 00:07 > 00000000-00000000 : pnp 00:00 > 00000000-00000000 : iTCO_wdt > 00000000-00000000 : iTCO_wdt > 00000000-00000000 : pnp 00:00 > 00000000-00000000 : pnp 00:00 > 00000000-00000000 : pnp 00:00 > 00000000-00000000 : pnp 00:00 > 00000000-00000000 : pnp 00:02 > 00000000-00000000 : reserved > 00000000-00000000 : reserved > 00000000-00000000 : IOAPIC 0 > 00000000-00000000 : reserved > 00000000-00000000 : HPET 0 > 00000000-00000000 : PNP0103:00 > 00000000-00000000 : reserved > 00000000-00000000 : pnp 00:08 > 00000000-00000000 : pnp 00:08 > 00000000-00000000 : pnp 00:08 > 00000000-00000000 : pnp 00:08 > 00000000-00000000 : MSFT0101:00 > 00000000-00000000 : reserved > 00000000-00000000 : dmar0 > 00000000-00000000 : dmar1 > 00000000-00000000 : Local APIC > 00000000-00000000 : reserved > 00000000-00000000 : INT0800:00 > 00000000-00000000 : reserved > 00000000-00000000 : System RAM > 00000000-00000000 : Kernel code > 00000000-00000000 : Kernel data > 00000000-00000000 : Kernel bss > 00000000-00000000 : RAM buffer [8.5.] PCI information: attached I would be very grateful for your assistance. Let me know if you need any further information. Kind regards, Ralf

2 3

[alsa-devel] ESI Maya22 init issues
by Rabit 04 Apr '17

04 Apr '17

Hi AlsaDevs, Seems like something wrong with maya22 usb initialization. I'm trying to use my control application after lin init (fail) and win init (working): https://github.com/rabits/esi-maya22-linux - it's working fine on ubuntu 14.04 ~yr ago, when I'm done this app, but now it's broken... Could you please help me with figuring out what's wrong? I can attach required info and try another ubuntu versions. Attached alsainfo. Also can provide pcapng with init process for lin & win. -- Best regards

1 1

[alsa-devel] [RFC][PATCH] ASoC: soc-core: verify Sound Card normality
by Kuninori Morimoto 04 Apr '17

04 Apr '17

Current ALSA SoC Sound Card basically consists of CPU/Codec/Platform drivers. If system uses Kernel modules, we can disable these drivers by using rmmod command. In such case, we can't disable CPU/Codec/Platform driver without disabling Sound Card driver. But on the other hand, we can disable these drivers by using unbind command. In such case, we can disable these drivers randomly. In this case, we can create dirty Sound Card which is missing necessary components. (1) If user disabled Sound Card first, but did nothing to other drivers, user can't use Sound because Sound Card is no longer exists. (2) If user disabled CPU/Codec/Platform driver randomly, but did nothing to Sound Card, user still be able to use Sound Card, because dirty Sound Card which is missing necessary components still exists. In this case, Sound system will be crashed if user started sound playback/capture. But we can't block such random unbind now. To avoid Sound Card crash in (2) case, what we can do now is, add dirty flag on Sound Card, and avoid to open Sound Card. This patch solved this issue. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- Mark, Lars-Peter This is still RFC, but I think we need to consider about this issue. I tested this patch on my system, and it can block to sound card crash for me include/sound/soc.h | 6 ++++-- sound/soc/soc-core.c | 12 +++++++++++- sound/soc/soc-pcm.c | 20 ++++++++++++++++++++ 3 files changed, 35 insertions(+), 3 deletions(-) diff --git a/include/sound/soc.h b/include/sound/soc.h index 316fdce..4813fc5 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -1106,8 +1106,6 @@ struct snd_soc_card { struct mutex mutex; struct mutex dapm_mutex; - bool instantiated; - int (*probe)(struct snd_soc_card *card); int (*late_probe)(struct snd_soc_card *card); int (*remove)(struct snd_soc_card *card); @@ -1197,6 +1195,10 @@ struct snd_soc_card { u32 pop_time; void *drvdata; + + /* bit field */ + u32 instantiated:1; + u32 dirty:1; }; /* SoC machine DAI configuration, glues a codec and cpu DAI together */ diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 07e4eec..a18e106 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -2882,7 +2882,15 @@ int snd_soc_unregister_card(struct snd_soc_card *card) { if (card->instantiated) { card->instantiated = false; - snd_soc_dapm_shutdown(card); + if (!card->dirty) { + /* + * In case of unbind, CPU/Codec/Platform component can + * be unbinded *before* Card unbind. In such case + * (= card->dirty) Card connected DAPMs are already + * doesn't exist. + */ + snd_soc_dapm_shutdown(card); + } soc_cleanup_card_resources(card); dev_dbg(card->dev, "ASoC: Unregistered card '%s'\n", card->name); } @@ -3236,6 +3244,8 @@ static void snd_soc_component_cleanup(struct snd_soc_component *component) static void snd_soc_component_del_unlocked(struct snd_soc_component *component) { + if (component->card) + component->card->dirty = 1; list_del(&component->list); } diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index efc5831..c861aba 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -455,6 +455,16 @@ static int soc_pcm_open(struct snd_pcm_substream *substream) const char *codec_dai_name = "multicodec"; int i, ret = 0; + if (rtd->card->dirty) { + /* + * In case of unbind, each CPU/Codec/Platform component can + * be unbinded randomly. In such case (= card->dirty) + * Sound Card is no longer safety. Don't open it. + */ + dev_warn(cpu_dai->dev, "Sound SoC Card is dirty, Recheck your system\n"); + return -ENXIO; + } + pinctrl_pm_select_default_state(cpu_dai->dev); for (i = 0; i < rtd->num_codecs; i++) pinctrl_pm_select_default_state(rtd->codec_dais[i]->dev); @@ -2577,6 +2587,16 @@ static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream) int ret; int stream = fe_substream->stream; + if (fe->card->dirty) { + /* + * In case of unbind, each CPU/Codec/Platform component can + * be unbinded randomly. In such case (= card->dirty) + * Sound Card is no longer safety. Don't open it. + */ + dev_warn(fe->dev, "Sound SoC Card is dirty, Recheck your system\n"); + return -ENXIO; + } + mutex_lock_nested(&fe->card->mutex, SND_SOC_CARD_CLASS_RUNTIME); fe->dpcm[stream].runtime = fe_substream->runtime; -- 1.9.1

4 11

[alsa-devel] mono/stereo translation & number of frames per period
by Paul Stone 04 Apr '17

04 Apr '17

I thought that simply by reporting that my driver only supports two channels, that I could simply utilize a mixer or that ALSA would automatically support sending and receiving monaural data to/from my stereo-only driver. Ultimately, I wasn't able to make it work. Is this a mode of operation that ALSA supports, or does ALSA require the driver to support single-channel operation in order to send/receive monaural data? So, I decided that I should support both mono and stereo in the driver. It appears that ALSA looks at the minimum period size and decides to send that much audio data for playback. The minimum period size is in bytes, which means that the number of mono and stereo frames per period will differ. This introduces a bit of additional unwanted complexity. I'm wondering if there is a way for ALSA to support a fixed number of frames per period. I see that there is a bit field SNDRV_PCM_INFO_FIFO_IN_FRAMES, and a fifo_size h/w parameter, but I'm not sure how this relates to the period size. I feel like this is a common mode of operation (fixed number of frames per period, regardless of the number of channels), and that it's likely supported by ALSA, but I don't know how it's supposed to work. Should I set up a rule to alter the minimum period size, based on the number of channels? Best Regards, Paul Stone

2 1

[alsa-devel] [PATCH v2 1/2] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK
by Zidan Wang 04 Apr '17

04 Apr '17

From: Zidan Wang <b50113(a)freescale.com> When we want to use wm8960 codec, we should enable its MCLK in machine driver. It's reasonable for wm8960 codec driver to manage its own MCLK. When current bias_level is SND_SOC_BIAS_ON, it is preparing for a transition away from ON. In this case, disable the codec mclk. When current bias_level is not SND_SOC_BIAS_ON, it preparing for a transition to ON. In this case, enable the codec mclk. Signed-off-by: Zidan Wang <b50113(a)freescale.com> --- sound/soc/codecs/wm8960.c | 51 ++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 75cd7de..fd25973 100644 --- a/sound/soc/codecs/wm8960.c +++ b/sound/soc/codecs/wm8960.c @@ -15,6 +15,7 @@ #include <linux/init.h> #include <linux/delay.h> #include <linux/pm.h> +#include <linux/clk.h> #include <linux/i2c.h> #include <linux/slab.h> #include <sound/core.h> @@ -117,6 +118,7 @@ static bool wm8960_volatile(struct device *dev, unsigned int reg) } struct wm8960_priv { + struct clk *mclk; struct regmap *regmap; int (*set_bias_level)(struct snd_soc_codec *, enum snd_soc_bias_level level); @@ -618,14 +620,38 @@ static int wm8960_set_bias_level_out3(struct snd_soc_codec *codec, enum snd_soc_bias_level level) { struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec); + int ret; switch (level) { case SND_SOC_BIAS_ON: break; case SND_SOC_BIAS_PREPARE: - /* Set VMID to 2x50k */ - snd_soc_update_bits(codec, WM8960_POWER1, 0x180, 0x80); + switch (codec->dapm.bias_level) { + case SND_SOC_BIAS_STANDBY: + if (!IS_ERR(wm8960->mclk)) { + ret = clk_prepare_enable(wm8960->mclk); + if (ret) { + dev_err(codec->dev, + "Failed to enable MCLK: %d\n", + ret); + return ret; + } + } + + /* Set VMID to 2x50k */ + snd_soc_update_bits(codec, WM8960_POWER1, 0x180, 0x80); + break; + + case SND_SOC_BIAS_ON: + if (!IS_ERR(wm8960->mclk)) + clk_disable_unprepare(wm8960->mclk); + break; + + default: + break; + } + break; case SND_SOC_BIAS_STANDBY: @@ -674,7 +700,7 @@ static int wm8960_set_bias_level_capless(struct snd_soc_codec *codec, enum snd_soc_bias_level level) { struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec); - int reg; + int reg, ret; switch (level) { case SND_SOC_BIAS_ON: @@ -715,9 +741,22 @@ static int wm8960_set_bias_level_capless(struct snd_soc_codec *codec, WM8960_VREF, WM8960_VREF); msleep(100); + + if (!IS_ERR(wm8960->mclk)) { + ret = clk_prepare_enable(wm8960->mclk); + if (ret) { + dev_err(codec->dev, + "Failed to enable MCLK: %d\n", + ret); + return ret; + } + } break; case SND_SOC_BIAS_ON: + if (!IS_ERR(wm8960->mclk)) + clk_disable_unprepare(wm8960->mclk); + /* Enable anti-pop mode */ snd_soc_update_bits(codec, WM8960_APOP1, WM8960_POBCTRL | WM8960_SOFT_ST | @@ -1002,6 +1041,12 @@ static int wm8960_i2c_probe(struct i2c_client *i2c, if (wm8960 == NULL) return -ENOMEM; + wm8960->mclk = devm_clk_get(&i2c->dev, "mclk"); + if (IS_ERR(wm8960->mclk)) { + if (PTR_ERR(wm8960->mclk) == -EPROBE_DEFER) + return -EPROBE_DEFER; + } + wm8960->regmap = devm_regmap_init_i2c(i2c, &wm8960_regmap); if (IS_ERR(wm8960->regmap)) return PTR_ERR(wm8960->regmap); -- 1.9.1

5 10

[alsa-devel] [PATCH 0/3] Improve SKL+ position reporting for legacy HD-audio
by Takashi Iwai 03 Apr '17

03 Apr '17

Hi, this is a port of SKL-specific hacks to the legacy HD-audio driver for improving the PCM position reporting that has been applied to ASoC driver so far. Takashi === Takashi Iwai (3): ALSA: hda - Avoid tricky macros ALSA: hda - Move SKL+ vendor specific register definitions to hda_register.h ALSA: hda - Improved position reporting on SKL+ include/sound/hda_register.h | 22 ++++++++++++++++++++-- include/sound/hdaudio.h | 28 ++++++++++++++++++---------- sound/hda/hdac_controller.c | 2 +- sound/hda/hdac_stream.c | 4 ++-- sound/pci/hda/hda_intel.c | 40 ++++++++++++++++++++++++++++++++++++---- sound/soc/intel/skylake/skl.h | 21 --------------------- 6 files changed, 77 insertions(+), 40 deletions(-) -- 2.11.1

2 7

[alsa-devel] [PATCH] ASoC: fsl_ssi: Fix channel swap on playback start
by Fabio Estevam 01 Apr '17

01 Apr '17

From: Fabio Estevam <fabio.estevam(a)nxp.com> Commit f8fdf5375e2005f2 ("ASoC: fsl-ssi: add SSIEN errata work around") implemented the workaround for the following erratum found on i.MX35 errata document: ENGcm06222: SSI:Transmission does not take place in bit length early frame sync configuration and also for ENGcm06222 from the same document. However it has been only applied for AC97 mode. Apply it to I2S mode as well so that it can fix audio channel swap during playback start. The channel swap can be noticed in about 10% of the times an audio track starts. With the recommended workaround in place no more channel swap happened after running audio start/stop sequence in more than 2000 times. Tested on a mx6dl-wandboard. Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- sound/soc/fsl/fsl_ssi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index fde08660..17f92b8 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -93,6 +93,9 @@ CCSR_SSI_SIER_TLS_EN | CCSR_SSI_SIER_TFS_EN | \ CCSR_SSI_SIER_TUE0_EN | CCSR_SSI_SIER_TFRC_EN) +#define FSLSSI_SSIEN_WORKAROUND (CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE | \ + CCSR_SSI_SCR_RE) + enum fsl_ssi_type { FSL_SSI_MCP8610, FSL_SSI_MX21, @@ -559,7 +562,8 @@ static void fsl_ssi_config(struct fsl_ssi_private *ssi_private, bool enable, int i; int max_loop = 100; regmap_update_bits(regs, CCSR_SSI_SCR, - CCSR_SSI_SCR_SSIEN, CCSR_SSI_SCR_SSIEN); + FSLSSI_SSIEN_WORKAROUND, + FSLSSI_SSIEN_WORKAROUND); for (i = 0; i < max_loop; i++) { u32 sfcsr; regmap_read(regs, CCSR_SSI_SFCSR, &sfcsr); @@ -650,8 +654,7 @@ static void fsl_ssi_setup_ac97(struct fsl_ssi_private *ssi_private) * codec before a stream is started. */ regmap_update_bits(regs, CCSR_SSI_SCR, - CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE | CCSR_SSI_SCR_RE, - CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE | CCSR_SSI_SCR_RE); + FSLSSI_SSIEN_WORKAROUND, FSLSSI_SSIEN_WORKAROUND); regmap_write(regs, CCSR_SSI_SOR, CCSR_SSI_SOR_WAIT(3)); } -- 2.7.4

2 3