March 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Likely offline for a while
by Takashi Iwai 01 Mar '17

01 Mar '17

Hi, JFYI: I'm going to travel from tomorrow for 2.5 weeks. Since I'm not sure how good the net connection in Sri Lanka will be, I'll be less responsive for a while. After all, a vacation is the time to enjoy on a shiny beach and not to discuss about messy bugs, no? :) That is, I'll handle only super urgent issues, and postpone the rest. thanks, Takashi

1 0

Re: [alsa-devel] playback discontinuities on buffer boundaries
by Paul Stone 01 Mar '17

01 Mar '17

Correction: the discontinuity pattern seems to repeat itself every 3 buffers (24 ms). There are 128 stereo frames per buffer. -Paul Stone On Mar 01, 2017, at 10:57 AM, Paul Stone <metabagel(a)icloud.com> wrote: Hi all, Summary: playback discontinuities that occur when PCM is configured for 16 kHz go away when it's configured at 8 kHz, even though the output still runs at 16 kHz. I have written an ALSA driver for an embedded system. If I feed a synthetic sine wave to my output, it looks fine. However, when I use the following test, I see (with an oscilloscope) discontinuity in the sine wave on a buffer boundary (every 8 ms). Additionally, the pattern of the discontinuity repeats every 4 buffers (32 ms). Here is the test I am running: # gst-launch audiotestsrc ! 'audio/x-raw-int, channels=2, rate=16000, depth=16' ! alsasink device=plughw:3,0 The audio components of the system are a bit old: gst-launch-0.10 version 0.10.36 GStreamer 0.10.36 alsa-lib-1.0.27.2-r1.cortexa9hf_vfp_neon I have not added any configuration for this device in /etc/asound.conf. Audio buffers are interleaved 16-bit stereo, output to FPGA which is configured with sampling frequency of 16 kHz. Buffer size is 128 frames. * hardware definition */ static struct snd_pcm_hardware snd_imx_audio_playback_hw = { .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER ), .formats = SNDRV_PCM_FMTBIT_S16_LE, // Signed 16 bits .rates = SNDRV_PCM_RATE_16000, .rate_min = 16000, .rate_max = 16000, .channels_min = 2, // stereo .channels_max = 2, .buffer_bytes_max = MAX_BUFFER, // 10 buffers * BUFFER_SIZE .period_bytes_min = BUFFER_SIZE, // 128 frames per buffer * 2 stereo samples per frame * 2 bytes per sample (16-bit) .period_bytes_max = MAX_BUFFER, // 10 buffers * BUFFER_SIZE .periods_min = 1, .periods_max = BUFFERS_PER_PAIR, // 10 }; If I modify the test script to 8 kHz as follows: # gst-launch audiotestsrc ! 'audio/x-raw-int, channels=2, rate=8000, depth=16' ! alsasink device=plughw:3,0 and modify the PCM h/w definition to 8 kHz as follows: * hardware definition */ static struct snd_pcm_hardware snd_imx_audio_playback_hw = { . .rates = SNDRV_PCM_RATE_8000, .rate_min = 8000, .rate_max = 8000, . }; ... then the discontinuities go away. I get a pretty good sine wave output. Additionally, the output runs at 16 kHz, so it appears that even though ALSA has been told that the PCM runs at 8 kHz, it is keeping up with the true output rate of 16 kHz. I don't believe the problem is in the FPGA, because the output looks fine if I synthesize a sine wave inside the driver. I am trying to investigate buffer usage, but any suggestions on how to approach this would be most welcome. I'm guessing that maybe ALSA is overflowing on every buffer boundary (dropped audio data), but I don't see any warning messages to that effect, and if that's the case I don't know why that would be happening or how to address it. Best Regards, Paul Stone -Paul Stone

1 0

[alsa-devel] playback discontinuities on buffer boundaries
by Paul Stone 01 Mar '17

01 Mar '17

Hi all, Summary: playback discontinuities that occur when PCM is configured for 16 kHz go away when it's configured at 8 kHz, even though the output still runs at 16 kHz. I have written an ALSA driver for an embedded system. If I feed a synthetic sine wave to my output, it looks fine. However, when I use the following test, I see (with an oscilloscope) discontinuity in the sine wave on a buffer boundary (every 8 ms). Additionally, the pattern of the discontinuity repeats every 4 buffers (32 ms). Here is the test I am running: # gst-launch audiotestsrc ! 'audio/x-raw-int, channels=2, rate=16000, depth=16' ! alsasink device=plughw:3,0 The audio components of the system are a bit old: gst-launch-0.10 version 0.10.36 GStreamer 0.10.36 alsa-lib-1.0.27.2-r1.cortexa9hf_vfp_neon I have not added any configuration for this device in /etc/asound.conf. Audio buffers are interleaved 16-bit stereo, output to FPGA which is configured with sampling frequency of 16 kHz. Buffer size is 128 frames. * hardware definition */ static struct snd_pcm_hardware snd_imx_audio_playback_hw = { .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER ), .formats = SNDRV_PCM_FMTBIT_S16_LE, // Signed 16 bits .rates = SNDRV_PCM_RATE_16000, .rate_min = 16000, .rate_max = 16000, .channels_min = 2, // stereo .channels_max = 2, .buffer_bytes_max = MAX_BUFFER, // 10 buffers * BUFFER_SIZE .period_bytes_min = BUFFER_SIZE, // 128 frames per buffer * 2 stereo samples per frame * 2 bytes per sample (16-bit) .period_bytes_max = MAX_BUFFER, // 10 buffers * BUFFER_SIZE .periods_min = 1, .periods_max = BUFFERS_PER_PAIR, // 10 }; If I modify the test script to 8 kHz as follows: # gst-launch audiotestsrc ! 'audio/x-raw-int, channels=2, rate=8000, depth=16' ! alsasink device=plughw:3,0 and modify the PCM h/w definition to 8 kHz as follows: * hardware definition */ static struct snd_pcm_hardware snd_imx_audio_playback_hw = { . .rates = SNDRV_PCM_RATE_8000, .rate_min = 8000, .rate_max = 8000, . }; ... then the discontinuities go away. I get a pretty good sine wave output. Additionally, the output runs at 16 kHz, so it appears that even though ALSA has been told that the PCM runs at 8 kHz, it is keeping up with the true output rate of 16 kHz. I don't believe the problem is in the FPGA, because the output looks fine if I synthesize a sine wave inside the driver. I am trying to investigate buffer usage, but any suggestions on how to approach this would be most welcome. I'm guessing that maybe ALSA is overflowing on every buffer boundary (dropped audio data), but I don't see any warning messages to that effect, and if that's the case I don't know why that would be happening or how to address it. Best Regards, Paul Stone -Paul Stone

1 0

[alsa-devel] usb headset with mic Jabra GN2400 (0b0e:2400) regression bug on linux 4.4.0-21-generic
by Fabrizio Lombardozzi 01 Mar '17

01 Mar '17

Hi, I've found that the headset gn2400 is not working properly any more on latest kernels, while it was working fine up to 3.8.0-19 (Ubuntu 13.04). The headset is steadily playing squeaky sound (probably a kind of rate mismatch) with any application that try to set a playback sample rate below 32Khz, e.g.: mplayer -srate 8000 song.mp3 Instead it can records properly at any rate: arecord -f S16_LE -r 8000 -D hw:1,0 -d 5 t.wav (but then you can't hear it) After "a few" modules recompilations I found an acceptable solution: --- ../../../linux-4.4_originale/linux-4.4/sound/usb/quirks.c 2017-02-24 17:22:57.021006325 +0100 +++ quirks.c 2017-03-01 18:36:51.877837419 +0100 @@ -1113,6 +1113,18 @@ set_format_emu_quirk(subs, fmt); break; } + + if (subs->stream->chip->usb_id == USB_ID(0x0b0e, 0x2400)) /* Jabra BIZ-2400 */ + { + if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK) + { + int flr,rate=48000; + printk(KERN_ALERT "snd_usb_set_format_quirk() Jabra BIZ-2400 PLAYBACK forced rate:%d\n",rate); + for (flr=0;flr<fmt->nr_rates;flr++) fmt->rate_table[fmt->nr_rates] = rate; + fmt->rate_min=rate; + fmt->rate_max=rate; + } + } } bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip) I hope it can be useful for others. Here are some other info root@fab-desktop:~/linux-4.4/sound/usb# lsusb -vvv -d 0b0e:2400 Bus 005 Device 059: ID 0b0e:2400 GN Netcom Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 0 (Defined at Interface level) bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 idVendor 0x0b0e GN Netcom idProduct 0x2400 bcdDevice 1.41 iManufacturer 0 iProduct 2 Jabra BIZ 2400 Mono USB iSerial 3 1C48F9103BE5x014100 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 256 bNumInterfaces 4 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xc0 Self Powered MaxPower 100mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 1 Control Device bInterfaceProtocol 0 iInterface 0 AudioControl Interface Descriptor: bLength 10 bDescriptorType 36 bDescriptorSubtype 1 (HEADER) bcdADC 1.00 wTotalLength 103 bInCollection 2 baInterfaceNr( 0) 1 baInterfaceNr( 1) 2 AudioControl Interface Descriptor: bLength 12 bDescriptorType 36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 1 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bNrChannels 1 wChannelConfig 0x0000 iChannelNames 0 iTerminal 0 AudioControl Interface Descriptor: bLength 8 bDescriptorType 36 bDescriptorSubtype 6 (FEATURE_UNIT) bUnitID 2 bSourceID 10 bControlSize 1 bmaControls( 0) 0x03 Mute Control Volume Control iFeature 0 AudioControl Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 3 wTerminalType 0x0301 Speaker bAssocTerminal 0 bSourceID 2 iTerminal 0 AudioControl Interface Descriptor: bLength 12 bDescriptorType 36 bDescriptorSubtype 2 (INPUT_TERMINAL) bTerminalID 4 wTerminalType 0x0201 Microphone bAssocTerminal 0 bNrChannels 1 wChannelConfig 0x0000 iChannelNames 0 iTerminal 0 AudioControl Interface Descriptor: bLength 8 bDescriptorType 36 bDescriptorSubtype 6 (FEATURE_UNIT) bUnitID 5 bSourceID 4 bControlSize 1 bmaControls( 0) 0x03 Mute Control Volume Control iFeature 0 AudioControl Interface Descriptor: bLength 7 bDescriptorType 36 bDescriptorSubtype 5 (SELECTOR_UNIT) bUnitID 7 bNrInPins 1 baSource( 0) 5 iSelector 0 AudioControl Interface Descriptor: bLength 9 bDescriptorType 36 bDescriptorSubtype 3 (OUTPUT_TERMINAL) bTerminalID 6 wTerminalType 0x0101 USB Streaming bAssocTerminal 0 bSourceID 7 iTerminal 0 AudioControl Interface Descriptor: bLength 8 bDescriptorType 36 bDescriptorSubtype 6 (FEATURE_UNIT) bUnitID 8 bSourceID 4 bControlSize 1 bmaControls( 0) 0x03 Mute Control Volume Control iFeature 0 AudioControl Interface Descriptor: bLength 7 bDescriptorType 36 bDescriptorSubtype 5 (SELECTOR_UNIT) bUnitID 9 bNrInPins 1 baSource( 0) 8 iSelector 0 AudioControl Interface Descriptor: bLength 13 bDescriptorType 36 bDescriptorSubtype 4 (MIXER_UNIT) bUnitID 10 bNrInPins 2 baSourceID( 0) 1 baSourceID( 1) 9 bNrChannels 1 wChannelConfig 0x0000 iChannelNames 0 bmControls 0x00 iMixer 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 0 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 0 iInterface 0 AudioStreaming Interface Descriptor: bLength 7 bDescriptorType 36 bDescriptorSubtype 1 (AS_GENERAL) bTerminalLink 1 bDelay 0 frames wFormatTag 1 PCM AudioStreaming Interface Descriptor: bLength 17 bDescriptorType 36 bDescriptorSubtype 2 (FORMAT_TYPE) bFormatType 1 (FORMAT_TYPE_I) bNrChannels 1 bSubframeSize 2 bBitResolution 16 bSamFreqType 3 Discrete tSamFreq[ 0] 8000 tSamFreq[ 1] 16000 tSamFreq[ 2] 48000 AudioControl Endpoint Descriptor: bLength 7 bDescriptorType 37 bDescriptorSubtype 1 (EP_GENERAL) bmAttributes 0x81 Sampling Frequency MaxPacketsOnly bLockDelayUnits 2 Decoded PCM samples wLockDelay 0 Decoded PCM samples Endpoint Descriptor: bLength 9 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 1 Transfer Type Isochronous Synch Type None Usage Type Data wMaxPacketSize 0x0060 1x 96 bytes bInterval 1 bRefresh 0 bSynchAddress 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 0 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 1 Audio bInterfaceSubClass 2 Streaming bInterfaceProtocol 0 iInterface 0 AudioStreaming Interface Descriptor: bLength 7 bDescriptorType 36 bDescriptorSubtype 1 (AS_GENERAL) bTerminalLink 6 bDelay 0 frames wFormatTag 1 PCM AudioStreaming Interface Descriptor: bLength 11 bDescriptorType 36 bDescriptorSubtype 2 (FORMAT_TYPE) bFormatType 1 (FORMAT_TYPE_I) bNrChannels 1 bSubframeSize 2 bBitResolution 16 bSamFreqType 1 Discrete tSamFreq[ 0] 16000 AudioControl Endpoint Descriptor: bLength 7 bDescriptorType 37 bDescriptorSubtype 1 (EP_GENERAL) bmAttributes 0x00 bLockDelayUnits 2 Decoded PCM samples wLockDelay 0 Decoded PCM samples Endpoint Descriptor: bLength 9 bDescriptorType 5 bEndpointAddress 0x83 EP 3 IN bmAttributes 1 Transfer Type Isochronous Synch Type None Usage Type Data wMaxPacketSize 0x0020 1x 32 bytes bInterval 1 bRefresh 0 bSynchAddress 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 3 bAlternateSetting 0 bNumEndpoints 1 bInterfaceClass 3 Human Interface Device bInterfaceSubClass 0 No Subclass bInterfaceProtocol 0 None iInterface 0 HID Device Descriptor: bLength 9 bDescriptorType 33 bcdHID 1.11 bCountryCode 0 Not supported bNumDescriptors 1 bDescriptorType 34 Report wDescriptorLength 339 Report Descriptors: ** UNAVAILABLE ** Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0010 1x 16 bytes bInterval 1 Device Status: 0x0001 Self Powered -- Saluti Fabrizio Ing.Fabrizio Lombardozzi Coord. Servizi Ippofono Capodarco Via Ostiense, 131L asc.B 00154 ROMA Tel. +39 0657 060 230 Cell. +39 335 585 3047 Email: fabrizio.lombardozzi(a)sociale.it Ai sensi e per effetti della legge sulla tutela della riservatezza personale (D.lgs n.196/2003), questa @mail e' destinata unicamente alle persone sopra indicate e le informazioni in essa contenute sono da considerarsi strettamente riservate. E' proibito leggere, copiare, usare o diffondere il contenuto della presente @mail senza autorizzazione. Se avete ricevuto questo messaggio per errore, siete pregati di rispedire la stessa al mittente. Grazie -- "Ai sensi e per gli effetti della legge sulla tutela dei dati personali (D.lgs 196/2003), le informazioni contenute nella presente @mail sono di natura riservata e destinate ad un uso aziendale-lavorativo con esclusione di utilizzi ad uso personale; come tali, pertanto, sono riservate esclusivamente ai destinatari sopra indicati. E' proibito leggere, copiare, usare o diffondere il contenuto della presente @mail senza autorizzazione. Se avete ricevuto questa @mail per errore, siete pregati di rispedire la stessa al mittente. Grazie"

1 0

[alsa-devel] [PATCH 1/9] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock
by Icenowy Zheng 01 Mar '17

01 Mar '17

Lichee Pi Zero features a dock, which adds some functions, and should be soldered with the core board of Lichee Pi Zero. Add support for the dock as a new dts, as soldering is needed to make the dock usable and there's functions enabled on the dock that is unavailable at the 2.54mm pins of the core board. Currently no new feature on core board is available in the mainline kernel, so the dock dt file only includes the core board device tree. Signed-off-by: Icenowy Zheng <icenowy(a)aosc.xyz> --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 49 ++++++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 011808490fed..1aa365306479 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -876,7 +876,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \ sun8i-h3-orangepi-plus.dtb \ sun8i-h3-orangepi-plus2e.dtb \ sun8i-r16-parrot.dtb \ - sun8i-v3s-licheepi-zero.dtb + sun8i-v3s-licheepi-zero.dtb \ + sun8i-v3s-licheepi-zero-dock.dtb dtb-$(CONFIG_MACH_SUN9I) += \ sun9i-a80-optimus.dtb \ sun9i-a80-cubieboard4.dtb diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts new file mode 100644 index 000000000000..68c114d6b939 --- /dev/null +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts @@ -0,0 +1,49 @@ +/* + * Copyright (C) 2016 Icenowy Zheng <icenowy(a)aosc.xyz> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +#include "sun8i-v3s-licheepi-zero.dts" + +/ { + model = "Lichee Pi Zero with Dock"; + compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero", + "allwinner,sun8i-v3s"; +}; -- 2.11.1

4 18

[alsa-devel] [PATCH RESEND 0/4] ASoC: es8328: various improvements
by Romain Perier 01 Mar '17

01 Mar '17

This set of patches fixes clock handling in slave mode, enables sampling frequency of 192khz in slave mode and adds support for this frame rate in the driver rk3288_hdmi_analog.c. Note: Due to an email configuration issue, some of my patches were not received on infradead.org or vger.kernel.org. It is now fixed, so I resend this set of patches for this reason. Romain Perier (4): ASoC: es8328: Simplify rates definition ASoC: es8328: Let device auto detect ratios in slave mode ASoC: es8328: Enabling support for 192k ASoC: rockchip: Enable 192khz in hw_params operation sound/soc/codecs/es8328.c | 51 +++++++++++++++++++-------------- sound/soc/rockchip/rk3288_hdmi_analog.c | 3 ++ 2 files changed, 32 insertions(+), 22 deletions(-) -- 2.9.3

1 4

[alsa-devel] [sound:topic/cht-whiskey-cove 1/3] include/acpi/acpi_bus.h:598:9: error: 'AE_SUPPORT' undeclared
by kbuild test robot 01 Mar '17

01 Mar '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/cht-whiskey-cove head: fe0334695c856dbdbeea861a5eb76f5ddc0dbaa9 commit: fbba8603f93e60c68116197326cdbbceee0b875b [1/3] mfd: Add Cherrytrail WhiskeyCove PMIC driver config: x86_64-randconfig-r0-03011404 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout fbba8603f93e60c68116197326cdbbceee0b875b # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): acpi_status acpi_evaluate_ej0(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:59:1: error: unknown type name 'acpi_status' acpi_status acpi_evaluate_lck(acpi_handle handle, int lock); ^~~~~~~~~~~ include/acpi/acpi_bus.h:59:31: error: unknown type name 'acpi_handle' acpi_status acpi_evaluate_lck(acpi_handle handle, int lock); ^~~~~~~~~~~ include/acpi/acpi_bus.h:60:21: error: unknown type name 'acpi_handle' bool acpi_ata_match(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:61:21: error: unknown type name 'acpi_handle' bool acpi_bay_match(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:62:22: error: unknown type name 'acpi_handle' bool acpi_dock_match(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:64:21: error: unknown type name 'acpi_handle' bool acpi_check_dsm(acpi_handle handle, const u8 *uuid, u64 rev, u64 funcs); ^~~~~~~~~~~ include/acpi/acpi_bus.h:65:38: error: unknown type name 'acpi_handle' union acpi_object *acpi_evaluate_dsm(acpi_handle handle, const u8 *uuid, ^~~~~~~~~~~ include/acpi/acpi_bus.h:69:25: error: unknown type name 'acpi_handle' acpi_evaluate_dsm_typed(acpi_handle handle, const u8 *uuid, u64 rev, u64 func, ^~~~~~~~~~~ include/acpi/acpi_bus.h:70:30: error: unknown type name 'acpi_object_type' union acpi_object *argv4, acpi_object_type type) ^~~~~~~~~~~~~~~~ In file included from drivers/mfd/intel_soc_pmic_chtwc.c:18:0: include/acpi/acpi_bus.h:286:40: error: 'ACPI_D_STATE_COUNT' undeclared here (not in a function) struct acpi_device_power_state states[ACPI_D_STATE_COUNT]; /* Power states (D0-D3Cold) */ ^~~~~~~~~~~~~~~~~~ include/acpi/acpi_bus.h:326:2: error: unknown type name 'acpi_handle' acpi_handle gpe_device; ^~~~~~~~~~~ include/acpi/acpi_bus.h:356:2: error: unknown type name 'acpi_handle' acpi_handle handle; /* no handle for fixed hardware */ ^~~~~~~~~~~ include/acpi/acpi_bus.h:387:2: error: unknown type name 'acpi_handle' acpi_handle handle; ^~~~~~~~~~~ include/acpi/acpi_bus.h:478:49: error: expected ')' before 'void' void acpi_bus_private_data_handler(acpi_handle, void *); ^~~~ include/acpi/acpi_bus.h:479:44: error: expected ')' before 'void' int acpi_bus_get_private_data(acpi_handle, void **); ^~~~ include/acpi/acpi_bus.h:480:47: error: expected ')' before 'void' int acpi_bus_attach_private_data(acpi_handle, void *); ^~~~ include/acpi/acpi_bus.h:481:1: warning: parameter names (without types) in function declaration void acpi_bus_detach_private_data(acpi_handle); ^~~~ include/acpi/acpi_bus.h:490:25: error: unknown type name 'acpi_handle' int acpi_bus_get_device(acpi_handle handle, struct acpi_device **device); ^~~~~~~~~~~ include/acpi/acpi_bus.h:491:46: error: unknown type name 'acpi_handle' struct acpi_device *acpi_bus_get_acpi_device(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:493:1: error: unknown type name 'acpi_status' acpi_status acpi_bus_get_status_handle(acpi_handle handle, ^~~~~~~~~~~ include/acpi/acpi_bus.h:493:40: error: unknown type name 'acpi_handle' acpi_status acpi_bus_get_status_handle(acpi_handle handle, ^~~~~~~~~~~ include/acpi/acpi_bus.h:497:24: error: unknown type name 'acpi_handle' int acpi_bus_set_power(acpi_handle handle, int state); ^~~~~~~~~~~ include/acpi/acpi_bus.h:503:27: error: unknown type name 'acpi_handle' int acpi_bus_update_power(acpi_handle handle, int *state_p); ^~~~~~~~~~~ include/acpi/acpi_bus.h:505:32: error: unknown type name 'acpi_handle' bool acpi_bus_power_manageable(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:510:40: error: unknown type name 'acpi_handle' static inline bool acpi_bus_can_wakeup(acpi_handle handle) { return false; } ^~~~~~~~~~~ include/acpi/acpi_bus.h:520:19: error: unknown type name 'acpi_handle' int acpi_bus_scan(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:522:1: error: unknown type name 'acpi_status' acpi_status acpi_bus_get_ejd(acpi_handle handle, acpi_handle * ejd); ^~~~~~~~~~~ include/acpi/acpi_bus.h:522:30: error: unknown type name 'acpi_handle' acpi_status acpi_bus_get_ejd(acpi_handle handle, acpi_handle * ejd); ^~~~~~~~~~~ include/acpi/acpi_bus.h:522:50: error: unknown type name 'acpi_handle' acpi_status acpi_bus_get_ejd(acpi_handle handle, acpi_handle * ejd); ^~~~~~~~~~~ include/acpi/acpi_bus.h:581:1: warning: parameter names (without types) in function declaration int acpi_is_root_bridge(acpi_handle); ^~~ include/acpi/acpi_bus.h:582:42: error: unknown type name 'acpi_handle' struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle); ^~~~~~~~~~~ include/acpi/acpi_bus.h:594:15: error: unknown type name 'acpi_status' static inline acpi_status acpi_add_pm_notifier(struct acpi_device *adev, ^~~~~~~~~~~ include/acpi/acpi_bus.h: In function 'acpi_add_pm_notifier': >> include/acpi/acpi_bus.h:598:9: error: 'AE_SUPPORT' undeclared (first use in this function) return AE_SUPPORT; ^~~~~~~~~~ include/acpi/acpi_bus.h:598:9: note: each undeclared identifier is reported only once for each function it appears in include/acpi/acpi_bus.h: At top level: include/acpi/acpi_bus.h:600:15: error: unknown type name 'acpi_status' static inline acpi_status acpi_remove_pm_notifier(struct acpi_device *adev) ^~~~~~~~~~~ include/acpi/acpi_bus.h: In function 'acpi_remove_pm_notifier': include/acpi/acpi_bus.h:602:9: error: 'AE_SUPPORT' undeclared (first use in this function) return AE_SUPPORT; ^~~~~~~~~~ include/acpi/acpi_bus.h: In function 'acpi_pm_device_sleep_state': >> include/acpi/acpi_bus.h:607:8: error: 'ACPI_STATE_D0' undeclared (first use in this function) *p = ACPI_STATE_D0; ^~~~~~~~~~~~~ include/acpi/acpi_bus.h:609:37: error: 'ACPI_STATE_D3_COLD' undeclared (first use in this function) return (m >= ACPI_STATE_D0 && m <= ACPI_STATE_D3_COLD) ? ^~~~~~~~~~~~~~~~~~ include/acpi/acpi_bus.h: In function 'acpi_target_system_state': include/acpi/acpi_bus.h:630:59: error: 'ACPI_STATE_S0' undeclared (first use in this function) static inline u32 acpi_target_system_state(void) { return ACPI_STATE_S0; } ^~~~~~~~~~~~~ include/acpi/acpi_bus.h: In function 'acpi_device_can_poweroff': include/acpi/acpi_bus.h:645:28: error: 'ACPI_STATE_D3_COLD' undeclared (first use in this function) return adev->power.states[ACPI_STATE_D3_COLD].flags.valid || ^~~~~~~~~~~~~~~~~~ include/acpi/acpi_bus.h:646:5: error: 'acpi_gbl_FADT' undeclared (first use in this function) ((acpi_gbl_FADT.header.revision < 6) && ^~~~~~~~~~~~~ include/acpi/acpi_bus.h:647:22: error: 'ACPI_STATE_D3_HOT' undeclared (first use in this function) adev->power.states[ACPI_STATE_D3_HOT].flags.explicit_set); ^~~~~~~~~~~~~~~~~ In file included from drivers/mfd/intel_soc_pmic_chtwc.c:19:0: include/linux/acpi.h: In function 'acpi_device_handle': include/linux/acpi.h:51:29: warning: pointer/integer type mismatch in conditional expression return adev ? adev->handle : NULL; ^ drivers/mfd/intel_soc_pmic_chtwc.c: In function 'cht_wc_probe': drivers/mfd/intel_soc_pmic_chtwc.c:104:11: error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration] status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv); ^~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/AE_SUPPORT +598 include/acpi/acpi_bus.h d760a1baf2 Lorenzo Pieralisi 2016-11-21 576 void acpi_dma_configure(struct device *dev, enum dev_dma_attr attr); d760a1baf2 Lorenzo Pieralisi 2016-11-21 577 void acpi_dma_deconfigure(struct device *dev); b84f196d96 Suthikulpanit, Suravee 2015-10-28 578 d9fef0c4d2 Rafael J. Wysocki 2013-11-28 579 struct acpi_device *acpi_find_child_device(struct acpi_device *parent, d9fef0c4d2 Rafael J. Wysocki 2013-11-28 580 u64 address, bool check_children); 275582031f Alexander Chiang 2009-06-10 581 int acpi_is_root_bridge(acpi_handle); 76d56de57a Alex Chiang 2009-07-23 @582 struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle); 4e10d12a3d David Shaohua Li 2005-03-18 583 b67ea76172 Rafael J. Wysocki 2010-02-17 584 int acpi_enable_wakeup_device_power(struct acpi_device *dev, int state); b67ea76172 Rafael J. Wysocki 2010-02-17 585 int acpi_disable_wakeup_device_power(struct acpi_device *dev); b67ea76172 Rafael J. Wysocki 2010-02-17 586 aa33860158 Rafael J. Wysocki 2011-02-11 587 #ifdef CONFIG_PM c072530f39 Rafael J. Wysocki 2014-07-23 588 acpi_status acpi_add_pm_notifier(struct acpi_device *adev, struct device *dev, c072530f39 Rafael J. Wysocki 2014-07-23 589 void (*work_func)(struct work_struct *work)); c072530f39 Rafael J. Wysocki 2014-07-23 590 acpi_status acpi_remove_pm_notifier(struct acpi_device *adev); ee85f54371 Huang Ying 2012-06-23 591 int acpi_pm_device_sleep_state(struct device *, int *, int); 5de21bb998 Rafael J. Wysocki 2014-11-27 592 int acpi_pm_device_run_wake(struct device *, bool); 761afb869f Rafael J. Wysocki 2010-10-14 593 #else ec2cd81ccf Rafael J. Wysocki 2012-11-02 594 static inline acpi_status acpi_add_pm_notifier(struct acpi_device *adev, c072530f39 Rafael J. Wysocki 2014-07-23 595 struct device *dev, c072530f39 Rafael J. Wysocki 2014-07-23 596 void (*work_func)(struct work_struct *work)) ec2cd81ccf Rafael J. Wysocki 2012-11-02 597 { ec2cd81ccf Rafael J. Wysocki 2012-11-02 @598 return AE_SUPPORT; ec2cd81ccf Rafael J. Wysocki 2012-11-02 599 } c072530f39 Rafael J. Wysocki 2014-07-23 @600 static inline acpi_status acpi_remove_pm_notifier(struct acpi_device *adev) ec2cd81ccf Rafael J. Wysocki 2012-11-02 601 { ec2cd81ccf Rafael J. Wysocki 2012-11-02 602 return AE_SUPPORT; ec2cd81ccf Rafael J. Wysocki 2012-11-02 603 } b25c77efa7 Rafael J. Wysocki 2013-06-16 604 static inline int acpi_pm_device_sleep_state(struct device *d, int *p, int m) 296699de6b Rafael J. Wysocki 2007-07-29 605 { 296699de6b Rafael J. Wysocki 2007-07-29 606 if (p) 296699de6b Rafael J. Wysocki 2007-07-29 @607 *p = ACPI_STATE_D0; b25c77efa7 Rafael J. Wysocki 2013-06-16 608 8ad928d52e Rafael J. Wysocki 2013-07-30 609 return (m >= ACPI_STATE_D0 && m <= ACPI_STATE_D3_COLD) ? 8ad928d52e Rafael J. Wysocki 2013-07-30 610 m : ACPI_STATE_D0; :::::: The code at line 598 was first introduced by commit :::::: ec2cd81ccfc055155ef4ca673f207168f516d287 ACPI / PM: Move routines for adding/removing device wakeup notifiers :::::: TO: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> :::::: CC: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0