December 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] ES8316
by Nerijus Baliunas 13 Dec '17

13 Dec '17

Hello, Onda obook 20 plus tablet, Fedora 27, kernel 4.13.16-302.fc27.x86_64: [ 8.910172] bytcht_es8316 bytcht_es8316: ASoC: CODEC DAI ES8316 HiFi not registered [ 8.910306] bytcht_es8316 bytcht_es8316: snd_soc_register_card failed -517 kernel 4.14.3-300.fc27.x86_64: [ 8.561159] rt5645 i2c-10EC5645:00: Device with ID register 0xffff8d85 is not rt5645 or rt5650 [ 9.344562] cht-bsw-rt5645 cht-bsw-rt5645: ASoC: CODEC DAI rt5645-aif1 not registered [ 9.344695] cht-bsw-rt5645 cht-bsw-rt5645: snd_soc_register_card failed -517 On both kernels snd_soc_sst_byt_cht_es8316 and snd_soc_es8316 modules are loaded automatically. How to make audio work? dmesg from Android 5.1 kernel 3.14.37-x86_64: <3>[ 3.900404] snd_intel_sst: sst_platform_get_resources_edk <3>[ 3.900442] snd_intel_sst: LPE base: 0xd1600000 size:0x200000 <3>[ 3.900452] snd_intel_sst: IRAM base: 0xd16c0000 <3>[ 3.900461] snd_intel_sst: DRAM base: 0xd1700000 <3>[ 3.900535] snd_intel_sst: SHIM base: 0xd1740000 <3>[ 3.900547] snd_intel_sst: Mailbox base: 0xd1744000 <3>[ 3.900720] snd_intel_sst: DDR base: 0x20000000 <6>[ 3.900720] snd_intel_sst: Enter: sst_audio_platform_init <6>[ 3.900723] snd_intel_sst: audio:set_cht_platform_config <6>[ 3.900958] snd_soc_sst_platform: sst_platform_probe is deferred <3>[ 3.900977] snd_intel_sst: board_name:Cherry Trail CR <6>[ 3.900979] snd_intel_sst: Registering machine device cht_es8316 <3>[ 3.901147] snd_intel_sst: Requesting FW fw_sst_22a8.bin now... <6>[ 3.986899] snd_soc_sst_platform: sst_platform_probe is deferred <6>[ 4.260819] snd_soc_sst_platform: sst_platform_probe is deferred <6>[ 4.262978] snd_soc_sst_platform: sst_platform_probe is deferred <6>[ 4.696961] snd_soc_sst_platform: sst_platform_probe is deferred <6>[ 7.361346] snd_soc_sst_platform: sst_platform_probe is deferred <6>[ 7.373893] snd_soc_sst_platform: sst_platform_probe is deferred <3>[ 7.374140] cht_es8316 cht_es8316: ASoC: CPU DAI Headset-cpu-dai not registered <3>[ 7.382393] snd_soc_register_card failed -517 <6>[ 7.387358] platform cht_es8316: Driver cht_es8316 requests probe deferral <6>[ 7.387542] Cherrytrail Machine Driver cht_es8316 registerd <7>[ 10.604513] ---es8316_probe--start-- <4>[ 10.695451] snd-soc-dummy snd-soc-dummy: ASoC: Failed to create platform debugfs directory <3>[ 10.706037] chuangang:********************************* codec->name = es8316.1-0011 <6>[ 10.739210] cht_es8316 cht_es8316: snd-soc-dummy-dai <-> Headset-cpu-dai mapping ok <6>[ 10.739332] cht_es8316 cht_es8316: snd-soc-dummy-dai <-> Deepbuffer-cpu-dai mapping ok <6>[ 10.739410] compress asoc: snd-soc-dummy-dai <-> Compress-cpu-dai mapping ok <6>[ 10.739530] cht_es8316 cht_es8316: snd-soc-dummy-dai <-> Voip-cpu-dai mapping ok <6>[ 10.739656] cht_es8316 cht_es8316: snd-soc-dummy-dai <-> Lowlatency-cpu-dai mapping ok <6>[ 10.740017] cht_es8316 cht_es8316: snd-soc-dummy-dai <-> Probe-cpu-dai mapping ok <6>[ 10.740253] cht_es8316 cht_es8316: ES8316 HiFi <-> ssp2-port mapping ok <6>[ 10.740321] cht_es8316 cht_es8316: snd-soc-dummy-dai <-> snd-soc-dummy-dai mapping ok <6>[ 10.740388] cht_es8316 cht_es8316: snd-soc-dummy-dai <-> snd-soc-dummy-dai mapping ok <3>[ 10.740503] cht_es8316 cht_es8316: ASoC: Failed to add Headphone Switch: -16 <7>[ 10.748616] es8316_set_dai_fmt----649, fmt[4305] <7>[ 10.750744] es8316 in slave mode <7>[ 10.763965] es8316 1-0011: es8316_set_bias_level standby <6>[ 10.792289] input: cherrytrailaud Headset Jack as /devices/platform/cht_es8316/sound/card1/input10 <6>[ 10.795340] snd_cht_mc_probe successful <6>[ 11.568221] ES8316_GPIO_FLAG:26 Regards, Nerijus

2 2

[alsa-devel] [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header and switch to SPDX
by Andrew F. Davis 13 Dec '17

13 Dec '17

The filename is often wrong after moves and adds nothing of value, lets drop it. While already here, switch to SPDX. Signed-off-by: Andrew F. Davis <afd(a)ti.com> --- sound/soc/codecs/tlv320aic32x4-i2c.c | 13 +------------ sound/soc/codecs/tlv320aic32x4-spi.c | 13 +------------ sound/soc/codecs/tlv320aic32x4.c | 18 +----------------- sound/soc/codecs/tlv320aic32x4.h | 9 +-------- 4 files changed, 4 insertions(+), 49 deletions(-) diff --git a/sound/soc/codecs/tlv320aic32x4-i2c.c b/sound/soc/codecs/tlv320aic32x4-i2c.c index 385fa2e9525a..106da31e9541 100644 --- a/sound/soc/codecs/tlv320aic32x4-i2c.c +++ b/sound/soc/codecs/tlv320aic32x4-i2c.c @@ -1,21 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0 /* - * linux/sound/soc/codecs/tlv320aic32x4-i2c.c - * * Copyright 2011 NW Digital Radio * * Author: Jeremy McDermond <nh6z(a)nh6z.net> * * Based on sound/soc/codecs/wm8974 and TI driver for kernel 2.6.27. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. */ #include <linux/i2c.h> diff --git a/sound/soc/codecs/tlv320aic32x4-spi.c b/sound/soc/codecs/tlv320aic32x4-spi.c index 07d78ae51e05..c4619f65d427 100644 --- a/sound/soc/codecs/tlv320aic32x4-spi.c +++ b/sound/soc/codecs/tlv320aic32x4-spi.c @@ -1,21 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0 /* - * linux/sound/soc/codecs/tlv320aic32x4-spi.c - * * Copyright 2011 NW Digital Radio * * Author: Jeremy McDermond <nh6z(a)nh6z.net> * * Based on sound/soc/codecs/wm8974 and TI driver for kernel 2.6.27. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. */ #include <linux/spi/spi.h> diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index e694f5f04eb9..c0ccf3f23a04 100644 --- a/sound/soc/codecs/tlv320aic32x4.c +++ b/sound/soc/codecs/tlv320aic32x4.c @@ -1,26 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0 /* - * linux/sound/soc/codecs/tlv320aic32x4.c - * * Copyright 2011 Vista Silicon S.L. * * Author: Javier Martin <javier.martin(a)vista-silicon.com> * * Based on sound/soc/codecs/wm8974 and TI driver for kernel 2.6.27. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include <linux/module.h> diff --git a/sound/soc/codecs/tlv320aic32x4.h b/sound/soc/codecs/tlv320aic32x4.h index da7cec482bcb..86552343b752 100644 --- a/sound/soc/codecs/tlv320aic32x4.h +++ b/sound/soc/codecs/tlv320aic32x4.h @@ -1,11 +1,4 @@ -/* - * tlv320aic32x4.h - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ - +// SPDX-License-Identifier: GPL-2.0 #ifndef _TLV320AIC32X4_H #define _TLV320AIC32X4_H -- 2.15.0

3 27

[alsa-devel] [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]
by Biju Das 13 Dec '17

13 Dec '17

Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME] (r8a774[35]) sound modules are identical to the R-Car Gen2 family. No driver change is needed as the fallback compatible string "renesas,rcar_sound-gen2" activates the right code in the driver. Signed-off-by: Biju Das <biju.das(a)bp.renesas.com> Reviewed-by: Fabrizio Castro <fabrizio.castro(a)bp.renesas.com> --- Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt index 085bec3..b3c28bd 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt @@ -4,7 +4,7 @@ Renesas R-Car sound * Modules ============================================= -Renesas R-Car sound is constructed from below modules +Renesas R-Car and RZ/G sound is constructed from below modules (for Gen2 or later) SCU : Sampling Rate Converter Unit @@ -334,9 +334,11 @@ Required properties: - compatible : "renesas,rcar_sound-<soctype>", fallbacks "renesas,rcar_sound-gen1" if generation1, and - "renesas,rcar_sound-gen2" if generation2 + "renesas,rcar_sound-gen2" if generation2 (or RZ/G1) "renesas,rcar_sound-gen3" if generation3 Examples with soctypes are: + - "renesas,rcar_sound-r8a7743" (RZ/G1M) + - "renesas,rcar_sound-r8a7745" (RZ/G1E) - "renesas,rcar_sound-r8a7778" (R-Car M1A) - "renesas,rcar_sound-r8a7779" (R-Car H1) - "renesas,rcar_sound-r8a7790" (R-Car H2) -- 1.9.1

3 8

[alsa-devel] [RFC v2 00/11] Enable HDA Codec support on Intel Platforms (Series2)
by Rakesh Ughreja 13 Dec '17

13 Dec '17

Many Intel platforms (SKL, KBL) etc. in the market supports enhanced audio capabilities which also includes DSP processing. This patch carry forwards the works that is done in the previous series to enable HD Audio codecs on such platforms. This patch series adds ASoC HDA codec driver for Intel platforms. It is written by reusing the legacy HDA ALSA codec driver. Intention is to maximize the reuse and minimize the changes in the legacy HDA codec driver. I would like to receive feedback before proceeding further on this direction. INFO: - This series is tested on KBL based product (Dell XPS 13). - Basic playback is working with headset and speakers. - HDMI playback is working. - Capture operation is not tested. - More platforms and use cases coverage can be added once we have basic agreement in terms of the overall approach. Changes in v2: - Using Topology framework to create DAIs and DAI Links - Moved most commonly used functions into a separate file for machine driver - Implemented separate Realtek ASoC HDA Driver driver for Realtek HDA codecs. It is just a driver registration wrapper which reuses the legacy HDA codec driver. This allows the removes the limitation that was present in v1. - Implemented the review feedback. Rakesh Ughreja (11): ASoC: Intel: Boards: Machine driver for Intel platforms ASoC: Intel: Skylake: Add entry in sst_acpi_mach for HDA codecs ASoC: Intel: Skylake: add HDA BE DAIs ASoC: Intel: Skylake: use hda_bus instead of hdac_bus ALSA: hda - make some of the functions externally visible ASoC: hdac_hda: add ASoC based HDA codec driver ALSA: hda: add new API snd_hda_asoc_codec_new for ASoC codec drivers ASoC: hdac_hda: add DAI, widgets and related ops ASoC: hdac_hda: add runtime PM support ASoC: patch_realtek: add ASoC based Realtek HDA codec driver patch ASoC: Intel: Boards: add support for HDA codecs include/sound/hdaudio_ext.h | 3 +- sound/hda/ext/hdac_ext_bus.c | 9 +- sound/pci/hda/hda_codec.c | 109 ++++- sound/pci/hda/hda_codec.h | 4 + sound/pci/hda/patch_realtek.c | 3 +- sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/hdac_hda.c | 628 +++++++++++++++++++++++++++ sound/soc/codecs/hdac_hda.h | 26 ++ sound/soc/codecs/patch_realtek.c | 48 ++ sound/soc/intel/boards/Kconfig | 11 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/skl_hda_dsp_common.c | 173 ++++++++ sound/soc/intel/boards/skl_hda_dsp_common.h | 42 ++ sound/soc/intel/boards/skl_hda_dsp_generic.c | 141 ++++++ sound/soc/intel/skylake/skl-pcm.c | 32 +- sound/soc/intel/skylake/skl.c | 79 +++- sound/soc/intel/skylake/skl.h | 10 +- 18 files changed, 1311 insertions(+), 25 deletions(-) create mode 100644 sound/soc/codecs/hdac_hda.c create mode 100644 sound/soc/codecs/hdac_hda.h create mode 100644 sound/soc/codecs/patch_realtek.c create mode 100644 sound/soc/intel/boards/skl_hda_dsp_common.c create mode 100644 sound/soc/intel/boards/skl_hda_dsp_common.h create mode 100644 sound/soc/intel/boards/skl_hda_dsp_generic.c -- 2.7.4

4 23

[alsa-devel] [PATCH] ASoC: Intel: bxt: Refine the HW contraint of Ref capture.
by Harry Pan 13 Dec '17

13 Dec '17

The patch restricts the HW contraint of the refcap of WoV stream in single channel (mono) and 16k Hz based on platform implementation. Such that, the userspace program can rely on correct HW parameters through the ALSA library call to manipulate the device. Signed-off-by: Harry Pan <harry.pan(a)intel.com> --- sound/soc/intel/boards/bxt_da7219_max98357a.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c index ce35ec7884d1..382f71228807 100644 --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c @@ -338,8 +338,23 @@ static const struct snd_pcm_hw_constraint_list constraints_16000 = { .list = rates_16000, }; +static const unsigned int ch_mono[] = { + 1, +}; + +static const struct snd_pcm_hw_constraint_list constraints_refcap = { + .count = ARRAY_SIZE(ch_mono), + .list = ch_mono, +}; + static int broxton_refcap_startup(struct snd_pcm_substream *substream) { + substream->runtime->hw.channels_max = 1; + + snd_pcm_hw_constraint_list(substream->runtime, 0, + SNDRV_PCM_HW_PARAM_CHANNELS, + &constraints_refcap); + return snd_pcm_hw_constraint_list(substream->runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &constraints_16000); -- 2.13.5

2 1

[alsa-devel] [PATCH v6 00/17] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs
by Richard Fitzgerald 13 Dec '17

13 Dec '17

The Cirrus Logic CS47L35, CS47L85, CS47L90/91 codecs are complex audio SoC devices. In addition to the core audio capability they have onboard GPIO, regulators, DSPs and interrupt controller and a large register map space accessed over SPI or I2C. This family of codecs is based around common IP blocks and they are managed by a set of common drivers referred to as "Madera". Patches still waiting for review/ack: #8 regulator #9 irqchip #14-17 ASoC Richard Fitzgerald (17): mfd: madera: Add register definitions for Cirrus Logic Madera codecs mfd: madera: Add DT bindings for Cirrus Logic Madera codecs mfd: madera: Add common support for Cirrus Logic Madera codecs mfd: madera: Register map tables for Cirrus Logic CS47L35 mfd: madera: Register map tables for Cirrus Logic CS47L85 mfd: madera: Register map tables for Cirrus Logic CS47L90/91 regulator: arizona-micsupp: Add support for Cirrus Logic Madera codecs regulator: arizona-ldo1: Add support for Cirrus Logic Madera codecs irqchip: Add driver for Cirrus Logic Madera codecs pinctrl: madera: Add DT bindings for Cirrus Logic Madera codecs pinctrl: madera: Add driver for Cirrus Logic Madera codecs gpio: madera: Support Cirrus Logic Madera class codecs ASoC: madera: Add DT bindings for Cirrus Logic Madera codecs ASoC: madera: Add common support for Cirrus Logic Madera codecs ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Documentation/devicetree/bindings/mfd/madera.txt | 102 + .../bindings/pinctrl/cirrus,madera-pinctrl.txt | 99 + .../bindings/regulator/arizona-regulator.txt | 3 +- Documentation/devicetree/bindings/sound/madera.txt | 67 + MAINTAINERS | 23 + drivers/gpio/Kconfig | 6 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-madera.c | 196 + drivers/irqchip/Kconfig | 3 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-madera.c | 301 ++ drivers/mfd/Kconfig | 48 + drivers/mfd/Makefile | 13 + drivers/mfd/cs47l35-tables.c | 1610 +++++++ drivers/mfd/cs47l85-tables.c | 3010 +++++++++++++ drivers/mfd/cs47l90-tables.c | 2675 ++++++++++++ drivers/mfd/madera-core.c | 599 +++ drivers/mfd/madera-i2c.c | 140 + drivers/mfd/madera-spi.c | 139 + drivers/mfd/madera.h | 44 + drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/cirrus/Kconfig | 15 + drivers/pinctrl/cirrus/Makefile | 11 + drivers/pinctrl/cirrus/pinctrl-cs47l35.c | 46 + drivers/pinctrl/cirrus/pinctrl-cs47l85.c | 60 + drivers/pinctrl/cirrus/pinctrl-cs47l90.c | 58 + drivers/pinctrl/cirrus/pinctrl-madera.c | 1074 +++++ drivers/pinctrl/cirrus/pinctrl-madera.h | 40 + drivers/regulator/Kconfig | 15 +- drivers/regulator/arizona-ldo1.c | 82 +- drivers/regulator/arizona-micsupp.c | 71 +- include/dt-bindings/sound/madera.h | 27 + include/linux/irqchip/irq-madera-pdata.h | 23 + include/linux/irqchip/irq-madera.h | 98 + include/linux/mfd/madera/core.h | 196 + include/linux/mfd/madera/pdata.h | 61 + include/linux/mfd/madera/registers.h | 3987 ++++++++++++++++++ include/sound/madera-pdata.h | 61 + sound/soc/codecs/Kconfig | 23 + sound/soc/codecs/Makefile | 8 + sound/soc/codecs/cs47l35.c | 1748 ++++++++ sound/soc/codecs/cs47l85.c | 2722 ++++++++++++ sound/soc/codecs/cs47l90.c | 2661 ++++++++++++ sound/soc/codecs/madera.c | 4439 ++++++++++++++++++++ sound/soc/codecs/madera.h | 470 +++ 46 files changed, 27068 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/madera.txt create mode 100644 Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt create mode 100644 Documentation/devicetree/bindings/sound/madera.txt create mode 100644 drivers/gpio/gpio-madera.c create mode 100644 drivers/irqchip/irq-madera.c create mode 100644 drivers/mfd/cs47l35-tables.c create mode 100644 drivers/mfd/cs47l85-tables.c create mode 100644 drivers/mfd/cs47l90-tables.c create mode 100644 drivers/mfd/madera-core.c create mode 100644 drivers/mfd/madera-i2c.c create mode 100644 drivers/mfd/madera-spi.c create mode 100644 drivers/mfd/madera.h create mode 100644 drivers/pinctrl/cirrus/Kconfig create mode 100644 drivers/pinctrl/cirrus/Makefile create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l35.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l85.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-cs47l90.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-madera.c create mode 100644 drivers/pinctrl/cirrus/pinctrl-madera.h create mode 100644 include/dt-bindings/sound/madera.h create mode 100644 include/linux/irqchip/irq-madera-pdata.h create mode 100644 include/linux/irqchip/irq-madera.h create mode 100644 include/linux/mfd/madera/core.h create mode 100644 include/linux/mfd/madera/pdata.h create mode 100644 include/linux/mfd/madera/registers.h create mode 100644 include/sound/madera-pdata.h create mode 100644 sound/soc/codecs/cs47l35.c create mode 100644 sound/soc/codecs/cs47l85.c create mode 100644 sound/soc/codecs/cs47l90.c create mode 100644 sound/soc/codecs/madera.c create mode 100644 sound/soc/codecs/madera.h -- 2.11.0

3 28

[alsa-devel] [PATCH] ASOC: wm8960: Add multiple MCLK frequency support
by Chen.Liu 12 Dec '17

12 Dec '17

From: "Chen.Liu" <chen.liu.opensource(a)gmail.com> Issue: MCLK=24MHZ,SYSCLOCK=12.288MHZ. When the 'wm8960_set_dai_pll' function is called,the driver will prompted "WM8960 PLL: unsupported N = 4" error message. However,the value of PLLN should be 8 based on the table45( PLL Frequency Examples) of the wm8960 chip manuanl. Reason: The intergrated PLL can be used to generate SYSCLK for the wm8960. The pll_factors function in the wm8974.c file is mainly responsible for setting the divider factor of the PLL divider with reference to MCLK clock frequency to obtain the required SYSCLK clock frequency. The configure diagram for this function can be seen below. MCLK-->[f/2]-->[R=f2/f1]-->[f/4]-->[f/N](1)-->SYSCLOCK The configuration of the PLL divider in above diagram is applicable to MCLK clock frequency is less than or equal to 14.4MHZ. examples: (1)MCLK=12MHz, required clock = 12.288MHz. R should be chosen to ensure 5 < PLLN < 13. There is a fixed divide by 4 in the PLL and a selectable divide by N after the PLL which should be set to divide by 1 to meet this requirement. Enabling the divide by 1 sets the required f2 = 4 x 1 x 12.288MHz = 49.152MHz. R = 49.152 / (12 / 2) = 8.192 PLLN = int R = 8 (2)MCLK=24MHz, required clock = 12.288MHz. Enabling the divide by 1 sets the required f2 = 4 x 1 x 12.288MHZ = 49.152MHZ. R = 49.152 / (24 / 2) = 4.096 PLLN = int R = 4 And if the [f/N] reg is set to 2,then the required f2 = 4x2x12.288MHZ = 98.304MHZ. R = 98.304 / (24 / 2) = 8.192 PLLN = int R = 8 Because the [f/N] reg is fixed divide by 1,that's why driver prompted error message. Solution: The purpose of this patch is when the conditions(5 < PLLN < 13) is false, set the register[f/N] to be 2, and the recalculate the divide factor of the PLL divider. MCLK-->[f/2]-->[R=f2/f1]-->[f/4]-->[f/N](2)-->SYSCLOCK Signed-off-by: Chen.Liu <chen.liu.opensource(a)gmail.com> --- sound/soc/codecs/wm8960.c | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 997c446..49a27b1 100644 --- a/sound/soc/codecs/wm8960.c +++ b/sound/soc/codecs/wm8960.c @@ -1036,17 +1036,25 @@ static bool is_pll_freq_available(unsigned int source, unsigned int target) * to allow rounding later */ #define FIXED_PLL_SIZE ((1 << 24) * 10) -static int pll_factors(unsigned int source, unsigned int target, +static int pll_factors(struct snd_soc_codec *codec, + unsigned int source, unsigned int target, struct _pll_div *pll_div) { unsigned long long Kpart; unsigned int K, Ndiv, Nmod; + int unsupport = 0; + u16 reg; pr_debug("WM8960 PLL: setting %dHz->%dHz\n", source, target); /* Scale up target to PLL operating frequency */ target *= 4; +retry: + if (unsupport) { + target *= 2; + unsupport += 1; + } Ndiv = target / source; if (Ndiv < 6) { source >>= 1; @@ -1056,8 +1064,12 @@ static int pll_factors(unsigned int source, unsigned int target, pll_div->pre_div = 0; if ((Ndiv < 6) || (Ndiv > 12)) { - pr_err("WM8960 PLL: Unsupported N=%d\n", Ndiv); - return -EINVAL; + if (unsupport == 2) { + pr_err("WM8960 PLL: Unsupported N=%d\n", Ndiv); + return -EINVAL; + } + unsupport = 1; + goto retry; } pll_div->n = Ndiv; @@ -1077,6 +1089,11 @@ static int pll_factors(unsigned int source, unsigned int target, pll_div->k = K; + if (unsupport) { + reg = snd_soc_read(codec, WM8960_CLOCK1) | WM8960_SYSCLK_DIV_2; + snd_soc_write(codec, WM8960_CLOCK1, reg); + } + pr_debug("WM8960 PLL: N=%x K=%x pre_div=%d\n", pll_div->n, pll_div->k, pll_div->pre_div); @@ -1091,7 +1108,7 @@ static int wm8960_set_pll(struct snd_soc_codec *codec, int ret; if (freq_in && freq_out) { - ret = pll_factors(freq_in, freq_out, &pll_div); + ret = pll_factors(codec, freq_in, freq_out, &pll_div); if (ret != 0) return ret; } -- 1.8.3.1

3 3

[alsa-devel] [BUG] soc/sti: a possible sleep-in-atomic bug in uni_player_ctl_iec958_put
by Jia-Ju Bai 12 Dec '17

12 Dec '17

According to sound/soc/sti/uniperif_player.c, the driver may sleep under a spinlock. The function call path is: uni_player_ctl_iec958_put (acquire the spinlock) uni_player_set_channel_status mutex_lock --> may sleep I do not find a good way to fix it, so I only report. This possible bug is found by my static analysis tool (DSAC) and checked by my code review. Thanks, Jia-Ju Bai

2 1

[alsa-devel] [BUG] haswell: a possible sleep-in-atomic bug in hsw_irq_thread
by Jia-Ju Bai 12 Dec '17

12 Dec '17

According to sound/soc/intel/haswell/sst-haswell-ipc.c, the driver may sleep under a spinlock. The function call path is: hsw_irq_thread (acquire the spinlock) hsw_process_notification hsw_log_message mutex_lock --> may sleep I do not find a good way to fix it, so I only report. This possible bug is found by my static analysis tool (DSAC) and checked by my code review. Thanks, Jia-Ju Bai

1 0

[alsa-devel] [PATCH 0/4] ARM: sun8i: a83t: Add support for I2S and I2C
by Chen-Yu Tsai 12 Dec '17

12 Dec '17

Hi everyone, This series adds support for I2S and I2C on the Allwinner A83T SoC. The I2S controllers are similar to the ones found on the A31. However the TX FIFO and interrupt status registers were swapped around. This seems to be a recurring theme for the audio related hardware blocks. Patch 1 adds support for the A83T variant with a compatible string and associated quirks structure. Patch 2 adds device nodes and default pinmux settings for the I2S controllers. Patch 3 adds device nodes and default pinmux settings for the I2C controllers. Patch 4 is an example of a PCM5122 codec tied to I2C2 and I2S1 over the GPIO header of the Banana Pi M3. This patch should not be merged. Please have a look. Regards ChenYu Chen-Yu Tsai (4): ASoC: sun4i-i2s: Add support for A83T ARM: dts: sun8i: a83t: Add I2S controller device nodes ARM: dts: sun8i: a83t: Add I2C device nodes and pinmux settings [DO NOT MERGE] ARM: dts: sun8i: a83t: bpi-m3: Enable PCM5122 codec with I2S1 .../devicetree/bindings/sound/sun4i-i2s.txt | 2 + arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 33 ++++++++ arch/arm/boot/dts/sun8i-a83t.dtsi | 99 ++++++++++++++++++++++ sound/soc/sunxi/sun4i-i2s.c | 21 +++++ 4 files changed, 155 insertions(+) -- 2.15.0

3 9