July 2016 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [patch] ALSA: mixart: don't print an unintialized variable on error
by Dan Carpenter 13 Jul '16

13 Jul '16

My static checker complains that "resp" could be unitialized on error when we print its value. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/sound/pci/mixart/mixart_mixer.c b/sound/pci/mixart/mixart_mixer.c index 58fd79eb..51e5349 100644 --- a/sound/pci/mixart/mixart_mixer.c +++ b/sound/pci/mixart/mixart_mixer.c @@ -965,7 +965,7 @@ static int mixart_update_monitoring(struct snd_mixart* chip, int channel) int err; struct mixart_msg request; struct mixart_set_out_audio_level audio_level; - u32 resp; + u32 resp = 0; if(chip->pipe_out_ana.status == PIPE_UNDEFINED) return -EINVAL; /* no pipe defined */

3 3

[alsa-devel] [PATCH 0/5] topology: Enhance support for private data
by mengdong.lin＠linux.intel.com 13 Jul '16

13 Jul '16

From: Mengdong Lin <mengdong.lin(a)linux.intel.com> There is no ABI change in this series. We finished verification on latest Intel platforms. There will be 4 or 5 series. Later series will come with some ABI update for topology. The size check on ABI objects in current ASoC kernel will detect possible ABI version mismatch between user space and kernel. Mengdong Lin (5): topology: An element can refer to multipe data sections in text conf file topology: Merge lookup for data reference into tplg_copy_data() topology: Change uuid value to 16 separate characters in text conf file topology: Parse vendor private data for manifest topology: Tuple type can have an extenstion include/topology.h | 69 ++++++++++- src/topology/ctl.c | 52 ++++---- src/topology/dapm.c | 17 ++- src/topology/data.c | 296 +++++++++++++++++++++++++++++++++++++++------- src/topology/elem.c | 4 + src/topology/parser.c | 28 ++++- src/topology/tplg_local.h | 14 ++- 7 files changed, 389 insertions(+), 91 deletions(-) -- 2.5.0

2 8

[alsa-devel] [alsa-lib][PATCH] ctl: add compatibility information for snd_ctl_elem_info_set_dimension()
by Takashi Sakamoto 13 Jul '16

13 Jul '16

I forgot it when committing to the API. Fixes: 16812b70daeb('ctl: add an API to set dimension levels to element information') Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- src/control/control.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/control/control.c b/src/control/control.c index a88f7a1..aa05130 100644 --- a/src/control/control.c +++ b/src/control/control.c @@ -2515,6 +2515,9 @@ use_default_symbol_version(__snd_ctl_elem_info_get_dimension, snd_ctl_elem_info_ * <dt>-EINVAL * <dd>Invalid arguments are given as parameters. * </dl> + * + * \par Compatibility: + * This function is added in version 1.1.2. */ int snd_ctl_elem_info_set_dimension(snd_ctl_elem_info_t *info, const int dimension[4]) -- 2.7.4

2 1

[alsa-devel] [GIT PULL] Add Kabylake audio firmware
by Vinod Koul 12 Jul '16

12 Jul '16

Hello, Please PULL to recive the audio firmware for Kabylake Intel SoC. The following changes since commit 1dc99be22222fbf88adc98d85f8ffb7529c6c4e3: amdgpu: update vce firmware for VI asics (2016-07-11 15:18:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/firmware.git kbl for you to fetch changes up to 11e3390b4fac69b50a5f88861d295fd94e51ba6c: linux-firmware: intel: Add Kabylake audio firmware (2016-07-12 14:50:59 +0530) ---------------------------------------------------------------- Vinod Koul (1): linux-firmware: intel: Add Kabylake audio firmware WHENCE | 6 ++++++ intel/dsp_fw_kbl.bin | 1 + intel/dsp_fw_kbl_v701.bin | Bin 0 -> 238920 bytes 3 files changed, 7 insertions(+) create mode 120000 intel/dsp_fw_kbl.bin create mode 100644 intel/dsp_fw_kbl_v701.bin Thanks -- ~Vinod

2 1

[alsa-devel] [PATCH] ALSA: ak4114: remove redundant check on err being < 0
by Colin King 12 Jul '16

12 Jul '16

From: Colin Ian King <colin.king(a)canonical.com> snd_ak4114_create checks if the error return err is less than zero or not. This is a redundant check, err can only be < 0 to get to the __fail label, in which case just return err and remove the redundant check (since we never return -EIO). Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/i2c/other/ak4114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/i2c/other/ak4114.c b/sound/i2c/other/ak4114.c index 5a4cf3f..d53c9bb 100644 --- a/sound/i2c/other/ak4114.c +++ b/sound/i2c/other/ak4114.c @@ -121,7 +121,7 @@ int snd_ak4114_create(struct snd_card *card, __fail: snd_ak4114_free(chip); - return err < 0 ? err : -EIO; + return err; } EXPORT_SYMBOL(snd_ak4114_create); -- 2.8.1

2 1

[alsa-devel] [PATCH] ALSA: ak4117: remove redundant check on err being < 0
by Colin King 12 Jul '16

12 Jul '16

From: Colin Ian King <colin.king(a)canonical.com> snd_ak4117_create checks if the error return err is less than zero or not. This is a redundant check, err can only be < 0 to get to the __fail label, in which case just return err and remove the redundant check (since we never return -EIO). Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/i2c/other/ak4117.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/i2c/other/ak4117.c b/sound/i2c/other/ak4117.c index 48848909..0702f05 100644 --- a/sound/i2c/other/ak4117.c +++ b/sound/i2c/other/ak4117.c @@ -110,7 +110,7 @@ int snd_ak4117_create(struct snd_card *card, ak4117_read_t *read, ak4117_write_t __fail: snd_ak4117_free(chip); - return err < 0 ? err : -EIO; + return err; } void snd_ak4117_reg_write(struct ak4117 *chip, unsigned char reg, unsigned char mask, unsigned char val) -- 2.8.1

2 1

[alsa-devel] [PATCH] ALSA: hda: add AMD Stoney PCI ID with proper driver caps
by Awais Belal 12 Jul '16

12 Jul '16

This allows the device to correctly show up as ATI HDMI rather than a generic one and allows the driver to use the available caps. Signed-off-by: Awais Belal <awais_belal(a)mentor.com> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 09920ba..4b80b16 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2106,6 +2106,8 @@ static const struct pci_device_id azx_ids[] = { .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, { PCI_DEVICE(0x1002, 0x157a), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + { PCI_DEVICE(0x1002, 0x15b3), + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, { PCI_DEVICE(0x1002, 0x793b), .driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI }, { PCI_DEVICE(0x1002, 0x7919), -- 1.9.1

2 1

[alsa-devel] Problem getting USB DAC to work
by John Westwood 12 Jul '16

12 Jul '16

Dear ALSA Developers I have a problem getting my obscure USB DAC (Starting Point Systems DAC3) to work in Linux. I believe the problem may be similar to this one, but am not sure: https://groups.google.com/forum/#!topic/linux.debian.kernel/HwwkRkbL5aY If I try to use aplay to play a wav I receive the following error: aplay -D default test.wav Playing WAVE 'test.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo aplay: pcm_write:1939: write error: No such device syslog shows the following: Jul 9 15:38:31 atlas kernel: [ 4805.148059] usb 7-2: USB disconnect, device number 19 Jul 9 15:38:32 atlas kernel: [ 4805.532022] usb 7-2: new full-speed USB device number 20 using uhci_hcd Jul 9 15:38:32 atlas kernel: [ 4805.725024] usb 7-2: New USB device found, idVendor=2504, idProduct=0201 Jul 9 15:38:32 atlas kernel: [ 4805.725029] usb 7-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3 Jul 9 15:38:32 atlas kernel: [ 4805.725032] usb 7-2: Product: TDA 1543 DAC 3 v1.4 Jul 9 15:38:32 atlas kernel: [ 4805.725034] usb 7-2: Manufacturer: STARTING POINT SYSTEMS Jul 9 15:38:32 atlas kernel: [ 4805.725035] usb 7-2: SerialNumber: Jul 9 15:38:32 atlas kernel: [ 4805.745018] usb 7-2: Warning! Unlikely big volume range (=65535), cval->res is probably wrong. Jul 9 15:38:32 atlas kernel: [ 4805.745023] usb 7-2: [2] FU [PCM Playback Volume] ch = 1, val = -32768/32767/1 Jul 9 15:38:32 atlas mtp-probe: checking bus 7, device 20: "/sys/devices/pci0000:00/0000:00:1d.1/usb7/7-2" Jul 9 15:38:32 atlas mtp-probe: bus: 7, device: 20 was not an MTP device I have another USB DAC that works fine, in syslog the working DAC has the following lines which are not present with the non-working DAC: Jul 11 19:56:35 atlas kernel: [83940.049124] input: Lakewest Audio Audiolab M-DAC as /devices/pci0000:00/0000:00:1d.1/usb7/7-2/7-2:1.0/0003:0451:ADAC.0002/input/input12 Jul 11 19:56:35 atlas kernel: [83940.104367] hid-generic 0003:0451:ADAC.0002:input,hiddev0,hidraw1: USB HID v1.11 Device [Lakewest Audio Audiolab M-DAC] on usb-0000:00:1d.1-2/input0 With the non-working DAC I get these lines instead: Jul 11 19:56:25 atlas kernel: [83930.079063] usb 7-2: Warning! Unlikely big volume range (=65535), cval->res is probably wrong. Jul 11 19:56:25 atlas kernel: [83930.079067] usb 7-2: [2] FU [PCM Playback Volume] ch = 1, val = -32768/32767/1 I am using Linux Mint 17.3 64bit, kernel 3.19.0-32. I have also tried kernel 4.4.0-28 but to no avail. The ALSA version is 1.0.27.2 . Any help or suggestions would be greatly appreciated. Thanks very much. Best regards John Westwood

1 0

[alsa-devel] Fwd: Audio capture on OMAP3530/DM3730 (Yocto Poky Linux 3.18+) occasionally swaps channels
by Akram Hameed 12 Jul '16

12 Jul '16

Hello there, (Apologies for cross-posting from user list if you are seeing this twice). I have a fairly serious problem using ALSA for capture on an Gumstix Overo based system. The audio device in question is a TWL4030 device. It is connected to a TI DM3730 (or in some cases, an OMAP3530). Previously I was using a 3.0 kernel and my audio capture worked just fine with no extra tweaks to ALSA. Now for other reasons I have to move to a more recent kernel, and have tried with 3.18 and 4.4 stable releases. Using these kernels, at random times, the audio capture channels will swap. They will remain swapped for an unpredictable period of time, and then they will swap back. This will continue forever, again, with the swapping occurring at random times. Our system totally relies on predictable audio capture - so for this random behaviour to occur means we must seek a different platform unless we can either: a) Find a solution for 3.18 or newer kernel (the problem is still occurring with ALSA 1.1 on kernel 4.4) or, b) Make some code change to solve the issue. I found this alsa-devel thread regarding the 2.6.32 kernel that seems to be almost exactly what I am experiencing: http://mailman.alsa-project.org/pipermail/alsa-devel/2011-February/036895.h… I also found this one which is probably more closely related: http://mailman.alsa-project.org/pipermail/alsa-devel/2013-March/060557.html My current thought is that it is indeed a DMA issue, but I am not familiar with that area of the kernel source and therefore hoping someone might have some suggestions about what to try next. Best regards, Akram

1 0

[alsa-devel] [PATCH v2] sound: oss: Remove useless initialisation
by Amitoj Kaur Chawla 12 Jul '16

12 Jul '16

Remove useless initialisation of variable whose value is reinitialised later. The Coccinelle semantic patch used to make this change is as follows: @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; Signed-off-by: Amitoj Kaur Chawla <amitoj1606(a)gmail.com> --- Changes in v2: -Modify commit message sound/oss/ad1848.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c index 10c8de1..6368e5c 100644 --- a/sound/oss/ad1848.c +++ b/sound/oss/ad1848.c @@ -254,7 +254,7 @@ static void ad_write(ad1848_info * devc, int reg, int data) static void wait_for_calibration(ad1848_info * devc) { - int timeout = 0; + int timeout; /* * Wait until the auto calibration process has finished. -- 1.9.1

2 1