July 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [asoc:for-next 6/18] sound/soc/codecs/rt5645.c:2931:3: warning: 'return' with a value, in function returning void
by kbuild test robot 17 Jul '15

17 Jul '15

tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next head: db91b047f7131c7e8fe00ca9e38d14c0c103363f commit: 947d4dc4cd5be5da8e5e82f314d5cfb85a3eb3cc [6/18] Merge remote-tracking branch 'asoc/topic/rt5645' into asoc-next config: i386-randconfig-x009-201528 (attached as .config) reproduce: git checkout 947d4dc4cd5be5da8e5e82f314d5cfb85a3eb3cc # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): sound/soc/codecs/rt5645.c: In function 'rt5645_jack_detect_work': >> sound/soc/codecs/rt5645.c:2931:3: warning: 'return' with a value, in function returning void return -EINVAL; ^ vim +/return +2931 sound/soc/codecs/rt5645.c 6e747d53 Bard Liao 2015-04-28 2915 regmap_update_bits(rt5645->regmap, RT5645_GEN_CTRL1, 6e747d53 Bard Liao 2015-04-28 2916 RT5645_DIG_GATE_CTRL, RT5645_DIG_GATE_CTRL); 6e747d53 Bard Liao 2015-04-28 2917 } 345b0f50 John Lin 2015-05-18 2918 rt5645_irq(0, rt5645); f3fa1bbd Oder Chiou 2014-09-19 2919 f3fa1bbd Oder Chiou 2014-09-19 2920 return 0; f3fa1bbd Oder Chiou 2014-09-19 2921 } f3fa1bbd Oder Chiou 2014-09-19 2922 EXPORT_SYMBOL_GPL(rt5645_set_jack_detect); f3fa1bbd Oder Chiou 2014-09-19 2923 cd6e82b8 Oder Chiou 2014-10-07 2924 static void rt5645_jack_detect_work(struct work_struct *work) cd6e82b8 Oder Chiou 2014-10-07 2925 { cd6e82b8 Oder Chiou 2014-10-07 2926 struct rt5645_priv *rt5645 = cd6e82b8 Oder Chiou 2014-10-07 2927 container_of(work, struct rt5645_priv, jack_detect_work.work); 6e747d53 Bard Liao 2015-04-28 2928 int val, btn_type, gpio_state = 0, report = 0; 6e747d53 Bard Liao 2015-04-28 2929 f2a5ded3 Nicolas Boichat 2015-07-17 2930 if (!rt5645->codec) f2a5ded3 Nicolas Boichat 2015-07-17 @2931 return -EINVAL; f2a5ded3 Nicolas Boichat 2015-07-17 2932 6e747d53 Bard Liao 2015-04-28 2933 switch (rt5645->pdata.jd_mode) { 6e747d53 Bard Liao 2015-04-28 2934 case 0: /* Not using rt5645 JD */ 0b0cefc8 Oder Chiou 2015-06-10 2935 if (rt5645->gpiod_hp_det) { 0b0cefc8 Oder Chiou 2015-06-10 2936 gpio_state = gpiod_get_value(rt5645->gpiod_hp_det); 0b0cefc8 Oder Chiou 2015-06-10 2937 dev_dbg(rt5645->codec->dev, "gpio_state = %d\n", 0b0cefc8 Oder Chiou 2015-06-10 2938 gpio_state); 0b0cefc8 Oder Chiou 2015-06-10 2939 report = rt5645_jack_detect(rt5645->codec, gpio_state); :::::: The code at line 2931 was first introduced by commit :::::: f2a5ded38592e5936a099ea6535ad5d3addcbc9d ASoC: rt5645: Check if codec is initialized in workqueue handler :::::: TO: Nicolas Boichat <drinkcat(a)chromium.org> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] HDMI hotplug on Skylake when power well is off
by David Henningsson 17 Jul '15

17 Jul '15

Hi, I'm trying to debug an issue here where the HDMI hotplug events are not delivered to the audio side when the power well is off. This is on a Skylake machine (running in HDA mode). I'm not sure whether the problem is upstream or due to my own patches while testing, so I was wondering how this is supposed to be working, so I can troubleshoot further? Should there be an IRQ on the HDA controller even if the power well is off, and if not, how should the audio driver be notified that an HDMI hotplug event has happened? -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic

3 13

[alsa-devel] [PATCH v4] ASoC: rt5645: Check if codec is initialized in workqueue handler
by Nicolas Boichat 17 Jul '15

17 Jul '15

This fixes kernel panic on boot, if rt5645->codec is NULL when rt5645_jack_detect_work is first called. rt5645_jack_detect_work needs rt5645->codec to be initialized to setup dapm pins. Also, reporting jack events is useless, as the jacks cannot be set before the codec is ready. Since we manually call the interrupt handler in rt5645_set_jack_detect, the initial jack state will be reported correctly, and dapm pins will be setup at that time. Signed-off-by: Nicolas Boichat <drinkcat(a)chromium.org> --- This replaces 3c2234569cfff83718792f810a9bb855b78c2473, and applies on top of Linux 4.2-rc1, so that this patch can be applied in its own branch, without triggering a compile warning. Also, reworded the message to make it more obvious this can cause a kernel panic. Thanks! sound/soc/codecs/rt5645.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 9ce311e..e9cc3aa 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -2943,6 +2943,9 @@ static int rt5645_irq_detection(struct rt5645_priv *rt5645) { int val, btn_type, gpio_state = 0, report = 0; + if (!rt5645->codec) + return -EINVAL; + switch (rt5645->pdata.jd_mode) { case 0: /* Not using rt5645 JD */ if (rt5645->gpiod_hp_det) { -- 2.4.3.573.g4eafbef

2 3

[alsa-devel] [PATCH] ALSA: hda: fix kstrdup return value
by Heloise NH 17 Jul '15

17 Jul '15

From: kernelpatch_update <kernelpatch_update(a)163.com> In kstrdup we should return -ENOMEM when it reports an memory allocation failure, while the -ENODEV is referred to a failure in finding the cpu node in the device tree. Signed-off-by: Heloise NH <kernelpatch_update(a)163.com> --- sound/pci/hda/hda_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 5de3c5d..d78fa71 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -975,7 +975,7 @@ int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card, if (codec->bus->modelname) { codec->modelname = kstrdup(codec->bus->modelname, GFP_KERNEL); if (!codec->modelname) { - err = -ENODEV; + err = -ENOMEM; goto error; } } -- 1.9.1

2 1

[alsa-devel] bug-report: Play Bad Sound After Test Runs for 6 hrs
by Yadi 17 Jul '15

17 Jul '15

Hi, everyone, I encounter a strange issue that sound would be bad after running below testcase on intel target over 7 hours. composite: libsdl1.2-dev 1.2.14-4ubuntu1.1 libsdl-mixer1.2 1.2.8-6build1 alsa-lib-1.0.29 this issue would disappear if I try to attach process by gdb or adding print in alsa-lib/pcm. any comments would be appreciated. Yadi

2 1

[alsa-devel] drm/edid: sound/core: pcm_drm_eld.c compilation error in 4.2
by Jean-Francois Moine 17 Jul '15

17 Jul '15

The file sound/core/pcm_drm_eld.c which was added by the commit 838d1631b766529213684f07dd71cdf2e92f0623 ALSA: pcm: add DRM ELD helper lacks the function drm_eld_sad() which was defined by Russell's patch http://article.gmane.org/gmane.linux.ports.arm.kernel/411574 drm/edid: add function to help find SADs This patch has not been applied. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/

3 2

[alsa-devel] [PATCH] ASoC: rt5645: remove unused variable
by Sudip Mukherjee 17 Jul '15

17 Jul '15

We were getting a build warning about unused variable. This variable was a leftover from: a4e3c5fa955c ("ASoC: rt5645: Simplify rt5645_enable_push_button_irq") Signed-off-by: Sudip Mukherjee <sudip(a)vectorindia.org> --- sound/soc/codecs/rt5645.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index d24c979..ff091d6 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -2763,7 +2763,6 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec, bool enable) { struct snd_soc_dapm_context *dapm = snd_soc_codec_get_dapm(codec); - struct rt5645_priv *rt5645 = snd_soc_codec_get_drvdata(codec); if (enable) { snd_soc_dapm_force_enable_pin(dapm, "ADC L power"); -- 1.8.1.2

2 1

[alsa-devel] [PATCH v2 1/2] ASoC: rt5645: Fix missing free_irq
by Koro Chen 17 Jul '15

17 Jul '15

The driver does not free irq when snd_soc_register_codec returns error. It does not return error when request irq failed, either. Add return when request irq failed, and free_irq if snd_soc_register_codec failed. Signed-off-by: Koro Chen <koro.chen(a)mediatek.com> --- Change since v1: - use free_irq instead of devm_request_threaded_irq --- sound/soc/codecs/rt5645.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 2cedf0d..56e8c31 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3401,12 +3401,23 @@ static int rt5645_i2c_probe(struct i2c_client *i2c, ret = request_threaded_irq(rt5645->i2c->irq, NULL, rt5645_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5645", rt5645); - if (ret) + if (ret) { dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + return ret; + } } - return snd_soc_register_codec(&i2c->dev, &soc_codec_dev_rt5645, - rt5645_dai, ARRAY_SIZE(rt5645_dai)); + ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_rt5645, + rt5645_dai, ARRAY_SIZE(rt5645_dai)); + if (ret) + goto err_irq; + + return 0; + +err_irq: + if (rt5645->i2c->irq) + free_irq(rt5645->i2c->irq, rt5645); + return ret; } static int rt5645_i2c_remove(struct i2c_client *i2c) -- 1.8.1.1.dirty

1 1

[alsa-devel] [PATCH] ASoC: rt5645: Remove unused rt5645 variable
by Nicolas Boichat 17 Jul '15

17 Jul '15

"ASoC: rt5645: Simplify rt5645_enable_push_button_irq" removes the test that accessed rt5645->pdata.jd_mode (that test is now done in rt5645_jack_detect only), so we do not need that variable anymore. Signed-off-by: Nicolas Boichat <drinkcat(a)chromium.org> --- Applies on top of topic/rt5645. Sorry for not catching this earlier. sound/soc/codecs/rt5645.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 2cedf0d..c959ee0 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -2763,7 +2763,6 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec, bool enable) { struct snd_soc_dapm_context *dapm = snd_soc_codec_get_dapm(codec); - struct rt5645_priv *rt5645 = snd_soc_codec_get_drvdata(codec); if (enable) { snd_soc_dapm_force_enable_pin(dapm, "ADC L power"); -- 2.4.3.573.g4eafbef

1 0

[alsa-devel] [PATCH] ASoC: Constify dev_pm_ops variables
by Axel Lin 17 Jul '15

17 Jul '15

The dev_pm_ops variables are not modified after initialization in these drivers, so make them const. Signed-off-by: Axel Lin <axel.lin(a)ingics.com> --- sound/soc/codecs/wm2200.c | 2 +- sound/soc/codecs/wm5100.c | 2 +- sound/soc/codecs/wm8962.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm2200.c b/sound/soc/codecs/wm2200.c index cdaa175..878d43a 100644 --- a/sound/soc/codecs/wm2200.c +++ b/sound/soc/codecs/wm2200.c @@ -2481,7 +2481,7 @@ static int wm2200_runtime_resume(struct device *dev) } #endif -static struct dev_pm_ops wm2200_pm = { +static const struct dev_pm_ops wm2200_pm = { SET_RUNTIME_PM_OPS(wm2200_runtime_suspend, wm2200_runtime_resume, NULL) }; diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index e5572d2..eb494d0 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2706,7 +2706,7 @@ static int wm5100_runtime_resume(struct device *dev) } #endif -static struct dev_pm_ops wm5100_pm = { +static const struct dev_pm_ops wm5100_pm = { SET_RUNTIME_PM_OPS(wm5100_runtime_suspend, wm5100_runtime_resume, NULL) }; diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index c67e304..cbd1886 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -3859,7 +3859,7 @@ static int wm8962_runtime_suspend(struct device *dev) } #endif -static struct dev_pm_ops wm8962_pm = { +static const struct dev_pm_ops wm8962_pm = { SET_RUNTIME_PM_OPS(wm8962_runtime_suspend, wm8962_runtime_resume, NULL) }; -- 2.1.0

1 0