July 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Applied "ASoC: sti-uniperf: Fix implicit inclusion of pinctrl" to the asoc tree
by Mark Brown 20 Jul '15

20 Jul '15

The patch ASoC: sti-uniperf: Fix implicit inclusion of pinctrl has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From c7ab66836d2d31fe549b71c0b835c563d4419061 Mon Sep 17 00:00:00 2001 From: Mark Brown <broonie(a)kernel.org> Date: Mon, 20 Jul 2015 18:36:15 +0100 Subject: [PATCH] ASoC: sti-uniperf: Fix implicit inclusion of pinctrl Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/sti/sti_uniperif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c index 83a301f2aa66..10e8c3a0b85f 100644 --- a/sound/soc/sti/sti_uniperif.c +++ b/sound/soc/sti/sti_uniperif.c @@ -6,6 +6,7 @@ */ #include <linux/module.h> +#include <linux/pinctrl.h> #include "uniperif.h" -- 2.1.4

1 0

[alsa-devel] [PATCH v2 1/4] ASoC: fsl_sai: Add driver suspend and resume to support MEGA Fast
by Zidan Wang 20 Jul '15

20 Jul '15

For i.MX6 SoloX, there is a mode of the SoC to shutdown all power source of modules during system suspend and resume procedure. Thus, SAI needs to save all the values of registers before the system suspend and restore them after the system resume. Signed-off-by: Zidan Wang <zidan.wang(a)freescale.com> --- sound/soc/fsl/fsl_sai.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 5c73bea..62187e4 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -637,6 +637,8 @@ static bool fsl_sai_readable_reg(struct device *dev, unsigned int reg) static bool fsl_sai_volatile_reg(struct device *dev, unsigned int reg) { switch (reg) { + case FSL_SAI_TCSR: + case FSL_SAI_RCSR: case FSL_SAI_TFR: case FSL_SAI_RFR: case FSL_SAI_TDR: @@ -681,6 +683,7 @@ static const struct regmap_config fsl_sai_regmap_config = { .readable_reg = fsl_sai_readable_reg, .volatile_reg = fsl_sai_volatile_reg, .writeable_reg = fsl_sai_writeable_reg, + .cache_type = REGCACHE_RBTREE, }; static int fsl_sai_probe(struct platform_device *pdev) @@ -802,10 +805,40 @@ static const struct of_device_id fsl_sai_ids[] = { { /* sentinel */ } }; +#if CONFIG_PM_SLEEP +static int fsl_sai_suspend(struct device *dev) +{ + struct fsl_sai *sai = dev_get_drvdata(dev); + + regcache_cache_only(sai->regmap, true); + regcache_mark_dirty(sai->regmap); + + return 0; +} + +static int fsl_sai_resume(struct device *dev) +{ + struct fsl_sai *sai = dev_get_drvdata(dev); + + regcache_cache_only(sai->regmap, false); + regmap_write(sai->regmap, FSL_SAI_TCSR, FSL_SAI_CSR_SR); + regmap_write(sai->regmap, FSL_SAI_RCSR, FSL_SAI_CSR_SR); + msleep(1); + regmap_write(sai->regmap, FSL_SAI_TCSR, 0); + regmap_write(sai->regmap, FSL_SAI_RCSR, 0); + return regcache_sync(sai->regmap); +} +#endif /* CONFIG_PM_SLEEP */ + +static const struct dev_pm_ops fsl_sai_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(fsl_sai_suspend, fsl_sai_resume) +}; + static struct platform_driver fsl_sai_driver = { .probe = fsl_sai_probe, .driver = { .name = "fsl-sai", + .pm = &fsl_sai_pm_ops, .of_match_table = fsl_sai_ids, }, }; -- 1.9.1

3 6

Re: [alsa-devel] ASoC: Add max98925 codec driver
by Dan Carpenter 20 Jul '15

20 Jul '15

Hello Anish Kumar, The patch 1ff2765182d1: "ASoC: Add max98925 codec driver" from Mar 9, 2015, leads to the following static checker warning: sound/soc/codecs/max98925.c:274 max98925_rate_value() error: buffer overflow 'rate_table' 9 <= 9 sound/soc/codecs/max98925.c 259 static inline int max98925_rate_value(struct snd_soc_codec *codec, 260 int rate, int clock, int *value, int *n, int *m) 261 { 262 int ret = -EINVAL; 263 int i; 264 265 for (i = 0; i < ARRAY_SIZE(rate_table); i++) { 266 if (rate_table[i].rate >= rate) { 267 *value = rate_table[i].sr; 268 *n = rate_table[i].divisors[clock][0]; 269 *m = rate_table[i].divisors[clock][1]; 270 ret = 0; 271 break; 272 } 273 } 274 dev_dbg(codec->dev, "%s: sample rate is %d, returning %d\n", 275 __func__, rate_table[i].rate, *value); ^^^^^^^^^^^^^^^^^^ If we don't break then we're off by one. 276 return ret; 277 } regards, dan carpenter

2 2

[alsa-devel] [PATCH] ALSA: hda: add new AMD PCI IDs with proper driver caps
by Maruthi Srinivas Bayyavarapu 20 Jul '15

20 Jul '15

Fixes audio problems on newer asics Signed-off-by: Maruthi Bayyavarapu <maruthi.bayyavarapu(a)amd.com> Cc: stable(a)vger.kernel.org --- sound/pci/hda/hda_intel.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index ca151b4..cb7e8f8 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2182,6 +2182,8 @@ static const struct pci_device_id azx_ids[] = { /* ATI HDMI */ { PCI_DEVICE(0x1002, 0x1308), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + { PCI_DEVICE(0x1002, 0x157a), + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, { PCI_DEVICE(0x1002, 0x793b), .driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI }, { PCI_DEVICE(0x1002, 0x7919), @@ -2236,8 +2238,14 @@ static const struct pci_device_id azx_ids[] = { .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, { PCI_DEVICE(0x1002, 0xaab0), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + { PCI_DEVICE(0x1002, 0xaac0), + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, { PCI_DEVICE(0x1002, 0xaac8), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + { PCI_DEVICE(0x1002, 0xaad8), + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, + { PCI_DEVICE(0x1002, 0xaae8), + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS }, /* VIA VT8251/VT8237A */ { PCI_DEVICE(0x1106, 0x3288), .driver_data = AZX_DRIVER_VIA | AZX_DCAPS_POSFIX_VIA }, -- 1.9.1

2 1

[alsa-devel] [PATCH v2] ALSA: hda - Fix Skylake codec timeout
by David Henningsson 20 Jul '15

20 Jul '15

When the controller is powered up but the HDMI codec is powered down on Skylake, the power well is turned off. When the codec is then powered up again, we need to poke the codec a little extra to make sure it wakes up. Otherwise we'll get sad "no response from codec" messages and broken audio. This also changes azx_runtime_resume to actually call snd_hdac_set_codec_wakeup for Skylake (before STATETS read). (Otherwise it would only have been called for Haswell and Broadwell, which both do not need it, so this probably was not the author's intention.) Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/hda/hdac_i915.c | 5 ++++- sound/pci/hda/hda_intel.c | 18 ++++++++++-------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index 442500e..5676b84 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -56,8 +56,11 @@ int snd_hdac_display_power(struct hdac_bus *bus, bool enable) enable ? "enable" : "disable"); if (enable) { - if (!bus->i915_power_refcount++) + if (!bus->i915_power_refcount++) { acomp->ops->get_power(acomp->dev); + snd_hdac_set_codec_wakeup(bus, true); + snd_hdac_set_codec_wakeup(bus, false); + } } else { WARN_ON(!bus->i915_power_refcount); if (!--bus->i915_power_refcount) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index ca151b4..9962237 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -979,14 +979,16 @@ static int azx_runtime_resume(struct device *dev) if (!azx_has_pm_runtime(chip)) return 0; - if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL - && hda->need_i915_power) { - bus = azx_bus(chip); - snd_hdac_display_power(bus, true); - haswell_set_bclk(hda); - /* toggle codec wakeup bit for STATESTS read */ - snd_hdac_set_codec_wakeup(bus, true); - snd_hdac_set_codec_wakeup(bus, false); + if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL) { + bus = azx_bus(chip); + if (hda->need_i915_power) { + snd_hdac_display_power(bus, true); + haswell_set_bclk(hda); + } else { + /* toggle codec wakeup bit for STATESTS read */ + snd_hdac_set_codec_wakeup(bus, true); + snd_hdac_set_codec_wakeup(bus, false); + } } /* Read STATESTS before controller reset */ -- 1.9.1

4 10

[alsa-devel] Beaglebone audio card problem diagnosis?
by g4＠novadsp.com 19 Jul '15

19 Jul '15

Hello all. I'm running mainline 4.1.0 on a Beaglebone Black (TI AM3359 SOC). The board has a standard TI TLV320AIC codec connected via the B3 rev B audio cape: (http://elinux.org/CircuitCo:Audio_Cape_RevB) Loading the nominally correct device tree overlay gets the following kernel log (1). An aplay -l listing (2) shows something recognized is present. Lsmod (3) shows what looks like a sane collection of prerequisite modules. Upon trying to play a test file the kernel gets a number of buffer underflow/underrun messages (4) There was a patch posted here (http://mailman.alsa-project.org/pipermail/alsa-devel/2014-November/083797.h tml) which appears to have made it into 4.1.0. Any thoughts on where to start looking to fix? More info can be provided if required and can also check hardware pin activity. Any pointers much appreciated. TAIA Jerry. -----------------------------------snip (1) root@arm:/home/debian# echo BB-BONE-AUDI-02 > /sys/devices/platform/bone_capemgr/slots [ 100.654019] bone_capemgr bone_capemgr: part_number 'BB-BONE-AUDI-02', version 'N/A' [ 100.662117] bone_capemgr bone_capemgr: slot #4: override [ 100.667840] bone_capemgr bone_capemgr: Using override eeprom data at slot 4 [ 100.675221] bone_capemgr bone_capemgr: slot #4: 'Override Board Name,00A0,Override Manuf,BB-BONE-AUDI-02' [ 100.712198] bone_capemgr bone_capemgr: slot #4: dtbo 'BB-BONE-AUDI-02-00A0.dtbo' loaded; overlay id #0 root@arm:/home/debian# [ 101.015982] davinci_evm ocp:sound: ASoC: CPU DAI (null) not registered [ 101.023017] davinci_evm ocp:sound: snd_soc_register_card failed (-517) [ 101.056114] 2-0018 supply IOVDD not found, using dummy regulator [ 101.067907] 2-0018 supply DVDD not found, using dummy regulator [ 101.074535] 2-0018 supply AVDD not found, using dummy regulator [ 101.080746] 2-0018 supply DRVDD not found, using dummy regulator [ 101.089316] davinci_evm ocp:sound: ASoC: CODEC DAI tlv320aic3x-hifi not registered [ 101.097310] davinci_evm ocp:sound: snd_soc_register_card failed (-517) [ 101.114161] davinci_evm ocp:sound: tlv320aic3x-hifi <-> 48038000.mcasp mapping ok -----------------------------------snip (2) root@arm:/home/debian# aplay -l **** List of PLAYBACK Hardware Devices **** card 0: EVM [DA830 EVM], device 0: AIC3X tlv320aic3x-hifi-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 -----------------------------------snip (3) root@arm:/home/debian# lsmod Module Size Used by snd_soc_davinci_mcasp 14407 2 snd_soc_tlv320aic3x 40077 1 snd_soc_edma 1150 1 snd_soc_davinci_mcasp snd_soc_evm 4802 0 snd_soc_omap 2573 1 snd_soc_davinci_mcasp snd_soc_core 156839 5 snd_soc_davinci_mcasp,snd_soc_edma,snd_soc_omap,snd_soc_tlv320aic3x,snd_soc_ evm snd_compress 11858 1 snd_soc_core snd_pcm_dmaengine 5065 2 snd_soc_core,snd_soc_omap snd_pcm 85645 5 snd_soc_davinci_mcasp,snd_soc_core,snd_soc_omap,snd_soc_tlv320aic3x,snd_pcm_ dmaengine snd_timer 17058 1 snd_pcm snd 58469 4 snd_soc_core,snd_timer,snd_pcm,snd_compress soundcore 6861 1 snd omap_aes 13065 0 omap_sham 19198 0 tda998x 11695 1 tilcdc 27899 0 omap_rng 4354 0 drm_kms_helper 106679 3 tda998x,tilcdc rng_core 7266 1 omap_rng uio_pdrv_genirq 3317 0 uio 8350 1 uio_pdrv_genirq leds_gpio 3110 0 -----------------------------------snip (4) debian@arm:~$ aplay sine2s.wav Playing WAVE 'sine2s.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo [ 618.068355] davinci-mcasp 48038000.mcasp: Transmit buffer underflow underrun!!! (at least 0.410 ms long) [ 618.092511] davinci-mcasp 48038000.mcasp: Transmit buffer underflow underrun!!! (at least 11.824 ms long) [ 618.121692] davinci-mcasp 48038000.mcasp: Transmit buffer underflow underrun!!! (at least 3.200 ms long) [ 618.134323] davinci-mcasp 48038000.mcasp: Transmit buffer underflow

1 0

[alsa-devel] [PATCH] ALSA: hda - Add headset mic support for Acer Aspire V5-573G
by Takashi Iwai 19 Jul '15

19 Jul '15

From: Mateusz Sylwestrzak <matisec7(a)gmail.com> Acer Aspire V5 with the ALC282 codec is given the wrong value for the 0x19 PIN by the laptop's BIOS. Overriding it with the correct value adds support for the headset microphone which would not otherwise be visible in the system. The fix is based on commit 7819717b1134 with a similar quirk for Acer Aspire with the ALC269 codec. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96201 Cc: <stable(a)vger.kernel.org> Signed-off-by: Mateusz Sylwestrzak <matisec7(a)gmail.com> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d35cf506a7db..caba66b2311c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5061,7 +5061,7 @@ static const struct hda_fixup alc269_fixups[] = { { 0x14, 0x90170110 }, { 0x17, 0x40000008 }, { 0x18, 0x411111f0 }, - { 0x19, 0x411111f0 }, + { 0x19, 0x01a1913c }, { 0x1a, 0x411111f0 }, { 0x1b, 0x411111f0 }, { 0x1d, 0x40f89b2d }, -- 2.4.5

1 0

[alsa-devel] [PATCH v3 0/2] Add codec machine driver for rockchip platform
by Xing Zheng 19 Jul '15

19 Jul '15

From: zhengxing <zhengxing(a)rock-chips.com> Hi, The simple-card is not common at present, soc maybe need own machine driver for jack detection. Add drivers for two families of rockchip-bases chromebooks. These machine drives don't use simplecard because we need custom jack detection plumbing. - use ts3a227e for ext jack detection with max98090 - call rt5645_set_jack_detect function via rt5645 codec driver Thanks. Changes in v3: Signed-off-by: zhengxing <zhengxing(a)rock-chips.com> zhengxing (2): ASoC: rockchip: Add machine driver for max98090 codec ASoC: rockchip: Add machine driver for rt5645/rt5650 codec .../bindings/sound/rockchip-max98090.txt | 19 ++ .../devicetree/bindings/sound/rockchip-rt5645.txt | 17 ++ sound/soc/rockchip/Kconfig | 19 ++ sound/soc/rockchip/Makefile | 6 + sound/soc/rockchip/rockchip_max98090.c | 236 ++++++++++++++++++++ sound/soc/rockchip/rockchip_rt5645.c | 225 +++++++++++++++++++ 6 files changed, 522 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rockchip-max98090.txt create mode 100644 Documentation/devicetree/bindings/sound/rockchip-rt5645.txt create mode 100644 sound/soc/rockchip/rockchip_max98090.c create mode 100644 sound/soc/rockchip/rockchip_rt5645.c -- 1.7.9.5

1 2

[alsa-devel] [PATCH v2 0/2] Add codec machine driver for rockchip platform
by Xing Zheng 19 Jul '15

19 Jul '15

From: zhengxing <zhengxing(a)rock-chips.com> Hi, The simple-card is not common at present, soc maybe need own machine driver for jack detection. Add drivers for two families of rockchip-bases chromebooks. These machine drives don't use simplecard because we need custom jack detection plumbing. - use ts3a227e for ext jack detection with max98090 - call rt5645_set_jack_detect function via rt5645 codec driver Thanks. Changes in v2: Signed-off-by: zhengxing <zhengxing(a)rock-chips.com> zhengxing (2): ASoC: rockchip: Add machine driver for max98090 codec ASoC: rockchip: Add machine driver for rt5645/rt5650 codec .../bindings/sound/rockchip-max98090.txt | 19 ++ .../devicetree/bindings/sound/rockchip-rt5645.txt | 17 ++ sound/soc/rockchip/Kconfig | 19 ++ sound/soc/rockchip/Makefile | 6 + sound/soc/rockchip/rockchip_max98090.c | 247 ++++++++++++++++++++ sound/soc/rockchip/rockchip_rt5645.c | 236 +++++++++++++++++++ 6 files changed, 544 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rockchip-max98090.txt create mode 100644 Documentation/devicetree/bindings/sound/rockchip-rt5645.txt create mode 100644 sound/soc/rockchip/rockchip_max98090.c create mode 100644 sound/soc/rockchip/rockchip_rt5645.c -- 1.7.9.5

2 4

Re: [alsa-devel] After kernel upgrade to v ~~> 4.1.0, no audio output unless UNPLUG/RE-PLUGIN of audio jack on card; OK with earlier kernels
by robert.devanna＠nospammail.net 19 Jul '15

19 Jul '15

On Mon, Jul 6, 2015, at 01:46 AM, Takashi Iwai wrote: > It's a known problem with VIA codecs, and the fix was already merged > in 4.2-rc1, the commit 735c75cf4d434862e38c01dcfb2ce8d2fcb9035f. > The next stable 4.1.x kernel should contain the fix. Upgraded to uname -rm 4.1.2-1.g5ccacb4-desktop x86_64 Fyi, the problem remains unchanged. To get sound, a physical unplug/replug is required.

2 1