October 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: rt5645: Allow 4 channel recording on AIF1
by Ben Zhang 02 Oct '15

02 Oct '15

The codec supports 4 channel recording with TDM on AIF1. This patch modifies the DAI capability to allow it. Signed-off-by: Ben Zhang <benzh(a)chromium.org> --- sound/soc/codecs/rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index b0d96b6..0d092bf 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3101,7 +3101,7 @@ static struct snd_soc_dai_driver rt5645_dai[] = { .capture = { .stream_name = "AIF1 Capture", .channels_min = 1, - .channels_max = 2, + .channels_max = 4, .rates = RT5645_STEREO_RATES, .formats = RT5645_FORMATS, }, -- 2.6.0.rc2.230.g3dd15c0

2 3

[alsa-devel] ATMEL sam9g25 SSC in I2S slave mode on linux 4.1.1 play only right channel
by Paolo Tagliavini 02 Oct '15

02 Oct '15

I'm working on my based sam9g25 design. To have SPDIF output I used cs4265 codec instead of wm8731 as sem9g25 reference design. Now I'm working on porting of cs4265 codec driver. It work for play only right channel, left channel is mute and not supplied by SSC. SSC is configured as I2S slave : SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM Do you know this behaviour ? There is a patch for fix it ? Thank you in advance.

1 0

[alsa-devel] [PATCH 1/1] ASoc: dwc: correct irq clear method
by yitian 02 Oct '15

02 Oct '15

from Designware I2S datasheet, irq is cleared by reading from TOR/ROR registers, rather than by writing into them. Signed-off-by: Yitian Bu <yitian.bu(a)tangramtek.com> --- sound/soc/dwc/designware_i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c index a3e97b4..0d28e3b 100644 --- a/sound/soc/dwc/designware_i2s.c +++ b/sound/soc/dwc/designware_i2s.c @@ -131,10 +131,10 @@ static inline void i2s_clear_irqs(struct dw_i2s_dev *dev, u32 stream) if (stream == SNDRV_PCM_STREAM_PLAYBACK) { for (i = 0; i < 4; i++) - i2s_write_reg(dev->i2s_base, TOR(i), 0); + i2s_read_reg(dev->i2s_base, TOR(i)); } else { for (i = 0; i < 4; i++) - i2s_write_reg(dev->i2s_base, ROR(i), 0); + i2s_read_reg(dev->i2s_base, ROR(i)); } } -- 1.7.12.4

2 1

Re: [alsa-devel] Bug: LADSPA implementation - no up/downmix handling
by Takashi Iwai 02 Oct '15

02 Oct '15

On Fri, 25 Sep 2015 20:51:38 +0200, Andreas Hartmann wrote: > > Am Donnerstag, 24. September 2015, 15:07:14 schrieben Sie: > > On Thu, 24 Sep 2015 12:44:53 +0200, > > > > Andreas Hartmann wrote: > > > Am Mittwoch, 23. September 2015, 16:26:58 schrieb Takashi Iwai: > > > > On Sat, 12 Sep 2015 22:10:40 +0200, > > > > > > > > Andreas Hartmann wrote: > > > > > Hi, > > > > > > > > > > Using the surround_encoder of the swh-plugins I noticed, that the alsa > > > > > implementation only assumes an equal number of in- and output channels > > > > > for > > > > > ladspa plugins. This occurs from Line 752 onwards in pcm_ladspa.c and > > > > > leads to a Segfault shortly after. > > > > > There needs to be a check and correct handling for up/downmix > > > > > scenarios. > > > > > > > > Could you give the back trace? Or at best submit a fix patch? > > > > > > > > > > > > thanks, > > > > > > > > Takashi > > > > _______________________________________________ > > > > Alsa-devel mailing list > > > > Alsa-devel(a)alsa-project.org > > > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > > > > > Sure here you go > > > > > > #0 0x00007ffff78623ef in snd_pcm_ladspa_allocate_memory (pcm=0x626fa0, > > > pcm=0x626fa0, pcm=0x626fa0, ladspa=0x621ad0) at pcm_ladspa.c:753 > > > #1 snd_pcm_ladspa_init (pcm=0x626fa0) at pcm_ladspa.c:834 > > > #2 0x00007ffff7842946 in snd_pcm_plugin_prepare (pcm=0x626fa0) at > > > pcm_plugin.c:171 > > > #3 0x00007ffff784290f in snd_pcm_plugin_prepare (pcm=0x62c760) at > > > pcm_plugin.c:162 > > > #4 0x000000000040256a in ?? () > > > #5 0x00007ffff7222ec5 in __libc_start_main (main=0x401d80, argc=4, > > > argv=0x7fffffffde28, init=<optimized out>, fini=<optimized out>, > > > rtld_fini=<optimized out>, > > > > > > stack_end=0x7fffffffde18) at libc-start.c:287 > > > > > > #6 0x0000000000402fdd in ?? () > > > > It looks rather like a simply typo. Does the patch below work? > > > > > > Takashi > > > > diff --git a/src/pcm/pcm_ladspa.c b/src/pcm/pcm_ladspa.c > > index 631ee0f35b73..6552b4379ec0 100644 > > --- a/src/pcm/pcm_ladspa.c > > +++ b/src/pcm/pcm_ladspa.c > > @@ -749,7 +749,7 @@ static int snd_pcm_ladspa_allocate_memory(snd_pcm_t > > *pcm, snd_pcm_ladspa_t *lads return -ENOMEM; > > } > > for (idx = 0; idx < instance->input.channels.size; idx++) { > > - chn = instance->output.channels.array[idx]; > > + chn = instance->input.channels.array[idx]; > > if (pchannels[chn] == NULL && chn < ichannels) { > > instance->input.data[idx] = NULL; > > continue; > > It seems to work Sorry, I forgot to apply this to upstream. Now pushed out. thanks, Takashi

1 0

[alsa-devel] [RESEND PATCH 1/1] ASoC: dwc: correct irq clear method
by yitian 02 Oct '15

02 Oct '15

from Designware I2S datasheet, irq is cleared by reading from TOR/ROR registers, rather than by writing into them. Signed-off-by: Yitian Bu <yitian.bu(a)tangramtek.com> --- sound/soc/dwc/designware_i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c index a3e97b4..0d28e3b 100644 --- a/sound/soc/dwc/designware_i2s.c +++ b/sound/soc/dwc/designware_i2s.c @@ -131,10 +131,10 @@ static inline void i2s_clear_irqs(struct dw_i2s_dev *dev, u32 stream) if (stream == SNDRV_PCM_STREAM_PLAYBACK) { for (i = 0; i < 4; i++) - i2s_write_reg(dev->i2s_base, TOR(i), 0); + i2s_read_reg(dev->i2s_base, TOR(i)); } else { for (i = 0; i < 4; i++) - i2s_write_reg(dev->i2s_base, ROR(i), 0); + i2s_read_reg(dev->i2s_base, ROR(i)); } } -- 1.7.12.4

2 4

[alsa-devel] [PATCH 1/1] ASoC: dwc: correct irq clear method
by Yitian Bu 02 Oct '15

02 Oct '15

from Designware I2S datasheet, tx/rx XRUN irq is cleared by reading register TOR/ROR, rather than by writing into them. Signed-off-by: Yitian Bu <yitian.bu(a)tangramtek.com> --- sound/soc/dwc/designware_i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c index a3e97b4..0d28e3b 100644 --- a/sound/soc/dwc/designware_i2s.c +++ b/sound/soc/dwc/designware_i2s.c @@ -131,10 +131,10 @@ static inline void i2s_clear_irqs(struct dw_i2s_dev *dev, u32 stream) if (stream == SNDRV_PCM_STREAM_PLAYBACK) { for (i = 0; i < 4; i++) - i2s_write_reg(dev->i2s_base, TOR(i), 0); + i2s_read_reg(dev->i2s_base, TOR(i)); } else { for (i = 0; i < 4; i++) - i2s_write_reg(dev->i2s_base, ROR(i), 0); + i2s_read_reg(dev->i2s_base, ROR(i)); } } -- 1.7.12.4

1 0

[alsa-devel] [PATCH 0/2] CONFIG_OF vs DMA_OF
by Kuninori Morimoto 02 Oct '15

02 Oct '15

Hi Vinod, Mark Current OF base DMAEngine API will be compiled if .config has CONFIG_DMA_OF. but of-dma.h based on CONFIG_OF instead of CONFIG_DMA_OF. These patches tidyup this issue. Please check 1) patch carefully, since DMAEngine API has many dependency to other drivers. > Mark I think 2) patch is based on 1). Please check it Kuninori Morimoto (2): 1) dmaengine: OF DMAEngine API based on CONFIG_DMA_OF instead of CONFIG_OF 2) ASoC: rsnd: SND_SOC_RCAR doesn't depend on DMA_OF include/linux/of_dma.h | 2 +- sound/soc/sh/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) Best regards --- Kuninori Morimoto

2 9

[alsa-devel] Additional bugs in tlv320aic3x.c driver (register defaults)
by Rick Mann 01 Oct '15

01 Oct '15

Benoît, I've discovered some additional minor bugs in the tlv320aic3104 support in the tlv320aic3x driver. In this instance, the reg_default values aren't quite right. I've written a corrected list, but the set specified includes the reserved registers. I don't know if devm_regmap_init_i2c() attempts to write the default values, or uses them as the initial values in a cache (and attempts to avoid writes unless specific registers change). In my debugging, it does not appear to write the entire register map at any point to the IC, so I think it's the latter. I also don't know how the regmap is intended to be used. It is passed to devm_regmap_init_i2c() as .reg_defaults, implying the array provides starting values, but other parts of the code refer to the array as if the values are changed in that array as they're read and written. Documentation for regmap suggests regmaps can be "sparse," which I presume would be done by omitting the reserved registers from the defaults array. In any case, the fix is not trivial, and I don't want to go down that road not knowing if it's the right approach. Does this make sense? For reference, the registers with different default values (than the ones specified in that file) are 32, 33, 51, 58, 65, 72, 93. Thanks, -- Rick Mann rmann(a)latencyzero.com

2 1

[alsa-devel] Enabling kernel debugging in sound before devices are loaded
by Rick Mann 01 Oct '15

01 Oct '15

I'm trying to enable kernel debug logging like this: # echo "file sound* +pflm" > /sys/kernel/debug/dynamic_debug/control But it has no effect until after I load the Device Tree Overlay that creates my codec and sound card nodes. Unfortunately at this point, it's too late for the debugging to do any good. This is with kernel 4.1.9 on a Beaglebone Black Debian Jessie distro. I don't really know how the kernel dyndebug system works; I am able to enable other debugging locations, but none in sound/* Appreciate any guidance. Thank you. -- Rick Mann rmann(a)latencyzero.com

1 0

[alsa-devel] [PATCH 1/2] ASoC: rt5645: Correct the naming and setting of ADC Boost Volume Control
by Oder Chiou 01 Oct '15

01 Oct '15

Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/codecs/rt5645.c | 6 +++--- sound/soc/codecs/rt5645.h | 16 +++++++++------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 3eb184c..080cc1c 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -519,11 +519,11 @@ static const struct snd_kcontrol_new rt5645_snd_controls[] = { RT5645_L_VOL_SFT + 1, RT5645_R_VOL_SFT + 1, 63, 0, adc_vol_tlv), /* ADC Boost Volume Control */ - SOC_DOUBLE_TLV("STO1 ADC Boost Gain", RT5645_ADC_BST_VOL1, + SOC_DOUBLE_TLV("ADC Boost Capture Volume", RT5645_ADC_BST_VOL1, RT5645_STO1_ADC_L_BST_SFT, RT5645_STO1_ADC_R_BST_SFT, 3, 0, adc_bst_tlv), - SOC_DOUBLE_TLV("STO2 ADC Boost Gain", RT5645_ADC_BST_VOL1, - RT5645_STO2_ADC_L_BST_SFT, RT5645_STO2_ADC_R_BST_SFT, 3, 0, + SOC_DOUBLE_TLV("Mono ADC Boost Capture Volume", RT5645_ADC_BST_VOL2, + RT5645_MONO_ADC_L_BST_SFT, RT5645_MONO_ADC_R_BST_SFT, 3, 0, adc_bst_tlv), /* I2S2 function select */ diff --git a/sound/soc/codecs/rt5645.h b/sound/soc/codecs/rt5645.h index f45861c..61bc8ab 100644 --- a/sound/soc/codecs/rt5645.h +++ b/sound/soc/codecs/rt5645.h @@ -39,8 +39,8 @@ #define RT5645_STO1_ADC_DIG_VOL 0x1c #define RT5645_MONO_ADC_DIG_VOL 0x1d #define RT5645_ADC_BST_VOL1 0x1e -/* Mixer - D-D */ #define RT5645_ADC_BST_VOL2 0x20 +/* Mixer - D-D */ #define RT5645_STO1_ADC_MIXER 0x27 #define RT5645_MONO_ADC_MIXER 0x28 #define RT5645_AD_DA_MIXER 0x29 @@ -315,12 +315,14 @@ #define RT5645_STO1_ADC_R_BST_SFT 12 #define RT5645_STO1_ADC_COMP_MASK (0x3 << 10) #define RT5645_STO1_ADC_COMP_SFT 10 -#define RT5645_STO2_ADC_L_BST_MASK (0x3 << 8) -#define RT5645_STO2_ADC_L_BST_SFT 8 -#define RT5645_STO2_ADC_R_BST_MASK (0x3 << 6) -#define RT5645_STO2_ADC_R_BST_SFT 6 -#define RT5645_STO2_ADC_COMP_MASK (0x3 << 4) -#define RT5645_STO2_ADC_COMP_SFT 4 + +/* ADC Boost Volume Control (0x20) */ +#define RT5645_MONO_ADC_L_BST_MASK (0x3 << 14) +#define RT5645_MONO_ADC_L_BST_SFT 14 +#define RT5645_MONO_ADC_R_BST_MASK (0x3 << 12) +#define RT5645_MONO_ADC_R_BST_SFT 12 +#define RT5645_MONO_ADC_COMP_MASK (0x3 << 10) +#define RT5645_MONO_ADC_COMP_SFT 10 /* Stereo2 ADC Mixer Control (0x26) */ #define RT5645_STO2_ADC_SRC_MASK (0x1 << 15) -- 1.8.1.1.439.g50a6b54

2 3