October 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/2] ASoC: rt5645: Prevent the weird sound of the headphone while rebooting
by Oder Chiou 05 Oct '15

05 Oct '15

The patch adds the codec reset setting in the shutdown function to prevent the weird sound of the headphone happened by rebooting. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/codecs/rt5645.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index f436f50..4c4fe6b 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3517,6 +3517,8 @@ static void rt5645_i2c_shutdown(struct i2c_client *i2c) RT5645_CBJ_MN_JD); regmap_update_bits(rt5645->regmap, RT5645_IN1_CTRL1, RT5645_CBJ_BST1_EN, 0); + msleep(20); + regmap_write(rt5645->regmap, RT5645_RESET, 0); } static struct i2c_driver rt5645_i2c_driver = { -- 1.8.1.1.439.g50a6b54

3 3

[alsa-devel] Applied "ASoC: da7219: Improve error handling for regulator supplies" to the asoc tree
by Mark Brown 05 Oct '15

05 Oct '15

The patch ASoC: da7219: Improve error handling for regulator supplies has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 4e929134eb8271abc9c52c371e056debfea6898b Mon Sep 17 00:00:00 2001 From: Adam Thomson <Adam.Thomson.Opensource(a)diasemi.com> Date: Mon, 5 Oct 2015 15:10:04 +0100 Subject: [PATCH] ASoC: da7219: Improve error handling for regulator supplies Currently if bulk_enable() of supplies fails, the code still goes on to try and put the device into active state, and set expected IO voltage of the device. This doesn't really make sense so code now returns on bulk_enable() failure, with an error message. Also, to help with debug, failure to get supplies also provides an error message. Signed-off-by: Adam Thomson <Adam.Thomson.Opensource(a)diasemi.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/da7219.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 76f8fc2..c86a833 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1554,8 +1554,10 @@ static int da7219_handle_supplies(struct snd_soc_codec *codec) ret = devm_regulator_bulk_get(codec->dev, DA7219_NUM_SUPPLIES, da7219->supplies); - if (ret) + if (ret) { + dev_err(codec->dev, "Failed to get supplies"); return ret; + } /* Determine VDDIO voltage provided */ vddio = da7219->supplies[DA7219_SUPPLY_VDDIO].consumer; @@ -1567,6 +1569,10 @@ static int da7219_handle_supplies(struct snd_soc_codec *codec) /* Enable main supplies */ ret = regulator_bulk_enable(DA7219_NUM_SUPPLIES, da7219->supplies); + if (ret) { + dev_err(codec->dev, "Failed to enable supplies"); + return ret; + } /* Ensure device in active mode */ snd_soc_write(codec, DA7219_SYSTEM_ACTIVE, DA7219_SYSTEM_ACTIVE_MASK); @@ -1574,7 +1580,7 @@ static int da7219_handle_supplies(struct snd_soc_codec *codec) /* Update IO voltage level range */ snd_soc_write(codec, DA7219_IO_CTRL, io_voltage_lvl); - return ret; + return 0; } static void da7219_handle_pdata(struct snd_soc_codec *codec) -- 2.5.0

1 0

[alsa-devel] sysfs: cannot create duplicate filename '/devices/isa/sbawe.0/sound/card0/seq-oss-0-0'
by Michael Shell 05 Oct '15

05 Oct '15

Greetings, I recently upgraded (an admittedly ancient K6-2 PCI/ISA machine) to kernel version 4.2.2 (compiled from source). It went surprising well, but I did run into a minor issue which did not occur under the older kernel 3.16.3. Maybe the info here will help someone else out in the future or even reveal a bug that might have greater implications that have not yet been seen. The ancient machine has one of those ISA SoundBlaster cards whose drivers are compiled as modules (to allow isapnp to operate) before module loading. Upon issuing a /sbin/modprobe snd-sbawe port=0x220 mpu_port=0x330 awe_port=0x620 irq=5 dma8=1 dma16=5 mic_agc=1 csp=0 dmesg (under 4.2.2) spits out: EMU8000 [0x620]: 4096 KiB on-board DRAM detected ------------[ cut here ]------------ WARNING: CPU: 0 PID: 2791 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x51/0x80() sysfs: cannot create duplicate filename '/devices/isa/sbawe.0/sound/card0/seq-oss-0-0' Modules linked in: snd_emu8000_synth(+) snd_emux_synth snd_seq_virmidi snd_util_mem snd_opl3_synth snd_seq_midi_emul snd_sbawe snd_opl3_lib snd_sb16_dsp snd_sb16_csp snd_sb_common snd_mpu401_uart lp parport_pc parport CPU: 0 PID: 2791 Comm: modprobe Not tainted 4.2.2 #1 . . ---- (full output with trace at the end of this message) The /sys/devices/isa/sbawe.0 directory did not exist prior to the attempt to load snd-sbawe and there are no other sound drivers in the system other than those for the Soundblaster. I do still have OSS emulation selected in the kernel config - I was surpised that still is the recommended default. I probably could avoid this bug by deselecting that. I doubt I have any software that still requires OSS emulation, which is probably going to be removed from future kernels anyway (and Debian systems don't even carry it anymore). Nevertheless, a bug is a bug and this problem should not happen. I think snd_seq_oss and snd_emux_synth are both trying to register the same sysfs name or a single driver is trying to register the same thing twice. For the record, what is the correct procedure to find out exactly which drivers are in conflict in duplicate sysfs filename cases like this? Cheers and thanks in advance, Mike Shell ---- EMU8000 [0x620]: 4096 KiB on-board DRAM detected ------------[ cut here ]------------ WARNING: CPU: 0 PID: 2791 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x51/0x80() sysfs: cannot create duplicate filename '/devices/isa/sbawe.0/sound/card0/seq-oss-0-0' Modules linked in: snd_emu8000_synth(+) snd_emux_synth snd_seq_virmidi snd_util_mem snd_opl3_synth snd_seq_midi_emul snd_sbawe snd_opl3_lib snd_sb16_dsp snd_sb16_csp snd_sb_common snd_mpu401_uart lp parport_pc parport CPU: 0 PID: 2791 Comm: modprobe Not tainted 4.2.2 #1 c1604e78 c1031c40 c175c544 dd6dfc48 00000ae7 c1758c38 0000001f c1103391 c1103391 df493000 dd6ef2c0 dd6ec6b0 dd6bfe9c c1031d13 00000009 dd6dfc30 c175c544 dd6dfc48 c1103391 c1758c38 0000001f c175c544 df493fdf dd6ef2c0 Call Trace: [<c1604e78>] ? dump_stack+0xa/0x13 [<c1031c40>] ? warn_slowpath_common+0x80/0xc0 [<c1103391>] ? sysfs_warn_dup+0x51/0x80 [<c1103391>] ? sysfs_warn_dup+0x51/0x80 [<c1031d13>] ? warn_slowpath_fmt+0x33/0x40 [<c1103391>] ? sysfs_warn_dup+0x51/0x80 [<c110346b>] ? sysfs_create_dir_ns+0x6b/0x80 [<c11c156c>] ? kobject_add_internal+0x6c/0x2e0 [<c11c86cb>] ? vsnprintf+0xcb/0x400 [<c11c1956>] ? kobject_add+0x36/0x80 [<c134de21>] ? device_add+0xc1/0x500 [<c1441669>] ? snd_device_new+0x29/0xa0 [<c1460a56>] ? snd_seq_device_new+0xb6/0x100 [<c146096c>] ? snd_seq_device_dev_register+0xc/0x40 [<c1441604>] ? snd_device_register+0x44/0x80 [<e0bd1fc4>] ? snd_emux_init_seq_oss+0x84/0xa0 [snd_emux_synth] [<e0bcd1e3>] ? snd_emux_register+0x103/0x140 [snd_emux_synth] [<e0bcd000>] ? 0xe0bcd000 [<e0bcd020>] ? sf_sample_new+0x20/0x20 [snd_emux_synth] [<e0bcd040>] ? sf_sample_free+0x20/0x20 [snd_emux_synth] [<e0bdf113>] ? snd_emu8000_probe+0xd3/0x180 [snd_emu8000_synth] [<c11036dd>] ? sysfs_create_link+0x1d/0x40 [<c13504fb>] ? driver_probe_device+0x15b/0x220 [<c1350631>] ? __driver_attach+0x71/0x80 [<c13505c0>] ? driver_probe_device+0x220/0x220 [<c134f000>] ? bus_for_each_dev+0x40/0x80 [<c134ff7a>] ? driver_attach+0x1a/0x20 [<c13505c0>] ? driver_probe_device+0x220/0x220 [<c134fcf4>] ? bus_add_driver+0xd4/0x200 [<c1350b91>] ? driver_register+0x51/0xe0 [<e0be3000>] ? 0xe0be3000 [<e0be3000>] ? 0xe0be3000 [<c10003f2>] ? do_one_initcall+0x72/0x1a0 [<e0be3000>] ? 0xe0be3000 [<c14ac646>] ? netlink_broadcast_filtered+0x166/0x3c0 [<c106c4a5>] ? do_init_module+0x45/0x200 [<c10a8425>] ? __vunmap+0x85/0xe0 [<c106dfaa>] ? load_module+0x186a/0x1ea0 [<c106e6aa>] ? SyS_init_module+0xca/0x100 [<c160a2dd>] ? syscall_call+0x7/0x7 ---[ end trace 826ff8353957cad3 ]--- ------------[ cut here ]------------ WARNING: CPU: 0 PID: 2791 at lib/kobject.c:240 kobject_add_internal+0x252/0x2e0() kobject_add_internal failed for seq-oss-0-0 with -EEXIST, don't try to register things with the same name in the same directory. Modules linked in: snd_emu8000_synth(+) snd_emux_synth snd_seq_virmidi snd_util_mem snd_opl3_synth snd_seq_midi_emul snd_sbawe snd_opl3_lib snd_sb16_dsp snd_sb16_csp snd_sb_common snd_mpu401_uart lp parport_pc parport CPU: 0 PID: 2791 Comm: modprobe Tainted: G W 4.2.2 #1 c1604e78 c1031c40 c1768d78 dd6dfc84 00000ae7 c1768e8e 000000f0 c11c1752 c11c1752 dd66c274 00000000 dd66c274 dd6bfe9c c1031d13 00000009 dd6dfc6c c1768d78 dd6dfc84 c11c1752 c1768e8e 000000f0 c1768d78 c162bbd4 dd6ef2c0 Call Trace: [<c1604e78>] ? dump_stack+0xa/0x13 [<c1031c40>] ? warn_slowpath_common+0x80/0xc0 [<c11c1752>] ? kobject_add_internal+0x252/0x2e0 [<c11c1752>] ? kobject_add_internal+0x252/0x2e0 [<c1031d13>] ? warn_slowpath_fmt+0x33/0x40 [<c11c1752>] ? kobject_add_internal+0x252/0x2e0 [<c11c1956>] ? kobject_add+0x36/0x80 [<c134de21>] ? device_add+0xc1/0x500 [<c1441669>] ? snd_device_new+0x29/0xa0 [<c1460a56>] ? snd_seq_device_new+0xb6/0x100 [<c146096c>] ? snd_seq_device_dev_register+0xc/0x40 [<c1441604>] ? snd_device_register+0x44/0x80 [<e0bd1fc4>] ? snd_emux_init_seq_oss+0x84/0xa0 [snd_emux_synth] [<e0bcd1e3>] ? snd_emux_register+0x103/0x140 [snd_emux_synth] [<e0bcd000>] ? 0xe0bcd000 [<e0bcd020>] ? sf_sample_new+0x20/0x20 [snd_emux_synth] [<e0bcd040>] ? sf_sample_free+0x20/0x20 [snd_emux_synth] [<e0bdf113>] ? snd_emu8000_probe+0xd3/0x180 [snd_emu8000_synth] [<c11036dd>] ? sysfs_create_link+0x1d/0x40 [<c13504fb>] ? driver_probe_device+0x15b/0x220 [<c1350631>] ? __driver_attach+0x71/0x80 [<c13505c0>] ? driver_probe_device+0x220/0x220 [<c134f000>] ? bus_for_each_dev+0x40/0x80 [<c134ff7a>] ? driver_attach+0x1a/0x20 [<c13505c0>] ? driver_probe_device+0x220/0x220 [<c134fcf4>] ? bus_add_driver+0xd4/0x200 [<c1350b91>] ? driver_register+0x51/0xe0 [<e0be3000>] ? 0xe0be3000 [<e0be3000>] ? 0xe0be3000 [<c10003f2>] ? do_one_initcall+0x72/0x1a0 [<e0be3000>] ? 0xe0be3000 [<c14ac646>] ? netlink_broadcast_filtered+0x166/0x3c0 [<c106c4a5>] ? do_init_module+0x45/0x200 [<c10a8425>] ? __vunmap+0x85/0xe0 [<c106dfaa>] ? load_module+0x186a/0x1ea0 [<c106e6aa>] ? SyS_init_module+0xca/0x100 [<c160a2dd>] ? syscall_call+0x7/0x7 ---[ end trace 826ff8353957cad4 ]---

2 3

[alsa-devel] [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing
by Maxime Ripard 05 Oct '15

05 Oct '15

Most of the boards have their headphone jack directly connected to the matching pins of the SoCs. Since most of the time we will have the same routing path, it makes sense to put that in the driver, and only have a property describing whether that route is enabled or not. It also fixes the following warning messages that were seen so far: sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Left -> direct -> Headphone Jack sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Right -> direct -> Headphone Jack Reported-by: Priit Laes <plaes(a)plaes.org> Signed-off-by: Maxime Ripard <maxime.ripard(a)free-electrons.com> --- .../devicetree/bindings/sound/sun4i-codec.txt | 9 ++++---- sound/soc/sunxi/sun4i-codec.c | 25 +++++++++++++++++----- 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/sun4i-codec.txt b/Documentation/devicetree/bindings/sound/sun4i-codec.txt index 680144b74ae9..470823845698 100644 --- a/Documentation/devicetree/bindings/sound/sun4i-codec.txt +++ b/Documentation/devicetree/bindings/sound/sun4i-codec.txt @@ -13,10 +13,10 @@ Required properties: - clock-names: should contain followings: - "apb": the parent APB clock for this controller - "codec": the parent module clock -- routing : A list of the connections between audio components. Each - entry is a pair of strings, the first being the connection's sink, - the second being the connection's source. +Optional Properties: +- allwinner,hp-jack-attached: Indicates that the headphone jack on the + board is directly routed to the SoC pins Example: codec: codec@01c22c00 { @@ -28,6 +28,5 @@ codec: codec@01c22c00 { clock-names = "apb", "codec"; dmas = <&dma 0 19>, <&dma 0 19>; dma-names = "rx", "tx"; - routing = "Headphone Jack", "HP Right", - "Headphone Jack", "HP Left"; + allwinner,hp-jack-attached; }; diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 47780552dcd0..e86b8fcede5a 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -568,10 +568,18 @@ static struct snd_soc_dai_link *sun4i_codec_create_link(struct device *dev, return link; }; +static const struct snd_soc_dapm_widget sun4i_codec_sink_widgets[] = { + SND_SOC_DAPM_HP("Headphone Jack", NULL), +}; + +static const struct snd_soc_dapm_route sun4i_codec_sink_routes[] = { + { "Headphone Jack", NULL, "HP Right" }, + { "Headphone Jack", NULL, "HP Left" }, +}; + static struct snd_soc_card *sun4i_codec_create_card(struct device *dev) { struct snd_soc_card *card; - int ret; card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL); if (!card) @@ -584,10 +592,17 @@ static struct snd_soc_card *sun4i_codec_create_card(struct device *dev) card->dev = dev; card->name = "sun4i-codec"; - ret = snd_soc_of_parse_audio_routing(card, "routing"); - if (ret) { - dev_err(dev, "Failed to create our audio routing\n"); - return NULL; + /* + * FIXME: This will probably require more logic once we will + * support other sinks (for capture for example), or + * encounter more complicated setups where the + * headphone jack is not directly connected to the SoC. + */ + if (of_property_read_bool(dev->of_node, "allwinner,hp-jack-attached")) { + card->dapm_widgets = sun4i_codec_sink_widgets; + card->num_dapm_widgets = ARRAY_SIZE(sun4i_codec_sink_widgets); + card->dapm_routes = sun4i_codec_sink_routes; + card->num_dapm_routes = ARRAY_SIZE(sun4i_codec_sink_routes); } return card; -- 2.5.3

2 3

[alsa-devel] [PATCH 1/1] ASoC: da7219: Improve error handling for regulator supplies
by Adam Thomson 05 Oct '15

05 Oct '15

Currently if bulk_enable() of supplies fails, the code still goes on to try and put the device into active state, and set expected IO voltage of the device. This doesn't really make sense so code now returns on bulk_enable() failure, with an error message. Also, to help with debug, failure to get supplies also provides an error message. Signed-off-by: Adam Thomson <Adam.Thomson.Opensource(a)diasemi.com> --- This patch is based on changes introduced under patch: 'ASoC: codecs: Add da7219 codec driver' (Commit 6d817c0e9fd7536be76690bfdee88e8a81c16f7d, kernel/git/broonie/sound.git) sound/soc/codecs/da7219.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 76f8fc2..c86a833 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1554,8 +1554,10 @@ static int da7219_handle_supplies(struct snd_soc_codec *codec) ret = devm_regulator_bulk_get(codec->dev, DA7219_NUM_SUPPLIES, da7219->supplies); - if (ret) + if (ret) { + dev_err(codec->dev, "Failed to get supplies"); return ret; + } /* Determine VDDIO voltage provided */ vddio = da7219->supplies[DA7219_SUPPLY_VDDIO].consumer; @@ -1567,6 +1569,10 @@ static int da7219_handle_supplies(struct snd_soc_codec *codec) /* Enable main supplies */ ret = regulator_bulk_enable(DA7219_NUM_SUPPLIES, da7219->supplies); + if (ret) { + dev_err(codec->dev, "Failed to enable supplies"); + return ret; + } /* Ensure device in active mode */ snd_soc_write(codec, DA7219_SYSTEM_ACTIVE, DA7219_SYSTEM_ACTIVE_MASK); @@ -1574,7 +1580,7 @@ static int da7219_handle_supplies(struct snd_soc_codec *codec) /* Update IO voltage level range */ snd_soc_write(codec, DA7219_IO_CTRL, io_voltage_lvl); - return ret; + return 0; } static void da7219_handle_pdata(struct snd_soc_codec *codec) -- 1.9.3

1 0

[alsa-devel] [PATCH v2 0/2] ASoC: add driver for Atmel I2S controller
by Cyrille Pitchen 05 Oct '15

05 Oct '15

This series of patches adds support to the new Atmel I2S controller embedded on sama5d2 SoCs. ChangeLog v2: - initialize dev->dev before calling dev->caps->mck_init(). Cyrille Pitchen (2): ASoC: atmel-i2s: add DT bindings for I2S controller ASoC: atmel-i2s: add driver for the new Atmel I2S controller .../devicetree/bindings/sound/atmel-i2s.txt | 43 ++ sound/soc/atmel/Kconfig | 10 + sound/soc/atmel/Makefile | 2 + sound/soc/atmel/atmel-i2s.c | 760 +++++++++++++++++++++ 4 files changed, 815 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/atmel-i2s.txt create mode 100644 sound/soc/atmel/atmel-i2s.c -- 1.8.2.2

2 3

[alsa-devel] Missing return check of of_property_read_*()
by Takashi Iwai 05 Oct '15

05 Oct '15

Hi, I hoped that I wouldn't need to write this kind of post, but since nothing happened so far, so here we go: The following compile warnings are present for quite some time. They are due to the lack of return check from of_property_read*(). sound/soc/codecs/cs35l32.c: In function ‘cs35l32_i2c_probe’: sound/soc/codecs/cs35l32.c:278:2: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] switch (val) { ^ sound/soc/codecs/cs35l32.c:272:15: note: ‘val’ was declared here unsigned int val; ^ sound/soc/sti/uniperif_player.c: In function ‘uni_player_init’: sound/soc/sti/uniperif_player.c:1006:6: warning: ‘mode’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (strcasecmp(mode, "hdmi") == 0) ^ sound/soc/sti/uniperif_player.c:985:14: note: ‘mode’ was declared here const char *mode; ^ Both should be trivial to fix, but I won't bother to fix these things by myself, as it results always in a matter of taste how to write. So, please fix them appropriately. Although not shown as compile warning like the above, lots of codec drivers have no return value checks from of_property_read*(), too. A quick grep reveals: % git grep -B1 '^[[:space:]]*of_property_read_' sound/soc sound/soc/codecs/adau1701.c- sound/soc/codecs/adau1701.c: of_property_read_u32(dev->of_node, "adi,pll-clkdiv", -- sound/soc/codecs/adau1701.c- sound/soc/codecs/adau1701.c: of_property_read_u8_array(dev->of_node, "adi,pin-config", -- sound/soc/codecs/cs35l32.c- sound/soc/codecs/cs35l32.c: of_property_read_u32(np, "cirrus,boost-manager", &val); -- sound/soc/codecs/cs35l32.c- sound/soc/codecs/cs35l32.c: of_property_read_u32(np, "cirrus,sdout-datacfg", &val); -- sound/soc/codecs/cs35l32.c- sound/soc/codecs/cs35l32.c: of_property_read_u32(np, "cirrus,battery-threshold", &val); -- sound/soc/codecs/cs35l32.c- sound/soc/codecs/cs35l32.c: of_property_read_u32(np, "cirrus,battery-recovery", &val); -- sound/soc/codecs/sta32x.c- sound/soc/codecs/sta32x.c: of_property_read_u8(np, "st,output-conf", sound/soc/codecs/sta32x.c- &pdata->output_conf); sound/soc/codecs/sta32x.c: of_property_read_u8(np, "st,ch1-output-mapping", sound/soc/codecs/sta32x.c- &pdata->ch1_output_mapping); sound/soc/codecs/sta32x.c: of_property_read_u8(np, "st,ch2-output-mapping", sound/soc/codecs/sta32x.c- &pdata->ch2_output_mapping); sound/soc/codecs/sta32x.c: of_property_read_u8(np, "st,ch3-output-mapping", -- sound/soc/codecs/sta32x.c- tmp = 140; sound/soc/codecs/sta32x.c: of_property_read_u16(np, "st,drop-compensation-ns", &tmp); -- sound/soc/codecs/sta350.c- sound/soc/codecs/sta350.c: of_property_read_u8(np, "st,output-conf", sound/soc/codecs/sta350.c- &pdata->output_conf); sound/soc/codecs/sta350.c: of_property_read_u8(np, "st,ch1-output-mapping", sound/soc/codecs/sta350.c- &pdata->ch1_output_mapping); sound/soc/codecs/sta350.c: of_property_read_u8(np, "st,ch2-output-mapping", sound/soc/codecs/sta350.c- &pdata->ch2_output_mapping); sound/soc/codecs/sta350.c: of_property_read_u8(np, "st,ch3-output-mapping", -- sound/soc/codecs/sta350.c- tmp = 140; sound/soc/codecs/sta350.c: of_property_read_u16(np, "st,drop-compensation-ns", &tmp); -- sound/soc/codecs/tas5086.c- sound/soc/codecs/tas5086.c: of_property_read_u32(of_node, "ti,charge-period", -- sound/soc/codecs/tlv320aic31xx.c- sound/soc/codecs/tlv320aic31xx.c: of_property_read_u32(np, "ai31xx-micbias-vg", &value); -- sound/soc/codecs/twl4030.c- sound/soc/codecs/twl4030.c: of_property_read_u32(node, "ti,digimic_delay", sound/soc/codecs/twl4030.c- &pdata->digimic_delay); sound/soc/codecs/twl4030.c: of_property_read_u32(node, "ti,ramp_delay_value", sound/soc/codecs/twl4030.c- &pdata->ramp_delay_value); sound/soc/codecs/twl4030.c: of_property_read_u32(node, "ti,offset_cncl_path", -- sound/soc/fsl/fsl_esai.c- esai_priv->synchronous = sound/soc/fsl/fsl_esai.c: of_property_read_bool(np, "fsl,esai-synchronous"); -- sound/soc/omap/omap-abe-twl6040.c- priv->jack_detection = of_property_read_bool(node, "ti,jack-detection"); sound/soc/omap/omap-abe-twl6040.c: of_property_read_u32(node, "ti,mclk-freq", &priv->mclk_freq); -- sound/soc/samsung/i2s.c- } sound/soc/samsung/i2s.c: of_property_read_string_index(dev->of_node, -- sound/soc/sh/rcar/rsrc-card.c- /* sampling rate convert */ sound/soc/sh/rcar/rsrc-card.c: of_property_read_u32(node, "convert-rate", &priv->convert_rate); -- sound/soc/sti/uniperif_player.c- sound/soc/sti/uniperif_player.c: of_property_read_u32(pnode, "version", &player->ver); -- sound/soc/sti/uniperif_player.c- sound/soc/sti/uniperif_player.c: of_property_read_u32(pnode, "uniperiph-id", &info->id); -- sound/soc/sti/uniperif_player.c- /* Read the device mode property */ sound/soc/sti/uniperif_player.c: of_property_read_string(pnode, "mode", &mode); -- sound/soc/sti/uniperif_reader.c- sound/soc/sti/uniperif_reader.c: of_property_read_u32(node, "version", &reader->ver); Many of them look really buggy (while some have the default value to fall back). And many codes have even no value checks. These should be fixed as well. thanks, Takashi

6 26

[alsa-devel] Fwd: Fwd: [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend)
by Christian Hartmann 05 Oct '15

05 Oct '15

Hi, this is a resend with all recipients in cc now ---------- Forwarded message ---------- From: Christian Hartmann <cornogle(a)googlemail.com> Date: 2015-08-28 9:41 GMT+02:00 Subject: Re: [alsa-devel] Fwd: [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend) To: Mark Brown <broonie(a)kernel.org> hi Mark et al., 2015-08-27 16:56 GMT+02:00 Mark Brown <broonie(a)kernel.org>: > I can't see how that would work, the interrupt output isn't a GPIO. yes I think also that this is the GPIO pin number. I am not familiar with the interrupt handling, have again to look (in other drivers or similar), to understand how things should work, never done that before. I have added three dev_info() into spi-pxa2xx pxa2xx_spi_probe() to found out more whats wrong with the slave/master: commit 4b6ff73610deef478e53b958a02617f024bbef22 Author: Christian Hartmann <cornogle(a)googlemail.com> Date: Thu Aug 27 14:51:48 2015 +0200 spi/spi-pxa2xx.c : added three new dev_infos, which prints irq, bus_num and num_chipselect Signed-off-by: Christian Hartmann <cornogle(a)googlemail.com> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 6d795a5..cf02094 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1389,6 +1389,9 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) master->unprepare_transfer_hardware = pxa2xx_spi_unprepare_transfer; master->auto_runtime_pm = true; + dev_info(&pdev->dev, "bus_num = %d\n",master->bus_num); + dev_info(&pdev->dev, "num_chipselect = %d\n",master->num_chipselect); + drv_data->ssp_type = ssp->type; drv_data->null_dma_buf = (u32 *)PTR_ALIGN(&drv_data[1], DMA_ALIGNMENT); @@ -1423,6 +1426,8 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) } + dev_info(&pdev->dev, "IRQ %d\n", ssp->irq); + /* Setup DMA if requested */ drv_data->tx_channel = -1; drv_data->rx_channel = -1; and thats what I got: [ 6.182903] pxa2xx-spi 80860F0E:00: bus_num = -1 [ 6.182909] pxa2xx-spi 80860F0E:00: num_chipselect = 2 [ 6.182928] pxa2xx-spi 80860F0E:00: IRQ 194 [ 6.183049] pxa2xx-spi 80860F0E:00: no DMA channels available, using PIO [ 6.183111] pxa2xx-spi 80860F0E:00: registered master spi32766 (dynamic) [ 6.192761] spi spi-WM510205:00: 8333333 Hz actual, PIO .... the rest of the dmesg is currently the same.... Q: this thread is about the patch for the pxa2xx-spi where the num_chipselect was raised by one to so that the slave connects here at all. otherwise the cs1 >= max will be hit. Do you think the bus_number is ok ? And shouldn't it be set the cs1=0 and num_chipselect=1 ?? The DSDT has wrongly SPI=1 as chipselect, either the firmware (DSDT) must be updated or a correct patch enables the spi master/slave init here. I hope or expect that when the spi slave will be init correctly, that the device would also work. The ACPI stuff is already done here, and I am running out of time. In the last resort I have to give up or have to do that at night :) cheers chris

2 9

[alsa-devel] Regarding ASoC: rt286: Fix the runtime error in the booting
by Axel Lin 05 Oct '15

05 Oct '15

Hi Order, I just notice your patch on the ML: http://mailman.alsa-project.org/pipermail/alsa-devel/2015-October/098390.ht… I didn't subscribe the ML and I'm not in CC so I cannot directly reply to you. I think you should make a copy of memory for index_cache rather than directly use the rt286_index_def if the index_cache is necessary. diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c index 1fbdb4f..210ab415 100644 --- a/sound/soc/codecs/rt286.c +++ b/sound/soc/codecs/rt286.c @@ -37,7 +37,7 @@ #define RT288_VENDOR_ID 0x10ec0288 struct rt286_priv { - const struct reg_default *index_cache; + struct reg_default *index_cache; int index_cache_size; struct regmap *regmap; struct snd_soc_codec *codec; @@ -1160,8 +1160,12 @@ static int rt286_i2c_probe(struct i2c_client *i2c, return -ENODEV; } - rt286->index_cache = rt286_index_def; rt286->index_cache_size = INDEX_CACHE_SIZE; + rt286->index_cache = devm_kmalloc(&i2c->dev, INDEX_CACHE_SIZE, + GFP_KERNEL); + if (!rt286->index_cache) + return -ENOMEM; + rt286->i2c = i2c; i2c_set_clientdata(i2c, rt286);

1 1

[alsa-devel] davinci_evm ocp:sound: ASoC: CPU DAI (null) not registered
by Rick Mann 05 Oct '15

05 Oct '15

I've been at this for weeks and I'm still unable to get linux to work correctly with my TI codec. This is on a Beaglebone Black running a 4.1.4 kernel (later versions are worse). I've tried multiple versions of the kernel trying to narrow it down. I keep coming back to 4.1.4 as the most recent that at least generates some audio clocks. The AM335x mcasp0 should be speaking i2s with the tlv320aic3104. I have my own build from source of the BBB 4.1.4-ti-r9 release (mainline plus TI plus Beaglebone stuff). I've sprinkled some logging around the audio drivers, but so far I don't see much, and I really don't understand how all the pieces fit together. One thing I found with my logging is the mcasp MCLK (AHCLKXDIV) is never set. I have logging calls in __davinci_mcasp_set_clkdiv() (sound/soc/davinci/davinci-mcasp.c), which is the only code I could find that sets the McASP clock, and it's never called. I tried to use devmem2 to read the registers in the SoC to see if they were set correctly, but I just get a bus error (other reads do work). Errors in dmesg when I load the device tree overlay for my cape suggest I still don't have something configured correctly (see below). I'd sure appreciate any insight into these latest issues. Thanks! Symptoms: MCLK should be 12 MHz, but is 24.00 MHz. Buffer underflows when running speaker-test. Errors to console upon loading cape: [ 38.502299] davinci_evm ocp:sound: ASoC: CPU DAI (null) not registered [ 38.517917] davinci_evm ocp:sound: snd_soc_register_card failed (-517) [ 38.530425] davinci_evm ocp:sound: ASoC: CPU DAI (null) not registered [ 38.536996] davinci_evm ocp:sound: snd_soc_register_card failed (-517) [ 38.564279] davinci_evm ocp:sound: ASoC: DAPM unknown pin MONO_LOUT dmesg upon loading cape overlay (https://github.com/JetForMe/podtique/blob/v1/bbb/cape/Podtique1/BB-ENABLE-P…): [ 568.323587] bone_capemgr bone_capemgr: part_number 'BB-ENABLE-PRU', version 'N/A' [ 568.323629] bone_capemgr bone_capemgr: slot #4: override [ 568.323646] bone_capemgr bone_capemgr: Using override eeprom data at slot 4 [ 568.323663] bone_capemgr bone_capemgr: slot #4: 'Override Board Name,00A0,Override Manuf,BB-ENABLE-PRU' [ 568.323804] bone_capemgr:capemgr_load_slot:1148: bone_capemgr bone_capemgr: slot #4: Requesting part number/version based 'BB-ENABLE-PRU-00A0.dtbo [ 568.323825] bone_capemgr:capemgr_load_slot:1162: bone_capemgr bone_capemgr: slot #4: Requesting firmware 'BB-ENABLE-PRU-00A0.dtbo' for board-name 'Override Board Name', version '00A0' [ 568.330369] bone_capemgr:capemgr_load_slot:1171: bone_capemgr bone_capemgr: slot #4: dtbo 'BB-ENABLE-PRU-00A0.dtbo' loaded; converting to live tree [ 568.341685] gpio-of-helper ocp:gpio_helper: ready [ 568.344695] bone_capemgr bone_capemgr: slot #4: dtbo 'BB-ENABLE-PRU-00A0.dtbo' loaded; overlay id #0 [ 568.387640] **** RLM davinci-evm.c:480: RLM: clock rate: 12000000 [ 568.387695] snd_soc_core:soc_bind_dai_link:938: davinci_evm ocp:sound: ASoC: binding TLV320AIC3X at idx 0 [ 568.387712] davinci_evm ocp:sound: ASoC: CPU DAI (null) not registered [ 568.394284] davinci_evm ocp:sound: snd_soc_register_card failed (-517) [ 568.410560] snd_soc_core:snd_soc_register_codec:3064: tlv320aic3x-codec 2-0018: codec register 2-0018 [ 568.410614] snd_soc_core:snd_soc_register_dais:2590: tlv320aic3x-codec 2-0018: ASoC: dai register 2-0018 #1 [ 568.410633] snd_soc_core:snd_soc_register_dais:2634: tlv320aic3x-codec 2-0018: ASoC: Registered DAI 'tlv320aic3x-hifi' [ 568.410653] snd_soc_core:snd_soc_register_codec:3138: tlv320aic3x-codec 2-0018: ASoC: Registered codec 'tlv320aic3x-codec.2-0018' [ 568.421529] **** RLM davinci-evm.c:480: RLM: clock rate: 12000000 [ 568.421588] snd_soc_core:soc_bind_dai_link:938: davinci_evm ocp:sound: ASoC: binding TLV320AIC3X at idx 0 [ 568.421605] davinci_evm ocp:sound: ASoC: CPU DAI (null) not registered [ 568.431455] **** RLM davinci-mcasp.c:1734: davinci_mcasp_probe [ 568.431507] base:of_property_match_string:1398: comparing tx with tx [ 568.431544] base:of_property_match_string:1398: comparing rx with tx [ 568.431555] base:of_property_match_string:1398: comparing rx with rx [ 568.431608] base:of_property_match_string:1398: comparing common with tx [ 568.431621] base:of_property_match_string:1398: comparing common with rx [ 568.431633] base:of_property_match_string:1398: comparing rx with tx [ 568.431643] base:of_property_match_string:1398: comparing rx with rx [ 568.434643] base:of_property_match_string:1398: comparing tx with tx [ 568.437971] davinci_evm ocp:sound: snd_soc_register_card failed (-517) [ 568.446651] snd_soc_core:snd_soc_register_dais:2590: davinci-mcasp 48038000.mcasp: ASoC: dai register 48038000.mcasp #1 [ 568.446682] snd_soc_core:snd_soc_register_dais:2634: davinci-mcasp 48038000.mcasp: ASoC: Registered DAI '48038000.mcasp' [ 568.446840] snd_soc_core:snd_soc_add_platform:2892: davinci-mcasp 48038000.mcasp: ASoC: Registered platform '48038000.mcasp' [ 568.450046] **** RLM davinci-evm.c:480: RLM: clock rate: 12000000 [ 568.450100] snd_soc_core:soc_bind_dai_link:938: davinci_evm ocp:sound: ASoC: binding TLV320AIC3X at idx 0 [ 568.450425] snd_soc_core:snd_soc_dapm_new_dai_widgets:3494: tlv320aic3x-codec 2-0018: ASoC: adding Playback widget [ 568.450448] snd_soc_core:snd_soc_dapm_new_dai_widgets:3513: tlv320aic3x-codec 2-0018: ASoC: adding Capture widget [ 568.450995] snd_soc_core:soc_probe_link_dais:1334: davinci_evm ocp:sound: ASoC: probe Podtique DaVinci EVM dai link 0 late -2 [ 568.451015] snd_soc_core:soc_probe_link_dais:1334: davinci_evm ocp:sound: ASoC: probe Podtique DaVinci EVM dai link 0 late -1 [ 568.451030] snd_soc_core:soc_probe_link_dais:1334: davinci_evm ocp:sound: ASoC: probe Podtique DaVinci EVM dai link 0 late 0 [ 568.451045] snd_soc_core:soc_probe_link_dais:1334: davinci_evm ocp:sound: ASoC: probe Podtique DaVinci EVM dai link 0 late 1 [ 568.451059] snd_soc_core:soc_probe_link_dais:1334: davinci_evm ocp:sound: ASoC: probe Podtique DaVinci EVM dai link 0 late 2 [ 568.451099] davinci_evm ocp:sound: ASoC: DAPM unknown pin MONO_LOUT [ 568.465530] snd_soc_core:soc_new_pcm:2510: davinci_evm ocp:sound: ASoC: registered pcm #0 AIC3X tlv320aic3x-hifi-0 [ 568.466155] davinci_evm ocp:sound: tlv320aic3x-hifi <-> 48038000.mcasp mapping ok [ 568.466185] snd_soc_core:snd_soc_dapm_link_dai_widgets:3570: tlv320aic3x-codec 2-0018: Right ADC -> Capture [ 568.466206] snd_soc_core:snd_soc_dapm_link_dai_widgets:3570: tlv320aic3x-codec 2-0018: Left ADC -> Capture [ 568.466226] snd_soc_core:snd_soc_dapm_link_dai_widgets:3570: tlv320aic3x-codec 2-0018: Playback -> Right DAC [ 568.466241] snd_soc_core:snd_soc_dapm_link_dai_widgets:3570: tlv320aic3x-codec 2-0018: Playback -> Left DAC upon starting speaker-test: [ 572.786071] snd_soc_core:soc_pcm_open:535: ASoC: tlv320aic3x-hifi <-> 48038000.mcasp info: [ 572.786103] snd_soc_core:soc_pcm_open:536: ASoC: rate mask 0x7fe [ 572.786114] snd_soc_core:soc_pcm_open:538: ASoC: min ch 2 max ch 2 [ 572.786126] snd_soc_core:soc_pcm_open:540: ASoC: min rate 8000 max rate 96000 [ 572.841514] davinci-mcasp 48038000.mcasp: Transmit buffer underflow ...repeated [ 574.087162] davinci-mcasp 48038000.mcasp: Transmit buffer underflow [ 579.135283] snd_soc_core:close_delayed_work:602: TLV320AIC3X: ASoC: pop wq checking: Playback status: inactive waiting: yes -- Rick Mann rmann(a)latencyzero.com

1 0