October 2014 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: rsnd: remove unsupported PAUSE flag
by Kuninori Morimoto 29 Oct '14

29 Oct '14

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> R-Car sound doesn't support PAUSE. Remove SNDRV_PCM_INFO_PAUSE flags from snd_pcm_hardware info Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 1922ec5..7004219 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -886,8 +886,7 @@ static int rsnd_dai_probe(struct platform_device *pdev, static struct snd_pcm_hardware rsnd_pcm_hardware = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_MMAP | - SNDRV_PCM_INFO_MMAP_VALID | - SNDRV_PCM_INFO_PAUSE, + SNDRV_PCM_INFO_MMAP_VALID, .buffer_bytes_max = 64 * 1024, .period_bytes_min = 32, .period_bytes_max = 8192, -- 1.7.9.5

2 1

[alsa-devel] [PATCH] ASoC: fsi: remove unsupported PAUSE flag
by Kuninori Morimoto 29 Oct '14

29 Oct '14

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> FSI doesn't support PAUSE. Remove SNDRV_PCM_INFO_PAUSE flags from snd_pcm_hardware info Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/fsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c index 66fddec..88e5df4 100644 --- a/sound/soc/sh/fsi.c +++ b/sound/soc/sh/fsi.c @@ -1711,8 +1711,7 @@ static const struct snd_soc_dai_ops fsi_dai_ops = { static struct snd_pcm_hardware fsi_pcm_hardware = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_MMAP | - SNDRV_PCM_INFO_MMAP_VALID | - SNDRV_PCM_INFO_PAUSE, + SNDRV_PCM_INFO_MMAP_VALID, .buffer_bytes_max = 64 * 1024, .period_bytes_min = 32, .period_bytes_max = 8192, -- 1.7.9.5

2 1

[alsa-devel] [PATCH] ASoC: rt5645:Mark RT5645_TDM_CTRL_3 as readable
by yang.a.fang＠intel.com 29 Oct '14

29 Oct '14

From: "Fang, Yang A" <yang.a.fang(a)intel.com> amixer query fails due to it is not readable reigster Signed-off-by: Fang, Yang A <yang.a.fang(a)intel.com> --- sound/soc/codecs/rt5645.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 3fb83bf..d16331e 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -139,6 +139,7 @@ static const struct reg_default rt5645_reg[] = { { 0x76, 0x000a }, { 0x77, 0x0c00 }, { 0x78, 0x0000 }, + { 0x79, 0x0123 }, { 0x80, 0x0000 }, { 0x81, 0x0000 }, { 0x82, 0x0000 }, @@ -334,6 +335,7 @@ static bool rt5645_readable_register(struct device *dev, unsigned int reg) case RT5645_DMIC_CTRL2: case RT5645_TDM_CTRL_1: case RT5645_TDM_CTRL_2: + case RT5645_TDM_CTRL_3: case RT5645_GLB_CLK: case RT5645_PLL_CTRL1: case RT5645_PLL_CTRL2: -- 1.7.9.5

3 2

[alsa-devel] [PATCH] ASoC: Intel: Add dependency on DesignWare DMA controller
by Mark Brown 29 Oct '14

29 Oct '14

We have calls into the controller so we need to ensure it is being built. Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/intel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 2a3af880868b..ae7f87221a3c 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -20,6 +20,7 @@ config SND_SOC_INTEL_SST tristate "ASoC support for Intel(R) Smart Sound Technology" select SND_SOC_INTEL_SST_ACPI if ACPI depends on (X86 || COMPILE_TEST) + depends on DW_DMAC_CORE help This adds support for Intel(R) Smart Sound Technology (SST). Say Y if you have such a device -- 2.1.1

1 0

[alsa-devel] - snd-usb-audio - SPDIF clock source mixer control for Digidesign Mbox
by Damien Zammit 29 Oct '14

29 Oct '14

Hi all, As some of you may remember, the Digidesign Mbox has a multiple endpoint interface and does not follow the standard USB audio spec. I am pretty sure that the first interface 0 is for firmware upgrades only, and the second interface has 2 endpoints one for playback and one for capture. I have heard that the SPDIF output is always on, but there is a special command to change the clock source to external sync with SPDIF. I think I have found the correct USB command for changing the clock source of the device to SPDIF external sync. I tried to use a pair of the devices in JACK using a pcm_multi configuration and syncing one of them to the other with a RCA cable, but unfortunately I get lots of XRUNs in JACK and I am wondering if there is a reason for this? Can someone who knows about the pcm_multi stuff shed some light on why I might be getting thousands of XRUNs when I use two identical USB soundcards that are (hopefully) synced to each other? I have written a non-standard mixer control for this so alsamixer can select the external clock source. Basically, the command to set SPDIF sync seems to include a sample rate command, but the sample rate is set to zero for SPDIF sync. Could JACK be resetting the sample rate and overriding my command perhaps? How would I override the ALSA driver code so that the sample rate is not reset by JACK to 48000 instead of 0 but only when the mixer control sets the flag? Damien

1 0

[alsa-devel] [PATCH] ASoC: rockchip-i2s: fix infinite loop in rockchip_snd_rxctrl
by Jianqun 29 Oct '14

29 Oct '14

We can get into an infinite loop if the I2S_CLR register fails to clear due to a missing break statement, so add that. Signed-off-by: Jianqun <jay.xu(a)rock-chips.com> --- sound/soc/rockchip/rockchip_i2s.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index f373e37..c74ba37 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -154,8 +154,10 @@ static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) while (val) { regmap_read(i2s->regmap, I2S_CLR, &val); retry--; - if (!retry) + if (!retry) { dev_warn(i2s->dev, "fail to clear\n"); + break; + } } } } -- 1.9.1

2 1

[alsa-devel] [PATCH 1/3] ASoC: sgtl5000: Use the preferred form for passing a size of a struct
by Fabio Estevam 29 Oct '14

29 Oct '14

From: Fabio Estevam <fabio.estevam(a)freescale.com> According to Documentation/CodingStyle - Chapter 14: "The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...); The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not." So do it as recommeded. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- sound/soc/codecs/sgtl5000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 6bb77d7..3f8c05b 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1419,8 +1419,7 @@ static int sgtl5000_i2c_probe(struct i2c_client *client, int ret, reg, rev; unsigned int mclk; - sgtl5000 = devm_kzalloc(&client->dev, sizeof(struct sgtl5000_priv), - GFP_KERNEL); + sgtl5000 = devm_kzalloc(&client->dev, sizeof(*sgtl5000), GFP_KERNEL); if (!sgtl5000) return -ENOMEM; -- 1.9.1

3 4

[alsa-devel] [PATCH - hda 1/1] Add ultra dock support for Thinkpad X240.
by Lukas Bossard 29 Oct '14

29 Oct '14

Adding ultra doch support for Lenovo Thinkpad X240 (17aa:2214). In the same process also rename ALC292_FIXUP_TPT440_DOCK to a more generic ALC292_FIXUP_LENOVO_ULTRA_DOCK Signed-off-by: Lukas Bossard <mr.bobukas(a)gmail.com> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 34b7bdb..693f083 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4212,7 +4212,7 @@ enum { ALC255_FIXUP_HEADSET_MODE, ALC255_FIXUP_HEADSET_MODE_NO_HP_MIC, ALC293_FIXUP_DELL1_MIC_NO_PRESENCE, - ALC292_FIXUP_TPT440_DOCK, + ALC292_FIXUP_LENOVO_ULTRA_DOCK, ALC283_FIXUP_BXBT2807_MIC, ALC255_FIXUP_DELL_WMI_MIC_MUTE_LED, ALC282_FIXUP_ASPIRE_V5_PINS, @@ -4640,7 +4640,7 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HEADSET_MODE }, - [ALC292_FIXUP_TPT440_DOCK] = { + [ALC292_FIXUP_LENOVO_ULTRA_DOCK] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { { 0x16, 0x21211010 }, /* dock headphone */ @@ -4799,16 +4799,17 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x21fb, "Thinkpad T430s", ALC269_FIXUP_LENOVO_DOCK), SND_PCI_QUIRK(0x17aa, 0x2203, "Thinkpad X230 Tablet", ALC269_FIXUP_LENOVO_DOCK), SND_PCI_QUIRK(0x17aa, 0x2208, "Thinkpad T431s", ALC269_FIXUP_LENOVO_DOCK), - SND_PCI_QUIRK(0x17aa, 0x220c, "Thinkpad T440s", ALC292_FIXUP_TPT440_DOCK), - SND_PCI_QUIRK(0x17aa, 0x220e, "Thinkpad T440p", ALC292_FIXUP_TPT440_DOCK), - SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_TPT440_DOCK), - SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_TPT440_DOCK), + SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_LENOVO_ULTRA_DOCK), + SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_LENOVO_ULTRA_DOCK), + SND_PCI_QUIRK(0x17aa, 0x220c, "Thinkpad T440s", ALC292_FIXUP_LENOVO_ULTRA_DOCK), + SND_PCI_QUIRK(0x17aa, 0x220e, "Thinkpad T440p", ALC292_FIXUP_LENOVO_ULTRA_DOCK), + SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_LENOVO_ULTRA_DOCK), SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP), SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x501a, "Thinkpad", ALC283_FIXUP_INT_MIC), - SND_PCI_QUIRK(0x17aa, 0x501e, "Thinkpad L440", ALC292_FIXUP_TPT440_DOCK), + SND_PCI_QUIRK(0x17aa, 0x501e, "Thinkpad L440", ALC292_FIXUP_LENOVO_ULTRA_DOCK), SND_PCI_QUIRK(0x17aa, 0x5026, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), @@ -4887,7 +4888,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {.id = ALC269_FIXUP_DELL2_MIC_NO_PRESENCE, .name = "dell-headset-dock"}, {.id = ALC283_FIXUP_CHROME_BOOK, .name = "alc283-dac-wcaps"}, {.id = ALC283_FIXUP_SENSE_COMBO_JACK, .name = "alc283-sense-combo"}, - {.id = ALC292_FIXUP_TPT440_DOCK, .name = "tpt440-dock"}, + {.id = ALC292_FIXUP_LENOVO_ULTRA_DOCK, .name = "lenovo-ultra-dock"}, {} }; -- 2.1.0

2 1

[alsa-devel] [PATCH 1/2] ALSA: doc: Add missing headers and compress stuff to alsa-driver-api.tmpl
by Takashi Iwai 29 Oct '14

29 Oct '14

Some header files have kereldoc comments but are not referred properly. Let's add them. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- Documentation/DocBook/alsa-driver-api.tmpl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/DocBook/alsa-driver-api.tmpl b/Documentation/DocBook/alsa-driver-api.tmpl index 0230a96f0564..13f8b241f042 100644 --- a/Documentation/DocBook/alsa-driver-api.tmpl +++ b/Documentation/DocBook/alsa-driver-api.tmpl @@ -57,6 +57,7 @@ !Esound/core/pcm.c !Esound/core/pcm_lib.c !Esound/core/pcm_native.c +!include/sound/pcm.h </sect1> <sect1><title>PCM Format Helpers</title> !Esound/core/pcm_misc.c @@ -64,6 +65,10 @@ <sect1><title>PCM Memory Management</title> !Esound/core/pcm_memory.c </sect1> + <sect1><title>PCM DMA Engine API</title> +!Esound/core/pcm_dmaengine.c +!Iinclude/sound/dmaengine_pcm.h + </sect1> </chapter> <chapter><title>Control/Mixer API</title> <sect1><title>General Control Interface</title> @@ -91,12 +96,19 @@ !Esound/core/info.c </sect1> </chapter> + <chapter><title>Compress Offload</title> + <sect1><title>Compress Offload API</title> +!Esound/core/compress_offload.c +!Iinclude/sound/compress_driver.h + </sect1> + </chapter> <chapter><title>Miscellaneous Functions</title> <sect1><title>Hardware-Dependent Devices API</title> !Esound/core/hwdep.c </sect1> <sect1><title>Jack Abstraction Layer API</title> !Esound/core/jack.c +!Iinclude/sound/jack.h </sect1> <sect1><title>ISA DMA Helpers</title> !Esound/core/isadma.c -- 2.1.2

2 3

[alsa-devel] [PATCH 0/3] documentation fixes
by Takashi Iwai 29 Oct '14

29 Oct '14

Hi, here is a few more minor fixes for kerneldoc comments. Per request from Vinod, uapid/sound/compress_*.h are included, too. [PATCH 1/3] ALSA: doc: Fix enum snd_jack_types comments [PATCH 2/3] ALSA: doc: Fix uapi/sound/compress_offload.h kerneldoc [PATCH 3/3] ALSA: doc: Include uapi/sound/compress_*.h, too Takashi

1 3