November 2010 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: atmel: test wrong variable
by Vasiliy Kulikov 22 Nov '10

22 Nov '10

After clk_get() mclk is checked second time instead of pllb check. Signed-off-by: Vasiliy Kulikov <segoon(a)openwall.com> --- Cannot compile this driver, so it is not tested. sound/soc/atmel/sam9g20_wm8731.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c index da9c303..68072a2 100644 --- a/sound/soc/atmel/sam9g20_wm8731.c +++ b/sound/soc/atmel/sam9g20_wm8731.c @@ -223,7 +223,7 @@ static int __init at91sam9g20ek_init(void) } pllb = clk_get(NULL, "pllb"); - if (IS_ERR(mclk)) { + if (IS_ERR(pllb)) { printk(KERN_ERR "ASoC: Failed to get PLLB\n"); ret = PTR_ERR(mclk); goto err_mclk; -- 1.7.0.4

5 5

[alsa-devel] [PATCH] ASoC: Fix multi-component mismerge in WM8523
by Mark Brown 22 Nov '10

22 Nov '10

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8523.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/wm8523.c b/sound/soc/codecs/wm8523.c index d331888..bf44ec7 100644 --- a/sound/soc/codecs/wm8523.c +++ b/sound/soc/codecs/wm8523.c @@ -147,7 +147,6 @@ static int wm8523_startup(struct snd_pcm_substream *substream, return -EINVAL; } - return 0; snd_pcm_hw_constraint_list(substream->runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &wm8523->rate_constraint); -- 1.7.1

2 1

[alsa-devel] [PATCH] cm6206: turn off de-emphasis in s/pdif
by Eric Lammerts 22 Nov '10

22 Nov '10

Hi, I just bought a device with a CM6206. Thank you for the quirk that made it work out-of-the-box! I noticed on my DAC that the de-emphasis LED was on. Is this by accident? Below is a patch (based on the info in the CM6206+datasheet+1.7.pdf that I found somewhere) that turns it off. cheers, Eric Index: linux-2.6.36/sound/usb/quirks.c =================================================================== --- linux-2.6.36.orig/sound/usb/quirks.c 2010-11-16 18:55:51.000000000 -0500 +++ linux-2.6.36/sound/usb/quirks.c 2010-11-16 18:55:57.000000000 -0500 @@ -387,7 +387,7 @@ static int snd_usb_cm6206_boot_quirk(struct usb_device *dev) { int err, reg; - int val[] = {0x200c, 0x3000, 0xf800, 0x143f, 0x0000, 0x3000}; + int val[] = {0x2004, 0x3000, 0xf800, 0x143f, 0x0000, 0x3000}; for (reg = 0; reg < ARRAY_SIZE(val); reg++) { err = snd_usb_cm106_write_int_reg(dev, reg, val[reg]);

4 6

Re: [alsa-devel] [PATCH] jack: use eventfd which never blocks.
by Alexander E. Patrakov 22 Nov '10

22 Nov '10

torbenh wrote: > i think in the case of mmap, there are one byte written -> advance one > period rules. these promises are not kept, when the write end is made > non-blocking. I was not aware of such rules. So, please disregard my review. -- Alexander E. Patrakov

2 1

[alsa-devel] [PATCH] Enable jack sense for Thinkpad Edge 11
by Manoj Iyer 22 Nov '10

22 Nov '10

This patch enables audio play back from external headphones on Thinkpad Edge 11. The following changes since commit 0c1c062266ecfeaebadadb780020a422f829284f: Manoj Iyer (1): Enable jack sense for Thinkpad Edge 11 are available in the git repository at: git://kernel.ubuntu.com/git/manjo/linux-2.6.git thinpad11

2 3

[alsa-devel] [PATCH 1/4] ASoC: Fix compile breakage in jz4740.c and smartq_wm8987.c
by Jarkko Nikula 22 Nov '10

22 Nov '10

Commit ce6120c require that soc-dapm.h cannot be included before soc.h but these two drivers were not checked. Fix them by including only soc.h as it includes soc-dapm.h. Signed-off-by: Jarkko Nikula <jhnikula(a)gmail.com> --- sound/soc/codecs/jz4740.c | 1 - sound/soc/s3c24xx/smartq_wm8987.c | 2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/jz4740.c b/sound/soc/codecs/jz4740.c index 8a45562..f7cd346 100644 --- a/sound/soc/codecs/jz4740.c +++ b/sound/soc/codecs/jz4740.c @@ -22,7 +22,6 @@ #include <sound/pcm.h> #include <sound/pcm_params.h> #include <sound/initval.h> -#include <sound/soc-dapm.h> #include <sound/soc.h> #define JZ4740_REG_CODEC_1 0x0 diff --git a/sound/soc/s3c24xx/smartq_wm8987.c b/sound/soc/s3c24xx/smartq_wm8987.c index 1f6da1e..5b07bb9 100644 --- a/sound/soc/s3c24xx/smartq_wm8987.c +++ b/sound/soc/s3c24xx/smartq_wm8987.c @@ -19,7 +19,7 @@ #include <sound/pcm.h> #include <sound/pcm_params.h> -#include <sound/soc-dapm.h> +#include <sound/soc.h> #include <sound/jack.h> #include <asm/mach-types.h> -- 1.7.0.4

3 5

[alsa-devel] [PATCH 0/5] [RFC]intel_hdmi_audio driver
by Babu, Ramesh 22 Nov '10

22 Nov '10

Hi Following emails are series of 5 patches for Intel MID HDMI audio driver. This driver is for the HDMI audio controller in upcoming Mobile Internet Devices (MID) platform from Intel. HDMI Audio Driver supports HDMI audio playback through ALSA interfaces. It interacts with the display driver to program the HDMI audio subsystem in the HDMI controller and receive hot plug/unplug events and DMA completion interrupts. HDMI audio driver is dependent on platform display driver. The dependant drivers for the platform are not yet available in the upstream. So please consider these patches only for RFC and provide your comments/suggestions. The patches are compiled with 0 warnings and checkpatch.pl The rest of the patches that follow have a brief description about the contents. Thanks Ramesh and Sailaja

1 0

[alsa-devel] [PATCH 0/5] [RFC]intel_hdmi_audio driver
by Babu, Ramesh 22 Nov '10

22 Nov '10

Hi Following emails are series of 5 patches for Intel MID HDMI audio driver. This driver is for the HDMI audio controller in upcoming Mobile Internet Devices (MID) platform from Intel. HDMI Audio Driver supports HDMI audio playback through ALSA interfaces. It interacts with the display driver to program the HDMI audio subsystem in the HDMI controller and receive hot plug/unplug events and DMA completion interrupts. HDMI audio driver is dependent on platform display driver. The dependant drivers for the platform are not yet available in the upstream. So please consider these patches only for RFC and provide your comments/suggestions. The patches are compiled with 0 warnings and checkpatch.pl The rest of the patches that follow have a brief description about the contents. Thanks Ramesh and Sailaja

1 0

[alsa-devel] [PATCH] ASoC: RX1950: Fix hw_params function
by Vasily Khoruzhick 22 Nov '10

22 Nov '10

Unfortunatelly, I misunderstood datasheet, and on s3c244x-iis when MPLLin source for master clock is selected, prescaler has no effect. Remove dividor calculation for 44100 rate; remove 88200 rate at all, rx1950 can't do it. Signed-off-by: Vasily Khoruzhick <anarsoul(a)gmail.com> --- sound/soc/s3c24xx/rx1950_uda1380.c | 20 +++----------------- 1 files changed, 3 insertions(+), 17 deletions(-) diff --git a/sound/soc/s3c24xx/rx1950_uda1380.c b/sound/soc/s3c24xx/rx1950_uda1380.c index ffd5cf2..468cc11 100644 --- a/sound/soc/s3c24xx/rx1950_uda1380.c +++ b/sound/soc/s3c24xx/rx1950_uda1380.c @@ -50,7 +50,6 @@ static unsigned int rates[] = { 16000, 44100, 48000, - 88200, }; static struct snd_pcm_hw_constraint_list hw_rates = { @@ -130,7 +129,6 @@ static const struct snd_soc_dapm_route audio_map[] = { }; static struct platform_device *s3c24xx_snd_device; -static struct clk *xtal; static int rx1950_startup(struct snd_pcm_substream *substream) { @@ -179,10 +177,8 @@ static int rx1950_hw_params(struct snd_pcm_substream *substream, case 44100: case 88200: clk_source = S3C24XX_CLKSRC_MPLL; - fs_mode = S3C2410_IISMOD_256FS; - div = clk_get_rate(xtal) / (256 * rate); - if (clk_get_rate(xtal) % (256 * rate) > (128 * rate)) - div++; + fs_mode = S3C2410_IISMOD_384FS; + div = 1; break; default: printk(KERN_ERR "%s: rate %d is not supported\n", @@ -210,7 +206,7 @@ static int rx1950_hw_params(struct snd_pcm_substream *substream, /* set MCLK division for sample rate */ ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_MCLK, - S3C2410_IISMOD_384FS); + fs_mode); if (ret < 0) return ret; @@ -295,17 +291,8 @@ static int __init rx1950_init(void) goto err_plat_add; } - xtal = clk_get(&s3c24xx_snd_device->dev, "xtal"); - - if (IS_ERR(xtal)) { - ret = PTR_ERR(xtal); - platform_device_unregister(s3c24xx_snd_device); - goto err_clk; - } - return 0; -err_clk: err_plat_add: err_plat_alloc: err_gpio_conf: @@ -320,7 +307,6 @@ static void __exit rx1950_exit(void) platform_device_unregister(s3c24xx_snd_device); snd_soc_jack_free_gpios(&hp_jack, ARRAY_SIZE(hp_jack_gpios), hp_jack_gpios); - clk_put(xtal); gpio_free(S3C2410_GPA(1)); } -- 1.7.3.2

3 5

Re: [alsa-devel] [PATCH] Acer 7730G support update.
by Takashi Iwai 22 Nov '10

22 Nov '10

At Mon, 8 Nov 2010 00:01:45 +0300, Denis Kup wrote: > > [1 <multipart/alternative (7bit)>] > [1.1 <text/plain; ISO-8859-1 (7bit)>] > Hello! > > I want to commit patch that fix no-sound on acer 7730G laptop. All work > history you can see here > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 . > This patch for the latest snapshot, where this changes have been made: > http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 . > > Acer 7730G support patch. > > Changes: > 1) Fixes automatic EAPD configuration on Acer 7730G laptop. > > Denis Kuplyakov <dener.kup(a)gmail.com> > 8.11.10 00:00:50 [Sorry for the late reply - the mail was stuck in my output queue without triggering for weeks!] Thanks for the patch. Unfortunately, your patch isn't applicable as is to the latest code. The patch gives fuzz and errors. Could you rebase your patch to the latest 2.6.37-rc kernel code? Also, don't forget to give your sign-off. It's simply a line like Signed-off-by: Foo Bar <foo(a)bar.com> thanks, Takashi

2 4