November 2010 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH] Acer 7730G support update.
by Denis Kup 24 Nov '10

24 Nov '10

Yes it is 70 MB in archived state and 266.6 when decompressed. After decompressing i have such folders in linux-2.6.37-rc3: drivers Documentation crypto block arch I have used find tool to locate sound folder and I have found it only in documentation. 2010/11/22 Takashi Iwai <tiwai(a)suse.de>: > At Mon, 22 Nov 2010 17:46:31 +0300, > Denis Kup wrote: >> >> There is no such directory in archive. > > You must be kidding. Double-check you downloaded the whole file. > It's 70M big in the compressed form. > > > Takashi > > >> 2010/11/22 Takashi Iwai <tiwai(a)suse.de>: >> > At Mon, 22 Nov 2010 15:40:31 +0300, >> > Denis Kup wrote: >> >> >> >> I can't find patch_realtek.c in this archive. Where should it be situated? >> > >> > It's in sound/pci/hda/patch_realtek.c. >> > >> > >> > Takashi >> > >> > >> >> 2010/11/22 Takashi Iwai <tiwai(a)suse.de>: >> >> > At Mon, 22 Nov 2010 15:24:16 +0300, >> >> > Denis Kup wrote: >> >> >> >> >> >> Do you mean that? >> >> >> http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2 >> >> > >> >> > Yes. >> >> > >> >> > >> >> > Takashi >> >> > >> >> >> 2010/11/22 Takashi Iwai <tiwai(a)suse.de>: >> >> >> > At Mon, 22 Nov 2010 13:51:45 +0300, >> >> >> > Denis Kup wrote: >> >> >> >> >> >> >> >> 2010/11/22 Takashi Iwai <tiwai(a)suse.de>: >> >> >> >> > At Mon, 8 Nov 2010 00:01:45 +0300, >> >> >> >> > Denis Kup wrote: >> >> >> >> >> >> >> >> >> >> [1 <multipart/alternative (7bit)>] >> >> >> >> >> [1.1 <text/plain; ISO-8859-1 (7bit)>] >> >> >> >> >> Hello! >> >> >> >> >> >> >> >> >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work >> >> >> >> >> history you can see here >> >> >> >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 . >> >> >> >> >> This patch for the latest snapshot, where this changes have been made: >> >> >> >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 . >> >> >> >> >> >> >> >> >> >> Acer 7730G support patch. >> >> >> >> >> >> >> >> >> >> Changes: >> >> >> >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop. >> >> >> >> >> >> >> >> >> >> Denis Kuplyakov <dener.kup(a)gmail.com> >> >> >> >> >> 8.11.10 00:00:50 >> >> >> >> > >> >> >> >> > [Sorry for the late reply - the mail was stuck in my output queue >> >> >> >> > without triggering for weeks!] >> >> >> >> > >> >> >> >> > Thanks for the patch. >> >> >> >> > Unfortunately, your patch isn't applicable as is to the latest code. >> >> >> >> > The patch gives fuzz and errors. >> >> >> >> > >> >> >> >> > Could you rebase your patch to the latest 2.6.37-rc kernel code? >> >> >> >> > >> >> >> >> > Also, don't forget to give your sign-off. It's simply a line like >> >> >> >> > Signed-off-by: Foo Bar <foo(a)bar.com> >> >> >> >> > >> >> >> >> > >> >> >> >> > thanks, >> >> >> >> > >> >> >> >> > Takashi >> >> >> >> > >> >> >> >> >> >> >> >> Can you send me a link to the latest version, that should I patch. >> >> >> > >> >> >> > It's Linus tree, e.g. 2.6.37-rc3 should suffice. >> >> >> > >> >> >> > >> >> >> > Takashi >> >> >> > >> >> >> >> >> > >> >> >> > >> >

2 5

[alsa-devel] ALSA throwing buffers away?
by Radivoje Jovanovic 23 Nov '10

23 Nov '10

Hello, I am developing driver for a really simple hardware. Hardware has codec that supports mono/stereo and the amplifier that supports only one speaker so the driver has to be mono driver and the codec is setup to manage mono data. I have setup ALSA with following parameters: .info = (SNDRV_PCM_INFO_NONINTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME), .formats = SNDRV_PCM_FMTBIT_U16_LE | SNDRV_PCM_FMTBIT_U16_BE | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_U8, .channels_min = 1, .channels_max = 1, Initially I was happy since sound started playing right away, but I noticed that songs are skipping. I created buffers that collect statistics about playback which is printed at the STOP trigger. The hardware is going through ALSA circular buffer correctly, and ALSA is filling the buffer as the hardware progresses, but after each buffer iteration ALSA skips the buffer length of the data?! For example: If buffer is .5 Mb ALSA will fill first .5Mb from the file into the buffer. As the hardware is playing the sound ALSA fills the buffer starting 1.0 Mb away from the begining of the file (the data from .5-1.0 Mb never makes it to the buffer). This pattern repeats constantly to the end of the song. I have tried SNDRV_PCM_INFO_INTERLEAVED with the same results (in this case ALSA will not even try to play stereo files using my mono driver). The files I tested are stereo and mono and they all behave the same. I am collecting ALSA info in the snd_pcm_lib_write1 method in the pcm_lib.c file. I was wondering if ALSA maybe deals with two circular buffers in the same time, or if anybody has an idea what is going on here? ~cheers, Ogi

2 4

[alsa-devel] [PATCH] ASoC: s3c24xx: test wrong variable
by Vasiliy Kulikov 23 Nov '10

23 Nov '10

After clk_get() mclk is checked three times instead of mout_epll and sclk_spdif checks. Signed-off-by: Vasiliy Kulikov <segoon(a)openwall.com> --- Cannot compile this driver, so it is not tested. sound/soc/s3c24xx/smdk_spdif.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/s3c24xx/smdk_spdif.c b/sound/soc/s3c24xx/smdk_spdif.c index 11c88b1..761e02b 100644 --- a/sound/soc/s3c24xx/smdk_spdif.c +++ b/sound/soc/s3c24xx/smdk_spdif.c @@ -38,7 +38,7 @@ static int set_audio_clock_heirachy(struct platform_device *pdev) } mout_epll = clk_get(NULL, "mout_epll"); - if (IS_ERR(fout_epll)) { + if (IS_ERR(mout_epll)) { printk(KERN_WARNING "%s: Cannot find mout_epll.\n", __func__); ret = -EINVAL; @@ -54,7 +54,7 @@ static int set_audio_clock_heirachy(struct platform_device *pdev) } sclk_spdif = clk_get(NULL, "sclk_spdif"); - if (IS_ERR(fout_epll)) { + if (IS_ERR(sclk_spdif)) { printk(KERN_WARNING "%s: Cannot find sclk_spdif.\n", __func__); ret = -EINVAL; -- 1.7.0.4

4 4

[alsa-devel] [PATCH] alsa: support module on-demand loading for seq and timer
by Kay Sievers 23 Nov '10

23 Nov '10

From: Kay Sievers <kay.sievers(a)vrfy.org> Subject: alsa: support module on-demand loading for seq and timer If CONFIG_SND_DYNAMIC_MINORS is used, assign /dev/snd/seq and /dev/snd/timer the usual static minors, and export specific module aliases to generate udev module on-demand loading instructions: $ cat /lib/modules/$(uname -r)/modules.devname # Device nodes to trigger on-demand module loading. microcode cpu/microcode c10:184 fuse fuse c10:229 ppp_generic ppp c108:0 tun net/tun c10:200 uinput uinput c10:223 dm_mod mapper/control c10:236 snd_timer snd/timer c116:33 snd_seq snd/seq c116:1 The last two lines instruct udev to create device nodes, even when the modules are not loaded at that time. As soon as userspace accesses any of these nodes, the in-kernel module-loader will load the module, and the device can be used. The header file minor calculation needed to be simplified to make __stringify() (supports only two indirections) in the MODULE_ALIAS macro work. This is part of systemd's effort to get rid of unconditional module load instructions and needless init scripts. Cc: Lennart Poettering <lennart(a)poettering.net> Signed-off-by: Kay Sievers <kay.sievers(a)vrfy.org> --- diff --git a/include/sound/minors.h b/include/sound/minors.h index a81798a..8f76420 100644 --- a/include/sound/minors.h +++ b/include/sound/minors.h @@ -31,8 +31,8 @@ /* these minors can still be used for autoloading devices (/dev/aload*) */ #define SNDRV_MINOR_CONTROL 0 /* 0 */ #define SNDRV_MINOR_GLOBAL 1 /* 1 */ -#define SNDRV_MINOR_SEQUENCER (SNDRV_MINOR_GLOBAL + 0 * 32) -#define SNDRV_MINOR_TIMER (SNDRV_MINOR_GLOBAL + 1 * 32) +#define SNDRV_MINOR_SEQUENCER 1 /* SNDRV_MINOR_GLOBAL + 0 * 32 */ +#define SNDRV_MINOR_TIMER 33 /* SNDRV_MINOR_GLOBAL + 1 * 32 */ #ifndef CONFIG_SND_DYNAMIC_MINORS /* 2 - 3 (reserved) */ diff --git a/sound/core/seq/seq.c b/sound/core/seq/seq.c index bf09a5a..119fddb6 100644 --- a/sound/core/seq/seq.c +++ b/sound/core/seq/seq.c @@ -32,6 +32,7 @@ #include "seq_timer.h" #include "seq_system.h" #include "seq_info.h" +#include <sound/minors.h> #include <sound/seq_device.h> #if defined(CONFIG_SND_SEQ_DUMMY_MODULE) @@ -73,6 +74,9 @@ MODULE_PARM_DESC(seq_default_timer_subdevice, "The default timer subdevice numbe module_param(seq_default_timer_resolution, int, 0644); MODULE_PARM_DESC(seq_default_timer_resolution, "The default timer resolution in Hz."); +MODULE_ALIAS_CHARDEV(CONFIG_SND_MAJOR, SNDRV_MINOR_SEQUENCER); +MODULE_ALIAS("devname:snd/seq"); + /* * INIT PART */ diff --git a/sound/core/sound.c b/sound/core/sound.c index 66691fe..1c7a3ef 100644 --- a/sound/core/sound.c +++ b/sound/core/sound.c @@ -188,14 +188,22 @@ static const struct file_operations snd_fops = }; #ifdef CONFIG_SND_DYNAMIC_MINORS -static int snd_find_free_minor(void) +static int snd_find_free_minor(int type) { int minor; + /* static minors for module auto loading */ + if (type == SNDRV_DEVICE_TYPE_SEQUENCER) + return SNDRV_MINOR_SEQUENCER; + if (type == SNDRV_DEVICE_TYPE_TIMER) + return SNDRV_MINOR_TIMER; + for (minor = 0; minor < ARRAY_SIZE(snd_minors); ++minor) { - /* skip minors still used statically for autoloading devices */ - if (SNDRV_MINOR_DEVICE(minor) == SNDRV_MINOR_CONTROL || - minor == SNDRV_MINOR_SEQUENCER) + /* skip static minors still used for module auto loading */ + if (SNDRV_MINOR_DEVICE(minor) == SNDRV_MINOR_CONTROL) + continue; + if (minor == SNDRV_MINOR_SEQUENCER || + minor == SNDRV_MINOR_TIMER) continue; if (!snd_minors[minor]) return minor; @@ -269,7 +277,7 @@ int snd_register_device_for_dev(int type, struct snd_card *card, int dev, preg->private_data = private_data; mutex_lock(&sound_mutex); #ifdef CONFIG_SND_DYNAMIC_MINORS - minor = snd_find_free_minor(); + minor = snd_find_free_minor(type); #else minor = snd_kernel_minor(type, card, dev); if (minor >= 0 && snd_minors[minor]) diff --git a/sound/core/timer.c b/sound/core/timer.c index 13afb60..17df52a 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -52,6 +52,9 @@ MODULE_PARM_DESC(timer_limit, "Maximum global timers in system."); module_param(timer_tstamp_monotonic, int, 0444); MODULE_PARM_DESC(timer_tstamp_monotonic, "Use posix monotonic clock source for timestamps (default)."); +MODULE_ALIAS_CHARDEV(CONFIG_SND_MAJOR, SNDRV_MINOR_TIMER); +MODULE_ALIAS("devname:snd/timer"); + struct snd_timer_user { struct snd_timer_instance *timeri; int tread; /* enhanced read with timestamps and events */

2 4

[alsa-devel] [PATCH] MPC5200: Eliminate duplicate include of of_device.h
by Jesper Juhl 23 Nov '10

23 Nov '10

Eliminate duplicate #include <linux/of_device.h> from sound/soc/fsl/mpc5200_dma.c Signed-off-by: Jesper Juhl <jj(a)chaosbits.net> --- mpc5200_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c index dce6b55..f92dca0 100644 --- a/sound/soc/fsl/mpc5200_dma.c +++ b/sound/soc/fsl/mpc5200_dma.c @@ -9,7 +9,6 @@ #include <linux/module.h> #include <linux/of_device.h> #include <linux/slab.h> -#include <linux/of_device.h> #include <linux/of_platform.h> #include <sound/soc.h> -- Jesper Juhl <jj(a)chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.

2 1

[alsa-devel] Writing a driver for Sound Card
by Ramya Desai 23 Nov '10

23 Nov '10

Dear All, I am new to this Advanced Linux Sound Architecture (ALSA) driver. I developed a few drivers in Linux kernel environment for PCI based devices which are of type character and block. I am going through the following link for writing a driver for my custom sound card. http://www.kernel.org/pub/linux/kernel/people/tiwai/docs/writing-an-alsa-dr… I have a doubt about the Linux sound driver architecture. I need to develop the driver with mixer, player, recorder, MIDI etc. components. Do I need to develop these components in single driver OR Do I need to develop as a individual component (one driver for one component). I looked into the /usr/src/linux-2.6.35/sound directory. I did not understand it completely. Is there any driver (sample) which I can go through? Please let me know. Any help greatly appreciated and helpful to me. Thanks and Regards, Srinivas G

2 1

[alsa-devel] [PATCHv3] ASoC: Overhaul Samsung drivers
by Jassi Brar 23 Nov '10

23 Nov '10

From: Jassi Brar <jassi.brar(a)samsung.com> Hi, Submitting revised patch series. Since v2: a) Divided 'ASoC Samsung Add common I2S driver' into two. b) 'ARM Samsung Rename s3c64xx I2S platform device' based on plat tree As Kgene agreed to prepare a branch for Mark, platform related changes are based on his tree wherever possible. Patches for Kgene will be posted on Arm-Linux ml and those for Mark Brown, on ALSA ml, now that people have already 'seen' two versions of the patch series with same code but different segregation. Here is overview of patches:- For Kgene:- ************ S5PV310: DMA: Add platform devices for PL330 DMACs ARM: Samsung: Rename s3c64xx I2S platform device ARM: Samsung: Prepare audio header for new I2S driver ARM: S3C64XX: I2S: Upgrade platform device ARM: S5P64X0: I2S: Upgrade platform device ARM: S5P6442: I2S: Upgrade platform device ARM: S5PC100: I2S: Upgrade platform device ARM: S5PV210: I2S: Upgrade platform device ARM: S5PV310: Add audio platform devices For Mark :- *********** ASoC: Samsung: Remove redundant AQUILA driver ASoC: Samsung: Rename DMA device ARM: Samsung: Define common audio-dma device ASoC: Samsung: Rename ASoC DMA driver ASoC: Samsung: Rename AC97 platform device ASoC: Samsung: Rename AC97 driver ASoC: Samsung: Rename PCM driver ASoC: Samsung: Generalize DMA driver namespace ASoC: Samsung: Rename s3c64xx I2S device ASoC: Samsung: Add common I2S driver ASoC: SMARTQ: Move to use new I2S driver ASoC: GONI: Move to use new I2S driver ASoC: SMDK64XX: Move to use new I2S driver ASoC: S3C64XX: Remove obsoleted I2S drivers ASoC: SMDK64XX: Rename for other platforms ASoC: SMDK_WM8580: Enable for SMDKC100 ASoC: Samsung: Generalize Kconfig symbols ASoC: Samsung: Rename from s3c24xx to samsung Thanks. ************************************************* Since v1: a) Use case 16 in set_bfs and default for error b) Better code comments. c) Use switch case in i2sv2_i2s_set_clkdiv d) Use SNDRV_PCM_RATE_8000_96000 e) MAX_I2S -> SAMSUNG_I2S_SECOFF f) Local namespace cleanup with i2s driver. ------------ Here come patches overhauling the Samsung ASoC support. The AC97, PCM, SPDIF and ASoC-DMA related code has merely undergone cosmetic changes - symbol, device & driver renaming and file moving. A new I2S controller driver has been added to manage Samsung SoCs since S3C64XX. Older driver has been changed only as is necessary. Regarding I2S, I have left the s3c24xx series untouched because the controllers are too different to run by a common driver. S3C2412's I2S does have some similarities, but not important enough to warrant impact on new driver design. The new I2S driver has been designed around the notion of features/quirks. The newer SoCs have revised version of I2S_0(usually) than previous ones. So, I2S block is 'specified' in the platform code and the driver works on that configuration. For now, Secondary I2S DAI works only with System-DMAC. I2S-Internal DMA and SRAM will be enabled later. Testing:- Simple testing of 5.1 channel and hardware mixing seems to work (though there seems to be some issue with symmetric_rates in soc-core.c which would be tried to fix later as saperate issue). I would appreciate any test-results for GONI and SMARTQ. I suggest the patches 13,14,16 & 17 go via Kgene's Tree, and the rest via ASoC tree due to tight dependencies. 1). ASoC: Samsung: Remove redundant AQUILA driver 2). ASoC: Samsung: Rename DMA device 3). ARM: Samsung: Define common audio-dma device 4). ASoC: Samsung: Rename ASoC DMA driver 5). ASoC: Samsung: Rename AC97 platform device 6). ASoC: Samsung: Rename AC97 driver 7). ASoC: Samsung: Rename PCM driver 8). ASoC: Samsung: Generalize DMA driver namespace 9). ASoC: Samsung: Rename s3c64xx I2S device 10). ASoC: Samsung: Add common I2S driver 11). ARM: S3C64XX: I2S: Upgrade platform device 12). ARM: S5P6440: I2S: Upgrade platform device 13). ARM: S5P6442: I2S: Upgrade platform device 14). ARM: S5PC100: I2S: Upgrade platform device 15). ARM: S5PV210: I2S: Upgrade platform device 16). ARM: S5PV310: Add audio platform devices 17). ASoC: SMARTQ: Move to use new I2S driver 18). ASoC: GONI: Move to use new I2S driver 19). ASoC: SMDK64XX: Move to use new I2S driver 20). ASoC: S3C64XX: Remove obsoleted I2S drivers 21). ASoC: SMDK64XX: Rename for other platforms 22). ASoC: SMDK_WM8580: Enable for SMDKC100 23). ASoC: Samsung: Generalize Kconfig symbols 24). ASoC: Samsung: Rename from s3c24xx to samsung

3 45

[alsa-devel] [patch] pcm: add MMAP_EMUL to type names
by Dan Carpenter 23 Nov '10

23 Nov '10

If we try to print this then it causes a read past the end of the array in snd_pcm_type_name(). diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c index 7409943..906b502 100644 --- a/src/pcm/pcm.c +++ b/src/pcm/pcm.c @@ -1633,6 +1633,7 @@ static const char *const snd_pcm_type_names[] = { PCMTYPE(SOFTVOL), PCMTYPE(IOPLUG), PCMTYPE(EXTPLUG), + PCMTYPE(MMAP_EMUL), }; static const char *const snd_pcm_subformat_names[] = {

2 1

[alsa-devel] [GIT PULL] ASoC updates for 2.6.38
by Liam Girdwood 23 Nov '10

23 Nov '10

Some updates for 2.6.38 too :- The following changes since commit 33ee617f4dad370bee016e4462e69481257453b0: Merge remote branch 'tiwai/topic/asoc' into for-2.6.38 (2010-11-03 14:18:42 +0000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lrg/asoc-2.6.git for-2.6.38 Axel Lin (1): ASoC: Move kfree(twl4030) to twl4030_soc_remove() Jarkko Nikula (3): ASoC: tlv320aic3x: Use gpio_is_valid in checking for valid gpio_reset ASoC: tlv320aic3x: Add support to shared common reset line ASoC: tpa6130a2: Revisit power-up sequence sound/soc/codecs/tlv320aic3x.c | 32 +++++++++++++++++++++++++++----- sound/soc/codecs/tpa6130a2.c | 6 +++--- sound/soc/codecs/twl4030.c | 6 +++--- 3 files changed, 33 insertions(+), 11 deletions(-)

2 1

[alsa-devel] [GIT PULL] ASoC Fixes for 2.6.37
by Liam Girdwood 23 Nov '10

23 Nov '10

Hi Takashi, One fix for 2.6.37 now that you are back from vacation. Thanks Liam --- The following changes since commit 8f987768eb99631374f4ab0bb19cd062baf1397d: Merge commit 'v2.6.37-rc1' into for-2.6.37 (2010-11-03 14:11:27 +0000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lrg/asoc-2.6.git for-2.6.37 Janusz Krzysztofik (1): ASoC: OMAP: fix OMAP1 compilation problem sound/soc/omap/omap-mcbsp.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)

2 1