August 2007 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] au88x0: mem leak fix in snd_vortex_create()
by Jesper Juhl 06 Aug '07

06 Aug '07

Hi, In sound/pci/au88x0/au88x0.c::snd_vortex_create() : The Coverity checker found that if we allocate storage for 'chip' but then leave via the regions_out: label, then we end up leaking the storage allocated for 'chip'. I believe simply freeing 'chip' before the "return err;" line is all we need to fix this, but please double-check me :) Signed-off-by: Jesper Juhl <jesper.juhl(a)gmail.com> --- diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c index 5ec1b6f..f70286a 100644 --- a/sound/pci/au88x0/au88x0.c +++ b/sound/pci/au88x0/au88x0.c @@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip) pci_disable_device(chip->pci_dev); //FIXME: this not the right place to unregister the gameport vortex_gameport_unregister(chip); + kfree(chip); return err; }

3 2

[alsa-devel] MPC5200 I2S driver for ASoC
by lokowich 05 Aug '07

05 Aug '07

I'm integrating a ALSA driver for an MPC5200 into the ASoC layer, similar to my successful effort for a PXA255 board. I'm modeling the DMA and ALSA interfaces per ac97mgt driver found in the Lite5200B BSP, rather than the BestComm API example in the 2.4 kernel. The speaker-test with 400Hz sine wave is working, but has a slight audible jitter. A wav file output using aplay produces white noise. Debugging shows I get two requests for buffer pointer per service of my transmit ISR (after the single call to snd_pcm_period_elapsed). I expect only one pointer request per interrupt. Could this be the noise problem? This email was Anti Virus checked by Astaro Security Gateway. http://www.astaro.com

3 7

[alsa-devel] [PATCH][RESEND] au88x0: mem leak fix in snd_vortex_create()
by Jesper Juhl 04 Aug '07

04 Aug '07

(resend of patch previously submitted on 04-Aug-2007 02:09) Hi, In sound/pci/au88x0/au88x0.c::snd_vortex_create() : The Coverity checker found that if we allocate storage for 'chip' but then leave via the regions_out: label, then we end up leaking the storage allocated for 'chip'. I believe simply freeing 'chip' before the "return err;" line is all we need to fix this, but please double-check me :) Signed-off-by: Jesper Juhl <jesper.juhl(a)gmail.com> Acked-by: Rene Herman <rene.herman(a)gmail.com> --- diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c index 5ec1b6f..f70286a 100644 --- a/sound/pci/au88x0/au88x0.c +++ b/sound/pci/au88x0/au88x0.c @@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip) pci_disable_device(chip->pci_dev); //FIXME: this not the right place to unregister the gameport vortex_gameport_unregister(chip); + kfree(chip); return err; }

1 0

[alsa-devel] SALSA and aplay
by Alan Horstmann 04 Aug '07

04 Aug '07

Quick questions: 1. Does SALSA provide everything needed by aplay? 2. Is there a version or equivalent of aplay that is a function that can be called from other code rather than the command line? Otherwise I shall hack it so for the purpose of some testing only, but ask to avoid re-inventing (no doubt poorly) something that exists. BTW SALSA compiled great (thanks Takashi), but with the following warning (which I ignore apart from mentioning here):- In file included from hcontrol.h:36, from mixer.h:25, from mixer.c:30: hctl_macros.h: In function `snd_hctl_elem_tlv_read': hctl_macros.h:136: warning: `snd_ctl_elem_tlv_read' is deprecated (declared at ctl_macros.h:1134) hctl_macros.h: In function `snd_hctl_elem_tlv_write': hctl_macros.h:142: warning: `snd_ctl_elem_tlv_write' is deprecated (declared at ctl_macros.h:1141) hctl_macros.h: In function `snd_hctl_elem_tlv_command': hctl_macros.h:148: warning: `snd_ctl_elem_tlv_command' is deprecated (declared at ctl_macros.h:1148) Alan

7 34

Re: [alsa-devel] trouble compiling alsa-drivers
by Wallace, Brooke 04 Aug '07

04 Aug '07

Package alsa-driver-1.0.14.tar.b2z also fails to compile with the same error. Is there a particualr version of the Kernel that is recommended to use? I don't think the issue is with including the macro itself, it is defined in adriver.h and including that file directly generates the same error. Seems that MARCO depends on another MACRO "RW_LOCK_UNLOCKED" and somewhere down the line there is a syntax error.... make[1]: Entering directory `/usr/src/kernels/2.6.9-34.EL-smp-i686' CC [M] /local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore/memallo c.o CC [M] /local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore/sgbuf.o CC [M] /local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore/memory_ wrapper.o CC [M] /local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore/pcm.o CC [M] /local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore/pcm_nat ive.o /local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore/pcm_nat ive.c:75: error: syntax error before "snd_pcm_link_rwlock" ... [Many more similar errors] ... make[4]: *** [/local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore/pcm_na tive.o] Error 1 make[3]: *** [/local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14/acore] Error 2 make[2]: *** [_module_/local/mnt/views/brookew/alsa/workspace/alsa-driver-1.0.14] Error 2 make[1]: *** [modules] Error 2 make[1]: Leaving directory `/usr/src/kernels/2.6.9-34.EL-smp-i686' make: *** [compile] Error 2 I will do some more digging around, but I don't want to go off the deep-end hacking software I don't understand, at least not yet. -Brooke ________________________________ From: Tobin Davis [mailto:tdavis@dsl-only.net] Sent: Thursday, August 02, 2007 6:21 PM To: Wallace, Brooke Subject: Re: [alsa-devel] trouble compiling alsa-drivers Alsa 1.0.14rc4 is NOT the latest. 1.0.14 went final a few weeks after, and there was a patch to fix build issues on Redhat's broken kernels that went into it. Tobin On Thu, 2007-08-02 at 16:53 -0700, Wallace, Brooke wrote: The alsa-drivers INSTALL file tells me: On 2.6 kernels, the build directory has to be given via --with-build=<kernel_build_dir> option additionaly, too. What exactly is mean by kernel_build_dir? I should not have to recompile my kernel because I already have the sourcecore module. Configure seems to work fine and locates my kernel source code: ./configure --with-cards=hda-intel --with-sequencer=yes But when I compile, it fails in acore/pcm_native.c line #75, acore/pcm_native.c line #75 uses the macro DEFINE_RWLOCK which apparently has not been defined yet. Searching thu the alsa-drivers source, I find that include/adriver.h defines this macro. What am I doing wrong? Why doesn't adriver.h get included when I compile acore/pcm_native.c? I'm using the latest release - alsa-driver-1.0.14rc4 My Kernel sources are: 2.6.9-34.EL-smp-i686 Alsa is already working fine on this system using the HDA Intel driver, its a RHEL- 3.4.5-2 system. I just want to re-compile the latest ALSA software and start writing a dummy user space driver that prints to a file or something. I should be able to cmopile all of the latest ALSA software... Any help is appreciated. -Brooke _______________________________________________ Alsa-devel mailing list Alsa-devel(a)alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Tobin Davis Laetrile is the pits.

1 0

Re: [alsa-devel] Will the real alsa wiki please stand up?
by Eliot Blennerhassett 03 Aug '07

03 Aug '07

I'm confused again. Which is the real official wiki? This one "AlsaWiki" http://bugtrack.alsa-project.org/main/index.php/Main_Page (MediaWiki, last change 25 July) OR This one "Official Alsa Wiki for Developers" https://bugtrack.alsa-project.org/wiki/wikka.php?wakka=AlsaWiki (Powered by Wikka Wakka Wiki) approx 28 content pages, last change 24 July) It was made clear a while ago that this is the UNofficial wiki: http://alsa.opensrc.org/index.php/Main_Page (MediaWiki) Gosh!, how much fragmentation do we need???? If 3 wikis really are necessary, can we at least have links to the others on the main page of each wiki, and explanation of which is most approriate for different content? thanks Eliot

5 9

[alsa-devel] User space drivers
by Wallace, Brooke 03 Aug '07

03 Aug '07

Hi, I've been trying to sort thru the ALSA docs and am starting to get the impression that all of the existing drivers are written as Kernel Modules. Doesn't this mean that they are running in Kernel space and infact are not User Space drivers? Shouldn't there be an ALSA Drivers API document that covers an API that User Space Drivers can use? I must be mssing something here... I'm looking into ALSA because my company wants to use this standard for writing User Space drivers for our product running on various linux kernels. The reasoning for this is strictly proprietary licensing - our leagl department is not comfortable with the GPL and the possiblitiy that something written for Kernel space could at some time be considered as required to be GPL - not my decision... -Brooke

4 3

[alsa-devel] Output to Input routing
by Vadim Lebedev 02 Aug '07

02 Aug '07

Hello, I remember reading AC97 specs that there si possibility to configure it in such a way, that when doing stereo capture, left input channel will get actual MIC input and right input channel will get the copy of speaker output. This setting is ideal for echo cancellation algorithm. To my grand dismay i'm unable to find a doc of ALSA mixer API so i'm unsucessuful writing code to put mixer in such mode. Can some kind soul please contibuite a code snippet.... Thanks Vadim

2 3

Re: [alsa-devel] Intel HDA Driver - Bug
by Takashi Iwai 02 Aug '07

02 Aug '07

At Tue, 31 Jul 2007 13:58:32 +0100, Steven King wrote: > > Hi Takashi, > > I still have not had much success getting the front microphone jack > working correctly. The internal array microphone works by setting the > "Digital Input Source" to "Digital Mic 1" which corresponds to the > chipset configuration loaded by BIOS and then by the driver in > patch_sigmatel.c. So, im not without a microphone for the time being. Aha, so it's indeed connected to a digital mic (0x17). Good to know. > I tried setting Port C,D,E,F (Port A and B are HP and internal > speaker) to be microphone inputs in the nid configuration, however it > still did not get any input audio. Would it have something to do with > the jack detect pin on the microphone jack? What else may I have a > look at? I guess 0x0b is the mic input (although it's labelled as "Line"). You might have "Line In as Output Switch". This will change the I/O direction of the pin. There have been bugs regarding this switch in the recent version and it got fixed after 1.0.14 release. So, please use the latest ALSA HG version for debugging the problems. thanks, Takashi

1 0

[alsa-devel] problem with ATI SB600 Azalia
by Rafał Zawadzki 02 Aug '07

02 Aug '07

Hello. I tried earlier on alsa-user, but nobody answer. Propably this is the better place for this post. I have the same problem as mentioned here: http://thread.gmane.org/gmane.linux.alsa.devel/47688/focus=47827 (the same laptop). I tried this solution, but unfortunately i had below error during kernel compilation (kernel source ubuntu 2.6.20-16). What is proper way to make upgrade alsa to alsa-hg? Building modules, stage 2. MODPOST 1855 modules WARNING: vmlinux - Section mismatch: reference to .init.data:boot_params from .text between '_text' (at offset 0xc0100036) and 'startup_32_smp' WARNING: vmlinux - Section mismatch: reference to .init.data:boot_params from .text between '_text' (at offset 0xc0100044) and 'startup_32_smp' WARNING: vmlinux - Section mismatch: reference to .init.data:init_pg_tables_end from .text between '_text' (at offset 0xc01000a6) and 'startup_32_smp' WARNING: vmlinux - Section mismatch: reference to .init.text:start_kernel from .text between 'is386' (at offset 0xc0100221) and 'check_x87' WARNING: vmlinux - Section mismatch: reference to .init.text:smp_prepare_cpus from .text between 'init' (at offset 0xc0100437) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:migration_init from .text between 'init' (at offset 0xc010043c) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:spawn_ksoftirqd from .text between 'init' (at offset 0xc0100441) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:spawn_softlockup_task from .text between 'init' (at offset 0xc0100446) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:smp_cpus_done from .text between 'init' (at offset 0xc01004c2) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:sched_init_smp from .text between 'init' (at offset 0xc01004c7) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:cpuset_init_smp from .text between 'init' (at offset 0xc01004cc) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:usermodehelper_init from .text between 'init' (at offset 0xc01004d6) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:driver_init from .text between 'init' (at offset 0xc01004db) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:sysctl_init from .text between 'init' (at offset 0xc01004e1) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between 'init' (at offset 0xc0100503) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between 'init' (at offset 0xc010051c) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:prepare_namespace from .text between 'init' (at offset 0xc01006ff) and 'rest_init' WARNING: vmlinux - Section mismatch: reference to .init.text:__alloc_bootmem from .text between 'init_gdt' (at offset 0xc010a0cb) and 'cpu_init' WARNING: vmlinux - Section mismatch: reference to .init.text:__alloc_bootmem from .text between 'init_gdt' (at offset 0xc010a0e1) and 'cpu_init' WARNING: vmlinux - Section mismatch: reference to .init.text:sysenter_setup from .text between 'identify_cpu' (at offset 0xc010a73b) and 'display_cacheinfo' WARNING: vmlinux - Section mismatch: reference to .init.text:mtrr_bp_init from .text between 'identify_cpu' (at offset 0xc010a745) and 'display_cacheinfo' WARNING: vmlinux - Section mismatch: reference to .init.text:trap_init_f00f_bug from .text between 'init_intel' (at offset 0xc010c796) and 'cpuid4_cache_lookup' WARNING: vmlinux - Section mismatch: reference to .init.data:initkmem_list3 from .text between 'set_up_list3s' (at offset 0xc017238f) and 's_start' WARNING: vmlinux - Section mismatch: reference to .init.text:eisa_root_register from .text between 'pci_eisa_init' (at offset 0xc026f71b) and 'virtual_eisa_release' WARNING: vmlinux - Section mismatch: reference to .init.text:eisa_root_register from .text between 'virtual_eisa_root_init' (at offset 0xc026f77f) and 'cpufreq_unregister_driver' WARNING: vmlinux - Section mismatch: reference to .init.text: from .text between 'iret_exc' (at offset 0xc02f2330) and '_etext' WARNING: vmlinux - Section mismatch: reference to .init.text:start_kernel from .paravirtprobe between '__start_paravirtprobe' (at offset 0xc03c4790) and '__stop_paravirtprobe' WARNING: "is_power_of_2" [sound/core/snd-rtctimer.ko] undefined! make[1]: *** [__modpost] Błąd 1 make: *** [modules] Błąd 2 root@antichrist:/usr/src/linux# Cheers, -- Rafał bluszcz Zawadzki http://my.jabberpl.org - use jabber http://glam.pl - try secondhand clothes http://bluszcz.net - my homepage

2 6