- Alsa-devel - mailman.alsa-project.org

Acer 315-24P Microphone indicator is not working
by GitHub issues - opened 23 Dec '24

23 Dec '24

alsa-project/alsa-utils issue #284 was opened from River000000: [alsa.txt](https://github.com/user-attachments/files/18227950/alsa.txt) ![изображение](https://github.com/user-attachments/assets/dc8b0b9a-f877-4edc-a9eb-d1c4d1d2fcb7) ![изображение](https://github.com/user-attachments/assets/5f8f1c69-294b-4833-8bdf-9c2f8033c379) Issue URL : https://github.com/alsa-project/alsa-utils/issues/284 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH RESEND] soundwire: amd: clear wake enable register for power off mode
by Vijendar Mukunda 23 Dec '24

23 Dec '24

As per design for power off mode, clear the wake enable register during resume sequence. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 5a4bfaef65fb..96a3aa6da711 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { return amd_sdw_clock_stop_exit(amd_manager); } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance)); val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL); if (val) { val |= AMD_SDW_CLK_RESUME_REQ; -- 2.34.1

3 3

[PATCH] soundwire: amd: clear wake enable register for power off mode
by Vijendar Mukunda 23 Dec '24

23 Dec '24

As per design for power off mode, clear the wake enable register during resume sequence. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 5a4bfaef65fb..96a3aa6da711 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { return amd_sdw_clock_stop_exit(amd_manager); } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance)); val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL); if (val) { val |= AMD_SDW_CLK_RESUME_REQ; -- 2.34.1

3 2

[PATCH V2] soundwire: amd: clear wake enable register for power off mode
by Vijendar Mukunda 23 Dec '24

23 Dec '24

As per design for AMD SoundWire manager power off mode, clear the wake enable register during resume sequence. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- Changes Since v1: - Replaced 0x00 with 0 in register write - Updte Commit message drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 5a4bfaef65fb..ca271a728a65 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { return amd_sdw_clock_stop_exit(amd_manager); } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { + writel(0, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance)); val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL); if (val) { val |= AMD_SDW_CLK_RESUME_REQ; -- 2.34.1

1 0

[PATCH RESEND] soundwire: amd: clear wake enable register for
by Vijendar Mukunda 23 Dec '24

23 Dec '24

As per design for power off mode, clear the wake enable register during resume sequence. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 5a4bfaef65fb..96a3aa6da711 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { return amd_sdw_clock_stop_exit(amd_manager); } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance)); val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL); if (val) { val |= AMD_SDW_CLK_RESUME_REQ; -- 2.34.1

3 3

make check fails to compile playmidi1.c: "error: expected identifier or '(' before numeric constant"
by GitHub issues - opened 22 Dec '24

22 Dec '24

alsa-project/alsa-lib issue #430 was opened from 746B61: Getting the latest version from branch master (352cbc5e) and running `./gitcompile` followed by `make check` fails with: ``` Making check in test make[1]: Entering directory '/tmp/alsa-lib-master/test' Making check in . make[2]: Entering directory '/tmp/alsa-lib-master/test' make control pcm pcm_min latency seq seq-ump-example playmidi1 timer rawmidi midiloop umpinfo oldapi queue_timer namehint client_event_filter chmap audio_time user-ctl-element-set pcm-multi-thread make[3]: Entering directory '/tmp/alsa-lib-master/test' CC control.o CCLD control CC pcm.o CCLD pcm CC pcm_min.o CCLD pcm_min CC latency.o CCLD latency CC seq.o In file included from seq.c:12: seq-sender.c: In function 'event_sender': seq-sender.c:150:62: warning: variable 'pcm_flag' set but not used [-Wunused-but-set-variable] 150 | int client, port, queue, max, err, v1, v2, time = 0, pcm_flag = 0; | ^~~~~~~~ CCLD seq CC seq-ump-example.o CCLD seq-ump-example CC playmidi1.o In file included from playmidi1.c:48: midifile.h:55:33: error: expected identifier or '(' before numeric constant 55 | #define note_on 0x90 | ^~~~ ../include/alsa/ump_msg.h:170:41: note: in expansion of macro 'note_on' 170 | snd_ump_msg_midi1_note_t note_on; /**< MIDI1 note-on message */ | ^~~~~~~ midifile.h:54:33: error: expected identifier or '(' before numeric constant 54 | #define note_off 0x80 | ^~~~ ../include/alsa/ump_msg.h:171:41: note: in expansion of macro 'note_off' 171 | snd_ump_msg_midi1_note_t note_off; /**< MIDI1 note-off message */ | ^~~~~~~~ midifile.h:57:33: error: expected identifier or '(' before numeric constant 57 | #define control_change 0xb0 | ^~~~ ../include/alsa/ump_msg.h:173:41: note: in expansion of macro 'control_change' 173 | snd_ump_msg_midi1_cc_t control_change; /**< MIDI1 control-change message */ | ^~~~~~~~~~~~~~ midifile.h:55:33: error: expected identifier or '(' before numeric constant 55 | #define note_on 0x90 | ^~~~ ../include/alsa/ump_msg.h:432:41: note: in expansion of macro 'note_on' 432 | snd_ump_msg_midi2_note_t note_on; /**< MIDI2 note-on message */ | ^~~~~~~ midifile.h:54:33: error: expected identifier or '(' before numeric constant 54 | #define note_off 0x80 | ^~~~ ../include/alsa/ump_msg.h:433:41: note: in expansion of macro 'note_off' 433 | snd_ump_msg_midi2_note_t note_off; /**< MIDI2 note-off message */ | ^~~~~~~~ midifile.h:57:33: error: expected identifier or '(' before numeric constant 57 | #define control_change 0xb0 | ^~~~ ../include/alsa/ump_msg.h:438:41: note: in expansion of macro 'control_change' 438 | snd_ump_msg_midi2_cc_t control_change; /**< MIDI2 control-change message */ | ^~~~~~~~~~~~~~ In file included from playmidi1.c:49: midifile.c:57:33: error: expected identifier or '(' before numeric constant 57 | #define set_tempo 0x51 | ^~~~ ../include/alsa/ump_msg.h:711:41: note: in expansion of macro 'set_tempo' 711 | snd_ump_msg_set_tempo_t set_tempo; /**< Set Tempo */ | ^~~~~~~~~ make[3]: *** [Makefile:622: playmidi1.o] Error 1 make[3]: Leaving directory '/tmp/alsa-lib-master/test' make[2]: *** [Makefile:819: check-am] Error 2 make[2]: Leaving directory '/tmp/alsa-lib-master/test' make[1]: *** [Makefile:669: check-recursive] Error 1 make[1]: Leaving directory '/tmp/alsa-lib-master/test' make: *** [Makefile:414: check-recursive] Error 1 ``` The issue was introduced with commit 07cee0ba. playmidi1.c first [includes](https://github.com/alsa-project/alsa-lib/blob/352cbc5eb94a271a9c3… midifile.h from the test directory, which [has](https://github.com/alsa-project/alsa-lib/blob/352cbc5eb94a271a9c3c0ff5… `#define note_on 0x90`. After commit 07cee0ba, ump_msg.h gets included later, which [has](https://github.com/alsa-project/alsa-lib/blob/352cbc5eb94a271a9c3c0ff5… ` snd_ump_msg_midi1_note_t note_on; /**< MIDI1 note-on message */`. The preprocessor replaces `note_on` with `0x90` and the compilation fails with the error above. Issue URL : https://github.com/alsa-project/alsa-lib/issues/430 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

sun4i-codec: add routing for headphones and internal speaker
by GitHub pull_request - opened 21 Dec '24

21 Dec '24

alsa-project/alsa-ucm-conf pull request #491 was opened from tokyovigilante: The sun4i-codec kernel driver covers a large number of Allwinner SoCs. The H616 codec has a single line-out route, which is used in concert with a Toshiba mux chip to send audio to either an internal speaker or headphone jack on a number of Anbernic handheld gaming devices. Add a UCM configuration to allow enabling/disabling the speaker amp depending on whether headphones are in use or not. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/491 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/491.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

API memory allocator
by GitHub issues - opened 20 Dec '24

20 Dec '24

alsa-project/alsa-lib issue #429 was opened from sylware: If I recall properly some data returned from the alsa lib API must be free using the C runtime free(). Would it be appropriate to move away from the C allocator to an API install-able memory allocator (like vulkan3D)? Backward compatibility would be achieved since the "default memory allocator" would be the C one, if the C runtime is around. Unless that part of the API is already deprecated (and I should not have used it). Issue URL : https://github.com/alsa-project/alsa-lib/issues/429 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 00/35] Reorganize kerneldoc parameter names
by Julia Lawall 20 Dec '24

20 Dec '24

Reorganize kerneldoc parameter names to match the parameter order in the function header. The misordered cases were identified using the following Coccinelle semantic patch: // <smpl> @initialize:ocaml@ @@ let parse_doc l = let pieces = List.map String.trim (String.split_on_char '*' l) in let l = String.concat " " pieces in match String.split_on_char ':' l with x::xs -> x | _ -> "" let params ps = List.rev (List.fold_left (fun prev (pm,_) -> let ty = String.trim(Pretty_print_c.string_of_fullType pm.Ast_c.p_type) in if ty = "void" && pm.Ast_c.p_namei = None then prev else let name = match pm.Ast_c.p_namei with Some name -> name | None -> failwith "function parameter has no name" in (String.trim (Pretty_print_c.string_of_name name),ty)::prev) [] ps) @r@ comments c; identifier fn; position p; parameter list ps; type T; @@ T@c fn@p(ps) { ... } @script:ocaml@ p << r.p; c << r.c; (_,ps) << r.ps; @@ let isdoc c ps = List.length ps > 1 && (let c = String.trim c in String.length c > 3 && String.sub c 0 3 = "/**" && String.get c 3 != '*') in let subset l1 l2 = List.for_all (fun x -> List.mem x l2) l1 in let (cb,cm,ca) = List.hd c in match List.rev cb with c::_ when isdoc c ps -> let pieces = String.split_on_char '@' c in (match pieces with _::tl -> let d_names = List.map parse_doc tl in (* check parameters *) let p_names = List.map fst (params ps) in if d_names <> [] && not(d_names = p_names) then begin if List.sort compare d_names = List.sort compare p_names then Coccilib.print_main "out of order" p else if subset d_names p_names then Coccilib.print_main "doc is missing a parameter" p else if subset d_names p_names then Coccilib.print_main "doc has an extra parameter" p end | _ -> ()) | _ -> () // </smpl> --- arch/arm/mach-omap2/prm2xxx_3xxx.c | 1 - arch/powerpc/platforms/ps3/interrupt.c | 2 +- arch/powerpc/platforms/ps3/repository.c | 2 +- drivers/base/firmware_loader/main.c | 2 +- drivers/comedi/drivers/comedi_8254.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 3 +-- drivers/gpu/drm/drm_gpuvm.c | 2 +- drivers/gpu/drm/radeon/radeon_ib.c | 2 +- drivers/iommu/iommu.c | 2 +- drivers/leds/leds-gpio-register.c | 2 +- drivers/mfd/atmel-smc.c | 4 ++-- drivers/misc/mei/bus.c | 2 +- drivers/mtd/ubi/eba.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c | 2 +- drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_common.c | 7 +++---- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- drivers/nvdimm/dimm_devs.c | 2 +- drivers/pci/hotplug/pci_hotplug_core.c | 2 +- drivers/pinctrl/pinmux.c | 2 +- drivers/slimbus/messaging.c | 2 +- drivers/soc/qcom/qmi_interface.c | 2 +- drivers/soundwire/stream.c | 2 +- drivers/usb/gadget/config.c | 4 ++-- fs/char_dev.c | 2 +- fs/dcache.c | 4 ++-- fs/seq_file.c | 2 +- kernel/audit.c | 2 +- kernel/resource.c | 2 +- kernel/sysctl.c | 1 - kernel/trace/ring_buffer.c | 2 +- lib/lru_cache.c | 2 +- lib/maple_tree.c | 2 +- mm/mmu_notifier.c | 2 +- net/dccp/feat.c | 2 +- net/mac80211/mesh_hwmp.c | 6 +++--- net/mac80211/mesh_pathtbl.c | 10 +++++----- net/socket.c | 2 +- net/sunrpc/xprt.c | 2 +- net/tipc/link.c | 14 +++++++------- net/tipc/msg.c | 2 +- sound/pci/hda/hda_codec.c | 2 +- 45 files changed, 60 insertions(+), 64 deletions(-)

4 5

[alsa-ucm-conf] sof-soundwire: Use correct speaker data port and PCM for cs35l56 bridge
by Maciej Strozek 20 Dec '24

20 Dec '24

Signed-off-by: Maciej Strozek <mstrozek(a)opensource.cirrus.com> --- ucm2/sof-soundwire/cs35l56-bridge.conf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ucm2/sof-soundwire/cs35l56-bridge.conf b/ucm2/sof-soundwire/cs35l56-bridge.conf index 176f880..2e8c1c6 100644 --- a/ucm2/sof-soundwire/cs35l56-bridge.conf +++ b/ucm2/sof-soundwire/cs35l56-bridge.conf @@ -23,8 +23,8 @@ SectionDevice."Speaker" { EnableSequence [ cset "name='cs42l43 Speaker L Input 1' 'ASPRX1'" cset "name='cs42l43 Speaker R Input 1' 'ASPRX2'" - cset "name='cs42l43 ASPTX1 Input' 'DP5RX1'" - cset "name='cs42l43 ASPTX2 Input' 'DP5RX2'" + cset "name='cs42l43 ASPTX1 Input' 'DP6RX1'" + cset "name='cs42l43 ASPTX2 Input' 'DP6RX2'" cset "name='AMPL ASP1 TX1 Source' 'DSP1TX1'" cset "name='AMPL ASP1 TX2 Source' 'None'" @@ -54,7 +54,7 @@ SectionDevice."Speaker" { Value { PlaybackPriority 100 - PlaybackPCM "hw:${CardId},0" + PlaybackPCM "hw:${CardId},2" PlaybackMixer "default:${CardId}" PlaybackMixerElem "Speaker" } -- 2.39.5

2 1