- Alsa-devel - mailman.alsa-project.org

Re: [PATCH v2 linux-next] Remove Unnecessary TODO
by Pierre-Louis Bossart 17 Aug '22

17 Aug '22

On 8/16/22 19:59, Khalid Masum wrote: > The capabilities enabled for multi-link are required as part of the > programming sequences, even when a stream uses a single link we still > use the syncArm/syncGo sequences. Therefore the TODO is no longer > necessary. > > Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> > Signed-off-by: Khalid Masum <khalid.masum.92(a)gmail.com> the title of your patch should be something like soundwire: intel: remove unnecessary TODO so that the patch scope and context is clearly identified. > --- > Previous discussions: > - v1 Link: https://lore.kernel.org/lkml/20220814080416.7531-1-khalid.masum.92@gmail.co… > > Changes since v1: > - Remove the todo, leave rest of the code as is > - Update commit message > > drivers/soundwire/bus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index 8d4000664fa3..18158825a6d8 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent, > > /* > * Initialize multi_link flag > - * TODO: populate this flag by reading property from FW node > */ > bus->multi_link = false; > if (bus->ops->read_prop) {

2 1

bat: Add 'readcapture' option to support analyzing external audio
by GitHub pull_request - opened 16 Aug '22

16 Aug '22

alsa-project/alsa-utils pull request #166 was opened from tbird20d: If audio data is captured on another device (ie we are NOT using loopback mode), then allow alsabat to analyze that data, by passing a filename reference on the command line. Add the '--readcapture' option to the argument parser. When this option is specified, avoid doing a local capture, and instead just read the audio data from the indicated file, and analyze that. Signed-off-by: Tim Bird <tim.bird(a)sony.com> Request URL : https://github.com/alsa-project/alsa-utils/pull/166 Patch URL : https://github.com/alsa-project/alsa-utils/pull/166.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Re: Rockchip I2S commit possibly ignored
by Mark Brown 16 Aug '22

16 Aug '22

On Tue, Aug 16, 2022 at 02:54:22PM -0300, Geraldo Nascimento wrote: > On Tue, Aug 16, 2022 at 04:22:37PM +0100, Mark Brown wrote: > > There's absolutely no problem with reposting someone else's patch - just > > add your Signed-off-by at the end of the signoff chain. > Mark, I'm in no position to lecture anyone, least of who, you, hard-working > ASoC maintainer that you are. But there are *tons* of problems with > reposting someone else's patch, even if they had been previously given > the green-light but misteriously vanished. > You are assuming responsibility for someone else's work! Let's see in Oh, sure - but TBH if you're chasing a patch via e-mail you're pretty much going to be in a similar situation if that results in the patch getting applied. A big part of the goal behind getting things reposted is to push them through the normal test/review cycle properly so if there was some reason for it to not get applied the first time around it's more likely that someone will notice than if it's just pulled out of list archives or whatever. > My main point is that without adding "resets" and "reset-names" to *at > least* every Rockchip device tree that enables sound over HDMI, just an > example, you get systems with non-working HDMI. I just tested it, I > omitted "resets" and "reset-names" from my device tree and then had > to SSH into the black screen to revert the changes to my boot partition. > So it's not trivial to RESEND this. It amounts to device tree overhaul > of arch/arm64/boot/dts/rockchip > This would require community effort of say, equivalent to LibreELEC > resources, which are not many, but they have enough patience to test > every proposed change to Rockchip device trees, and could help upstream > this. Right, that's a problem. Even with those changes if we start requiring new properties that'd be an ABI break anyway which isn't something we want for DT - ideally the patch should be reworked so that existing systems continue to work even without DT updates.

1 0

[PATCH] ASoC: Variable type completion
by Xin Gao 16 Aug '22

16 Aug '22

'unsigned int' is better than 'unsigned'. Signed-off-by: Xin Gao <gaoxin(a)cdjrlc.com> --- sound/soc/ti/davinci-evm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/ti/davinci-evm.c b/sound/soc/ti/davinci-evm.c index 68d69e32681a..392bf17564bf 100644 --- a/sound/soc/ti/davinci-evm.c +++ b/sound/soc/ti/davinci-evm.c @@ -23,7 +23,7 @@ struct snd_soc_card_drvdata_davinci { struct clk *mclk; - unsigned sysclk; + unsigned int sysclk; }; static int evm_startup(struct snd_pcm_substream *substream) @@ -57,7 +57,7 @@ static int evm_hw_params(struct snd_pcm_substream *substream, struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0); struct snd_soc_card *soc_card = rtd->card; int ret = 0; - unsigned sysclk = ((struct snd_soc_card_drvdata_davinci *) + unsigned int sysclk = ((struct snd_soc_card_drvdata_davinci *) snd_soc_card_get_drvdata(soc_card))->sysclk; /* set the codec system clock */ -- 2.30.2

1 0

[PATCH] ASoC: Variable type completion
by Xin Gao 16 Aug '22

16 Aug '22

'unsigned int' is better than 'unsigned'. Signed-off-by: Xin Gao <gaoxin(a)cdjrlc.com> --- sound/soc/codecs/pcm3008.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/pcm3008.h b/sound/soc/codecs/pcm3008.h index f7f4fbbd89db..45270bcf1c02 100644 --- a/sound/soc/codecs/pcm3008.h +++ b/sound/soc/codecs/pcm3008.h @@ -10,10 +10,10 @@ #define __LINUX_SND_SOC_PCM3008_H struct pcm3008_setup_data { - unsigned dem0_pin; - unsigned dem1_pin; - unsigned pdad_pin; - unsigned pdda_pin; + unsigned int dem0_pin; + unsigned int dem1_pin; + unsigned int pdad_pin; + unsigned int pdda_pin; }; #endif -- 2.30.2

1 0

ASoC: snd_soc_info_volsw and platfrom_max
by Srinivas Kandagatla 16 Aug '22

16 Aug '22

Hi Mark, After patch 30ac49841386 (ASoC: ops: Don't modify the driver's plaform_max when reading state) all the controls that are using signed TLV range like below /* -84dB min - 40dB max */ SOC_SINGLE_S8_TLV("RX0 Digital Volume", WCD934X_CDC_RX0_RX_VOL_CTL, -84, 40, digital_gain), reports max value as 40 instead of 124. before this patch the controls max value was calculated considering the min value, but with this patch this calculation has changed resulting in low volume on most of the codecs that are using SOC_SINGLE_S8_TLV. snd_soc_put_volsw does the right thing by considering mc->min, but info_volsw does it differently. Below change fixes the issue for me, but I am bit confused with the first line of this function that calculates max value as max = mc->max - mc->min and then limits it to platform_max. diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c index bd88de056358..49fb34609202 100644 --- a/sound/soc/soc-ops.c +++ b/sound/soc/soc-ops.c @@ -196,7 +196,7 @@ int snd_soc_info_volsw(struct snd_kcontrol *kcontrol, uinfo->count = snd_soc_volsw_is_stereo(mc) ? 2 : 1; uinfo->value.integer.min = 0; - uinfo->value.integer.max = max; + uinfo->value.integer.max = max - mc->min; return 0; } Or should we fix the macro to set platform_max to be max - min. thanks, Srini

2 5

[PATCH 1/2] ASoC: Intel: common: add ACPI matching tables for Raptor Lake
by Kai Vehmanen 16 Aug '22

16 Aug '22

Initial support for RPL w/ RT711 Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Tested-by: Gopal Vamshi Krishna <vamshi.krishna.gopal(a)intel.com> --- include/sound/soc-acpi-intel-match.h | 2 + sound/soc/intel/common/Makefile | 2 +- .../intel/common/soc-acpi-intel-rpl-match.c | 51 +++++++++++++++++++ 3 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 sound/soc/intel/common/soc-acpi-intel-rpl-match.c diff --git a/include/sound/soc-acpi-intel-match.h b/include/sound/soc-acpi-intel-match.h index bc7fd46ec2bc..ac750afa7bc6 100644 --- a/include/sound/soc-acpi-intel-match.h +++ b/include/sound/soc-acpi-intel-match.h @@ -30,6 +30,7 @@ extern struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_ehl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_adl_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_mtl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_cnl_sdw_machines[]; @@ -38,6 +39,7 @@ extern struct snd_soc_acpi_mach snd_soc_acpi_intel_cml_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_icl_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_adl_sdw_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_mtl_sdw_machines[]; /* diff --git a/sound/soc/intel/common/Makefile b/sound/soc/intel/common/Makefile index 8ca8f872ec80..41054cf09ec9 100644 --- a/sound/soc/intel/common/Makefile +++ b/sound/soc/intel/common/Makefile @@ -9,7 +9,7 @@ snd-soc-acpi-intel-match-objs := soc-acpi-intel-byt-match.o soc-acpi-intel-cht-m soc-acpi-intel-cml-match.o soc-acpi-intel-icl-match.o \ soc-acpi-intel-tgl-match.o soc-acpi-intel-ehl-match.o \ soc-acpi-intel-jsl-match.o soc-acpi-intel-adl-match.o \ - soc-acpi-intel-mtl-match.o \ + soc-acpi-intel-rpl-match.o soc-acpi-intel-mtl-match.o \ soc-acpi-intel-hda-match.o \ soc-acpi-intel-sdw-mockup-match.o diff --git a/sound/soc/intel/common/soc-acpi-intel-rpl-match.c b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c new file mode 100644 index 000000000000..0b77401e4e6f --- /dev/null +++ b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c @@ -0,0 +1,51 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * soc-apci-intel-rpl-match.c - tables and support for RPL ACPI enumeration. + * + * Copyright (c) 2022 Intel Corporation. + */ + +#include <sound/soc-acpi.h> +#include <sound/soc-acpi-intel-match.h> + +static const struct snd_soc_acpi_endpoint single_endpoint = { + .num = 0, + .aggregated = 0, + .group_position = 0, + .group_id = 0, +}; + +static const struct snd_soc_acpi_adr_device rt711_0_adr[] = { + { + .adr = 0x000020025D071100ull, + .num_endpoints = 1, + .endpoints = &single_endpoint, + .name_prefix = "rt711" + } +}; + +static const struct snd_soc_acpi_link_adr rpl_rvp[] = { + { + .mask = BIT(0), + .num_adr = ARRAY_SIZE(rt711_0_adr), + .adr_d = rt711_0_adr, + }, + {} +}; + +struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_machines[] = { + {}, +}; +EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_rpl_machines); + +/* this table is used when there is no I2S codec present */ +struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_sdw_machines[] = { + { + .link_mask = 0x1, /* link0 required */ + .links = rpl_rvp, + .drv_name = "sof_sdw", + .sof_tplg_filename = "sof-rpl-rt711.tplg", + }, + {}, +}; +EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_rpl_sdw_machines); base-commit: efe30e2cb6ff87467389cece8ce604f6601059f9 -- 2.37.2

2 2

[PATCH 0/4] ASoC: Intel: HSW and BDW updates
by Cezary Rojewski 16 Aug '22

16 Aug '22

Sharing this PR as it touches on cross-driver subjects. Four commits yet two subject. Given the small delta, decided to combine within single PR here. I plan to send these subjects separately to the mailing list though. 1. Rename hsw_rt5640 and bdw_rt286 module names 2. Drop SND_SOC_INTEL_ACPI_MATCH dependency for catpt-driver In regard to 1), this is a followup to discussion that has already happened on upstream [1]. Goal is to align kernel module names for hsw and bdw boards with their siblings found in /intel/boards and /intel/avs/boards. In regard to 2), this is yet another followup [2]. Given the fact that /intel/avs/boards are already their on upstream, intention is to align catpt-driver to approach found in the avs-driver. This is also my suggestion for existing sof-boards: most should be listed under /sof/intel/boards/ as they're not common, really - they're are SOF specific. I believe that in time /intel/common and /intel/boards should be either limited or completely removed. As subject touches code used by the sof-driver, additional review has been conducted on thesofproject/linux [3]. [1]: https://lore.kernel.org/alsa-devel/54fcdedc-278c-06b8-5402-28880597d3f4@int… [2]: https://lore.kernel.org/alsa-devel/d9fd60e0-a157-bda7-a918-5548918d1552@int… [3]: https://github.com/thesofproject/linux/pull/3799 Cezary Rojewski (4): ASoC: Intel: hsw_rt5640: Rename module ASoC: Intel: bdw_rt286: Rename module ASoC: Intel: catpt: Drop SND_SOC_ACPI_INTEL_MATCH dependency ASoC: Intel: Drop legacy HSW/BDW board-match information include/sound/soc-acpi-intel-match.h | 1 - sound/soc/intel/Kconfig | 2 +- sound/soc/intel/boards/Makefile | 8 ++--- sound/soc/intel/catpt/device.c | 33 +++++++++++++++++-- .../common/soc-acpi-intel-hsw-bdw-match.c | 15 --------- 5 files changed, 35 insertions(+), 24 deletions(-) -- 2.25.1

2 6

Rockchip I2S commit possibly ignored
by Geraldo Nascimento 16 Aug '22

16 Aug '22

Hi Mark, I was looking at Rockchip I2S commits and it seems "ASoC: rockchip: i2s: Reset the controller if soft reset failed" was supposed to have been merged to your sound.git but never was. I don't know if this was intentional or a real miss but in any case I'm letting you know. According to 515b436be291ff197c52198282bbb19e79c9d197 'Merge series "Patches to update for rockchip i2s" from Sugar Zhang <sugar.zhang(a)rock-chips.com>:' it should have been merged to your tree. In rockchip-i2s.yaml there's even documentation that references the missing commit. However in the alsa-devel archives, https://mailman.alsa-project.org/pipermail/alsa-devel/2021-August/189050.ht… I see there was no commit info for the unmerged patch. Perhaps this caused it to be black-holed? Thanks, Geraldo Nascimento

2 4

Re: [PATCH v6 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC
by Mark Brown 16 Aug '22

16 Aug '22

On Tue, 16 Aug 2022 10:44:55 +0800, Zhu Ning wrote: > Add device tree binding documentation for Everest ES8326 > > ---- > v5 tested by dtschema > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC commit: 8c6789f4e2d4ee7d6c8c60daa88ea7a4c4cf6779 [2/2] ASoC: codecs: add support for ES8326 commit: 5c439937775d77a334696a98fb2a25dee72ffa2d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0