- Alsa-devel - mailman.alsa-project.org

[RESEND PATCH] Revert "ASoC: fsl_audmix: make clock and output src write only"
by Shengjiu Wang 23 Sep '22

23 Sep '22

This reverts commit 944c517b8c838832a166f1c89afbf8724f4a6b49. There is error after making clock and output src write only $amixer -c imxaudmix cset numid=1 1 amixer: Cannot read the given element from control sysdefault:3 Which is worse than before, so let's revert the change. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/fsl/fsl_audmix.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c index 43857b7a81c9..672148dd4b23 100644 --- a/sound/soc/fsl/fsl_audmix.c +++ b/sound/soc/fsl/fsl_audmix.c @@ -199,18 +199,10 @@ static int fsl_audmix_put_out_src(struct snd_kcontrol *kcontrol, static const struct snd_kcontrol_new fsl_audmix_snd_controls[] = { /* FSL_AUDMIX_CTR controls */ - { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, - .name = "Mixing Clock Source", - .info = snd_soc_info_enum_double, - .access = SNDRV_CTL_ELEM_ACCESS_WRITE, - .put = fsl_audmix_put_mix_clk_src, - .private_value = (unsigned long)&fsl_audmix_enum[0] }, - { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, - .name = "Output Source", - .info = snd_soc_info_enum_double, - .access = SNDRV_CTL_ELEM_ACCESS_WRITE, - .put = fsl_audmix_put_out_src, - .private_value = (unsigned long)&fsl_audmix_enum[1] }, + SOC_ENUM_EXT("Mixing Clock Source", fsl_audmix_enum[0], + snd_soc_get_enum_double, fsl_audmix_put_mix_clk_src), + SOC_ENUM_EXT("Output Source", fsl_audmix_enum[1], + snd_soc_get_enum_double, fsl_audmix_put_out_src), SOC_ENUM("Output Width", fsl_audmix_enum[2]), SOC_ENUM("Frame Rate Diff Error", fsl_audmix_enum[3]), SOC_ENUM("Clock Freq Diff Error", fsl_audmix_enum[4]), -- 2.34.1

1 0

[PATCH 0/2] ASoC: SOF: Intel: add missing PCI IDs
by Pierre-Louis Bossart 22 Sep '22

22 Sep '22

Two missing PCI IDs already added to hda_intel.c and missed in SOF. Pierre-Louis Bossart (2): ASoC: SOF: Intel: pci-tgl: reorder PCI IDs ASoC: SOF: pci-tgl: add missing PCI IDs for RPL sound/soc/sof/intel/pci-tgl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.34.1

2 3

[PATCH] ASoC: es8316: fix register sync error in suspend/resume tests
by Pierre-Louis Bossart 22 Sep '22

22 Sep '22

The SOF CI tests report failures with the following error thrown kernel: es8316 i2c-ESSX8336:00: Unable to sync registers 0x0-0x1. -121 ES8336 only supports I2C read/write one byte a time, so we do need to set the .use_single_read and .use_single_write flags to avoid this sync issue. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: FRED OH <fred.oh(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- sound/soc/codecs/es8316.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index 8643014472ae6..056c3082fe02c 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -815,6 +815,8 @@ static const struct regmap_access_table es8316_volatile_table = { static const struct regmap_config es8316_regmap = { .reg_bits = 8, .val_bits = 8, + .use_single_read = true, + .use_single_write = true, .max_register = 0x53, .volatile_table = &es8316_volatile_table, .cache_type = REGCACHE_RBTREE, -- 2.34.1

2 1

[PATCH linux-next] ALSA: hda/ca0132 - remove the unneeded result variable
by cgel.zte＠gmail.com 22 Sep '22

22 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Return the value dsp_allocate_ports() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/pci/hda/patch_ca0132.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 208933792787..9580fe00cbd9 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -2962,7 +2962,6 @@ static int dsp_allocate_ports_format(struct hda_codec *codec, const unsigned short fmt, unsigned int *port_map) { - int status; unsigned int num_chans; unsigned int sample_rate_div = ((get_hdafmt_rate(fmt) >> 0) & 3) + 1; @@ -2976,9 +2975,7 @@ static int dsp_allocate_ports_format(struct hda_codec *codec, num_chans = get_hdafmt_chs(fmt) + 1; - status = dsp_allocate_ports(codec, num_chans, rate_multi, port_map); - - return status; + return dsp_allocate_ports(codec, num_chans, rate_multi, port_map); } /* -- 2.25.1

2 1

[PATCH] ALSA: hda: intel-dsp-config: add missing RaptorLake PCI IDs
by Pierre-Louis Bossart 22 Sep '22

22 Sep '22

These two missed IDs need to be added for dynamic selection of drivers. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/hda/intel-dsp-config.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c index 1997ffc16663a..b9eb3208f2888 100644 --- a/sound/hda/intel-dsp-config.c +++ b/sound/hda/intel-dsp-config.c @@ -455,6 +455,16 @@ static const struct config_entry config_table[] = { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = 0x51cb, }, + /* RaptorLake-M */ + { + .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, + .device = 0x51ce, + }, + /* RaptorLake-PX */ + { + .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, + .device = 0x51cf, + }, #endif }; -- 2.34.1

2 1

[GIT PULL] ASoC fixes for v6.0-rc6
by Mark Brown 22 Sep '22

22 Sep '22

The following changes since commit 80e78fcce86de0288793a0ef0f6acf37656ee4cf: Linux 6.0-rc5 (2022-09-11 16:22:01 -0400) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.0-rc6 for you to fetch changes up to 0a0342ede303fc420f3a388e1ae82da3ae8ff6bd: ASoC: tas2770: Reinit regcache on reset (2022-09-19 18:48:43 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.0 A few device specific fixes, nothing too large, and a new device ID for a Dell laptop. ---------------------------------------------------------------- Martin Povišer (1): ASoC: tas2770: Reinit regcache on reset Oder Chiou (1): ASoC: rt5640: Fix the issue of the abnormal JD2 status Pierre-Louis Bossart (1): ASoC: Intel: sof_sdw: add support for Dell SKU 0AFF SJLIN0 (1): ASoC: nau8824: Fix semaphore is released unexpectedly Shengjiu Wang (1): ASoC: imx-card: Fix refcount issue with of_node_put sound/soc/codecs/nau8824.c | 17 +++++++++-- sound/soc/codecs/nau8824.h | 1 + sound/soc/codecs/rt5640.c | 64 ++++++++++++++++++++++++++++------------ sound/soc/codecs/rt5640.h | 14 +++++++++ sound/soc/codecs/tas2770.c | 3 ++ sound/soc/fsl/imx-card.c | 4 +++ sound/soc/intel/boards/sof_sdw.c | 10 +++++++ 7 files changed, 91 insertions(+), 22 deletions(-)

2 1

KASAN: use-after-free Write in snd_rawmidi_receive
by Rondreis 22 Sep '22

22 Sep '22

Hello, When fuzzing the Linux kernel driver v5.18.0, the following crash was triggered. HEAD commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f git tree: upstream kernel config: https://pastebin.com/raw/KecL2gaG console output: https://pastebin.com/raw/aJGZYGs4 Sorry for failing to extract the reproducer. But on other versions of Linux, I also triggered this crash. I would appreciate it if you have any idea how to solve this bug. The crash report is as follows: ================================================================== BUG: KASAN: use-after-free in snd_rawmidi_receive+0x2f6/0xe70 sound/core/rawmidi.c:1097 Write of size 3 at addr ffff88803cf1a05a by task kworker/u8:6/13973 CPU: 3 PID: 13973 Comm: kworker/u8:6 Not tainted 5.18.0 #2 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Workqueue: bat_events batadv_nc_worker Call Trace: <IRQ> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 print_address_description mm/kasan/report.c:313 [inline] print_report.cold+0xe5/0x659 mm/kasan/report.c:429 kasan_report+0x8a/0x1b0 mm/kasan/report.c:491 check_region_inline mm/kasan/generic.c:183 [inline] kasan_check_range+0x13b/0x190 mm/kasan/generic.c:189 memcpy+0x39/0x60 mm/kasan/shadow.c:66 snd_rawmidi_receive+0x2f6/0xe70 sound/core/rawmidi.c:1097 f_midi_read_data drivers/usb/gadget/function/f_midi.c:253 [inline] f_midi_handle_out_data.isra.0+0x1ee/0x290 drivers/usb/gadget/function/f_midi.c:265 f_midi_complete+0x3b7/0x480 drivers/usb/gadget/function/f_midi.c:280 transfer drivers/usb/gadget/udc/dummy_hcd.c:1516 [inline] dummy_timer+0x1866/0x33b0 drivers/usb/gadget/udc/dummy_hcd.c:1972 call_timer_fn+0x1a5/0x6b0 kernel/time/timer.c:1421 expire_timers kernel/time/timer.c:1466 [inline] __run_timers kernel/time/timer.c:1737 [inline] __run_timers kernel/time/timer.c:1710 [inline] run_timer_softirq+0x1084/0x16d0 kernel/time/timer.c:1750 __do_softirq+0x1d0/0x908 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu kernel/softirq.c:637 [inline] irq_exit_rcu+0xf2/0x130 kernel/softirq.c:649 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1097 </IRQ> <TASK> asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:645 RIP: 0010:lock_release+0x3f0/0x670 kernel/locking/lockdep.c:5649 Code: 7e 83 f8 01 0f 85 59 01 00 00 9c 58 f6 c4 02 0f 85 44 01 00 00 48 f7 04 24 00 02 00 00 74 01 fb 48 b8 00 00 00 00 00 fc ff df <48> 01 c5 48 c7 45 00 00 00 00 00 c7 45 08 00 00 00 00 48 8b 84 24 RSP: 0018:ffffc90008a0fb90 EFLAGS: 00000206 RAX: dffffc0000000000 RBX: c422640388757846 RCX: 0000000000000000 RDX: 1ffff11007b1f892 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 1ffff92001141f74 R08: 0000000000000001 R09: fffffbfff1ce851b R10: ffffffff8e7428d7 R11: fffffbfff1ce851a R12: 0000000000000002 R13: ffff88803d8fc498 R14: 0000000000000003 R15: ffff88803d8fba80 rcu_lock_release include/linux/rcupdate.h:273 [inline] rcu_read_unlock include/linux/rcupdate.h:727 [inline] batadv_nc_process_nc_paths.part.0+0x235/0x3c0 net/batman-adv/network-coding.c:699 batadv_nc_process_nc_paths net/batman-adv/network-coding.c:679 [inline] batadv_nc_worker+0x54f/0x770 net/batman-adv/network-coding.c:728 process_one_work+0x9cc/0x1650 kernel/workqueue.c:2289 worker_thread+0x623/0x1070 kernel/workqueue.c:2436 kthread+0x2e9/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298 </TASK> Allocated by task 17441: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track mm/kasan/common.c:45 [inline] set_alloc_info mm/kasan/common.c:436 [inline] ____kasan_kmalloc mm/kasan/common.c:515 [inline] ____kasan_kmalloc mm/kasan/common.c:474 [inline] __kasan_kmalloc+0xa9/0xd0 mm/kasan/common.c:524 kasan_kmalloc include/linux/kasan.h:234 [inline] __kmalloc_node+0x1fc/0x450 mm/slub.c:4462 kmalloc_node include/linux/slab.h:604 [inline] kvmalloc_node+0x3e/0x190 mm/util.c:580 kvmalloc include/linux/slab.h:731 [inline] kvzalloc include/linux/slab.h:739 [inline] snd_rawmidi_runtime_create sound/core/rawmidi.c:162 [inline] open_substream+0x340/0x8b0 sound/core/rawmidi.c:306 rawmidi_open_priv+0x2e8/0x6f0 sound/core/rawmidi.c:352 snd_rawmidi_kernel_open+0x1b5/0x270 sound/core/rawmidi.c:392 midisynth_subscribe+0xf2/0x380 sound/core/seq/seq_midi.c:171 subscribe_port sound/core/seq/seq_ports.c:412 [inline] check_and_subscribe_port+0x5be/0x810 sound/core/seq/seq_ports.c:495 snd_seq_port_connect+0x2e6/0x520 sound/core/seq/seq_ports.c:576 snd_seq_ioctl_subscribe_port+0x1df/0x310 sound/core/seq/seq_clientmgr.c:1492 snd_seq_kernel_client_ctl+0x105/0x1b0 sound/core/seq/seq_clientmgr.c:2369 snd_seq_oss_midi_open+0x3f4/0x670 sound/core/seq/oss/seq_oss_midi.c:368 snd_seq_oss_synth_reset+0x462/0x890 sound/core/seq/oss/seq_oss_synth.c:407 snd_seq_oss_reset+0x6f/0x290 sound/core/seq/oss/seq_oss_init.c:435 snd_seq_oss_release+0x79/0x160 sound/core/seq/oss/seq_oss_init.c:412 odev_release+0x4f/0x70 sound/core/seq/oss/seq_oss.c:144 __fput+0x277/0x9d0 fs/file_table.c:317 task_work_run+0xe0/0x1a0 kernel/task_work.c:164 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop kernel/entry/common.c:169 [inline] exit_to_user_mode_prepare+0x253/0x260 kernel/entry/common.c:201 __syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline] syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:294 do_syscall_64+0x42/0x80 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae Freed by task 17441: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track+0x21/0x30 mm/kasan/common.c:45 kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:370 ____kasan_slab_free mm/kasan/common.c:366 [inline] ____kasan_slab_free mm/kasan/common.c:328 [inline] __kasan_slab_free+0x11d/0x190 mm/kasan/common.c:374 kasan_slab_free include/linux/kasan.h:200 [inline] slab_free_hook mm/slub.c:1728 [inline] slab_free_freelist_hook mm/slub.c:1754 [inline] slab_free mm/slub.c:3510 [inline] kfree+0xec/0x4b0 mm/slub.c:4552 kvfree+0x42/0x50 mm/util.c:622 snd_rawmidi_runtime_free sound/core/rawmidi.c:176 [inline] close_substream.part.0+0x18e/0x650 sound/core/rawmidi.c:528 close_substream sound/core/rawmidi.c:507 [inline] rawmidi_release_priv+0xd3/0x270 sound/core/rawmidi.c:543 snd_rawmidi_kernel_release+0x39/0xd0 sound/core/rawmidi.c:564 midisynth_unsubscribe+0x3b/0x70 sound/core/seq/seq_midi.c:203 unsubscribe_port sound/core/seq/seq_ports.c:437 [inline] __delete_and_unsubscribe_port+0x279/0x4e0 sound/core/seq/seq_ports.c:537 delete_and_unsubscribe_port+0x59/0x80 sound/core/seq/seq_ports.c:549 snd_seq_port_disconnect+0x1ee/0x270 sound/core/seq/seq_ports.c:627 snd_seq_ioctl_unsubscribe_port+0x1df/0x310 sound/core/seq/seq_clientmgr.c:1537 snd_seq_kernel_client_ctl+0x105/0x1b0 sound/core/seq/seq_clientmgr.c:2369 snd_seq_oss_midi_close+0x2ff/0x470 sound/core/seq/oss/seq_oss_midi.c:410 snd_seq_oss_synth_cleanup+0x32c/0x480 sound/core/seq/oss/seq_oss_synth.c:307 snd_seq_oss_release+0x81/0x160 sound/core/seq/oss/seq_oss_init.c:414 odev_release+0x4f/0x70 sound/core/seq/oss/seq_oss.c:144 __fput+0x277/0x9d0 fs/file_table.c:317 task_work_run+0xe0/0x1a0 kernel/task_work.c:164 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop kernel/entry/common.c:169 [inline] exit_to_user_mode_prepare+0x253/0x260 kernel/entry/common.c:201 __syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline] syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:294 do_syscall_64+0x42/0x80 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae The buggy address belongs to the object at ffff88803cf1a000 which belongs to the cache kmalloc-4k of size 4096 The buggy address is located 90 bytes inside of 4096-byte region [ffff88803cf1a000, ffff88803cf1b000) The buggy address belongs to the physical page: page:ffffea0000f3c600 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3cf18 head:ffffea0000f3c600 order:3 compound_mapcount:0 compound_pincount:0 flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff) raw: 00fff00000010200 0000000000000000 dead000000000122 ffff888011843040 raw: 0000000000000000 0000000000040004 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 3, migratetype Unmovable, gfp_mask 0x1d20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL), pid 17441, tgid 17441 (syz-executor.0), ts 589072773595, free_ts 589014752799 set_page_owner include/linux/page_owner.h:31 [inline] post_alloc_hook mm/page_alloc.c:2434 [inline] prep_new_page+0x297/0x330 mm/page_alloc.c:2441 get_page_from_freelist+0x210e/0x3ab0 mm/page_alloc.c:4182 __alloc_pages+0x30c/0x6e0 mm/page_alloc.c:5408 alloc_pages+0x119/0x250 mm/mempolicy.c:2272 alloc_slab_page mm/slub.c:1799 [inline] allocate_slab mm/slub.c:1944 [inline] new_slab+0x2a9/0x3f0 mm/slub.c:2004 ___slab_alloc+0xc62/0x1080 mm/slub.c:3005 __slab_alloc.isra.0+0x4d/0xa0 mm/slub.c:3092 slab_alloc_node mm/slub.c:3183 [inline] __kmalloc_node+0x340/0x450 mm/slub.c:4458 kmalloc_node include/linux/slab.h:604 [inline] kvmalloc_node+0x3e/0x190 mm/util.c:580 kvmalloc include/linux/slab.h:731 [inline] kvzalloc include/linux/slab.h:739 [inline] snd_rawmidi_runtime_create sound/core/rawmidi.c:162 [inline] open_substream+0x340/0x8b0 sound/core/rawmidi.c:306 rawmidi_open_priv+0x592/0x6f0 sound/core/rawmidi.c:357 snd_rawmidi_kernel_open+0x1b5/0x270 sound/core/rawmidi.c:392 midisynth_use+0xee/0x270 sound/core/seq/seq_midi.c:215 subscribe_port sound/core/seq/seq_ports.c:412 [inline] check_and_subscribe_port+0x5be/0x810 sound/core/seq/seq_ports.c:495 snd_seq_port_connect+0x382/0x520 sound/core/seq/seq_ports.c:581 snd_seq_ioctl_subscribe_port+0x1df/0x310 sound/core/seq/seq_clientmgr.c:1492 page last free stack trace: reset_page_owner include/linux/page_owner.h:24 [inline] free_pages_prepare mm/page_alloc.c:1356 [inline] free_pcp_prepare+0x51f/0xd00 mm/page_alloc.c:1406 free_unref_page_prepare mm/page_alloc.c:3328 [inline] free_unref_page+0x19/0x5b0 mm/page_alloc.c:3423 __unfreeze_partials+0x3d2/0x3f0 mm/slub.c:2523 do_slab_free mm/slub.c:3498 [inline] ___cache_free+0x12c/0x140 mm/slub.c:3517 qlink_free mm/kasan/quarantine.c:157 [inline] qlist_free_all+0x6a/0x170 mm/kasan/quarantine.c:176 kasan_quarantine_reduce+0x13d/0x180 mm/kasan/quarantine.c:283 __kasan_slab_alloc+0xa2/0xc0 mm/kasan/common.c:446 kasan_slab_alloc include/linux/kasan.h:224 [inline] slab_post_alloc_hook+0x4d/0x4f0 mm/slab.h:749 slab_alloc_node mm/slub.c:3217 [inline] slab_alloc mm/slub.c:3225 [inline] __kmem_cache_alloc_lru mm/slub.c:3232 [inline] kmem_cache_alloc+0x1be/0x460 mm/slub.c:3242 getname_flags fs/namei.c:138 [inline] getname_flags+0xd2/0x5b0 fs/namei.c:128 vfs_fstatat+0x73/0xb0 fs/stat.c:254 __do_sys_newfstatat+0x91/0x110 fs/stat.c:425 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae Memory state around the buggy address: ffff88803cf19f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff88803cf19f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff88803cf1a000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff88803cf1a080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff88803cf1a100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== ---------------- Code disassembly (best guess): 0: 7e 83 jle 0xffffff85 2: f8 clc 3: 01 0f add %ecx,(%rdi) 5: 85 59 01 test %ebx,0x1(%rcx) 8: 00 00 add %al,(%rax) a: 9c pushfq b: 58 pop %rax c: f6 c4 02 test $0x2,%ah f: 0f 85 44 01 00 00 jne 0x159 15: 48 f7 04 24 00 02 00 testq $0x200,(%rsp) 1c: 00 1d: 74 01 je 0x20 1f: fb sti 20: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax 27: fc ff df * 2a: 48 01 c5 add %rax,%rbp <-- trapping instruction 2d: 48 c7 45 00 00 00 00 movq $0x0,0x0(%rbp) 34: 00 35: c7 45 08 00 00 00 00 movl $0x0,0x8(%rbp) 3c: 48 rex.W 3d: 8b .byte 0x8b 3e: 84 .byte 0x84 3f: 24 .byte 0x24

2 1

[PATCH] ASoC: SOF: mediatek: add pcm_pointer callback for mt8186
by Chunxu Li 22 Sep '22

22 Sep '22

add pcm_pointer callback for mt8186 to support read host position from DSP Signed-off-by: Chunxu Li <chunxu.li(a)mediatek.com> --- sound/soc/sof/mediatek/mt8186/mt8186.c | 33 ++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c index 9ec89fc7fec0..181189e00e02 100644 --- a/sound/soc/sof/mediatek/mt8186/mt8186.c +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c @@ -470,6 +470,38 @@ static int mt8186_pcm_hw_params(struct snd_sof_dev *sdev, return 0; } +static snd_pcm_uframes_t mt8186_pcm_pointer(struct snd_sof_dev *sdev, + struct snd_pcm_substream *substream) +{ + int ret; + snd_pcm_uframes_t pos; + struct snd_sof_pcm *spcm; + struct sof_ipc_stream_posn posn; + struct snd_sof_pcm_stream *stream; + struct snd_soc_component *scomp = sdev->component; + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); + + spcm = snd_sof_find_spcm_dai(scomp, rtd); + if (!spcm) { + dev_warn_ratelimited(sdev->dev, "warn: can't find PCM with DAI ID %d\n", + rtd->dai_link->id); + return 0; + } + + stream = &spcm->stream[substream->stream]; + ret = snd_sof_ipc_msg_data(sdev, stream->substream, &posn, sizeof(posn)); + if (ret < 0) { + dev_warn(sdev->dev, "failed to read stream position: %d\n", ret); + return 0; + } + + memcpy(&stream->posn, &posn, sizeof(posn)); + pos = spcm->stream[substream->stream].posn.host_posn; + pos = bytes_to_frames(substream->runtime, pos); + + return pos; +} + static struct snd_soc_dai_driver mt8186_dai[] = { { .name = "SOF_DL1", @@ -537,6 +569,7 @@ static struct snd_sof_dsp_ops sof_mt8186_ops = { /* stream callbacks */ .pcm_open = sof_stream_pcm_open, .pcm_hw_params = mt8186_pcm_hw_params, + .pcm_pointer = mt8186_pcm_pointer, .pcm_close = sof_stream_pcm_close, /* firmware loading */ -- 2.25.1

4 3

[linux-next:master] BUILD REGRESSION 483fed3b5dc8ce3644c83d24240cf5756fb0993e
by kernel test robot 22 Sep '22

22 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 483fed3b5dc8ce3644c83d24240cf5756fb0993e Add linux-next specific files for 20220921 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.FQi69rLV-lkp@intel.com https://lore.kernel.org/linux-mm/202209060229.dVuyxjBv-lkp@intel.com https://lore.kernel.org/linux-mm/202209150141.WgbAKqmX-lkp@intel.com https://lore.kernel.org/linux-mm/202209160607.sE3qvgTy-lkp@intel.com https://lore.kernel.org/linux-mm/202209200603.Hpvoa8Ii-lkp@intel.com https://lore.kernel.org/linux-mm/202209200949.Vl3xrUYD-lkp@intel.com https://lore.kernel.org/llvm/202209220009.8nYpIPST-lkp@intel.com https://lore.kernel.org/llvm/202209220019.Yr2VuXhg-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) ERROR: modpost: "devm_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/dma/idma64.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/dma/qcom/hdma.ko] undefined! ERROR: modpost: "devm_memremap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_memunmap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/char/xillybus/xillybus_of.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/clk/xilinx/clk-xlnx-clock-wizard.ko] undefined! ERROR: modpost: "ioremap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/tty/ipwireless/ipwireless.ko] undefined! arch/arm64/kernel/alternative.c:199:6: warning: no previous prototype for 'apply_alternatives_vdso' [-Wmissing-prototypes] arch/arm64/kernel/alternative.c:295:14: warning: no previous prototype for 'alt_cb_patch_nops' [-Wmissing-prototypes] arch/ia64/kernel/sys_ia64.c:188:17: sparse: sparse: typename in expression arch/ia64/kernel/sys_ia64.c:188:31: sparse: sparse: Trying to use reserved word 'typeof' as identifier arch/ia64/kernel/sys_ia64.c:188:31: sparse: sparse: Trying to use reserved word 'void' as identifier arch/ia64/kernel/sys_ia64.c:189:60: sparse: sparse: invalid initializer arch/ia64/kernel/sys_ia64.c:190:17: sparse: sparse: Trying to use reserved word 'return' as identifier arch/parisc/lib/iomap.c:363:5: warning: no previous prototype for 'ioread64_lo_hi' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:373:5: warning: no previous prototype for 'ioread64_hi_lo' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:448:6: warning: no previous prototype for 'iowrite64_lo_hi' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:454:6: warning: no previous prototype for 'iowrite64_hi_lo' [-Wmissing-prototypes] drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration] drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration] mm/hugetlb.c:5539:14: warning: variable 'reserve_alloc' set but not used [-Wunused-but-set-variable] Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | `-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast |-- alpha-randconfig-s033-20220921 | `-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand |-- arm64-allyesconfig | |-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-alt_cb_patch_nops | |-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-apply_alternatives_vdso | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- arm64-randconfig-r013-20220921 | |-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-alt_cb_patch_nops | `-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-apply_alternatives_vdso |-- i386-allyesconfig | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-defconfig | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-randconfig-c021 | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-randconfig-m021 | `-- drivers-gpu-drm-display-drm_dp_helper.c-drm_dp_phy_name()-warn:unsigned-dp_phy-is-never-less-than-zero. |-- i386-randconfig-s001 | |-- arch-x86-kernel-signal.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__user-to-got-unsigned-long-long-usertype | |-- drivers-gpu-drm-tiny-simpledrm.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-vaddr-got-void-noderef-__iomem-screen_base | |-- drivers-gpu-drm-vkms-vkms_formats.c:sparse:sparse:cast-to-restricted-__le16 | |-- drivers-gpu-drm-vkms-vkms_formats.c:sparse:sparse:incorrect-type-in-assignment-(different-base-types)-expected-unsigned-short-usertype-got-restricted-__le16-usertype | `-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand |-- i386-randconfig-s002 | |-- arch-x86-kernel-signal.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__user-to-got-unsigned-long-long-usertype | |-- drivers-gpu-drm-tiny-simpledrm.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-vaddr-got-void-noderef-__iomem-screen_base | |-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-randconfig-s003 | |-- arch-x86-kernel-signal.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__user-to-got-unsigned-long-long-usertype | |-- drivers-gpu-drm-tiny-simpledrm.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-vaddr-got-void-noderef-__iomem-screen_base | |-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand | |-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used | `-- sound-soc-generic-simple-card-utils.c:sparse:sparse:incorrect-type-in-initializer-(different-base-types)-expected-unsigned-int-usertype-val-got-restricted-snd_pcm_format_t-usertype |-- ia64-allmodconfig | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- ia64-randconfig-s052-20220921 | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:Trying-to-use-reserved-word-return-as-identifier | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:Trying-to-use-reserved-word-typeof-as-identifier | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:Trying-to-use-reserved-word-void-as-identifier | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:invalid-initializer | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:typename-in-expression | |-- kernel-bpf-hashtab.c:sparse:sparse:cast-removes-address-space-__percpu-of-expression clang_recent_errors |-- arm-randconfig-r014-20220921 | `-- make:No-rule-to-make-target-drivers-crypto-aspeed-aspeed_crypto.o-needed-by-drivers-crypto-aspeed-built-in.a-. |-- arm-randconfig-r026-20220921 | |-- drivers-scsi-qla2xxx-qla_os.c:error:call-to-undeclared-function-trace_array_get_by_name-ISO-C99-and-later-do-not-support-implicit-function-declarations | |-- drivers-scsi-qla2xxx-qla_os.c:error:call-to-undeclared-function-trace_array_put-ISO-C99-and-later-do-not-support-implicit-function-declarations | `-- drivers-scsi-qla2xxx-qla_os.c:error:incompatible-integer-to-pointer-conversion-assigning-to-struct-trace_array-from-int |-- i386-randconfig-a015 | |-- ERROR:__cpuhp_remove_state-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:__cpuhp_setup_state-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:_printk-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:boot_cpu_data-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:cpu_bit_bitmap-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:perf_msr_probe-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:perf_pmu_register-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:perf_pmu_unregister-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:x86_match_cpu-arch-x86-events-intel-intel-cstate.ko-undefined | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- powerpc-randconfig-r006-20220921 | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-virtual-virtual_link_hwss.c:warning:no-previous-prototype-for-function-virtual_disable_link_output | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- x86_64-allyesconfig | |-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used `-- x86_64-randconfig-a016 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 728m configs tested: 67 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig i386 defconfig arm defconfig x86_64 randconfig-a004 x86_64 randconfig-a002 arc axs103_smp_defconfig arc randconfig-r043-20220921 arc defconfig x86_64 defconfig m68k allmodconfig powerpc allmodconfig loongarch allnoconfig riscv randconfig-r042-20220921 sh allmodconfig x86_64 rhel-8.3-kvm x86_64 rhel-8.3-kselftests s390 randconfig-r044-20220921 x86_64 rhel-8.3-syz x86_64 rhel-8.3-func x86_64 rhel-8.3-kunit arc allnoconfig arm viper_defconfig alpha allnoconfig arm lpd270_defconfig riscv allnoconfig csky allnoconfig m68k sun3x_defconfig sh sdk7780_defconfig sh sh03_defconfig sh ul2_defconfig i386 randconfig-a016 powerpc ppc6xx_defconfig powerpc klondike_defconfig powerpc mpc837x_mds_defconfig arm trizeps4_defconfig sh dreamcast_defconfig riscv nommu_k210_sdcard_defconfig powerpc sam440ep_defconfig powerpc pcm030_defconfig sh se7780_defconfig i386 randconfig-c001 powerpc wii_defconfig powerpc allnoconfig alpha defconfig x86_64 rhel-8.3 m68k allyesconfig s390 defconfig x86_64 allyesconfig s390 allmodconfig arc allyesconfig alpha allyesconfig s390 allyesconfig mips allyesconfig i386 allyesconfig ia64 allmodconfig arm64 allyesconfig arm allyesconfig clang tested configs: hexagon randconfig-r041-20220921 hexagon randconfig-r045-20220921 arm hackkit_defconfig s390 alldefconfig x86_64 randconfig-a016 i386 randconfig-a015 powerpc katmai_defconfig arm mvebu_v5_defconfig x86_64 randconfig-k001 x86_64 allyesconfig -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[PATCH] ASoC: SOF: ipc4-topology: Free the ida when IPC fails in sof_ipc4_widget_setup()
by Peter Ujfalusi 21 Sep '22

21 Sep '22

The allocated ida needs to be freed up if the IPC message fails since next time when we try again to set up the widget we are going to try to allocate another ID and given enough tries, we are going to run out of unique IDs. Fixes: 711d0427c713 ("ASoC: SOF: ipc4-topology: move ida allocate/free to widget_setup/free") Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/sof/ipc4-topology.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index 64929dc9af39..340d92452d7c 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -1544,9 +1544,16 @@ static int sof_ipc4_widget_setup(struct snd_sof_dev *sdev, struct snd_sof_widget msg->data_ptr = ipc_data; ret = sof_ipc_tx_message(sdev->ipc, msg, ipc_size, NULL, 0); - if (ret < 0) + if (ret < 0) { dev_err(sdev->dev, "failed to create module %s\n", swidget->widget->name); + if (swidget->id != snd_soc_dapm_scheduler) { + struct sof_ipc4_fw_module *fw_module = swidget->module_info; + + ida_free(&fw_module->m_ida, swidget->instance_id); + } + } + return ret; } -- 2.37.3

2 1