- Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH -mm] sound/pci/au88x0/au88x0_eq.c remove unused code
by Michal Piotrowski 25 Mar '07

25 Mar '07

This patch is against the latest -mm snapshot. Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski(a)gmail.com> --- linux-work5/sound/pci/au88x0/au88x0_eq.c 2007-02-04 19:44:54.000000000 +0100 +++ linux-work3/sound/pci/au88x0/au88x0_eq.c 2007-03-25 17:13:31.000000000 +0200 @@ -142,34 +142,6 @@ static void vortex_EqHw_SetRightStates(v } } -#if 0 -static void vortex_EqHw_GetTimeConsts(vortex_t * vortex, u16 * a, u16 * b) -{ - *a = hwread(vortex->mmio, 0x2b3c4); - *b = hwread(vortex->mmio, 0x2b3c8); -} - -static void vortex_EqHw_GetLeftCoefs(vortex_t * vortex, u16 a[]) -{ - -} - -static void vortex_EqHw_GetRightCoefs(vortex_t * vortex, u16 a[]) -{ - -} - -static void vortex_EqHw_GetLeftStates(vortex_t * vortex, u16 * a, u16 b[]) -{ - -} - -static void vortex_EqHw_GetRightStates(vortex_t * vortex, u16 * a, u16 b[]) -{ - -} - -#endif /* Mix Gains */ static void vortex_EqHw_SetBypassGain(vortex_t * vortex, u16 a, u16 b) { @@ -190,22 +162,6 @@ static void vortex_EqHw_SetA3DBypassGain hwwrite(vortex->mmio, 0x2b3f8, b); } -#if 0 -static void vortex_EqHw_SetCurrBypassGain(vortex_t * vortex, u16 a, u16 b) -{ - - hwwrite(vortex->mmio, 0x2b3d0, a); - hwwrite(vortex->mmio, 0x2b3e8, b); -} - -static void vortex_EqHw_SetCurrA3DBypassGain(vortex_t * vortex, u16 a, u16 b) -{ - - hwwrite(vortex->mmio, 0x2b3dc, a); - hwwrite(vortex->mmio, 0x2b3f4, b); -} - -#endif static void vortex_EqHw_SetLeftGainsSingleTarget(vortex_t * vortex, u16 index, u16 b) { @@ -258,68 +214,6 @@ static void vortex_EqHw_SetRightGainsCur } } -#if 0 -static void vortex_EqHw_GetLeftGainsTarget(vortex_t * vortex, u16 a[]) -{ - eqhw_t *eqhw = &(vortex->eq.this04); - int ebx = 0; - - if (eqhw->this04 < 0) - return; - - do { - a[ebx] = hwread(vortex->mmio, 0x2b02c + ebx * 0x30); - ebx++; - } - while (ebx < eqhw->this04); -} - -static void vortex_EqHw_GetRightGainsTarget(vortex_t * vortex, u16 a[]) -{ - eqhw_t *eqhw = &(vortex->eq.this04); - int ebx = 0; - - if (eqhw->this04 < 0) - return; - - do { - a[ebx] = hwread(vortex->mmio, 0x2b20c + ebx * 0x30); - ebx++; - } - while (ebx < eqhw->this04); -} - -static void vortex_EqHw_GetLeftGainsCurrent(vortex_t * vortex, u16 a[]) -{ - eqhw_t *eqhw = &(vortex->eq.this04); - int ebx = 0; - - if (eqhw->this04 < 0) - return; - - do { - a[ebx] = hwread(vortex->mmio, 0x2b028 + ebx * 0x30); - ebx++; - } - while (ebx < eqhw->this04); -} - -static void vortex_EqHw_GetRightGainsCurrent(vortex_t * vortex, u16 a[]) -{ - eqhw_t *eqhw = &(vortex->eq.this04); - int ebx = 0; - - if (eqhw->this04 < 0) - return; - - do { - a[ebx] = hwread(vortex->mmio, 0x2b208 + ebx * 0x30); - ebx++; - } - while (ebx < eqhw->this04); -} - -#endif /* EQ band levels settings */ static void vortex_EqHw_SetLevels(vortex_t * vortex, u16 peaks[]) { @@ -344,38 +238,6 @@ static void vortex_EqHw_SetLevels(vortex hwwrite(vortex->mmio, 0x2b3f0, peaks[3 + (eqhw->this04 * 2)]); } -#if 0 -static void vortex_EqHw_GetLevels(vortex_t * vortex, u16 a[]) -{ - eqhw_t *eqhw = &(vortex->eq.this04); - int ebx; - - if (eqhw->this04 < 0) - return; - - ebx = 0; - do { - a[ebx] = hwread(vortex->mmio, 0x2b024 + ebx * 0x30); - ebx++; - } - while (ebx < eqhw->this04); - - a[eqhw->this04] = hwread(vortex->mmio, 0x2b3cc); - a[eqhw->this04 + 1] = hwread(vortex->mmio, 0x2b3d8); - - ebx = 0; - do { - a[ebx + (eqhw->this04 + 2)] = - hwread(vortex->mmio, 0x2b204 + ebx * 0x30); - ebx++; - } - while (ebx < eqhw->this04); - - a[2 + (eqhw->this04 * 2)] = hwread(vortex->mmio, 0x2b3e4); - a[3 + (eqhw->this04 * 2)] = hwread(vortex->mmio, 0x2b3f0); -} - -#endif /* Global Control */ static void vortex_EqHw_SetControlReg(vortex_t * vortex, u32 reg) { @@ -387,18 +249,6 @@ static void vortex_EqHw_SetSampleRate(vo hwwrite(vortex->mmio, 0x2b440, ((sr & 0x1f) << 3) | 0xb800); } -#if 0 -static void vortex_EqHw_GetControlReg(vortex_t * vortex, u32 *reg) -{ - *reg = hwread(vortex->mmio, 0x2b440); -} - -static void vortex_EqHw_GetSampleRate(vortex_t * vortex, u32 *sr) -{ - *sr = (hwread(vortex->mmio, 0x2b440) >> 3) & 0x1f; -} - -#endif static void vortex_EqHw_Enable(vortex_t * vortex) { hwwrite(vortex->mmio, VORTEX_EQ_CTRL, 0xf001); @@ -552,29 +402,6 @@ static void vortex_Eqlzr_SetRightGain(vo vortex_EqHw_SetRightGainsSingleTarget(vortex, index, gain); } -#if 0 -static int -vortex_Eqlzr_GetAllBands(vortex_t * vortex, u16 * gains, s32 *cnt) -{ - eqlzr_t *eq = &(vortex->eq); - int si = 0; - - if (eq->this10 == 0) - return 1; - - { - if (vortex_Eqlzr_GetLeftGain(vortex, si, &gains[si])) - return 1; - if (vortex_Eqlzr_GetRightGain - (vortex, si, &gains[si + eq->this10])) - return 1; - si++; - } - while (eq->this10 > si) ; - *cnt = si * 2; - return 0; -} -#endif static int vortex_Eqlzr_SetAllBandsFromActiveCoeffSet(vortex_t * vortex) { eqlzr_t *eq = &(vortex->eq); @@ -678,14 +505,6 @@ static int vortex_Eqlzr_GetAllPeaks(vort return 0; } -#if 0 -static auxxEqCoeffSet_t *vortex_Eqlzr_GetActiveCoefSet(vortex_t * vortex) -{ - eqlzr_t *eq = &(vortex->eq); - - return (&(eq->coefset)); -} -#endif static void vortex_Eqlzr_init(vortex_t * vortex) { eqlzr_t *eq = &(vortex->eq);

1 0

[alsa-devel] [PATCH -mm] sound/pci/au88x0/au88x0.c remove unused code
by Michal Piotrowski 25 Mar '07

25 Mar '07

This patch is against the latest -mm snapshot. Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (PL) (http://www.stardust.webpages.pl/ltg/) LTG - Linux Testers Group (EN) (http://www.stardust.webpages.pl/linux_testers_group_en/) Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski(a)gmail.com> --- linux-work5/sound/pci/au88x0/au88x0.c 2007-02-04 19:44:54.000000000 +0100 +++ linux-work3/sound/pci/au88x0/au88x0.c 2007-03-25 17:10:42.000000000 +0200 @@ -313,23 +313,6 @@ snd_vortex_probe(struct pci_dev *pci, co vortex_gameport_register(chip); -#if 0 - if (snd_seq_device_new(card, 1, SNDRV_SEQ_DEV_ID_VORTEX_SYNTH, - sizeof(snd_vortex_synth_arg_t), &wave) < 0 - || wave == NULL) { - snd_printk(KERN_ERR "Can't initialize Aureal wavetable synth\n"); - } else { - snd_vortex_synth_arg_t *arg; - - arg = SNDRV_SEQ_DEVICE_ARGPTR(wave); - strcpy(wave->name, "Aureal Synth"); - arg->hwptr = vortex; - arg->index = 1; - arg->seq_ports = seq_ports[dev]; - arg->max_voices = max_synth_voices[dev]; - } -#endif - // (5) if ((err = pci_read_config_word(pci, PCI_DEVICE_ID, &(chip->device))) < 0) {

1 0

[alsa-devel] ALSA initialization still seems to be too late?
by Adrian Bunk 23 Mar '07

23 Mar '07

The commit below from 2005 (sic) seems to be an example that workarounds often have quite a long lifetime. Can we get this sorted out properly for 2.6.22? TIA Adrian commit c7ac6b42ffba28c350cbcd48268f46689f6eb1cc Author: Linus Torvalds <torvalds(a)g5.osdl.org> Date: Wed Dec 21 14:52:32 2005 -0800 Initialize drivers/media/video/saa7134 late When compiled-in, make sure the sound system has initialized before these drivers do. Reported by Adrian Bunk <bunk(a)stusta.de> (The right fix would be to make the sound core use "subsys_initcall()" and thus initialize before all normal drivers, but this is the quick and limited safe fix for 2.6.15). Signed-off-by: Linus Torvalds <torvalds(a)osdl.org> diff --git a/drivers/media/video/saa7134/saa7134-alsa.c b/drivers/media/video/saa7134/saa7134-alsa.c index 953d5fe..6752dd1 100644 --- a/drivers/media/video/saa7134/saa7134-alsa.c +++ b/drivers/media/video/saa7134/saa7134-alsa.c @@ -1028,7 +1028,8 @@ static void saa7134_alsa_exit(void) return; } -module_init(saa7134_alsa_init); +/* We initialize this late, to make sure the sound system is up and running */ +late_initcall(saa7134_alsa_init); module_exit(saa7134_alsa_exit); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Ricardo Cerqueira"); diff --git a/drivers/media/video/saa7134/saa7134-oss.c b/drivers/media/video/saa7134/saa7134-oss.c index 513a699..c450d57 100644 --- a/drivers/media/video/saa7134/saa7134-oss.c +++ b/drivers/media/video/saa7134/saa7134-oss.c @@ -1002,7 +1002,8 @@ static void saa7134_oss_exit(void) return; } -module_init(saa7134_oss_init); +/* We initialize this late, to make sure the sound system is up and running */ +late_initcall(saa7134_oss_init); module_exit(saa7134_oss_exit); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Gerd Knorr <kraxel(a)bytesex.org> [SuSE Labs]");

1 0

[alsa-devel] [5/5] 2.6.21-rc4: known regressions (v2)
by Adrian Bunk 23 Mar '07

23 Mar '07

This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involved with one or more of these issues. Due to the huge amount of recipients, please trim the Cc when answering. Subject : Oops when changing DVB-T adapter References : http://lkml.org/lkml/2007/3/9/212 Submitter : CIJOML <cijoml(a)volny.cz> Status : unknown Subject : USB: iPod doesn't work References : http://lkml.org/lkml/2007/3/21/320 Submitter : Tino Keitel <tino.keitel(a)gmx.de> Handled-By : Oliver Neukum <oneukum(a)suse.de> Status : problem is being debuggged Subject : snd_intel8x0: divide error: 0000 References : http://lkml.org/lkml/2007/3/5/252 Submitter : Michal Piotrowski <michal.k.k.piotrowski(a)gmail.com> Handled-By : Takashi Iwai <tiwai(a)suse.de> Status : problem is being debugged Subject : forcedeth: skb_over_panic References : http://bugzilla.kernel.org/show_bug.cgi?id=8058 Submitter : Albert Hopkins <kernel(a)marduk.letterboxes.org> Handled-By : Ayaz Abdulla <aabdulla(a)nvidia.com> Patch : http://bugzilla.kernel.org/show_bug.cgi?id=8058 Status : patch available

1 0

[alsa-devel] snd_pcm_writei() error: Write error: -32,Broken pipe
by John Utz 23 Mar '07

23 Mar '07

Hello; I am running into some trouble with writing out to the device, i get some sound and then i get the Write error. Heres the code fragment: if (-EAGAIN == (iErr = snd_pcm_writei(handle, pu8Frames, iSizPer))) continue; if (0 > iErr) { printf("Write error: %d,%s\n", iErr, snd_strerror(iErr)); Is the problem that my buffer (pointed to by pu8frames) isnt big enuf? or is this a different failure entirely. If so, what are the possibilities? tnx!

1 0

[alsa-devel] PCM -- no need to release params mem nor close handle?
by intellij 23 Mar '07

23 Mar '07

I am looking at PCM interface manual http://www.alsa-project.org/alsa-doc/alsa-lib/pcm.html It tells that there are an open and set_params functions but nothing about close(). Furthermore, the description of open() http://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#g8340c7dc0… neither tells that. Ok, I have realized from the examples. However, even the examples demonstrate no params deallocation. You call the snd_pcm_hw_params_alloca(&hwparams) but never release the allocated memory. Why? Thank you.

3 2

[alsa-devel] Supported architecture: m68knommu?
by Sven Johnsson 23 Mar '07

23 Mar '07

Hello, I am interested in building ALSA for the m68knommu architecture on uClinux. Is this possible? Best Regards, Sven

2 1

Re: [alsa-devel] Réf. : Where is _snd_pcm defined?
by intellij 23 Mar '07

23 Mar '07

Thank you for your answer. However, you information is not correct. I do not have the snd_pcm structure in the three copies of pcm.h I have in alsa-lib/include, arm-linux/alsa nor arm-linux/include. Peahaps, this is because my lib is slightly obsolete. Fortunately, today I have accidentally discovered the requested _snd_pcm structure in the alsa-lib/src/pcm/pcm_local.h. Excuse me for the fuss. BTW, we have fallen out of the mailing list. Forums are efficient only when there are many participants for two reasons: neighbors can provide more information and the same questions will be prevented from asking repeatedly. Do you think this case is different? > >Hello, > >If you get the alsa-driver sources, you can have everything you need (hope :-). >Note that in my typedefs.h, I don't have any _ at the beginin, so "struct snd_pcm" is in alsa-kernel/include/pcm.h. > >Regards, >JM > > >********************************* >This message and any attachments (the "message") are confidential and intended solely for the addressees. Any unauthorised >use or dissemination is prohibited. >Messages are susceptible to alteration. France Telecom Group shall not be liable for the message if altered, changed or >falsified. >If you are not the intended addressee of this message, please cancel it immediately and inform the sender. >******************************** -- Яндекс.Почта: объем почтового ящика не ограничен! http://mail.yandex.ru/monitoring/

2 1

[alsa-devel] Where is _snd_pcm defined?
by intellij 22 Mar '07

22 Mar '07

Hello, I have gone through all the source codes to wee the definition of snd_pcm_t and see that it is defined typedef struct _snd_pcm snd_pcm_t; But is has many fields inside! At least, name and fast_ops pointers should be there. I do not understand where are they hiding. Actually, I am an alsa user. However, the system occasionaly hangs on writing into the buffer (because the consumption stops). For this reason, I'm looking for the features for hacking the system. I have an idea of turning the printfs on/of in runtime by a shared flag. I could put the pointer to the flag into pcm, so that my application could modify it and the library functions would check it before printing the traces. Thank you.

1 0

[alsa-devel] (no subject)
by ODINOT Jean-Marc ETRALI 22 Mar '07

22 Mar '07

Hi Alsa gurus, I've to write an alsa driver for a custom card. I readed "writing an alsa driver" and other paper about alsa and drivers. Well I got a result, but not as good as I think it's possible with alsa. My card have 30 output slots (and 7 input slots), can be 8Khz or 16Khz (same rate for every slots), 16bits little endian by sample, can have one or more sample for each slot (same for every slots) in a frame, an hardware IT every frame (a frame is 30 slots :-). The purpose is to get, for each IT, a frame with all the datas. IT -> frame [channel1][channel2][channel3]...[channel30] channelX [sample1][sample2]...[sampleN] sampleX [16bitsle] At this time, I've something like a frame if I use channel30 with speaker-test -c30, but if I use channel1, alsa give me a buffer with many samples for channel1. And, just after oppening, I get an extra word. BTW I use .copy to get the buffer. My questions: -why the extra word (can I avoid it?)? -how set the buffer len to always have all my channels (used or not)? -is it possible to have more than a sample by channel contiguous? Think's it's all for today, but maybe your answers will give me more ideas :-) Thanx for replies (and please, forgive my awful english :-(, JM PS: sorry for my previous (and my first) post which was in html only ********************************* This message and any attachments (the "message") are confidential and intended solely for the addressees. Any unauthorised use or dissemination is prohibited. Messages are susceptible to alteration. France Telecom Group shall not be liable for the message if altered, changed or falsified. If you are not the intended addressee of this message, please cancel it immediately and inform the sender. ********************************

1 0