- Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: ASoC: Fix compile-time warning for tlv320aic23.c
by Arun KS 13 Oct '08

13 Oct '08

Fixes this warning: sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_write': sound/soc/codecs/tlv320aic23.c:104: warning: passing argument 2 of 'codec->hw_write' makes pointer from integer without a cast Replaces i2c smbus write function with standard i2c write function Signed-off-by: Arun KS <arunks(a)mistralsolutions.com> --- sound/soc/codecs/tlv320aic23.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c index bac7815..44308da 100644 --- a/sound/soc/codecs/tlv320aic23.c +++ b/sound/soc/codecs/tlv320aic23.c @@ -84,7 +84,7 @@ static int tlv320aic23_write(struct snd_soc_codec *codec, unsigned int reg, unsigned int value) { - u8 data; + u8 data[2]; /* TLV320AIC23 has 7 bit address and 9 bits of data * so we need to switch one data bit into reg and rest @@ -96,12 +96,12 @@ static int tlv320aic23_write(struct snd_soc_codec *codec, unsigned int reg, return -1; } - data = (reg << 1) | (value >> 8 & 0x01); + data[0] = (reg << 1) | (value >> 8 & 0x01); + data[1] = value & 0xff; tlv320aic23_write_reg_cache(codec, reg, value); - if (codec->hw_write(codec->control_data, data, - (value & 0xff)) == 0) + if (codec->hw_write(codec->control_data, data, 2) == 2) return 0; printk(KERN_ERR "%s cannot write %03x to register R%d\n", __func__, @@ -674,7 +674,7 @@ static int tlv320aic23_probe(struct platform_device *pdev) tlv320aic23_socdev = socdev; #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) - codec->hw_write = (hw_write_t) i2c_smbus_write_byte_data; + codec->hw_write = (hw_write_t) i2c_master_send; codec->hw_read = NULL; ret = i2c_add_driver(&tlv320aic23_i2c_driver); if (ret != 0) -- 1.5.3.4

3 2

[alsa-devel] ASUS V1Sn can have digout
by asto 13 Oct '08

13 Oct '08

Regarding this change: http://git.alsa-project.org/?p=alsa-kernel.git;a=commit;h=2522d7359301efadf… (Added support for Asus V1Sn) This card can have digital output, and indeed does in my situation. The patch above added to patch_realtek.c: SND_PCI_QUIRK(0x1043, 0x1633, "Asus V1Sn", ALC861VD_LENOVO) However, ALC861VD_LENOVO definition has no digout Is it possible to have digital out for this device configured in auto-probe rather than map to lenovo ? For now, I add a definition for it based on the lenovo and 3stack-660-digout: to patch_realtek.c [ALC660VD_V1S] = { .mixers = { alc861vd_3st_mixer }, .init_verbs = { alc861vd_volume_init_verbs, alc861vd_3stack_init_verbs, alc861vd_eapd_verbs, alc861vd_lenovo_unsol_verbs }, .num_dacs = ARRAY_SIZE(alc660vd_dac_nids), .dac_nids = alc660vd_dac_nids, .dig_out_nid = ALC861VD_DIGOUT_NID, .num_channel_mode = ARRAY_SIZE(alc861vd_3stack_2ch_modes), .channel_mode = alc861vd_3stack_2ch_modes, .input_mux = &alc861vd_capture_source, .unsol_event = alc861vd_lenovo_unsol_event, .init_hook = alc861vd_lenovo_automute, },

2 1

[alsa-devel] missing subject in my previous email
by Philippe CARRIERE 13 Oct '08

13 Oct '08

Sorry, I realized I omitted the subject in my previous email. Read ehci-hcd patch required by snd-usb-us122l Regards Phil.

1 0

Re: [alsa-devel] [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver
by matthias.nyffenegger＠bluewin.ch 13 Oct '08

13 Oct '08

Hi Takashi, Thank you for your quick answer, I am not that fast ;-) >At the next time, it'd be appreciate if you post the patch itself, >then we can review and give comments on the code in a reply. >Even if it's too big, you can split to several pieces. Ok. >Just checking it now, and soon found out that many components look >similar as AW2. We have already AW2 driver (whose authors cc'ed). >Can you reuse the code? Hm, I'm afraid not at his point. The existing AW2 driver is IMHO a very straight-forward implementation - with focus on AW2 - and does not provide generic code parts (apart saa7146 register addr. definitions) for reuse. Maybe that's why it has its own directory not named after the chipset? Besides that I have put much emphasis on providing an abstraction-layer for saa7146 chipset audio functionality, on top of which the audiowerk specific stuff is built. Hence it does not make much sense to me trying to reuse code of the existing AW2 driver. I hope you see my point and would appreciate your opinion on this. regards, Matthias ----Ursprüngliche Nachricht---- Von: tiwai(a)suse.de Datum: 19.09.2008 17:55 An: <matthias.nyffenegger(a)bluewin.ch> Kopie: "Cedric Bregardis"<cedric.bregardis(a)free.fr>, "Jean-Christian Hassler"<jhassler(a)free.fr>, <alsa-devel@alsa- project.org> Betreff: Re: [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver At Fri, 19 Sep 2008 09:10:00 +0000 (GMT), matthias.nyffenegger(a)bluewin.ch wrote: > > From: Matthias Nyffenegger <matthias.nyffenegger(a)bluewin.ch> > > Low-level ALSA driver for Emagic Audiowerk8 sound card. > Project page: http://sourceforge.net/projects/aw8-alsa First off, thanks for your patch. At the next time, it'd be appreciate if you post the patch itself, then we can review and give comments on the code in a reply. Even if it's too big, you can split to several pieces. > Built and tested with Vanilla 2.6.25.16, ALSA 1.0.14a. > > Signed-off-by: Matthias Nyffenegger <matthias.nyffenegger(a)bluewin.ch> > --- > This is a request for submission to ALSA-tree. > URL: http://downloads.sourceforge.net/aw8-alsa/aw-alsa-patch-0.2 Just checking it now, and soon found out that many components look similar as AW2. We have already AW2 driver (whose authors cc'ed). Can you reuse the code? thanks, Takashi

2 1

Re: [alsa-devel] Backported sbxfi driver (UNTESTED!)
by Takashi Iwai 13 Oct '08

13 Oct '08

At Fri, 10 Oct 2008 20:39:48 +0400, The Source wrote: > > 2008/10/10 Takashi Iwai <tiwai(a)suse.de> > > At Fri, 10 Oct 2008 01:26:15 -0500, > Ted T. Logian wrote: > > > > > > > > On Fri, 2008-10-10 at 08:01 +0200, Takashi Iwai wrote: > > > At Thu, 09 Oct 2008 15:17:58 -0500, > > > Ted T. Logian wrote: > > > > > > > > Sorry for the multiple posts, but once I rmmod snd-sbxfi, running > mixer does > > > > fine. It seems if I have snd-sbxfi loaded and I run alsamixer, it > locks the > > > > entire system. > > > > > > So, do you mean loading the driver itself doesn't lock up? If so, > > > it's better than I expected. > > > > > > Did you run ever PCM playback/capture before that? This is more > > > dangerous :) > > > > > > Also, please give your hardware details, as there are different models > > > for X-Fi, and some are handled pretty differently. > > > > > > [BTW, please stop top-posting, and avoid HTML mails for ML. It's easy > > > to switch to normal (plain) mail mode on Gmail, just a click.] > > > > > > > > > thanks, > > > > > > Takashi > > > > > > I think perhaps from uninstalling pulseaudio I got further. I can use > > mixer now, and it even has a "Master" device, but nothing else... > > > > however, I do get a lock up later. > > > > I get this from running aplay, too, if this helps... > > Thanks! That's rather a stupid bug. > The patch is below. > > Takashi > > diff --git a/sound/pci/sbxfi/sbxfi.c b/sound/pci/sbxfi/sbxfi.c > index 8066bf4..8a0eea0 100644 > --- a/sound/pci/sbxfi/sbxfi.c > +++ b/sound/pci/sbxfi/sbxfi.c > @@ -831,7 +831,7 @@ static struct sbxfi_port *sbxfi_port_alloc(struct > sbxfi *chip, > port->src[0] = src; > port->src[1] = src + 1; > spin_lock_irq(&chip->port_lock); > - list_add(&chip->port_list, &port->list); > + list_add(&port->list, &chip->port_list); > spin_unlock_irq(&chip->port_lock); > return port; > } > _______________________________________________ > Alsa-devel mailing list > Alsa-devel(a)alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > Hello, I have tried the driver with the fix you provided, but I couldn't get > anything. Kernel panic on any attempt to use sound or mixer. Also kernel panic > several seconds after Xorg starts. Each crash causes either hang or reboot so > I couldn't get any error messages. If there are some logs left, please tell me > where they are and I'll send them to you. > My card is X-Fi Platinum Fatality Champion Series. For testing, first try without X but just use Linux console, so that you have a better chance to see Oops messages. It's pretty important to see whether it's an Oops or a panic. Also, double-check whether you really installed the corrected drivers. Often it's missing in the right place by stupid reasons. For first tests, don't use any sound server. Try with aplay like: % aplay -Dhw foo.wav Try first 96kHz samples, 48kHz samples, and then others. thanks, Takashi

5 9

[alsa-devel] Creative Sound Blaster 5.1vx
by Zhi Xiong 13 Oct '08

13 Oct '08

Hi, I own a creative sound blaster 5.1vx card, its model is sb1070, and its based on CA0106 and an ADC I believed to be a WM8772S(74AAWR2) chip, for the rest, my weak eyes can't really see it. I tested the driver on 2.6.20 and 2.6.26, both of them didn't work, so I believed this model is not yet "supported" by the driver, I added the lines below into ca0106_chip_details inside ca0106_main.c and the card works. { .serial = 0x10041102, .name = "Sound Blaster 5.1vx [SB1070]", .gpio_type = 1, .i2c_adc = 1, .spi_dac = 1 } , But I don't really know what gpio_type, .i2c_adc, .spi_dac . I do noticed that setting gpio_type to 1 or 2 will work and not setting it will have some performance issue. I wish can write the code more accurately to the specs and hopefully this few lines of code will get added to the next alsa release for others to use. So, can anyone please explain to me what the 3 parameters do? Thanks in advanced. -- Cheers, Zhi Xiong

2 1

[alsa-devel] Issue with onboard sound on Toshiba A110-225
by Travis Place 13 Oct '08

13 Oct '08

Hey all, When working out an issue for a person in #alsa, i found that the onboard sound in their laptop (A110-225) has the Subsystem IDs 1179:ff01 . The card has an ALC861 codec.. the issue (non-fatal thankfully) is that the above mentioned Subsystem IDs match in patch_realtek.c to 'dallas' which is for an ALC861VD codec.. SND_PCI_QUIRK(0x1179, 0xff01, "DALLAS", ALC861VD_DALLAS), The user was getting the non-fatal: hda_codec: Unknown model for ALC861, trying auto-probe from BIOS... in dmesg.. I had the user force the 'toshiba' model (which is valid for ALC861) and the warning went away, and sound continues to work as it should.. Just wanted to make sure this problem (even though non-fatal) is documented, and we are aware of it. Perhaps this laptop, and the 'Dallas' need to be matched on some other level. Thanks, Travis Place (wishie)

2 2

Re: [alsa-devel] Backported sbxfi driver (UNTESTED!)
by Takashi Iwai 13 Oct '08

13 Oct '08

At Sun, 12 Oct 2008 20:16:10 -0500, Christopher Lemire wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Sun, Oct 12, 2008 at 2:34 PM, Takashi Iwai wrote: > > At Sat, 11 Oct 2008 13:04:02 -0500, > > William Pitcock wrote: > >> > >> Hi, > >> > >> On Sat, 2008-10-11 at 19:41 +0200, Takashi Iwai wrote: > >> > Could you build with XXX_CONST_TIMER defined? This will disable the > >> > adaptive timer-resolution handling I added to the driver, which > >> > doesn't > >> > exist in OSS sbxfi code at all. > >> > >> No change in behaviour. It survives a little longer, but then the system > >> hardlocks... without me even touching the keyboard even. > > > > This can be a spin deadlock I fixed today. > > Could you try the latest sound-unstable GIT or snapshot tarball? > > > > Also, now the driver has "debug" module option. As default, it's 1, > > and the driver shows some debug messages. When it's 2, it shows more > > often, e.g. at each IRQ. When it's 3, it shows all register accesses. > > > > The debug option can be changed even dynamically via sysfs. Write > > /sys/modules/snd_sbxfi/parameters/debug file as root, > > # echo 3 > /sys/modules/..../debug > > > > Just a note before I go to bed :) > > > > Takashi > > _______________________________________________ > > Alsa-devel mailing list > > Alsa-devel(a)alsa-project.org > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > > > Would someone mind telling me how I can put my card in hda-intel mode > and use the snd-hda-intel driver with it? I read it was possible to do > that with the creative windows software but didn't see that anywhere. > Is there any reason I shouldn't do that? Do I really need any Xfi > driver when I can do that? My Xfi card is a newer one that should have > the hda-intel mode. It's Vista compatible (though I use it dual boot > with xp) and a newer PCIe model called Titanium. It's newer than the > Creative Linux beta driver, so it will not work with that or OSS4. I > just removed OSS4 and going back to Alsa to test that snd-sbxfi > because OSS4 would crash my computer with this sound card. I think the > OSS4 was written for older Xfi models, not this newer PCIe model I > have. Chances of me getting it to work in Linux aren't good, so I'll > probably be doing a RMA on it in the next few days before I run out of > time to do that and going back to using onboard audio. The sound-unstable tree contains the HD-audio X-Fi support, but right now it's disabled due to possible conflicts of drivers. Just uncomment the corresponding entries in PCI entries of sound/pci/hda_intel.c. Takashi

1 0

[alsa-devel] sound and sound-unstable git tree rebased
by Takashi Iwai 13 Oct '08

13 Oct '08

Hi, I rebased the whole sound GIT tree right now due to major conflicts with the upstream. Some commits order were changed due to manual pick-ups, but I think I picked all old commits. Please check whether anything missing. Also, the master branch is now pointing to the latest upstream, that is, ahead from 2.6.27. I revived the "devel" branch again for tracking the 2.6.27 tree. If you use 2.6.27 kernel but would like to track ALSA development, use this branch instead of master. Many topic branches vanished now because of the successful merges. There will be still topic/hda and topic/asoc branches, and occasionally more. The sound-unstable GIT tree is rebased as well. This is a usual thing, though... Sorry for inconvenience. Takashi

1 0

[alsa-devel] ALSA: ASoC codec: remove unused #include <version.h>
by Huang Weiyi 13 Oct '08

13 Oct '08

The files below do not use LINUX_VERSION_CODE nor KERNEL_VERSION. sound/soc/codecs/ad1980.c sound/soc/codecs/wm8580.c sound/soc/codecs/wm8900.c This patch removes the said #include <version.h>. Signed-off-by: Huang Weiyi <weiyi.huang(a)gmail.com> diff --git a/sound/soc/codecs/ad1980.c b/sound/soc/codecs/ad1980.c index 4e09c1f..1397b8e 100644 --- a/sound/soc/codecs/ad1980.c +++ b/sound/soc/codecs/ad1980.c @@ -13,7 +13,6 @@ #include <linux/init.h> #include <linux/module.h> -#include <linux/version.h> #include <linux/kernel.h> #include <linux/device.h> #include <sound/core.h> diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c index df1ffbe..a10edda 100644 --- a/sound/soc/codecs/wm8580.c +++ b/sound/soc/codecs/wm8580.c @@ -18,7 +18,6 @@ #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/version.h> #include <linux/kernel.h> #include <linux/init.h> #include <linux/delay.h> diff --git a/sound/soc/codecs/wm8900.c b/sound/soc/codecs/wm8900.c index 0b8c6d3..3b326c9 100644 --- a/sound/soc/codecs/wm8900.c +++ b/sound/soc/codecs/wm8900.c @@ -18,7 +18,6 @@ #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/version.h> #include <linux/kernel.h> #include <linux/init.h> #include <linux/delay.h>

2 1