- Alsa-devel - mailman.alsa-project.org

[PATCH v3] ASoC: dt-bindings: wm8510: Convert to dtschema
by Saalim Quadri 05 Apr '23

05 Apr '23

Convert the WM8510 audio CODEC bindings to DT schema Signed-off-by: Saalim Quadri <danascape(a)gmail.com> --- Changes from V2 -> V3: > Drop unneeded SPI example Changes from V1 -> V2: > Added cirrus opensource as the maintainer > Added missing $ref to dai-common.yaml > Dropped I2C and SPI description > Added sound-dai-cells property > Added 'compatible' as the required property > additionalProperties: false -> unevaluatedProperties: false after adding $ref > Added SPI example .../devicetree/bindings/sound/wlf,wm8510.yaml | 41 +++++++++++++++++++ .../devicetree/bindings/sound/wm8510.txt | 18 -------- 2 files changed, 41 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file mode 100644 index 000000000000..6d12b0ac37e2 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: WM8510 audio CODEC + +maintainers: + - patches(a)opensource.cirrus.com + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: wlf,wm8510 + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + codec@1a { + compatible = "wlf,wm8510"; + reg = <0x1a>; + }; + }; diff --git a/Documentation/devicetree/bindings/sound/wm8510.txt b/Documentation/devicetree/bindings/sound/wm8510.txt deleted file mode 100644 index e6b6cc041f89..000000000000 --- a/Documentation/devicetree/bindings/sound/wm8510.txt +++ /dev/null @@ -1,18 +0,0 @@ -WM8510 audio CODEC - -This device supports both I2C and SPI (configured with pin strapping -on the board). - -Required properties: - - - compatible : "wlf,wm8510" - - - reg : the I2C address of the device for I2C, the chip select - number for SPI. - -Example: - -wm8510: codec@1a { - compatible = "wlf,wm8510"; - reg = <0x1a>; -}; -- 2.34.1

2 1

[PATCH v2] ASoC: dt-bindings: wm8510: Convert to dtschema
by Saalim Quadri 05 Apr '23

05 Apr '23

Convert the WM8510 audio CODEC bindings to DT schema Signed-off-by: Saalim Quadri <danascape(a)gmail.com> --- Changes: V1 - V2: Fixup issues mentioned by Krzysztof Add SPI and I2C examples .../devicetree/bindings/sound/wlf,wm8510.yaml | 52 +++++++++++++++++++ .../devicetree/bindings/sound/wm8510.txt | 18 ------- 2 files changed, 52 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file mode 100644 index 000000000000..418a82f65531 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: WM8510 audio CODEC + +maintainers: + - patches(a)opensource.cirrus.com + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: wlf,wm8510 + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + codec@0 { + compatible = "wlf,wm8510"; + reg = <0>; + }; + }; + + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + codec@1a { + compatible = "wlf,wm8510"; + reg = <0x1a>; + }; + }; diff --git a/Documentation/devicetree/bindings/sound/wm8510.txt b/Documentation/devicetree/bindings/sound/wm8510.txt deleted file mode 100644 index e6b6cc041f89..000000000000 --- a/Documentation/devicetree/bindings/sound/wm8510.txt +++ /dev/null @@ -1,18 +0,0 @@ -WM8510 audio CODEC - -This device supports both I2C and SPI (configured with pin strapping -on the board). - -Required properties: - - - compatible : "wlf,wm8510" - - - reg : the I2C address of the device for I2C, the chip select - number for SPI. - -Example: - -wm8510: codec@1a { - compatible = "wlf,wm8510"; - reg = <0x1a>; -}; -- 2.34.1

3 3

[PATCH] ASoC: SOF: pm: Tear down pipelines only if DSP was active
by Daniel Baluta 05 Apr '23

05 Apr '23

From: Daniel Baluta <daniel.baluta(a)nxp.com> With PCI if the device was suspended it is brought back to full power and then suspended again. This doesn't happen when device is described via DT. We need to make sure that we tear down pipelines only if the device was previously active (thus the pipelines were setup). Otherwise, we can break the use_count: [ 219.009743] sof-audio-of-imx8m 3b6e8000.dsp: sof_ipc3_tear_down_all_pipelines: widget PIPELINE.2.SAI3.IN is still in use: count -1 and after this everything stops working. Fixes: d185e0689abc ("ASoC: SOF: pm: Always tear down pipelines before DSP suspend") Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Signed-off-by: Daniel Baluta <daniel.baluta(a)nxp.com> --- sound/soc/sof/pm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/pm.c b/sound/soc/sof/pm.c index c74ce8d414e7..2fdbc53ca715 100644 --- a/sound/soc/sof/pm.c +++ b/sound/soc/sof/pm.c @@ -188,6 +188,7 @@ static int sof_suspend(struct device *dev, bool runtime_suspend) const struct sof_ipc_tplg_ops *tplg_ops = sof_ipc_get_ops(sdev, tplg); pm_message_t pm_state; u32 target_state = snd_sof_dsp_power_target(sdev); + u32 old_state = sdev->dsp_power_state.state; int ret; /* do nothing if dsp suspend callback is not set */ @@ -197,7 +198,12 @@ static int sof_suspend(struct device *dev, bool runtime_suspend) if (runtime_suspend && !sof_ops(sdev)->runtime_suspend) return 0; - if (tplg_ops && tplg_ops->tear_down_all_pipelines) + /* we need to tear down pipelines only if the DSP hardware is + * active, which happens for PCI devices. if the device is + * suspended, it is brought back to full power and then + * suspended again + */ + if (tplg_ops && tplg_ops->tear_down_all_pipelines && (old_state == SOF_DSP_PM_D0)) tplg_ops->tear_down_all_pipelines(sdev, false); if (sdev->fw_state != SOF_FW_BOOT_COMPLETE) -- 2.25.1

2 2

KASAN: use-after-free Read in snd_pcm_plug_read_transfer
by Dae R. Jeong 05 Apr '23

05 Apr '23

Hi, We observed an issue "KASAN: use-after-free Read in snd_pcm_plug_read_transfer". Unfortunately, we have not found a reproducer for the crash. We will inform you if we have any update on this crash. Detailed crash information is attached below. Best regards, Dae R. Jeong ----- - Kernel version: 6.0-rc7 - Crash report: ================================================================== BUG: KASAN: use-after-free in snd_pcm_plug_read_transfer+0x2e6/0x4e0 sound/core/oss/pcm_plugin.c:653 Read of size 8 at addr ffff88801fb82e60 by task syz-executor.0/3194 CPU: 2 PID: 3194 Comm: syz-executor.0 Not tainted 6.0.0-rc7-00167-g92162e4a9862 #2 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1cf/0x2b7 lib/dump_stack.c:106 print_address_description+0x21/0x470 mm/kasan/report.c:317 print_report+0x108/0x1f0 mm/kasan/report.c:433 kasan_report+0xe5/0x110 mm/kasan/report.c:495 snd_pcm_plug_read_transfer+0x2e6/0x4e0 sound/core/oss/pcm_plugin.c:653 snd_pcm_oss_read2 sound/core/oss/pcm_oss.c:1493 [inline] snd_pcm_oss_read1+0x7a0/0x1130 sound/core/oss/pcm_oss.c:1531 vfs_read+0x31e/0xd30 fs/read_write.c:468 ksys_read+0x182/0x2c0 fs/read_write.c:607 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4e/0xa0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x4725fd Code: 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3e600f5be8 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 RAX: ffffffffffffffda RBX: 0000000000582928 RCX: 00000000004725fd RDX: 0000000000000016 RSI: 0000000020000140 RDI: 0000000000000007 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000582930 R13: 0000000000582934 R14: 00007fff5bd8fb10 R15: 00007f3e600f5d80 </TASK> Allocated by task 3193: kasan_save_stack mm/kasan/common.c:38 [inline] kasan_set_track mm/kasan/common.c:45 [inline] set_alloc_info mm/kasan/common.c:437 [inline] ____kasan_kmalloc+0xcd/0x100 mm/kasan/common.c:516 kasan_kmalloc include/linux/kasan.h:234 [inline] __kmalloc+0x31e/0x490 mm/slub.c:4429 kmalloc include/linux/slab.h:605 [inline] kzalloc include/linux/slab.h:733 [inline] snd_pcm_plugin_build+0x5e/0x560 sound/core/oss/pcm_plugin.c:164 snd_pcm_plugin_build_rate+0x22d/0x720 sound/core/oss/rate.c:324 snd_pcm_plug_format_plugins+0xb5f/0x1b80 sound/core/oss/pcm_plugin.c:478 snd_pcm_oss_change_params_locked+0x2c06/0x4e20 sound/core/oss/pcm_oss.c:986 snd_pcm_oss_change_params sound/core/oss/pcm_oss.c:1116 [inline] snd_pcm_oss_get_active_substream+0x244/0x2b0 sound/core/oss/pcm_oss.c:1133 snd_pcm_oss_get_rate sound/core/oss/pcm_oss.c:1790 [inline] snd_pcm_oss_set_rate sound/core/oss/pcm_oss.c:1782 [inline] snd_pcm_oss_ioctl+0x217b/0x4190 sound/core/oss/pcm_oss.c:2638 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0x110/0x180 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4e/0xa0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0xcd Freed by task 3195: kasan_save_stack mm/kasan/common.c:38 [inline] kasan_set_track+0x3d/0x60 mm/kasan/common.c:45 kasan_set_free_info+0x1f/0x40 mm/kasan/generic.c:370 ____kasan_slab_free+0x134/0x1c0 mm/kasan/common.c:367 kasan_slab_free include/linux/kasan.h:200 [inline] slab_free_hook mm/slub.c:1759 [inline] slab_free_freelist_hook+0x278/0x370 mm/slub.c:1785 slab_free mm/slub.c:3539 [inline] kfree+0x108/0x460 mm/slub.c:4567 snd_pcm_plugin_free+0xd1/0xe0 sound/core/oss/pcm_plugin.c:199 snd_pcm_oss_plugin_clear sound/core/oss/pcm_oss.c:547 [inline] snd_pcm_oss_release_buffers sound/core/oss/pcm_oss.c:852 [inline] snd_pcm_oss_change_params_locked+0x11d9/0x4e20 sound/core/oss/pcm_oss.c:1096 snd_pcm_oss_change_params sound/core/oss/pcm_oss.c:1116 [inline] snd_pcm_oss_make_ready sound/core/oss/pcm_oss.c:1175 [inline] snd_pcm_oss_set_trigger+0x45f/0xf70 sound/core/oss/pcm_oss.c:2092 snd_pcm_oss_poll+0x810/0xab0 sound/core/oss/pcm_oss.c:2878 vfs_poll include/linux/poll.h:88 [inline] p9_fd_poll net/9p/trans_fd.c:233 [inline] p9_conn_create+0x52f/0x700 net/9p/trans_fd.c:598 p9_fd_create+0x3e0/0x4c0 net/9p/trans_fd.c:1077 p9_client_create+0x916/0x11d0 net/9p/client.c:966 v9fs_session_init+0x223/0x1cf0 fs/9p/v9fs.c:408 v9fs_mount+0xdd/0xe90 fs/9p/vfs_super.c:126 legacy_get_tree+0x135/0x1f0 fs/fs_context.c:610 vfs_get_tree+0xa5/0x310 fs/super.c:1530 do_new_mount fs/namespace.c:3040 [inline] path_mount+0x1b37/0x3090 fs/namespace.c:3370 do_mount fs/namespace.c:3383 [inline] __do_sys_mount fs/namespace.c:3591 [inline] __se_sys_mount+0x313/0x3d0 fs/namespace.c:3568 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4e/0xa0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0xcd Last potentially related work creation: kasan_save_stack+0x2b/0x50 mm/kasan/common.c:38 __kasan_record_aux_stack+0xac/0xc0 mm/kasan/generic.c:348 insert_work+0x54/0x400 kernel/workqueue.c:1358 __queue_work+0xa95/0xe00 kernel/workqueue.c:1517 queue_work_on+0x12c/0x210 kernel/workqueue.c:1545 queue_work include/linux/workqueue.h:503 [inline] call_usermodehelper_exec+0x298/0x4b0 kernel/umh.c:435 kobject_uevent_env+0x1571/0x1990 lib/kobject_uevent.c:618 kobject_synth_uevent+0x3ed/0x980 lib/kobject_uevent.c:208 uevent_store+0x20/0x60 drivers/base/core.c:2509 kernfs_fop_write_iter+0x450/0x600 fs/kernfs/file.c:354 call_write_iter include/linux/fs.h:2187 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x848/0xd90 fs/read_write.c:578 ksys_write+0x182/0x2c0 fs/read_write.c:631 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4e/0xa0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0xcd Second to last potentially related work creation: kasan_save_stack+0x2b/0x50 mm/kasan/common.c:38 __kasan_record_aux_stack+0xac/0xc0 mm/kasan/generic.c:348 insert_work+0x54/0x400 kernel/workqueue.c:1358 __queue_work+0xa95/0xe00 kernel/workqueue.c:1517 queue_work_on+0x12c/0x210 kernel/workqueue.c:1545 queue_work include/linux/workqueue.h:503 [inline] call_usermodehelper_exec+0x298/0x4b0 kernel/umh.c:435 kobject_uevent_env+0x1571/0x1990 lib/kobject_uevent.c:618 device_add+0x1339/0x1b60 drivers/base/core.c:3498 usb_new_device+0xd9d/0x1bb0 drivers/usb/core/hub.c:2573 hub_port_connect+0x1243/0x2dd0 drivers/usb/core/hub.c:5353 hub_port_connect_change+0x696/0xd40 drivers/usb/core/hub.c:5497 port_event+0xaca/0x12b0 drivers/usb/core/hub.c:5653 hub_event+0x511/0xed0 drivers/usb/core/hub.c:5735 process_one_work+0x83f/0x11a0 kernel/workqueue.c:2289 worker_thread+0xa6c/0x1290 kernel/workqueue.c:2436 kthread+0x28a/0x320 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 The buggy address belongs to the object at ffff88801fb82e00 which belongs to the cache kmalloc-192 of size 192 The buggy address is located 96 bytes inside of 192-byte region [ffff88801fb82e00, ffff88801fb82ec0) The buggy address belongs to the physical page: page:ffffea00007ee080 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1fb82 flags: 0xfff00000000200(slab|node=0|zone=1|lastcpupid=0x7ff) raw: 00fff00000000200 ffffea0000503380 dead000000000002 ffff888013442a00 raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 0, migratetype Unmovable, gfp_mask 0x12c00(GFP_NOIO|__GFP_NOWARN|__GFP_NORETRY), pid 949, tgid 949 (kworker/0:2), ts 20844494854, free_ts 20409160136 prep_new_page mm/page_alloc.c:2532 [inline] get_page_from_freelist+0x800/0xc10 mm/page_alloc.c:4283 __alloc_pages+0x2f0/0x650 mm/page_alloc.c:5549 alloc_slab_page mm/slub.c:1829 [inline] allocate_slab+0x1eb/0xc00 mm/slub.c:1974 new_slab mm/slub.c:2034 [inline] ___slab_alloc+0x581/0xff0 mm/slub.c:3036 __slab_alloc mm/slub.c:3123 [inline] slab_alloc_node mm/slub.c:3214 [inline] slab_alloc mm/slub.c:3256 [inline] __kmalloc+0x3cb/0x490 mm/slub.c:4425 kmalloc include/linux/slab.h:605 [inline] usb_alloc_urb+0x38/0x180 drivers/usb/core/urb.c:74 usb_internal_control_msg drivers/usb/core/message.c:95 [inline] usb_control_msg+0x1bd/0x590 drivers/usb/core/message.c:153 get_port_status drivers/usb/core/hub.c:581 [inline] hub_ext_port_status+0x12d/0x780 drivers/usb/core/hub.c:598 usb_hub_port_status drivers/usb/core/hub.c:620 [inline] hub_activate+0x917/0x2060 drivers/usb/core/hub.c:1130 process_one_work+0x83f/0x11a0 kernel/workqueue.c:2289 worker_thread+0xa6c/0x1290 kernel/workqueue.c:2436 kthread+0x28a/0x320 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 page last free stack trace: reset_page_owner include/linux/page_owner.h:24 [inline] free_pages_prepare mm/page_alloc.c:1449 [inline] free_pcp_prepare+0x76d/0x890 mm/page_alloc.c:1499 free_unref_page_prepare mm/page_alloc.c:3380 [inline] free_unref_page+0x8a/0x880 mm/page_alloc.c:3476 __tlb_remove_table arch/x86/include/asm/tlb.h:34 [inline] __tlb_remove_table_free mm/mmu_gather.c:114 [inline] tlb_remove_table_rcu+0x9b/0x120 mm/mmu_gather.c:169 rcu_do_batch kernel/rcu/tree.c:2245 [inline] rcu_core+0x9bb/0x1680 kernel/rcu/tree.c:2505 __do_softirq+0x372/0x783 kernel/softirq.c:571 Memory state around the buggy address: ffff88801fb82d00: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff88801fb82d80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc >ffff88801fb82e00: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff88801fb82e80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc ffff88801fb82f00: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ==================================================================

1 0

http://www.alsa-project.org/alsa-info.sh doesnt exist
by GitHub issues - edited 05 Apr '23

05 Apr '23

alsa-project/alsa-utils issue #199 was edited from petke: http://www.alsa-project.org/alsa-info.sh doesnt exist. http status code 404 Looks like alsa-info.sh tries to auto update itself, but as that url doesnt exist. It overwrites itself with empty file. Issue URL : https://github.com/alsa-project/alsa-utils/issues/199 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

http://www.alsa-project.org/alsa-info.sh doesnt exist
by GitHub issues - edited 05 Apr '23

05 Apr '23

alsa-project/alsa-utils issue #199 was edited from petke: http://www.alsa-project.org/alsa-info.sh doesnt exist. http status code 404 Looks like alsa-info.sh tries to auto update itself, but as that url doesnt exist. It overwrites itself with empty file. Edir: If i disabled the auto updating by editing script to ``` REMOTE_VERSION=$SCRIPT_VERSION ``` Then i can run it. Issue URL : https://github.com/alsa-project/alsa-utils/issues/199 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

http://www.alsa-project.org/alsa-info.sh doesnt exist
by GitHub issues - edited 05 Apr '23

05 Apr '23

alsa-project/alsa-utils issue #199 was edited from petke: http://www.alsa-project.org/alsa-info.sh doesnt exist. http status code 404 Looks like alsa-info.sh tries to auto update itself, but as that url doesnt exist. It overwrites itself with empty file. Issue URL : https://github.com/alsa-project/alsa-utils/issues/199 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

http://www.alsa-project.org/alsa-info.sh doesnt exist
by GitHub issues - opened 05 Apr '23

05 Apr '23

alsa-project/alsa-utils issue #199 was opened from petke: http://www.alsa-project.org/alsa-info.sh doesnt exist. http status code 404 Looks like alsa-info.sh tries to update itself, but as that url doesnt exist. It overwrites itself with empty file. Issue URL : https://github.com/alsa-project/alsa-utils/issues/199 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH 00/12] ASoC: SOF: core/Intel: Introduce DSPless mode
by Peter Ujfalusi 04 Apr '23

04 Apr '23

Hi, This series will add support for SOF Linux stack to run without using the DSP. DSPless mode provides a good tool for verification that the hardware itself works correctly by taking the DSP use out from the picture. It can only work with interfaces which supports this mode: Intel HDA at the moment but with LNL it could be possible to support other audio interfaces. The main driver for this mode is to be able to test programming sequences, low-level code and for low-level verification of a platform. The feature is not targetted for end-users and it will not make the SOF stack to work on hardware without DSP, but it is giving us a tool to debug and enable platforms earlier (when for example t he firmware is not mature enough). Regards, Peter --- Peter Ujfalusi (11): ASoC: SOF: Intel: hda-stream: Do not dereference hstream until it is safe ASoC: SOF: Add flag and state which will be used for DSP-less mode ASoC: SOF: Add support for DSPless mode ASoC: SOF: Intel: hda: Skip interfaces not supported on a platform ASoC: SOF: Intel: hda: Add support for DSPless mode ASoC: SOF: Intel: pci-apl: Allow DSPless mode ASoC: SOF: Intel: pci-cnl: Allow DSPless mode ASoC: SOF: Intel: pci-icl: Allow DSPless mode ASoC: SOF: Intel: pci-mtl: Allow DSPless mode ASoC: SOF: Intel: pci-skl: Allow DSPless mode ASoC: SOF: Intel: pci-tgl: Allow DSPless mode Pierre-Louis Bossart (1): ASoC: SOF: Intel: hda: make DSPless mode work with DSP disabled in BIOS include/sound/sof.h | 5 + sound/soc/sof/core.c | 31 ++++++- sound/soc/sof/debug.c | 1 + sound/soc/sof/intel/hda-dai-ops.c | 33 ++++++- sound/soc/sof/intel/hda-dai.c | 25 ++++- sound/soc/sof/intel/hda-dsp.c | 30 ++++-- sound/soc/sof/intel/hda-ipc.c | 3 + sound/soc/sof/intel/hda-pcm.c | 24 +++-- sound/soc/sof/intel/hda-stream.c | 67 ++++++++------ sound/soc/sof/intel/hda.c | 149 +++++++++++++++++++++++------- sound/soc/sof/intel/pci-apl.c | 2 + sound/soc/sof/intel/pci-cnl.c | 3 + sound/soc/sof/intel/pci-icl.c | 2 + sound/soc/sof/intel/pci-mtl.c | 1 + sound/soc/sof/intel/pci-skl.c | 2 + sound/soc/sof/intel/pci-tgl.c | 8 ++ sound/soc/sof/pcm.c | 13 ++- sound/soc/sof/pm.c | 5 + sound/soc/sof/sof-audio.c | 2 +- sound/soc/sof/sof-client.c | 3 + sound/soc/sof/sof-priv.h | 11 +++ sound/soc/sof/topology.c | 130 +++++++++++++++++++++++++- 22 files changed, 459 insertions(+), 91 deletions(-) -- 2.40.0

2 13

[PATCH next] ASoC: cs35l56: Fix unsigned 'rv' comparison with zero in cs35l56_irq()
by Harshit Mogalapalli 04 Apr '23

04 Apr '23

'rv' is of type unsigned int, which can never be less than zero. rv = pm_runtime_resume_and_get(cs35l56->dev); if (rv < 0) { // can never be true. ... } As pm_runtime_resume_and_get returns integers, change the type of 'rv' to int to fix this. This is found by static analysis with smatch. Fixes: e49611252900 ("ASoC: cs35l56: Add driver for Cirrus Logic CS35L56") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli(a)oracle.com> --- Only compile tested. --- sound/soc/codecs/cs35l56.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c index 90fc79b5666d..b3772005668a 100644 --- a/sound/soc/codecs/cs35l56.c +++ b/sound/soc/codecs/cs35l56.c @@ -321,7 +321,8 @@ irqreturn_t cs35l56_irq(int irq, void *data) struct cs35l56_private *cs35l56 = data; unsigned int status1 = 0, status8 = 0, status20 = 0; unsigned int mask1, mask8, mask20; - unsigned int rv, val; + unsigned int val; + int rv; irqreturn_t ret = IRQ_NONE; if (!cs35l56->init_done) -- 2.38.1

2 2