- Alsa-devel - mailman.alsa-project.org

[alsa-devel] [RFC PATCH 0/5] PXA SSP code cleanup
by Eric Miao 23 Apr '09

23 Apr '09

Remove legacy SSP API by deprecating the only user now - corgi_ts.c, (which could be now well substituted by ads7846 after the sync patch) sound/soc/pxa/pxa-ssp.c is modified and simplified a bit. I guess sound/soc/pxa/pxa-ssp.c will still have to undergo the changes as ASoCv2 progress, hopefully that should be a little bit easier now. -- Cheers - eric

1 0

[PATCH] ASoC: simplify the SSP DMA parameters settings by
by Eric Miao 23 Apr '09

23 Apr '09

run-time generation The SSP DMA parameters can actually be easily generated at run-time since they are almost similar except for the FIFO width and direction. Another benefit is the re-use of information from 'struct ssp_device', like SSDR physical FIFO address and DRCMR register index for both directions. Signed-off-by: Eric Miao <eric.miao(a)marvell.com> Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Reviewed-by: pHilipp Zabel <philipp.zabel(a)gmail.com> --- sound/soc/pxa/pxa-ssp.c | 203 ++++++++++------------------------------------- 1 files changed, 43 insertions(+), 160 deletions(-) diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c index b9b61dd..fb8cacc 100644 --- a/sound/soc/pxa/pxa-ssp.c +++ b/sound/soc/pxa/pxa-ssp.c @@ -50,139 +50,6 @@ struct ssp_priv { #endif }; -#define PXA2xx_SSP1_BASE 0x41000000 -#define PXA27x_SSP2_BASE 0x41700000 -#define PXA27x_SSP3_BASE 0x41900000 -#define PXA3xx_SSP4_BASE 0x41a00000 - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_mono_out = { - .name = "SSP1 PCM Mono out", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(14), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_mono_in = { - .name = "SSP1 PCM Mono in", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(13), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_stereo_out = { - .name = "SSP1 PCM Stereo out", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(14), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_stereo_in = { - .name = "SSP1 PCM Stereo in", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(13), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_mono_out = { - .name = "SSP2 PCM Mono out", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(16), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_mono_in = { - .name = "SSP2 PCM Mono in", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(15), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_stereo_out = { - .name = "SSP2 PCM Stereo out", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(16), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_stereo_in = { - .name = "SSP2 PCM Stereo in", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(15), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_mono_out = { - .name = "SSP3 PCM Mono out", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_mono_in = { - .name = "SSP3 PCM Mono in", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_stereo_out = { - .name = "SSP3 PCM Stereo out", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_stereo_in = { - .name = "SSP3 PCM Stereo in", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_mono_out = { - .name = "SSP4 PCM Mono out", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_mono_in = { - .name = "SSP4 PCM Mono in", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_stereo_out = { - .name = "SSP4 PCM Stereo out", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_stereo_in = { - .name = "SSP4 PCM Stereo in", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - static void dump_registers(struct ssp_device *ssp) { dev_dbg(&ssp->pdev->dev, "SSCR0 0x%08x SSCR1 0x%08x SSTO 0x%08x\n", @@ -194,25 +61,33 @@ static void dump_registers(struct ssp_device *ssp) ssp_read_reg(ssp, SSACD)); } -static struct pxa2xx_pcm_dma_params *ssp_dma_params[4][4] = { - { - &pxa_ssp1_pcm_mono_out, &pxa_ssp1_pcm_mono_in, - &pxa_ssp1_pcm_stereo_out, &pxa_ssp1_pcm_stereo_in, - }, - { - &pxa_ssp2_pcm_mono_out, &pxa_ssp2_pcm_mono_in, - &pxa_ssp2_pcm_stereo_out, &pxa_ssp2_pcm_stereo_in, - }, - { - &pxa_ssp3_pcm_mono_out, &pxa_ssp3_pcm_mono_in, - &pxa_ssp3_pcm_stereo_out, &pxa_ssp3_pcm_stereo_in, - }, - { - &pxa_ssp4_pcm_mono_out, &pxa_ssp4_pcm_mono_in, - &pxa_ssp4_pcm_stereo_out, &pxa_ssp4_pcm_stereo_in, - }, +struct pxa2xx_pcm_dma_data { + struct pxa2xx_pcm_dma_params params; + char name[20]; }; +static struct pxa2xx_pcm_dma_params * +ssp_get_dma_params(struct ssp_device *ssp, int stereo, int out) +{ + struct pxa2xx_pcm_dma_data *dma; + + dma = kzalloc(sizeof(struct pxa2xx_pcm_dma_data), GFP_KERNEL); + if (dma == NULL) + return NULL; + + snprintf(dma->name, 20, "SSP%d PCM %s %s", ssp->port_id, + stereo ? "Stereo" : "Mono", out ? "out" : "in"); + + dma->params.name = dma->name; + dma->params.drcmr = &DRCMR(out ? ssp->drcmr_tx : ssp->drcmr_rx); + dma->params.dcmd = (out ? (DCMD_INCSRCADDR | DCMD_FLOWTRG) : + (DCMD_INCTRGADDR | DCMD_FLOWSRC)) | + (stereo ? DCMD_WIDTH4 : DCMD_WIDTH2) | DCMD_BURST16; + dma->params.dev_addr = ssp->phys_base + SSDR; + + return &dma->params; +} + static int pxa_ssp_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { @@ -227,6 +102,11 @@ static int pxa_ssp_startup(struct snd_pcm_substream *substream, clk_enable(priv->dev.ssp->clk); ssp_disable(&priv->dev); } + + if (cpu_dai->dma_data) { + kfree(cpu_dai->dma_data); + cpu_dai->dma_data = NULL; + } return ret; } @@ -241,6 +121,11 @@ static void pxa_ssp_shutdown(struct snd_pcm_substream *substream, ssp_disable(&priv->dev); clk_disable(priv->dev.ssp->clk); } + + if (cpu_dai->dma_data) { + kfree(cpu_dai->dma_data); + cpu_dai->dma_data = NULL; + } } #ifdef CONFIG_PM @@ -653,25 +538,23 @@ static int pxa_ssp_hw_params(struct snd_pcm_substream *substream, struct snd_soc_dai *cpu_dai = rtd->dai->cpu_dai; struct ssp_priv *priv = cpu_dai->private_data; struct ssp_device *ssp = priv->dev.ssp; - int dma = 0, chn = params_channels(params); + int chn = params_channels(params); u32 sscr0; u32 sspsp; int width = snd_pcm_format_physical_width(params_format(params)); int ttsa = ssp_read_reg(ssp, SSTSA) & 0xf; - /* select correct DMA params */ - if (substream->stream != SNDRV_PCM_STREAM_PLAYBACK) - dma = 1; /* capture DMA offset is 1,3 */ + /* generate correct DMA params */ + if (cpu_dai->dma_data) + kfree(cpu_dai->dma_data); + /* Network mode with one active slot (ttsa == 1) can be used * to force 16-bit frame width on the wire (for S16_LE), even * with two channels. Use 16-bit DMA transfers for this case. */ - if (((chn == 2) && (ttsa != 1)) || (width == 32)) - dma += 2; /* 32-bit DMA offset is 2, 16-bit is 0 */ - - cpu_dai->dma_data = ssp_dma_params[cpu_dai->id][dma]; - - dev_dbg(&ssp->pdev->dev, "pxa_ssp_hw_params: dma %d\n", dma); + cpu_dai->dma_data = ssp_get_dma_params(ssp, + ((chn == 2) && (ttsa != 1)) || (width == 32), + substream->stream == SNDRV_PCM_STREAM_PLAYBACK); /* we can only change the settings if the port is not in use */ if (ssp_read_reg(ssp, SSCR0) & SSCR0_SSE) -- 1.6.0.4 --0016364ee0220e5a4e0468352f08 Content-Type: text/x-diff; charset=US-ASCII; name="0001-ASoC-simplify-the-SSP-DMA-parameters-settings-by-ru.patch" Content-Disposition: attachment; filename="0001-ASoC-simplify-the-SSP-DMA-parameters-settings-by-ru.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ftv880y00 RnJvbSA2NTViYWQ4ZTcyZTNhYTEzZjBkZGY5MTBkNWY0YjlmMDY2ZWM5Y2MzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmljIE1pYW8gPGVyaWMubWlhb0BtYXJ2ZWxsLmNvbT4KRGF0 ZTogVGh1LCAyMyBBcHIgMjAwOSAxMDo1ODozNCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFTb0M6 IHNpbXBsaWZ5IHRoZSBTU1AgRE1BIHBhcmFtZXRlcnMgc2V0dGluZ3MgYnkgcnVuLXRpbWUgZ2Vu ZXJhdGlvbgoKVGhlIFNTUCBETUEgcGFyYW1ldGVycyBjYW4gYWN0dWFsbHkgYmUgZWFzaWx5IGdl bmVyYXRlZCBhdCBydW4tdGltZSBzaW5jZQp0aGV5IGFyZSBhbG1vc3Qgc2ltaWxhciBleGNlcHQg Zm9yIHRoZSBGSUZPIHdpZHRoIGFuZCBkaXJlY3Rpb24uIEFub3RoZXIKYmVuZWZpdCBpcyB0aGUg cmUtdXNlIG9mIGluZm9ybWF0aW9uIGZyb20gJ3N0cnVjdCBzc3BfZGV2aWNlJywgbGlrZSBTU0RS CnBoeXNpY2FsIEZJRk8gYWRkcmVzcyBhbmQgRFJDTVIgcmVnaXN0ZXIgaW5kZXggZm9yIGJvdGgg ZGlyZWN0aW9ucy4KClNpZ25lZC1vZmYtYnk6IEVyaWMgTWlhbyA8ZXJpYy5taWFvQG1hcnZlbGwu Y29tPgpTaWduZWQtb2ZmLWJ5OiBNYXJrIEJyb3duIDxicm9vbmllQG9wZW5zb3VyY2Uud29sZnNv bm1pY3JvLmNvbT4KUmV2aWV3ZWQtYnk6IHBIaWxpcHAgWmFiZWwgPHBoaWxpcHAuemFiZWxAZ21h aWwuY29tPgotLS0KIHNvdW5kL3NvYy9weGEvcHhhLXNzcC5jIHwgIDIwMyArKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlcyBjaGFuZ2VkLCA0MyBp bnNlcnRpb25zKCspLCAxNjAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc291bmQvc29jL3B4 YS9weGEtc3NwLmMgYi9zb3VuZC9zb2MvcHhhL3B4YS1zc3AuYwppbmRleCBiOWI2MWRkLi5mYjhj YWNjIDEwMDY0NAotLS0gYS9zb3VuZC9zb2MvcHhhL3B4YS1zc3AuYworKysgYi9zb3VuZC9zb2Mv cHhhL3B4YS1zc3AuYwpAQCAtNTAsMTM5ICs1MCw2IEBAIHN0cnVjdCBzc3BfcHJpdiB7CiAjZW5k aWYKIH07CiAKLSNkZWZpbmUgUFhBMnh4X1NTUDFfQkFTRQkweDQxMDAwMDAwCi0jZGVmaW5lIFBY QTI3eF9TU1AyX0JBU0UJMHg0MTcwMDAwMAotI2RlZmluZSBQWEEyN3hfU1NQM19CQVNFCTB4NDE5 MDAwMDAKLSNkZWZpbmUgUFhBM3h4X1NTUDRfQkFTRQkweDQxYTAwMDAwCi0KLXN0YXRpYyBzdHJ1 Y3QgcHhhMnh4X3BjbV9kbWFfcGFyYW1zIHB4YV9zc3AxX3BjbV9tb25vX291dCA9IHsKLQkubmFt ZQkJCT0gIlNTUDEgUENNIE1vbm8gb3V0IiwKLQkuZGV2X2FkZHIJCT0gUFhBMnh4X1NTUDFfQkFT RSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoMTQpLAotCS5kY21kCQkJPSBEQ01EX0lOQ1NS Q0FERFIgfCBEQ01EX0ZMT1dUUkcgfAotCQkJCSAgRENNRF9CVVJTVDE2IHwgRENNRF9XSURUSDIs Ci19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFtcyBweGFfc3NwMV9wY21f bW9ub19pbiA9IHsKLQkubmFtZQkJCT0gIlNTUDEgUENNIE1vbm8gaW4iLAotCS5kZXZfYWRkcgkJ PSBQWEEyeHhfU1NQMV9CQVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZEUkNNUigxMyksCi0JLmRj bWQJCQk9IERDTURfSU5DVFJHQUREUiB8IERDTURfRkxPV1NSQyB8Ci0JCQkJICBEQ01EX0JVUlNU MTYgfCBEQ01EX1dJRFRIMiwKLX07Ci0KLXN0YXRpYyBzdHJ1Y3QgcHhhMnh4X3BjbV9kbWFfcGFy YW1zIHB4YV9zc3AxX3BjbV9zdGVyZW9fb3V0ID0gewotCS5uYW1lCQkJPSAiU1NQMSBQQ00gU3Rl cmVvIG91dCIsCi0JLmRldl9hZGRyCQk9IFBYQTJ4eF9TU1AxX0JBU0UgKyBTU0RSLAotCS5kcmNt cgkJCT0gJkRSQ01SKDE0KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNTUkNBRERSIHwgRENNRF9GTE9X VFJHIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEg0LAotfTsKLQotc3RhdGljIHN0 cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDFfcGNtX3N0ZXJlb19pbiA9IHsKLQku bmFtZQkJCT0gIlNTUDEgUENNIFN0ZXJlbyBpbiIsCi0JLmRldl9hZGRyCQk9IFBYQTJ4eF9TU1Ax X0JBU0UgKyBTU0RSLAotCS5kcmNtcgkJCT0gJkRSQ01SKDEzKSwKLQkuZGNtZAkJCT0gRENNRF9J TkNUUkdBRERSIHwgRENNRF9GTE9XU1JDIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lE VEg0LAotfTsKLQotc3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDJf cGNtX21vbm9fb3V0ID0gewotCS5uYW1lCQkJPSAiU1NQMiBQQ00gTW9ubyBvdXQiLAotCS5kZXZf YWRkcgkJPSBQWEEyN3hfU1NQMl9CQVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZEUkNNUigxNiks Ci0JLmRjbWQJCQk9IERDTURfSU5DU1JDQUREUiB8IERDTURfRkxPV1RSRyB8Ci0JCQkJICBEQ01E X0JVUlNUMTYgfCBEQ01EX1dJRFRIMiwKLX07Ci0KLXN0YXRpYyBzdHJ1Y3QgcHhhMnh4X3BjbV9k bWFfcGFyYW1zIHB4YV9zc3AyX3BjbV9tb25vX2luID0gewotCS5uYW1lCQkJPSAiU1NQMiBQQ00g TW9ubyBpbiIsCi0JLmRldl9hZGRyCQk9IFBYQTI3eF9TU1AyX0JBU0UgKyBTU0RSLAotCS5kcmNt cgkJCT0gJkRSQ01SKDE1KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNUUkdBRERSIHwgRENNRF9GTE9X U1JDIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEgyLAotfTsKLQotc3RhdGljIHN0 cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDJfcGNtX3N0ZXJlb19vdXQgPSB7Ci0J Lm5hbWUJCQk9ICJTU1AyIFBDTSBTdGVyZW8gb3V0IiwKLQkuZGV2X2FkZHIJCT0gUFhBMjd4X1NT UDJfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoMTYpLAotCS5kY21kCQkJPSBEQ01E X0lOQ1NSQ0FERFIgfCBEQ01EX0ZMT1dUUkcgfAotCQkJCSAgRENNRF9CVVJTVDE2IHwgRENNRF9X SURUSDQsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFtcyBweGFfc3Nw Ml9wY21fc3RlcmVvX2luID0gewotCS5uYW1lCQkJPSAiU1NQMiBQQ00gU3RlcmVvIGluIiwKLQku ZGV2X2FkZHIJCT0gUFhBMjd4X1NTUDJfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIo MTUpLAotCS5kY21kCQkJPSBEQ01EX0lOQ1RSR0FERFIgfCBEQ01EX0ZMT1dTUkMgfAotCQkJCSAg RENNRF9CVVJTVDE2IHwgRENNRF9XSURUSDQsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9w Y21fZG1hX3BhcmFtcyBweGFfc3NwM19wY21fbW9ub19vdXQgPSB7Ci0JLm5hbWUJCQk9ICJTU1Az IFBDTSBNb25vIG91dCIsCi0JLmRldl9hZGRyCQk9IFBYQTI3eF9TU1AzX0JBU0UgKyBTU0RSLAot CS5kcmNtcgkJCT0gJkRSQ01SKDY3KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNTUkNBRERSIHwgRENN RF9GTE9XVFJHIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEgyLAotfTsKLQotc3Rh dGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDNfcGNtX21vbm9faW4gPSB7 Ci0JLm5hbWUJCQk9ICJTU1AzIFBDTSBNb25vIGluIiwKLQkuZGV2X2FkZHIJCT0gUFhBMjd4X1NT UDNfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoNjYpLAotCS5kY21kCQkJPSBEQ01E X0lOQ1RSR0FERFIgfCBEQ01EX0ZMT1dTUkMgfAotCQkJCSAgRENNRF9CVVJTVDE2IHwgRENNRF9X SURUSDIsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFtcyBweGFfc3Nw M19wY21fc3RlcmVvX291dCA9IHsKLQkubmFtZQkJCT0gIlNTUDMgUENNIFN0ZXJlbyBvdXQiLAot CS5kZXZfYWRkcgkJPSBQWEEyN3hfU1NQM19CQVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZEUkNN Uig2NyksCi0JLmRjbWQJCQk9IERDTURfSU5DU1JDQUREUiB8IERDTURfRkxPV1RSRyB8Ci0JCQkJ ICBEQ01EX0JVUlNUMTYgfCBEQ01EX1dJRFRINCwKLX07Ci0KLXN0YXRpYyBzdHJ1Y3QgcHhhMnh4 X3BjbV9kbWFfcGFyYW1zIHB4YV9zc3AzX3BjbV9zdGVyZW9faW4gPSB7Ci0JLm5hbWUJCQk9ICJT U1AzIFBDTSBTdGVyZW8gaW4iLAotCS5kZXZfYWRkcgkJPSBQWEEyN3hfU1NQM19CQVNFICsgU1NE UiwKLQkuZHJjbXIJCQk9ICZEUkNNUig2NiksCi0JLmRjbWQJCQk9IERDTURfSU5DVFJHQUREUiB8 IERDTURfRkxPV1NSQyB8Ci0JCQkJICBEQ01EX0JVUlNUMTYgfCBEQ01EX1dJRFRINCwKLX07Ci0K LXN0YXRpYyBzdHJ1Y3QgcHhhMnh4X3BjbV9kbWFfcGFyYW1zIHB4YV9zc3A0X3BjbV9tb25vX291 dCA9IHsKLQkubmFtZQkJCT0gIlNTUDQgUENNIE1vbm8gb3V0IiwKLQkuZGV2X2FkZHIJCT0gUFhB M3h4X1NTUDRfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoNjcpLAotCS5kY21kCQkJ PSBEQ01EX0lOQ1NSQ0FERFIgfCBEQ01EX0ZMT1dUUkcgfAotCQkJCSAgRENNRF9CVVJTVDE2IHwg RENNRF9XSURUSDIsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFtcyBw eGFfc3NwNF9wY21fbW9ub19pbiA9IHsKLQkubmFtZQkJCT0gIlNTUDQgUENNIE1vbm8gaW4iLAot CS5kZXZfYWRkcgkJPSBQWEEzeHhfU1NQNF9CQVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZEUkNN Uig2NiksCi0JLmRjbWQJCQk9IERDTURfSU5DVFJHQUREUiB8IERDTURfRkxPV1NSQyB8Ci0JCQkJ ICBEQ01EX0JVUlNUMTYgfCBEQ01EX1dJRFRIMiwKLX07Ci0KLXN0YXRpYyBzdHJ1Y3QgcHhhMnh4 X3BjbV9kbWFfcGFyYW1zIHB4YV9zc3A0X3BjbV9zdGVyZW9fb3V0ID0gewotCS5uYW1lCQkJPSAi U1NQNCBQQ00gU3RlcmVvIG91dCIsCi0JLmRldl9hZGRyCQk9IFBYQTN4eF9TU1A0X0JBU0UgKyBT U0RSLAotCS5kcmNtcgkJCT0gJkRSQ01SKDY3KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNTUkNBRERS IHwgRENNRF9GTE9XVFJHIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEg0LAotfTsK LQotc3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDRfcGNtX3N0ZXJl b19pbiA9IHsKLQkubmFtZQkJCT0gIlNTUDQgUENNIFN0ZXJlbyBpbiIsCi0JLmRldl9hZGRyCQk9 IFBYQTN4eF9TU1A0X0JBU0UgKyBTU0RSLAotCS5kcmNtcgkJCT0gJkRSQ01SKDY2KSwKLQkuZGNt ZAkJCT0gRENNRF9JTkNUUkdBRERSIHwgRENNRF9GTE9XU1JDIHwKLQkJCQkgIERDTURfQlVSU1Qx NiB8IERDTURfV0lEVEg0LAotfTsKLQogc3RhdGljIHZvaWQgZHVtcF9yZWdpc3RlcnMoc3RydWN0 IHNzcF9kZXZpY2UgKnNzcCkKIHsKIAlkZXZfZGJnKCZzc3AtPnBkZXYtPmRldiwgIlNTQ1IwIDB4 JTA4eCBTU0NSMSAweCUwOHggU1NUTyAweCUwOHhcbiIsCkBAIC0xOTQsMjUgKzYxLDMzIEBAIHN0 YXRpYyB2b2lkIGR1bXBfcmVnaXN0ZXJzKHN0cnVjdCBzc3BfZGV2aWNlICpzc3ApCiAJCSBzc3Bf cmVhZF9yZWcoc3NwLCBTU0FDRCkpOwogfQogCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1h X3BhcmFtcyAqc3NwX2RtYV9wYXJhbXNbNF1bNF0gPSB7Ci0JewotCQkmcHhhX3NzcDFfcGNtX21v bm9fb3V0LCAmcHhhX3NzcDFfcGNtX21vbm9faW4sCi0JCSZweGFfc3NwMV9wY21fc3RlcmVvX291 dCwgJnB4YV9zc3AxX3BjbV9zdGVyZW9faW4sCi0JfSwKLQl7Ci0JCSZweGFfc3NwMl9wY21fbW9u b19vdXQsICZweGFfc3NwMl9wY21fbW9ub19pbiwKLQkJJnB4YV9zc3AyX3BjbV9zdGVyZW9fb3V0 LCAmcHhhX3NzcDJfcGNtX3N0ZXJlb19pbiwKLQl9LAotCXsKLQkJJnB4YV9zc3AzX3BjbV9tb25v X291dCwgJnB4YV9zc3AzX3BjbV9tb25vX2luLAotCQkmcHhhX3NzcDNfcGNtX3N0ZXJlb19vdXQs ICZweGFfc3NwM19wY21fc3RlcmVvX2luLAotCX0sCi0JewotCQkmcHhhX3NzcDRfcGNtX21vbm9f b3V0LCAmcHhhX3NzcDRfcGNtX21vbm9faW4sCi0JCSZweGFfc3NwNF9wY21fc3RlcmVvX291dCwg JnB4YV9zc3A0X3BjbV9zdGVyZW9faW4sCi0JfSwKK3N0cnVjdCBweGEyeHhfcGNtX2RtYV9kYXRh IHsKKwlzdHJ1Y3QgcHhhMnh4X3BjbV9kbWFfcGFyYW1zIHBhcmFtczsKKwljaGFyIG5hbWVbMjBd OwogfTsKIAorc3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgKgorc3NwX2dldF9k bWFfcGFyYW1zKHN0cnVjdCBzc3BfZGV2aWNlICpzc3AsIGludCBzdGVyZW8sIGludCBvdXQpCit7 CisJc3RydWN0IHB4YTJ4eF9wY21fZG1hX2RhdGEgKmRtYTsKKworCWRtYSA9IGt6YWxsb2Moc2l6 ZW9mKHN0cnVjdCBweGEyeHhfcGNtX2RtYV9kYXRhKSwgR0ZQX0tFUk5FTCk7CisJaWYgKGRtYSA9 PSBOVUxMKQorCQlyZXR1cm4gTlVMTDsKKworCXNucHJpbnRmKGRtYS0+bmFtZSwgMjAsICJTU1Al ZCBQQ00gJXMgJXMiLCBzc3AtPnBvcnRfaWQsCisJCQlzdGVyZW8gPyAiU3RlcmVvIiA6ICJNb25v Iiwgb3V0ID8gIm91dCIgOiAiaW4iKTsKKworCWRtYS0+cGFyYW1zLm5hbWUgPSBkbWEtPm5hbWU7 CisJZG1hLT5wYXJhbXMuZHJjbXIgPSAmRFJDTVIob3V0ID8gc3NwLT5kcmNtcl90eCA6IHNzcC0+ ZHJjbXJfcngpOworCWRtYS0+cGFyYW1zLmRjbWQgPSAob3V0ID8gKERDTURfSU5DU1JDQUREUiB8 IERDTURfRkxPV1RSRykgOgorCQkJCSAgKERDTURfSU5DVFJHQUREUiB8IERDTURfRkxPV1NSQykp IHwKKwkJCShzdGVyZW8gPyBEQ01EX1dJRFRINCA6IERDTURfV0lEVEgyKSB8IERDTURfQlVSU1Qx NjsKKwlkbWEtPnBhcmFtcy5kZXZfYWRkciA9IHNzcC0+cGh5c19iYXNlICsgU1NEUjsKKworCXJl dHVybiAmZG1hLT5wYXJhbXM7Cit9CisKIHN0YXRpYyBpbnQgcHhhX3NzcF9zdGFydHVwKHN0cnVj dCBzbmRfcGNtX3N1YnN0cmVhbSAqc3Vic3RyZWFtLAogCQkJICAgc3RydWN0IHNuZF9zb2NfZGFp ICpkYWkpCiB7CkBAIC0yMjcsNiArMTAyLDExIEBAIHN0YXRpYyBpbnQgcHhhX3NzcF9zdGFydHVw KHN0cnVjdCBzbmRfcGNtX3N1YnN0cmVhbSAqc3Vic3RyZWFtLAogCQljbGtfZW5hYmxlKHByaXYt PmRldi5zc3AtPmNsayk7CiAJCXNzcF9kaXNhYmxlKCZwcml2LT5kZXYpOwogCX0KKworCWlmIChj cHVfZGFpLT5kbWFfZGF0YSkgeworCQlrZnJlZShjcHVfZGFpLT5kbWFfZGF0YSk7CisJCWNwdV9k YWktPmRtYV9kYXRhID0gTlVMTDsKKwl9CiAJcmV0dXJuIHJldDsKIH0KIApAQCAtMjQxLDYgKzEy MSwxMSBAQCBzdGF0aWMgdm9pZCBweGFfc3NwX3NodXRkb3duKHN0cnVjdCBzbmRfcGNtX3N1YnN0 cmVhbSAqc3Vic3RyZWFtLAogCQlzc3BfZGlzYWJsZSgmcHJpdi0+ZGV2KTsKIAkJY2xrX2Rpc2Fi bGUocHJpdi0+ZGV2LnNzcC0+Y2xrKTsKIAl9CisKKwlpZiAoY3B1X2RhaS0+ZG1hX2RhdGEpIHsK KwkJa2ZyZWUoY3B1X2RhaS0+ZG1hX2RhdGEpOworCQljcHVfZGFpLT5kbWFfZGF0YSA9IE5VTEw7 CisJfQogfQogCiAjaWZkZWYgQ09ORklHX1BNCkBAIC02NTMsMjUgKzUzOCwyMyBAQCBzdGF0aWMg aW50IHB4YV9zc3BfaHdfcGFyYW1zKHN0cnVjdCBzbmRfcGNtX3N1YnN0cmVhbSAqc3Vic3RyZWFt LAogCXN0cnVjdCBzbmRfc29jX2RhaSAqY3B1X2RhaSA9IHJ0ZC0+ZGFpLT5jcHVfZGFpOwogCXN0 cnVjdCBzc3BfcHJpdiAqcHJpdiA9IGNwdV9kYWktPnByaXZhdGVfZGF0YTsKIAlzdHJ1Y3Qgc3Nw X2RldmljZSAqc3NwID0gcHJpdi0+ZGV2LnNzcDsKLQlpbnQgZG1hID0gMCwgY2huID0gcGFyYW1z X2NoYW5uZWxzKHBhcmFtcyk7CisJaW50IGNobiA9IHBhcmFtc19jaGFubmVscyhwYXJhbXMpOwog CXUzMiBzc2NyMDsKIAl1MzIgc3Nwc3A7CiAJaW50IHdpZHRoID0gc25kX3BjbV9mb3JtYXRfcGh5 c2ljYWxfd2lkdGgocGFyYW1zX2Zvcm1hdChwYXJhbXMpKTsKIAlpbnQgdHRzYSA9IHNzcF9yZWFk X3JlZyhzc3AsIFNTVFNBKSAmIDB4ZjsKIAotCS8qIHNlbGVjdCBjb3JyZWN0IERNQSBwYXJhbXMg Ki8KLQlpZiAoc3Vic3RyZWFtLT5zdHJlYW0gIT0gU05EUlZfUENNX1NUUkVBTV9QTEFZQkFDSykK LQkJZG1hID0gMTsgLyogY2FwdHVyZSBETUEgb2Zmc2V0IGlzIDEsMyAqLworCS8qIGdlbmVyYXRl IGNvcnJlY3QgRE1BIHBhcmFtcyAqLworCWlmIChjcHVfZGFpLT5kbWFfZGF0YSkKKwkJa2ZyZWUo Y3B1X2RhaS0+ZG1hX2RhdGEpOworCiAJLyogTmV0d29yayBtb2RlIHdpdGggb25lIGFjdGl2ZSBz bG90ICh0dHNhID09IDEpIGNhbiBiZSB1c2VkCiAJICogdG8gZm9yY2UgMTYtYml0IGZyYW1lIHdp ZHRoIG9uIHRoZSB3aXJlIChmb3IgUzE2X0xFKSwgZXZlbgogCSAqIHdpdGggdHdvIGNoYW5uZWxz LiBVc2UgMTYtYml0IERNQSB0cmFuc2ZlcnMgZm9yIHRoaXMgY2FzZS4KIAkgKi8KLQlpZiAoKChj aG4gPT0gMikgJiYgKHR0c2EgIT0gMSkpIHx8ICh3aWR0aCA9PSAzMikpCi0JCWRtYSArPSAyOyAv KiAzMi1iaXQgRE1BIG9mZnNldCBpcyAyLCAxNi1iaXQgaXMgMCAqLwotCi0JY3B1X2RhaS0+ZG1h X2RhdGEgPSBzc3BfZG1hX3BhcmFtc1tjcHVfZGFpLT5pZF1bZG1hXTsKLQotCWRldl9kYmcoJnNz cC0+cGRldi0+ZGV2LCAicHhhX3NzcF9od19wYXJhbXM6IGRtYSAlZFxuIiwgZG1hKTsKKwljcHVf ZGFpLT5kbWFfZGF0YSA9IHNzcF9nZXRfZG1hX3BhcmFtcyhzc3AsCisJCQkoKGNobiA9PSAyKSAm JiAodHRzYSAhPSAxKSkgfHwgKHdpZHRoID09IDMyKSwKKwkJCXN1YnN0cmVhbS0+c3RyZWFtID09 IFNORFJWX1BDTV9TVFJFQU1fUExBWUJBQ0spOwogCiAJLyogd2UgY2FuIG9ubHkgY2hhbmdlIHRo ZSBzZXR0aW5ncyBpZiB0aGUgcG9ydCBpcyBub3QgaW4gdXNlICovCiAJaWYgKHNzcF9yZWFkX3Jl Zyhzc3AsIFNTQ1IwKSAmIFNTQ1IwX1NTRSkKLS0gCjEuNi4wLjQKCg== --0016364ee0220e5a4e0468352f08--

1 0

[PATCH] ASoC: simplify the SSP DMA parameters settings by
by Eric Miao 23 Apr '09

23 Apr '09

run-time generation The SSP DMA parameters can actually be easily generated at run-time since they are almost similar except for the FIFO width and direction. Another benefit is the re-use of information from 'struct ssp_device', like SSDR physical FIFO address and DRCMR register index for both directions. In addition, the name of the DMA parameter has been changed to something like: "SSP3 PCM 16-bit out" or "SSP3 PCM 32-bit in" instead of the original "Stereo" and "Mono". This is more consistent with the code. Signed-off-by: Eric Miao <eric.miao(a)marvell.com> Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Reviewed-by: pHilipp Zabel <philipp.zabel(a)gmail.com> --- sound/soc/pxa/pxa-ssp.c | 203 ++++++++++------------------------------------- 1 files changed, 43 insertions(+), 160 deletions(-) diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c index b9b61dd..6fc7876 100644 --- a/sound/soc/pxa/pxa-ssp.c +++ b/sound/soc/pxa/pxa-ssp.c @@ -50,139 +50,6 @@ struct ssp_priv { #endif }; -#define PXA2xx_SSP1_BASE 0x41000000 -#define PXA27x_SSP2_BASE 0x41700000 -#define PXA27x_SSP3_BASE 0x41900000 -#define PXA3xx_SSP4_BASE 0x41a00000 - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_mono_out = { - .name = "SSP1 PCM Mono out", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(14), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_mono_in = { - .name = "SSP1 PCM Mono in", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(13), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_stereo_out = { - .name = "SSP1 PCM Stereo out", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(14), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp1_pcm_stereo_in = { - .name = "SSP1 PCM Stereo in", - .dev_addr = PXA2xx_SSP1_BASE + SSDR, - .drcmr = &DRCMR(13), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_mono_out = { - .name = "SSP2 PCM Mono out", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(16), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_mono_in = { - .name = "SSP2 PCM Mono in", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(15), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_stereo_out = { - .name = "SSP2 PCM Stereo out", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(16), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp2_pcm_stereo_in = { - .name = "SSP2 PCM Stereo in", - .dev_addr = PXA27x_SSP2_BASE + SSDR, - .drcmr = &DRCMR(15), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_mono_out = { - .name = "SSP3 PCM Mono out", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_mono_in = { - .name = "SSP3 PCM Mono in", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_stereo_out = { - .name = "SSP3 PCM Stereo out", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp3_pcm_stereo_in = { - .name = "SSP3 PCM Stereo in", - .dev_addr = PXA27x_SSP3_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_mono_out = { - .name = "SSP4 PCM Mono out", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_mono_in = { - .name = "SSP4 PCM Mono in", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH2, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_stereo_out = { - .name = "SSP4 PCM Stereo out", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(67), - .dcmd = DCMD_INCSRCADDR | DCMD_FLOWTRG | - DCMD_BURST16 | DCMD_WIDTH4, -}; - -static struct pxa2xx_pcm_dma_params pxa_ssp4_pcm_stereo_in = { - .name = "SSP4 PCM Stereo in", - .dev_addr = PXA3xx_SSP4_BASE + SSDR, - .drcmr = &DRCMR(66), - .dcmd = DCMD_INCTRGADDR | DCMD_FLOWSRC | - DCMD_BURST16 | DCMD_WIDTH4, -}; - static void dump_registers(struct ssp_device *ssp) { dev_dbg(&ssp->pdev->dev, "SSCR0 0x%08x SSCR1 0x%08x SSTO 0x%08x\n", @@ -194,25 +61,33 @@ static void dump_registers(struct ssp_device *ssp) ssp_read_reg(ssp, SSACD)); } -static struct pxa2xx_pcm_dma_params *ssp_dma_params[4][4] = { - { - &pxa_ssp1_pcm_mono_out, &pxa_ssp1_pcm_mono_in, - &pxa_ssp1_pcm_stereo_out, &pxa_ssp1_pcm_stereo_in, - }, - { - &pxa_ssp2_pcm_mono_out, &pxa_ssp2_pcm_mono_in, - &pxa_ssp2_pcm_stereo_out, &pxa_ssp2_pcm_stereo_in, - }, - { - &pxa_ssp3_pcm_mono_out, &pxa_ssp3_pcm_mono_in, - &pxa_ssp3_pcm_stereo_out, &pxa_ssp3_pcm_stereo_in, - }, - { - &pxa_ssp4_pcm_mono_out, &pxa_ssp4_pcm_mono_in, - &pxa_ssp4_pcm_stereo_out, &pxa_ssp4_pcm_stereo_in, - }, +struct pxa2xx_pcm_dma_data { + struct pxa2xx_pcm_dma_params params; + char name[20]; }; +static struct pxa2xx_pcm_dma_params * +ssp_get_dma_params(struct ssp_device *ssp, int width4, int out) +{ + struct pxa2xx_pcm_dma_data *dma; + + dma = kzalloc(sizeof(struct pxa2xx_pcm_dma_data), GFP_KERNEL); + if (dma == NULL) + return NULL; + + snprintf(dma->name, 20, "SSP%d PCM %s %s", ssp->port_id, + width4 ? "32-bit" : "16-bit", out ? "out" : "in"); + + dma->params.name = dma->name; + dma->params.drcmr = &DRCMR(out ? ssp->drcmr_tx : ssp->drcmr_rx); + dma->params.dcmd = (out ? (DCMD_INCSRCADDR | DCMD_FLOWTRG) : + (DCMD_INCTRGADDR | DCMD_FLOWSRC)) | + (width4 ? DCMD_WIDTH4 : DCMD_WIDTH2) | DCMD_BURST16; + dma->params.dev_addr = ssp->phys_base + SSDR; + + return &dma->params; +} + static int pxa_ssp_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { @@ -227,6 +102,11 @@ static int pxa_ssp_startup(struct snd_pcm_substream *substream, clk_enable(priv->dev.ssp->clk); ssp_disable(&priv->dev); } + + if (cpu_dai->dma_data) { + kfree(cpu_dai->dma_data); + cpu_dai->dma_data = NULL; + } return ret; } @@ -241,6 +121,11 @@ static void pxa_ssp_shutdown(struct snd_pcm_substream *substream, ssp_disable(&priv->dev); clk_disable(priv->dev.ssp->clk); } + + if (cpu_dai->dma_data) { + kfree(cpu_dai->dma_data); + cpu_dai->dma_data = NULL; + } } #ifdef CONFIG_PM @@ -653,25 +538,23 @@ static int pxa_ssp_hw_params(struct snd_pcm_substream *substream, struct snd_soc_dai *cpu_dai = rtd->dai->cpu_dai; struct ssp_priv *priv = cpu_dai->private_data; struct ssp_device *ssp = priv->dev.ssp; - int dma = 0, chn = params_channels(params); + int chn = params_channels(params); u32 sscr0; u32 sspsp; int width = snd_pcm_format_physical_width(params_format(params)); int ttsa = ssp_read_reg(ssp, SSTSA) & 0xf; - /* select correct DMA params */ - if (substream->stream != SNDRV_PCM_STREAM_PLAYBACK) - dma = 1; /* capture DMA offset is 1,3 */ + /* generate correct DMA params */ + if (cpu_dai->dma_data) + kfree(cpu_dai->dma_data); + /* Network mode with one active slot (ttsa == 1) can be used * to force 16-bit frame width on the wire (for S16_LE), even * with two channels. Use 16-bit DMA transfers for this case. */ - if (((chn == 2) && (ttsa != 1)) || (width == 32)) - dma += 2; /* 32-bit DMA offset is 2, 16-bit is 0 */ - - cpu_dai->dma_data = ssp_dma_params[cpu_dai->id][dma]; - - dev_dbg(&ssp->pdev->dev, "pxa_ssp_hw_params: dma %d\n", dma); + cpu_dai->dma_data = ssp_get_dma_params(ssp, + ((chn == 2) && (ttsa != 1)) || (width == 32), + substream->stream == SNDRV_PCM_STREAM_PLAYBACK); /* we can only change the settings if the port is not in use */ if (ssp_read_reg(ssp, SSCR0) & SSCR0_SSE) -- 1.6.0.4 --0016364eef74c9234b046835b0db Content-Type: text/x-diff; charset=US-ASCII; name="0001-ASoC-simplify-the-SSP-DMA-parameters-settings-by-ru.patch" Content-Disposition: attachment; filename="0001-ASoC-simplify-the-SSP-DMA-parameters-settings-by-ru.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ftv9ixzn0 RnJvbSAzZGVhZjNjZTQzOTc5MDY2OGZkM2YwNDE0MjMyNmNmODRjYjcxYjM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmljIE1pYW8gPGVyaWMubWlhb0BtYXJ2ZWxsLmNvbT4KRGF0 ZTogVGh1LCAyMyBBcHIgMjAwOSAxMDo1ODozNCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFTb0M6 IHNpbXBsaWZ5IHRoZSBTU1AgRE1BIHBhcmFtZXRlcnMgc2V0dGluZ3MgYnkgcnVuLXRpbWUgZ2Vu ZXJhdGlvbgoKVGhlIFNTUCBETUEgcGFyYW1ldGVycyBjYW4gYWN0dWFsbHkgYmUgZWFzaWx5IGdl bmVyYXRlZCBhdCBydW4tdGltZSBzaW5jZQp0aGV5IGFyZSBhbG1vc3Qgc2ltaWxhciBleGNlcHQg Zm9yIHRoZSBGSUZPIHdpZHRoIGFuZCBkaXJlY3Rpb24uIEFub3RoZXIKYmVuZWZpdCBpcyB0aGUg cmUtdXNlIG9mIGluZm9ybWF0aW9uIGZyb20gJ3N0cnVjdCBzc3BfZGV2aWNlJywgbGlrZSBTU0RS CnBoeXNpY2FsIEZJRk8gYWRkcmVzcyBhbmQgRFJDTVIgcmVnaXN0ZXIgaW5kZXggZm9yIGJvdGgg ZGlyZWN0aW9ucy4KCkluIGFkZGl0aW9uLCB0aGUgbmFtZSBvZiB0aGUgRE1BIHBhcmFtZXRlciBo YXMgYmVlbiBjaGFuZ2VkIHRvIHNvbWV0aGluZwpsaWtlOgoKICAiU1NQMyBQQ00gMTYtYml0IG91 dCIgb3IgIlNTUDMgUENNIDMyLWJpdCBpbiIKCmluc3RlYWQgb2YgdGhlIG9yaWdpbmFsICJTdGVy ZW8iIGFuZCAiTW9ubyIuIFRoaXMgaXMgbW9yZSBjb25zaXN0ZW50IHdpdGgKdGhlIGNvZGUuCgpT aWduZWQtb2ZmLWJ5OiBFcmljIE1pYW8gPGVyaWMubWlhb0BtYXJ2ZWxsLmNvbT4KU2lnbmVkLW9m Zi1ieTogTWFyayBCcm93biA8YnJvb25pZUBvcGVuc291cmNlLndvbGZzb25taWNyby5jb20+ClJl dmlld2VkLWJ5OiBwSGlsaXBwIFphYmVsIDxwaGlsaXBwLnphYmVsQGdtYWlsLmNvbT4KLS0tCiBz b3VuZC9zb2MvcHhhL3B4YS1zc3AuYyB8ICAyMDMgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZXMgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwg MTYwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy9weGEvcHhhLXNzcC5jIGIv c291bmQvc29jL3B4YS9weGEtc3NwLmMKaW5kZXggYjliNjFkZC4uNmZjNzg3NiAxMDA2NDQKLS0t IGEvc291bmQvc29jL3B4YS9weGEtc3NwLmMKKysrIGIvc291bmQvc29jL3B4YS9weGEtc3NwLmMK QEAgLTUwLDEzOSArNTAsNiBAQCBzdHJ1Y3Qgc3NwX3ByaXYgewogI2VuZGlmCiB9OwogCi0jZGVm aW5lIFBYQTJ4eF9TU1AxX0JBU0UJMHg0MTAwMDAwMAotI2RlZmluZSBQWEEyN3hfU1NQMl9CQVNF CTB4NDE3MDAwMDAKLSNkZWZpbmUgUFhBMjd4X1NTUDNfQkFTRQkweDQxOTAwMDAwCi0jZGVmaW5l IFBYQTN4eF9TU1A0X0JBU0UJMHg0MWEwMDAwMAotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21f ZG1hX3BhcmFtcyBweGFfc3NwMV9wY21fbW9ub19vdXQgPSB7Ci0JLm5hbWUJCQk9ICJTU1AxIFBD TSBNb25vIG91dCIsCi0JLmRldl9hZGRyCQk9IFBYQTJ4eF9TU1AxX0JBU0UgKyBTU0RSLAotCS5k cmNtcgkJCT0gJkRSQ01SKDE0KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNTUkNBRERSIHwgRENNRF9G TE9XVFJHIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEgyLAotfTsKLQotc3RhdGlj IHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDFfcGNtX21vbm9faW4gPSB7Ci0J Lm5hbWUJCQk9ICJTU1AxIFBDTSBNb25vIGluIiwKLQkuZGV2X2FkZHIJCT0gUFhBMnh4X1NTUDFf QkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoMTMpLAotCS5kY21kCQkJPSBEQ01EX0lO Q1RSR0FERFIgfCBEQ01EX0ZMT1dTUkMgfAotCQkJCSAgRENNRF9CVVJTVDE2IHwgRENNRF9XSURU SDIsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFtcyBweGFfc3NwMV9w Y21fc3RlcmVvX291dCA9IHsKLQkubmFtZQkJCT0gIlNTUDEgUENNIFN0ZXJlbyBvdXQiLAotCS5k ZXZfYWRkcgkJPSBQWEEyeHhfU1NQMV9CQVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZEUkNNUigx NCksCi0JLmRjbWQJCQk9IERDTURfSU5DU1JDQUREUiB8IERDTURfRkxPV1RSRyB8Ci0JCQkJICBE Q01EX0JVUlNUMTYgfCBEQ01EX1dJRFRINCwKLX07Ci0KLXN0YXRpYyBzdHJ1Y3QgcHhhMnh4X3Bj bV9kbWFfcGFyYW1zIHB4YV9zc3AxX3BjbV9zdGVyZW9faW4gPSB7Ci0JLm5hbWUJCQk9ICJTU1Ax IFBDTSBTdGVyZW8gaW4iLAotCS5kZXZfYWRkcgkJPSBQWEEyeHhfU1NQMV9CQVNFICsgU1NEUiwK LQkuZHJjbXIJCQk9ICZEUkNNUigxMyksCi0JLmRjbWQJCQk9IERDTURfSU5DVFJHQUREUiB8IERD TURfRkxPV1NSQyB8Ci0JCQkJICBEQ01EX0JVUlNUMTYgfCBEQ01EX1dJRFRINCwKLX07Ci0KLXN0 YXRpYyBzdHJ1Y3QgcHhhMnh4X3BjbV9kbWFfcGFyYW1zIHB4YV9zc3AyX3BjbV9tb25vX291dCA9 IHsKLQkubmFtZQkJCT0gIlNTUDIgUENNIE1vbm8gb3V0IiwKLQkuZGV2X2FkZHIJCT0gUFhBMjd4 X1NTUDJfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoMTYpLAotCS5kY21kCQkJPSBE Q01EX0lOQ1NSQ0FERFIgfCBEQ01EX0ZMT1dUUkcgfAotCQkJCSAgRENNRF9CVVJTVDE2IHwgRENN RF9XSURUSDIsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFtcyBweGFf c3NwMl9wY21fbW9ub19pbiA9IHsKLQkubmFtZQkJCT0gIlNTUDIgUENNIE1vbm8gaW4iLAotCS5k ZXZfYWRkcgkJPSBQWEEyN3hfU1NQMl9CQVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZEUkNNUigx NSksCi0JLmRjbWQJCQk9IERDTURfSU5DVFJHQUREUiB8IERDTURfRkxPV1NSQyB8Ci0JCQkJICBE Q01EX0JVUlNUMTYgfCBEQ01EX1dJRFRIMiwKLX07Ci0KLXN0YXRpYyBzdHJ1Y3QgcHhhMnh4X3Bj bV9kbWFfcGFyYW1zIHB4YV9zc3AyX3BjbV9zdGVyZW9fb3V0ID0gewotCS5uYW1lCQkJPSAiU1NQ MiBQQ00gU3RlcmVvIG91dCIsCi0JLmRldl9hZGRyCQk9IFBYQTI3eF9TU1AyX0JBU0UgKyBTU0RS LAotCS5kcmNtcgkJCT0gJkRSQ01SKDE2KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNTUkNBRERSIHwg RENNRF9GTE9XVFJHIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEg0LAotfTsKLQot c3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDJfcGNtX3N0ZXJlb19p biA9IHsKLQkubmFtZQkJCT0gIlNTUDIgUENNIFN0ZXJlbyBpbiIsCi0JLmRldl9hZGRyCQk9IFBY QTI3eF9TU1AyX0JBU0UgKyBTU0RSLAotCS5kcmNtcgkJCT0gJkRSQ01SKDE1KSwKLQkuZGNtZAkJ CT0gRENNRF9JTkNUUkdBRERSIHwgRENNRF9GTE9XU1JDIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8 IERDTURfV0lEVEg0LAotfTsKLQotc3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMg cHhhX3NzcDNfcGNtX21vbm9fb3V0ID0gewotCS5uYW1lCQkJPSAiU1NQMyBQQ00gTW9ubyBvdXQi LAotCS5kZXZfYWRkcgkJPSBQWEEyN3hfU1NQM19CQVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZE UkNNUig2NyksCi0JLmRjbWQJCQk9IERDTURfSU5DU1JDQUREUiB8IERDTURfRkxPV1RSRyB8Ci0J CQkJICBEQ01EX0JVUlNUMTYgfCBEQ01EX1dJRFRIMiwKLX07Ci0KLXN0YXRpYyBzdHJ1Y3QgcHhh Mnh4X3BjbV9kbWFfcGFyYW1zIHB4YV9zc3AzX3BjbV9tb25vX2luID0gewotCS5uYW1lCQkJPSAi U1NQMyBQQ00gTW9ubyBpbiIsCi0JLmRldl9hZGRyCQk9IFBYQTI3eF9TU1AzX0JBU0UgKyBTU0RS LAotCS5kcmNtcgkJCT0gJkRSQ01SKDY2KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNUUkdBRERSIHwg RENNRF9GTE9XU1JDIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEgyLAotfTsKLQot c3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDNfcGNtX3N0ZXJlb19v dXQgPSB7Ci0JLm5hbWUJCQk9ICJTU1AzIFBDTSBTdGVyZW8gb3V0IiwKLQkuZGV2X2FkZHIJCT0g UFhBMjd4X1NTUDNfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoNjcpLAotCS5kY21k CQkJPSBEQ01EX0lOQ1NSQ0FERFIgfCBEQ01EX0ZMT1dUUkcgfAotCQkJCSAgRENNRF9CVVJTVDE2 IHwgRENNRF9XSURUSDQsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFt cyBweGFfc3NwM19wY21fc3RlcmVvX2luID0gewotCS5uYW1lCQkJPSAiU1NQMyBQQ00gU3RlcmVv IGluIiwKLQkuZGV2X2FkZHIJCT0gUFhBMjd4X1NTUDNfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJ PSAmRFJDTVIoNjYpLAotCS5kY21kCQkJPSBEQ01EX0lOQ1RSR0FERFIgfCBEQ01EX0ZMT1dTUkMg fAotCQkJCSAgRENNRF9CVVJTVDE2IHwgRENNRF9XSURUSDQsCi19OwotCi1zdGF0aWMgc3RydWN0 IHB4YTJ4eF9wY21fZG1hX3BhcmFtcyBweGFfc3NwNF9wY21fbW9ub19vdXQgPSB7Ci0JLm5hbWUJ CQk9ICJTU1A0IFBDTSBNb25vIG91dCIsCi0JLmRldl9hZGRyCQk9IFBYQTN4eF9TU1A0X0JBU0Ug KyBTU0RSLAotCS5kcmNtcgkJCT0gJkRSQ01SKDY3KSwKLQkuZGNtZAkJCT0gRENNRF9JTkNTUkNB RERSIHwgRENNRF9GTE9XVFJHIHwKLQkJCQkgIERDTURfQlVSU1QxNiB8IERDTURfV0lEVEgyLAot fTsKLQotc3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgcHhhX3NzcDRfcGNtX21v bm9faW4gPSB7Ci0JLm5hbWUJCQk9ICJTU1A0IFBDTSBNb25vIGluIiwKLQkuZGV2X2FkZHIJCT0g UFhBM3h4X1NTUDRfQkFTRSArIFNTRFIsCi0JLmRyY21yCQkJPSAmRFJDTVIoNjYpLAotCS5kY21k CQkJPSBEQ01EX0lOQ1RSR0FERFIgfCBEQ01EX0ZMT1dTUkMgfAotCQkJCSAgRENNRF9CVVJTVDE2 IHwgRENNRF9XSURUSDIsCi19OwotCi1zdGF0aWMgc3RydWN0IHB4YTJ4eF9wY21fZG1hX3BhcmFt cyBweGFfc3NwNF9wY21fc3RlcmVvX291dCA9IHsKLQkubmFtZQkJCT0gIlNTUDQgUENNIFN0ZXJl byBvdXQiLAotCS5kZXZfYWRkcgkJPSBQWEEzeHhfU1NQNF9CQVNFICsgU1NEUiwKLQkuZHJjbXIJ CQk9ICZEUkNNUig2NyksCi0JLmRjbWQJCQk9IERDTURfSU5DU1JDQUREUiB8IERDTURfRkxPV1RS RyB8Ci0JCQkJICBEQ01EX0JVUlNUMTYgfCBEQ01EX1dJRFRINCwKLX07Ci0KLXN0YXRpYyBzdHJ1 Y3QgcHhhMnh4X3BjbV9kbWFfcGFyYW1zIHB4YV9zc3A0X3BjbV9zdGVyZW9faW4gPSB7Ci0JLm5h bWUJCQk9ICJTU1A0IFBDTSBTdGVyZW8gaW4iLAotCS5kZXZfYWRkcgkJPSBQWEEzeHhfU1NQNF9C QVNFICsgU1NEUiwKLQkuZHJjbXIJCQk9ICZEUkNNUig2NiksCi0JLmRjbWQJCQk9IERDTURfSU5D VFJHQUREUiB8IERDTURfRkxPV1NSQyB8Ci0JCQkJICBEQ01EX0JVUlNUMTYgfCBEQ01EX1dJRFRI NCwKLX07Ci0KIHN0YXRpYyB2b2lkIGR1bXBfcmVnaXN0ZXJzKHN0cnVjdCBzc3BfZGV2aWNlICpz c3ApCiB7CiAJZGV2X2RiZygmc3NwLT5wZGV2LT5kZXYsICJTU0NSMCAweCUwOHggU1NDUjEgMHgl MDh4IFNTVE8gMHglMDh4XG4iLApAQCAtMTk0LDI1ICs2MSwzMyBAQCBzdGF0aWMgdm9pZCBkdW1w X3JlZ2lzdGVycyhzdHJ1Y3Qgc3NwX2RldmljZSAqc3NwKQogCQkgc3NwX3JlYWRfcmVnKHNzcCwg U1NBQ0QpKTsKIH0KIAotc3RhdGljIHN0cnVjdCBweGEyeHhfcGNtX2RtYV9wYXJhbXMgKnNzcF9k bWFfcGFyYW1zWzRdWzRdID0gewotCXsKLQkJJnB4YV9zc3AxX3BjbV9tb25vX291dCwgJnB4YV9z c3AxX3BjbV9tb25vX2luLAotCQkmcHhhX3NzcDFfcGNtX3N0ZXJlb19vdXQsICZweGFfc3NwMV9w Y21fc3RlcmVvX2luLAotCX0sCi0JewotCQkmcHhhX3NzcDJfcGNtX21vbm9fb3V0LCAmcHhhX3Nz cDJfcGNtX21vbm9faW4sCi0JCSZweGFfc3NwMl9wY21fc3RlcmVvX291dCwgJnB4YV9zc3AyX3Bj bV9zdGVyZW9faW4sCi0JfSwKLQl7Ci0JCSZweGFfc3NwM19wY21fbW9ub19vdXQsICZweGFfc3Nw M19wY21fbW9ub19pbiwKLQkJJnB4YV9zc3AzX3BjbV9zdGVyZW9fb3V0LCAmcHhhX3NzcDNfcGNt X3N0ZXJlb19pbiwKLQl9LAotCXsKLQkJJnB4YV9zc3A0X3BjbV9tb25vX291dCwgJnB4YV9zc3A0 X3BjbV9tb25vX2luLAotCQkmcHhhX3NzcDRfcGNtX3N0ZXJlb19vdXQsICZweGFfc3NwNF9wY21f c3RlcmVvX2luLAotCX0sCitzdHJ1Y3QgcHhhMnh4X3BjbV9kbWFfZGF0YSB7CisJc3RydWN0IHB4 YTJ4eF9wY21fZG1hX3BhcmFtcyBwYXJhbXM7CisJY2hhciBuYW1lWzIwXTsKIH07CiAKK3N0YXRp YyBzdHJ1Y3QgcHhhMnh4X3BjbV9kbWFfcGFyYW1zICoKK3NzcF9nZXRfZG1hX3BhcmFtcyhzdHJ1 Y3Qgc3NwX2RldmljZSAqc3NwLCBpbnQgd2lkdGg0LCBpbnQgb3V0KQoreworCXN0cnVjdCBweGEy eHhfcGNtX2RtYV9kYXRhICpkbWE7CisKKwlkbWEgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgcHhh Mnh4X3BjbV9kbWFfZGF0YSksIEdGUF9LRVJORUwpOworCWlmIChkbWEgPT0gTlVMTCkKKwkJcmV0 dXJuIE5VTEw7CisKKwlzbnByaW50ZihkbWEtPm5hbWUsIDIwLCAiU1NQJWQgUENNICVzICVzIiwg c3NwLT5wb3J0X2lkLAorCQkJd2lkdGg0ID8gIjMyLWJpdCIgOiAiMTYtYml0Iiwgb3V0ID8gIm91 dCIgOiAiaW4iKTsKKworCWRtYS0+cGFyYW1zLm5hbWUgPSBkbWEtPm5hbWU7CisJZG1hLT5wYXJh bXMuZHJjbXIgPSAmRFJDTVIob3V0ID8gc3NwLT5kcmNtcl90eCA6IHNzcC0+ZHJjbXJfcngpOwor CWRtYS0+cGFyYW1zLmRjbWQgPSAob3V0ID8gKERDTURfSU5DU1JDQUREUiB8IERDTURfRkxPV1RS RykgOgorCQkJCSAgKERDTURfSU5DVFJHQUREUiB8IERDTURfRkxPV1NSQykpIHwKKwkJCSh3aWR0 aDQgPyBEQ01EX1dJRFRINCA6IERDTURfV0lEVEgyKSB8IERDTURfQlVSU1QxNjsKKwlkbWEtPnBh cmFtcy5kZXZfYWRkciA9IHNzcC0+cGh5c19iYXNlICsgU1NEUjsKKworCXJldHVybiAmZG1hLT5w YXJhbXM7Cit9CisKIHN0YXRpYyBpbnQgcHhhX3NzcF9zdGFydHVwKHN0cnVjdCBzbmRfcGNtX3N1 YnN0cmVhbSAqc3Vic3RyZWFtLAogCQkJICAgc3RydWN0IHNuZF9zb2NfZGFpICpkYWkpCiB7CkBA IC0yMjcsNiArMTAyLDExIEBAIHN0YXRpYyBpbnQgcHhhX3NzcF9zdGFydHVwKHN0cnVjdCBzbmRf cGNtX3N1YnN0cmVhbSAqc3Vic3RyZWFtLAogCQljbGtfZW5hYmxlKHByaXYtPmRldi5zc3AtPmNs ayk7CiAJCXNzcF9kaXNhYmxlKCZwcml2LT5kZXYpOwogCX0KKworCWlmIChjcHVfZGFpLT5kbWFf ZGF0YSkgeworCQlrZnJlZShjcHVfZGFpLT5kbWFfZGF0YSk7CisJCWNwdV9kYWktPmRtYV9kYXRh ID0gTlVMTDsKKwl9CiAJcmV0dXJuIHJldDsKIH0KIApAQCAtMjQxLDYgKzEyMSwxMSBAQCBzdGF0 aWMgdm9pZCBweGFfc3NwX3NodXRkb3duKHN0cnVjdCBzbmRfcGNtX3N1YnN0cmVhbSAqc3Vic3Ry ZWFtLAogCQlzc3BfZGlzYWJsZSgmcHJpdi0+ZGV2KTsKIAkJY2xrX2Rpc2FibGUocHJpdi0+ZGV2 LnNzcC0+Y2xrKTsKIAl9CisKKwlpZiAoY3B1X2RhaS0+ZG1hX2RhdGEpIHsKKwkJa2ZyZWUoY3B1 X2RhaS0+ZG1hX2RhdGEpOworCQljcHVfZGFpLT5kbWFfZGF0YSA9IE5VTEw7CisJfQogfQogCiAj aWZkZWYgQ09ORklHX1BNCkBAIC02NTMsMjUgKzUzOCwyMyBAQCBzdGF0aWMgaW50IHB4YV9zc3Bf aHdfcGFyYW1zKHN0cnVjdCBzbmRfcGNtX3N1YnN0cmVhbSAqc3Vic3RyZWFtLAogCXN0cnVjdCBz bmRfc29jX2RhaSAqY3B1X2RhaSA9IHJ0ZC0+ZGFpLT5jcHVfZGFpOwogCXN0cnVjdCBzc3BfcHJp diAqcHJpdiA9IGNwdV9kYWktPnByaXZhdGVfZGF0YTsKIAlzdHJ1Y3Qgc3NwX2RldmljZSAqc3Nw ID0gcHJpdi0+ZGV2LnNzcDsKLQlpbnQgZG1hID0gMCwgY2huID0gcGFyYW1zX2NoYW5uZWxzKHBh cmFtcyk7CisJaW50IGNobiA9IHBhcmFtc19jaGFubmVscyhwYXJhbXMpOwogCXUzMiBzc2NyMDsK IAl1MzIgc3Nwc3A7CiAJaW50IHdpZHRoID0gc25kX3BjbV9mb3JtYXRfcGh5c2ljYWxfd2lkdGgo cGFyYW1zX2Zvcm1hdChwYXJhbXMpKTsKIAlpbnQgdHRzYSA9IHNzcF9yZWFkX3JlZyhzc3AsIFNT VFNBKSAmIDB4ZjsKIAotCS8qIHNlbGVjdCBjb3JyZWN0IERNQSBwYXJhbXMgKi8KLQlpZiAoc3Vi c3RyZWFtLT5zdHJlYW0gIT0gU05EUlZfUENNX1NUUkVBTV9QTEFZQkFDSykKLQkJZG1hID0gMTsg LyogY2FwdHVyZSBETUEgb2Zmc2V0IGlzIDEsMyAqLworCS8qIGdlbmVyYXRlIGNvcnJlY3QgRE1B IHBhcmFtcyAqLworCWlmIChjcHVfZGFpLT5kbWFfZGF0YSkKKwkJa2ZyZWUoY3B1X2RhaS0+ZG1h X2RhdGEpOworCiAJLyogTmV0d29yayBtb2RlIHdpdGggb25lIGFjdGl2ZSBzbG90ICh0dHNhID09 IDEpIGNhbiBiZSB1c2VkCiAJICogdG8gZm9yY2UgMTYtYml0IGZyYW1lIHdpZHRoIG9uIHRoZSB3 aXJlIChmb3IgUzE2X0xFKSwgZXZlbgogCSAqIHdpdGggdHdvIGNoYW5uZWxzLiBVc2UgMTYtYml0 IERNQSB0cmFuc2ZlcnMgZm9yIHRoaXMgY2FzZS4KIAkgKi8KLQlpZiAoKChjaG4gPT0gMikgJiYg KHR0c2EgIT0gMSkpIHx8ICh3aWR0aCA9PSAzMikpCi0JCWRtYSArPSAyOyAvKiAzMi1iaXQgRE1B IG9mZnNldCBpcyAyLCAxNi1iaXQgaXMgMCAqLwotCi0JY3B1X2RhaS0+ZG1hX2RhdGEgPSBzc3Bf ZG1hX3BhcmFtc1tjcHVfZGFpLT5pZF1bZG1hXTsKLQotCWRldl9kYmcoJnNzcC0+cGRldi0+ZGV2 LCAicHhhX3NzcF9od19wYXJhbXM6IGRtYSAlZFxuIiwgZG1hKTsKKwljcHVfZGFpLT5kbWFfZGF0 YSA9IHNzcF9nZXRfZG1hX3BhcmFtcyhzc3AsCisJCQkoKGNobiA9PSAyKSAmJiAodHRzYSAhPSAx KSkgfHwgKHdpZHRoID09IDMyKSwKKwkJCXN1YnN0cmVhbS0+c3RyZWFtID09IFNORFJWX1BDTV9T VFJFQU1fUExBWUJBQ0spOwogCiAJLyogd2UgY2FuIG9ubHkgY2hhbmdlIHRoZSBzZXR0aW5ncyBp ZiB0aGUgcG9ydCBpcyBub3QgaW4gdXNlICovCiAJaWYgKHNzcF9yZWFkX3JlZyhzc3AsIFNTQ1Iw KSAmIFNTQ1IwX1NTRSkKLS0gCjEuNi4wLjQKCg== --0016364eef74c9234b046835b0db--

1 0

[alsa-devel] inserting operations while in rate conversion
by Maris 22 Apr '09

22 Apr '09

I'm running uClinux with ALSA in an Analog Devices' Blackfin CPU environment. Actually I'm checking possibilities in doing special things while ALSA is going to do automatic rate conversion. Specific description: ADC is sampled with 32 or 64 ksps rate. The corresponding hardware driver is specified to operate at one of these rates (which I'll specify later). The application reads the ADC input stream at the output end of the ALSA processing as a stream with a rate of 8 ksps. I need some information about inside details of ALSA's automatic rate conversion (pointers to appropriate information would be helpful). What I want to do: insert a digital anti-aliasing filter algorithm which limits the effective bandwidth of the ADC stream to 4 kHz prior to actually have the rate converted. Of course, I could also add the filter algorithm in the hardware device driver - at the cost of not inherently being available as a hardware independent algorithm. Some detail info: - ADC = AD73311 (speech codec). Basic drivers that allow e.g. arecord & aplay are available. - CPU: convergent DSP/microcontroller core @ 500 MHz and fixed point processing. Thanks for attention. BTW: this is my first dig into ALSA details... Rob Code snippet: (currently only one rate is defined as a correspondence to the hardware driver rate) #define AD73311_RATES (SNDRV_PCM_RATE_8000 | \ SNDRV_PCM_RATE_16000 | \ SNDRV_PCM_RATE_32000 | \ SNDRV_PCM_RATE_64000) struct snd_soc_dai ad73311_dai = { .name = "AD73311", .playback = { .stream_name = "Playback", .channels_min = 1, .channels_max = 1, .rates = SNDRV_PCM_RATE_32000, .formats = SNDRV_PCM_FMTBIT_S16_LE, }, .capture = { .stream_name = "Capture", .channels_min = 1, .channels_max = 1, .rates = SNDRV_PCM_RATE_32000, .formats = SNDRV_PCM_FMTBIT_S16_LE, }, }; EXPORT_SYMBOL_GPL(ad73311_dai);

1 0

[alsa-devel] bug in salsa async handler + patch
by maarten van es 22 Apr '09

22 Apr '09

Hi, I couldn't find where or how to submit patches for salsa, so here goes. This patch resolves random program crashes when using libsalsa with an async handler: snd_async_del_handler does not correctly maintain its list of async handlers. This patch is for salsa-lib-0.0.21, the latest stable version. change src/async.c, line 118 async_list = h; to src/async.c, line 118 async_list = h->next; Maarten

2 1

Re: [alsa-devel] [stable] [PATCH] us122l: add snd_us122l_free()
by Takashi Iwai 22 Apr '09

22 Apr '09

At Tue, 21 Apr 2009 22:20:43 +0000, Chris Wright wrote: > > * Takashi Iwai (tiwai(a)suse.de) wrote: > > At Fri, 17 Apr 2009 13:38:24 +0200, > > Karsten Wiese wrote: > > > > > > Am Freitag 17 April 2009 schrieb Takashi Iwai: > > > > At Thu, 16 Apr 2009 19:38:50 +0200, > > > > Karsten Wiese wrote: > > > > > > > > > > Use it to clean up snd_us122l_card_used[]. > > > > > > > > > > Signed-off-by: Karsten Wiese <fzu(a)wemgehoertderstaat.de> > > > > > Cc: stable(a)kernel.org > > > > > > > > Is it really for stable kernel? Any bug report for this? > > > > > > This really is for stable too. The bug it fixes happens if one does: > > > > > > Start on a pc with onboard soundcard at index 0. > > > $ modprobe snd_usb_us122l modprobe snd_usb_us122l index=2 > > > plug US122L soundcard > > > $ cat /proc/asound/devices > > > last command shows the US122L soundcard is at index 2. > > > > > > unplug US122L soundcard > > > plug US122L soundcard > > > $ cat /proc/asound/devices > > > last command shows the US122L soundcard is at index 1 now, which is the bug > > > the patch fixes. > > > > OK, then please write up the problem to be fixed in the changelog, > > too. > > This looks like it's still outstanding issue. It's already in sound git tree which I'll send a pull request soon later. The relevant commit contains Cc to stable(a)kernel.org, so that it can be handled easily (automatically?)). thanks, Takashi

2 1

[alsa-devel] iMac 9,1 patch work
by Micah Bucy 22 Apr '09

22 Apr '09

I¹m working on a patch for the iMac 9,1 and have the output working. Input is giving me problems. The particular setup is using patch_realtek.c from hda. I noticed that the built-in microphone works if it uses alc883 with model=auto specified. I¹m just not sure what the relevant code is that alc883_auto is using for capture. Any pointers would be helpful. -Micah

2 1

[alsa-devel] [PATCH] ASoC: OMAP: Add checking to detect bufferless pcms
by Joonyoung Shim 22 Apr '09

22 Apr '09

Add checking in hw_params and prepare to detect bufferless pcms(i.e. BT <--> codec). Signed-off-by: Joonyoung Shim <jy0922.shim(a)samsung.com> --- sound/soc/omap/omap-pcm.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c index 07cf7f4..6454e15 100644 --- a/sound/soc/omap/omap-pcm.c +++ b/sound/soc/omap/omap-pcm.c @@ -87,8 +87,10 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream, struct omap_pcm_dma_data *dma_data = rtd->dai->cpu_dai->dma_data; int err = 0; + /* return if this is a bufferless transfer e.g. + * codec <--> BT codec or GSM modem -- lg FIXME */ if (!dma_data) - return -ENODEV; + return 0; snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer); runtime->dma_bytes = params_buffer_bytes(params); @@ -134,6 +136,11 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream) struct omap_pcm_dma_data *dma_data = prtd->dma_data; struct omap_dma_channel_params dma_params; + /* return if this is a bufferless transfer e.g. + * codec <--> BT codec or GSM modem -- lg FIXME */ + if (!prtd->dma_data) + return 0; + memset(&dma_params, 0, sizeof(dma_params)); /* * Note: Regardless of interface data formats supported by OMAP McBSP -- 1.5.6.3

4 6

[alsa-devel] [PATCH v2 0/1] ASoC: TWL4030: Add VDL path support
by Joonyoung Shim 22 Apr '09

22 Apr '09

Hi, I added and modified some DAPMs for VDL path of the twl4030 codec. This patch was posted in the past, but i resend the patch modified more. Please review. Thanks.

1 0

[alsa-devel] Asterisk 1.4.17 and alsa 1.0.19 dmix plugin problem.
by Nicola Mfb 21 Apr '09

21 Apr '09

Hi! I'm sorry if this is an old issue but I did not found help in archives/alsaweb/google and I'm new to alsa, so this report is what I guessed reading sources and compiling test apps for about 2 days, and the following assumptions may be completely wrong. Asterisk has an alsa channel that works fine when using plughw:0,0 both for read and for writing, but if use plug:dmix/plug:dsnoop or default with a dmix/dsnoop wrapper in /etc/asound.conf it does not emit any sound. It uses select on poll fd descriptor to know if the pcm is ready to be sent output samples. The select will never return as it seems the dmix plugin is not able to signal when is ready. I noted that using snd_pcm_wait works well but cannot be used in asterisk as it needs to select on two fd. I guess that snd_pcm_wait with dmix check the shared memory and not the fd descriptor. So should poll/select be avoided completely in applications (as they does not know if the default pcm is a dmix) and asterisk alsa channel be rewritten or is there a workaround? Best Regards Nicola

2 5