- Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] add missing definitions(letters) to HD-Audio.txt
by Justin Mattock 15 Apr '09

15 Apr '09

impact: Add missing definitions(letters). Signed-off-by: Justin P. Mattock <justinmattock(a)gmail.com> --- Documentation/sound/alsa/HD-Audio.txt | 3 +++ 1 files changed,3 insertions(+),0 deletions(-) =========================================================================================== ---- Documentation/sound/alsa/HD-Audio.txt 2009-04-14 17:03:14.000000000 -0700 ++++ Documentation/sound/alsa/HD-Audio.txt 2009-04-14 21:15:22.000000000 -0700 @@ -162,7 +162,7 @@ What `model` option values are available depends on the codec chip. Check your codec chip from the codec proc file (see "Codec Proc-File" section below). It will show the vendor/product name of your codec -chip. Then, see Documentation/sound/alsa/HD-Audio-Modelstxt file, +chip. Then, see Documentation/sound/alsa/HD-Audio-Models.txt file, the section of HD-audio driver. You can find a list of codecs and `model` options belonging to each codec. For example, for Realtek ALC262 codec chip, pass `model=ultra` for devices that are compatible @@ -170,7 +170,7 @@ Thus, the first thing you can do for any brand-new, unsupported and non-working HD-audio hardware is to check HD-audio codec and several -different `model` option values. If you have a luck, some of them +different `model` option values. If you have any luck, some of them might suit with your device well. Some codecs such as ALC880 have a special model option `model=test`. -- Justin P. Mattock

3 4

[alsa-devel] Acer 5920G: HDMI Sound
by tifereth 15 Apr '09

15 Apr '09

hi, i'm the owner of an "Acer 5920g" Laptop with the following specs: - Nvidia 8600m GT - HDMI Port - afaik. Realtek Sound Chip i've tried a lot to get the hdmi sound working, but still without success. As i can only find "requests for help" for this sound chip, perhaps you could help the lost acer 5920 owners and me. things i've tried yet: - updated kernel to vanilla 2.6.29.1 ( alsa 1.8a ) - updated alsa to 1.9 ( stable ) - updated alsa to "1.0.19.46.g516fa.506.gb750c" ( snapshot from 14.04.2009 ) - added the followng line to /etc/modprobe.d/alsa-base: "options snd-hda-intel model=auto" result of aplay -L && aplay -l ist still the same: aplay -l **** Liste von PLAYBACK Geräten **** Karte 0: Intel [HDA Intel], Gerät 0: ALC1200 Analog [ALC1200 Analog] Untergeordnete Geräte: 1/1 Untergeordnetes Gerät '0: subdevice #0 Karte 0: Intel [HDA Intel], Gerät 1: ALC1200 Digital [ALC1200 Digital] Untergeordnete Geräte: 1/1 Untergeordnetes Gerät '0: subdevice #0 aplay -L default:CARD=Intel HDA Intel, ALC1200 Analog Default Audio Device front:CARD=Intel,DEV=0 HDA Intel, ALC1200 Analog Front speakers surround40:CARD=Intel,DEV=0 HDA Intel, ALC1200 Analog 4.0 Surround output to Front and Rear speakers surround41:CARD=Intel,DEV=0 HDA Intel, ALC1200 Analog 4.1 Surround output to Front, Rear and Subwoofer speakers surround50:CARD=Intel,DEV=0 HDA Intel, ALC1200 Analog 5.0 Surround output to Front, Center and Rear speakers surround51:CARD=Intel,DEV=0 HDA Intel, ALC1200 Analog 5.1 Surround output to Front, Center, Rear and Subwoofer speakers surround71:CARD=Intel,DEV=0 HDA Intel, ALC1200 Analog 7.1 Surround output to Front, Center, Side, Rear and Woofer speakers iec958:CARD=Intel,DEV=0 HDA Intel, ALC1200 Digital IEC958 (S/PDIF) Digital Audio Output null Discard all samples (playback) or generate zero samples (capture) alsa_info.sh output: http://www.alsa-project.org/db/?f=aa10ba4429b9cc24826d8ce1a79a0e898fd69dea Hopefully you have anymore ideas i could try, if you need anymore hardware information please contact me thanks in advance, tifereth

1 1

Re: [alsa-devel] 15 April unstable does not handle wave-in
by Susan Cragin 15 Apr '09

15 Apr '09

PLEASE IGNORE THE ONE I JUST SENT OFF-LIST. THANKS. >> >At Wed, 15 Apr 2009 07:22:08 -0400 (GMT-04:00), >> >Susan Cragin wrote: >> >> >> >> I just downloaded and installed the unstable snapshot 15-April 9:55. >> >> Both my sound cards are shown by asoundconf, but neither works. The wave-in wave-out is still not recognized. >> > >> >I suppose you are referring to CA0110? Could you elaborate? >> > >> >The ca0110 codec support itself has no big change. The last one was >> >in Feb. 18. The rest is either HD-audio core or PCM core. But these >> >have little to do with the probing... >> > >> > >> >Takashi >> >> Please excuse my technical ignorance. Here is everything I know. >> My hda-intel card is also not being recognized after installing alsa-driver-unstable. The only thing that works is my usb microphone. >> I think that the program is not giving the instruction to have >> modules inserted on bootup. >> I have attached sample modprobe, aplay, asoundconf, modules, >> alsa-base.conf > >Check /proc/asound/version. Is it the latest one? > >> $ modprobe snd-card-hda-intel > >modprobe snd-hda-intel > > >Takashi $ sudo cat /proc/asound/version Advanced Linux Sound Architecture Driver Version 1.0.19. Compiled on Apr 15 2009 for kernel 2.6.28-11-generic (SMP). susan@ubuntu:~$ modprobe snd-hda-intel WARNING: All config files need .conf: /etc/modprobe.d/oss-compat, it will be ignored in a future release. susan@ubuntu:~$

1 0

[alsa-devel] hda-intel channels hibernate bug
by Johannes Berg 15 Apr '09

15 Apr '09

Hi, On my macbook 5,1 I need to use model=mbp3, as you may still remember. I also need to set channels to 6 to hear anything at all, probably due to the codec mismatch -- it's not really an mbp3 so that only works 80%, but I haven't gotten around to writing a better codec description. However, when I hibernate with channels set to 6, I always need to reset the channels to 6 again after resume to hear anything -- it seems the channels control isn't reset to the hardware at resume time. I suppose this bugs affects any users of this codec, regardless of whether it is actually right or wrong. johannes PS: I wanted to file a bug on the alsa bugtracker but mantisbt decided I had not entered all fields correctly and didn't give me an option to edit, so I had to reenter, which frustrated me enough to give up on mantis.

3 14

[alsa-devel] Gigabyte ALC889A Function ID: 0x01
by Jerry Geis 15 Apr '09

15 Apr '09

I am using the gigabyte MA78GM-US2H motherboard. it has the ALC889A audio. I am trying 1.0.19 and audio works out the analog back port but not over HDMI. Codec: Realtek ALC889A Address: 0 Function Id: 0x1 <--------------------------------- this is different Vendor Id: 0x10ec0885 Subsystem Id: 0x1458a002 Revision Id: 0x100101 No Modem Function Group found Default PCM: rates [0x560]: 44100 48000 96000 192000 bits [0xe]: 16 20 24 formats [0x1]: PCM Default Amp-In caps: N/A Default Amp-Out caps: N/A GPIO: io=2, o=0, i=0, unsolicited=1, wake=0 IO[0]: enable=0, dir=0, wake=0, sticky=0, data=0, unsol=0 IO[1]: enable=0, dir=0, wake=0, sticky=0, data=0, unsol=0 Node 0x02 [Audio Output] wcaps 0x11: Stereo Converter: stream=0, channel=0 PCM: rates [0x560]: 44100 48000 96000 192000 bits [0xe]: 16 20 24 formats [0x1]: PCM Node 0x03 [Audio Output] wcaps 0x11: Stereo I have been looking but havent found a solution yet. I tried grabbing the snapshot tar ball for today but I get errors on the compile. I had a similiar motherboard but it does not report Function ID: 01 : - HDMI audio on this board works correctly. Codec: Realtek ALC889A Address: 0 Vendor Id: 0x10ec0885 Subsystem Id: 0x1458a002 Revision Id: 0x100101 No Modem Function Group found Default PCM: rates [0x560]: 44100 48000 96000 192000 Any thoughts???? Jerry

2 9

Re: [alsa-devel] 15 April unstable does not handle wave-in
by Susan Cragin 15 Apr '09

15 Apr '09

>At Wed, 15 Apr 2009 07:22:08 -0400 (GMT-04:00), >Susan Cragin wrote: >> >> I just downloaded and installed the unstable snapshot 15-April 9:55. >> Both my sound cards are shown by asoundconf, but neither works. The wave-in wave-out is still not recognized. > >I suppose you are referring to CA0110? Could you elaborate? > >The ca0110 codec support itself has no big change. The last one was >in Feb. 18. The rest is either HD-audio core or PCM core. But these >have little to do with the probing... > > >Takashi Please excuse my technical ignorance. Here is everything I know. My hda-intel card is also not being recognized after installing alsa-driver-unstable. The only thing that works is my usb microphone. I think that the program is not giving the instruction to have modules inserted on bootup. I have attached sample modprobe, aplay, asoundconf, modules, alsa-base.conf Susan ---------------------------------------------------------------------- $ modprobe snd-card-hda-intel WARNING: All config files need .conf: /etc/modprobe.d/oss-compat, it will be ignored in a future release. FATAL: Module snd_card_hda_intel not found. oss-compat is already the newest version. ----------------------------------------------------------------------- $ aplay -l **** List of PLAYBACK Hardware Devices **** card 0: Intel [HDA Intel], device 6: Si3054 Modem [Si3054 Modem] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: system [iMic USB audio system], device 0: USB Audio [USB Audio] Subdevices: 1/1 Subdevice #0: subdevice #0 ------------------------------------------------------------------------ $ asoundconf list Names of available sound cards: Intel Generic (this is my Creative X-fi) system (this is my USB microphone) ------------------------------------------------------------------------ # /etc/modules: kernel modules to load at boot time. # # This file contains the names of kernel modules that should be loaded # at boot time, one per line. Lines beginning with "#" are ignored. loop lp ------------------------------------------------------------------------ alsabase.conf # autoloader aliases install sound-slot-0 /sbin/modprobe snd-card-0 install sound-slot-1 /sbin/modprobe snd-card-1 install sound-slot-2 /sbin/modprobe snd-card-2 install sound-slot-3 /sbin/modprobe snd-card-3 install sound-slot-4 /sbin/modprobe snd-card-4 install sound-slot-5 /sbin/modprobe snd-card-5 install sound-slot-6 /sbin/modprobe snd-card-6 install sound-slot-7 /sbin/modprobe snd-card-7 # Cause optional modules to be loaded above generic modules install snd /sbin/modprobe --ignore-install snd $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist snd-ioctl32 ; /sbin/modprobe --quiet --use-blacklist snd-seq ; } # # Workaround at bug #499695 (reverted in Ubuntu see LP #319505) install snd-pcm /sbin/modprobe --ignore-install snd-pcm $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist snd-pcm-oss ; : ; } install snd-mixer /sbin/modprobe --ignore-install snd-mixer $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist snd-mixer-oss ; : ; } install snd-seq /sbin/modprobe --ignore-install snd-seq $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist snd-seq-midi ; /sbin/modprobe --quiet --use-blacklist snd-se$ # install snd-rawmidi /sbin/modprobe --ignore-install snd-rawmidi $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist snd-seq-midi ; : ; } # Cause optional modules to be loaded above sound card driver modules install snd-emu10k1 /sbin/modprobe --ignore-install snd-emu10k1 $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist snd-emu10k1-synth ; } install snd-via82xx /sbin/modprobe --ignore-install snd-via82xx $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist snd-seq ; } # Load saa7134-alsa instead of saa7134 (which gets dragged in by it anyway) install saa7134 /sbin/modprobe --ignore-install saa7134 $CMDLINE_OPTS && { /sbin/modprobe --quiet --use-blacklist saa7134-alsa ; : ; } # Prevent abnormal drivers from grabbing index 0 options bt87x index=-2 options cx88_alsa index=-2 options saa7134-alsa index=-2 options snd-atiixp-modem index=-2 options snd-intel8x0m index=-2 options snd-via82xx-modem index=-2 options snd-usb-audio index=-2 options snd-usb-us122l index=-2 options snd-usb-usx2y index=-2 options snd-usb-caiaq index=-2 # Ubuntu #62691, enable MPU for snd-cmipci options snd-cmipci mpu_port=0x330 fm_port=0x388 # Keep snd-pcsp from beeing loaded as first soundcard options snd-pcsp index=-2

2 1

[alsa-devel] [PATCH] Automatic driver detection for Amilo 3540
by Michalis Pappas 15 Apr '09

15 Apr '09

A patch to fix the issue described in #4344 and #4352. Signed-off-by: Michalis Pappas <mepapp(a)noc.uoa.gr> --- a/alsa-kernel/pci/hda/patch_realtek.c 2009-01-19 13:08:58.000000000 +0200 +++ b/alsa-kernel/pci/hda/patch_realtek.c 2009-04-11 14:15:44.000000000 +0300 @@ -8516,6 +8516,8 @@ SND_PCI_QUIRK(0x1734, 0x1108, "Fujitsu AMILO Pi2515", ALC883_FUJITSU_PI2515), SND_PCI_QUIRK(0x1734, 0x113d, "Fujitsu AMILO Xa3530", ALC888_FUJITSU_XA3530), + SND_PCI_QUIRK(0x1734, 0x1137, "Fujitsu AMILO Xa3540", + ALC888_FUJITSU_XA3530), SND_PCI_QUIRK(0x17aa, 0x101e, "Lenovo 101e", ALC883_LENOVO_101E_2ch), SND_PCI_QUIRK(0x17aa, 0x2085, "Lenovo NB0763", ALC883_LENOVO_NB0763), SND_PCI_QUIRK(0x17aa, 0x3bfc, "Lenovo NB0763", ALC883_LENOVO_NB0763),

2 1

Re: [alsa-devel] Ubuntu sound problem - http://ubuntuforums.org/showthread.php?t=1073090
by crimsunkg＠yahoo.com 15 Apr '09

15 Apr '09

--- On Mon, 4/13/09, jesse fillion <jessefillion24(a)hotmail.com> wrote: > I have attached my alsa-info output. You should try the latest alsa-driver snapshot (http://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-sn…), which contains quite a few fixes.

2 1

[alsa-devel] [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers (v3)
by Jean Delvare 15 Apr '09

15 Apr '09

The legacy i2c binding model is going away soon, so convert the AOA codec drivers to the new model or they'll break. Signed-off-by: Jean Delvare <khali(a)linux-fr.org> Cc: Johannes Berg <johannes(a)sipsolutions.net> Cc: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> Tested-by: Andreas Schwab <schwab(a)linux-m68k.org> --- Johannes, this is a reworked patch which assumes that the onyx codec probing can fail. It's not exactly clean but that's the easiest approach for now. Can you please give it a try? Thanks. sound/aoa/codecs/onyx.c | 76 ++++++++++++++++++++++++++++++++--------------- sound/aoa/codecs/tas.c | 66 +++++++++++++++++++++++++--------------- 2 files changed, 95 insertions(+), 47 deletions(-) --- linux-2.6.30-rc2.orig/sound/aoa/codecs/onyx.c 2009-04-15 09:55:20.000000000 +0200 +++ linux-2.6.30-rc2/sound/aoa/codecs/onyx.c 2009-04-15 14:07:50.000000000 +0200 @@ -47,7 +47,7 @@ MODULE_DESCRIPTION("pcm3052 (onyx) codec struct onyx { /* cache registers 65 to 80, they are write-only! */ u8 cache[16]; - struct i2c_client i2c; + struct i2c_client *i2c; struct aoa_codec codec; u32 initialised:1, spdif_locked:1, @@ -72,7 +72,7 @@ static int onyx_read_register(struct ony *value = onyx->cache[reg-FIRSTREGISTER]; return 0; } - v = i2c_smbus_read_byte_data(&onyx->i2c, reg); + v = i2c_smbus_read_byte_data(onyx->i2c, reg); if (v < 0) return -1; *value = (u8)v; @@ -84,7 +84,7 @@ static int onyx_write_register(struct on { int result; - result = i2c_smbus_write_byte_data(&onyx->i2c, reg, value); + result = i2c_smbus_write_byte_data(onyx->i2c, reg, value); if (!result) onyx->cache[reg-FIRSTREGISTER] = value; return result; @@ -996,12 +996,45 @@ static void onyx_exit_codec(struct aoa_c onyx->codec.soundbus_dev->detach_codec(onyx->codec.soundbus_dev, onyx); } -static struct i2c_driver onyx_driver; - static int onyx_create(struct i2c_adapter *adapter, struct device_node *node, int addr) { + struct i2c_board_info info; + struct i2c_client *client; + + memset(&info, 0, sizeof(struct i2c_board_info)); + strlcpy(info.type, "aoa_codec_onyx", I2C_NAME_SIZE); + info.addr = addr; + info.platform_data = node; + client = i2c_new_device(adapter, &info); + if (!client) + return -ENODEV; + + /* + * We know the driver is already loaded, so the device should be + * already bound. If not it means binding failed, which suggests + * the device doesn't really exist and should be deleted. + * Ideally this would be replaced by better checks _before_ + * instantiating the device. + */ + if (!client->driver) { + i2c_unregister_device(client); + return -ENODEV; + } + + /* + * Let i2c-core delete that device on driver removal. + * This is safe because i2c-core holds the core_lock mutex for us. + */ + list_add_tail(&client->detected, &client->driver->clients); + return 0; +} + +static int onyx_i2c_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct device_node *node = client->dev.platform_data; struct onyx *onyx; u8 dummy; @@ -1011,20 +1044,12 @@ static int onyx_create(struct i2c_adapte return -ENOMEM; mutex_init(&onyx->mutex); - onyx->i2c.driver = &onyx_driver; - onyx->i2c.adapter = adapter; - onyx->i2c.addr = addr & 0x7f; - strlcpy(onyx->i2c.name, "onyx audio codec", I2C_NAME_SIZE); - - if (i2c_attach_client(&onyx->i2c)) { - printk(KERN_ERR PFX "failed to attach to i2c\n"); - goto fail; - } + onyx->i2c = client; + i2c_set_clientdata(client, onyx); /* we try to read from register ONYX_REG_CONTROL * to check if the codec is present */ if (onyx_read_register(onyx, ONYX_REG_CONTROL, &dummy) != 0) { - i2c_detach_client(&onyx->i2c); printk(KERN_ERR PFX "failed to read control register\n"); goto fail; } @@ -1036,14 +1061,14 @@ static int onyx_create(struct i2c_adapte onyx->codec.node = of_node_get(node); if (aoa_codec_register(&onyx->codec)) { - i2c_detach_client(&onyx->i2c); goto fail; } printk(KERN_DEBUG PFX "created and attached onyx instance\n"); return 0; fail: + i2c_set_clientdata(client, NULL); kfree(onyx); - return -EINVAL; + return -ENODEV; } static int onyx_i2c_attach(struct i2c_adapter *adapter) @@ -1080,28 +1105,33 @@ static int onyx_i2c_attach(struct i2c_ad return onyx_create(adapter, NULL, 0x47); } -static int onyx_i2c_detach(struct i2c_client *client) +static int onyx_i2c_remove(struct i2c_client *client) { - struct onyx *onyx = container_of(client, struct onyx, i2c); - int err; + struct onyx *onyx = i2c_get_clientdata(client); - if ((err = i2c_detach_client(client))) - return err; aoa_codec_unregister(&onyx->codec); of_node_put(onyx->codec.node); if (onyx->codec_info) kfree(onyx->codec_info); + i2c_set_clientdata(client, onyx); kfree(onyx); return 0; } +static const struct i2c_device_id onyx_i2c_id[] = { + { "aoa_codec_onyx", 0 }, + { } +}; + static struct i2c_driver onyx_driver = { .driver = { .name = "aoa_codec_onyx", .owner = THIS_MODULE, }, .attach_adapter = onyx_i2c_attach, - .detach_client = onyx_i2c_detach, + .probe = onyx_i2c_probe, + .remove = onyx_i2c_remove, + .id_table = onyx_i2c_id, }; static int __init onyx_init(void) --- linux-2.6.30-rc2.orig/sound/aoa/codecs/tas.c 2009-04-15 09:55:20.000000000 +0200 +++ linux-2.6.30-rc2/sound/aoa/codecs/tas.c 2009-04-15 09:56:39.000000000 +0200 @@ -82,7 +82,7 @@ MODULE_DESCRIPTION("tas codec driver for struct tas { struct aoa_codec codec; - struct i2c_client i2c; + struct i2c_client *i2c; u32 mute_l:1, mute_r:1 , controls_created:1 , drc_enabled:1, @@ -108,9 +108,9 @@ static struct tas *codec_to_tas(struct a static inline int tas_write_reg(struct tas *tas, u8 reg, u8 len, u8 *data) { if (len == 1) - return i2c_smbus_write_byte_data(&tas->i2c, reg, *data); + return i2c_smbus_write_byte_data(tas->i2c, reg, *data); else - return i2c_smbus_write_i2c_block_data(&tas->i2c, reg, len, data); + return i2c_smbus_write_i2c_block_data(tas->i2c, reg, len, data); } static void tas3004_set_drc(struct tas *tas) @@ -882,12 +882,34 @@ static void tas_exit_codec(struct aoa_co } -static struct i2c_driver tas_driver; - static int tas_create(struct i2c_adapter *adapter, struct device_node *node, int addr) { + struct i2c_board_info info; + struct i2c_client *client; + + memset(&info, 0, sizeof(struct i2c_board_info)); + strlcpy(info.type, "aoa_codec_tas", I2C_NAME_SIZE); + info.addr = addr; + info.platform_data = node; + + client = i2c_new_device(adapter, &info); + if (!client) + return -ENODEV; + + /* + * Let i2c-core delete that device on driver removal. + * This is safe because i2c-core holds the core_lock mutex for us. + */ + list_add_tail(&client->detected, &client->driver->clients); + return 0; +} + +static int tas_i2c_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct device_node *node = client->dev.platform_data; struct tas *tas; tas = kzalloc(sizeof(struct tas), GFP_KERNEL); @@ -896,17 +918,11 @@ static int tas_create(struct i2c_adapter return -ENOMEM; mutex_init(&tas->mtx); - tas->i2c.driver = &tas_driver; - tas->i2c.adapter = adapter; - tas->i2c.addr = addr; + tas->i2c = client; + i2c_set_clientdata(client, tas); + /* seems that half is a saner default */ tas->drc_range = TAS3004_DRC_MAX / 2; - strlcpy(tas->i2c.name, "tas audio codec", I2C_NAME_SIZE); - - if (i2c_attach_client(&tas->i2c)) { - printk(KERN_ERR PFX "failed to attach to i2c\n"); - goto fail; - } strlcpy(tas->codec.name, "tas", MAX_CODEC_NAME_LEN); tas->codec.owner = THIS_MODULE; @@ -915,14 +931,12 @@ static int tas_create(struct i2c_adapter tas->codec.node = of_node_get(node); if (aoa_codec_register(&tas->codec)) { - goto detach; + goto fail; } printk(KERN_DEBUG "snd-aoa-codec-tas: tas found, addr 0x%02x on %s\n", - addr, node->full_name); + (unsigned int)client->addr, node->full_name); return 0; - detach: - i2c_detach_client(&tas->i2c); fail: mutex_destroy(&tas->mtx); kfree(tas); @@ -970,14 +984,11 @@ static int tas_i2c_attach(struct i2c_ada return -ENODEV; } -static int tas_i2c_detach(struct i2c_client *client) +static int tas_i2c_remove(struct i2c_client *client) { - struct tas *tas = container_of(client, struct tas, i2c); - int err; + struct tas *tas = i2c_get_clientdata(client); u8 tmp = TAS_ACR_ANALOG_PDOWN; - if ((err = i2c_detach_client(client))) - return err; aoa_codec_unregister(&tas->codec); of_node_put(tas->codec.node); @@ -989,13 +1000,20 @@ static int tas_i2c_detach(struct i2c_cli return 0; } +static const struct i2c_device_id tas_i2c_id[] = { + { "aoa_codec_tas", 0 }, + { } +}; + static struct i2c_driver tas_driver = { .driver = { .name = "aoa_codec_tas", .owner = THIS_MODULE, }, .attach_adapter = tas_i2c_attach, - .detach_client = tas_i2c_detach, + .probe = tas_i2c_probe, + .remove = tas_i2c_remove, + .id_table = tas_i2c_id, }; static int __init tas_init(void) -- Jean Delvare

2 2

[alsa-devel] 15 April unstable does not handle wave-in
by Susan Cragin 15 Apr '09

15 Apr '09

I just downloaded and installed the unstable snapshot 15-April 9:55. Both my sound cards are shown by asoundconf, but neither works. The wave-in wave-out is still not recognized. (USB sound does work.) System: Asus G1S running Ubuntu Jaunty with all updates (most recent kernel is only 2.6.28-11-Generic). Sound cards present: hda-intel / Realtek ALC660-VD hda-audio-generic / Creative CA0110-IBG (Creative X-fi)

2 1