- Alsa-devel - mailman.alsa-project.org

[alsa-devel] About my issue with the sound on a Dell Dimension 4550.
by Kristoffer Grundström 21 May '09

21 May '09

What is the problem? I really want to know if it's about to be fixed. I'm getting tired of having no sound. https://qa.mandriva.com/show_bug.cgi?id=49048 /Kristoffer

2 1

[alsa-devel] [PATCH 0/2] ASoC: TWL4030: DAPM restructuring and Headset pop-attenuation fix
by Peter Ujfalusi 21 May '09

21 May '09

Hello, The following series aims to fix the Headset power on/off pop noise problems. Since the twl4030 codec internal implementation have this order in HW: DAC -> Analog PGA -> Mixer While the ASoC framework expects the following order: DAC -> Mixer -> Analog PGA I needed to move the APGA control from SND_SOC_DAPM_PGA to be handled with _MIXER. Than adding a PGA to the headset outputs results correct power sequences. This patch also separates the analog and digital loopback paths, so when the analog loopback is enabled none of the DACs will be powered on, while in case of digital loopback the corresponding DACs will be powered. These are internal changes, not visible for the user. I have tested it with my custom board with the headset soldered to HeadsetL, the pop noise is really small if any. The user must also set the correct ramp delay for the given board. On my board: MCLK = 38.4MHz RAMP_DELAY = 2 (109/81/55 ms) works best (meaning 55ms ramp delay), if it is shorter, than it clicks, if it is longer, than it does not click, but the beep tone can be observed. I hope that I have not missed anything with the patches, since these are forward ported from my working tree to sound-2.6:topic/asoc. I have applied the patch from Misael on top of the current topic/asoc, so the head was: ASoC: TWL4030: Enable/disable voice digital filters I believe that this should be able to minimize the pop noise on the headset outputs. --- Peter Ujfalusi (2): ASoC: TWL4030: Change DAPM routings and controls for DACs and PGAs ASoC: TWL4030: Move the Headset pop-attenuation code to PGA event sound/soc/codecs/twl4030.c | 257 ++++++++++++++++++++++++++++---------------- 1 files changed, 162 insertions(+), 95 deletions(-)

5 18

[alsa-devel] [GIT branch] Fix envy24control on glibc-2.10
by Diego E. “Flameeyes” Pettenò 21 May '09

21 May '09

I've pushed to git://git.flameeyes.eu/others/alsa/alsa-tools.git a single commit to fix building of envy24control on glibc-2.10. HTH, -- Diego Elio Pettenò — “Flameeyes” http://blog.flameeyes.eu/ If you found a .asc file in this mail and know not what it is, it's a GnuPG digital signature: http://www.gnupg.org/

1 1

[alsa-devel] Testers wanted: New SB X-Fi driver
by Noel Bourke 21 May '09

21 May '09

Hi Takashi, I set this up with an Auzentech X-Fi Prelude. Driver works OK but sound seemed a bit off. According to speaker-test I seem to only have one audio channel! Any thoughts? Regards, Noel

3 5

[alsa-devel] Testers wanted: New SB X-Fi driver
by Marcel Mulders 20 May '09

20 May '09

Hi Takashi, I tried the snd-ctxfi driver on Ubuntu Jaunty x64. Seems to work just fine for me. Audacious and Totem have no problems as far as I can see. Great work, your efforts are very much appreciated! I was wondering, is there any chance to get the headphones-output on the frontpanel working? I don't really need all the other jacks to work, just plain old analog stereo.. ;-) In one of the closed-source drivers from Creative from a year ago or so, version 1.18, that worked fine. In the opensource driver from last February, the headphones were broken again, just like with the latest snapshot alsa drivers. Can you comment on this maybe? Thanks in advance. Marcel

1 0

Re: [alsa-devel] Acer Aspire One codec: Realtek ALC272 not found in ALSA-Configuration.txt Mic does not capture in alsamixer
by Takashi Iwai 20 May '09

20 May '09

[Please don't drop Cc from alsa-devel ML so that other people can follow.] At Wed, 20 May 2009 12:51:17 -0400, wirechief wrote: > > Takashi > I got brave. i did compile this: > ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-sna… > I used this: > sudo apt-get install build-essential linux-headers-$(uname -r) > ./configure --with-cards=all > make > sudo make install Note that you may have already the driver modules in the update directory in /lib/modules/*, depending on distro. As default, alsa-driver external build tries to replace the existing /lib/module/*/kernel/ module files, but the update directory always wins. Takashi > then i rebooted and re-ran the alsa script : > http://www.alsa-project.org/db/?f=249eea933a054742dc27c86822edecc0c731e1b9 > > Sorry if but i am new to this and wonder if i should of compiled more > than just this > "snapshot" the report does show the new driver however, i am including a .png of > alsamixer if that helps. > > > > On Wed, May 20, 2009 at 10:34 AM, wirechief <silvermachineman(a)gmail.com> wrote: > > thank you very much, I am trying to contact dtchen perhaps he can advise > > perhaps there is a backport for jaunty 9.04 remix that i can get a .deb > > > > On Wed, May 20, 2009 at 10:26 AM, Takashi Iwai <tiwai(a)suse.de> wrote: > >> At Wed, 20 May 2009 10:23:30 -0400, > >> wirechief wrote: > >>> > >>> My skills at doing compiling is limited and not sure this netbook can > >>> accomplish > >>> this. I will look for 1.0.20 in a deb as my first option, perhaps that > >>> will work.. > >> > >> There are lots of changes since 1.0.20, so you should try anyway the > >> later version. > >> > >> Cc'ed ML, so that anyone who knows well Debian could help... > >> > >> > >> thanks, > >> > >> Takashi > >> > > > > > > > > -- > > Reach out and share life, care for others, > > > > > > -- > Reach out and share life, care for others, > [2 alsamixer.png <image/png (base64)>] >

1 0

Re: [alsa-devel] Acer Aspire One codec: Realtek ALC272 not found in ALSA-Configuration.txt Mic does not capture in alsamixer
by Takashi Iwai 20 May '09

20 May '09

At Wed, 20 May 2009 10:23:30 -0400, wirechief wrote: > > My skills at doing compiling is limited and not sure this netbook can > accomplish > this. I will look for 1.0.20 in a deb as my first option, perhaps that > will work.. There are lots of changes since 1.0.20, so you should try anyway the later version. Cc'ed ML, so that anyone who knows well Debian could help... thanks, Takashi

1 0

[alsa-devel] Acer Aspire One codec: Realtek ALC272 not found in ALSA-Configuration.txt Mic does not capture in alsamixer
by wirechief 20 May '09

20 May '09

Host/Kernel/OS "wirechief-notebook" running Linux 2.6.30-020630rc5-generic i686 [ Jaunty 9.04 remix ] CPU Info (1) Intel Atom N270 @ 512 KB cache flags( sse3 ) clocked at [ 1333.000 MHz ] (2) Intel Atom N270 @ 512 KB cache flags( sse3 ) clocked at [ 800.000 MHz ] Videocard Intel Mobile 945GME Express Integrated Graphics Controller X.Org 1.6.0 [ 1024x600(a)60.0hz ] Network cards Attansic Corp. L1e Gigabit Ethernet Adapter, at port: 1000 Atheros AR242x 802.11abg Wireless PCI Express Adapter Processes 154 | Uptime 2:44 | Memory 357.3/993.4MB | HDD Verbatim STORE N GO,ATA TOSHIBA MK1652GS,Generic- Multi-Card Size 166GB (1%used) | Client Shell | Infobash v3.11 my alsa info report: http://www.alsa-project.org/db/?f=83ac843507b5450f5c4d3252a0082ef6f9c6f124 I am not able to see a sound indication with : arecord -f cd -vv /dev/null -- Reach out and share life, care for others,

2 2

[alsa-devel] [PATCH] TXx9: Add ACLC support (v2)
by Atsushi Nemoto 20 May '09

20 May '09

Add platform support for ACLC of TXx9 SoCs. Signed-off-by: Atsushi Nemoto <anemo(a)mba.ocn.ne.jp> --- Changes since v1: * use one platform device to provide irq/mem/dma resources and another platform device for machine driver. arch/mips/include/asm/txx9/generic.h | 5 ++++ arch/mips/include/asm/txx9/tx4927.h | 2 + arch/mips/include/asm/txx9/tx4938.h | 1 + arch/mips/include/asm/txx9/tx4939.h | 1 + arch/mips/txx9/Kconfig | 3 ++ arch/mips/txx9/generic/setup.c | 36 +++++++++++++++++++++++++++ arch/mips/txx9/generic/setup_tx4927.c | 43 +++++++++++++++++++++++++++++++++ arch/mips/txx9/generic/setup_tx4938.c | 11 ++++++++ arch/mips/txx9/generic/setup_tx4939.c | 9 +++++++ arch/mips/txx9/rbtx4927/setup.c | 8 ++++- arch/mips/txx9/rbtx4938/setup.c | 2 + arch/mips/txx9/rbtx4939/setup.c | 2 + 12 files changed, 121 insertions(+), 2 deletions(-) diff --git a/arch/mips/include/asm/txx9/generic.h b/arch/mips/include/asm/txx9/generic.h index 9cde009..8169477 100644 --- a/arch/mips/include/asm/txx9/generic.h +++ b/arch/mips/include/asm/txx9/generic.h @@ -91,4 +91,9 @@ void txx9_7segled_init(unsigned int num, void (*putc)(unsigned int pos, unsigned char val)); int txx9_7segled_putc(unsigned int pos, char c); +void __init txx9_aclc_init(unsigned long baseaddr, int irq, + unsigned int dmac_id, + unsigned int dma_chan_out, + unsigned int dma_chan_in); + #endif /* __ASM_TXX9_GENERIC_H */ diff --git a/arch/mips/include/asm/txx9/tx4927.h b/arch/mips/include/asm/txx9/tx4927.h index d92ae07..18c98c5 100644 --- a/arch/mips/include/asm/txx9/tx4927.h +++ b/arch/mips/include/asm/txx9/tx4927.h @@ -50,6 +50,7 @@ #define TX4927_NR_SIO 2 #define TX4927_SIO_REG(ch) (TX4927_REG_BASE + 0xf300 + (ch) * 0x100) #define TX4927_PIO_REG (TX4927_REG_BASE + 0xf500) +#define TX4927_ACLC_REG (TX4927_REG_BASE + 0xf700) #define TX4927_IR_ECCERR 0 #define TX4927_IR_WTOERR 1 @@ -267,5 +268,6 @@ void tx4927_setup_pcierr_irq(void); void tx4927_irq_init(void); void tx4927_mtd_init(int ch); void tx4927_dmac_init(int memcpy_chan); +void tx4927_aclc_init(unsigned int dma_chan_out, unsigned int dma_chan_in); #endif /* __ASM_TXX9_TX4927_H */ diff --git a/arch/mips/include/asm/txx9/tx4938.h b/arch/mips/include/asm/txx9/tx4938.h index 0758a0c..54e4674 100644 --- a/arch/mips/include/asm/txx9/tx4938.h +++ b/arch/mips/include/asm/txx9/tx4938.h @@ -306,5 +306,6 @@ struct tx4938ide_platform_info { void tx4938_ata_init(unsigned int irq, unsigned int shift, int tune); void tx4938_dmac_init(int memcpy_chan0, int memcpy_chan1); +void tx4938_aclc_init(void); #endif diff --git a/arch/mips/include/asm/txx9/tx4939.h b/arch/mips/include/asm/txx9/tx4939.h index 1be9798..f13b708 100644 --- a/arch/mips/include/asm/txx9/tx4939.h +++ b/arch/mips/include/asm/txx9/tx4939.h @@ -545,5 +545,6 @@ void tx4939_rtc_init(void); void tx4939_ndfmc_init(unsigned int hold, unsigned int spw, unsigned char ch_mask, unsigned char wide_mask); void tx4939_dmac_init(int memcpy_chan0, int memcpy_chan1); +void tx4939_aclc_init(void); #endif /* __ASM_TXX9_TX4939_H */ diff --git a/arch/mips/txx9/Kconfig b/arch/mips/txx9/Kconfig index 0db7cf3..852ae4b 100644 --- a/arch/mips/txx9/Kconfig +++ b/arch/mips/txx9/Kconfig @@ -69,6 +69,7 @@ config SOC_TX4927 select IRQ_TXX9 select PCI_TX4927 select GPIO_TXX9 + select HAS_TXX9_ACLC config SOC_TX4938 bool @@ -78,6 +79,7 @@ config SOC_TX4938 select IRQ_TXX9 select PCI_TX4927 select GPIO_TXX9 + select HAS_TXX9_ACLC config SOC_TX4939 bool @@ -85,6 +87,7 @@ config SOC_TX4939 select HAS_TXX9_SERIAL select HW_HAS_PCI select PCI_TX4927 + select HAS_TXX9_ACLC config TXX9_7SEGLED bool diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c index 369d863..7f91012 100644 --- a/arch/mips/txx9/generic/setup.c +++ b/arch/mips/txx9/generic/setup.c @@ -876,3 +876,39 @@ void __init txx9_dmac_init(int id, unsigned long baseaddr, int irq, } #endif } + +void __init txx9_aclc_init(unsigned long baseaddr, int irq, + unsigned int dmac_id, + unsigned int dma_chan_out, + unsigned int dma_chan_in) +{ +#if defined(CONFIG_SND_SOC_TXX9ACLC) || \ + defined(CONFIG_SND_SOC_TXX9ACLC_MODULE) + unsigned int dma_base = dmac_id * TXX9_DMA_MAX_NR_CHANNELS; + struct resource res[] = { + { + .start = baseaddr, + .end = baseaddr + 0x100 - 1, + .flags = IORESOURCE_MEM, + }, { + .start = irq, + .flags = IORESOURCE_IRQ, + }, { + .name = "txx9dmac-chan", + .start = dma_base + dma_chan_out, + .flags = IORESOURCE_DMA, + }, { + .name = "txx9dmac-chan", + .start = dma_base + dma_chan_in, + .flags = IORESOURCE_DMA, + } + }; + struct platform_device *pdev = + platform_device_alloc("txx9aclc-ac97", -1); + + if (!pdev || + platform_device_add_resources(pdev, res, ARRAY_SIZE(res)) || + platform_device_add(pdev)) + platform_device_put(pdev); +#endif +} diff --git a/arch/mips/txx9/generic/setup_tx4927.c b/arch/mips/txx9/generic/setup_tx4927.c index 6b681cd..3418b2a 100644 --- a/arch/mips/txx9/generic/setup_tx4927.c +++ b/arch/mips/txx9/generic/setup_tx4927.c @@ -265,6 +265,49 @@ void __init tx4927_dmac_init(int memcpy_chan) TXX9_IRQ_BASE + TX4927_IR_DMA(0), &plat_data); } +void __init tx4927_aclc_init(unsigned int dma_chan_out, + unsigned int dma_chan_in) +{ + u64 pcfg = __raw_readq(&tx4927_ccfgptr->pcfg); + __u64 dmasel_mask = 0, dmasel = 0; + unsigned long flags; + + if (!(pcfg & TX4927_PCFG_SEL2)) + return; + /* setup DMASEL (playback:ACLC ch0, capture:ACLC ch1) */ + switch (dma_chan_out) { + case 0: + dmasel_mask |= TX4927_PCFG_DMASEL0_MASK; + dmasel |= TX4927_PCFG_DMASEL0_ACL0; + break; + case 2: + dmasel_mask |= TX4927_PCFG_DMASEL2_MASK; + dmasel |= TX4927_PCFG_DMASEL2_ACL0; + break; + default: + return; + } + switch (dma_chan_in) { + case 1: + dmasel_mask |= TX4927_PCFG_DMASEL1_MASK; + dmasel |= TX4927_PCFG_DMASEL1_ACL1; + break; + case 3: + dmasel_mask |= TX4927_PCFG_DMASEL3_MASK; + dmasel |= TX4927_PCFG_DMASEL3_ACL1; + break; + default: + return; + } + local_irq_save(flags); + txx9_clear64(&tx4927_ccfgptr->pcfg, dmasel_mask); + txx9_set64(&tx4927_ccfgptr->pcfg, dmasel); + local_irq_restore(flags); + txx9_aclc_init(TX4927_ACLC_REG & 0xfffffffffULL, + TXX9_IRQ_BASE + TX4927_IR_ACLC, + 0, dma_chan_out, dma_chan_in); +} + static void __init tx4927_stop_unused_modules(void) { __u64 pcfg, rst = 0, ckd = 0; diff --git a/arch/mips/txx9/generic/setup_tx4938.c b/arch/mips/txx9/generic/setup_tx4938.c index b2b8529..4dfdb52 100644 --- a/arch/mips/txx9/generic/setup_tx4938.c +++ b/arch/mips/txx9/generic/setup_tx4938.c @@ -414,6 +414,17 @@ void __init tx4938_dmac_init(int memcpy_chan0, int memcpy_chan1) } } +void __init tx4938_aclc_init(void) +{ + u64 pcfg = __raw_readq(&tx4938_ccfgptr->pcfg); + + if ((pcfg & TX4938_PCFG_SEL2) && + !(pcfg & TX4938_PCFG_ETH0_SEL)) + txx9_aclc_init(TX4938_ACLC_REG & 0xfffffffffULL, + TXX9_IRQ_BASE + TX4938_IR_ACLC, + 1, 0, 1); +} + static void __init tx4938_stop_unused_modules(void) { __u64 pcfg, rst = 0, ckd = 0; diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index 98effef..7139686 100644 --- a/arch/mips/txx9/generic/setup_tx4939.c +++ b/arch/mips/txx9/generic/setup_tx4939.c @@ -485,6 +485,15 @@ void __init tx4939_dmac_init(int memcpy_chan0, int memcpy_chan1) } } +void __init tx4939_aclc_init(void) +{ + u64 pcfg = __raw_readq(&tx4939_ccfgptr->pcfg); + + if ((pcfg & TX4939_PCFG_I2SMODE_MASK) == TX4939_PCFG_I2SMODE_ACLC) + txx9_aclc_init(TX4939_ACLC_REG & 0xfffffffffULL, + TXX9_IRQ_BASE + TX4939_IR_ACLC, 1, 0, 1); +} + static void __init tx4939_stop_unused_modules(void) { __u64 pcfg, rst = 0, ckd = 0; diff --git a/arch/mips/txx9/rbtx4927/setup.c b/arch/mips/txx9/rbtx4927/setup.c index 332cdbc..ee468ea 100644 --- a/arch/mips/txx9/rbtx4927/setup.c +++ b/arch/mips/txx9/rbtx4927/setup.c @@ -337,10 +337,14 @@ static void __init rbtx4927_device_init(void) rbtx4927_ne_init(); tx4927_wdt_init(); rbtx4927_mtd_init(); - if (TX4927_REV_PCODE() == 0x4927) + if (TX4927_REV_PCODE() == 0x4927) { tx4927_dmac_init(2); - else + tx4927_aclc_init(0, 1); + } else { tx4938_dmac_init(0, 2); + tx4938_aclc_init(); + } + platform_device_register_simple("txx9aclc-generic", -1, NULL, 0); txx9_iocled_init(RBTX4927_LED_ADDR - IO_BASE, -1, 3, 1, "green", NULL); rbtx4927_gpioled_init(); } diff --git a/arch/mips/txx9/rbtx4938/setup.c b/arch/mips/txx9/rbtx4938/setup.c index 37c5e3d..8da66e9 100644 --- a/arch/mips/txx9/rbtx4938/setup.c +++ b/arch/mips/txx9/rbtx4938/setup.c @@ -356,6 +356,8 @@ static void __init rbtx4938_device_init(void) tx4938_ndfmc_init(10, 35); tx4938_ata_init(RBTX4938_IRQ_IOC_ATA, 0, 1); tx4938_dmac_init(0, 2); + tx4938_aclc_init(); + platform_device_register_simple("txx9aclc-generic", -1, NULL, 0); txx9_iocled_init(RBTX4938_LED_ADDR - IO_BASE, -1, 8, 1, "green", NULL); } diff --git a/arch/mips/txx9/rbtx4939/setup.c b/arch/mips/txx9/rbtx4939/setup.c index 91f2ec8..d5ad5ab 100644 --- a/arch/mips/txx9/rbtx4939/setup.c +++ b/arch/mips/txx9/rbtx4939/setup.c @@ -499,6 +499,8 @@ static void __init rbtx4939_device_init(void) tx4939_ata_init(); tx4939_rtc_init(); tx4939_dmac_init(0, 2); + tx4939_aclc_init(); + platform_device_register_simple("txx9aclc-generic", -1, NULL, 0); } static void __init rbtx4939_setup(void) -- 1.5.6.5

3 2

[alsa-devel] [PATCH 1/1] Add AIC3106 support.
by Ambrose, Martin 19 May '09

19 May '09

Signed-off-by: Steve Chen <schen(a)mvista.com> Signed-off-by: Martin Ambrose <martin(a)ti.com> --- sound/soc/codecs/tlv320aic3x.c | 185 ++++++++++++++++++++++++++++++++++++++- sound/soc/codecs/tlv320aic3x.h | 11 ++- 2 files changed, 190 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c index ab099f4..5720cad 100644 --- a/sound/soc/codecs/tlv320aic3x.c +++ b/sound/soc/codecs/tlv320aic3x.c @@ -57,13 +57,17 @@ struct aic3x_priv { int master; }; +static u8 pg0_end = AIC3X_GEN_PG0_END; +static u8 pg1_end = AIC3X_GEN_PG1_END; +static enum aic3x_codec_variant codec_variant; + /* * AIC3X register cache * We can't read the AIC3X register space when we are * using 2 wire for device control, so we cache them instead. * There is no point in caching the reset register */ -static const u8 aic3x_reg[AIC3X_CACHEREGNUM] = { +static const u8 aic3x_reg[] = { 0x00, 0x00, 0x00, 0x10, /* 0 */ 0x04, 0x00, 0x00, 0x00, /* 4 */ 0x00, 0x00, 0x00, 0x01, /* 8 */ @@ -90,6 +94,35 @@ static const u8 aic3x_reg[AIC3X_CACHEREGNUM] = { 0x00, 0x00, 0x00, 0x00, /* 92 */ 0x00, 0x00, 0x00, 0x00, /* 96 */ 0x00, 0x00, 0x02, /* 100 */ + + 0x00, 0x00, 0x00, 0x00, /* 103-127 unused */ + 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, + 0x00, + + 0x00, 0x6b, 0xe3, 0x96, /* 0 */ + 0x66, 0x67, 0x5d, 0x6b, /* 4 */ + 0xe3, 0x96, 0x66, 0x67, /* 8 */ + 0x5d, 0x7d, 0x83, 0x84, /* 12 */ + 0xee, 0x7d, 0x83, 0x84, /* 16 */ + 0xee, 0x39, 0x55, 0xf3, /* 20 */ + 0x2d, 0x53, 0x7e, 0x6b, /* 24 */ + 0xe3, 0x96, 0x66, 0x67, /* 28 */ + 0x5d, 0x6b, 0xe3, 0x96, /* 32 */ + 0x66, 0x67, 0x5d, 0x7d, /* 36 */ + 0x83, 0x84, 0xee, 0x7d, /* 40 */ + 0x83, 0x84, 0xee, 0x39, /* 44 */ + 0x55, 0xf3, 0x2d, 0x53, /* 48 */ + 0x7e, 0x7f, 0xff, 0x00, /* 52 */ + 0x00, 0x00, 0x00, 0x00, /* 56 */ + 0x00, 0x00, 0x00, 0x00, /* 60 */ + 0x00, 0x39, 0x55, 0xf3, /* 64 */ + 0x2d, 0x53, 0x7e, 0x39, /* 68 */ + 0x55, 0xf3, 0x2d, 0x53, /* 72 */ + 0x7e, /* 76 */ }; /* @@ -99,7 +132,8 @@ static inline unsigned int aic3x_read_reg_cache(struct snd_soc_codec *codec, unsigned int reg) { u8 *cache = codec->reg_cache; - if (reg >= AIC3X_CACHEREGNUM) + if ((reg >= pg1_end) || + ((reg >= pg0_end) && (reg < AIC3X_GEN_PG1_BEG))) return -1; return cache[reg]; } @@ -111,7 +145,8 @@ static inline void aic3x_write_reg_cache(struct snd_soc_codec *codec, u8 reg, u8 value) { u8 *cache = codec->reg_cache; - if (reg >= AIC3X_CACHEREGNUM) + if ((reg >= pg1_end) || + ((reg >= pg0_end) && (reg < AIC3X_GEN_PG1_BEG))) return; cache[reg] = value; } @@ -119,8 +154,8 @@ static inline void aic3x_write_reg_cache(struct snd_soc_codec *codec, /* * write to the aic3x register space */ -static int aic3x_write(struct snd_soc_codec *codec, unsigned int reg, - unsigned int value) +static int _aic3x_write(struct snd_soc_codec *codec, unsigned int reg, + unsigned int value) { u8 data[2]; @@ -132,12 +167,41 @@ static int aic3x_write(struct snd_soc_codec *codec, unsigned int reg, data[1] = value & 0xff; aic3x_write_reg_cache(codec, data[0], data[1]); + + /* adjust for page 1 before updating hardware if necessary */ + if (data[0] >= AIC3X_GEN_PG1_BEG) + data[0] -= AIC3X_GEN_PG1_BEG; + if (codec->hw_write(codec->control_data, data, 2) == 2) return 0; else return -EIO; } +static int aic3x_write(struct snd_soc_codec *codec, unsigned int reg, + unsigned int value) +{ + u8 cur_pg; + u8 reg_pg; + int ret = 0; + + cur_pg = aic3x_read_reg_cache(codec, 0); + if (reg < pg0_end) + reg_pg = 0; + else if ((reg >= AIC3X_GEN_PG1_BEG) && (reg < pg1_end)) + reg_pg = 1; + else + return -EIO; + + if (cur_pg != reg_pg) + ret = _aic3x_write(codec, 0, reg_pg); + + if (ret == 0) + ret = _aic3x_write(codec, reg, value); + + return ret; +} + /* * read from the aic3x register space */ @@ -218,6 +282,65 @@ static int snd_soc_dapm_put_volsw_aic3x(struct snd_kcontrol *kcontrol, return ret; } +static int tlv320aic3x_dual_reg_info(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo) +{ + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; + uinfo->count = 1; + uinfo->value.integer.min = 0; + uinfo->value.integer.max = 0xffff; + return 0; +} + +static int tlv320aic3x_dual_reg_get(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol); + int reg_msb = kcontrol->private_value & 0xff; + int reg_lsb = (kcontrol->private_value >> 8) & 0xff; + int val = aic3x_read_reg_cache(codec, reg_msb) << 8; + + val |= aic3x_read_reg_cache(codec, reg_lsb); + + /* convert 2's complement to unsigned int */ + val ^= 0x8000; + + ucontrol->value.integer.value[0] = val; + + return 0; +} + +static int tlv320aic3x_dual_reg_put(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol); + int err; + int reg_msb = kcontrol->private_value & 0xff; + int reg_lsb = (kcontrol->private_value >> 8) & 0xff; + int val_msb, val_lsb; + + val_msb = (ucontrol->value.integer.value[0] >> 8) & 0xff; + val_lsb = ucontrol->value.integer.value[0] & 0xff; + + /* convert unsigned int to 2's complement */ + val_msb ^= 0x80; + + err = snd_soc_update_bits(codec, reg_msb, 0xff, val_msb); + if (err < 0) + return err; + err = snd_soc_update_bits(codec, reg_lsb, 0xff, val_lsb); + return err; +} + +#define TLV320AIC3X_DUAL_R(xname, page, reg_msb, reg_lsb) \ +{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname), \ + .info = tlv320aic3x_dual_reg_info, \ + .get = tlv320aic3x_dual_reg_get, .put = tlv320aic3x_dual_reg_put, \ + .private_value = ((reg_msb) + page) | (((reg_lsb) + page) << 8) } + +#define TLV320AIC3X_PG1_DUAL_R(xname, reg_msb, reg_lsb) \ + TLV320AIC3X_DUAL_R(xname, AIC3X_GEN_PG1_BEG, reg_msb, reg_lsb) + static const char *aic3x_left_dac_mux[] = { "DAC_L1", "DAC_L3", "DAC_L2" }; static const char *aic3x_right_dac_mux[] = { "DAC_R1", "DAC_R3", "DAC_R2" }; static const char *aic3x_left_hpcom_mux[] = @@ -344,6 +467,36 @@ static const struct snd_kcontrol_new aic3x_snd_controls[] = { SOC_DOUBLE_R("PGA Capture Switch", LADC_VOL, RADC_VOL, 7, 0x01, 1), SOC_ENUM("ADC HPF Cut-off", aic3x_enum[ADC_HPF_ENUM]), + + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient N0", 1, 2), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient N1", 3, 4), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient N2", 5, 6), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient N3", 7, 8), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient N4", 9, 10), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient N5", 11, 12), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient D1", 13, 14), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient D2", 15, 16), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient D4", 17, 18), + TLV320AIC3X_PG1_DUAL_R("Left Effects Coefficient D5", 19, 20), + TLV320AIC3X_PG1_DUAL_R("Left De-Emphasis Coefficient N0", 21, 22), + TLV320AIC3X_PG1_DUAL_R("Left De-Emphasis Coefficient N1", 23, 24), + TLV320AIC3X_PG1_DUAL_R("Left De-Emphasis Coefficient D1", 25, 26), + + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient N0", 27, 28), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient N1", 29, 30), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient N2", 31, 32), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient N3", 33, 34), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient N4", 35, 36), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient N5", 37, 38), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient D1", 39, 40), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient D2", 41, 42), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient D4", 43, 44), + TLV320AIC3X_PG1_DUAL_R("Right Effects Coefficient D5", 45, 46), + TLV320AIC3X_PG1_DUAL_R("Right De-Emphasis Coefficient N0", 47, 48), + TLV320AIC3X_PG1_DUAL_R("Right De-Emphasis Coefficient N1", 49, 50), + TLV320AIC3X_PG1_DUAL_R("Right De-Emphasis Coefficient D1", 51, 52), + + TLV320AIC3X_PG1_DUAL_R("3-D Attenuation Coefficient", 53, 54), }; /* Left DAC Mux */ @@ -454,6 +607,18 @@ static const struct snd_kcontrol_new aic3x_right_line2_bp_mixer_controls[] = { SOC_DAPM_SINGLE("HPRCOM Switch", LINE2R_2_HPRCOM_VOL, 7, 1, 0), }; +static const struct snd_kcontrol_new aic3106_snd_controls[] = { + TLV320AIC3X_PG1_DUAL_R("Left Capture High Pass Coefficient N0", 65, 66), + TLV320AIC3X_PG1_DUAL_R("Left Capture High Pass Coefficient N1", 67, 68), + TLV320AIC3X_PG1_DUAL_R("Left Capture High Pass Coefficient D1", 69, 70), + TLV320AIC3X_PG1_DUAL_R("Right Capture High Pass Coefficient N0", + 71, 72), + TLV320AIC3X_PG1_DUAL_R("Right Capture High Pass Coefficient N1", + 73, 74), + TLV320AIC3X_PG1_DUAL_R("Right Capture High Pass Coefficient D1", + 75, 76), +}; + static const struct snd_soc_dapm_widget aic3x_dapm_widgets[] = { /* Left DAC to Left Outputs */ SND_SOC_DAPM_DAC("Left DAC", "Left Playback", DAC_PWR, 7, 0), @@ -1165,6 +1330,10 @@ static int aic3x_init(struct snd_soc_device *socdev) if (codec->reg_cache == NULL) return -ENOMEM; + /* setup register cache sizes */ + if (codec_variant == AIC3106_CODEC) + pg1_end = AIC3106_PG1_END; + aic3x_write(codec, AIC3X_PAGE_SELECT, PAGE0_SELECT); aic3x_write(codec, AIC3X_RESET, SOFT_RESET); @@ -1247,6 +1416,11 @@ static int aic3x_init(struct snd_soc_device *socdev) snd_soc_add_controls(codec, aic3x_snd_controls, ARRAY_SIZE(aic3x_snd_controls)); + + if (codec_variant == AIC3106_CODEC) + snd_soc_add_controls(codec, aic3106_snd_controls, + ARRAY_SIZE(aic3106_snd_controls)); + aic3x_add_widgets(codec); ret = snd_soc_init_card(socdev); if (ret < 0) { @@ -1374,6 +1548,7 @@ static int aic3x_probe(struct platform_device *pdev) printk(KERN_INFO "AIC3X Audio Codec %s\n", AIC3X_VERSION); setup = socdev->codec_data; + codec_variant = setup->variant; codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL); if (codec == NULL) return -ENOMEM; diff --git a/sound/soc/codecs/tlv320aic3x.h b/sound/soc/codecs/tlv320aic3x.h index ac827e5..ee40e9c 100644 --- a/sound/soc/codecs/tlv320aic3x.h +++ b/sound/soc/codecs/tlv320aic3x.h @@ -13,7 +13,10 @@ #define _AIC3X_H /* AIC3X register space */ -#define AIC3X_CACHEREGNUM 103 +#define AIC3X_GEN_PG0_END 103 +#define AIC3X_GEN_PG1_BEG 128 +#define AIC3X_GEN_PG1_END 183 +#define AIC3106_PG1_END 205 /* Page select register */ #define AIC3X_PAGE_SELECT 0 @@ -199,6 +202,11 @@ /* Default input volume */ #define DEFAULT_GAIN 0x20 +enum aic3x_codec_variant { + AIC3X_GENERIC_CODEC, + AIC3106_CODEC, +}; + /* GPIO API */ enum { AIC3X_GPIO1_FUNC_DISABLED = 0, @@ -284,6 +292,7 @@ int aic3x_button_pressed(struct snd_soc_codec *codec); struct aic3x_setup_data { int i2c_bus; unsigned short i2c_address; + enum aic3x_codec_variant variant; unsigned int gpio_func[2]; }; -- 1.6.0.6

2 3