- Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] Fix disable of SPDIF on STAC9766 codec
by Jon Smirl 16 Dec '09

16 Dec '09

Change code so that switching to playing music through the analog output disables SPDIF out instead of disabling it when stream ends. Signed-off-by: Jon Smirl <jonsmirl(a)gmail.com> --- sound/soc/codecs/stac9766.c | 18 +----------------- 1 files changed, 1 insertions(+), 17 deletions(-) diff --git a/sound/soc/codecs/stac9766.c b/sound/soc/codecs/stac9766.c index bbc72c2..81b8c9d 100644 --- a/sound/soc/codecs/stac9766.c +++ b/sound/soc/codecs/stac9766.c @@ -191,6 +191,7 @@ static int ac97_analog_prepare(struct snd_pcm_substream *substream, vra = stac9766_ac97_read(codec, AC97_EXTENDED_STATUS); vra |= 0x1; /* enable variable rate audio */ + vra &= ~0x4; /* disable SPDIF output */ stac9766_ac97_write(codec, AC97_EXTENDED_STATUS, vra); @@ -221,22 +222,6 @@ static int ac97_digital_prepare(struct snd_pcm_substream *substream, return stac9766_ac97_write(codec, reg, runtime->rate); } -static int ac97_digital_trigger(struct snd_pcm_substream *substream, - int cmd, struct snd_soc_dai *dai) -{ - struct snd_soc_codec *codec = dai->codec; - unsigned short vra; - - switch (cmd) { - case SNDRV_PCM_TRIGGER_STOP: - vra = stac9766_ac97_read(codec, AC97_EXTENDED_STATUS); - vra &= !0x04; - stac9766_ac97_write(codec, AC97_EXTENDED_STATUS, vra); - break; - } - return 0; -} - static int stac9766_set_bias_level(struct snd_soc_codec *codec, enum snd_soc_bias_level level) { @@ -315,7 +300,6 @@ static struct snd_soc_dai_ops stac9766_dai_ops_analog = { static struct snd_soc_dai_ops stac9766_dai_ops_digital = { .prepare = ac97_digital_prepare, - .trigger = ac97_digital_trigger, }; struct snd_soc_dai stac9766_dai[] = {

2 1

[alsa-devel] poll events?
by pl bossart 16 Dec '09

16 Dec '09

I am trying to understand what the expected behavior of poll() is in audio applications. I am using the pcm.c test app from alsa-lib with the following parameters. ./pcm -Dhw -c2 -r48000 -f440 --method write_and_poll The output looks like this: snd_pcm_dump(): Hardware PCM card 0 'Intel ICH6' device 0 subdevice 0 Its setup is: stream : PLAYBACK access : RW_INTERLEAVED format : S16_LE subformat : STD channels : 2 rate : 48000 exact rate : 48000 (48000/1) msbits : 16 buffer_size : 16384 period_size : 8192 period_time : 170666 tstamp_mode : NONE period_step : 1 avail_min : 8192 period_event : 0 start_threshold : 16384 stop_threshold : 16384 silence_threshold: 0 silence_size : 0 boundary : 1073741824 appl_ptr : 0 hw_ptr : 0 Now I instrumented the code in sound/core/pcm_native.c to show what events are returned by snd_pcm_playback_poll(), and I get the following pattern: [ 176.062986] ALSA: poll event POLLOUT|POLLWRNORM, avail 8193 avail_min 8192 [ 176.066630] ALSA: null poll event, avail 175 avail_min 8192 [ 176.233739] ALSA: poll event POLLOUT|POLLWRNORM, avail 8193 avail_min 8192 [ 176.237399] ALSA: null poll event, avail 176 avail_min 8192 [ 176.404503] ALSA: poll event POLLOUT|POLLWRNORM, avail 8193 avail_min 8192 [ 176.407652] ALSA: null poll event, avail 152 avail_min 8192 [ 176.575257] ALSA: poll event POLLOUT|POLLWRNORM, avail 8193 avail_min 8192 [ 176.578995] ALSA: null poll event, avail 180 avail_min 8192 [ 176.745999] ALSA: poll event POLLOUT|POLLWRNORM, avail 8193 avail_min 8192 [ 176.749663] ALSA: null poll event, avail 176 avail_min 8192 [ 176.916750] ALSA: poll event POLLOUT|POLLWRNORM, avail 8193 avail_min 8192 [ 176.919893] ALSA: null poll event, avail 151 avail_min 8192 It looks like I am getting additional wakeups from poll instead of waiting for a complete period. Is this supposed to be ok or is there something broken here? My expectation is that the hardware would only generate interrupts when a period has elapsed, i.e avail>=avail_min. The delta shown in dmesg between two POLLOUT events matches the period duration of 171 ms, I don't understand what generates these additional null events. Am I missing something? Thanks for your help. - Pierre

1 0

[alsa-devel] Another 2.6.33 ASoC fix
by Mark Brown 15 Dec '09

15 Dec '09

The following changes since commit bc2580061e42c323d7777029f01318f395edac0d: Julia Lawall (1): ASoC: Correct code taking the size of a pointer are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33 Kuninori Morimoto (1): ASoC: ak4642: Add default return value in ak4642_modinit sound/soc/codecs/ak4642.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

2 1

[alsa-devel] [PATCH v2] ASoC: ak4642: Add default return value in ak4642_modinit
by Kuninori Morimoto 15 Dec '09

15 Dec '09

If ak4642 driver was compiled without I2C configs, ak4642_modinit return value will become un-stable. This patch modify this bug Reported-by: Magnus Damm <damm(a)opensource.se> Signed-off-by: Kuninori Morimoto <morimoto.kuninori(a)renesas.com> --- v1 -> v2 o modify Magnus's email address So sorry ... sound/soc/codecs/ak4642.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c index b69861d..3ef16bb 100644 --- a/sound/soc/codecs/ak4642.c +++ b/sound/soc/codecs/ak4642.c @@ -470,7 +470,7 @@ EXPORT_SYMBOL_GPL(soc_codec_dev_ak4642); static int __init ak4642_modinit(void) { - int ret; + int ret = 0; #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) ret = i2c_add_driver(&ak4642_i2c_driver); #endif -- 1.6.3.3

2 2

[alsa-devel] X-Fi Notebook express card
by The Source 15 Dec '09

15 Dec '09

Sorry for asking it here, but alsa-user mailing list is not responding. Has anyone tested yet if this card is supported? (not extreme audio, just X-Fi Notebook)

1 0

Re: [alsa-devel] [PATCH fixed bug 4032 1/1] Fixed bug 4032.
by Takashi Iwai 15 Dec '09

15 Dec '09

At Mon, 14 Dec 2009 13:49:33 -0700, Steve Soule wrote: > > On 12/14/2009 12:01 PM, Takashi Iwai wrote: > > At Mon, 14 Dec 2009 11:41:55 -0700, > > Steve Soule wrote: > >> > >> >From c3387a767f827f57a6b1f6b772d3d7a1b6b39942 Mon Sep 17 00:00:00 2001 > >> From: Steve Soule <sts11dbxr(a)gmail.com> > >> Date: Mon, 14 Dec 2009 11:06:03 -0700 > >> Subject: [PATCH fixed bug 4032 1/1] Fixed bug 4032. > >> > >> > >> Signed-off-by: Steve Soule <sts11dbxr(a)gmail.com> > > > > Could you give a bit more changelog text? > > It's not sure what bug 4032 indicates, and more importantly, why this > > change is needed for fixing what. > > Okay. Here is a thorough changelog: > > This is a fix of a bug in ac97_codec.c. This bug has existed for many > years in many versions of alsa and versions of the kernel. The bug > appears with a Soundblaster 16PCI sound card. With this card, sometimes > the driver works correctly, and sometimes it doesn't. When it doesn't > work correctly, the driver prints the error message: > > AC'97 0 analog subsections not ready > > and fails to detect the complete set of sound controls. In particular, > the driver fails to detect the "Master Playback Volume" control, and so > the sound card volume level is arbitrary--usually very low. > > As far as I can tell, the problem is in the function snd_ac97_mixer() in > ac97_codec.c, in the lines immediately before the error message is > printed. These lines appear to be waiting for the card to come out of > powerdown mode. If the card does not come up within a timeout, the > error message is printed, and the controls are not detected correctly. > > The timeout in the latest version is 120 ms (though it was 100 ms when I > first reported this bug a year and a half ago). I experimented with > different timeout values, and found that 1 second was not sufficient, > and that 5 seconds is sufficient. Hrm, usually 1 second is really long enough for any operations. And 5 seconds is already a history since genesis. If it takes so long, something other is fishy. Although extending the timeout would be relatively harmless, I still don't think this is the point to fix. More likely the problem is in the codec accessor side... thanks, Takashi

2 2

[alsa-devel] More HDA NID / control / proc related changes
by Jaroslav Kysela 15 Dec '09

15 Dec '09

Hi all, continuing the work of extending the HDA codec proc contents, I would like to introduce two new patches: ALSA: hda - add more NID->Control mapping ALSA: hda - introduce HDA_SUBDEV_AMP_FLAG (ControlAmp in proc) Patches can be obtained here: http://git.alsa-project.org/?p=alsa-kernel.git;a=shortlog;h=topic/hda-nid Jaroslav ----- Jaroslav Kysela <perex(a)perex.cz> Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.

3 12

[alsa-devel] [PATCH] ASoC: ak4642: Add default return value in ak4642_modinit
by Kuninori Morimoto 15 Dec '09

15 Dec '09

If ak4642 driver was compiled without I2C configs, ak4642_modinit return value will become un-stable. This patch modify this bug Reported-by: Magnus Damm <damm(a)igel.co.jp> Signed-off-by: Kuninori Morimoto <morimoto.kuninori(a)renesas.com> --- sound/soc/codecs/ak4642.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c index b69861d..3ef16bb 100644 --- a/sound/soc/codecs/ak4642.c +++ b/sound/soc/codecs/ak4642.c @@ -470,7 +470,7 @@ EXPORT_SYMBOL_GPL(soc_codec_dev_ak4642); static int __init ak4642_modinit(void) { - int ret; + int ret = 0; #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) ret = i2c_add_driver(&ak4642_i2c_driver); #endif -- 1.6.3.3

1 0

[alsa-devel] Testing spam filter - please reply.
by Shareef Jalloq 15 Dec '09

15 Dec '09

Sorry - having amazing trouble trying to post to this mailing list. Replaced post with this text to see if it gets through. Shareef.

3 2

[alsa-devel] [PATCH] sh: ms7724se: Add ak4642 support
by Kuninori Morimoto 15 Dec '09

15 Dec '09

Signed-off-by: Kuninori Morimoto <morimoto.kuninori(a)renesas.com> --- This patch is based on ALSA ak4642 patch. arch/sh/boards/mach-se/7724/setup.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c index 4b0f0c0..5d0f70b 100644 --- a/arch/sh/boards/mach-se/7724/setup.c +++ b/arch/sh/boards/mach-se/7724/setup.c @@ -514,6 +514,13 @@ static struct platform_device *ms7724se_devices[] __initdata = { &sdhi1_cn8_device, }; +/* I2C device */ +static struct i2c_board_info i2c0_devices[] = { + { + I2C_BOARD_INFO("ak4642", 0x12), + }, +}; + #define EEPROM_OP 0xBA206000 #define EEPROM_ADR 0xBA206004 #define EEPROM_DATA 0xBA20600C @@ -575,6 +582,16 @@ extern char ms7724se_sdram_enter_end; extern char ms7724se_sdram_leave_start; extern char ms7724se_sdram_leave_end; + +static int __init arch_setup(void) +{ + /* enable I2C device */ + i2c_register_board_info(0, i2c0_devices, + ARRAY_SIZE(i2c0_devices)); + return 0; +} +arch_initcall(arch_setup); + static int __init devices_setup(void) { u16 sw = ctrl_inw(SW4140); /* select camera, monitor */ -- 1.6.3.3

2 1