- Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: fix a memory-leak in wm8903
by Guennadi Liakhovetski 23 Jan '10

23 Jan '10

Remember to free the temporary register-cache. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski(a)gmx.de> --- should go in -rc, maybe also for stable diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index ce5515e..3595bd5 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -1504,7 +1504,7 @@ static int wm8903_resume(struct platform_device *pdev) struct i2c_client *i2c = codec->control_data; int i; u16 *reg_cache = codec->reg_cache; - u16 *tmp_cache = kmemdup(codec->reg_cache, sizeof(wm8903_reg_defaults), + u16 *tmp_cache = kmemdup(reg_cache, sizeof(wm8903_reg_defaults), GFP_KERNEL); /* Bring the codec back up to standby first to minimise pop/clicks */ @@ -1516,6 +1516,7 @@ static int wm8903_resume(struct platform_device *pdev) for (i = 2; i < ARRAY_SIZE(wm8903_reg_defaults); i++) if (tmp_cache[i] != reg_cache[i]) snd_soc_write(codec, i, tmp_cache[i]); + kfree(tmp_cache); } else { dev_err(&i2c->dev, "Failed to allocate temporary cache\n"); }

3 2

[alsa-devel] ca0106 broken (fwd)
by Russell Whitaker 23 Jan '10

23 Jan '10

Hi Sent msg below and no responce. As a work-around replaced ng code with know good code into 2.6.29.6 and it worked. Tried same trick with 2.6.31.12 and it won't compile. If you send me something to try will do it and report back. Russ ---------- Forwarded message ---------- Date: Wed, 21 Oct 2009 14:54:45 -0700 (PDT) From: Russell Whitaker <russ(a)ashlandhome.net> To: James(a)superbug.demon.co.uk Subject: ca0106 broken Hi ca0106 is known to work in these releases: linux-2.6.27.20 linux-2.6.27.23 linux-2.6.28.10 It is broken in: linux-2.6.29.6 linux-2.6.30.9 For the broken releases dmesg reports: unknown hardware "CA0106" "" "" "" "" Anything I can do to help? Russ

2 3

Re: [alsa-devel] Echo Indigo card on Sabayon Gentoo
by S. Aguinaga 23 Jan '10

23 Jan '10

Hello Giuliano, No luck, same behavior. I edited the first file listed listed below and recompiled it and installed it. Then I restarted the system with the indigo card in place, and the VU meters show levels in the -120 to -100 dB? I do have alsa-driver-1.0.22 my kernel is 2.6.31 // Salvador ________________________________ From: Giuliano Pochini <pochini(a)shiny.it> To: S. Aguinaga <sa_jr(a)yahoo.com> Sent: Sun, January 17, 2010 4:04:38 PM Subject: Re: [alsa-devel] Echo Indigo card on Sabayon Gentoo On Thu, 14 Jan 2010 12:13:55 -0800 (PST) "S. Aguinaga" <sa_jr(a)yahoo.com> wrote: > Hello Fellows, > Just downloaded the latest (released) alsa-lib, alsa-driver, and alsa-utils, but my Indigo card does not work. It has been tested on the same system using the same drivers and on the same system using Fedora 10, that works fine. First install a recent version of echomixer. If you are using alsa-driver 1.0.22 or kernel 2.6.32, try to add this line: #define ECHOCARD_HAS_LINE_OUT_GAIN in alsa-driver-1.0.22/alsa-kernel/pci/echoaudio/indigoio.c or in linux-2.6.32/sound/pci/echoaudio/indigoio.c and recompile. It re-enables the line-out control that I removed last year because it was not supposed to exist in that card. -- Giuliano.

2 2

[alsa-devel] [PATCH] modem.conf Off-hook improve behavior
by David Fries 23 Jan '10

23 Jan '10

From: David Fries <david(a)fries.net> Only restore the old value if it differs from the requested value, because if it has changed restoring the old value overrides the change. Take for example, a voice modem with a .conf that sets preserve off-hook. Start playback (on-hook to off-hook), start record (off-hook to off-hook), stop playback (off-hook to restore on-hook), stop record (on-hook to restore off-hook), Clearly you don't want to leave the modem "on the phone" now that there isn't any playback or recording active. Signed-off-by: David Fries <david(a)fries.net> --- Comments welcome. The default modem.conf has, hooks.0 { type ctl_elems hook_args [ { name "Off-hook Switch" preserve true value "on" lock false optional true } ] } I wrote the patch to be, if you didn't modify it, don't restore the value. I also thought that it might work to check to see if the current mixer value matches the requested value (which is the value the program set on open), and only set the old value if it hasn't been externally modified. The theory being if something else changed the mixer value, we don't want to by default overwrite that change. Some additional flags could also be added to leave the current behavior alone and add the if you didn't modify it, don't restore it, or if it changed after you set it, don't restore it. Here are some flag names if that would be preferred, preserve_if_different restore_if_unmodified no_squash restore_overrides preserve_if_changed. Setting the lock isn't really an option, because then you can't manually "hang up" the modem if you needed to. On a side note, do any of the alsa voice/software modems support notifying userspace when the line is ringing? I'm using intel8x0m, not that I think it matters here. diff --git a/include/control.h b/include/control.h index 2361dc3..ded884a 100644 --- a/include/control.h +++ b/include/control.h @@ -419,6 +419,7 @@ int snd_ctl_elem_value_malloc(snd_ctl_elem_value_t **ptr); void snd_ctl_elem_value_free(snd_ctl_elem_value_t *obj); void snd_ctl_elem_value_clear(snd_ctl_elem_value_t *obj); void snd_ctl_elem_value_copy(snd_ctl_elem_value_t *dst, const snd_ctl_elem_value_t *src); +int snd_ctl_elem_value_compare(snd_ctl_elem_value_t *left, const snd_ctl_elem_value_t *right); void snd_ctl_elem_value_get_id(const snd_ctl_elem_value_t *obj, snd_ctl_elem_id_t *ptr); unsigned int snd_ctl_elem_value_get_numid(const snd_ctl_elem_value_t *obj); snd_ctl_elem_iface_t snd_ctl_elem_value_get_interface(const snd_ctl_elem_value_t *obj); diff --git a/src/control/control.c b/src/control/control.c index df249dd..159b09a 100644 --- a/src/control/control.c +++ b/src/control/control.c @@ -2256,6 +2256,18 @@ void snd_ctl_elem_value_copy(snd_ctl_elem_value_t *dst, const snd_ctl_elem_value } /** + * \brief compare one #snd_ctl_elem_value_t to another + * \param dst pointer to destination + * \param src pointer to source + * \return 0 on match, less than or greater than otherwise, see memcmp + */ +int snd_ctl_elem_value_compare(snd_ctl_elem_value_t *left, const snd_ctl_elem_value_t *right) +{ + assert(left && right); + return memcmp(left, right, sizeof(*left)); +} + +/** * \brief Get CTL element identifier of a CTL element id/value * \param obj CTL element id/value * \param ptr Pointer to returned CTL element identifier diff --git a/src/control/setup.c b/src/control/setup.c index 408244e..3606daf 100644 --- a/src/control/setup.c +++ b/src/control/setup.c @@ -192,7 +192,17 @@ int snd_sctl_remove(snd_sctl_t *h) return err; } } - if (elem->preserve) { + /* Only restore the old value if it differs from the requested + * value, because if it has changed restoring the old value + * overrides the change. Take for example, a voice modem with + * a .conf that sets preserve off-hook. Start playback (on-hook + * to off-hook), start record (off-hook to off-hook), stop + * playback (off-hook to restore on-hook), stop record (on-hook + * to restore off-hook), Clearly you don't want to leave the + * modem "on the phone" now that there isn't any playback or + * recording active. + */ + if (elem->preserve && snd_ctl_elem_value_compare(elem->val, elem->old)) { err = snd_ctl_elem_write(h->ctl, elem->old); if (err < 0) { SNDERR("Cannot restore ctl elem");

2 2

[alsa-devel] default alsa pcm improvement
by Aleksandar Kostadinov 23 Jan '10

23 Jan '10

Hello, _From some time now ALSA is a real pleasure to use. Namely it works by OOB and has lots of predefined useful PCMs so one doesn't need to be a guru to do advanced operations. I think that a small improvement in how default PCM is defined can help users with multiple sound cards that like to use pure ALSA and not some of the many available sound servers. I want to be able to switch the default sound device easily in asoundrc but the way the default pcm is defined makes this not very straightforward. I like to use the definitions of default:<CARD> but if I define "pcm.!default" in .asoundrc I lose the "default:<CARD>" definition. I now can rename the "default" definition in default.conf to someting like "defaultorg" and then reference it asoundrc but that requires root as well change can possibly disappear after an alsa-lib package upgrade. Or I can use the dmix and dsnoop predefined PCMs to put together PCMs that I can later reference in my "pcm.!default" definition but in this case one needs to know if the card needs dsnoop/dmix and probably other tweaks that default.conf contains. Additionally this needs to be done for every sound card one owns. So I would suggest the "default" PCM as defined now in the default.conf file to be renamed to something like "alsadefault". Then "default" PCM should be an alias to the alsadefault pcm. This will be backwards compatible to what users have now and owners of multiple sound devices can define their "default" pcm in asoundrc referencing the alsadefault pcm benefiting from the good work already done and not have to mess with a complex asoundrc file or make changes to the system configurations files. Please CC me in replies because I'm not subscribed. Thanks again for the cool work!

2 2

[alsa-devel] [PATCHv2 4/6] OMAP4: MCPDM: Register McPDM platform device
by Candelaria Villareal, Jorge 23 Jan '10

23 Jan '10

Add platform device for McPDM interface in OMAP4 and register its memory and irq resources. Signed-off-by: Jorge Eduardo Candelaria <x0107209(a)ti.com> --- arch/arm/plat-omap/devices.c | 37 +++++++++++++++++++++++++++++++++++++ 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/devices.c b/arch/arm/plat-omap/devices.c index 30b5db7..572265c 100644 --- a/arch/arm/plat-omap/devices.c +++ b/arch/arm/plat-omap/devices.c @@ -28,6 +28,7 @@ #include <plat/menelaus.h> #include <plat/mcbsp.h> #include <plat/dsp_common.h> +#include <plat/omap44xx.h> #if defined(CONFIG_OMAP_DSP) || defined(CONFIG_OMAP_DSP_MODULE) @@ -192,6 +193,41 @@ void omap_mcbsp_register_board_cfg(struct omap_mcbsp_platform_data *config, /*-------------------------------------------------------------------------*/ +#if defined(CONFIG_SND_OMAP_SOC_MCPDM) || \ + defined(CONFIG_SND_OMAP_SOC_MCPDM_MODULE) + +static struct resource mcpdm_resources[] = { + { + .name = "mcpdm_mem", + .start = OMAP44XX_MCPDM_BASE, + .end = OMAP44XX_MCPDM_BASE + SZ_4K, + .flags = IORESOURCE_MEM, + }, + { + .name = "mcpdm_irq", + .start = INT_44XX_MCPDM_IRQ, + .end = INT_44XX_MCPDM_IRQ, + .flags = IORESOURCE_IRQ, + }, +}; + +static struct platform_device omap_mcpdm_device = { + .name = "omap-mcpdm", + .id = -1, + .num_resources = ARRAY_SIZE(mcpdm_resources), + .resource = mcpdm_resources, +}; + +static void omap_init_mcpdm(void) +{ + (void) platform_device_register(&omap_mcpdm_device); +} +#else +static inline void omap_init_mcpdm(void) {} +#endif + +/*-------------------------------------------------------------------------*/ + #if defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE) || \ defined(CONFIG_MMC_OMAP_HS) || defined(CONFIG_MMC_OMAP_HS_MODULE) @@ -385,6 +421,7 @@ static int __init omap_init_devices(void) omap_init_dsp(); omap_init_kp(); omap_init_rng(); + omap_init_mcpdm(); omap_init_uwire(); omap_init_wdt(); return 0; -- 1.6.0.4

1 0

[alsa-devel] [PATCHv2 3/6] ARM: OMAP4: Add McPDM base address
by Candelaria Villareal, Jorge 23 Jan '10

23 Jan '10

Define McPDM physical and L3 base address for OMAP4 Signed-off-by: Jorge Eduardo Candelaria <x0107209(a)ti.com> --- arch/arm/plat-omap/include/plat/omap44xx.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h b/arch/arm/plat-omap/include/plat/omap44xx.h index 8e4c581..4c64f20 100644 --- a/arch/arm/plat-omap/include/plat/omap44xx.h +++ b/arch/arm/plat-omap/include/plat/omap44xx.h @@ -43,6 +43,8 @@ #define OMAP44XX_SCU_BASE 0x48240000 #define OMAP44XX_LOCAL_TWD_BASE 0x48240600 #define OMAP44XX_WKUPGEN_BASE 0x48281000 +#define OMAP44XX_MCPDM_BASE 0x40132000 +#define OMAP44XX_MCPDM_L3_BASE 0x49032000 #define OMAP44XX_MAILBOX_BASE (L4_44XX_BASE + 0xF4000) -- 1.6.0.4

1 0

[alsa-devel] [PATCHv2 2/6] OMAP4: IRQ: Add McPDM IRQ definition.
by Candelaria Villareal, Jorge 23 Jan '10

23 Jan '10

Support for McPDM IRQs in OMAP4 Signed-off-by: Jorge Eduardo Candelaria <x0107209(a)ti.com> --- arch/arm/plat-omap/include/plat/irqs.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/irqs.h b/arch/arm/plat-omap/include/plat/irqs.h index c0ab7c8..bbb8eb6 100644 --- a/arch/arm/plat-omap/include/plat/irqs.h +++ b/arch/arm/plat-omap/include/plat/irqs.h @@ -432,7 +432,7 @@ #define INT_44XX_PARTHASH_IRQ (79 + IRQ_GIC_START) #define INT_44XX_MMC3_IRQ (94 + IRQ_GIC_START) #define INT_44XX_MMC4_IRQ (96 + IRQ_GIC_START) - +#define INT_44XX_MCPDM_IRQ (112 + IRQ_GIC_START) /* Max. 128 level 2 IRQs (OMAP1610), 192 GPIOs (OMAP730/850) and * 16 MPUIO lines */ -- 1.6.0.4

1 0

[alsa-devel] Conexant 5051 subsystem 0x103c30d6
by Jacopo De Simoi 22 Jan '10

22 Jan '10

Dear all, this is a follow up to my previous posting to the ml about having CX 5051 working on my laptop; I found out that the patch provided in http://mailman.alsa-project.org/pipermail/alsa-devel/2010-January/024284.ht… fits perfectly my model as well. Hence I suggest to add a quirk matching my subsystem id as follows: SND_PCI_QUIRK(0x103c, 0x30d6, "HP DV2700", CXT5051_F700) Thanks __J

1 0

[alsa-devel] Reg: Audio recording with twl4030 codec
by shariff 22 Jan '10

22 Jan '10

Hi all, I am working with OMAP3 based custom board that has twl4030 codec & using linux-2.6.29 kernel from opensource. I have some queries regarding Audio recording. Audio codec is connected to twl4030 as bellow TWL4030 |--------------------| | |------ MAINMIC McBSP2 ------ |i2s/tdm | | ___________| --> One Analog MIC is connected to Main Mic and I am using Audio path not the Voice path. After selecting Main Mic through amixer control. and recording audio using "arecord -c 1 -r 8000 -f S16_LE -t wav -d 20 record-file.wav" --> Here record is successful but with lot of noise. 1) Can we record Mono(1 channel) through I2S from TWL4030 codec? 2) To record stereo(2 channels), do we need two Mic's ? (i.e do I need Sub Mic also). Regards, Shariff

2 1