- Alsa-devel - mailman.alsa-project.org

[PATCH] sound: drivers: fix typo 'reguest' to 'request'
by Yinchuan Guo 12 Feb '24

12 Feb '24

This patch fixes a widespread spelling mistake of the word "request" (incorrectly spelled as "reguest") across multiple files. Signed-off-by: Yinchuan Guo <guoych37(a)mail2.sysu.edu.cn> --- drivers/mfd/da9063-irq.c | 2 +- drivers/scsi/lpfc/lpfc_sli.c | 2 +- drivers/tty/serial/max310x.c | 2 +- drivers/tty/serial/sccnxp.c | 2 +- sound/soc/codecs/rt274.c | 2 +- sound/soc/codecs/rt286.c | 2 +- sound/soc/codecs/rt298.c | 2 +- sound/soc/codecs/rt5514-spi.c | 2 +- sound/soc/codecs/rt5640.c | 2 +- sound/soc/codecs/rt5645.c | 2 +- sound/soc/codecs/rt5651.c | 2 +- sound/soc/codecs/rt5659.c | 2 +- sound/soc/codecs/rt5663.c | 2 +- sound/soc/codecs/rt5665.c | 2 +- sound/soc/codecs/rt5668.c | 2 +- sound/soc/codecs/rt5682-i2c.c | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c index e2bbedf58e68..698d8ea50f32 100644 --- a/drivers/mfd/da9063-irq.c +++ b/drivers/mfd/da9063-irq.c @@ -188,7 +188,7 @@ int da9063_irq_init(struct da9063 *da9063) IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED, da9063->irq_base, irq_chip, &da9063->regmap_irq); if (ret) { - dev_err(da9063->dev, "Failed to reguest IRQ %d: %d\n", + dev_err(da9063->dev, "Failed to request IRQ %d: %d\n", da9063->chip_irq, ret); return ret; } diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index fc3682f15f50..a4fd45bb4ea5 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -9724,7 +9724,7 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, } wqe->els_req.payload_len = xmit_len; - /* Els_reguest64 has a TMO */ + /* Els_request64 has a TMO */ bf_set(wqe_tmo, &wqe->els_req.wqe_com, iocbq->iocb.ulpTimeout); /* Need a VF for word 4 set the vf bit*/ diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 3cbc757d7be7..6e259b292c41 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -1402,7 +1402,7 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty if (!ret) return 0; - dev_err(dev, "Unable to reguest IRQ %i\n", irq); + dev_err(dev, "Unable to request IRQ %i\n", irq); out_uart: for (i = 0; i < devtype->nr; i++) { diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c index 10cc16a71f26..8968d214da2f 100644 --- a/drivers/tty/serial/sccnxp.c +++ b/drivers/tty/serial/sccnxp.c @@ -1016,7 +1016,7 @@ static int sccnxp_probe(struct platform_device *pdev) if (!ret) return 0; - dev_err(&pdev->dev, "Unable to reguest IRQ %i\n", s->irq); + dev_err(&pdev->dev, "Unable to request IRQ %i\n", s->irq); } else { timer_setup(&s->timer, sccnxp_timer, 0); mod_timer(&s->timer, jiffies + diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c index 0d3773c576f8..b385b859373b 100644 --- a/sound/soc/codecs/rt274.c +++ b/sound/soc/codecs/rt274.c @@ -1196,7 +1196,7 @@ static int rt274_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt274", rt274); if (ret != 0) { dev_err(&i2c->dev, - "Failed to reguest IRQ: %d\n", ret); + "Failed to request IRQ: %d\n", ret); return ret; } } diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c index 802f4851c3df..061211f0fd65 100644 --- a/sound/soc/codecs/rt286.c +++ b/sound/soc/codecs/rt286.c @@ -1244,7 +1244,7 @@ static int rt286_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt286", rt286); if (ret != 0) { dev_err(&i2c->dev, - "Failed to reguest IRQ: %d\n", ret); + "Failed to request IRQ: %d\n", ret); return ret; } } diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c index c592c40a7ab3..ac81edfd2320 100644 --- a/sound/soc/codecs/rt298.c +++ b/sound/soc/codecs/rt298.c @@ -1286,7 +1286,7 @@ static int rt298_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt298", rt298); if (ret != 0) { dev_err(&i2c->dev, - "Failed to reguest IRQ: %d\n", ret); + "Failed to request IRQ: %d\n", ret); return ret; } } diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index 1a25a3787935..98e12f8113bc 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -280,7 +280,7 @@ static int rt5514_spi_pcm_probe(struct snd_soc_component *component) rt5514_dsp); if (ret) dev_err(&rt5514_spi->dev, - "%s Failed to reguest IRQ: %d\n", __func__, + "%s Failed to request IRQ: %d\n", __func__, ret); else device_init_wakeup(rt5514_dsp->dev, true); diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c index 9523f4b5c800..5b7ae70be1be 100644 --- a/sound/soc/codecs/rt5640.c +++ b/sound/soc/codecs/rt5640.c @@ -2843,7 +2843,7 @@ static int rt5640_i2c_probe(struct i2c_client *i2c, /* Gets re-enabled by rt5640_set_jack() */ disable_irq(rt5640->irq); } else { - dev_warn(&i2c->dev, "Failed to reguest IRQ %d: %d\n", + dev_warn(&i2c->dev, "Failed to request IRQ %d: %d\n", rt5640->irq, ret); rt5640->irq = -ENXIO; } diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 9408ee63cb26..cc868a9742bc 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -4127,7 +4127,7 @@ static int rt5645_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5645", rt5645); if (ret) { - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); goto err_enable; } } diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index fc0c83b73f09..e603886627e4 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -2266,7 +2266,7 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, /* Gets re-enabled by rt5651_set_jack() */ disable_irq(rt5651->irq); } else { - dev_warn(&i2c->dev, "Failed to reguest IRQ %d: %d\n", + dev_warn(&i2c->dev, "Failed to request IRQ %d: %d\n", rt5651->irq, ret); rt5651->irq = -ENXIO; } diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index 4a50b169fe03..acfbdcf2fbd9 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -4299,7 +4299,7 @@ static int rt5659_i2c_probe(struct i2c_client *i2c, rt5659_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5659", rt5659); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); /* Enable IRQ output for GPIO1 pin any way */ regmap_update_bits(rt5659->regmap, RT5659_GPIO_CTRL_1, diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/codecs/rt5663.c index be9fc58ff681..8f7db0703ea2 100644 --- a/sound/soc/codecs/rt5663.c +++ b/sound/soc/codecs/rt5663.c @@ -3676,7 +3676,7 @@ static int rt5663_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5663", rt5663); if (ret) { - dev_err(&i2c->dev, "%s Failed to reguest IRQ: %d\n", + dev_err(&i2c->dev, "%s Failed to request IRQ: %d\n", __func__, ret); goto err_enable; } diff --git a/sound/soc/codecs/rt5665.c b/sound/soc/codecs/rt5665.c index e59323fd5bf2..d82ead0e5caf 100644 --- a/sound/soc/codecs/rt5665.c +++ b/sound/soc/codecs/rt5665.c @@ -4930,7 +4930,7 @@ static int rt5665_i2c_probe(struct i2c_client *i2c, rt5665_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5665", rt5665); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); } diff --git a/sound/soc/codecs/rt5668.c b/sound/soc/codecs/rt5668.c index 6ab1a8bc3735..f1abfbc62a78 100644 --- a/sound/soc/codecs/rt5668.c +++ b/sound/soc/codecs/rt5668.c @@ -2581,7 +2581,7 @@ static int rt5668_i2c_probe(struct i2c_client *i2c, rt5668_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5668", rt5668); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); } diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c index 8ea9f1d9fec0..d03307585806 100644 --- a/sound/soc/codecs/rt5682-i2c.c +++ b/sound/soc/codecs/rt5682-i2c.c @@ -261,7 +261,7 @@ static int rt5682_i2c_probe(struct i2c_client *i2c, rt5682_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5682", rt5682); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); } return devm_snd_soc_register_component(&i2c->dev, -- 2.34.1

4 5

MAG Z790 TOMAHAWK WIFI DDR4 no Sound Front Audio Realtek 4080
by GitHub issues - opened 12 Feb '24

12 Feb '24

alsa-project/alsa-ucm-conf issue #395 was opened from Acer6920: Greetings, back audio is working the sound card is recognized as Generic USB Audio 3 [Audio ]: USB-Audio - USB Audio Generic USB Audio at usb-0000:00:14.0-11, high speed alsa information: http://alsa-project.org/db/?f=655312de1f9b11ddc33de5fa41c6cad87bcbab9d if i missed something excuse it please i use zorin os/linux since yesterday and need some advice if you need more information. thanks a lot. ace Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/395 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] Subject: [PATCH] sound: drivers: fix typo 'reguest' to 'request'
by Yinchuan Guo 12 Feb '24

12 Feb '24

This patch fixes a widespread spelling mistake of the word "request" (incorrectly spelled as "reguest") across multiple files. Signed-off-by: Yinchuan Guo <guoych37(a)mail2.sysu.edu.cn> --- drivers/mfd/da9063-irq.c | 2 +- drivers/scsi/lpfc/lpfc_sli.c | 2 +- drivers/tty/serial/max310x.c | 2 +- drivers/tty/serial/sccnxp.c | 2 +- sound/soc/codecs/rt274.c | 2 +- sound/soc/codecs/rt286.c | 2 +- sound/soc/codecs/rt298.c | 2 +- sound/soc/codecs/rt5514-spi.c | 2 +- sound/soc/codecs/rt5640.c | 2 +- sound/soc/codecs/rt5645.c | 2 +- sound/soc/codecs/rt5651.c | 2 +- sound/soc/codecs/rt5659.c | 2 +- sound/soc/codecs/rt5663.c | 2 +- sound/soc/codecs/rt5665.c | 2 +- sound/soc/codecs/rt5668.c | 2 +- sound/soc/codecs/rt5682-i2c.c | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c index e2bbedf58e68..698d8ea50f32 100644 --- a/drivers/mfd/da9063-irq.c +++ b/drivers/mfd/da9063-irq.c @@ -188,7 +188,7 @@ int da9063_irq_init(struct da9063 *da9063) IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED, da9063->irq_base, irq_chip, &da9063->regmap_irq); if (ret) { - dev_err(da9063->dev, "Failed to reguest IRQ %d: %d\n", + dev_err(da9063->dev, "Failed to request IRQ %d: %d\n", da9063->chip_irq, ret); return ret; } diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index fc3682f15f50..a4fd45bb4ea5 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -9724,7 +9724,7 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, } wqe->els_req.payload_len = xmit_len; - /* Els_reguest64 has a TMO */ + /* Els_request64 has a TMO */ bf_set(wqe_tmo, &wqe->els_req.wqe_com, iocbq->iocb.ulpTimeout); /* Need a VF for word 4 set the vf bit*/ diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 3cbc757d7be7..6e259b292c41 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -1402,7 +1402,7 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty if (!ret) return 0; - dev_err(dev, "Unable to reguest IRQ %i\n", irq); + dev_err(dev, "Unable to request IRQ %i\n", irq); out_uart: for (i = 0; i < devtype->nr; i++) { diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c index 10cc16a71f26..8968d214da2f 100644 --- a/drivers/tty/serial/sccnxp.c +++ b/drivers/tty/serial/sccnxp.c @@ -1016,7 +1016,7 @@ static int sccnxp_probe(struct platform_device *pdev) if (!ret) return 0; - dev_err(&pdev->dev, "Unable to reguest IRQ %i\n", s->irq); + dev_err(&pdev->dev, "Unable to request IRQ %i\n", s->irq); } else { timer_setup(&s->timer, sccnxp_timer, 0); mod_timer(&s->timer, jiffies + diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c index 0d3773c576f8..b385b859373b 100644 --- a/sound/soc/codecs/rt274.c +++ b/sound/soc/codecs/rt274.c @@ -1196,7 +1196,7 @@ static int rt274_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt274", rt274); if (ret != 0) { dev_err(&i2c->dev, - "Failed to reguest IRQ: %d\n", ret); + "Failed to request IRQ: %d\n", ret); return ret; } } diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c index 802f4851c3df..061211f0fd65 100644 --- a/sound/soc/codecs/rt286.c +++ b/sound/soc/codecs/rt286.c @@ -1244,7 +1244,7 @@ static int rt286_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt286", rt286); if (ret != 0) { dev_err(&i2c->dev, - "Failed to reguest IRQ: %d\n", ret); + "Failed to request IRQ: %d\n", ret); return ret; } } diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c index c592c40a7ab3..ac81edfd2320 100644 --- a/sound/soc/codecs/rt298.c +++ b/sound/soc/codecs/rt298.c @@ -1286,7 +1286,7 @@ static int rt298_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt298", rt298); if (ret != 0) { dev_err(&i2c->dev, - "Failed to reguest IRQ: %d\n", ret); + "Failed to request IRQ: %d\n", ret); return ret; } } diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index 1a25a3787935..98e12f8113bc 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -280,7 +280,7 @@ static int rt5514_spi_pcm_probe(struct snd_soc_component *component) rt5514_dsp); if (ret) dev_err(&rt5514_spi->dev, - "%s Failed to reguest IRQ: %d\n", __func__, + "%s Failed to request IRQ: %d\n", __func__, ret); else device_init_wakeup(rt5514_dsp->dev, true); diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c index 9523f4b5c800..5b7ae70be1be 100644 --- a/sound/soc/codecs/rt5640.c +++ b/sound/soc/codecs/rt5640.c @@ -2843,7 +2843,7 @@ static int rt5640_i2c_probe(struct i2c_client *i2c, /* Gets re-enabled by rt5640_set_jack() */ disable_irq(rt5640->irq); } else { - dev_warn(&i2c->dev, "Failed to reguest IRQ %d: %d\n", + dev_warn(&i2c->dev, "Failed to request IRQ %d: %d\n", rt5640->irq, ret); rt5640->irq = -ENXIO; } diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 9408ee63cb26..cc868a9742bc 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -4127,7 +4127,7 @@ static int rt5645_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5645", rt5645); if (ret) { - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); goto err_enable; } } diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index fc0c83b73f09..e603886627e4 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -2266,7 +2266,7 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, /* Gets re-enabled by rt5651_set_jack() */ disable_irq(rt5651->irq); } else { - dev_warn(&i2c->dev, "Failed to reguest IRQ %d: %d\n", + dev_warn(&i2c->dev, "Failed to request IRQ %d: %d\n", rt5651->irq, ret); rt5651->irq = -ENXIO; } diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index 4a50b169fe03..acfbdcf2fbd9 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -4299,7 +4299,7 @@ static int rt5659_i2c_probe(struct i2c_client *i2c, rt5659_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5659", rt5659); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); /* Enable IRQ output for GPIO1 pin any way */ regmap_update_bits(rt5659->regmap, RT5659_GPIO_CTRL_1, diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/codecs/rt5663.c index be9fc58ff681..8f7db0703ea2 100644 --- a/sound/soc/codecs/rt5663.c +++ b/sound/soc/codecs/rt5663.c @@ -3676,7 +3676,7 @@ static int rt5663_i2c_probe(struct i2c_client *i2c, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5663", rt5663); if (ret) { - dev_err(&i2c->dev, "%s Failed to reguest IRQ: %d\n", + dev_err(&i2c->dev, "%s Failed to request IRQ: %d\n", __func__, ret); goto err_enable; } diff --git a/sound/soc/codecs/rt5665.c b/sound/soc/codecs/rt5665.c index e59323fd5bf2..d82ead0e5caf 100644 --- a/sound/soc/codecs/rt5665.c +++ b/sound/soc/codecs/rt5665.c @@ -4930,7 +4930,7 @@ static int rt5665_i2c_probe(struct i2c_client *i2c, rt5665_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5665", rt5665); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); } diff --git a/sound/soc/codecs/rt5668.c b/sound/soc/codecs/rt5668.c index 6ab1a8bc3735..f1abfbc62a78 100644 --- a/sound/soc/codecs/rt5668.c +++ b/sound/soc/codecs/rt5668.c @@ -2581,7 +2581,7 @@ static int rt5668_i2c_probe(struct i2c_client *i2c, rt5668_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5668", rt5668); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); } diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c index 8ea9f1d9fec0..d03307585806 100644 --- a/sound/soc/codecs/rt5682-i2c.c +++ b/sound/soc/codecs/rt5682-i2c.c @@ -261,7 +261,7 @@ static int rt5682_i2c_probe(struct i2c_client *i2c, rt5682_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "rt5682", rt5682); if (ret) - dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret); + dev_err(&i2c->dev, "Failed to request IRQ: %d\n", ret); } return devm_snd_soc_register_component(&i2c->dev, -- 2.34.1

3 2

Asus ROG Strix Z790-A Gaming WIFI II audio codec detected as generic USB audio, headphones and SPDIF not working
by GitHub issues - opened 12 Feb '24

12 Feb '24

alsa-project/alsa-ucm-conf issue #394 was opened from danielton1: Hi, I have an Asus ROG STRIX Z790-A GAMING WIFI II motherboard with a Realtek ALC4080 audio codec. Sound is working through the speakers via the line out jack, and it does detect when I plug headphones in, but everything I'm finding is that the ALSA UCM is failing to detect the device as a Realtek ALC4080 and instead is just using a generic USB profile, probably due to the USB ID being unknown. Audio always comes out the line out jack no matter what is plugged in to the front panel or SPDIF or how pipewire/ALSA are configured. This is what lsusb gives as the ID: Bus 001 Device 002: ID 0b05:1af1 ASUSTek Computer, Inc. USB Audio This is the output of alsa-info.sh: http://alsa-project.org/db/?f=3dc5eb049583da76a18466a6cf16d144dae95f53 I've tried modifying the files in /usr/share/alsa/ucm2/USB-Audio several different ways per several forum threads I came across online and ended up with no sound at all, so I'm not sure what's going on or how to fix this. Any help would be greatly appreciated! Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/394 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 6.8 regression fix 0/2] ASoC: Intel: Boards: Fix NULL pointer deref in BYT/CHT boards
by Hans de Goede 12 Feb '24

12 Feb '24

Hi All, While testing 6.8 on a Bay Trail device with a ALC5640 codec I noticed a regression in 6.8 which causes a NULL pointer deref in probe(). All BYT/CHT Intel machine drivers are affected. Patch 1/2 of this series fixes all of them. Patch 2/2 adds some small cleanups to cht_bsw_rt5645.c for issues which I noticed while working on 1/2. Regards, Hans Hans de Goede (2): ASoC: Intel: Boards: Fix NULL pointer deref in BYT/CHT boards ASoC: Intel: cht_bsw_rt5645: Cleanup codec_name handling sound/soc/intel/boards/bytcht_cx2072x.c | 3 ++- sound/soc/intel/boards/bytcht_da7213.c | 3 ++- sound/soc/intel/boards/bytcht_es8316.c | 3 ++- sound/soc/intel/boards/bytcr_rt5640.c | 3 ++- sound/soc/intel/boards/bytcr_rt5651.c | 3 ++- sound/soc/intel/boards/bytcr_wm5102.c | 3 ++- sound/soc/intel/boards/cht_bsw_rt5645.c | 7 +++---- sound/soc/intel/boards/cht_bsw_rt5672.c | 3 ++- 8 files changed, 17 insertions(+), 11 deletions(-) -- 2.43.0

2 3

Re: [REGRESSION] Acp5x probing regression introduced between kernel 6.7.2 -> 6.7.4
by Linux regression tracking (Thorsten Leemhuis) 11 Feb '24

11 Feb '24

[CCing a few people] On 11.02.24 15:34, Ted Chang wrote: > > I noticed 6.7.4 has introduced a regression for the steam deck. The LCD > steam deck can no longer probe the acp5x audio chipset anymore. This > regression does not affect the 6.8.x series. I did not test kernel > 6.7.3 because Opensuse tumbleweed skipped the update on my machine. Thx for your report. FWIW, problems like this can be caused by all sorts of changes, but obviously those in the area of audio support are most likely to cause this. There are just a few in the v6.7.2..v6.7.4 range[1]. Among them a commit that is related to acp5x, that's why I CCed its author as well (Venkata Prasad Potturu). Maybe one of the new recipients will have an idea. If not, you most likely will have to bisect this and check if mainline is affected as well.[2] Ciao, Thorsten [1] $ git log --oneline v6.7.2..v6.7.4 sound/ f3570675bf09af ASoC: codecs: wsa883x: fix PA volume control 2f8e9b77ca2fea ASoC: codecs: lpass-wsa-macro: fix compander volume hack 5b465d6384e4eb ASoC: codecs: wcd938x: fix headphones volume controls 1673211a38012e ASoC: qcom: sc8280xp: limit speaker volumes 242b5bffa23a9c ASoC: codecs: rtq9128: Fix TDM enable and DAI format control flow 2c272ff9859601 ASoC: codecs: rtq9128: Fix PM_RUNTIME usage 4a28302b2c681e ALSA: hda/conexant: Fix headset auto detect fail in cx8070 and SN6140 e37a96941fdd53 ALSA: hda: intel-dspcfg: add filters for ARL-S and ARL ffa3eea886c6fe ALSA: hda: Intel: add HDA_ARL PCI ID support 4b6986b170f2f2 ASoC: amd: Add new dmi entries for acp5x platform e38ad4ace20b4d ALSA: hda: Refer to correct stream index at loops a434c75e0671f9 soundwire: fix initializing sysfs for same devices on different buses [2] I'm working on a guide that describes what's needed: https://www.leemhuis.info/files/misc/How%20to%20bisect%20a%20Linux%20kernel… > Steps to reproduce the problem > 1. Obtain a steam deck > 2. Install kernel 6.7.4 > 3. Boot the device and you will see dummy output in gnome shell > > Observed kernel logs. > > [ 8.755614] cs35l41 spi-VLV1776:00: supply VA not found, using dummy regulator > [ 8.760506] cs35l41 spi-VLV1776:00: supply VP not found, using dummy regulator > [ 8.777148] cs35l41 spi-VLV1776:00: Cirrus Logic CS35L41 (35a40), Revision: B2 > [ 8.777471] cs35l41 spi-VLV1776:01: supply VA not found, using dummy regulator > [ 8.777532] cs35l41 spi-VLV1776:01: supply VP not found, using dummy regulator > [ 8.777709] cs35l41 spi-VLV1776:01: Reset line busy, assuming shared reset > [ 8.788465] cs35l41 spi-VLV1776:01: Cirrus Logic CS35L41 (35a40), Revision: B2 > [ 8.877280] snd_hda_intel 0000:04:00.1: enabling device (0000 -> 0002) > [ 8.877595] snd_hda_intel 0000:04:00.1: Handle vga_switcheroo audio client > [ 8.889913] snd_acp_pci 0000:04:00.5: enabling device (0000 -> 0002) > [ 8.890063] snd_acp_pci 0000:04:00.5: Unsupported device revision:0x50 > [ 8.890129] snd_acp_pci: probe of 0000:04:00.5 failed with error -22 > [ 8.906136] snd_hda_intel 0000:04:00.1: bound 0000:04:00.0 (ops amdgpu_dm_audio_component_bind_ops [amdgpu] > > > No kernel module in use shown. > > 04:00.5 Multimedia controller [0480]: Advanced Micro Devices, Inc. [AMD] > ACP/ACP3X/ACP6x Audio Coprocessor [1022:15e2] (rev 50) > Subsystem: Valve Software Device [1e44:1776] > Flags: fast devsel, IRQ 70, IOMMU group 4 > Memory at 80380000 (32-bit, non-prefetchable) [size=256K] > Capabilities: <access denied> > Kernel modules: snd_pci_acp3x, snd_rn_pci_acp3x, snd_pci_acp5x, > snd_pci_acp6x, snd_acp_pci, snd_rpl_pci_acp6x, snd_pci_ps, > snd_sof_amd_renoir, snd_sof_amd_rembrandt, snd_sof_amd_vangogh, > snd_sof_amd_acp63 > > > Information for package kernel-default: > --------------------------------------- > Repository : openSUSE-Tumbleweed-Oss > Name : kernel-default > Version : 6.7.4-1.1 > Arch : x86_64 > Vendor : openSUSE > Installed Size : 240.3 MiB > Installed : Yes > Status : up-to-date > Source package : kernel-default-6.7.4-1.1.nosrc > Upstream URL : https://www.kernel.org/ <https://www.kernel.org/> > Summary : The Standard Kernel > Description : > The standard kernel for both uniprocessor and multiprocessor systems. > > > Source Timestamp: 2024-02-06 05:32:37 +0000 > GIT Revision: 01735a3e65287585dd830a6a3d33d909a4f9ae7f > GIT Branch: stable > > Handle 0x0000, DMI type 0, 26 bytes > BIOS Information > Vendor: Valve > Version: F7A0120 > Release Date: 12/01/2023 > Address: 0xE0000 > Runtime Size: 128 kB > BIOS Revision: 1.20 > Firmware Revision: 1.16 > > #regzbot introduced: v6.7.2..v6.7.4 >

1 0

[PATCH] ASoC: cs35l56: Remove default from IRQ1_CFG register
by Richard Fitzgerald 09 Feb '24

09 Feb '24

The driver never uses the IRQ1_CFG register so there's no need to provide a default value. It's set as a readable register only for debugging through the regmap registers file. A system-specific firmware could overwrite this register with a non-default value. Therefore the driver can't hardcode what the initial value actually is. As the register is only for debugging the value can be left unknown until someone wants to read it through debugfs. Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- sound/soc/codecs/cs35l56-shared.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-shared.c index 02fba4bc0a14..995d979b6d87 100644 --- a/sound/soc/codecs/cs35l56-shared.c +++ b/sound/soc/codecs/cs35l56-shared.c @@ -51,7 +51,6 @@ static const struct reg_default cs35l56_reg_defaults[] = { { CS35L56_SWIRE_DP3_CH2_INPUT, 0x00000019 }, { CS35L56_SWIRE_DP3_CH3_INPUT, 0x00000029 }, { CS35L56_SWIRE_DP3_CH4_INPUT, 0x00000028 }, - { CS35L56_IRQ1_CFG, 0x00000000 }, { CS35L56_IRQ1_MASK_1, 0x83ffffff }, { CS35L56_IRQ1_MASK_2, 0xffff7fff }, { CS35L56_IRQ1_MASK_4, 0xe0ffffff }, -- 2.30.2

2 1

[PATCH v4] ASoC: tas2781: remove unused acpi_subysystem_id
by Gergo Koteles 09 Feb '24

09 Feb '24

The acpi_subysystem_id is only written and freed, not read, so unnecessary. Signed-off-by: Gergo Koteles <soyer(a)irl.hu> --- Changes since v3: - remove Fixes and CC tags from commit message - remove In-Reply-To from header - rebase onto for-next - link to v3: https://lore.kernel.org/lkml/7f056a4148fec176812ff6cc490860bf565b161c.17072… Changes since v2: remove sub from tas2781_read_acpi Changes since v1: remove physdev from tas2781_read_acpi --- include/sound/tas2781.h | 1 - sound/pci/hda/tas2781_hda_i2c.c | 12 ------------ sound/soc/codecs/tas2781-comlib.c | 1 - 3 files changed, 14 deletions(-) diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h index 9aff384941de..99ca3e401fd1 100644 --- a/include/sound/tas2781.h +++ b/include/sound/tas2781.h @@ -103,7 +103,6 @@ struct tasdevice_priv { struct tm tm; enum device_catlog_id catlog_id; - const char *acpi_subsystem_id; unsigned char cal_binaryname[TASDEVICE_MAX_CHANNELS][64]; unsigned char crc8_lkp_tbl[CRC8_TABLE_SIZE]; unsigned char coef_binaryname[64]; diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index 1bfb00102a77..4c9a788c3501 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -111,9 +111,7 @@ static int tas2781_get_i2c_res(struct acpi_resource *ares, void *data) static int tas2781_read_acpi(struct tasdevice_priv *p, const char *hid) { struct acpi_device *adev; - struct device *physdev; LIST_HEAD(resources); - const char *sub; int ret; adev = acpi_dev_get_first_match_dev(hid, NULL, -1); @@ -129,18 +127,8 @@ static int tas2781_read_acpi(struct tasdevice_priv *p, const char *hid) acpi_dev_free_resource_list(&resources); strscpy(p->dev_name, hid, sizeof(p->dev_name)); - physdev = get_device(acpi_get_first_physical_node(adev)); acpi_dev_put(adev); - /* No side-effect to the playback even if subsystem_id is NULL*/ - sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev)); - if (IS_ERR(sub)) - sub = NULL; - - p->acpi_subsystem_id = sub; - - put_device(physdev); - return 0; err: diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c index 5d0e5348b361..3aa81514dad7 100644 --- a/sound/soc/codecs/tas2781-comlib.c +++ b/sound/soc/codecs/tas2781-comlib.c @@ -408,7 +408,6 @@ void tasdevice_remove(struct tasdevice_priv *tas_priv) { if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) gpio_free(tas_priv->irq_info.irq_gpio); - kfree(tas_priv->acpi_subsystem_id); mutex_destroy(&tas_priv->codec_lock); } EXPORT_SYMBOL_GPL(tasdevice_remove); base-commit: aa0dc84513e94a6ee2df360cf5e3b207abf734e0 -- 2.43.0

2 1

[PATCH v2] ASoC: Intel: avs: Expose FW version with sysfs
by Amadeusz Sławiński 09 Feb '24

09 Feb '24

From: Cezary Rojewski <cezary.rojewski(a)intel.com> Add functionality to read version of loaded FW from sysfs. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> --- Changes in v2: - Adjust path in Documentation to correct one --- .../ABI/testing/sysfs-bus-pci-devices-avs | 8 +++++ sound/soc/intel/avs/Makefile | 3 +- sound/soc/intel/avs/avs.h | 4 +++ sound/soc/intel/avs/core.c | 1 + sound/soc/intel/avs/sysfs.c | 35 +++++++++++++++++++ 5 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-avs create mode 100644 sound/soc/intel/avs/sysfs.c diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-avs b/Documentation/ABI/testing/sysfs-bus-pci-devices-avs new file mode 100644 index 0000000000000..ebff3fa12055d --- /dev/null +++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-avs @@ -0,0 +1,8 @@ +What: /sys/devices/pci0000:00/<dev>/avs/fw_version +Date: February 2024 +Contact: Cezary Rojewski <cezary.rojewski(a)intel.com> +Description: + Version of AudioDSP firmware ASoC avs driver is communicating + with. + + Format: %d.%d.%d.%d, type:major:minor:build. diff --git a/sound/soc/intel/avs/Makefile b/sound/soc/intel/avs/Makefile index 460ee6599daf0..a3fad926d0fb0 100644 --- a/sound/soc/intel/avs/Makefile +++ b/sound/soc/intel/avs/Makefile @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-only snd-soc-avs-objs := dsp.o ipc.o messages.o utils.o core.o loader.o \ - topology.o path.o pcm.o board_selection.o control.o + topology.o path.o pcm.o board_selection.o control.o \ + sysfs.o snd-soc-avs-objs += cldma.o snd-soc-avs-objs += skl.o apl.o diff --git a/sound/soc/intel/avs/avs.h b/sound/soc/intel/avs/avs.h index d694e08e44e18..69c912feb8a7e 100644 --- a/sound/soc/intel/avs/avs.h +++ b/sound/soc/intel/avs/avs.h @@ -392,4 +392,8 @@ static inline void avs_debugfs_init(struct avs_dev *adev) { } static inline void avs_debugfs_exit(struct avs_dev *adev) { } #endif +/* Filesystems integration */ + +extern const struct attribute_group *avs_attr_groups[]; + #endif /* __SOUND_SOC_INTEL_AVS_H */ diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c index db78eb2f01080..273a902168562 100644 --- a/sound/soc/intel/avs/core.c +++ b/sound/soc/intel/avs/core.c @@ -776,6 +776,7 @@ static struct pci_driver avs_pci_driver = { .probe = avs_pci_probe, .remove = avs_pci_remove, .shutdown = avs_pci_shutdown, + .dev_groups = avs_attr_groups, .driver = { .pm = &avs_dev_pm, }, diff --git a/sound/soc/intel/avs/sysfs.c b/sound/soc/intel/avs/sysfs.c new file mode 100644 index 0000000000000..cce21636fbc02 --- /dev/null +++ b/sound/soc/intel/avs/sysfs.c @@ -0,0 +1,35 @@ +// SPDX-License-Identifier: GPL-2.0-only +// +// Copyright(c) 2021-2024 Intel Corporation. All rights reserved. +// +// Authors: Cezary Rojewski <cezary.rojewski(a)intel.com> +// Amadeusz Slawinski <amadeuszx.slawinski(a)linux.intel.com> +// + +#include <linux/sysfs.h> +#include "avs.h" + +static ssize_t fw_version_show(struct device *dev, struct device_attribute *attr, char *buf) +{ + struct avs_dev *adev = to_avs_dev(dev); + struct avs_fw_version *fw_version = &adev->fw_cfg.fw_version; + + return sysfs_emit(buf, "%d.%d.%d.%d\n", fw_version->major, fw_version->minor, + fw_version->hotfix, fw_version->build); +} +static DEVICE_ATTR_RO(fw_version); + +static struct attribute *avs_fw_attrs[] = { + &dev_attr_fw_version.attr, + NULL +}; + +static const struct attribute_group avs_attr_group = { + .name = "avs", + .attrs = avs_fw_attrs, +}; + +const struct attribute_group *avs_attr_groups[] = { + &avs_attr_group, + NULL +}; -- 2.34.1

2 1

[PATCH 00/24] ASoC: Intel: Machine driver updates for 6.9
by Pierre-Louis Bossart 09 Feb '24

09 Feb '24

A fairly large update this time, with Brent Lu's continued cleanup of Chromebook cards, and updates for new SoundWire configurations. Bard Liao (11): ASoC: Intel: sof_sdw: use single rtd_init for rt_amps ASoC: Intel: add get_codec_dai_by_name helper function ASoC: Intel: sof_sdw_rt_sdca_jack_common: use helper to get codec dai by name ASoC: Intel: sof_sdw_rt711: use helper to get codec dai by name ASoC: Intel: sof_sdw_rt712_sdca: use helper to get codec dai by name ASoC: Intel: sof_sdw_rt700: use helper to get codec dai by name ASoC: Intel: sof_sdw_cs42l42: use helper to get codec dai by name ASoC: Intel: sof_sdw_rt5682: use helper to get codec dai by name ASoC: Intel: sof_sdw: add common sdw dai link init ASoC: Intel: sof_sdw: remove .init callbacks ASoC: Intel: sof_sdw: starts non sdw BE id with the highest sdw BE id Brent Lu (8): ASoC: Intel: sof_rt5682: board id cleanup for jsl boards ASoC: Intel: sof_rt5682: board id cleanup for tgl boards ASoC: Intel: sof_rt5682: board id cleanup for adl boards ASoC: Intel: sof_rt5682: board id cleanup for rpl boards ASoC: Intel: sof_rt5682: board id cleanup for mtl boards ASoC: Intel: sof_rt5682: dmi quirk cleanup for mtl boards ASoC: Intel: board_helpers: support DAI link order customization ASoC: Intel: sof_cs42l42: use common module for DAI link generation Chao Song (2): ASoC: Intel: soc-acpi: add RT712 support for LNL ASoC: Intel: soc-acpi-intel-lnl-match: Add rt722 support Charles Keepax (2): ASoC: Intel: ssp-common: Add stub for sof_ssp_get_codec_name ASoC: Intel: sof_sdw: Remove unused function prototypes mosomate (1): ASoC: Intel: common: DMI remap for rebranded Intel NUC M15 (LAPRC710) laptops drivers/soundwire/dmi-quirks.c | 8 + sound/soc/intel/boards/Kconfig | 1 + sound/soc/intel/boards/sof_board_helpers.c | 225 ++++++++++++------ sound/soc/intel/boards/sof_board_helpers.h | 29 +++ sound/soc/intel/boards/sof_cs42l42.c | 224 +++++------------ sound/soc/intel/boards/sof_rt5682.c | 151 +----------- sound/soc/intel/boards/sof_sdw.c | 106 +++++++-- sound/soc/intel/boards/sof_sdw_common.h | 82 ++----- sound/soc/intel/boards/sof_sdw_cs42l42.c | 35 ++- sound/soc/intel/boards/sof_sdw_cs42l43.c | 25 +- sound/soc/intel/boards/sof_sdw_cs_amp.c | 3 +- sound/soc/intel/boards/sof_sdw_maxim.c | 4 +- sound/soc/intel/boards/sof_sdw_rt5682.c | 35 ++- sound/soc/intel/boards/sof_sdw_rt700.c | 35 ++- sound/soc/intel/boards/sof_sdw_rt711.c | 19 +- sound/soc/intel/boards/sof_sdw_rt712_sdca.c | 39 ++- sound/soc/intel/boards/sof_sdw_rt715.c | 12 +- sound/soc/intel/boards/sof_sdw_rt715_sdca.c | 12 +- sound/soc/intel/boards/sof_sdw_rt_amp.c | 53 +---- .../boards/sof_sdw_rt_sdca_jack_common.c | 19 +- sound/soc/intel/boards/sof_ssp_common.h | 8 + .../intel/common/soc-acpi-intel-adl-match.c | 12 +- .../intel/common/soc-acpi-intel-jsl-match.c | 10 +- .../intel/common/soc-acpi-intel-lnl-match.c | 102 ++++++++ .../intel/common/soc-acpi-intel-mtl-match.c | 4 +- .../intel/common/soc-acpi-intel-rpl-match.c | 4 +- .../intel/common/soc-acpi-intel-tgl-match.c | 6 +- 27 files changed, 585 insertions(+), 678 deletions(-) -- 2.40.1

2 25