- Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: hda/realtek: Add model alc298-samsung-headphone
by Mike Pozulp 17 Aug '20

17 Aug '20

The very quiet and distorted headphone output bug that afflicted my Samsung Notebook 9 is appearing in many other Samsung laptops. Expose the quirk which fixed my laptop as a model so other users can try it. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423 Signed-off-by: Mike Pozulp <pozulp.kernel(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 29f5878f0c50..722d01a06422 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7867,6 +7867,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {.id = ALC299_FIXUP_PREDATOR_SPK, .name = "predator-spk"}, {.id = ALC298_FIXUP_HUAWEI_MBX_STEREO, .name = "huawei-mbx-stereo"}, {.id = ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE, .name = "alc256-medion-headset"}, + {.id = ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET, .name = "alc298-samsung-headphone"}, {} }; #define ALC225_STANDARD_PINS \ -- 2.28.0

2 1

[PATCH] usb-audio: Update documentation comment for MS2109 quirk
by Hector Martin 17 Aug '20

17 Aug '20

Signed-off-by: Hector Martin <marcan(a)marcan.st> --- sound/usb/quirks-table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index d79e3ddc5690..72cc03e7aed1 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -3714,8 +3714,8 @@ ALC1220_VB_DESKTOP(0x26ce, 0x0a01), /* Asrock TRX40 Creator */ * they pretend to be 96kHz mono as a workaround for stereo being broken * by that... * - * They also have swapped L-R channels, but that's for userspace to deal - * with. + * They also have an issue with initial stream alignment that causes the + * channels to be swapped and out of phase, which is dealt with in quirks.c. */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | -- 2.27.0

2 1

[PATCH v2] soundwire: master: enable pm runtime
by Bard Liao 17 Aug '20

17 Aug '20

The hierarchy of soundwire devices is platform device -> M device -> S device. A S device is physically attached on the platform device. So the platform device should be resumed when a S device is resumed. As the bridge of platform device and S device, we have to implement runtime pm on M driver. We have set runtime pm ops in M driver already, but still need to enable runtime pm. Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- Changes in v2: - Edit the commit message to explain why we need the patch. --- drivers/soundwire/master.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soundwire/master.c b/drivers/soundwire/master.c index 5f0b2189defe..3488bb824e84 100644 --- a/drivers/soundwire/master.c +++ b/drivers/soundwire/master.c @@ -154,6 +154,7 @@ int sdw_master_device_add(struct sdw_bus *bus, struct device *parent, bus->dev = &md->dev; bus->md = md; + pm_runtime_enable(&bus->md->dev); device_register_err: return ret; } @@ -166,6 +167,7 @@ int sdw_master_device_add(struct sdw_bus *bus, struct device *parent, */ int sdw_master_device_del(struct sdw_bus *bus) { + pm_runtime_disable(&bus->md->dev); device_unregister(bus->dev); return 0; -- 2.17.1

2 1

[PATCH] ALSA: usb-audio: ignore broken processing/extension unit
by tom.ty89＠gmail.com 17 Aug '20

17 Aug '20

From: Tom Yan <tom.ty89(a)gmail.com> Some devices have broken extension unit where getting current value doesn't work. Attempt that once when creating mixer control for it. If it fails, just ignore it, so that it won't cripple the device entirely (and/or make the error floods). --- sound/usb/mixer.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index eab0fd4fd7c3..e0b7174c1043 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2367,7 +2367,7 @@ static int build_audio_procunit(struct mixer_build *state, int unitid, int num_ins; struct usb_mixer_elem_info *cval; struct snd_kcontrol *kctl; - int i, err, nameid, type, len; + int i, err, nameid, type, len, val; const struct procunit_info *info; const struct procunit_value_info *valinfo; const struct usbmix_name_map *map; @@ -2470,6 +2470,12 @@ static int build_audio_procunit(struct mixer_build *state, int unitid, break; } + err = get_cur_ctl_value(cval, cval->control << 8, &val); + if (err < 0) { + usb_mixer_elem_info_free(cval); + return -EINVAL; + } + kctl = snd_ctl_new1(&mixer_procunit_ctl, cval); if (!kctl) { usb_mixer_elem_info_free(cval); -- 2.28.0

2 1

Re: pcm|dmaengine|imx-sdma race condition on i.MX6
by Richard Leitner 17 Aug '20

17 Aug '20

On Fri, Aug 14, 2020 at 11:18:10AM +0200, Robin Gong wrote: > > On 2020/08/13 19:23: Richard Leitner <richard.leitner(a)skidata.com> wrote: > > Hi, > > we've found a race condition with the PCM on the i.MX6 which results > > in an -EIO for the SNDRV_PCM_IOCTL_READI_FRAMES ioctl after an -EPIPE (XRUN). > > > > A possible reproduction may look like the following reduced call graph > > during a PCM capture: > > > > us -> ioctl(SNDRV_PCM_IOCTL_READI_FRAMES) > > - wait_for_avail() > > - schedule_timeout() > > -> snd_pcm_update_hw_ptr0() > > - snd_pcm_update_state: EPIPE (XRUN) > > - sdma_disable_channel_async() # get's scheduled away due to sleep us > > <- ioctl(SNDRV_PCM_IOCTL_READI_FRAMES) returns -EPIPE > > us -> ioctl(SNDRV_PCM_IOCTL_PREPARE) # as reaction to the EPIPE (XRUN) > > us -> ioctl(SNDRV_PCM_IOCTL_READI_FRAMES) # next try to capture frames > > - sdma_prep_dma_cyclic() > > - sdma_load_context() # not loaded as context_loaded is 1 > > - wait_for_avail() > > - schedule_timeout() > > # now the sdma_channel_terminate_work() comes back and sets # > > context_loaded = false and frees in vchan_dma_desc_free_list(). > > us <- ioctl returns -EIO (capture write error (DMA or IRQ trouble?)) > > Seems the write error caused by context_loaded not set to false before > next transfer start? If yes, please have a try with the 03/04 of the below > patch set, anyway, could you post your failure log? > https://lkml.org/lkml/2020/8/11/111 Thanks for the pointer to those patches. I've tested them on top of the v5.8 tag during the weekend. It seems those patches are mitigiating the described EIO issue. Nonetheless IMHO this patches are not fixing the root cause of the problem (unsynchronized sdma_disable_channel_async / sdma_prep_dma_cyclic). Do you (or somebody else) have any suggestions/comments/objections on that? regards;rl > > > > > > > What we have found out, based on our understanding: > > The dmaengine docu states that a dmaengine_terminate_async() must be > > followed by a dmaengine_synchronize(). > > However, in the pcm_dmaengine.c, only dmaengine_terminate_async() is > > called (for performance reasons and because it might be called from an > > interrupt handler). > > > > In our tests, we saw that the user-space immediately calls > > ioctl(SNDRV_PCM_IOCTL_PREPARE) as a handler for the happened xrun > > (previous ioctl(SNDRV_PCM_IOCTL_READI_FRAMES) returns with -EPIPE). In > > our case (imx-sdma.c), the terminate really happens asynchronously > > with a worker thread which is not awaited/synchronized by the > > ioctl(SNDRV_PCM_IOCTL_PREPARE) call. > > > > Since the syscall immediately enters an atomic context > > (snd_pcm_stream_lock_irq()), we are not able to flush the work of the > > termination worker from within the DMA context. This leads to an > > unterminated DMA getting re-initialized and then terminated. > > > > On the i.MX6 platform the problem is (if I got it correctly) that the > > sdma_channel_terminate_work() called after the -EPIPE gets scheduled > > away (for the 1-2ms sleep [1]). During that time the userspace already > > sends in the > > ioctl(SNDRV_PCM_IOCTL_PREPARE) and > > ioctl(SNDRV_PCM_IOCTL_READI_FRAMES). > > As none of them are anyhow synchronized to the terminate_worker the > > vchan_dma_desc_free_list() [2] and "sdmac->context_loaded = false;" > > [3] are executed during the wait_for_avail() [4] of the > > ioctl(SNDRV_PCM_IOCTL_READI_FRAMES). > > > > To make sure we identified the problem correctly we've tested to add a > > "dmaengine_synchronize()" before the snd_pcm_prepare() in [5]. This > > fixed the race condition in all our tests. (Before we were able to > > reproduce it in 100% of the test runs). > > > > Based on our understanding, there are two different points to ensure > > the > > termination: > > Either ensure that the termination is finished within the previous > > SNDRV_PCM_IOCTL_READI_FRAMES call (inside the DMA context) or > > finishing it in the SNDRV_PCM_IOCTL_PREPARE call (and all other > > applicable ioclts) before entering the atomic context (from the PCM context). > > > > We initially thought about implementing the first approach, basically > > splitting up the dma_device terminate_all operation into a sync > > (busy-wait) and a async one. This would align the operations with the > > DMAengine interface and would enable a sync termination variant from > > atomic contexts. > > However, we saw that the dma_free_attrs() function has a WARN_ON on > > irqs disabled, which would be the case for the sync variant. > > Side note: We found this issue on the current v5.4.y LTS branch, but > > it also affects v5.8.y. > > > > Any feedback or pointers how we may fix the problem are warmly welcome! > > If anything is unclear please just ask :-) > > > > regards; > > Richard Leitner > > Benjamin Bara

1 0

[PATCH v4 0/2] Add mediatek codec mt6359 driver
by Jiaxin Yu 17 Aug '20

17 Aug '20

Add mediatek codec (MT6359) driver MT6359 support playback and capture feature. On downlink path, it includes three DACs for handset, headset, and lineout path. On unlink path, it includeds three ADCs for main mic, second mic, 3rd mic, and headset mic. By scenario, select *_MUX widget to create damp path. And by select mic_type_mux to choose DMIC/AMIC/.... For example, select these MUX widget to create headset path (1) DAC In Mux --> "Normal Path" (2) HP Mux --> "Audio Playback" v4 changes: 1. Add a remove() function to undo regulator_enable(). 2. Removed unnecessary logs. v3 changes: 1. patchwork link: https://patchwork.kernel.org/cover/11714291/ https://patchwork.kernel.org/patch/11714295/ https://patchwork.kernel.org/patch/11714339/ v2 changes: 1. patchwork link: https://patchwork.kernel.org/cover/11706935/ https://patchwork.kernel.org/patch/11708865/ https://patchwork.kernel.org/patch/11706937/ v1 changes: 1.lkml link: https://lkml.org/lkml/2020/3/5/1257 Jiaxin Yu (2): ASoC: mediatek: mt6359: add codec driver dt-bindings: mediatek: mt6359: add codec document .../devicetree/bindings/sound/mt6359.yaml | 68 + sound/soc/codecs/Kconfig | 8 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/mt6359.c | 2755 +++++++++++++++++ sound/soc/codecs/mt6359.h | 2640 ++++++++++++++++ 5 files changed, 5473 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mt6359.yaml create mode 100644 sound/soc/codecs/mt6359.c create mode 100644 sound/soc/codecs/mt6359.h -- 2.18.0

2 3

USB-Audio: Dell-WD15-Dock: make input and output volume adjustable
by GitHub pull_request - opened 17 Aug '20

17 Aug '20

alsa-project/alsa-ucm-conf pull request #47 was opened from jason77-wang: Recently we found the input volume is too low for some specific headset-mic, even we adjust the input volume to max from PA, we still can't record the sound from that headset-mic. That is because we change the input or output volume from PA, but the mixer's volume is not changed, only PA's soft-volume is changed. Checking the amixer controls for this sound card, it supports MixerElem, Volume and Switch, So adding them in the ucm. Signed-off-by: Hui Wang <hui.wang(a)canonical.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/47 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/47.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

HDA-Intel: HiFi-dual: Fix the Rear Mic's Jack name
by GitHub pull_request - opened 17 Aug '20

17 Aug '20

alsa-project/alsa-ucm-conf pull request #46 was opened from jason77-wang: On the LENOVO P520 (dual codecs machine), the Jack name of Rear Mic is "Rear Mic Jack" instead of "Mic Jack". Below is picked from alsa-info.txt on the LENOVO p520 machine: control.18 { iface CARD name 'Rear Mic Jack' value true comment { access read type BOOLEAN count 1 } } Signed-off-by: Hui Wang <hui.wang(a)canonical.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/46 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/46.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v2] soundwire: SDCA: detect sdca_cascade interrupt
by Bard Liao 16 Aug '20

16 Aug '20

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> The SoundWire 1.2 specification defines an "SDCA cascade" bit which handles a logical OR of all SDCA interrupt sources (up to 30 defined). Due to limitations of the addressing space, this bit is located in the SDW_DP0_INT register when DP0 is used, or alternatively in the DP0_SDCA_Support_INTSTAT register when DP0 is not used. To allow for both cases to be handled, this bit will be checked in the main device-level interrupt handling code. This will result in the register being read twice if DP0 is enabled, but it's not clear how to optimize this case. It's also more logical to deal with this interrupt at the device than the port level, this bit is really not DP0 specific and its location in the DP0_INTSTAT bit is only due to the lack of free space in SCP_INTSTAT_1. The SDCA_Cascade bit cannot be masked or cleared, so the interrupt handling only forwards the detection to the Slave driver, which will deal with reading the relevant SDCA status bits and clearing them. The bus driver only signals the detection. The communication with the Slave driver is based on the same interrupt callback, with only an extension to provide the status of the sdca_cascade bit. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- Changelog: v2: - Re-read SDW_DP0_INT while reading status again. --- drivers/soundwire/bus.c | 28 +++++++++++++++++++++++++++- include/linux/soundwire/sdw.h | 4 ++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index e6e0fb9a81b4..d254c23201b9 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1361,6 +1361,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) int port_num, stat, ret, count = 0; unsigned long port; bool slave_notify = false; + u8 sdca_cascade = 0; u8 buf, buf2[2], _buf, _buf2[2]; sdw_modify_slave_status(slave, SDW_SLAVE_ALERT); @@ -1388,6 +1389,16 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) goto io_err; } + if (slave->prop.is_sdca) { + ret = sdw_read(slave, SDW_DP0_INT); + if (ret < 0) { + dev_err(slave->bus->dev, + "SDW_DP0_INT read failed:%d\n", ret); + goto io_err; + } + sdca_cascade = ret & SDW_DP0_SDCA_CASCADE; + } + do { /* * Check parity, bus clash and Slave (impl defined) @@ -1416,6 +1427,10 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) slave_notify = true; } + /* the SDCA interrupts are cleared in the codec driver .interrupt_callback() */ + if (sdca_cascade) + slave_notify = true; + /* Check port 0 - 3 interrupts */ port = buf & SDW_SCP_INT1_PORT0_3; @@ -1453,6 +1468,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) /* Update the Slave driver */ if (slave_notify && slave->ops && slave->ops->interrupt_callback) { + slave_intr.sdca_cascade = sdca_cascade; slave_intr.control_port = clear; memcpy(slave_intr.port, &port_status, sizeof(slave_intr.port)); @@ -1487,11 +1503,21 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) goto io_err; } + if (slave->prop.is_sdca) { + ret = sdw_read(slave, SDW_DP0_INT); + if (ret < 0) { + dev_err(slave->bus->dev, + "SDW_DP0_INT read failed:%d\n", ret); + goto io_err; + } + sdca_cascade = ret & SDW_DP0_SDCA_CASCADE; + } + /* Make sure no interrupts are pending */ buf &= _buf; buf2[0] &= _buf2[0]; buf2[1] &= _buf2[1]; - stat = buf || buf2[0] || buf2[1]; + stat = buf || buf2[0] || buf2[1] || sdca_cascade; /* * Exit loop if Slave is continuously in ALERT state even diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h index 76052f12c9f7..a51494646a2c 100644 --- a/include/linux/soundwire/sdw.h +++ b/include/linux/soundwire/sdw.h @@ -355,6 +355,7 @@ struct sdw_dpn_prop { * @dp0_prop: Data Port 0 properties * @src_dpn_prop: Source Data Port N properties * @sink_dpn_prop: Sink Data Port N properties + * @is_sdca: the Slave supports the SDCA specification */ struct sdw_slave_prop { u32 mipi_revision; @@ -376,6 +377,7 @@ struct sdw_slave_prop { struct sdw_dp0_prop *dp0_prop; struct sdw_dpn_prop *src_dpn_prop; struct sdw_dpn_prop *sink_dpn_prop; + bool is_sdca; }; /** @@ -465,10 +467,12 @@ struct sdw_slave_id { /** * struct sdw_slave_intr_status - Slave interrupt status + * @sdca_cascade: set if the Slave device reports an SDCA interrupt * @control_port: control port status * @port: data port status */ struct sdw_slave_intr_status { + bool sdca_cascade; u8 control_port; u8 port[15]; }; -- 2.17.1

1 0

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files
by Sam Ravnborg 16 Aug '20

16 Aug '20

Hi Rob. On Wed, Aug 12, 2020 at 02:36:18PM -0600, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding > keyword. > > Found with yamllint (which I plan to integrate into the checks). I have browsed through the patch - and there was only a few things that jumped at me. With these points considered: Acked-by: Sam Ravnborg <sam(a)ravnborg.org> I expect only some (few) of my points to actually results in any updates. I look forward to have the lint functionality as part of the built-in tools so we catch these things early. Sam > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index f63895c8ce2d..88814a2a14a5 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -273,8 +273,8 @@ properties: > - fsl,imx6ull-14x14-evk # i.MX6 UltraLiteLite 14x14 EVK Board > - kontron,imx6ull-n6411-som # Kontron N6411 SOM > - myir,imx6ull-mys-6ulx-eval # MYiR Tech iMX6ULL Evaluation Board > - - toradex,colibri-imx6ull-eval # Colibri iMX6ULL Module on Colibri Evaluation Board > - - toradex,colibri-imx6ull-wifi-eval # Colibri iMX6ULL Wi-Fi / Bluetooth Module on Colibri Evaluation Board > + - toradex,colibri-imx6ull-eval # Colibri iMX6ULL Module on Colibri Eval Board > + - toradex,colibri-imx6ull-wifi-eval # Colibri iMX6ULL Wi-Fi / BT Module on Colibri Eval Board > - const: fsl,imx6ull This change looks bad as it drops the alignment with the comments below. See following patch chunck: > > - description: Kontron N6411 S Board > @@ -312,9 +312,12 @@ properties: > - toradex,colibri-imx7d # Colibri iMX7 Dual Module > - toradex,colibri-imx7d-aster # Colibri iMX7 Dual Module on Aster Carrier Board > - toradex,colibri-imx7d-emmc # Colibri iMX7 Dual 1GB (eMMC) Module > - - toradex,colibri-imx7d-emmc-aster # Colibri iMX7 Dual 1GB (eMMC) Module on Aster Carrier Board > - - toradex,colibri-imx7d-emmc-eval-v3 # Colibri iMX7 Dual 1GB (eMMC) Module on Colibri Evaluation Board V3 > - - toradex,colibri-imx7d-eval-v3 # Colibri iMX7 Dual Module on Colibri Evaluation Board V3 > + - toradex,colibri-imx7d-emmc-aster # Colibri iMX7 Dual 1GB (eMMC) Module on > + # Aster Carrier Board > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml > index 177d48c5bd97..e89c1ea62ffa 100644 > --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml > @@ -25,8 +25,7 @@ properties: > compatible: > items: > - enum: > - - dlink,dir-685-panel > - > + - dlink,dir-685-panel > - const: ilitek,ili9322 > > reset-gpios: true > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml > index a39332276bab..76a9068a85dd 100644 > --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml > @@ -13,8 +13,7 @@ properties: > compatible: > items: > - enum: > - - bananapi,lhr050h41 > - > + - bananapi,lhr050h41 > - const: ilitek,ili9881c > The extra lines is a simple way to indicate that here shall be added more in the future. So I like the empty line. > diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > index 32e0896c6bc1..47938e372987 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > @@ -79,7 +79,8 @@ properties: > description: | > kHz; switching frequency. > $ref: /schemas/types.yaml#/definitions/uint32 > - enum: [ 600, 640, 685, 738, 800, 872, 960, 1066, 1200, 1371, 1600, 1920, 2400, 3200, 4800, 9600 ] > + enum: [ 600, 640, 685, 738, 800, 872, 960, 1066, 1200, 1371, 1600, 1920, > + 2400, 3200, 4800, 9600 ] > > qcom,ovp: > description: | In the modern world we are living in now line length of 100 chars are OK. checkpatch and coding_style is updated to reflected this. > diff --git a/Documentation/devicetree/bindings/spi/mikrotik,rb4xx-spi.yaml b/Documentation/devicetree/bindings/spi/mikrotik,rb4xx-spi.yaml > index 4ddb42a4ae05..9102feae90a2 100644 > --- a/Documentation/devicetree/bindings/spi/mikrotik,rb4xx-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/mikrotik,rb4xx-spi.yaml > @@ -33,4 +33,5 @@ examples: > reg = <0x1f000000 0x10>; > }; > > -... > \ No newline at end of file > +... > + Added one line too much? diff --git a/Documentation/devicetree/bindings/spi/spi-mux.yaml b/Documentation/devicetree/bindings/spi/spi-mux.yaml > index 0ae692dc28b5..3d3fed63409b 100644 > --- a/Documentation/devicetree/bindings/spi/spi-mux.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-mux.yaml > @@ -43,47 +43,47 @@ properties: > maxItems: 1 > > required: > - - compatible > - - reg > - - spi-max-frequency > - - mux-controls > + - compatible > + - reg > + - spi-max-frequency > + - mux-controls > > examples: > - - | > - #include <dt-bindings/gpio/gpio.h> > - mux: mux-controller { > - compatible = "gpio-mux"; > - #mux-control-cells = <0>; > + - | > + #include <dt-bindings/gpio/gpio.h> > + mux: mux-controller { > + compatible = "gpio-mux"; > + #mux-control-cells = <0>; > > - mux-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>; > - }; > + mux-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>; > + }; Example is updated to use 4-space indent. I like. But many other examples are left untouched. So I wonder if updating all examples to the same indent should be left for another mega-patch? > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index f3d847832fdc..2baee2c817c1 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -993,7 +993,8 @@ patternProperties: > "^sst,.*": > description: Silicon Storage Technology, Inc. > "^sstar,.*": > - description: Xiamen Xingchen(SigmaStar) Technology Co., Ltd. (formerly part of MStar Semiconductor, Inc.) > + description: Xiamen Xingchen(SigmaStar) Technology Co., Ltd. > + (formerly part of MStar Semiconductor, Inc.) > "^st,.*": > description: STMicroelectronics > "^starry,.*": Did you check that they are all in alphabetical order? I would be suprised if this is the only issue in this file.

3 2