- Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: pcm3168a: ignore 0 Hz settings
by Kuninori Morimoto 25 Aug '20

25 Aug '20

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Some sound card try to set 0 Hz as reset, but it is impossible. This patch ignores it to avoid error return. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/codecs/pcm3168a.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 9711fab296eb..045c6f8b26be 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -306,6 +306,13 @@ static int pcm3168a_set_dai_sysclk(struct snd_soc_dai *dai, struct pcm3168a_priv *pcm3168a = snd_soc_component_get_drvdata(dai->component); int ret; + /* + * Some sound card sets 0 Hz as reset, + * but it is impossible to set. Ignore it here + */ + if (freq == 0) + return 0; + if (freq > PCM3168A_MAX_SYSCLK) return -EINVAL; -- 2.25.1

2 2

[PATCH 0/8] ASoC: SOF: trivial code/log/comment improvements
by Pierre-Louis Bossart 25 Aug '20

25 Aug '20

Remove useless variable initialization and allocation, adjust log levels to make support easier, and fix comments. No functional changes. Guennadi Liakhovetski (2): ASoC: SOF: topology: (cosmetic) remove redundant variable initialisations ASoC: SOF: (cosmetic) use the "bool" type where it makes sense Pierre-Louis Bossart (4): ASoC: SOF: IPC: reduce verbosity of IPC pointer updates ASoC: SOF: acpi: add dev_dbg() log for probe completion ASoC: SOF: Intel: add dev_dbg log when driver is not selected ASoC: Intel: use consistent HDAudio spelling in comments/docs Ranjani Sridharan (2): ASoC: SOF: topology: remove unnecessary memory alloc for sdev->private ASoC: SOF: topology: reduce the log level for unhandled widgets include/sound/soc-acpi.h | 2 +- sound/soc/intel/Kconfig | 2 +- sound/soc/intel/skylake/skl.c | 6 +++--- sound/soc/sof/Kconfig | 2 +- sound/soc/sof/intel/Kconfig | 2 +- sound/soc/sof/ipc.c | 16 +++++++++++----- sound/soc/sof/pcm.c | 8 ++++---- sound/soc/sof/sof-acpi-dev.c | 2 ++ sound/soc/sof/sof-pci-dev.c | 6 +++--- sound/soc/sof/sof-priv.h | 10 +++++----- sound/soc/sof/topology.c | 20 ++++---------------- 11 files changed, 36 insertions(+), 40 deletions(-) base-commit: aafdeba5cbc14cecee3797e669473b70a2b3e81e -- 2.25.1

2 9

[PATCH] ASoC: hdac_hdmi: tidy up a memset()
by Dan Carpenter 25 Aug '20

25 Aug '20

The ARRAY_SIZE() is the number of the elements but we want to use the number of bytes. Fortunately, in this case the value is the same so it doesn't affect runtime. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/soc/codecs/hdac_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 869d1547ae5d..c61cce53f513 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -1474,7 +1474,7 @@ static int hdac_hdmi_eld_ctl_get(struct snd_kcontrol *kcontrol, struct hdac_hdmi_port *port; struct hdac_hdmi_eld *eld; - memset(ucontrol->value.bytes.data, 0, ARRAY_SIZE(ucontrol->value.bytes.data)); + memset(ucontrol->value.bytes.data, 0, sizeof(ucontrol->value.bytes.data)); pcm = get_hdmi_pcm_from_id(hdmi, kcontrol->id.device); if (!pcm) { -- 2.28.0

2 1

[PATCH 0/5]: Qualcomm's lpass-hdmi ASoC driver to support audio over dp port
by Srinivasa Rao 25 Aug '20

25 Aug '20

These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc. It includes machine driver, cpu driver, platform driver updates for HDMI path support, device tree documention, lpass variant structure optimization and configuration changes. These patches depends on the DP patch series https://patchwork.kernel.org/project/dri-devel/list/?series=332029 vsujithk (5): dt-bindings: Add sc7180-lpass HDMI header define dt-bindings: Add dts entry for lpass-hdmi dp audio ASoC: qcom: add support for lpass hdmi driver ASoC: qcom: Add support for audio over DP Optimise lpass variant structure .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 42 ++ include/dt-bindings/sound/sc7180-lpass.h | 1 + sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/lpass-apq8016.c | 25 +- sound/soc/qcom/lpass-cpu.c | 92 ++- sound/soc/qcom/lpass-hdmi.c | 685 +++++++++++++++++++++ sound/soc/qcom/lpass-hdmi.h | 129 ++++ sound/soc/qcom/lpass-ipq806x.c | 25 +- sound/soc/qcom/lpass-lpaif-reg.h | 51 +- sound/soc/qcom/lpass-platform.c | 287 +++++++-- sound/soc/qcom/lpass-sc7180.c | 147 ++++- sound/soc/qcom/lpass.h | 123 +++- 13 files changed, 1467 insertions(+), 147 deletions(-) create mode 100644 sound/soc/qcom/lpass-hdmi.c create mode 100644 sound/soc/qcom/lpass-hdmi.h -- 2.7.4

2 7

[PATCH v5 0/2] Add documentation and machine driver for SC7180 sound card
by Cheng-Yi Chiang 25 Aug '20

25 Aug '20

Note: - The machine driver patch depends on LPASS patch series so it is not ready to be merged now. ASoC: qcom: Add support for SC7180 lpass variant https://patchwork.kernel.org/cover/11714317/ - The machine driver patch is made by the collaboration of Cheng-Yi Chiang <cychiang(a)chromium.org> Rohit kumar <rohitkr(a)codeaurora.org> Ajit Pandey <ajitp(a)codeaurora.org> But Ajit has left codeaurora. Changes from v1 to v2: - Ducumentation: Addressed all suggestions from Doug. - Machine driver: - Fix comment style for license. - Sort includes. - Remove sc7180_snd_hw_params. - Remove sc7180_dai_init and use aux device instead for headset jack registration. - Statically define format for Primary MI2S. - Atomic is not a concern because there is mutex in card to make sure startup and shutdown happen sequentially. - Fix missing return -EINVAL in startup. - Use static sound card. - Use devm_kzalloc to avoid kfree. Changes from v2 to v3: - Ducumentation: Addressed suggestions from Srini. - Machine driver: - Reuse qcom_snd_parse_of to parse properties. - Remove playback-only and capture-only. - Misc fixes to address comments. Changes from v3 to v4: - Ducumentation: Addressed suggestions from Rob. - Remove definition of dai. - Use 'sound-dai: true' for sound-dai schema. - Add reg property to pass 'make dt_binding_check' check although reg is not used in the driver. - Machine driver: - Add Reviewed-by: Tzung-Bi Shih <tzungbi(a)google.com> Changes from v4 to v5: - Documentation: Addressed suggestions from Rob. - Add definition for "#address-cells" and "#size-cells". - Add additionalProperties: false - Add required properties. Ajit Pandey (1): ASoC: qcom: sc7180: Add machine driver for sound card registration Cheng-Yi Chiang (1): ASoC: qcom: dt-bindings: Add sc7180 machine bindings .../bindings/sound/qcom,sc7180.yaml | 127 +++++++++ sound/soc/qcom/Kconfig | 12 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/sc7180.c | 244 ++++++++++++++++++ 4 files changed, 385 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml create mode 100644 sound/soc/qcom/sc7180.c -- 2.28.0.220.ged08abb693-goog

2 3

[PATCH] Add implicit feedback quirk for UR22C
by Joshua Sivec 25 Aug '20

25 Aug '20

This uses the same quirk as the Motu and SSL2 devices. Tested on the UR22C. Fixes bug 208851. Signed-off-by: Joshua Sivec <sivec(a)posteo.net> --- sound/usb/pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index 5600751803cf..10d342270dd9 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -369,6 +369,7 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs, case USB_ID(0x07fd, 0x0008): /* MOTU M Series */ case USB_ID(0x31e9, 0x0001): /* Solid State Logic SSL2 */ case USB_ID(0x31e9, 0x0002): /* Solid State Logic SSL2+ */ + case USB_ID(0x0499, 0x172f): /* Steinberg UR22C */ case USB_ID(0x0d9a, 0x00df): /* RTX6001 */ ep = 0x81; ifnum = 2; -- 2.26.2

2 1

[PATCH] Revert "ALSA: hda: Add support for Loongson 7A1000 controller"
by Tiezhu Yang 25 Aug '20

25 Aug '20

This reverts commit 61eee4a7fc40 ("ALSA: hda: Add support for Loongson 7A1000 controller"). With this patch, there exists the following error on the Loongson LS7A platform: [ 216.639938] rcu: INFO: rcu_preempt self-detected stall on CPU [ 216.645685] rcu: 0-....: (1 GPs behind) idle=d5a/1/0x4000000000000004 softirq=562/563 fqs=16476 [ 216.654565] (t=53772 jiffies g=-463 q=11976) [ 216.658923] NMI backtrace for cpu 0 [ 216.662417] CPU: 0 PID: 68 Comm: kworker/0:2 Not tainted 5.8.0+ #3 [ 216.668587] Hardware name: , BIOS [ 216.672174] Workqueue: events azx_probe_work [snd_hda_intel] [ 216.677829] Stack : 0000000000000000 0000000000000000 ffffffff95004ce0 d786f9efa2288403 [ 216.685848] d786f9efa2288403 0000000000000000 98000001102638c8 ffffffff80cee270 [ 216.693866] 0000000000000000 0000000000000000 0000000000000000 00000000000002b4 [ 216.701883] 206b726f775f6562 0000000000000001 0000000000000000 ffffffff80f30000 [ 216.709902] ffffffff80f30000 ffffffff80d90000 0000000000000000 0000000000000000 [ 216.717919] 0000000000000000 0000000000000000 0000000000000000 ffffffff80d90000 [ 216.725937] ffffffff80d90000 0000000000000007 ffffffff806aff18 0000000000000000 [ 216.733955] ffffffff80f00000 9800000110cc4000 98000001102638c0 ffffffff80d9db80 [ 216.741974] ffffffff8065a740 0000000000000000 0000000000000000 0000000000000000 [ 216.749991] 000073746e657665 0000000000000000 ffffffff80211a64 d786f9efa2288403 [ 216.758009] ... [ 216.760464] Call Trace: [ 216.762920] [<ffffffff80211a64>] show_stack+0x9c/0x130 [ 216.768058] [<ffffffff8065a740>] dump_stack+0xb0/0xf0 [ 216.773110] [<ffffffff80665774>] nmi_cpu_backtrace+0x134/0x140 [ 216.778939] [<ffffffff80665910>] nmi_trigger_cpumask_backtrace+0x190/0x200 [ 216.785805] [<ffffffff802b1abc>] rcu_dump_cpu_stacks+0x12c/0x190 [ 216.791806] [<ffffffff802b08cc>] rcu_sched_clock_irq+0xa2c/0xfc8 [ 216.797808] [<ffffffff802b91d4>] update_process_times+0x2c/0xb8 [ 216.803724] [<ffffffff802cad80>] tick_sched_timer+0x40/0xb8 [ 216.809293] [<ffffffff802ba5f0>] __hrtimer_run_queues+0x118/0x1d0 [ 216.815380] [<ffffffff802bab74>] hrtimer_interrupt+0x12c/0x2d8 [ 216.821208] [<ffffffff8021547c>] c0_compare_interrupt+0x74/0xa0 [ 216.827124] [<ffffffff80296bd0>] __handle_irq_event_percpu+0xa8/0x198 [ 216.833558] [<ffffffff80296cf0>] handle_irq_event_percpu+0x30/0x90 [ 216.839732] [<ffffffff8029d958>] handle_percpu_irq+0x88/0xb8 [ 216.845388] [<ffffffff80296124>] generic_handle_irq+0x44/0x60 [ 216.851131] [<ffffffff80b3cfd0>] do_IRQ+0x18/0x28 [ 216.855838] [<ffffffff8067ace4>] plat_irq_dispatch+0x64/0x100 [ 216.861579] [<ffffffff80209a20>] handle_int+0x140/0x14c [ 216.866802] [<ffffffff802402e8>] irq_exit+0xf8/0x100 This is because AZX_DRIVER_GENERIC can not work well for Loongson LS7A HDA controller, it needs some workarounds which are not merged into the upstream kernel, so it should revert this patch now. There will be a better solution that has been tested carefully to support Loongson LS7A HDA controller. Fixes: 61eee4a7fc40 ("ALSA: hda: Add support for Loongson 7A1000 controller") Cc: <stable(a)vger.kernel.org> # 5.9-rc1+ Signed-off-by: Tiezhu Yang <yangtiezhu(a)loongson.cn> --- sound/pci/hda/hda_intel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index e34a4d5..0f86e37 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2745,8 +2745,6 @@ static const struct pci_device_id azx_ids[] = { .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_ATI_HDMI }, /* Zhaoxin */ { PCI_DEVICE(0x1d17, 0x3288), .driver_data = AZX_DRIVER_ZHAOXIN }, - /* Loongson */ - { PCI_DEVICE(0x0014, 0x7a07), .driver_data = AZX_DRIVER_GENERIC }, { 0, } }; MODULE_DEVICE_TABLE(pci, azx_ids); -- 2.1.0

2 2

[PATCH 0/2] Tegra HDA specific fixes
by Mohan Kumar 25 Aug '20

25 Aug '20

This series has the fix for - 2 Channel swapping issue for Tegra - WAKEEN programming to detect wake events. Mohan Kumar (2): ALSA: hda: Fix 2 channel swapping for Tegra ALSA: hda/tegra: Program WAKEEN register for Tegra sound/pci/hda/hda_tegra.c | 7 +++++++ sound/pci/hda/patch_hdmi.c | 5 +++++ 2 files changed, 12 insertions(+) -- 2.17.1

3 5

[PATCH] ALSA: ca0106: fix error code handling
by Tong Zhang 25 Aug '20

25 Aug '20

snd_ca0106_spi_write() returns 1 on error, snd_ca0106_pcm_power_dac() is returning the error code directly, and the caller is expecting an negative error code Signed-off-by: Tong Zhang <ztong0001(a)gmail.com> --- sound/pci/ca0106/ca0106_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c index 70d775ff967e..c189f70c82cb 100644 --- a/sound/pci/ca0106/ca0106_main.c +++ b/sound/pci/ca0106/ca0106_main.c @@ -537,7 +537,8 @@ static int snd_ca0106_pcm_power_dac(struct snd_ca0106 *chip, int channel_id, else /* Power down */ chip->spi_dac_reg[reg] |= bit; - return snd_ca0106_spi_write(chip, chip->spi_dac_reg[reg]); + if (snd_ca0106_spi_write(chip, chip->spi_dac_reg[reg]) != 0) + return -ENXIO; } return 0; } -- 2.25.1

2 1

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files
by Wolfram Sang 25 Aug '20

25 Aug '20

On Wed, Aug 12, 2020 at 02:36:18PM -0600, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding > keyword. > > Found with yamllint (which I plan to integrate into the checks). > > Cc: linux-arm-kernel(a)lists.infradead.org > Cc: linux-clk(a)vger.kernel.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-spi(a)vger.kernel.org > Cc: linux-gpio(a)vger.kernel.org > Cc: linux-remoteproc(a)vger.kernel.org > Cc: linux-hwmon(a)vger.kernel.org > Cc: linux-i2c(a)vger.kernel.org > Cc: linux-fbdev(a)vger.kernel.org > Cc: linux-iio(a)vger.kernel.org > Cc: linux-input(a)vger.kernel.org > Cc: linux-pm(a)vger.kernel.org > Cc: linux-media(a)vger.kernel.org > Cc: alsa-devel(a)alsa-project.org > Cc: linux-mmc(a)vger.kernel.org > Cc: linux-mtd(a)lists.infradead.org > Cc: netdev(a)vger.kernel.org > Cc: linux-rtc(a)vger.kernel.org > Cc: linux-serial(a)vger.kernel.org > Cc: linux-usb(a)vger.kernel.org > Signed-off-by: Rob Herring <robh(a)kernel.org> I trust you guys in figuring out the details, so for touching I2C: Acked-by: Wolfram Sang <wsa(a)kernel.org>

1 0