- Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: ac97: fix PM reference leak in ac97_bus_remove()
by Yufen Yu 25 May '21

25 May '21

pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Yufen Yu <yuyufen(a)huawei.com> --- sound/ac97/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c index d9077e91382b..6ddf646cda65 100644 --- a/sound/ac97/bus.c +++ b/sound/ac97/bus.c @@ -520,7 +520,7 @@ static int ac97_bus_remove(struct device *dev) struct ac97_codec_driver *adrv = to_ac97_driver(dev->driver); int ret; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) return ret; -- 2.25.4

2 1

[PATCH v2 0/6] ALSA: Prep work for PCI rescan support
by Takashi Iwai 25 May '21

25 May '21

Hi, this is a revised patch set as a prep work for the future-planned PCI rescan support(*). The essential part is the patch to track in-flight tasks, and the rest are cleanups and fixes in the core code. With those changes, the driver can perform a sort of software suspend on the device without the hardware intervention, which is required during the PCI BAR movement, for example. v1->v2: * Move / drop unnecessary snd_power_wait() calls * Rephrase changelogs and comments, reorder patches Takashi (*) https://lore.kernel.org/alsa-devel/e25017c6-e5e4-7a24-e793-14a2e70a434e@amd… === Takashi Iwai (6): ALSA: core: Use READ_ONCE() / WRITE_ONCE() for power state change ALSA: control: Track in-flight control read/write/tlv accesses ALSA: control: Drop superfluous snd_power_wait() calls ALSA: control: Minor optimization for SNDRV_CTL_IOCTL_POWER_STATE ALSA: Drop superfluous argument from snd_power_wait() ALSA: pcm: Block the release until the system resume finishes include/sound/core.h | 50 ++++++++++++++++++++++++++++++++++--- sound/core/control.c | 38 +++++++++++++--------------- sound/core/control_compat.c | 14 +++-------- sound/core/init.c | 46 ++++++++++++++++++++++++++++------ sound/core/pcm_native.c | 6 ++++- sound/soc/soc-core.c | 2 +- sound/usb/usx2y/us122l.c | 2 +- 7 files changed, 113 insertions(+), 45 deletions(-) -- 2.26.2

3 9

[PATCH v2 0/4] ALSA: firewire-lib: drop initial NODATA packets or empty packets
by Takashi Sakamoto 25 May '21

25 May '21

Hi, This patchset is take 2 of my previous one; * https://lore.kernel.org/alsa-devel/20210523124114.272134-1-o-takashi@sakamo… The devices based on BeBoB ASICs or the devices in Tascam FireWire series transfer a batch of NODATA packet or empty packet in initial step of streaming. To avoid processing them, current implementation uses an option to skip processing content of tx packet during some initial cycles. However, the hard-coded number is not enough useful. In 1st patch, ALSA IEC 61883-1/6 packet streaming engine becomes to drop the initial packets. As a result, The tx_init_skip_cycles argument of amdtp_domain_start() function changes its meaning. In the following patches, ALSA bebob driver is refactored. Changes from v1: * Fix -Wunused-but-set-variable warning reported by 0day-ci * Add 2nd patch to obsolete unused member of structure Takashi Sakamoto (4): ALSA: firewire-lib: drop initial NODATA or empty packet ALSA: firewire-lib: obsolete callbacked member ALSA: bebob: cancel switching connection order ALSA: bebob: distinguish M-Audio ProFire Lightbridge quirk sound/firewire/amdtp-stream.c | 145 +++++++++++++++++++--------- sound/firewire/amdtp-stream.h | 6 +- sound/firewire/bebob/bebob.c | 10 +- sound/firewire/bebob/bebob.h | 1 + sound/firewire/bebob/bebob_stream.c | 25 ++--- 5 files changed, 122 insertions(+), 65 deletions(-) -- 2.27.0

2 5

[PATCH v2 0/2] Unify NVIDIA Tegra ASoC machine drivers
by Dmitry Osipenko 25 May '21

25 May '21

During review of the RT5631 machine driver, Jon Hunter suggested that it will be better to squash all the current ASoC machine drivers into a single one. This suggestion is implemented by this patchset. The RT5631 support will come later with the ASUS Transformer changes. This series needs to be approved by Jaroslav Kysela before it can be merged. Changelog: v2: - Dropped use of of_device_compatible_match(), like it was suggested by Rob Herring in a review comment to v1. - Added patch that sets card's driver_name of as Tegra ASoC drivers. In a comment to v1 Jaroslav Kysela suggested that the Tegra drivers don't set the card name properly and he was right. I opened pull request with the new Tegra UCMs and updated lookup paths for older UCMs [1]. [1] https://github.com/alsa-project/alsa-ucm-conf/pull/92 Dmitry Osipenko (2): ASoC: tegra: Set driver_name=tegra for all machine drivers ASoC: tegra: Unify ASoC machine drivers sound/soc/tegra/Kconfig | 12 + sound/soc/tegra/Makefile | 18 +- sound/soc/tegra/tegra_alc5632.c | 259 ---------- sound/soc/tegra/tegra_asoc_machine.c | 732 +++++++++++++++++++++++++++ sound/soc/tegra/tegra_asoc_machine.h | 45 ++ sound/soc/tegra/tegra_max98090.c | 276 ---------- sound/soc/tegra/tegra_rt5640.c | 222 -------- sound/soc/tegra/tegra_rt5677.c | 324 ------------ sound/soc/tegra/tegra_sgtl5000.c | 211 -------- sound/soc/tegra/tegra_wm8753.c | 185 ------- sound/soc/tegra/tegra_wm8903.c | 357 +++---------- sound/soc/tegra/tegra_wm9712.c | 166 ------ sound/soc/tegra/trimslice.c | 172 ------- 13 files changed, 862 insertions(+), 2117 deletions(-) delete mode 100644 sound/soc/tegra/tegra_alc5632.c create mode 100644 sound/soc/tegra/tegra_asoc_machine.c create mode 100644 sound/soc/tegra/tegra_asoc_machine.h delete mode 100644 sound/soc/tegra/tegra_max98090.c delete mode 100644 sound/soc/tegra/tegra_rt5640.c delete mode 100644 sound/soc/tegra/tegra_rt5677.c delete mode 100644 sound/soc/tegra/tegra_sgtl5000.c delete mode 100644 sound/soc/tegra/tegra_wm8753.c delete mode 100644 sound/soc/tegra/tegra_wm9712.c delete mode 100644 sound/soc/tegra/trimslice.c -- 2.30.2

4 14

RE: Re: [PATCH] ALSA: pcm: Need to check whether runtime is valid or not
by EUNWOO KIM 25 May '21

25 May '21

> > > Sender : Takashi Iwai <tiwai(a)suse.de> > > > Date : 2021-05-12 16:08 (GMT+9) > > > Title : Re: [PATCH] ALSA: pcm: Need to check whether runtime is v alid or not > > > > > > On Wed, 12 May 2021 06:43:23 +0200, > > > Chanho Park wrote: > > > > > > > > From: eunwoo kim <ew.kim(a)samsung.com> > > > > > > > > Since snd_pcm_ioctl_sw_params_compat has no runtime variable ch eck, > > > > if application call the ioctl after close, it can make kernel c rash. > > > > So, snd_pcm_ioctl_sw_params_compat needs to check the runtime v ariable > > > > at the beginning of the function. > > > > > > > In principle, you cannot call ioctl for an already closed file. > > > > Or do you mean other code path? > > > > > > Yes, other code path such as application layer or alsa framwork l ayer. > > > > But how can it go over the 32bit compat ioctl layer...? > > It's always tied with a file object, so the runtime object is > > assured. > > > > > > Yes, I think so too. but in fact, some case can call 32bit comp at ioctl. > > > > > In our case, suspend call is releasing all running pcm device. ot her side some application want to start music. > > > it make critical section between suspend and pcm_open from applic ation. > > > this is error and we have to solve this problem without this patc h. > > > but I think kernel don't make kernel crash even if application or system architecture have problem. > > > > I guess you're scratching a wrong surface. > > > > > could you tell me more detail? why do you think that. > > > In 64bit native case, it didn't make kernel crash on same test ca se. because native always check runtime in ioctl. > > > Try to put WARN_ON() there. If you can catch the real case, it'd b e > > worth to merge. Otherwise, it's just a wrong place to look at. > > I already found root cause in our issue case. And I am fixing this is sue via changing sequence. > > I think that you want to know issue case because why this patch need. > So I explain more about our case. > 1. application playback sound in android. > 2. call pcm_open in tinyalsa. > 3. call file open and hw param in pcm_open > 4. go to suspend > 5. freezing all task before calling sw param in pcm_open. > 6. kernel layer try to go suspend > 7. release all running substream, because all HW IPs must to go idle for power save mode. > -> detach runtime from substream. > 8. go to resume. > 9. call sw param in pcm_open. > 10-1. native case : has runtime check in ioctl -> return error -> aud io hal layer recovery hw connect. > 10-2. 32bit compat case : has not runtime check -> runtime is not val id -> make kernel crash. > > - if AAOS can support wakelock, we can postpone suspend until finishe d pcm_open. but AAOS didn't support wakelock. > I'm afraid that the approach is wrong. It breaks the fundamental PCM > state change rule. Yes, that is wrong approach I know. So I am changing that. > I guess it's a downstream driver that does that? If so, tweaking > something superfluous in the upstream code is unacceptable. > BTW, if you want further discussions, please don't drop Cc to > alsa-devel ML. Safety is very important in automotive. so it must not to make kernel crash even if someone make wrong code. because it can connect to accident. If 32bit compat don't need checking-runtime, why do pcm_native check runtime? thanks, Takashi [update?userid=ew.kim&do=bWFpbElEPTIwMjEwNTE5MjMxNjE1ZXBjbXMycDE4Y2NlMT Q1YzJhOWMwZDk5ZmViZjMxNDBjMTY3ZDIyNiZyZWNpcGllbnRBZGRyZXNzPWFsc2EtZGV2Z WxAYWxzYS1wcm9qZWN0Lm9yZw__]

3 3

[RFC] ALSA: hda: Add Lenovo ThinkStation P340 to power_save_denylist
by Peter Ujfalusi 25 May '21

25 May '21

On playback start there is a huge plock/pop noise via the green jack used in Line out mode. The only way I was able to fix it to set the power_save to 0 for the snd_hda_intel. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> --- Hi Takashi, ever since I have this workstation the plock/pop noise on playback start bugged me. So far the only solution I have found is to disable the power_save which I find acceptable on a desktop compared to the pops. The alsa-info.sh output is can be found here: http://alsa-project.org/db/?f=414b1b236fc73db386ad4f938bc3b304f6b30b05 The machine have ALC623 codec and the jacks are correctly discovered and they do what they supposed to be. When I have the headset connected to the front and audio is routed there the line out (green jack) from the back still prodices the plock/pop. Is there a known quirk for similar issue or a better way to handle it? Thanks you, Peter Ujfalusi sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 79ade335c8a0..e16d93d8291f 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2213,6 +2213,8 @@ static const struct snd_pci_quirk power_save_denylist[] = { SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0), /* https://bugs.launchpad.net/bugs/1821663 */ SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0), + /* Loud pluck/pop noise via the green jack on playback start */ + SND_PCI_QUIRK(0x8086, 0x06c8, "Lenovo ThinkStation P340", 0), {} }; #endif /* CONFIG_PM */ -- 2.31.1

2 1

[PATCH 00/10] Documentation build warning fixes
by Mauro Carvalho Chehab 25 May '21

25 May '21

Hi Jon, This small series contain a series of fixes for the documentation. it is against your docs-next branch. Three of the patches fix duplicated symbols at the ABI documents. There are still some ABI warnings from IIO, but all but one were already fixed at linux-next. So, hopefully, after having everything merged, the ABI warnings will be solved. Mauro Carvalho Chehab (10): docs: update sysfs-platform_profile.rst reference docs: vcpu-requests.rst: fix reference for atomic ops docs: translations/zh_CN: fix a typo at 8.Conclusion.rst docs: sched-bwc.rst: fix a typo on a doc name docs: update pin-control.rst references docs: virt: api.rst: fix a pointer to SGX documentation docs: ABI: iommu: remove duplicated definition for sysfs-kernel-iommu_groups docs: ABI: sysfs-class-backlight: unify ambient light zone nodes docs: ABI: sysfs-class-led-trigger-pattern: remove repeat duplication iio: documentation: fix a typo Documentation/ABI/testing/sysfs-bus-iio | 4 +- .../ABI/testing/sysfs-class-backlight | 100 ++++++++++++++++++ .../ABI/testing/sysfs-class-backlight-adp5520 | 31 ------ .../ABI/testing/sysfs-class-backlight-adp8860 | 37 ------- .../sysfs-class-backlight-driver-adp8870 | 32 ------ .../testing/sysfs-class-led-driver-el15203000 | 9 -- .../testing/sysfs-class-led-trigger-pattern | 3 + .../ABI/testing/sysfs-kernel-iommu_groups | 12 +-- Documentation/scheduler/sched-bwc.rst | 2 +- .../zh_CN/process/8.Conclusion.rst | 2 +- Documentation/virt/kvm/api.rst | 2 +- Documentation/virt/kvm/vcpu-requests.rst | 2 +- include/linux/device.h | 2 +- include/linux/mfd/madera/pdata.h | 2 +- include/linux/pinctrl/pinconf-generic.h | 2 +- include/linux/platform_profile.h | 2 +- 16 files changed, 117 insertions(+), 127 deletions(-) delete mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp5520 delete mode 100644 Documentation/ABI/testing/sysfs-class-backlight-adp8860 delete mode 100644 Documentation/ABI/testing/sysfs-class-backlight-driver-adp8870 delete mode 100644 Documentation/ABI/testing/sysfs-class-led-driver-el15203000 -- 2.31.1

5 5

[RFC PATCH 0/6] soc-pcm: Add separate snd_pcm_runtime for BEs
by Codrin Ciubotariu 24 May '21

24 May '21

This patchset adds a different snd_pcm_runtime in the BE's substream, replacing the FE's snd_pcm_runtime. With a different structure, the BE HW capabilities and constraints will no longer merge with the FE ones. This allows for error detection if the be_hw_params_fixup() applies HW parameters not supported by the BE DAIs. Also, it calculates values needed for mem-to-dev/dev-to-mem DMA transfers, such as buffer size and period size, if needed. The first 4 patches are preparatory patches, that just group and export functions used to allocate and initialize the snd_pcm_runtime. Also, the functions that set and apply the HW constraints are exported. The 5th patch does (almost) everything need to create the new snd_pcm_runtime for BEs, which includes allocation, initializing the HW capabilities, HW constraints and HW parameters. The BE HW parameters are no longer copied from the FE. They are recalculated, based on HW capabilities, constraints and the be_hw_params_fixup() callback. The 6th and last patch basically adds support for the PCM generic dmaengine to be used as a platform driver for BE DAI links. It allocates a buffer, needed by the DMA transfers that do not support dev-to-dev transfers between FE and BE DAIs. This is a superset of https://mailman.alsa-project.org/pipermail/alsa-devel/2021-March/182630.html which only handles the BE HW constraints. This patchset aims to be more complete, defining a a snd_pcm_runtime between each FE and BE and can be used between any DAI link connection. I am sure I am not handling all the needed members of snd_pcm_runtime (such as handling struct snd_pcm_mmap_status *status), but I would like to have your feedback regarding this idea. Codrin Ciubotariu (6): ALSA: core: pcm: Create helpers to allocate/free struct snd_pcm_runtime ALSA: pcm: Export constraints initialization functions ALSA: pcm: Check for substream->ops before substream->ops->mmap ALSA: pcm: Create function for snd_pcm_runtime initialization ASoC: soc-pcm: Create new snd_pcm_runtime for BE DAIs ASoC: dmaengine: Allocate buffer if substream is unmanaged include/sound/pcm.h | 7 ++ sound/core/pcm.c | 82 ++++++++++------- sound/core/pcm_native.c | 116 +++++++++++++----------- sound/soc/soc-generic-dmaengine-pcm.c | 18 ++++ sound/soc/soc-pcm.c | 126 ++++++++++++++++++-------- 5 files changed, 229 insertions(+), 120 deletions(-) -- 2.27.0

3 12

[PATCH v7 0/9] ASoC: codecs: add wcd938x support
by Srinivas Kandagatla 24 May '21

24 May '21

This patchset adds support for Qualcomm WCD938X codec. Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC connected over SoundWire. This device has two SoundWire devices, RX and TX respectively supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH, 7 x TX diff inputs, 8 DMICs and MBHC. Eventhough this device has two SoundWire devices, only tx device has access to main codec Control/Status Registers! For codec driver to be functional it would need both tx and rx Soundwire devices to be up and this is taken care by using device component framework and device-links are used to ensure proper pm dependencies. Ex tx does not enter suspend before rx or codec is suspended. This patchset along with other SoundWire patches on the list have been tested on SM8250 MTP device. Thanks, srini Changes since v6: - Removed unnecessary maxItems from qcom,tx/rx-device property as suggested by RobH. Srinivas Kandagatla (9): ASoC: dt-bindings: wcd938x: add bindings for wcd938x ASoC: codecs: wcd-clsh: add new version support ASoC: codecs: wcd938x: add basic driver ASoC: dt-bindings: wcd938x-sdw: add bindings for wcd938x-sdw ASoC: codecs: wcd938x-sdw: add SoundWire driver ASoC: codecs: wcd938x: add basic controls ASoC: codecs: wcd938x: add playback dapm widgets ASoC: codecs: wcd938x: add capture dapm widgets ASoC: codecs: wcd938x: add audio routing .../bindings/sound/qcom,wcd938x-sdw.yaml | 70 + .../bindings/sound/qcom,wcd938x.yaml | 146 + sound/soc/codecs/Kconfig | 13 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/wcd-clsh-v2.c | 348 +- sound/soc/codecs/wcd-clsh-v2.h | 16 + sound/soc/codecs/wcd938x-sdw.c | 298 ++ sound/soc/codecs/wcd938x.c | 3753 +++++++++++++++++ sound/soc/codecs/wcd938x.h | 705 ++++ 9 files changed, 5343 insertions(+), 10 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x-sdw.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml create mode 100644 sound/soc/codecs/wcd938x-sdw.c create mode 100644 sound/soc/codecs/wcd938x.c create mode 100644 sound/soc/codecs/wcd938x.h -- 2.21.0

2 12

[PATCH AUTOSEL 4.4 05/16] ALSA: sb8: Add a comment note regarding an unused pointer
by Sasha Levin 24 May '21

24 May '21

From: Atul Gopinathan <atulgopinathan(a)gmail.com> [ Upstream commit a28591f61b60fac820c6de59826ffa710e5e314e ] The field "fm_res" of "struct snd_sb8" is never used/dereferenced throughout the sb8.c code. Therefore there is no need for any null value check after the "request_region()". Add a comment note to make developers know about this and prevent any "NULL check" patches on this part of code. Cc: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Atul Gopinathan <atulgopinathan(a)gmail.com> Link: https://lore.kernel.org/r/20210503115736.2104747-36-gregkh@linuxfoundation.… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/isa/sb/sb8.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index 0c7fe1418447..815639c04c52 100644 --- a/sound/isa/sb/sb8.c +++ b/sound/isa/sb/sb8.c @@ -109,7 +109,11 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev) acard = card->private_data; card->private_free = snd_sb8_free; - /* block the 0x388 port to avoid PnP conflicts */ + /* + * Block the 0x388 port to avoid PnP conflicts. + * No need to check this value after request_region, + * as we never do anything with it. + */ acard->fm_res = request_region(0x388, 4, "SoundBlaster FM"); if (!acard->fm_res) { err = -EBUSY; -- 2.30.2

1 0