- Alsa-devel - mailman.alsa-project.org

Re: [PATCH v3 2/4] dt-bindings: sound: bindings for tac5x1x family of codecs
by Holalu Yogendra, Niranjan 27 Jun '25

27 Jun '25

Thanks for quick review. > From: Rob Herring (Arm) <robh(a)kernel.org> > Sent: Friday, June 27, 2025 1:09 AM > To: Holalu Yogendra, Niranjan <niranjan.hy(a)ti.com> > Subject: Re: [PATCH v3 2/4] dt-bindings: sound: bindings for > tac5x1x family of codecs > On Thu, 26 Jun 2025 23:43:31 +0530, Niranjan H Y wrote: > > Documentation/devicetree/bindings/sound/ti,tac5x1x.yaml ... > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Warning: Duplicate compatible "ti,taa5412" found in schemas matching > Warning: Duplicate compatible "ti,taa5212" found in schemas matching > Warning: Duplicate compatible "ti,tad5212" found in schemas matching The duplicate compatible are already removed as part of the patch series in patch [v3,4/4] dt-bindings: sound: device support list for pcm6240 . https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202506261813… Please let me know if still additional action is required. Regards Niranjan H Y

1 1

Re: [PATCH v2 2/4] Asoc: tac5x1x: document tac5x1x codec
by Holalu Yogendra, Niranjan 26 Jun '25

26 Jun '25

Thank you for the time and review comment. > From: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> > Sent: Wednesday, June 25, 2025 8:01 PM > Subject: Re: [PATCH v2 2/4] Asoc: tac5x1x: document tac5x1x codec > > On Tue, Jun 24, 2025 at 09:07:40PM +0530, Niranjan H Y wrote: > > tac5x1x family are series of low-power and high performance > > mono/stereo audio codecs consists of ADC and DAC combinations. > > Aren't DT bindings changes supposed to follow the common template in the > Subject? Is it okay to change the subject in the next patch or keep using the same subject tracking? please suggest. > > More important, the Cc list missed DT mailing lists and maintainers. > What's going on here, please? Pardon my ignorance. I will address in the next patch. Regards Niranjan

1 0

[GIT PULL] ASoC fixes for v6.16-rc3
by Mark Brown 26 Jun '25

26 Jun '25

The following changes since commit 86731a2a651e58953fc949573895f2fa6d456841: Linux 6.16-rc3 (2025-06-22 13:30:08 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.16-rc3 for you to fetch changes up to 6c038b58a2dc5a008c7e7a1297f5aaa4deaaaa7e: ASoC: SOF: Intel: hda: Use devm_kstrdup() to avoid memleak. (2025-06-24 16:39:42 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.16 A small collection of fixes, the main one being a fix for resume from hibernation on AMD systems, plus a few new quirk entries for AMD systems. ---------------------------------------------------------------- Jack Yu (1): ASoC: rt721-sdca: fix boost gain calculation error Luca Weiss (1): ASoC: qcom: sm8250: Fix possibly undefined reference Oliver Schramm (1): ASoC: amd: yc: Add DMI quirk for Lenovo IdeaPad Slim 5 15 Tamura Dai (1): ASoC: SOF: Intel: hda: Use devm_kstrdup() to avoid memleak. Vijendar Mukunda (1): ASoC: amd: ps: fix for soundwire failures during hibernation exit sequence Yuzuru10 (1): ASoC: amd: yc: add quirk for Acer Nitro ANV15-41 internal mic sound/soc/amd/ps/acp63.h | 4 ++++ sound/soc/amd/ps/ps-common.c | 18 ++++++++++++++++++ sound/soc/amd/yc/acp6x-mach.c | 14 ++++++++++++++ sound/soc/codecs/rt721-sdca.c | 23 +++++++++++++++++++---- sound/soc/qcom/Kconfig | 1 + sound/soc/sof/intel/hda.c | 6 +++--- 6 files changed, 59 insertions(+), 7 deletions(-)

2 1

[PATCH 0/2] Add SoundWire machines for ACP7.0/ACP7.1 sof stack
by Vijendar Mukunda 25 Jun '25

25 Jun '25

Add SoundWire machines as alternate machines for ACP7.0 & ACP7.1 platforms with the below machine configuration. Link 0: RT722 codec with three endpoints: Headset, Speaker, and DMIC. Vijendar Mukunda (2): ASoC: amd: acp: add soundwire machine for ACP7.0 and ACP7.1 sof stack ASoC: SOF: amd: add alternate machines for ACP7.0 and ACP7.1 platforms sound/soc/amd/acp/Kconfig | 1 + sound/soc/amd/acp/amd-acp70-acpi-match.c | 12 ++++++++++++ sound/soc/amd/mach-config.h | 1 + sound/soc/sof/amd/pci-acp70.c | 1 + 4 files changed, 15 insertions(+) -- 2.45.2

2 3

ucm2: codecs: lpass-rx-macro: move mixers that do not belong
by GitHub pull_request - opened 25 Jun '25

25 Jun '25

alsa-project/alsa-ucm-conf pull request #585 was opened from Srinivas-Kandagatla: Some of the mixers ended up in rx-macro which actually are part of WCD codecs. Move such mixers to their respective codecs. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/585 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/585.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH REQUEST] No speaker output on HP Spectre with ALC245 unless warm-booted from Windows
by Erik Johnsson 25 Jun '25

25 Jun '25

* PCI-ID: |SUBSYS_103C89DA| * Codec: Realtek ALC245 * Symptom: "No audio via internal speakers unless first booting into Windows" * |alsa-info-sh|: http://alsa-project.org/db/?f=01ca91462e838cf9d54472011a745914ea112c37

1 0

Improvements to Steinberg UR-44 device support
by GitHub pull_request - opened 24 Jun '25

24 Jun '25

alsa-project/alsa-ucm-conf pull request #584 was opened from peterix: - Relabeled the inputs and outputs to make sense considering the device's physical layout and internals - Added one more USB device ID for the UR44 (0x1704 is a non-C variant) - Added stereo inputs in sensible combinations for the various inputs on the device - 1 for inputs 5 & 6 in the back - 3 'adjacent ones' for the 4 inputs in the front - 1 & 2 - 2 & 3 - 3 & 4 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/584 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/584.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: rt721-sdca: fix boost gain calculation error
by Jack Yu 24 Jun '25

24 Jun '25

Fix the boost gain calculation error in rt721_sdca_set_gain_get. This patch is specific for "FU33 Boost Volume". Signed-off-by: Jack Yu <jack.yu(a)realtek.com> --- sound/soc/codecs/rt721-sdca.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt721-sdca.c b/sound/soc/codecs/rt721-sdca.c index 1c9f32e405cf..ba080957e933 100644 --- a/sound/soc/codecs/rt721-sdca.c +++ b/sound/soc/codecs/rt721-sdca.c @@ -430,6 +430,7 @@ static int rt721_sdca_set_gain_get(struct snd_kcontrol *kcontrol, unsigned int read_l, read_r, ctl_l = 0, ctl_r = 0; unsigned int adc_vol_flag = 0; const unsigned int interval_offset = 0xc0; + const unsigned int tendA = 0x200; const unsigned int tendB = 0xa00; if (strstr(ucontrol->id.name, "FU1E Capture Volume") || @@ -439,9 +440,16 @@ static int rt721_sdca_set_gain_get(struct snd_kcontrol *kcontrol, regmap_read(rt721->mbq_regmap, mc->reg, &read_l); regmap_read(rt721->mbq_regmap, mc->rreg, &read_r); - if (mc->shift == 8) /* boost gain */ + if (mc->shift == 8) { + /* boost gain */ ctl_l = read_l / tendB; - else { + } else if (mc->shift == 1) { + /* FU33 boost gain */ + if (read_l == 0x8000 || read_l == 0xfe00) + ctl_l = 0; + else + ctl_l = read_l / tendA + 1; + } else { if (adc_vol_flag) ctl_l = mc->max - (((0x1e00 - read_l) & 0xffff) / interval_offset); else @@ -449,9 +457,16 @@ static int rt721_sdca_set_gain_get(struct snd_kcontrol *kcontrol, } if (read_l != read_r) { - if (mc->shift == 8) /* boost gain */ + if (mc->shift == 8) { + /* boost gain */ ctl_r = read_r / tendB; - else { /* ADC/DAC gain */ + } else if (mc->shift == 1) { + /* FU33 boost gain */ + if (read_r == 0x8000 || read_r == 0xfe00) + ctl_r = 0; + else + ctl_r = read_r / tendA + 1; + } else { /* ADC/DAC gain */ if (adc_vol_flag) ctl_r = mc->max - (((0x1e00 - read_r) & 0xffff) / interval_offset); else -- 2.34.1

2 1

[PATCH V2] ASoC: amd: ps: fix for soundwire failures during hibernation exit sequence
by Vijendar Mukunda 24 Jun '25

24 Jun '25

During the hibernate entry sequence, ACP registers will be reset to default values and acp ip will be completely powered off including acp SoundWire pads. During resume sequence, if acp SoundWire pad keeper enable register is not restored along with pad pulldown control register value, then SoundWire manager links won't be powered on correctly results in peripheral register access failures and completely audio function is broken. Add code to store the acp SoundWire pad keeper enable register and acp pad pulldown ctrl register values before entering into suspend state and restore the register values during resume sequence based on condition check for acp SoundWire pad keeper enable register for ACP6.3, ACP7.0 & ACP7.1 platforms. Fixes: 491628388005 ("ASoC: amd: ps: add callback functions for acp pci driver pm ops") Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- Changes since v1: removed extra macro ACP_SW_PAD_KEEPER_EN and used existing macro ACP_SW0_PAD_KEEPER_EN in the code. sound/soc/amd/ps/acp63.h | 4 ++++ sound/soc/amd/ps/ps-common.c | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/sound/soc/amd/ps/acp63.h b/sound/soc/amd/ps/acp63.h index 85feae45c44c..d7c994e26e4d 100644 --- a/sound/soc/amd/ps/acp63.h +++ b/sound/soc/amd/ps/acp63.h @@ -334,6 +334,8 @@ struct acp_hw_ops { * @addr: pci ioremap address * @reg_range: ACP reigister range * @acp_rev: ACP PCI revision id + * @acp_sw_pad_keeper_en: store acp SoundWire pad keeper enable register value + * @acp_pad_pulldown_ctrl: store acp pad pulldown control register value * @acp63_sdw0-dma_intr_stat: DMA interrupt status array for ACP6.3 platform SoundWire * manager-SW0 instance * @acp63_sdw_dma_intr_stat: DMA interrupt status array for ACP6.3 platform SoundWire @@ -367,6 +369,8 @@ struct acp63_dev_data { u32 addr; u32 reg_range; u32 acp_rev; + u32 acp_sw_pad_keeper_en; + u32 acp_pad_pulldown_ctrl; u16 acp63_sdw0_dma_intr_stat[ACP63_SDW0_DMA_MAX_STREAMS]; u16 acp63_sdw1_dma_intr_stat[ACP63_SDW1_DMA_MAX_STREAMS]; u16 acp70_sdw0_dma_intr_stat[ACP70_SDW0_DMA_MAX_STREAMS]; diff --git a/sound/soc/amd/ps/ps-common.c b/sound/soc/amd/ps/ps-common.c index 1c89fb5fe1da..7b4966b75dc6 100644 --- a/sound/soc/amd/ps/ps-common.c +++ b/sound/soc/amd/ps/ps-common.c @@ -160,6 +160,8 @@ static int __maybe_unused snd_acp63_suspend(struct device *dev) adata = dev_get_drvdata(dev); if (adata->is_sdw_dev) { + adata->acp_sw_pad_keeper_en = readl(adata->acp63_base + ACP_SW0_PAD_KEEPER_EN); + adata->acp_pad_pulldown_ctrl = readl(adata->acp63_base + ACP_PAD_PULLDOWN_CTRL); adata->sdw_en_stat = check_acp_sdw_enable_status(adata); if (adata->sdw_en_stat) { writel(1, adata->acp63_base + ACP_ZSC_DSP_CTRL); @@ -197,6 +199,7 @@ static int __maybe_unused snd_acp63_runtime_resume(struct device *dev) static int __maybe_unused snd_acp63_resume(struct device *dev) { struct acp63_dev_data *adata; + u32 acp_sw_pad_keeper_en; int ret; adata = dev_get_drvdata(dev); @@ -209,6 +212,12 @@ static int __maybe_unused snd_acp63_resume(struct device *dev) if (ret) dev_err(dev, "ACP init failed\n"); + acp_sw_pad_keeper_en = readl(adata->acp63_base + ACP_SW0_PAD_KEEPER_EN); + dev_dbg(dev, "ACP_SW0_PAD_KEEPER_EN:0x%x\n", acp_sw_pad_keeper_en); + if (!acp_sw_pad_keeper_en) { + writel(adata->acp_sw_pad_keeper_en, adata->acp63_base + ACP_SW0_PAD_KEEPER_EN); + writel(adata->acp_pad_pulldown_ctrl, adata->acp63_base + ACP_PAD_PULLDOWN_CTRL); + } return ret; } @@ -408,6 +417,8 @@ static int __maybe_unused snd_acp70_suspend(struct device *dev) adata = dev_get_drvdata(dev); if (adata->is_sdw_dev) { + adata->acp_sw_pad_keeper_en = readl(adata->acp63_base + ACP_SW0_PAD_KEEPER_EN); + adata->acp_pad_pulldown_ctrl = readl(adata->acp63_base + ACP_PAD_PULLDOWN_CTRL); adata->sdw_en_stat = check_acp_sdw_enable_status(adata); if (adata->sdw_en_stat) { writel(1, adata->acp63_base + ACP_ZSC_DSP_CTRL); @@ -445,6 +456,7 @@ static int __maybe_unused snd_acp70_runtime_resume(struct device *dev) static int __maybe_unused snd_acp70_resume(struct device *dev) { struct acp63_dev_data *adata; + u32 acp_sw_pad_keeper_en; int ret; adata = dev_get_drvdata(dev); @@ -459,6 +471,12 @@ static int __maybe_unused snd_acp70_resume(struct device *dev) if (ret) dev_err(dev, "ACP init failed\n"); + acp_sw_pad_keeper_en = readl(adata->acp63_base + ACP_SW0_PAD_KEEPER_EN); + dev_dbg(dev, "ACP_SW0_PAD_KEEPER_EN:0x%x\n", acp_sw_pad_keeper_en); + if (!acp_sw_pad_keeper_en) { + writel(adata->acp_sw_pad_keeper_en, adata->acp63_base + ACP_SW0_PAD_KEEPER_EN); + writel(adata->acp_pad_pulldown_ctrl, adata->acp63_base + ACP_PAD_PULLDOWN_CTRL); + } return ret; } -- 2.45.2

2 1

[PATCH] ASoC: amd: yc: add quirk for Acer Nitro ANV15-41 internal mic
by Yuzuru10 23 Jun '25

23 Jun '25

This patch adds DMI-based quirk for the Acer Nitro ANV15-41, allowing the internal microphone to be detected correctly on machines with "RB" as board vendor. Signed-off-by: Yuzuru <yuzuru_10(a)proton.me> --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 98022e5fd428..499f9f7c76ee 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -353,6 +353,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "RB"), + DMI_MATCH(DMI_PRODUCT_NAME, "Nitro ANV15-41"), + } + }, { .driver_data = &acp6x_card, .matches = { -- 2.50.0

1 0