- Alsa-devel - mailman.alsa-project.org

alsaloop doesn't pass sound with libsamplerate resampling on raspberry pi 5
by GitHub issues - edited 10 Feb '25

10 Feb '25

alsa-project/alsa-utils issue #291 was edited from willangley: Hi alsa-utils team! I'm using `alsaloop`s on a Raspberry Pi 5 as part of a slightly ridiculous signal chain: * Yamaha P-525 keyboard * USB C-to-A cable * Raspberry Pi 5 * USB A-to-B cable * ESI U24XL * SPDIF in/out * Focusrite Clarett+ 4Pre * ... * MacBook Pro [Why? The analog Aux In/Aux Out on the keyboard have an always on loopback connection, which is undesirable when playing to a video meeting. The USB port has user controllable loopback.] Two alsaloop processes run on the Pi, one moving sound from the computer to the piano, one moving sound from the piano to the computer. Both run under `supervisord`. I've got them running at acceptable latency — RTL Utility says 40ms from my MacBook Pro. But I haven't been able to get any of the high quality resampling options working -- everything other than add/drop stops passing sound within a few seconds. I'm surprised; this Pi should be powerful enough to handle this. Any ideas how to troubleshoot it? I didn't see errors in logs at the default log level. Thank you! Will Issue URL : https://github.com/alsa-project/alsa-utils/issues/291 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

alsaloop doesn't pass sound with libsamplerate resampling on raspberry pi 5
by GitHub issues - edited 10 Feb '25

10 Feb '25

alsa-project/alsa-utils issue #291 was edited from willangley: Hi alsa-utils team! I'm using `alsaloop`s on a Raspberry Pi 5 as part of a slightly ridiculous signal chain: * Yamaha P-525 keyboard * USB C-to-A cable * Raspberry Pi 5 * USB A-to-B cable * ESI U24XL * SPDIF in/out * Focusrite Clarett+ 4Pre * ... * MacBook Pro [Why? The analog Aux In/Aux Out on the keyboard have an always on loopback connection, which is undesirable when playing to a video meeting. The USB port has user controllable loopback.] Two alsaloop processes run on the Pi, one moving sound from the computer to the piano, one moving sound from the piano to the computer. Both run under `supervisord`. I've got them running at acceptable latency — RTL Utility says 40ms from my MacBook Pro. But I haven't been able to get any of the high quality resampling options working -- everything other than add/drop stops passing sound within a few seconds. I'm surprised; this Pi should be powerful enough to handle this. Any ideas how to troubleshoot it? Thank you! Will Issue URL : https://github.com/alsa-project/alsa-utils/issues/291 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

alsaloop doesn't pass sound with libsamplerate on raspberry pi 5
by GitHub issues - opened 10 Feb '25

10 Feb '25

alsa-project/alsa-utils issue #291 was opened from willangley: Hi alsa-utils team! I'm using `alsaloop`s on a Raspberry Pi 5 as part of a slightly ridiculous signal chain: * Yamaha P-525 keyboard * USB C-to-A cable * Raspberry Pi 5 * USB A-to-B cable * ESI U24XL * SPDIF in/out * Focusrite Clarett+ 4Pre * ... * MacBook Pro [Why? The analog Aux In/Aux Out on the keyboard have an always on loopback connection, which is undesirable when playing to a video meeting. The USB port has user controllable loopback.] Two alsaloop processes run on the Pi, one moving sound from the computer to the piano, one moving sound from the piano to the computer. Both run under `supervisord`. I've got them running at acceptable latency — RTL Utility says 40ms from my MacBook Pro. But I haven't been able to get any of the high quality resampling options working -- everything other than add/drop stops passing sound within a few seconds. I'm surprised; this Pi should be powerful enough to handle this. Any ideas how to troubleshoot it? Thank you! Will Issue URL : https://github.com/alsa-project/alsa-utils/issues/291 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Soundblaster G8 USB Audio not working correctly
by GitHub issues - opened 07 Feb '25

07 Feb '25

alsa-project/alsa-lib issue #437 was opened from Starfoxfs: Soundblaster G8 works partly under Linux Mint 22.1 Cinnamon. Audio playback works in Analog stereo or Duplex mode with headphones and these are displayed as Speakers. Digital SPDIF Out works and also the switch button between headphones and Digital out to external Speakers (only with pipewire not with Pulseaudio). What doesn't work is the Direct Mode and all the Crystalizer surround settings as well as output in virtual 5.1 or 7.1 sound. Microphone doesn´t work, if it plugged in i have no sound at all. [alsa-info.txt](https://github.com/user-attachments/files/18710112/alsa-info… Issue URL : https://github.com/alsa-project/alsa-lib/issues/437 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

rt722: change output volume of speaker to 0dB
by GitHub pull_request - opened 07 Feb '25

07 Feb '25

alsa-project/alsa-ucm-conf pull request #506 was opened from shumingfan: This patch also changes hardware gain to software gain when using volume bar. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/506 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/506.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

soundwire : LnK SoundWire Protocol Analyzer on Linux
by Muni Sekhar 06 Feb '25

06 Feb '25

Hi all, I hope this message finds you well. I am planning to use the LnK SoundWire Protocol Analyzer on a Linux platform. However, I am uncertain whether the current Linux kernel includes the necessary SoundWire drivers to support this . I would appreciate any guidance on how to use the LnK SoundWire Protocol Analyzer with the Linux kernel, as well as information on the specific device drivers required. Could you please provide details on: The compatibility of the LnK SoundWire Protocol Analyzer with the Linux kernel. The steps to set up and use the analyzer on a Linux platform. The necessary device drivers and any additional configurations needed. Thank you for your assistance. -- Thanks, Sekhar

1 0

[PATCH v1] ASoC: tas2781: drop a redundant code
by Shenghao Ding 06 Feb '25

06 Feb '25

Report from internal ticket, priv->cali_data.data devm_kzalloc twice, drop the first one, it is the unnecessary one. Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v1: - update the year from 2024 to 2025. - drop a redundant code. --- sound/soc/codecs/tas2781-i2c.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index a730ab6ad4e3..90c5b2e74d12 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -2,7 +2,7 @@ // // ALSA SoC Texas Instruments TAS2563/TAS2781 Audio Smart Amplifier // -// Copyright (C) 2022 - 2024 Texas Instruments Incorporated +// Copyright (C) 2022 - 2025 Texas Instruments Incorporated // https://www.ti.com // // The TAS2563/TAS2781 driver implements a flexible and configurable @@ -1260,8 +1260,6 @@ static int tasdevice_create_cali_ctrls(struct tasdevice_priv *priv) (cali_data->cali_dat_sz_per_dev + 1) + 1 + 15 + 1; priv->cali_data.total_sz = priv->ndev * (cali_data->cali_dat_sz_per_dev + 1); - priv->cali_data.data = devm_kzalloc(priv->dev, - ext_cali_data->max, GFP_KERNEL); cali_ctrls[i].name = cali_name; cali_ctrls[i].iface = SNDRV_CTL_ELEM_IFACE_MIXER; cali_ctrls[i].info = snd_soc_bytes_info_ext; -- 2.34.1

2 1

[PATCH v1] MAINTAINERS: remove Kevin Lu from TEXAS INSTRUMENTS AUDIO (ASoC/HDA) DRIVERS
by Shenghao Ding 04 Feb '25

04 Feb '25

Due to internal re-org, Kevin Lu has no longer maintained audio driver. Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 896a307fa065..bc0bf402818d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23370,7 +23370,6 @@ F: sound/soc/ti/ TEXAS INSTRUMENTS AUDIO (ASoC/HDA) DRIVERS M: Shenghao Ding <shenghao-ding(a)ti.com> -M: Kevin Lu <kevin-lu(a)ti.com> M: Baojun Xu <baojun.xu(a)ti.com> L: linux-sound(a)vger.kernel.org S: Maintained -- 2.34.1

1 0

[PATCH alsa-utils] amixer: implement handling of TLV bytes kcontrols
by Jan Dakinevich 03 Feb '25

03 Feb '25

SND_SOC_BYTES_EXT kcontrols are deprecated and SND_SOC_BYTES_TLV should be used instead. However, there is no support of these kcontrols in amixer. This commit introduces a mechanism to show and write the content of SND_SOC_BYTES_TLV-based kcontrols. Example: $ amixer cset name="Test" 0x10,0x20,0x30,0x40,0x50,0x60,0x70,0x80,0x90,0xa0 $ amixer cget name="Test" numid=42,iface=MIXER,name='Test' ; type=BYTES,access=-----RW-,values=10 : values=0x10,0x20,0x30,0x40,0x50,0x60,0x70,0x80,0x90,0xa0 Signed-off-by: Jan Dakinevich <jan.dakinevich(a)salutedevices.com> --- amixer/amixer.c | 180 +++++++++++++++++++++++++++++++++++++----------- 1 file changed, 141 insertions(+), 39 deletions(-) diff --git a/amixer/amixer.c b/amixer/amixer.c index 07e9819e5cdb..09f774fe2885 100644 --- a/amixer/amixer.c +++ b/amixer/amixer.c @@ -609,6 +609,8 @@ static int show_control(const char *space, snd_hctl_elem_t *elem, { int err; unsigned int item, idx, count, *tlv; + uint8_t *tlv_bytes = NULL; + unsigned int tlv_bytes_count = 0; snd_ctl_elem_type_t type; snd_ctl_elem_id_t *id; snd_ctl_elem_info_t *info; @@ -628,6 +630,18 @@ static int show_control(const char *space, snd_hctl_elem_t *elem, } count = snd_ctl_elem_info_get_count(info); type = snd_ctl_elem_info_get_type(info); + if (type == SND_CTL_ELEM_TYPE_BYTES && + !snd_ctl_elem_info_is_readable(info) && + !snd_ctl_elem_info_is_writable(info)) { + if (count <= 2 * sizeof(unsigned int)) + return -EINVAL; + tlv_bytes_count = count; + count -= 2 * sizeof(unsigned int); + + tlv_bytes = malloc(tlv_bytes_count); + if (!tlv_bytes) + return -ENOMEM; + } printf("%s; type=%s,access=%s,values=%u", space, control_type(info), control_access(info), count); switch (type) { case SND_CTL_ELEM_TYPE_INTEGER: @@ -661,16 +675,30 @@ static int show_control(const char *space, snd_hctl_elem_t *elem, break; } if (level & LEVEL_BASIC) { - if (!snd_ctl_elem_info_is_readable(info)) + if (snd_ctl_elem_info_is_readable(info)) { + err = snd_hctl_elem_read(elem, control); + if (err < 0) { + error("Control %s element read error: %s\n", card, snd_strerror(err)); + return err; + } + } else if (tlv_bytes) { + err = snd_hctl_elem_tlv_read(elem, (void *)tlv_bytes, tlv_bytes_count); + if (err < 0) { + error("Control %s element TLV read error: %s\n", card, snd_strerror(err)); + free(tlv_bytes); + return err; + } + } else goto __skip_read; - if ((err = snd_hctl_elem_read(elem, control)) < 0) { - error("Control %s element read error: %s\n", card, snd_strerror(err)); - return err; - } + printf("%s: values=", space); for (idx = 0; idx < count; idx++) { if (idx > 0) printf(","); + if (tlv_bytes) { + printf("0x%02x", tlv_bytes[idx + 2 * sizeof(unsigned int)]); + continue; + } switch (type) { case SND_CTL_ELEM_TYPE_BOOLEAN: printf("%s", snd_ctl_elem_value_get_boolean(control, idx) ? "on" : "off"); @@ -699,17 +727,11 @@ static int show_control(const char *space, snd_hctl_elem_t *elem, } } printf("\n"); + if (tlv_bytes) + goto __skip_tlv; __skip_read: if (!snd_ctl_elem_info_is_tlv_readable(info)) goto __skip_tlv; - /* skip ASoC ext bytes controls that may have huge binary TLV data */ - if (type == SND_CTL_ELEM_TYPE_BYTES && - !snd_ctl_elem_info_is_readable(info) && - !snd_ctl_elem_info_is_writable(info)) { - printf("%s; ASoC TLV Byte control, skipping bytes dump\n", space); - goto __skip_tlv; - } - tlv = malloc(4096); if ((err = snd_hctl_elem_tlv_read(elem, tlv, 4096)) < 0) { error("Control %s element TLV read error: %s\n", card, snd_strerror(err)); @@ -720,6 +742,7 @@ static int show_control(const char *space, snd_hctl_elem_t *elem, free(tlv); } __skip_tlv: + free(tlv_bytes); return 0; } @@ -1133,16 +1156,110 @@ static int parse_simple_id(const char *str, snd_mixer_selem_id_t *sid) return 0; } +static int parse_bytes(const char *str, void *ptr, unsigned int len) +{ + char *p; + unsigned long tmp; + unsigned int idx = 0; + unsigned char *data = ptr; + + for (;;) { + if (!*str) + break; + if (idx == len) + return -EINVAL; + + tmp = strtoul(str, &p, 0); + if (p - str < 1) + return -EINVAL; + if (*p == ',') + str = p + 1; + else if (*p == '\0') + str = p; + else + return -EINVAL; + + if (tmp > 255) + return -EINVAL; + + data[idx] = tmp; + idx++; + } + + if (!idx) + return -EINVAL; + + return idx; +} + +static int cset_tlv(int argc, char *argv[], snd_ctl_t *handle, + snd_ctl_elem_info_t *info, snd_ctl_elem_id_t *id) +{ + int err; + unsigned int count; + unsigned int *tlv = NULL; + + count = snd_ctl_elem_info_get_count(info); + if (count <= 2 * sizeof(unsigned int)) { + err = -EINVAL; + goto out; + } + tlv = malloc(count); + if (!tlv) { + err = -ENOMEM; + goto out; + } + err = parse_bytes(argv[1], tlv + 2, + count - 2 * sizeof(unsigned int)); + if (err < 0) + goto out; + tlv[0] = 0; + tlv[1] = err; + + err = snd_ctl_elem_tlv_write(handle, id, tlv); + +out: + free(tlv); + return err; +} + +static int cset_elem(int argc, char *argv[], snd_ctl_t *handle, + snd_ctl_elem_info_t *info, snd_ctl_elem_id_t *id) +{ + int err; + snd_ctl_elem_value_t *control; + snd_ctl_elem_value_alloca(&control); + + snd_ctl_elem_value_set_id(control, id); + if ((err = snd_ctl_elem_read(handle, control)) < 0) { + if (!ignore_error) + error("Cannot read the given element from control %s\n", card); + return err; + } + err = snd_ctl_ascii_value_parse(handle, control, info, argv[1]); + if (err < 0) { + if (!ignore_error) + error("Control %s parse error: %s\n", card, snd_strerror(err)); + return err; + } + if ((err = snd_ctl_elem_write(handle, control)) < 0) { + if (!ignore_error) + error("Control %s element write error: %s\n", card, snd_strerror(err)); + return err; + } + + return 0; +} + static int cset(int argc, char *argv[], int roflag, int keep_handle) { int err; static snd_ctl_t *handle = NULL; snd_ctl_elem_info_t *info; snd_ctl_elem_id_t *id; - snd_ctl_elem_value_t *control; + snd_ctl_elem_type_t type; snd_ctl_elem_info_alloca(&info); snd_ctl_elem_id_alloca(&id); - snd_ctl_elem_value_alloca(&control); if (argc < 1) { fprintf(stderr, "Specify a full control identifier: [[iface=<iface>,][name='name',][index=<index>,][device=<device>,][subdevice=<subdevice>]]|[numid=<numid>]\n"); @@ -1175,30 +1292,15 @@ static int cset(int argc, char *argv[], int roflag, int keep_handle) } snd_ctl_elem_info_get_id(info, id); /* FIXME: Remove it when hctl find works ok !!! */ if (!roflag) { - snd_ctl_elem_value_set_id(control, id); - if ((err = snd_ctl_elem_read(handle, control)) < 0) { - if (ignore_error) - return 0; - error("Cannot read the given element from control %s\n", card); - if (! keep_handle) { - snd_ctl_close(handle); - handle = NULL; - } - return err; - } - err = snd_ctl_ascii_value_parse(handle, control, info, argv[1]); - if (err < 0) { - if (!ignore_error) - error("Control %s parse error: %s\n", card, snd_strerror(err)); - if (!keep_handle) { - snd_ctl_close(handle); - handle = NULL; - } - return ignore_error ? 0 : err; - } - if ((err = snd_ctl_elem_write(handle, control)) < 0) { - if (!ignore_error) - error("Control %s element write error: %s\n", card, snd_strerror(err)); + type = snd_ctl_elem_info_get_type(info); + if (type == SND_CTL_ELEM_TYPE_BYTES && + !snd_ctl_elem_info_is_readable(info) && + !snd_ctl_elem_info_is_writable(info)) { + err = cset_tlv(argc, argv, handle, info, id); + } else + err = cset_elem(argc, argv, handle, info, id); + + if (err) { if (!keep_handle) { snd_ctl_close(handle); handle = NULL; -- 2.34.1

1 0

Compilation failure with Clang-21 due to macro conflicts
by GitHub issues - opened 02 Feb '25

02 Feb '25

alsa-project/alsa-lib issue #436 was opened from ms178: **Description:** Attempting to compile alsa-lib (both the `git` version and version 1.2.13) with Clang-21 (commit `bfa7edcc6652bdb37d53e0cec64926aab3f280eb`) results in multiple compilation errors. These errors stem from conflicts between macros defined in `midifile.h` and member names within structures defined in `include/alsa/ump_msg.h`. **Environment:** * **alsa-lib version:** `git` (and 1.2.13) * **Compiler:** Clang-21 (`bfa7edcc6652bdb37d53e0cec64926aab3f280eb`) * **Operating System:** CachyOS * **Build System:** Autotools **Steps to Reproduce:** 1. Obtain the PKGBUILD and the other files from https://github.com/ms178/archpkgbuilds/blob/main/packages/alsa-lib-main/PKG… 2. Uncomment the patch that I apply to workaround the issue. 3. Configure the build to use Clang-21 (`bfa7edcc6652bdb37d53e0cec64926aab3f280eb`). 4. Attempt to compile the library. **Expected Behavior:** The compilation should complete successfully without errors. **Actual Behavior:** The compilation fails with multiple errors similar to the following: ``` In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h:31: ../include/alsa/ump_msg.h:170:27: error: expected member name or ';' after declaration specifiers 170 | snd_ump_msg_midi1_note_t note_on; /**< MIDI1 note-on message */ | ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ./midifile.h:55:27: note: expanded from macro 'note_on' 55 | #define note_on 0x90 | ^ In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h:31: ../include/alsa/ump_msg.h:170:26: error: expected ';' at end of declaration list 170 | snd_ump_msg_midi1_note_t note_on; /**< MIDI1 note-on message */ | ^ | ; ../include/alsa/ump_msg.h:171:27: error: expected member name or ';' after declaration specifiers 171 | snd_ump_msg_midi1_note_t note_off; /**< MIDI1 note-off message */ | ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ./midifile.h:54:27: note: expanded from macro 'note_off' 54 | #define note_off 0x80 | ^ In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h:31: ../include/alsa/ump_msg.h:171:26: error: expected ';' at end of declaration list 171 | snd_ump_msg_midi1_note_t note_off; /**< MIDI1 note-off message */ | ^ | ; ../include/alsa/ump_msg.h:173:26: error: expected member name or ';' after declaration specifiers 173 | snd_ump_msg_midi1_cc CCLD rawmidi _t control_change; /**< MIDI1 control-change message */ | ~~~~~~~~~~~~~~~~~~~~~~ ^ ./midifile.h:57:28: note: expanded from macro 'control_change' 57 | #define control_change 0xb0 | ^ In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h CCLD oldapi :31: ../include/alsa/ump_msg.h:173:24: error: expected ';' at end of declaration list 173 | snd_ump_msg_midi1_cc_t control_change; /**< MIDI1 control-change message */ | ^ | ; ../include/alsa/ump_msg.h:432:27: error: expected member name or ';' after declaration specifiers 432 | snd_ump_msg_midi2_note_t note_on; /**< MIDI2 note-on message */ | ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ./midifile.h:55:27: note: expanded from macro 'note_on' 55 | #define note_on 0x90 | ^ CCLD pcm_min In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h:31: ../include/alsa/ump_msg.h:432:26: error: expected ';' at end of declaration list 432 | snd_ump_msg_midi2_note_t note_on; /**< MIDI2 note-on message */ | ^ | ; ../include/alsa/ump_msg.h:433:27: error: expected member name or ';' after declaration specifiers 433 | snd_ump_msg_midi2_note_t note_off; /**< MIDI2 note-off message */ | ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ./midifile.h:54:27: note: expanded from macro 'note_off' 54 | #define note_off 0x80 | ^ In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h:31: ../include/alsa/ump_msg.h:433:26: error: expected ';' at end of declaration list 433 | snd_ump_msg_midi2_note_t note_off; /**< MIDI2 note-off message */ | ^ | ; ../include/alsa/ump_msg.h:438:26: error: expected member name or ';' after declaration specifiers 438 | snd_ump_msg_midi2_cc_t control_change; /**< MIDI2 control-change message */ | ~~~~~~~~~~~~~~~~~~~~~~ ^ ./midifile.h:57:28: note: expanded from macro 'control_change' 57 | #define control_change 0xb0 | ^ In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h:31: ../include/alsa/ump_msg.h:438:24: error: expected ';' at end of declaration list 438 | snd_ump_msg_midi2_cc_t control_change; /**< MIDI2 control-change message */ | ^ | ; ../include/alsa/ump_msg.h:711:27: error: expected member name or ';' after declaration specifiers 711 | snd_ump_msg_set_tempo_t set_tempo; /**< Set Tempo */ | ~~~~~~~~~~~~~~~~~~~~~~~ ^ ./midifile.c:57:20: note: expanded from macro 'set_tempo' 57 | #define set_tempo 0x51 | ^ In file included from playmidi1.c:51: In file included from ./../include/asoundlib.h:63: In file included from ../include/alsa/seq_event.h:31: ../include/alsa/ump_msg.h:711:25: error: expected ';' at end of declaration list 711 | snd_ump_msg_set_tempo_t set_tempo; /**< Set Tempo */ | ^ | ; CCLD control CCLD chmap 14 errors generated. ``` **Root Cause analysis by AI:** The macros `note_on`, `note_off`, `control_change`, and `set_tempo` defined in `midifile.h` are conflicting with member names used in structures within `include/alsa/ump_msg.h`. This leads to incorrect code expansion and subsequent compilation errors. **Workaround:** The following patch applied to `include/asoundlib-head.h` allows the compilation to succeed: ```diff --- a/include/asoundlib-head.h +++ b/include/asoundlib-head.h @@ -28,6 +28,11 @@ #ifndef __ASOUNDLIB_H #define __ASOUNDLIB_H +#undef note_on +#undef note_off +#undef control_change +#undef set_tempo + #include <unistd.h> #include <stdio.h> #include <stdlib.h> ``` **Suggested Solutions by AI:** While the provided workaround resolves the immediate compilation issue, a more robust solution might involve: 1. **Renaming conflicting members:** Consider renaming the members in `ump_msg.h` (e.g., `midi1_note_on`, `midi2_note_off`, etc.) to avoid clashes with commonly used MIDI event names. 2. **Namespace/prefix:** If renaming is not feasible, consider using a namespace or prefix for the `ump_msg.h` members to prevent conflicts. 3. **Conditional undef:** Instead of unconditionally undefining the macros in `asoundlib-head.h`, a more targeted approach could be to undefine them only within the scope of `ump_msg.h`'s inclusion. 4. **Review macro definitions:** Investigate if the macros in `midifile.h` are strictly necessary or if they can be replaced with constants or enums within a namespace. **Additional Notes:** * I am not a programmer and cannot provide a definitive fix. The provided workaround is based on AI feedback. Issue URL : https://github.com/alsa-project/alsa-lib/issues/436 Repository URL: https://github.com/alsa-project/alsa-lib

1 0