- Alsa-devel - mailman.alsa-project.org

[PATCH 0/6] ASoC: mediatek: Allow separate handling of headphone and headset mic jack
by Nícolas F. R. A. Prado 23 Sep '22

23 Sep '22

This series allows the headphone and headset mic jack status to be handled separately by userspace on MT8192, MT8195 and MT8186. Changes based on commit d0508b4f1604 ("ASoC: rk3399_gru_sound: Add DAPM pins, kcontrols for jack detection"). Found while searching for an alternative for JackSwitch [1]. [1] https://lore.kernel.org/all/b98a8a77-7652-1995-27ba-eb7b6d30202a@gmail.com/ Nícolas F. R. A. Prado (6): ASoC: mediatek: mt8192-mt6359: Expose individual headset jack pins ASoC: mediatek: mt8195: Expose individual headset jack pins ASoC: mediatek: mt8186-da7219: Add headset widgets with switches ASoC: mediatek: mt8186-da7219: Expose individual headset jack pins ASoC: mediatek: mt8186-rt5682: Add headset widgets with switches ASoC: mediatek: mt8186-rt5682: Expose individual headset jack pins .../mt8186/mt8186-mt6366-da7219-max98357.c | 25 +++++++++++++++++-- .../mt8186/mt8186-mt6366-rt1019-rt5682s.c | 25 +++++++++++++++++-- .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 17 +++++++++++-- sound/soc/mediatek/mt8195/mt8195-mt6359.c | 17 +++++++++++-- 4 files changed, 76 insertions(+), 8 deletions(-) -- 2.37.3

3 13

[PATCH 00/10] ASoC: SOF: Intel: MTL: Fixes for suspend/resume
by Ranjani Sridharan 23 Sep '22

23 Sep '22

This series includes fixes for suspend/resume and module loading/unloading for the MTL platform. Fred Oh (4): ASoC: SOF: Intel: introduce new op to handle dsp power down ASoC: SOF: Intel: define and set power_down_dsp op for HDA platforms ASoC: SOF: Intel: mtl: define and set power_down_dsp op ASoC: SOF: Intel: use power_down_dsp op in hda_dsp_remove Ranjani Sridharan (5): ASoC: SOF: Intel: Add a new op for disabling interrupts ASoC: SOF: Intel: define and set the disable_interrupts op for cavs platforms ASoC: SOF: Intel: MTL: define and set the disable_interrupts op ASoC: SOF: Intel: HDA: use IPC version-specific ops ASoC: SOF: Intel: MTL: reuse the common ops for PM Yong Zhi (1): ASoC: SOF: Intel: MTL: remove the unnecessary snd_sof_dsp_read() sound/soc/sof/intel/apl.c | 2 + sound/soc/sof/intel/cnl.c | 4 + sound/soc/sof/intel/hda-dsp.c | 21 ++-- sound/soc/sof/intel/hda.c | 14 ++- sound/soc/sof/intel/hda.h | 2 + sound/soc/sof/intel/icl.c | 2 + sound/soc/sof/intel/mtl.c | 193 ++++++---------------------------- sound/soc/sof/intel/shim.h | 2 + sound/soc/sof/intel/skl.c | 2 + sound/soc/sof/intel/tgl.c | 8 ++ 10 files changed, 81 insertions(+), 169 deletions(-) -- 2.25.1

2 11

[PATCH] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data()
by Gaosheng Cui 23 Sep '22

23 Sep '22

The imx_pcm_dma_params_init_data() are no longer used since commit c31da0b196f9 ("ASoC: imx-ssi: Remove unused driver"), and the function is used to initialize some members of "struct imx_dma_data", it's more readable to assign the value directly, imx_pcm_dma_params_init_data is useless, so remove it. Signed-off-by: Gaosheng Cui <cuigaosheng1(a)huawei.com> --- sound/soc/fsl/imx-pcm.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sound/soc/fsl/imx-pcm.h b/sound/soc/fsl/imx-pcm.h index 06b25f4b26b6..ac5f57c3cc55 100644 --- a/sound/soc/fsl/imx-pcm.h +++ b/sound/soc/fsl/imx-pcm.h @@ -18,15 +18,6 @@ #define IMX_DEFAULT_DMABUF_SIZE (64 * 1024) -static inline void -imx_pcm_dma_params_init_data(struct imx_dma_data *dma_data, - int dma, enum sdma_peripheral_type peripheral_type) -{ - dma_data->dma_request = dma; - dma_data->priority = DMA_PRIO_HIGH; - dma_data->peripheral_type = peripheral_type; -} - struct imx_pcm_fiq_params { int irq; void __iomem *base; -- 2.25.1

2 1

[PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops instead of custom ops
by AngeloGioacchino Del Regno 23 Sep '22

23 Sep '22

It is possible to use the standard snd_soc_pm_ops for this card: remove the custom mt8195_mt6359_pm_ops. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> --- sound/soc/mediatek/mt8195/mt8195-mt6359.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c index 961e769602d6..23bdde6acd1c 100644 --- a/sound/soc/mediatek/mt8195/mt8195-mt6359.c +++ b/sound/soc/mediatek/mt8195/mt8195-mt6359.c @@ -1532,16 +1532,11 @@ static const struct of_device_id mt8195_mt6359_dt_match[] = { {}, }; -static const struct dev_pm_ops mt8195_mt6359_pm_ops = { - .poweroff = snd_soc_poweroff, - .restore = snd_soc_resume, -}; - static struct platform_driver mt8195_mt6359_driver = { .driver = { .name = "mt8195_mt6359", .of_match_table = mt8195_mt6359_dt_match, - .pm = &mt8195_mt6359_pm_ops, + .pm = &snd_soc_pm_ops, }, .probe = mt8195_mt6359_dev_probe, }; -- 2.37.2

4 6

[PATCH 00/12] ASoC: cs42l42: Add Soundwire support
by Richard Fitzgerald 23 Sep '22

23 Sep '22

The CS42L42 has a Soundwire interface for control and audio. This chain of patches adds support for this. Patches #1 .. #10 split out various changes to the existing code that are needed for adding Soundwire. These are mostly around clocking and supporting the separate probe and enumeration stages in Soundwire. Patches #11 and #12 actually add the Soundwire handling. Richard Fitzgerald (12): ASoC: cs42l42: Add SOFT_RESET_REBOOT register ASoC: cs42l42: Add bitclock frequency argument to cs42l42_pll_config() ASoC: cs42l42: Ensure MCLKint is a multiple of the sample rate ASoC: cs42l42: Separate ASP config from PLL config ASoC: cs42l42: Use cs42l42->dev instead of &i2c_client->dev ASoC: cs42l42: Split probe() and remove() into stages ASoC: cs42l42: Split cs42l42_resume into two functions ASoC: cs42l42: Pass component and dai defs into common probe ASoC: cs42l42: Split I2C identity into separate module ASoC: cs42l42: Export some functions for Soundwire ASoC: cs42l42: Add Soundwire support ASoC: cs42l42: Add support for Soundwire interrupts include/sound/cs42l42.h | 5 + sound/soc/codecs/Kconfig | 14 +- sound/soc/codecs/Makefile | 6 +- sound/soc/codecs/cs42l42-i2c.c | 107 +++++ sound/soc/codecs/cs42l42-sdw.c | 689 +++++++++++++++++++++++++++++++++ sound/soc/codecs/cs42l42.c | 359 +++++++++-------- sound/soc/codecs/cs42l42.h | 30 +- 7 files changed, 1049 insertions(+), 161 deletions(-) create mode 100644 sound/soc/codecs/cs42l42-i2c.c create mode 100644 sound/soc/codecs/cs42l42-sdw.c -- 2.30.2

3 20

[Allen & Heath Qu-Pac] regression since 0.3.53+ / no audio inputs unless manual selection of config profile ("Pro") in pulse audio control
by GitHub issues - edited 23 Sep '22

23 Sep '22

alsa-project/alsa-lib issue #272 was edited from ianhundere:  - PipeWire version (`pipewire --version`): - `0.3.58` but also experienced with `0.3.53`, `0.3.55` and `0.3.56`. did not experience this prior to `0.3.53`. - Distribution and distribution version (`PRETTY_NAME` from `/etc/os-release`): - `Pop!_OS 22.04 LTS` - Desktop Environment: - `GNOME 42.3.1` - Kernel version (`uname -r`): - `5.19.0-76051900-generic` ## Description of Problem: have to manually set audio profile in pulse audio control. ## How Reproducible: reset interface / no inputs in daw (bitwig 4.3.8) ### Steps to Reproduce: 1. reset interface (allen heath qupac) 1. go to pulse audio control 1. unselect pro / reselect pro errors: `journalctl --no-hostname --user -u pipewire ` ``` Jul 30 14:39:43 systemd[1618]: Started PipeWire Multimedia Service. Jul 30 14:39:43 pipewire[1635]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 14:39:43 pipewire[1635]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 14:39:43 pipewire[1635]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 14:40:42 pipewire[1635]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 14:40:42 pipewire[1635]: spa.audioadapter: 0x56374b3cf218: can't send command 2: Broken pipe Jul 30 14:40:42 pipewire[1635]: pw.node: (alsa_input.usb-Allen_Heath_Ltd_QU-PAC-01.pro-input-0-110) suspended -> error (Start error: Broken> ``` then i unselect / reselect "Pro" via pulseaudio volume control: ``` Jul 30 22:54:35 pipewire[1632]: pw.link: 0x55618e69d5d0: one of the nodes is in error out:error in:suspended Jul 30 22:54:35 pipewire[1632]: pw.link: 0x55618e69e200: one of the nodes is in error out:error in:suspended Jul 30 22:54:35 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:46 pipewire[1632]: spa.alsa: hw:3,0: follower delay:520 target:256 thr:256, resync ``` ### Actual Results: no audio from external inputs ### Expected Results: you shouldn't need to reselect a profile # Additional Info (as attachments): - more info: https://github.com/pop-os/pipewire/issues/16, https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/2567 Issue URL : https://github.com/alsa-project/alsa-lib/issues/272 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[Allen & Heath Qu-Pac] regression since 0.3.53+ / no audio inputs unless manual selection of config profile ("Pro") in pulse audio control
by GitHub issues - opened 23 Sep '22

23 Sep '22

alsa-project/alsa-lib issue #272 was opened from ianhundere:  - PipeWire version (`pipewire --version`): - `0.3.58` but also experienced with `0.3.53`, `0.3.55` and `0.3.56`. did not experience this prior to `0.3.53`. - Distribution and distribution version (`PRETTY_NAME` from `/etc/os-release`): - `Pop!_OS 22.04 LTS` - Desktop Environment: - `GNOME 42.3.1` - Kernel version (`uname -r`): - `5.19.0-76051900-generic` ## Description of Problem: have to manually set audio profile in pulse audio control. ## How Reproducible: reset interface / no inputs in daw (bitwig 4.3.2) ### Steps to Reproduce: 1. reset interface (allen heath qupac) 1. go to pulse audio control 1. unselect pro / reselect pro errors: `journalctl --no-hostname --user -u pipewire ` ``` Jul 30 14:39:43 systemd[1618]: Started PipeWire Multimedia Service. Jul 30 14:39:43 pipewire[1635]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 14:39:43 pipewire[1635]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 14:39:43 pipewire[1635]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 14:40:42 pipewire[1635]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 14:40:42 pipewire[1635]: spa.audioadapter: 0x56374b3cf218: can't send command 2: Broken pipe Jul 30 14:40:42 pipewire[1635]: pw.node: (alsa_input.usb-Allen_Heath_Ltd_QU-PAC-01.pro-input-0-110) suspended -> error (Start error: Broken> ``` then i unselect / reselect "Pro" via pulseaudio volume control: ``` Jul 30 22:54:35 pipewire[1632]: pw.link: 0x55618e69d5d0: one of the nodes is in error out:error in:suspended Jul 30 22:54:35 pipewire[1632]: pw.link: 0x55618e69e200: one of the nodes is in error out:error in:suspended Jul 30 22:54:35 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:35 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:acp: Rate doesn't match (requested 44100, got 48000) Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.alsa: hw:3,0: snd_pcm_start: Broken pipe Jul 30 22:54:36 pipewire[1632]: spa.audioadapter: 0x55618e007e58: can't send command 2: Broken pipe Jul 30 22:54:46 pipewire[1632]: spa.alsa: hw:3,0: follower delay:520 target:256 thr:256, resync ``` ### Actual Results: no audio from external inputs ### Expected Results: you shouldn't need to reselect a profile # Additional Info (as attachments): - more info: https://github.com/pop-os/pipewire/issues/16, https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/2567 Issue URL : https://github.com/alsa-project/alsa-lib/issues/272 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Re: [PATCH V2 1/2] ASoc:codes:Add Awinic AW883XX audio amplifier driver
by Pierre-Louis Bossart 23 Sep '22

23 Sep '22

Please add the alsa-devel mailing list in the To: list in future submissions. The commit title should be "ASoC: codecs: Add Awinic AW883XX audio amplifier driver" This patch needs a lot of cleanups I am afraid. On 9/23/22 13:15, wangweidong.a(a)awinic.com wrote: > From: Weidong Wang <wangweidong.a(a)awinic.com> > > The Awinic AW883XX is an I2S/TDM input, high efficiency > digital Smart K audio amplifier with an integrated 10.25V > smart boost convert > > Add a simple dirver that allows setting it up in the driver tree driver. > diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile > index 92fd441..4c91102 100644 > --- a/sound/soc/codecs/Makefile > +++ b/sound/soc/codecs/Makefile > @@ -352,6 +352,8 @@ snd-soc-tas2780-objs := tas2780.o > # Mux > snd-soc-simple-mux-objs := simple-mux.o > > +snd_soc_aw883xx-objs := aw883xx/aw883xx.o aw883xx/aw883xx_monitor.o aw883xx/aw883xx_init.o aw883xx/aw883xx_device.o aw883xx/aw883xx_calib.o aw883xx/aw883xx_bin_parse.o aw883xx/aw883xx_spin.o This split is a bit unusual > + > obj-$(CONFIG_SND_SOC_88PM860X) += snd-soc-88pm860x.o > obj-$(CONFIG_SND_SOC_AB8500_CODEC) += snd-soc-ab8500-codec.o > obj-$(CONFIG_SND_SOC_AC97_CODEC) += snd-soc-ac97.o > @@ -709,3 +711,5 @@ obj-$(CONFIG_SND_SOC_LPASS_TX_MACRO) += snd-soc-lpass-tx-macro.o > > # Mux > obj-$(CONFIG_SND_SOC_SIMPLE_MUX) += snd-soc-simple-mux.o > + > +obj-$(CONFIG_SND_SOC_AW883XX) +=snd_soc_aw883xx.o > diff --git a/sound/soc/codecs/aw883xx/aw883xx.c b/sound/soc/codecs/aw883xx/aw883xx.c > new file mode 100644 > index 0000000..b64b610 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx.c > @@ -0,0 +1,2734 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD 2022? > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#include <linux/module.h> > +#include <linux/i2c.h> > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/pcm_params.h> > +#include <sound/soc.h> > +#include <linux/of_gpio.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/firmware.h> > +#include <linux/i2c.h> > +#include <linux/debugfs.h> > +#include <linux/version.h> > +#include <linux/input.h> > +#include <linux/timer.h> > +#include <linux/workqueue.h> > +#include <linux/hrtimer.h> > +#include <linux/syscalls.h> > +#include <linux/vmalloc.h> > +#include <sound/tlv.h> > +#include <linux/uaccess.h> it's nicer if this is sorted by alphabetical order. > +#include "aw883xx_pid_2049_reg.h" > +#include "aw883xx.h" > +#include "aw883xx_bin_parse.h" > +#include "aw883xx_device.h" > +#include "aw883xx_log.h" > +#include "aw883xx_spin.h" > + > +/* > + * Marco > + */ > +#define AW883XX_I2C_NAME "aw883xx_smartpa" > + > +#define AW883XX_DRIVER_VERSION "v1.3.0" > + > +#define AW883XX_RATES (SNDRV_PCM_RATE_8000_48000 | \ > + SNDRV_PCM_RATE_96000) this doesn't include 24kHz > +#define AW883XX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \ > + SNDRV_PCM_FMTBIT_S24_LE | \ > + SNDRV_PCM_FMTBIT_S32_LE) > + > + > +#define AW883XX_ACF_FILE "aw883xx_acf.bin" > +#define AW_REQUEST_FW_RETRIES 5 /* 5 times */ > + > +static unsigned int g_aw883xx_dev_cnt; > +static DEFINE_MUTEX(g_aw883xx_lock); > +static struct aw_container *g_awinic_cfg; > + > +static const char *const aw883xx_switch[] = {"Disable", "Enable"}; > + > +static int aw883xx_platform_init(struct aw883xx *aw883xx) > +{ > +#ifdef AW_QCOM_PLATFORM > + aw883xx->aw_pa->platform = AW_QCOM; > + return 0; > +#elif defined AW_MTK_PLATFORM > + aw883xx->aw_pa->platform = AW_MTK; > + return 0; > +#elif defined AW_SPRD_PLATFORM > + aw883xx->aw_pa->platform = AW_SPRD; > + return 0; > +#else > + return -EINVAL; > +#endif that looks awful. codec drivers are supposed to be relatively common, and platform-specific configuration are usually done with device-tree bindings or machine-driver configurations. > +} > + > +int aw883xx_get_version(char *buf, int size) > +{ > + if (size > strlen(AW883XX_DRIVER_VERSION)) { > + memcpy(buf, AW883XX_DRIVER_VERSION, strlen(AW883XX_DRIVER_VERSION)); > + return strlen(AW883XX_DRIVER_VERSION); what would you return the string length? Usually success is 0 and error a negative number. > + } else { > + return -ENOMEM; > + } > +} > + > +/* > + * aw883xx append suffix sound channel information > + */ > +static void *aw883xx_devm_kstrdup(struct device *dev, char *buf) It's rather odd to re-declare your local function when there's an existing devm_kstrdup() https://elixir.bootlin.com/linux/v6.0-rc6/source/include/linux/device.h#L227 > +{ > + char *str = NULL; > + > + str = devm_kzalloc(dev, strlen(buf) + 1, GFP_KERNEL); > + if (!str) > + return str; > + memcpy(str, buf, strlen(buf)); > + return str; > +} > + > +static int aw883xx_append_i2c_suffix(char *format, > + const char **change_name, struct aw883xx *aw883xx) > +{ > + char buf[64] = { 0 }; > + int i2cbus = aw883xx->i2c->adapter->nr; > + int addr = aw883xx->i2c->addr; > + > + snprintf(buf, sizeof(buf), format, *change_name, i2cbus, addr); > + *change_name = aw883xx_devm_kstrdup(aw883xx->dev, buf); > + if (!(*change_name)) > + return -ENOMEM; > + > + aw_dev_info(aw883xx->dev, "change name :%s", *change_name); > + return 0; > +} > + > +static int aw883xx_append_channel_suffix(char *format, > + const char **change_name, struct aw883xx *aw883xx) > +{ > + char buf[64] = { 0 }; > + int channel = aw883xx->aw_pa->channel; > + > + snprintf(buf, sizeof(buf), format, *change_name, channel); > + *change_name = aw883xx_devm_kstrdup(aw883xx->dev, buf); > + if (!(*change_name)) > + return -ENOMEM; > + > + aw_dev_info(aw883xx->dev, "change name :%s", *change_name); > + return 0; > +} > + > +/* > + * aw883xx distinguish between codecs and components by version > + */ > +#ifdef AW_KERNEL_VER_OVER_4_19_1 > +static struct aw_componet_codec_ops aw_componet_codec_ops = { component > + .kcontrol_codec = snd_soc_kcontrol_component, > + .codec_get_drvdata = snd_soc_component_get_drvdata, > + .add_codec_controls = snd_soc_add_component_controls, > + .unregister_codec = snd_soc_unregister_component, > + .register_codec = snd_soc_register_component, > +}; > +#else > +static struct aw_componet_codec_ops aw_componet_codec_ops = { > + .kcontrol_codec = snd_soc_kcontrol_codec, > + .codec_get_drvdata = snd_soc_codec_get_drvdata, > + .add_codec_controls = snd_soc_add_codec_controls, > + .unregister_codec = snd_soc_unregister_codec, > + .register_codec = snd_soc_register_codec, > +}; > +#endif No, we can't deal with old kernels in upstream contributions. Remove the old stuff please. > + > +static aw_snd_soc_codec_t *aw883xx_get_codec(struct snd_soc_dai *dai) > +{ > +#ifdef AW_KERNEL_VER_OVER_4_19_1 > + return dai->component; > +#else > + return dai->codec; > +#endif > +} > + > +/* > + * aw883xx reg write/read > + */ > + > +int aw883xx_i2c_writes(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint8_t *buf, uint16_t len) > +{ > + int ret = -1; > + uint8_t *data = NULL; > + > + data = kmalloc(len + 1, GFP_KERNEL); > + if (data == NULL) > + return -ENOMEM; > + > + data[0] = reg_addr; > + memcpy(&data[1], buf, len); > + > + ret = i2c_master_send(aw883xx->i2c, data, len + 1); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c master send error"); > + goto i2c_master_error; > + } else if (ret != (len + 1)) { > + aw_dev_err(aw883xx->dev, "i2c master send error(size error)"); > + ret = -ENXIO; > + goto i2c_master_error; > + } > + > + kfree(data); > + data = NULL; > + return 0; > + > +i2c_master_error: > + kfree(data); > + data = NULL; > + return ret; isn't there an I2C helper for this and all the data transmission helpers below? > +} > + > +int aw883xx_i2c_reads(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint8_t *data_buf, > + uint16_t data_len) > +{ > + int ret; > + struct i2c_msg msg[] = { > + [0] = { > + .addr = aw883xx->i2c->addr, > + .flags = 0, > + .len = sizeof(uint8_t), > + .buf = &reg_addr, > + }, > + [1] = { > + .addr = aw883xx->i2c->addr, > + .flags = I2C_M_RD, > + .len = data_len, > + .buf = data_buf, > + }, > + }; > + > + ret = i2c_transfer(aw883xx->i2c->adapter, msg, ARRAY_SIZE(msg)); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c_transfer failed"); > + return ret; > + } else if (ret != AW883XX_READ_MSG_NUM) { > + aw_dev_err(aw883xx->dev, "transfer failed(size error)"); > + return -ENXIO; > + } > + > + return 0; > +} > + > +int aw883xx_i2c_write(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t reg_data) > +{ > + int ret = -1;> + uint8_t cnt = 0; > + uint8_t buf[2] = {0}; > + > + buf[0] = (reg_data & 0xff00) >> 8; > + buf[1] = (reg_data & 0x00ff) >> 0; > + > + while (cnt < AW_I2C_RETRIES) { > + ret = aw883xx_i2c_writes(aw883xx, reg_addr, buf, 2); > + if (ret < 0) > + aw_dev_err(aw883xx->dev, "i2c_write cnt=%d error=%d", > + cnt, ret); > + else > + break; > + cnt++; > + } > + > + if (aw883xx->i2c_log_en) > + aw_dev_info(aw883xx->dev, "write: reg = 0x%02x, val = 0x%04x", > + reg_addr, reg_data); > + > + return ret; > +} > + > +int aw883xx_i2c_read(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t *reg_data) > +{ > + int ret = -1; > + uint8_t cnt = 0; > + uint8_t buf[2] = {0}; > + > + while (cnt < AW_I2C_RETRIES) { > + ret = aw883xx_i2c_reads(aw883xx, reg_addr, buf, 2); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c_read cnt=%d error=%d", > + cnt, ret); > + } else { > + *reg_data = (buf[0] << 8) | (buf[1] << 0); > + break; > + } > + cnt++; > + } > + > + if (aw883xx->i2c_log_en) > + aw_dev_info(aw883xx->dev, "read: reg = 0x%02x, val = 0x%04x", > + reg_addr, *reg_data); > + > + return ret; > +} > + > +int aw883xx_i2c_write_bits(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t mask, > + uint16_t reg_data) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + > + ret = aw883xx_i2c_read(aw883xx, reg_addr, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c read error, ret=%d", ret); > + return ret; > + } > + reg_val &= mask; > + reg_val |= reg_data & (~mask); > + ret = aw883xx_i2c_write(aw883xx, reg_addr, reg_val); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c read error, ret=%d", ret); > + return ret; > + } > + > + return 0; > +} > + > +int aw883xx_reg_write(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t reg_data) > +{ > + int ret = -1; > + > + mutex_lock(&aw883xx->i2c_lock); > + ret = aw883xx_i2c_write(aw883xx, reg_addr, reg_data); > + if (ret < 0) > + aw_dev_err(aw883xx->dev, > + "write fail, reg = 0x%02x, val = 0x%04x, ret=%d", > + reg_addr, reg_data, ret); > + mutex_unlock(&aw883xx->i2c_lock); > + > + return ret; > +} > + > +int aw883xx_reg_read(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t *reg_data) > +{ > + int ret = -1; > + > + mutex_lock(&aw883xx->i2c_lock); > + ret = aw883xx_i2c_read(aw883xx, reg_addr, reg_data); > + if (ret < 0) > + aw_dev_err(aw883xx->dev, > + "read fail: reg = 0x%02x, val = 0x%04x, ret=%d", > + reg_addr, *reg_data, ret); > + mutex_unlock(&aw883xx->i2c_lock); > + > + return ret; > +} > + > +int aw883xx_reg_write_bits(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t mask, uint16_t reg_data) > +{ > + int ret = -1; > + > + mutex_lock(&aw883xx->i2c_lock); > + ret = aw883xx_i2c_write_bits(aw883xx, reg_addr, mask, reg_data); > + if (ret < 0) > + aw_dev_err(aw883xx->dev, > + "%s fail, ret=%d", __func__, ret); > + mutex_unlock(&aw883xx->i2c_lock); > + > + return ret; > +} > + > +static int aw883xx_dsp_write_16bit(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t dsp_data) > +{ > + int ret; > + struct aw_dsp_mem_desc *desc = &aw883xx->aw_pa->dsp_mem_desc; > + > + ret = aw883xx_i2c_write(aw883xx, desc->dsp_madd_reg, dsp_addr); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + ret = aw883xx_i2c_write(aw883xx, desc->dsp_mdat_reg, (uint16_t)dsp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + return 0; > +} > + > +static int aw883xx_dsp_write_32bit(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t dsp_data) > +{ > + int ret; > + uint16_t temp_data = 0; > + struct aw_dsp_mem_desc *desc = &aw883xx->aw_pa->dsp_mem_desc; > + > + ret = aw883xx_i2c_write(aw883xx, desc->dsp_madd_reg, dsp_addr); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + temp_data = dsp_data & AW883XX_DSP_16_DATA_MASK; > + ret = aw883xx_i2c_write(aw883xx, desc->dsp_mdat_reg, temp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + temp_data = dsp_data >> 16; > + ret = aw883xx_i2c_write(aw883xx, desc->dsp_mdat_reg, temp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + return 0; > +} > + > +/* > + * aw883xx clear dsp chip select state > + */ > +static void aw883xx_clear_dsp_sel_st(struct aw883xx *aw883xx) > +{ > + uint16_t reg_value; > + uint8_t reg = aw883xx->aw_pa->soft_rst.reg; > + > + aw883xx_i2c_read(aw883xx, reg, &reg_value); > +} > + > +int aw883xx_dsp_write(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t dsp_data, uint8_t data_type) > +{ > + int ret = -1; > + > + mutex_lock(&aw883xx->i2c_lock); > + if (data_type == AW_DSP_16_DATA) { > + ret = aw883xx_dsp_write_16bit(aw883xx, dsp_addr, dsp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "write dsp_addr[0x%04x] 16 bit dsp_data[%04x] failed", > + (uint32_t)dsp_addr, dsp_data); > + goto exit; > + } > + } else if (data_type == AW_DSP_32_DATA) { > + ret = aw883xx_dsp_write_32bit(aw883xx, dsp_addr, dsp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "write dsp_addr[0x%04x] 32 bit dsp_data[%08x] failed", > + (uint32_t)dsp_addr, dsp_data); > + goto exit; > + } > + } else { > + aw_dev_err(aw883xx->dev, "data type[%d] unsupported", data_type); > + ret = -EINVAL; > + goto exit; > + } > + > +exit: > + aw883xx_clear_dsp_sel_st(aw883xx); > + mutex_unlock(&aw883xx->i2c_lock); > + return ret; > +} > + > + > +static int aw883xx_dsp_read_16bit(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t *dsp_data) > +{ > + int ret; > + uint16_t temp_data = 0; > + struct aw_dsp_mem_desc *desc = &aw883xx->aw_pa->dsp_mem_desc; > + > + ret = aw883xx_i2c_write(aw883xx, desc->dsp_madd_reg, dsp_addr); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + ret = aw883xx_i2c_read(aw883xx, desc->dsp_mdat_reg, &temp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + *dsp_data = temp_data; > + > + return 0; > +} > + > +static int aw883xx_dsp_read_32bit(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t *dsp_data) > +{ > + int ret; > + uint16_t temp_data = 0; > + struct aw_dsp_mem_desc *desc = &aw883xx->aw_pa->dsp_mem_desc; > + > + /*write dsp addr*/ > + ret = aw883xx_i2c_write(aw883xx, desc->dsp_madd_reg, dsp_addr); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c write error, ret=%d", ret); > + return ret; > + } > + > + /*get Low 16 bit data*/ > + ret = aw883xx_i2c_read(aw883xx, desc->dsp_mdat_reg, &temp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c read error, ret=%d", ret); > + return ret; > + } > + > + *dsp_data = temp_data; > + > + /*get high 16 bit data*/ > + ret = aw883xx_i2c_read(aw883xx, desc->dsp_mdat_reg, &temp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "i2c read error, ret=%d", ret); > + return ret; > + } > + *dsp_data |= (temp_data << 16); > + > + return 0; > +} > + > +int aw883xx_dsp_read(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t *dsp_data, uint8_t data_type) > +{ > + int ret = -1; > + > + mutex_lock(&aw883xx->i2c_lock); > + if (data_type == AW_DSP_16_DATA) { > + ret = aw883xx_dsp_read_16bit(aw883xx, dsp_addr, dsp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "read dsp_addr[0x%04x] 16 bit dsp_data[%04x] failed", > + (uint32_t)dsp_addr, *dsp_data); > + goto exit; > + } > + } else if (data_type == AW_DSP_32_DATA) { > + ret = aw883xx_dsp_read_32bit(aw883xx, dsp_addr, dsp_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "read dsp_addr[0x%04x] 32 bit dsp_data[%08x] failed", > + (uint32_t)dsp_addr, *dsp_data); > + goto exit; > + } > + } else { > + aw_dev_err(aw883xx->dev, "data type[%d] unsupported", data_type); > + ret = -EINVAL; > + goto exit; > + } > + > +exit: > + aw883xx_clear_dsp_sel_st(aw883xx); > + mutex_unlock(&aw883xx->i2c_lock); > + return ret; > +} > + > +/* > + * aw883xx get dev num > + */ > +int aw883xx_get_dev_num(void) > +{ > + return g_aw883xx_dev_cnt; > +} > + > +/* > + * aw883xx interrupt > + */ > +static void aw883xx_interrupt_work(struct work_struct *work) > +{ > + struct aw883xx *aw883xx = container_of(work, > + struct aw883xx, interrupt_work.work); > + int16_t reg_value = 0; > + int ret = -1; > + > + aw_dev_info(aw883xx->dev, "enter"); don't redefine your own dev_info, and that's way to verbose for an interrupt. > + > + /*read reg value*/ > + ret = aw883xx_dev_get_int_status(aw883xx->aw_pa, &reg_value); > + if (ret < 0) > + aw_dev_err(aw883xx->dev, "get init_reg value failed"); > + else > + aw_dev_info(aw883xx->dev, "int value 0x%x", reg_value); > + > + /*clear init reg*/ spaces in comments please > + aw883xx_dev_clear_int_status(aw883xx->aw_pa); > + > + /*unmask interrupt*/ > + aw883xx_dev_set_intmask(aw883xx->aw_pa, true); > +} > + > +/* > + * Digital Audio Interface > + */ > +static int aw883xx_startup(struct snd_pcm_substream *substream, > + struct snd_soc_dai *dai) > +{ > + aw_snd_soc_codec_t *codec = aw883xx_get_codec(dai); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { > + aw_dev_info(aw883xx->dev, "playback enter"); > + /*load cali re*/ > + if (aw883xx->aw_pa->cali_desc.cali_re == AW_ERRO_CALI_RE_VALUE) > + aw883xx_cali_get_cali_re(&aw883xx->aw_pa->cali_desc); > + } else { > + aw_dev_info(aw883xx->dev, "capture enter"); that's really useless, please trim the debug logs. > + } > + > + return 0; > +} > + > +static int aw883xx_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) > +{ > + aw_snd_soc_codec_t *codec = aw883xx_get_codec(dai); > + > + aw_dev_info(codec->dev, "fmt=0x%x", fmt); > + > + return 0; > +} > + > +static int aw883xx_set_dai_sysclk(struct snd_soc_dai *dai, > + int clk_id, unsigned int freq, int dir) > +{ > + aw_snd_soc_codec_t *codec = aw883xx_get_codec(dai); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + aw_dev_info(aw883xx->dev, "freq=%d", freq); > + > + aw883xx->sysclk = freq; > + return 0; > +} > + > +static int aw883xx_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params, > + struct snd_soc_dai *dai) > +{ > + aw_snd_soc_codec_t *codec = aw883xx_get_codec(dai); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + /* get CAPTURE rate param bit width*/ > + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) { > + aw_dev_info(aw883xx->dev, > + "STREAM_CAPTURE requested rate: %d, width = %d", > + params_rate(params), params_width(params)); > + } > + > + /* get PLAYBACK rate param bit width*/ > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { > + aw_dev_info(aw883xx->dev, > + "STREAM_PLAYBACK requested rate: %d, width = %d", > + params_rate(params), params_width(params)); > + } > + > + return 0; > +} > + > +static void aw883xx_start_pa(struct aw883xx *aw883xx) > +{ > + int ret, i; > + > + aw_dev_info(aw883xx->dev, "enter"); > + > + if (aw883xx->allow_pw == false) { > + aw_dev_info(aw883xx->dev, "dev can not allow power"); > + return; > + } > + > + if (aw883xx->pstream == AW883XX_STREAM_CLOSE) { > + aw_dev_info(aw883xx->dev, "pstream is close"); > + return; > + } > + > + for (i = 0; i < AW_START_RETRIES; i++) { > + ret = aw883xx_device_start(aw883xx->aw_pa); > + if (ret) { > + aw_dev_err(aw883xx->dev, "start failed"); > + ret = aw883xx_dev_fw_update(aw883xx->aw_pa, AW_DSP_FW_UPDATE_ON, true); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "fw update failed"); > + continue; > + } > + } else { > + aw_dev_info(aw883xx->dev, "start success"); > + break; > + } > + } > +} > + > +static void aw883xx_startup_work(struct work_struct *work) > +{ > + struct aw883xx *aw883xx = > + container_of(work, struct aw883xx, start_work.work); > + > + mutex_lock(&aw883xx->lock); do you really need such high-level locks? > + aw883xx_start_pa(aw883xx); > + mutex_unlock(&aw883xx->lock); > +} > + > +static void aw883xx_start(struct aw883xx *aw883xx, bool sync_start) > +{ > + int ret; > + int i; > + > + if (aw883xx->aw_pa->fw_status == AW_DEV_FW_OK) { > + if (aw883xx->allow_pw == false) { > + aw_dev_info(aw883xx->dev, "dev can not allow power"); > + return; > + } > + > + if (aw883xx->aw_pa->status == AW_DEV_PW_ON) > + return; > + > + for (i = 0; i < AW_START_RETRIES; i++) { > + ret = aw883xx_dev_fw_update(aw883xx->aw_pa, AW_DSP_FW_UPDATE_OFF, > + aw883xx->phase_sync); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "fw update failed"); > + continue; > + } else { > + /*firmware update success*/ > + if (sync_start == AW_SYNC_START) > + aw883xx_start_pa(aw883xx); > + else > + queue_delayed_work(aw883xx->work_queue, > + &aw883xx->start_work, > + AW883XX_START_WORK_DELAY_MS); > + > + return; > + } > + } > + } > +} > + > +static int aw883xx_mute(struct snd_soc_dai *dai, int mute, int stream) > +{ > + aw_snd_soc_codec_t *codec = aw883xx_get_codec(dai); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + aw_dev_info(aw883xx->dev, "mute state=%d", mute); > + > + if (stream != SNDRV_PCM_STREAM_PLAYBACK) { > + aw_dev_info(aw883xx->dev, "capture"); > + return 0; > + } > + > + if (mute) { > + aw883xx->pstream = AW883XX_STREAM_CLOSE; > + cancel_delayed_work_sync(&aw883xx->start_work); > + mutex_lock(&aw883xx->lock); > + aw883xx_device_stop(aw883xx->aw_pa); > + mutex_unlock(&aw883xx->lock); > + } else { > + aw883xx->pstream = AW883XX_STREAM_OPEN; > + mutex_lock(&aw883xx->lock); > + aw883xx_start(aw883xx, AW_ASYNC_START); > + aw883xx_hold_dsp_spin_st(&aw883xx->aw_pa->spin_desc); > + mutex_unlock(&aw883xx->lock); > + } > + > + return 0; > +} > + > +static void aw883xx_shutdown(struct snd_pcm_substream *substream, > + struct snd_soc_dai *dai) > +{ > + aw_snd_soc_codec_t *codec = aw883xx_get_codec(dai); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) > + aw_dev_info(aw883xx->dev, "stream playback"); > + else > + aw_dev_info(aw883xx->dev, "stream capture"); > +} > + > +static const struct snd_soc_dai_ops aw883xx_dai_ops = { > + .startup = aw883xx_startup, > + .set_fmt = aw883xx_set_fmt, > + .set_sysclk = aw883xx_set_dai_sysclk, > + .hw_params = aw883xx_hw_params, > + .mute_stream = aw883xx_mute, > + .shutdown = aw883xx_shutdown, > +}; > + > +static struct snd_soc_dai_driver aw883xx_dai[] = { > + { > + .name = "aw883xx-aif", > + .id = 1, > + .playback = { > + .stream_name = "Speaker_Playback", > + .channels_min = 1, > + .channels_max = 2, > + .rates = AW883XX_RATES, > + .formats = AW883XX_FORMATS, > + }, > + .capture = { > + .stream_name = "Speaker_Capture", > + .channels_min = 1, > + .channels_max = 2, > + .rates = AW883XX_RATES, > + .formats = AW883XX_FORMATS, > + }, > + .ops = &aw883xx_dai_ops, > + /*.symmetric_rates = 1,*/ > + }, > +}; > + > +static int aw883xx_dai_drv_append_suffix(struct aw883xx *aw883xx, > + struct snd_soc_dai_driver *dai_drv, > + int num_dai) > +{ > + int ret; > + int i; > + > + if ((dai_drv != NULL) && (num_dai > 0)) { > + for (i = 0; i < num_dai; i++) { > + if (aw883xx->rename_flag == AW_RENAME_ENABLE) { > + ret = aw883xx_append_channel_suffix("%s-%d", > + &dai_drv->name, aw883xx); > + if (ret < 0) > + return ret; > + ret = aw883xx_append_channel_suffix("%s_%d", > + &dai_drv->playback.stream_name, aw883xx); > + if (ret < 0) > + return ret; > + ret = aw883xx_append_channel_suffix("%s_%d", > + &dai_drv->capture.stream_name, aw883xx); > + if (ret < 0) > + return ret; > + dev_set_name(aw883xx->dev, "%s_%d", > + "aw883xx_smartpa", aw883xx->aw_pa->channel); > + aw_dev_info(aw883xx->dev, "change dev_name:%s", > + dev_name(aw883xx->dev)); > + > + } else { > + ret = aw883xx_append_i2c_suffix("%s-%d-%x", > + &dai_drv->name, aw883xx); > + if (ret < 0) > + return ret; > + ret = aw883xx_append_i2c_suffix("%s_%d_%x", > + &dai_drv->playback.stream_name, aw883xx); > + if (ret < 0) > + return ret; > + ret = aw883xx_append_i2c_suffix("%s_%d_%x", > + &dai_drv->capture.stream_name, aw883xx); > + if (ret < 0) > + return ret; > + > + } > + > + aw_dev_info(aw883xx->dev, "dai name [%s]", dai_drv[i].name); > + aw_dev_info(aw883xx->dev, "pstream_name [%s]", > + dai_drv[i].playback.stream_name); > + aw_dev_info(aw883xx->dev, "cstream_name [%s]", > + dai_drv[i].capture.stream_name); > + } > + } > + > + return 0; not sure what this function is trying to do, but it certainly would be very hard to use the dai names for any machine driver binding if they are so dynamic and variable, no? > +} > + > +/* > + * codec driver > + */ > +static int aw883xx_get_fade_in_time(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + unsigned int time; > + > + aw883xx_dev_get_fade_time(&time, true); > + ucontrol->value.integer.value[0] = time; > + > + aw_pr_dbg("step time %ld", ucontrol->value.integer.value[0]); > + > + return 0; > + > +} > + > +static int aw883xx_set_fade_in_time(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct soc_mixer_control *mc = > + (struct soc_mixer_control *)kcontrol->private_value; > + > + if ((ucontrol->value.integer.value[0] > mc->max) || > + (ucontrol->value.integer.value[0] < mc->min)) { > + aw_pr_dbg("set val %ld overflow %d or less than :%d", > + ucontrol->value.integer.value[0], mc->max, mc->min); > + return 0; > + } > + aw883xx_dev_set_fade_time(ucontrol->value.integer.value[0], true); > + > + aw_pr_dbg("step time %ld", ucontrol->value.integer.value[0]); > + return 0; > +} > + > +static int aw883xx_get_fade_out_time(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + unsigned int time; > + > + aw883xx_dev_get_fade_time(&time, false); > + ucontrol->value.integer.value[0] = time; > + > + aw_pr_dbg("step time %ld", ucontrol->value.integer.value[0]); > + > + return 0; > +} > + > +static int aw883xx_set_fade_out_time(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct soc_mixer_control *mc = > + (struct soc_mixer_control *)kcontrol->private_value; > + > + if ((ucontrol->value.integer.value[0] > mc->max) || > + (ucontrol->value.integer.value[0] < mc->min)) { > + aw_pr_dbg("set val %ld overflow %d or less than :%d", > + ucontrol->value.integer.value[0], mc->max, mc->min); > + return 0; > + } > + > + aw883xx_dev_set_fade_time(ucontrol->value.integer.value[0], false); > + > + aw_pr_dbg("step time %ld", ucontrol->value.integer.value[0]); > + > + return 0; > +} > + > +static const struct soc_enum aw883xx_snd_enum[] = { > + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(aw883xx_switch), aw883xx_switch), > +}; > + > +static struct snd_kcontrol_new aw883xx_controls[] = { > + SOC_SINGLE_EXT("aw883xx_fadein_us", 0, 0, 1000000, 0, > + aw883xx_get_fade_in_time, aw883xx_set_fade_in_time), > + SOC_SINGLE_EXT("aw883xx_fadeout_us", 0, 0, 1000000, 0, > + aw883xx_get_fade_out_time, aw883xx_set_fade_out_time), > +}; > + > + > +static void aw883xx_add_codec_controls(struct aw883xx *aw883xx) > +{ > + aw_dev_info(aw883xx->dev, "enter"); > + > + if (aw883xx->aw_pa->channel == 0) { > + aw_componet_codec_ops.add_codec_controls(aw883xx->codec, > + &aw883xx_controls[0], ARRAY_SIZE(aw883xx_controls)); > + aw883xx_add_spin_controls((void *)aw883xx); > + } > +} > + > +static int aw883xx_profile_info(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_info *uinfo) > +{ > + int count; > + char *name = NULL; > + const char *prof_name = NULL; > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); component typo. please fix this in all the file. > + > + uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED; > + uinfo->count = 1; > + > + count = aw883xx_dev_get_profile_count(aw883xx->aw_pa); > + if (count <= 0) { > + uinfo->value.enumerated.items = 0; > + aw_dev_err(aw883xx->dev, "get count[%d] failed", count); > + return 0; > + } > + > + uinfo->value.enumerated.items = count; > + > + if (uinfo->value.enumerated.item >= count) > + uinfo->value.enumerated.item = count - 1; > + > + name = uinfo->value.enumerated.name; > + count = uinfo->value.enumerated.item; > + > + prof_name = aw_dev_get_prof_name(aw883xx->aw_pa, count); > + if (prof_name == NULL) { > + strscpy(uinfo->value.enumerated.name, "null", > + strlen("null") + 1); > + return 0; > + } > + > + strscpy(name, prof_name, sizeof(uinfo->value.enumerated.name)); > + > + return 0; > +} > + > +static int aw883xx_profile_get(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + ucontrol->value.integer.value[0] = aw883xx_dev_get_profile_index(aw883xx->aw_pa); > + aw_dev_dbg(codec->dev, "profile index [%d]", > + aw883xx_dev_get_profile_index(aw883xx->aw_pa)); > + return 0; > + > +} > + > +static int aw883xx_profile_set(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + int ret; > + int cur_index; > + > + if (aw883xx->dbg_en_prof == false) { > + aw_dev_info(codec->dev, "profile close"); > + return 0; > + } > + > + /* check value valid */ > + ret = aw883xx_dev_check_profile_index(aw883xx->aw_pa, ucontrol->value.integer.value[0]); > + if (ret) { > + aw_dev_info(codec->dev, "unsupported index %ld", > + ucontrol->value.integer.value[0]); > + return 0; > + } > + > + /*check cur_index == set value*/ > + cur_index = aw883xx_dev_get_profile_index(aw883xx->aw_pa); > + if (cur_index == ucontrol->value.integer.value[0]) { > + aw_dev_info(codec->dev, "index no change"); > + return 0; > + } > + > + /*pa stop or stopping just set profile*/ > + mutex_lock(&aw883xx->lock); > + aw883xx_dev_set_profile_index(aw883xx->aw_pa, ucontrol->value.integer.value[0]); > + > + if (aw883xx->pstream) { > + aw883xx_device_stop(aw883xx->aw_pa); > + aw883xx_start(aw883xx, AW_SYNC_START); > + } > + > + mutex_unlock(&aw883xx->lock); > + > + aw_dev_info(codec->dev, "profile id %ld", ucontrol->value.integer.value[0]); > + return 0; > +} > + > +static int aw883xx_switch_info(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_info *uinfo) > +{ > + int count; > + > + uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED; > + uinfo->count = 1; > + count = 2; > + > + uinfo->value.enumerated.items = count; > + > + if (uinfo->value.enumerated.item >= count) > + uinfo->value.enumerated.item = count - 1; > + > + strscpy(uinfo->value.enumerated.name, > + aw883xx_switch[uinfo->value.enumerated.item], > + strlen(aw883xx_switch[uinfo->value.enumerated.item]) + 1); > + > + return 0; > +} > + > +static int aw883xx_switch_get(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + ucontrol->value.integer.value[0] = aw883xx->allow_pw; > + > + return 0; > +} > + > +static int aw883xx_switch_set(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + > + aw_dev_info(codec->dev, "set value:%ld", ucontrol->value.integer.value[0]); > + > + if (ucontrol->value.integer.value[0] == aw883xx->allow_pw) { > + aw_dev_info(aw883xx->dev, "PA switch not change"); > + return 0; > + } > + > + if (aw883xx->pstream) { > + if (ucontrol->value.integer.value[0] == 0) { > + cancel_delayed_work_sync(&aw883xx->start_work); > + mutex_lock(&aw883xx->lock); > + aw883xx_device_stop(aw883xx->aw_pa); > + aw883xx->allow_pw = false; > + mutex_unlock(&aw883xx->lock); > + } else { > + cancel_delayed_work_sync(&aw883xx->start_work); > + mutex_lock(&aw883xx->lock); > + aw883xx->allow_pw = true; > + aw883xx_start(aw883xx, AW_SYNC_START); > + mutex_unlock(&aw883xx->lock); > + } > + } else { > + mutex_lock(&aw883xx->lock); > + if (ucontrol->value.integer.value[0]) > + aw883xx->allow_pw = true; > + else > + aw883xx->allow_pw = false; > + mutex_unlock(&aw883xx->lock); > + } > + > + return 0; > +} > + > +static int aw883xx_monitor_switch_info(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_info *uinfo) > +{ > + int count; > + > + uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED; > + uinfo->count = 1; > + count = 2; > + > + uinfo->value.enumerated.items = count; > + > + if (uinfo->value.enumerated.item >= count) > + uinfo->value.enumerated.item = count - 1; > + > + strscpy(uinfo->value.enumerated.name, > + aw883xx_switch[uinfo->value.enumerated.item], > + strlen(aw883xx_switch[uinfo->value.enumerated.item]) + 1); > + > + return 0; > +} > + > +static int aw883xx_monitor_switch_get(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + struct aw_monitor_desc *monitor_desc = &aw883xx->aw_pa->monitor_desc; > + > + ucontrol->value.integer.value[0] = monitor_desc->monitor_cfg.monitor_switch; > + > + return 0; > +} > + > +static int aw883xx_monitor_switch_set(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + struct aw_monitor_desc *monitor_desc = &aw883xx->aw_pa->monitor_desc; > + uint32_t enable = 0; > + > + aw_dev_info(codec->dev, "set monitor_switch:%ld", ucontrol->value.integer.value[0]); > + > + enable = (uint32_t)ucontrol->value.integer.value[0]; > + > + if (monitor_desc->monitor_cfg.monitor_switch != enable) { > + monitor_desc->monitor_cfg.monitor_switch = enable; > + if (enable) > + aw883xx_monitor_start(monitor_desc); > + } else { > + aw_dev_info(aw883xx->dev, "monitor_switch not change"); > + return 0; > + } > + > + return 0; > +} > + > +static int aw883xx_volume_info(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_info *uinfo) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + struct aw_volume_desc *vol_desc = &aw883xx->aw_pa->volume_desc; > + > + /* set kcontrol info */ > + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; > + uinfo->count = 1; > + uinfo->value.integer.min = 0; > + uinfo->value.integer.max = vol_desc->mute_volume; > + > + return 0; > +} > + > +static int aw883xx_volume_get(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + struct aw_volume_desc *vol_desc = &aw883xx->aw_pa->volume_desc; > + > + ucontrol->value.integer.value[0] = vol_desc->ctl_volume; > + > + aw_dev_info(aw883xx->dev, "ucontrol->value.integer.value[0]=%d", > + vol_desc->ctl_volume); > + > + return 0; > +} > + > +static int aw883xx_volume_set(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + uint16_t value = 0; > + uint16_t compared_vol = 0; > + aw_snd_soc_codec_t *codec = > + aw_componet_codec_ops.kcontrol_codec(kcontrol); > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(codec); > + struct aw_volume_desc *vol_desc = &aw883xx->aw_pa->volume_desc; > + > + value = (uint16_t)ucontrol->value.integer.value[0]; > + if (value > vol_desc->mute_volume) { > + aw_dev_err(aw883xx->dev, "value over range\n"); > + return -EINVAL; > + } > + > + aw_dev_info(aw883xx->dev, "ucontrol->value.integer.value[0]=%d", value); > + > + vol_desc->ctl_volume = value; > + > + /*get smaller dB*/ > + compared_vol = AW_GET_MAX_VALUE(vol_desc->ctl_volume, > + vol_desc->monitor_volume); > + > + aw883xx_dev_set_volume(aw883xx->aw_pa, compared_vol); > + > + return 0; > +} > + > +static int aw883xx_dynamic_create_controls(struct aw883xx *aw883xx) > +{ > + struct snd_kcontrol_new *aw883xx_dev_control = NULL; > + char *kctl_name = NULL; > + > + aw883xx_dev_control = devm_kzalloc(aw883xx->codec->dev, > + sizeof(struct snd_kcontrol_new) * AW_KCONTROL_NUM, GFP_KERNEL); > + if (aw883xx_dev_control == NULL) > + return -ENOMEM; > + > + kctl_name = devm_kzalloc(aw883xx->codec->dev, AW_NAME_BUF_MAX, GFP_KERNEL); > + if (kctl_name == NULL) if (!ptr) in all checks please. > + return -ENOMEM; > + > + snprintf(kctl_name, AW_NAME_BUF_MAX, "aw_dev_%u_prof", > + aw883xx->aw_pa->channel); > + > + aw883xx_dev_control[0].name = kctl_name; > + aw883xx_dev_control[0].iface = SNDRV_CTL_ELEM_IFACE_MIXER; > + aw883xx_dev_control[0].info = aw883xx_profile_info; > + aw883xx_dev_control[0].get = aw883xx_profile_get; > + aw883xx_dev_control[0].put = aw883xx_profile_set; > + > + kctl_name = devm_kzalloc(aw883xx->codec->dev, AW_NAME_BUF_MAX, GFP_KERNEL); > + if (!kctl_name) > + return -ENOMEM; > + > + snprintf(kctl_name, AW_NAME_BUF_MAX, "aw_dev_%u_switch", aw883xx->aw_pa->channel); > + > + aw883xx_dev_control[1].name = kctl_name; > + aw883xx_dev_control[1].iface = SNDRV_CTL_ELEM_IFACE_MIXER; > + aw883xx_dev_control[1].info = aw883xx_switch_info; > + aw883xx_dev_control[1].get = aw883xx_switch_get; > + aw883xx_dev_control[1].put = aw883xx_switch_set; > + > + kctl_name = devm_kzalloc(aw883xx->codec->dev, AW_NAME_BUF_MAX, GFP_KERNEL); > + if (!kctl_name) > + return -ENOMEM; > + > + snprintf(kctl_name, AW_NAME_BUF_MAX, "aw_dev_%u_monitor_switch", aw883xx->aw_pa->channel); > + > + aw883xx_dev_control[2].name = kctl_name; > + aw883xx_dev_control[2].iface = SNDRV_CTL_ELEM_IFACE_MIXER; > + aw883xx_dev_control[2].info = aw883xx_monitor_switch_info; > + aw883xx_dev_control[2].get = aw883xx_monitor_switch_get; > + aw883xx_dev_control[2].put = aw883xx_monitor_switch_set; > + > + kctl_name = devm_kzalloc(aw883xx->codec->dev, AW_NAME_BUF_MAX, GFP_KERNEL); > + if (!kctl_name) > + return -ENOMEM; > + > + snprintf(kctl_name, AW_NAME_BUF_MAX, "aw_dev_%d_rx_volume", aw883xx->aw_pa->channel); > + > + aw883xx_dev_control[3].name = kctl_name; > + aw883xx_dev_control[3].iface = SNDRV_CTL_ELEM_IFACE_MIXER; > + aw883xx_dev_control[3].info = aw883xx_volume_info; > + aw883xx_dev_control[3].get = aw883xx_volume_get; > + aw883xx_dev_control[3].put = aw883xx_volume_set; > + > + aw_componet_codec_ops.add_codec_controls(aw883xx->codec, > + aw883xx_dev_control, AW_KCONTROL_NUM); > + > + return 0; > +} > + > +static int aw883xx_request_firmware_file(struct aw883xx *aw883xx) > +{ > + const struct firmware *cont = NULL; > + struct aw_container *aw_cfg = NULL; > + int ret = -1; > + int i; > + > + aw883xx->aw_pa->fw_status = AW_DEV_FW_FAILED; > + > + for (i = 0; i < AW_REQUEST_FW_RETRIES; i++) { > + ret = request_firmware(&cont, AW883XX_ACF_FILE, aw883xx->dev); > + if ((ret < 0) || (!cont)) { > + aw883xx->fw_retry_cnt++; > + aw_dev_err(aw883xx->dev, "load [%s] try [%d]!", > + AW883XX_ACF_FILE, aw883xx->fw_retry_cnt); > + > + if (aw883xx->fw_retry_cnt == AW_REQUEST_FW_RETRIES) { > + aw883xx->fw_retry_cnt = 0; > + return ret; > + } > + msleep(1000); > + } else { > + break; > + } what makes you think that waiting and retrying is a good way to deal with a missing firmware file? > + } > + > + aw_dev_info(aw883xx->dev, "loaded %s - size: %zu", > + AW883XX_ACF_FILE, cont ? cont->size : 0); > + > + mutex_lock(&g_aw883xx_lock); > + if (g_awinic_cfg == NULL) { > + aw_cfg = vzalloc(cont->size + sizeof(int)); > + if (aw_cfg == NULL) { > + release_firmware(cont); > + mutex_unlock(&g_aw883xx_lock); > + return -ENOMEM; > + } > + aw_cfg->len = (int)cont->size; > + memcpy(aw_cfg->data, cont->data, cont->size); > + ret = aw883xx_dev_load_acf_check(aw_cfg); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "Load [%s] failed ....!", AW883XX_ACF_FILE); > + vfree(aw_cfg); > + aw_cfg = NULL; > + release_firmware(cont); > + mutex_unlock(&g_aw883xx_lock); > + return ret; > + } > + g_awinic_cfg = aw_cfg; > + } else { > + aw_cfg = g_awinic_cfg; > + aw_dev_info(aw883xx->dev, "[%s] already loaded...", AW883XX_ACF_FILE); > + } > + release_firmware(cont); > + mutex_unlock(&g_aw883xx_lock); > + > + mutex_lock(&aw883xx->lock); > + /*aw device init*/ > + ret = aw883xx_device_init(aw883xx->aw_pa, aw_cfg); > + if (ret < 0) { > + aw_dev_info(aw883xx->dev, "dev init failed"); > + mutex_unlock(&aw883xx->lock); > + return ret; > + } > + > + aw883xx_dynamic_create_controls(aw883xx); > + > + aw883xx_check_spin_mode(&aw883xx->aw_pa->spin_desc); > + > + mutex_unlock(&aw883xx->lock); > + > + return 0; > +} > + > +static void aw883xx_fw_wrok(struct work_struct *work) > +{ > + struct aw883xx *aw883xx = container_of(work, > + struct aw883xx, acf_work.work); > + int ret; > + > + ret = aw883xx_request_firmware_file(aw883xx); > + if (ret < 0) > + aw_dev_err(aw883xx->dev, "load profile failed"); > + > +} > + > +static void aw883xx_load_fw(struct aw883xx *aw883xx) > +{ > +#ifdef AW_SYNC_LOAD > + /*sync loading*/ > + aw883xx_request_firmware_file(aw883xx); > +#else > + /*async loading*/ > + queue_delayed_work(aw883xx->work_queue, > + &aw883xx->acf_work, > + msecs_to_jiffies(AW883XX_LOAD_FW_DELAY_TIME)); > +#endif > +} > + > +#ifdef AW_MTK_PLATFORM > + > +static const struct snd_soc_dapm_widget aw883xx_dapm_widgets[] = { > + /* playback */ > + SND_SOC_DAPM_AIF_IN("AIF_RX", "Speaker_Playback", 0, SND_SOC_NOPM, 0, 0), > + SND_SOC_DAPM_OUTPUT("audio_out"), > + /* capture */ > + SND_SOC_DAPM_AIF_OUT("AIF_TX", "Speaker_Capture", 0, SND_SOC_NOPM, 0, 0), > + SND_SOC_DAPM_INPUT("iv_in"), > +}; > + > +static const struct snd_soc_dapm_route aw883xx_audio_map[] = { > + {"audio_out", NULL, "AIF_RX"}, > + {"AIF_TX", NULL, "iv_in"}, > +}; > + > +#if KERNEL_VERSION(4, 2, 0) > LINUX_VERSION_CODE > +static struct snd_soc_dapm_context *snd_soc_codec_get_dapm(struct snd_soc_codec *codec) > +{ > + return &codec->dapm; > +} > +#endif > + > +static int aw883xx_add_widgets(struct aw883xx *aw883xx) > +{ > + int i = 0; > + int ret; > + struct snd_soc_dapm_widget *aw_widgets = NULL; > + struct snd_soc_dapm_route *aw_route = NULL; > +#ifdef AW_KERNEL_VER_OVER_4_19_1 > + struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(aw883xx->codec); > +#else > + struct snd_soc_dapm_context *dapm = snd_soc_codec_get_dapm(aw883xx->codec); > +#endif > + > + /*add widgets*/ > + aw_widgets = devm_kzalloc(aw883xx->dev, > + sizeof(struct snd_soc_dapm_widget) * > + ARRAY_SIZE(aw883xx_dapm_widgets), > + GFP_KERNEL); > + if (!aw_widgets) > + return -ENOMEM; > + > + memcpy(aw_widgets, aw883xx_dapm_widgets, > + sizeof(struct snd_soc_dapm_widget) * ARRAY_SIZE(aw883xx_dapm_widgets)); > + > + for (i = 0; i < ARRAY_SIZE(aw883xx_dapm_widgets); i++) { > + if (aw883xx->rename_flag == AW_RENAME_ENABLE) { > + if (aw_widgets[i].name) { > + ret = aw883xx_append_channel_suffix("%s_%d", > + &aw_widgets[i].name, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_widgets.name append channel suffix failed!\n"); > + return ret; > + } > + } > + > + if (aw_widgets[i].sname) { > + ret = aw883xx_append_channel_suffix("%s_%d", > + &aw_widgets[i].sname, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_widgets.name append channel suffix failed!"); > + return ret; > + } > + } > + } else { > + if (aw_widgets[i].name) { > + ret = aw883xx_append_i2c_suffix("%s_%d_%x", > + &aw_widgets[i].name, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_widgets.name append i2c suffix failed!\n"); > + return ret; > + } > + } > + > + if (aw_widgets[i].sname) { > + ret = aw883xx_append_i2c_suffix("%s_%d_%x", > + &aw_widgets[i].sname, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_widgets.name append i2c suffix failed!"); > + return ret; > + } > + } > + } > + > + } > + > + snd_soc_dapm_new_controls(dapm, aw_widgets, ARRAY_SIZE(aw883xx_dapm_widgets)); > + > + /*add route*/ > + aw_route = devm_kzalloc(aw883xx->dev, > + sizeof(struct snd_soc_dapm_route) * ARRAY_SIZE(aw883xx_audio_map), > + GFP_KERNEL); > + if (!aw_route) > + return -ENOMEM; > + > + memcpy(aw_route, aw883xx_audio_map, > + sizeof(struct snd_soc_dapm_route) * ARRAY_SIZE(aw883xx_audio_map)); > + > + for (i = 0; i < ARRAY_SIZE(aw883xx_audio_map); i++) { > + if (aw883xx->rename_flag == AW_RENAME_ENABLE) { > + if (aw_route[i].sink) { > + ret = aw883xx_append_channel_suffix("%s_%d", > + &aw_route[i].sink, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_route.sink append channel suffix failed!"); > + return ret; > + } > + } > + if (aw_route[i].source) { > + ret = aw883xx_append_channel_suffix("%s_%d", > + &aw_route[i].source, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_route.source append channel suffix failed!"); > + return ret; > + } > + } > + } else { > + if (aw_route[i].sink) { > + ret = aw883xx_append_i2c_suffix("%s_%d_%x", > + &aw_route[i].sink, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_route.sink append i2c suffix failed!"); > + return ret; > + } > + } > + if (aw_route[i].source) { > + ret = aw883xx_append_i2c_suffix("%s_%d_%x", > + &aw_route[i].source, > + aw883xx); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "aw_route.source append i2c suffix failed!"); > + return ret; > + } > + } > + } > + > + > + } > + snd_soc_dapm_add_routes(dapm, aw_route, ARRAY_SIZE(aw883xx_audio_map)); > + > + return 0; > +} > +#endif > + > +static int aw883xx_codec_probe(aw_snd_soc_codec_t *aw_codec) > +{ > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(aw_codec); > + > + aw_dev_info(aw883xx->dev, "enter"); > + > + /*destroy_workqueue(struct workqueue_struct *wq)*/ > + aw883xx->work_queue = create_singlethread_workqueue("aw883xx"); > + if (!aw883xx->work_queue) { > + aw_dev_err(aw883xx->dev, "create workqueue failed !"); > + return -EINVAL; > + } > + > + INIT_DELAYED_WORK(&aw883xx->interrupt_work, aw883xx_interrupt_work); > + INIT_DELAYED_WORK(&aw883xx->start_work, aw883xx_startup_work); > + INIT_DELAYED_WORK(&aw883xx->acf_work, aw883xx_fw_wrok); > + > + aw883xx->codec = aw_codec; > +aw_dev_info(aw883xx->dev, "ex0"); > + aw883xx_add_codec_controls(aw883xx); > + aw_dev_info(aw883xx->dev, "ex1"); > +#ifdef AW_MTK_PLATFORM > + aw883xx_add_widgets(aw883xx); > +#endif > +aw_dev_info(aw883xx->dev, "ex2"); > + aw883xx_load_fw(aw883xx); > +aw_dev_info(aw883xx->dev, "ex3"); > + return 0; > +} > + > +#ifdef AW_KERNEL_VER_OVER_4_19_1 > +static void aw883xx_codec_remove(aw_snd_soc_codec_t *aw_codec) > +{ > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(aw_codec); > + > + aw_dev_info(aw883xx->dev, "enter"); > + dump_stack(); > + cancel_delayed_work_sync(&aw883xx->interrupt_work); > + cancel_delayed_work_sync(&aw883xx->acf_work); > + cancel_delayed_work_sync(&aw883xx->aw_pa->monitor_desc.delay_work); > + cancel_delayed_work_sync(&aw883xx->start_work); > + > + if (aw883xx->work_queue) > + destroy_workqueue(aw883xx->work_queue); > + > + aw883xx_dev_deinit(aw883xx->aw_pa); > +} > +#else > +static int aw883xx_codec_remove(aw_snd_soc_codec_t *aw_codec) > +{ > + struct aw883xx *aw883xx = > + aw_componet_codec_ops.codec_get_drvdata(aw_codec); > + > + aw_dev_info(aw883xx->dev, "enter"); > + > + cancel_delayed_work_sync(&aw883xx->interrupt_work); > + cancel_delayed_work_sync(&aw883xx->acf_work); > + cancel_delayed_work_sync(&aw883xx->aw_pa->monitor_desc.delay_work); > + cancel_delayed_work_sync(&aw883xx->start_work); > + > + if (aw883xx->work_queue) > + destroy_workqueue(aw883xx->work_queue); > + > + aw883xx_dev_deinit(aw883xx->aw_pa); > + > + return 0; > +} > +#endif > + > +#ifdef AW_KERNEL_VER_OVER_4_19_1 > +static const struct snd_soc_component_driver soc_codec_dev_aw883xx = { > + .probe = aw883xx_codec_probe, > + .remove = aw883xx_codec_remove, > +}; > +#else > +static struct snd_soc_codec_driver soc_codec_dev_aw883xx = { > + .probe = aw883xx_codec_probe, > + .remove = aw883xx_codec_remove, > +}; > +#endif > + > +static int aw883xx_componet_codec_register(struct aw883xx *aw883xx) > +{ > + struct snd_soc_dai_driver *dai_drv = NULL; > + int ret; > + > + dai_drv = devm_kzalloc(aw883xx->dev, sizeof(aw883xx_dai), GFP_KERNEL); > + if (dai_drv == NULL) > + return -ENOMEM; > + > + memcpy(dai_drv, aw883xx_dai, sizeof(aw883xx_dai)); > + > + ret = aw883xx_dai_drv_append_suffix(aw883xx, dai_drv, 1); > + if (ret < 0) > + return ret; > + > + ret = aw883xx->codec_ops->register_codec(aw883xx->dev, > + &soc_codec_dev_aw883xx, > + dai_drv, ARRAY_SIZE(aw883xx_dai)); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "failed to register aw883xx: %d", ret); > + return ret; > + } > + > + if (aw883xx->rename_flag == AW_RENAME_ENABLE) { > + dev_set_name(aw883xx->dev, "%d-00%x", > + aw883xx->i2c->adapter->nr, aw883xx->i2c->addr); > + aw_dev_info(aw883xx->dev, "reset dev_name:%s", > + dev_name(aw883xx->dev)); > + } > + > + return 0; > +} > + > + > +static struct aw883xx *aw883xx_malloc_init(struct i2c_client *i2c) > +{ > + struct aw883xx *aw883xx = devm_kzalloc(&i2c->dev, > + sizeof(struct aw883xx), GFP_KERNEL); > + if (aw883xx == NULL) > + return NULL; > + > + aw883xx->dev = &i2c->dev; > + aw883xx->i2c = i2c; > + aw883xx->aw_pa = NULL; > + aw883xx->codec = NULL; > + aw883xx->codec_ops = &aw_componet_codec_ops; > + aw883xx->dbg_en_prof = true; > + aw883xx->allow_pw = true; > + aw883xx->work_queue = NULL; > + aw883xx->i2c_log_en = 0; > + mutex_init(&aw883xx->lock); > + mutex_init(&aw883xx->i2c_lock); > + > + return aw883xx; > +} > + > +static int aw883xx_gpio_request(struct aw883xx *aw883xx) > +{ > + int ret; > + > + if (gpio_is_valid(aw883xx->reset_gpio)) { > + ret = devm_gpio_request_one(aw883xx->dev, aw883xx->reset_gpio, > + GPIOF_OUT_INIT_LOW, "aw883xx_rst"); > + if (ret) { > + aw_dev_err(aw883xx->dev, "rst request failed"); > + return ret; > + } > + } > + > + if (gpio_is_valid(aw883xx->irq_gpio)) { > + ret = devm_gpio_request_one(aw883xx->dev, aw883xx->irq_gpio, > + GPIOF_DIR_IN, "aw883xx_int"); > + if (ret) { > + aw_dev_err(aw883xx->dev, "int request failed"); > + return ret; > + } > + } > + > + return 0; > +} > + > +/* > + * device tree > + */ > +static int aw883xx_parse_gpio_dt(struct aw883xx *aw883xx) > +{ > + struct device_node *np = aw883xx->dev->of_node; > + > + aw883xx->reset_gpio = of_get_named_gpio(np, "reset-gpio", 0); > + if (aw883xx->reset_gpio < 0) { > + aw_dev_err(aw883xx->dev, "no reset gpio provided, will not hw reset"); > + //return -EIO; remove? > + } else { > + aw_dev_info(aw883xx->dev, "reset gpio provided ok"); > + } > + > + aw883xx->irq_gpio = of_get_named_gpio(np, "irq-gpio", 0); > + if (aw883xx->irq_gpio < 0) > + aw_dev_info(aw883xx->dev, "no irq gpio provided."); > + else > + aw_dev_info(aw883xx->dev, "irq gpio provided ok."); > + > + return 0; > +} > + > +static void aw883xx_parse_sync_flag_dt(struct aw883xx *aw883xx) > +{ > + int ret; > + int32_t sync_enable = 0; > + struct device_node *np = aw883xx->dev->of_node; > + > + ret = of_property_read_u32(np, "sync-flag", &sync_enable); > + if (ret < 0) { > + aw_dev_info(aw883xx->dev, > + "read sync flag failed,default phase sync off"); > + sync_enable = false; > + } else { > + aw_dev_info(aw883xx->dev, > + "sync flag is %d", sync_enable); > + } > + > + aw883xx->phase_sync = sync_enable; > +} > + > +static void aw883xx_parse_rename_flag_dt(struct aw883xx *aw883xx) > +{ > + int ret; > + uint32_t rename_enable = 0; > + struct device_node *np = aw883xx->dev->of_node; > + > + ret = of_property_read_u32(np, "rename-flag", &rename_enable); > + if (ret < 0) { > + aw_dev_info(aw883xx->dev, > + "read rename flag failed,default rename off"); > + } else { > + aw_dev_info(aw883xx->dev, > + "rename flag is %d", rename_enable); > + } > + > + aw883xx->rename_flag = rename_enable; > +} > + > +static int aw883xx_parse_dt(struct aw883xx *aw883xx) > +{ > + aw883xx_parse_sync_flag_dt(aw883xx); > + aw883xx_parse_rename_flag_dt(aw883xx); > + return aw883xx_parse_gpio_dt(aw883xx); > +} > + > +static int aw883xx_hw_reset(struct aw883xx *aw883xx) > +{ > + aw_dev_info(aw883xx->dev, "enter"); > + > + if (gpio_is_valid(aw883xx->reset_gpio)) { > + gpio_set_value_cansleep(aw883xx->reset_gpio, 0); > + usleep_range(AW_1000_US, AW_1000_US + 10); > + gpio_set_value_cansleep(aw883xx->reset_gpio, 1); > + usleep_range(AW_1000_US, AW_1000_US + 10); > + } else { > + aw_dev_err(aw883xx->dev, "failed"); > + } > + return 0; > +} > + > +static int aw883xx_read_chipid(struct aw883xx *aw883xx) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + > + ret = aw883xx_reg_read(aw883xx, AW883XX_CHIP_ID_REG, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, > + "failed to read chip id, ret=%d", ret); > + return -EIO; > + } > + > + aw883xx->chip_id = reg_val; > + aw_dev_info(aw883xx->dev, > + "read chip id: 0x%x", reg_val); > + > + return 0; > +} > + > +/* > + * irq > + */ > +static irqreturn_t aw883xx_irq(int irq, void *data) > +{ > + struct aw883xx *aw883xx = data; > + > + if (aw883xx == NULL) { > + aw_pr_err("pointer is NULL"); > + return -EINVAL; > + } > + > + aw_dev_info(aw883xx->dev, "enter"); > + /*mask all irq*/ > + aw883xx_dev_set_intmask(aw883xx->aw_pa, false); > + > + /*upload workqueue*/ > + if (aw883xx->work_queue) > + queue_delayed_work(aw883xx->work_queue, > + &aw883xx->interrupt_work, 0); > + > + return IRQ_HANDLED; > +} > + > +static int aw883xx_interrupt_init(struct aw883xx *aw883xx) > +{ > + int irq_flags; > + int ret; > + > + if (gpio_is_valid(aw883xx->irq_gpio)) { > + irq_flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT; > + ret = devm_request_threaded_irq(aw883xx->dev, > + gpio_to_irq(aw883xx->irq_gpio), > + NULL, aw883xx_irq, irq_flags, > + "aw883xx", aw883xx); > + if (ret) { > + aw_dev_err(aw883xx->dev, "Failed to request IRQ %d: %d", > + gpio_to_irq(aw883xx->irq_gpio), ret); > + return ret; > + } > + } else { > + aw_dev_info(aw883xx->dev, "skipping IRQ registration"); > + } > + > + return 0; > +} > + > + > +/* > + * sys group attribute: reg > + */ > +static ssize_t aw883xx_reg_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + int reg_num = aw883xx->aw_pa->ops.aw_get_reg_num(); > + ssize_t len = 0; > + uint8_t i = 0; > + uint16_t reg_val = 0; > + > + for (i = 0; i < reg_num; i++) { > + if (aw883xx->aw_pa->ops.aw_check_rd_access(i)) { > + aw883xx_reg_read(aw883xx, i, &reg_val); > + len += snprintf(buf + len, PAGE_SIZE - len, > + "reg:0x%02x=0x%04x\n", i, reg_val); > + } > + } > + > + return len; > +} > + > +static ssize_t aw883xx_reg_store(struct device *dev, > + struct device_attribute *attr, const char *buf, > + size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + unsigned int databuf[2] = { 0 }; > + > + if (sscanf(buf, "%x %x", &databuf[0], &databuf[1]) == 2) > + aw883xx_reg_write(aw883xx, databuf[0], databuf[1]); > + > + return count; > +} > + > +static ssize_t aw883xx_rw_store(struct device *dev, > + struct device_attribute *attr, const char *buf, > + size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + unsigned int databuf[2] = { 0 }; > + > + if (sscanf(buf, "%x %x", &databuf[0], &databuf[1]) == 2) { > + aw883xx->reg_addr = (uint8_t)databuf[0]; > + if (aw883xx->aw_pa->ops.aw_check_rd_access(databuf[0])) > + aw883xx_reg_write(aw883xx, databuf[0], databuf[1]); > + } else if (sscanf(buf, "%x", &databuf[0]) == 1) { > + aw883xx->reg_addr = (uint8_t)databuf[0]; > + } > + > + return count; > +} > + > +static ssize_t aw883xx_rw_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + uint16_t reg_val = 0; > + > + if (aw883xx->aw_pa->ops.aw_check_rd_access(aw883xx->reg_addr)) { > + aw883xx_reg_read(aw883xx, aw883xx->reg_addr, &reg_val); > + len += snprintf(buf + len, PAGE_SIZE - len, > + "reg:0x%02x=0x%04x\n", aw883xx->reg_addr, > + reg_val); > + } > + > + return len; > +} > + > +static ssize_t aw883xx_drv_ver_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + ssize_t len = 0; > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "driver_ver: %s\n", AW883XX_DRIVER_VERSION); > + > + return len; > +} > + > +static ssize_t aw883xx_dsp_rw_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + uint16_t reg_val = 0; > + > + mutex_lock(&aw883xx->i2c_lock); > + aw883xx_i2c_write(aw883xx, aw883xx->aw_pa->dsp_mem_desc.dsp_madd_reg, aw883xx->dsp_addr); > + aw883xx_i2c_read(aw883xx, aw883xx->aw_pa->dsp_mem_desc.dsp_mdat_reg, &reg_val); > + len += snprintf(buf + len, PAGE_SIZE - len, > + "dsp:0x%04x=0x%04x\n", aw883xx->dsp_addr, reg_val); > + aw883xx_i2c_read(aw883xx, aw883xx->aw_pa->dsp_mem_desc.dsp_mdat_reg, &reg_val); > + len += snprintf(buf + len, PAGE_SIZE - len, > + "dsp:0x%04x=0x%04x\n", aw883xx->dsp_addr + 1, reg_val); > + aw883xx_clear_dsp_sel_st(aw883xx); > + mutex_unlock(&aw883xx->i2c_lock); > + > + return len; > +} > + > +static ssize_t aw883xx_dsp_rw_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + unsigned int databuf[2] = { 0 }; > + > + if (sscanf(buf, "%x %x", &databuf[0], &databuf[1]) == 2) { > + aw883xx->dsp_addr = (unsigned int)databuf[0]; > + aw883xx_dsp_write(aw883xx, databuf[0], databuf[1], AW_DSP_16_DATA); > + aw_dev_dbg(aw883xx->dev, "get param: %x %x", > + databuf[0], databuf[1]); > + } else if (sscanf(buf, "%x", &databuf[0]) == 1) { > + aw883xx->dsp_addr = (unsigned int)databuf[0]; > + aw_dev_dbg(aw883xx->dev, "get param: %x", > + databuf[0]); > + } > + aw883xx_clear_dsp_sel_st(aw883xx); > + > + return count; > +} > + > +static int aw883xx_awrw_write(struct aw883xx *aw883xx, const char *buf, size_t count) > +{ > + int i, ret; > + char *data_buf = NULL; > + int str_len, data_len, temp_data; > + struct aw883xx_i2c_packet *packet = &aw883xx->i2c_packet; > + uint32_t dsp_addr_h = 0, dsp_addr_l = 0; > + > + if (buf == NULL) { > + aw_dev_err(aw883xx->dev, "awrw buf is NULL"); > + return -EINVAL; > + } > + > + data_len = AWRW_DATA_BYTES * packet->reg_num; > + > + str_len = count - AWRW_HDR_LEN - 1; > + if ((data_len * 5 - 1) > str_len) { > + aw_dev_err(aw883xx->dev, "data_str_len [%d], requeset len [%d]", > + str_len, (data_len * 5 - 1)); > + return -EINVAL; > + } > + > + if (packet->reg_addr == aw883xx->aw_pa->dsp_mem_desc.dsp_madd_reg) { > + if (sscanf(buf + AWRW_HDR_LEN + 1, > + "0x%02x 0x%02x", &dsp_addr_h, > + &dsp_addr_l) == 2) { > + packet->dsp_addr = (dsp_addr_h << 8) | dsp_addr_l; > + packet->dsp_status = AWRW_DSP_READY; > + aw_dev_dbg(aw883xx->dev, "write:reg_addr[0x%02x], dsp_base_addr:[0x%02x]", > + packet->reg_addr, packet->dsp_addr); > + } else { > + aw_dev_err(aw883xx->dev, "get reg 0x%x data failed", packet->reg_addr); > + return -EINVAL; > + } > + return 0; > + } > + > + mutex_lock(&aw883xx->i2c_lock); > + if (packet->reg_addr == aw883xx->aw_pa->dsp_mem_desc.dsp_mdat_reg) { > + if (packet->dsp_status != AWRW_DSP_READY) { > + aw_dev_err(aw883xx->dev, "please write reg[0x40] first"); > + ret = -EINVAL; > + goto exit; > + } > + aw883xx_i2c_write(aw883xx, > + aw883xx->aw_pa->dsp_mem_desc.dsp_madd_reg, > + packet->dsp_addr); > + packet->dsp_status = AWRW_DSP_ST_NONE; > + } > + > + aw_dev_info(aw883xx->dev, "write:reg_addr[0x%02x], reg_num[%d]", > + packet->reg_addr, packet->reg_num); > + > + data_buf = devm_kzalloc(aw883xx->dev, data_len, GFP_KERNEL); > + if (data_buf == NULL) { > + ret = -ENOMEM; > + goto exit; > + } > + > + for (i = 0; i < data_len; i++) { > + if (sscanf(buf + AWRW_HDR_LEN + 1 + i * 5, "0x%02x", &temp_data) == 1) > + data_buf[i] = temp_data; > + data_buf[i] = temp_data; > + > + } > + > + ret = aw883xx_i2c_writes(aw883xx, packet->reg_addr, data_buf, data_len); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "write failed"); > + devm_kfree(aw883xx->dev, data_buf); > + data_buf = NULL; > + goto exit; > + } > + > + devm_kfree(aw883xx->dev, data_buf); > + data_buf = NULL; > + aw_dev_info(aw883xx->dev, "write success"); > +exit: > + mutex_unlock(&aw883xx->i2c_lock); > + return ret; > +} > + > +static int aw883xx_awrw_data_check(struct aw883xx *aw883xx, int *data) > +{ > + if ((data[AWRW_HDR_ADDR_BYTES] != AWRW_ADDR_BYTES) || > + (data[AWRW_HDR_DATA_BYTES] != AWRW_DATA_BYTES)) { > + aw_dev_err(aw883xx->dev, "addr_bytes [%d] or data_bytes [%d] unsupport", > + data[AWRW_HDR_ADDR_BYTES], data[AWRW_HDR_DATA_BYTES]); > + return -EINVAL; > + } > + > + return 0; > +} > + > +/* flag addr_bytes data_bytes reg_num reg_addr*/ > +static int aw883xx_awrw_parse_buf(struct aw883xx *aw883xx, const char *buf, size_t count) > +{ > + int data[AWRW_HDR_MAX] = { 0 }; > + struct aw883xx_i2c_packet *packet = &aw883xx->i2c_packet; > + int ret; > + > + if (sscanf(buf, "0x%02x 0x%02x 0x%02x 0x%02x 0x%02x", > + &data[AWRW_HDR_WR_FLAG], &data[AWRW_HDR_ADDR_BYTES], &data[AWRW_HDR_DATA_BYTES], > + &data[AWRW_HDR_REG_NUM], &data[AWRW_HDR_REG_ADDR]) == 5) { > + > + ret = aw883xx_awrw_data_check(aw883xx, data); > + if (ret < 0) > + return ret; > + > + packet->reg_addr = data[AWRW_HDR_REG_ADDR]; > + packet->reg_num = data[AWRW_HDR_REG_NUM]; > + > + if (data[AWRW_HDR_WR_FLAG] == AWRW_FLAG_WRITE) { > + return aw883xx_awrw_write(aw883xx, buf, count); > + } else if (data[AWRW_HDR_WR_FLAG] == AWRW_FLAG_READ) { > + packet->i2c_status = AWRW_I2C_ST_READ; > + aw_dev_info(aw883xx->dev, "read_cmd:reg_addr[0x%02x], reg_num[%d]", > + packet->reg_addr, packet->reg_num); > + > + } else { > + aw_dev_err(aw883xx->dev, > + "please check str format, unsupport flag %d", > + data[AWRW_HDR_WR_FLAG]); > + return -EINVAL; > + } > + } else { > + aw_dev_err(aw883xx->dev, "can not parse string"); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static ssize_t aw883xx_awrw_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + int ret; > + > + if (count < AWRW_HDR_LEN) { > + aw_dev_err(dev, "data count too smaller, please check write format"); > + aw_dev_err(dev, "string %s", buf); > + return -EINVAL; > + } > + > + ret = aw883xx_awrw_parse_buf(aw883xx, buf, count); > + if (ret) > + return -EINVAL; > + > + > + return count; > +} > + > +static ssize_t aw883xx_awrw_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw883xx_i2c_packet *packet = &aw883xx->i2c_packet; > + int data_len, len = 0; > + int ret, i; > + char *reg_data = NULL; > + > + if (packet->i2c_status != AWRW_I2C_ST_READ) { > + aw_dev_err(aw883xx->dev, "please write read cmd first"); > + return -EINVAL; > + } > + > + mutex_lock(&aw883xx->i2c_lock); > + if (packet->reg_addr == aw883xx->aw_pa->dsp_mem_desc.dsp_mdat_reg) { > + if (packet->dsp_status != AWRW_DSP_READY) { > + aw_dev_err(aw883xx->dev, "please write reg[0x40] first"); > + mutex_unlock(&aw883xx->i2c_lock); > + return -EINVAL; > + } > + ret = aw883xx_i2c_write(aw883xx, > + aw883xx->aw_pa->dsp_mem_desc.dsp_madd_reg, > + packet->dsp_addr); > + if (ret < 0) { > + mutex_unlock(&aw883xx->i2c_lock); > + return ret; > + } > + packet->dsp_status = AWRW_DSP_ST_NONE; > + } > + > + data_len = AWRW_DATA_BYTES * packet->reg_num; > + reg_data = devm_kzalloc(dev, data_len, GFP_KERNEL); > + if (reg_data == NULL) { > + aw_dev_err(aw883xx->dev, "memory alloc failed"); > + ret = -EINVAL; > + goto exit; > + } > + > + ret = aw883xx_i2c_reads(aw883xx, packet->reg_addr, (char *)reg_data, data_len); > + if (ret < 0) { > + ret = -EFAULT; > + goto exit; > + } > + > + aw_dev_info(aw883xx->dev, "reg_addr 0x%02x, reg_num %d", > + packet->reg_addr, packet->reg_num); > + > + for (i = 0; i < data_len; i++) { > + len += snprintf(buf + len, PAGE_SIZE - len, > + "0x%02x,", reg_data[i]); > + > + } > + ret = len; > + > +exit: > + if (reg_data) { > + devm_kfree(dev, reg_data); > + reg_data = NULL; > + } > + mutex_unlock(&aw883xx->i2c_lock); > + packet->i2c_status = AWRW_I2C_ST_NONE; > + return ret; > +} > + > +static ssize_t aw883xx_fade_step_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + unsigned int databuf = 0; > + int ret = 0; > + > + ret = kstrtoint(buf, 0, &databuf); > + if (ret == 0) { > + if (databuf > (aw883xx->aw_pa->volume_desc.mute_volume)) { > + aw_dev_info(aw883xx->dev, "step overflow %d Db", databuf); > + return count; > + } > + aw883xx_dev_set_fade_vol_step(aw883xx->aw_pa, databuf); > + } > + > + aw_dev_info(aw883xx->dev, "set step %d DB Done", databuf); > + > + return count; > +} > + > +static ssize_t aw883xx_fade_step_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + ssize_t len = 0; > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "step: %d\n", aw883xx_dev_get_fade_vol_step(aw883xx->aw_pa)); > + > + return len; > +} > + > +static ssize_t aw883xx_dbg_prof_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + unsigned int databuf = 0; > + int ret = 0; > + > + ret = kstrtoint(buf, 0, &databuf); > + if (ret == 0) { > + if (databuf) > + aw883xx->dbg_en_prof = true; > + else > + aw883xx->dbg_en_prof = false; > + } > + > + aw_dev_info(aw883xx->dev, "en_prof %d Done", databuf); > + > + return count; > +} > + > +static ssize_t aw883xx_dbg_prof_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + " %d\n", aw883xx->dbg_en_prof); > + > + return len; > +} > + > +static ssize_t aw883xx_spk_temp_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + int ret; > + int32_t te; > + > + ret = aw883xx_cali_svc_get_dev_te(&aw883xx->aw_pa->cali_desc, &te); > + if (ret < 0) > + return ret; > + > + len += snprintf(buf + len, PAGE_SIZE - len, > + "Temp:%d\n", te); > + > + return len; > +} > + > +static ssize_t aw883xx_sync_flag_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + unsigned int flag = 0; > + int ret; > + > + ret = kstrtouint(buf, 0, &flag); > + if (ret < 0) > + return ret; > + > + flag = ((flag == false) ? false : true); > + > + aw_dev_info(aw883xx->dev, "set phase sync flag : [%d]", flag); > + > + aw883xx->phase_sync = flag; > + > + return count; > +} > + > +static ssize_t aw883xx_sync_flag_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + > + len += snprintf(buf + len, PAGE_SIZE - len, > + "sync flag : %d\n", aw883xx->phase_sync); > + > + return len; > +} > + > +static ssize_t aw883xx_fade_enable_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + uint32_t fade_en = 0; > + int ret = 0; > + > + ret = kstrtouint(buf, 0, &fade_en); > + if (ret == 0) > + aw883xx->aw_pa->fade_en = fade_en; > + > + aw_dev_info(aw883xx->dev, "set fade_en %d", aw883xx->aw_pa->fade_en); > + > + return count; > +} > + > +static ssize_t aw883xx_fade_enable_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "fade_en: %d\n", aw883xx->aw_pa->fade_en); > + > + return len; > +} > + > +static ssize_t aw883xx_dsp_re_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + int ret; > + uint32_t read_re = 0; > + > + ret = aw883xx_cali_read_cali_re_from_dsp(&aw883xx->aw_pa->cali_desc, &read_re); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "%s:read dsp re fail\n", __func__); > + return ret; > + } > + > + len += snprintf((char *)(buf + len), > + PAGE_SIZE - len, > + "dsp_re: %d\n", read_re); > + > + return len; > +} > + > +static ssize_t aw883xx_log_en_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + > + len += snprintf(buf + len, PAGE_SIZE - len, "i2c_log_en: %d\n", > + aw883xx->i2c_log_en); > + > + return len; > +} > + > +static ssize_t aw883xx_log_en_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + uint32_t log_en = 0; > + int ret = 0; > + > + ret = kstrtouint(buf, 0, &log_en); > + if (ret == 0) > + aw883xx->i2c_log_en = log_en; > + > + aw_dev_info(aw883xx->dev, "set i2c_log_en: %d", > + aw883xx->i2c_log_en); > + > + return count; > +} > + > +static int aw883xx_dsp_log_info(struct aw883xx *aw883xx, unsigned int base_addr, > + uint32_t data_len, char *format) > +{ > + uint16_t reg_val = 0; > + char *dsp_reg_info = NULL; > + ssize_t dsp_info_len = 0; > + int i; > + > + dsp_reg_info = devm_kzalloc(aw883xx->dev, AW_NAME_BUF_MAX, GFP_KERNEL); > + if (dsp_reg_info == NULL) > + return -ENOMEM; > + > + mutex_lock(&aw883xx->i2c_lock); > + aw883xx_i2c_write(aw883xx, aw883xx->aw_pa->dsp_mem_desc.dsp_madd_reg, base_addr); > + > + for (i = 0; i < data_len; i += 2) { > + aw883xx_i2c_read(aw883xx, aw883xx->aw_pa->dsp_mem_desc.dsp_mdat_reg, &reg_val); > + dsp_info_len += snprintf(dsp_reg_info + dsp_info_len, > + AW_NAME_BUF_MAX - dsp_info_len, > + "%02x,%02x,", (reg_val >> 0) & 0xff, > + (reg_val >> 8) & 0xff); > + if ((i / 2 + 1) % 8 == 0) { > + aw_dev_info(aw883xx->dev, "%s: %s", format, dsp_reg_info); > + dsp_info_len = 0; > + memset(dsp_reg_info, 0, AW_NAME_BUF_MAX); > + } > + > + if (((data_len) % 8 != 0) && > + (i == (data_len - 2))) { > + aw_dev_info(aw883xx->dev, "%s: %s", format, dsp_reg_info); > + dsp_info_len = 0; > + memset(dsp_reg_info, 0, AW_NAME_BUF_MAX); > + } > + } > + > + dsp_info_len = 0; > + memset(dsp_reg_info, 0, AW_NAME_BUF_MAX); > + devm_kfree(aw883xx->dev, dsp_reg_info); > + dsp_reg_info = NULL; > + mutex_unlock(&aw883xx->i2c_lock); > + > + return 0; > +} > + > +static ssize_t aw883xx_dsp_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + ssize_t len = 0; > + int ret = -1; > + uint32_t data_len; > + > + if (aw883xx->aw_pa->dsp_cfg == AW_DEV_DSP_BYPASS) { > + len += snprintf((char *)(buf + len), PAGE_SIZE - len, > + "%s: dsp bypass\n", __func__); > + } else { > + len += snprintf((char *)(buf + len), PAGE_SIZE - len, > + "%s: dsp working\n", __func__); > + ret = aw883xx_dev_get_iis_status(aw883xx->aw_pa); > + if (ret < 0) { > + len += snprintf((char *)(buf + len), > + PAGE_SIZE - len, > + "%s: no iis signal\n", > + __func__); > + aw_dev_err(aw883xx->dev, "no iis signal, dsp show failed"); > + return len; > + } > + > + len += snprintf(buf + len, PAGE_SIZE - len, > + "dsp firmware and config info is displayed in the kernel log\n"); > + > + aw_dev_info(aw883xx->dev, "dsp_firmware_len:%d", aw883xx->aw_pa->dsp_fw_len); > + ret = aw883xx_dsp_log_info(aw883xx, aw883xx->aw_pa->dsp_mem_desc.dsp_fw_base_addr, > + aw883xx->aw_pa->dsp_fw_len, "dsp_fw"); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "dsp_fw display failed"); > + return len; > + } > + > + aw_dev_info(aw883xx->dev, "dsp_config_len:%d", aw883xx->aw_pa->dsp_cfg_len); > + ret = aw883xx_dsp_log_info(aw883xx, aw883xx->aw_pa->dsp_mem_desc.dsp_cfg_base_addr, > + aw883xx->aw_pa->dsp_cfg_len, "dsp_config"); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "dsp_config display failed"); > + return len; > + } > + > + aw_dev_info(aw883xx->dev, "dsp_config:0x8180-0x83fc"); > + data_len = 2 * (aw883xx->aw_pa->dsp_st_desc.dsp_reg_e1 - > + aw883xx->aw_pa->dsp_st_desc.dsp_reg_s1); > + ret = aw883xx_dsp_log_info(aw883xx, aw883xx->aw_pa->dsp_st_desc.dsp_reg_s1, > + data_len, "dsp_st"); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "dsp_config:0x8180-0x83fc failed"); > + return len; > + } > + > + aw_dev_info(aw883xx->dev, "dsp_config:0x9c00-0x9c5c"); > + data_len = 2 * (aw883xx->aw_pa->dsp_st_desc.dsp_reg_e2 - > + aw883xx->aw_pa->dsp_st_desc.dsp_reg_s2); > + ret = aw883xx_dsp_log_info(aw883xx, aw883xx->aw_pa->dsp_st_desc.dsp_reg_s2, > + data_len, "dsp_st"); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "dsp_config:0x9c00-0x9c5c display failed"); > + return len; > + } > + } > + > + return len; > +} > + > +static DEVICE_ATTR(reg, 0644, > + aw883xx_reg_show, aw883xx_reg_store); > +static DEVICE_ATTR(rw, 0644, > + aw883xx_rw_show, aw883xx_rw_store); > +static DEVICE_ATTR(drv_ver, 0444, > + aw883xx_drv_ver_show, NULL); > +static DEVICE_ATTR(dsp_rw, 0644, > + aw883xx_dsp_rw_show, aw883xx_dsp_rw_store); > +static DEVICE_ATTR(awrw, 0644, > + aw883xx_awrw_show, aw883xx_awrw_store); > +static DEVICE_ATTR(fade_step, 0644, > + aw883xx_fade_step_show, aw883xx_fade_step_store); > +static DEVICE_ATTR(dbg_prof, 0644, > + aw883xx_dbg_prof_show, aw883xx_dbg_prof_store); > +static DEVICE_ATTR(spk_temp, 0444, > + aw883xx_spk_temp_show, NULL); > +static DEVICE_ATTR(phase_sync, 0644, > + aw883xx_sync_flag_show, aw883xx_sync_flag_store); > +static DEVICE_ATTR(fade_en, 0644, > + aw883xx_fade_enable_show, aw883xx_fade_enable_store); > +static DEVICE_ATTR(dsp_re, 0444, > + aw883xx_dsp_re_show, NULL); > +static DEVICE_ATTR(i2c_log_en, 0644, > + aw883xx_log_en_show, aw883xx_log_en_store); > +static DEVICE_ATTR(dsp, 0444, > + aw883xx_dsp_show, NULL); > + > + > +static struct attribute *aw883xx_attributes[] = { > + &dev_attr_reg.attr, > + &dev_attr_rw.attr, > + &dev_attr_drv_ver.attr, > + &dev_attr_dsp_rw.attr, > + &dev_attr_awrw.attr, > + &dev_attr_fade_step.attr, > + &dev_attr_dbg_prof.attr, > + &dev_attr_spk_temp.attr, > + &dev_attr_phase_sync.attr, > + &dev_attr_fade_en.attr, > + &dev_attr_dsp_re.attr, > + &dev_attr_i2c_log_en.attr, > + &dev_attr_dsp.attr, > + NULL > +}; > + > +static struct attribute_group aw883xx_attribute_group = { > + .attrs = aw883xx_attributes > +}; All this use of sysfs seems questionable. You have all kinds of mixers already, what applications would use this? > + > + > + > +/* > + * i2c driver > + */ > +static int aw883xx_i2c_probe(struct i2c_client *i2c, > + const struct i2c_device_id *id) > +{ > + struct aw883xx *aw883xx = NULL; > + int ret = -1; > + > + aw_dev_info(&i2c->dev, "enter"); > + > + if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) { > + aw_dev_err(&i2c->dev, "check_functionality failed"); > + return -EIO; > + } > + > + aw883xx = aw883xx_malloc_init(i2c); > + if (aw883xx == NULL) { > + aw_dev_err(&i2c->dev, "malloc aw883xx failed"); > + return -ENOMEM; > + } > + i2c_set_clientdata(i2c, aw883xx); > + > + ret = aw883xx_parse_dt(aw883xx); > + if (ret < 0) { > + aw_dev_err(&i2c->dev, "parse dts failed"); > + return ret; > + } > + > + /*get gpio resource*/ > + ret = aw883xx_gpio_request(aw883xx); > + if (ret) > + return ret; > + > + /* hardware reset */ > + aw883xx_hw_reset(aw883xx); > + > + /* aw883xx chip id */ > + ret = aw883xx_read_chipid(aw883xx); > + if (ret < 0) { > + aw_dev_err(&i2c->dev, "aw883xx_read_chipid failed ret=%d", ret); > + return ret; > + } > + > + /*aw pa init*/ > + ret = aw883xx_init(aw883xx); > + if (ret < 0) > + return ret; > + > + ret = aw883xx_platform_init(aw883xx); > + if (ret < 0) { > + aw_dev_err(&i2c->dev, "get platform failed"); > + return ret; > + } > + > + ret = aw883xx_interrupt_init(aw883xx); > + if (ret < 0) > + return ret; > + > + ret = aw883xx_componet_codec_register(aw883xx); component... > + if (ret) { > + aw_dev_err(&i2c->dev, "codec register failed"); > + return ret; > + } > + > + ret = sysfs_create_group(&i2c->dev.kobj, &aw883xx_attribute_group); > + if (ret < 0) { > + aw_dev_info(&i2c->dev, "error creating sysfs attr files"); > + goto err_sysfs; > + } > + > + dev_set_drvdata(&i2c->dev, aw883xx); > + > + /*add device to total list*/ > + mutex_lock(&g_aw883xx_lock); > + g_aw883xx_dev_cnt++; > + mutex_unlock(&g_aw883xx_lock); why do you need to keep track of instances? > + > + aw_dev_info(&i2c->dev, "dev_cnt %d probe completed successfully", > + g_aw883xx_dev_cnt); > + > + return 0; > + > + > +err_sysfs: > + aw_componet_codec_ops.unregister_codec(&i2c->dev); > + return ret; > +} > + > +static int aw883xx_i2c_remove(struct i2c_client *i2c) > +{ > + struct aw883xx *aw883xx = i2c_get_clientdata(i2c); > + > + aw_dev_info(aw883xx->dev, "enter"); > + > + if (gpio_to_irq(aw883xx->irq_gpio)) > + devm_free_irq(&i2c->dev, > + gpio_to_irq(aw883xx->irq_gpio), > + aw883xx); > + > + sysfs_remove_group(&aw883xx->dev->kobj, > + &aw883xx_attribute_group); > + > + /*free device resource */ > + aw883xx_device_remove(aw883xx->aw_pa); > + > + aw_componet_codec_ops.unregister_codec(&i2c->dev); > + > + mutex_lock(&g_aw883xx_lock); > + g_aw883xx_dev_cnt--; > + if (g_aw883xx_dev_cnt == 0) { > + vfree(g_awinic_cfg); > + g_awinic_cfg = NULL; > + } > + mutex_unlock(&g_aw883xx_lock); > + > + return 0; > +} > + > +static const struct i2c_device_id aw883xx_i2c_id[] = { > + {AW883XX_I2C_NAME, 0}, > + {} > +}; > + > +MODULE_DEVICE_TABLE(i2c, aw883xx_i2c_id); > + > +static const struct of_device_id aw883xx_dt_match[] = { > + {.compatible = "awinic,aw883xx_smartpa"}, > + {}, > +}; > + > +static struct i2c_driver aw883xx_i2c_driver = { > + .driver = { > + .name = AW883XX_I2C_NAME, > + .owner = THIS_MODULE, > + .of_match_table = of_match_ptr(aw883xx_dt_match), > + }, > + .probe = aw883xx_i2c_probe, > + .remove = aw883xx_i2c_remove, > + .id_table = aw883xx_i2c_id, > +}; > + > +static int __init aw883xx_i2c_init(void) > +{ > + int ret = -1; > + > + aw_pr_info("aw883xx driver version %s", AW883XX_DRIVER_VERSION); > + > + ret = i2c_add_driver(&aw883xx_i2c_driver); > + if (ret) > + aw_pr_err("fail to add aw883xx device into i2c"); > + > + return ret; > +} > +module_init(aw883xx_i2c_init); > + > +static void __exit aw883xx_i2c_exit(void) > +{ > + i2c_del_driver(&aw883xx_i2c_driver); > +} > +module_exit(aw883xx_i2c_exit); use module_i2c_driver? > + > +MODULE_DESCRIPTION("ASoC AW883XX Smart PA Driver"); > +MODULE_LICENSE("GPL v2"); "GPL" is enough > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx.h b/sound/soc/codecs/aw883xx/aw883xx.h > new file mode 100644 > index 0000000..076f7cd > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx.h > @@ -0,0 +1,213 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD 2022? > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_H__ > +#define __AW883XX_H__ > + > +#include <linux/version.h> > +#include <sound/control.h> > +#include <sound/soc.h> > +#include "aw883xx_device.h" > + > +/*#define AW_QCOM_PLATFORM*/ > +#define AW_MTK_PLATFORM > +/*#define AW_SPRD_PLATFORM*/ > + > +/*#define AW_SYNC_LOAD*/ > + > +#define AW883XX_CHIP_ID_REG (0x00) > + > +#if KERNEL_VERSION(4, 19, 1) <= LINUX_VERSION_CODE > +#define AW_KERNEL_VER_OVER_4_19_1 > +#endif > + > +#if KERNEL_VERSION(5, 4, 0) <= LINUX_VERSION_CODE > +#define AW_KERNEL_VER_OVER_5_4_0 > +MODULE_IMPORT_NS(VFS_internal_I_am_really_a_filesystem_and_am_NOT_a_driver); > +#endif seriously? > + > +/* > + * i2c transaction on Linux limited to 64k > + * (See Linux kernel documentation: Documentation/i2c/writing-clients) > + */ > +#define MAX_I2C_BUFFER_SIZE (65536) > +#define AW883XX_READ_MSG_NUM (2) > + > +#define AW_I2C_RETRIES (5) > +#define AW_I2C_RETRY_DELAY (5)/* 5ms */ > + > +#define AW_READ_CHIPID_RETRY_DELAY (5)/* 5ms */ > +#define AW_START_RETRIES (5) > + > +#define AW883XX_FLAG_START_ON_MUTE (1 << 0) > +#define AW883XX_FLAG_SKIP_INTERRUPTS (1 << 1) > + > +#define AW883XX_I2S_CHECK_MAX (5) > + > +#define AW883XX_SYSST_CHECK_MAX (10) > + > +#define AW883XX_BIN_TYPE_NUM (3) > +#define AW883XX_LOAD_FW_DELAY_TIME (3000) > +#define AW883XX_START_WORK_DELAY_MS (0) > + > + > +#define AW883XX_DSP_16_DATA_MASK (0x0000ffff) > + > +#define AW_GET_IV_CNT_MAX (6) > +#define AW_KCONTROL_NUM (4) > +#define AW_HW_MONITOR_DELAY (1000) > + > +enum { > + AWRW_I2C_ST_NONE = 0, > + AWRW_I2C_ST_READ, > + AWRW_I2C_ST_WRITE, > +}; > + > +enum { > + AWRW_DSP_ST_NONE = 0, > + AWRW_DSP_READY, > +}; > + > +enum { > + AW_SYNC_START = 0, > + AW_ASYNC_START, > +}; > + > + > +#define AWRW_ADDR_BYTES (1) > +#define AWRW_DATA_BYTES (2) > +#define AWRW_HDR_LEN (24) > + > +enum { > + AWRW_FLAG_WRITE = 0, > + AWRW_FLAG_READ, > +}; > + > +enum { > + AWRW_HDR_WR_FLAG = 0, > + AWRW_HDR_ADDR_BYTES, > + AWRW_HDR_DATA_BYTES, > + AWRW_HDR_REG_NUM, > + AWRW_HDR_REG_ADDR, > + AWRW_HDR_MAX, > +}; > + > +struct aw883xx_i2c_packet { > + unsigned char i2c_status; > + unsigned char dsp_status; > + unsigned int reg_num; > + unsigned int reg_addr; > + unsigned int dsp_addr; > + char *reg_data; > +}; > + > + > + > +enum { > + AW883XX_STREAM_CLOSE = 0, > + AW883XX_STREAM_OPEN, > +}; > + > +enum aw883xx_init { > + AW883XX_INIT_ST = 0, > + AW883XX_INIT_OK = 1, > + AW883XX_INIT_NG = 2, > +}; > + > +enum aw_re_range { > + AW_RE_MIN = 1000, > + AW_RE_MAX = 40000, > +}; > + > +enum { > + AW_RENAME_DISABLE = 0, > + AW_RENAME_ENABLE, > +}; > + > +/* > + * Compatible with codec and component > + */ > +#ifdef AW_KERNEL_VER_OVER_4_19_1 > +typedef struct snd_soc_component aw_snd_soc_codec_t; > +typedef struct snd_soc_component_driver aw_snd_soc_codec_driver_t; > +#else > +typedef struct snd_soc_codec aw_snd_soc_codec_t; > +typedef struct snd_soc_codec_driver aw_snd_soc_codec_driver_t; > +#endif > + > +struct aw_componet_codec_ops { > + aw_snd_soc_codec_t *(*kcontrol_codec)(struct snd_kcontrol *kcontrol); > + void *(*codec_get_drvdata)(aw_snd_soc_codec_t *codec); > + int (*add_codec_controls)(aw_snd_soc_codec_t *codec, > + const struct snd_kcontrol_new *controls, unsigned int num_controls); > + void (*unregister_codec)(struct device *dev); > + int (*register_codec)(struct device *dev, > + const aw_snd_soc_codec_driver_t *codec_drv, > + struct snd_soc_dai_driver *dai_drv, > + int num_dai); > +}; > + > +struct aw883xx { > + struct i2c_client *i2c; > + struct device *dev; > + struct mutex lock; > + struct mutex i2c_lock; > + aw_snd_soc_codec_t *codec; > + struct aw_componet_codec_ops *codec_ops; > + struct aw_device *aw_pa; > + > + int sysclk; > + int reset_gpio; > + int irq_gpio; > + > + unsigned char phase_sync; /*phase sync*/ > + uint32_t allow_pw; > + uint32_t rename_flag; > + uint8_t pstream; > + unsigned char fw_retry_cnt; > + > + uint8_t dbg_en_prof; > + uint8_t i2c_log_en; > + uint8_t spin_flag; > + > + struct list_head list; > + > + struct workqueue_struct *work_queue; > + struct delayed_work start_work; > + struct delayed_work monitor_work; > + struct delayed_work interrupt_work; > + struct delayed_work acf_work; > + > + uint8_t reg_addr; > + uint16_t dsp_addr; > + uint16_t chip_id; > + struct aw883xx_i2c_packet i2c_packet; > +}; > + > +int aw883xx_init(struct aw883xx *aw883xx); > +int aw883xx_i2c_writes(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint8_t *buf, uint16_t len); > +int aw883xx_i2c_write(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t reg_data); > +int aw883xx_reg_write(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t reg_data); > +int aw883xx_i2c_read(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t *reg_data); > +int aw883xx_reg_read(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t *reg_data); > +int aw883xx_reg_write_bits(struct aw883xx *aw883xx, > + uint8_t reg_addr, uint16_t mask, uint16_t reg_data); > +int aw883xx_dsp_write(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t dsp_data, uint8_t data_type); > +int aw883xx_dsp_read(struct aw883xx *aw883xx, > + uint16_t dsp_addr, uint32_t *dsp_data, uint8_t data_type); > +int aw883xx_get_dev_num(void); > +int aw883xx_get_version(char *buf, int size); > + > +#endif > diff --git a/sound/soc/codecs/aw883xx/aw883xx_bin_parse.c b/sound/soc/codecs/aw883xx/aw883xx_bin_parse.c > new file mode 100644 > index 0000000..2338b73 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_bin_parse.c > @@ -0,0 +1,1392 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * aw_bin_parse.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + */ > + > +#include <linux/module.h> > +#include <linux/kernel.h> > +#include <linux/i2c.h> > +#include <linux/of_gpio.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/firmware.h> > +#include <linux/slab.h> > +#include <linux/version.h> > +#include <linux/input.h> > +#include <linux/interrupt.h> > +#include <linux/debugfs.h> > +#include <linux/miscdevice.h> > +#include <linux/uaccess.h> > +#include <linux/regmap.h> > +#include <linux/timer.h> > +#include <linux/workqueue.h> > +#include <linux/hrtimer.h> > +#include <linux/mutex.h> > +#include <linux/cdev.h> > +#include <linux/list.h> > +#include <linux/string.h> > +#include "aw883xx_bin_parse.h" > +#include "aw883xx_log.h" > + > +/* "code version"-"excel version" */ > +#define AWINIC_CODE_VERSION "V0.0.8-V1.0.4" > + > +#define DEBUG_LOG_LEVEL > +#ifdef DEBUG_LOG_LEVEL > +#define DBG(fmt, arg...) \ > + pr_debug("AWINIC_BIN %s,line= %d,"fmt, __func__, __LINE__, ##arg) > +#define DBG_ERR(fmt, arg...) \ > + pr_err("AWINIC_BIN_ERR %s,line= %d,"fmt, __func__, __LINE__, ##arg) > +#else > +#define DBG(fmt, arg...) do {} while (0) > +#define DBG_ERR(fmt, arg...) do {} while (0) > +#endif > + > +#define printing_data_code > + > +#define BigLittleSwap16(A) ((((uint16_t)(A) & 0xff00) >> 8) | \ > + (((uint16_t)(A) & 0x00ff) << 8)) > + > +#define BigLittleSwap32(A) ((((uint32_t)(A) & 0xff000000) >> 24) | \ > + (((uint32_t)(A) & 0x00ff0000) >> 8) | \ > + (((uint32_t)(A) & 0x0000ff00) << 8) | \ > + (((uint32_t)(A) & 0x000000ff) << 24)) > + > +static char *profile_name[AW_PROFILE_MAX] = { > + "Music", "Voice", "Voip", "Ringtone", > + "Ringtone_hs", "Lowpower", "Bypass", > + "Mmi", "Fm", "Notification", "Receiver" > +}; > + > +static int aw_parse_bin_header_1_0_0(struct aw_bin *bin); > + > +/** > + * > + * Interface function > + * > + * return value: > + * value = 0 :success; > + * value = -1 :check bin header version > + * value = -2 :check bin data type > + * value = -3 :check sum or check bin data len error > + * value = -4 :check data version > + * value = -5 :check register num > + * value = -6 :check dsp reg num > + * value = -7 :check soc app num > + * value = -8 :bin is NULL point > + * > + */ > + > +/* > + * check sum data > + */ > +static int aw_check_sum(struct aw_bin *bin, int bin_num) > +{ > + unsigned int i = 0; > + unsigned int sum_data = 0; > + unsigned int check_sum = 0; > + char *p_check_sum = NULL; > + > + DBG("enter\n"); > + p_check_sum = &(bin->info.data[(bin->header_info[bin_num].valid_data_addr - > + bin->header_info[bin_num].header_len)]); > + DBG("aw_bin_parse p_check_sum = %p\n", p_check_sum); > + check_sum = GET_32_DATA(*(p_check_sum + 3), *(p_check_sum + 2), > + *(p_check_sum + 1), *(p_check_sum)); > + > + for (i = 4; i < bin->header_info[bin_num].bin_data_len + > + bin->header_info[bin_num].header_len; i++) { > + sum_data += *(p_check_sum + i); > + } > + DBG("aw_bin_parse bin_num = %d, check_sum = 0x%x, sum_data = 0x%x\n", > + bin_num, check_sum, sum_data); > + if (sum_data != check_sum) { > + p_check_sum = NULL; > + DBG_ERR("aw_bin_parse check sum or check bin data len error\n"); > + DBG_ERR("aw_bin_parse bin_num = %d\n", bin_num); > + DBG_ERR("aw_bin_parse check_sum = 0x%x\n", check_sum); > + DBG_ERR("aw_bin_parse sum_data = 0x%x\n", sum_data); > + return -BIN_DATA_LEN_ERR; > + } > + p_check_sum = NULL; > + > + return 0; > +} > + > +static int aw_check_data_version(struct aw_bin *bin, int bin_num) > +{ > + int i = 0; > + > + DBG("enter\n"); > + for (i = DATA_VERSION_V1; i < DATA_VERSION_MAX; i++) { > + if (bin->header_info[bin_num].bin_data_ver == i) > + return 0; > + } > + DBG_ERR("aw_bin_parse Unrecognized this bin data version\n"); > + return -DATA_VER_ERR; > +} > + > +static int aw_check_register_num_v1(struct aw_bin *bin, int bin_num) > +{ > + unsigned int check_register_num = 0; > + unsigned int parse_register_num = 0; > + char *p_check_sum = NULL; > + struct bin_header_info temp_info; > + > + DBG("enter\n"); > + temp_info = bin->header_info[bin_num]; > + p_check_sum = &(bin->info.data[(temp_info.valid_data_addr)]); > + DBG("aw_bin_parse p_check_sum = %p\n", p_check_sum); > + parse_register_num = GET_32_DATA(*(p_check_sum + 3), *(p_check_sum + 2), > + *(p_check_sum + 1), *(p_check_sum)); > + check_register_num = (bin->header_info[bin_num].bin_data_len - 4) / > + (bin->header_info[bin_num].reg_byte_len + > + bin->header_info[bin_num].data_byte_len); > + DBG("aw_bin_parse bin_num = %d\n", bin_num); > + DBG("aw_bin_parse parse_register_num = 0x%x\n", parse_register_num); > + DBG("aw_bin_parse check_register_num = 0x%x\n", check_register_num); > + if (parse_register_num != check_register_num) { > + p_check_sum = NULL; > + DBG_ERR("aw_bin_parse check register num error\n"); > + DBG_ERR("aw_bin_parse bin_num = %d\n", bin_num); > + DBG_ERR("aw_bin_parse parse_register_num = 0x%x\n", > + parse_register_num); > + DBG_ERR("aw_bin_parse check_register_num = 0x%x\n", > + check_register_num); > + return -REG_NUM_ERR; > + } > + bin->header_info[bin_num].reg_num = parse_register_num; > + bin->header_info[bin_num].valid_data_len = temp_info.bin_data_len - 4; > + p_check_sum = NULL; > + bin->header_info[bin_num].valid_data_addr = temp_info.valid_data_addr + 4; > + return 0; > +} > + > +static int aw_check_dsp_reg_num_v1(struct aw_bin *bin, int bin_num) > +{ > + unsigned int check_dsp_reg_num = 0; > + unsigned int parse_dsp_reg_num = 0; > + char *p_check_sum = NULL; > + struct bin_header_info temp_info; > + > + DBG("enter\n"); > + temp_info = bin->header_info[bin_num]; > + p_check_sum = &(bin->info.data[(temp_info.valid_data_addr)]); > + DBG("aw_bin_parse p_check_sum = %p\n", p_check_sum); > + parse_dsp_reg_num = GET_32_DATA(*(p_check_sum + 7), *(p_check_sum + 6), > + *(p_check_sum + 5), *(p_check_sum + 4)); > + bin->header_info[bin_num].reg_data_byte_len = > + GET_32_DATA(*(p_check_sum + 11), *(p_check_sum + 10), > + *(p_check_sum + 9), *(p_check_sum + 8)); > + check_dsp_reg_num = (bin->header_info[bin_num].bin_data_len - 12) / > + bin->header_info[bin_num].reg_data_byte_len; > + DBG("aw_bin_parse bin_num = %d\n", bin_num); > + DBG("aw_bin_parse parse_dsp_reg_num = 0x%x\n", parse_dsp_reg_num); > + DBG("aw_bin_parse check_dsp_reg_num = 0x%x\n", check_dsp_reg_num); > + if (parse_dsp_reg_num != check_dsp_reg_num) { > + p_check_sum = NULL; > + DBG_ERR("aw_bin_parse check dsp reg num error\n"); > + DBG_ERR("aw_bin_parse bin_num = %d\n", bin_num); > + DBG_ERR("aw_bin_parse parse_dsp_reg_num = 0x%x\n", > + parse_dsp_reg_num); > + DBG_ERR("aw_bin_parse check_dsp_reg_num = 0x%x\n", > + check_dsp_reg_num); > + return -DSP_REG_NUM_ERR; > + } > + bin->header_info[bin_num].download_addr = > + GET_32_DATA(*(p_check_sum + 3), *(p_check_sum + 2), > + *(p_check_sum + 1), *(p_check_sum)); > + bin->header_info[bin_num].reg_num = parse_dsp_reg_num; > + bin->header_info[bin_num].valid_data_len = temp_info.bin_data_len - 12; > + p_check_sum = NULL; > + bin->header_info[bin_num].valid_data_addr = temp_info.valid_data_addr + 12; > + return 0; > +} > + > +static int aw_check_soc_app_num_v1(struct aw_bin *bin, int bin_num) > +{ > + unsigned int check_soc_app_num = 0; > + unsigned int parse_soc_app_num = 0; > + char *p_check_sum = NULL; > + struct bin_header_info temp_info; > + > + DBG("enter\n"); > + temp_info = bin->header_info[bin_num]; > + p_check_sum = &(bin->info.data[(temp_info.valid_data_addr)]); > + DBG("aw_bin_parse p_check_sum = %p\n", p_check_sum); > + bin->header_info[bin_num].app_version = GET_32_DATA(*(p_check_sum + 3), > + *(p_check_sum + 2), *(p_check_sum + 1), *(p_check_sum)); > + parse_soc_app_num = GET_32_DATA(*(p_check_sum + 11), > + *(p_check_sum + 10), *(p_check_sum + 9), *(p_check_sum + 8)); > + check_soc_app_num = bin->header_info[bin_num].bin_data_len - 12; > + DBG("aw_bin_parse bin_num = %d\n", bin_num); > + DBG("aw_bin_parse parse_soc_app_num = 0x%x\n", parse_soc_app_num); > + DBG("aw_bin_parse check_soc_app_num = 0x%x\n", check_soc_app_num); > + if (parse_soc_app_num != check_soc_app_num) { > + p_check_sum = NULL; > + DBG_ERR("aw_bin_parse check soc app num error\n"); > + DBG_ERR("aw_bin_parse bin_num = %d\n", bin_num); > + DBG_ERR("aw_bin_parse parse_soc_app_num = 0x%x\n", > + parse_soc_app_num); > + DBG_ERR("aw_bin_parse check_soc_app_num = 0x%x\n", > + check_soc_app_num); > + return -SOC_APP_NUM_ERR; > + } > + bin->header_info[bin_num].reg_num = parse_soc_app_num; > + bin->header_info[bin_num].download_addr = > + GET_32_DATA(*(p_check_sum + 7), *(p_check_sum + 6), > + *(p_check_sum + 5), *(p_check_sum + 4)); > + bin->header_info[bin_num].valid_data_len = temp_info.bin_data_len - 12; > + p_check_sum = NULL; > + bin->header_info[bin_num].valid_data_addr = temp_info.valid_data_addr + 12; > + return 0; > +} > +/* > + * bin header 1_0_0 > + */ > +static void aw_get_single_bin_header_1_0_0(struct aw_bin *bin) > +{ > + int i; > + > + bin->header_info[bin->all_bin_parse_num].header_len = 60; > + bin->header_info[bin->all_bin_parse_num].check_sum = > + GET_32_DATA(*(bin->p_addr + 3), *(bin->p_addr + 2), > + *(bin->p_addr + 1), *(bin->p_addr)); > + bin->header_info[bin->all_bin_parse_num].header_ver = > + GET_32_DATA(*(bin->p_addr + 7), *(bin->p_addr + 6), > + *(bin->p_addr + 5), *(bin->p_addr + 4)); > + bin->header_info[bin->all_bin_parse_num].bin_data_type = > + GET_32_DATA(*(bin->p_addr + 11), *(bin->p_addr + 10), > + *(bin->p_addr + 9), *(bin->p_addr + 8)); > + bin->header_info[bin->all_bin_parse_num].bin_data_ver = > + GET_32_DATA(*(bin->p_addr + 15), *(bin->p_addr + 14), > + *(bin->p_addr + 13), *(bin->p_addr + 12)); > + bin->header_info[bin->all_bin_parse_num].bin_data_len = > + GET_32_DATA(*(bin->p_addr + 19), *(bin->p_addr + 18), > + *(bin->p_addr + 17), *(bin->p_addr + 16)); > + bin->header_info[bin->all_bin_parse_num].ui_ver = > + GET_32_DATA(*(bin->p_addr + 23), *(bin->p_addr + 22), > + *(bin->p_addr + 21), *(bin->p_addr + 20)); > + bin->header_info[bin->all_bin_parse_num].reg_byte_len = > + GET_32_DATA(*(bin->p_addr + 35), *(bin->p_addr + 34), > + *(bin->p_addr + 33), *(bin->p_addr + 32)); > + bin->header_info[bin->all_bin_parse_num].data_byte_len = > + GET_32_DATA(*(bin->p_addr + 39), *(bin->p_addr + 38), > + *(bin->p_addr + 37), *(bin->p_addr + 36)); > + bin->header_info[bin->all_bin_parse_num].device_addr = > + GET_32_DATA(*(bin->p_addr + 43), *(bin->p_addr + 42), > + *(bin->p_addr + 41), *(bin->p_addr + 40)); > + for (i = 0; i < 8; i++) { > + bin->header_info[bin->all_bin_parse_num].chip_type[i] = > + *(bin->p_addr + 24 + i); > + } > + bin->header_info[bin->all_bin_parse_num].reg_num = 0x00000000; > + bin->header_info[bin->all_bin_parse_num].reg_data_byte_len = 0x00000000; > + bin->header_info[bin->all_bin_parse_num].download_addr = 0x00000000; > + bin->header_info[bin->all_bin_parse_num].app_version = 0x00000000; > + bin->header_info[bin->all_bin_parse_num].valid_data_len = 0x00000000; > + bin->all_bin_parse_num += 1; > +} > + > +static int aw_parse_each_of_multi_bins_1_0_0(unsigned int bin_num, int bin_serial_num, > + struct aw_bin *bin) > +{ > + int ret = 0; > + unsigned int bin_start_addr = 0; > + unsigned int valid_data_len = 0; > + struct bin_header_info aw_bin_header_info; > + > + DBG("aw_bin_parse enter multi bin branch -- %s\n", __func__); > + aw_bin_header_info = bin->header_info[bin->all_bin_parse_num - 1]; > + if (!bin_serial_num) { > + bin_start_addr = GET_32_DATA(*(bin->p_addr + 67), *(bin->p_addr > + + 66), *(bin->p_addr + 65), *(bin->p_addr + 64)); > + bin->p_addr += (60 + bin_start_addr); > + bin->header_info[bin->all_bin_parse_num].valid_data_addr = > + aw_bin_header_info.valid_data_addr + 4 + 8 * bin_num + 60; > + } else { > + valid_data_len = aw_bin_header_info.bin_data_len; > + bin->p_addr += (60 + valid_data_len); > + bin->header_info[bin->all_bin_parse_num].valid_data_addr = > + aw_bin_header_info.valid_data_addr > + + aw_bin_header_info.bin_data_len > + + 60; > + } > + > + ret = aw_parse_bin_header_1_0_0(bin); > + return ret; > +} > + > +/* Get the number of bins in multi bins, and set a for loop, > + * loop processing each bin data > + */ > +static int aw_get_multi_bin_header_1_0_0(struct aw_bin *bin) > +{ > + int i = 0; > + int ret = 0; > + unsigned int bin_num = 0; > + > + DBG("aw_bin_parse enter multi bin branch -- %s\n", __func__); > + bin_num = GET_32_DATA(*(bin->p_addr + 63), *(bin->p_addr + 62), > + *(bin->p_addr + 61), *(bin->p_addr + 60)); > + if (bin->multi_bin_parse_num == 1) > + bin->header_info[bin->all_bin_parse_num].valid_data_addr = 60; > + aw_get_single_bin_header_1_0_0(bin); > + > + for (i = 0; i < bin_num; i++) { > + DBG("aw_bin_parse enter multi bin for is %d\n", i); > + ret = aw_parse_each_of_multi_bins_1_0_0(bin_num, i, bin); > + if (ret < 0) > + return ret; > + } > + return 0; > +} > + > +/* > + * If the bin framework header version is 1.0.0, > + * determine the data type of bin, and then perform different processing > + * according to the data type > + * If it is a single bin data type, write the data directly > + * into the structure array > + * If it is a multi-bin data type, first obtain the number of bins, > + * and then recursively call the bin frame header processing function > + * according to the bin number to process the frame header information > + * of each bin separately > + */ > +static int aw_parse_bin_header_1_0_0(struct aw_bin *bin) > +{ > + int ret = 0; > + unsigned int bin_data_type; > + > + bin_data_type = GET_32_DATA(*(bin->p_addr + 11), *(bin->p_addr + 10), > + *(bin->p_addr + 9), *(bin->p_addr + 8)); > + DBG("aw_bin_parse bin_data_type 0x%x\n", bin_data_type); > + switch (bin_data_type) { > + case DATA_TYPE_REGISTER: > + case DATA_TYPE_DSP_REG: > + case DATA_TYPE_SOC_APP: > + /* Divided into two processing methods, > + * one is single bin processing, > + * and the other is single bin processing in multi bin > + */ > + DBG("aw_bin_parse enter single bin branch\n"); > + bin->single_bin_parse_num += 1; > + DBG("%s bin->single_bin_parse_num is %d\n", __func__, > + bin->single_bin_parse_num); > + if (!bin->multi_bin_parse_num) > + bin->header_info[bin->all_bin_parse_num].valid_data_addr = 60; > + aw_get_single_bin_header_1_0_0(bin); > + break; > + case DATA_TYPE_MULTI_BINS: > + /* Get the number of times to enter multi bins */ > + DBG("aw_bin_parse enter multi bin branch\n"); > + bin->multi_bin_parse_num += 1; > + DBG("%s bin->multi_bin_parse_num is %d\n", __func__, > + bin->multi_bin_parse_num); > + ret = aw_get_multi_bin_header_1_0_0(bin); > + if (ret < 0) > + return ret; > + break; > + } > + return 0; > +} > + > +/* get the bin's header version */ > +static int aw_check_bin_header_version(struct aw_bin *bin) > +{ > + int ret = 0; > + unsigned int header_version = 0; > + > + header_version = GET_32_DATA(*(bin->p_addr + 7), *(bin->p_addr + 6), > + *(bin->p_addr + 5), *(bin->p_addr + 4)); > + DBG("aw_bin_parse header_version 0x%x\n", header_version); > + /* Write data to the corresponding structure array > + * according to different formats of the bin frame header version > + */ > + switch (header_version) { > + case HEADER_VERSION_1_0_0: > + ret = aw_parse_bin_header_1_0_0(bin); > + return ret; > + default: > + DBG_ERR("aw_bin_parse Unrecognized this bin header version\n"); > + return -BIN_HEADER_VER_ERR; > + } > +} > + > +static int aw_parsing_bin_file(struct aw_bin *bin) > +{ > + int i = 0; > + int ret = 0; > + > + DBG("aw_bin_parse code version:%s\n", AWINIC_CODE_VERSION); > + if (!bin) { > + DBG_ERR("aw_bin_parse bin is NULL\n"); > + return -BIN_IS_NULL; > + } > + bin->p_addr = bin->info.data; > + bin->all_bin_parse_num = 0; > + bin->multi_bin_parse_num = 0; > + bin->single_bin_parse_num = 0; > + > + /* filling bins header info */ > + ret = aw_check_bin_header_version(bin); > + if (ret < 0) { > + DBG_ERR("aw_bin_parse check bin header version error\n"); > + return ret; > + } > + bin->p_addr = NULL; > + > + /* check bin header info */ > + for (i = 0; i < bin->all_bin_parse_num; i++) { > + /* check sum */ > + ret = aw_check_sum(bin, i); > + if (ret < 0) { > + DBG_ERR("aw_bin_parse check sum data error\n"); > + return ret; > + } > + /* check bin data version */ > + ret = aw_check_data_version(bin, i); > + if (ret < 0) { > + DBG_ERR("aw_bin_parse check data version error\n"); > + return ret; > + } > + /* check valid data */ > + if (bin->header_info[i].bin_data_ver == DATA_VERSION_V1) { > + /* check register num */ > + if (bin->header_info[i].bin_data_type == > + DATA_TYPE_REGISTER) { > + ret = aw_check_register_num_v1(bin, i); > + if (ret < 0) > + return ret; > + /* check dsp reg num */ > + } else if (bin->header_info[i].bin_data_type == > + DATA_TYPE_DSP_REG) { > + ret = aw_check_dsp_reg_num_v1(bin, i); > + if (ret < 0) > + return ret; > + /* check soc app num */ > + } else if (bin->header_info[i].bin_data_type == > + DATA_TYPE_SOC_APP) { > + ret = aw_check_soc_app_num_v1(bin, i); > + if (ret < 0) > + return ret; > + } else { > + bin->header_info[i].valid_data_len = > + bin->header_info[i].bin_data_len; > + } > + } > + } > + DBG("aw_bin_parse parsing success\n"); > + > + return 0; > +} > + > +int aw883xx_dev_dsp_data_order(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len) > +{ > + int i = 0; > + uint8_t tmp_val = 0; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + if (data_len % 2 != 0) { > + aw_dev_dbg(aw_dev->dev, "data_len:%d unsupported", data_len); > + return -EINVAL; > + } > + > + for (i = 0; i < data_len; i += 2) { > + tmp_val = data[i]; > + data[i] = data[i + 1]; > + data[i + 1] = tmp_val; > + } > + > + return 0; > +} > + > +static int aw_dev_parse_raw_reg(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len, struct aw_prof_desc *prof_desc) > +{ > + aw_dev_info(aw_dev->dev, "data_size:%d enter", data_len); > + > + prof_desc->sec_desc[AW_DATA_TYPE_REG].data = data; > + prof_desc->sec_desc[AW_DATA_TYPE_REG].len = data_len; > + > + prof_desc->prof_st = AW_PROFILE_OK; > + > + return 0; > +} > + > +static int aw_dev_parse_raw_dsp_cfg(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len, struct aw_prof_desc *prof_desc) > +{ > + int ret; > + > + aw_dev_info(aw_dev->dev, "data_size:%d enter", data_len); > + > + ret = aw883xx_dev_dsp_data_order(aw_dev, data, data_len); > + if (ret < 0) > + return ret; > + > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_CFG].data = data; > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_CFG].len = data_len; > + > + prof_desc->prof_st = AW_PROFILE_OK; > + > + return 0; > +} > + > +static int aw_dev_parse_raw_dsp_fw(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len, struct aw_prof_desc *prof_desc) > +{ > + int ret; > + > + aw_dev_info(aw_dev->dev, "data_size:%d enter", data_len); > + > + ret = aw883xx_dev_dsp_data_order(aw_dev, data, data_len); > + if (ret < 0) > + return ret; > + > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_FW].data = data; > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_FW].len = data_len; > + > + prof_desc->prof_st = AW_PROFILE_OK; > + > + return 0; > +} > + > +static int aw_dev_prof_parse_multi_bin(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len, struct aw_prof_desc *prof_desc) > +{ > + struct aw_bin *aw_bin = NULL; > + int i; > + int ret; > + > + aw_bin = devm_kzalloc(aw_dev->dev, data_len + sizeof(struct aw_bin), GFP_KERNEL); > + if (aw_bin == NULL) > + return -ENOMEM; > + > + aw_bin->info.len = data_len; > + memcpy(aw_bin->info.data, data, data_len); > + > + ret = aw_parsing_bin_file(aw_bin); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse bin failed"); > + goto parse_bin_failed; > + } > + > + for (i = 0; i < aw_bin->all_bin_parse_num; i++) { > + if (aw_bin->header_info[i].bin_data_type == DATA_TYPE_REGISTER) { > + prof_desc->sec_desc[AW_DATA_TYPE_REG].len = > + aw_bin->header_info[i].valid_data_len; > + prof_desc->sec_desc[AW_DATA_TYPE_REG].data = > + data + aw_bin->header_info[i].valid_data_addr; > + } else if (aw_bin->header_info[i].bin_data_type == DATA_TYPE_DSP_REG) { > + ret = aw883xx_dev_dsp_data_order(aw_dev, > + data + aw_bin->header_info[i].valid_data_addr, > + aw_bin->header_info[i].valid_data_len); > + if (ret < 0) > + return ret; > + > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_CFG].len = > + aw_bin->header_info[i].valid_data_len; > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_CFG].data = > + data + aw_bin->header_info[i].valid_data_addr; > + } else if (aw_bin->header_info[i].bin_data_type == DATA_TYPE_DSP_FW) { > + ret = aw883xx_dev_dsp_data_order(aw_dev, > + data + aw_bin->header_info[i].valid_data_addr, > + aw_bin->header_info[i].valid_data_len); > + if (ret < 0) > + return ret; > + > + prof_desc->fw_ver = aw_bin->header_info[i].app_version; > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_FW].len = > + aw_bin->header_info[i].valid_data_len; > + prof_desc->sec_desc[AW_DATA_TYPE_DSP_FW].data = > + data + aw_bin->header_info[i].valid_data_addr; > + } > + } > + devm_kfree(aw_dev->dev, aw_bin); > + aw_bin = NULL; > + prof_desc->prof_st = AW_PROFILE_OK; > + return 0; > + > +parse_bin_failed: > + devm_kfree(aw_dev->dev, aw_bin); > + aw_bin = NULL; > + return ret; > +} > + > +static int aw_dev_parse_data_by_sec_type(struct aw_device *aw_dev, struct aw_cfg_hdr *cfg_hdr, > + struct aw_cfg_dde *cfg_dde, struct aw_prof_desc *scene_prof_desc) > +{ > + > + switch (cfg_dde->data_type) { > + case ACF_SEC_TYPE_REG: > + return aw_dev_parse_raw_reg(aw_dev, > + (uint8_t *)cfg_hdr + cfg_dde->data_offset, > + cfg_dde->data_size, scene_prof_desc); > + case ACF_SEC_TYPE_DSP_CFG: > + return aw_dev_parse_raw_dsp_cfg(aw_dev, > + (uint8_t *)cfg_hdr + cfg_dde->data_offset, > + cfg_dde->data_size, scene_prof_desc); > + case ACF_SEC_TYPE_DSP_FW: > + return aw_dev_parse_raw_dsp_fw(aw_dev, > + (uint8_t *)cfg_hdr + cfg_dde->data_offset, > + cfg_dde->data_size, scene_prof_desc); > + case ACF_SEC_TYPE_MUTLBIN: > + return aw_dev_prof_parse_multi_bin(aw_dev, > + (uint8_t *)cfg_hdr + cfg_dde->data_offset, > + cfg_dde->data_size, scene_prof_desc); > + } > + return 0; > +} > + > +static int aw_dev_parse_dev_type(struct aw_device *aw_dev, > + struct aw_cfg_hdr *prof_hdr, struct aw_all_prof_info *all_prof_info) > +{ > + int i = 0; > + int ret; > + int sec_num = 0; > + struct aw_cfg_dde *cfg_dde = > + (struct aw_cfg_dde *)((char *)prof_hdr + prof_hdr->a_hdr_offset); > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + for (i = 0; i < prof_hdr->a_ddt_num; i++) { > + if ((aw_dev->i2c->adapter->nr == cfg_dde[i].dev_bus) && > + (aw_dev->i2c->addr == cfg_dde[i].dev_addr) && > + (cfg_dde[i].type == AW_DEV_TYPE_ID)) { > + if (cfg_dde[i].data_type == ACF_SEC_TYPE_MONITOR) { > + ret = aw883xx_monitor_parse_fw(&aw_dev->monitor_desc, > + (uint8_t *)prof_hdr + cfg_dde[i].data_offset, > + cfg_dde[i].data_size); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse monitor failed"); > + return ret; > + } > + } else { > + if (cfg_dde[i].dev_profile >= AW_PROFILE_MAX) { > + aw_dev_err(aw_dev->dev, "dev_profile [%d] overflow", > + cfg_dde[i].dev_profile); > + return -EINVAL; > + } > + ret = aw_dev_parse_data_by_sec_type(aw_dev, prof_hdr, &cfg_dde[i], > + &all_prof_info->prof_desc[cfg_dde[i].dev_profile]); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse failed"); > + return ret; > + } > + sec_num++; > + } > + } > + } > + > + if (sec_num == 0) { > + aw_dev_info(aw_dev->dev, "get dev type num is %d, please use default", > + sec_num); > + return AW_DEV_TYPE_NONE; > + } > + > + return AW_DEV_TYPE_OK; > +} > + > +static int aw_dev_parse_dev_default_type(struct aw_device *aw_dev, > + struct aw_cfg_hdr *prof_hdr, struct aw_all_prof_info *all_prof_info) > +{ > + int i = 0; > + int ret; > + int sec_num = 0; > + struct aw_cfg_dde *cfg_dde = > + (struct aw_cfg_dde *)((char *)prof_hdr + prof_hdr->a_hdr_offset); > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + for (i = 0; i < prof_hdr->a_ddt_num; i++) { > + if ((aw_dev->channel == cfg_dde[i].dev_index) && > + (cfg_dde[i].type == AW_DEV_DEFAULT_TYPE_ID)) { > + if (cfg_dde[i].data_type == ACF_SEC_TYPE_MONITOR) { > + ret = aw883xx_monitor_parse_fw(&aw_dev->monitor_desc, > + (uint8_t *)prof_hdr + cfg_dde[i].data_offset, > + cfg_dde[i].data_size); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse monitor failed"); > + return ret; > + } > + } else { > + if (cfg_dde[i].dev_profile >= AW_PROFILE_MAX) { > + aw_dev_err(aw_dev->dev, "dev_profile [%d] overflow", > + cfg_dde[i].dev_profile); > + return -EINVAL; > + } > + ret = aw_dev_parse_data_by_sec_type(aw_dev, prof_hdr, &cfg_dde[i], > + &all_prof_info->prof_desc[cfg_dde[i].dev_profile]); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse failed"); > + return ret; > + } > + sec_num++; > + } > + } > + } > + > + if (sec_num == 0) { > + aw_dev_err(aw_dev->dev, "get dev default type failed, get num[%d]", sec_num); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_dev_cfg_get_vaild_prof(struct aw_device *aw_dev, > + struct aw_all_prof_info all_prof_info) > +{ > + int i; > + int num = 0; > + struct aw_sec_data_desc *sec_desc = NULL; > + struct aw_prof_desc *prof_desc = all_prof_info.prof_desc; > + struct aw_prof_info *prof_info = &aw_dev->prof_info; > + > + for (i = 0; i < AW_PROFILE_MAX; i++) { > + if (prof_desc[i].prof_st == AW_PROFILE_OK) { > + sec_desc = prof_desc[i].sec_desc; > + if ((sec_desc[AW_DATA_TYPE_REG].data != NULL) && > + (sec_desc[AW_DATA_TYPE_REG].len != 0) && > + (sec_desc[AW_DATA_TYPE_DSP_CFG].data != NULL) && > + (sec_desc[AW_DATA_TYPE_DSP_CFG].len != 0) && > + (sec_desc[AW_DATA_TYPE_DSP_FW].data != NULL) && > + (sec_desc[AW_DATA_TYPE_DSP_FW].len != 0)) { > + prof_info->count++; > + } > + } > + } > + > + aw_dev_info(aw_dev->dev, "get valid profile:%d", aw_dev->prof_info.count); > + > + if (!prof_info->count) { > + aw_dev_err(aw_dev->dev, "no profile data"); > + return -EPERM; > + } > + > + prof_info->prof_desc = devm_kzalloc(aw_dev->dev, > + prof_info->count * sizeof(struct aw_prof_desc), > + GFP_KERNEL); > + if (prof_info->prof_desc == NULL) { > + aw_dev_err(aw_dev->dev, "prof_desc kzalloc failed"); > + return -ENOMEM; > + } > + > + for (i = 0; i < AW_PROFILE_MAX; i++) { > + if (prof_desc[i].prof_st == AW_PROFILE_OK) { > + sec_desc = prof_desc[i].sec_desc; > + if ((sec_desc[AW_DATA_TYPE_REG].data != NULL) && > + (sec_desc[AW_DATA_TYPE_REG].len != 0) && > + (sec_desc[AW_DATA_TYPE_DSP_CFG].data != NULL) && > + (sec_desc[AW_DATA_TYPE_DSP_CFG].len != 0) && > + (sec_desc[AW_DATA_TYPE_DSP_FW].data != NULL) && > + (sec_desc[AW_DATA_TYPE_DSP_FW].len != 0)) { > + if (num >= prof_info->count) { > + aw_dev_err(aw_dev->dev, "get scene num[%d] overflow count[%d]", > + num, prof_info->count); > + return -ENOMEM; > + } > + prof_info->prof_desc[num] = prof_desc[i]; > + prof_info->prof_desc[num].id = i; > + num++; > + } > + } > + } > + > + return 0; > +} > + > +static int aw_dev_load_cfg_by_hdr(struct aw_device *aw_dev, > + struct aw_cfg_hdr *prof_hdr) > +{ > + int ret; > + struct aw_all_prof_info all_prof_info; > + > + memset(&all_prof_info, 0, sizeof(struct aw_all_prof_info)); > + > + ret = aw_dev_parse_dev_type(aw_dev, prof_hdr, &all_prof_info); > + if (ret < 0) { > + return ret; > + } else if (ret == AW_DEV_TYPE_NONE) { > + aw_dev_info(aw_dev->dev, "get dev type num is 0, parse default dev"); > + ret = aw_dev_parse_dev_default_type(aw_dev, prof_hdr, &all_prof_info); > + if (ret < 0) > + return ret; > + } > + > + ret = aw_dev_cfg_get_vaild_prof(aw_dev, all_prof_info); > + if (ret < 0) > + return ret; > + > + aw_dev->prof_info.prof_name_list = profile_name; > + > + return 0; > +} > + > +static int aw_dev_create_prof_name_list_v_1_0_0_0(struct aw_device *aw_dev) > +{ > + struct aw_prof_info *prof_info = &aw_dev->prof_info; > + struct aw_prof_desc *prof_desc = prof_info->prof_desc; > + int i; > + > + if (prof_desc == NULL) { > + aw_dev_err(aw_dev->dev, "prof_desc is NULL"); > + return -EINVAL; > + } > + > + prof_info->prof_name_list = devm_kzalloc(aw_dev->dev, > + prof_info->count * PROFILE_STR_MAX, > + GFP_KERNEL); > + if (prof_info->prof_name_list == NULL) { > + aw_dev_err(aw_dev->dev, "prof_name_list devm_kzalloc failed"); > + return -ENOMEM; > + } > + > + for (i = 0; i < prof_info->count; i++) { > + prof_desc[i].id = i; > + prof_info->prof_name_list[i] = prof_desc[i].prf_str; > + aw_dev_info(aw_dev->dev, "prof name is %s", prof_info->prof_name_list[i]); > + } > + > + return 0; > +} > + > +static int aw_get_dde_type_info(struct aw_device *aw_dev, struct aw_container *aw_cfg) > +{ > + int i; > + int dev_num = 0; > + int default_num = 0; > + struct aw_cfg_hdr *cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + struct aw_cfg_dde_v_1_0_0_0 *cfg_dde = > + (struct aw_cfg_dde_v_1_0_0_0 *)(aw_cfg->data + cfg_hdr->a_hdr_offset); > + > + for (i = 0; i < cfg_hdr->a_ddt_num; i++) { > + if (cfg_dde[i].type == AW_DEV_TYPE_ID) > + dev_num++; > + > + if (cfg_dde[i].type == AW_DEV_DEFAULT_TYPE_ID) > + default_num++; > + } > + > + if (!(dev_num || default_num)) { > + aw_dev_err(aw_dev->dev, "can't find scene"); > + return -EINVAL; > + } > + > + if (dev_num != 0) > + aw_dev->prof_info.prof_type = AW_DEV_TYPE_ID; > + else if (default_num != 0) > + aw_dev->prof_info.prof_type = AW_DEV_DEFAULT_TYPE_ID; > + > + return 0; > +} > + > +static int aw_get_dev_scene_count_v_1_0_0_0(struct aw_device *aw_dev, struct aw_container *aw_cfg, > + uint32_t *scene_num) > +{ > + int i; > + struct aw_cfg_hdr *cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + struct aw_cfg_dde_v_1_0_0_0 *cfg_dde = > + (struct aw_cfg_dde_v_1_0_0_0 *)(aw_cfg->data + cfg_hdr->a_hdr_offset); > + > + for (i = 0; i < cfg_hdr->a_ddt_num; ++i) { > + if ((cfg_dde[i].data_type == ACF_SEC_TYPE_MUTLBIN) && > + (aw_dev->chip_id == cfg_dde[i].chip_id) && > + ((aw_dev->i2c->adapter->nr == cfg_dde[i].dev_bus) && > + (aw_dev->i2c->addr == cfg_dde[i].dev_addr))) > + (*scene_num)++; > + } > + > + return 0; > +} > + > +static int aw_get_default_scene_count_v_1_0_0_0(struct aw_device *aw_dev, > + struct aw_container *aw_cfg, > + uint32_t *scene_num) > +{ > + int i; > + struct aw_cfg_hdr *cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + struct aw_cfg_dde_v_1_0_0_0 *cfg_dde = > + (struct aw_cfg_dde_v_1_0_0_0 *)(aw_cfg->data + cfg_hdr->a_hdr_offset); > + > + for (i = 0; i < cfg_hdr->a_ddt_num; ++i) { > + if ((cfg_dde[i].data_type == ACF_SEC_TYPE_MUTLBIN) && > + (aw_dev->chip_id == cfg_dde[i].chip_id) && > + (aw_dev->channel == cfg_dde[i].dev_index)) > + (*scene_num)++; > + } > + > + return 0; > +} > + > +static int aw_dev_parse_scene_count_v_1_0_0_0(struct aw_device *aw_dev, > + struct aw_container *aw_cfg, > + uint32_t *count) > +{ > + int ret; > + > + ret = aw_get_dde_type_info(aw_dev, aw_cfg); > + if (ret < 0) > + return ret; > + > + if (aw_dev->prof_info.prof_type == AW_DEV_TYPE_ID) { > + aw_get_dev_scene_count_v_1_0_0_0(aw_dev, aw_cfg, count); > + } else if (aw_dev->prof_info.prof_type == AW_DEV_DEFAULT_TYPE_ID) { > + aw_get_default_scene_count_v_1_0_0_0(aw_dev, aw_cfg, count); > + } else { > + aw_dev_err(aw_dev->dev, "unsupported prof_type[%x]", > + aw_dev->prof_info.prof_type); > + return -EINVAL; > + } > + > + aw_dev_info(aw_dev->dev, "scene count is %d", (*count)); > + return 0; > +} > + > +static int aw_dev_parse_data_by_sec_type_v_1_0_0_0(struct aw_device *aw_dev, > + struct aw_cfg_hdr *prof_hdr, > + struct aw_cfg_dde_v_1_0_0_0 *cfg_dde, > + int *cur_scene_id) > +{ > + int ret; > + struct aw_prof_info *prof_info = &aw_dev->prof_info; > + > + switch (cfg_dde->data_type) { > + case ACF_SEC_TYPE_MUTLBIN: > + ret = aw_dev_prof_parse_multi_bin(aw_dev, > + (uint8_t *)prof_hdr + cfg_dde->data_offset, > + cfg_dde->data_size, &prof_info->prof_desc[*cur_scene_id]); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse multi bin failed"); > + return ret; > + } > + prof_info->prof_desc[*cur_scene_id].prf_str = cfg_dde->dev_profile_str; > + prof_info->prof_desc[*cur_scene_id].id = cfg_dde->dev_profile; > + (*cur_scene_id)++; > + break; > + case ACF_SEC_TYPE_MONITOR: > + return aw883xx_monitor_parse_fw(&aw_dev->monitor_desc, > + (uint8_t *)prof_hdr + cfg_dde->data_offset, > + cfg_dde->data_size); > + default: > + aw_pr_err("unsupported SEC_TYPE [%d]", cfg_dde->data_type); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_dev_parse_dev_type_v_1_0_0_0(struct aw_device *aw_dev, > + struct aw_cfg_hdr *prof_hdr) > +{ > + int i = 0; > + int ret; > + int cur_scene_id = 0; > + struct aw_cfg_dde_v_1_0_0_0 *cfg_dde = > + (struct aw_cfg_dde_v_1_0_0_0 *)((char *)prof_hdr + prof_hdr->a_hdr_offset); > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + for (i = 0; i < prof_hdr->a_ddt_num; i++) { > + if ((aw_dev->i2c->adapter->nr == cfg_dde[i].dev_bus) && > + (aw_dev->i2c->addr == cfg_dde[i].dev_addr) && > + (aw_dev->chip_id == cfg_dde[i].chip_id)) { > + ret = aw_dev_parse_data_by_sec_type_v_1_0_0_0(aw_dev, prof_hdr, > + &cfg_dde[i], &cur_scene_id); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse failed"); > + return ret; > + } > + } > + } > + > + if (cur_scene_id == 0) { > + aw_dev_info(aw_dev->dev, "get dev type failed, get num [%d]", cur_scene_id); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_dev_parse_default_type_v_1_0_0_0(struct aw_device *aw_dev, > + struct aw_cfg_hdr *prof_hdr) > +{ > + int i = 0; > + int ret; > + int cur_scene_id = 0; > + struct aw_cfg_dde_v_1_0_0_0 *cfg_dde = > + (struct aw_cfg_dde_v_1_0_0_0 *)((char *)prof_hdr + prof_hdr->a_hdr_offset); > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + for (i = 0; i < prof_hdr->a_ddt_num; i++) { > + if ((aw_dev->channel == cfg_dde[i].dev_index) && > + (aw_dev->chip_id == cfg_dde[i].chip_id)) { > + ret = aw_dev_parse_data_by_sec_type_v_1_0_0_0(aw_dev, prof_hdr, > + &cfg_dde[i], &cur_scene_id); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "parse failed"); > + return ret; > + } > + } > + } > + > + if (cur_scene_id == 0) { > + aw_dev_err(aw_dev->dev, "get dev default type failed, get num[%d]", cur_scene_id); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_dev_parse_by_hdr_v_1_0_0_0(struct aw_device *aw_dev, > + struct aw_cfg_hdr *cfg_hdr) > +{ > + int ret; > + > + if (aw_dev->prof_info.prof_type == AW_DEV_TYPE_ID) { > + ret = aw_dev_parse_dev_type_v_1_0_0_0(aw_dev, cfg_hdr); > + if (ret < 0) > + return ret; > + } else if (aw_dev->prof_info.prof_type == AW_DEV_DEFAULT_TYPE_ID) { > + ret = aw_dev_parse_default_type_v_1_0_0_0(aw_dev, cfg_hdr); > + if (ret < 0) > + return ret; > + } else { > + aw_dev_err(aw_dev->dev, "prof type matched failed, get num[%d]", > + aw_dev->prof_info.prof_type); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_dev_load_cfg_by_hdr_v_1_0_0_0(struct aw_device *aw_dev, struct aw_container *aw_cfg) > +{ > + struct aw_prof_info *prof_info = &aw_dev->prof_info; > + struct aw_cfg_hdr *cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + int ret; > + > + ret = aw_dev_parse_scene_count_v_1_0_0_0(aw_dev, aw_cfg, &prof_info->count); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get scene count failed"); > + return ret; > + } > + > + prof_info->prof_desc = devm_kzalloc(aw_dev->dev, > + prof_info->count * sizeof(struct aw_prof_desc), > + GFP_KERNEL); > + if (prof_info->prof_desc == NULL) { > + aw_dev_err(aw_dev->dev, "prof_desc devm_kzalloc failed"); > + return -ENOMEM; > + } > + > + ret = aw_dev_parse_by_hdr_v_1_0_0_0(aw_dev, cfg_hdr); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, " failed"); > + return ret; > + } > + > + ret = aw_dev_create_prof_name_list_v_1_0_0_0(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "create prof name list failed"); > + return ret; > + } > + > + return 0; > +} > + > +int aw883xx_dev_cfg_load(struct aw_device *aw_dev, struct aw_container *aw_cfg) > +{ > + struct aw_cfg_hdr *cfg_hdr = NULL; > + int ret; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + switch (cfg_hdr->a_hdr_version) { > + case AW_CFG_HDR_VER_0_0_0_1: > + ret = aw_dev_load_cfg_by_hdr(aw_dev, cfg_hdr); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "hdr_cersion[0x%x] parse failed", > + cfg_hdr->a_hdr_version); > + return ret; > + } > + break; > + case AW_CFG_HDR_VER_1_0_0_0: > + ret = aw_dev_load_cfg_by_hdr_v_1_0_0_0(aw_dev, aw_cfg); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "hdr_cersion[0x%x] parse failed", > + cfg_hdr->a_hdr_version); > + return ret; > + } > + break; > + default: > + aw_pr_err("unsupported hdr_version [0x%x]", cfg_hdr->a_hdr_version); > + return -EINVAL; > + } > + > + aw_dev->fw_status = AW_DEV_FW_OK; > + aw_dev_info(aw_dev->dev, "parse cfg success"); > + return 0; > +} > + > +static uint8_t aw_dev_crc8_check(unsigned char *data, uint32_t data_size) > +{ > + uint8_t crc_value = 0x00; > + uint8_t pdatabuf = 0; > + int i; > + > + while (data_size--) { > + pdatabuf = *data++; > + for (i = 0; i < 8; i++) { > + /*if the lowest bit is 1*/ > + if ((crc_value ^ (pdatabuf)) & 0x01) { > + /*Xor multinomial*/ > + crc_value ^= 0x18; > + crc_value >>= 1; > + crc_value |= 0x80; > + } else { > + crc_value >>= 1; > + } > + pdatabuf >>= 1; > + } > + } > + return crc_value; > +} > + > +static int aw_dev_check_cfg_by_hdr(struct aw_container *aw_cfg) > +{ > + struct aw_cfg_hdr *cfg_hdr = NULL; > + struct aw_cfg_dde *cfg_dde = NULL; > + unsigned int end_data_offset = 0; > + unsigned int act_data = 0; > + unsigned int hdr_ddt_len = 0; > + uint8_t act_crc8 = 0; > + int i; > + > + cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + > + /*check file type id is awinic acf file*/ > + if (cfg_hdr->a_id != ACF_FILE_ID) { > + aw_pr_err("not acf type file"); > + return -EINVAL; > + } > + > + hdr_ddt_len = cfg_hdr->a_hdr_offset + cfg_hdr->a_ddt_size; > + if (hdr_ddt_len > aw_cfg->len) { > + aw_pr_err("hdrlen with ddt_len [%d] overflow file size[%d]", > + cfg_hdr->a_hdr_offset, aw_cfg->len); > + return -EINVAL; > + } > + > + /*check data size*/ > + cfg_dde = (struct aw_cfg_dde *)((char *)aw_cfg->data + cfg_hdr->a_hdr_offset); > + act_data += hdr_ddt_len; > + for (i = 0; i < cfg_hdr->a_ddt_num; i++) > + act_data += cfg_dde[i].data_size; > + > + if (act_data != aw_cfg->len) { > + aw_pr_err("act_data[%d] not equal to file size[%d]!", > + act_data, aw_cfg->len); > + return -EINVAL; > + } > + > + for (i = 0; i < cfg_hdr->a_ddt_num; i++) { > + /* data check */ > + end_data_offset = cfg_dde[i].data_offset + cfg_dde[i].data_size; > + if (end_data_offset > aw_cfg->len) { > + aw_pr_err("a_ddt_num[%d] end_data_offset[%d] overflow file size[%d]", > + i, end_data_offset, aw_cfg->len); > + return -EINVAL; > + } > + > + /* crc check */ > + act_crc8 = aw_dev_crc8_check(aw_cfg->data + cfg_dde[i].data_offset, > + cfg_dde[i].data_size); > + if (act_crc8 != cfg_dde[i].data_crc) { > + aw_pr_err("a_ddt_num[%d] crc8 check failed, act_crc8:0x%x != data_crc 0x%x", > + i, (uint32_t)act_crc8, cfg_dde[i].data_crc); > + return -EINVAL; > + } > + } > + > + aw_pr_info("project name [%s]", cfg_hdr->a_project); > + aw_pr_info("custom name [%s]", cfg_hdr->a_custom); > + aw_pr_info("version name [%d.%d.%d.%d]", cfg_hdr->a_version[3], cfg_hdr->a_version[2], > + cfg_hdr->a_version[1], cfg_hdr->a_version[0]); > + aw_pr_info("author id %d", cfg_hdr->a_author_id); > + > + return 0; > +} > + > +static int aw_dev_check_acf_by_hdr_v_1_0_0_0(struct aw_container *aw_cfg) > +{ > + struct aw_cfg_hdr *cfg_hdr = NULL; > + struct aw_cfg_dde_v_1_0_0_0 *cfg_dde = NULL; > + unsigned int end_data_offset = 0; > + unsigned int act_data = 0; > + unsigned int hdr_ddt_len = 0; > + uint8_t act_crc8 = 0; > + int i; > + > + cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + > + /*check file type id is awinic acf file*/ > + if (cfg_hdr->a_id != ACF_FILE_ID) { > + aw_pr_err("not acf type file"); > + return -EINVAL; > + } > + > + hdr_ddt_len = cfg_hdr->a_hdr_offset + cfg_hdr->a_ddt_size; > + if (hdr_ddt_len > aw_cfg->len) { > + aw_pr_err("hdrlen with ddt_len [%d] overflow file size[%d]", > + cfg_hdr->a_hdr_offset, aw_cfg->len); > + return -EINVAL; > + } > + > + /*check data size*/ > + cfg_dde = (struct aw_cfg_dde_v_1_0_0_0 *)((char *)aw_cfg->data + cfg_hdr->a_hdr_offset); > + act_data += hdr_ddt_len; > + for (i = 0; i < cfg_hdr->a_ddt_num; i++) > + act_data += cfg_dde[i].data_size; > + > + if (act_data != aw_cfg->len) { > + aw_pr_err("act_data[%d] not equal to file size[%d]!", > + act_data, aw_cfg->len); > + return -EINVAL; > + } > + > + for (i = 0; i < cfg_hdr->a_ddt_num; i++) { > + /* data check */ > + end_data_offset = cfg_dde[i].data_offset + cfg_dde[i].data_size; > + if (end_data_offset > aw_cfg->len) { > + aw_pr_err("a_ddt_num[%d] end_data_offset[%d] overflow file size[%d]", > + i, end_data_offset, aw_cfg->len); > + return -EINVAL; > + } > + > + /* crc check */ > + act_crc8 = aw_dev_crc8_check(aw_cfg->data + cfg_dde[i].data_offset, > + cfg_dde[i].data_size); > + if (act_crc8 != cfg_dde[i].data_crc) { > + aw_pr_err("a_ddt_num[%d] crc8 check failed, act_crc8:0x%x != data_crc 0x%x", > + i, (uint32_t)act_crc8, cfg_dde[i].data_crc); > + return -EINVAL; > + } > + } > + > + aw_pr_info("project name [%s]", cfg_hdr->a_project); > + aw_pr_info("custom name [%s]", cfg_hdr->a_custom); > + aw_pr_info("version name [%d.%d.%d.%d]", cfg_hdr->a_version[3], cfg_hdr->a_version[2], > + cfg_hdr->a_version[1], cfg_hdr->a_version[0]); > + aw_pr_info("author id %d", cfg_hdr->a_author_id); > + > + return 0; > + > +} > + > +int aw883xx_dev_load_acf_check(struct aw_container *aw_cfg) > +{ > + struct aw_cfg_hdr *cfg_hdr = NULL; > + > + if (aw_cfg == NULL) { > + aw_pr_err("aw_prof is NULL"); > + return -ENOMEM; > + } > + > + if (aw_cfg->len < sizeof(struct aw_cfg_hdr)) { > + aw_pr_err("cfg hdr size[%d] overflow file size[%d]", > + aw_cfg->len, (int)sizeof(struct aw_cfg_hdr)); > + return -EINVAL; > + } > + > + cfg_hdr = (struct aw_cfg_hdr *)aw_cfg->data; > + switch (cfg_hdr->a_hdr_version) { > + case AW_CFG_HDR_VER_0_0_0_1: > + return aw_dev_check_cfg_by_hdr(aw_cfg); > + case AW_CFG_HDR_VER_1_0_0_0: > + return aw_dev_check_acf_by_hdr_v_1_0_0_0(aw_cfg); > + default: > + aw_pr_err("unsupported hdr_version [0x%x]", cfg_hdr->a_hdr_version); > + return -EINVAL; > + } > + > + return 0; > +} > + > +int aw883xx_dev_get_profile_count(struct aw_device *aw_dev) > +{ > + if (aw_dev == NULL) { > + aw_pr_err("aw_dev is NULL"); > + return -ENOMEM; > + } > + > + return aw_dev->prof_info.count; > +} > + > +int aw883xx_dev_check_profile_index(struct aw_device *aw_dev, int index) > +{ > + if ((index >= aw_dev->prof_info.count) || (index < 0)) > + return -EINVAL; > + else > + return 0; > +} > + > +int aw883xx_dev_get_profile_index(struct aw_device *aw_dev) > +{ > + return aw_dev->set_prof; > +} > + > +int aw883xx_dev_set_profile_index(struct aw_device *aw_dev, int index) > +{ > + struct aw_prof_desc *prof_desc = NULL; > + > + if ((index < aw_dev->prof_info.count) && (index >= 0)) { > + aw_dev->set_prof = index; > + prof_desc = &aw_dev->prof_info.prof_desc[index]; > + > + aw_dev_info(aw_dev->dev, "set prof[%s]", > + aw_dev->prof_info.prof_name_list[prof_desc->id]); > + } else { > + return -EINVAL; > + } > + > + return 0; > +} > + > +char *aw_dev_get_prof_name(struct aw_device *aw_dev, int index) > +{ > + struct aw_prof_desc *prof_desc = NULL; > + struct aw_prof_info *prof_info = &aw_dev->prof_info; > + > + if ((index >= aw_dev->prof_info.count) || (index < 0)) { > + aw_dev_err(aw_dev->dev, "index[%d] overflow count[%d]", > + index, aw_dev->prof_info.count); > + return NULL; > + } > + > + prof_desc = &aw_dev->prof_info.prof_desc[index]; > + > + return prof_info->prof_name_list[prof_desc->id]; > +} > + > +int aw883xx_dev_get_prof_data(struct aw_device *aw_dev, int index, > + struct aw_prof_desc **prof_desc) > +{ > + if ((index >= aw_dev->prof_info.count) || (index < 0)) { > + aw_dev_err(aw_dev->dev, "%s: index[%d] overflow count[%d]\n", > + __func__, index, aw_dev->prof_info.count); > + return -EINVAL; > + } > + > + *prof_desc = &aw_dev->prof_info.prof_desc[index]; > + > + return 0; > +} > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_bin_parse.h b/sound/soc/codecs/aw883xx/aw883xx_bin_parse.h > new file mode 100644 > index 0000000..a961a35 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_bin_parse.h > @@ -0,0 +1,145 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_BIN_PARSE_H__ > +#define __AW883XX_BIN_PARSE_H__ > + > +#include "aw883xx_device.h" > + > +#define NULL ((void *)0) > +#define GET_32_DATA(w, x, y, z) \ > + ((unsigned int)((((uint8_t)w) << 24) | \ > + (((uint8_t)x) << 16) | (((uint8_t)y) << 8) | \ > + ((uint8_t)z))) > +#define BIN_NUM_MAX 100 > +#define HEADER_LEN 60 > +/* > + * header information > + */ > +enum return_enum { > + BIN_HEADER_VER_ERR = 1, > + BIN_DATA_TYPE_ERR = 2, > + BIN_DATA_LEN_ERR = 3, > + DATA_VER_ERR = 4, > + REG_NUM_ERR = 5, > + DSP_REG_NUM_ERR = 6, > + SOC_APP_NUM_ERR = 7, > + BIN_IS_NULL = 8, > +}; > + > +enum bin_header_version_enum { > + HEADER_VERSION_1_0_0 = 0x01000000, > +}; > + > +enum data_type_enum { > + DATA_TYPE_REGISTER = 0x00000000, > + DATA_TYPE_DSP_REG = 0x00000010, > + DATA_TYPE_DSP_CFG = 0x00000011, > + DATA_TYPE_SOC_REG = 0x00000020, > + DATA_TYPE_SOC_APP = 0x00000021, > + DATA_TYPE_DSP_FW = DATA_TYPE_SOC_APP, > + DATA_TYPE_MULTI_BINS = 0x00002000, > +}; > + > +/** > + * @DATA_VERSION_V1：default little edian > + */ > +enum data_version_enum { > + DATA_VERSION_V1 = 0X00000001, > + DATA_VERSION_MAX, > +}; > + > +/** > + * @header_len: Frame header length > + * @check_sum: Frame header information-Checksum > + * @header_ver: Frame header information-Frame header version > + * @bin_data_type: Frame header information-Data type > + * @bin_data_ver: Frame header information-Data version > + * @bin_data_len: Frame header information-Data length > + * @ui_ver: Frame header information-ui version > + * @chip_type[8]: Frame header information-chip type > + * @reg_byte_len: Frame header information-reg byte len > + * @data_byte_len: Frame header information-data byte len > + * @device_addr: Frame header information-device addr > + * @valid_data_len: Length of valid data obtained after parsing > + * @valid_data_addr: The offset address of the valid data obtained > + * after parsing relative to info > + * @reg_num: The number of registers obtained after parsing > + * @reg_data_byte_len: The byte length of the register obtained after parsing > + * @download_addr: The starting address or download address obtained > + * after parsing > + * @app_version: The software version number obtained after parsing > + */ > +struct bin_header_info { > + unsigned int header_len; > + unsigned int check_sum; > + unsigned int header_ver; > + unsigned int bin_data_type; > + unsigned int bin_data_ver; > + unsigned int bin_data_len; > + unsigned int ui_ver; > + unsigned char chip_type[8]; > + unsigned int reg_byte_len; > + unsigned int data_byte_len; > + unsigned int device_addr; > + unsigned int valid_data_len; > + unsigned int valid_data_addr; > + > + unsigned int reg_num; > + unsigned int reg_data_byte_len; > + unsigned int download_addr; > + unsigned int app_version; > +}; > + > +/* > + * function define > + * > + */ > +/* > + * @len: The size of the bin file obtained from the firmware > + * @data[]: Store the bin file obtained from the firmware > + */ > +struct bin_container { > + unsigned int len; > + unsigned char data[]; > +}; > + > +/** > + * @p_addr: Offset pointer (backward offset pointer to obtain frame header > + * information and important information) > + * @all_bin_parse_num: The number of all bin files > + * @multi_bin_parse_num: The number of single bin files > + * @single_bin_parse_num: The number of multiple bin files > + * @header_info[BIN_NUM_MAX]: Frame header information and other important data > + * obtained after parsing > + * @info: Obtained bin file data that needs to be parsed > + */ > +struct aw_bin { > + unsigned char *p_addr; > + unsigned int all_bin_parse_num; > + unsigned int multi_bin_parse_num; > + unsigned int single_bin_parse_num; > + struct bin_header_info header_info[BIN_NUM_MAX]; > + struct bin_container info; > +}; > + > +/*******************awinic audio parse acf***********************/ > +int aw883xx_dev_dsp_data_order(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len); > +int aw883xx_dev_get_prof_data(struct aw_device *aw_dev, int index, > + struct aw_prof_desc **prof_desc); > +char *aw_dev_get_prof_name(struct aw_device *aw_dev, int index); > +int aw883xx_dev_set_profile_index(struct aw_device *aw_dev, int index); > +int aw883xx_dev_get_profile_index(struct aw_device *aw_dev); > +int aw883xx_dev_check_profile_index(struct aw_device *aw_dev, int index); > +int aw883xx_dev_get_profile_count(struct aw_device *aw_dev); > +int aw883xx_dev_cfg_load(struct aw_device *aw_dev, struct aw_container *aw_cfg); > +int aw883xx_dev_load_acf_check(struct aw_container *aw_cfg); > + > +#endif > diff --git a/sound/soc/codecs/aw883xx/aw883xx_calib.c b/sound/soc/codecs/aw883xx/aw883xx_calib.c > new file mode 100644 > index 0000000..4d1b90f > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_calib.c > @@ -0,0 +1,2534 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#include <linux/module.h> > +#include <asm/ioctls.h> > +#include <linux/uaccess.h> > +#include <linux/delay.h> > +#include <linux/slab.h> > +#include <linux/fs.h> > +#include <linux/miscdevice.h> > +#include <linux/device.h> > +#include <linux/kernel.h> > +#include <linux/of.h> > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/pcm_params.h> > +#include <sound/soc.h> > + > +#include "aw883xx_device.h" > +#include "aw883xx_log.h" > +#include "aw883xx_calib.h" > +#include "aw883xx.h" > + > + > + > +static bool is_single_cali; /*if mutli_dev cali false, single dev true*/ > +static unsigned int g_cali_re_time = AW_CALI_RE_DEFAULT_TIMER; > +static unsigned int g_dev_select; > +static struct miscdevice *g_misc_dev; > +static unsigned int g_msic_wr_flag = CALI_STR_NONE; > +static DEFINE_MUTEX(g_cali_lock); > +static const char *cali_str[CALI_STR_MAX] = {"none", "start_cali", "cali_re", > + "cali_f0", "store_re", "show_re", "show_r0", "show_cali_f0", "show_f0", > + "show_te", "dev_sel", "get_ver", "get_re_range" > +}; > + > + > +/******************************cali re store example start***********************************/ > +#ifdef AW_CALI_STORE_EXAMPLE > +/*write cali to persist file example*/ > +#define AWINIC_CALI_FILE "/mnt/vendor/persist/factory/audio/aw_cali.bin" > +#define AW_INT_DEC_DIGIT (10) > + > +static void aw_fs_read(struct file *file, char *buf, size_t count, loff_t *pos) > +{ > +#ifdef AW_KERNEL_VER_OVER_5_4_0 > + kernel_read(file, buf, count, pos); > +#else > + vfs_read(file, buf, count, pos); > +#endif > +} > + > +static void aw_fs_write(struct file *file, char *buf, size_t count, loff_t *pos) > +{ > +#ifdef AW_KERNEL_VER_OVER_5_4_0 > + kernel_write(file, buf, count, pos); > +#else > + vfs_write(file, buf, count, pos); > +#endif > +} > + > +static int aw_cali_write_cali_re_to_file(int32_t cali_re, int channel) > +{ > + struct file *fp = NULL; > + char buf[50] = { 0 }; > + loff_t pos = 0; > + //mm_segment_t fs; > + > + fp = filp_open(AWINIC_CALI_FILE, O_RDWR | O_CREAT, 0644); > + if (IS_ERR(fp)) { > + aw_pr_err("channel:%d open %s failed!", > + channel, AWINIC_CALI_FILE); > + return -EINVAL; > + } > + > + pos = AW_INT_DEC_DIGIT * channel; > + > + snprintf(buf, sizeof(buf), "%10d", cali_re); > + > + //fs = get_fs(); > + //set_fs(KERNFS_NS); > + > + aw_fs_write(fp, buf, strlen(buf), &pos); > + > + //set_fs(fs); > + > + aw_pr_info("channel:%d buf:%s cali_re:%d", > + channel, buf, cali_re); > + > + filp_close(fp, NULL); > + return 0; > +} > + > +static int aw_cali_get_cali_re_from_file(int32_t *cali_re, int channel) > +{ > + struct file *fp = NULL; > + int f_size; > + char *buf = NULL; > + int32_t int_cali_re = 0; > + loff_t pos = 0; > + int ret; > + //mm_segment_t fs; > + > + fp = filp_open(AWINIC_CALI_FILE, O_RDONLY, 0); > + if (IS_ERR(fp)) { > + aw_pr_err("channel:%d open %s failed!", > + channel, AWINIC_CALI_FILE); > + return -EINVAL; > + } > + > + pos = AW_INT_DEC_DIGIT * channel; > + > + f_size = AW_INT_DEC_DIGIT; > + > + buf = kzalloc(f_size + 1, GFP_ATOMIC); > + if (!buf) { > + filp_close(fp, NULL); > + return -EINVAL; > + } > + > + //fs = get_fs(); > + //set_fs(KERNFS_NS); > + > + aw_fs_read(fp, buf, f_size, &pos); > + > + //set_fs(fs); > + ret = kstrtoint(buf, 0, &int_cali_re); > + if (ret < 0) > + *cali_re = AW_ERRO_CALI_RE_VALUE; > + else > + *cali_re = int_cali_re; > + > + aw_pr_info("channel:%d buf:%s int_cali_re: %d", > + channel, buf, int_cali_re); > + > + kfree(buf); > + buf = NULL; > + filp_close(fp, NULL); > + > + return 0; > +} > +#endif > +/********************cali re store example end*****************************/ > + > + > +/*custom need add to set/get cali_re form/to nv*/ > +static int aw_cali_write_re_to_nvram(int32_t cali_re, int32_t channel) > +{ > +#ifdef AW_CALI_STORE_EXAMPLE > + return aw_cali_write_cali_re_to_file(cali_re, channel); > +#else > + return 0; > +#endif > +} > +static int aw_cali_read_re_from_nvram(int32_t *cali_re, int32_t channel) > +{ > +/*custom add, if success return value is 0 , else -1*/ > +#ifdef AW_CALI_STORE_EXAMPLE > + return aw_cali_get_cali_re_from_file(cali_re, channel); > +#else > + return 0; > +#endif > +} > + > +bool aw883xx_cali_check_result(struct aw_cali_desc *cali_desc) > +{ > + if (cali_desc->cali_check_st && > + (cali_desc->cali_result == CALI_RESULT_ERROR)) > + return false; > + else > + return true; > +} > + > +static void aw_cali_svc_run_mute(struct aw_device *aw_dev, int8_t cali_result) > +{ > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + if (aw_dev->cali_desc.cali_check_st) { > + if (cali_result == CALI_RESULT_ERROR) > + aw883xx_dev_mute(aw_dev, true); > + else if (cali_result == CALI_RESULT_NORMAL) > + aw883xx_dev_mute(aw_dev, false); > + } else { > + aw_dev_info(aw_dev->dev, "cali check disable"); > + } > + > + aw_dev_info(aw_dev->dev, "done"); > +} > + > +static int aw_cali_svc_get_dev_re_range(struct aw_device *aw_dev, > + uint32_t *data_buf) > +{ > + data_buf[RE_MIN_FLAG] = aw_dev->re_range.re_min; > + data_buf[RE_MAX_FLAG] = aw_dev->re_range.re_max; > + > + return 0; > +} > + > +static int aw_cali_svc_get_devs_re_range(struct aw_device *aw_dev, > + uint32_t *data_buf, int num) > +{ > + struct list_head *dev_list = NULL; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret, cnt = 0; > + > + /*get dev list*/ > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, "get dev list failed"); > + return ret; > + } > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel < num) { > + data_buf[RE_MIN_FLAG + local_dev->channel * 2] = > + local_dev->re_range.re_min; > + data_buf[RE_MAX_FLAG + local_dev->channel * 2] = > + local_dev->re_range.re_max; > + cnt++; > + } else { > + aw_dev_err(local_dev->dev, "channel num[%d] overflow buf num[%d]", > + local_dev->channel, num); > + return -EINVAL; > + } > + } > + > + return cnt; > +} > + > + > +static int aw_cali_store_cali_re(struct aw_device *aw_dev, int32_t re) > +{ > + int ret; > + > + if ((re > aw_dev->re_range.re_min) && (re < aw_dev->re_range.re_max)) { > + aw_dev->cali_desc.cali_re = re; > + ret = aw_cali_write_re_to_nvram(re, aw_dev->channel); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write re to nvram failed!"); > + return ret; > + } > + } else { > + aw_dev_err(aw_dev->dev, "invalid cali re %d!", re); > + return -EINVAL; > + } > + > + return 0; > +} > + > +int aw883xx_cali_get_cali_re(struct aw_cali_desc *cali_desc) > +{ > + int ret; > + int32_t cali_re = 0; > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + > + ret = aw_cali_read_re_from_nvram(&cali_re, aw_dev->channel); > + if (ret < 0) { > + cali_desc->cali_re = AW_ERRO_CALI_RE_VALUE; > + cali_desc->cali_result = CALI_RESULT_NONE; > + aw_dev_err(aw_dev->dev, "get re failed"); > + return ret; > + } > + > + if (cali_re < aw_dev->re_range.re_min || cali_re > aw_dev->re_range.re_max) { > + aw_dev_err(aw_dev->dev, > + "out range re value: %d", cali_re); > + cali_desc->cali_re = AW_ERRO_CALI_RE_VALUE; > + /*cali_result is error when aw-cali-check enable*/ > + if (aw_dev->cali_desc.cali_check_st) > + cali_desc->cali_result = CALI_RESULT_ERROR; > + return -EINVAL; > + } > + cali_desc->cali_re = cali_re; > + > + /*cali_result is normal when aw-cali-check enable*/ > + if (aw_dev->cali_desc.cali_check_st) > + cali_desc->cali_result = CALI_RESULT_NORMAL; > + > + aw_dev_info(aw_dev->dev, "get cali re %d", cali_desc->cali_re); > + > + return 0; > +} > + > +int aw883xx_cali_read_cali_re_from_dsp(struct aw_cali_desc *cali_desc, uint32_t *re) > +{ > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + struct aw_adpz_re_desc *desc = &aw_dev->adpz_re_desc; > + int ret; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, desc->dsp_reg, re, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "set cali re error"); > + return ret; > + } > + > + *re = AW_DSP_RE_TO_SHOW_RE(*re, desc->shift); > + *re -= aw_dev->cali_desc.ra; > + > + aw_dev_info(aw_dev->dev, "get dsp re:%d", *re); > + > + return 0; > +} > + > + > +/*************Calibration base function************/ > +int aw883xx_cali_svc_set_cali_re_to_dsp(struct aw_cali_desc *cali_desc) > +{ > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + struct aw_adpz_re_desc *adpz_re_desc = &aw_dev->adpz_re_desc; > + uint32_t cali_re = 0; > + int ret; > + > + cali_re = AW_SHOW_RE_TO_DSP_RE((aw_dev->cali_desc.cali_re + > + aw_dev->cali_desc.ra), adpz_re_desc->shift); > + > + /* set cali re to aw883xx */ > + ret = aw_dev->ops.aw_dsp_write(aw_dev, > + adpz_re_desc->dsp_reg, cali_re, adpz_re_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "set cali re error"); > + return ret; > + } > + > + ret = aw883xx_dev_modify_dsp_cfg(aw_dev, adpz_re_desc->dsp_reg, > + cali_re, adpz_re_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "modify dsp cfg failed"); > + return ret; > + } > + > + return 0; > +} > + > +int aw883xx_cali_svc_get_ra(struct aw_cali_desc *cali_desc) > +{ > + int ret; > + uint32_t dsp_ra; > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + struct aw_ra_desc *desc = &aw_dev->ra_desc; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, desc->dsp_reg, > + &dsp_ra, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read ra error"); > + return ret; > + } > + > + cali_desc->ra = AW_DSP_RE_TO_SHOW_RE(dsp_ra, > + aw_dev->adpz_re_desc.shift); > + aw_dev_info(aw_dev->dev, "get ra:%d", cali_desc->ra); > + return 0; > +} > + > +static int aw_cali_svc_get_dev_realtime_re(struct aw_device *aw_dev, > + uint32_t *re) > +{ > + int ret; > + struct aw_adpz_re_desc *re_desc = &aw_dev->adpz_re_desc; > + struct aw_ra_desc *ra_desc = &aw_dev->ra_desc; > + struct aw_adpz_t0_desc *t0_desc = &aw_dev->t0_desc; > + uint32_t dsp_re = 0; > + uint32_t show_re = 0; > + uint32_t re_cacl = 0; > + uint32_t ra = 0; > + uint32_t t0 = 0; > + int32_t te = 0; > + int32_t te_cacl = 0; > + uint32_t coil_alpha = 0; > + uint16_t pst_rpt = 0; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, re_desc->dsp_reg, &dsp_re, re_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read re error"); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, ra_desc->dsp_reg, &ra, ra_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read ra error"); > + return ret; > + } > + > + re_cacl = dsp_re - ra; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, t0_desc->dsp_reg, &t0, t0_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read t0 error"); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, t0_desc->coilalpha_reg, > + &coil_alpha, t0_desc->coil_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read coil_alpha error"); > + return ret; > + } > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, aw_dev->spkr_temp_desc.reg, &pst_rpt); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "reg read pst_rpt error"); > + return ret; > + } > + > + te = (int32_t)((uint32_t)pst_rpt - t0); > + > + te_cacl = AW_TE_CACL_VALUE(te, (uint16_t)coil_alpha); > + > + show_re = AW_RE_REALTIME_VALUE((int32_t)re_cacl, te_cacl); > + > + *re = AW_DSP_RE_TO_SHOW_RE(show_re, re_desc->shift); > + aw_dev_dbg(aw_dev->dev, "real_r0:[%d]", *re); > + > + return 0; > +} > + > +static int aw_cali_svc_get_dev_re(struct aw_device *aw_dev, > + uint32_t *re) > +{ > + int ret; > + struct aw_ste_re_desc *desc = &aw_dev->ste_re_desc; > + uint32_t dsp_re = 0; > + uint32_t show_re = 0; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, desc->dsp_reg, &dsp_re, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read re error"); > + return ret; > + } > + > + show_re = AW_DSP_RE_TO_SHOW_RE(dsp_re, > + aw_dev->ste_re_desc.shift); > + > + *re = show_re - aw_dev->cali_desc.ra; > + aw_dev_dbg(aw_dev->dev, "real_r0:[%d]", *re); > + > + return 0; > +} > + > +static int aw_cali_svc_get_devs_r0(struct aw_device *aw_dev, int32_t *r0_buf, int num) > +{ > + struct list_head *dev_list = NULL; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret, cnt = 0; > + > + //get dev list > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, "get dev list failed"); > + return ret; > + } > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel < num) { > + ret = aw_cali_svc_get_dev_realtime_re(local_dev, > + &r0_buf[local_dev->channel]); > + if (ret) { > + aw_dev_err(local_dev->dev, "get r0 failed!"); > + return ret; > + } > + cnt++; > + } else { > + aw_dev_err(aw_dev->dev, "channel num[%d] overflow buf num[%d] ", > + local_dev->channel, num); > + } > + } > + return cnt; > +} > + > +static int aw_cali_svc_get_dev_f0(struct aw_device *aw_dev, > + uint32_t *f0) > +{ > + struct aw_f0_desc *f0_desc = &aw_dev->f0_desc; > + uint32_t dsp_val = 0; > + int ret; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + f0_desc->dsp_reg, &dsp_val, f0_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read f0 failed"); > + return ret; > + } > + > + *f0 = dsp_val >> f0_desc->shift; > + aw_dev_dbg(aw_dev->dev, "real_f0:[%d]", *f0); > + > + return 0; > +} > + > +static int aw_cali_svc_get_devs_f0(struct aw_device *aw_dev, int32_t *f0_buf, int num) > +{ > + struct list_head *dev_list = NULL; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret, cnt = 0; > + > + //get dev list > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, "get dev list failed"); > + return ret; > + } > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel < num) { > + ret = aw_cali_svc_get_dev_f0(local_dev, &f0_buf[local_dev->channel]); > + if (ret) { > + aw_dev_err(local_dev->dev, "get f0 failed!"); > + return ret; > + } > + cnt++; > + } else { > + aw_dev_err(aw_dev->dev, "channel num[%d] overflow buf num[%d] ", > + local_dev->channel, num); > + } > + } > + return cnt; > +} > + > +static int aw_cali_svc_get_dev_q(struct aw_device *aw_dev, > + uint32_t *q) > +{ > + struct aw_q_desc *q_desc = &aw_dev->q_desc; > + uint32_t dsp_val = 0; > + int ret; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + q_desc->dsp_reg, &dsp_val, q_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read q failed"); > + return ret; > + } > + > + *q = ((dsp_val * 1000) >> q_desc->shift); > + > + return 0; > +} > + > +int aw883xx_cali_svc_get_dev_te(struct aw_cali_desc *cali_desc, int32_t *te) > +{ > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + uint16_t reg_val = 0; > + int ret; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, aw_dev->spkr_temp_desc.reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read temperature failed"); > + return ret; > + } > + > + *te = (int32_t)((int16_t)reg_val); > + aw_dev_info(aw_dev->dev, "real_te:[%d]", *te); > + > + return 0; > +} > + > +static int aw_cali_svc_get_devs_te(struct aw_device *aw_dev, int32_t *te_buf, int num) > +{ > + struct list_head *dev_list = NULL; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret, cnt = 0; > + > + //get dev list > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, "get dev list failed"); > + return ret; > + } > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel < num) { > + ret = aw883xx_cali_svc_get_dev_te(&local_dev->cali_desc, > + &te_buf[local_dev->channel]); > + if (ret) { > + aw_dev_err(local_dev->dev, "get temperature failed!"); > + return ret; > + } > + cnt++; > + } else { > + aw_dev_err(aw_dev->dev, "channel num[%d] overflow buf num[%d]", > + local_dev->channel, num); > + } > + } > + return cnt; > +} > + > +static void aw_cali_svc_bubble_sort(uint32_t *data, int data_size) > +{ > + int loop_num = data_size - 1; > + uint16_t temp_store = 0; > + int i; > + int j; > + > + if (data == NULL) { > + aw_pr_err("data is NULL"); > + return; > + } > + > + for (i = 0; i < loop_num; i++) { > + for (j = 0; j < loop_num - i; j++) { > + if (data[j] > data[j + 1]) { > + temp_store = data[j]; > + data[j] = data[j + 1]; > + data[j + 1] = temp_store; > + } > + } > + } > +} > + > +static int aw_cali_svc_del_max_min_ave_algo(uint32_t *data, int data_size) > +{ > + int sum = 0; > + int ave = 0; > + int i = 0; > + > + aw_cali_svc_bubble_sort(data, data_size); > + for (i = 1; i < data_size - 1; i++) > + sum += data[i]; > + > + if ((data_size - AW_CALI_DATA_SUM_RM) == 0) { > + aw_pr_err("data_size id :%d less than 2", data_size); > + return -EINVAL; > + } > + > + ave = sum / (data_size - AW_CALI_DATA_SUM_RM); > + > + return ave; > +} > + > +static void aw_cali_svc_set_cali_status(struct aw_device *aw_dev, bool status) > +{ > + aw_dev->cali_desc.status = status; > + > + if (status) > + aw883xx_monitor_stop(&aw_dev->monitor_desc); > + else > + aw883xx_monitor_start(&aw_dev->monitor_desc); > + > + aw_dev_info(aw_dev->dev, "cali %s", > + (status == 0) ? ("disable") : ("enable")); > +} > + > +bool aw883xx_cali_svc_get_cali_status(struct aw_cali_desc *cali_desc) > +{ > + return cali_desc->status; > +} > + > +static int aw_cali_svc_cali_init_check(struct aw_device *aw_dev) > +{ > + int ret; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + ret = aw883xx_dev_sysst_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "syst_check failed"); > + return ret; > + } > + > + ret = aw883xx_dev_get_dsp_status(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp status error"); > + return ret; > + } > + > + ret = aw883xx_dev_get_hmute(aw_dev); > + if (ret == 1) { > + aw_dev_err(aw_dev->dev, "mute staus"); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_cali_svc_get_cali_cfg(struct aw_device *aw_dev) > +{ > + int ret; > + struct aw_cali_cfg_desc *desc = &aw_dev->cali_cfg_desc; > + struct cali_cfg *cali_cfg = &aw_dev->cali_desc.cali_cfg; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + desc->actampth_reg, &cali_cfg->data[0], desc->actampth_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read reg0x%x error", desc->actampth_reg); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + desc->noiseampth_reg, &cali_cfg->data[1], desc->noiseampth_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read reg0x%x error", desc->noiseampth_reg); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + desc->ustepn_reg, &cali_cfg->data[2], desc->ustepn_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read reg0x%x error", desc->ustepn_reg); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + desc->alphan_reg, &cali_cfg->data[3], desc->alphan_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read reg0x%x error", desc->alphan_reg); > + return ret; > + } > + > + return 0; > +} > + > +static int aw_cali_svc_set_cali_cfg(struct aw_device *aw_dev, > + struct cali_cfg cali_cfg) > +{ > + int ret; > + struct aw_cali_cfg_desc *desc = &aw_dev->cali_cfg_desc; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, > + desc->actampth_reg, cali_cfg.data[0], desc->actampth_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp write reg0x%x error", desc->actampth_reg); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, > + desc->noiseampth_reg, cali_cfg.data[1], desc->noiseampth_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp write reg0x%x error", desc->noiseampth_reg); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, > + desc->ustepn_reg, cali_cfg.data[2], desc->ustepn_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp write reg0x%x error", desc->ustepn_reg); > + return ret; > + } > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, > + desc->alphan_reg, cali_cfg.data[3], desc->alphan_data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp write reg0x%x error", desc->alphan_reg); > + return ret; > + } > + > + return 0; > +} > + > +static int aw_cali_svc_get_smooth_cali_re(struct aw_device *aw_dev) > +{ > + int ret = 0; > + int i = 0; > + uint32_t re_temp[AW_CALI_READ_CNT_MAX] = { 0 }; > + uint32_t dsp_re; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + for (i = 0; i < AW_CALI_READ_CNT_MAX; i++) { > + ret = aw_cali_svc_get_dev_re(aw_dev, &re_temp[i]); > + if (ret < 0) > + goto cali_re_fail; > + > + msleep(30);/*delay 30 ms*/ > + } > + dsp_re = aw_cali_svc_del_max_min_ave_algo(re_temp, > + AW_CALI_READ_CNT_MAX); > + > + if (aw_dev->ops.aw_cali_svc_get_iv_st) { > + ret = aw_dev->ops.aw_cali_svc_get_iv_st(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, > + "get iv data failed"); > + goto cali_re_fail; > + } > + } > + > + if (dsp_re < aw_dev->re_range.re_min || dsp_re > aw_dev->re_range.re_max) { > + aw_dev_err(aw_dev->dev, > + "out range re value: [%d]mohm", dsp_re); > + aw_dev->cali_desc.cali_re = dsp_re; > + if (aw_dev->cali_desc.cali_check_st) { > + aw_dev->cali_desc.cali_result = CALI_RESULT_ERROR; > + ret = aw_cali_write_re_to_nvram(dsp_re, aw_dev->channel); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "write re failed"); > + } > + aw_cali_svc_run_mute(aw_dev, aw_dev->cali_desc.cali_result); > + return 0; > + } > + > + ret = aw_cali_write_re_to_nvram(dsp_re, aw_dev->channel); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write re failed"); > + goto cali_re_fail; > + } > + > + if (aw_dev->cali_desc.cali_check_st) > + aw_dev->cali_desc.cali_result = CALI_RESULT_NORMAL; > + > + aw_dev->cali_desc.cali_re = dsp_re; > + aw_dev_info(aw_dev->dev, "re[%d]mohm", aw_dev->cali_desc.cali_re); > + > + aw883xx_dev_dsp_enable(aw_dev, false); > + aw883xx_cali_svc_set_cali_re_to_dsp(&aw_dev->cali_desc); > + aw883xx_dev_dsp_enable(aw_dev, true); > + > + return 0; > + > +cali_re_fail: > + if (aw_dev->cali_desc.cali_check_st) > + aw_dev->cali_desc.cali_result = CALI_RESULT_ERROR; > + aw_cali_svc_run_mute(aw_dev, aw_dev->cali_desc.cali_result); > + return -EINVAL; > +} > + > +static int aw_cali_svc_cali_en(struct aw_device *aw_dev, bool cali_en) > +{ > + int ret = 0; > + struct cali_cfg set_cfg; > + > + aw_dev_info(aw_dev->dev, "cali_en:%d", cali_en); > + > + aw883xx_dev_dsp_enable(aw_dev, false); > + if (cali_en) { > + ret = aw_cali_svc_get_cali_cfg(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get cali cfg failed"); > + aw883xx_dev_dsp_enable(aw_dev, true); > + return ret; > + } > + set_cfg.data[0] = 0; > + set_cfg.data[1] = 0; > + set_cfg.data[2] = -1; > + set_cfg.data[3] = 1; > + > + ret = aw_cali_svc_set_cali_cfg(aw_dev, set_cfg); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "set cali cfg failed"); > + aw_cali_svc_set_cali_cfg(aw_dev, aw_dev->cali_desc.cali_cfg); > + aw883xx_dev_dsp_enable(aw_dev, true); > + return ret; > + } > + } else { > + aw_cali_svc_set_cali_cfg(aw_dev, aw_dev->cali_desc.cali_cfg); > + } > + aw883xx_dev_dsp_enable(aw_dev, true); > + > + return 0; > +} > + > +static int aw_cali_svc_cali_run_dsp_vol(struct aw_device *aw_dev, > + int type, bool enable) > +{ > + int ret; > + uint16_t reg_val = 0; > + uint16_t set_vol = 0; > + struct aw_dsp_vol_desc *desc = &aw_dev->dsp_vol_desc; > + > + aw_dev_info(aw_dev->dev, "type:%d, enable:%d", type, enable); > + > + if (enable) { > + /*set dsp vol*/ > + if (type == CALI_TYPE_RE) { > + set_vol = desc->mute_st; > + } else if (type == CALI_TYPE_F0) { > + set_vol = desc->noise_st; > + } else { > + aw_dev_err(aw_dev->dev, "type:%d unsupported", type); > + return -EINVAL; > + } > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, > + desc->reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read reg 0x%x failed", desc->reg); > + return ret; > + } > + > + aw_dev->cali_desc.store_vol = reg_val & (~desc->mask); > + reg_val &= desc->mask; > + reg_val |= set_vol; > + > + ret = aw_dev->ops.aw_reg_write(aw_dev, > + desc->reg, reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write reg 0x%x failed", desc->reg); > + return ret; > + } > + } else { > + /*reset dsp vol*/ > + ret = aw_dev->ops.aw_reg_read(aw_dev, > + desc->reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read reg 0x%x failed", desc->reg); > + return ret; > + } > + > + reg_val &= desc->mask; > + reg_val |= aw_dev->cali_desc.store_vol; > + > + ret = aw_dev->ops.aw_reg_write(aw_dev, > + desc->reg, reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write reg 0x%x failed", desc->reg); > + return ret; > + } > + } > + > + return 0; > +} > + > +static int aw_cali_svc_set_white_noise(struct aw_device *aw_dev, > + bool noise_enable) > +{ > + int ret; > + uint32_t reg_val; > + struct aw_noise_desc *desc = &aw_dev->noise_desc; > + > + aw_dev_info(aw_dev->dev, "set noise %s", > + (noise_enable == 0) ? ("disable") : ("enable")); > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + desc->dsp_reg, &reg_val, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read dsp reg 0x%x failed", desc->dsp_reg); > + return ret; > + } > + > + if (noise_enable) > + reg_val |= (~desc->mask); > + else > + reg_val &= desc->mask; > + > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, > + desc->dsp_reg, reg_val, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write dsp reg 0x%x failed", desc->dsp_reg); > + return ret; > + } > + > + return 0; > +} > + > +static int aw_cali_svc_cali_f0_en(struct aw_device *aw_dev, bool f0_enable) > +{ > + int ret; > + struct aw_cali_delay_desc *desc = &aw_dev->cali_delay_desc; > + > + aw_dev_info(aw_dev->dev, "cali f0 %s", > + (f0_enable == 0) ? ("disable") : ("enable")); > + > + if (f0_enable) { > + ret = aw_cali_svc_cali_run_dsp_vol(aw_dev, CALI_TYPE_F0, true); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "run dsp volume error, ret=%d", ret); > + return ret; > + } > + > + msleep(desc->delay); > + > + ret = aw_cali_svc_set_white_noise(aw_dev, true); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write white noise error, ret=%d", ret); > + aw_cali_svc_cali_run_dsp_vol(aw_dev, CALI_TYPE_F0, false); > + return ret; > + } > + } else { > + aw_cali_svc_set_white_noise(aw_dev, false); > + aw_cali_svc_cali_run_dsp_vol(aw_dev, CALI_TYPE_F0, false); > + } > + > + return 0; > +} > + > +static int aw_cali_svc_get_cali_f0_q(struct aw_device *aw_dev) > +{ > + int ret = -1; > + int cnt = 0; > + uint32_t f0 = 0; > + uint32_t q = 0; > + uint32_t f0_sum = 0; > + uint32_t q_sum = 0; > + struct aw_cali_desc *cali_desc = &aw_dev->cali_desc; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + for (cnt = 0; cnt < F0_READ_CNT_MAX; cnt++) { > + /*f0*/ > + ret = aw_cali_svc_get_dev_f0(aw_dev, &f0); > + if (ret < 0) > + return ret; > + f0_sum += f0; > + > + /*q*/ > + ret = aw_cali_svc_get_dev_q(aw_dev, &q); > + if (ret < 0) > + return ret; > + q_sum += q; > + msleep(30); > + } > + > + cali_desc->f0 = f0_sum / cnt; > + cali_desc->q = q_sum / cnt; > + > + if (aw_dev->ops.aw_cali_svc_get_iv_st) { > + ret = aw_dev->ops.aw_cali_svc_get_iv_st(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, > + "get iv data failed, set default f0: 2600 q: 2600"); > + cali_desc->f0 = 2600; > + cali_desc->q = 2600; > + } > + } > + aw_dev_info(aw_dev->dev, "f0[%d] q[%d]", cali_desc->f0, cali_desc->q); > + return 0; > +} > + > +static int aw_cali_svc_cali_mode_enable(struct aw_device *aw_dev, > + int type, unsigned int flag, bool is_enable) > +{ > + int ret; > + > + aw_dev_info(aw_dev->dev, "type:%d, flag:0x%x, is_enable:%d", > + type, flag, is_enable); > + > + if (is_enable) { > + ret = aw_cali_svc_cali_init_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "init check failed"); > + return ret; > + } > + > + aw_cali_svc_set_cali_status(aw_dev, true); > + > + ret = aw_cali_svc_cali_en(aw_dev, true); > + if (ret < 0) { > + aw_cali_svc_set_cali_status(aw_dev, false); > + return ret; > + } > + > + if ((type == CALI_TYPE_RE) && (flag & CALI_OPS_HMUTE)) { > + ret = aw_cali_svc_cali_run_dsp_vol(aw_dev, CALI_TYPE_RE, true); > + if (ret < 0) { > + aw_cali_svc_cali_en(aw_dev, false); > + aw_cali_svc_set_cali_status(aw_dev, false); > + return ret; > + } > + } else if ((type == CALI_TYPE_F0) && (flag & CALI_OPS_NOISE)) { > + ret = aw_cali_svc_cali_f0_en(aw_dev, true); > + if (ret < 0) { > + aw_cali_svc_cali_en(aw_dev, false); > + aw_cali_svc_set_cali_status(aw_dev, false); > + return ret; > + } > + } > + } else { > + > + if ((type == CALI_TYPE_RE) && (flag & CALI_OPS_HMUTE)) > + aw_cali_svc_cali_run_dsp_vol(aw_dev, CALI_TYPE_RE, false); > + else if ((type == CALI_TYPE_F0) && (flag & CALI_OPS_NOISE)) > + aw_cali_svc_cali_f0_en(aw_dev, false); > + > + aw_cali_svc_cali_en(aw_dev, false); > + aw883xx_dev_clear_int_status(aw_dev); > + aw_cali_svc_set_cali_status(aw_dev, false); > + } > + > + return 0; > +} > + > +static int aw_cali_svc_devs_cali_mode_enable(struct list_head *dev_list, > + int type, unsigned int flag, > + bool is_enable) > +{ > + int ret; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (is_enable) > + aw_cali_svc_run_mute(local_dev, CALI_RESULT_NORMAL); > + ret = aw_cali_svc_cali_mode_enable(local_dev, type, flag, is_enable); > + if (ret < 0) > + return ret; > + if (!is_enable && (type == CALI_TYPE_F0)) > + aw_cali_svc_run_mute(local_dev, local_dev->cali_desc.cali_result); > + } > + > + return ret; > +} > + > +static int aw_cali_svc_dev_cali_re(struct aw_device *aw_dev, unsigned int flag) > +{ > + int ret; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + aw_cali_svc_run_mute(aw_dev, CALI_RESULT_NORMAL); > + > + ret = aw_cali_svc_cali_mode_enable(aw_dev, > + CALI_TYPE_RE, flag, true); > + if (ret < 0) > + return ret; > + > + msleep(g_cali_re_time); > + > + ret = aw_cali_svc_get_smooth_cali_re(aw_dev); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "cali re failed"); > + > + aw_cali_svc_cali_mode_enable(aw_dev, > + CALI_TYPE_RE, flag, false); > + > + return ret; > +} > + > +static int aw_cali_svc_devs_get_cali_re(struct list_head *dev_list) > +{ > + int ret; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + ret = aw_cali_svc_get_smooth_cali_re(local_dev); > + if (ret < 0) { > + aw_dev_err(local_dev->dev, "get re failed"); > + return ret; > + } > + } > + > + return ret; > +} > + > +static int aw_cali_svc_devs_cali_re(struct aw_device *aw_dev, unsigned int flag) > +{ > + int ret; > + struct list_head *dev_list = NULL; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, " get dev list failed"); > + return ret; > + } > + > + ret = aw_cali_svc_devs_cali_mode_enable(dev_list, CALI_TYPE_RE, flag, true); > + if (ret < 0) > + goto error; > + > + msleep(g_cali_re_time); > + > + ret = aw_cali_svc_devs_get_cali_re(dev_list); > + if (ret < 0) > + goto error; > + > + aw_cali_svc_devs_cali_mode_enable(dev_list, CALI_TYPE_RE, flag, false); > + > + return 0; > + > +error: > + aw_cali_svc_devs_cali_mode_enable(dev_list, CALI_TYPE_RE, flag, false); > + return ret; > +} > + > +static int aw_cali_svc_cali_re(struct aw_device *aw_dev, bool is_single, unsigned int flag) > +{ > + if (is_single) > + return aw_cali_svc_dev_cali_re(aw_dev, flag); > + else > + return aw_cali_svc_devs_cali_re(aw_dev, flag); > +} > + > +static int aw_cali_svc_set_devs_re_str(struct aw_device *aw_dev, const char *re_str) > +{ > + struct list_head *dev_list = NULL, *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret, cnt = 0; > + int re_data[AW_DEV_CH_MAX] = { 0 }; > + char str_data[32] = { 0 }; > + int i, len = 0; > + int dev_num = 0; > + > + /*get dev list*/ > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get dev list failed"); > + return ret; > + } > + > + dev_num = aw_dev->ops.aw_get_dev_num(); > + > + for (i = 0 ; i < dev_num; i++) { > + memset(str_data, 0, sizeof(str_data)); > + snprintf(str_data, sizeof(str_data), "dev[%d]:%s ", i, "%d"); > + ret = sscanf(re_str + len, str_data, &re_data[i]); > + if (ret <= 0) { > + aw_dev_err(aw_dev->dev, "unsupported str: %s", re_str); > + return -EINVAL; > + } > + len += snprintf(str_data, sizeof(str_data), "dev[%d]:%d ", i, re_data[i]); > + if (len > strlen(re_str)) { > + aw_dev_err(aw_dev->dev, "%s: unsupported", re_str); > + return -EINVAL; > + } > + } > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel < AW_DEV_CH_MAX) { > + ret = aw_cali_store_cali_re(local_dev, re_data[local_dev->channel]); > + if (ret < 0) { > + aw_dev_err(local_dev->dev, "store cali re failed"); > + return ret; > + } > + cnt++; > + } > + } > + > + return cnt; > +} > + > +static int aw_cali_svc_dev_cali_f0_q(struct aw_device *aw_dev, unsigned int flag) > +{ > + int ret; > + > + aw_cali_svc_run_mute(aw_dev, CALI_RESULT_NORMAL); > + > + ret = aw_cali_svc_cali_mode_enable(aw_dev, CALI_TYPE_F0, flag, true); > + if (ret < 0) > + return ret; > + > + msleep(AW_CALI_F0_TIME); > + > + ret = aw_cali_svc_get_cali_f0_q(aw_dev); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "get f0 q failed"); > + > + aw_cali_svc_cali_mode_enable(aw_dev, CALI_TYPE_F0, flag, false); > + > + aw_cali_svc_run_mute(aw_dev, aw_dev->cali_desc.cali_result); > + > + return ret; > +} > + > +static int aw_cali_svc_devs_get_cali_f0_q(struct list_head *dev_list) > +{ > + int ret; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + ret = aw_cali_svc_get_cali_f0_q(local_dev); > + if (ret < 0) { > + aw_dev_err(local_dev->dev, "get f0 q failed"); > + return ret; > + } > + } > + > + return ret; > +} > + > +static int aw_cali_svc_devs_cali_f0_q(struct aw_device *aw_dev, unsigned int flag) > +{ > + int ret; > + struct list_head *dev_list = NULL; > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, " get dev list failed"); > + return ret; > + } > + > + ret = aw_cali_svc_devs_cali_mode_enable(dev_list, CALI_TYPE_F0, flag, true); > + if (ret < 0) > + goto error; > + > + msleep(AW_CALI_F0_TIME); > + > + ret = aw_cali_svc_devs_get_cali_f0_q(dev_list); > + if (ret < 0) > + goto error; > + > + aw_cali_svc_devs_cali_mode_enable(dev_list, CALI_TYPE_F0, flag, false); > + > + return 0; > + > +error: > + aw_cali_svc_devs_cali_mode_enable(dev_list, CALI_TYPE_F0, flag, false); > + return ret; > +} > + > +static int aw_cali_svc_cali_f0_q(struct aw_device *aw_dev, bool is_single, unsigned int flag) > +{ > + if (is_single) > + return aw_cali_svc_dev_cali_f0_q(aw_dev, flag); > + else > + return aw_cali_svc_devs_cali_f0_q(aw_dev, flag); > +} > + > +static int aw_cali_svc_get_dev_cali_val(struct aw_device *aw_dev, int type, uint32_t *data_buf) > +{ > + switch (type) { > + case GET_RE_TYPE: > + *data_buf = aw_dev->cali_desc.cali_re; > + break; > + case GET_F0_TYPE: > + *data_buf = aw_dev->cali_desc.f0; > + break; > + case GET_Q_TYPE: > + *data_buf = aw_dev->cali_desc.q; > + break; > + default: > + aw_dev_err(aw_dev->dev, "type:%d not support", type); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_cali_svc_get_devs_cali_val(struct aw_device *aw_dev, > + int type, > + uint32_t *data_buf, > + int num) > +{ > + struct list_head *dev_list = NULL; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret, cnt = 0; > + > + /*get dev list*/ > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, "get dev list failed"); > + return ret; > + } > + > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel < num) { > + switch (type) { > + case GET_RE_TYPE: > + data_buf[local_dev->channel] = local_dev->cali_desc.cali_re; > + break; > + case GET_F0_TYPE: > + data_buf[local_dev->channel] = local_dev->cali_desc.f0; > + break; > + case GET_Q_TYPE: > + data_buf[local_dev->channel] = local_dev->cali_desc.q; > + break; > + default: > + aw_dev_err(local_dev->dev, "type:%d not support", type); > + return -EINVAL; > + } > + cnt++; > + } else { > + aw_dev_err(local_dev->dev, "channel num[%d] overflow buf num[%d]", > + local_dev->channel, num); > + return -EINVAL; > + } > + } > + > + return cnt; > +} > + > +static int aw_cali_svc_cali_re_f0_q(struct aw_device *aw_dev, bool is_single, unsigned int flag) > +{ > + int ret; > + > + ret = aw_cali_svc_cali_re(aw_dev, is_single, flag); > + if (ret < 0) > + return ret; > + > + ret = aw_cali_svc_cali_f0_q(aw_dev, is_single, flag); > + if (ret < 0) > + return ret; > + > + return 0; > +} > + > +static int aw_cali_svc_cali_cmd(struct aw_device *aw_dev, > + int cali_cmd, > + bool is_single, > + unsigned int flag) > +{ > + switch (cali_cmd) { > + case AW_CALI_CMD_RE: { > + return aw_cali_svc_cali_re(aw_dev, is_single, flag); > + } break; > + case AW_CALI_CMD_F0: > + case AW_CALI_CMD_F0_Q: { > + return aw_cali_svc_cali_f0_q(aw_dev, is_single, flag); > + } break; > + case AW_CALI_CMD_RE_F0: > + case AW_CALI_CMD_RE_F0_Q: { > + return aw_cali_svc_cali_re_f0_q(aw_dev, is_single, flag); > + } > + default: { > + aw_dev_err(aw_dev->dev, "unsupported cmd %d", cali_cmd); > + return -EINVAL; > + } > + } > + return 0; > +} > + > +static int aw_cali_svc_get_cmd_form_str(struct aw_device *aw_dev, const char *buf) > +{ > + int i; > + > + for (i = 0; i < CALI_STR_MAX; i++) { > + if (!strncmp(cali_str[i], buf, strlen(cali_str[i]))) > + break; > + } > + > + if (i == CALI_STR_MAX) { > + aw_dev_err(aw_dev->dev, "supported cmd [%s]!", buf); > + return -EINVAL; > + } > + > + aw_dev_dbg(aw_dev->dev, "find str [%s]", cali_str[i]); > + return i; > +} > + > +/*****************************attr cali***************************************************/ > +static ssize_t aw_cali_attr_time_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + int ret; > + uint32_t time; > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + > + ret = kstrtoint(buf, 0, &time); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read buf %s failed", buf); > + return ret; > + } > + > + if (time < 1000) { > + aw_dev_err(aw_dev->dev, "time:%d is too short, no set", time); > + return -EINVAL; > + } > + > + g_cali_re_time = time; > + aw_dev_dbg(aw_dev->dev, "time:%u", time); > + > + return count; > +} > + > +static ssize_t aw_cali_attr_time_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + ssize_t len = 0; > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "time: %u\n", g_cali_re_time); > + > + return len; > +} > + > +static ssize_t aw_cali_attr_re_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + int ret; > + int re; > + > + if (is_single_cali) { > + ret = kstrtoint(buf, 0, &re); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read buf %s failed", buf); > + return ret; > + } > + > + ret = aw_cali_store_cali_re(aw_dev, re); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "store cali re failed!"); > + return ret; > + } > + } else { > + ret = aw_cali_svc_set_devs_re_str(aw_dev, buf); > + if (ret <= 0) { > + aw_pr_err("set re str %s failed", buf); > + return -EPERM; > + } > + } > + > + return count; > +} > + > +static ssize_t aw_cali_attr_re_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + int ret, i; > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + ssize_t len = 0; > + int32_t re[AW_DEV_CH_MAX] = { 0 }; > + > + ret = aw_cali_svc_cali_re(aw_dev, is_single_cali, CALI_OPS_HMUTE); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "cali re failed"); > + return ret; > + } > + > + if (is_single_cali) { > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]: %umOhms\n", > + aw_dev->channel, aw_dev->cali_desc.cali_re); > + } else { > + ret = aw_cali_svc_get_devs_cali_val(aw_dev, GET_RE_TYPE, re, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(aw_dev->dev, "get re failed"); > + } else { > + for (i = 0; i < ret; i++) > + len += snprintf(buf+len, PAGE_SIZE-len, > + "dev[%d]: %umOhms ", i, re[i]); > + > + len += snprintf(buf+len, PAGE_SIZE-len, "\n"); > + } > + } > + > + return len; > +} > + > +static ssize_t aw_cali_attr_f0_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + int ret, i; > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + ssize_t len = 0; > + uint32_t f0[AW_DEV_CH_MAX] = { 0 }; > + > + ret = aw_cali_svc_cali_f0_q(aw_dev, is_single_cali, CALI_OPS_NOISE); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "cali f0 failed"); > + return ret; > + } > + > + if (is_single_cali) { > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]:%u Hz\n", > + aw_dev->channel, aw_dev->cali_desc.f0); > + } else { > + ret = aw_cali_svc_get_devs_cali_val(aw_dev, GET_F0_TYPE, f0, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(aw_dev->dev, "get re failed"); > + } else { > + for (i = 0; i < ret; i++) > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]:%u Hz ", i, f0[i]); > + > + len += snprintf(buf+len, PAGE_SIZE-len, "\n"); > + } > + } > + > + return len; > +} > + > +static ssize_t aw_cali_attr_f0_q_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + int ret, i; > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + ssize_t len = 0; > + uint32_t f0[AW_DEV_CH_MAX] = { 0 }; > + uint32_t q[AW_DEV_CH_MAX] = { 0 }; > + > + ret = aw_cali_svc_cali_f0_q(aw_dev, is_single_cali, CALI_OPS_NOISE); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "cali f0 q failed"); > + return ret; > + } > + > + if (is_single_cali) { > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]f0:%u Hz q:%u\n", > + aw_dev->channel, aw_dev->cali_desc.f0, aw_dev->cali_desc.q); > + } else { > + > + ret = aw_cali_svc_get_devs_cali_val(aw_dev, GET_F0_TYPE, f0, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(aw_dev->dev, "get f0 failed"); > + return -EINVAL; > + } > + > + ret = aw_cali_svc_get_devs_cali_val(aw_dev, GET_Q_TYPE, q, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(aw_dev->dev, "get q failed"); > + return -EINVAL; > + } > + > + for (i = 0; i < ret; i++) > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]:f0:%u Hz q:%u ", > + i, f0[i], q[i]); > + > + len += snprintf(buf+len, PAGE_SIZE-len, "\n"); > + } > + > + return len; > +} > + > +static ssize_t aw_re_range_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + ssize_t len = 0; > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + uint32_t range_buf[RE_RANGE_NUM] = { 0 }; > + > + aw_cali_svc_get_dev_re_range(aw_dev, range_buf); > + > + len += snprintf(buf + len, PAGE_SIZE - len, > + "re_min value: [%d]\n", range_buf[RE_MIN_FLAG]); > + len += snprintf(buf + len, PAGE_SIZE - len, > + "re_max value: [%d]\n", range_buf[RE_MAX_FLAG]); > + > + return len; > +} > + > +static DEVICE_ATTR(cali_time, 0644, > + aw_cali_attr_time_show, aw_cali_attr_time_store); > +static DEVICE_ATTR(cali_re, 0644, > + aw_cali_attr_re_show, aw_cali_attr_re_store); > +static DEVICE_ATTR(cali_f0, 0444, > + aw_cali_attr_f0_show, NULL); > +static DEVICE_ATTR(cali_f0_q, 0444, > + aw_cali_attr_f0_q_show, NULL); > +static DEVICE_ATTR(re_range, 0444, > + aw_re_range_show, NULL); > + > +static struct attribute *aw_cali_attr[] = { > + &dev_attr_cali_time.attr, > + &dev_attr_cali_re.attr, > + &dev_attr_cali_f0.attr, > + &dev_attr_cali_f0_q.attr, > + &dev_attr_re_range.attr, > + NULL > +}; > + > +static struct attribute_group aw_cali_attr_group = { > + .attrs = aw_cali_attr, > + NULL > +}; > + > +static void aw_cali_attr_init(struct aw_device *aw_dev) > +{ > + int ret; > + > + ret = sysfs_create_group(&aw_dev->dev->kobj, &aw_cali_attr_group); > + if (ret < 0) > + aw_dev_info(aw_dev->dev, "error creating sysfs cali attr files"); > +} > + > +static void aw_cali_attr_deinit(struct aw_device *aw_dev) > +{ > + sysfs_remove_group(&aw_dev->dev->kobj, &aw_cali_attr_group); > + aw_dev_info(aw_dev->dev, "attr files deinit"); > +} > + > + > + > + > +/*****************************class node******************************************************/ > +static ssize_t aw_cali_class_time_show(struct class *class, struct class_attribute *attr, char *buf) > +{ > + ssize_t len = 0; > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "time: %d\n", g_cali_re_time); > + > + return len; > +} > + > +static ssize_t aw_cali_class_time_store(struct class *class, > + struct class_attribute *attr, const char *buf, size_t len) > +{ > + int ret; > + uint32_t time; > + > + ret = kstrtoint(buf, 0, &time); > + if (ret < 0) { > + aw_pr_err("read buf %s failed", buf); > + return ret; > + } > + > + if (time < 1000) { > + aw_pr_err("time:%d is too short, no set", time); > + return -EINVAL; > + } > + > + g_cali_re_time = time; > + aw_pr_dbg("time:%d", time); > + > + return len; > +} > + > +static ssize_t aw_cali_class_cali_re_show(struct class *class, > + struct class_attribute *attr, > + char *buf) > +{ > + struct list_head *dev_list; > + struct aw_device *local_dev; > + int ret, i; > + ssize_t len = 0; > + uint32_t cali_re[AW_DEV_CH_MAX] = { 0 }; > + > + aw_pr_info("enter"); > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_pr_err("get dev list failed"); > + return ret; > + } > + > + local_dev = list_first_entry(dev_list, struct aw_device, list_node); > + > + ret = aw_cali_svc_cali_re(local_dev, false, CALI_OPS_HMUTE); > + if (ret < 0) > + return ret; > + > + ret = aw_cali_svc_get_devs_cali_val(local_dev, GET_RE_TYPE, cali_re, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(local_dev->dev, "get re failed"); > + } else { > + for (i = 0; i < ret; i++) > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]:%u mOhms ", i, cali_re[i]); > + > + len += snprintf(buf+len, PAGE_SIZE-len, "\n"); > + } > + > + return len; > +} > + > +static ssize_t aw_cali_class_cali_re_store(struct class *class, > + struct class_attribute *attr, const char *buf, size_t len) > +{ > + struct list_head *dev_list = NULL; > + struct aw_device *local_dev = NULL; > + int ret; > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_pr_err("get dev list failed"); > + return ret; > + } > + > + local_dev = list_first_entry(dev_list, struct aw_device, list_node); > + > + ret = aw_cali_svc_set_devs_re_str(local_dev, buf); > + if (ret <= 0) { > + aw_pr_err("set re str %s failed", buf); > + return -EPERM; > + } > + > + return len; > +} > + > +static ssize_t aw_cali_class_cali_f0_show(struct class *class, > + struct class_attribute *attr, char *buf) > +{ > + struct list_head *dev_list = NULL; > + struct aw_device *local_dev = NULL; > + int ret = -1; > + int i = 0; > + ssize_t len = 0; > + uint32_t f0[AW_DEV_CH_MAX] = { 0 }; > + > + aw_pr_info("enter"); > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret < 0) { > + aw_pr_err("get dev list failed"); > + return ret; > + } > + > + local_dev = list_first_entry(dev_list, struct aw_device, list_node); > + > + ret = aw_cali_svc_cali_f0_q(local_dev, is_single_cali, CALI_OPS_NOISE); > + if (ret < 0) { > + aw_pr_err("cali f0 failed"); > + return ret; > + } > + > + ret = aw_cali_svc_get_devs_cali_val(local_dev, GET_F0_TYPE, f0, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_pr_err("get f0 failed"); > + } else { > + for (i = 0; i < ret; i++) > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]:%u Hz ", > + i, f0[i]); > + > + len += snprintf(buf+len, PAGE_SIZE-len, "\n"); > + } > + > + return len; > +} > + > +static ssize_t aw_cali_class_cali_f0_q_show(struct class *class, > + struct class_attribute *attr, > + char *buf) > +{ > + struct list_head *dev_list = NULL; > + struct aw_device *local_dev = NULL; > + int ret, i; > + ssize_t len = 0; > + uint32_t f0[AW_DEV_CH_MAX] = { 0 }; > + uint32_t q[AW_DEV_CH_MAX] = { 0 }; > + > + aw_pr_info("enter"); > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret < 0) { > + aw_pr_err("get dev list failed"); > + return ret; > + } > + > + local_dev = list_first_entry(dev_list, struct aw_device, list_node); > + > + ret = aw_cali_svc_cali_f0_q(local_dev, is_single_cali, CALI_OPS_NOISE); > + if (ret < 0) { > + aw_dev_err(local_dev->dev, "cali f0 q failed"); > + return ret; > + } > + > + ret = aw_cali_svc_get_devs_cali_val(local_dev, GET_F0_TYPE, f0, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(local_dev->dev, "get f0 failed"); > + return -EINVAL; > + } > + > + ret = aw_cali_svc_get_devs_cali_val(local_dev, GET_Q_TYPE, q, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(local_dev->dev, "get q failed"); > + return -EINVAL; > + } > + > + for (i = 0; i < ret; i++) > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]:f0:%u Hz q:%u ", > + i, f0[i], q[i]); > + > + len += snprintf(buf+len, PAGE_SIZE-len, "\n"); > + > + return len; > +} > + > +static ssize_t aw_class_re_range_show(struct class *class, struct class_attribute *attr, char *buf) > +{ > + int ret, i; > + ssize_t len = 0; > + struct list_head *dev_list = NULL; > + struct aw_device *local_dev = NULL; > + uint32_t re_value[AW_DEV_RE_RANGE] = { 0 }; > + > + aw_pr_info("enter"); > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret < 0) { > + aw_pr_err("get dev list failed"); > + return ret; > + } > + > + local_dev = list_first_entry(dev_list, struct aw_device, list_node); > + ret = aw_cali_svc_get_devs_re_range(local_dev, re_value, AW_DEV_CH_MAX); > + if (ret <= 0) { > + aw_dev_err(local_dev->dev, "get re range failed"); > + return -EINVAL; > + } > + > + for (i = 0; i < ret; i++) { > + len += snprintf(buf+len, PAGE_SIZE-len, "dev[%d]:re_min:%d re_max:%d ", > + i, re_value[RE_MIN_FLAG + i * RE_RANGE_NUM], > + re_value[RE_MAX_FLAG + i * RE_RANGE_NUM]); > + } > + len += snprintf(buf+len, PAGE_SIZE-len, "\n"); > + > + return len; > +} > + > +static struct class_attribute class_attr_cali_time = > + __ATTR(cali_time, 0644, > + aw_cali_class_time_show, aw_cali_class_time_store); > + > +static struct class_attribute class_attr_re25_calib = > + __ATTR(re25_calib, 0644, > + aw_cali_class_cali_re_show, aw_cali_class_cali_re_store); > + > +static struct class_attribute class_attr_f0_calib = > + __ATTR(f0_calib, 0444, > + aw_cali_class_cali_f0_show, NULL); > + > +static struct class_attribute class_attr_f0_q_calib = > + __ATTR(f0_q_calib, 0444, > + aw_cali_class_cali_f0_q_show, NULL); > + > +static struct class_attribute class_att_re_range = > + __ATTR(re_range, 0444, > + aw_class_re_range_show, NULL); > + > +static struct class aw_cali_class = { > + .name = "smartpa", > + .owner = THIS_MODULE, > +}; > + > +static void aw_cali_class_attr_init(struct aw_device *aw_dev) > +{ > + int ret; > + > + if (aw_dev->channel != 0) { > + aw_dev_err(aw_dev->dev, "class node already register"); > + return; > + } > + > + ret = class_register(&aw_cali_class); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "error creating class node"); > + return; > + } > + > + ret = class_create_file(&aw_cali_class, &class_attr_cali_time); > + if (ret) > + aw_dev_err(aw_dev->dev, "creat class_attr_cali_time fail"); > + > + ret = class_create_file(&aw_cali_class, &class_attr_re25_calib); > + if (ret) > + aw_dev_err(aw_dev->dev, "creat class_attr_re25_calib fail"); > + > + ret = class_create_file(&aw_cali_class, &class_attr_f0_calib); > + if (ret) > + aw_dev_err(aw_dev->dev, "creat class_attr_f0_calib fail"); > + > + > + ret = class_create_file(&aw_cali_class, &class_attr_f0_q_calib); > + if (ret) > + aw_dev_err(aw_dev->dev, "creat class_attr_f0_q_calib fail"); > + > + ret = class_create_file(&aw_cali_class, &class_att_re_range); > + if (ret) > + aw_dev_err(aw_dev->dev, "creat class_att_re_range fail"); > +} > + > +static void aw_cali_class_attr_deinit(struct aw_device *aw_dev) > +{ > + class_remove_file(&aw_cali_class, &class_att_re_range); > + class_remove_file(&aw_cali_class, &class_attr_f0_q_calib); > + class_remove_file(&aw_cali_class, &class_attr_f0_calib); > + class_remove_file(&aw_cali_class, &class_attr_re25_calib); > + class_remove_file(&aw_cali_class, &class_attr_cali_time); > + > + class_unregister(&aw_cali_class); > + aw_dev_info(aw_dev->dev, "unregister class node"); > +} > +/*****************************class node******************************************************/ > + > + > +/*****************************misc cali******************************************************/ > +static int aw_cali_misc_open(struct inode *inode, struct file *file) > +{ > + struct list_head *dev_list = NULL; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret; > + > + aw_pr_dbg("misc open success"); > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_pr_err("get dev list failed"); > + file->private_data = NULL; > + return -EINVAL; > + } > + > + //find select dev > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel == g_dev_select) > + break; > + } > + > + if (local_dev == NULL) { > + aw_pr_err("get dev failed"); > + return -EINVAL; > + } > + > + //cannot find sel dev, use list first dev > + if (local_dev->channel != g_dev_select) { > + local_dev = list_first_entry(dev_list, struct aw_device, list_node); > + aw_dev_dbg(local_dev->dev, "can not find dev[%d], use default", g_dev_select); > + } > + > + file->private_data = (void *)local_dev; > + > + aw_dev_dbg(local_dev->dev, "misc open success"); > + > + return 0; > +} > + > +static int aw_cali_misc_release(struct inode *inode, struct file *file) > +{ > + file->private_data = (void *)NULL; > + > + aw_pr_dbg("misc release success"); > + > + return 0; > +} > + > +static int aw_cali_misc_ops_write(struct aw_device *aw_dev, > + unsigned int cmd, unsigned long arg) > +{ > + > + unsigned int data_len = _IOC_SIZE(cmd); > + char *data_ptr = NULL; > + int ret = 0; > + > + data_ptr = devm_kzalloc(aw_dev->dev, data_len, GFP_KERNEL); > + if (!data_ptr) > + return -ENOMEM; > + if (copy_from_user(data_ptr, (void __user *)arg, data_len)) { > + ret = -EFAULT; > + goto exit; > + } > + > + switch (cmd) { > + case AW_IOCTL_SET_CALI_RE: { > + aw_cali_store_cali_re(aw_dev, *((int32_t *)data_ptr)); > + } break; > + default:{ > + aw_dev_err(aw_dev->dev, "unsupported cmd %d", cmd); > + ret = -EINVAL; > + } break; > + } > + > +exit: > + devm_kfree(aw_dev->dev, data_ptr); > + data_ptr = NULL; > + return ret; > +} > + > +static int aw_cali_misc_ops_read(struct aw_device *aw_dev, > + unsigned int cmd, unsigned long arg) > +{ > + > + int16_t data_len = _IOC_SIZE(cmd); > + char *data_ptr = NULL; > + int32_t *data_32_ptr = NULL; > + int ret = 0; > + > + data_ptr = devm_kzalloc(aw_dev->dev, data_len, GFP_KERNEL); > + if (!data_ptr) > + return -ENOMEM; > + > + data_32_ptr = (int32_t *)data_ptr; > + switch (cmd) { > + case AW_IOCTL_GET_RE: { > + ret = aw_cali_svc_dev_cali_re(aw_dev, CALI_OPS_HMUTE); > + if (ret < 0) > + goto exit; > + > + ret = aw_cali_svc_get_dev_cali_val(aw_dev, GET_RE_TYPE, data_32_ptr); > + } break; > + case AW_IOCTL_GET_CALI_F0: { > + ret = aw_cali_svc_dev_cali_f0_q(aw_dev, CALI_OPS_NOISE); > + if (ret < 0) > + goto exit; > + > + ret = aw_cali_svc_get_dev_cali_val(aw_dev, GET_F0_TYPE, data_32_ptr); > + } break; > + case AW_IOCTL_GET_F0: { > + ret = aw_cali_svc_get_dev_f0(aw_dev, data_32_ptr); > + } break; > + case AW_IOCTL_GET_TE: { > + ret = aw883xx_cali_svc_get_dev_te(&aw_dev->cali_desc, data_32_ptr); > + } break; > + case AW_IOCTL_GET_REAL_R0: { > + ret = aw_cali_svc_get_dev_realtime_re(aw_dev, data_32_ptr); > + } break; > + case AW_IOCTL_GET_RE_RANGE: { > + ret = aw_cali_svc_get_dev_re_range(aw_dev, data_32_ptr); > + } break; > + default:{ > + aw_dev_err(aw_dev->dev, "unsupported cmd %d", cmd); > + ret = -EINVAL; > + } break; > + } > + > +exit: > + if (copy_to_user((void __user *)arg, > + data_ptr, data_len)) { > + ret = -EFAULT; > + } > + > + devm_kfree(aw_dev->dev, data_ptr); > + data_ptr = NULL; > + return ret; > +} > + > +static int aw_cali_misc_ops(struct aw_device *aw_dev, > + unsigned int cmd, unsigned long arg) > +{ > + int ret = 0; > + > + switch (cmd) { > + case AW_IOCTL_SET_CALI_RE: > + return aw_cali_misc_ops_write(aw_dev, cmd, arg); > + case AW_IOCTL_GET_F0: > + case AW_IOCTL_GET_CALI_F0: > + case AW_IOCTL_GET_RE: > + case AW_IOCTL_GET_REAL_R0: > + case AW_IOCTL_GET_TE: > + case AW_IOCTL_GET_RE_RANGE: > + return aw_cali_misc_ops_read(aw_dev, cmd, arg); > + default: > + aw_dev_err(aw_dev->dev, "unsupported cmd %d", cmd); > + ret = -EINVAL; > + break; > + } > + > + return ret; > +} > + > +static long aw_cali_misc_unlocked_ioctl(struct file *file, > + unsigned int cmd, unsigned long arg) > +{ > + int ret = 0; > + struct aw_device *aw_dev = NULL; > + > + if (((_IOC_TYPE(cmd)) != (AW_IOCTL_MAGIC))) { > + aw_pr_err(" cmd magic err"); > + return -EINVAL; > + } > + aw_dev = (struct aw_device *)file->private_data; > + ret = aw_cali_misc_ops(aw_dev, cmd, arg); > + if (ret < 0) > + return -EINVAL; > + return 0; > +} > + > +#ifdef CONFIG_COMPAT > +static long aw_cali_misc_compat_ioctl(struct file *file, > + unsigned int cmd, unsigned long arg) > +{ > + int ret = 0; > + struct aw_device *aw_dev = NULL; > + > + if (((_IOC_TYPE(cmd)) != (AW_IOCTL_MAGIC))) { > + aw_pr_err("cmd magic err"); > + return -EINVAL; > + } > + aw_dev = (struct aw_device *)file->private_data; > + ret = aw_cali_misc_ops(aw_dev, cmd, arg); > + if (ret < 0) > + return -EINVAL; > + > + > + return 0; > +} > +#endif > + > +static ssize_t aw_cali_misc_read(struct file *filp, char __user *buf, size_t size, loff_t *pos) > +{ > + int len = 0; > + int i, ret; > + struct aw_device *aw_dev = (struct aw_device *)filp->private_data; > + char local_buf[512] = { 0 }; > + uint32_t temp_data[AW_DEV_CH_MAX] = { 0 }; > + uint32_t re_value[AW_DEV_RE_RANGE] = { 0 }; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + if (*pos) { > + *pos = 0; > + return 0; > + } > + > + switch (g_msic_wr_flag) { > + case CALI_STR_SHOW_RE: { > + ret = aw_cali_svc_get_devs_cali_val(aw_dev, GET_RE_TYPE, temp_data, AW_DEV_CH_MAX); > + if (ret > 0) { > + for (i = 0; i < ret; i++) > + len += snprintf(local_buf+len, > + sizeof(local_buf)-len, > + "dev[%d]:%u ", > + i, temp_data[i]); > + > + len += snprintf(local_buf+len, sizeof(local_buf)-len, "\n"); > + } else { > + aw_dev_err(aw_dev->dev, "get re failed"); > + return -EINVAL; > + } > + } break; > + case CALI_STR_SHOW_R0: { > + ret = aw_cali_svc_get_devs_r0(aw_dev, temp_data, AW_DEV_CH_MAX); > + if (ret > 0) { > + for (i = 0; i < ret; i++) > + len += snprintf(local_buf+len, sizeof(local_buf)-len, > + "dev[%d]:%d ", i, temp_data[i]); > + len += snprintf(local_buf+len, sizeof(local_buf)-len, "\n"); > + } else { > + aw_dev_err(aw_dev->dev, "get r0 failed"); > + return -EINVAL; > + } > + } break; > + case CALI_STR_SHOW_CALI_F0: { > + ret = aw_cali_svc_get_devs_cali_val(aw_dev, GET_F0_TYPE, temp_data, AW_DEV_CH_MAX); > + if (ret > 0) { > + for (i = 0; i < ret; i++) > + len += snprintf(local_buf+len, sizeof(local_buf)-len, > + "dev[%d]:%d ", i, temp_data[i]); > + > + len += snprintf(local_buf+len, sizeof(local_buf)-len, "\n"); > + } else { > + aw_dev_err(aw_dev->dev, "get cali f0 failed"); > + return -EINVAL; > + } > + } break; > + case CALI_STR_SHOW_F0: { > + ret = aw_cali_svc_get_devs_f0(aw_dev, temp_data, AW_DEV_CH_MAX); > + if (ret > 0) { > + for (i = 0; i < ret; i++) > + len += snprintf(local_buf+len, sizeof(local_buf)-len, > + "dev[%d]:%d ", i, temp_data[i]); > + > + len += snprintf(local_buf+len, sizeof(local_buf) - len, "\n"); > + } else { > + aw_dev_err(aw_dev->dev, "get f0 failed"); > + return -EINVAL; > + } > + } break; > + case CALI_STR_SHOW_TE: { > + ret = aw_cali_svc_get_devs_te(aw_dev, temp_data, AW_DEV_CH_MAX); > + if (ret > 0) { > + for (i = 0; i < ret; i++) > + len += snprintf(local_buf+len, sizeof(local_buf)-len, > + "dev[%d]:%d ", i, temp_data[i]); > + len += snprintf(local_buf+len, sizeof(local_buf)-len, "\n"); > + } else { > + aw_dev_err(aw_dev->dev, "get te failed"); > + return -EINVAL; > + } > + } break; > + case CALI_STR_VER: { > + if (aw_dev->ops.aw_get_version) { > + len = aw_dev->ops.aw_get_version(local_buf, sizeof(local_buf)); > + if (len < 0) { > + aw_dev_err(aw_dev->dev, "get version failed"); > + return -EINVAL; > + } > + len += snprintf(local_buf+len, sizeof(local_buf) - len, "\n"); > + } else { > + aw_dev_err(aw_dev->dev, "get version is NULL"); > + return -EINVAL; > + } > + } break; > + case CALI_STR_SHOW_RE_RANGE: { > + ret = aw_cali_svc_get_devs_re_range(aw_dev, re_value, AW_DEV_CH_MAX); > + if (ret > 0) { > + for (i = 0; i < ret; i++) { > + len += snprintf(local_buf+len, sizeof(local_buf)-len, > + "dev[%d]:re_min:%d re_max:%d\n", > + i, re_value[RE_MIN_FLAG + i * RE_RANGE_NUM], > + re_value[RE_MAX_FLAG + i * RE_RANGE_NUM]); > + } > + } else { > + aw_dev_err(aw_dev->dev, "get re range failed"); > + return -EINVAL; > + } > + } break; > + default: { > + if (g_msic_wr_flag == CALI_STR_NONE) { > + aw_dev_info(aw_dev->dev, "please write cmd first"); > + } else { > + aw_dev_err(aw_dev->dev, "unsupported flag [%d]", g_msic_wr_flag); > + g_msic_wr_flag = CALI_STR_NONE; > + return -EINVAL; > + } > + return -EINVAL; > + } break; > + } > + > + if (copy_to_user((void __user *)buf, local_buf, len)) { > + aw_dev_err(aw_dev->dev, "copy_to_user error"); > + g_msic_wr_flag = CALI_STR_NONE; > + return -EFAULT; > + } > + > + g_msic_wr_flag = CALI_STR_NONE; > + *pos += len; > + return len; > + > +} > + > +static int aw_cali_misc_switch_dev(struct file *filp, struct aw_device *aw_dev, char *cmd_buf) > +{ > + int dev_select_num; > + struct list_head *dev_list = NULL; > + struct list_head *pos = NULL; > + struct aw_device *local_dev = NULL; > + int ret; > + > + if (cmd_buf == NULL) { > + aw_dev_err(aw_dev->dev, "cmd_buf is NULL"); > + return -EINVAL; > + } > + > + /*get sel dev str*/ > + sscanf(cmd_buf, "dev_sel:dev[%d]", &dev_select_num); > + > + if (dev_select_num >= AW_DEV_CH_MAX) { > + aw_dev_err(aw_dev->dev, "unsupport str [%s]", cmd_buf); > + return -EINVAL; > + } > + > + /*get dev list*/ > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw_dev->dev, "get dev list failed"); > + return ret; > + } > + > + /*find sel dev*/ > + list_for_each(pos, dev_list) { > + local_dev = container_of(pos, struct aw_device, list_node); > + if (local_dev->channel == dev_select_num) { > + filp->private_data = (void *)local_dev; > + g_dev_select = dev_select_num; > + aw_dev_info(local_dev->dev, "switch to dev[%d]", dev_select_num); > + return 0; > + } > + } > + aw_dev_err(aw_dev->dev, " unsupport [%s]", cmd_buf); > + return -EINVAL; > +} > + > +static ssize_t aw_cali_misc_write(struct file *filp, > + const char __user *buf, > + size_t size, loff_t *pos) > +{ > + char *kernel_buf = NULL; > + struct aw_device *aw_dev = (struct aw_device *)filp->private_data; > + int ret = 0; > + > + aw_dev_info(aw_dev->dev, "enter, write size:%d", (int)size); > + kernel_buf = kzalloc(size + 1, GFP_KERNEL); > + if (kernel_buf == NULL) { > + aw_dev_err(aw_dev->dev, "kzalloc failed !"); > + return -ENOMEM; > + } > + > + if (copy_from_user(kernel_buf, > + (void __user *)buf, > + size)) { > + ret = -EFAULT; > + goto exit; > + } > + > + ret = aw_cali_svc_get_cmd_form_str(aw_dev, kernel_buf); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "upported cmd [%s]!", kernel_buf); > + ret = -EINVAL; > + goto exit; > + } > + > + switch (ret) { > + case CALI_STR_CALI_RE_F0: { > + ret = aw_cali_svc_cali_cmd(aw_dev, AW_CALI_CMD_RE_F0, > + is_single_cali, CALI_OPS_HMUTE|CALI_OPS_NOISE); > + } break; > + case CALI_STR_CALI_RE: { > + ret = aw_cali_svc_cali_cmd(aw_dev, AW_CALI_CMD_RE, > + is_single_cali, CALI_OPS_HMUTE); > + } break; > + case CALI_STR_CALI_F0: { > + ret = aw_cali_svc_cali_cmd(aw_dev, AW_CALI_CMD_F0, > + is_single_cali, CALI_OPS_HMUTE|CALI_OPS_NOISE); > + } break; > + case CALI_STR_SET_RE: { > + /*skip store_re*/ > + kernel_buf[size] = '\0'; > + ret = aw_cali_svc_set_devs_re_str(aw_dev, > + kernel_buf + strlen(cali_str[CALI_STR_SET_RE]) + 1); > + } break; > + case CALI_STR_DEV_SEL: { > + ret = aw_cali_misc_switch_dev(filp, aw_dev, kernel_buf); > + } break; > + case CALI_STR_SHOW_RE: /*show cali_re*/ > + case CALI_STR_SHOW_R0: /*show real r0*/ > + case CALI_STR_SHOW_CALI_F0: /*GET DEV CALI_F0*/ > + case CALI_STR_SHOW_F0: /*SHOW REAL F0*/ > + case CALI_STR_SHOW_TE: > + case CALI_STR_VER: > + case CALI_STR_SHOW_RE_RANGE: { > + g_msic_wr_flag = ret; > + ret = 0; > + } break; > + default: { > + aw_dev_err(aw_dev->dev, "unsupported [%s]!", kernel_buf); > + ret = -EINVAL; > + } break; > + }; > + > +exit: > + aw_dev_dbg(aw_dev->dev, "cmd [%s]!", kernel_buf); > + kfree(kernel_buf); > + kernel_buf = NULL; > + > + if (ret < 0) > + return -EINVAL; > + else > + return size; > +} > + > +static const struct file_operations aw_cali_misc_fops = { > + .owner = THIS_MODULE, > + .open = aw_cali_misc_open, > + .read = aw_cali_misc_read, > + .write = aw_cali_misc_write, > + .release = aw_cali_misc_release, > + .unlocked_ioctl = aw_cali_misc_unlocked_ioctl, > +#ifdef CONFIG_COMPAT > + .compat_ioctl = aw_cali_misc_compat_ioctl, > +#endif > +}; > + > +static struct miscdevice misc_cali = { > + .name = "aw_smartpa", > + .minor = MISC_DYNAMIC_MINOR, > + .fops = &aw_cali_misc_fops, > +}; > + > +static int aw_cali_misc_init(struct aw_device *aw_dev) > +{ > + int ret; > + > + mutex_lock(&g_cali_lock); > + if (g_misc_dev == NULL) { > + ret = misc_register(&misc_cali); > + if (ret) { > + aw_dev_err(aw_dev->dev, "misc register fail: %d\n", ret); > + mutex_unlock(&g_cali_lock); > + return -EINVAL; > + } > + g_misc_dev = &misc_cali; > + aw_dev_dbg(aw_dev->dev, "misc register success"); > + } else { > + aw_dev_dbg(aw_dev->dev, "misc already register"); > + } > + mutex_unlock(&g_cali_lock); > + > + return 0; > +} > + > +static void aw_cali_misc_deinit(struct aw_device *aw_dev) > +{ > + mutex_lock(&g_cali_lock); > + if (g_misc_dev) { > + misc_deregister(g_misc_dev); > + g_misc_dev = NULL; > + } > + mutex_unlock(&g_cali_lock); > + aw_dev_dbg(aw_dev->dev, " misc unregister done"); > +} > +/*****************************misc cali******************************************************/ > + > +static void aw_cali_parse_dt(struct aw_device *aw_dev) > +{ > + struct device_node *np = aw_dev->dev->of_node; > + int ret = -1; > + uint32_t cali_check = CALI_CHECK_DISABLE; > + struct aw_cali_desc *desc = &aw_dev->cali_desc; > + > + ret = of_property_read_u32(np, "aw-cali-check", &cali_check); > + if (ret < 0) { > + aw_dev_info(aw_dev->dev, " cali-check get failed ,default turn off"); > + cali_check = CALI_CHECK_DISABLE; > + } > + > + desc->cali_check_st = cali_check; > + aw_dev_info(aw_dev->dev, "cali check :%s", > + (desc->cali_check_st) ? "enable" : "disable"); > +} > + > +void aw883xx_cali_init(struct aw_cali_desc *cali_desc) > +{ > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + > + memset(cali_desc, 0, sizeof(struct aw_cali_desc)); > + > + aw_cali_parse_dt(aw_dev); > + > + aw_cali_attr_init(aw_dev); > + > + aw_cali_class_attr_init(aw_dev); > + > + aw_cali_misc_init(aw_dev); > + > + cali_desc->cali_result = CALI_RESULT_NONE; > +} > + > +void aw883xx_cali_deinit(struct aw_cali_desc *cali_desc) > +{ > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + > + aw_cali_attr_deinit(aw_dev); > + > + aw_cali_class_attr_deinit(aw_dev); > + > + aw_cali_misc_deinit(aw_dev); > +} > diff --git a/sound/soc/codecs/aw883xx/aw883xx_calib.h b/sound/soc/codecs/aw883xx/aw883xx_calib.h > new file mode 100644 > index 0000000..c20c319 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_calib.h > @@ -0,0 +1,154 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_CALIBRATION_H__ > +#define __AW883XX_CALIBRATION_H__ > + > +/*#define AW_CALI_STORE_EXAMPLE*/ > + > +#define AW_CALI_STORE_EXAMPLE > +#define AW_ERRO_CALI_RE_VALUE (0) > +#define AW_ERRO_CALI_F0_VALUE (2600) > + > +#define AW_CALI_RE_DEFAULT_TIMER (3000) > +#define MSGS_SIZE (512) > +#define RESERVED_SIZE (252) > + > + > +#define AW_CALI_ALL_DEV (0xFFFFFFFF) > + > +#define AW_CALI_RE_MAX (15000) > +#define AW_CALI_RE_MIN (4000) > +#define AW_CALI_CFG_NUM (4) > +#define AW_CALI_F0_DATA_NUM (4) > +#define AW_CALI_READ_CNT_MAX (8) > +#define AW_CALI_DATA_SUM_RM (2) > +#define AW_DSP_RE_TO_SHOW_RE(re, shift) (((re) * (1000)) >> (shift)) > +#define AW_SHOW_RE_TO_DSP_RE(re, shift) (((re) << shift) / (1000)) > +#define AW_CALI_F0_TIME (5 * 1000) > +#define F0_READ_CNT_MAX (5) > +#define AW_FS_CFG_MAX (11) > +#define AW_DEV_CH_MAX (16) > +#define AW_DEV_RE_RANGE (RE_RANGE_NUM * AW_DEV_CH_MAX) > +#define AW_TE_CACL_VALUE(te, coil_alpha) ((int32_t)(((int32_t)te << 18) / (coil_alpha))) > +#define AW_RE_REALTIME_VALUE(re_cacl, te_cacl) \ > + ((re_cacl) + (int32_t)((int64_t)((te_cacl) * (re_cacl)) >> 14)) > + > +enum { > + CALI_CHECK_DISABLE = 0, > + CALI_CHECK_ENABLE = 1, > +}; > + > +enum { > + CALI_RESULT_NONE = 0, > + CALI_RESULT_NORMAL = 1, > + CALI_RESULT_ERROR = -1, > +}; > + > +enum { > + CALI_OPS_HMUTE = 0X0001, > + CALI_OPS_NOISE = 0X0002, > +}; > + > +enum { > + CALI_TYPE_RE = 0, > + CALI_TYPE_F0, > +}; > + > +enum{ > + AW_CALI_MODE_NONE = 0, > + AW_CALI_MODE_ATTR, > + AW_CALI_MODE_CLASS, > + AW_CALI_MODE_MISC, > + AW_CALI_MODE_MAX > +}; > + > +enum { > + GET_RE_TYPE = 0, > + GET_F0_TYPE, > + GET_Q_TYPE, > +}; > + > +enum { > + AW_CALI_CMD_RE = 0, > + AW_CALI_CMD_F0, > + AW_CALI_CMD_RE_F0, > + AW_CALI_CMD_F0_Q, > + AW_CALI_CMD_RE_F0_Q, > +}; > + > +enum { > + CALI_STR_NONE = 0, > + CALI_STR_CALI_RE_F0, > + CALI_STR_CALI_RE, > + CALI_STR_CALI_F0, > + CALI_STR_SET_RE, > + CALI_STR_SHOW_RE, /*show cali_re*/ > + CALI_STR_SHOW_R0, /*show real r0*/ > + CALI_STR_SHOW_CALI_F0, /*GET DEV CALI_F0*/ > + CALI_STR_SHOW_F0, /*SHOW REAL F0*/ > + CALI_STR_SHOW_TE, > + CALI_STR_DEV_SEL, /*switch device*/ > + CALI_STR_VER, > + CALI_STR_SHOW_RE_RANGE, > + CALI_STR_MAX, > +}; > + > +enum { > + RE_MIN_FLAG = 0, > + RE_MAX_FLAG = 1, > + RE_RANGE_NUM = 2, > +}; > + > +struct re_data { > + uint32_t re_range[2]; > +}; > + > + > +#define AW_IOCTL_MAGIC 'a' > + > +#define AW_IOCTL_GET_F0 _IOWR(AW_IOCTL_MAGIC, 5, int32_t) > +#define AW_IOCTL_SET_CALI_RE _IOWR(AW_IOCTL_MAGIC, 6, int32_t) > + > +#define AW_IOCTL_GET_RE _IOWR(AW_IOCTL_MAGIC, 17, int32_t) > +#define AW_IOCTL_GET_CALI_F0 _IOWR(AW_IOCTL_MAGIC, 18, int32_t) > +#define AW_IOCTL_GET_REAL_R0 _IOWR(AW_IOCTL_MAGIC, 19, int32_t) > +#define AW_IOCTL_GET_TE _IOWR(AW_IOCTL_MAGIC, 20, int32_t) > +#define AW_IOCTL_GET_RE_RANGE _IOWR(AW_IOCTL_MAGIC, 21, struct re_data) > + > +struct cali_cfg { > + uint32_t data[AW_CALI_CFG_NUM]; > +}; > + > + > +struct aw_cali_desc { > + bool status; > + struct cali_cfg cali_cfg; > + uint16_t store_vol; > + uint32_t cali_re; /*cali value*/ > + uint32_t f0; > + uint32_t q; > + uint32_t ra; > + int8_t cali_result; > + uint8_t cali_check_st; > +}; > + > +void aw883xx_cali_init(struct aw_cali_desc *cali_desc); > +void aw883xx_cali_deinit(struct aw_cali_desc *cali_desc); > +bool aw883xx_cali_svc_get_cali_status(struct aw_cali_desc *cali_desc); > +int aw883xx_cali_svc_set_cali_re_to_dsp(struct aw_cali_desc *cali_desc); > +int aw883xx_cali_svc_get_ra(struct aw_cali_desc *cali_desc); > +int aw883xx_cali_svc_get_dev_te(struct aw_cali_desc *cali_desc, int32_t *te); > +int aw883xx_cali_get_cali_re(struct aw_cali_desc *cali_desc); > +int aw883xx_cali_read_cali_re_from_dsp(struct aw_cali_desc *cali_desc, uint32_t *re); > +bool aw883xx_cali_check_result(struct aw_cali_desc *cali_desc); > + > +#endif > + > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_data_type.h b/sound/soc/codecs/aw883xx/aw883xx_data_type.h > new file mode 100644 > index 0000000..b21f938 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_data_type.h > @@ -0,0 +1,157 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_DATA_TYPE_H__ > +#define __AW883XX_DATA_TYPE_H__ > + > +#define AW_NAME_BUF_MAX (50) > + > + > +/* > + * aw profile > + */ > +#define PROJECT_NAME_MAX (24) > +#define CUSTOMER_NAME_MAX (16) > +#define CFG_VERSION_MAX (4) > +#define DEV_NAME_MAX (16) > +#define PROFILE_STR_MAX (32) > + > +#define ACF_FILE_ID (0xa15f908) > + > +struct aw_msg_hdr { > + int32_t type; > + int32_t opcode_id; > + int32_t version; > + int32_t reseriver[3]; > +}; > + > +enum aw_cfg_hdr_version { > + AW_CFG_HDR_VER_0_0_0_1 = 0x00000001, > + AW_CFG_HDR_VER_1_0_0_0 = 0x01000000, > +}; > + > +enum aw_cfg_dde_type { > + AW_DEV_NONE_TYPE_ID = 0xFFFFFFFF, > + AW_DEV_TYPE_ID = 0x00000000, > + AW_SKT_TYPE_ID = 0x00000001, > + AW_DEV_DEFAULT_TYPE_ID = 0x00000002, > +}; > + > +enum aw_sec_type { > + ACF_SEC_TYPE_REG = 0, > + ACF_SEC_TYPE_DSP, > + ACF_SEC_TYPE_DSP_CFG, > + ACF_SEC_TYPE_DSP_FW, > + ACF_SEC_TYPE_HDR_REG, > + ACF_SEC_TYPE_HDR_DSP_CFG, > + ACF_SEC_TYPE_HDR_DSP_FW, > + ACF_SEC_TYPE_MUTLBIN, > + ACF_SEC_TYPE_SKT_PROJECT, > + ACF_SEC_TYPE_DSP_PROJECT, > + ACF_SEC_TYPE_MONITOR, > + ACF_SEC_TYPE_MAX, > +}; > + > +enum profile_data_type { > + AW_DATA_TYPE_REG = 0, > + AW_DATA_TYPE_DSP_CFG, > + AW_DATA_TYPE_DSP_FW, > + AW_DATA_TYPE_MAX, > +}; > + > +enum aw_prof_type { > + AW_PROFILE_MUSIC = 0, > + AW_PROFILE_VOICE, > + AW_PROFILE_VOIP, > + AW_PROFILE_RINGTONE, > + AW_PROFILE_RINGTONE_HS, > + AW_PROFILE_LOWPOWER, > + AW_PROFILE_BYPASS, > + AW_PROFILE_MMI, > + AW_PROFILE_FM, > + AW_PROFILE_NOTIFICATION, > + AW_PROFILE_RECEIVER, > + AW_PROFILE_MAX, > +}; > + > +enum aw_profile_status { > + AW_PROFILE_WAIT = 0, > + AW_PROFILE_OK, > +}; > + > +struct aw_cfg_hdr { > + uint32_t a_id; /*acf file ID 0xa15f908*/ > + char a_project[PROJECT_NAME_MAX]; /*project name*/ > + char a_custom[CUSTOMER_NAME_MAX]; /*custom name :huawei xiaomi vivo oppo*/ > + char a_version[CFG_VERSION_MAX]; /*author update version*/ > + uint32_t a_author_id; /*author id*/ > + uint32_t a_ddt_size; /*sub section table entry size*/ > + uint32_t a_ddt_num; /*sub section table entry num*/ > + uint32_t a_hdr_offset; /*sub section table offset in file*/ > + uint32_t a_hdr_version; /*sub section table version*/ > + uint32_t reserve[3]; > +}; > + > +struct aw_cfg_dde { > + uint32_t type; /*DDE type id*/ > + char dev_name[DEV_NAME_MAX]; > + uint16_t dev_index; /*dev id*/ > + uint16_t dev_bus; /*dev bus id*/ > + uint16_t dev_addr; /*dev addr id*/ > + uint16_t dev_profile; /*dev profile id*/ > + uint32_t data_type; /*data type id*/ > + uint32_t data_size; > + uint32_t data_offset; > + uint32_t data_crc; > + uint32_t reserve[5]; > +}; > + > +struct aw_cfg_dde_v_1_0_0_0 { > + uint32_t type; /*DDE type id*/ > + char dev_name[DEV_NAME_MAX]; > + uint16_t dev_index; /*dev id*/ > + uint16_t dev_bus; /*dev bus id*/ > + uint16_t dev_addr; /*dev addr id*/ > + uint16_t dev_profile; /*dev profile id*/ > + uint32_t data_type; /*data type id*/ > + uint32_t data_size; > + uint32_t data_offset; > + uint32_t data_crc; > + char dev_profile_str[PROFILE_STR_MAX]; > + uint32_t chip_id; > + uint32_t reserve[4]; > +}; > + > +struct aw_sec_data_desc { > + uint32_t len; > + unsigned char *data; > +}; > + > +struct aw_prof_desc { > + uint32_t id; > + uint32_t prof_st; > + char *prf_str; > + uint32_t fw_ver; > + struct aw_sec_data_desc sec_desc[AW_DATA_TYPE_MAX]; > +}; > + > +struct aw_all_prof_info { > + struct aw_prof_desc prof_desc[AW_PROFILE_MAX]; > +}; > + > +struct aw_prof_info { > + int count; > + int prof_type; > + char **prof_name_list; > + struct aw_prof_desc *prof_desc; > +}; > + > + > +#endif > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_device.c b/sound/soc/codecs/aw883xx/aw883xx_device.c > new file mode 100644 > index 0000000..681d9e5 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_device.c > @@ -0,0 +1,1734 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#include <linux/module.h> > +#include <linux/i2c.h> > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/pcm_params.h> > +#include <sound/soc.h> > +#include <linux/of_gpio.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/firmware.h> > +#include <linux/debugfs.h> > +#include <linux/version.h> > +#include <linux/workqueue.h> > +#include <linux/syscalls.h> > +#include <sound/control.h> > +#include <linux/uaccess.h> > + > +#include "aw883xx_data_type.h" > +#include "aw883xx_log.h" > +#include "aw883xx_device.h" > +#include "aw883xx_bin_parse.h" > +#include "aw883xx_calib.h" > + > +#define AW_DEV_SYSST_CHECK_MAX (10) > + > +enum { > + AW_EXT_DSP_WRITE_NONE = 0, > + AW_EXT_DSP_WRITE, > +}; > + > +static unsigned int g_fade_in_time = AW_1000_US / 10; > +static unsigned int g_fade_out_time = AW_1000_US >> 1; > +static LIST_HEAD(g_dev_list); > +static DEFINE_MUTEX(g_dev_lock); > + > +static int aw_dev_reg_dump(struct aw_device *aw_dev) > +{ > + int reg_num = aw_dev->ops.aw_get_reg_num(); > + uint8_t i = 0; > + uint16_t reg_val = 0; > + > + for (i = 0; i < reg_num; i++) { > + if (aw_dev->ops.aw_check_rd_access(i)) { > + aw_dev->ops.aw_reg_read(aw_dev, i, &reg_val); > + aw_dev_info(aw_dev->dev, "read: reg = 0x%02x, val = 0x%04x", > + i, reg_val); > + } > + } > + > + return 0; > +} > + > +int aw883xx_dev_set_volume(struct aw_device *aw_dev, uint16_t set_vol) > +{ > + uint16_t hw_vol = 0; > + int ret = -1; > + struct aw_volume_desc *vol_desc = &aw_dev->volume_desc; > + > + hw_vol = set_vol + vol_desc->init_volume; > + > + ret = aw_dev->ops.aw_set_hw_volume(aw_dev, hw_vol); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "set volume failed"); > + return ret; > + } > + > + return 0; > +} > + > +int aw883xx_dev_get_volume(struct aw_device *aw_dev, uint16_t *get_vol) > +{ > + int ret = -1; > + uint16_t hw_vol = 0; > + struct aw_volume_desc *vol_desc = &aw_dev->volume_desc; > + > + ret = aw_dev->ops.aw_get_hw_volume(aw_dev, &hw_vol); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read volume failed"); > + return ret; > + } > + > + *get_vol = hw_vol - vol_desc->init_volume; > + > + return 0; > +} > + > +static void aw_dev_fade_in(struct aw_device *aw_dev) > +{ > + int i = 0; > + struct aw_volume_desc *desc = &aw_dev->volume_desc; > + int fade_step = aw_dev->fade_step; > + uint16_t fade_in_vol = desc->ctl_volume; > + > + if (!aw_dev->fade_en) > + return; > + > + if (fade_step == 0 || g_fade_in_time == 0) { > + aw883xx_dev_set_volume(aw_dev, fade_in_vol); > + return; > + } > + /*volume up*/ > + for (i = desc->mute_volume; i >= fade_in_vol; i -= fade_step) { > + aw883xx_dev_set_volume(aw_dev, i); > + usleep_range(g_fade_in_time, g_fade_in_time + 10); > + } > + if (i != fade_in_vol) > + aw883xx_dev_set_volume(aw_dev, fade_in_vol); > + > +} > + > +static void aw_dev_fade_out(struct aw_device *aw_dev) > +{ > + int i = 0; > + struct aw_volume_desc *desc = &aw_dev->volume_desc; > + int fade_step = aw_dev->fade_step; > + > + if (!aw_dev->fade_en) > + return; > + > + if (fade_step == 0 || g_fade_out_time == 0) { > + aw883xx_dev_set_volume(aw_dev, desc->mute_volume); > + return; > + } > + > + for (i = desc->ctl_volume; i <= desc->mute_volume; i += fade_step) { > + aw883xx_dev_set_volume(aw_dev, i); > + usleep_range(g_fade_out_time, g_fade_out_time + 10); > + } > + if (i != desc->mute_volume) { > + aw883xx_dev_set_volume(aw_dev, desc->mute_volume); > + usleep_range(g_fade_out_time, g_fade_out_time + 10); > + } > +} > + > +int aw883xx_dev_get_fade_vol_step(struct aw_device *aw_dev) > +{ > + return aw_dev->fade_step; > +} > + > +void aw883xx_dev_set_fade_vol_step(struct aw_device *aw_dev, unsigned int step) > +{ > + aw_dev->fade_step = step; > +} > + > +void aw883xx_dev_get_fade_time(unsigned int *time, bool fade_in) > +{ > + if (fade_in) > + *time = g_fade_in_time; > + else > + *time = g_fade_out_time; > +} > + > +void aw883xx_dev_set_fade_time(unsigned int time, bool fade_in) > +{ > + if (fade_in) > + g_fade_in_time = time; > + else > + g_fade_out_time = time; > +} > + > +static uint64_t aw_dev_dsp_crc32_reflect(uint64_t ref, uint8_t ch) > +{ > + int i; > + uint64_t value = 0; > + > + for (i = 1; i < (ch + 1); i++) { > + if (ref & 1) > + value |= 1 << (ch - i); > + > + ref >>= 1; > + } > + > + return value; > +} > + > +static uint32_t aw_dev_calc_dsp_cfg_crc32(uint8_t *buf, uint32_t len) > +{ > + uint8_t i; > + uint32_t crc = 0xffffffff; > + > + while (len--) { > + for (i = 1; i != 0; i <<= 1) { > + if ((crc & 0x80000000) != 0) { > + crc <<= 1; > + crc ^= 0x1EDC6F41; > + } else { > + crc <<= 1; > + } > + > + if ((*buf & i) != 0) > + crc ^= 0x1EDC6F41; > + } > + buf++; > + } > + > + return (aw_dev_dsp_crc32_reflect(crc, 32)^0xffffffff); > +} > + > +static int aw_dev_set_dsp_crc32(struct aw_device *aw_dev) > +{ > + uint32_t crc_value = 0; > + uint32_t crc_data_len = 0; > + int ret = -1; > + struct aw_sec_data_desc *crc_dsp_cfg = &aw_dev->crc_dsp_cfg; > + struct aw_dsp_crc_desc *desc = &aw_dev->dsp_crc_desc; > + > + /*get crc data len*/ > + crc_data_len = (desc->dsp_reg - aw_dev->dsp_mem_desc.dsp_cfg_base_addr) * 2; > + if (crc_data_len > crc_dsp_cfg->len) { > + aw_dev_err(aw_dev->dev, "crc data len :%d > cfg_data len:%d", > + crc_data_len, crc_dsp_cfg->len); > + return -EINVAL; > + } > + > + if (crc_data_len % 4 != 0) { > + aw_dev_err(aw_dev->dev, "The crc data len :%d unsupport", crc_data_len); > + return -EINVAL; > + } > + > + crc_value = aw_dev_calc_dsp_cfg_crc32(crc_dsp_cfg->data, crc_data_len); > + > + aw_dev_info(aw_dev->dev, "crc_value:0x%x", crc_value); > + ret = aw_dev->ops.aw_dsp_write(aw_dev, desc->dsp_reg, crc_value, > + desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "set dsp crc value failed"); > + return ret; > + } > + > + return 0; > +} > + > +static int aw_dev_dsp_crc_check_enable(struct aw_device *aw_dev, bool flag) > +{ > + struct aw_dsp_crc_desc *dsp_crc_desc = &aw_dev->dsp_crc_desc; > + int ret; > + > + aw_dev_info(aw_dev->dev, "enter,flag:%d", flag); > + if (flag) { > + ret = aw_dev->ops.aw_reg_write_bits(aw_dev, dsp_crc_desc->ctl_reg, > + dsp_crc_desc->ctl_mask, dsp_crc_desc->ctl_enable); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "enable dsp crc failed"); > + return ret; > + } > + } else { > + ret = aw_dev->ops.aw_reg_write_bits(aw_dev, dsp_crc_desc->ctl_reg, > + dsp_crc_desc->ctl_mask, dsp_crc_desc->ctl_disable); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "close dsp crc failed"); > + return ret; > + } > + } > + > + return 0; > +} > + > + > +static int aw_dev_dsp_st_check(struct aw_device *aw_dev) > +{ > + struct aw_sysst_desc *desc = &aw_dev->sysst_desc; > + int ret = -1; > + uint16_t reg_val = 0; > + int i; > + > + for (i = 0; i < AW_DSP_ST_CHECK_MAX; i++) { > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read reg0x%x failed", desc->reg); > + continue; > + } > + > + if ((reg_val & (~desc->dsp_mask)) != desc->dsp_check) { > + aw_dev_err(aw_dev->dev, "check dsp st fail,reg_val:0x%04x", reg_val); > + ret = -EINVAL; > + continue; > + } else { > + aw_dev_info(aw_dev->dev, "dsp st check ok, reg_val:0x%04x", reg_val); > + return 0; > + } > + } > + > + return ret; > +} > + > +static int aw_dev_dsp_crc32_check(struct aw_device *aw_dev) > +{ > + int ret; > + > + if (aw_dev->dsp_cfg == AW_DEV_DSP_BYPASS) { > + aw_dev_info(aw_dev->dev, "dsp bypass"); > + return 0; > + } > + > + ret = aw_dev_set_dsp_crc32(aw_dev); > + if (ret < 0) { > + aw_dev_info(aw_dev->dev, "set dsp crc32 failed"); > + return ret; > + } > + > + aw_dev_dsp_crc_check_enable(aw_dev, true); > + > + /*dsp enable*/ > + aw883xx_dev_dsp_enable(aw_dev, true); > + usleep_range(AW_5000_US, AW_5000_US + 100); > + > + ret = aw_dev_dsp_st_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "check crc32 fail"); > + return ret; > + } > + > + aw_dev_dsp_crc_check_enable(aw_dev, false); > + aw_dev->dsp_crc_st = AW_DSP_CRC_OK; > + return 0; > +} > + > +static void aw_dev_pwd(struct aw_device *aw_dev, bool pwd) > +{ > + struct aw_pwd_desc *pwd_desc = &aw_dev->pwd_desc; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + if (pwd) { > + aw_dev->ops.aw_reg_write_bits(aw_dev, pwd_desc->reg, > + pwd_desc->mask, > + pwd_desc->enable); > + } else { > + aw_dev->ops.aw_reg_write_bits(aw_dev, pwd_desc->reg, > + pwd_desc->mask, > + pwd_desc->disable); > + } > + aw_dev_info(aw_dev->dev, "done"); > +} > + > +static void aw_dev_amppd(struct aw_device *aw_dev, bool amppd) > +{ > + struct aw_amppd_desc *amppd_desc = &aw_dev->amppd_desc; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + if (amppd) { > + aw_dev->ops.aw_reg_write_bits(aw_dev, amppd_desc->reg, > + amppd_desc->mask, > + amppd_desc->enable); > + } else { > + aw_dev->ops.aw_reg_write_bits(aw_dev, amppd_desc->reg, > + amppd_desc->mask, > + amppd_desc->disable); > + } > + aw_dev_info(aw_dev->dev, "done"); > +} > + > + > +void aw883xx_dev_mute(struct aw_device *aw_dev, bool mute) > +{ > + struct aw_mute_desc *mute_desc = &aw_dev->mute_desc; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + if (mute) { > + aw_dev_fade_out(aw_dev); > + aw_dev->ops.aw_reg_write_bits(aw_dev, mute_desc->reg, > + mute_desc->mask, mute_desc->enable); > + } else { > + aw_dev->ops.aw_reg_write_bits(aw_dev, mute_desc->reg, > + mute_desc->mask, mute_desc->disable); > + aw_dev_fade_in(aw_dev); > + } > + aw_dev_info(aw_dev->dev, "done"); > +} > + > +int aw883xx_dev_get_hmute(struct aw_device *aw_dev) > +{ > + uint16_t reg_val = 0; > + int ret; > + struct aw_mute_desc *desc = &aw_dev->mute_desc; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if (ret < 0) > + return ret; > + > + if (reg_val & (~desc->mask)) > + ret = 1; > + else > + ret = 0; > + > + return ret; > +} > + > +static int aw_dev_get_icalk(struct aw_device *aw_dev, int16_t *icalk) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + uint16_t reg_icalk = 0; > + struct aw_vcalb_desc *desc = &aw_dev->vcalb_desc; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->icalk_reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "reg read failed"); > + return ret; > + } > + > + reg_icalk = reg_val & (~desc->icalk_reg_mask); > + > + if (reg_icalk & (~desc->icalk_sign_mask)) > + reg_icalk = reg_icalk | desc->icalk_neg_mask; > + > + *icalk = (int16_t)reg_icalk; > + > + return 0; > +} > + > +static int aw_dev_get_vcalk(struct aw_device *aw_dev, int16_t *vcalk) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + uint16_t reg_vcalk = 0; > + struct aw_vcalb_desc *desc = &aw_dev->vcalb_desc; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->vcalk_reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "reg read failed"); > + return ret; > + } > + > + reg_val = reg_val >> desc->vcalk_shift; > + > + reg_vcalk = (uint16_t)reg_val & (~desc->vcalk_reg_mask); > + > + if (reg_vcalk & (~desc->vcalk_sign_mask)) > + reg_vcalk = reg_vcalk | desc->vcalk_neg_mask; > + > + *vcalk = (int16_t)reg_vcalk; > + > + return 0; > +} > + > +static int aw_dev_get_vcalk_dac(struct aw_device *aw_dev, int16_t *vcalk) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + uint16_t reg_vcalk = 0; > + struct aw_vcalb_desc *desc = &aw_dev->vcalb_desc; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->icalk_reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "reg read failed"); > + return ret; > + } > + > + reg_vcalk = reg_val >> desc->vcalk_dac_shift; > + > + if (reg_vcalk & desc->vcalk_dac_mask) > + reg_vcalk = reg_vcalk | desc->vcalk_dac_neg_mask; > + > + *vcalk = (int16_t)reg_vcalk; > + > + return 0; > +} > + > +int aw883xx_dev_modify_dsp_cfg(struct aw_device *aw_dev, > + unsigned int addr, uint32_t dsp_data, unsigned char data_type) > +{ > + uint32_t addr_offset = 0; > + int len = 0; > + uint8_t temp_data[4] = { 0 }; > + struct aw_sec_data_desc *crc_dsp_cfg = &aw_dev->crc_dsp_cfg; > + > + aw_dev_dbg(aw_dev->dev, "addr:0x%x, dsp_data:0x%x", addr, dsp_data); > + if (data_type == AW_DSP_16_DATA) { > + temp_data[0] = (uint8_t)(dsp_data & 0x00ff); > + temp_data[1] = (uint8_t)((dsp_data & 0xff00) >> 8); > + len = 2; > + } else if (data_type == AW_DSP_32_DATA) { > + temp_data[0] = (uint8_t)(dsp_data & 0x000000ff); > + temp_data[1] = (uint8_t)((dsp_data & 0x0000ff00) >> 8); > + temp_data[2] = (uint8_t)((dsp_data & 0x00ff0000) >> 16); > + temp_data[3] = (uint8_t)((dsp_data & 0xff000000) >> 24); > + len = 4; > + } else { > + aw_dev_err(aw_dev->dev, "data type[%d] unsupported", data_type); > + return -EINVAL; > + } > + > + addr_offset = (addr - aw_dev->dsp_mem_desc.dsp_cfg_base_addr) * 2; > + if (addr_offset > crc_dsp_cfg->len) { > + aw_dev_err(aw_dev->dev, "addr_offset[%d] > crc_dsp_cfg->len[%d]", > + addr_offset, crc_dsp_cfg->len); > + return -EINVAL; > + } > + > + memcpy(crc_dsp_cfg->data + addr_offset, temp_data, len); > + return 0; > +} > + > +static int aw_dev_vsense_select(struct aw_device *aw_dev, int *vsense_select) > +{ > + int ret = -1; > + struct aw_vcalb_desc *desc = &aw_dev->vcalb_desc; > + uint16_t vsense_reg_val; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->vcalb_vsense_reg, &vsense_reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read vsense_reg_val failed"); > + return ret; > + } > + aw_dev_dbg(aw_dev->dev, "vsense_reg = 0x%x", vsense_reg_val); > + > + if (vsense_reg_val & (~desc->vcalk_vdsel_mask)) { > + *vsense_select = AW_DEV_VDSEL_VSENSE; > + aw_dev_info(aw_dev->dev, "vsense outside"); > + return 0; > + } > + > + *vsense_select = AW_DEV_VDSEL_DAC; > + aw_dev_info(aw_dev->dev, "vsense inside"); > + return 0; > +} > + > +static int aw_dev_set_vcalb(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint32_t reg_val = 0; > + int vcalb; > + int icalk; > + int vcalk; > + int16_t icalk_val = 0; > + int16_t vcalk_val = 0; > + struct aw_vcalb_desc *desc = &aw_dev->vcalb_desc; > + uint32_t vcalb_adj; > + int vsense_select = -1; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, desc->vcalb_dsp_reg, &vcalb_adj, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read vcalb_adj failed"); > + return ret; > + } > + > + ret = aw_dev_vsense_select(aw_dev, &vsense_select); > + if (ret < 0) > + return ret; > + aw_dev_dbg(aw_dev->dev, "vsense_select = %d", vsense_select); > + > + ret = aw_dev_get_icalk(aw_dev, &icalk_val); > + if (ret < 0) > + return ret; > + icalk = desc->cabl_base_value + desc->icalk_value_factor * icalk_val; > + > + if (vsense_select == AW_DEV_VDSEL_VSENSE) { > + ret = aw_dev_get_vcalk(aw_dev, &vcalk_val); > + if (ret < 0) > + return ret; > + vcalk = desc->cabl_base_value + desc->vcalk_value_factor * vcalk_val; > + vcalb = desc->vcal_factor * desc->vscal_factor / > + desc->iscal_factor * icalk / vcalk * vcalb_adj; > + > + aw_dev_dbg(aw_dev->dev, "vcalk_factor=%d, vscal_factor=%d, icalk=%d, vcalk=%d", > + desc->vcalk_value_factor, desc->vscal_factor, icalk, vcalk); > + } else if (vsense_select == AW_DEV_VDSEL_DAC) { > + ret = aw_dev_get_vcalk_dac(aw_dev, &vcalk_val); > + if (ret < 0) > + return ret; > + vcalk = desc->cabl_base_value + desc->vcalk_value_factor_vsense_in * vcalk_val; > + vcalb = desc->vcal_factor * desc->vscal_factor_vsense_in / > + desc->iscal_factor * icalk / vcalk * vcalb_adj; > + > + aw_dev_dbg(aw_dev->dev, "vcalk_dac_factor=%d, vscal_dac_factor=%d, icalk=%d, vcalk=%d", > + desc->vcalk_value_factor_vsense_in, > + desc->vscal_factor_vsense_in, icalk, vcalk); > + } else { > + aw_dev_err(aw_dev->dev, "unsupport vsense status"); > + return -EINVAL; > + } > + > + if ((vcalk == 0) || (desc->iscal_factor == 0)) { > + aw_dev_err(aw_dev->dev, "vcalk:%d or desc->iscal_factor:%d unsupported", > + vcalk, desc->iscal_factor); > + return -EINVAL; > + } > + > + vcalb = vcalb >> aw_dev->vcalb_desc.vcalb_adj_shift; > + reg_val = (uint32_t)vcalb; > + > + aw_dev_dbg(aw_dev->dev, "vcalb=%d, reg_val=0x%x, vcalb_adj =0x%x", > + vcalb, reg_val, vcalb_adj); > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, desc->vcalb_dsp_reg, reg_val, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write vcalb failed"); > + return ret; > + } > + > + ret = aw883xx_dev_modify_dsp_cfg(aw_dev, desc->vcalb_dsp_reg, > + (uint32_t)reg_val, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "modify dsp cfg failed"); > + return ret; > + } > + > + aw_dev_info(aw_dev->dev, "done"); > + > + return 0; > +} > + > +static int aw_dev_get_cali_f0_delay(struct aw_device *aw_dev) > +{ > + struct aw_cali_delay_desc *desc = &aw_dev->cali_delay_desc; > + uint32_t cali_delay = 0; > + int ret = -1; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, > + desc->dsp_reg, &cali_delay, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read cali delay failed, ret=%d", ret); > + return ret; > + } > + > + desc->delay = AW_CALI_DELAY_CACL(cali_delay); > + aw_dev_info(aw_dev->dev, "read cali delay: %d ms", desc->delay); > + > + return 0; > +} > + > +int aw883xx_dev_get_int_status(struct aw_device *aw_dev, uint16_t *int_status) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, aw_dev->int_desc.st_reg, &reg_val); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "read interrupt reg fail, ret=%d", ret); > + else > + *int_status = reg_val; > + > + aw_dev_dbg(aw_dev->dev, "read interrupt reg = 0x%04x", *int_status); > + return ret; > +} > + > +void aw883xx_dev_clear_int_status(struct aw_device *aw_dev) > +{ > + uint16_t int_status = 0; > + > + /*read int status and clear*/ > + aw883xx_dev_get_int_status(aw_dev, &int_status); > + /*make sure int status is clear*/ > + aw883xx_dev_get_int_status(aw_dev, &int_status); > + aw_dev_info(aw_dev->dev, "done"); > +} > + > + > +int aw883xx_dev_get_iis_status(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + struct aw_sysst_desc *desc = &aw_dev->sysst_desc; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if ((reg_val & desc->pll_check) == desc->pll_check) > + ret = 0; > + else > + aw_dev_err(aw_dev->dev, "check pll lock fail,reg_val:0x%04x", reg_val); > + > + return ret; > +} > + > + > +static int aw_dev_mode1_pll_check(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint16_t i = 0; > + > + for (i = 0; i < AW_DEV_SYSST_CHECK_MAX; i++) { > + ret = aw883xx_dev_get_iis_status(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "mode1 iis signal check error"); > + usleep_range(AW_2000_US, AW_2000_US + 10); > + } else { > + return 0; > + } > + } > + > + return ret; > +} > + > +static int aw_dev_mode2_pll_check(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint16_t i = 0; > + uint16_t reg_val = 0; > + struct aw_cco_mux_desc *cco_mux_desc = &aw_dev->cco_mux_desc; > + > + aw_dev->ops.aw_reg_read(aw_dev, cco_mux_desc->reg, &reg_val); > + reg_val &= (~cco_mux_desc->mask); > + if (reg_val == cco_mux_desc->divider) { > + aw_dev_dbg(aw_dev->dev, "CCO_MUX is already divider"); > + return ret; > + } > + > + /* change mode2 */ > + aw_dev->ops.aw_reg_write_bits(aw_dev, cco_mux_desc->reg, > + cco_mux_desc->mask, cco_mux_desc->divider); > + > + for (i = 0; i < AW_DEV_SYSST_CHECK_MAX; i++) { > + ret = aw883xx_dev_get_iis_status(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "mode2 iis signal check error"); > + usleep_range(AW_2000_US, AW_2000_US + 10); > + } else { > + break; > + } > + } > + > + /* change mode1*/ > + aw_dev->ops.aw_reg_write_bits(aw_dev, cco_mux_desc->reg, > + cco_mux_desc->mask, cco_mux_desc->bypass); > + > + if (ret == 0) { > + usleep_range(AW_2000_US, AW_2000_US + 10); > + for (i = 0; i < AW_DEV_SYSST_CHECK_MAX; i++) { > + ret = aw_dev_mode1_pll_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "mode2 switch to mode1, iis signal check error"); > + usleep_range(AW_2000_US, AW_2000_US + 10); > + } else { > + break; > + } > + } > + } > + > + return ret; > +} > + > +int aw883xx_dev_syspll_check(struct aw_device *aw_dev) > +{ > + int ret = -1; > + > + ret = aw_dev_mode1_pll_check(aw_dev); > + if (ret < 0) { > + aw_dev_info(aw_dev->dev, "mode1 check iis failed try switch to mode2 check"); > + ret = aw_dev_mode2_pll_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "mode2 check iis failed"); > + return ret; > + } > + } > + > + return ret; > +} > + > +int aw883xx_dev_sysst_check(struct aw_device *aw_dev) > +{ > + int ret = -1; > + unsigned char i; > + uint16_t reg_val = 0; > + struct aw_sysst_desc *desc = &aw_dev->sysst_desc; > + > + for (i = 0; i < AW_DEV_SYSST_CHECK_MAX; i++) { > + aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if (((reg_val & (~desc->st_mask)) & desc->st_check) != desc->st_check) { > + aw_dev_dbg(aw_dev->dev, "check fail, cnt=%d, reg_val=0x%04x", > + i, reg_val); > + usleep_range(AW_2000_US, AW_2000_US + 10); > + } else { > + ret = 0; > + break; > + } > + } > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "check fail"); > + > + return ret; > +} > + > +static int aw_dev_get_monitor_sysint_st(struct aw_device *aw_dev) > +{ > + int ret = 0; > + struct aw_int_desc *desc = &aw_dev->int_desc; > + > + if ((desc->intst_mask) & (desc->sysint_st)) { > + aw_dev_err(aw_dev->dev, > + "monitor check fail:0x%04x", desc->sysint_st); > + ret = -EINVAL; > + } > + desc->sysint_st = 0; > + > + return ret; > +} > + > +static int aw_dev_sysint_check(struct aw_device *aw_dev) > +{ > + int ret = 0; > + uint16_t reg_val = 0; > + struct aw_int_desc *desc = &aw_dev->int_desc; > + > + aw883xx_dev_get_int_status(aw_dev, &reg_val); > + > + if (reg_val & (desc->intst_mask)) { > + aw_dev_err(aw_dev->dev, "pa stop check fail:0x%04x", reg_val); > + ret = -EINVAL; > + } > + > + return ret; > +} > + > +static void aw_dev_get_cur_mode_st(struct aw_device *aw_dev) > +{ > + uint16_t reg_val; > + struct aw_profctrl_desc *profctrl_desc = &aw_dev->profctrl_desc; > + > + aw_dev->ops.aw_reg_read(aw_dev, aw_dev->pwd_desc.reg, &reg_val); > + > + if ((reg_val & (~profctrl_desc->mask)) == profctrl_desc->rcv_mode_val) > + profctrl_desc->cur_mode = AW_RCV_MODE; > + else > + profctrl_desc->cur_mode = AW_NOT_RCV_MODE; > +} > + > +int aw883xx_dev_set_intmask(struct aw_device *aw_dev, bool flag) > +{ > + int ret = -1; > + struct aw_int_desc *desc = &aw_dev->int_desc; > + > + if (flag) > + ret = aw_dev->ops.aw_reg_write(aw_dev, desc->mask_reg, > + desc->int_mask); > + else > + ret = aw_dev->ops.aw_reg_write(aw_dev, desc->mask_reg, > + desc->mask_default); > + > + aw_dev_info(aw_dev->dev, "done"); > + return ret; > +} > + > +void aw883xx_dev_dsp_enable(struct aw_device *aw_dev, bool dsp) > +{ > + int ret = -1; > + struct aw_dsp_en_desc *desc = &aw_dev->dsp_en_desc; > + > + if (dsp) { > + ret = aw_dev->ops.aw_reg_write_bits(aw_dev, desc->reg, > + desc->mask, desc->enable); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "enable dsp failed"); > + } else { > + ret = aw_dev->ops.aw_reg_write_bits(aw_dev, desc->reg, > + desc->mask, desc->disable); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "disable dsp failed"); > + } > + > + aw_dev_info(aw_dev->dev, "done"); > +} > + > +static int aw_dev_get_dsp_config(struct aw_device *aw_dev, unsigned char *dsp_cfg) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + struct aw_dsp_en_desc *desc = &aw_dev->dsp_en_desc; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "reg read failed"); > + return ret; > + } > + > + if (reg_val & (~desc->mask)) > + *dsp_cfg = AW_DEV_DSP_BYPASS; > + else > + *dsp_cfg = AW_DEV_DSP_WORK; > + > + aw_dev_info(aw_dev->dev, "done"); > + > + return 0; > +} > + > +void aw883xx_dev_memclk_select(struct aw_device *aw_dev, unsigned char flag) > +{ > + struct aw_memclk_desc *desc = &aw_dev->memclk_desc; > + int ret = -1; > + > + if (flag == AW_DEV_MEMCLK_PLL) { > + ret = aw_dev->ops.aw_reg_write_bits(aw_dev, desc->reg, > + desc->mask, desc->mcu_hclk); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "memclk select pll failed"); > + > + } else if (flag == AW_DEV_MEMCLK_OSC) { > + ret = aw_dev->ops.aw_reg_write_bits(aw_dev, desc->reg, > + desc->mask, desc->osc_clk); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "memclk select OSC failed"); > + } else { > + aw_dev_err(aw_dev->dev, "unknown memclk config, flag=0x%x", flag); > + } > + > + aw_dev_info(aw_dev->dev, "done"); > +} > + > +int aw883xx_dev_get_dsp_status(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + struct aw_watch_dog_desc *desc = &aw_dev->watch_dog_desc; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if (reg_val & (~desc->mask)) > + ret = 0; > + > + return ret; > +} > + > +static int aw_dev_get_vmax(struct aw_device *aw_dev, unsigned int *vmax) > +{ > + int ret = -1; > + struct aw_vmax_desc *desc = &aw_dev->vmax_desc; > + > + ret = aw_dev->ops.aw_dsp_read(aw_dev, desc->dsp_reg, vmax, desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get vmax failed"); > + return ret; > + } > + > + return 0; > +} > + > +/* > + * aw_dev update cfg > + */ > + > +static int aw_dev_reg_container_update(struct aw_device *aw_dev, > + uint8_t *data, uint32_t len) > +{ > + int i, ret; > + uint8_t reg_addr = 0; > + uint16_t reg_val = 0; > + uint16_t read_val = 0; > + uint16_t read_vol = 0; > + struct aw_int_desc *int_desc = &aw_dev->int_desc; > + struct aw_volume_desc *vol_desc = &aw_dev->volume_desc; > + int16_t *reg_data = NULL; > + int data_len; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + reg_data = (int16_t *)data; > + data_len = len >> 1; > + > + if (data_len % 2 != 0) { > + aw_dev_err(aw_dev->dev, "data len:%d unsupported", > + data_len); > + return -EINVAL; > + } > + > + for (i = 0; i < data_len; i += 2) { > + reg_addr = reg_data[i]; > + reg_val = reg_data[i + 1]; > + aw_dev_dbg(aw_dev->dev, "reg = 0x%02x, val = 0x%04x", > + reg_addr, reg_val); > + if (reg_addr == int_desc->mask_reg) { > + int_desc->int_mask = reg_val; > + reg_val = int_desc->mask_default; > + } > + if (reg_addr == aw_dev->mute_desc.reg) { > + aw_dev->ops.aw_reg_read(aw_dev, reg_addr, &read_val); > + read_val &= (~aw_dev->mute_desc.mask); > + reg_val &= aw_dev->mute_desc.mask; > + reg_val |= read_val; > + } > + if (reg_addr == aw_dev->dsp_crc_desc.ctl_reg) > + reg_val &= aw_dev->dsp_crc_desc.ctl_mask; > + > + if (reg_addr == aw_dev->chansel_desc.txchan_reg) { > + /*close tx*/ > + reg_val &= aw_dev->tx_en_desc.tx_en_mask; > + reg_val |= aw_dev->tx_en_desc.tx_disable; > + } > + > + if (reg_addr == aw_dev->volume_desc.reg) { > + read_vol = (reg_val & (~aw_dev->volume_desc.mask)) >> > + aw_dev->volume_desc.shift; > + aw_dev->volume_desc.init_volume = > + aw_dev->ops.aw_reg_val_to_db(read_vol); > + } > + > + ret = aw_dev->ops.aw_reg_write(aw_dev, reg_addr, reg_val); > + if (ret < 0) > + break; > + > + } > + > + aw883xx_hold_reg_spin_st(&aw_dev->spin_desc); > + > + aw_dev_get_cur_mode_st(aw_dev); > + > + if (aw_dev->cur_prof != aw_dev->set_prof) { > + /*clear control volume when PA change profile*/ > + vol_desc->ctl_volume = 0; > + } else { > + /*keep control volume when PA start with sync mode*/ > + aw883xx_dev_set_volume(aw_dev, vol_desc->ctl_volume); > + } > + > + /*keep min volume*/ > + if (aw_dev->fade_en) > + aw883xx_dev_set_volume(aw_dev, vol_desc->mute_volume); > + > + aw_dev_get_dsp_config(aw_dev, &aw_dev->dsp_cfg); > + > + aw_dev_dbg(aw_dev->dev, "exit"); > + > + return ret; > +} > + > +static int aw_dev_reg_update(struct aw_device *aw_dev, > + uint8_t *data, uint32_t len) > +{ > + > + aw_dev_dbg(aw_dev->dev, "reg len:%d", len); > + > + if (len && (data != NULL)) { > + aw_dev_reg_container_update(aw_dev, data, len); > + } else { > + aw_dev_err(aw_dev->dev, "reg data is null or len is 0"); > + return -EPERM; > + } > + > + return 0; > +} > + > +static int aw_dev_dsp_container_update(struct aw_device *aw_dev, > + uint8_t *data, uint32_t len, uint16_t base) > +{ > + int i; > + struct aw_dsp_mem_desc *dsp_mem_desc = &aw_dev->dsp_mem_desc; > +#ifdef AW_DSP_I2C_WRITES > + uint32_t tmp_len = 0; > +#else > + uint16_t reg_val = 0; > +#endif > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + mutex_lock(aw_dev->i2c_lock); > +#ifdef AW_DSP_I2C_WRITES > + /* i2c writes */ > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, base); > + > + for (i = 0; i < len; i += AW_MAX_RAM_WRITE_BYTE_SIZE) { > + if ((len - i) < AW_MAX_RAM_WRITE_BYTE_SIZE) > + tmp_len = len - i; > + else > + tmp_len = AW_MAX_RAM_WRITE_BYTE_SIZE; > + aw_dev->ops.aw_i2c_writes(aw_dev, dsp_mem_desc->dsp_mdat_reg, > + &data[i], tmp_len); > + } > + > +#else > + /* i2c write */ > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, base); > + for (i = 0; i < len; i += 2) { > + reg_val = (data[i] << 8) + data[i + 1]; > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_mdat_reg, > + reg_val); > + } > +#endif > + mutex_unlock(aw_dev->i2c_lock); > + aw_dev_dbg(aw_dev->dev, "exit"); > + > + return 0; > +} > + > +int aw_dev_dsp_fw_update(struct aw_device *aw_dev, > + uint8_t *data, uint32_t len) > +{ > + struct aw_dsp_mem_desc *dsp_mem_desc = &aw_dev->dsp_mem_desc; > + > + aw_dev_dbg(aw_dev->dev, "dsp firmware len:%d", len); > + > + if (len && (data != NULL)) { > + aw_dev_dsp_container_update(aw_dev, > + data, len, dsp_mem_desc->dsp_fw_base_addr); > + aw_dev->dsp_fw_len = len; > + } else { > + aw_dev_err(aw_dev->dev, "dsp firmware data is null or len is 0"); > + return -EPERM; > + } > + > + return 0; > +} > + > +static int aw_dev_copy_to_crc_dsp_cfg(struct aw_device *aw_dev, > + uint8_t *data, uint32_t size) > +{ > + struct aw_sec_data_desc *crc_dsp_cfg = &aw_dev->crc_dsp_cfg; > + int ret; > + > + if (crc_dsp_cfg->data == NULL) { > + crc_dsp_cfg->data = devm_kzalloc(aw_dev->dev, size, GFP_KERNEL); > + if (!crc_dsp_cfg->data) > + return -ENOMEM; > + crc_dsp_cfg->len = size; > + } else if (crc_dsp_cfg->len < size) { > + devm_kfree(aw_dev->dev, crc_dsp_cfg->data); > + crc_dsp_cfg->data = NULL; > + crc_dsp_cfg->data = devm_kzalloc(aw_dev->dev, size, GFP_KERNEL); > + if (!crc_dsp_cfg->data) { > + aw_dev_err(aw_dev->dev, "error allocating memory"); > + return -ENOMEM; > + } > + } > + memcpy(crc_dsp_cfg->data, data, size); > + ret = aw883xx_dev_dsp_data_order(aw_dev, crc_dsp_cfg->data, size); > + if (ret < 0) > + return ret; > + > + return 0; > +} > + > +int aw883xx_dev_dsp_cfg_update(struct aw_device *aw_dev, > + uint8_t *data, uint32_t len) > +{ > + struct aw_dsp_mem_desc *dsp_mem_desc = &aw_dev->dsp_mem_desc; > + int ret; > + > + aw_dev_dbg(aw_dev->dev, "dsp config len:%d", len); > + > + if (len && (data != NULL)) { > + aw_dev_dsp_container_update(aw_dev, > + data, len, dsp_mem_desc->dsp_cfg_base_addr); > + aw_dev->dsp_cfg_len = len; > + > + ret = aw_dev_copy_to_crc_dsp_cfg(aw_dev, data, len); > + if (ret < 0) > + return ret; > + > + aw_dev_set_vcalb(aw_dev); > + aw883xx_cali_svc_get_ra(&aw_dev->cali_desc); > + aw_dev_get_cali_f0_delay(aw_dev); > + > + if (aw_dev->ops.aw_get_hw_mon_st) { > + ret = aw_dev->ops.aw_get_hw_mon_st(aw_dev, > + &aw_dev->monitor_desc.hw_mon_en, > + &aw_dev->monitor_desc.hw_temp_flag); > + if (ret < 0) > + return ret; > + } > + > + ret = aw_dev_get_vmax(aw_dev, &aw_dev->vmax_desc.init_vmax); > + if (ret == 0) { > + aw_dev_info(aw_dev->dev, "get init vmax:0x%x", > + aw_dev->vmax_desc.init_vmax); > + } else { > + aw_dev_err(aw_dev->dev, "get vmax failed"); > + return ret; > + } > + > + aw_dev->dsp_crc_st = AW_DSP_CRC_NA; > + } else { > + aw_dev_err(aw_dev->dev, "dsp config data is null or len is 0"); > + return -EPERM; > + } > + > + return 0; > +} > + > +static int aw_dev_sram_check(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + struct aw_dsp_mem_desc *dsp_mem_desc = &aw_dev->dsp_mem_desc; > + > + mutex_lock(aw_dev->i2c_lock); > + /*check the odd bits of reg 0x40*/ > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, > + AW_DSP_ODD_NUM_BIT_TEST); > + aw_dev->ops.aw_i2c_read(aw_dev, dsp_mem_desc->dsp_madd_reg, &reg_val); > + if (reg_val != AW_DSP_ODD_NUM_BIT_TEST) { > + aw_dev_err(aw_dev->dev, "check reg 0x40 odd bit failed, read[0x%x] does not match write[0x%x]", > + reg_val, AW_DSP_ODD_NUM_BIT_TEST); > + goto error; > + } > + > + /*check the even bits of reg 0x40*/ > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, > + AW_DSP_EVEN_NUM_BIT_TEST); > + aw_dev->ops.aw_i2c_read(aw_dev, dsp_mem_desc->dsp_madd_reg, &reg_val); > + if (reg_val != AW_DSP_EVEN_NUM_BIT_TEST) { > + aw_dev_err(aw_dev->dev, "check reg 0x40 even bit failed, read[0x%x] does not match write[0x%x]", > + reg_val, AW_DSP_EVEN_NUM_BIT_TEST); > + goto error; > + } > + > + /*check dsp_fw_base_addr*/ > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, > + dsp_mem_desc->dsp_fw_base_addr); > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_mdat_reg, > + AW_DSP_EVEN_NUM_BIT_TEST); > + > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, > + dsp_mem_desc->dsp_fw_base_addr); > + aw_dev->ops.aw_i2c_read(aw_dev, dsp_mem_desc->dsp_mdat_reg, &reg_val); > + if (reg_val != AW_DSP_EVEN_NUM_BIT_TEST) { > + aw_dev_err(aw_dev->dev, "check dsp fw addr failed, read[0x%x] does not match write[0x%x]", > + reg_val, AW_DSP_EVEN_NUM_BIT_TEST); > + goto error; > + } > + > + /*check dsp_cfg_base_addr*/ > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, > + dsp_mem_desc->dsp_cfg_base_addr); > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_mdat_reg, > + AW_DSP_ODD_NUM_BIT_TEST); > + > + aw_dev->ops.aw_i2c_write(aw_dev, dsp_mem_desc->dsp_madd_reg, > + dsp_mem_desc->dsp_cfg_base_addr); > + aw_dev->ops.aw_i2c_read(aw_dev, dsp_mem_desc->dsp_mdat_reg, &reg_val); > + if (reg_val != AW_DSP_ODD_NUM_BIT_TEST) { > + aw_dev_err(aw_dev->dev, "check dsp cfg failed, read[0x%x] does not match write[0x%x]", > + reg_val, AW_DSP_ODD_NUM_BIT_TEST); > + goto error; > + } > + > + mutex_unlock(aw_dev->i2c_lock); > + return 0; > + > +error: > + mutex_unlock(aw_dev->i2c_lock); > + return ret; > +} > + > +int aw883xx_dev_fw_update(struct aw_device *aw_dev, bool up_dsp_fw_en, bool force_up_en) > +{ > + int ret = -1; > + struct aw_prof_desc *set_prof_desc = NULL; > + struct aw_sec_data_desc *sec_desc = NULL; > + char *prof_name = NULL; > + > + if ((aw_dev->cur_prof == aw_dev->set_prof) && > + (force_up_en == AW_FORCE_UPDATE_OFF)) { > + aw_dev_info(aw_dev->dev, "scene no change, not update"); > + return 0; > + } > + > + if (aw_dev->fw_status == AW_DEV_FW_FAILED) { > + aw_dev_err(aw_dev->dev, "fw status[%d] error", aw_dev->fw_status); > + return -EPERM; > + } > + > + prof_name = aw_dev_get_prof_name(aw_dev, aw_dev->set_prof); > + if (prof_name == NULL) > + return -ENOMEM; > + > + aw_dev_info(aw_dev->dev, "start update %s", prof_name); > + > + ret = aw883xx_dev_get_prof_data(aw_dev, aw_dev->set_prof, &set_prof_desc); > + if (ret < 0) > + return ret; > + > + /*update reg*/ > + sec_desc = set_prof_desc->sec_desc; > + ret = aw_dev_reg_update(aw_dev, sec_desc[AW_DATA_TYPE_REG].data, > + sec_desc[AW_DATA_TYPE_REG].len); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "update reg failed"); > + return ret; > + } > + > + aw883xx_dev_mute(aw_dev, true); > + > + if (aw_dev->dsp_cfg == AW_DEV_DSP_WORK) > + aw883xx_dev_dsp_enable(aw_dev, false); > + > + aw883xx_dev_memclk_select(aw_dev, AW_DEV_MEMCLK_OSC); > + > + if (up_dsp_fw_en) { > + ret = aw_dev_sram_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "check sram failed"); > + goto error; > + } > + > + /*update dsp firmware*/ > + aw_dev_info(aw_dev->dev, "fw_ver: [%x]", set_prof_desc->fw_ver); > + ret = aw_dev_dsp_fw_update(aw_dev, sec_desc[AW_DATA_TYPE_DSP_FW].data, > + sec_desc[AW_DATA_TYPE_DSP_FW].len); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "update dsp fw failed"); > + goto error; > + } > + } > + > + /*update dsp config*/ > + ret = aw883xx_dev_dsp_cfg_update(aw_dev, sec_desc[AW_DATA_TYPE_DSP_CFG].data, > + sec_desc[AW_DATA_TYPE_DSP_CFG].len); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "update dsp cfg failed"); > + goto error; > + } > + > + aw883xx_dev_memclk_select(aw_dev, AW_DEV_MEMCLK_PLL); > + > + aw_dev->cur_prof = aw_dev->set_prof; > + > + aw_dev_info(aw_dev->dev, "load %s done", prof_name); > + return 0; > + > +error: > + aw883xx_dev_memclk_select(aw_dev, AW_DEV_MEMCLK_PLL); > + > + return ret; > +} > + > +int aw883xx_dev_dsp_check(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint16_t i = 0; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + if (aw_dev->dsp_cfg == AW_DEV_DSP_BYPASS) { > + aw_dev_dbg(aw_dev->dev, "dsp bypass"); > + return 0; > + } else if (aw_dev->dsp_cfg == AW_DEV_DSP_WORK) { > + aw883xx_dev_dsp_enable(aw_dev, false); > + aw883xx_dev_dsp_enable(aw_dev, true); > + usleep_range(AW_1000_US, AW_1000_US + 10); > + for (i = 0; i < AW_DEV_DSP_CHECK_MAX; i++) { > + ret = aw883xx_dev_get_dsp_status(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp wdt status error=%d", ret); > + usleep_range(AW_2000_US, AW_2000_US + 10); > + } else { > + return 0; > + } > + } > + } else { > + aw_dev_err(aw_dev->dev, "unknown dsp cfg=%d", aw_dev->dsp_cfg); > + return -EINVAL; > + } > + > + return -EINVAL; > +} > + > +static int aw_dev_set_cfg_f0_fs(struct aw_device *aw_dev) > +{ > + uint32_t f0_fs = 0; > + struct aw_cfgf0_fs_desc *cfgf0_fs_desc = &aw_dev->cfgf0_fs_desc; > + int ret; > + > + if (aw_dev->ops.aw_set_cfg_f0_fs) { > + aw_dev->ops.aw_set_cfg_f0_fs(aw_dev, &f0_fs); > + ret = aw883xx_dev_modify_dsp_cfg(aw_dev, cfgf0_fs_desc->dsp_reg, > + f0_fs, cfgf0_fs_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "modify dsp cfg failed"); > + return ret; > + } > + } > + > + return 0; > +} > + > +static void aw_dev_cali_re_update(struct aw_cali_desc *cali_desc) > +{ > + struct aw_device *aw_dev = > + container_of(cali_desc, struct aw_device, cali_desc); > + > + if (aw_dev->cali_desc.cali_re < aw_dev->re_range.re_max && > + aw_dev->cali_desc.cali_re > aw_dev->re_range.re_min) { > + aw883xx_cali_svc_set_cali_re_to_dsp(&aw_dev->cali_desc); > + } else { > + aw_dev_err(aw_dev->dev, "cali_re:%d out of range, no set", > + aw_dev->cali_desc.cali_re); > + } > +} > + > + > +int aw883xx_device_start(struct aw_device *aw_dev) > +{ > + int ret = -1; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + if (aw_dev->status == AW_DEV_PW_ON) { > + aw_dev_info(aw_dev->dev, "already power on"); > + return 0; > + } > + > + /*power on*/ > + aw_dev_pwd(aw_dev, false); > + usleep_range(AW_2000_US, AW_2000_US + 10); > + > + ret = aw883xx_dev_syspll_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "pll check failed cannot start"); > + aw_dev_reg_dump(aw_dev); > + goto pll_check_fail; > + } > + > + /*amppd on*/ > + aw_dev_amppd(aw_dev, false); > + usleep_range(AW_1000_US, AW_1000_US + 50); > + > + /*check i2s status*/ > + ret = aw883xx_dev_sysst_check(aw_dev); > + if (ret < 0) { > + /*check failed*/ > + aw_dev_reg_dump(aw_dev); > + goto sysst_check_fail; > + } > + > + if (aw_dev->dsp_cfg == AW_DEV_DSP_WORK) { > + /*dsp bypass*/ > + aw883xx_dev_dsp_enable(aw_dev, false); > + if (aw_dev->ops.aw_dsp_fw_check) { > + ret = aw_dev->ops.aw_dsp_fw_check(aw_dev); > + if (ret < 0) { > + aw_dev_reg_dump(aw_dev); > + goto dsp_fw_check_fail; > + } > + } > + aw_dev_set_cfg_f0_fs(aw_dev); > + > + aw_dev_cali_re_update(&aw_dev->cali_desc); > + > + if (aw_dev->dsp_crc_st != AW_DSP_CRC_OK) { > + ret = aw_dev_dsp_crc32_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp crc check failed"); > + aw_dev_reg_dump(aw_dev); > + goto crc_check_fail; > + } > + } > + > + ret = aw883xx_dev_dsp_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "check dsp status failed"); > + aw_dev_reg_dump(aw_dev); > + goto dsp_check_fail; > + } > + } else { > + aw_dev_dbg(aw_dev->dev, "start pa with dsp bypass"); > + } > + > + /*enable tx feedback*/ > + if (aw_dev->ops.aw_i2s_tx_enable) > + aw_dev->ops.aw_i2s_tx_enable(aw_dev, true); > + > + /*close mute*/ > + if (aw883xx_cali_check_result(&aw_dev->cali_desc)) > + aw883xx_dev_mute(aw_dev, false); > + else > + aw883xx_dev_mute(aw_dev, true); > + > + /*clear inturrupt*/ > + aw883xx_dev_clear_int_status(aw_dev); > + /*set inturrupt mask*/ > + aw883xx_dev_set_intmask(aw_dev, true); > + > + aw883xx_monitor_start(&aw_dev->monitor_desc); > + > + aw_dev->status = AW_DEV_PW_ON; > + > + aw_dev_info(aw_dev->dev, "done"); > + > + return 0; > + > +dsp_check_fail: > +crc_check_fail: > + aw883xx_dev_dsp_enable(aw_dev, false); > +dsp_fw_check_fail: > +sysst_check_fail: > + /*clear interrupt*/ > + aw883xx_dev_clear_int_status(aw_dev); > + aw_dev_amppd(aw_dev, true); > +pll_check_fail: > + aw_dev_pwd(aw_dev, true); > + aw_dev->status = AW_DEV_PW_OFF; > + return ret; > +} > + > +int aw883xx_device_stop(struct aw_device *aw_dev) > +{ > + struct aw_sec_data_desc *dsp_cfg = > + &aw_dev->prof_info.prof_desc[aw_dev->cur_prof].sec_desc[AW_DATA_TYPE_DSP_CFG]; > + struct aw_sec_data_desc *dsp_fw = > + &aw_dev->prof_info.prof_desc[aw_dev->cur_prof].sec_desc[AW_DATA_TYPE_DSP_FW]; > + int int_st = 0; > + int monitor_int_st = 0; > + > + aw_dev_dbg(aw_dev->dev, "enter"); > + > + if (aw_dev->status == AW_DEV_PW_OFF) { > + aw_dev_info(aw_dev->dev, "already power off"); > + return 0; > + } > + > + aw_dev->status = AW_DEV_PW_OFF; > + > + aw883xx_monitor_stop(&aw_dev->monitor_desc); > + > + /*set mute*/ > + aw883xx_dev_mute(aw_dev, true); > + usleep_range(AW_4000_US, AW_4000_US + 100); > + > + /*close tx feedback*/ > + if (aw_dev->ops.aw_i2s_tx_enable) > + aw_dev->ops.aw_i2s_tx_enable(aw_dev, false); > + usleep_range(AW_1000_US, AW_1000_US + 100); > + > + /*set defaut int mask*/ > + aw883xx_dev_set_intmask(aw_dev, false); > + > + /*check sysint state*/ > + int_st = aw_dev_sysint_check(aw_dev); > + > + /*close dsp*/ > + aw883xx_dev_dsp_enable(aw_dev, false); > + > + /*enable amppd*/ > + aw_dev_amppd(aw_dev, true); > + > + /*check monitor process sysint state*/ > + monitor_int_st = aw_dev_get_monitor_sysint_st(aw_dev); > + > + if (int_st < 0 || monitor_int_st < 0) { > + /*system status anomaly*/ > + aw883xx_dev_memclk_select(aw_dev, AW_DEV_MEMCLK_OSC); > + aw883xx_dev_dsp_cfg_update(aw_dev, dsp_cfg->data, dsp_cfg->len); > + aw_dev_dsp_fw_update(aw_dev, dsp_fw->data, dsp_fw->len); > + aw883xx_dev_memclk_select(aw_dev, AW_DEV_MEMCLK_PLL); > + } > + > + /*set power down*/ > + aw_dev_pwd(aw_dev, true); > + > + aw_dev_info(aw_dev->dev, "done"); > + return 0; > +} > + > +/*deinit aw_device*/ > +void aw883xx_dev_deinit(struct aw_device *aw_dev) > +{ > + if (aw_dev == NULL) > + return; > + > + if (aw_dev->prof_info.prof_desc != NULL) { > + devm_kfree(aw_dev->dev, aw_dev->prof_info.prof_desc); > + aw_dev->prof_info.prof_desc = NULL; > + } > + aw_dev->prof_info.count = 0; > + > + if (aw_dev->crc_dsp_cfg.data != NULL) { > + aw_dev->crc_dsp_cfg.len = 0; > + devm_kfree(aw_dev->dev, aw_dev->crc_dsp_cfg.data); > + aw_dev->crc_dsp_cfg.data = NULL; > + } > + > +} > + > +/*init aw_device*/ > +int aw883xx_device_init(struct aw_device *aw_dev, struct aw_container *aw_cfg) > +{ > + int ret; > + > + if (aw_dev == NULL || aw_cfg == NULL) { > + aw_pr_err("aw_dev is NULL or aw_cfg is NULL"); > + return -ENOMEM; > + } > + > + ret = aw883xx_dev_cfg_load(aw_dev, aw_cfg); > + if (ret < 0) { > + aw883xx_dev_deinit(aw_dev); > + aw_dev_err(aw_dev->dev, "aw_dev acf parse failed"); > + return -EINVAL; > + } > + > + aw_dev->cur_prof = aw_dev->prof_info.prof_desc[0].id; > + aw_dev->set_prof = aw_dev->prof_info.prof_desc[0].id; > + ret = aw883xx_dev_fw_update(aw_dev, AW_FORCE_UPDATE_ON, > + AW_DSP_FW_UPDATE_ON); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "fw update failed"); > + return ret; > + } > + > + aw883xx_dev_set_intmask(aw_dev, false); > + > + /*set mute*/ > + aw883xx_dev_mute(aw_dev, true); > + > + /*close tx feedback*/ > + if (aw_dev->ops.aw_i2s_tx_enable) > + aw_dev->ops.aw_i2s_tx_enable(aw_dev, false); > + usleep_range(AW_1000_US, AW_1000_US + 100); > + > + /*enable amppd*/ > + aw_dev_amppd(aw_dev, true); > + /*close dsp*/ > + aw883xx_dev_dsp_enable(aw_dev, false); > + /*set power down*/ > + aw_dev_pwd(aw_dev, true); > + > + mutex_lock(&g_dev_lock); > + list_add(&aw_dev->list_node, &g_dev_list); > + mutex_unlock(&g_dev_lock); > + > + aw_dev_info(aw_dev->dev, "init done"); > + > + return 0; > +} > + > +static void aw883xx_parse_channel_dt(struct aw_device *aw_dev) > +{ > + int ret; > + uint32_t channel_value; > + struct device_node *np = aw_dev->dev->of_node; > + > + ret = of_property_read_u32(np, "sound-channel", &channel_value); > + if (ret < 0) { > + aw_dev_info(aw_dev->dev, > + "read sound-channel failed,use default 0"); > + aw_dev->channel = AW_DEV_DEFAULT_CH; > + return; > + } > + > + aw_dev_dbg(aw_dev->dev, "read sound-channel value is: %d", > + channel_value); > + aw_dev->channel = channel_value; > +} > + > +static void aw883xx_parse_fade_enable_dt(struct aw_device *aw_dev) > +{ > + int ret = -1; > + struct device_node *np = aw_dev->dev->of_node; > + uint32_t fade_en; > + > + ret = of_property_read_u32(np, "fade-enable", &fade_en); > + if (ret < 0) { > + aw_dev_info(aw_dev->dev, > + "read fade-enable failed, close fade_in_out"); > + fade_en = AW_FADE_IN_OUT_DEFAULT; > + } else { > + aw_dev_info(aw_dev->dev, "read fade-enable value is: %d", fade_en); > + } > + > + aw_dev->fade_en = fade_en; > +} > + > +static void aw883xx_parse_re_range_dt(struct aw_device *aw_dev) > +{ > + int ret; > + uint32_t re_max; > + uint32_t re_min; > + struct device_node *np = aw_dev->dev->of_node; > + > + ret = of_property_read_u32(np, "re-min", &re_min); > + if (ret < 0) { > + aw_dev->re_range.re_min = aw_dev->re_range.re_min_default; > + aw_dev_info(aw_dev->dev, > + "read re-min value failed, set default value:[%d]mohm", > + aw_dev->re_range.re_min); > + } else { > + aw_dev_info(aw_dev->dev, > + "parse re-min:[%d]", re_min); > + aw_dev->re_range.re_min = re_min; > + } > + > + ret = of_property_read_u32(np, "re-max", &re_max); > + if (ret < 0) { > + aw_dev->re_range.re_max = aw_dev->re_range.re_max_default; > + aw_dev_info(aw_dev->dev, > + "read re-max failed, set default value:[%d]mohm", > + aw_dev->re_range.re_max); > + } else { > + aw_dev_info(aw_dev->dev, > + "parse re-max:[%d]", re_max); > + aw_dev->re_range.re_max = re_max; > + } > +} > + > +static void aw_device_parse_dt(struct aw_device *aw_dev) > +{ > + aw883xx_parse_channel_dt(aw_dev); > + aw883xx_parse_fade_enable_dt(aw_dev); > + aw883xx_parse_re_range_dt(aw_dev); > +} > + > +int aw883xx_dev_get_list_head(struct list_head **head) > +{ > + if (list_empty(&g_dev_list)) > + return -EINVAL; > + > + *head = &g_dev_list; > + > + return 0; > +} > + > +int aw883xx_device_probe(struct aw_device *aw_dev) > +{ > + INIT_LIST_HEAD(&aw_dev->list_node); > + > + aw_device_parse_dt(aw_dev); > + > + aw883xx_cali_init(&aw_dev->cali_desc); > + > + aw883xx_monitor_init(&aw_dev->monitor_desc); > + > + aw883xx_spin_init(&aw_dev->spin_desc); > + > + return 0; > +} > + > +int aw883xx_device_remove(struct aw_device *aw_dev) > +{ > + aw883xx_monitor_deinit(&aw_dev->monitor_desc); > + > + aw883xx_cali_deinit(&aw_dev->cali_desc); > + > + return 0; > +} > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_device.h b/sound/soc/codecs/aw883xx/aw883xx_device.h > new file mode 100644 > index 0000000..bfac8e2 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_device.h > @@ -0,0 +1,557 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_DEVICE_FILE_H__ > +#define __AW883XX_DEVICE_FILE_H__ > +#include "aw883xx_spin.h" > +#include "aw883xx_monitor.h" > +#include "aw883xx_data_type.h" > +#include "aw883xx_calib.h" > + > +#define AW_DEV_DEFAULT_CH (0) > +#define AW_DEV_I2S_CHECK_MAX (5) > +#define AW_DEV_DSP_CHECK_MAX (5) > + > +/* > + * DSP I2C WRITES > + */ > +#define AW_DSP_I2C_WRITES > +#define AW_MAX_RAM_WRITE_BYTE_SIZE (128) > +#define AW_DSP_ODD_NUM_BIT_TEST (0x5555) > +#define AW_DSP_EVEN_NUM_BIT_TEST (0xAAAA) > +#define AW_DSP_ST_CHECK_MAX (2) > +#define AW_FADE_IN_OUT_DEFAULT (0) > +#define AW_CALI_DELAY_CACL(value) ((value * 32) / 48) > + > +#define AW_GET_MIN_VALUE(value1, value2) \ > + ((value1) > (value2) ? (value2) : (value1)) > + > +#define AW_GET_MAX_VALUE(value1, value2) \ > + ((value1) > (value2) ? (value1) : (value2)) > + > +struct aw_device; > + > +enum { > + AW_DEV_VDSEL_DAC = 0, > + AW_DEV_VDSEL_VSENSE = 1, > +}; > + > +enum { > + AW_DSP_CRC_NA = 0, > + AW_DSP_CRC_OK = 1, > +}; > + > +enum { > + AW_DSP_CRC_DISABLE = 0, > + AW_DSP_CRC_ENABLE = 1, > +}; > + > +enum { > + AW_DSP_FW_UPDATE_OFF = 0, > + AW_DSP_FW_UPDATE_ON = 1, > +}; > + > +enum { > + AW_FORCE_UPDATE_OFF = 0, > + AW_FORCE_UPDATE_ON = 1, > +}; > + > +enum { > + AW_1000_US = 1000, > + AW_2000_US = 2000, > + AW_3000_US = 3000, > + AW_4000_US = 4000, > + AW_5000_US = 5000, > + AW_10000_US = 10000, > + AW_100000_US = 100000, > +}; > + > +enum { > + AW_DEV_TYPE_OK = 0, > + AW_DEV_TYPE_NONE = 1, > +}; > + > + > +enum AW_DEV_STATUS { > + AW_DEV_PW_OFF = 0, > + AW_DEV_PW_ON, > +}; > + > +enum AW_DEV_FW_STATUS { > + AW_DEV_FW_FAILED = 0, > + AW_DEV_FW_OK, > +}; > + > +enum AW_DEV_MEMCLK { > + AW_DEV_MEMCLK_OSC = 0, > + AW_DEV_MEMCLK_PLL = 1, > +}; > + > +enum AW_DEV_DSP_CFG { > + AW_DEV_DSP_WORK = 0, > + AW_DEV_DSP_BYPASS = 1, > +}; > + > +enum { > + AW_DSP_16_DATA = 0, > + AW_DSP_32_DATA = 1, > +}; > + > +enum aw_platform { > + AW_QCOM = 0, > + AW_MTK = 1, > + AW_SPRD = 2, > +}; > + > +enum { > + AW_NOT_RCV_MODE = 0, > + AW_RCV_MODE = 1, > +}; > + > +struct aw_device_ops { > + int (*aw_i2c_writes)(struct aw_device *aw_dev, uint8_t reg_addr, > + uint8_t *buf, uint16_t len); > + int (*aw_i2c_write)(struct aw_device *aw_dev, uint8_t reg_addr, uint16_t reg_data); > + int (*aw_i2c_read)(struct aw_device *aw_dev, uint8_t reg_addr, uint16_t *reg_data); > + > + int (*aw_reg_write)(struct aw_device *aw_dev, uint8_t reg_addr, uint16_t reg_data); > + int (*aw_reg_read)(struct aw_device *aw_dev, uint8_t reg_addr, uint16_t *reg_data); > + int (*aw_reg_write_bits)(struct aw_device *aw_dev, uint8_t reg_addr, > + uint16_t mask, uint16_t reg_data); > + > + int (*aw_dsp_write)(struct aw_device *aw_dev, > + uint16_t dsp_addr, > + uint32_t reg_data, > + uint8_t data_type); > + int (*aw_dsp_read)(struct aw_device *aw_dev, > + uint16_t dsp_addr, > + uint32_t *dsp_data, > + uint8_t data_type); > + int (*aw_dsp_write_bits)(struct aw_device *aw_dev, uint16_t dsp_addr, > + uint16_t mask, uint16_t dsp_data); > + > + int (*aw_set_hw_volume)(struct aw_device *aw_dev, uint16_t value); > + int (*aw_get_hw_volume)(struct aw_device *aw_dev, uint16_t *value); > + unsigned int (*aw_reg_val_to_db)(unsigned int value); > + > + void (*aw_i2s_tx_enable)(struct aw_device *aw_dev, bool flag); > + int (*aw_get_dev_num)(void); > + > + bool (*aw_check_wr_access)(int reg); > + bool (*aw_check_rd_access)(int reg); > + int (*aw_get_reg_num)(void); > + int (*aw_get_version)(char *buf, int size); > + int (*aw_read_dsp_pid)(struct aw_device *aw_dev); > + int (*aw_get_hw_mon_st)(struct aw_device *aw_dev, bool *is_enable, uint8_t *temp_flag); > + int (*aw_cali_svc_get_iv_st)(struct aw_device *aw_dev); > + void (*aw_set_cfg_f0_fs)(struct aw_device *aw_dev, uint32_t *f0_fs); > + int (*aw_dsp_fw_check)(struct aw_device *aw_dev); > +}; > + > +struct aw_int_desc { > + unsigned int mask_reg; /*interrupt mask reg*/ > + unsigned int st_reg; /*interrupt status reg*/ > + unsigned int mask_default; /*default mask close all*/ > + unsigned int int_mask; /*set mask*/ > + unsigned int intst_mask; /*interrupt check mask*/ > + uint16_t sysint_st; /*interrupt reg status*/ > +}; > + > +struct aw_pwd_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int enable; > + unsigned int disable; > +}; > + > +struct aw_vcalb_desc { > + unsigned int icalk_reg; > + unsigned int icalk_reg_mask; > + unsigned int icalk_sign_mask; > + unsigned int icalk_neg_mask; > + int icalk_value_factor; > + > + unsigned int vcalk_reg; > + unsigned int vcalk_reg_mask; > + unsigned int vcalk_sign_mask; > + unsigned int vcalk_neg_mask; > + unsigned int vcalk_shift; > + int vcalk_value_factor; > + > + unsigned int vcalb_dsp_reg; > + unsigned char data_type; > + int cabl_base_value; > + int vcal_factor; > + int vscal_factor; > + int iscal_factor; > + > + unsigned int vcalb_adj_shift; > + > + unsigned int vcalb_vsense_reg; > + int vscal_factor_vsense_in; > + int vcalk_value_factor_vsense_in; > + unsigned int vcalk_dac_shift; > + unsigned int vcalk_dac_mask; > + unsigned int vcalk_dac_neg_mask; > + unsigned int vcalk_vdsel_mask; > +}; > + > +struct aw_mute_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int enable; > + unsigned int disable; > +}; > + > +struct aw_sysst_desc { > + unsigned int reg; > + unsigned int st_check; > + unsigned int st_mask; > + unsigned int pll_check; > + unsigned int dsp_check; > + unsigned int dsp_mask; > +}; > + > +struct aw_profctrl_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int rcv_mode_val; > + unsigned int cur_mode; > +}; > + > +struct aw_volume_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int shift; > + unsigned int init_volume; > + unsigned int mute_volume; > + unsigned int ctl_volume; > + unsigned int max_volume; > + unsigned int monitor_volume; > +}; > + > +struct aw_dsp_en_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int enable; > + unsigned int disable; > +}; > + > +struct aw_memclk_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int mcu_hclk; > + unsigned int osc_clk; > +}; > + > +struct aw_watch_dog_desc { > + unsigned int reg; > + unsigned int mask; > +}; > + > +struct aw_dsp_mem_desc { > + unsigned int dsp_madd_reg; > + unsigned int dsp_mdat_reg; > + unsigned int dsp_fw_base_addr; > + unsigned int dsp_cfg_base_addr; > +}; > + > +struct aw_voltage_desc { > + unsigned int reg; > + unsigned int vbat_range; > + unsigned int int_bit; > +}; > + > +struct aw_temperature_desc { > + unsigned int reg; > + unsigned int sign_mask; > + unsigned int neg_mask; > +}; > + > +struct aw_ipeak_desc { > + unsigned int reg; > + unsigned int mask; > +}; > + > +struct aw_vmax_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int init_vmax; > +}; > + > +struct aw_soft_rst { > + uint8_t reg; > + uint16_t reg_value; > +}; > + > +struct aw_cali_cfg_desc { > + unsigned int actampth_reg; > + unsigned char actampth_data_type; > + > + unsigned int noiseampth_reg; > + unsigned char noiseampth_data_type; > + > + unsigned int ustepn_reg; > + unsigned char ustepn_data_type; > + > + unsigned int alphan_reg; > + unsigned int alphan_data_type; > +}; > + > +struct aw_dsp_vol_desc { > + unsigned int reg; > + unsigned int mute_st; > + unsigned int noise_st; > + unsigned int mask; > +}; > + > +struct aw_amppd_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int enable; > + unsigned int disable; > +}; > + > +struct aw_f0_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int shift; > +}; > + > +struct aw_cfgf0_fs_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > +}; > + > +struct aw_q_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int shift; > +}; > + > +struct aw_ra_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > +}; > + > +struct aw_noise_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int mask; > +}; > + > +struct aw_hw_mon_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int mask; > + unsigned int enable; > + unsigned int disable; > +}; > + > +struct aw_ste_re_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int shift; > +}; > + > +struct aw_adpz_re_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int shift; > +}; > + > +struct aw_adpz_t0_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + uint16_t coilalpha_reg; > + unsigned char coil_type; > +}; > + > +struct aw_spkr_temp_desc { > + unsigned int reg; > +}; > + > +struct aw_dsp_crc_desc { > + unsigned int ctl_reg; > + unsigned int ctl_mask; > + unsigned int ctl_enable; > + unsigned int ctl_disable; > + > + unsigned int dsp_reg; > + unsigned char data_type; > +}; > + > +struct aw_cco_mux_desc { > + unsigned int reg; > + unsigned int mask; > + unsigned int divider; > + unsigned int bypass; > +}; > + > +struct aw_hw_temp_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > +}; > + > +struct aw_re_range_desc { > + uint32_t re_min; > + uint32_t re_max; > + uint32_t re_min_default; > + uint32_t re_max_default; > +}; > + > +struct aw_cali_delay_desc { > + unsigned int dsp_reg; > + unsigned char data_type; > + unsigned int delay; > +}; > + > +struct aw_chansel_desc { > + unsigned int rxchan_reg; > + unsigned int rxchan_mask; > + unsigned int txchan_reg; > + unsigned int txchan_mask; > + > + unsigned int rx_left; > + unsigned int rx_right; > + unsigned int tx_left; > + unsigned int tx_right; > +}; > + > +struct aw_tx_en_desc { > + unsigned int tx_en_mask; > + unsigned int tx_disable; > +}; > + > +struct aw_dsp_st { > + unsigned int dsp_reg_s1; > + unsigned int dsp_reg_e1; > + > + unsigned int dsp_reg_s2; > + unsigned int dsp_reg_e2; > +}; > + > +struct aw_container { > + int len; > + uint8_t data[]; > +}; > + > +struct aw_device { > + int status; > + struct mutex *i2c_lock; > + > + unsigned char cur_prof; /*current profile index*/ > + unsigned char set_prof; /*set profile index*/ > + unsigned char dsp_crc_st; > + uint16_t chip_id; > + > + unsigned int channel; /*pa channel select*/ > + unsigned int fade_step; > + > + struct i2c_client *i2c; > + struct device *dev; > + char *acf; > + void *private_data; > + > + uint32_t fade_en; > + unsigned char dsp_cfg; > + > + uint32_t dsp_fw_len; > + uint32_t dsp_cfg_len; > + uint8_t platform; > + uint8_t fw_status; /*load cfg status*/ > + struct aw_prof_info prof_info; > + struct aw_sec_data_desc crc_dsp_cfg; > + > + struct aw_int_desc int_desc; > + struct aw_pwd_desc pwd_desc; > + struct aw_mute_desc mute_desc; > + struct aw_vcalb_desc vcalb_desc; > + struct aw_sysst_desc sysst_desc; > + struct aw_profctrl_desc profctrl_desc; > + struct aw_volume_desc volume_desc; > + struct aw_dsp_en_desc dsp_en_desc; > + struct aw_memclk_desc memclk_desc; > + struct aw_watch_dog_desc watch_dog_desc; > + struct aw_dsp_mem_desc dsp_mem_desc; > + struct aw_voltage_desc voltage_desc; > + struct aw_temperature_desc temp_desc; > + struct aw_vmax_desc vmax_desc; > + struct aw_ipeak_desc ipeak_desc; > + struct aw_soft_rst soft_rst; > + struct aw_cali_cfg_desc cali_cfg_desc; > + struct aw_ra_desc ra_desc; > + struct aw_dsp_vol_desc dsp_vol_desc; > + struct aw_noise_desc noise_desc; > + struct aw_f0_desc f0_desc; > + struct aw_cfgf0_fs_desc cfgf0_fs_desc; > + struct aw_q_desc q_desc; > + struct aw_hw_mon_desc hw_mon_desc; > + struct aw_ste_re_desc ste_re_desc; > + struct aw_adpz_re_desc adpz_re_desc; > + struct aw_adpz_t0_desc t0_desc; > + struct aw_amppd_desc amppd_desc; > + struct aw_spkr_temp_desc spkr_temp_desc; > + struct aw_dsp_crc_desc dsp_crc_desc; > + struct aw_cco_mux_desc cco_mux_desc; > + struct aw_hw_temp_desc hw_temp_desc; > + > + struct aw_cali_desc cali_desc; > + struct aw_monitor_desc monitor_desc; > + struct aw_re_range_desc re_range; > + struct aw_spin_desc spin_desc; > + struct aw_chansel_desc chansel_desc; > + struct aw_tx_en_desc tx_en_desc; > + struct aw_cali_delay_desc cali_delay_desc; > + struct aw_dsp_st dsp_st_desc; > + > + struct aw_device_ops ops; > + struct list_head list_node; > +}; > + > + > +void aw883xx_dev_deinit(struct aw_device *aw_dev); > +int aw883xx_device_init(struct aw_device *aw_dev, struct aw_container *aw_prof); > +int aw883xx_device_start(struct aw_device *aw_dev); > +int aw883xx_device_stop(struct aw_device *aw_dev); > + > +int aw883xx_dev_fw_update(struct aw_device *aw_dev, bool up_dsp_fw_en, bool force_up_en); > +int aw883xx_dev_get_int_status(struct aw_device *aw_dev, uint16_t *int_status); > +void aw883xx_dev_set_volume_step(struct aw_device *aw_dev, unsigned int step); > +int aw883xx_dev_set_intmask(struct aw_device *aw_dev, bool flag); > +void aw883xx_dev_clear_int_status(struct aw_device *aw_dev); > +int aw883xx_dev_get_volume_step(struct aw_device *aw_dev); > +int aw883xx_device_probe(struct aw_device *aw_dev); > +int aw883xx_device_remove(struct aw_device *aw_dev); > +int aw883xx_dev_syspll_check(struct aw_device *aw_dev); > +int aw883xx_dev_get_dsp_status(struct aw_device *aw_dev); > + > +void aw883xx_dev_set_fade_vol_step(struct aw_device *aw_dev, unsigned int step); > +int aw883xx_dev_get_fade_vol_step(struct aw_device *aw_dev); > +void aw883xx_dev_get_fade_time(unsigned int *time, bool fade_in); > +void aw883xx_dev_set_fade_time(unsigned int time, bool fade_in); > +int aw883xx_dev_get_hmute(struct aw_device *aw_dev); > +int aw883xx_dev_sysst_check(struct aw_device *aw_dev); > +int aw883xx_dev_get_list_head(struct list_head **head); > +int aw883xx_dev_dsp_check(struct aw_device *aw_dev); > +void aw883xx_dev_memclk_select(struct aw_device *aw_dev, unsigned char flag); > +void aw883xx_dev_dsp_enable(struct aw_device *aw_dev, bool dsp); > +void aw883xx_dev_mute(struct aw_device *aw_dev, bool mute); > +int aw883xx_dev_dsp_fw_update(struct aw_device *aw_dev, > + uint8_t *data, uint32_t len); > +int aw883xx_dev_dsp_cfg_update(struct aw_device *aw_dev, > + uint8_t *data, uint32_t len); > +int aw883xx_dev_modify_dsp_cfg(struct aw_device *aw_dev, > + unsigned int addr, uint32_t dsp_data, unsigned char data_type); > +int aw883xx_dev_get_iis_status(struct aw_device *aw_dev); > +int aw883xx_dev_set_volume(struct aw_device *aw_dev, uint16_t set_vol); > +int aw883xx_dev_get_volume(struct aw_device *aw_dev, uint16_t *get_vol); > + > +#endif > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_init.c b/sound/soc/codecs/aw883xx/aw883xx_init.c > new file mode 100644 > index 0000000..b34f92f > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_init.c > @@ -0,0 +1,649 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +/*#define DEBUG*/ > +#include <linux/module.h> > +#include <linux/i2c.h> > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/pcm_params.h> > +#include <sound/soc.h> > +#include <linux/of_gpio.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/firmware.h> > +#include <linux/version.h> > +#include <linux/workqueue.h> > +#include <linux/syscalls.h> > +#include <sound/control.h> > +#include <linux/uaccess.h> > +#include <linux/syscalls.h> > + > +#include "aw883xx.h" > +#include "aw883xx_bin_parse.h" > +#include "aw883xx_pid_2049_reg.h" > +#include "aw883xx_log.h" > + > +#define AW_FW_CHECK_PART (10) > + > + > +static int aw883xx_dev_i2c_writes(struct aw_device *aw_dev, > + uint8_t reg_addr, uint8_t *buf, uint16_t len) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_i2c_writes(aw883xx, reg_addr, buf, len); > +} > + > +static int aw883xx_dev_i2c_write(struct aw_device *aw_dev, > + uint8_t reg_addr, uint16_t reg_data) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_i2c_write(aw883xx, reg_addr, reg_data); > +} > + > +static int aw883xx_dev_i2c_read(struct aw_device *aw_dev, > + uint8_t reg_addr, uint16_t *reg_data) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_i2c_read(aw883xx, reg_addr, reg_data); > +} > + > + > +static int aw883xx_dev_reg_read(struct aw_device *aw_dev, > + uint8_t reg_addr, uint16_t *reg_data) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_reg_read(aw883xx, reg_addr, reg_data); > +} > + > +static int aw883xx_dev_reg_write(struct aw_device *aw_dev, > + uint8_t reg_addr, uint16_t reg_data) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_reg_write(aw883xx, reg_addr, reg_data); > +} > + > +static int aw883xx_dev_reg_write_bits(struct aw_device *aw_dev, > + uint8_t reg_addr, uint16_t mask, uint16_t reg_data) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_reg_write_bits(aw883xx, reg_addr, mask, reg_data); > +} > + > +static int aw883xx_dev_dsp_write(struct aw_device *aw_dev, > + uint16_t dsp_addr, uint32_t dsp_data, uint8_t data_type) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_dsp_write(aw883xx, dsp_addr, dsp_data, data_type); > +} > + > +static int aw883xx_dev_dsp_read(struct aw_device *aw_dev, > + uint16_t dsp_addr, uint32_t *dsp_data, uint8_t data_type) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_dsp_read(aw883xx, dsp_addr, dsp_data, data_type); > +} > + > + > +/* > + * aw883xx i2c write/read > + */ > +/*[9 : 6]: -6DB ; [5 : 0]: -0.125DB real_value = value * 8 : 0.125db --> 1*/ > +static unsigned int aw_pid_2049_reg_val_to_db(unsigned int value) > +{ > + return (((value >> AW_PID_2049_VOL_6DB_START) * AW_PID_2049_VOLUME_STEP_DB) + > + ((value & 0x3f) % AW_PID_2049_VOLUME_STEP_DB)); > +} > + > +/*[9 : 6]: -6DB ; [5 : 0]: -0.125DB reg_value = value / step << 6 + value % step ; step = 6 * 8*/ > +static uint16_t aw_pid_2049_db_val_to_reg(uint16_t value) > +{ > + return (((value / AW_PID_2049_VOLUME_STEP_DB) << AW_PID_2049_VOL_6DB_START) + > + (value % AW_PID_2049_VOLUME_STEP_DB)); > +} > + > +static int aw883xx_set_volume(struct aw883xx *aw883xx, uint16_t value) > +{ > + uint16_t reg_value = 0; > + uint16_t real_value = 0; > + uint16_t volume = 0; > + struct aw_volume_desc *vol_desc = &aw883xx->aw_pa->volume_desc; > + > + volume = AW_GET_MIN_VALUE(value, vol_desc->mute_volume); > + real_value = aw_pid_2049_db_val_to_reg(volume); > + > + /* cal real value */ > + aw883xx_reg_read(aw883xx, AW_PID_2049_SYSCTRL2_REG, &reg_value); > + > + aw_dev_dbg(aw883xx->dev, "value 0x%x , reg:0x%x", value, real_value); > + > + /*[15 : 6] volume*/ > + real_value = (real_value << AW_PID_2049_VOL_START_BIT) | (reg_value & AW_PID_2049_VOL_MASK); > + > + /* write value */ > + aw883xx_reg_write(aw883xx, AW_PID_2049_SYSCTRL2_REG, real_value); > + > + return 0; > +} > + > +static int aw883xx_get_volume(struct aw883xx *aw883xx, uint16_t *value) > +{ > + uint16_t reg_value = 0; > + uint16_t real_value = 0; > + > + /* read value */ > + aw883xx_reg_read(aw883xx, AW_PID_2049_SYSCTRL2_REG, &reg_value); > + > + /*[15 : 6] volume*/ > + real_value = reg_value >> AW_PID_2049_VOL_START_BIT; > + > + real_value = aw_pid_2049_reg_val_to_db(real_value); > + > + *value = real_value; > + > + return 0; > +} > + > +static int aw_pid_2049_set_volume(struct aw_device *aw_dev, uint16_t value) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_set_volume(aw883xx, value); > +} > + > +static int aw_pid_2049_get_volume(struct aw_device *aw_dev, uint16_t *value) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + return aw883xx_get_volume(aw883xx, value); > +} > + > +static void aw_pid_2049_i2s_tx_enable(struct aw_device *aw_dev, bool flag) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + aw_dev_dbg(aw883xx->dev, "enter"); > + > + if (flag) { > + aw883xx_reg_write_bits(aw883xx, AW_PID_2049_I2SCFG1_REG, > + AW_PID_2049_I2STXEN_MASK, > + AW_PID_2049_I2STXEN_ENABLE_VALUE); > + } else { > + aw883xx_reg_write_bits(aw883xx, AW_PID_2049_I2SCFG1_REG, > + AW_PID_2049_I2STXEN_MASK, > + AW_PID_2049_I2STXEN_DISABLE_VALUE); > + } > +} > + > +static void aw_pid_2049_set_cfg_f0_fs(struct aw_device *aw_dev, uint32_t *f0_fs) > +{ > + uint16_t rate_data = 0; > + uint32_t fs = 0; > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + aw_dev_dbg(aw883xx->dev, "enter"); > + aw883xx_reg_read(aw883xx, AW_PID_2049_I2SCTRL_REG, &rate_data); > + > + switch (rate_data & (~AW_PID_2049_I2SSR_MASK)) { > + case AW_PID_2049_I2SSR_8_KHZ_VALUE: > + fs = 8000; > + break; > + case AW_PID_2049_I2SSR_16_KHZ_VALUE: > + fs = 16000; > + break; > + case AW_PID_2049_I2SSR_32_KHZ_VALUE: > + fs = 32000; > + break; > + case AW_PID_2049_I2SSR_44_KHZ_VALUE: > + fs = 44000; > + break; > + case AW_PID_2049_I2SSR_48_KHZ_VALUE: > + fs = 48000; > + break; > + case AW_PID_2049_I2SSR_96_KHZ_VALUE: > + fs = 96000; > + break; > + case AW_PID_2049_I2SSR_192KHZ_VALUE: > + fs = 192000; > + break; > + default: > + fs = 48000; > + aw_dev_err(aw883xx->dev, > + "rate can not support, use default 48k"); > + break; > + } > + > + aw_dev_dbg(aw883xx->dev, "get i2s fs:%d", fs); > + *f0_fs = fs / 8; > + > + aw883xx_dsp_write(aw883xx, > + AW_PID_2049_DSP_REG_CFGF0_FS, *f0_fs, AW_DSP_32_DATA); > +} > + > +static bool aw_pid_2049_check_rd_access(int reg) > +{ > + if (reg >= AW_PID_2049_REG_MAX) > + return false; > + > + if (aw_pid_2049_reg_access[reg] & REG_RD_ACCESS) > + return true; > + else > + return false; > +} > + > +static bool aw_pid_2049_check_wr_access(int reg) > +{ > + if (reg >= AW_PID_2049_REG_MAX) > + return false; > + > + if (aw_pid_2049_reg_access[reg] & REG_WR_ACCESS) > + return true; > + else > + return false; > +} > + > +static int aw_pid_2049_get_reg_num(void) > +{ > + return AW_PID_2049_REG_MAX; > +} > + > +static int aw_pid_2049_get_hw_mon_st(struct aw_device *aw_dev, > + bool *is_enable, uint8_t *temp_flag) > +{ > + int ret = 0; > + uint32_t vbat_en = 0; > + uint32_t temp_en = 0; > + uint32_t temp_switch = 0; > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + ret = aw883xx_dsp_read(aw883xx, > + AW_PID_2049_DSP_REG_CFG_MBMEC_GLBCFG, &vbat_en, AW_DSP_16_DATA); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "read hardware monitor status failed"); > + return ret; > + } > + > + ret = aw883xx_dsp_read(aw883xx, > + AW_PID_2049_DSP_REG_TEMP_SWITCH, &temp_en, AW_DSP_16_DATA); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "read hardware temp switch failed"); > + return ret; > + } > + > + temp_switch = temp_en; > + vbat_en &= (~AW_PID_2049_DSP_MONITOR_MASK); > + temp_en &= (~AW_PID_2049_DSP_TEMP_PEAK_MASK); > + temp_switch &= (~AW_PID_2049_DSP_TEMP_SEL_FLAG); > + > + if (vbat_en || temp_en) > + *is_enable = true; > + else > + *is_enable = false; > + > + if (temp_switch) > + *temp_flag = AW_EXTERNAL_TEMP; > + else > + *temp_flag = AW_INTERNAL_TEMP; > + > + return 0; > +} > + > +static int aw_pid_2049_cali_get_iv_st(struct aw_device *aw_dev) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + int ret; > + uint16_t reg_data = 0; > + int i; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + for (i = 0; i < AW_GET_IV_CNT_MAX; i++) { > + ret = aw883xx_reg_read(aw883xx, AW_PID_2049_ASR1_REG, &reg_data); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, > + "read 0x%x failed", AW_PID_2049_ASR1_REG); > + return ret; > + } > + > + reg_data &= (~AW_PID_2049_ReAbs_MASK); > + if (!reg_data) > + return 0; > + msleep(30); > + } > + > + aw_dev_err(aw883xx->dev, "IV data abnormal, please check"); > + > + return -EINVAL; > +} > + > +static int aw_pid_2049_dsp_fw_check(struct aw_device *aw_dev) > +{ > + struct aw_prof_desc *set_prof_desc = NULL; > + struct aw_sec_data_desc *dsp_fw_desc = NULL; > + uint16_t base_addr = AW_PID_2049_DSP_FW_ADDR; > + uint16_t addr = base_addr; > + int ret, i; > + uint32_t dsp_val; > + uint16_t bin_val; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + ret = aw883xx_dev_get_prof_data(aw_dev, aw_dev->cur_prof, &set_prof_desc); > + if (ret < 0) > + return ret; > + > + /*update reg*/ > + dsp_fw_desc = &set_prof_desc->sec_desc[AW_DATA_TYPE_DSP_FW]; > + > + for (i = 0; i < AW_FW_CHECK_PART; i++) { > + ret = aw883xx_dev_dsp_read(aw_dev, addr, &dsp_val, AW_DSP_16_DATA); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp read failed"); > + return ret; > + } > + > + bin_val = AW_GET_16_DATA(dsp_fw_desc->data[2 * (addr - base_addr)], > + dsp_fw_desc->data[2 * (addr - base_addr) + 1]); > + > + if (dsp_val != bin_val) { > + aw_dev_err(aw_dev->dev, "check failed, addr[0x%x], read[0x%x] != bindata[0x%x]", > + addr, dsp_val, bin_val); > + return -EINVAL; > + } > + > + addr += (dsp_fw_desc->len / 2) / AW_FW_CHECK_PART; > + if ((addr - base_addr) > dsp_fw_desc->len) { > + aw_dev_err(aw_dev->dev, "check failed, addr[0x%x] too large", addr); > + return -EINVAL; > + } > + } > + > + aw_dev_info(aw_dev->dev, "dsp fw check success"); > + > + return 0; > +} > + > +static int aw883xx_dev_init(struct aw883xx *aw883xx) > +{ > + struct aw_device *aw_pa = NULL; > + > + aw_pa = devm_kzalloc(aw883xx->dev, sizeof(struct aw_device), GFP_KERNEL); > + if (aw_pa == NULL) > + return -ENOMEM; > + > + /*call aw device init func*/ > + aw_pa->acf = NULL; > + aw_pa->prof_info.prof_desc = NULL; > + aw_pa->prof_info.count = 0; > + aw_pa->prof_info.prof_type = AW_DEV_NONE_TYPE_ID; > + aw_pa->channel = 0; > + aw_pa->i2c_lock = &aw883xx->i2c_lock; > + aw_pa->i2c = aw883xx->i2c; > + aw_pa->fw_status = AW_DEV_FW_FAILED; > + aw_pa->fade_step = AW_PID_2049_VOLUME_STEP_DB; > + aw_pa->re_range.re_min_default = AW_RE_MIN; > + aw_pa->re_range.re_max_default = AW_RE_MAX; > + aw_pa->monitor_desc.hw_monitor_delay = AW_HW_MONITOR_DELAY; > + > + aw_pa->chip_id = aw883xx->chip_id; > + aw_pa->private_data = (void *)aw883xx; > + aw_pa->dev = aw883xx->dev; > + aw_pa->ops.aw_get_version = aw883xx_get_version; > + aw_pa->ops.aw_i2c_writes = aw883xx_dev_i2c_writes; > + aw_pa->ops.aw_i2c_write = aw883xx_dev_i2c_write; > + aw_pa->ops.aw_reg_write = aw883xx_dev_reg_write; > + aw_pa->ops.aw_reg_write_bits = aw883xx_dev_reg_write_bits; > + aw_pa->ops.aw_i2c_read = aw883xx_dev_i2c_read; > + aw_pa->ops.aw_reg_read = aw883xx_dev_reg_read; > + aw_pa->ops.aw_dsp_read = aw883xx_dev_dsp_read; > + aw_pa->ops.aw_dsp_write = aw883xx_dev_dsp_write; > + aw_pa->ops.aw_get_dev_num = aw883xx_get_dev_num; > + > + aw_pa->ops.aw_get_hw_volume = aw_pid_2049_get_volume; > + aw_pa->ops.aw_set_hw_volume = aw_pid_2049_set_volume; > + aw_pa->ops.aw_reg_val_to_db = aw_pid_2049_reg_val_to_db; > + > + aw_pa->ops.aw_check_rd_access = aw_pid_2049_check_rd_access; > + aw_pa->ops.aw_check_wr_access = aw_pid_2049_check_wr_access; > + aw_pa->ops.aw_get_reg_num = aw_pid_2049_get_reg_num; > + > + aw_pa->ops.aw_i2s_tx_enable = aw_pid_2049_i2s_tx_enable; > + aw_pa->ops.aw_get_hw_mon_st = aw_pid_2049_get_hw_mon_st; > + > + aw_pa->ops.aw_cali_svc_get_iv_st = aw_pid_2049_cali_get_iv_st; > + aw_pa->ops.aw_set_cfg_f0_fs = aw_pid_2049_set_cfg_f0_fs; > + aw_pa->ops.aw_dsp_fw_check = aw_pid_2049_dsp_fw_check; > + > + aw_pa->int_desc.mask_reg = AW_PID_2049_SYSINTM_REG; > + aw_pa->int_desc.mask_default = AW_PID_2049_SYSINTM_DEFAULT; > + aw_pa->int_desc.int_mask = AW_PID_2049_SYSINTM_DEFAULT; > + aw_pa->int_desc.st_reg = AW_PID_2049_SYSINT_REG; > + aw_pa->int_desc.intst_mask = AW_PID_2049_BIT_SYSINT_CHECK; > + > + aw_pa->pwd_desc.reg = AW_PID_2049_SYSCTRL_REG; > + aw_pa->pwd_desc.mask = AW_PID_2049_PWDN_MASK; > + aw_pa->pwd_desc.enable = AW_PID_2049_PWDN_POWER_DOWN_VALUE; > + aw_pa->pwd_desc.disable = AW_PID_2049_PWDN_WORKING_VALUE; > + > + aw_pa->mute_desc.reg = AW_PID_2049_SYSCTRL_REG; > + aw_pa->mute_desc.mask = AW_PID_2049_HMUTE_MASK; > + aw_pa->mute_desc.enable = AW_PID_2049_HMUTE_ENABLE_VALUE; > + aw_pa->mute_desc.disable = AW_PID_2049_HMUTE_DISABLE_VALUE; > + > + aw_pa->vcalb_desc.vcalb_dsp_reg = AW_PID_2049_DSP_REG_VCALB; > + aw_pa->vcalb_desc.data_type = AW_DSP_16_DATA; > + aw_pa->vcalb_desc.vcal_factor = AW_PID_2049_VCAL_FACTOR; > + aw_pa->vcalb_desc.cabl_base_value = AW_PID_2049_CABL_BASE_VALUE; > + aw_pa->vcalb_desc.vscal_factor = AW_PID_2049_VSCAL_FACTOR; > + aw_pa->vcalb_desc.iscal_factor = AW_PID_2049_ISCAL_FACTOR; > + > + aw_pa->vcalb_desc.vcalb_adj_shift = AW_PID_2049_VCALB_ADJ_FACTOR; > + > + aw_pa->vcalb_desc.icalk_value_factor = AW_PID_2049_ICABLK_FACTOR; > + aw_pa->vcalb_desc.icalk_reg = AW_PID_2049_EFRM2_REG; > + aw_pa->vcalb_desc.icalk_reg_mask = AW_PID_2049_EF_ISN_GESLP_MASK; > + aw_pa->vcalb_desc.icalk_sign_mask = AW_PID_2049_EF_ISN_GESLP_SIGN_MASK; > + aw_pa->vcalb_desc.icalk_neg_mask = AW_PID_2049_EF_ISN_GESLP_SIGN_NEG; > + > + aw_pa->vcalb_desc.vcalk_reg = AW_PID_2049_EFRH_REG; > + aw_pa->vcalb_desc.vcalk_reg_mask = AW_PID_2049_EF_VSN_GESLP_MASK; > + aw_pa->vcalb_desc.vcalk_sign_mask = AW_PID_2049_EF_VSN_GESLP_SIGN_MASK; > + aw_pa->vcalb_desc.vcalk_neg_mask = AW_PID_2049_EF_VSN_GESLP_SIGN_NEG; > + aw_pa->vcalb_desc.vcalk_value_factor = AW_PID_2049_VCABLK_FACTOR; > + aw_pa->vcalb_desc.vcalk_shift = AW_PID_2049_EF_VSENSE_GAIN_SHIFT; > + > + aw_pa->vcalb_desc.vcalb_vsense_reg = AW_PID_2049_I2SCFG3_REG; > + aw_pa->vcalb_desc.vcalk_vdsel_mask = AW_PID_2049_VDSEL_MASK; > + aw_pa->vcalb_desc.vcalk_value_factor_vsense_in = AW_PID_2049_VCABLK_FACTOR_DAC; > + aw_pa->vcalb_desc.vscal_factor_vsense_in = AW_PID_2049_VSCAL_FACTOR_DAC; > + aw_pa->vcalb_desc.vcalk_dac_shift = AW_PID_2049_EF_DAC_GESLP_SHIFT; > + aw_pa->vcalb_desc.vcalk_dac_mask = AW_PID_2049_EF_DAC_GESLP_SIGN_MASK; > + aw_pa->vcalb_desc.vcalk_dac_neg_mask = AW_PID_2049_EF_DAC_GESLP_SIGN_NEG; > + > + aw_pa->sysst_desc.reg = AW_PID_2049_SYSST_REG; > + aw_pa->sysst_desc.st_check = AW_PID_2049_BIT_SYSST_CHECK; > + aw_pa->sysst_desc.st_mask = AW_PID_2049_BIT_SYSST_CHECK_MASK; > + aw_pa->sysst_desc.pll_check = AW_PID_2049_BIT_PLL_CHECK; > + aw_pa->sysst_desc.dsp_check = AW_PID_2049_DSPS_NORMAL_VALUE; > + aw_pa->sysst_desc.dsp_mask = AW_PID_2049_DSPS_MASK; > + > + aw_pa->profctrl_desc.reg = AW_PID_2049_SYSCTRL_REG; > + aw_pa->profctrl_desc.mask = AW_PID_2049_RCV_MODE_MASK; > + aw_pa->profctrl_desc.rcv_mode_val = AW_PID_2049_RCV_MODE_RECEIVER_VALUE; > + > + aw_pa->volume_desc.reg = AW_PID_2049_SYSCTRL2_REG; > + aw_pa->volume_desc.mask = AW_PID_2049_VOL_MASK; > + aw_pa->volume_desc.shift = AW_PID_2049_VOL_START_BIT; > + aw_pa->volume_desc.mute_volume = AW_PID_2049_MUTE_VOL; > + aw_pa->volume_desc.max_volume = AW_PID_2049_VOL_DEFAULT_VALUE; > + aw_pa->volume_desc.ctl_volume = AW_PID_2049_VOL_DEFAULT_VALUE; > + > + aw_pa->dsp_en_desc.reg = AW_PID_2049_SYSCTRL_REG; > + aw_pa->dsp_en_desc.mask = AW_PID_2049_DSPBY_MASK; > + aw_pa->dsp_en_desc.enable = AW_PID_2049_DSPBY_WORKING_VALUE; > + aw_pa->dsp_en_desc.disable = AW_PID_2049_DSPBY_BYPASS_VALUE; > + > + aw_pa->memclk_desc.reg = AW_PID_2049_DBGCTRL_REG; > + aw_pa->memclk_desc.mask = AW_PID_2049_MEM_CLKSEL_MASK; > + aw_pa->memclk_desc.mcu_hclk = AW_PID_2049_MEM_CLKSEL_DAP_HCLK_VALUE; > + aw_pa->memclk_desc.osc_clk = AW_PID_2049_MEM_CLKSEL_OSC_CLK_VALUE; > + > + aw_pa->watch_dog_desc.reg = AW_PID_2049_WDT_REG; > + aw_pa->watch_dog_desc.mask = AW_PID_2049_WDT_CNT_MASK; > + > + aw_pa->dsp_mem_desc.dsp_madd_reg = AW_PID_2049_DSPMADD_REG; > + aw_pa->dsp_mem_desc.dsp_mdat_reg = AW_PID_2049_DSPMDAT_REG; > + aw_pa->dsp_mem_desc.dsp_cfg_base_addr = AW_PID_2049_DSP_CFG_ADDR; > + aw_pa->dsp_mem_desc.dsp_fw_base_addr = AW_PID_2049_DSP_FW_ADDR; > + > + aw_pa->voltage_desc.reg = AW_PID_2049_VBAT_REG; > + aw_pa->voltage_desc.vbat_range = AW_PID_2049_VBAT_RANGE; > + aw_pa->voltage_desc.int_bit = AW_PID_2049_INT_10BIT; > + > + aw_pa->temp_desc.reg = AW_PID_2049_TEMP_REG; > + aw_pa->temp_desc.sign_mask = AW_PID_2049_TEMP_SIGN_MASK; > + aw_pa->temp_desc.neg_mask = AW_PID_2049_TEMP_NEG_MASK; > + > + aw_pa->vmax_desc.dsp_reg = AW_PID_2049_DSP_REG_VMAX; > + aw_pa->vmax_desc.data_type = AW_DSP_16_DATA; > + > + aw_pa->ipeak_desc.reg = AW_PID_2049_SYSCTRL2_REG; > + aw_pa->ipeak_desc.mask = AW_PID_2049_BST_IPEAK_MASK; > + > + aw_pa->soft_rst.reg = AW_PID_2049_ID_REG; > + aw_pa->soft_rst.reg_value = AW_PID_2049_SOFT_RESET_VALUE; > + > + aw_pa->dsp_vol_desc.reg = AW_PID_2049_DSPCFG_REG; > + aw_pa->dsp_vol_desc.mask = AW_PID_2049_DSP_VOL_MASK; > + aw_pa->dsp_vol_desc.mute_st = AW_PID_2049_DSP_VOL_MUTE; > + aw_pa->dsp_vol_desc.noise_st = AW_PID_2049_DSP_VOL_NOISE_ST; > + > + aw_pa->amppd_desc.reg = AW_PID_2049_SYSCTRL_REG; > + aw_pa->amppd_desc.mask = AW_PID_2049_AMPPD_MASK; > + aw_pa->amppd_desc.enable = AW_PID_2049_AMPPD_POWER_DOWN_VALUE; > + aw_pa->amppd_desc.disable = AW_PID_2049_AMPPD_WORKING_VALUE; > + > + aw_pa->spkr_temp_desc.reg = AW_PID_2049_ASR2_REG; > + > + /*32-bit data types need bypass dsp*/ > + aw_pa->ra_desc.dsp_reg = AW_PID_2049_DSP_REG_CFG_ADPZ_RA; > + aw_pa->ra_desc.data_type = AW_DSP_32_DATA; > + > + /*32-bit data types need bypass dsp*/ > + aw_pa->cali_cfg_desc.actampth_reg = AW_PID_2049_DSP_REG_CFG_MBMEC_ACTAMPTH; > + aw_pa->cali_cfg_desc.actampth_data_type = AW_DSP_32_DATA; > + > + /*32-bit data types need bypass dsp*/ > + aw_pa->cali_cfg_desc.noiseampth_reg = AW_PID_2049_DSP_REG_CFG_MBMEC_NOISEAMPTH; > + aw_pa->cali_cfg_desc.noiseampth_data_type = AW_DSP_32_DATA; > + > + aw_pa->cali_cfg_desc.ustepn_reg = AW_PID_2049_DSP_REG_CFG_ADPZ_USTEPN; > + aw_pa->cali_cfg_desc.ustepn_data_type = AW_DSP_16_DATA; > + > + aw_pa->cali_cfg_desc.alphan_reg = AW_PID_2049_DSP_REG_CFG_RE_ALPHA; > + aw_pa->cali_cfg_desc.alphan_data_type = AW_DSP_16_DATA; > + > + /*32-bit data types need bypass dsp*/ > + aw_pa->adpz_re_desc.dsp_reg = AW_PID_2049_DSP_REG_CFG_ADPZ_RE; > + aw_pa->adpz_re_desc.data_type = AW_DSP_32_DATA; > + aw_pa->adpz_re_desc.shift = AW_PID_2049_DSP_RE_SHIFT; > + > + aw_pa->t0_desc.dsp_reg = AW_PID_2049_DSP_CFG_ADPZ_T0; > + aw_pa->t0_desc.data_type = AW_DSP_16_DATA; > + aw_pa->t0_desc.coilalpha_reg = AW_PID_2049_DSP_CFG_ADPZ_COILALPHA; > + aw_pa->t0_desc.coil_type = AW_DSP_16_DATA; > + > + aw_pa->ste_re_desc.shift = AW_PID_2049_DSP_REG_CALRE_SHIFT; > + aw_pa->ste_re_desc.dsp_reg = AW_PID_2049_DSP_REG_CALRE; > + aw_pa->ste_re_desc.data_type = AW_DSP_16_DATA; > + > + aw_pa->noise_desc.dsp_reg = AW_PID_2049_DSP_REG_CFG_MBMEC_GLBCFG; > + aw_pa->noise_desc.data_type = AW_DSP_16_DATA; > + aw_pa->noise_desc.mask = AW_PID_2049_DSP_REG_NOISE_MASK; > + > + aw_pa->f0_desc.dsp_reg = AW_PID_2049_DSP_REG_RESULT_F0; > + aw_pa->f0_desc.shift = AW_PID_2049_DSP_F0_SHIFT; > + aw_pa->f0_desc.data_type = AW_DSP_16_DATA; > + > + /*32-bit data types need bypass dsp*/ > + aw_pa->cfgf0_fs_desc.dsp_reg = AW_PID_2049_DSP_REG_CFGF0_FS; > + aw_pa->cfgf0_fs_desc.data_type = AW_DSP_32_DATA; > + > + aw_pa->q_desc.dsp_reg = AW_PID_2049_DSP_REG_RESULT_Q; > + aw_pa->q_desc.shift = AW_PID_2049_DSP_Q_SHIFT; > + aw_pa->q_desc.data_type = AW_DSP_16_DATA; > + > + /*32-bit data types need bypass dsp*/ > + aw_pa->dsp_crc_desc.dsp_reg = AW_PID_2049_DSP_REG_CRC_ADDR; > + aw_pa->dsp_crc_desc.data_type = AW_DSP_32_DATA; > + > + aw_pa->dsp_crc_desc.ctl_reg = AW_PID_2049_HAGCCFG7_REG; > + aw_pa->dsp_crc_desc.ctl_mask = AW_PID_2049_AGC_DSP_CTL_MASK; > + aw_pa->dsp_crc_desc.ctl_enable = AW_PID_2049_AGC_DSP_CTL_ENABLE_VALUE; > + aw_pa->dsp_crc_desc.ctl_disable = AW_PID_2049_AGC_DSP_CTL_DISABLE_VALUE; > + > + aw_pa->cco_mux_desc.reg = AW_PID_2049_PLLCTRL1_REG; > + aw_pa->cco_mux_desc.mask = AW_PID_2049_CCO_MUX_MASK; > + aw_pa->cco_mux_desc.divider = AW_PID_2049_CCO_MUX_DIVIDED_VALUE; > + aw_pa->cco_mux_desc.bypass = AW_PID_2049_CCO_MUX_BYPASS_VALUE; > + > + /*hw monitor temp reg*/ > + aw_pa->hw_temp_desc.dsp_reg = AW_PID_2049_DSP_REG_TEMP_ADDR; > + aw_pa->hw_temp_desc.data_type = AW_DSP_16_DATA; > + > + aw_pa->chansel_desc.rxchan_reg = AW_PID_2049_I2SCTRL_REG; > + aw_pa->chansel_desc.rxchan_mask = AW_PID_2049_CHSEL_MASK; > + aw_pa->chansel_desc.txchan_reg = AW_PID_2049_I2SCFG1_REG; > + aw_pa->chansel_desc.txchan_mask = AW_PID_2049_I2SCHS_MASK; > + > + aw_pa->chansel_desc.rx_left = AW_PID_2049_CHSEL_LEFT_VALUE; > + aw_pa->chansel_desc.rx_right = AW_PID_2049_CHSEL_RIGHT_VALUE; > + aw_pa->chansel_desc.tx_left = AW_PID_2049_I2SCHS_LEFT_VALUE; > + aw_pa->chansel_desc.tx_right = AW_PID_2049_I2SCHS_RIGHT_VALUE; > + > + aw_pa->tx_en_desc.tx_en_mask = AW_PID_2049_I2STXEN_MASK; > + aw_pa->tx_en_desc.tx_disable = AW_PID_2049_I2STXEN_DISABLE_VALUE; > + > + aw_pa->cali_delay_desc.dsp_reg = AW_PID_2049_DSP_CALI_F0_DELAY; > + aw_pa->cali_delay_desc.data_type = AW_DSP_16_DATA; > + > + aw_pa->dsp_st_desc.dsp_reg_s1 = AW_PID_2049_DSP_ST_S1; > + aw_pa->dsp_st_desc.dsp_reg_e1 = AW_PID_2049_DSP_ST_E1; > + aw_pa->dsp_st_desc.dsp_reg_s2 = AW_PID_2049_DSP_ST_S2; > + aw_pa->dsp_st_desc.dsp_reg_e2 = AW_PID_2049_DSP_ST_E2; > + > + aw883xx_device_probe(aw_pa); > + > + aw883xx->aw_pa = aw_pa; > + > + return 0; > +} > + > +int aw883xx_init(struct aw883xx *aw883xx) > +{ > + int ret = 0; > + > + if (aw883xx->chip_id == AW883XX_PID_2049) { > + ret = aw883xx_dev_init(aw883xx); > + } else { > + aw_dev_err(aw883xx->dev, "unsupported device"); > + return -EINVAL; > + } > + > + return ret; > +} > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_log.h b/sound/soc/codecs/aw883xx/aw883xx_log.h > new file mode 100644 > index 0000000..1667f43 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_log.h > @@ -0,0 +1,32 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_LOG_H__ > +#define __AW883XX_LOG_H__ > + > +/* > + * print information control > + */ > +#define aw_dev_err(dev, format, ...) \ > + pr_err("[Awinic][%s]%s: " format "\n", dev_name(dev), __func__, ##__VA_ARGS__) > +#define aw_dev_info(dev, format, ...) \ > + pr_info("[Awinic][%s]%s: " format "\n", dev_name(dev), __func__, ##__VA_ARGS__) > +#define aw_dev_dbg(dev, format, ...) \ > + pr_debug("[Awinic][%s]%s: " format "\n", dev_name(dev), __func__, ##__VA_ARGS__) > + > +#define aw_pr_err(format, ...) \ > + pr_err("[Awinic]%s: " format "\n", __func__, ##__VA_ARGS__) > +#define aw_pr_info(format, ...) \ > + pr_info("[Awinic]%s: " format "\n", __func__, ##__VA_ARGS__) > +#define aw_pr_dbg(format, ...) \ > + pr_debug("[Awinic]%s: " format "\n", __func__, ##__VA_ARGS__) > + > + > +#endif > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_monitor.c b/sound/soc/codecs/aw883xx/aw883xx_monitor.c > new file mode 100644 > index 0000000..1897d40 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_monitor.c > @@ -0,0 +1,1197 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * awinic_monitor.c monitor_module > + * > + * Copyright (c) 2019 AWINIC Technology CO., LTD > + * > + * Author: Nick Li <liweilei(a)awinic.com.cn> > + */ > + > +#include <linux/module.h> > +#include <linux/i2c.h> > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/pcm_params.h> > +#include <sound/soc.h> > +#include <linux/of_gpio.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/firmware.h> > +#include <linux/of.h> > +#include <linux/version.h> > +#include <linux/input.h> > +#include <linux/timer.h> > +#include <linux/workqueue.h> > +#include <linux/hrtimer.h> > +#include <linux/power_supply.h> > +#include "aw883xx_monitor.h" > +#include "aw883xx_log.h" > +#include "aw883xx_device.h" > +#include "aw883xx.h" > +#include "aw883xx_calib.h" > + > + > +#define AW883XX_MONITOR_NAME "aw883xx_monitor.bin" > + > +/* > + * device monitor > + */ > + #ifndef AW_SYS_BATTERY_ST > +static int aw_monitor_get_chip_voltage(struct aw_device *aw_dev, > + unsigned int *vol) > +{ > + int ret = -1; > + uint16_t local_vol = 0; > + struct aw_voltage_desc *desc = &aw_dev->voltage_desc; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->reg, (uint16_t *)vol); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read voltage failed!"); > + return ret; > + } > + > + if (desc->int_bit == 0) { > + aw_dev_err(aw_dev->dev, "desc->int_bit:%d unsupported", desc->int_bit); > + return -EINVAL; > + } > + > + local_vol = ((*vol) * desc->vbat_range) / desc->int_bit; > + > + *vol = local_vol; > + > + aw_dev_info(aw_dev->dev, "chip voltage is %d", *vol); > + > + return 0; > +} > + > +static int aw_monitor_get_chip_temperature(struct aw_device *aw_dev, int *temp) > +{ > + int ret = -1; > + uint16_t reg_val = 0; > + uint16_t local_temp; > + struct aw_temperature_desc *desc = &aw_dev->temp_desc; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get temperature failed!"); > + return ret; > + } > + > + local_temp = reg_val; > + > + if (local_temp & (~desc->sign_mask)) > + local_temp = local_temp | desc->neg_mask; > + > + *temp = (int)((int16_t)local_temp); > + > + aw_dev_info(aw_dev->dev, "chip temperature = %d", *temp); > + return 0; > +} > +#endif > + > +static int aw_monitor_get_battery_state(struct aw_device *aw_dev, > + int *data, int data_type) > +{ > + char name[] = "battery"; > + int ret = -1; > + union power_supply_propval prop = { 0 }; > + struct power_supply *psy = NULL; > + > + psy = power_supply_get_by_name(name); > + if (psy) { > + ret = power_supply_get_property(psy, data_type, &prop); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get data failed"); > + return -EINVAL; > + } > + *data = prop.intval; > + aw_dev_dbg(aw_dev->dev, "get system data: %d", *data); > + } else { > + aw_dev_err(aw_dev->dev, "no struct power supply name : %s", name); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int aw_monitor_get_system_temperature(struct aw_device *aw_dev, int *temp) > +{ > + int ret = -1; > + int sys_temp; > + > + ret = aw_monitor_get_battery_state(aw_dev, &sys_temp, POWER_SUPPLY_PROP_TEMP); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get system temperature failed!"); > + return ret; > + } > + > + *temp = sys_temp / 10; > + aw_dev_dbg(aw_dev->dev, "system temperature = %d", *temp); > + > + return ret; > +} > + > +static int aw_monitor_set_system_temperature(struct aw_device *aw_dev, int sys_temp) > +{ > + int ret = -1; > + struct aw_hw_temp_desc *hw_temp_desc = &aw_dev->hw_temp_desc; > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, hw_temp_desc->dsp_reg, > + sys_temp, hw_temp_desc->data_type); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "set system temperature failed!"); > + return ret; > + } > + > + return ret; > +} > + > +#ifdef AW_SYS_BATTERY_ST > +static int aw_monitor_get_system_voltage(struct aw_device *aw_dev, unsigned int *vol) > +{ > + int ret = -1; > + unsigned int sys_vol; > + > + ret = aw_monitor_get_battery_state(aw_dev, &sys_vol, POWER_SUPPLY_PROP_VOLTAGE_NOW); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get system voltage failed!"); > + return ret; > + } > + > + *vol = sys_vol / 1000; > + aw_dev_dbg(aw_dev->dev, "system voltage = %d", *vol); > + > + return ret; > +} > +#endif > + > +static int aw_monitor_get_temperature(struct aw_device *aw_dev, int *temp) > +{ > +#ifdef AW_SYS_BATTERY_ST > + return aw_monitor_get_system_temperature(aw_dev, temp); > +#else > + return aw_monitor_get_chip_temperature(aw_dev, temp); > +#endif > +} > + > +static int aw_monitor_get_voltage(struct aw_device *aw_dev, unsigned int *vol) > +{ > +#ifdef AW_SYS_BATTERY_ST > + return aw_monitor_get_system_voltage(aw_dev, vol); > +#else > + return aw_monitor_get_chip_voltage(aw_dev, vol); > +#endif > +} > + > +static int aw_monitor_get_temp_and_vol(struct aw_device *aw_dev) > +{ > + struct aw_monitor_desc *monitor = &aw_dev->monitor_desc; > + unsigned int voltage = 0; > + int current_temp = 0; > + int ret = -1; > + > +#ifdef AW_DEBUG > + if (monitor->test_vol == 0) { > + ret = aw_monitor_get_voltage(aw_dev, &voltage); > + if (ret < 0) > + return ret; > + } else { > + voltage = monitor->test_vol; > + } > + > + if (monitor->test_temp == 0) { > + ret = aw_monitor_get_temperature(aw_dev, &current_temp); > + if (ret < 0) > + return ret; > + } else { > + current_temp = monitor->test_temp; > + } > +#else > + ret = aw_monitor_get_voltage(aw_dev, &voltage); > + if (ret < 0) > + return ret; > + > + ret = aw_monitor_get_temperature(aw_dev, &current_temp); > + if (ret < 0) > + return ret; > +#endif > + > + monitor->vol_trace.sum_val += voltage; > + monitor->temp_trace.sum_val += current_temp; > + monitor->samp_count++; > + > + return 0; > +} > + > +static int aw_monitor_first_get_data_form_table(struct aw_device *aw_dev, > + struct aw_table_info table_info, > + struct aw_monitor_trace *data_trace) > +{ > + int i; > + > + if (table_info.aw_table == NULL) { > + aw_dev_err(aw_dev->dev, "table_info.aw_table is null"); > + return -EINVAL; > + } > + > + for (i = 0; i < table_info.table_num; i++) { > + if (data_trace->sum_val >= table_info.aw_table[i].min_val) { > + memcpy(&data_trace->aw_table, &table_info.aw_table[i], > + sizeof(struct aw_table)); > + break; > + } > + } > + return 0; > +} > + > +static int aw_monitor_trace_data_from_table(struct aw_device *aw_dev, > + struct aw_table_info table_info, > + struct aw_monitor_trace *data_trace) > +{ > + int i; > + > + if (table_info.aw_table == NULL) { > + aw_dev_err(aw_dev->dev, "table_info.aw_table is null"); > + return -EINVAL; > + } > + > + for (i = 0; i < table_info.table_num; i++) { > + if (data_trace->sum_val >= table_info.aw_table[i].min_val && > + data_trace->sum_val <= table_info.aw_table[i].max_val) { > + memcpy(&data_trace->aw_table, &table_info.aw_table[i], > + sizeof(struct aw_table)); > + break; > + } > + } > + > + return 0; > +} > + > +static int aw_monitor_get_data_from_table(struct aw_device *aw_dev, > + struct aw_table_info table_info, > + struct aw_monitor_trace *data_trace, > + uint32_t aplha) > +{ > + struct aw_monitor_desc *monitor = &aw_dev->monitor_desc; > + > + if (monitor->first_entry == AW_FIRST_ENTRY) { > + return aw_monitor_first_get_data_form_table(aw_dev, > + table_info, data_trace); > + } else { > + if (monitor->samp_count == 0) { > + aw_dev_err(aw_dev->dev, "monitor->samp_count:%d unsupported", > + monitor->samp_count); > + return -EINVAL; > + } > + > + data_trace->sum_val = data_trace->sum_val / monitor->samp_count; > + data_trace->sum_val = ((int32_t)aplha * data_trace->sum_val + > + (1000 - (int32_t)aplha) * data_trace->pre_val) / 1000; > + return aw_monitor_trace_data_from_table(aw_dev, > + table_info, data_trace); > + } > + > + return 0; > +} > + > +static int aw_monitor_get_data(struct aw_device *aw_dev) > +{ > + struct aw_monitor_desc *monitor = &aw_dev->monitor_desc; > + struct aw_monitor_cfg *monitor_cfg = &monitor->monitor_cfg; > + struct aw_monitor_trace *vol_trace = &monitor->vol_trace; > + struct aw_monitor_trace *temp_trace = &monitor->temp_trace; > + int ret; > + > + if (monitor_cfg->vol_switch) { > + ret = aw_monitor_get_data_from_table(aw_dev, > + monitor_cfg->vol_info, vol_trace, > + monitor_cfg->vol_aplha); > + if (ret < 0) > + return ret; > + } else { > + vol_trace->aw_table.ipeak = IPEAK_NONE; > + vol_trace->aw_table.gain = GAIN_NONE; > + vol_trace->aw_table.vmax = VMAX_NONE; > + } > + > + if (monitor_cfg->temp_switch) { > + ret = aw_monitor_get_data_from_table(aw_dev, > + monitor_cfg->temp_info, temp_trace, > + monitor_cfg->temp_aplha); > + if (ret < 0) > + return ret; > + } else { > + temp_trace->aw_table.ipeak = IPEAK_NONE; > + temp_trace->aw_table.gain = GAIN_NONE; > + temp_trace->aw_table.vmax = VMAX_NONE; > + } > + > + aw_dev_dbg(aw_dev->dev, > + "filter_vol:%d, vol: ipeak = 0x%x, gain = 0x%x, vmax = 0x%x", > + monitor->vol_trace.sum_val, vol_trace->aw_table.ipeak, > + vol_trace->aw_table.gain, vol_trace->aw_table.vmax); > + > + aw_dev_dbg(aw_dev->dev, > + "filter_temp:%d, temp: ipeak = 0x%x, gain = 0x%x, vmax = 0x%x", > + monitor->temp_trace.sum_val, temp_trace->aw_table.ipeak, > + temp_trace->aw_table.gain, temp_trace->aw_table.vmax); > + return 0; > +} > + > +static void aw_monitor_get_cfg(struct aw_device *aw_dev, > + struct aw_table *set_table) > +{ > + struct aw_monitor_desc *monitor = &aw_dev->monitor_desc; > + struct aw_table *temp_data = &monitor->temp_trace.aw_table; > + struct aw_table *vol_data = &monitor->vol_trace.aw_table; > + > + if (temp_data->ipeak == IPEAK_NONE && vol_data->ipeak == IPEAK_NONE) { > + memcpy(set_table, temp_data, sizeof(struct aw_table)); > + } else if (temp_data->ipeak == IPEAK_NONE) { > + memcpy(set_table, vol_data, sizeof(struct aw_table)); > + } else if (vol_data->ipeak == IPEAK_NONE) { > + memcpy(set_table, temp_data, sizeof(struct aw_table)); > + } else { > + if (monitor->monitor_cfg.logic_switch == AW_MON_LOGIC_OR) { > + set_table->ipeak = (temp_data->ipeak < vol_data->ipeak ? > + temp_data->ipeak : vol_data->ipeak); > + set_table->gain = (temp_data->gain < vol_data->gain ? > + vol_data->gain : temp_data->gain); > + set_table->vmax = (temp_data->vmax < vol_data->vmax ? > + vol_data->vmax : temp_data->vmax); > + } else { > + set_table->ipeak = (temp_data->ipeak < vol_data->ipeak ? > + vol_data->ipeak : temp_data->ipeak); > + set_table->gain = (temp_data->gain < vol_data->gain ? > + temp_data->gain : vol_data->gain); > + set_table->vmax = (temp_data->vmax < vol_data->vmax ? > + temp_data->vmax : vol_data->vmax); > + } > + } > +} > + > +static void aw_monitor_set_ipeak(struct aw_device *aw_dev, > + uint16_t ipeak) > +{ > + struct aw_monitor_cfg *monitor_cfg = &aw_dev->monitor_desc.monitor_cfg; > + uint16_t reg_val = 0; > + uint16_t read_reg_val; > + int ret; > + struct aw_ipeak_desc *desc = &aw_dev->ipeak_desc; > + > + if (ipeak == IPEAK_NONE || (!monitor_cfg->ipeak_switch)) > + return; > + > + ret = aw_dev->ops.aw_reg_read(aw_dev, desc->reg, &reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "read ipeak failed"); > + return; > + } > + > + read_reg_val = reg_val; > + read_reg_val &= (~desc->mask); > + > + if (read_reg_val == ipeak) { > + aw_dev_dbg(aw_dev->dev, "ipeak = 0x%x, no change", > + read_reg_val); > + return; > + } > + reg_val &= desc->mask; > + read_reg_val = ipeak; > + reg_val |= read_reg_val; > + > + ret = aw_dev->ops.aw_reg_write(aw_dev, desc->reg, reg_val); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write ipeak failed"); > + return; > + } > + aw_dev_info(aw_dev->dev, "set reg val = 0x%x, ipeak = 0x%x", > + reg_val, ipeak); > + > +} > + > +static void aw_monitor_set_gain(struct aw_device *aw_dev, uint16_t gain) > +{ > + uint16_t monitor_vol = 0; > + uint16_t compared_vol = 0; > + struct aw_monitor_cfg *monitor_cfg = &aw_dev->monitor_desc.monitor_cfg; > + struct aw_volume_desc *vol_desc = &aw_dev->volume_desc; > + > + if (gain == GAIN_NONE || (!monitor_cfg->gain_switch)) > + return; > + > + monitor_vol = aw_dev->ops.aw_reg_val_to_db(gain); > + vol_desc->monitor_volume = monitor_vol; > + > + /*get smaller dB*/ > + compared_vol = AW_GET_MAX_VALUE(vol_desc->ctl_volume, > + vol_desc->monitor_volume); > + > + aw883xx_dev_set_volume(aw_dev, compared_vol); > +} > + > +static int aw_monitor_vmax_check(struct aw_device *aw_dev) > +{ > + int ret = -1; > + > + ret = aw883xx_dev_syspll_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "no iis signal"); > + return ret; > + } > + > + ret = aw883xx_dev_get_dsp_status(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "dsp not work"); > + return ret; > + } > + > + return 0; > +} > + > +static void aw_monitor_set_vmax(struct aw_device *aw_dev, > + uint32_t vmax) > +{ > + struct aw_monitor_cfg *monitor_cfg = &aw_dev->monitor_desc.monitor_cfg; > + struct aw_vmax_desc *desc = &aw_dev->vmax_desc; > + uint16_t vmax_set; > + int ret = -1; > + > + if (vmax == VMAX_NONE || (!monitor_cfg->vmax_switch)) > + return; > + > + ret = aw_monitor_vmax_check(aw_dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "vmax_check fail, ret=%d", ret); > + return; > + } > + > + if ((vmax == aw_dev->monitor_desc.pre_vmax) && > + (aw_dev->monitor_desc.first_entry != AW_FIRST_ENTRY)) { > + aw_dev_dbg(aw_dev->dev, "vmax = 0x%x, no change", vmax); > + return; > + } > + > + vmax_set = (uint16_t)((int16_t)vmax + > + (int16_t)aw_dev->vmax_desc.init_vmax); > + > + > + ret = aw_dev->ops.aw_dsp_write(aw_dev, > + desc->dsp_reg, vmax_set, desc->data_type); > + if (ret < 0) > + return; > + > + aw_dev_info(aw_dev->dev, "get monitor vmax = 0x%x, set vmax = 0x%x", > + vmax, vmax_set); > +} > + > +static void aw_monitor_check_sysint(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint16_t sysint = 0; > + struct aw_int_desc *desc = &aw_dev->int_desc; > + > + ret = aw883xx_dev_get_int_status(aw_dev, &sysint); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "get_sysint fail, ret=%d", ret); > + > + if (sysint & (desc->intst_mask)) { > + desc->sysint_st = sysint; > + aw_dev_err(aw_dev->dev, "check sysint fail, reg=0x%04x", sysint); > + } > +} > + > +static int aw_monitor_work(struct aw_device *aw_dev) > +{ > + struct aw_monitor_desc *monitor = &aw_dev->monitor_desc; > + struct aw_monitor_cfg *monitor_cfg = &monitor->monitor_cfg; > + struct aw_table set_table; > + int ret = -1; > + > + if (aw883xx_cali_svc_get_cali_status(&aw_dev->cali_desc)) { > + aw_dev_info(aw_dev->dev, "done nothing during calibration"); > + return 0; > + } > + > + ret = aw_monitor_get_temp_and_vol(aw_dev); > + if (ret < 0) > + return ret; > + > + if (monitor->samp_count < monitor_cfg->monitor_count && > + (monitor->first_entry == AW_NOT_FIRST_ENTRY)) > + return 0; > + > + ret = aw_monitor_get_data(aw_dev); > + if (ret < 0) > + return ret; > + > + aw_monitor_get_cfg(aw_dev, &set_table); > + > + aw_dev_dbg(aw_dev->dev, > + "set_ipeak = 0x%x, set_gain = 0x%x, set_vmax = 0x%x", > + set_table.ipeak, set_table.gain, set_table.vmax); > + > + aw_monitor_set_ipeak(aw_dev, set_table.ipeak); > + > + aw_monitor_set_gain(aw_dev, set_table.gain); > + > + aw_monitor_set_vmax(aw_dev, set_table.vmax); > + > + aw_monitor_check_sysint(aw_dev); > + > + monitor->samp_count = 0; > + monitor->temp_trace.pre_val = monitor->temp_trace.sum_val; > + monitor->temp_trace.sum_val = 0; > + > + monitor->vol_trace.pre_val = monitor->vol_trace.sum_val; > + monitor->vol_trace.sum_val = 0; > + > + if (monitor->first_entry == AW_FIRST_ENTRY) > + monitor->first_entry = AW_NOT_FIRST_ENTRY; > + > + return 0; > +} > + > +static void aw_monitor_work_func(struct work_struct *work) > +{ > + struct aw_device *aw_dev = container_of(work, > + struct aw_device, monitor_desc.delay_work.work); > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + struct aw_monitor_cfg *monitor_cfg = &aw_dev->monitor_desc.monitor_cfg; > + struct aw_monitor_desc *monitor = &aw_dev->monitor_desc; > + > + aw_dev_dbg(aw_dev->dev, "scene_mode %d,monitor_status:%d, monitor_switch:%d", > + aw_dev->cur_prof, monitor_cfg->monitor_status, > + monitor_cfg->monitor_switch); > + > + if ((monitor_cfg->monitor_status == AW_MON_CFG_OK) && > + monitor_cfg->monitor_switch) { > + > + if (!aw883xx_dev_get_hmute(aw_dev)) { > + aw_monitor_work(aw_dev); > + queue_delayed_work(aw883xx->work_queue, > + &monitor->delay_work, > + msecs_to_jiffies(monitor_cfg->monitor_time)); > + } > + > + } > +} > + > +static int aw_hw_monitor_work(struct aw_device *aw_dev) > +{ > + int32_t sys_temp; > + > + aw_monitor_get_system_temperature(aw_dev, &sys_temp); > + > + aw_monitor_set_system_temperature(aw_dev, sys_temp); > + > + return 0; > +} > + > +static void aw_hw_monitor_work_func(struct work_struct *work) > +{ > + struct aw_device *aw_dev = container_of(work, > + struct aw_device, monitor_desc.hw_monitor_work.work); > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + struct aw_monitor_desc *monitor = &aw_dev->monitor_desc; > + > + if (!aw883xx_dev_get_hmute(aw_dev)) { > + aw_hw_monitor_work(aw_dev); > + queue_delayed_work(aw883xx->work_queue, > + &monitor->hw_monitor_work, > + msecs_to_jiffies(monitor->hw_monitor_delay)); > + } > +} > + > +void aw883xx_monitor_start(struct aw_monitor_desc *monitor_desc) > +{ > + uint8_t temp_flag = monitor_desc->hw_temp_flag; > + struct aw_device *aw_dev = container_of(monitor_desc, > + struct aw_device, monitor_desc); > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + if (aw_dev->profctrl_desc.cur_mode == AW_RCV_MODE) { > + aw_dev_dbg(aw_dev->dev, "receiver mode no need to start monitor"); > + return; > + } > + > + if (monitor_desc->hw_mon_en) { > + aw_dev_info(aw_dev->dev, "hardware monitor is enable"); > + if (temp_flag == AW_EXTERNAL_TEMP) { > + queue_delayed_work(aw883xx->work_queue, > + &monitor_desc->hw_monitor_work, 0); > + } else { > + aw_dev_dbg(aw_dev->dev, "Internal chip temperature used"); > + } > + return; > + } > + > + monitor_desc->first_entry = AW_FIRST_ENTRY; > + monitor_desc->samp_count = 0; > + monitor_desc->vol_trace.sum_val = 0; > + monitor_desc->temp_trace.sum_val = 0; > + > + queue_delayed_work(aw883xx->work_queue, > + &monitor_desc->delay_work, 0); > +} > + > +int aw883xx_monitor_stop(struct aw_monitor_desc *monitor_desc) > +{ > + struct aw_device *aw_dev = container_of(monitor_desc, > + struct aw_device, monitor_desc); > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + aw_dev->volume_desc.monitor_volume = 0; > + cancel_delayed_work_sync(&monitor_desc->delay_work); > + cancel_delayed_work_sync(&monitor_desc->hw_monitor_work); > + > + return 0; > + > +} > + > +/* > + * load monitor config > + */ > +static int aw_monitor_param_check_sum(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len) > +{ > + int i, check_sum = 0; > + struct aw_monitor_hdr_v_0_1_1 *monitor_hdr = > + (struct aw_monitor_hdr_v_0_1_1 *)data; > + > + if (data_len < sizeof(struct aw_monitor_hdr_v_0_1_1)) { > + aw_dev_err(aw_dev->dev, > + "data size smaller than hdr , please check monitor bin"); > + return -ENOMEM; > + } > + > + for (i = 4 ; i < data_len; i++) > + check_sum += (uint8_t)data[i]; > + > + if (monitor_hdr->check_sum != check_sum) { > + aw_dev_err(aw_dev->dev, > + "check_sum[%d] is not equal to actual check_sum[%d]", > + monitor_hdr->check_sum, check_sum); > + return -ENOMEM; > + } > + > + return 0; > +} > + > +static void aw_monitor_write_data_to_table(struct aw_device *aw_dev, > + struct aw_table_info *table_info, const char *offset_ptr) > +{ > + int i; > + int table_size = AW_TABLE_SIZE; > + > + for (i = 0; i < table_info->table_num * table_size; i += table_size) { > + table_info->aw_table[i / AW_TABLE_SIZE].min_val = > + AW_GET_16_DATA(offset_ptr[1 + i], offset_ptr[i]); > + table_info->aw_table[i / AW_TABLE_SIZE].max_val = > + AW_GET_16_DATA(offset_ptr[3 + i], offset_ptr[2 + i]); > + table_info->aw_table[i / AW_TABLE_SIZE].ipeak = > + AW_GET_16_DATA(offset_ptr[5 + i], offset_ptr[4 + i]); > + table_info->aw_table[i / AW_TABLE_SIZE].gain = > + AW_GET_16_DATA(offset_ptr[7 + i], offset_ptr[6 + i]); > + table_info->aw_table[i / AW_TABLE_SIZE].vmax = > + AW_GET_32_DATA(offset_ptr[11 + i], offset_ptr[10 + i], > + offset_ptr[9 + i], offset_ptr[8 + i]); > + } > + > + for (i = 0; i < table_info->table_num; i++) > + aw_dev_info(aw_dev->dev, > + "min_val:%d, max_val:%d, ipeak:0x%x, gain:0x%x, vmax:0x%x", > + table_info->aw_table[i].min_val, > + table_info->aw_table[i].max_val, > + table_info->aw_table[i].ipeak, > + table_info->aw_table[i].gain, > + table_info->aw_table[i].vmax); > + > +} > + > +static int aw_monitor_parse_vol_data_v_0_1_1(struct aw_device *aw_dev, uint8_t *data) > +{ > + struct aw_monitor_hdr_v_0_1_1 *monitor_hdr = > + (struct aw_monitor_hdr_v_0_1_1 *)data; > + struct aw_table_info *vol_info = > + &aw_dev->monitor_desc.monitor_cfg.vol_info; > + > + aw_dev_info(aw_dev->dev, "===parse vol start ==="); > + if (vol_info->aw_table != NULL) { > + devm_kfree(aw_dev->dev, vol_info->aw_table); > + vol_info->aw_table = NULL; > + } > + > + vol_info->aw_table = devm_kzalloc(aw_dev->dev, > + (monitor_hdr->vol_num * AW_TABLE_SIZE), > + GFP_KERNEL); > + if (vol_info->aw_table == NULL) > + return -ENOMEM; > + > + vol_info->table_num = monitor_hdr->vol_num; > + aw_monitor_write_data_to_table(aw_dev, vol_info, > + &data[monitor_hdr->vol_offset]); > + aw_dev_info(aw_dev->dev, "===parse vol end ==="); > + return 0; > +} > + > +static int aw_monitor_parse_temp_data_v_0_1_1(struct aw_device *aw_dev, uint8_t *data) > +{ > + struct aw_monitor_hdr_v_0_1_1 *monitor_hdr = > + (struct aw_monitor_hdr_v_0_1_1 *)data; > + struct aw_table_info *temp_info = > + &aw_dev->monitor_desc.monitor_cfg.temp_info; > + > + aw_dev_info(aw_dev->dev, "===parse temp start ==="); > + > + if (temp_info->aw_table != NULL) { > + devm_kfree(aw_dev->dev, temp_info->aw_table); > + temp_info->aw_table = NULL; > + } > + > + temp_info->aw_table = devm_kzalloc(aw_dev->dev, > + (monitor_hdr->temp_num * AW_TABLE_SIZE), > + GFP_KERNEL); > + if (temp_info->aw_table == NULL) > + return -ENOMEM; > + > + temp_info->table_num = monitor_hdr->temp_num; > + aw_monitor_write_data_to_table(aw_dev, temp_info, > + &data[monitor_hdr->temp_offset]); > + aw_dev_info(aw_dev->dev, "===parse temp end ==="); > + return 0; > +} > + > +static void aw_monitor_parse_hdr_v_0_1_1(struct aw_device *aw_dev, uint8_t *data) > +{ > + struct aw_monitor_hdr_v_0_1_1 *monitor_hdr = > + (struct aw_monitor_hdr_v_0_1_1 *)data; > + struct aw_monitor_cfg *monitor_cfg = &aw_dev->monitor_desc.monitor_cfg; > + > + monitor_cfg->monitor_switch = > + (monitor_hdr->enable_flag >> MONITOR_EN_BIT) & MONITOR_EN_MASK; > + monitor_cfg->monitor_time = monitor_hdr->monitor_time; > + monitor_cfg->monitor_count = monitor_hdr->monitor_count; > + monitor_cfg->ipeak_switch = > + (monitor_hdr->enable_flag >> MONITOR_IPEAK_EN_BIT) & MONITOR_EN_MASK; > + monitor_cfg->logic_switch = > + (monitor_hdr->enable_flag >> MONITOR_LOGIC_BIT) & MONITOR_EN_MASK; > + monitor_cfg->gain_switch = > + (monitor_hdr->enable_flag >> MONITOR_GAIN_EN_BIT) & MONITOR_EN_MASK; > + monitor_cfg->vmax_switch = > + (monitor_hdr->enable_flag >> MONITOR_VMAX_EN_BIT) & MONITOR_EN_MASK; > + monitor_cfg->temp_switch = > + (monitor_hdr->enable_flag >> MONITOR_TEMP_EN_BIT) & MONITOR_EN_MASK; > + monitor_cfg->temp_aplha = monitor_hdr->temp_aplha; > + monitor_cfg->vol_switch = > + (monitor_hdr->enable_flag >> MONITOR_VOL_EN_BIT) & MONITOR_EN_MASK; > + monitor_cfg->vol_aplha = monitor_hdr->vol_aplha; > + > + aw_dev_info(aw_dev->dev, "chip name:%s", > + monitor_hdr->chip_type); > + aw_dev_info(aw_dev->dev, "ui ver:0x%x", > + monitor_hdr->ui_ver); > + > + aw_dev_info(aw_dev->dev, > + "monitor_switch:%d, monitor_time:%d (ms), monitor_count:%d", > + monitor_cfg->monitor_switch, monitor_cfg->monitor_time, > + monitor_cfg->monitor_count); > + > + aw_dev_info(aw_dev->dev, > + "logic_switch:%d, ipeak_switch:%d, gain_switch:%d, vmax_switch:%d", > + monitor_cfg->logic_switch, monitor_cfg->ipeak_switch, > + monitor_cfg->gain_switch, monitor_cfg->vmax_switch); > + > + aw_dev_info(aw_dev->dev, > + "temp_switch:%d, temp_aplha:%d, vol_switch:%d, vol_aplha:%d", > + monitor_cfg->temp_switch, monitor_cfg->temp_aplha, > + monitor_cfg->vol_switch, monitor_cfg->vol_aplha); > +} > + > +static int aw_monitor_check_fw_v_0_1_1(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len) > +{ > + struct aw_monitor_hdr_v_0_1_1 *monitor_hdr = > + (struct aw_monitor_hdr_v_0_1_1 *)data; > + int temp_size, vol_size; > + > + if (data_len < sizeof(struct aw_monitor_hdr_v_0_1_1)) { > + aw_dev_err(aw_dev->dev, > + "params size[%d] < struct aw_monitor_hdr size[%d]!", > + data_len, (int)sizeof(struct aw_monitor_hdr_v_0_1_1)); > + return -ENOMEM; > + } > + > + if (monitor_hdr->temp_offset > data_len) { > + aw_dev_err(aw_dev->dev, "temp_offset[%d] overflow file size[%d]!", > + monitor_hdr->temp_offset, data_len); > + return -ENOMEM; > + } > + > + if (monitor_hdr->vol_offset > data_len) { > + aw_dev_err(aw_dev->dev, "vol_offset[%d] overflow file size[%d]!", > + monitor_hdr->vol_offset, data_len); > + return -ENOMEM; > + } > + > + temp_size = monitor_hdr->temp_num * monitor_hdr->single_temp_size; > + if (temp_size > data_len) { > + aw_dev_err(aw_dev->dev, "temp_size:[%d] overflow file size[%d]!", > + temp_size, data_len); > + return -ENOMEM; > + } > + > + vol_size = monitor_hdr->vol_num * monitor_hdr->single_vol_size; > + if (vol_size > data_len) { > + aw_dev_err(aw_dev->dev, "vol_size:[%d] overflow file size[%d]!", > + vol_size, data_len); > + return -ENOMEM; > + } > + > + return 0; > +} > + > +static int aw_monitor_parse_data_v_0_1_1(struct aw_device *aw_dev, > + uint8_t *data, uint32_t data_len) > +{ > + int ret; > + struct aw_monitor_cfg *monitor_cfg = &aw_dev->monitor_desc.monitor_cfg; > + > + ret = aw_monitor_check_fw_v_0_1_1(aw_dev, data, data_len); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "check monitor failed"); > + return ret; > + } > + > + aw_monitor_parse_hdr_v_0_1_1(aw_dev, data); > + > + ret = aw_monitor_parse_temp_data_v_0_1_1(aw_dev, data); > + if (ret < 0) > + return ret; > + > + ret = aw_monitor_parse_vol_data_v_0_1_1(aw_dev, data); > + if (ret < 0) { > + if (monitor_cfg->temp_info.aw_table != NULL) { > + devm_kfree(aw_dev->dev, monitor_cfg->temp_info.aw_table); > + monitor_cfg->temp_info.aw_table = NULL; > + monitor_cfg->temp_info.table_num = 0; > + } > + return ret; > + } > + > + monitor_cfg->monitor_status = AW_MON_CFG_OK; > + return 0; > +} > + > +int aw883xx_monitor_parse_fw(struct aw_monitor_desc *monitor_desc, > + uint8_t *data, uint32_t data_len) > +{ > + struct aw_monitor_hdr_v_0_1_1 *monitor_hdr = NULL; > + struct aw_device *aw_dev = NULL; > + int ret; > + > + if (monitor_desc == NULL || data == NULL) { > + pr_err("monitor_desc or data is NULL"); > + return -EINVAL; > + } > + > + monitor_hdr = (struct aw_monitor_hdr_v_0_1_1 *)data; > + aw_dev = container_of(monitor_desc, > + struct aw_device, monitor_desc); > + > + ret = aw_monitor_param_check_sum(aw_dev, data, data_len); > + if (ret < 0) > + return ret; > + > + switch (monitor_hdr->monitor_ver) { > + case AW_MONITOR_HDR_VER_0_1_1: > + return aw_monitor_parse_data_v_0_1_1(aw_dev, data, data_len); > + default: > + aw_dev_err(aw_dev->dev, "cfg version:0x%x unsupported", > + monitor_hdr->monitor_ver); > + return -EINVAL; > + } > +} > + > +static void aw_monitor_free_firmware(struct aw_device *aw_dev) > +{ > + struct aw_monitor_cfg *monitor_cfg = > + &aw_dev->monitor_desc.monitor_cfg; > + > + monitor_cfg->monitor_status = AW_MON_CFG_ST; > + > + if (monitor_cfg->temp_info.aw_table != NULL) { > + devm_kfree(aw_dev->dev, monitor_cfg->temp_info.aw_table); > + monitor_cfg->temp_info.aw_table = NULL; > + } > + > + if (monitor_cfg->vol_info.aw_table != NULL) { > + devm_kfree(aw_dev->dev, monitor_cfg->vol_info.aw_table); > + monitor_cfg->vol_info.aw_table = NULL; > + } > + > + memset(monitor_cfg, 0, sizeof(struct aw_monitor_cfg)); > +} > + > +static int aw_monitor_real_time_update_monitor(struct aw_device *aw_dev) > +{ > + const struct firmware *cont = NULL; > + struct aw_container *aw_monitor_cnt = NULL; > + int ret; > + > + ret = request_firmware(&cont, AW883XX_MONITOR_NAME, aw_dev->dev); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "failed to read %s", AW883XX_MONITOR_NAME); > + release_firmware(cont); > + return ret; > + } > + > + aw_monitor_cnt = devm_kzalloc(aw_dev->dev, > + cont->size + sizeof(uint32_t), GFP_KERNEL); > + if (aw_monitor_cnt == NULL) { > + release_firmware(cont); > + return ret; > + } > + > + aw_monitor_cnt->len = (int)cont->size; > + memcpy(aw_monitor_cnt->data, cont->data, cont->size); > + release_firmware(cont); > + > + ret = aw883xx_monitor_parse_fw(&aw_dev->monitor_desc, > + aw_monitor_cnt->data, aw_monitor_cnt->len); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "parse monitor firmware failed!"); > + > + devm_kfree(aw_dev->dev, aw_monitor_cnt); > + aw_monitor_cnt = NULL; > + > + return ret; > +} > + > +/* > + * monitor init > + */ > +#ifdef AW_DEBUG > +static ssize_t aw_vol_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + uint32_t vol = 0; > + int ret = -1; > + > + if (count == 0) > + return 0; > + > + ret = kstrtouint(buf, 0, &vol); > + if (ret < 0) > + return ret; > + > + aw_dev_info(aw_dev->dev, "vol set =%d", vol); > + aw_dev->monitor_desc.test_vol = vol; > + > + return count; > +} > + > +static ssize_t aw_vol_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + ssize_t len = 0; > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "vol: %d\n", > + aw_dev->monitor_desc.test_vol); > + return len; > +} > + > +static ssize_t aw_temp_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + int32_t temp = 0; > + int ret = -1; > + > + if (count == 0) > + return 0; > + > + ret = kstrtoint(buf, 0, &temp); > + if (ret < 0) > + return ret; > + > + aw_dev_info(aw_dev->dev, "temp set =%d", temp); > + > + aw_dev->monitor_desc.test_temp = temp; > + > + return count; > +} > + > +static ssize_t aw_temp_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + ssize_t len = 0; > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "aw883xx temp: %d\n", > + aw_dev->monitor_desc.test_temp); > + > + return len; > +} > + > +static DEVICE_ATTR(vol, 0644, > + aw_vol_show, aw_vol_store); > +static DEVICE_ATTR(temp, 0644, > + aw_temp_show, aw_temp_store); > +#endif > + > +static ssize_t aw_monitor_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + uint32_t enable = 0; > + int ret = -1; > + > + if (count == 0) > + return 0; > + > + ret = kstrtouint(buf, 0, &enable); > + if (ret < 0) > + return ret; > + > + aw_dev_info(aw_dev->dev, "monitor enable set =%d", enable); > + > + if (aw_dev->monitor_desc.monitor_cfg.monitor_switch != enable) { > + aw_dev->monitor_desc.monitor_cfg.monitor_switch = enable; > + if (enable) > + aw883xx_monitor_start(&aw_dev->monitor_desc); > + } else { > + return count; > + } > + > + return count; > +} > + > +static ssize_t aw_monitor_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + ssize_t len = 0; > + > + > + len += snprintf(buf+len, PAGE_SIZE-len, > + "aw883xx monitor_flag=%u\n", > + aw_dev->monitor_desc.monitor_cfg.monitor_switch); > + return len; > +} > + > +static ssize_t aw_monitor_update_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t count) > +{ > + struct aw883xx *aw883xx = dev_get_drvdata(dev); > + struct aw_device *aw_dev = aw883xx->aw_pa; > + > + uint32_t update = 0; > + int ret = -1; > + > + if (count == 0) > + return 0; > + > + ret = kstrtouint(buf, 0, &update); > + if (ret < 0) > + return ret; > + > + aw_dev_info(aw_dev->dev, "monitor update = %d", update); > + > + if (update) { > + aw883xx_monitor_stop(&aw_dev->monitor_desc); > + aw_monitor_free_firmware(aw_dev); > + ret = aw_monitor_real_time_update_monitor(aw_dev); > + if (ret < 0) > + return ret; > + aw883xx_monitor_start(&aw_dev->monitor_desc); > + } > + > + return count; > +} > + > +static DEVICE_ATTR(monitor, 0644, > + aw_monitor_show, aw_monitor_store); > +static DEVICE_ATTR(monitor_update, 0200, > + NULL, aw_monitor_update_store); > + > + > +static struct attribute *aw_monitor_attr[] = { > + &dev_attr_monitor.attr, > + &dev_attr_monitor_update.attr, > +#ifdef AW_DEBUG > + &dev_attr_vol.attr, > + &dev_attr_temp.attr, > +#endif > + NULL > +}; > + > +static struct attribute_group aw_monitor_attr_group = { > + .attrs = aw_monitor_attr, > +}; > + > +static void aw_monitor_parse_dt(struct aw_device *aw_dev) > +{ > + int ret = -1; > + uint32_t monitor_delay; > + struct device_node *np = aw_dev->dev->of_node; > + > + ret = of_property_read_u32(np, "hw-monitor-delay", &monitor_delay); > + if (ret < 0) { > + aw_dev_info(aw_dev->dev, > + "read hw-monitor-delay failed, set default value:[%d]ms", > + aw_dev->monitor_desc.hw_monitor_delay); > + } else { > + aw_dev_info(aw_dev->dev, > + "parse hw-monitor-delay:[%d]", monitor_delay); > + aw_dev->monitor_desc.hw_monitor_delay = monitor_delay; > + } > +} > + > +void aw883xx_monitor_init(struct aw_monitor_desc *monitor_desc) > +{ > + int ret; > + struct aw_device *aw_dev = container_of(monitor_desc, > + struct aw_device, monitor_desc); > + > + aw_dev_info(aw_dev->dev, "enter"); > + > + aw_monitor_parse_dt(aw_dev); > + > +#ifdef AW_DEBUG > + monitor_desc->test_vol = 0; > + monitor_desc->test_temp = 0; > +#endif > + > + INIT_DELAYED_WORK(&monitor_desc->delay_work, aw_monitor_work_func); > + INIT_DELAYED_WORK(&monitor_desc->hw_monitor_work, aw_hw_monitor_work_func); > + > + ret = sysfs_create_group(&aw_dev->dev->kobj, > + &aw_monitor_attr_group); > + if (ret < 0) > + aw_dev_err(aw_dev->dev, "error creating sysfs attr files"); > +} > + > +void aw883xx_monitor_deinit(struct aw_monitor_desc *monitor_desc) > +{ > + struct aw_device *aw_dev = > + container_of(monitor_desc, struct aw_device, monitor_desc); > + > + aw883xx_monitor_stop(monitor_desc); > + > + sysfs_remove_group(&aw_dev->dev->kobj, &aw_monitor_attr_group); > +} > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_monitor.h b/sound/soc/codecs/aw883xx/aw883xx_monitor.h > new file mode 100644 > index 0000000..5a1a017 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_monitor.h > @@ -0,0 +1,167 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_MONITOR_H__ > +#define __AW883XX_MONITOR_H__ > + > +/*#define AW_DEBUG*/ > +/*#define AW_SYS_BATTERY_ST*/ > + > +struct aw_table; > + > +#define AW_TABLE_SIZE sizeof(struct aw_table) > +#define AW_MONITOR_DEFAULT_FLAG (0) > + > +#define IPEAK_NONE (0xFF) > +#define GAIN_NONE (0xFF) > +#define VMAX_NONE (0xFFFFFFFF) > + > + > +#define AW_GET_32_DATA(w, x, y, z) \ > + ((uint32_t)((((uint8_t)w) << 24) | (((uint8_t)x) << 16) | \ > + (((uint8_t)y) << 8) | ((uint8_t)z))) > +#define AW_GET_16_DATA(x, y) \ > + ((uint16_t)((((uint8_t)x) << 8) | (uint8_t)y)) > + > +enum { > + AW_MON_LOGIC_OR = 0, > + AW_MON_LOGIC_AND = 1, > +}; > + > +enum { > + AW_FIRST_ENTRY = 0, > + AW_NOT_FIRST_ENTRY = 1, > +}; > + > +enum aw_monitor_hdr_ver { > + AW_MONITOR_HDR_VER_0_1_1 = 0x00010100, > +}; > + > +enum aw_monitor_init { > + AW_MON_CFG_ST = 0, > + AW_MON_CFG_OK = 1, > +}; > + > +#define MONITOR_EN_MASK 0x01 > + > +enum { > + MONITOR_EN_BIT = 0, > + MONITOR_LOGIC_BIT = 1, > + MONITOR_IPEAK_EN_BIT = 2, > + MONITOR_GAIN_EN_BIT = 3, > + MONITOR_VMAX_EN_BIT = 4, > + MONITOR_TEMP_EN_BIT = 5, > + MONITOR_VOL_EN_BIT = 6, > +}; > + > +enum { > + AW_INTERNAL_TEMP = 0, > + AW_EXTERNAL_TEMP = 1, > +}; > + > +struct aw_monitor_hdr_v_0_1_1 { > + uint32_t check_sum; > + uint32_t monitor_ver; > + char chip_type[16]; > + uint32_t ui_ver; > + uint32_t monitor_time; > + uint32_t monitor_count; > + uint32_t enable_flag; > + /* [bit 31:7]*/ > + /* [bit 6: vol en]*/ > + /* [bit 5: temp en]*/ > + /* [bit 4: vmax en]*/ > + /* [bit 3: gain en]*/ > + /* [bit 2: ipeak en]*/ > + /* [bit 1: & or | flag]*/ > + /* [bit 0: monitor en]*/ > + uint32_t temp_aplha; > + uint32_t temp_num; > + uint32_t single_temp_size; > + uint32_t temp_offset; > + uint32_t vol_aplha; > + uint32_t vol_num; > + uint32_t single_vol_size; > + uint32_t vol_offset; > + uint32_t reserver[3]; > +}; > + > +struct aw_table { > + int16_t min_val; > + int16_t max_val; > + uint16_t ipeak; > + uint16_t gain; > + uint32_t vmax; > +}; > + > +struct aw_table_info { > + uint8_t table_num; > + struct aw_table *aw_table; > +}; > + > +struct aw_monitor_cfg { > + uint8_t monitor_status; > + uint32_t monitor_switch; > + uint32_t monitor_time; > + uint32_t monitor_count; > + uint32_t logic_switch; > + uint32_t temp_switch; > + uint32_t temp_aplha; > + uint32_t vol_switch; > + uint32_t vol_aplha; > + uint32_t ipeak_switch; > + uint32_t gain_switch; > + uint32_t vmax_switch; > + struct aw_table_info temp_info; > + struct aw_table_info vol_info; > +}; > + > +struct aw_monitor_trace { > + int32_t pre_val; > + int32_t sum_val; > + struct aw_table aw_table; > +}; > + > + > +/* > + * struct aw882xx monitor > + */ > +struct aw_monitor_desc { > + struct delayed_work delay_work; > + struct delayed_work hw_monitor_work; > + struct aw_monitor_cfg monitor_cfg; > + bool hw_mon_en; > + > + uint8_t hw_temp_flag; > + uint8_t first_entry; > + uint8_t samp_count; > + uint32_t pre_vmax; > + uint32_t hw_monitor_delay; > + > + struct aw_monitor_trace temp_trace; > + struct aw_monitor_trace vol_trace; > + > +#ifdef AW_DEBUG > + uint16_t test_vol; > + int16_t test_temp; > +#endif > +}; > + > +/* > + * aw882xx monitor functions > + */ > +void aw883xx_monitor_start(struct aw_monitor_desc *monitor_desc); > +int aw883xx_monitor_stop(struct aw_monitor_desc *monitor_desc); > +void aw883xx_monitor_init(struct aw_monitor_desc *monitor_desc); > +void aw883xx_monitor_deinit(struct aw_monitor_desc *monitor_desc); > +int aw883xx_monitor_parse_fw(struct aw_monitor_desc *monitor_desc, > + uint8_t *data, uint32_t data_len); > + > +#endif > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_pid_2049_reg.h b/sound/soc/codecs/aw883xx/aw883xx_pid_2049_reg.h > new file mode 100644 > index 0000000..afddec5 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_pid_2049_reg.h > @@ -0,0 +1,2388 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#ifndef __AW883XX_PID_2049_REG_H__ > +#define __AW883XX_PID_2049_REG_H__ > + > +/* registers list */ > +#define AW_PID_2049_ID_REG (0x00) > +#define AW_PID_2049_SYSST_REG (0x01) > +#define AW_PID_2049_SYSINT_REG (0x02) > +#define AW_PID_2049_SYSINTM_REG (0x03) > +#define AW_PID_2049_SYSCTRL_REG (0x04) > +#define AW_PID_2049_SYSCTRL2_REG (0x05) > +#define AW_PID_2049_I2SCTRL_REG (0x06) > +#define AW_PID_2049_I2SCFG1_REG (0x07) > +#define AW_PID_2049_I2SCFG2_REG (0x08) > +#define AW_PID_2049_HAGCCFG1_REG (0x09) > +#define AW_PID_2049_HAGCCFG2_REG (0x0A) > +#define AW_PID_2049_HAGCCFG3_REG (0x0B) > +#define AW_PID_2049_HAGCCFG4_REG (0x0C) > +#define AW_PID_2049_HAGCCFG5_REG (0x0D) > +#define AW_PID_2049_HAGCCFG6_REG (0x0E) > +#define AW_PID_2049_HAGCCFG7_REG (0x0F) > +#define AW_PID_2049_MPDCFG_REG (0x10) > +#define AW_PID_2049_PWMCTRL_REG (0x11) > +#define AW_PID_2049_I2SCFG3_REG (0x12) > +#define AW_PID_2049_DBGCTRL_REG (0x13) > +#define AW_PID_2049_HAGCST_REG (0x20) > +#define AW_PID_2049_VBAT_REG (0x21) > +#define AW_PID_2049_TEMP_REG (0x22) > +#define AW_PID_2049_PVDD_REG (0x23) > +#define AW_PID_2049_ISNDAT_REG (0x24) > +#define AW_PID_2049_VSNDAT_REG (0x25) > +#define AW_PID_2049_I2SINT_REG (0x26) > +#define AW_PID_2049_I2SCAPCNT_REG (0x27) > +#define AW_PID_2049_ANASTA1_REG (0x28) > +#define AW_PID_2049_ANASTA2_REG (0x29) > +#define AW_PID_2049_ANASTA3_REG (0x2A) > +#define AW_PID_2049_ANASTA4_REG (0x2B) > +#define AW_PID_2049_TESTDET_REG (0x2C) > +#define AW_PID_2049_TESTIN_REG (0x38) > +#define AW_PID_2049_TESTOUT_REG (0x39) > +#define AW_PID_2049_DSPMADD_REG (0x40) > +#define AW_PID_2049_DSPMDAT_REG (0x41) > +#define AW_PID_2049_WDT_REG (0x42) > +#define AW_PID_2049_ACR1_REG (0x43) > +#define AW_PID_2049_ACR2_REG (0x44) > +#define AW_PID_2049_ASR1_REG (0x45) > +#define AW_PID_2049_ASR2_REG (0x46) > +#define AW_PID_2049_DSPCFG_REG (0x47) > +#define AW_PID_2049_ASR3_REG (0x48) > +#define AW_PID_2049_ASR4_REG (0x49) > +#define AW_PID_2049_VSNCTRL1_REG (0x50) > +#define AW_PID_2049_ISNCTRL1_REG (0x51) > +#define AW_PID_2049_PLLCTRL1_REG (0x52) > +#define AW_PID_2049_PLLCTRL2_REG (0x53) > +#define AW_PID_2049_PLLCTRL3_REG (0x54) > +#define AW_PID_2049_CDACTRL1_REG (0x55) > +#define AW_PID_2049_CDACTRL2_REG (0x56) > +#define AW_PID_2049_SADCCTRL1_REG (0x57) > +#define AW_PID_2049_SADCCTRL2_REG (0x58) > +#define AW_PID_2049_CPCTRL1_REG (0x59) > +#define AW_PID_2049_BSTCTRL1_REG (0x60) > +#define AW_PID_2049_BSTCTRL2_REG (0x61) > +#define AW_PID_2049_BSTCTRL3_REG (0x62) > +#define AW_PID_2049_BSTCTRL4_REG (0x63) > +#define AW_PID_2049_BSTCTRL5_REG (0x64) > +#define AW_PID_2049_BSTCTRL6_REG (0x65) > +#define AW_PID_2049_BSTCTRL7_REG (0x66) > +#define AW_PID_2049_DSMCFG1_REG (0x67) > +#define AW_PID_2049_DSMCFG2_REG (0x68) > +#define AW_PID_2049_DSMCFG3_REG (0x69) > +#define AW_PID_2049_DSMCFG4_REG (0x6A) > +#define AW_PID_2049_DSMCFG5_REG (0x6B) > +#define AW_PID_2049_DSMCFG6_REG (0x6C) > +#define AW_PID_2049_DSMCFG7_REG (0x6D) > +#define AW_PID_2049_DSMCFG8_REG (0x6E) > +#define AW_PID_2049_TESTCTRL1_REG (0x70) > +#define AW_PID_2049_TESTCTRL2_REG (0x71) > +#define AW_PID_2049_EFCTRL1_REG (0x72) > +#define AW_PID_2049_EFCTRL2_REG (0x73) > +#define AW_PID_2049_EFWH_REG (0x74) > +#define AW_PID_2049_EFWM2_REG (0x75) > +#define AW_PID_2049_EFWM1_REG (0x76) > +#define AW_PID_2049_EFWL_REG (0x77) > +#define AW_PID_2049_EFRH_REG (0x78) > +#define AW_PID_2049_EFRM2_REG (0x79) > +#define AW_PID_2049_EFRM1_REG (0x7A) > +#define AW_PID_2049_EFRL_REG (0x7B) > +#define AW_PID_2049_TM_REG (0x7C) > + > +/* > + * Register Access > + */ > +enum aw883xx_id { > + AW883XX_PID_2049 = 0x2049, > +}; > + > +#define AW_PID_2049_REG_MAX (0x7D) > + > +#define REG_NONE_ACCESS (0) > +#define REG_RD_ACCESS (1 << 0) > +#define REG_WR_ACCESS (1 << 1) > + > +static const unsigned char aw_pid_2049_reg_access[AW_PID_2049_REG_MAX] = { > + [AW_PID_2049_ID_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_SYSST_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_SYSINT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_SYSINTM_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_SYSCTRL_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_SYSCTRL2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_I2SCTRL_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_I2SCFG1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_I2SCFG2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCCFG1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCCFG2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCCFG3_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCCFG4_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCCFG5_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCCFG6_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCCFG7_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_MPDCFG_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_PWMCTRL_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_I2SCFG3_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DBGCTRL_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_HAGCST_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_VBAT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_TEMP_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_PVDD_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ISNDAT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_VSNDAT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_I2SINT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_I2SCAPCNT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ANASTA1_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ANASTA2_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ANASTA3_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ANASTA4_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_TESTDET_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_TESTIN_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_TESTOUT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_DSPMADD_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSPMDAT_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_WDT_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ACR1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_ACR2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_ASR1_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ASR2_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_DSPCFG_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_ASR3_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_ASR4_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_VSNCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_ISNCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_PLLCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_PLLCTRL2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_PLLCTRL3_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_CDACTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_CDACTRL2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_SADCCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_SADCCTRL2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_CPCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_BSTCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_BSTCTRL2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_BSTCTRL3_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_BSTCTRL4_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_BSTCTRL5_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_BSTCTRL6_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_BSTCTRL7_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG3_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG4_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG5_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG6_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG7_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_DSMCFG8_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_TESTCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_TESTCTRL2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_EFCTRL1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_EFCTRL2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_EFWH_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_EFWM2_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_EFWM1_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_EFWL_REG] = (REG_RD_ACCESS | REG_WR_ACCESS), > + [AW_PID_2049_EFRH_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_EFRM2_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_EFRM1_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_EFRL_REG] = (REG_RD_ACCESS), > + [AW_PID_2049_TM_REG] = (REG_NONE_ACCESS), > +}; > + > +#define AW_PID_2049_VOLUME_STEP_DB (6 * 8) > + > + > +/* detail information of registers begin */ > +/* ID (0x00) detail */ > +/* IDCODE bit 15:0 (ID 0x00) */ > +#define AW_PID_2049_IDCODE_START_BIT (0) > +#define AW_PID_2049_IDCODE_BITS_LEN (16) > +#define AW_PID_2049_IDCODE_MASK \ > + (~(((1<<AW_PID_2049_IDCODE_BITS_LEN)-1) << AW_PID_2049_IDCODE_START_BIT)) > + > +#define AW_PID_2049_IDCODE_DEFAULT_VALUE (0x2049) > +#define AW_PID_2049_IDCODE_DEFAULT \ > + (AW_PID_2049_IDCODE_DEFAULT_VALUE << AW_PID_2049_IDCODE_START_BIT) > + > +#define AW_PID_2049_SOFT_RESET_VALUE (0x55aa) > + > +/* default value of ID (0x00) */ > +/* #define AW_PID_2049_ID_DEFAULT (0x2049) */ > + > +/* SYSST (0x01) detail */ > +/* OVP2S bit 15 (SYSST 0x01) */ > +#define AW_PID_2049_OVP2S_START_BIT (15) > +#define AW_PID_2049_OVP2S_BITS_LEN (1) > +#define AW_PID_2049_OVP2S_MASK \ > + (~(((1<<AW_PID_2049_OVP2S_BITS_LEN)-1) << AW_PID_2049_OVP2S_START_BIT)) > + > +#define AW_PID_2049_OVP2S_NORMAL (0) > +#define AW_PID_2049_OVP2S_NORMAL_VALUE \ > + (AW_PID_2049_OVP2S_NORMAL << AW_PID_2049_OVP2S_START_BIT) > + > +#define AW_PID_2049_OVP2S_OVP (1) > +#define AW_PID_2049_OVP2S_OVP_VALUE \ > + (AW_PID_2049_OVP2S_OVP << AW_PID_2049_OVP2S_START_BIT) > + > +#define AW_PID_2049_OVP2S_DEFAULT_VALUE (0) > +#define AW_PID_2049_OVP2S_DEFAULT \ > + (AW_PID_2049_OVP2S_DEFAULT_VALUE << AW_PID_2049_OVP2S_START_BIT) > + > +/* UVLS bit 14 (SYSST 0x01) */ > +#define AW_PID_2049_UVLS_START_BIT (14) > +#define AW_PID_2049_UVLS_BITS_LEN (1) > +#define AW_PID_2049_UVLS_MASK \ > + (~(((1<<AW_PID_2049_UVLS_BITS_LEN)-1) << AW_PID_2049_UVLS_START_BIT)) > + > +#define AW_PID_2049_UVLS_NORMAL (0) > +#define AW_PID_2049_UVLS_NORMAL_VALUE \ > + (AW_PID_2049_UVLS_NORMAL << AW_PID_2049_UVLS_START_BIT) > + > +#define AW_PID_2049_UVLS_UVLO (1) > +#define AW_PID_2049_UVLS_UVLO_VALUE \ > + (AW_PID_2049_UVLS_UVLO << AW_PID_2049_UVLS_START_BIT) > + > +#define AW_PID_2049_UVLS_DEFAULT_VALUE (0) > +#define AW_PID_2049_UVLS_DEFAULT \ > + (AW_PID_2049_UVLS_DEFAULT_VALUE << AW_PID_2049_UVLS_START_BIT) > + > +/* ADPS bit 13 (SYSST 0x01) */ > +#define AW_PID_2049_ADPS_START_BIT (13) > +#define AW_PID_2049_ADPS_BITS_LEN (1) > +#define AW_PID_2049_ADPS_MASK \ > + (~(((1<<AW_PID_2049_ADPS_BITS_LEN)-1) << AW_PID_2049_ADPS_START_BIT)) > + > +#define AW_PID_2049_ADPS_TRANSPARENT (0) > +#define AW_PID_2049_ADPS_TRANSPARENT_VALUE \ > + (AW_PID_2049_ADPS_TRANSPARENT << AW_PID_2049_ADPS_START_BIT) > + > +#define AW_PID_2049_ADPS_BOOST (1) > +#define AW_PID_2049_ADPS_BOOST_VALUE \ > + (AW_PID_2049_ADPS_BOOST << AW_PID_2049_ADPS_START_BIT) > + > +#define AW_PID_2049_ADPS_DEFAULT_VALUE (0) > +#define AW_PID_2049_ADPS_DEFAULT \ > + (AW_PID_2049_ADPS_DEFAULT_VALUE << AW_PID_2049_ADPS_START_BIT) > + > +/* DSPS bit 12 (SYSST 0x01) */ > +#define AW_PID_2049_DSPS_START_BIT (12) > +#define AW_PID_2049_DSPS_BITS_LEN (1) > +#define AW_PID_2049_DSPS_MASK \ > + (~(((1<<AW_PID_2049_DSPS_BITS_LEN)-1) << AW_PID_2049_DSPS_START_BIT)) > + > +#define AW_PID_2049_DSPS_NORMAL (0) > +#define AW_PID_2049_DSPS_NORMAL_VALUE \ > + (AW_PID_2049_DSPS_NORMAL << AW_PID_2049_DSPS_START_BIT) > + > +#define AW_PID_2049_DSPS_DSP_STABLE (1) > +#define AW_PID_2049_DSPS_DSP_STABLE_VALUE \ > + (AW_PID_2049_DSPS_DSP_STABLE << AW_PID_2049_DSPS_START_BIT) > + > +#define AW_PID_2049_DSPS_DEFAULT_VALUE (0) > +#define AW_PID_2049_DSPS_DEFAULT \ > + (AW_PID_2049_DSPS_DEFAULT_VALUE << AW_PID_2049_DSPS_START_BIT) > + > +/* BSTOCS bit 11 (SYSST 0x01) */ > +#define AW_PID_2049_BSTOCS_START_BIT (11) > +#define AW_PID_2049_BSTOCS_BITS_LEN (1) > +#define AW_PID_2049_BSTOCS_MASK \ > + (~(((1<<AW_PID_2049_BSTOCS_BITS_LEN)-1) << AW_PID_2049_BSTOCS_START_BIT)) > + > +#define AW_PID_2049_BSTOCS_NORMAL (0) > +#define AW_PID_2049_BSTOCS_NORMAL_VALUE \ > + (AW_PID_2049_BSTOCS_NORMAL << AW_PID_2049_BSTOCS_START_BIT) > + > +#define AW_PID_2049_BSTOCS_OVER_CURRENT (1) > +#define AW_PID_2049_BSTOCS_OVER_CURRENT_VALUE \ > + (AW_PID_2049_BSTOCS_OVER_CURRENT << AW_PID_2049_BSTOCS_START_BIT) > + > +#define AW_PID_2049_BSTOCS_DEFAULT_VALUE (0) > +#define AW_PID_2049_BSTOCS_DEFAULT \ > + (AW_PID_2049_BSTOCS_DEFAULT_VALUE << AW_PID_2049_BSTOCS_START_BIT) > + > +/* OVPS bit 10 (SYSST 0x01) */ > +#define AW_PID_2049_OVPS_START_BIT (10) > +#define AW_PID_2049_OVPS_BITS_LEN (1) > +#define AW_PID_2049_OVPS_MASK \ > + (~(((1<<AW_PID_2049_OVPS_BITS_LEN)-1) << AW_PID_2049_OVPS_START_BIT)) > + > +#define AW_PID_2049_OVPS_NORMAL (0) > +#define AW_PID_2049_OVPS_NORMAL_VALUE \ > + (AW_PID_2049_OVPS_NORMAL << AW_PID_2049_OVPS_START_BIT) > + > +#define AW_PID_2049_OVPS_OVP (1) > +#define AW_PID_2049_OVPS_OVP_VALUE \ > + (AW_PID_2049_OVPS_OVP << AW_PID_2049_OVPS_START_BIT) > + > +#define AW_PID_2049_OVPS_DEFAULT_VALUE (0) > +#define AW_PID_2049_OVPS_DEFAULT \ > + (AW_PID_2049_OVPS_DEFAULT_VALUE << AW_PID_2049_OVPS_START_BIT) > + > +/* BSTS bit 9 (SYSST 0x01) */ > +#define AW_PID_2049_BSTS_START_BIT (9) > +#define AW_PID_2049_BSTS_BITS_LEN (1) > +#define AW_PID_2049_BSTS_MASK \ > + (~(((1<<AW_PID_2049_BSTS_BITS_LEN)-1) << AW_PID_2049_BSTS_START_BIT)) > + > +#define AW_PID_2049_BSTS_NOT_FINISHED (0) > +#define AW_PID_2049_BSTS_NOT_FINISHED_VALUE \ > + (AW_PID_2049_BSTS_NOT_FINISHED << AW_PID_2049_BSTS_START_BIT) > + > +#define AW_PID_2049_BSTS_FINISHED (1) > +#define AW_PID_2049_BSTS_FINISHED_VALUE \ > + (AW_PID_2049_BSTS_FINISHED << AW_PID_2049_BSTS_START_BIT) > + > +#define AW_PID_2049_BSTS_DEFAULT_VALUE (0) > +#define AW_PID_2049_BSTS_DEFAULT \ > + (AW_PID_2049_BSTS_DEFAULT_VALUE << AW_PID_2049_BSTS_START_BIT) > + > +/* SWS bit 8 (SYSST 0x01) */ > +#define AW_PID_2049_SWS_START_BIT (8) > +#define AW_PID_2049_SWS_BITS_LEN (1) > +#define AW_PID_2049_SWS_MASK \ > + (~(((1<<AW_PID_2049_SWS_BITS_LEN)-1) << AW_PID_2049_SWS_START_BIT)) > + > +#define AW_PID_2049_SWS_NOT_SWITCHING (0) > +#define AW_PID_2049_SWS_NOT_SWITCHING_VALUE \ > + (AW_PID_2049_SWS_NOT_SWITCHING << AW_PID_2049_SWS_START_BIT) > + > +#define AW_PID_2049_SWS_SWITCHING (1) > +#define AW_PID_2049_SWS_SWITCHING_VALUE \ > + (AW_PID_2049_SWS_SWITCHING << AW_PID_2049_SWS_START_BIT) > + > +#define AW_PID_2049_SWS_DEFAULT_VALUE (0) > +#define AW_PID_2049_SWS_DEFAULT \ > + (AW_PID_2049_SWS_DEFAULT_VALUE << AW_PID_2049_SWS_START_BIT) > + > +/* CLIPS bit 7 (SYSST 0x01) */ > +#define AW_PID_2049_CLIPS_START_BIT (7) > +#define AW_PID_2049_CLIPS_BITS_LEN (1) > +#define AW_PID_2049_CLIPS_MASK \ > + (~(((1<<AW_PID_2049_CLIPS_BITS_LEN)-1) << AW_PID_2049_CLIPS_START_BIT)) > + > +#define AW_PID_2049_CLIPS_NOT_CLIPPING (0) > +#define AW_PID_2049_CLIPS_NOT_CLIPPING_VALUE \ > + (AW_PID_2049_CLIPS_NOT_CLIPPING << AW_PID_2049_CLIPS_START_BIT) > + > +#define AW_PID_2049_CLIPS_CLIPPING (1) > +#define AW_PID_2049_CLIPS_CLIPPING_VALUE \ > + (AW_PID_2049_CLIPS_CLIPPING << AW_PID_2049_CLIPS_START_BIT) > + > +#define AW_PID_2049_CLIPS_DEFAULT_VALUE (0) > +#define AW_PID_2049_CLIPS_DEFAULT \ > + (AW_PID_2049_CLIPS_DEFAULT_VALUE << AW_PID_2049_CLIPS_START_BIT) > + > +/* WDS bit 6 (SYSST 0x01) */ > +#define AW_PID_2049_WDS_START_BIT (6) > +#define AW_PID_2049_WDS_BITS_LEN (1) > +#define AW_PID_2049_WDS_MASK \ > + (~(((1<<AW_PID_2049_WDS_BITS_LEN)-1) << AW_PID_2049_WDS_START_BIT)) > + > +#define AW_PID_2049_WDS_NORMAL (0) > +#define AW_PID_2049_WDS_NORMAL_VALUE \ > + (AW_PID_2049_WDS_NORMAL << AW_PID_2049_WDS_START_BIT) > + > +#define AW_PID_2049_WDS_ABNORMAL (1) > +#define AW_PID_2049_WDS_ABNORMAL_VALUE \ > + (AW_PID_2049_WDS_ABNORMAL << AW_PID_2049_WDS_START_BIT) > + > +#define AW_PID_2049_WDS_DEFAULT_VALUE (0) > +#define AW_PID_2049_WDS_DEFAULT \ > + (AW_PID_2049_WDS_DEFAULT_VALUE << AW_PID_2049_WDS_START_BIT) > + > +/* NOCLKS bit 5 (SYSST 0x01) */ > +#define AW_PID_2049_NOCLKS_START_BIT (5) > +#define AW_PID_2049_NOCLKS_BITS_LEN (1) > +#define AW_PID_2049_NOCLKS_MASK \ > + (~(((1<<AW_PID_2049_NOCLKS_BITS_LEN)-1) << AW_PID_2049_NOCLKS_START_BIT)) > + > +#define AW_PID_2049_NOCLKS_CLOCK_OK (0) > +#define AW_PID_2049_NOCLKS_CLOCK_OK_VALUE \ > + (AW_PID_2049_NOCLKS_CLOCK_OK << AW_PID_2049_NOCLKS_START_BIT) > + > +#define AW_PID_2049_NOCLKS_NO_CLOCK (1) > +#define AW_PID_2049_NOCLKS_NO_CLOCK_VALUE \ > + (AW_PID_2049_NOCLKS_NO_CLOCK << AW_PID_2049_NOCLKS_START_BIT) > + > +#define AW_PID_2049_NOCLKS_DEFAULT_VALUE (0) > +#define AW_PID_2049_NOCLKS_DEFAULT \ > + (AW_PID_2049_NOCLKS_DEFAULT_VALUE << AW_PID_2049_NOCLKS_START_BIT) > + > +/* CLKS bit 4 (SYSST 0x01) */ > +#define AW_PID_2049_CLKS_START_BIT (4) > +#define AW_PID_2049_CLKS_BITS_LEN (1) > +#define AW_PID_2049_CLKS_MASK \ > + (~(((1<<AW_PID_2049_CLKS_BITS_LEN)-1) << AW_PID_2049_CLKS_START_BIT)) > + > +#define AW_PID_2049_CLKS_NOT_STABLE (0) > +#define AW_PID_2049_CLKS_NOT_STABLE_VALUE \ > + (AW_PID_2049_CLKS_NOT_STABLE << AW_PID_2049_CLKS_START_BIT) > + > +#define AW_PID_2049_CLKS_STABLE (1) > +#define AW_PID_2049_CLKS_STABLE_VALUE \ > + (AW_PID_2049_CLKS_STABLE << AW_PID_2049_CLKS_START_BIT) > + > +#define AW_PID_2049_CLKS_DEFAULT_VALUE (0) > +#define AW_PID_2049_CLKS_DEFAULT \ > + (AW_PID_2049_CLKS_DEFAULT_VALUE << AW_PID_2049_CLKS_START_BIT) > + > +/* OCDS bit 3 (SYSST 0x01) */ > +#define AW_PID_2049_OCDS_START_BIT (3) > +#define AW_PID_2049_OCDS_BITS_LEN (1) > +#define AW_PID_2049_OCDS_MASK \ > + (~(((1<<AW_PID_2049_OCDS_BITS_LEN)-1) << AW_PID_2049_OCDS_START_BIT)) > + > +#define AW_PID_2049_OCDS_NORAML (0) > +#define AW_PID_2049_OCDS_NORAML_VALUE \ > + (AW_PID_2049_OCDS_NORAML << AW_PID_2049_OCDS_START_BIT) > + > +#define AW_PID_2049_OCDS_OC (1) > +#define AW_PID_2049_OCDS_OC_VALUE \ > + (AW_PID_2049_OCDS_OC << AW_PID_2049_OCDS_START_BIT) > + > +#define AW_PID_2049_OCDS_DEFAULT_VALUE (0) > +#define AW_PID_2049_OCDS_DEFAULT \ > + (AW_PID_2049_OCDS_DEFAULT_VALUE << AW_PID_2049_OCDS_START_BIT) > + > +/* CLIP_PRES bit 2 (SYSST 0x01) */ > +#define AW_PID_2049_CLIP_PRES_START_BIT (2) > +#define AW_PID_2049_CLIP_PRES_BITS_LEN (1) > +#define AW_PID_2049_CLIP_PRES_MASK \ > + (~(((1<<AW_PID_2049_CLIP_PRES_BITS_LEN)-1) << AW_PID_2049_CLIP_PRES_START_BIT)) > + > +#define AW_PID_2049_CLIP_PRES_NOT_CLIPPING (0) > +#define AW_PID_2049_CLIP_PRES_NOT_CLIPPING_VALUE \ > + (AW_PID_2049_CLIP_PRES_NOT_CLIPPING << AW_PID_2049_CLIP_PRES_START_BIT) > + > +#define AW_PID_2049_CLIP_PRES_CLIPPING (1) > +#define AW_PID_2049_CLIP_PRES_CLIPPING_VALUE \ > + (AW_PID_2049_CLIP_PRES_CLIPPING << AW_PID_2049_CLIP_PRES_START_BIT) > + > +#define AW_PID_2049_CLIP_PRES_DEFAULT_VALUE (0) > +#define AW_PID_2049_CLIP_PRES_DEFAULT \ > + (AW_PID_2049_CLIP_PRES_DEFAULT_VALUE << AW_PID_2049_CLIP_PRES_START_BIT) > + > +/* OTHS bit 1 (SYSST 0x01) */ > +#define AW_PID_2049_OTHS_START_BIT (1) > +#define AW_PID_2049_OTHS_BITS_LEN (1) > +#define AW_PID_2049_OTHS_MASK \ > + (~(((1<<AW_PID_2049_OTHS_BITS_LEN)-1) << AW_PID_2049_OTHS_START_BIT)) > + > +#define AW_PID_2049_OTHS_NORMAL (0) > +#define AW_PID_2049_OTHS_NORMAL_VALUE \ > + (AW_PID_2049_OTHS_NORMAL << AW_PID_2049_OTHS_START_BIT) > + > +#define AW_PID_2049_OTHS_OT (1) > +#define AW_PID_2049_OTHS_OT_VALUE \ > + (AW_PID_2049_OTHS_OT << AW_PID_2049_OTHS_START_BIT) > + > +#define AW_PID_2049_OTHS_DEFAULT_VALUE (0) > +#define AW_PID_2049_OTHS_DEFAULT \ > + (AW_PID_2049_OTHS_DEFAULT_VALUE << AW_PID_2049_OTHS_START_BIT) > + > +/* PLLS bit 0 (SYSST 0x01) */ > +#define AW_PID_2049_PLLS_START_BIT (0) > +#define AW_PID_2049_PLLS_BITS_LEN (1) > +#define AW_PID_2049_PLLS_MASK \ > + (~(((1<<AW_PID_2049_PLLS_BITS_LEN)-1) << AW_PID_2049_PLLS_START_BIT)) > + > +#define AW_PID_2049_PLLS_UNLOCKED (0) > +#define AW_PID_2049_PLLS_UNLOCKED_VALUE \ > + (AW_PID_2049_PLLS_UNLOCKED << AW_PID_2049_PLLS_START_BIT) > + > +#define AW_PID_2049_PLLS_LOCKED (1) > +#define AW_PID_2049_PLLS_LOCKED_VALUE \ > + (AW_PID_2049_PLLS_LOCKED << AW_PID_2049_PLLS_START_BIT) > + > +#define AW_PID_2049_PLLS_DEFAULT_VALUE (0) > +#define AW_PID_2049_PLLS_DEFAULT \ > + (AW_PID_2049_PLLS_DEFAULT_VALUE << AW_PID_2049_PLLS_START_BIT) > + > + > + > +#define AW_PID_2049_BIT_PLL_CHECK \ > + (AW_PID_2049_CLKS_STABLE_VALUE | \ > + AW_PID_2049_PLLS_LOCKED_VALUE) > + > + > +#define AW_PID_2049_BIT_SYSST_CHECK_MASK \ > + (~(AW_PID_2049_UVLS_NORMAL_VALUE | \ > + AW_PID_2049_BSTOCS_OVER_CURRENT_VALUE | \ > + AW_PID_2049_BSTS_FINISHED_VALUE | \ > + AW_PID_2049_SWS_SWITCHING_VALUE | \ > + AW_PID_2049_NOCLKS_NO_CLOCK_VALUE | \ > + AW_PID_2049_CLKS_STABLE_VALUE | \ > + AW_PID_2049_OCDS_OC_VALUE | \ > + AW_PID_2049_OTHS_OT_VALUE | \ > + AW_PID_2049_PLLS_LOCKED_VALUE)) > + > +#define AW_PID_2049_BIT_SYSST_CHECK \ > + (AW_PID_2049_BSTS_FINISHED_VALUE | \ > + AW_PID_2049_SWS_SWITCHING_VALUE | \ > + AW_PID_2049_CLKS_STABLE_VALUE | \ > + AW_PID_2049_PLLS_LOCKED_VALUE) > + > +/* default value of SYSST (0x01) */ > +/* #define AW_PID_2049_SYSST_DEFAULT (0x0000) */ > + > +/* SYSINT (0x02) detail */ > +/* OVP2I bit 15 (SYSINT 0x02) */ > +#define AW_PID_2049_OVP2I_START_BIT (15) > +#define AW_PID_2049_OVP2I_BITS_LEN (1) > +#define AW_PID_2049_OVP2I_MASK \ > + (~(((1<<AW_PID_2049_OVP2I_BITS_LEN)-1) << AW_PID_2049_OVP2I_START_BIT)) > + > +#define AW_PID_2049_OVP2I_DEFAULT_VALUE (0) > +#define AW_PID_2049_OVP2I_DEFAULT \ > + (AW_PID_2049_OVP2I_DEFAULT_VALUE << AW_PID_2049_OVP2I_START_BIT) > + > +/* UVLI bit 14 (SYSINT 0x02) */ > +#define AW_PID_2049_UVLI_START_BIT (14) > +#define AW_PID_2049_UVLI_BITS_LEN (1) > +#define AW_PID_2049_UVLI_MASK \ > + (~(((1<<AW_PID_2049_UVLI_BITS_LEN)-1) << AW_PID_2049_UVLI_START_BIT)) > + > +#define AW_PID_2049_UVLI_DEFAULT_VALUE (0) > +#define AW_PID_2049_UVLI_DEFAULT \ > + (AW_PID_2049_UVLI_DEFAULT_VALUE << AW_PID_2049_UVLI_START_BIT) > + > +/* ADPI bit 13 (SYSINT 0x02) */ > +#define AW_PID_2049_ADPI_START_BIT (13) > +#define AW_PID_2049_ADPI_BITS_LEN (1) > +#define AW_PID_2049_ADPI_MASK \ > + (~(((1<<AW_PID_2049_ADPI_BITS_LEN)-1) << AW_PID_2049_ADPI_START_BIT)) > + > +#define AW_PID_2049_ADPI_DEFAULT_VALUE (0) > +#define AW_PID_2049_ADPI_DEFAULT \ > + (AW_PID_2049_ADPI_DEFAULT_VALUE << AW_PID_2049_ADPI_START_BIT) > + > +/* DSPI bit 12 (SYSINT 0x02) */ > +#define AW_PID_2049_DSPI_START_BIT (12) > +#define AW_PID_2049_DSPI_BITS_LEN (1) > +#define AW_PID_2049_DSPI_MASK \ > + (~(((1<<AW_PID_2049_DSPI_BITS_LEN)-1) << AW_PID_2049_DSPI_START_BIT)) > + > +#define AW_PID_2049_DSPI_DEFAULT_VALUE (0) > +#define AW_PID_2049_DSPI_DEFAULT \ > + (AW_PID_2049_DSPI_DEFAULT_VALUE << AW_PID_2049_DSPI_START_BIT) > + > +/* BSTOCI bit 11 (SYSINT 0x02) */ > +#define AW_PID_2049_BSTOCI_START_BIT (11) > +#define AW_PID_2049_BSTOCI_BITS_LEN (1) > +#define AW_PID_2049_BSTOCI_MASK \ > + (~(((1<<AW_PID_2049_BSTOCI_BITS_LEN)-1) << AW_PID_2049_BSTOCI_START_BIT)) > + > +#define AW_PID_2049_BSTOCI_DEFAULT_VALUE (0) > +#define AW_PID_2049_BSTOCI_DEFAULT \ > + (AW_PID_2049_BSTOCI_DEFAULT_VALUE << AW_PID_2049_BSTOCI_START_BIT) > + > +/* OVPI bit 10 (SYSINT 0x02) */ > +#define AW_PID_2049_OVPI_START_BIT (10) > +#define AW_PID_2049_OVPI_BITS_LEN (1) > +#define AW_PID_2049_OVPI_MASK \ > + (~(((1<<AW_PID_2049_OVPI_BITS_LEN)-1) << AW_PID_2049_OVPI_START_BIT)) > + > +#define AW_PID_2049_OVPI_DEFAULT_VALUE (0) > +#define AW_PID_2049_OVPI_DEFAULT \ > + (AW_PID_2049_OVPI_DEFAULT_VALUE << AW_PID_2049_OVPI_START_BIT) > + > +/* BSTI bit 9 (SYSINT 0x02) */ > +#define AW_PID_2049_BSTI_START_BIT (9) > +#define AW_PID_2049_BSTI_BITS_LEN (1) > +#define AW_PID_2049_BSTI_MASK \ > + (~(((1<<AW_PID_2049_BSTI_BITS_LEN)-1) << AW_PID_2049_BSTI_START_BIT)) > + > +#define AW_PID_2049_BSTI_DEFAULT_VALUE (0) > +#define AW_PID_2049_BSTI_DEFAULT \ > + (AW_PID_2049_BSTI_DEFAULT_VALUE << AW_PID_2049_BSTI_START_BIT) > + > +/* SWI bit 8 (SYSINT 0x02) */ > +#define AW_PID_2049_SWI_START_BIT (8) > +#define AW_PID_2049_SWI_BITS_LEN (1) > +#define AW_PID_2049_SWI_MASK \ > + (~(((1<<AW_PID_2049_SWI_BITS_LEN)-1) << AW_PID_2049_SWI_START_BIT)) > + > +#define AW_PID_2049_SWI_DEFAULT_VALUE (0) > +#define AW_PID_2049_SWI_DEFAULT \ > + (AW_PID_2049_SWI_DEFAULT_VALUE << AW_PID_2049_SWI_START_BIT) > + > +/* CLIPI bit 7 (SYSINT 0x02) */ > +#define AW_PID_2049_CLIPI_START_BIT (7) > +#define AW_PID_2049_CLIPI_BITS_LEN (1) > +#define AW_PID_2049_CLIPI_MASK \ > + (~(((1<<AW_PID_2049_CLIPI_BITS_LEN)-1) << AW_PID_2049_CLIPI_START_BIT)) > + > +#define AW_PID_2049_CLIPI_DEFAULT_VALUE (0) > +#define AW_PID_2049_CLIPI_DEFAULT \ > + (AW_PID_2049_CLIPI_DEFAULT_VALUE << AW_PID_2049_CLIPI_START_BIT) > + > +/* WDI bit 6 (SYSINT 0x02) */ > +#define AW_PID_2049_WDI_START_BIT (6) > +#define AW_PID_2049_WDI_BITS_LEN (1) > +#define AW_PID_2049_WDI_MASK \ > + (~(((1<<AW_PID_2049_WDI_BITS_LEN)-1) << AW_PID_2049_WDI_START_BIT)) > + > +#define AW_PID_2049_WDI_DEFAULT_VALUE (0) > +#define AW_PID_2049_WDI_INT_VALUE (1) > +#define AW_PID_2049_WDI_DEFAULT \ > + (AW_PID_2049_WDI_DEFAULT_VALUE << AW_PID_2049_WDI_START_BIT) > +#define AW_PID_2049_WDI_INTERRUPT \ > + (AW_PID_2049_WDI_INT_VALUE << AW_PID_2049_WDI_START_BIT) > + > +/* NOCLKI bit 5 (SYSINT 0x02) */ > +#define AW_PID_2049_NOCLKI_START_BIT (5) > +#define AW_PID_2049_NOCLKI_BITS_LEN (1) > +#define AW_PID_2049_NOCLKI_MASK \ > + (~(((1<<AW_PID_2049_NOCLKI_BITS_LEN)-1) << AW_PID_2049_NOCLKI_START_BIT)) > + > +#define AW_PID_2049_NOCLKI_DEFAULT_VALUE (0) > +#define AW_PID_2049_NOCLKI_INT_VALUE (1) > +#define AW_PID_2049_NOCLKI_DEFAULT \ > + (AW_PID_2049_NOCLKI_DEFAULT_VALUE << AW_PID_2049_NOCLKI_START_BIT) > +#define AW_PID_2049_NOCLKI_INTERRUPT \ > + (AW_PID_2049_NOCLKI_INT_VALUE << AW_PID_2049_NOCLKI_START_BIT) > + > +/* CLKI bit 4 (SYSINT 0x02) */ > +#define AW_PID_2049_CLKI_START_BIT (4) > +#define AW_PID_2049_CLKI_BITS_LEN (1) > +#define AW_PID_2049_CLKI_MASK \ > + (~(((1<<AW_PID_2049_CLKI_BITS_LEN)-1) << AW_PID_2049_CLKI_START_BIT)) > + > +#define AW_PID_2049_CLKI_DEFAULT_VALUE (0) > +#define AW_PID_2049_CLKI_INT_VALUE (1) > +#define AW_PID_2049_CLKI_DEFAULT \ > + (AW_PID_2049_CLKI_DEFAULT_VALUE << AW_PID_2049_CLKI_START_BIT) > +#define AW_PID_2049_CLKI_INTERRUPT \ > + (AW_PID_2049_CLKI_INT_VALUE << AW_PID_2049_CLKI_START_BIT) > + > +/* OCDI bit 3 (SYSINT 0x02) */ > +#define AW_PID_2049_OCDI_START_BIT (3) > +#define AW_PID_2049_OCDI_BITS_LEN (1) > +#define AW_PID_2049_OCDI_MASK \ > + (~(((1<<AW_PID_2049_OCDI_BITS_LEN)-1) << AW_PID_2049_OCDI_START_BIT)) > + > +#define AW_PID_2049_OCDI_DEFAULT_VALUE (0) > +#define AW_PID_2049_OCDI_DEFAULT \ > + (AW_PID_2049_OCDI_DEFAULT_VALUE << AW_PID_2049_OCDI_START_BIT) > + > +/* CLIP_PREI bit 2 (SYSINT 0x02) */ > +#define AW_PID_2049_CLIP_PREI_START_BIT (2) > +#define AW_PID_2049_CLIP_PREI_BITS_LEN (1) > +#define AW_PID_2049_CLIP_PREI_MASK \ > + (~(((1<<AW_PID_2049_CLIP_PREI_BITS_LEN)-1) << AW_PID_2049_CLIP_PREI_START_BIT)) > + > +#define AW_PID_2049_CLIP_PREI_DEFAULT_VALUE (0) > +#define AW_PID_2049_CLIP_PREI_DEFAULT \ > + (AW_PID_2049_CLIP_PREI_DEFAULT_VALUE << AW_PID_2049_CLIP_PREI_START_BIT) > + > +/* OTHI bit 1 (SYSINT 0x02) */ > +#define AW_PID_2049_OTHI_START_BIT (1) > +#define AW_PID_2049_OTHI_BITS_LEN (1) > +#define AW_PID_2049_OTHI_MASK \ > + (~(((1<<AW_PID_2049_OTHI_BITS_LEN)-1) << AW_PID_2049_OTHI_START_BIT)) > + > +#define AW_PID_2049_OTHI_DEFAULT_VALUE (0) > +#define AW_PID_2049_OTHI_DEFAULT \ > + (AW_PID_2049_OTHI_DEFAULT_VALUE << AW_PID_2049_OTHI_START_BIT) > + > +/* PLLI bit 0 (SYSINT 0x02) */ > +#define AW_PID_2049_PLLI_START_BIT (0) > +#define AW_PID_2049_PLLI_BITS_LEN (1) > +#define AW_PID_2049_PLLI_MASK \ > + (~(((1<<AW_PID_2049_PLLI_BITS_LEN)-1) << AW_PID_2049_PLLI_START_BIT)) > + > +#define AW_PID_2049_PLLI_DEFAULT_VALUE (0) > +#define AW_PID_2049_PLLI_INT_VALUE (1) > +#define AW_PID_2049_PLLI_DEFAULT \ > + (AW_PID_2049_PLLI_DEFAULT_VALUE << AW_PID_2049_PLLI_START_BIT) > +#define AW_PID_2049_PLLI_INTERRUPT \ > + (AW_PID_2049_PLLI_INT_VALUE << AW_PID_2049_PLLI_START_BIT) > + > +/* default value of SYSINT (0x02) */ > +/* #define AW_PID_2049_SYSINT_DEFAULT (0x0000) */ > + > +#define AW_PID_2049_BIT_SYSINT_CHECK \ > + (AW_PID_2049_WDI_INTERRUPT | \ > + AW_PID_2049_CLKI_INTERRUPT | \ > + AW_PID_2049_NOCLKI_INTERRUPT | \ > + AW_PID_2049_PLLI_INTERRUPT) > + > +/* SYSINTM (0x03) detail */ > +/* OVP2M bit 15 (SYSINTM 0x03) */ > +#define AW_PID_2049_OVP2M_START_BIT (15) > +#define AW_PID_2049_OVP2M_BITS_LEN (1) > +#define AW_PID_2049_OVP2M_MASK \ > + (~(((1<<AW_PID_2049_OVP2M_BITS_LEN)-1) << AW_PID_2049_OVP2M_START_BIT)) > + > +#define AW_PID_2049_OVP2M_DEFAULT_VALUE (1) > +#define AW_PID_2049_OVP2M_DEFAULT \ > + (AW_PID_2049_OVP2M_DEFAULT_VALUE << AW_PID_2049_OVP2M_START_BIT) > + > +/* UVLM bit 14 (SYSINTM 0x03) */ > +#define AW_PID_2049_UVLM_START_BIT (14) > +#define AW_PID_2049_UVLM_BITS_LEN (1) > +#define AW_PID_2049_UVLM_MASK \ > + (~(((1<<AW_PID_2049_UVLM_BITS_LEN)-1) << AW_PID_2049_UVLM_START_BIT)) > + > +#define AW_PID_2049_UVLM_DEFAULT_VALUE (1) > +#define AW_PID_2049_UVLM_DEFAULT \ > + (AW_PID_2049_UVLM_DEFAULT_VALUE << AW_PID_2049_UVLM_START_BIT) > + > +/* ADPM bit 13 (SYSINTM 0x03) */ > +#define AW_PID_2049_ADPM_START_BIT (13) > +#define AW_PID_2049_ADPM_BITS_LEN (1) > +#define AW_PID_2049_ADPM_MASK \ > + (~(((1<<AW_PID_2049_ADPM_BITS_LEN)-1) << AW_PID_2049_ADPM_START_BIT)) > + > +#define AW_PID_2049_ADPM_DEFAULT_VALUE (1) > +#define AW_PID_2049_ADPM_DEFAULT \ > + (AW_PID_2049_ADPM_DEFAULT_VALUE << AW_PID_2049_ADPM_START_BIT) > + > +/* DSPM bit 12 (SYSINTM 0x03) */ > +#define AW_PID_2049_DSPM_START_BIT (12) > +#define AW_PID_2049_DSPM_BITS_LEN (1) > +#define AW_PID_2049_DSPM_MASK \ > + (~(((1<<AW_PID_2049_DSPM_BITS_LEN)-1) << AW_PID_2049_DSPM_START_BIT)) > + > +#define AW_PID_2049_DSPM_DEFAULT_VALUE (1) > +#define AW_PID_2049_DSPM_DEFAULT \ > + (AW_PID_2049_DSPM_DEFAULT_VALUE << AW_PID_2049_DSPM_START_BIT) > + > +/* BSTOCM bit 11 (SYSINTM 0x03) */ > +#define AW_PID_2049_BSTOCM_START_BIT (11) > +#define AW_PID_2049_BSTOCM_BITS_LEN (1) > +#define AW_PID_2049_BSTOCM_MASK \ > + (~(((1<<AW_PID_2049_BSTOCM_BITS_LEN)-1) << AW_PID_2049_BSTOCM_START_BIT)) > + > +#define AW_PID_2049_BSTOCM_DEFAULT_VALUE (1) > +#define AW_PID_2049_BSTOCM_DEFAULT \ > + (AW_PID_2049_BSTOCM_DEFAULT_VALUE << AW_PID_2049_BSTOCM_START_BIT) > + > +/* OVPM bit 10 (SYSINTM 0x03) */ > +#define AW_PID_2049_OVPM_START_BIT (10) > +#define AW_PID_2049_OVPM_BITS_LEN (1) > +#define AW_PID_2049_OVPM_MASK \ > + (~(((1<<AW_PID_2049_OVPM_BITS_LEN)-1) << AW_PID_2049_OVPM_START_BIT)) > + > +#define AW_PID_2049_OVPM_DEFAULT_VALUE (1) > +#define AW_PID_2049_OVPM_DEFAULT \ > + (AW_PID_2049_OVPM_DEFAULT_VALUE << AW_PID_2049_OVPM_START_BIT) > + > +/* BSTM bit 9 (SYSINTM 0x03) */ > +#define AW_PID_2049_BSTM_START_BIT (9) > +#define AW_PID_2049_BSTM_BITS_LEN (1) > +#define AW_PID_2049_BSTM_MASK \ > + (~(((1<<AW_PID_2049_BSTM_BITS_LEN)-1) << AW_PID_2049_BSTM_START_BIT)) > + > +#define AW_PID_2049_BSTM_DEFAULT_VALUE (1) > +#define AW_PID_2049_BSTM_DEFAULT \ > + (AW_PID_2049_BSTM_DEFAULT_VALUE << AW_PID_2049_BSTM_START_BIT) > + > +/* SWM bit 8 (SYSINTM 0x03) */ > +#define AW_PID_2049_SWM_START_BIT (8) > +#define AW_PID_2049_SWM_BITS_LEN (1) > +#define AW_PID_2049_SWM_MASK \ > + (~(((1<<AW_PID_2049_SWM_BITS_LEN)-1) << AW_PID_2049_SWM_START_BIT)) > + > +#define AW_PID_2049_SWM_DEFAULT_VALUE (1) > +#define AW_PID_2049_SWM_DEFAULT \ > + (AW_PID_2049_SWM_DEFAULT_VALUE << AW_PID_2049_SWM_START_BIT) > + > +/* CLIPM bit 7 (SYSINTM 0x03) */ > +#define AW_PID_2049_CLIPM_START_BIT (7) > +#define AW_PID_2049_CLIPM_BITS_LEN (1) > +#define AW_PID_2049_CLIPM_MASK \ > + (~(((1<<AW_PID_2049_CLIPM_BITS_LEN)-1) << AW_PID_2049_CLIPM_START_BIT)) > + > +#define AW_PID_2049_CLIPM_DEFAULT_VALUE (1) > +#define AW_PID_2049_CLIPM_DEFAULT \ > + (AW_PID_2049_CLIPM_DEFAULT_VALUE << AW_PID_2049_CLIPM_START_BIT) > + > +/* WDM bit 6 (SYSINTM 0x03) */ > +#define AW_PID_2049_WDM_START_BIT (6) > +#define AW_PID_2049_WDM_BITS_LEN (1) > +#define AW_PID_2049_WDM_MASK \ > + (~(((1<<AW_PID_2049_WDM_BITS_LEN)-1) << AW_PID_2049_WDM_START_BIT)) > + > +#define AW_PID_2049_WDM_DEFAULT_VALUE (1) > +#define AW_PID_2049_WDM_DEFAULT \ > + (AW_PID_2049_WDM_DEFAULT_VALUE << AW_PID_2049_WDM_START_BIT) > + > +/* NOCLKM bit 5 (SYSINTM 0x03) */ > +#define AW_PID_2049_NOCLKM_START_BIT (5) > +#define AW_PID_2049_NOCLKM_BITS_LEN (1) > +#define AW_PID_2049_NOCLKM_MASK \ > + (~(((1<<AW_PID_2049_NOCLKM_BITS_LEN)-1) << AW_PID_2049_NOCLKM_START_BIT)) > + > +#define AW_PID_2049_NOCLKM_DEFAULT_VALUE (1) > +#define AW_PID_2049_NOCLKM_DEFAULT \ > + (AW_PID_2049_NOCLKM_DEFAULT_VALUE << AW_PID_2049_NOCLKM_START_BIT) > + > +/* CLKM bit 4 (SYSINTM 0x03) */ > +#define AW_PID_2049_CLKM_START_BIT (4) > +#define AW_PID_2049_CLKM_BITS_LEN (1) > +#define AW_PID_2049_CLKM_MASK \ > + (~(((1<<AW_PID_2049_CLKM_BITS_LEN)-1) << AW_PID_2049_CLKM_START_BIT)) > + > +#define AW_PID_2049_CLKM_DEFAULT_VALUE (1) > +#define AW_PID_2049_CLKM_DEFAULT \ > + (AW_PID_2049_CLKM_DEFAULT_VALUE << AW_PID_2049_CLKM_START_BIT) > + > +/* OCDM bit 3 (SYSINTM 0x03) */ > +#define AW_PID_2049_OCDM_START_BIT (3) > +#define AW_PID_2049_OCDM_BITS_LEN (1) > +#define AW_PID_2049_OCDM_MASK \ > + (~(((1<<AW_PID_2049_OCDM_BITS_LEN)-1) << AW_PID_2049_OCDM_START_BIT)) > + > +#define AW_PID_2049_OCDM_DEFAULT_VALUE (1) > +#define AW_PID_2049_OCDM_DEFAULT \ > + (AW_PID_2049_OCDM_DEFAULT_VALUE << AW_PID_2049_OCDM_START_BIT) > + > +/* CLIP_PREM bit 2 (SYSINTM 0x03) */ > +#define AW_PID_2049_CLIP_PREM_START_BIT (2) > +#define AW_PID_2049_CLIP_PREM_BITS_LEN (1) > +#define AW_PID_2049_CLIP_PREM_MASK \ > + (~(((1<<AW_PID_2049_CLIP_PREM_BITS_LEN)-1) << AW_PID_2049_CLIP_PREM_START_BIT)) > + > +#define AW_PID_2049_CLIP_PREM_DEFAULT_VALUE (1) > +#define AW_PID_2049_CLIP_PREM_DEFAULT \ > + (AW_PID_2049_CLIP_PREM_DEFAULT_VALUE << AW_PID_2049_CLIP_PREM_START_BIT) > + > +/* OTHM bit 1 (SYSINTM 0x03) */ > +#define AW_PID_2049_OTHM_START_BIT (1) > +#define AW_PID_2049_OTHM_BITS_LEN (1) > +#define AW_PID_2049_OTHM_MASK \ > + (~(((1<<AW_PID_2049_OTHM_BITS_LEN)-1) << AW_PID_2049_OTHM_START_BIT)) > + > +#define AW_PID_2049_OTHM_DEFAULT_VALUE (1) > +#define AW_PID_2049_OTHM_DEFAULT \ > + (AW_PID_2049_OTHM_DEFAULT_VALUE << AW_PID_2049_OTHM_START_BIT) > + > +/* PLLM bit 0 (SYSINTM 0x03) */ > +#define AW_PID_2049_PLLM_START_BIT (0) > +#define AW_PID_2049_PLLM_BITS_LEN (1) > +#define AW_PID_2049_PLLM_MASK \ > + (~(((1<<AW_PID_2049_PLLM_BITS_LEN)-1) << AW_PID_2049_PLLM_START_BIT)) > + > +#define AW_PID_2049_PLLM_DEFAULT_VALUE (1) > +#define AW_PID_2049_PLLM_DEFAULT \ > + (AW_PID_2049_PLLM_DEFAULT_VALUE << AW_PID_2049_PLLM_START_BIT) > + > +/* default value of SYSINTM (0x03) */ > +#define AW_PID_2049_SYSINTM_DEFAULT (0xFFFF) > + > +/* SYSCTRL (0x04) detail */ > +/* SPK_GAIN bit 14:12 (SYSCTRL 0x04) */ > +#define AW_PID_2049_SPK_GAIN_START_BIT (12) > +#define AW_PID_2049_SPK_GAIN_BITS_LEN (3) > +#define AW_PID_2049_SPK_GAIN_MASK \ > + (~(((1<<AW_PID_2049_SPK_GAIN_BITS_LEN)-1) << AW_PID_2049_SPK_GAIN_START_BIT)) > + > +#define AW_PID_2049_SPK_GAIN_4_AV (0) > +#define AW_PID_2049_SPK_GAIN_4_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_4_AV << AW_PID_2049_SPK_GAIN_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_4P67_AV (1) > +#define AW_PID_2049_SPK_GAIN_4P67_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_4P67_AV << AW_PID_2049_SPK_GAIN_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_6_AV (2) > +#define AW_PID_2049_SPK_GAIN_6_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_6_AV << AW_PID_2049_SPK_GAIN_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_7_AV (3) > +#define AW_PID_2049_SPK_GAIN_7_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_7_AV << AW_PID_2049_SPK_GAIN_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_12_AV (4) > +#define AW_PID_2049_SPK_GAIN_12_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_12_AV << AW_PID_2049_SPK_GAIN_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_14_AV (5) > +#define AW_PID_2049_SPK_GAIN_14_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_14_AV << AW_PID_2049_SPK_GAIN_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_DEFAULT_VALUE (0x5) > +#define AW_PID_2049_SPK_GAIN_DEFAULT \ > + (AW_PID_2049_SPK_GAIN_DEFAULT_VALUE << AW_PID_2049_SPK_GAIN_START_BIT) > + > +/* RMSE bit 11 (SYSCTRL 0x04) */ > +#define AW_PID_2049_RMSE_START_BIT (11) > +#define AW_PID_2049_RMSE_BITS_LEN (1) > +#define AW_PID_2049_RMSE_MASK \ > + (~(((1<<AW_PID_2049_RMSE_BITS_LEN)-1) << AW_PID_2049_RMSE_START_BIT)) > + > +#define AW_PID_2049_RMSE_PEAK_AGC (0) > +#define AW_PID_2049_RMSE_PEAK_AGC_VALUE \ > + (AW_PID_2049_RMSE_PEAK_AGC << AW_PID_2049_RMSE_START_BIT) > + > +#define AW_PID_2049_RMSE_RMS_AGC (1) > +#define AW_PID_2049_RMSE_RMS_AGC_VALUE \ > + (AW_PID_2049_RMSE_RMS_AGC << AW_PID_2049_RMSE_START_BIT) > + > +#define AW_PID_2049_RMSE_DEFAULT_VALUE (0) > +#define AW_PID_2049_RMSE_DEFAULT \ > + (AW_PID_2049_RMSE_DEFAULT_VALUE << AW_PID_2049_RMSE_START_BIT) > + > +/* HAGCE bit 10 (SYSCTRL 0x04) */ > +#define AW_PID_2049_HAGCE_START_BIT (10) > +#define AW_PID_2049_HAGCE_BITS_LEN (1) > +#define AW_PID_2049_HAGCE_MASK \ > + (~(((1<<AW_PID_2049_HAGCE_BITS_LEN)-1) << AW_PID_2049_HAGCE_START_BIT)) > + > +#define AW_PID_2049_HAGCE_DISABLE (0) > +#define AW_PID_2049_HAGCE_DISABLE_VALUE \ > + (AW_PID_2049_HAGCE_DISABLE << AW_PID_2049_HAGCE_START_BIT) > + > +#define AW_PID_2049_HAGCE_ENABLE (1) > +#define AW_PID_2049_HAGCE_ENABLE_VALUE \ > + (AW_PID_2049_HAGCE_ENABLE << AW_PID_2049_HAGCE_START_BIT) > + > +#define AW_PID_2049_HAGCE_DEFAULT_VALUE (0) > +#define AW_PID_2049_HAGCE_DEFAULT \ > + (AW_PID_2049_HAGCE_DEFAULT_VALUE << AW_PID_2049_HAGCE_START_BIT) > + > +/* HDCCE bit 9 (SYSCTRL 0x04) */ > +#define AW_PID_2049_HDCCE_START_BIT (9) > +#define AW_PID_2049_HDCCE_BITS_LEN (1) > +#define AW_PID_2049_HDCCE_MASK \ > + (~(((1<<AW_PID_2049_HDCCE_BITS_LEN)-1) << AW_PID_2049_HDCCE_START_BIT)) > + > +#define AW_PID_2049_HDCCE_DISABLE (0) > +#define AW_PID_2049_HDCCE_DISABLE_VALUE \ > + (AW_PID_2049_HDCCE_DISABLE << AW_PID_2049_HDCCE_START_BIT) > + > +#define AW_PID_2049_HDCCE_ENABLE (1) > +#define AW_PID_2049_HDCCE_ENABLE_VALUE \ > + (AW_PID_2049_HDCCE_ENABLE << AW_PID_2049_HDCCE_START_BIT) > + > +#define AW_PID_2049_HDCCE_DEFAULT_VALUE (1) > +#define AW_PID_2049_HDCCE_DEFAULT \ > + (AW_PID_2049_HDCCE_DEFAULT_VALUE << AW_PID_2049_HDCCE_START_BIT) > + > +/* HMUTE bit 8 (SYSCTRL 0x04) */ > +#define AW_PID_2049_HMUTE_START_BIT (8) > +#define AW_PID_2049_HMUTE_BITS_LEN (1) > +#define AW_PID_2049_HMUTE_MASK \ > + (~(((1<<AW_PID_2049_HMUTE_BITS_LEN)-1) << AW_PID_2049_HMUTE_START_BIT)) > + > +#define AW_PID_2049_HMUTE_DISABLE (0) > +#define AW_PID_2049_HMUTE_DISABLE_VALUE \ > + (AW_PID_2049_HMUTE_DISABLE << AW_PID_2049_HMUTE_START_BIT) > + > +#define AW_PID_2049_HMUTE_ENABLE (1) > +#define AW_PID_2049_HMUTE_ENABLE_VALUE \ > + (AW_PID_2049_HMUTE_ENABLE << AW_PID_2049_HMUTE_START_BIT) > + > +#define AW_PID_2049_HMUTE_DEFAULT_VALUE (1) > +#define AW_PID_2049_HMUTE_DEFAULT \ > + (AW_PID_2049_HMUTE_DEFAULT_VALUE << AW_PID_2049_HMUTE_START_BIT) > + > +/* RCV_MODE bit 7 (SYSCTRL 0x04) */ > +#define AW_PID_2049_RCV_MODE_START_BIT (7) > +#define AW_PID_2049_RCV_MODE_BITS_LEN (1) > +#define AW_PID_2049_RCV_MODE_MASK \ > + (~(((1<<AW_PID_2049_RCV_MODE_BITS_LEN)-1) << AW_PID_2049_RCV_MODE_START_BIT)) > + > +#define AW_PID_2049_RCV_MODE_SPEAKER (0) > +#define AW_PID_2049_RCV_MODE_SPEAKER_VALUE \ > + (AW_PID_2049_RCV_MODE_SPEAKER << AW_PID_2049_RCV_MODE_START_BIT) > + > +#define AW_PID_2049_RCV_MODE_RECEIVER (1) > +#define AW_PID_2049_RCV_MODE_RECEIVER_VALUE \ > + (AW_PID_2049_RCV_MODE_RECEIVER << AW_PID_2049_RCV_MODE_START_BIT) > + > +#define AW_PID_2049_RCV_MODE_DEFAULT_VALUE (0) > +#define AW_PID_2049_RCV_MODE_DEFAULT \ > + (AW_PID_2049_RCV_MODE_DEFAULT_VALUE << AW_PID_2049_RCV_MODE_START_BIT) > + > +/* I2SEN bit 6 (SYSCTRL 0x04) */ > +#define AW_PID_2049_I2SEN_START_BIT (6) > +#define AW_PID_2049_I2SEN_BITS_LEN (1) > +#define AW_PID_2049_I2SEN_MASK \ > + (~(((1<<AW_PID_2049_I2SEN_BITS_LEN)-1) << AW_PID_2049_I2SEN_START_BIT)) > + > +#define AW_PID_2049_I2SEN_DISABLE (0) > +#define AW_PID_2049_I2SEN_DISABLE_VALUE \ > + (AW_PID_2049_I2SEN_DISABLE << AW_PID_2049_I2SEN_START_BIT) > + > +#define AW_PID_2049_I2SEN_ENABLE (1) > +#define AW_PID_2049_I2SEN_ENABLE_VALUE \ > + (AW_PID_2049_I2SEN_ENABLE << AW_PID_2049_I2SEN_START_BIT) > + > +#define AW_PID_2049_I2SEN_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2SEN_DEFAULT \ > + (AW_PID_2049_I2SEN_DEFAULT_VALUE << AW_PID_2049_I2SEN_START_BIT) > + > +/* WSINV bit 5 (SYSCTRL 0x04) */ > +#define AW_PID_2049_WSINV_START_BIT (5) > +#define AW_PID_2049_WSINV_BITS_LEN (1) > +#define AW_PID_2049_WSINV_MASK \ > + (~(((1<<AW_PID_2049_WSINV_BITS_LEN)-1) << AW_PID_2049_WSINV_START_BIT)) > + > +#define AW_PID_2049_WSINV_NOT_SWITCH (0) > +#define AW_PID_2049_WSINV_NOT_SWITCH_VALUE \ > + (AW_PID_2049_WSINV_NOT_SWITCH << AW_PID_2049_WSINV_START_BIT) > + > +#define AW_PID_2049_WSINV_SWITCH (1) > +#define AW_PID_2049_WSINV_SWITCH_VALUE \ > + (AW_PID_2049_WSINV_SWITCH << AW_PID_2049_WSINV_START_BIT) > + > +#define AW_PID_2049_WSINV_DEFAULT_VALUE (0) > +#define AW_PID_2049_WSINV_DEFAULT \ > + (AW_PID_2049_WSINV_DEFAULT_VALUE << AW_PID_2049_WSINV_START_BIT) > + > +/* BCKINV bit 4 (SYSCTRL 0x04) */ > +#define AW_PID_2049_BCKINV_START_BIT (4) > +#define AW_PID_2049_BCKINV_BITS_LEN (1) > +#define AW_PID_2049_BCKINV_MASK \ > + (~(((1<<AW_PID_2049_BCKINV_BITS_LEN)-1) << AW_PID_2049_BCKINV_START_BIT)) > + > +#define AW_PID_2049_BCKINV_NOT_INVERT (0) > +#define AW_PID_2049_BCKINV_NOT_INVERT_VALUE \ > + (AW_PID_2049_BCKINV_NOT_INVERT << AW_PID_2049_BCKINV_START_BIT) > + > +#define AW_PID_2049_BCKINV_INVERTED (1) > +#define AW_PID_2049_BCKINV_INVERTED_VALUE \ > + (AW_PID_2049_BCKINV_INVERTED << AW_PID_2049_BCKINV_START_BIT) > + > +#define AW_PID_2049_BCKINV_DEFAULT_VALUE (0) > +#define AW_PID_2049_BCKINV_DEFAULT \ > + (AW_PID_2049_BCKINV_DEFAULT_VALUE << AW_PID_2049_BCKINV_START_BIT) > + > +/* IPLL bit 3 (SYSCTRL 0x04) */ > +#define AW_PID_2049_IPLL_START_BIT (3) > +#define AW_PID_2049_IPLL_BITS_LEN (1) > +#define AW_PID_2049_IPLL_MASK \ > + (~(((1<<AW_PID_2049_IPLL_BITS_LEN)-1) << AW_PID_2049_IPLL_START_BIT)) > + > +#define AW_PID_2049_IPLL_BCK (0) > +#define AW_PID_2049_IPLL_BCK_VALUE \ > + (AW_PID_2049_IPLL_BCK << AW_PID_2049_IPLL_START_BIT) > + > +#define AW_PID_2049_IPLL_WCK (1) > +#define AW_PID_2049_IPLL_WCK_VALUE \ > + (AW_PID_2049_IPLL_WCK << AW_PID_2049_IPLL_START_BIT) > + > +#define AW_PID_2049_IPLL_DEFAULT_VALUE (0) > +#define AW_PID_2049_IPLL_DEFAULT \ > + (AW_PID_2049_IPLL_DEFAULT_VALUE << AW_PID_2049_IPLL_START_BIT) > + > +/* DSPBY bit 2 (SYSCTRL 0x04) */ > +#define AW_PID_2049_DSPBY_START_BIT (2) > +#define AW_PID_2049_DSPBY_BITS_LEN (1) > +#define AW_PID_2049_DSPBY_MASK \ > + (~(((1<<AW_PID_2049_DSPBY_BITS_LEN)-1) << AW_PID_2049_DSPBY_START_BIT)) > + > +#define AW_PID_2049_DSPBY_WORKING (0) > +#define AW_PID_2049_DSPBY_WORKING_VALUE \ > + (AW_PID_2049_DSPBY_WORKING << AW_PID_2049_DSPBY_START_BIT) > + > +#define AW_PID_2049_DSPBY_BYPASS (1) > +#define AW_PID_2049_DSPBY_BYPASS_VALUE \ > + (AW_PID_2049_DSPBY_BYPASS << AW_PID_2049_DSPBY_START_BIT) > + > +#define AW_PID_2049_DSPBY_DEFAULT_VALUE (1) > +#define AW_PID_2049_DSPBY_DEFAULT \ > + (AW_PID_2049_DSPBY_DEFAULT_VALUE << AW_PID_2049_DSPBY_START_BIT) > + > +/* AMPPD bit 1 (SYSCTRL 0x04) */ > +#define AW_PID_2049_AMPPD_START_BIT (1) > +#define AW_PID_2049_AMPPD_BITS_LEN (1) > +#define AW_PID_2049_AMPPD_MASK \ > + (~(((1<<AW_PID_2049_AMPPD_BITS_LEN)-1) << AW_PID_2049_AMPPD_START_BIT)) > + > +#define AW_PID_2049_AMPPD_WORKING (0) > +#define AW_PID_2049_AMPPD_WORKING_VALUE \ > + (AW_PID_2049_AMPPD_WORKING << AW_PID_2049_AMPPD_START_BIT) > + > +#define AW_PID_2049_AMPPD_POWER_DOWN (1) > +#define AW_PID_2049_AMPPD_POWER_DOWN_VALUE \ > + (AW_PID_2049_AMPPD_POWER_DOWN << AW_PID_2049_AMPPD_START_BIT) > + > +#define AW_PID_2049_AMPPD_DEFAULT_VALUE (1) > +#define AW_PID_2049_AMPPD_DEFAULT \ > + (AW_PID_2049_AMPPD_DEFAULT_VALUE << AW_PID_2049_AMPPD_START_BIT) > + > +/* PWDN bit 0 (SYSCTRL 0x04) */ > +#define AW_PID_2049_PWDN_START_BIT (0) > +#define AW_PID_2049_PWDN_BITS_LEN (1) > +#define AW_PID_2049_PWDN_MASK \ > + (~(((1<<AW_PID_2049_PWDN_BITS_LEN)-1) << AW_PID_2049_PWDN_START_BIT)) > + > +#define AW_PID_2049_PWDN_WORKING (0) > +#define AW_PID_2049_PWDN_WORKING_VALUE \ > + (AW_PID_2049_PWDN_WORKING << AW_PID_2049_PWDN_START_BIT) > + > +#define AW_PID_2049_PWDN_POWER_DOWN (1) > +#define AW_PID_2049_PWDN_POWER_DOWN_VALUE \ > + (AW_PID_2049_PWDN_POWER_DOWN << AW_PID_2049_PWDN_START_BIT) > + > +#define AW_PID_2049_PWDN_DEFAULT_VALUE (1) > +#define AW_PID_2049_PWDN_DEFAULT \ > + (AW_PID_2049_PWDN_DEFAULT_VALUE << AW_PID_2049_PWDN_START_BIT) > + > +/* default value of SYSCTRL (0x04) */ > +/* #define AW_PID_2049_SYSCTRL_DEFAULT (0x5307) */ > + > +/* SYSCTRL2 (0x05) detail */ > +/* VOL bit 15:6 (SYSCTRL2 0x05) */ > +#define AW_PID_2049_MUTE_VOL (90 * 8) > +#define AW_PID_2049_VOLUME_STEP_DB (6 * 8) > + > +#define AW_PID_2049_VOL_6DB_START (6) > +#define AW_PID_2049_VOL_START_BIT (6) > +#define AW_PID_2049_VOL_BITS_LEN (10) > +#define AW_PID_2049_VOL_MASK \ > + (~(((1<<AW_PID_2049_VOL_BITS_LEN)-1) << AW_PID_2049_VOL_START_BIT)) > + > +#define AW_PID_2049_VOL_DEFAULT_VALUE (0) > +#define AW_PID_2049_VOL_DEFAULT \ > + (AW_PID_2049_VOL_DEFAULT_VALUE << AW_PID_2049_VOL_START_BIT) > + > +/* INTMODE bit 5 (SYSCTRL2 0x05) */ > +#define AW_PID_2049_INTMODE_START_BIT (5) > +#define AW_PID_2049_INTMODE_BITS_LEN (1) > +#define AW_PID_2049_INTMODE_MASK \ > + (~(((1<<AW_PID_2049_INTMODE_BITS_LEN)-1) << AW_PID_2049_INTMODE_START_BIT)) > + > +#define AW_PID_2049_INTMODE_OPENMINUS_DRAIN (0) > +#define AW_PID_2049_INTMODE_OPENMINUS_DRAIN_VALUE \ > + (AW_PID_2049_INTMODE_OPENMINUS_DRAIN << AW_PID_2049_INTMODE_START_BIT) > + > +#define AW_PID_2049_INTMODE_PUSHPULL (1) > +#define AW_PID_2049_INTMODE_PUSHPULL_VALUE \ > + (AW_PID_2049_INTMODE_PUSHPULL << AW_PID_2049_INTMODE_START_BIT) > + > +#define AW_PID_2049_INTMODE_DEFAULT_VALUE (0) > +#define AW_PID_2049_INTMODE_DEFAULT \ > + (AW_PID_2049_INTMODE_DEFAULT_VALUE << AW_PID_2049_INTMODE_START_BIT) > + > +/* INTN bit 4 (SYSCTRL2 0x05) */ > +#define AW_PID_2049_INTN_START_BIT (4) > +#define AW_PID_2049_INTN_BITS_LEN (1) > +#define AW_PID_2049_INTN_MASK \ > + (~(((1<<AW_PID_2049_INTN_BITS_LEN)-1) << AW_PID_2049_INTN_START_BIT)) > + > +#define AW_PID_2049_INTN_SYSINT (0) > +#define AW_PID_2049_INTN_SYSINT_VALUE \ > + (AW_PID_2049_INTN_SYSINT << AW_PID_2049_INTN_START_BIT) > + > +#define AW_PID_2049_INTN_SYSST (1) > +#define AW_PID_2049_INTN_SYSST_VALUE \ > + (AW_PID_2049_INTN_SYSST << AW_PID_2049_INTN_START_BIT) > + > +#define AW_PID_2049_INTN_DEFAULT_VALUE (0) > +#define AW_PID_2049_INTN_DEFAULT \ > + (AW_PID_2049_INTN_DEFAULT_VALUE << AW_PID_2049_INTN_START_BIT) > + > +/* BST_IPEAK bit 3:0 (SYSCTRL2 0x05) */ > +#define AW_PID_2049_BST_IPEAK_START_BIT (0) > +#define AW_PID_2049_BST_IPEAK_BITS_LEN (4) > +#define AW_PID_2049_BST_IPEAK_MASK \ > + (~(((1<<AW_PID_2049_BST_IPEAK_BITS_LEN)-1) << AW_PID_2049_BST_IPEAK_START_BIT)) > + > +#define AW_PID_2049_BST_IPEAK_1P50A (0) > +#define AW_PID_2049_BST_IPEAK_1P50A_VALUE \ > + (AW_PID_2049_BST_IPEAK_1P50A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_1P75A (1) > +#define AW_PID_2049_BST_IPEAK_1P75A_VALUE \ > + (AW_PID_2049_BST_IPEAK_1P75A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_2P00A (2) > +#define AW_PID_2049_BST_IPEAK_2P00A_VALUE \ > + (AW_PID_2049_BST_IPEAK_2P00A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_2P25A (3) > +#define AW_PID_2049_BST_IPEAK_2P25A_VALUE \ > + (AW_PID_2049_BST_IPEAK_2P25A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_2P50A (4) > +#define AW_PID_2049_BST_IPEAK_2P50A_VALUE \ > + (AW_PID_2049_BST_IPEAK_2P50A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_2P75A (5) > +#define AW_PID_2049_BST_IPEAK_2P75A_VALUE \ > + (AW_PID_2049_BST_IPEAK_2P75A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_3P00A (6) > +#define AW_PID_2049_BST_IPEAK_3P00A_VALUE \ > + (AW_PID_2049_BST_IPEAK_3P00A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_3P25A (7) > +#define AW_PID_2049_BST_IPEAK_3P25A_VALUE \ > + (AW_PID_2049_BST_IPEAK_3P25A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_3P50A (8) > +#define AW_PID_2049_BST_IPEAK_3P50A_VALUE \ > + (AW_PID_2049_BST_IPEAK_3P50A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_3P75A (9) > +#define AW_PID_2049_BST_IPEAK_3P75A_VALUE \ > + (AW_PID_2049_BST_IPEAK_3P75A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_4P00A (10) > +#define AW_PID_2049_BST_IPEAK_4P00A_VALUE \ > + (AW_PID_2049_BST_IPEAK_4P00A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_4P25A (11) > +#define AW_PID_2049_BST_IPEAK_4P25A_VALUE \ > + (AW_PID_2049_BST_IPEAK_4P25A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_4P50A (12) > +#define AW_PID_2049_BST_IPEAK_4P50A_VALUE \ > + (AW_PID_2049_BST_IPEAK_4P50A << AW_PID_2049_BST_IPEAK_START_BIT) > + > +#define AW_PID_2049_BST_IPEAK_DEFAULT_VALUE (9) > +#define AW_PID_2049_BST_IPEAK_DEFAULT \ > + (AW_PID_2049_BST_IPEAK_DEFAULT_VALUE << AW_PID_2049_BST_IPEAK_START_BIT) > + > +/* default value of SYSCTRL2 (0x05) */ > +/* #define AW_PID_2049_SYSCTRL2_DEFAULT (0x0009) */ > + > +/* I2SCTRL (0x06) detail */ > +/* SLOT_NUM bit 14:12 (I2SCTRL 0x06) */ > +#define AW_PID_2049_SLOT_NUM_START_BIT (12) > +#define AW_PID_2049_SLOT_NUM_BITS_LEN (3) > +#define AW_PID_2049_SLOT_NUM_MASK \ > + (~(((1<<AW_PID_2049_SLOT_NUM_BITS_LEN)-1) << AW_PID_2049_SLOT_NUM_START_BIT)) > + > +#define AW_PID_2049_SLOT_NUM_I2S_MODE (0) > +#define AW_PID_2049_SLOT_NUM_I2S_MODE_VALUE \ > + (AW_PID_2049_SLOT_NUM_I2S_MODE << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_TDM1S (1) > +#define AW_PID_2049_SLOT_NUM_TDM1S_VALUE \ > + (AW_PID_2049_SLOT_NUM_TDM1S << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_TDM2S (2) > +#define AW_PID_2049_SLOT_NUM_TDM2S_VALUE \ > + (AW_PID_2049_SLOT_NUM_TDM2S << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_TDM4S (3) > +#define AW_PID_2049_SLOT_NUM_TDM4S_VALUE \ > + (AW_PID_2049_SLOT_NUM_TDM4S << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_TDM6S (4) > +#define AW_PID_2049_SLOT_NUM_TDM6S_VALUE \ > + (AW_PID_2049_SLOT_NUM_TDM6S << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_TDM8S (5) > +#define AW_PID_2049_SLOT_NUM_TDM8S_VALUE \ > + (AW_PID_2049_SLOT_NUM_TDM8S << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_TDM16S (6) > +#define AW_PID_2049_SLOT_NUM_TDM16S_VALUE \ > + (AW_PID_2049_SLOT_NUM_TDM16S << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_RESERVED (7) > +#define AW_PID_2049_SLOT_NUM_RESERVED_VALUE \ > + (AW_PID_2049_SLOT_NUM_RESERVED << AW_PID_2049_SLOT_NUM_START_BIT) > + > +#define AW_PID_2049_SLOT_NUM_DEFAULT_VALUE (0) > +#define AW_PID_2049_SLOT_NUM_DEFAULT \ > + (AW_PID_2049_SLOT_NUM_DEFAULT_VALUE << AW_PID_2049_SLOT_NUM_START_BIT) > + > +/* CHSEL bit 11:10 (I2SCTRL 0x06) */ > +#define AW_PID_2049_CHSEL_START_BIT (10) > +#define AW_PID_2049_CHSEL_BITS_LEN (2) > +#define AW_PID_2049_CHSEL_MASK \ > + (~(((1<<AW_PID_2049_CHSEL_BITS_LEN)-1) << AW_PID_2049_CHSEL_START_BIT)) > + > +#define AW_PID_2049_CHSEL_RESERVED (0) > +#define AW_PID_2049_CHSEL_RESERVED_VALUE \ > + (AW_PID_2049_CHSEL_RESERVED << AW_PID_2049_CHSEL_START_BIT) > + > +#define AW_PID_2049_CHSEL_LEFT (1) > +#define AW_PID_2049_CHSEL_LEFT_VALUE \ > + (AW_PID_2049_CHSEL_LEFT << AW_PID_2049_CHSEL_START_BIT) > + > +#define AW_PID_2049_CHSEL_RIGHT (2) > +#define AW_PID_2049_CHSEL_RIGHT_VALUE \ > + (AW_PID_2049_CHSEL_RIGHT << AW_PID_2049_CHSEL_START_BIT) > + > +#define AW_PID_2049_CHSEL_MONO (3) > +#define AW_PID_2049_CHSEL_MONO_VALUE \ > + (AW_PID_2049_CHSEL_MONO << AW_PID_2049_CHSEL_START_BIT) > + > +#define AW_PID_2049_CHSEL_DEFAULT_VALUE (1) > +#define AW_PID_2049_CHSEL_DEFAULT \ > + (AW_PID_2049_CHSEL_DEFAULT_VALUE << AW_PID_2049_CHSEL_START_BIT) > + > +/* I2SMD bit 9:8 (I2SCTRL 0x06) */ > +#define AW_PID_2049_I2SMD_START_BIT (8) > +#define AW_PID_2049_I2SMD_BITS_LEN (2) > +#define AW_PID_2049_I2SMD_MASK \ > + (~(((1<<AW_PID_2049_I2SMD_BITS_LEN)-1) << AW_PID_2049_I2SMD_START_BIT)) > + > +#define AW_PID_2049_I2SMD_PHILIP_STANDARD (0) > +#define AW_PID_2049_I2SMD_PHILIP_STANDARD_VALUE \ > + (AW_PID_2049_I2SMD_PHILIP_STANDARD << AW_PID_2049_I2SMD_START_BIT) > + > +#define AW_PID_2049_I2SMD_MSB_JUSTIFIED (1) > +#define AW_PID_2049_I2SMD_MSB_JUSTIFIED_VALUE \ > + (AW_PID_2049_I2SMD_MSB_JUSTIFIED << AW_PID_2049_I2SMD_START_BIT) > + > +#define AW_PID_2049_I2SMD_LSB_JUSTIFIED (2) > +#define AW_PID_2049_I2SMD_LSB_JUSTIFIED_VALUE \ > + (AW_PID_2049_I2SMD_LSB_JUSTIFIED << AW_PID_2049_I2SMD_START_BIT) > + > +#define AW_PID_2049_I2SMD_RESERVED (3) > +#define AW_PID_2049_I2SMD_RESERVED_VALUE \ > + (AW_PID_2049_I2SMD_RESERVED << AW_PID_2049_I2SMD_START_BIT) > + > +#define AW_PID_2049_I2SMD_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2SMD_DEFAULT \ > + (AW_PID_2049_I2SMD_DEFAULT_VALUE << AW_PID_2049_I2SMD_START_BIT) > + > +/* I2SFS bit 7:6 (I2SCTRL 0x06) */ > +#define AW_PID_2049_I2SFS_START_BIT (6) > +#define AW_PID_2049_I2SFS_BITS_LEN (2) > +#define AW_PID_2049_I2SFS_MASK \ > + (~(((1<<AW_PID_2049_I2SFS_BITS_LEN)-1) << AW_PID_2049_I2SFS_START_BIT)) > + > +#define AW_PID_2049_I2SFS_16_BITS (0) > +#define AW_PID_2049_I2SFS_16_BITS_VALUE \ > + (AW_PID_2049_I2SFS_16_BITS << AW_PID_2049_I2SFS_START_BIT) > + > +#define AW_PID_2049_I2SFS_20_BITS (1) > +#define AW_PID_2049_I2SFS_20_BITS_VALUE \ > + (AW_PID_2049_I2SFS_20_BITS << AW_PID_2049_I2SFS_START_BIT) > + > +#define AW_PID_2049_I2SFS_24_BITS (2) > +#define AW_PID_2049_I2SFS_24_BITS_VALUE \ > + (AW_PID_2049_I2SFS_24_BITS << AW_PID_2049_I2SFS_START_BIT) > + > +#define AW_PID_2049_I2SFS_32_BITS (3) > +#define AW_PID_2049_I2SFS_32_BITS_VALUE \ > + (AW_PID_2049_I2SFS_32_BITS << AW_PID_2049_I2SFS_START_BIT) > + > +#define AW_PID_2049_I2SFS_DEFAULT_VALUE (3) > +#define AW_PID_2049_I2SFS_DEFAULT \ > + (AW_PID_2049_I2SFS_DEFAULT_VALUE << AW_PID_2049_I2SFS_START_BIT) > + > +/* I2SBCK bit 5:4 (I2SCTRL 0x06) */ > +#define AW_PID_2049_I2SBCK_START_BIT (4) > +#define AW_PID_2049_I2SBCK_BITS_LEN (2) > +#define AW_PID_2049_I2SBCK_MASK \ > + (~(((1<<AW_PID_2049_I2SBCK_BITS_LEN)-1) << AW_PID_2049_I2SBCK_START_BIT)) > + > +#define AW_PID_2049_I2SBCK_32FS (0) > +#define AW_PID_2049_I2SBCK_32FS_VALUE \ > + (AW_PID_2049_I2SBCK_32FS << AW_PID_2049_I2SBCK_START_BIT) > + > +#define AW_PID_2049_I2SBCK_48FS (1) > +#define AW_PID_2049_I2SBCK_48FS_VALUE \ > + (AW_PID_2049_I2SBCK_48FS << AW_PID_2049_I2SBCK_START_BIT) > + > +#define AW_PID_2049_I2SBCK_64FS (2) > +#define AW_PID_2049_I2SBCK_64FS_VALUE \ > + (AW_PID_2049_I2SBCK_64FS << AW_PID_2049_I2SBCK_START_BIT) > + > +#define AW_PID_2049_I2SBCK_RESERVED (3) > +#define AW_PID_2049_I2SBCK_RESERVED_VALUE \ > + (AW_PID_2049_I2SBCK_RESERVED << AW_PID_2049_I2SBCK_START_BIT) > + > +#define AW_PID_2049_I2SBCK_DEFAULT_VALUE (2) > +#define AW_PID_2049_I2SBCK_DEFAULT \ > + (AW_PID_2049_I2SBCK_DEFAULT_VALUE << AW_PID_2049_I2SBCK_START_BIT) > + > +/* I2SSR bit 3:0 (I2SCTRL 0x06) */ > +#define AW_PID_2049_I2SSR_START_BIT (0) > +#define AW_PID_2049_I2SSR_BITS_LEN (4) > +#define AW_PID_2049_I2SSR_MASK \ > + (~(((1<<AW_PID_2049_I2SSR_BITS_LEN)-1) << AW_PID_2049_I2SSR_START_BIT)) > + > +#define AW_PID_2049_I2SSR_8_KHZ (0) > +#define AW_PID_2049_I2SSR_8_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_8_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_11_KHZ (1) > +#define AW_PID_2049_I2SSR_11_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_11_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_12_KHZ (2) > +#define AW_PID_2049_I2SSR_12_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_12_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_16_KHZ (3) > +#define AW_PID_2049_I2SSR_16_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_16_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_22_KHZ (4) > +#define AW_PID_2049_I2SSR_22_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_22_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_24_KHZ (5) > +#define AW_PID_2049_I2SSR_24_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_24_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_32_KHZ (6) > +#define AW_PID_2049_I2SSR_32_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_32_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_44_KHZ (7) > +#define AW_PID_2049_I2SSR_44_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_44_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_48_KHZ (8) > +#define AW_PID_2049_I2SSR_48_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_48_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_96_KHZ (9) > +#define AW_PID_2049_I2SSR_96_KHZ_VALUE \ > + (AW_PID_2049_I2SSR_96_KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_192KHZ (10) > +#define AW_PID_2049_I2SSR_192KHZ_VALUE \ > + (AW_PID_2049_I2SSR_192KHZ << AW_PID_2049_I2SSR_START_BIT) > + > +#define AW_PID_2049_I2SSR_DEFAULT_VALUE (8) > +#define AW_PID_2049_I2SSR_DEFAULT \ > + (AW_PID_2049_I2SSR_DEFAULT_VALUE << AW_PID_2049_I2SSR_START_BIT) > + > +/* default value of I2SCTRL (0x06) */ > +/* #define AW_PID_2049_I2SCTRL_DEFAULT (0x04E8) */ > + > +/* I2SCFG1 (0x07) detail */ > +/* I2S_RXL_SLOTVLD bit 15:12 (I2SCFG1 0x07) */ > +#define AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT (12) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_BITS_LEN (4) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_MASK \ > + (~(((1<<AW_PID_2049_I2S_RXL_SLOTVLD_BITS_LEN)-1) << AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT)) > + > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_0 (0) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_0_VALUE \ > + (AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_0 << AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_1 (1) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_1_VALUE \ > + (AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_1 << AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_2 (2) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_2_VALUE \ > + (AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_2 << AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_3 (3) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_3_VALUE \ > + (AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_3 << AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_15 (15) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_15_VALUE \ > + (AW_PID_2049_I2S_RXL_SLOTVLD_SLOT_15 << AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXL_SLOTVLD_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2S_RXL_SLOTVLD_DEFAULT \ > + (AW_PID_2049_I2S_RXL_SLOTVLD_DEFAULT_VALUE << AW_PID_2049_I2S_RXL_SLOTVLD_START_BIT) > + > +/* I2S_RXR_SLOTVLD bit 11:8 (I2SCFG1 0x07) */ > +#define AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT (8) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_BITS_LEN (4) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_MASK \ > + (~(((1<<AW_PID_2049_I2S_RXR_SLOTVLD_BITS_LEN)-1) << AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT)) > + > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_0 (0) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_0_VALUE \ > + (AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_0 << AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_1 (1) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_1_VALUE \ > + (AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_1 << AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_2 (2) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_2_VALUE \ > + (AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_2 << AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_3 (3) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_3_VALUE \ > + (AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_3 << AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_15 (15) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_15_VALUE \ > + (AW_PID_2049_I2S_RXR_SLOTVLD_SLOT_15 << AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_RXR_SLOTVLD_DEFAULT_VALUE (1) > +#define AW_PID_2049_I2S_RXR_SLOTVLD_DEFAULT \ > + (AW_PID_2049_I2S_RXR_SLOTVLD_DEFAULT_VALUE << AW_PID_2049_I2S_RXR_SLOTVLD_START_BIT) > + > +/* I2S_TX_SLOTVLD bit 7:4 (I2SCFG1 0x07) */ > +#define AW_PID_2049_I2S_TX_SLOTVLD_START_BIT (4) > +#define AW_PID_2049_I2S_TX_SLOTVLD_BITS_LEN (4) > +#define AW_PID_2049_I2S_TX_SLOTVLD_MASK \ > + (~(((1<<AW_PID_2049_I2S_TX_SLOTVLD_BITS_LEN)-1) << AW_PID_2049_I2S_TX_SLOTVLD_START_BIT)) > + > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_0 (0) > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_0_VALUE \ > + (AW_PID_2049_I2S_TX_SLOTVLD_SLOT_0 << AW_PID_2049_I2S_TX_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_1 (1) > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_1_VALUE \ > + (AW_PID_2049_I2S_TX_SLOTVLD_SLOT_1 << AW_PID_2049_I2S_TX_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_2 (2) > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_2_VALUE \ > + (AW_PID_2049_I2S_TX_SLOTVLD_SLOT_2 << AW_PID_2049_I2S_TX_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_3 (3) > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_3_VALUE \ > + (AW_PID_2049_I2S_TX_SLOTVLD_SLOT_3 << AW_PID_2049_I2S_TX_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_15 (15) > +#define AW_PID_2049_I2S_TX_SLOTVLD_SLOT_15_VALUE \ > + (AW_PID_2049_I2S_TX_SLOTVLD_SLOT_15 << AW_PID_2049_I2S_TX_SLOTVLD_START_BIT) > + > +#define AW_PID_2049_I2S_TX_SLOTVLD_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2S_TX_SLOTVLD_DEFAULT \ > + (AW_PID_2049_I2S_TX_SLOTVLD_DEFAULT_VALUE << AW_PID_2049_I2S_TX_SLOTVLD_START_BIT) > + > +/* FSYNC_TYPE bit 3 (I2SCFG1 0x07) */ > +#define AW_PID_2049_FSYNC_TYPE_START_BIT (3) > +#define AW_PID_2049_FSYNC_TYPE_BITS_LEN (1) > +#define AW_PID_2049_FSYNC_TYPE_MASK \ > + (~(((1<<AW_PID_2049_FSYNC_TYPE_BITS_LEN)-1) << AW_PID_2049_FSYNC_TYPE_START_BIT)) > + > +#define AW_PID_2049_FSYNC_TYPE_ONEMINUS_SLOT (0) > +#define AW_PID_2049_FSYNC_TYPE_ONEMINUS_SLOT_VALUE \ > + (AW_PID_2049_FSYNC_TYPE_ONEMINUS_SLOT << AW_PID_2049_FSYNC_TYPE_START_BIT) > + > +#define AW_PID_2049_FSYNC_TYPE_ONEMINUS_BCK (1) > +#define AW_PID_2049_FSYNC_TYPE_ONEMINUS_BCK_VALUE \ > + (AW_PID_2049_FSYNC_TYPE_ONEMINUS_BCK << AW_PID_2049_FSYNC_TYPE_START_BIT) > + > +#define AW_PID_2049_FSYNC_TYPE_DEFAULT_VALUE (0) > +#define AW_PID_2049_FSYNC_TYPE_DEFAULT \ > + (AW_PID_2049_FSYNC_TYPE_DEFAULT_VALUE << AW_PID_2049_FSYNC_TYPE_START_BIT) > + > +/* I2SCHS bit 2 (I2SCFG1 0x07) */ > +#define AW_PID_2049_I2SCHS_START_BIT (2) > +#define AW_PID_2049_I2SCHS_BITS_LEN (1) > +#define AW_PID_2049_I2SCHS_MASK \ > + (~(((1<<AW_PID_2049_I2SCHS_BITS_LEN)-1) << AW_PID_2049_I2SCHS_START_BIT)) > + > +#define AW_PID_2049_I2SCHS_LEFT (0) > +#define AW_PID_2049_I2SCHS_LEFT_VALUE \ > + (AW_PID_2049_I2SCHS_LEFT << AW_PID_2049_I2SCHS_START_BIT) > + > +#define AW_PID_2049_I2SCHS_RIGHT (1) > +#define AW_PID_2049_I2SCHS_RIGHT_VALUE \ > + (AW_PID_2049_I2SCHS_RIGHT << AW_PID_2049_I2SCHS_START_BIT) > + > +#define AW_PID_2049_I2SCHS_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2SCHS_DEFAULT \ > + (AW_PID_2049_I2SCHS_DEFAULT_VALUE << AW_PID_2049_I2SCHS_START_BIT) > + > +/* I2SRXEN bit 1 (I2SCFG1 0x07) */ > +#define AW_PID_2049_I2SRXEN_START_BIT (1) > +#define AW_PID_2049_I2SRXEN_BITS_LEN (1) > +#define AW_PID_2049_I2SRXEN_MASK \ > + (~(((1<<AW_PID_2049_I2SRXEN_BITS_LEN)-1) << AW_PID_2049_I2SRXEN_START_BIT)) > + > +#define AW_PID_2049_I2SRXEN_DISABLE (0) > +#define AW_PID_2049_I2SRXEN_DISABLE_VALUE \ > + (AW_PID_2049_I2SRXEN_DISABLE << AW_PID_2049_I2SRXEN_START_BIT) > + > +#define AW_PID_2049_I2SRXEN_ENABLE (1) > +#define AW_PID_2049_I2SRXEN_ENABLE_VALUE \ > + (AW_PID_2049_I2SRXEN_ENABLE << AW_PID_2049_I2SRXEN_START_BIT) > + > +#define AW_PID_2049_I2SRXEN_DEFAULT_VALUE (1) > +#define AW_PID_2049_I2SRXEN_DEFAULT \ > + (AW_PID_2049_I2SRXEN_DEFAULT_VALUE << AW_PID_2049_I2SRXEN_START_BIT) > + > +/* I2STXEN bit 0 (I2SCFG1 0x07) */ > +#define AW_PID_2049_I2STXEN_START_BIT (0) > +#define AW_PID_2049_I2STXEN_BITS_LEN (1) > +#define AW_PID_2049_I2STXEN_MASK \ > + (~(((1<<AW_PID_2049_I2STXEN_BITS_LEN)-1) << AW_PID_2049_I2STXEN_START_BIT)) > + > +#define AW_PID_2049_I2STXEN_DISABLE (0) > +#define AW_PID_2049_I2STXEN_DISABLE_VALUE \ > + (AW_PID_2049_I2STXEN_DISABLE << AW_PID_2049_I2STXEN_START_BIT) > + > +#define AW_PID_2049_I2STXEN_ENABLE (1) > +#define AW_PID_2049_I2STXEN_ENABLE_VALUE \ > + (AW_PID_2049_I2STXEN_ENABLE << AW_PID_2049_I2STXEN_START_BIT) > + > +#define AW_PID_2049_I2STXEN_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2STXEN_DEFAULT \ > + (AW_PID_2049_I2STXEN_DEFAULT_VALUE << AW_PID_2049_I2STXEN_START_BIT) > + > +/* default value of I2SCFG1 (0x07) */ > +/* #define AW_PID_2049_I2SCFG1_DEFAULT (0x0102) */ > + > +/* I2SCFG2 (0x08) detail */ > +/* ULS_FIR_MD bit 14 (I2SCFG2 0x08) */ > +#define AW_PID_2049_ULS_FIR_MD_START_BIT (14) > +#define AW_PID_2049_ULS_FIR_MD_BITS_LEN (1) > +#define AW_PID_2049_ULS_FIR_MD_MASK \ > + (~(((1<<AW_PID_2049_ULS_FIR_MD_BITS_LEN)-1) << AW_PID_2049_ULS_FIR_MD_START_BIT)) > + > +#define AW_PID_2049_ULS_FIR_MD_NOTMINUS_USED (0) > +#define AW_PID_2049_ULS_FIR_MD_NOTMINUS_USED_VALUE \ > + (AW_PID_2049_ULS_FIR_MD_NOTMINUS_USED << AW_PID_2049_ULS_FIR_MD_START_BIT) > + > +#define AW_PID_2049_ULS_FIR_MD_USED (1) > +#define AW_PID_2049_ULS_FIR_MD_USED_VALUE \ > + (AW_PID_2049_ULS_FIR_MD_USED << AW_PID_2049_ULS_FIR_MD_START_BIT) > + > +#define AW_PID_2049_ULS_FIR_MD_DEFAULT_VALUE (0) > +#define AW_PID_2049_ULS_FIR_MD_DEFAULT \ > + (AW_PID_2049_ULS_FIR_MD_DEFAULT_VALUE << AW_PID_2049_ULS_FIR_MD_START_BIT) > + > +/* ULS_MODE bit 13 (I2SCFG2 0x08) */ > +#define AW_PID_2049_ULS_MODE_START_BIT (13) > +#define AW_PID_2049_ULS_MODE_BITS_LEN (1) > +#define AW_PID_2049_ULS_MODE_MASK \ > + (~(((1<<AW_PID_2049_ULS_MODE_BITS_LEN)-1) << AW_PID_2049_ULS_MODE_START_BIT)) > + > +#define AW_PID_2049_ULS_MODE_LOWPASS (0) > +#define AW_PID_2049_ULS_MODE_LOWPASS_VALUE \ > + (AW_PID_2049_ULS_MODE_LOWPASS << AW_PID_2049_ULS_MODE_START_BIT) > + > +#define AW_PID_2049_ULS_MODE_TDM (1) > +#define AW_PID_2049_ULS_MODE_TDM_VALUE \ > + (AW_PID_2049_ULS_MODE_TDM << AW_PID_2049_ULS_MODE_START_BIT) > + > +#define AW_PID_2049_ULS_MODE_DEFAULT_VALUE (0) > +#define AW_PID_2049_ULS_MODE_DEFAULT \ > + (AW_PID_2049_ULS_MODE_DEFAULT_VALUE << AW_PID_2049_ULS_MODE_START_BIT) > + > +/* ULS_EN bit 12 (I2SCFG2 0x08) */ > +#define AW_PID_2049_ULS_EN_START_BIT (12) > +#define AW_PID_2049_ULS_EN_BITS_LEN (1) > +#define AW_PID_2049_ULS_EN_MASK \ > + (~(((1<<AW_PID_2049_ULS_EN_BITS_LEN)-1) << AW_PID_2049_ULS_EN_START_BIT)) > + > +#define AW_PID_2049_ULS_EN_DISABLE (0) > +#define AW_PID_2049_ULS_EN_DISABLE_VALUE \ > + (AW_PID_2049_ULS_EN_DISABLE << AW_PID_2049_ULS_EN_START_BIT) > + > +#define AW_PID_2049_ULS_EN_ENABLE (1) > +#define AW_PID_2049_ULS_EN_ENABLE_VALUE \ > + (AW_PID_2049_ULS_EN_ENABLE << AW_PID_2049_ULS_EN_START_BIT) > + > +#define AW_PID_2049_ULS_EN_DEFAULT_VALUE (0) > +#define AW_PID_2049_ULS_EN_DEFAULT \ > + (AW_PID_2049_ULS_EN_DEFAULT_VALUE << AW_PID_2049_ULS_EN_START_BIT) > + > +/* IV2CH bit 9 (I2SCFG2 0x08) */ > +#define AW_PID_2049_IV2CH_START_BIT (9) > +#define AW_PID_2049_IV2CH_BITS_LEN (1) > +#define AW_PID_2049_IV2CH_MASK \ > + (~(((1<<AW_PID_2049_IV2CH_BITS_LEN)-1) << AW_PID_2049_IV2CH_START_BIT)) > + > +#define AW_PID_2049_IV2CH_LEGACY (0) > +#define AW_PID_2049_IV2CH_LEGACY_VALUE \ > + (AW_PID_2049_IV2CH_LEGACY << AW_PID_2049_IV2CH_START_BIT) > + > +#define AW_PID_2049_IV2CH_SPECIAL (1) > +#define AW_PID_2049_IV2CH_SPECIAL_VALUE \ > + (AW_PID_2049_IV2CH_SPECIAL << AW_PID_2049_IV2CH_START_BIT) > + > +#define AW_PID_2049_IV2CH_DEFAULT_VALUE (0) > +#define AW_PID_2049_IV2CH_DEFAULT \ > + (AW_PID_2049_IV2CH_DEFAULT_VALUE << AW_PID_2049_IV2CH_START_BIT) > + > +/* I2S_TXEDGE bit 8 (I2SCFG2 0x08) */ > +#define AW_PID_2049_I2S_TXEDGE_START_BIT (8) > +#define AW_PID_2049_I2S_TXEDGE_BITS_LEN (1) > +#define AW_PID_2049_I2S_TXEDGE_MASK \ > + (~(((1<<AW_PID_2049_I2S_TXEDGE_BITS_LEN)-1) << AW_PID_2049_I2S_TXEDGE_START_BIT)) > + > +#define AW_PID_2049_I2S_TXEDGE_NEGEDGE (0) > +#define AW_PID_2049_I2S_TXEDGE_NEGEDGE_VALUE \ > + (AW_PID_2049_I2S_TXEDGE_NEGEDGE << AW_PID_2049_I2S_TXEDGE_START_BIT) > + > +#define AW_PID_2049_I2S_TXEDGE_POSEDGE (1) > +#define AW_PID_2049_I2S_TXEDGE_POSEDGE_VALUE \ > + (AW_PID_2049_I2S_TXEDGE_POSEDGE << AW_PID_2049_I2S_TXEDGE_START_BIT) > + > +#define AW_PID_2049_I2S_TXEDGE_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2S_TXEDGE_DEFAULT \ > + (AW_PID_2049_I2S_TXEDGE_DEFAULT_VALUE << AW_PID_2049_I2S_TXEDGE_START_BIT) > + > +/* I2SDOSEL bit 7 (I2SCFG2 0x08) */ > +#define AW_PID_2049_I2SDOSEL_START_BIT (7) > +#define AW_PID_2049_I2SDOSEL_BITS_LEN (1) > +#define AW_PID_2049_I2SDOSEL_MASK \ > + (~(((1<<AW_PID_2049_I2SDOSEL_BITS_LEN)-1) << AW_PID_2049_I2SDOSEL_START_BIT)) > + > +#define AW_PID_2049_I2SDOSEL_ZEROS (0) > +#define AW_PID_2049_I2SDOSEL_ZEROS_VALUE \ > + (AW_PID_2049_I2SDOSEL_ZEROS << AW_PID_2049_I2SDOSEL_START_BIT) > + > +#define AW_PID_2049_I2SDOSEL_TXDATA (1) > +#define AW_PID_2049_I2SDOSEL_TXDATA_VALUE \ > + (AW_PID_2049_I2SDOSEL_TXDATA << AW_PID_2049_I2SDOSEL_START_BIT) > + > +#define AW_PID_2049_I2SDOSEL_DEFAULT_VALUE (0) > +#define AW_PID_2049_I2SDOSEL_DEFAULT \ > + (AW_PID_2049_I2SDOSEL_DEFAULT_VALUE << AW_PID_2049_I2SDOSEL_START_BIT) > + > +/* DOHZ bit 6 (I2SCFG2 0x08) */ > +#define AW_PID_2049_DOHZ_START_BIT (6) > +#define AW_PID_2049_DOHZ_BITS_LEN (1) > +#define AW_PID_2049_DOHZ_MASK \ > + (~(((1<<AW_PID_2049_DOHZ_BITS_LEN)-1) << AW_PID_2049_DOHZ_START_BIT)) > + > +#define AW_PID_2049_DOHZ_ALL (0) > +#define AW_PID_2049_DOHZ_ALL_VALUE \ > + (AW_PID_2049_DOHZ_ALL << AW_PID_2049_DOHZ_START_BIT) > + > +#define AW_PID_2049_DOHZ_HIZ (1) > +#define AW_PID_2049_DOHZ_HIZ_VALUE \ > + (AW_PID_2049_DOHZ_HIZ << AW_PID_2049_DOHZ_START_BIT) > + > +#define AW_PID_2049_DOHZ_DEFAULT_VALUE (1) > +#define AW_PID_2049_DOHZ_DEFAULT \ > + (AW_PID_2049_DOHZ_DEFAULT_VALUE << AW_PID_2049_DOHZ_START_BIT) > + > +/* DRVSTREN bit 5 (I2SCFG2 0x08) */ > +#define AW_PID_2049_DRVSTREN_START_BIT (5) > +#define AW_PID_2049_DRVSTREN_BITS_LEN (1) > +#define AW_PID_2049_DRVSTREN_MASK \ > + (~(((1<<AW_PID_2049_DRVSTREN_BITS_LEN)-1) << AW_PID_2049_DRVSTREN_START_BIT)) > + > +#define AW_PID_2049_DRVSTREN_4MA (0) > +#define AW_PID_2049_DRVSTREN_4MA_VALUE \ > + (AW_PID_2049_DRVSTREN_4MA << AW_PID_2049_DRVSTREN_START_BIT) > + > +#define AW_PID_2049_DRVSTREN_12MA (1) > +#define AW_PID_2049_DRVSTREN_12MA_VALUE \ > + (AW_PID_2049_DRVSTREN_12MA << AW_PID_2049_DRVSTREN_START_BIT) > + > +#define AW_PID_2049_DRVSTREN_DEFAULT_VALUE (1) > +#define AW_PID_2049_DRVSTREN_DEFAULT \ > + (AW_PID_2049_DRVSTREN_DEFAULT_VALUE << AW_PID_2049_DRVSTREN_START_BIT) > + > +/* INPLEV bit 4 (I2SCFG2 0x08) */ > +#define AW_PID_2049_INPLEV_START_BIT (4) > +#define AW_PID_2049_INPLEV_BITS_LEN (1) > +#define AW_PID_2049_INPLEV_MASK \ > + (~(((1<<AW_PID_2049_INPLEV_BITS_LEN)-1) << AW_PID_2049_INPLEV_START_BIT)) > + > +#define AW_PID_2049_INPLEV_NOT_ATTENUATED (0) > +#define AW_PID_2049_INPLEV_NOT_ATTENUATED_VALUE \ > + (AW_PID_2049_INPLEV_NOT_ATTENUATED << AW_PID_2049_INPLEV_START_BIT) > + > +#define AW_PID_2049_INPLEV_ATTENUATED (1) > +#define AW_PID_2049_INPLEV_ATTENUATED_VALUE \ > + (AW_PID_2049_INPLEV_ATTENUATED << AW_PID_2049_INPLEV_START_BIT) > + > +#define AW_PID_2049_INPLEV_DEFAULT_VALUE (0) > +#define AW_PID_2049_INPLEV_DEFAULT \ > + (AW_PID_2049_INPLEV_DEFAULT_VALUE << AW_PID_2049_INPLEV_START_BIT) > + > +/* CFSEL bit 2:0 (I2SCFG2 0x08) */ > +#define AW_PID_2049_CFSEL_START_BIT (0) > +#define AW_PID_2049_CFSEL_BITS_LEN (3) > +#define AW_PID_2049_CFSEL_MASK \ > + (~(((1<<AW_PID_2049_CFSEL_BITS_LEN)-1) << AW_PID_2049_CFSEL_START_BIT)) > + > +#define AW_PID_2049_CFSEL_HAGC (0) > +#define AW_PID_2049_CFSEL_HAGC_VALUE \ > + (AW_PID_2049_CFSEL_HAGC << AW_PID_2049_CFSEL_START_BIT) > + > +#define AW_PID_2049_CFSEL_DFIFO (1) > +#define AW_PID_2049_CFSEL_DFIFO_VALUE \ > + (AW_PID_2049_CFSEL_DFIFO << AW_PID_2049_CFSEL_START_BIT) > + > +#define AW_PID_2049_CFSEL_ULS (2) > +#define AW_PID_2049_CFSEL_ULS_VALUE \ > + (AW_PID_2049_CFSEL_ULS << AW_PID_2049_CFSEL_START_BIT) > + > +#define AW_PID_2049_CFSEL_IVT_FS (3) > +#define AW_PID_2049_CFSEL_IVT_FS_VALUE \ > + (AW_PID_2049_CFSEL_IVT_FS << AW_PID_2049_CFSEL_START_BIT) > + > +#define AW_PID_2049_CFSEL_IVT_IPVT (4) > +#define AW_PID_2049_CFSEL_IVT_IPVT_VALUE \ > + (AW_PID_2049_CFSEL_IVT_IPVT << AW_PID_2049_CFSEL_START_BIT) > + > +#define AW_PID_2049_CFSEL_DEFAULT_VALUE (0) > +#define AW_PID_2049_CFSEL_DEFAULT \ > + (AW_PID_2049_CFSEL_DEFAULT_VALUE << AW_PID_2049_CFSEL_START_BIT) > + > +/* default value of I2SCFG2 (0x08) */ > +/* #define AW_PID_2049_I2SCFG2_DEFAULT (0x0060) */ > + > +/* HAGCCFG1 (0x09) detail */ > +/* RVTH bit 15:8 (HAGCCFG1 0x09) */ > +#define AW_PID_2049_RVTH_START_BIT (8) > +#define AW_PID_2049_RVTH_BITS_LEN (8) > +#define AW_PID_2049_RVTH_MASK \ > + (~(((1<<AW_PID_2049_RVTH_BITS_LEN)-1) << AW_PID_2049_RVTH_START_BIT)) > + > +#define AW_PID_2049_RVTH_DEFAULT_VALUE (0x39) > +#define AW_PID_2049_RVTH_DEFAULT \ > + (AW_PID_2049_RVTH_DEFAULT_VALUE << AW_PID_2049_RVTH_START_BIT) > + > +/* AVTH bit 7:0 (HAGCCFG1 0x09) */ > +#define AW_PID_2049_AVTH_START_BIT (0) > +#define AW_PID_2049_AVTH_BITS_LEN (8) > +#define AW_PID_2049_AVTH_MASK \ > + (~(((1<<AW_PID_2049_AVTH_BITS_LEN)-1) << AW_PID_2049_AVTH_START_BIT)) > + > +#define AW_PID_2049_AVTH_DEFAULT_VALUE (0x40) > +#define AW_PID_2049_AVTH_DEFAULT \ > + (AW_PID_2049_AVTH_DEFAULT_VALUE << AW_PID_2049_AVTH_START_BIT) > + > +/* default value of HAGCCFG1 (0x09) */ > +/* #define AW_PID_2049_HAGCCFG1_DEFAULT (0x3940) */ > + > +/* HAGCCFG2 (0x0A) detail */ > +/* ATTH bit 15:0 (HAGCCFG2 0x0A) */ > +#define AW_PID_2049_ATTH_START_BIT (0) > +#define AW_PID_2049_ATTH_BITS_LEN (16) > +#define AW_PID_2049_ATTH_MASK \ > + (~(((1<<AW_PID_2049_ATTH_BITS_LEN)-1) << AW_PID_2049_ATTH_START_BIT)) > + > +#define AW_PID_2049_ATTH_RESERVED (0) > +#define AW_PID_2049_ATTH_RESERVED_VALUE \ > + (AW_PID_2049_ATTH_RESERVED << AW_PID_2049_ATTH_START_BIT) > + > +#define AW_PID_2049_ATTH_DEFAULT_VALUE (0x0030) > +#define AW_PID_2049_ATTH_DEFAULT \ > + (AW_PID_2049_ATTH_DEFAULT_VALUE << AW_PID_2049_ATTH_START_BIT) > + > +/* default value of HAGCCFG2 (0x0A) */ > +/* #define AW_PID_2049_HAGCCFG2_DEFAULT (0x0030) */ > + > +/* HAGCCFG3 (0x0B) detail */ > +/* RTTH bit 15:0 (HAGCCFG3 0x0B) */ > +#define AW_PID_2049_RTTH_START_BIT (0) > +#define AW_PID_2049_RTTH_BITS_LEN (16) > +#define AW_PID_2049_RTTH_MASK \ > + (~(((1<<AW_PID_2049_RTTH_BITS_LEN)-1) << AW_PID_2049_RTTH_START_BIT)) > + > +#define AW_PID_2049_RTTH_RESERVED (0) > +#define AW_PID_2049_RTTH_RESERVED_VALUE \ > + (AW_PID_2049_RTTH_RESERVED << AW_PID_2049_RTTH_START_BIT) > + > +#define AW_PID_2049_RTTH_DEFAULT_VALUE (0x01E0) > +#define AW_PID_2049_RTTH_DEFAULT \ > + (AW_PID_2049_RTTH_DEFAULT_VALUE << AW_PID_2049_RTTH_START_BIT) > + > +/* default value of HAGCCFG3 (0x0B) */ > +/* #define AW_PID_2049_HAGCCFG3_DEFAULT (0x01E0) */ > + > +/* HAGCCFG4 (0x0C) detail */ > +/* IIC_GEN_ADDR bit 15:9 (HAGCCFG4 0x0C) */ > +#define AW_PID_2049_IIC_GEN_ADDR_START_BIT (9) > +#define AW_PID_2049_IIC_GEN_ADDR_BITS_LEN (7) > +#define AW_PID_2049_IIC_GEN_ADDR_MASK \ > + (~(((1<<AW_PID_2049_IIC_GEN_ADDR_BITS_LEN)-1) << AW_PID_2049_IIC_GEN_ADDR_START_BIT)) > + > +#define AW_PID_2049_IIC_GEN_ADDR_DEFAULT_VALUE (0x0E) > +#define AW_PID_2049_IIC_GEN_ADDR_DEFAULT \ > + (AW_PID_2049_IIC_GEN_ADDR_DEFAULT_VALUE << AW_PID_2049_IIC_GEN_ADDR_START_BIT) > + > +/* IIC_GEN_EN bit 8 (HAGCCFG4 0x0C) */ > +#define AW_PID_2049_IIC_GEN_EN_START_BIT (8) > +#define AW_PID_2049_IIC_GEN_EN_BITS_LEN (1) > +#define AW_PID_2049_IIC_GEN_EN_MASK \ > + (~(((1<<AW_PID_2049_IIC_GEN_EN_BITS_LEN)-1) << AW_PID_2049_IIC_GEN_EN_START_BIT)) > + > +#define AW_PID_2049_IIC_GEN_EN_DISABLE (0) > +#define AW_PID_2049_IIC_GEN_EN_DISABLE_VALUE \ > + (AW_PID_2049_IIC_GEN_EN_DISABLE << AW_PID_2049_IIC_GEN_EN_START_BIT) > + > +#define AW_PID_2049_IIC_GEN_EN_ENABLE (1) > +#define AW_PID_2049_IIC_GEN_EN_ENABLE_VALUE \ > + (AW_PID_2049_IIC_GEN_EN_ENABLE << AW_PID_2049_IIC_GEN_EN_START_BIT) > + > +#define AW_PID_2049_IIC_GEN_EN_DEFAULT_VALUE (0) > +#define AW_PID_2049_IIC_GEN_EN_DEFAULT \ > + (AW_PID_2049_IIC_GEN_EN_DEFAULT_VALUE << AW_PID_2049_IIC_GEN_EN_START_BIT) > + > +/* HOLDTH bit 7:0 (HAGCCFG4 0x0C) */ > +#define AW_PID_2049_HOLDTH_START_BIT (0) > +#define AW_PID_2049_HOLDTH_BITS_LEN (8) > +#define AW_PID_2049_HOLDTH_MASK \ > + (~(((1<<AW_PID_2049_HOLDTH_BITS_LEN)-1) << AW_PID_2049_HOLDTH_START_BIT)) > + > +#define AW_PID_2049_HOLDTH_RESERVED (0) > +#define AW_PID_2049_HOLDTH_RESERVED_VALUE \ > + (AW_PID_2049_HOLDTH_RESERVED << AW_PID_2049_HOLDTH_START_BIT) > + > +#define AW_PID_2049_HOLDTH_DEFAULT_VALUE (0x64) > +#define AW_PID_2049_HOLDTH_DEFAULT \ > + (AW_PID_2049_HOLDTH_DEFAULT_VALUE << AW_PID_2049_HOLDTH_START_BIT) > + > +/* default value of HAGCCFG4 (0x0C) */ > +/* #define AW_PID_2049_HAGCCFG4_DEFAULT (0x1C64) */ > + > +/* AGC_DSP_CTL bit 15 (HAGCCFG7 0x0F) */ > +#define AW_PID_2049_AGC_DSP_CTL_START_BIT (15) > +#define AW_PID_2049_AGC_DSP_CTL_BITS_LEN (1) > +#define AW_PID_2049_AGC_DSP_CTL_MASK \ > + (~(((1<<AW_PID_2049_AGC_DSP_CTL_BITS_LEN)-1) << AW_PID_2049_AGC_DSP_CTL_START_BIT)) > + > +#define AW_PID_2049_AGC_DSP_CTL_DISABLE (0) > +#define AW_PID_2049_AGC_DSP_CTL_DISABLE_VALUE \ > + (AW_PID_2049_AGC_DSP_CTL_DISABLE << AW_PID_2049_AGC_DSP_CTL_START_BIT) > + > +#define AW_PID_2049_AGC_DSP_CTL_ENABLE (1) > +#define AW_PID_2049_AGC_DSP_CTL_ENABLE_VALUE \ > + (AW_PID_2049_AGC_DSP_CTL_ENABLE << AW_PID_2049_AGC_DSP_CTL_START_BIT) > +/* VDSEL bit 0 (I2SCFG3 0x12) */ > +#define AW_PID_2049_VDSEL_START_BIT (0) > +#define AW_PID_2049_VDSEL_BITS_LEN (1) > +#define AW_PID_2049_VDSEL_MASK \ > + (~(((1<<AW_PID_2049_VDSEL_BITS_LEN)-1) << AW_PID_2049_VDSEL_START_BIT)) > + > +/* MEM_CLKSEL bit 3 (DBGCTRL 0x13) */ > +#define AW_PID_2049_MEM_CLKSEL_START_BIT (3) > +#define AW_PID_2049_MEM_CLKSEL_BITS_LEN (1) > +#define AW_PID_2049_MEM_CLKSEL_MASK \ > + (~(((1<<AW_PID_2049_MEM_CLKSEL_BITS_LEN)-1) << AW_PID_2049_MEM_CLKSEL_START_BIT)) > + > +#define AW_PID_2049_MEM_CLKSEL_OSC_CLK (0) > +#define AW_PID_2049_MEM_CLKSEL_OSC_CLK_VALUE \ > + (AW_PID_2049_MEM_CLKSEL_OSC_CLK << AW_PID_2049_MEM_CLKSEL_START_BIT) > + > +#define AW_PID_2049_MEM_CLKSEL_DAP_HCLK (1) > +#define AW_PID_2049_MEM_CLKSEL_DAP_HCLK_VALUE \ > + (AW_PID_2049_MEM_CLKSEL_DAP_HCLK << AW_PID_2049_MEM_CLKSEL_START_BIT) > + > +/* HAGCST (0x20) detail */ > +/* SPK_GAIN_ST bit 10:8 (HAGCST 0x20) */ > +#define AW_PID_2049_SPK_GAIN_ST_START_BIT (8) > +#define AW_PID_2049_SPK_GAIN_ST_BITS_LEN (3) > +#define AW_PID_2049_SPK_GAIN_ST_MASK \ > + (~(((1<<AW_PID_2049_SPK_GAIN_ST_BITS_LEN)-1) << AW_PID_2049_SPK_GAIN_ST_START_BIT)) > + > +#define AW_PID_2049_SPK_GAIN_ST_4_AV (0) > +#define AW_PID_2049_SPK_GAIN_ST_4_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_ST_4_AV << AW_PID_2049_SPK_GAIN_ST_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_ST_4P67_AV (1) > +#define AW_PID_2049_SPK_GAIN_ST_4P67_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_ST_4P67_AV << AW_PID_2049_SPK_GAIN_ST_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_ST_6_AV (2) > +#define AW_PID_2049_SPK_GAIN_ST_6_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_ST_6_AV << AW_PID_2049_SPK_GAIN_ST_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_ST_7_AV (3) > +#define AW_PID_2049_SPK_GAIN_ST_7_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_ST_7_AV << AW_PID_2049_SPK_GAIN_ST_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_ST_12_AV (4) > +#define AW_PID_2049_SPK_GAIN_ST_12_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_ST_12_AV << AW_PID_2049_SPK_GAIN_ST_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_ST_14_AV (5) > +#define AW_PID_2049_SPK_GAIN_ST_14_AV_VALUE \ > + (AW_PID_2049_SPK_GAIN_ST_14_AV << AW_PID_2049_SPK_GAIN_ST_START_BIT) > + > +#define AW_PID_2049_SPK_GAIN_ST_DEFAULT_VALUE (5) > +#define AW_PID_2049_SPK_GAIN_ST_DEFAULT \ > + (AW_PID_2049_SPK_GAIN_ST_DEFAULT_VALUE << AW_PID_2049_SPK_GAIN_ST_START_BIT) > + > +/* BSTVOUT_ST bit 5:0 (HAGCST 0x20) */ > +#define AW_PID_2049_BSTVOUT_ST_START_BIT (0) > +#define AW_PID_2049_BSTVOUT_ST_BITS_LEN (6) > +#define AW_PID_2049_BSTVOUT_ST_MASK \ > + (~(((1<<AW_PID_2049_BSTVOUT_ST_BITS_LEN)-1) << AW_PID_2049_BSTVOUT_ST_START_BIT)) > + > +#define AW_PID_2049_BSTVOUT_ST_3P125V (0) > +#define AW_PID_2049_BSTVOUT_ST_3P125V_VALUE \ > + (AW_PID_2049_BSTVOUT_ST_3P125V << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +#define AW_PID_2049_BSTVOUT_ST_3P250V (1) > +#define AW_PID_2049_BSTVOUT_ST_3P250V_VALUE \ > + (AW_PID_2049_BSTVOUT_ST_3P250V << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +#define AW_PID_2049_BSTVOUT_ST_3P375V (2) > +#define AW_PID_2049_BSTVOUT_ST_3P375V_VALUE \ > + (AW_PID_2049_BSTVOUT_ST_3P375V << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +#define AW_PID_2049_BSTVOUT_ST_3P500V (3) > +#define AW_PID_2049_BSTVOUT_ST_3P500V_VALUE \ > + (AW_PID_2049_BSTVOUT_ST_3P500V << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +#define AW_PID_2049_BSTVOUT_ST_3P625V (4) > +#define AW_PID_2049_BSTVOUT_ST_3P625V_VALUE \ > + (AW_PID_2049_BSTVOUT_ST_3P625V << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +#define AW_PID_2049_BSTVOUT_ST_3P750V (5) > +#define AW_PID_2049_BSTVOUT_ST_3P750V_VALUE \ > + (AW_PID_2049_BSTVOUT_ST_3P750V << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +#define AW_PID_2049_BSTVOUT_ST_11P000V (63) > +#define AW_PID_2049_BSTVOUT_ST_11P000V_VALUE \ > + (AW_PID_2049_BSTVOUT_ST_11P000V << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +#define AW_PID_2049_BSTVOUT_ST_DEFAULT_VALUE (0) > +#define AW_PID_2049_BSTVOUT_ST_DEFAULT \ > + (AW_PID_2049_BSTVOUT_ST_DEFAULT_VALUE << AW_PID_2049_BSTVOUT_ST_START_BIT) > + > +/* default value of HAGCST (0x20) */ > +/* #define AW_PID_2049_HAGCST_DEFAULT (0x0500) */ > + > +/* VBAT (0x21) detail */ > +/* VBAT_DET bit 9:0 (VBAT 0x21) */ > +#define AW_PID_2049_VBAT_DET_START_BIT (0) > +#define AW_PID_2049_VBAT_DET_BITS_LEN (10) > +#define AW_PID_2049_VBAT_DET_MASK \ > + (~(((1<<AW_PID_2049_VBAT_DET_BITS_LEN)-1) << AW_PID_2049_VBAT_DET_START_BIT)) > + > +#define AW_PID_2049_VBAT_DET_DEFAULT_VALUE (0x263) > +#define AW_PID_2049_VBAT_DET_DEFAULT \ > + (AW_PID_2049_VBAT_DET_DEFAULT_VALUE << AW_PID_2049_VBAT_DET_START_BIT) > + > +#define AW_PID_2049_VBAT_RANGE (6025) > +#define AW_PID_2049_INT_10BIT (1023) > +/* default value of VBAT (0x21) */ > +/* #define AW_PID_2049_VBAT_DEFAULT (0x0263) */ > + > +/* TEMP (0x22) detail */ > +/* TEMP_DET bit 9:0 (TEMP 0x22) */ > +#define AW_PID_2049_TEMP_DET_START_BIT (0) > +#define AW_PID_2049_TEMP_DET_BITS_LEN (10) > +#define AW_PID_2049_TEMP_DET_MASK \ > + (~(((1<<AW_PID_2049_TEMP_DET_BITS_LEN)-1) << AW_PID_2049_TEMP_DET_START_BIT)) > + > +#define AW_PID_2049_TEMP_DET_MINUS_40 (0x3D8) > +#define AW_PID_2049_TEMP_DET_MINUS_40_VALUE \ > + (AW_PID_2049_TEMP_DET_MINUS_40 << AW_PID_2049_TEMP_DET_START_BIT) > + > +#define AW_PID_2049_TEMP_DET_0 (0x00) > +#define AW_PID_2049_TEMP_DET_0_VALUE \ > + (AW_PID_2049_TEMP_DET_0 << AW_PID_2049_TEMP_DET_START_BIT) > + > +#define AW_PID_2049_TEMP_DET_1 (0x01) > +#define AW_PID_2049_TEMP_DET_1_VALUE \ > + (AW_PID_2049_TEMP_DET_1 << AW_PID_2049_TEMP_DET_START_BIT) > + > +#define AW_PID_2049_TEMP_DET_25 (0x19) > +#define AW_PID_2049_TEMP_DET_25_VALUE \ > + (AW_PID_2049_TEMP_DET_25 << AW_PID_2049_TEMP_DET_START_BIT) > + > +#define AW_PID_2049_TEMP_DET_55 (0x37) > +#define AW_PID_2049_TEMP_DET_55_VALUE \ > + (AW_PID_2049_TEMP_DET_55 << AW_PID_2049_TEMP_DET_START_BIT) > + > +#define AW_PID_2049_TEMP_DET_DEFAULT_VALUE (0x019) > +#define AW_PID_2049_TEMP_DET_DEFAULT \ > + (AW_PID_2049_TEMP_DET_DEFAULT_VALUE << AW_PID_2049_TEMP_DET_START_BIT) > +#define AW_PID_2049_TEMP_SIGN_MASK (~(1 << 9)) > +#define AW_PID_2049_TEMP_NEG_MASK (0XFC00) > + > +/* default value of TEMP (0x22) */ > +/* #define AW_PID_2049_TEMP_DEFAULT (0x0019) */ > + > +/* PVDD (0x23) detail */ > +/* PVDD_DET bit 9:0 (PVDD 0x23) */ > +#define AW_PID_2049_PVDD_DET_START_BIT (0) > +#define AW_PID_2049_PVDD_DET_BITS_LEN (10) > +#define AW_PID_2049_PVDD_DET_MASK \ > + (~(((1<<AW_PID_2049_PVDD_DET_BITS_LEN)-1) << AW_PID_2049_PVDD_DET_START_BIT)) > + > +#define AW_PID_2049_PVDD_DET_DEFAULT_VALUE (0x263) > +#define AW_PID_2049_PVDD_DET_DEFAULT \ > + (AW_PID_2049_PVDD_DET_DEFAULT_VALUE << AW_PID_2049_PVDD_DET_START_BIT) > + > +/* default value of PVDD (0x23) */ > +/* #define AW_PID_2049_PVDD_DEFAULT (0x0263) */ > + > +/* BSTCTRL1 (0x60) detail */ > +/* BST_RTH bit 13:8 (BSTCTRL1 0x60) */ > +#define AW_PID_2049_BST_RTH_START_BIT (8) > +#define AW_PID_2049_BST_RTH_BITS_LEN (6) > +#define AW_PID_2049_BST_RTH_MASK \ > + (~(((1<<AW_PID_2049_BST_RTH_BITS_LEN)-1) << AW_PID_2049_BST_RTH_START_BIT)) > + > +#define AW_PID_2049_BST_RTH_DEFAULT_VALUE (4) > +#define AW_PID_2049_BST_RTH_DEFAULT \ > + (AW_PID_2049_BST_RTH_DEFAULT_VALUE << AW_PID_2049_BST_RTH_START_BIT) > + > +/* BST_ATH bit 5:0 (BSTCTRL1 0x60) */ > +#define AW_PID_2049_BST_ATH_START_BIT (0) > +#define AW_PID_2049_BST_ATH_BITS_LEN (6) > +#define AW_PID_2049_BST_ATH_MASK \ > + (~(((1<<AW_PID_2049_BST_ATH_BITS_LEN)-1) << AW_PID_2049_BST_ATH_START_BIT)) > + > +#define AW_PID_2049_BST_ATH_DEFAULT_VALUE (2) > +#define AW_PID_2049_BST_ATH_DEFAULT \ > + (AW_PID_2049_BST_ATH_DEFAULT_VALUE << AW_PID_2049_BST_ATH_START_BIT) > + > +/* default value of BSTCTRL1 (0x60) */ > +/* #define AW_PID_2049_BSTCTRL1_DEFAULT (0x0402) */ > + > +/* BSTCTRL2 (0x61) detail */ > +/* BST_MODE bit 14:12 (BSTCTRL2 0x61) */ > +#define AW_PID_2049_BST_MODE_START_BIT (12) > +#define AW_PID_2049_BST_MODE_BITS_LEN (3) > +#define AW_PID_2049_BST_MODE_MASK \ > + (~(((1<<AW_PID_2049_BST_MODE_BITS_LEN)-1) << AW_PID_2049_BST_MODE_START_BIT)) > + > +#define AW_PID_2049_BST_MODE_TRANSPARENT (0) > +#define AW_PID_2049_BST_MODE_TRANSPARENT_VALUE \ > + (AW_PID_2049_BST_MODE_TRANSPARENT << AW_PID_2049_BST_MODE_START_BIT) > + > +#define AW_PID_2049_BST_MODE_FORCE_BOOST (1) > +#define AW_PID_2049_BST_MODE_FORCE_BOOST_VALUE \ > + (AW_PID_2049_BST_MODE_FORCE_BOOST << AW_PID_2049_BST_MODE_START_BIT) > + > +#define AW_PID_2049_BST_MODE_SMART_BOOST1 (5) > +#define AW_PID_2049_BST_MODE_SMART_BOOST1_VALUE \ > + (AW_PID_2049_BST_MODE_SMART_BOOST1 << AW_PID_2049_BST_MODE_START_BIT) > + > +#define AW_PID_2049_BST_MODE_SMART_BOOST2 (6) > +#define AW_PID_2049_BST_MODE_SMART_BOOST2_VALUE \ > + (AW_PID_2049_BST_MODE_SMART_BOOST2 << AW_PID_2049_BST_MODE_START_BIT) > + > +#define AW_PID_2049_BST_MODE_DEFAULT_VALUE (0x6) > +#define AW_PID_2049_BST_MODE_DEFAULT \ > + (AW_PID_2049_BST_MODE_DEFAULT_VALUE << AW_PID_2049_BST_MODE_START_BIT) > + > +/* WDT_CNT bit 7:0 (WDT 0x42) */ > +#define AW_PID_2049_WDT_CNT_START_BIT (0) > +#define AW_PID_2049_WDT_CNT_BITS_LEN (8) > +#define AW_PID_2049_WDT_CNT_MASK \ > + (~(((1<<AW_PID_2049_WDT_CNT_BITS_LEN)-1) << AW_PID_2049_WDT_CNT_START_BIT)) > + > +/* BST_TDEG bit 11:8 (BSTCTRL2 0x61) */ > +#define AW_PID_2049_BST_TDEG_START_BIT (8) > +#define AW_PID_2049_BST_TDEG_BITS_LEN (4) > +#define AW_PID_2049_BST_TDEG_MASK \ > + (~(((1<<AW_PID_2049_BST_TDEG_BITS_LEN)-1) << AW_PID_2049_BST_TDEG_START_BIT)) > + > +#define AW_PID_2049_BST_TDEG_0P50_MS (0) > +#define AW_PID_2049_BST_TDEG_0P50_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_0P50_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_1P00_MS (1) > +#define AW_PID_2049_BST_TDEG_1P00_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_1P00_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_2P00_MS (2) > +#define AW_PID_2049_BST_TDEG_2P00_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_2P00_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_4P00_MS (3) > +#define AW_PID_2049_BST_TDEG_4P00_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_4P00_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_8P00_MS (4) > +#define AW_PID_2049_BST_TDEG_8P00_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_8P00_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_10P7_MS (5) > +#define AW_PID_2049_BST_TDEG_10P7_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_10P7_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +/* ReAbs bit 3 (ASR1 0x45) */ > +#define AW_PID_2049_ReAbs_START_BIT (3) > +#define AW_PID_2049_ReAbs_BITS_LEN (1) > +#define AW_PID_2049_ReAbs_MASK \ > + (~(((1<<AW_PID_2049_ReAbs_BITS_LEN)-1) << AW_PID_2049_ReAbs_START_BIT)) > + > +#define AW_PID_2049_BST_TDEG_13P3_MS (6) > +#define AW_PID_2049_BST_TDEG_13P3_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_13P3_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +/* DSP_VOL bit 15:8 (DSPCFG 0x47) */ > +#define AW_PID_2049_DSP_VOL_START_BIT (8) > +#define AW_PID_2049_DSP_VOL_BITS_LEN (8) > +#define AW_PID_2049_DSP_VOL_MASK \ > + (~(((1<<AW_PID_2049_DSP_VOL_BITS_LEN)-1) << AW_PID_2049_DSP_VOL_START_BIT)) > + > +#define AW_PID_2049_DSP_VOL_MUTE (0XFF00) > +#define AW_PID_2049_DSP_VOL_NOISE_ST (0X1800) > + > +#define AW_PID_2049_BST_TDEG_16P0_MS (7) > +#define AW_PID_2049_BST_TDEG_16P0_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_16P0_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_18P6_MS (8) > +#define AW_PID_2049_BST_TDEG_18P6_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_18P6_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_21P3_MS (9) > +#define AW_PID_2049_BST_TDEG_21P3_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_21P3_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_24P0_MS (10) > +#define AW_PID_2049_BST_TDEG_24P0_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_24P0_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_32P0_MS (11) > +#define AW_PID_2049_BST_TDEG_32P0_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_32P0_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_64P0_MS (12) > +#define AW_PID_2049_BST_TDEG_64P0_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_64P0_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_128_MS (13) > +#define AW_PID_2049_BST_TDEG_128_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_128_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_256_MS (14) > +#define AW_PID_2049_BST_TDEG_256_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_256_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_1200_MS (15) > +#define AW_PID_2049_BST_TDEG_1200_MS_VALUE \ > + (AW_PID_2049_BST_TDEG_1200_MS << AW_PID_2049_BST_TDEG_START_BIT) > + > +#define AW_PID_2049_BST_TDEG_DEFAULT_VALUE (11) > +#define AW_PID_2049_BST_TDEG_DEFAULT \ > + (AW_PID_2049_BST_TDEG_DEFAULT_VALUE << AW_PID_2049_BST_TDEG_START_BIT) > + > +/* VOUT_VREFSET bit 5:0 (BSTCTRL2 0x61) */ > +/* CCO_MUX bit 14 (PLLCTRL1 0x52) */ > +#define AW_PID_2049_CCO_MUX_START_BIT (14) > +#define AW_PID_2049_CCO_MUX_BITS_LEN (1) > +#define AW_PID_2049_CCO_MUX_MASK \ > + (~(((1<<AW_PID_2049_CCO_MUX_BITS_LEN)-1) << AW_PID_2049_CCO_MUX_START_BIT)) > + > +#define AW_PID_2049_CCO_MUX_DIVIDED (0) > +#define AW_PID_2049_CCO_MUX_DIVIDED_VALUE \ > + (AW_PID_2049_CCO_MUX_DIVIDED << AW_PID_2049_CCO_MUX_START_BIT) > + > +#define AW_PID_2049_CCO_MUX_BYPASS (1) > +#define AW_PID_2049_CCO_MUX_BYPASS_VALUE \ > + (AW_PID_2049_CCO_MUX_BYPASS << AW_PID_2049_CCO_MUX_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_START_BIT (0) > +#define AW_PID_2049_VOUT_VREFSET_BITS_LEN (6) > +#define AW_PID_2049_VOUT_VREFSET_MASK \ > + (~(((1<<AW_PID_2049_VOUT_VREFSET_BITS_LEN)-1) << AW_PID_2049_VOUT_VREFSET_START_BIT)) > + > +#define AW_PID_2049_VOUT_VREFSET_3P125V (0) > +#define AW_PID_2049_VOUT_VREFSET_3P125V_VALUE \ > + (AW_PID_2049_VOUT_VREFSET_3P125V << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_3P250V (1) > +#define AW_PID_2049_VOUT_VREFSET_3P250V_VALUE \ > + (AW_PID_2049_VOUT_VREFSET_3P250V << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_3P375V (2) > +#define AW_PID_2049_VOUT_VREFSET_3P375V_VALUE \ > + (AW_PID_2049_VOUT_VREFSET_3P375V << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_3P500V (3) > +#define AW_PID_2049_VOUT_VREFSET_3P500V_VALUE \ > + (AW_PID_2049_VOUT_VREFSET_3P500V << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_3P625V (4) > +#define AW_PID_2049_VOUT_VREFSET_3P625V_VALUE \ > + (AW_PID_2049_VOUT_VREFSET_3P625V << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_3P750V (5) > +#define AW_PID_2049_VOUT_VREFSET_3P750V_VALUE \ > + (AW_PID_2049_VOUT_VREFSET_3P750V << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_11P000V (63) > +#define AW_PID_2049_VOUT_VREFSET_11P000V_VALUE \ > + (AW_PID_2049_VOUT_VREFSET_11P000V << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +#define AW_PID_2049_VOUT_VREFSET_DEFAULT_VALUE (0x33) > +#define AW_PID_2049_VOUT_VREFSET_DEFAULT \ > + (AW_PID_2049_VOUT_VREFSET_DEFAULT_VALUE << AW_PID_2049_VOUT_VREFSET_START_BIT) > + > +/* default value of BSTCTRL2 (0x61) */ > +/* #define AW_PID_2049_BSTCTRL2_DEFAULT (0x6B33) */ > + > +/* detail information of registers end */ > + > +/* EF_VSN_GESLP bit 9:0 (EFRH 0x78) */ > +#define AW_PID_2049_EF_VSN_GESLP_START_BIT (0) > +#define AW_PID_2049_EF_VSN_GESLP_BITS_LEN (10) > +#define AW_PID_2049_EF_VSN_GESLP_MASK \ > + (~(((1<<AW_PID_2049_EF_VSN_GESLP_BITS_LEN)-1) << AW_PID_2049_EF_VSN_GESLP_START_BIT)) > + > +#define AW_PID_2049_EF_VSN_GESLP_SIGN_MASK (~(1 << 9)) > +#define AW_PID_2049_EF_VSN_GESLP_SIGN_NEG (0xfe00) > +/* EF_ISN_GESLP bit 9:0 (EFRM2 0x79) */ > +#define AW_PID_2049_EF_ISN_GESLP_START_BIT (0) > +#define AW_PID_2049_EF_ISN_GESLP_BITS_LEN (10) > +#define AW_PID_2049_EF_ISN_GESLP_MASK \ > + (~(((1<<AW_PID_2049_EF_ISN_GESLP_BITS_LEN)-1) << AW_PID_2049_EF_ISN_GESLP_START_BIT)) > + > +#define AW_PID_2049_EF_ISN_GESLP_SIGN_MASK (~(1 << 9)) > +#define AW_PID_2049_EF_ISN_GESLP_SIGN_NEG (0xfe00) > +/* > + * Vcalb > + */ > + > +#define AW_PID_2049_CABL_BASE_VALUE (1000) > +#define AW_PID_2049_ICABLK_FACTOR (1) > +#define AW_PID_2049_VCABLK_FACTOR (1) > +#define AW_PID_2049_VCAL_FACTOR (1 << 12) > +#define AW_PID_2049_VSCAL_FACTOR (16500) > +#define AW_PID_2049_ISCAL_FACTOR (3667) > +#define AW_PID_2049_EF_VSENSE_GAIN_SHIFT (0) > + > +#define AW_PID_2049_VCABLK_FACTOR_DAC (2) > +#define AW_PID_2049_VSCAL_FACTOR_DAC (11790) > +#define AW_PID_2049_EF_DAC_GESLP_SHIFT (10) > +#define AW_PID_2049_EF_DAC_GESLP_SIGN_MASK (1 << 5) > +#define AW_PID_2049_EF_DAC_GESLP_SIGN_NEG (0xffc0) > + > +#define AW_PID_2049_VCALB_ADJ_FACTOR (12) > + > +/* > + * AW883XX DSP > + */ > +#define AW_PID_2049_DSP_CFG_ADDR (0x9C80) > +#define AW_PID_2049_DSP_FW_ADDR (0x8C00) > + > +#define AW_PID_2049_DSP_REG_RESULT_F0 (0x9C58) > +#define AW_PID_2049_DSP_F0_SHIFT (1) > + > +#define AW_PID_2049_DSP_REG_CALRE (0x9C5A) > +#define AW_PID_2049_DSP_REG_CALRE_SHIFT (10) > +#define AW_PID_2049_DSP_REG_RESULT_Q (0x9C5C) > +#define AW_PID_2049_DSP_Q_SHIFT (11) > + > +#define AW_PID_2049_DSP_REG_VMAX (0x9C94) > + > + > +#define AW_PID_2049_DSP_REG_CFG_MBMEC_GLBCFG (0x9CE2) > +/* bit 0 */ > +#define AW_PID_2049_DSP_MONITOR_MASK (~(1 << 0)) > +#define AW_PID_2049_DSP_MONITOR_ENABLE (1 << 0) > +#define AW_PID_2049_DSP_MONITOR_DISABLE (0 << 0) > +/*bit 4*/ > +#define AW_PID_2049_DSP_REG_NOISE_MASK (~(1 << 4)) > + > +#define AW_PID_2049_DSP_TEMP_PEAK_MASK (~(1 << 4)) > +#define AW_PID_2049_DSP_TEMP_SEL_FLAG (~(1 << 14)) > + > +#define AW_PID_2049_DSP_REG_CFG_MBMEC_ACTAMPTH (0x9CE4)/*32bit*/ > +#define AW_PID_2049_DSP_REG_CFG_MBMEC_NOISEAMPTH (0x9CE6)/*32bit*/ > +#define AW_PID_2049_DSP_REG_VCALB (0x9CF7) > + > +#define AW_PID_2049_DSP_REG_CFG_ADPZ_RE (0x9D00)/*32bit*/ > +#define AW_PID_2049_DSP_RE_SHIFT (12) > + > +#define AW_PID_2049_DSP_REG_CFG_ADPZ_RA (0x9D02)/*32bit*/ > + > +#define AW_PID_2049_DSP_REG_CFG_ADPZ_USTEPN (0x9D08) > + > + > +#define AW_PID_2049_DSP_REG_CRC_ADDR (0x9F42)/*32bit*/ > +#define AW_PID_2049_DSP_REG_CFGF0_FS (0x9F44)/*32bit*/ > +#define AW_PID_2049_DSP_REG_CFG_RE_ALPHA (0x9F47) > +#define AW_PID_2049_DSP_REG_TEMP_ADDR (0x9C5D) > +#define AW_PID_2049_DSP_REG_TEMP_SWITCH (0x9D71)/*16bit*/ > +#define AW_PID_2049_DSP_CALI_F0_DELAY (0x9CFD) > +#define AW_PID_2049_DSP_CFG_ADPZ_T0 (0x9D11)/*16bit*/ > +#define AW_PID_2049_DSP_CFG_ADPZ_COILALPHA (0x9D0F)/*16bit*/ > +#define AW_PID_2049_DSP_ST_S1 (0x8180) > +#define AW_PID_2049_DSP_ST_E1 (0x83FD) > +#define AW_PID_2049_DSP_ST_S2 (0x9C00) > +#define AW_PID_2049_DSP_ST_E2 (0x9C5D) > + > +#endif /* #ifndef __AW_PID_2049_REG_H__ */ > diff --git a/sound/soc/codecs/aw883xx/aw883xx_spin.c b/sound/soc/codecs/aw883xx/aw883xx_spin.c > new file mode 100644 > index 0000000..de5f6c3 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_spin.c > @@ -0,0 +1,807 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * aw_spin.c aw883xx spin module > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD > + * > + * Author: Bruce zhao <zhaolei(a)awinic.com> > + */ > + > +#include <linux/module.h> > +#include <linux/i2c.h> > +#include <sound/soc.h> > +#include <linux/of_gpio.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/version.h> > +#include <linux/syscalls.h> > +#include <sound/control.h> > +#include <linux/uaccess.h> > +#include <linux/debugfs.h> > +#include <linux/slab.h> > +#include <linux/fs.h> > +#include <linux/kernel.h> > +#include <linux/of.h> > +#include "aw883xx_spin.h" > +#include "aw883xx_device.h" > +#include "aw883xx.h" > +#include "aw883xx_log.h" > + > +static DEFINE_MUTEX(g_aw_spin_lock); > +static DEFINE_MUTEX(g_aw_dsp_lock); > + > +static int g_rx_topo_id = AW_RX_TOPO_ID; > +static int g_rx_port_id = AW_RX_PORT_ID; > + > +static unsigned int g_spin_angle = AW_SPIN_0; > +static unsigned int g_spin_mode = AW_SPIN_OFF_MODE; > + > +static const char *const aw_spin[] = {"spin_0", "spin_90", > + "spin_180", "spin_270"}; > + > +#ifdef AW_MTK_PLATFORM_SPIN > +extern int mtk_spk_send_ipi_buf_to_dsp(void *data_buffer, uint32_t data_size); > +extern int mtk_spk_recv_ipi_buf_from_dsp(int8_t *buffer, int16_t size, uint32_t *buf_len); > +#elif defined AW_QCOM_PLATFORM_SPIN > +extern int afe_get_topology(int port_id); > +extern int aw_send_afe_cal_apr(uint32_t param_id, > + void *buf, int cmd_size, bool write); > +#else > +static int aw_send_afe_cal_apr(uint32_t param_id, > + void *buf, int cmd_size, bool write) > +{ > + return 0; > +} > + > +static int afe_get_topology(int port_id) > +{ > + return 0; > +} > +#endif > + > +#ifdef AW_QCOM_PLATFORM_SPIN > +extern void aw_set_port_id(int tx_port_id, int rx_port_id); > +#else > +static void aw_set_port_id(int tx_port_id, int rx_port_id) > +{ > + > +} > +#endif > + > +static int aw_get_msg_id(int dev_ch, uint32_t *msg_id) > +{ > + switch (dev_ch) { > + case AW_DEV_CH_PRI_L: > + *msg_id = AFE_MSG_ID_MSG_0; > + break; > + case AW_DEV_CH_PRI_R: > + *msg_id = AFE_MSG_ID_MSG_0; > + break; > + case AW_DEV_CH_SEC_L: > + *msg_id = AFE_MSG_ID_MSG_1; > + break; > + case AW_DEV_CH_SEC_R: > + *msg_id = AFE_MSG_ID_MSG_1; > + break; > + default: > + pr_err("%s: can not find msg num, channel %d ", __func__, dev_ch); > + return -EINVAL; > + } > + > + pr_debug("%s: msg id[%d] ", __func__, *msg_id); > + return 0; > +} > + > +#ifdef AW_MTK_PLATFORM_SPIN > +static int aw_mtk_write_data_to_dsp(int msg_id, void *data, int size) > +{ > + int32_t *dsp_data = NULL; > + struct aw_msg_hdr *hdr = NULL; > + int ret; > + > + dsp_data = kzalloc(sizeof(struct aw_msg_hdr) + size, GFP_KERNEL); > + if (!dsp_data) > + return -ENOMEM; > + > + hdr = (struct aw_msg_hdr *)dsp_data; > + hdr->type = AW_DSP_MSG_TYPE_DATA; > + hdr->opcode_id = msg_id; > + hdr->version = AW_DSP_MSG_HDR_VER; > + > + memcpy(((char *)dsp_data) + sizeof(struct aw_msg_hdr), data, size); > + > + ret = mtk_spk_send_ipi_buf_to_dsp(dsp_data, > + sizeof(struct aw_msg_hdr) + size); > + if (ret < 0) { > + pr_err("%s: write data failed\n", __func__); > + kfree(dsp_data); > + dsp_data = NULL; > + return ret; > + } > + > + kfree(dsp_data); > + dsp_data = NULL; > + return 0; > +} > + > +static int aw_mtk_set_spin_angle(struct aw_device *aw_dev, uint32_t spin_angle) > +{ > + int ret; > + > + ret = aw_mtk_write_data_to_dsp(AW_MSG_ID_SPIN, &spin_angle, sizeof(uint32_t)); > + if (ret) > + aw_dev_err(aw_dev->dev, "write data to dsp failed"); > + > + return ret; > +} > + > +static int aw_mtk_get_spin_angle(void *spin_angle, int size) > +{ > + int ret; > + struct aw_msg_hdr hdr; > + > + hdr.type = AW_DSP_MSG_TYPE_CMD; > + hdr.opcode_id = AW_MSG_ID_SPIN; > + hdr.version = AW_DSP_MSG_HDR_VER; > + > + mutex_lock(&g_aw_dsp_lock); > + ret = mtk_spk_send_ipi_buf_to_dsp(&hdr, sizeof(struct aw_msg_hdr)); > + if (ret < 0) { > + pr_err("%s:send cmd failed\n", __func__); > + mutex_unlock(&g_aw_dsp_lock); > + return ret; > + } > + > + ret = mtk_spk_recv_ipi_buf_from_dsp(spin_angle, size, &size); > + if (ret < 0) { > + pr_err("%s:get data failed\n", __func__); > + mutex_unlock(&g_aw_dsp_lock); > + return ret; > + } > + mutex_unlock(&g_aw_dsp_lock); > + > + return 0; > +} > + > +static int aw_mtk_set_mixer_en(struct aw_device *aw_dev, uint32_t msg_id, int32_t is_enable) > +{ > + int32_t *dsp_msg = NULL; > + struct aw_msg_hdr *hdr = NULL; > + int ret; > + > + dsp_msg = kzalloc(sizeof(struct aw_msg_hdr) + sizeof(int32_t), GFP_KERNEL); > + if (!dsp_msg) > + return -ENOMEM; > + hdr = (struct aw_msg_hdr *)dsp_msg; > + hdr->type = AW_DSP_MSG_TYPE_DATA; > + hdr->opcode_id = AW_INLINE_ID_AUDIO_MIX; > + hdr->version = AW_DSP_MSG_HDR_VER; > + > + memcpy(((char *)dsp_msg) + sizeof(struct aw_msg_hdr), > + (char *)&is_enable, sizeof(int32_t)); > + > + ret = aw_mtk_write_data_to_dsp(msg_id, (void *)dsp_msg, > + sizeof(struct aw_msg_hdr) + sizeof(int32_t)); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, " write data failed"); > + kfree(dsp_msg); > + dsp_msg = NULL; > + return ret; > + } > + > + kfree(dsp_msg); > + dsp_msg = NULL; > + return 0; > +} > +#else > +static int aw_check_dsp_ready(void) > +{ > + int ret; > + > + ret = afe_get_topology(g_rx_port_id); What is this related to, and why is this Qualcomm-specific. I stopped here. > + > + aw_pr_dbg("rx topo_id 0x%x ", ret); > + > + if (ret != g_rx_topo_id) > + aw_pr_err("get rx_topo_id 0x%x ", ret); > + > + return 0; > +} > + > +static int aw_qcom_write_data_to_dsp(uint32_t msg_id, void *data, int size) > +{ > + int ret; > + > + mutex_lock(&g_aw_dsp_lock); > + > + aw_check_dsp_ready(); > + ret = aw_send_afe_cal_apr(msg_id, data, size, true); > + > + mutex_unlock(&g_aw_dsp_lock); > + > + return ret; > +} > + > +static int aw_qcom_read_data_from_dsp(uint32_t msg_id, void *data, int size) > +{ > + int ret; > + > + mutex_lock(&g_aw_dsp_lock); > + > + aw_check_dsp_ready(); > + ret = aw_send_afe_cal_apr(msg_id, data, size, false); > + > + mutex_unlock(&g_aw_dsp_lock); > + > + return ret; > +} > + > +static int aw_qcom_set_spin_angle(struct aw_device *aw_dev, > + uint32_t spin_angle) > +{ > + int ret; > + > + ret = aw_qcom_write_data_to_dsp(AW_MSG_ID_SPIN, &spin_angle, sizeof(uint32_t)); > + if (ret) > + aw_dev_err(aw_dev->dev, "write spin angle to dsp failed"); > + else > + aw_dev_info(aw_dev->dev, "write spin angle to dsp successful"); > + > + return ret; > +} > + > +static int aw_qcom_get_spin_angle(uint32_t *spin_angle, int size) > +{ > + int ret; > + > + ret = aw_qcom_read_data_from_dsp(AW_MSG_ID_SPIN, spin_angle, size); > + if (ret) > + pr_err("%s: get spin angle failed\n", __func__); > + else > + pr_info("%s: get spin angle successful\n", __func__); > + > + return ret; > +} > + > +static int aw_qcom_set_mixer_en(struct aw_device *aw_dev, > + uint32_t msg_id, int32_t is_enable) > +{ > + int32_t *dsp_msg; > + int ret = 0; > + int msg_len = (int)(sizeof(struct aw_msg_hdr) + sizeof(int32_t)); > + > + dsp_msg = kzalloc(msg_len, GFP_KERNEL); > + if (!dsp_msg) > + return -ENOMEM; > + > + dsp_msg[0] = AW_DSP_MSG_TYPE_DATA; > + dsp_msg[1] = AW_INLINE_ID_AUDIO_MIX; > + dsp_msg[2] = AW_DSP_MSG_HDR_VER; > + > + memcpy(dsp_msg + (sizeof(struct aw_msg_hdr) / sizeof(int32_t)), > + (char *)&is_enable, sizeof(int32_t)); > + > + ret = aw_qcom_write_data_to_dsp(msg_id, (void *)dsp_msg, msg_len); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "write data to dsp failed"); > + kfree(dsp_msg); > + return ret; > + } > + > + aw_dev_dbg(aw_dev->dev, "write data[%d] to dsp success", msg_len); > + kfree(dsp_msg); > + return 0; > +} > +#endif > + > +/***********************************spin_angle**********************************/ > +static int aw_set_adsp_spin_angle(struct aw_device *aw_dev, uint32_t spin_angle) > +{ > + if (spin_angle >= AW_SPIN_MAX) { > + aw_dev_err(aw_dev->dev, "spin_angle:%d not support", > + spin_angle); > + return -EINVAL; > + } > + > +#ifdef AW_MTK_PLATFORM_SPIN > + return aw_mtk_set_spin_angle(aw_dev, spin_angle); > +#else > + return aw_qcom_set_spin_angle(aw_dev, spin_angle); > +#endif > +} > + > +static void aw_get_adsp_spin_angle(uint32_t *spin_angle) > +{ > +#ifdef AW_MTK_PLATFORM_SPIN > + aw_mtk_get_spin_angle(spin_angle, sizeof(uint32_t)); > +#else > + aw_qcom_get_spin_angle(spin_angle, sizeof(uint32_t)); > +#endif > +} > +/*******************************************************************************/ > + > +/**********************************mixer_status*********************************/ > +static int aw_set_mixer_en(struct aw_device *aw_dev, int32_t is_enable) > +{ > + int ret; > + uint32_t msg_id; > + > + ret = aw_get_msg_id(aw_dev->channel, &msg_id); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get msg_num failed"); > + return ret; > + } > + > +#ifdef AW_MTK_PLATFORM_SPIN > + ret = aw_mtk_set_mixer_en(aw_dev, msg_id, is_enable); > +#else > + ret = aw_qcom_set_mixer_en(aw_dev, msg_id, is_enable); > +#endif No, we can't have such ifdefs > + if (ret) > + aw_dev_err(aw_dev->dev, "set mixer status failed"); > + > + return ret; > +} > + > +int aw883xx_hold_reg_spin_st(struct aw_spin_desc *spin_desc) > +{ > + struct aw_device *aw_dev = container_of(spin_desc, > + struct aw_device, spin_desc); > + uint16_t reg_val; > + > + if (aw_dev == NULL) { > + aw_pr_err("aw_dev is NULL"); > + return -EINVAL; > + } > + > + mutex_lock(&g_aw_spin_lock); > + if ((g_spin_mode == AW_REG_SPIN_MODE) || > + (g_spin_mode == AW_REG_MIXER_SPIN_MODE)) { > + /*set rx*/ > + aw_dev->ops.aw_reg_read(aw_dev, > + aw_dev->chansel_desc.rxchan_reg, &reg_val); > + reg_val &= aw_dev->chansel_desc.rxchan_mask; > + reg_val |= spin_desc->spin_table[g_spin_angle].rx_val; > + aw_dev->ops.aw_reg_write(aw_dev, > + aw_dev->chansel_desc.rxchan_reg, reg_val); > + > + /*set tx*/ > + aw_dev->ops.aw_reg_read(aw_dev, > + aw_dev->chansel_desc.txchan_reg, &reg_val); > + reg_val &= aw_dev->chansel_desc.txchan_mask; > + reg_val |= spin_desc->spin_table[g_spin_angle].tx_val; > + aw_dev->ops.aw_reg_write(aw_dev, > + aw_dev->chansel_desc.txchan_reg, reg_val); > + } > + mutex_unlock(&g_aw_spin_lock); > + > + return 0; > +} > + > +int aw883xx_check_spin_mode(struct aw_spin_desc *spin_desc) > +{ > + struct list_head *pos = NULL; > + struct list_head *dev_list = NULL; > + struct aw_device *local_pa = NULL; > + int ret = -1; > + int spin_mode = AW_SPIN_OFF_MODE; > + struct aw_device *aw_dev = container_of(spin_desc, > + struct aw_device, spin_desc); > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev->private_data; > + > + if (g_spin_mode == AW_SPIN_OFF_MODE) { > + aw883xx->spin_flag = AW_SPIN_OFF; > + return 0; > + } > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_pr_err("get dev list failed"); > + return ret; > + } > + > + list_for_each(pos, dev_list) { > + local_pa = container_of(pos, struct aw_device, list_node); > + spin_mode = local_pa->spin_desc.spin_mode; > + if (g_spin_mode != spin_mode) { > + aw_pr_err("dev[%d] spin mode:%d not equal g_spin_mode:%d, check failed", > + local_pa->channel, spin_mode, g_spin_mode); > + aw883xx->spin_flag = AW_SPIN_OFF; > + return -EINVAL; > + } > + } > + aw883xx->spin_flag = AW_SPIN_ON; > + > + return 0; > +} > + > +int aw883xx_hold_dsp_spin_st(struct aw_spin_desc *spin_desc) > +{ > + struct aw_device *aw_dev = container_of(spin_desc, > + struct aw_device, spin_desc); > + int ret = -1; > + > + if (aw_dev == NULL) { > + aw_pr_err("aw_dev is NULL"); > + return -EINVAL; > + } > + > + if (aw_dev->channel == 0) { > + if (g_spin_mode == AW_ADSP_SPIN_MODE) { > + ret = aw_set_adsp_spin_angle(aw_dev, > + g_spin_angle); > + if (ret < 0) > + return ret; > + } > + } > + > + return ret; > +} > + > +static int aw_set_channal_mode(struct aw_device *aw_pa, channel > + uint32_t spin_angle) > +{ > + int ret; > + struct aw_chansel_desc *chansel_desc = &aw_pa->chansel_desc; > + struct aw_spin_ch *spin_ch = &aw_pa->spin_desc.spin_table[spin_angle]; > + > + ret = aw_pa->ops.aw_reg_write_bits(aw_pa, chansel_desc->rxchan_reg, > + chansel_desc->rxchan_mask, spin_ch->rx_val); this looks like regmap should be used... > + if (ret < 0) { > + aw_dev_err(aw_pa->dev, "set rx failed"); > + return ret; > + } > + > + ret = aw_pa->ops.aw_reg_write_bits(aw_pa, chansel_desc->txchan_reg, > + chansel_desc->txchan_mask, spin_ch->tx_val); > + if (ret < 0) { > + aw_dev_err(aw_pa->dev, "set tx failed"); > + return ret; > + } > + > + aw_dev_dbg(aw_pa->dev, "set channel mode done!"); > + > + return 0; > +} > + > +static int aw_set_reg_spin_angle(struct aw883xx *aw883xx, uint32_t spin_angle) what do spin and spin_angle refer to? > +{ > + struct list_head *pos = NULL; > + struct list_head *dev_list = NULL; > + struct aw_device *local_pa = NULL; > + int ret; > + > + if (spin_angle >= ARRAY_SIZE(aw_spin)) { > + aw_dev_err(aw883xx->dev, "spin_angle:%d not support", > + spin_angle); > + return -EINVAL; > + } > + > + ret = aw883xx_dev_get_list_head(&dev_list); > + if (ret) { > + aw_dev_err(aw883xx->dev, "get dev list failed"); > + return ret; > + } > + > + list_for_each(pos, dev_list) { > + local_pa = container_of(pos, struct aw_device, list_node); > + ret = aw_set_channal_mode(local_pa, spin_angle); > + if (ret < 0) { > + aw_dev_err(aw883xx->dev, "set channal mode failed"); > + return ret; > + } > + } > + > + return 0; > +} > + > +static int aw_set_reg_mixer_spin_angle(struct aw883xx *aw883xx, uint32_t spin_angle) > +{ > + int ret; > + > + if (spin_angle >= ARRAY_SIZE(aw_spin)) { > + aw_dev_err(aw883xx->dev, "spin_angle:%d not support", > + spin_angle); > + return -EINVAL; > + } > + > + ret = aw_set_mixer_en(aw883xx->aw_pa, AW_AUDIO_MIX_ENABLE); > + if (ret) > + return ret; > + > + usleep_range(AW_100000_US, AW_100000_US + 10); > + > + aw_set_reg_spin_angle(aw883xx, spin_angle); > + > + ret = aw_set_mixer_en(aw883xx->aw_pa, AW_AUDIO_MIX_DISABLE); > + if (ret) > + return ret; > + > + return ret; > +} > + > +static void aw_get_reg_spin_angle(uint32_t *spin_angle) > +{ > + *spin_angle = g_spin_angle; > + > + pr_debug("%s: get spin:%s\n", __func__, aw_spin[g_spin_angle]); > +} > + > +static int aw_set_spin_angle(struct aw883xx *aw883xx, uint32_t spin_angle) > +{ > + switch (g_spin_mode) { > + case AW_REG_SPIN_MODE: > + return aw_set_reg_spin_angle(aw883xx, spin_angle); > + case AW_ADSP_SPIN_MODE: > + return aw_set_adsp_spin_angle(aw883xx->aw_pa, spin_angle); > + case AW_REG_MIXER_SPIN_MODE: > + return aw_set_reg_mixer_spin_angle(aw883xx, spin_angle); > + default: > + aw_pr_err("unsupported spin mode:%d", g_spin_mode); > + return -EINVAL; > + } > +} > + > +static void aw_set_spin_mode(int mode) > +{ > + g_spin_mode = mode; > +} > + > +static int aw_set_spin(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)kcontrol->private_value; > + uint32_t ctrl_value; > + int ret; > + > + aw_dev_dbg(aw883xx->dev, "ucontrol->value.integer.value[0]=%ld", > + ucontrol->value.integer.value[0]); > + > + if (aw883xx->spin_flag == AW_SPIN_OFF) { > + aw_dev_dbg(aw883xx->dev, "spin func not enable"); > + return 0; > + } > + > + ctrl_value = (uint32_t)ucontrol->value.integer.value[0]; > + > + mutex_lock(&g_aw_spin_lock); > + if (aw883xx->pstream == AW883XX_STREAM_OPEN) { > + ret = aw_set_spin_angle(aw883xx, ctrl_value); > + if (ret < 0) > + aw_dev_err(aw883xx->dev, "set spin error, ret=%d\n", > + ret); > + } else { > + if ((g_spin_mode == AW_REG_SPIN_MODE) || (g_spin_mode == AW_REG_MIXER_SPIN_MODE)) > + aw_set_reg_spin_angle(aw883xx, ctrl_value); > + else > + aw_dev_info(aw883xx->dev, "stream no start only record spin angle"); > + } > + g_spin_angle = ctrl_value; > + mutex_unlock(&g_aw_spin_lock); > + > + return 0; > +} > + > +static void aw_get_spin_angle(uint32_t *spin_angle) > +{ > + if ((g_spin_mode == AW_REG_SPIN_MODE) || (g_spin_mode == AW_REG_MIXER_SPIN_MODE)) > + aw_get_reg_spin_angle(spin_angle); > + else if (g_spin_mode == AW_ADSP_SPIN_MODE) > + aw_get_adsp_spin_angle(spin_angle); > +} > + > +static int aw_get_spin(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)kcontrol->private_value; > + uint32_t ctrl_value = 0; > + > + mutex_lock(&g_aw_spin_lock); > + if (aw883xx->pstream == AW883XX_STREAM_OPEN) { > + aw_get_spin_angle(&ctrl_value); > + ucontrol->value.integer.value[0] = ctrl_value; > + } else { > + ucontrol->value.integer.value[0] = g_spin_angle; > + aw_dev_dbg(aw883xx->dev, "no stream, use record value"); > + } > + mutex_unlock(&g_aw_spin_lock); > + > + return 0; > +} > + > +static int aw_spin_info(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_info *uinfo) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)kcontrol->private_value; > + int count = 0; > + > + if (aw883xx == NULL) { > + aw_pr_err("get struct aw883xx failed"); > + return -EINVAL; > + } > + > + uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED; > + uinfo->count = 1; > + count = ARRAY_SIZE(aw_spin); > + > + uinfo->value.enumerated.items = count; > + if (uinfo->value.enumerated.item >= count) > + uinfo->value.enumerated.item = count - 1; > + > + strscpy(uinfo->value.enumerated.name, > + aw_spin[uinfo->value.enumerated.item], > + strlen(aw_spin[uinfo->value.enumerated.item]) + 1); > + > + return 0; > +} > + > +static int aw_spin_control_create(struct aw883xx *aw883xx) > +{ > + int kcontrol_num = 1; > + struct snd_kcontrol_new *aw_spin_control = NULL; > + char *kctl_name = NULL; > + > + aw_spin_control = devm_kzalloc(aw883xx->codec->dev, > + sizeof(struct snd_kcontrol_new) * 1, GFP_KERNEL); > + if (aw_spin_control == NULL) > + return -ENOMEM; > + > + kctl_name = devm_kzalloc(aw883xx->codec->dev, AW_NAME_BUF_MAX, GFP_KERNEL); > + if (kctl_name == NULL) > + return -ENOMEM; > + > + snprintf(kctl_name, AW_NAME_BUF_MAX, "aw_spin_switch"); > + > + aw_spin_control[0].name = kctl_name; > + aw_spin_control[0].iface = SNDRV_CTL_ELEM_IFACE_MIXER; > + aw_spin_control[0].info = aw_spin_info; > + aw_spin_control[0].get = aw_get_spin; > + aw_spin_control[0].put = aw_set_spin; > + aw_spin_control[0].private_value = (unsigned long)aw883xx; > + > + kctl_name = devm_kzalloc(aw883xx->codec->dev, AW_NAME_BUF_MAX, GFP_KERNEL); > + if (!kctl_name) > + return -ENOMEM; > + > + aw883xx->codec_ops->add_codec_controls(aw883xx->codec, > + aw_spin_control, kcontrol_num); > + > + return 0; > +} > + > +void aw883xx_add_spin_controls(void *aw_dev) > +{ > + struct aw883xx *aw883xx = (struct aw883xx *)aw_dev; > + > + if (aw883xx->aw_pa->spin_desc.spin_mode != AW_SPIN_OFF_MODE) > + aw_spin_control_create(aw883xx); > +} > + > +static int aw_parse_spin_table_dt(struct aw_device *aw_dev, > + struct device_node *np) > +{ > + int ret = -1; > + const char *str_data = NULL; > + char spin_table_str[AW_SPIN_MAX] = { 0 }; > + int i, spin_count = 0; > + > + ret = of_property_read_string(np, "spin-data", &str_data); > + if (ret < 0) { > + aw_dev_err(aw_dev->dev, "get spin_data failed, close spin function"); > + return ret; > + } > + > + ret = sscanf(str_data, "%c %c %c %c", > + &spin_table_str[AW_SPIN_0], &spin_table_str[AW_SPIN_90], > + &spin_table_str[AW_SPIN_180], &spin_table_str[AW_SPIN_270]); > + if (ret != AW_SPIN_MAX) { > + aw_dev_err(aw_dev->dev, "unsupported str:%s, close spin function", > + str_data); > + return -EINVAL; > + } > + > + for (i = 0; i < AW_SPIN_MAX; i++) { > + if (spin_table_str[i] == 'l' || spin_table_str[i] == 'L') { > + aw_dev->spin_desc.spin_table[i].rx_val = aw_dev->chansel_desc.rx_left; > + aw_dev->spin_desc.spin_table[i].tx_val = aw_dev->chansel_desc.tx_left; > + spin_count++; > + } else if (spin_table_str[i] == 'r' || spin_table_str[i] == 'R') { > + aw_dev->spin_desc.spin_table[i].rx_val = aw_dev->chansel_desc.rx_right; > + aw_dev->spin_desc.spin_table[i].tx_val = aw_dev->chansel_desc.tx_right; > + spin_count++; > + } else { > + aw_dev_err(aw_dev->dev, "unsupported str:%s, close spin function", > + str_data); > + return -EINVAL; > + } > + } > + > + if (spin_count != ARRAY_SIZE(aw_spin)) { > + aw_dev_err(aw_dev->dev, "get spin_data failed, spin_count:%d", spin_count); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static void aw_parse_topo_id_dt(struct aw_device *aw_dev) > +{ > + int ret; > + > + ret = of_property_read_u32(aw_dev->dev->of_node, "aw-rx-topo-id", &g_rx_topo_id); > + if (ret < 0) { > + g_rx_topo_id = AW_RX_TOPO_ID; > + aw_dev_info(aw_dev->dev, "read aw-rx-topo-id failed,use default"); > + } > + > + aw_dev_info(aw_dev->dev, "rx-topo-id: 0x%x", g_rx_topo_id); > +} > + > +static void aw_parse_port_id_dt(struct aw_device *aw_dev) > +{ > + int ret; > + > + ret = of_property_read_u32(aw_dev->dev->of_node, "aw-rx-port-id", &g_rx_port_id); > + if (ret < 0) { > + g_rx_port_id = AW_RX_PORT_ID; > + aw_dev_info(aw_dev->dev, "read aw-rx-port-id failed,use default"); > + } > + > + aw_set_port_id(0, g_rx_port_id); > + aw_dev_info(aw_dev->dev, "rx-port-id: 0x%x", > + g_rx_port_id); > +} > + > +static int aw_parse_spin_mode_dt(struct aw_device *aw_dev) what does 'spin' refer to? > +{ > + int ret = -1; > + const char *spin_mode = NULL; > + int mode; > + struct device_node *np = aw_dev->dev->of_node; > + > + ret = of_property_read_string(np, "spin-mode", &spin_mode); > + if (ret < 0) { > + aw_dev_info(aw_dev->dev, > + "spin-mode get failed, spin switch off"); > + aw_dev->spin_desc.spin_mode = AW_SPIN_OFF_MODE; > + return 0; > + } > + > + if (!strcmp(spin_mode, "dsp_spin")) > + mode = AW_ADSP_SPIN_MODE; > + else if (!strcmp(spin_mode, "reg_spin")) > + mode = AW_REG_SPIN_MODE; > + else if (!strcmp(spin_mode, "reg_mixer_spin")) > + mode = AW_REG_MIXER_SPIN_MODE; > + else > + mode = AW_SPIN_OFF_MODE; > + > + aw_dev->spin_desc.spin_mode = mode; > + > + aw_set_spin_mode(mode); > + > + if ((mode == AW_REG_SPIN_MODE) || (mode == AW_REG_MIXER_SPIN_MODE)) { > + ret = aw_parse_spin_table_dt(aw_dev, np); > + if (ret < 0) { > + aw_dev->spin_desc.spin_mode = AW_SPIN_OFF_MODE; > + aw_dev_err(aw_dev->dev, > + "spin-table get failed, ret = %d", ret); > + return ret; > + } > + } > + > + aw_dev_info(aw_dev->dev, "spin mode is %d", mode); > + > + return 0; > +} > + > +void aw883xx_spin_init(struct aw_spin_desc *spin_desc) > +{ > + struct aw_device *aw_dev = container_of(spin_desc, > + struct aw_device, spin_desc); > + > + aw_parse_spin_mode_dt(aw_dev); > + aw_parse_topo_id_dt(aw_dev); > + aw_parse_port_id_dt(aw_dev); > +} > + > diff --git a/sound/soc/codecs/aw883xx/aw883xx_spin.h b/sound/soc/codecs/aw883xx/aw883xx_spin.h > new file mode 100644 > index 0000000..cb5dc39 > --- /dev/null > +++ b/sound/soc/codecs/aw883xx/aw883xx_spin.h > @@ -0,0 +1,80 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * aw883xx.c -- ALSA Soc AW883XX codec support > + * > + * Copyright (c) 2020 AWINIC Technology CO., LTD 2022?

1 0

ACP6x: PulseAudio profiles different (from the legacy probe)
by GitHub issues - edited 23 Sep '22

23 Sep '22

alsa-project/alsa-ucm-conf issue #215 was edited from sebastianst: My Ryzen 6000 laptop has an AMD audio coprocessor driving the microphone with the ACP6x kernel module. #138 added initial support for this, but me and some other people on different Ryzen 6000 laptops have issues with alsa-ucm not configuring the microphone properly. We have to disable `alsa-ucm` to get any sound input or output working with pulseaudio, see https://bbs.archlinux.org/viewtopic.php?pid=2058087#p2058087 for the relevant discussion. Note that we first had to add our laptops to some quirk table of the kernel module to get it working at all. Any idea how to fix this? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/215 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[RESEND PATCH] Revert "ASoC: fsl_audmix: make clock and output src write only"
by Shengjiu Wang 23 Sep '22

23 Sep '22

This reverts commit 944c517b8c838832a166f1c89afbf8724f4a6b49. There is error after making clock and output src write only $amixer -c imxaudmix cset numid=1 1 amixer: Cannot read the given element from control sysdefault:3 Which is worse than before, so let's revert the change. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/fsl/fsl_audmix.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c index 43857b7a81c9..672148dd4b23 100644 --- a/sound/soc/fsl/fsl_audmix.c +++ b/sound/soc/fsl/fsl_audmix.c @@ -199,18 +199,10 @@ static int fsl_audmix_put_out_src(struct snd_kcontrol *kcontrol, static const struct snd_kcontrol_new fsl_audmix_snd_controls[] = { /* FSL_AUDMIX_CTR controls */ - { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, - .name = "Mixing Clock Source", - .info = snd_soc_info_enum_double, - .access = SNDRV_CTL_ELEM_ACCESS_WRITE, - .put = fsl_audmix_put_mix_clk_src, - .private_value = (unsigned long)&fsl_audmix_enum[0] }, - { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, - .name = "Output Source", - .info = snd_soc_info_enum_double, - .access = SNDRV_CTL_ELEM_ACCESS_WRITE, - .put = fsl_audmix_put_out_src, - .private_value = (unsigned long)&fsl_audmix_enum[1] }, + SOC_ENUM_EXT("Mixing Clock Source", fsl_audmix_enum[0], + snd_soc_get_enum_double, fsl_audmix_put_mix_clk_src), + SOC_ENUM_EXT("Output Source", fsl_audmix_enum[1], + snd_soc_get_enum_double, fsl_audmix_put_out_src), SOC_ENUM("Output Width", fsl_audmix_enum[2]), SOC_ENUM("Frame Rate Diff Error", fsl_audmix_enum[3]), SOC_ENUM("Clock Freq Diff Error", fsl_audmix_enum[4]), -- 2.34.1

1 0

[PATCH 0/2] ASoC: SOF: Intel: add missing PCI IDs
by Pierre-Louis Bossart 22 Sep '22

22 Sep '22

Two missing PCI IDs already added to hda_intel.c and missed in SOF. Pierre-Louis Bossart (2): ASoC: SOF: Intel: pci-tgl: reorder PCI IDs ASoC: SOF: pci-tgl: add missing PCI IDs for RPL sound/soc/sof/intel/pci-tgl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.34.1

2 3

[PATCH] ASoC: es8316: fix register sync error in suspend/resume tests
by Pierre-Louis Bossart 22 Sep '22

22 Sep '22

The SOF CI tests report failures with the following error thrown kernel: es8316 i2c-ESSX8336:00: Unable to sync registers 0x0-0x1. -121 ES8336 only supports I2C read/write one byte a time, so we do need to set the .use_single_read and .use_single_write flags to avoid this sync issue. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: FRED OH <fred.oh(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- sound/soc/codecs/es8316.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index 8643014472ae6..056c3082fe02c 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -815,6 +815,8 @@ static const struct regmap_access_table es8316_volatile_table = { static const struct regmap_config es8316_regmap = { .reg_bits = 8, .val_bits = 8, + .use_single_read = true, + .use_single_write = true, .max_register = 0x53, .volatile_table = &es8316_volatile_table, .cache_type = REGCACHE_RBTREE, -- 2.34.1

2 1

[PATCH linux-next] ALSA: hda/ca0132 - remove the unneeded result variable
by cgel.zte＠gmail.com 22 Sep '22

22 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Return the value dsp_allocate_ports() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/pci/hda/patch_ca0132.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 208933792787..9580fe00cbd9 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -2962,7 +2962,6 @@ static int dsp_allocate_ports_format(struct hda_codec *codec, const unsigned short fmt, unsigned int *port_map) { - int status; unsigned int num_chans; unsigned int sample_rate_div = ((get_hdafmt_rate(fmt) >> 0) & 3) + 1; @@ -2976,9 +2975,7 @@ static int dsp_allocate_ports_format(struct hda_codec *codec, num_chans = get_hdafmt_chs(fmt) + 1; - status = dsp_allocate_ports(codec, num_chans, rate_multi, port_map); - - return status; + return dsp_allocate_ports(codec, num_chans, rate_multi, port_map); } /* -- 2.25.1

2 1

[PATCH] ALSA: hda: intel-dsp-config: add missing RaptorLake PCI IDs
by Pierre-Louis Bossart 22 Sep '22

22 Sep '22

These two missed IDs need to be added for dynamic selection of drivers. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/hda/intel-dsp-config.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c index 1997ffc16663a..b9eb3208f2888 100644 --- a/sound/hda/intel-dsp-config.c +++ b/sound/hda/intel-dsp-config.c @@ -455,6 +455,16 @@ static const struct config_entry config_table[] = { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = 0x51cb, }, + /* RaptorLake-M */ + { + .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, + .device = 0x51ce, + }, + /* RaptorLake-PX */ + { + .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, + .device = 0x51cf, + }, #endif }; -- 2.34.1

2 1

[GIT PULL] ASoC fixes for v6.0-rc6
by Mark Brown 22 Sep '22

22 Sep '22

The following changes since commit 80e78fcce86de0288793a0ef0f6acf37656ee4cf: Linux 6.0-rc5 (2022-09-11 16:22:01 -0400) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.0-rc6 for you to fetch changes up to 0a0342ede303fc420f3a388e1ae82da3ae8ff6bd: ASoC: tas2770: Reinit regcache on reset (2022-09-19 18:48:43 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.0 A few device specific fixes, nothing too large, and a new device ID for a Dell laptop. ---------------------------------------------------------------- Martin Povišer (1): ASoC: tas2770: Reinit regcache on reset Oder Chiou (1): ASoC: rt5640: Fix the issue of the abnormal JD2 status Pierre-Louis Bossart (1): ASoC: Intel: sof_sdw: add support for Dell SKU 0AFF SJLIN0 (1): ASoC: nau8824: Fix semaphore is released unexpectedly Shengjiu Wang (1): ASoC: imx-card: Fix refcount issue with of_node_put sound/soc/codecs/nau8824.c | 17 +++++++++-- sound/soc/codecs/nau8824.h | 1 + sound/soc/codecs/rt5640.c | 64 ++++++++++++++++++++++++++++------------ sound/soc/codecs/rt5640.h | 14 +++++++++ sound/soc/codecs/tas2770.c | 3 ++ sound/soc/fsl/imx-card.c | 4 +++ sound/soc/intel/boards/sof_sdw.c | 10 +++++++ 7 files changed, 91 insertions(+), 22 deletions(-)

2 1

KASAN: use-after-free Write in snd_rawmidi_receive
by Rondreis 22 Sep '22

22 Sep '22

Hello, When fuzzing the Linux kernel driver v5.18.0, the following crash was triggered. HEAD commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f git tree: upstream kernel config: https://pastebin.com/raw/KecL2gaG console output: https://pastebin.com/raw/aJGZYGs4 Sorry for failing to extract the reproducer. But on other versions of Linux, I also triggered this crash. I would appreciate it if you have any idea how to solve this bug. The crash report is as follows: ================================================================== BUG: KASAN: use-after-free in snd_rawmidi_receive+0x2f6/0xe70 sound/core/rawmidi.c:1097 Write of size 3 at addr ffff88803cf1a05a by task kworker/u8:6/13973 CPU: 3 PID: 13973 Comm: kworker/u8:6 Not tainted 5.18.0 #2 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Workqueue: bat_events batadv_nc_worker Call Trace: <IRQ> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 print_address_description mm/kasan/report.c:313 [inline] print_report.cold+0xe5/0x659 mm/kasan/report.c:429 kasan_report+0x8a/0x1b0 mm/kasan/report.c:491 check_region_inline mm/kasan/generic.c:183 [inline] kasan_check_range+0x13b/0x190 mm/kasan/generic.c:189 memcpy+0x39/0x60 mm/kasan/shadow.c:66 snd_rawmidi_receive+0x2f6/0xe70 sound/core/rawmidi.c:1097 f_midi_read_data drivers/usb/gadget/function/f_midi.c:253 [inline] f_midi_handle_out_data.isra.0+0x1ee/0x290 drivers/usb/gadget/function/f_midi.c:265 f_midi_complete+0x3b7/0x480 drivers/usb/gadget/function/f_midi.c:280 transfer drivers/usb/gadget/udc/dummy_hcd.c:1516 [inline] dummy_timer+0x1866/0x33b0 drivers/usb/gadget/udc/dummy_hcd.c:1972 call_timer_fn+0x1a5/0x6b0 kernel/time/timer.c:1421 expire_timers kernel/time/timer.c:1466 [inline] __run_timers kernel/time/timer.c:1737 [inline] __run_timers kernel/time/timer.c:1710 [inline] run_timer_softirq+0x1084/0x16d0 kernel/time/timer.c:1750 __do_softirq+0x1d0/0x908 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu kernel/softirq.c:637 [inline] irq_exit_rcu+0xf2/0x130 kernel/softirq.c:649 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1097 </IRQ> <TASK> asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:645 RIP: 0010:lock_release+0x3f0/0x670 kernel/locking/lockdep.c:5649 Code: 7e 83 f8 01 0f 85 59 01 00 00 9c 58 f6 c4 02 0f 85 44 01 00 00 48 f7 04 24 00 02 00 00 74 01 fb 48 b8 00 00 00 00 00 fc ff df <48> 01 c5 48 c7 45 00 00 00 00 00 c7 45 08 00 00 00 00 48 8b 84 24 RSP: 0018:ffffc90008a0fb90 EFLAGS: 00000206 RAX: dffffc0000000000 RBX: c422640388757846 RCX: 0000000000000000 RDX: 1ffff11007b1f892 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 1ffff92001141f74 R08: 0000000000000001 R09: fffffbfff1ce851b R10: ffffffff8e7428d7 R11: fffffbfff1ce851a R12: 0000000000000002 R13: ffff88803d8fc498 R14: 0000000000000003 R15: ffff88803d8fba80 rcu_lock_release include/linux/rcupdate.h:273 [inline] rcu_read_unlock include/linux/rcupdate.h:727 [inline] batadv_nc_process_nc_paths.part.0+0x235/0x3c0 net/batman-adv/network-coding.c:699 batadv_nc_process_nc_paths net/batman-adv/network-coding.c:679 [inline] batadv_nc_worker+0x54f/0x770 net/batman-adv/network-coding.c:728 process_one_work+0x9cc/0x1650 kernel/workqueue.c:2289 worker_thread+0x623/0x1070 kernel/workqueue.c:2436 kthread+0x2e9/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298 </TASK> Allocated by task 17441: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track mm/kasan/common.c:45 [inline] set_alloc_info mm/kasan/common.c:436 [inline] ____kasan_kmalloc mm/kasan/common.c:515 [inline] ____kasan_kmalloc mm/kasan/common.c:474 [inline] __kasan_kmalloc+0xa9/0xd0 mm/kasan/common.c:524 kasan_kmalloc include/linux/kasan.h:234 [inline] __kmalloc_node+0x1fc/0x450 mm/slub.c:4462 kmalloc_node include/linux/slab.h:604 [inline] kvmalloc_node+0x3e/0x190 mm/util.c:580 kvmalloc include/linux/slab.h:731 [inline] kvzalloc include/linux/slab.h:739 [inline] snd_rawmidi_runtime_create sound/core/rawmidi.c:162 [inline] open_substream+0x340/0x8b0 sound/core/rawmidi.c:306 rawmidi_open_priv+0x2e8/0x6f0 sound/core/rawmidi.c:352 snd_rawmidi_kernel_open+0x1b5/0x270 sound/core/rawmidi.c:392 midisynth_subscribe+0xf2/0x380 sound/core/seq/seq_midi.c:171 subscribe_port sound/core/seq/seq_ports.c:412 [inline] check_and_subscribe_port+0x5be/0x810 sound/core/seq/seq_ports.c:495 snd_seq_port_connect+0x2e6/0x520 sound/core/seq/seq_ports.c:576 snd_seq_ioctl_subscribe_port+0x1df/0x310 sound/core/seq/seq_clientmgr.c:1492 snd_seq_kernel_client_ctl+0x105/0x1b0 sound/core/seq/seq_clientmgr.c:2369 snd_seq_oss_midi_open+0x3f4/0x670 sound/core/seq/oss/seq_oss_midi.c:368 snd_seq_oss_synth_reset+0x462/0x890 sound/core/seq/oss/seq_oss_synth.c:407 snd_seq_oss_reset+0x6f/0x290 sound/core/seq/oss/seq_oss_init.c:435 snd_seq_oss_release+0x79/0x160 sound/core/seq/oss/seq_oss_init.c:412 odev_release+0x4f/0x70 sound/core/seq/oss/seq_oss.c:144 __fput+0x277/0x9d0 fs/file_table.c:317 task_work_run+0xe0/0x1a0 kernel/task_work.c:164 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop kernel/entry/common.c:169 [inline] exit_to_user_mode_prepare+0x253/0x260 kernel/entry/common.c:201 __syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline] syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:294 do_syscall_64+0x42/0x80 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae Freed by task 17441: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track+0x21/0x30 mm/kasan/common.c:45 kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:370 ____kasan_slab_free mm/kasan/common.c:366 [inline] ____kasan_slab_free mm/kasan/common.c:328 [inline] __kasan_slab_free+0x11d/0x190 mm/kasan/common.c:374 kasan_slab_free include/linux/kasan.h:200 [inline] slab_free_hook mm/slub.c:1728 [inline] slab_free_freelist_hook mm/slub.c:1754 [inline] slab_free mm/slub.c:3510 [inline] kfree+0xec/0x4b0 mm/slub.c:4552 kvfree+0x42/0x50 mm/util.c:622 snd_rawmidi_runtime_free sound/core/rawmidi.c:176 [inline] close_substream.part.0+0x18e/0x650 sound/core/rawmidi.c:528 close_substream sound/core/rawmidi.c:507 [inline] rawmidi_release_priv+0xd3/0x270 sound/core/rawmidi.c:543 snd_rawmidi_kernel_release+0x39/0xd0 sound/core/rawmidi.c:564 midisynth_unsubscribe+0x3b/0x70 sound/core/seq/seq_midi.c:203 unsubscribe_port sound/core/seq/seq_ports.c:437 [inline] __delete_and_unsubscribe_port+0x279/0x4e0 sound/core/seq/seq_ports.c:537 delete_and_unsubscribe_port+0x59/0x80 sound/core/seq/seq_ports.c:549 snd_seq_port_disconnect+0x1ee/0x270 sound/core/seq/seq_ports.c:627 snd_seq_ioctl_unsubscribe_port+0x1df/0x310 sound/core/seq/seq_clientmgr.c:1537 snd_seq_kernel_client_ctl+0x105/0x1b0 sound/core/seq/seq_clientmgr.c:2369 snd_seq_oss_midi_close+0x2ff/0x470 sound/core/seq/oss/seq_oss_midi.c:410 snd_seq_oss_synth_cleanup+0x32c/0x480 sound/core/seq/oss/seq_oss_synth.c:307 snd_seq_oss_release+0x81/0x160 sound/core/seq/oss/seq_oss_init.c:414 odev_release+0x4f/0x70 sound/core/seq/oss/seq_oss.c:144 __fput+0x277/0x9d0 fs/file_table.c:317 task_work_run+0xe0/0x1a0 kernel/task_work.c:164 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop kernel/entry/common.c:169 [inline] exit_to_user_mode_prepare+0x253/0x260 kernel/entry/common.c:201 __syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline] syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:294 do_syscall_64+0x42/0x80 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x44/0xae The buggy address belongs to the object at ffff88803cf1a000 which belongs to the cache kmalloc-4k of size 4096 The buggy address is located 90 bytes inside of 4096-byte region [ffff88803cf1a000, ffff88803cf1b000) The buggy address belongs to the physical page: page:ffffea0000f3c600 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3cf18 head:ffffea0000f3c600 order:3 compound_mapcount:0 compound_pincount:0 flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff) raw: 00fff00000010200 0000000000000000 dead000000000122 ffff888011843040 raw: 0000000000000000 0000000000040004 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 3, migratetype Unmovable, gfp_mask 0x1d20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL), pid 17441, tgid 17441 (syz-executor.0), ts 589072773595, free_ts 589014752799 set_page_owner include/linux/page_owner.h:31 [inline] post_alloc_hook mm/page_alloc.c:2434 [inline] prep_new_page+0x297/0x330 mm/page_alloc.c:2441 get_page_from_freelist+0x210e/0x3ab0 mm/page_alloc.c:4182 __alloc_pages+0x30c/0x6e0 mm/page_alloc.c:5408 alloc_pages+0x119/0x250 mm/mempolicy.c:2272 alloc_slab_page mm/slub.c:1799 [inline] allocate_slab mm/slub.c:1944 [inline] new_slab+0x2a9/0x3f0 mm/slub.c:2004 ___slab_alloc+0xc62/0x1080 mm/slub.c:3005 __slab_alloc.isra.0+0x4d/0xa0 mm/slub.c:3092 slab_alloc_node mm/slub.c:3183 [inline] __kmalloc_node+0x340/0x450 mm/slub.c:4458 kmalloc_node include/linux/slab.h:604 [inline] kvmalloc_node+0x3e/0x190 mm/util.c:580 kvmalloc include/linux/slab.h:731 [inline] kvzalloc include/linux/slab.h:739 [inline] snd_rawmidi_runtime_create sound/core/rawmidi.c:162 [inline] open_substream+0x340/0x8b0 sound/core/rawmidi.c:306 rawmidi_open_priv+0x592/0x6f0 sound/core/rawmidi.c:357 snd_rawmidi_kernel_open+0x1b5/0x270 sound/core/rawmidi.c:392 midisynth_use+0xee/0x270 sound/core/seq/seq_midi.c:215 subscribe_port sound/core/seq/seq_ports.c:412 [inline] check_and_subscribe_port+0x5be/0x810 sound/core/seq/seq_ports.c:495 snd_seq_port_connect+0x382/0x520 sound/core/seq/seq_ports.c:581 snd_seq_ioctl_subscribe_port+0x1df/0x310 sound/core/seq/seq_clientmgr.c:1492 page last free stack trace: reset_page_owner include/linux/page_owner.h:24 [inline] free_pages_prepare mm/page_alloc.c:1356 [inline] free_pcp_prepare+0x51f/0xd00 mm/page_alloc.c:1406 free_unref_page_prepare mm/page_alloc.c:3328 [inline] free_unref_page+0x19/0x5b0 mm/page_alloc.c:3423 __unfreeze_partials+0x3d2/0x3f0 mm/slub.c:2523 do_slab_free mm/slub.c:3498 [inline] ___cache_free+0x12c/0x140 mm/slub.c:3517 qlink_free mm/kasan/quarantine.c:157 [inline] qlist_free_all+0x6a/0x170 mm/kasan/quarantine.c:176 kasan_quarantine_reduce+0x13d/0x180 mm/kasan/quarantine.c:283 __kasan_slab_alloc+0xa2/0xc0 mm/kasan/common.c:446 kasan_slab_alloc include/linux/kasan.h:224 [inline] slab_post_alloc_hook+0x4d/0x4f0 mm/slab.h:749 slab_alloc_node mm/slub.c:3217 [inline] slab_alloc mm/slub.c:3225 [inline] __kmem_cache_alloc_lru mm/slub.c:3232 [inline] kmem_cache_alloc+0x1be/0x460 mm/slub.c:3242 getname_flags fs/namei.c:138 [inline] getname_flags+0xd2/0x5b0 fs/namei.c:128 vfs_fstatat+0x73/0xb0 fs/stat.c:254 __do_sys_newfstatat+0x91/0x110 fs/stat.c:425 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae Memory state around the buggy address: ffff88803cf19f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff88803cf19f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff88803cf1a000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff88803cf1a080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff88803cf1a100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== ---------------- Code disassembly (best guess): 0: 7e 83 jle 0xffffff85 2: f8 clc 3: 01 0f add %ecx,(%rdi) 5: 85 59 01 test %ebx,0x1(%rcx) 8: 00 00 add %al,(%rax) a: 9c pushfq b: 58 pop %rax c: f6 c4 02 test $0x2,%ah f: 0f 85 44 01 00 00 jne 0x159 15: 48 f7 04 24 00 02 00 testq $0x200,(%rsp) 1c: 00 1d: 74 01 je 0x20 1f: fb sti 20: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax 27: fc ff df * 2a: 48 01 c5 add %rax,%rbp <-- trapping instruction 2d: 48 c7 45 00 00 00 00 movq $0x0,0x0(%rbp) 34: 00 35: c7 45 08 00 00 00 00 movl $0x0,0x8(%rbp) 3c: 48 rex.W 3d: 8b .byte 0x8b 3e: 84 .byte 0x84 3f: 24 .byte 0x24

2 1

[PATCH] ASoC: SOF: mediatek: add pcm_pointer callback for mt8186
by Chunxu Li 22 Sep '22

22 Sep '22

add pcm_pointer callback for mt8186 to support read host position from DSP Signed-off-by: Chunxu Li <chunxu.li(a)mediatek.com> --- sound/soc/sof/mediatek/mt8186/mt8186.c | 33 ++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c index 9ec89fc7fec0..181189e00e02 100644 --- a/sound/soc/sof/mediatek/mt8186/mt8186.c +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c @@ -470,6 +470,38 @@ static int mt8186_pcm_hw_params(struct snd_sof_dev *sdev, return 0; } +static snd_pcm_uframes_t mt8186_pcm_pointer(struct snd_sof_dev *sdev, + struct snd_pcm_substream *substream) +{ + int ret; + snd_pcm_uframes_t pos; + struct snd_sof_pcm *spcm; + struct sof_ipc_stream_posn posn; + struct snd_sof_pcm_stream *stream; + struct snd_soc_component *scomp = sdev->component; + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); + + spcm = snd_sof_find_spcm_dai(scomp, rtd); + if (!spcm) { + dev_warn_ratelimited(sdev->dev, "warn: can't find PCM with DAI ID %d\n", + rtd->dai_link->id); + return 0; + } + + stream = &spcm->stream[substream->stream]; + ret = snd_sof_ipc_msg_data(sdev, stream->substream, &posn, sizeof(posn)); + if (ret < 0) { + dev_warn(sdev->dev, "failed to read stream position: %d\n", ret); + return 0; + } + + memcpy(&stream->posn, &posn, sizeof(posn)); + pos = spcm->stream[substream->stream].posn.host_posn; + pos = bytes_to_frames(substream->runtime, pos); + + return pos; +} + static struct snd_soc_dai_driver mt8186_dai[] = { { .name = "SOF_DL1", @@ -537,6 +569,7 @@ static struct snd_sof_dsp_ops sof_mt8186_ops = { /* stream callbacks */ .pcm_open = sof_stream_pcm_open, .pcm_hw_params = mt8186_pcm_hw_params, + .pcm_pointer = mt8186_pcm_pointer, .pcm_close = sof_stream_pcm_close, /* firmware loading */ -- 2.25.1

4 3

[linux-next:master] BUILD REGRESSION 483fed3b5dc8ce3644c83d24240cf5756fb0993e
by kernel test robot 22 Sep '22

22 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 483fed3b5dc8ce3644c83d24240cf5756fb0993e Add linux-next specific files for 20220921 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.FQi69rLV-lkp@intel.com https://lore.kernel.org/linux-mm/202209060229.dVuyxjBv-lkp@intel.com https://lore.kernel.org/linux-mm/202209150141.WgbAKqmX-lkp@intel.com https://lore.kernel.org/linux-mm/202209160607.sE3qvgTy-lkp@intel.com https://lore.kernel.org/linux-mm/202209200603.Hpvoa8Ii-lkp@intel.com https://lore.kernel.org/linux-mm/202209200949.Vl3xrUYD-lkp@intel.com https://lore.kernel.org/llvm/202209220009.8nYpIPST-lkp@intel.com https://lore.kernel.org/llvm/202209220019.Yr2VuXhg-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) ERROR: modpost: "devm_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/dma/idma64.ko] undefined! ERROR: modpost: "devm_ioremap_resource" [drivers/dma/qcom/hdma.ko] undefined! ERROR: modpost: "devm_memremap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_memunmap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/char/xillybus/xillybus_of.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/clk/xilinx/clk-xlnx-clock-wizard.ko] undefined! ERROR: modpost: "ioremap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/tty/ipwireless/ipwireless.ko] undefined! arch/arm64/kernel/alternative.c:199:6: warning: no previous prototype for 'apply_alternatives_vdso' [-Wmissing-prototypes] arch/arm64/kernel/alternative.c:295:14: warning: no previous prototype for 'alt_cb_patch_nops' [-Wmissing-prototypes] arch/ia64/kernel/sys_ia64.c:188:17: sparse: sparse: typename in expression arch/ia64/kernel/sys_ia64.c:188:31: sparse: sparse: Trying to use reserved word 'typeof' as identifier arch/ia64/kernel/sys_ia64.c:188:31: sparse: sparse: Trying to use reserved word 'void' as identifier arch/ia64/kernel/sys_ia64.c:189:60: sparse: sparse: invalid initializer arch/ia64/kernel/sys_ia64.c:190:17: sparse: sparse: Trying to use reserved word 'return' as identifier arch/parisc/lib/iomap.c:363:5: warning: no previous prototype for 'ioread64_lo_hi' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:373:5: warning: no previous prototype for 'ioread64_hi_lo' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:448:6: warning: no previous prototype for 'iowrite64_lo_hi' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:454:6: warning: no previous prototype for 'iowrite64_hi_lo' [-Wmissing-prototypes] drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration] drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration] mm/hugetlb.c:5539:14: warning: variable 'reserve_alloc' set but not used [-Wunused-but-set-variable] Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | `-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast |-- alpha-randconfig-s033-20220921 | `-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand |-- arm64-allyesconfig | |-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-alt_cb_patch_nops | |-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-apply_alternatives_vdso | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- arm64-randconfig-r013-20220921 | |-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-alt_cb_patch_nops | `-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-apply_alternatives_vdso |-- i386-allyesconfig | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-defconfig | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-randconfig-c021 | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-randconfig-m021 | `-- drivers-gpu-drm-display-drm_dp_helper.c-drm_dp_phy_name()-warn:unsigned-dp_phy-is-never-less-than-zero. |-- i386-randconfig-s001 | |-- arch-x86-kernel-signal.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__user-to-got-unsigned-long-long-usertype | |-- drivers-gpu-drm-tiny-simpledrm.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-vaddr-got-void-noderef-__iomem-screen_base | |-- drivers-gpu-drm-vkms-vkms_formats.c:sparse:sparse:cast-to-restricted-__le16 | |-- drivers-gpu-drm-vkms-vkms_formats.c:sparse:sparse:incorrect-type-in-assignment-(different-base-types)-expected-unsigned-short-usertype-got-restricted-__le16-usertype | `-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand |-- i386-randconfig-s002 | |-- arch-x86-kernel-signal.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__user-to-got-unsigned-long-long-usertype | |-- drivers-gpu-drm-tiny-simpledrm.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-vaddr-got-void-noderef-__iomem-screen_base | |-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- i386-randconfig-s003 | |-- arch-x86-kernel-signal.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__user-to-got-unsigned-long-long-usertype | |-- drivers-gpu-drm-tiny-simpledrm.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-vaddr-got-void-noderef-__iomem-screen_base | |-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand | |-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used | `-- sound-soc-generic-simple-card-utils.c:sparse:sparse:incorrect-type-in-initializer-(different-base-types)-expected-unsigned-int-usertype-val-got-restricted-snd_pcm_format_t-usertype |-- ia64-allmodconfig | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used |-- ia64-randconfig-s052-20220921 | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:Trying-to-use-reserved-word-return-as-identifier | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:Trying-to-use-reserved-word-typeof-as-identifier | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:Trying-to-use-reserved-word-void-as-identifier | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:invalid-initializer | |-- arch-ia64-kernel-sys_ia64.c:sparse:sparse:typename-in-expression | |-- kernel-bpf-hashtab.c:sparse:sparse:cast-removes-address-space-__percpu-of-expression clang_recent_errors |-- arm-randconfig-r014-20220921 | `-- make:No-rule-to-make-target-drivers-crypto-aspeed-aspeed_crypto.o-needed-by-drivers-crypto-aspeed-built-in.a-. |-- arm-randconfig-r026-20220921 | |-- drivers-scsi-qla2xxx-qla_os.c:error:call-to-undeclared-function-trace_array_get_by_name-ISO-C99-and-later-do-not-support-implicit-function-declarations | |-- drivers-scsi-qla2xxx-qla_os.c:error:call-to-undeclared-function-trace_array_put-ISO-C99-and-later-do-not-support-implicit-function-declarations | `-- drivers-scsi-qla2xxx-qla_os.c:error:incompatible-integer-to-pointer-conversion-assigning-to-struct-trace_array-from-int |-- i386-randconfig-a015 | |-- ERROR:__cpuhp_remove_state-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:__cpuhp_setup_state-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:_printk-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:boot_cpu_data-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:cpu_bit_bitmap-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:perf_msr_probe-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:perf_pmu_register-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:perf_pmu_unregister-arch-x86-events-intel-intel-cstate.ko-undefined | |-- ERROR:x86_match_cpu-arch-x86-events-intel-intel-cstate.ko-undefined | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- powerpc-randconfig-r006-20220921 | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-virtual-virtual_link_hwss.c:warning:no-previous-prototype-for-function-virtual_disable_link_output | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- x86_64-allyesconfig | |-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead | `-- mm-hugetlb.c:warning:variable-reserve_alloc-set-but-not-used `-- x86_64-randconfig-a016 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 728m configs tested: 67 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig i386 defconfig arm defconfig x86_64 randconfig-a004 x86_64 randconfig-a002 arc axs103_smp_defconfig arc randconfig-r043-20220921 arc defconfig x86_64 defconfig m68k allmodconfig powerpc allmodconfig loongarch allnoconfig riscv randconfig-r042-20220921 sh allmodconfig x86_64 rhel-8.3-kvm x86_64 rhel-8.3-kselftests s390 randconfig-r044-20220921 x86_64 rhel-8.3-syz x86_64 rhel-8.3-func x86_64 rhel-8.3-kunit arc allnoconfig arm viper_defconfig alpha allnoconfig arm lpd270_defconfig riscv allnoconfig csky allnoconfig m68k sun3x_defconfig sh sdk7780_defconfig sh sh03_defconfig sh ul2_defconfig i386 randconfig-a016 powerpc ppc6xx_defconfig powerpc klondike_defconfig powerpc mpc837x_mds_defconfig arm trizeps4_defconfig sh dreamcast_defconfig riscv nommu_k210_sdcard_defconfig powerpc sam440ep_defconfig powerpc pcm030_defconfig sh se7780_defconfig i386 randconfig-c001 powerpc wii_defconfig powerpc allnoconfig alpha defconfig x86_64 rhel-8.3 m68k allyesconfig s390 defconfig x86_64 allyesconfig s390 allmodconfig arc allyesconfig alpha allyesconfig s390 allyesconfig mips allyesconfig i386 allyesconfig ia64 allmodconfig arm64 allyesconfig arm allyesconfig clang tested configs: hexagon randconfig-r041-20220921 hexagon randconfig-r045-20220921 arm hackkit_defconfig s390 alldefconfig x86_64 randconfig-a016 i386 randconfig-a015 powerpc katmai_defconfig arm mvebu_v5_defconfig x86_64 randconfig-k001 x86_64 allyesconfig -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[PATCH] ASoC: SOF: ipc4-topology: Free the ida when IPC fails in sof_ipc4_widget_setup()
by Peter Ujfalusi 21 Sep '22

21 Sep '22

The allocated ida needs to be freed up if the IPC message fails since next time when we try again to set up the widget we are going to try to allocate another ID and given enough tries, we are going to run out of unique IDs. Fixes: 711d0427c713 ("ASoC: SOF: ipc4-topology: move ida allocate/free to widget_setup/free") Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/sof/ipc4-topology.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index 64929dc9af39..340d92452d7c 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -1544,9 +1544,16 @@ static int sof_ipc4_widget_setup(struct snd_sof_dev *sdev, struct snd_sof_widget msg->data_ptr = ipc_data; ret = sof_ipc_tx_message(sdev->ipc, msg, ipc_size, NULL, 0); - if (ret < 0) + if (ret < 0) { dev_err(sdev->dev, "failed to create module %s\n", swidget->widget->name); + if (swidget->id != snd_soc_dapm_scheduler) { + struct sof_ipc4_fw_module *fw_module = swidget->module_info; + + ida_free(&fw_module->m_ida, swidget->instance_id); + } + } + return ret; } -- 2.37.3

2 1

[PATCH v4 0/3] ASoC: ts3a227e control debounce times
by Astrid Rost 21 Sep '22

21 Sep '22

From: Astrid Rost <astridr(a)axis.com> PATCH 1 - convert ts3a227e bindings to yaml. PATCH 2 - add ts3a227e bindings to support debounce times. PATCH 3 - add ts3a227e driver to support debounce times. v3 -> v4 Removed the comments on enums in Patch2. Signed-off-by: Astrid Rost <astrid.rost(a)axis.com> Astrid Rost (3): dt-bindings: sound: ti,ts3a227e: convert to yaml dt-bindings: sound: ti,ts3a227e: add control of debounce ASoC: ts3a227e: add parameters to control debounce times .../bindings/sound/ti,ts3a227e.yaml | 94 +++++++++++++++++++ .../devicetree/bindings/sound/ts3a227e.txt | 30 ------ sound/soc/codecs/ts3a227e.c | 61 ++++++++++-- 3 files changed, 149 insertions(+), 36 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml delete mode 100644 Documentation/devicetree/bindings/sound/ts3a227e.txt -- 2.20.1

3 7

possible deadlock in snd_rawmidi_free
by Rondreis 21 Sep '22

21 Sep '22

Hello, When fuzzing the Linux kernel driver v6.0-rc4, the following crash was triggered. HEAD commit: 7e18e42e4b280c85b76967a9106a13ca61c16179 git tree: upstream kernel config: https://pastebin.com/raw/xtrgsXP3 console output: https://pastebin.com/raw/9tabWDtu Sorry for failing to extract the reproducer, and the crash occurred at the moment of disconnecting the midi device. On other versions of Linux, I also triggered this crash. I would appreciate it if you have any idea how to solve this bug. The crash report is as follows: ====================================================== WARNING: possible circular locking dependency detected 6.0.0-rc4+ #20 Not tainted ------------------------------------------------------ kworker/1:7/10868 is trying to acquire lock: ffffffff8e289108 (register_mutex#5){+.+.}-{3:3}, at: snd_rawmidi_free+0x7a/0x190 sound/core/rawmidi.c:1902 but task is already holding lock: ffffffff8e274048 (sound_oss_mutex){+.+.}-{3:3}, at: snd_unregister_oss_device+0x97/0x290 sound/core/sound_oss.c:159 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (sound_oss_mutex){+.+.}-{3:3}: lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x580 kernel/locking/lockdep.c:5631 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x14f/0x1f50 kernel/locking/mutex.c:747 snd_unregister_oss_device+0x97/0x290 sound/core/sound_oss.c:159 snd_rawmidi_dev_disconnect+0x418/0x650 sound/core/rawmidi.c:2043 __snd_device_disconnect.part.0+0x5b/0xc0 sound/core/device.c:63 __snd_device_disconnect sound/core/device.c:61 [inline] snd_device_disconnect_all+0x9b/0xf0 sound/core/device.c:215 snd_card_disconnect+0x306/0x740 sound/core/init.c:530 snd_card_free_when_closed+0x13/0x50 sound/core/init.c:622 f_midi_unbind+0x60/0x120 drivers/usb/gadget/function/f_midi.c:1335 purge_configs_funcs+0x281/0x4e0 drivers/usb/gadget/configfs.c:1274 configfs_composite_bind+0xbd3/0x11c0 drivers/usb/gadget/configfs.c:1426 gadget_bind_driver+0x285/0x860 drivers/usb/gadget/udc/core.c:1495 call_driver_probe drivers/base/dd.c:560 [inline] really_probe+0x249/0xa90 drivers/base/dd.c:639 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808 __driver_attach+0x1e6/0x420 drivers/base/dd.c:1190 bus_for_each_dev+0x147/0x1d0 drivers/base/bus.c:301 bus_add_driver+0x4c9/0x640 drivers/base/bus.c:618 driver_register+0x1c4/0x330 drivers/base/driver.c:240 usb_gadget_register_driver_owner+0xfb/0x1e0 drivers/usb/gadget/udc/core.c:1560 gadget_dev_desc_UDC_store+0x184/0x220 drivers/usb/gadget/configfs.c:299 flush_write_buffer fs/configfs/file.c:207 [inline] configfs_write_iter+0x2ea/0x480 fs/configfs/file.c:229 call_write_iter include/linux/fs.h:2187 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x9ca/0xd90 fs/read_write.c:578 ksys_write+0x127/0x250 fs/read_write.c:631 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&rmidi->open_mutex){+.+.}-{3:3}: lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x580 kernel/locking/lockdep.c:5631 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x14f/0x1f50 kernel/locking/mutex.c:747 snd_rawmidi_dev_disconnect+0x60/0x650 sound/core/rawmidi.c:2028 __snd_device_disconnect.part.0+0x5b/0xc0 sound/core/device.c:63 __snd_device_disconnect sound/core/device.c:61 [inline] snd_device_disconnect_all+0x9b/0xf0 sound/core/device.c:215 snd_card_disconnect+0x306/0x740 sound/core/init.c:530 snd_card_free_when_closed+0x13/0x50 sound/core/init.c:622 f_midi_unbind+0x60/0x120 drivers/usb/gadget/function/f_midi.c:1335 purge_configs_funcs+0x281/0x4e0 drivers/usb/gadget/configfs.c:1274 configfs_composite_bind+0xbd3/0x11c0 drivers/usb/gadget/configfs.c:1426 gadget_bind_driver+0x285/0x860 drivers/usb/gadget/udc/core.c:1495 call_driver_probe drivers/base/dd.c:560 [inline] really_probe+0x249/0xa90 drivers/base/dd.c:639 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808 __driver_attach+0x1e6/0x420 drivers/base/dd.c:1190 bus_for_each_dev+0x147/0x1d0 drivers/base/bus.c:301 bus_add_driver+0x4c9/0x640 drivers/base/bus.c:618 driver_register+0x1c4/0x330 drivers/base/driver.c:240 usb_gadget_register_driver_owner+0xfb/0x1e0 drivers/usb/gadget/udc/core.c:1560 gadget_dev_desc_UDC_store+0x184/0x220 drivers/usb/gadget/configfs.c:299 flush_write_buffer fs/configfs/file.c:207 [inline] configfs_write_iter+0x2ea/0x480 fs/configfs/file.c:229 call_write_iter include/linux/fs.h:2187 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x9ca/0xd90 fs/read_write.c:578 ksys_write+0x127/0x250 fs/read_write.c:631 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (register_mutex#5){+.+.}-{3:3}: check_prev_add+0x165/0x2520 kernel/locking/lockdep.c:3095 check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2df7/0x5830 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x580 kernel/locking/lockdep.c:5631 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x14f/0x1f50 kernel/locking/mutex.c:747 snd_rawmidi_free+0x7a/0x190 sound/core/rawmidi.c:1902 __snd_device_free+0x19f/0x230 sound/core/device.c:76 snd_device_free_all+0xef/0x210 sound/core/device.c:233 snd_card_do_free sound/core/init.c:591 [inline] release_card_device+0x70/0x200 sound/core/init.c:145 device_release+0x9f/0x240 drivers/base/core.c:2330 kobject_cleanup lib/kobject.c:673 [inline] kobject_release lib/kobject.c:704 [inline] kref_put include/linux/kref.h:65 [inline] kobject_put+0x1be/0x4c0 lib/kobject.c:721 put_device+0x1b/0x30 drivers/base/core.c:3624 klist_next+0x254/0x4a0 lib/klist.c:404 class_dev_iter_next+0x83/0xc0 drivers/base/class.c:311 class_find_device+0x144/0x220 drivers/base/class.c:415 class_find_device_by_devt include/linux/device/class.h:167 [inline] device_destroy+0x79/0xd0 drivers/base/core.c:4299 sound_remove_unit+0x13f/0x1f0 sound/sound_core.c:305 snd_unregister_oss_device+0xe8/0x290 sound/core/sound_oss.c:165 snd_mixer_oss_notify_handler+0x282/0x360 sound/core/oss/mixer_oss.c:1417 snd_card_disconnect+0x2f9/0x740 sound/core/init.c:526 usb_audio_disconnect+0x335/0x800 sound/usb/card.c:930 usb_unbind_interface+0x1bd/0x890 drivers/usb/core/driver.c:458 device_remove drivers/base/dd.c:550 [inline] device_remove+0x11f/0x170 drivers/base/dd.c:542 __device_release_driver drivers/base/dd.c:1249 [inline] device_release_driver_internal+0x1a7/0x360 drivers/base/dd.c:1275 bus_remove_device+0x2e3/0x590 drivers/base/bus.c:529 device_del+0x5d2/0xe80 drivers/base/core.c:3704 usb_disable_device+0x214/0x600 drivers/usb/core/message.c:1419 usb_disconnect+0x285/0x860 drivers/usb/core/hub.c:2235 hub_port_connect drivers/usb/core/hub.c:5197 [inline] hub_port_connect_change drivers/usb/core/hub.c:5497 [inline] port_event drivers/usb/core/hub.c:5653 [inline] hub_event+0x1c1b/0x4260 drivers/usb/core/hub.c:5735 process_one_work+0x9c7/0x1650 kernel/workqueue.c:2289 worker_thread+0x623/0x1070 kernel/workqueue.c:2436 kthread+0x2e9/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 other info that might help us debug this: Chain exists of: register_mutex#5 --> &rmidi->open_mutex --> sound_oss_mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sound_oss_mutex); lock(&rmidi->open_mutex); lock(sound_oss_mutex); lock(register_mutex#5); *** DEADLOCK *** 7 locks held by kworker/1:7/10868: #0: ffff88801452b938 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] #0: ffff88801452b938 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: arch_atomic_long_set include/linux/atomic/atomic-long.h:41 [inline] #0: ffff88801452b938 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: atomic_long_set include/linux/atomic/atomic-instrumented.h:1280 [inline] #0: ffff88801452b938 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:636 [inline] #0: ffff88801452b938 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:663 [inline] #0: ffff88801452b938 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: process_one_work+0x8b0/0x1650 kernel/workqueue.c:2260 #1: ffffc90018367db0 ((work_completion)(&hub->events)){+.+.}-{0:0}, at: process_one_work+0x8e4/0x1650 kernel/workqueue.c:2264 #2: ffff8880164d2190 (&dev->mutex){....}-{3:3}, at: device_lock include/linux/device.h:835 [inline] #2: ffff8880164d2190 (&dev->mutex){....}-{3:3}, at: hub_event+0x1bc/0x4260 drivers/usb/core/hub.c:5681 #3: ffff888047497190 (&dev->mutex){....}-{3:3}, at: device_lock include/linux/device.h:835 [inline] #3: ffff888047497190 (&dev->mutex){....}-{3:3}, at: usb_disconnect+0x95/0x860 drivers/usb/core/hub.c:2226 #4: ffff888047493118 (&dev->mutex){....}-{3:3}, at: device_release_driver_internal+0x23/0x360 drivers/base/dd.c:1272 #5: ffffffff8e2e7f68 (register_mutex#7){+.+.}-{3:3}, at: usb_audio_disconnect+0xe3/0x800 sound/usb/card.c:919 #6: ffffffff8e274048 (sound_oss_mutex){+.+.}-{3:3}, at: snd_unregister_oss_device+0x97/0x290 sound/core/sound_oss.c:159 stack backtrace: CPU: 1 PID: 10868 Comm: kworker/1:7 Not tainted 6.0.0-rc4+ #20 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Workqueue: usb_hub_wq hub_event Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 check_noncircular+0x26b/0x310 kernel/locking/lockdep.c:2175 check_prev_add+0x165/0x2520 kernel/locking/lockdep.c:3095 check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2df7/0x5830 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x580 kernel/locking/lockdep.c:5631 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x14f/0x1f50 kernel/locking/mutex.c:747 snd_rawmidi_free+0x7a/0x190 sound/core/rawmidi.c:1902 __snd_device_free+0x19f/0x230 sound/core/device.c:76 snd_device_free_all+0xef/0x210 sound/core/device.c:233 snd_card_do_free sound/core/init.c:591 [inline] release_card_device+0x70/0x200 sound/core/init.c:145 device_release+0x9f/0x240 drivers/base/core.c:2330 kobject_cleanup lib/kobject.c:673 [inline] kobject_release lib/kobject.c:704 [inline] kref_put include/linux/kref.h:65 [inline] kobject_put+0x1be/0x4c0 lib/kobject.c:721 put_device+0x1b/0x30 drivers/base/core.c:3624 klist_next+0x254/0x4a0 lib/klist.c:404 class_dev_iter_next+0x83/0xc0 drivers/base/class.c:311 class_find_device+0x144/0x220 drivers/base/class.c:415 class_find_device_by_devt include/linux/device/class.h:167 [inline] device_destroy+0x79/0xd0 drivers/base/core.c:4299 sound_remove_unit+0x13f/0x1f0 sound/sound_core.c:305 snd_unregister_oss_device+0xe8/0x290 sound/core/sound_oss.c:165 snd_mixer_oss_notify_handler+0x282/0x360 sound/core/oss/mixer_oss.c:1417 snd_card_disconnect+0x2f9/0x740 sound/core/init.c:526 usb_audio_disconnect+0x335/0x800 sound/usb/card.c:930 usb_unbind_interface+0x1bd/0x890 drivers/usb/core/driver.c:458 device_remove drivers/base/dd.c:550 [inline] device_remove+0x11f/0x170 drivers/base/dd.c:542 __device_release_driver drivers/base/dd.c:1249 [inline] device_release_driver_internal+0x1a7/0x360 drivers/base/dd.c:1275 bus_remove_device+0x2e3/0x590 drivers/base/bus.c:529 device_del+0x5d2/0xe80 drivers/base/core.c:3704 usb_disable_device+0x214/0x600 drivers/usb/core/message.c:1419 usb_disconnect+0x285/0x860 drivers/usb/core/hub.c:2235 hub_port_connect drivers/usb/core/hub.c:5197 [inline] hub_port_connect_change drivers/usb/core/hub.c:5497 [inline] port_event drivers/usb/core/hub.c:5653 [inline] hub_event+0x1c1b/0x4260 drivers/usb/core/hub.c:5735 process_one_work+0x9c7/0x1650 kernel/workqueue.c:2289 worker_thread+0x623/0x1070 kernel/workqueue.c:2436 kthread+0x2e9/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 </TASK>

2 3

[PATCH -next] sound: sunxi: fix declaration compile error
by Zeng Heng 21 Sep '22

21 Sep '22

Just fix compile error without any logic changes. sound/soc/sunxi/sun50i-dmic.c:62:1: error: ‘static’ is not at beginning of declaration [-Werror=old-style-declaration] 62 | const static struct dmic_rate dmic_rate_s[] = { | ^~~~~ Signed-off-by: Zeng Heng <zengheng4(a)huawei.com> --- sound/soc/sunxi/sun50i-dmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c index cd3c07f2070f..86cff5a5b1bd 100644 --- a/sound/soc/sunxi/sun50i-dmic.c +++ b/sound/soc/sunxi/sun50i-dmic.c @@ -59,7 +59,7 @@ struct dmic_rate { unsigned int rate_bit; }; -const static struct dmic_rate dmic_rate_s[] = { +static const struct dmic_rate dmic_rate_s[] = { {48000, 0x0}, {44100, 0x0}, {32000, 0x1}, -- 2.25.1

2 2

[PATCH] ALSA: hda/hdmi: ELD procfs - print the codec NIDs
by Jaroslav Kysela 21 Sep '22

21 Sep '22

It is useful for the debugging to print also the used HDA codec NIDs used for the given HDMI device. With the dynamic converter assignment the converter NID is changed dynamically. Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/pci/hda/hda_eld.c | 6 +++++- sound/pci/hda/hda_local.h | 3 ++- sound/pci/hda/patch_hdmi.c | 3 ++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c index 9e97443795f8..1d108ed5c6f2 100644 --- a/sound/pci/hda/hda_eld.c +++ b/sound/pci/hda/hda_eld.c @@ -440,7 +440,8 @@ static void hdmi_print_sad_info(int i, struct cea_sad *a, } void snd_hdmi_print_eld_info(struct hdmi_eld *eld, - struct snd_info_buffer *buffer) + struct snd_info_buffer *buffer, + hda_nid_t pin_nid, int dev_id, hda_nid_t cvt_nid) { struct parsed_hdmi_eld *e = &eld->info; char buf[SND_PRINT_CHANNEL_ALLOCATION_ADVISED_BUFSIZE]; @@ -462,6 +463,9 @@ void snd_hdmi_print_eld_info(struct hdmi_eld *eld, snd_iprintf(buffer, "monitor_present\t\t%d\n", eld->monitor_present); snd_iprintf(buffer, "eld_valid\t\t%d\n", eld->eld_valid); + snd_iprintf(buffer, "codec_pin_nid\t\t0x%x\n", pin_nid); + snd_iprintf(buffer, "codec_dev_id\t\t0x%x\n", dev_id); + snd_iprintf(buffer, "codec_cvt_nid\t\t0x%x\n", cvt_nid); if (!eld->eld_valid) return; snd_iprintf(buffer, "monitor_name\t\t%s\n", e->monitor_name); diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h index 682dca2057db..53a5a62b78fa 100644 --- a/sound/pci/hda/hda_local.h +++ b/sound/pci/hda/hda_local.h @@ -712,7 +712,8 @@ int snd_hdmi_get_eld_ati(struct hda_codec *codec, hda_nid_t nid, #ifdef CONFIG_SND_PROC_FS void snd_hdmi_print_eld_info(struct hdmi_eld *eld, - struct snd_info_buffer *buffer); + struct snd_info_buffer *buffer, + hda_nid_t pin_nid, int dev_id, hda_nid_t cvt_nid); void snd_hdmi_write_eld_info(struct hdmi_eld *eld, struct snd_info_buffer *buffer); #endif diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index e20e0ed759f6..f27a4ee810e3 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -494,7 +494,8 @@ static void print_eld_info(struct snd_info_entry *entry, struct hdmi_spec_per_pin *per_pin = entry->private_data; mutex_lock(&per_pin->lock); - snd_hdmi_print_eld_info(&per_pin->sink_eld, buffer); + snd_hdmi_print_eld_info(&per_pin->sink_eld, buffer, per_pin->pin_nid, + per_pin->dev_id, per_pin->cvt_nid); mutex_unlock(&per_pin->lock); } -- 2.35.3

2 1

[PATCH] ALSA: hda/hdmi: Simplify the pcm_idx condition in hdmi_pcm_setup_pin()
by Jaroslav Kysela 21 Sep '22

21 Sep '22

Make the code more readable. Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/pci/hda/patch_hdmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index dc36af2928b7..e20e0ed759f6 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1461,10 +1461,9 @@ static void hdmi_pcm_setup_pin(struct hdmi_spec *spec, int mux_idx; bool non_pcm; - if (per_pin->pcm_idx >= 0 && per_pin->pcm_idx < spec->pcm_used) - pcm = get_pcm_rec(spec, per_pin->pcm_idx); - else + if (per_pin->pcm_idx < 0 || per_pin->pcm_idx >= spec->pcm_used) return; + pcm = get_pcm_rec(spec, per_pin->pcm_idx); if (!pcm->pcm) return; if (!test_bit(per_pin->pcm_idx, &spec->pcm_in_use)) -- 2.35.3

2 1

[PATCH v3 0/2] Add some models into acp6x quirk list
by Mario Limonciello 21 Sep '22

21 Sep '22

Another model from ASUS and Lenovo have been identified that don't include anything in ACPI tables to indicate they require the ACP6x DMIC driver to be loaded. This series adds them both to the quirk list. changes from v1->v2: * Both models were independently sent in v1 but touch the same code, so v2 collates them together. v2->v3: * Add my missing S-o-B for 1/2 Mario Limonciello (1): ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table Xiaoyan Li (1): ASoC: amd: yc: Add ASUS UM5302TA into DMI table sound/soc/amd/yc/acp6x-mach.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) -- 2.34.1

2 3

[PATCH v2 0/2] Add some models into acp6x quirk list
by Mario Limonciello 21 Sep '22

21 Sep '22

Another model from ASUS and Lenovo have been identified that don't include anything in ACPI tables to indicate they require the ACP6x DMIC driver to be loaded. This series adds them both to the quirk list. changes from v1->v2: * Both models were independently sent in v1 but touch the same code, so v2 collates them together. Mario Limonciello (1): ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table Xiaoyan Li (1): ASoC: amd: yc: Add ASUS UM5302TA into DMI table sound/soc/amd/yc/acp6x-mach.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) -- 2.34.1

2 4

[PATCH -next] ASoC: rt5682s: simplify the return of rt5682s_probe()
by Yang Yingliang 21 Sep '22

21 Sep '22

After commit bfc5e8b860ad ("ASoC: rt5682s: Reduce coupling of Micbias and Vref2 settings"), the return of rt5682s_probe() can be simplified. No functional changed. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/codecs/rt5682s.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index 9d7a70753c6f..466a37f3500c 100644 --- a/sound/soc/codecs/rt5682s.c +++ b/sound/soc/codecs/rt5682s.c @@ -2864,15 +2864,10 @@ static inline int rt5682s_dai_probe_clks(struct snd_soc_component *component) static int rt5682s_probe(struct snd_soc_component *component) { struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component); - int ret; rt5682s->component = component; - ret = rt5682s_dai_probe_clks(component); - if (ret) - return ret; - - return 0; + return rt5682s_dai_probe_clks(component); } static void rt5682s_remove(struct snd_soc_component *component) -- 2.25.1

2 1

[PATCH] ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table
by Mario Limonciello 21 Sep '22

21 Sep '22

Lenovo Yoga Slim 7 Pro X has an ACP DMIC that isn't specified in the ASL or existing quirk list. Add it to the quirk table to let DMIC work on these systems. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216299 Tested-by: Sebastian S <iam(a)decentr.al> Reporetd-and-tested-by: Travis Glenn Hansen <travisghansen(a)yahoo.com> Signed-off-by: Mario Limonciello <mario.limonciello(a)amd.com> --- This patch applies on top of the other patch introducing a quirk: https://lore.kernel.org/alsa-devel/20220917070847.14346-1-lxy.lixiaoyan@gma… If either of them need to change, we should roll both into a series. sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 5eab3baf3573..2cb50d5cf1a9 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -171,6 +171,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "21J6"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "82"), + } + }, { .driver_data = &acp6x_card, .matches = { -- 2.34.1

3 6

[PATCH v2 0/4] ASoC: SOF: Add SKL/KBL support for IPC4 CI tests
by Pierre-Louis Bossart 21 Sep '22

21 Sep '22

This patchset was submitted earlier in April 2022 as part of the "ASoC: SOF: add INTEL_IPC4 plumbing" series. As requested the SKL/KBL support is moved to a different series. This update adds minor style fixes and the ops that were missing at the time. SKL and KBL daily tests have been running for several months and helped identify missing sequences in the SOF driver for HDaudio links, or platform differences that the driver did not account for (number of pipelines, etc). Note that this capability is not recommended for any distribution, it is ONLY for SOF IPC4 CI tests on HDaudio devices, we will not extend this SKL/KBL support for I2S devices based on ES8336 or Chromebooks which are ONLY supported by the AVS driver. v2: Squashed commits from Peter Ujfalusi that fixed compilation issues and ipc4-mtrace information. Peter's Signed-off-by tag was kept for credit. Updated commit messages to remove obsolete statements about IPC4 integration. Pierre-Louis Bossart (4): ASoC: SOF: Intel: hda-dsp: expose functions for SKL support ASoC: SOF: Intel: add SKL/KBL hardware code loader ASoC: SOF: Intel: add initial SKL/KBL hardware support ASoC: SOF: Intel: add ops for SKL/KBL sound/soc/sof/intel/Kconfig | 25 ++ sound/soc/sof/intel/Makefile | 4 + sound/soc/sof/intel/hda-dsp.c | 4 +- sound/soc/sof/intel/hda-ipc.c | 8 + sound/soc/sof/intel/hda-loader-skl.c | 580 +++++++++++++++++++++++++++ sound/soc/sof/intel/hda.c | 2 + sound/soc/sof/intel/hda.h | 13 + sound/soc/sof/intel/pci-skl.c | 91 +++++ sound/soc/sof/intel/skl.c | 116 ++++++ 9 files changed, 841 insertions(+), 2 deletions(-) create mode 100644 sound/soc/sof/intel/hda-loader-skl.c create mode 100644 sound/soc/sof/intel/pci-skl.c create mode 100644 sound/soc/sof/intel/skl.c -- 2.34.1

2 5

[PATCH 0/4] ASoC: SOF: Add SKL/KBL support for IPC4 CI tests
by Pierre-Louis Bossart 21 Sep '22

21 Sep '22

This patchset was submitted earlier in April 2022 as part of the "ASoC: SOF: add INTEL_IPC4 plumbing" series. As requested the SKL/KBL support is moved to a different series. This updates adds minor style fixes and the ops that were missing at the time. SKL and KBL daily tests have been running for several months and helped identify missing sequences in the SOF driver for HDaudio links, or platform differences that the driver did not account for (number of pipelines, etc). Note that this capability is not recommended for any distribution, it is ONLY for SOF IPC4 CI tests on HDaudio devices, we will not extend this SKL/KBL support for I2S devices based on ES8336 or Chromebooks which are ONLY supported by the AVS driver. This patchset is dependent on the series " ASoC: SOF: start using tracing instead of dev_dbg" Pierre-Louis Bossart (4): ASoC: SOF: Intel: hda-dsp: expose functions for SKL support ASoC: SOF: Intel: add SKL/KBL hardware code loader ASoC: SOF: Intel: add initial SKL/KBL hardware support ASoC: SOF: Intel: add ops for SKL/KBL sound/soc/sof/intel/Kconfig | 25 ++ sound/soc/sof/intel/Makefile | 4 + sound/soc/sof/intel/hda-dsp.c | 4 +- sound/soc/sof/intel/hda-ipc.c | 8 + sound/soc/sof/intel/hda-loader-skl.c | 580 +++++++++++++++++++++++++++ sound/soc/sof/intel/hda.c | 2 + sound/soc/sof/intel/hda.h | 12 + sound/soc/sof/intel/pci-skl.c | 91 +++++ sound/soc/sof/intel/skl.c | 114 ++++++ 9 files changed, 838 insertions(+), 2 deletions(-) create mode 100644 sound/soc/sof/intel/hda-loader-skl.c create mode 100644 sound/soc/sof/intel/pci-skl.c create mode 100644 sound/soc/sof/intel/skl.c -- 2.34.1

3 9

[PATCH v3 0/3] ASoC: ts3a227e control debounce times
by Astrid Rost 21 Sep '22

21 Sep '22

From: Astrid Rost <astridr(a)axis.com> PATCH 1 - convert ts3a227e bindings to yaml. PATCH 2 - add ts3a227e bindings to support debounce times. PATCH 3 - add ts3a227e driver to support debounce times. v2 -> v3 Changes in the yaml file: - Renamed ts3a227e.yaml to ti,ts3a227e.yaml. - Changed "ti,micbias" default value to the reset register value. - Skipped some obvious descriptions. - Removed unused include. - Node name is "audio-controller". - Removed register value from the description. Signed-off-by: Astrid Rost <astrid.rost(a)axis.com> Astrid Rost (3): dt-bindings: sound: ti,ts3a227e: convert to yaml dt-bindings: sound: ti,s3a227e: add control of debounce ASoC: ts3a227e: add parameters to control debounce times .../bindings/sound/ti,ts3a227e.yaml | 94 +++++++++++++++++++ .../devicetree/bindings/sound/ts3a227e.txt | 30 ------ sound/soc/codecs/ts3a227e.c | 58 ++++++++++-- 3 files changed, 146 insertions(+), 36 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml delete mode 100644 Documentation/devicetree/bindings/sound/ts3a227e.txt -- 2.20.1

3 6

[PATCH 0/2] ASoC: SOF: sof-audio: fix prepare/unprepare
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

2 patches from Rander required to enable mixing usages with multiple pipelines. Rander Wang (2): ASoC: SOF: clear prepare state when widget is unprepared ASoC: SOF: don't unprepare widget used other pipelines sound/soc/sof/sof-audio.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) -- 2.34.1

2 3

[PATCH 0/2] ASoC: SOF: ipc4-topology: minor cleanup
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

Two updates on warnings reported by cppcheck. Pierre-Louis Bossart (2): ASoC: SOF: ipc4-topology: clarify calculation precedence ASoC: SOF: ipc4-topology: remove useless assignment sound/soc/sof/ipc4-topology.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.34.1

2 3

[PATCH] ASoC: codecs: tfa989x: fix register access comments
by Alexander Martinz 20 Sep '22

20 Sep '22

Fix comments regarding register access based on review feedback[1]. [1]: https://lore.kernel.org/all/YppQ7BiqlBDMNsuc@gerhold.net/ Signed-off-by: Alexander Martinz <amartinz(a)shiftphones.com> --- sound/soc/codecs/tfa989x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tfa989x.c b/sound/soc/codecs/tfa989x.c index 1c27429b9af6..b853507e65a8 100644 --- a/sound/soc/codecs/tfa989x.c +++ b/sound/soc/codecs/tfa989x.c @@ -193,7 +193,7 @@ static int tfa9890_init(struct regmap *regmap) { int ret; - /* unhide keys to allow updating them */ + /* temporarily allow access to hidden registers */ ret = regmap_write(regmap, TFA989X_HIDE_UNHIDE_KEY, 0x5a6b); if (ret) return ret; @@ -203,7 +203,7 @@ static int tfa9890_init(struct regmap *regmap) if (ret) return ret; - /* hide keys again */ + /* hide registers again */ ret = regmap_write(regmap, TFA989X_HIDE_UNHIDE_KEY, 0x0000); if (ret) return ret; -- 2.37.3

2 1

[PATCH 0/3] ASoC: soc.h: random cleanup
by Kuninori Morimoto 20 Sep '22

20 Sep '22

Hi Mark These are random cleanup for soc.h Kuninori Morimoto (3): ASoC: soc.h: remove num_cpus/codecs ASoC: soc.h: use defined number instead of direct number ASoC: soc.h: use array instead of playback/capture_widget include/sound/soc.h | 16 ++++++---------- sound/soc/amd/vangogh/acp5x-mach.c | 2 +- sound/soc/samsung/odroid.c | 2 +- sound/soc/soc-compress.c | 4 ++-- sound/soc/soc-core.c | 4 +--- sound/soc/soc-dapm.c | 23 +++++++++++++---------- sound/soc/soc-generic-dmaengine-pcm.c | 6 +++--- sound/soc/soc-pcm.c | 20 ++++++++++---------- sound/soc/sof/topology.c | 4 ++-- 9 files changed, 39 insertions(+), 42 deletions(-) -- 2.25.1

2 4

[PATCH] ASoC: Intel: soc-acpi-intel-rpl-match: add rpl_sdca_3_in_1 support
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

From: Bard Liao <yung-chuan.liao(a)linux.intel.com> Add rpl_sdca_3_in_1 match information. Reviewed-by: Rander Wang <rander.wang(a)intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- .../intel/common/soc-acpi-intel-rpl-match.c | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) diff --git a/sound/soc/intel/common/soc-acpi-intel-rpl-match.c b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c index 0b77401e4e6f9..9ccf7370157b4 100644 --- a/sound/soc/intel/common/soc-acpi-intel-rpl-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c @@ -15,6 +15,20 @@ static const struct snd_soc_acpi_endpoint single_endpoint = { .group_id = 0, }; +static const struct snd_soc_acpi_endpoint spk_l_endpoint = { + .num = 0, + .aggregated = 1, + .group_position = 0, + .group_id = 1, +}; + +static const struct snd_soc_acpi_endpoint spk_r_endpoint = { + .num = 0, + .aggregated = 1, + .group_position = 1, + .group_id = 1, +}; + static const struct snd_soc_acpi_adr_device rt711_0_adr[] = { { .adr = 0x000020025D071100ull, @@ -33,6 +47,66 @@ static const struct snd_soc_acpi_link_adr rpl_rvp[] = { {} }; +static const struct snd_soc_acpi_adr_device rt711_sdca_0_adr[] = { + { + .adr = 0x000030025D071101ull, + .num_endpoints = 1, + .endpoints = &single_endpoint, + .name_prefix = "rt711" + } +}; + +static const struct snd_soc_acpi_adr_device rt1316_1_group1_adr[] = { + { + .adr = 0x000131025D131601ull, /* unique ID is set for some reason */ + .num_endpoints = 1, + .endpoints = &spk_l_endpoint, + .name_prefix = "rt1316-1" + } +}; + +static const struct snd_soc_acpi_adr_device rt1316_3_group1_adr[] = { + { + .adr = 0x000330025D131601ull, + .num_endpoints = 1, + .endpoints = &spk_r_endpoint, + .name_prefix = "rt1316-2" + } +}; + +static const struct snd_soc_acpi_adr_device rt714_2_adr[] = { + { + .adr = 0x000230025D071401ull, + .num_endpoints = 1, + .endpoints = &single_endpoint, + .name_prefix = "rt714" + } +}; + +static const struct snd_soc_acpi_link_adr rpl_sdca_3_in_1[] = { + { + .mask = BIT(0), + .num_adr = ARRAY_SIZE(rt711_sdca_0_adr), + .adr_d = rt711_sdca_0_adr, + }, + { + .mask = BIT(1), + .num_adr = ARRAY_SIZE(rt1316_1_group1_adr), + .adr_d = rt1316_1_group1_adr, + }, + { + .mask = BIT(2), + .num_adr = ARRAY_SIZE(rt714_2_adr), + .adr_d = rt714_2_adr, + }, + { + .mask = BIT(3), + .num_adr = ARRAY_SIZE(rt1316_3_group1_adr), + .adr_d = rt1316_3_group1_adr, + }, + {} +}; + struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_machines[] = { {}, }; @@ -40,6 +114,12 @@ EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_rpl_machines); /* this table is used when there is no I2S codec present */ struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_sdw_machines[] = { + { + .link_mask = 0xF, /* 4 active links required */ + .links = rpl_sdca_3_in_1, + .drv_name = "sof_sdw", + .sof_tplg_filename = "sof-rpl-rt711-l0-rt1316-l13-rt714-l2.tplg", + }, { .link_mask = 0x1, /* link0 required */ .links = rpl_rvp, -- 2.34.1

2 1

[PATCH] ASoC: SOF: mediatek: add pcm_hw_params callback for mt8186
by Chunxu Li 20 Sep '22

20 Sep '22

add pcm_hw_params callback for mt8186 to support continue update dma host position Signed-off-by: Chunxu Li <chunxu.li(a)mediatek.com> --- sound/soc/sof/mediatek/mt8186/mt8186.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c index a1be5d74f40b..9ec89fc7fec0 100644 --- a/sound/soc/sof/mediatek/mt8186/mt8186.c +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c @@ -460,6 +460,16 @@ static int mt8186_get_bar_index(struct snd_sof_dev *sdev, u32 type) return type; } +static int mt8186_pcm_hw_params(struct snd_sof_dev *sdev, + struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct snd_sof_platform_stream_params *platform_params) +{ + platform_params->cont_update_posn = 1; + + return 0; +} + static struct snd_soc_dai_driver mt8186_dai[] = { { .name = "SOF_DL1", @@ -526,6 +536,7 @@ static struct snd_sof_dsp_ops sof_mt8186_ops = { /* stream callbacks */ .pcm_open = sof_stream_pcm_open, + .pcm_hw_params = mt8186_pcm_hw_params, .pcm_close = sof_stream_pcm_close, /* firmware loading */ -- 2.25.1

2 1

[PATCH v2 0/4] ASoC: SOF: Intel: override mclk_id for ES8336 support
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

This patchset solves a known issue with ES8336 platforms wrt MCLK selection. Most of the devices use the MCLK0 signal, but some devices do use the MCLK1 signal. The MCLK is defined in the topology, it would be a nightmare to generate more topology files just for one MCLK difference. With a minor extension to the intel-nhlt library, the MCLK information can be found by parsing the NHLT table, and we can override the mclk_id at boot time. The only known issues for this platform remain the detection of GPIO and microphone connections, currently only possible with manual quirks. Thanks to Eugene J. Markow for testing this patchset. v2: addressed comments from Takashi and Amadeusz Better error handling for the 1.5 case Report error at the library level when 2 mclks are used Pierre-Louis Bossart (4): ASoC: SOF: Intel: hda: refine SSP count support ASoC: SOF: add quirk to override topology mclk_id ALSA: hda: intel-nhlt: add intel_nhlt_ssp_mclk_mask() ASoC: SOF: Intel: hda: override mclk_id after parsing NHLT SSP blob include/sound/intel-nhlt.h | 7 ++++ sound/hda/intel-nhlt.c | 79 +++++++++++++++++++++++++++++++++++ sound/soc/sof/intel/hda.c | 39 +++++++++++++++++ sound/soc/sof/intel/hda.h | 2 + sound/soc/sof/intel/mtl.c | 2 +- sound/soc/sof/intel/tgl.c | 8 ++-- sound/soc/sof/ipc3-topology.c | 7 ++++ sound/soc/sof/sof-priv.h | 4 ++ 8 files changed, 143 insertions(+), 5 deletions(-) -- 2.34.1

3 6

[PATCH v2 00/11] Support for CS42L83 on Apple machines
by Martin Povišer 20 Sep '22

20 Sep '22

[Changes for v2: Collected ack on compatible. Addressed Richard's comments pertaining to error handling. Rebased. Switched to dev_err_probe() in few places (added patch #11). Fixed authorship of one of Richard's patches.] Hi all, there's a CS42L83 headphone jack codec found in Apple computers (in the recent 'Apple Silicon' ones as well as in earlier models, one example [1]). The part isn't publicly documented, but it appears almost identical to CS42L42, for which we have a driver in kernel. This series adapts the CS42L42 driver to the new part, and makes one change in anticipation of a machine driver for the Apple computers. Patch 1 adds new compatible to the cs42l42 schema. Patches 2 to 7 are taken from Richard's recent series [2] adding soundwire support to cs42l42. They are useful refactorings to build on in the later patches, and also this way our work doesn't diverge. (I fixed missing free_irq path in cs42l42_init, did s/Soundwire/SoundWire/ in changelogs, rebased.) Patch 8 exports some regmap-related symbols from cs42l42.c so they can be used to create cs42l83 regmap in cs42l83-i2c.c later. Patch 9 is the cs42l83 support proper. Patch 10 implements 'set_bclk_ratio' on the cs42l42 core. This will be called by the upcoming ASoC machine driver for 'Apple Silicon' Macs. (We have touched on this change to be made in earlier discussion, see [3] and replies.) Patch 11 brings cs42l42-i2c.c in sync with cs42l83-i2c.c on dev_err_probe() usage. Best, Martin [1] https://www.ifixit.com/Teardown/MacBook+Pro+13-Inch+Touch+Bar+2018+Teardown… [2] https://lore.kernel.org/alsa-devel/20220819125230.42731-1-rf@opensource.cir… [3] https://lore.kernel.org/asahi/8961DDD2-93FF-4A18-BCA2-90FCE298F517@cutebit.… Martin Povišer (5): ASoC: dt-bindings: cs42l42: Add 'cs42l83' compatible ASoC: cs42l42: Export regmap elements to core namespace ASoC: cs42l83: Extend CS42L42 support to new part ASoC: cs42l42: Implement 'set_bclk_ratio' ASoC: cs42l42: Switch to dev_err_probe() helper Richard Fitzgerald (6): ASoC: cs42l42: Add bitclock frequency argument to cs42l42_pll_config() ASoC: cs42l42: Use cs42l42->dev instead of &i2c_client->dev ASoC: cs42l42: Split probe() and remove() into stages ASoC: cs42l42: Split cs42l42_resume into two functions ASoC: cs42l42: Pass component and dai defs into common probe ASoC: cs42l42: Split I2C identity into separate module .../bindings/sound/cirrus,cs42l42.yaml | 1 + MAINTAINERS | 1 + include/sound/cs42l42.h | 1 + sound/soc/codecs/Kconfig | 15 +- sound/soc/codecs/Makefile | 6 +- sound/soc/codecs/cs42l42-i2c.c | 106 +++++++ sound/soc/codecs/cs42l42.c | 259 +++++++++--------- sound/soc/codecs/cs42l42.h | 24 +- sound/soc/codecs/cs42l83-i2c.c | 242 ++++++++++++++++ 9 files changed, 529 insertions(+), 126 deletions(-) create mode 100644 sound/soc/codecs/cs42l42-i2c.c create mode 100644 sound/soc/codecs/cs42l83-i2c.c -- 2.33.0

3 14

"no soundcard" for GeminiLake High Definition Audio (rev 06)
by Linas Vepstas 20 Sep '22

20 Sep '22

Kernel reports "no soundcard". Presumably, this is why I don't have sound. Let me dive right in with details: cat /proc/asound/cards --- no soundcards --- lspci: 00:0e.0 Multimedia audio controller: Intel Corporation Celeron/Pentium Silver Processor High Definition Audio (rev 06) 00:0e.0 0401: 8086:3198 (rev 06) DeviceName: Onboard - Sound Subsystem: Device 02f3:f000 Kernel driver in use: sof-audio-pci-intel-apl Kernel modules: snd_hda_intel, snd_soc_skl, snd_sof_pci_intel_apl dmesg |grep -iE 'snd|sof|audio' [ 0.201569] ACPI: Added _OSI(Linux-Lenovo-NV-HDMI-Audio) [ 4.715400] snd_hda_intel 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100 [ 4.938181] snd_soc_skl 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100 [ 5.324959] sof-audio-pci-intel-apl 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100 [ 5.325268] sof-audio-pci-intel-apl 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if 0x040100 [ 5.325465] sof-audio-pci-intel-apl 0000:00:0e.0: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915]) [ 5.357483] sof-audio-pci-intel-apl 0000:00:0e.0: use msi interrupt mode [ 5.393933] sof-audio-pci-intel-apl 0000:00:0e.0: NHLT_DEVICE_I2S detected, ssp_mask 0x5 [ 5.393945] sof-audio-pci-intel-apl 0000:00:0e.0: hda codecs found, mask 4 [ 5.399557] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware info: version 2:1:1-3964a [ 5.399567] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware: ABI 3:21:0 Kernel ABI 3:23:0 [ 5.399579] sof-audio-pci-intel-apl 0000:00:0e.0: unknown sof_ext_man header type 3 size 0x30 [ 5.439596] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware info: version 2:1:1-3964a [ 5.439604] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware: ABI 3:21:0 Kernel ABI 3:23:0 cat /proc/version Linux version 6.0.0-rc5 (root@yippie) (gcc (Debian 12.2.0-1) 12.2.0, GNU ld (GNU Binutils for Debian) 2.38.90.20220713) #3 SMP PREEMPT_DYNAMIC Thu Sep 15 04:35:50 CDT 2022 I built this a few days ago from `make oldconfig` on the current Debian testing 5.19.15 kernel. I attempted debugging, and I found this: sound/soc/sof/intel/pci-apl.c: { PCI_DEVICE(0x8086, 0x3198), /* GeminiLake */ .driver_data = (unsigned long)&glk_desc}, Yay! That's my pci id! Adding printk's to both int snd_card_register(struct snd_card *card) int snd_soc_register_card(struct snd_soc_card *card) shows that neither of these are ever called. I was unable to figure out where they should have been called from. It's as if some driver is missing ??? There's nothing in sound/soc/intel/boards/* that seems to apply to my situation??? FWIW, more about this hardware: -- It's a cheap laptop, from newegg, Ipason MaxBook P1X, 4-core Intel Celeron, 12GB RAM, great price. -- lspci 00:00.0 Host bridge: Intel Corporation Gemini Lake Host Bridge (rev 06) 00:00.1 Signal processing controller: Intel Corporation Celeron/Pentium Silver Processor Dynamic Platform and Thermal Framework Processor Participant (rev 06) 00:02.0 VGA compatible controller: Intel Corporation GeminiLake [UHD Graphics 600] (rev 06) 00:0e.0 Multimedia audio controller: Intel Corporation Celeron/Pentium Silver Processor High Definition Audio (rev 06) 00:0f.0 Communication controller: Intel Corporation Celeron/Pentium Silver Processor Trusted Execution Engine Interface (rev 06) 00:12.0 SATA controller: Intel Corporation Celeron/Pentium Silver Processor SATA Controller (rev 06) 00:13.0 PCI bridge: Intel Corporation Gemini Lake PCI Express Root Port (rev f6) ... 00:15.0 USB controller: Intel Corporation Celeron/Pentium Silver Processor USB 3.0 xHCI Controller (rev 06) 00:16.0 Signal processing controller: Intel Corporation Celeron/Pentium Silver Processor I2C 0 (rev 06) ... 00:18.0 Signal processing controller: Intel Corporation Celeron/Pentium Silver Processor Serial IO UART Host Controller (rev 06) ... 00:1c.0 SD Host controller: Intel Corporation Celeron/Pentium Silver Processor SDA Standard Compliant SD Host Controller (rev 06) 00:1e.0 SD Host controller: Intel Corporation Device 31d0 (rev 06) 00:1f.0 ISA bridge: Intel Corporation Celeron/Pentium Silver Processor LPC Controller (rev 06) 00:1f.1 SMBus: Intel Corporation Celeron/Pentium Silver Processor Gaussian Mixture Model (rev 06) 01:00.0 Network controller: Realtek Semiconductor Co., Ltd. RTL8821CE 802.11ac PCIe Wireless Network Adapter So I guess there's "no soundcard" because the thing is wired directly into the PCI bus ?? I used to know PCI intimately, but that was a decade ago. I've forgotten all of that. Advice on how to proceed would be appreciated. I could maybe even write a device driver if someone holds my hand (I've written or worked on drivers for ethernet, scsi before) -- Linas -- Patrick: Are they laughing at us? Sponge Bob: No, Patrick, they are laughing next to us.

2 3

[PATCH] ALSA: usb-audio: Properly refcounting clock rate
by Takashi Iwai 20 Sep '22

20 Sep '22

We fixed the bug introduced by the patch for managing the shared clocks at the commit 809f44a0cc5a ("ALSA: usb-audio: Clear fixed clock rate at closing EP"), but it was merely a workaround. By this change, the clock reference rate is cleared at each EP close, hence the still remaining EP may need a re-setup of rate unnecessarily. This patch introduces the proper refcounting for the clock reference object so that the clock setup is done only when needed. Fixes: 809f44a0cc5a ("ALSA: usb-audio: Clear fixed clock rate at closing EP") Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/endpoint.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c index 0c94ebc98e90..b2d0b42b581f 100644 --- a/sound/usb/endpoint.c +++ b/sound/usb/endpoint.c @@ -39,6 +39,7 @@ struct snd_usb_iface_ref { struct snd_usb_clock_ref { unsigned char clock; atomic_t locked; + int opened; int rate; bool need_setup; struct list_head list; @@ -803,6 +804,7 @@ snd_usb_endpoint_open(struct snd_usb_audio *chip, ep = NULL; goto unlock; } + ep->clock_ref->opened++; } ep->cur_audiofmt = fp; @@ -926,8 +928,10 @@ void snd_usb_endpoint_close(struct snd_usb_audio *chip, endpoint_set_interface(chip, ep, false); if (!--ep->opened) { - if (ep->clock_ref && !atomic_read(&ep->clock_ref->locked)) - ep->clock_ref->rate = 0; + if (ep->clock_ref) { + if (!--ep->clock_ref->opened) + ep->clock_ref->rate = 0; + } ep->iface = 0; ep->altsetting = 0; ep->cur_audiofmt = NULL; @@ -1649,8 +1653,7 @@ void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep, bool keep_pending) WRITE_ONCE(ep->sync_source->sync_sink, NULL); stop_urbs(ep, false, keep_pending); if (ep->clock_ref) - if (!atomic_dec_return(&ep->clock_ref->locked)) - ep->clock_ref->rate = 0; + atomic_dec(&ep->clock_ref->locked); } } -- 2.35.3

1 0

ACP6x: UCM not working
by GitHub issues - opened 20 Sep '22

20 Sep '22

alsa-project/alsa-ucm-conf issue #215 was opened from sebastianst: My Ryzen 6000 laptop has an AMD audio coprocessor driving the microphone with the ACP6x kernel module. #138 added initial support for this, but me and some other people on different Ryzen 6000 laptops have issues with alsa-ucm not configuring the microphone properly. We have to disable `alsa-ucm` to get any sound input or output working with pulseaudio, see https://bbs.archlinux.org/viewtopic.php?pid=2058087#p2058087 for the relevant discussion. Note that we first had to add our laptops to some quirk table of the kernel module to get it working at all. Any idea how to fix this? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/215 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH -next] slimbus: qcom-ngd: Add error handling in of_qcom_slim_ngd_register
by Lin Yujun 20 Sep '22

20 Sep '22

No error handling is performed when platform_device_add() return fails. Refer to the error handling of driver_set_override(), add error handling for platform_device_add(). Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Signed-off-by: Lin Yujun <linyujun809(a)huawei.com> --- drivers/slimbus/qcom-ngd-ctrl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 0aa8408464ad..fb591990ddad 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1470,7 +1470,13 @@ static int of_qcom_slim_ngd_register(struct device *parent, ngd->pdev->dev.of_node = node; ctrl->ngd = ngd; - platform_device_add(ngd->pdev); + ret = platform_device_add(ngd->pdev); + if (ret) { + platform_device_put(ngd->pdev); + kfree(ngd); + of_node_put(node); + return ret; + } ngd->base = ctrl->base + ngd->id * data->offset + (ngd->id - 1) * data->size; -- 2.17.1

2 1

[PATCH] Revert "ALSA: usb-audio: Split endpoint setups for hw_params and prepare"
by Takashi Iwai 20 Sep '22

20 Sep '22

This reverts commit ff878b408a03bef5d610b7e2302702e16a53636e. Unfortunately the recent fix seems bringing another regressions with PulseAudio / pipewire, at least for Steinberg and MOTU devices. As a temporary solution, do a straight revert. The issue for Android will be revisited again later by another different fix (if any). Fixes: ff878b408a03 ("ALSA: usb-audio: Split endpoint setups for hw_params and prepare") Cc: <stable(a)vger.kernel.org> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=216500 Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/endpoint.c | 23 ++++++++++++++--------- sound/usb/endpoint.h | 6 ++---- sound/usb/pcm.c | 14 ++++---------- 3 files changed, 20 insertions(+), 23 deletions(-) diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c index 8c8f9a851f89..eb71df9da831 100644 --- a/sound/usb/endpoint.c +++ b/sound/usb/endpoint.c @@ -758,8 +758,7 @@ bool snd_usb_endpoint_compatible(struct snd_usb_audio *chip, * The endpoint needs to be closed via snd_usb_endpoint_close() later. * * Note that this function doesn't configure the endpoint. The substream - * needs to set it up later via snd_usb_endpoint_set_params() and - * snd_usb_endpoint_prepare(). + * needs to set it up later via snd_usb_endpoint_configure(). */ struct snd_usb_endpoint * snd_usb_endpoint_open(struct snd_usb_audio *chip, @@ -1293,13 +1292,12 @@ static int sync_ep_set_params(struct snd_usb_endpoint *ep) /* * snd_usb_endpoint_set_params: configure an snd_usb_endpoint * - * It's called either from hw_params callback. * Determine the number of URBs to be used on this endpoint. * An endpoint must be configured before it can be started. * An endpoint that is already running can not be reconfigured. */ -int snd_usb_endpoint_set_params(struct snd_usb_audio *chip, - struct snd_usb_endpoint *ep) +static int snd_usb_endpoint_set_params(struct snd_usb_audio *chip, + struct snd_usb_endpoint *ep) { const struct audioformat *fmt = ep->cur_audiofmt; int err; @@ -1382,18 +1380,18 @@ static int init_sample_rate(struct snd_usb_audio *chip, } /* - * snd_usb_endpoint_prepare: Prepare the endpoint + * snd_usb_endpoint_configure: Configure the endpoint * * This function sets up the EP to be fully usable state. - * It's called either from prepare callback. + * It's called either from hw_params or prepare callback. * The function checks need_setup flag, and performs nothing unless needed, * so it's safe to call this multiple times. * * This returns zero if unchanged, 1 if the configuration has changed, * or a negative error code. */ -int snd_usb_endpoint_prepare(struct snd_usb_audio *chip, - struct snd_usb_endpoint *ep) +int snd_usb_endpoint_configure(struct snd_usb_audio *chip, + struct snd_usb_endpoint *ep) { bool iface_first; int err = 0; @@ -1414,6 +1412,9 @@ int snd_usb_endpoint_prepare(struct snd_usb_audio *chip, if (err < 0) goto unlock; } + err = snd_usb_endpoint_set_params(chip, ep); + if (err < 0) + goto unlock; goto done; } @@ -1441,6 +1442,10 @@ int snd_usb_endpoint_prepare(struct snd_usb_audio *chip, if (err < 0) goto unlock; + err = snd_usb_endpoint_set_params(chip, ep); + if (err < 0) + goto unlock; + err = snd_usb_select_mode_quirk(chip, ep->cur_audiofmt); if (err < 0) goto unlock; diff --git a/sound/usb/endpoint.h b/sound/usb/endpoint.h index e67ea28faa54..6a9af04cf175 100644 --- a/sound/usb/endpoint.h +++ b/sound/usb/endpoint.h @@ -17,10 +17,8 @@ snd_usb_endpoint_open(struct snd_usb_audio *chip, bool is_sync_ep); void snd_usb_endpoint_close(struct snd_usb_audio *chip, struct snd_usb_endpoint *ep); -int snd_usb_endpoint_set_params(struct snd_usb_audio *chip, - struct snd_usb_endpoint *ep); -int snd_usb_endpoint_prepare(struct snd_usb_audio *chip, - struct snd_usb_endpoint *ep); +int snd_usb_endpoint_configure(struct snd_usb_audio *chip, + struct snd_usb_endpoint *ep); int snd_usb_endpoint_get_clock_rate(struct snd_usb_audio *chip, int clock); bool snd_usb_endpoint_compatible(struct snd_usb_audio *chip, diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index b604f7e95e82..d45d1d7e6664 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -443,17 +443,17 @@ static int configure_endpoints(struct snd_usb_audio *chip, if (stop_endpoints(subs, false)) sync_pending_stops(subs); if (subs->sync_endpoint) { - err = snd_usb_endpoint_prepare(chip, subs->sync_endpoint); + err = snd_usb_endpoint_configure(chip, subs->sync_endpoint); if (err < 0) return err; } - err = snd_usb_endpoint_prepare(chip, subs->data_endpoint); + err = snd_usb_endpoint_configure(chip, subs->data_endpoint); if (err < 0) return err; snd_usb_set_format_quirk(subs, subs->cur_audiofmt); } else { if (subs->sync_endpoint) { - err = snd_usb_endpoint_prepare(chip, subs->sync_endpoint); + err = snd_usb_endpoint_configure(chip, subs->sync_endpoint); if (err < 0) return err; } @@ -551,13 +551,7 @@ static int snd_usb_hw_params(struct snd_pcm_substream *substream, subs->cur_audiofmt = fmt; mutex_unlock(&chip->mutex); - if (subs->sync_endpoint) { - ret = snd_usb_endpoint_set_params(chip, subs->sync_endpoint); - if (ret < 0) - goto unlock; - } - - ret = snd_usb_endpoint_set_params(chip, subs->data_endpoint); + ret = configure_endpoints(chip, subs); unlock: if (ret < 0) -- 2.35.3

1 0

[PATCH linux-next] ALSA: es18xx: Remove the unneeded result variable
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Return the value inb() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/isa/es18xx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c index 3fcd168480b6..0a32845b1017 100644 --- a/sound/isa/es18xx.c +++ b/sound/isa/es18xx.c @@ -1344,11 +1344,8 @@ ES18XX_SINGLE("GPO1 Switch", 0, ES18XX_PM, 1, 1, ES18XX_FL_PMPORT), static int snd_es18xx_config_read(struct snd_es18xx *chip, unsigned char reg) { - int data; - outb(reg, chip->ctrl_port); - data = inb(chip->ctrl_port + 1); - return data; + return inb(chip->ctrl_port + 1); } static void snd_es18xx_config_write(struct snd_es18xx *chip, -- 2.25.1

2 1

[PATCH] soundwire: bus: Fix wrong port number in sdw_handle_slave_alerts()
by Richard Fitzgerald 20 Sep '22

20 Sep '22

for_each_set_bit() gives the bit-number counting from 0 (LSbit==0). When processing INTSTAT2, bit 0 is DP4 so the port number is (bit + 4). Likewise for INTSTAT3 bit 0 is DP11 so port number is (bit + 11). Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- drivers/soundwire/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 8eded1a55227..df0ae869ee51 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1622,7 +1622,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) port = buf2[0] & SDW_SCP_INTSTAT2_PORT4_10; for_each_set_bit(bit, &port, 8) { /* scp2 ports start from 4 */ - port_num = bit + 3; + port_num = bit + 4; sdw_handle_port_interrupt(slave, port_num, &port_status[port_num]); @@ -1634,7 +1634,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) port = buf2[1] & SDW_SCP_INTSTAT3_PORT11_14; for_each_set_bit(bit, &port, 8) { /* scp3 ports start from 11 */ - port_num = bit + 10; + port_num = bit + 11; sdw_handle_port_interrupt(slave, port_num, &port_status[port_num]); -- 2.30.2

2 2

HDA HDMI PCM device allocation
by Jaroslav Kysela 20 Sep '22

20 Sep '22

Hi, I am trying to fix some issues in UCM for the HDA HDMI devices [1][2]. I would like to summary the current situation at first (correct me, if I miss something): We have two methods to map the PINs in the HDA HDMI driver to the PCM devices (legacy/static - 1:1 mapping, dynamic - used for new devices with the MST capability). There is also set of converters in each HDMI codec and the number of simultaneously used PCM devices cannot go beyond this count of converters in hardware (otherwise -EBUSY error is returned). The count of converters is 3 or 4 depending on the hardware. Things to discuss: It seems quite straight to limit the count of created PCMs to the count of converters. We cannot use more anyway and it does not help, if more PCM devices are allocated (and Jacks reported) to applications when they cannot be used simultaneously. Legacy/static mapping should be converted to dynamic (unless the count of created PCM devices is equal to the count of codec converters). There may be 1:1 mapping between the converter and the PCM device to make things easier. There is a corner case, when more HDMI devices are connected than the count of converters. In this case, an extra method (a module parameter and/or a control element and/or procfs) may be used to filter unwanted HDMI devices. It may be a bit difficult to select the proper filtering key - it may be the PIN/MST device hash or so. The driver may report this key in eld#* files (procfs). Impact to applications: Those days, pulseaudio or pipewire servers are mostly used on the current hardware. Both servers share the legacy probe code for HDMI devices - they are trying to open PCM devices sequentially and check for the error code. There should not be a problem when the connected HDMI devices do not go beyond the count of converters. A minor issue is that the name of the used sink/port may be different (users may be forced to reselect the output path). For other applications, the PCM device assigned to the connected HDMI device may be different (available in a different ALSA device name). I do not think that it's a big issue. It should be easy solvable with an updated software configuration. Let me know about your opinion about this. Thank you, Jaroslav [1] https://github.com/alsa-project/alsa-lib/issues/245 [2] https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/2481 -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

3 2

[PATCH 0/8] ALSA: hda: document/simplify hdac_ext handling
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

This sound/hda/ext library is a confusing magic black box that very few understand. It needn't be that way, we can document/simplify and make the code clearer. Pierre-Louis Bossart (8): ALSA: hda: make snd_hdac_stream_clear() static ALSA: hda: document state machine for hdac_streams ALSA: hda: ext: make snd_hdac_ext_stream_init() static ALSA: hda: Use hdac_ext prefix in snd_hdac_stream_free_all() for clarity ALSA: hda: add snd_hdac_stop_streams() helper ALSA: hda: ext: simplify logic for stream assignment ALSA: hda: ext: fix locking in stream_release ALSA: hda: ext: remove always-true conditions on host and link release include/sound/hdaudio.h | 3 +- include/sound/hdaudio_ext.h | 5 +-- sound/hda/ext/hdac_ext_stream.c | 34 +++++++-------- sound/hda/hdac_stream.c | 74 +++++++++++++++++++++++++++++---- sound/pci/hda/hda_controller.c | 4 +- sound/soc/intel/avs/core.c | 4 +- sound/soc/intel/skylake/skl.c | 2 +- 7 files changed, 87 insertions(+), 39 deletions(-) -- 2.34.1

2 9

[PATCH] ALSA: hda/hdmi: Fix the converter allocation for the silent stream
by Jaroslav Kysela 20 Sep '22

20 Sep '22

Track the converters handling the silent stream using a new variable to avoid mixing of the open/close and silent stream use. This change ensures the proper allocation of the converters. Fixes: 5f80d6bd2b01 ("ALSA: hda/hdmi: Fix the converter reuse for the silent stream") Cc: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/pci/hda/patch_hdmi.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 4576af4cff90..dc36af2928b7 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -54,6 +54,7 @@ MODULE_PARM_DESC(enable_all_pins, "Forcibly enable all pins"); struct hdmi_spec_per_cvt { hda_nid_t cvt_nid; bool assigned; /* the stream has been assigned */ + bool silent_stream; /* silent stream activated */ unsigned int channels_min; unsigned int channels_max; u32 rates; @@ -977,7 +978,8 @@ static int hdmi_setup_stream(struct hda_codec *codec, hda_nid_t cvt_nid, * of the pin. */ static int hdmi_choose_cvt(struct hda_codec *codec, - int pin_idx, int *cvt_id) + int pin_idx, int *cvt_id, + bool silent) { struct hdmi_spec *spec = codec->spec; struct hdmi_spec_per_pin *per_pin; @@ -992,6 +994,9 @@ static int hdmi_choose_cvt(struct hda_codec *codec, if (per_pin && per_pin->silent_stream) { cvt_idx = cvt_nid_to_cvt_index(codec, per_pin->cvt_nid); + per_cvt = get_cvt(spec, cvt_idx); + if (per_cvt->assigned && !silent) + return -EBUSY; if (cvt_id) *cvt_id = cvt_idx; return 0; @@ -1002,7 +1007,7 @@ static int hdmi_choose_cvt(struct hda_codec *codec, per_cvt = get_cvt(spec, cvt_idx); /* Must not already be assigned */ - if (per_cvt->assigned) + if (per_cvt->assigned || per_cvt->silent_stream) continue; if (per_pin == NULL) break; @@ -1188,7 +1193,7 @@ static int hdmi_pcm_open_no_pin(struct hda_pcm_stream *hinfo, if (pcm_idx < 0) return -EINVAL; - err = hdmi_choose_cvt(codec, -1, &cvt_idx); + err = hdmi_choose_cvt(codec, -1, &cvt_idx, false); if (err) return err; @@ -1256,7 +1261,7 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo, } } - err = hdmi_choose_cvt(codec, pin_idx, &cvt_idx); + err = hdmi_choose_cvt(codec, pin_idx, &cvt_idx, false); if (err < 0) goto unlock; @@ -1267,7 +1272,6 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo, set_bit(pcm_idx, &spec->pcm_in_use); per_pin = get_pin(spec, pin_idx); per_pin->cvt_nid = per_cvt->cvt_nid; - per_pin->silent_stream = false; hinfo->nid = per_cvt->cvt_nid; /* flip stripe flag for the assigned stream if supported */ @@ -1749,14 +1753,14 @@ static void silent_stream_enable(struct hda_codec *codec, } pin_idx = pin_id_to_pin_index(codec, per_pin->pin_nid, per_pin->dev_id); - err = hdmi_choose_cvt(codec, pin_idx, &cvt_idx); + err = hdmi_choose_cvt(codec, pin_idx, &cvt_idx, true); if (err) { codec_err(codec, "hdmi: no free converter to enable silent mode\n"); goto unlock_out; } per_cvt = get_cvt(spec, cvt_idx); - per_cvt->assigned = true; + per_cvt->silent_stream = true; per_pin->cvt_nid = per_cvt->cvt_nid; per_pin->silent_stream = true; @@ -1816,7 +1820,7 @@ static void silent_stream_disable(struct hda_codec *codec, cvt_idx = cvt_nid_to_cvt_index(codec, per_pin->cvt_nid); if (cvt_idx >= 0 && cvt_idx < spec->num_cvts) { per_cvt = get_cvt(spec, cvt_idx); - per_cvt->assigned = false; + per_cvt->silent_stream = false; } if (spec->silent_stream_type == SILENT_STREAM_I915) { -- 2.35.3

3 2

[PATCH 00/11] soundwire: intel: cleanups/fixes before code reorganization
by Bard Liao 20 Sep '22

20 Sep '22

This is a really big cleanup to introduce well defined helpers, prior to a larger code reorganization. Pierre-Louis Bossart (11): soundwire: intel: fix error handling on dai registration issues soundwire: intel: simplify flow and use devm_ for DAI registration soundwire: intel: move DAI registration and debugfs init earlier soundwire: intel: move all PDI initialization under intel_register_dai() soundwire: intel: remove clock_stop parameter in intel_shim_init() soundwire: intel: move shim initialization before power up/down soundwire: intel: remove intel_init() wrapper soundwire: intel: simplify read ops assignment soundwire: intel: introduce intel_shim_check_wake() helper soundwire: intel: introduce helpers to start bus soundwire: intel: add helper to stop bus drivers/soundwire/intel.c | 775 +++++++++++++++++++------------------- 1 file changed, 380 insertions(+), 395 deletions(-) -- 2.25.1

2 12

[PATCH 1/2] soundwire: cadence: Fix error check in cdns_xfer_msg()
by Richard Fitzgerald 20 Sep '22

20 Sep '22

_cdns_xfer_msg() returns an sdw_command_response value, not a negative error code. Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- drivers/soundwire/cadence_master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index ca241bbeadd9..3543a923ee6b 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -708,7 +708,7 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg) for (i = 0; i < msg->len / CDNS_MCP_CMD_LEN; i++) { ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN, CDNS_MCP_CMD_LEN, false); - if (ret < 0) + if (ret != SDW_CMD_OK) goto exit; } -- 2.30.2

3 4

[PATCH] soundwire: cadence: Write to correct address for each FIFO chunk
by Richard Fitzgerald 20 Sep '22

20 Sep '22

_cdns_xfer_msg() must add the fragment offset to msg->addr to get the base target address of each FIFO chunk. Otherwise every chunk will be written to the first 32 register addresses. Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- drivers/soundwire/cadence_master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index 3ef472049980..ca241bbeadd9 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -569,7 +569,7 @@ _cdns_xfer_msg(struct sdw_cdns *cdns, struct sdw_msg *msg, int cmd, } base = CDNS_MCP_CMD_BASE; - addr = msg->addr; + addr = msg->addr + offset; for (i = 0; i < count; i++) { data = FIELD_PREP(CDNS_MCP_CMD_DEV_ADDR, msg->dev_num); -- 2.30.2

3 2

[PATCH v2 1/2] soundwire: qcom: update status from device id 1
by Srinivas Kandagatla 20 Sep '22

20 Sep '22

By default autoenumeration is enabled on QCom SoundWire controller which means the core should not be dealing with device 0 w.r.t enumeration. During Enumeration if SoundWire core sees status[0] as SDW_SLAVE_ATTACHED and start programming the device id, however reading DEVID registers return zeros which does not match to any of the slaves in the list and the core attempts to park this device to Group 13. This results in adding SoundWire device with enumeration address 0:0:0:0 Fix this by not passing device 0 status to SoundWire core. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- Changes since v1: - updated change log and split patch in to two as suggested by Pierre drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index e7f95c41eb70..d3ce580cdeaf 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -448,7 +448,7 @@ static void qcom_swrm_get_device_status(struct qcom_swrm_ctrl *ctrl) ctrl->reg_read(ctrl, SWRM_MCP_SLV_STATUS, &val); ctrl->slave_status = val; - for (i = 0; i <= SDW_MAX_DEVICES; i++) { + for (i = 1; i <= SDW_MAX_DEVICES; i++) { u32 s; s = (val >> (i * 2)); -- 2.21.0

3 4

[PATCH] soundwire: cadence: Don't overwrite msg->buf during write commands
by Richard Fitzgerald 20 Sep '22

20 Sep '22

The buf passed in struct sdw_msg must only be written for a READ, in that case the RDATA part of the response is the data value of the register. For a write command there is no RDATA, and buf should be assumed to be const and unmodifable. The original caller should not expect its data buffer to be corrupted by an sdw_nwrite(). Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- drivers/soundwire/cadence_master.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index be9cd47f31ec..3ef472049980 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -544,9 +544,12 @@ cdns_fill_msg_resp(struct sdw_cdns *cdns, return SDW_CMD_IGNORED; } - /* fill response */ - for (i = 0; i < count; i++) - msg->buf[i + offset] = FIELD_GET(CDNS_MCP_RESP_RDATA, cdns->response_buf[i]); + if (msg->flags == SDW_MSG_FLAG_READ) { + /* fill response */ + for (i = 0; i < count; i++) + msg->buf[i + offset] = FIELD_GET(CDNS_MCP_RESP_RDATA, + cdns->response_buf[i]); + } return SDW_CMD_OK; } -- 2.30.2

3 2

[PATCH v4 0/5] soundwire: Fixes for spurious and missing UNATTACH
by Richard Fitzgerald 20 Sep '22

20 Sep '22

The bus and cadence code has several bugs that cause UNATTACH notifications to either be sent spuriously or to be missed. These can be seen occasionally with a single peripheral on the bus, but are much more frequent with multiple peripherals, where several peripherals could change state and report in consecutive PINGs. The root of all of these bugs seems to be a code design flaw that assumed every PING status change would be handled separately. However, PINGs are handled by a workqueue function and there is no guarantee when that function will be scheduled to run or how much CPU time it will receive. PINGs will continue while the work function is handling a snapshot of a previous PING so the code must take account that (a) status could change during the work function and (b) there can be a backlog of changes before the IRQ work function runs again. Tested with 4 peripherals on 1 bus, and 8 peripherals on 2 buses. CHANGES SINCE V3: Fixed minor comment typo in patch #4. Richard Fitzgerald (4): soundwire: bus: Don't lose unattach notifications soundwire: bus: Don't re-enumerate before status is UNATTACHED soundwire: cadence: Fix lost ATTACHED interrupts when enumerating soundwire: bus: Don't exit early if no device IDs were programmed Simon Trimmer (1): soundwire: cadence: fix updating slave status when a bus has multiple peripherals drivers/soundwire/bus.c | 44 +++++++++++++--- drivers/soundwire/cadence_master.c | 80 ++++++++++++++++-------------- 2 files changed, 80 insertions(+), 44 deletions(-) -- 2.30.2

2 6

[PATCH 1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe
by Mikhail Rudenko 20 Sep '22

20 Sep '22

In the case when a codec device is probed before codec analog controls, snd_soc_register_card() returns -EPROBE_DEFER, resulting in a misleading error message sun4i-codec 1c22c00.codec: Failed to register our card even if the device is probed successfully later. Use dev_err_probe() to demote the above error to a debug message. Signed-off-by: Mikhail Rudenko <mike.rudenko(a)gmail.com> --- sound/soc/sunxi/sun4i-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 60712f24ade5..01b461c64d68 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -1825,7 +1825,7 @@ static int sun4i_codec_probe(struct platform_device *pdev) ret = snd_soc_register_card(card); if (ret) { - dev_err(&pdev->dev, "Failed to register our card\n"); + dev_err_probe(&pdev->dev, ret, "Failed to register our card\n"); goto err_assert_reset; } -- 2.37.3

3 8

[PATCH 1/3] ASoC: rt5682s: Reduce coupling of Micbias and Vref2 settings
by derek.fang＠realtek.com 20 Sep '22

20 Sep '22

From: Derek Fang <derek.fang(a)realtek.com> Some parts of rt5682s CCF function are implemented by 'MICBIAS' and 'Vref2' dapm widgets. There is a risk of causing not expected behavior if we mix using dapm and CCF operations in machine specific code. This patch reduces the coupling. Signed-off-by: Derek Fang <derek.fang(a)realtek.com> --- sound/soc/codecs/rt5682s.c | 54 ++++++++++++++++++-------------------- sound/soc/codecs/rt5682s.h | 2 ++ 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index eb47e7cd485a..c5c55d146ddf 100644 --- a/sound/soc/codecs/rt5682s.c +++ b/sound/soc/codecs/rt5682s.c @@ -739,6 +739,7 @@ static void rt5682s_disable_push_button_irq(struct snd_soc_component *component) */ static int rt5682s_headset_detect(struct snd_soc_component *component, int jack_insert) { + struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component); unsigned int val, count; int jack_type = 0; @@ -805,12 +806,10 @@ static int rt5682s_headset_detect(struct snd_soc_component *component, int jack_ snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1, RT5682S_TRIG_JD_MASK, RT5682S_TRIG_JD_LOW); - if (!snd_soc_dapm_get_pin_status(&component->dapm, "MICBIAS")) - snd_soc_component_update_bits(component, - RT5682S_PWR_ANLG_1, RT5682S_PWR_MB, 0); - if (!snd_soc_dapm_get_pin_status(&component->dapm, "Vref2")) + if (!rt5682s->wclk_enabled) { snd_soc_component_update_bits(component, - RT5682S_PWR_ANLG_1, RT5682S_PWR_VREF2, 0); + RT5682S_PWR_ANLG_1, RT5682S_PWR_VREF2 | RT5682S_PWR_MB, 0); + } snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_3, RT5682S_PWR_CBJ, 0); @@ -845,6 +844,7 @@ static void rt5682s_jack_detect_handler(struct work_struct *work) snd_soc_dapm_mutex_lock(dapm); mutex_lock(&rt5682s->calibrate_mutex); + mutex_lock(&rt5682s->wclk_mutex); val = snd_soc_component_read(rt5682s->component, RT5682S_AJD1_CTRL) & RT5682S_JDH_RS_MASK; @@ -900,6 +900,7 @@ static void rt5682s_jack_detect_handler(struct work_struct *work) rt5682s->irq_work_delay_time = 50; } + mutex_unlock(&rt5682s->wclk_mutex); mutex_unlock(&rt5682s->calibrate_mutex); snd_soc_dapm_mutex_unlock(dapm); @@ -1218,13 +1219,9 @@ static int set_dmic_power(struct snd_soc_dapm_widget *w, break; case SND_SOC_DAPM_POST_PMD: - if (!rt5682s->jack_type) { - if (!snd_soc_dapm_get_pin_status(w->dapm, "MICBIAS")) - snd_soc_component_update_bits(component, - RT5682S_PWR_ANLG_1, RT5682S_PWR_MB, 0); - if (!snd_soc_dapm_get_pin_status(w->dapm, "Vref2")) - snd_soc_component_update_bits(component, - RT5682S_PWR_ANLG_1, RT5682S_PWR_VREF2, 0); + if (!rt5682s->jack_type && !rt5682s->wclk_enabled) { + snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1, + RT5682S_PWR_VREF2 | RT5682S_PWR_MB, 0); } break; } @@ -1615,8 +1612,6 @@ static const struct snd_soc_dapm_widget rt5682s_dapm_widgets[] = { RT5682S_PWR_LDO_MB2_BIT, 0, NULL, 0), SND_SOC_DAPM_SUPPLY("LDO", RT5682S_PWR_ANLG_3, RT5682S_PWR_LDO_BIT, 0, NULL, 0), - SND_SOC_DAPM_SUPPLY("Vref2", SND_SOC_NOPM, 0, 0, NULL, 0), - SND_SOC_DAPM_SUPPLY("MICBIAS", SND_SOC_NOPM, 0, 0, NULL, 0), /* PLL Powers */ SND_SOC_DAPM_SUPPLY_S("PLLA_LDO", 0, RT5682S_PWR_ANLG_3, @@ -2469,19 +2464,21 @@ static int rt5682s_wclk_prepare(struct clk_hw *hw) if (!rt5682s_clk_check(rt5682s)) return -EINVAL; - snd_soc_dapm_mutex_lock(dapm); - - snd_soc_dapm_force_enable_pin_unlocked(dapm, "MICBIAS"); - snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1, - RT5682S_PWR_MB, RT5682S_PWR_MB); + mutex_lock(&rt5682s->wclk_mutex); - snd_soc_dapm_force_enable_pin_unlocked(dapm, "Vref2"); snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1, - RT5682S_PWR_VREF2 | RT5682S_PWR_FV2, RT5682S_PWR_VREF2); + RT5682S_PWR_VREF2 | RT5682S_PWR_FV2 | RT5682S_PWR_MB, + RT5682S_PWR_VREF2 | RT5682S_PWR_MB); usleep_range(15000, 20000); snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1, RT5682S_PWR_FV2, RT5682S_PWR_FV2); + rt5682s->wclk_enabled = 1; + + mutex_unlock(&rt5682s->wclk_mutex); + + snd_soc_dapm_mutex_lock(dapm); + snd_soc_dapm_force_enable_pin_unlocked(dapm, "I2S1"); /* Only need to power PLLB due to the rate set restriction */ snd_soc_dapm_force_enable_pin_unlocked(dapm, "PLLB"); @@ -2502,14 +2499,18 @@ static void rt5682s_wclk_unprepare(struct clk_hw *hw) if (!rt5682s_clk_check(rt5682s)) return; - snd_soc_dapm_mutex_lock(dapm); + mutex_lock(&rt5682s->wclk_mutex); - snd_soc_dapm_disable_pin_unlocked(dapm, "MICBIAS"); - snd_soc_dapm_disable_pin_unlocked(dapm, "Vref2"); if (!rt5682s->jack_type) snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1, RT5682S_PWR_VREF2 | RT5682S_PWR_FV2 | RT5682S_PWR_MB, 0); + rt5682s->wclk_enabled = 0; + + mutex_unlock(&rt5682s->wclk_mutex); + + snd_soc_dapm_mutex_lock(dapm); + snd_soc_dapm_disable_pin_unlocked(dapm, "I2S1"); snd_soc_dapm_disable_pin_unlocked(dapm, "PLLB"); snd_soc_dapm_sync_unlocked(dapm); @@ -2805,7 +2806,6 @@ static inline int rt5682s_dai_probe_clks(struct snd_soc_component *component) static int rt5682s_probe(struct snd_soc_component *component) { struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component); - struct snd_soc_dapm_context *dapm = &component->dapm; int ret; rt5682s->component = component; @@ -2814,9 +2814,6 @@ static int rt5682s_probe(struct snd_soc_component *component) if (ret) return ret; - snd_soc_dapm_disable_pin(dapm, "MICBIAS"); - snd_soc_dapm_disable_pin(dapm, "Vref2"); - snd_soc_dapm_sync(dapm); return 0; } @@ -3113,6 +3110,7 @@ static int rt5682s_i2c_probe(struct i2c_client *i2c) mutex_init(&rt5682s->calibrate_mutex); mutex_init(&rt5682s->sar_mutex); + mutex_init(&rt5682s->wclk_mutex); rt5682s_calibrate(rt5682s); regmap_update_bits(rt5682s->regmap, RT5682S_MICBIAS_2, diff --git a/sound/soc/codecs/rt5682s.h b/sound/soc/codecs/rt5682s.h index 7353831c73dd..824dc6543c18 100644 --- a/sound/soc/codecs/rt5682s.h +++ b/sound/soc/codecs/rt5682s.h @@ -1450,6 +1450,7 @@ struct rt5682s_priv { struct delayed_work jd_check_work; struct mutex calibrate_mutex; struct mutex sar_mutex; + struct mutex wclk_mutex; #ifdef CONFIG_COMMON_CLK struct clk_hw dai_clks_hw[RT5682S_DAI_NUM_CLKS]; @@ -1469,6 +1470,7 @@ struct rt5682s_priv { int jack_type; int irq_work_delay_time; + int wclk_enabled; }; int rt5682s_sel_asrc_clk_src(struct snd_soc_component *component, -- 2.17.1

2 3

[PATCH v10 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
by Ban Tao 20 Sep '22

20 Sep '22

DT binding documentation for this new ASoC driver. Signed-off-by: Ban Tao <fengzheng923(a)gmail.com> Reviewed-by: Rob Herring <robh(a)kernel.org> Reviewed-by: Maxime Ripard <maxime(a)cerno.tech> --- v1->v2: 1.Fix some build errors. v2->v3: 1.Fix some build errors. v3->v4: 1.None. v4->v5: 1.Add interrupt. 2.Keep clock and reset index. v5->v6: 1.None. v6->v7: 1.None. v7->v8: 1.Fix some build errors. v8->v9: 1.None. v9->v10: 1.Put compatible first in the list of properties. --- .../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml new file mode 100644 index 0000000..2f12cab --- /dev/null +++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner H6 DMIC + +maintainers: + - Ban Tao <fengzheng923(a)gmail.com> + +properties: + compatible: + const: allwinner,sun50i-h6-dmic + + "#sound-dai-cells": + const: 0 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: Bus Clock + - description: Module Clock + + clock-names: + items: + - const: bus + - const: mod + + dmas: + items: + - description: RX DMA Channel + + dma-names: + items: + - const: rx + + resets: + maxItems: 1 + +required: + - "#sound-dai-cells" + - compatible + - reg + - interrupts + - clocks + - clock-names + - dmas + - dma-names + - resets + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + #include <dt-bindings/clock/sun50i-h6-ccu.h> + #include <dt-bindings/reset/sun50i-h6-ccu.h> + + dmic: dmic@5095000 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun50i-h6-dmic"; + reg = <0x05095000 0x400>; + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>; + clock-names = "bus", "mod"; + dmas = <&dma 7>; + dma-names = "rx"; + resets = <&ccu RST_BUS_DMIC>; + }; + +... -- 2.7.4

2 1

[PATCH v10 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver
by Ban Tao 20 Sep '22

20 Sep '22

The Allwinner H6 and later SoCs have an DMIC block which is capable of capture. Signed-off-by: Ban Tao <fengzheng923(a)gmail.com> Tested-by: Samuel Holland <samuel(a)sholland.org> --- v1->v2: 1.Fix some compilation errors. 2.Modify some code styles. v2->v3: None. v3->v4: 1.add sig_bits. v4->v5: None. v5->v6: 1.Modify RXFIFO_CTL_MODE to mode 1. v6->v7: 1.Modify dmic_rate_s to be a global variable. 2.Changed some macro names to make more sense. 3.Align code format. 4.Add a depends on PM to Kconfig entry. v7->v8: None. v8->v9: 1.Modified Kconfig. 2.Added a comment. v9->v10: None. --- MAINTAINERS | 7 + sound/soc/sunxi/Kconfig | 7 + sound/soc/sunxi/Makefile | 1 + sound/soc/sunxi/sun50i-dmic.c | 406 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 421 insertions(+) create mode 100644 sound/soc/sunxi/sun50i-dmic.c diff --git a/MAINTAINERS b/MAINTAINERS index e9d5b05..839f625 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -796,6 +796,13 @@ L: linux-media(a)vger.kernel.org S: Maintained F: drivers/staging/media/sunxi/cedrus/ +ALLWINNER DMIC DRIVERS +M: Ban Tao <fengzheng923(a)gmail.com> +L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml +F: sound/soc/sunxi/sun50i-dmic.c + ALPHA PORT M: Richard Henderson <rth(a)twiddle.net> M: Ivan Kokshaysky <ink(a)jurassic.park.msu.ru> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig index ddcaaa9..1f18f01 100644 --- a/sound/soc/sunxi/Kconfig +++ b/sound/soc/sunxi/Kconfig @@ -56,6 +56,13 @@ config SND_SUN4I_SPDIF Say Y or M to add support for the S/PDIF audio block in the Allwinner A10 and affiliated SoCs. +config SND_SUN50I_DMIC + tristate "Allwinner H6 DMIC Support" + select SND_SOC_GENERIC_DMAENGINE_PCM + help + Say Y or M to add support for the DMIC audio block in the Allwinner + H6 and affiliated SoCs. + config SND_SUN8I_ADDA_PR_REGMAP tristate select REGMAP diff --git a/sound/soc/sunxi/Makefile b/sound/soc/sunxi/Makefile index a86be34..4483fe9 100644 --- a/sound/soc/sunxi/Makefile +++ b/sound/soc/sunxi/Makefile @@ -6,3 +6,4 @@ obj-$(CONFIG_SND_SUN8I_CODEC_ANALOG) += sun8i-codec-analog.o obj-$(CONFIG_SND_SUN50I_CODEC_ANALOG) += sun50i-codec-analog.o obj-$(CONFIG_SND_SUN8I_CODEC) += sun8i-codec.o obj-$(CONFIG_SND_SUN8I_ADDA_PR_REGMAP) += sun8i-adda-pr-regmap.o +obj-$(CONFIG_SND_SUN50I_DMIC) += sun50i-dmic.o diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c new file mode 100644 index 0000000..cd3c07f --- /dev/null +++ b/sound/soc/sunxi/sun50i-dmic.c @@ -0,0 +1,406 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +// +// This driver supports the DMIC in Allwinner's H6 SoCs. +// +// Copyright 2021 Ban Tao <fengzheng923(a)gmail.com> + +#include <linux/clk.h> +#include <linux/device.h> +#include <linux/of_device.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> +#include <linux/reset.h> +#include <sound/dmaengine_pcm.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> + +#define SUN50I_DMIC_EN_CTL (0x00) + #define SUN50I_DMIC_EN_CTL_GLOBE BIT(8) + #define SUN50I_DMIC_EN_CTL_CHAN(v) ((v) << 0) + #define SUN50I_DMIC_EN_CTL_CHAN_MASK GENMASK(7, 0) +#define SUN50I_DMIC_SR (0x04) + #define SUN50I_DMIC_SR_SAMPLE_RATE(v) ((v) << 0) + #define SUN50I_DMIC_SR_SAMPLE_RATE_MASK GENMASK(2, 0) +#define SUN50I_DMIC_CTL (0x08) + #define SUN50I_DMIC_CTL_OVERSAMPLE_RATE BIT(0) +#define SUN50I_DMIC_DATA (0x10) +#define SUN50I_DMIC_INTC (0x14) + #define SUN50I_DMIC_FIFO_DRQ_EN BIT(2) +#define SUN50I_DMIC_INT_STA (0x18) + #define SUN50I_DMIC_INT_STA_OVERRUN_IRQ_PENDING BIT(1) + #define SUN50I_DMIC_INT_STA_DATA_IRQ_PENDING BIT(0) +#define SUN50I_DMIC_RXFIFO_CTL (0x1c) + #define SUN50I_DMIC_RXFIFO_CTL_FLUSH BIT(31) + #define SUN50I_DMIC_RXFIFO_CTL_MODE_MASK BIT(9) + #define SUN50I_DMIC_RXFIFO_CTL_MODE_LSB (0 << 9) + #define SUN50I_DMIC_RXFIFO_CTL_MODE_MSB (1 << 9) + #define SUN50I_DMIC_RXFIFO_CTL_SAMPLE_MASK BIT(8) + #define SUN50I_DMIC_RXFIFO_CTL_SAMPLE_16 (0 << 8) + #define SUN50I_DMIC_RXFIFO_CTL_SAMPLE_24 (1 << 8) +#define SUN50I_DMIC_CH_NUM (0x24) + #define SUN50I_DMIC_CH_NUM_N(v) ((v) << 0) + #define SUN50I_DMIC_CH_NUM_N_MASK GENMASK(2, 0) +#define SUN50I_DMIC_CNT (0x2c) + #define SUN50I_DMIC_CNT_N (1 << 0) +#define SUN50I_DMIC_HPF_CTRL (0x38) +#define SUN50I_DMIC_VERSION (0x50) + +struct sun50i_dmic_dev { + struct clk *dmic_clk; + struct clk *bus_clk; + struct reset_control *rst; + struct regmap *regmap; + struct snd_dmaengine_dai_dma_data dma_params_rx; +}; + +struct dmic_rate { + unsigned int samplerate; + unsigned int rate_bit; +}; + +const static struct dmic_rate dmic_rate_s[] = { + {48000, 0x0}, + {44100, 0x0}, + {32000, 0x1}, + {24000, 0x2}, + {22050, 0x2}, + {16000, 0x3}, + {12000, 0x4}, + {11025, 0x4}, + {8000, 0x5}, +}; + +static int sun50i_dmic_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *cpu_dai) +{ + struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(asoc_rtd_to_cpu(rtd, 0)); + + /* only support capture */ + if (substream->stream != SNDRV_PCM_STREAM_CAPTURE) + return -EINVAL; + + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_FLUSH, + SUN50I_DMIC_RXFIFO_CTL_FLUSH); + regmap_write(host->regmap, SUN50I_DMIC_CNT, SUN50I_DMIC_CNT_N); + + return 0; +} + +static int sun50i_dmic_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct snd_soc_dai *cpu_dai) +{ + int i = 0; + unsigned long rate = params_rate(params); + unsigned int mclk = 0; + unsigned int channels = params_channels(params); + unsigned int chan_en = (1 << channels) - 1; + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(cpu_dai); + + /* DMIC num is N+1 */ + regmap_update_bits(host->regmap, SUN50I_DMIC_CH_NUM, + SUN50I_DMIC_CH_NUM_N_MASK, + SUN50I_DMIC_CH_NUM_N(channels - 1)); + regmap_write(host->regmap, SUN50I_DMIC_HPF_CTRL, chan_en); + regmap_update_bits(host->regmap, SUN50I_DMIC_EN_CTL, + SUN50I_DMIC_EN_CTL_CHAN_MASK, + SUN50I_DMIC_EN_CTL_CHAN(chan_en)); + + switch (params_format(params)) { + case SNDRV_PCM_FORMAT_S16_LE: + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_MASK, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_16); + break; + case SNDRV_PCM_FORMAT_S24_LE: + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_MASK, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_24); + break; + default: + dev_err(cpu_dai->dev, "Invalid format!\n"); + return -EINVAL; + } + /* The hardware supports FIFO mode 1 for 24-bit samples */ + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_MODE_MASK, + SUN50I_DMIC_RXFIFO_CTL_MODE_MSB); + + switch (rate) { + case 11025: + case 22050: + case 44100: + mclk = 22579200; + break; + case 8000: + case 12000: + case 16000: + case 24000: + case 32000: + case 48000: + mclk = 24576000; + break; + default: + dev_err(cpu_dai->dev, "Invalid rate!\n"); + return -EINVAL; + } + + if (clk_set_rate(host->dmic_clk, mclk)) { + dev_err(cpu_dai->dev, "mclk : %u not support\n", mclk); + return -EINVAL; + } + + for (i = 0; i < ARRAY_SIZE(dmic_rate_s); i++) { + if (dmic_rate_s[i].samplerate == rate) { + regmap_update_bits(host->regmap, SUN50I_DMIC_SR, + SUN50I_DMIC_SR_SAMPLE_RATE_MASK, + SUN50I_DMIC_SR_SAMPLE_RATE(dmic_rate_s[i].rate_bit)); + break; + } + } + + switch (params_physical_width(params)) { + case 16: + host->dma_params_rx.addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; + break; + case 32: + host->dma_params_rx.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; + break; + default: + dev_err(cpu_dai->dev, "Unsupported physical sample width: %d\n", + params_physical_width(params)); + return -EINVAL; + } + + /* oversamplerate adjust */ + if (params_rate(params) >= 24000) + regmap_update_bits(host->regmap, SUN50I_DMIC_CTL, + SUN50I_DMIC_CTL_OVERSAMPLE_RATE, + SUN50I_DMIC_CTL_OVERSAMPLE_RATE); + else + regmap_update_bits(host->regmap, SUN50I_DMIC_CTL, + SUN50I_DMIC_CTL_OVERSAMPLE_RATE, 0); + + return 0; +} + +static int sun50i_dmic_trigger(struct snd_pcm_substream *substream, int cmd, + struct snd_soc_dai *dai) +{ + int ret = 0; + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(dai); + + if (substream->stream != SNDRV_PCM_STREAM_CAPTURE) + return -EINVAL; + + switch (cmd) { + case SNDRV_PCM_TRIGGER_START: + case SNDRV_PCM_TRIGGER_RESUME: + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: + /* DRQ ENABLE */ + regmap_update_bits(host->regmap, SUN50I_DMIC_INTC, + SUN50I_DMIC_FIFO_DRQ_EN, + SUN50I_DMIC_FIFO_DRQ_EN); + /* Global enable */ + regmap_update_bits(host->regmap, SUN50I_DMIC_EN_CTL, + SUN50I_DMIC_EN_CTL_GLOBE, + SUN50I_DMIC_EN_CTL_GLOBE); + break; + case SNDRV_PCM_TRIGGER_STOP: + case SNDRV_PCM_TRIGGER_SUSPEND: + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: + /* DRQ DISABLE */ + regmap_update_bits(host->regmap, SUN50I_DMIC_INTC, + SUN50I_DMIC_FIFO_DRQ_EN, 0); + /* Global disable */ + regmap_update_bits(host->regmap, SUN50I_DMIC_EN_CTL, + SUN50I_DMIC_EN_CTL_GLOBE, 0); + break; + default: + ret = -EINVAL; + break; + } + return ret; +} + +static int sun50i_dmic_soc_dai_probe(struct snd_soc_dai *dai) +{ + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(dai); + + snd_soc_dai_init_dma_data(dai, NULL, &host->dma_params_rx); + + return 0; +} + +static const struct snd_soc_dai_ops sun50i_dmic_dai_ops = { + .startup = sun50i_dmic_startup, + .trigger = sun50i_dmic_trigger, + .hw_params = sun50i_dmic_hw_params, +}; + +static const struct regmap_config sun50i_dmic_regmap_config = { + .reg_bits = 32, + .reg_stride = 4, + .val_bits = 32, + .max_register = SUN50I_DMIC_VERSION, + .cache_type = REGCACHE_NONE, +}; + +#define SUN50I_DMIC_RATES (SNDRV_PCM_RATE_8000_48000) +#define SUN50I_DMIC_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE) + +static struct snd_soc_dai_driver sun50i_dmic_dai = { + .capture = { + .channels_min = 1, + .channels_max = 8, + .rates = SUN50I_DMIC_RATES, + .formats = SUN50I_DMIC_FORMATS, + .sig_bits = 21, + }, + .probe = sun50i_dmic_soc_dai_probe, + .ops = &sun50i_dmic_dai_ops, + .name = "dmic", +}; + +static const struct of_device_id sun50i_dmic_of_match[] = { + { + .compatible = "allwinner,sun50i-h6-dmic", + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, sun50i_dmic_of_match); + +static const struct snd_soc_component_driver sun50i_dmic_component = { + .name = "sun50i-dmic", +}; + +static int sun50i_dmic_runtime_suspend(struct device *dev) +{ + struct sun50i_dmic_dev *host = dev_get_drvdata(dev); + + clk_disable_unprepare(host->dmic_clk); + clk_disable_unprepare(host->bus_clk); + + return 0; +} + +static int sun50i_dmic_runtime_resume(struct device *dev) +{ + struct sun50i_dmic_dev *host = dev_get_drvdata(dev); + int ret; + + ret = clk_prepare_enable(host->dmic_clk); + if (ret) + return ret; + + ret = clk_prepare_enable(host->bus_clk); + if (ret) { + clk_disable_unprepare(host->dmic_clk); + return ret; + } + + return 0; +} + +static int sun50i_dmic_probe(struct platform_device *pdev) +{ + struct sun50i_dmic_dev *host; + struct resource *res; + int ret; + void __iomem *base; + + host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); + if (!host) + return -ENOMEM; + + /* Get the addresses */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(base)) + return dev_err_probe(&pdev->dev, PTR_ERR(base), + "get resource failed.\n"); + + host->regmap = devm_regmap_init_mmio(&pdev->dev, base, + &sun50i_dmic_regmap_config); + + /* Clocks */ + host->bus_clk = devm_clk_get(&pdev->dev, "bus"); + if (IS_ERR(host->bus_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->bus_clk), + "failed to get bus clock.\n"); + + host->dmic_clk = devm_clk_get(&pdev->dev, "mod"); + if (IS_ERR(host->dmic_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->dmic_clk), + "failed to get dmic clock.\n"); + + host->dma_params_rx.addr = res->start + SUN50I_DMIC_DATA; + host->dma_params_rx.maxburst = 8; + + platform_set_drvdata(pdev, host); + + host->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); + if (IS_ERR(host->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->rst), + "Failed to get reset.\n"); + reset_control_deassert(host->rst); + + ret = devm_snd_soc_register_component(&pdev->dev, &sun50i_dmic_component, + &sun50i_dmic_dai, 1); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "failed to register component.\n"); + + pm_runtime_enable(&pdev->dev); + if (!pm_runtime_enabled(&pdev->dev)) { + ret = sun50i_dmic_runtime_resume(&pdev->dev); + if (ret) + goto err_disable_runtime_pm; + } + + ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); + if (ret) + goto err_suspend; + + return 0; +err_suspend: + if (!pm_runtime_status_suspended(&pdev->dev)) + sun50i_dmic_runtime_suspend(&pdev->dev); +err_disable_runtime_pm: + pm_runtime_disable(&pdev->dev); + return ret; +} + +static int sun50i_dmic_remove(struct platform_device *pdev) +{ + pm_runtime_disable(&pdev->dev); + if (!pm_runtime_status_suspended(&pdev->dev)) + sun50i_dmic_runtime_suspend(&pdev->dev); + + return 0; +} + +static const struct dev_pm_ops sun50i_dmic_pm = { + SET_RUNTIME_PM_OPS(sun50i_dmic_runtime_suspend, + sun50i_dmic_runtime_resume, NULL) +}; + +static struct platform_driver sun50i_dmic_driver = { + .driver = { + .name = "sun50i-dmic", + .of_match_table = of_match_ptr(sun50i_dmic_of_match), + .pm = &sun50i_dmic_pm, + }, + .probe = sun50i_dmic_probe, + .remove = sun50i_dmic_remove, +}; + +module_platform_driver(sun50i_dmic_driver); + +MODULE_DESCRIPTION("Allwinner sun50i DMIC SoC Interface"); +MODULE_AUTHOR("Ban Tao <fengzheng923(a)gmail.com>"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:sun50i-dmic"); -- 2.7.4

2 1

[PATCH] ASoC: soc-core.c: setup rtd->pmdown_time at soc_new_pcm_runtime()
by Kuninori Morimoto 20 Sep '22

20 Sep '22

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Almost all default rtd->xxx are setup at soc_new_pcm_runtime() which is sub-function of snd_soc_add_pcm_runtime() (A). But "rtd->pmdown_time" is setup at soc_init_pcm_runtime() (B). It is very random timing setup. This patch setup it at (A), same as other rtd->xxx. static int snd_soc_bind_card(...) { ... for_each_card_prelinks(...) { (A) ret = snd_soc_add_pcm_runtime(...); ... } ... for_each_card_rtds(...) { (B) ret = soc_init_pcm_runtime(...); ... } ... } One note is that current topology/intel are directly calling snd_soc_add_pcm_runtime() (A) without calling soc_init_pcm_runtime() (B). This means, its "rtd->pmdown_time settings" was 0, but will have default value by this patch. "rtd->pmdown_time settings" will be used at snd_soc_runtime_ignore_pmdown_time(). This patch adds "ignore_pmdown_time" to these driver to keep compatibility. bool snd_soc_runtime_ignore_pmdown_time(...) { ... => if (!rtd->pmdown_time || rtd->dai_link->ignore_pmdown_time) return true; ... } Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/intel/avs/boards/hdaudio.c | 1 + sound/soc/soc-core.c | 4 +--- sound/soc/soc-topology.c | 1 + 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/avs/boards/hdaudio.c b/sound/soc/intel/avs/boards/hdaudio.c index d2fc41d39448..073663ba140d 100644 --- a/sound/soc/intel/avs/boards/hdaudio.c +++ b/sound/soc/intel/avs/boards/hdaudio.c @@ -42,6 +42,7 @@ static int avs_create_dai_links(struct device *dev, struct hda_codec *codec, int dl[i].dpcm_capture = 1; dl[i].platforms = platform; dl[i].num_platforms = 1; + dl[i].ignore_pmdown_time = 1; dl[i].codecs = devm_kzalloc(dev, sizeof(*dl->codecs), GFP_KERNEL); dl[i].cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL); diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index e020ab49cfb1..df2bd8098c63 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -487,6 +487,7 @@ static struct snd_soc_pcm_runtime *soc_new_pcm_runtime( rtd->card = card; rtd->dai_link = dai_link; rtd->num = card->num_rtd++; + rtd->pmdown_time = pmdown_time; /* default power off timeout */ /* see for_each_card_rtds */ list_add_tail(&rtd->list, &card->rtd_list); @@ -1247,9 +1248,6 @@ static int soc_init_pcm_runtime(struct snd_soc_card *card, struct snd_soc_component *component; int ret, num, i; - /* set default power off timeout */ - rtd->pmdown_time = pmdown_time; - /* do machine specific initialization */ ret = snd_soc_link_init(rtd); if (ret < 0) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index b101db85446f..c3be24b2fac5 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -1755,6 +1755,7 @@ static int soc_tplg_fe_link_create(struct soc_tplg *tplg, /* enable DPCM */ link->dynamic = 1; + link->ignore_pmdown_time = 1; link->dpcm_playback = le32_to_cpu(pcm->playback); link->dpcm_capture = le32_to_cpu(pcm->capture); if (pcm->flag_mask) -- 2.25.1

2 1

[PATCH v2] ASoC: fsl_spdif: add ALSA event on dpll locked
by Robert Rosengren 20 Sep '22

20 Sep '22

Add an ALSA event on the RX Sample Rate controller upon the dpll locked interrupt, making it possible for audio applications to monitor changes in the hardware. Signed-off-by: Robert Rosengren <robert.rosengren(a)axis.com> --- Notes: v2: Cache RX Sample Rate kcontrol to avoid lookup in interrupt. Properly add description to fsl_spdif_priv. Fix indentation. sound/soc/fsl/fsl_spdif.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 7fc1c96929bb..275aba8e0c46 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -44,6 +44,8 @@ static u8 srpc_dpll_locked[] = { 0x0, 0x1, 0x2, 0x3, 0x4, 0xa, 0xb }; #define DEFAULT_RXCLK_SRC 1 +#define RX_SAMPLE_RATE_KCONTROL "RX Sample Rate" + /** * struct fsl_spdif_soc_data: soc specific data * @@ -98,6 +100,8 @@ struct spdif_mixer_control { * @soc: SPDIF soc data * @fsl_spdif_control: SPDIF control data * @cpu_dai_drv: cpu dai driver + * @snd_card: sound card pointer + * @rxrate_kcontrol: kcontrol for RX Sample Rate * @pdev: platform device pointer * @regmap: regmap handler * @dpll_locked: dpll lock flag @@ -122,6 +126,8 @@ struct fsl_spdif_priv { const struct fsl_spdif_soc_data *soc; struct spdif_mixer_control fsl_spdif_control; struct snd_soc_dai_driver cpu_dai_drv; + struct snd_card *snd_card; + struct snd_kcontrol *rxrate_kcontrol; struct platform_device *pdev; struct regmap *regmap; bool dpll_locked; @@ -226,6 +232,12 @@ static void spdif_irq_dpll_lock(struct fsl_spdif_priv *spdif_priv) locked ? "locked" : "loss lock"); spdif_priv->dpll_locked = locked ? true : false; + + if (spdif_priv->snd_card && spdif_priv->rxrate_kcontrol) { + snd_ctl_notify(spdif_priv->snd_card, + SNDRV_CTL_EVENT_MASK_VALUE, + &spdif_priv->rxrate_kcontrol->id); + } } /* Receiver found illegal symbol interrupt handler */ @@ -1197,7 +1209,7 @@ static struct snd_kcontrol_new fsl_spdif_ctrls[] = { /* DPLL lock info get controller */ { .iface = SNDRV_CTL_ELEM_IFACE_PCM, - .name = "RX Sample Rate", + .name = RX_SAMPLE_RATE_KCONTROL, .access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE, .info = fsl_spdif_rxrate_info, @@ -1251,6 +1263,13 @@ static int fsl_spdif_dai_probe(struct snd_soc_dai *dai) snd_soc_add_dai_controls(dai, fsl_spdif_ctrls_rcm, ARRAY_SIZE(fsl_spdif_ctrls_rcm)); + spdif_private->snd_card = dai->component->card->snd_card; + spdif_private->rxrate_kcontrol = snd_soc_card_get_kcontrol(dai->component->card, + RX_SAMPLE_RATE_KCONTROL); + if (!spdif_private->rxrate_kcontrol) + dev_err(&spdif_private->pdev->dev, "failed to get %s kcontrol\n", + RX_SAMPLE_RATE_KCONTROL); + /*Clear the val bit for Tx*/ regmap_update_bits(spdif_private->regmap, REG_SPDIF_SCR, SCR_VAL_MASK, SCR_VAL_CLEAR); -- 2.30.2

3 2

[PATCH v5 0/5] ASoC: qcom: add support for sc8280xp machine
by Srinivas Kandagatla 20 Sep '22

20 Sep '22

This patchset adds support for SC8280XP SoC machine driver. First patch moves some of the commonly used code to common from sm8250 machine driver and the follow on code adds minimal support for sc8280xp. Currently this driver is only tested with SmartSpeakers and Headset on Lenovo Thinkpad X13s. Support for sm8450 is tested and I will post the patches soon. Thanks, Srini Changes since v4: - fixed typo in commit log - sorted compatible strings before adding new ones. Srinivas Kandagatla (5): ASoC: qcom: common: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL ASoC: dt-bindings: qcom: sort compatible strings ASoC: dt-bindings: qcom,sm8250: add compatibles for sm8450 and sm8250 ASoC: qcom: sm8250: move some code to common ASoC: qcom: add machine driver for sc8280xp .../bindings/sound/qcom,sm8250.yaml | 4 +- sound/soc/qcom/Kconfig | 12 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/common.c | 173 +++++++++++++++++- sound/soc/qcom/common.h | 35 ++++ sound/soc/qcom/sc8280xp.c | 157 ++++++++++++++++ sound/soc/qcom/sm8250.c | 152 +-------------- 7 files changed, 388 insertions(+), 147 deletions(-) create mode 100644 sound/soc/qcom/sc8280xp.c -- 2.21.0

3 7

[PATCH] ALSA: intel-dspconfig: add ES8336 support for AlderLake-PS
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

From: Muralidhar Reddy <muralidhar.reddy(a)intel.com> added quirks for ESS8336 for AlderLake-PS Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Signed-off-by: Muralidhar Reddy <muralidhar.reddy(a)intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/hda/intel-dsp-config.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c index d84ffdf47210e..1997ffc16663a 100644 --- a/sound/hda/intel-dsp-config.c +++ b/sound/hda/intel-dsp-config.c @@ -427,6 +427,11 @@ static const struct config_entry config_table[] = { .device = 0x51cd, }, /* Alderlake-PS */ + { + .flags = FLAG_SOF, + .device = 0x51c9, + .codec_hid = &essx_83x6, + }, { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = 0x51c9, -- 2.34.1

2 1

[PATCH] ASOC: SOF: pci: Change DMI match info to support all Chrome platforms
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

From: Jairaj Arava <jairaj.arava(a)intel.com> In some Chrome platforms if OEM's use their own string as SYS_VENDOR than "Google", it leads to firmware load failure from intel/sof/community path. Hence, changing SYS_VENDOR to PRODUCT_FAMILY in which "Google" is used as common prefix and is supported in all Chrome platforms. Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Chao Song <chao.song(a)intel.com> Reviewed-by: Curtis Malainey <curtis(a)malainey.com> Signed-off-by: Jairaj Arava <jairaj.arava(a)intel.com> Signed-off-by: Curtis Malainey <cujomalainey(a)chromium.org> Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/sof/sof-pci-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c index d627092b399d7..643fd1036d60b 100644 --- a/sound/soc/sof/sof-pci-dev.c +++ b/sound/soc/sof/sof-pci-dev.c @@ -138,7 +138,7 @@ static const struct dmi_system_id community_key_platforms[] = { .ident = "Google Chromebooks", .callback = chromebook_use_community_key, .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Google"), + DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"), } }, {}, -- 2.34.1

2 1

[PATCH 0/7] ASoC: SOF: start using tracing instead of dev_dbg
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

Multiple maintainers have told us to start using the tracing subsystem. Wish granted, this patchset suggested by Noah Klayman removes a number of verbose and arguably useless dev_dbg or dev_vdbg logs. Beyond higher efficiency and less intrusive instrumentation, the use of bpftrace scripts bring new functionality and helps gather statistics on usage count on a running system, see how we can get information on suspend/resume times with [1] [1] https://github.com/thesofproject/sof-test/blob/main/kernel_tracing/bpftrace… Bard Liao (2): ASoC: SOF: add widget setup/free tracing ASoC: SOF: Intel: replace dev_vdbg with tracepoints Noah Klayman (5): ASoC: SOF: Intel: add HDA interrupt source tracing ASoC: SOF: Intel: remove unneeded dev_vdbg ASoC: SOF: remove unneeded dev_vdbg ASoC: SOF: replace dev_vdbg with tracepoints ASoC: SOF: replace ipc4-loader dev_vdbg with tracepoints include/trace/events/sof.h | 121 +++++++++++++++++++++++++ include/trace/events/sof_intel.h | 148 +++++++++++++++++++++++++++++++ sound/soc/sof/core.c | 3 + sound/soc/sof/intel/cnl.c | 9 +- sound/soc/sof/intel/hda-dsp.c | 4 +- sound/soc/sof/intel/hda-ipc.c | 11 +-- sound/soc/sof/intel/hda-pcm.c | 4 +- sound/soc/sof/intel/hda-stream.c | 9 +- sound/soc/sof/intel/hda.c | 19 +++- sound/soc/sof/intel/mtl.c | 3 +- sound/soc/sof/ipc3.c | 12 +-- sound/soc/sof/ipc4-loader.c | 7 +- sound/soc/sof/pcm.c | 5 +- sound/soc/sof/sof-audio.c | 5 ++ sound/soc/sof/sof-utils.c | 2 - sound/soc/sof/topology.c | 9 -- 16 files changed, 320 insertions(+), 51 deletions(-) create mode 100644 include/trace/events/sof.h create mode 100644 include/trace/events/sof_intel.h -- 2.34.1

2 8

[PATCH v2] ASoC: max98390: Fix dsm calibration reading
by Peter Ujfalusi 20 Sep '22

20 Sep '22

With the change introduced by 6ac246105b4f, the calibration can only be done after the codec probe (but questionable if it is working since 203A_AMP_EN is 0) or when the codec is powered up for audio use, in other cases "AMP is not ready to run calibration" is printed. This changes how this worked before the patch: the codec was force powered on for the duration of the calibration readout, then shut down. So, if a calibration was asked when the codec was active, it would have powered it down? To correct the calibration logic: check if the codec is powered on and if it is not then enable it, do the readout and put it back to disabled. Do this while keeping the dapm locked to avoid interfering with normal operation via DAPM. Fixes: 6ac246105b4f ("ASoC: max98390: Remove unnecessary amp on/off conrtol") Reported-by: Fred Oh <fred.oh(a)linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> --- Hi, Changes since v1: - typos corrected in the commit message Regards, Peter sound/soc/codecs/max98390.c | 79 ++++++++++++++++++------------------- 1 file changed, 39 insertions(+), 40 deletions(-) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index 4ef8cd1053af..7a5260ff8d6b 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -161,8 +161,6 @@ static struct reg_default max98390_reg_defaults[] = { {MAX98390_R23FF_GLOBAL_EN, 0x00}, }; -static int max98390_dsm_calibrate(struct snd_soc_component *component); - static int max98390_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) { struct snd_soc_component *component = codec_dai->component; @@ -635,20 +633,49 @@ static int max98390_dsm_calib_get(struct snd_kcontrol *kcontrol, static int max98390_dsm_calib_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - unsigned int val; - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct max98390_priv *max98390 = - snd_soc_component_get_drvdata(component); + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct max98390_priv *max98390 = snd_soc_component_get_drvdata(component); + struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component); + unsigned int rdc, rdc_cal_result, rdc_integer, rdc_factor, temp, val; + + snd_soc_dapm_mutex_lock(dapm); regmap_read(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, &val); - if (val == 0x1) - max98390_dsm_calibrate(component); - else { - dev_err(component->dev, "AMP is not ready to run calibration\n"); - return -ECANCELED; + if (!val) { + /* Enable the codec for the duration of calibration readout */ + regmap_update_bits(max98390->regmap, MAX98390_R203A_AMP_EN, + MAX98390_AMP_EN_MASK, 1); + regmap_update_bits(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, + MAX98390_GLOBAL_EN_MASK, 1); + } + + regmap_read(max98390->regmap, THERMAL_RDC_RD_BACK_BYTE1, &rdc); + regmap_read(max98390->regmap, THERMAL_RDC_RD_BACK_BYTE0, &rdc_cal_result); + regmap_read(max98390->regmap, MAX98390_MEAS_ADC_CH2_READ, &temp); + + if (!val) { + /* Disable the codec if it was disabled */ + regmap_update_bits(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, + MAX98390_GLOBAL_EN_MASK, 0); + regmap_update_bits(max98390->regmap, MAX98390_R203A_AMP_EN, + MAX98390_AMP_EN_MASK, 0); } + snd_soc_dapm_mutex_unlock(dapm); + + rdc_cal_result |= (rdc << 8) & 0x0000FFFF; + if (rdc_cal_result) + max98390->ref_rdc_value = 268435456U / rdc_cal_result; + + max98390->ambient_temp_value = temp * 52 - 1188; + + rdc_integer = rdc_cal_result * 937 / 65536; + rdc_factor = ((rdc_cal_result * 937 * 100) / 65536) - (rdc_integer * 100); + + dev_info(component->dev, + "rdc resistance about %d.%02d ohm, reg=0x%X temp reg=0x%X\n", + rdc_integer, rdc_factor, rdc_cal_result, temp); + return 0; } @@ -828,34 +855,6 @@ static int max98390_dsm_init(struct snd_soc_component *component) return ret; } -static int max98390_dsm_calibrate(struct snd_soc_component *component) -{ - unsigned int rdc, rdc_cal_result, temp; - unsigned int rdc_integer, rdc_factor; - struct max98390_priv *max98390 = - snd_soc_component_get_drvdata(component); - - regmap_read(max98390->regmap, - THERMAL_RDC_RD_BACK_BYTE1, &rdc); - regmap_read(max98390->regmap, - THERMAL_RDC_RD_BACK_BYTE0, &rdc_cal_result); - rdc_cal_result |= (rdc << 8) & 0x0000FFFF; - if (rdc_cal_result) - max98390->ref_rdc_value = 268435456U / rdc_cal_result; - - regmap_read(max98390->regmap, MAX98390_MEAS_ADC_CH2_READ, &temp); - max98390->ambient_temp_value = temp * 52 - 1188; - - rdc_integer = rdc_cal_result * 937 / 65536; - rdc_factor = ((rdc_cal_result * 937 * 100) / 65536) - - (rdc_integer * 100); - - dev_info(component->dev, "rdc resistance about %d.%02d ohm, reg=0x%X temp reg=0x%X\n", - rdc_integer, rdc_factor, rdc_cal_result, temp); - - return 0; -} - static void max98390_init_regs(struct snd_soc_component *component) { struct max98390_priv *max98390 = -- 2.37.3

2 1

[PATCH linux-next] ASoC: Intel: sof_rt5682: use devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/intel/boards/sof_rt5682.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c index 045965312245..1bf9455eaf93 100644 --- a/sound/soc/intel/boards/sof_rt5682.c +++ b/sound/soc/intel/boards/sof_rt5682.c @@ -600,10 +600,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, struct snd_soc_dai_link *links; int i, id = 0; - links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * - sof_audio_card_rt5682.num_links, GFP_KERNEL); - cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) * - sof_audio_card_rt5682.num_links, GFP_KERNEL); + links = devm_kcalloc(dev, sof_audio_card_rt5682.num_links, + sizeof(struct snd_soc_dai_link), GFP_KERNEL); + cpus = devm_kcalloc(dev, sof_audio_card_rt5682.num_links, + sizeof(struct snd_soc_dai_link_component), GFP_KERNEL); if (!links || !cpus) goto devm_err; @@ -687,9 +687,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, /* HDMI */ if (hdmi_num > 0) { - idisp_components = devm_kzalloc(dev, - sizeof(struct snd_soc_dai_link_component) * - hdmi_num, GFP_KERNEL); + idisp_components = devm_kcalloc(dev, + hdmi_num, + sizeof(struct snd_soc_dai_link_component), + GFP_KERNEL); if (!idisp_components) goto devm_err; } -- 2.25.1

3 2

[PATCH linux-next] ASoC: Intel: sof_ssp_amp: use devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/intel/boards/sof_ssp_amp.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sound/soc/intel/boards/sof_ssp_amp.c b/sound/soc/intel/boards/sof_ssp_amp.c index 4a762e002ac7..94d25aeb6e7c 100644 --- a/sound/soc/intel/boards/sof_ssp_amp.c +++ b/sound/soc/intel/boards/sof_ssp_amp.c @@ -210,10 +210,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, struct snd_soc_dai_link *links; int i, id = 0; - links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * - sof_ssp_amp_card.num_links, GFP_KERNEL); - cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) * - sof_ssp_amp_card.num_links, GFP_KERNEL); + links = devm_kcalloc(dev, sof_ssp_amp_card.num_links, + sizeof(struct snd_soc_dai_link), GFP_KERNEL); + cpus = devm_kcalloc(dev, sof_ssp_amp_card.num_links, + sizeof(struct snd_soc_dai_link_component), GFP_KERNEL); if (!links || !cpus) return NULL; @@ -306,9 +306,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, if (sof_ssp_amp_quirk & SOF_HDMI_PLAYBACK_PRESENT) { /* HDMI */ if (hdmi_num > 0) { - idisp_components = devm_kzalloc(dev, - sizeof(struct snd_soc_dai_link_component) * - hdmi_num, GFP_KERNEL); + idisp_components = devm_kcalloc(dev, + hdmi_num, + sizeof(struct snd_soc_dai_link_component), + GFP_KERNEL); if (!idisp_components) goto devm_err; } -- 2.25.1

3 2

[PATCH linux-next] ASOC: SOF: use devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/sof/nocodec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/nocodec.c b/sound/soc/sof/nocodec.c index 356497fe4f4c..3537805070ad 100644 --- a/sound/soc/sof/nocodec.c +++ b/sound/soc/sof/nocodec.c @@ -32,7 +32,7 @@ static int sof_nocodec_bes_setup(struct device *dev, /* set up BE dai_links */ for (i = 0; i < link_num; i++) { - dlc = devm_kzalloc(dev, 3 * sizeof(*dlc), GFP_KERNEL); + dlc = devm_kcalloc(dev, 3, sizeof(*dlc), GFP_KERNEL); if (!dlc) return -ENOMEM; @@ -78,7 +78,7 @@ static int sof_nocodec_setup(struct device *dev, struct snd_soc_dai_link *links; /* create dummy BE dai_links */ - links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * num_dai_drivers, GFP_KERNEL); + links = devm_kcalloc(dev, num_dai_drivers, sizeof(struct snd_soc_dai_link), GFP_KERNEL); if (!links) return -ENOMEM; -- 2.25.1

3 2

[PATCH linux-next] ASoC: Intel: sof_es8336: use function devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/intel/boards/sof_es8336.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/sof_es8336.c b/sound/soc/intel/boards/sof_es8336.c index 606cc3242a60..fbb42e54947a 100644 --- a/sound/soc/intel/boards/sof_es8336.c +++ b/sound/soc/intel/boards/sof_es8336.c @@ -481,9 +481,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, /* HDMI */ if (hdmi_num > 0) { - idisp_components = devm_kzalloc(dev, - sizeof(struct snd_soc_dai_link_component) * - hdmi_num, GFP_KERNEL); + idisp_components = devm_kcalloc(dev, + hdmi_num, + sizeof(struct snd_soc_dai_link_component), + GFP_KERNEL); if (!idisp_components) goto devm_err; } -- 2.25.1

3 2

[PATCH linux-next] ASoC: Intel: sof_nau8825: use function devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/intel/boards/sof_nau8825.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/sound/soc/intel/boards/sof_nau8825.c b/sound/soc/intel/boards/sof_nau8825.c index 8d7e5ba9e516..5585c217f78d 100644 --- a/sound/soc/intel/boards/sof_nau8825.c +++ b/sound/soc/intel/boards/sof_nau8825.c @@ -355,10 +355,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, struct snd_soc_dai_link *links; int i, id = 0; - links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * - sof_audio_card_nau8825.num_links, GFP_KERNEL); - cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) * - sof_audio_card_nau8825.num_links, GFP_KERNEL); + links = devm_kcalloc(dev, sof_audio_card_nau8825.num_links, + sizeof(struct snd_soc_dai_link), GFP_KERNEL); + cpus = devm_kcalloc(dev, sof_audio_card_nau8825.num_links, + sizeof(struct snd_soc_dai_link_component), GFP_KERNEL); if (!links || !cpus) goto devm_err; @@ -421,9 +421,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, /* HDMI */ if (hdmi_num > 0) { - idisp_components = devm_kzalloc(dev, - sizeof(struct snd_soc_dai_link_component) * - hdmi_num, GFP_KERNEL); + idisp_components = devm_kcalloc(dev, + hdmi_num, + sizeof(struct snd_soc_dai_link_component), + GFP_KERNEL); if (!idisp_components) goto devm_err; } -- 2.25.1

3 2

[PATCH linux-next] ASoC: Intel: sof_cs42l42: use function devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/intel/boards/sof_cs42l42.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/intel/boards/sof_cs42l42.c b/sound/soc/intel/boards/sof_cs42l42.c index 85ffd065895d..e38bd2831e6a 100644 --- a/sound/soc/intel/boards/sof_cs42l42.c +++ b/sound/soc/intel/boards/sof_cs42l42.c @@ -445,9 +445,9 @@ static int create_hdmi_dai_links(struct device *dev, if (hdmi_num <= 0) return 0; - idisp_components = devm_kzalloc(dev, - sizeof(struct snd_soc_dai_link_component) * - hdmi_num, GFP_KERNEL); + idisp_components = devm_kcalloc(dev, + hdmi_num, + sizeof(struct snd_soc_dai_link_component), GFP_KERNEL); if (!idisp_components) goto devm_err; @@ -543,10 +543,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, struct snd_soc_dai_link *links; int ret, id = 0, link_seq; - links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * - sof_audio_card_cs42l42.num_links, GFP_KERNEL); - cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) * - sof_audio_card_cs42l42.num_links, GFP_KERNEL); + links = devm_kcalloc(dev, sof_audio_card_cs42l42.num_links, + sizeof(struct snd_soc_dai_link), GFP_KERNEL); + cpus = devm_kcalloc(dev, sof_audio_card_cs42l42.num_links, + sizeof(struct snd_soc_dai_link_component), GFP_KERNEL); if (!links || !cpus) goto devm_err; -- 2.25.1

3 2

[PATCH linux-next] ASoC: amd: acp: use function devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/amd/acp/acp-mach-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c index f0c49127aad1..4c69cb6e3400 100644 --- a/sound/soc/amd/acp/acp-mach-common.c +++ b/sound/soc/amd/acp/acp-mach-common.c @@ -584,7 +584,7 @@ int acp_sofdsp_dai_links_create(struct snd_soc_card *card) if (drv_data->dmic_cpu_id) num_links++; - links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * num_links, GFP_KERNEL); + links = devm_kcalloc(dev, num_links, sizeof(struct snd_soc_dai_link), GFP_KERNEL); if (!links) return -ENOMEM; @@ -749,7 +749,7 @@ int acp_legacy_dai_links_create(struct snd_soc_card *card) if (drv_data->dmic_cpu_id) num_links++; - links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * num_links, GFP_KERNEL); + links = devm_kcalloc(dev, num_links, sizeof(struct snd_soc_dai_link), GFP_KERNEL); if (!links) return -ENOMEM; -- 2.25.1

2 1

[PATCH linux-next] ASoC: amd: acp: use devm_kcalloc() instead of devm_kzalloc()
by cgel.zte＠gmail.com 20 Sep '22

20 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Use 2-factor multiplication argument form devm_kcalloc() instead of devm_kzalloc(). Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/amd/acp/acp-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c index ef2ce083521e..a0c84cd07fde 100644 --- a/sound/soc/amd/acp/acp-pci.c +++ b/sound/soc/amd/acp/acp-pci.c @@ -107,7 +107,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id goto unregister_dmic_dev; } - res = devm_kzalloc(&pci->dev, sizeof(struct resource) * num_res, GFP_KERNEL); + res = devm_kcalloc(&pci->dev, num_res, sizeof(struct resource), GFP_KERNEL); if (!res) { ret = -ENOMEM; goto unregister_dmic_dev; -- 2.25.1

2 1

[PATCH] ASoC: max98390: Fix dsm calibration reading
by Peter Ujfalusi 20 Sep '22

20 Sep '22

With the change introduced by 6ac246105b4f, the calibration can only be done after the codec probe (but questionable if it is working since 203A_AMP_EN is 0) or when the codec is powered up for audio use, in other cases "AMP is not ready to run calibration" is printed. This changes how this worked before the patch: the codec was force powered on for the duration of the calibration readout, then shut down. So, if a calibration was asked when the codec was active, it would have powered it down? To correct the calibration logic: check if the codec is powered on and if it is not then enable it, do the readout and put it back to disabled. Do this while keeping the dapm licked to avoid interfering with normal operation wia DAPM. Fixes: 6ac246105b4f ("ASoC: max98390: Remove unnecessary amp on/off conrtol") Reported-by: Fred Oh <fred.oh(a)linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> --- sound/soc/codecs/max98390.c | 79 ++++++++++++++++++------------------- 1 file changed, 39 insertions(+), 40 deletions(-) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index 4ef8cd1053af..7a5260ff8d6b 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -161,8 +161,6 @@ static struct reg_default max98390_reg_defaults[] = { {MAX98390_R23FF_GLOBAL_EN, 0x00}, }; -static int max98390_dsm_calibrate(struct snd_soc_component *component); - static int max98390_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) { struct snd_soc_component *component = codec_dai->component; @@ -635,20 +633,49 @@ static int max98390_dsm_calib_get(struct snd_kcontrol *kcontrol, static int max98390_dsm_calib_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - unsigned int val; - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct max98390_priv *max98390 = - snd_soc_component_get_drvdata(component); + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct max98390_priv *max98390 = snd_soc_component_get_drvdata(component); + struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component); + unsigned int rdc, rdc_cal_result, rdc_integer, rdc_factor, temp, val; + + snd_soc_dapm_mutex_lock(dapm); regmap_read(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, &val); - if (val == 0x1) - max98390_dsm_calibrate(component); - else { - dev_err(component->dev, "AMP is not ready to run calibration\n"); - return -ECANCELED; + if (!val) { + /* Enable the codec for the duration of calibration readout */ + regmap_update_bits(max98390->regmap, MAX98390_R203A_AMP_EN, + MAX98390_AMP_EN_MASK, 1); + regmap_update_bits(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, + MAX98390_GLOBAL_EN_MASK, 1); + } + + regmap_read(max98390->regmap, THERMAL_RDC_RD_BACK_BYTE1, &rdc); + regmap_read(max98390->regmap, THERMAL_RDC_RD_BACK_BYTE0, &rdc_cal_result); + regmap_read(max98390->regmap, MAX98390_MEAS_ADC_CH2_READ, &temp); + + if (!val) { + /* Disable the codec if it was disabled */ + regmap_update_bits(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, + MAX98390_GLOBAL_EN_MASK, 0); + regmap_update_bits(max98390->regmap, MAX98390_R203A_AMP_EN, + MAX98390_AMP_EN_MASK, 0); } + snd_soc_dapm_mutex_unlock(dapm); + + rdc_cal_result |= (rdc << 8) & 0x0000FFFF; + if (rdc_cal_result) + max98390->ref_rdc_value = 268435456U / rdc_cal_result; + + max98390->ambient_temp_value = temp * 52 - 1188; + + rdc_integer = rdc_cal_result * 937 / 65536; + rdc_factor = ((rdc_cal_result * 937 * 100) / 65536) - (rdc_integer * 100); + + dev_info(component->dev, + "rdc resistance about %d.%02d ohm, reg=0x%X temp reg=0x%X\n", + rdc_integer, rdc_factor, rdc_cal_result, temp); + return 0; } @@ -828,34 +855,6 @@ static int max98390_dsm_init(struct snd_soc_component *component) return ret; } -static int max98390_dsm_calibrate(struct snd_soc_component *component) -{ - unsigned int rdc, rdc_cal_result, temp; - unsigned int rdc_integer, rdc_factor; - struct max98390_priv *max98390 = - snd_soc_component_get_drvdata(component); - - regmap_read(max98390->regmap, - THERMAL_RDC_RD_BACK_BYTE1, &rdc); - regmap_read(max98390->regmap, - THERMAL_RDC_RD_BACK_BYTE0, &rdc_cal_result); - rdc_cal_result |= (rdc << 8) & 0x0000FFFF; - if (rdc_cal_result) - max98390->ref_rdc_value = 268435456U / rdc_cal_result; - - regmap_read(max98390->regmap, MAX98390_MEAS_ADC_CH2_READ, &temp); - max98390->ambient_temp_value = temp * 52 - 1188; - - rdc_integer = rdc_cal_result * 937 / 65536; - rdc_factor = ((rdc_cal_result * 937 * 100) / 65536) - - (rdc_integer * 100); - - dev_info(component->dev, "rdc resistance about %d.%02d ohm, reg=0x%X temp reg=0x%X\n", - rdc_integer, rdc_factor, rdc_cal_result, temp); - - return 0; -} - static void max98390_init_regs(struct snd_soc_component *component) { struct max98390_priv *max98390 = -- 2.37.3

2 1

[PATCH] ASoC: tas2770: Reinit regcache on reset
by Martin Povišer 20 Sep '22

20 Sep '22

On probe of the ASoC component, the device is reset but the regcache is retained. This means the regcache gets out of sync if the codec is rebound to a sound card for a second time. Fix it by reinitializing the regcache to defaults after the device is reset. Fixes: b0bcbe615756 ("ASoC: tas2770: Fix calling reset in probe") Signed-off-by: Martin Povišer <povik+lin(a)cutebit.org> --- sound/soc/codecs/tas2770.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index bb653b664146..b6765235a4b3 100644 --- a/sound/soc/codecs/tas2770.c +++ b/sound/soc/codecs/tas2770.c @@ -495,6 +495,8 @@ static struct snd_soc_dai_driver tas2770_dai_driver[] = { }, }; +static const struct regmap_config tas2770_i2c_regmap; + static int tas2770_codec_probe(struct snd_soc_component *component) { struct tas2770_priv *tas2770 = @@ -508,6 +510,7 @@ static int tas2770_codec_probe(struct snd_soc_component *component) } tas2770_reset(tas2770); + regmap_reinit_cache(tas2770->regmap, &tas2770_i2c_regmap); return 0; } -- 2.33.0

2 1

[PATCH] ASOC: nau8824: Fix semaphore is released unexpectedly
by Wallace Lin 20 Sep '22

20 Sep '22

From: SJLIN0 <SJLIN0(a)nuvoton.com> On resuming, we anticipate that the jack is detected before playback or capture. Therefore, we use semaphore to control the jack detection done without any bothering. During booting, the driver launches jack detection and releases the semaphore. However, it doesn't perceive the maniputation of semaphore is not like resuming procedure. This makes the semaphore's count value become to 2. There is more than one thread can enter into the critical section. This may get unexpected situation and make some chaos. Signed-off-by: SJLIN0 <SJLIN0(a)nuvoton.com> Signed-off-by: Wallace Lin <savagecin(a)gmail.com> --- sound/soc/codecs/nau8824.c | 17 ++++++++++++++--- sound/soc/codecs/nau8824.h | 1 + 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 15596452ca37..4f19fd9b65d1 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -901,7 +901,10 @@ static void nau8824_jdet_work(struct work_struct *work) NAU8824_IRQ_KEY_RELEASE_DIS | NAU8824_IRQ_KEY_SHORT_PRESS_DIS, 0); - nau8824_sema_release(nau8824); + if (nau8824->resume_lock) { + nau8824_sema_release(nau8824); + nau8824->resume_lock = false; + } } static void nau8824_setup_auto_irq(struct nau8824 *nau8824) @@ -966,7 +969,10 @@ static irqreturn_t nau8824_interrupt(int irq, void *data) /* release semaphore held after resume, * and cancel jack detection */ - nau8824_sema_release(nau8824); + if (nau8824->resume_lock) { + nau8824_sema_release(nau8824); + nau8824->resume_lock = false; + } cancel_work_sync(&nau8824->jdet_work); } else if (active_irq & NAU8824_KEY_SHORT_PRESS_IRQ) { int key_status, button_pressed; @@ -1524,6 +1530,7 @@ static int __maybe_unused nau8824_suspend(struct snd_soc_component *component) static int __maybe_unused nau8824_resume(struct snd_soc_component *component) { struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); + int ret; regcache_cache_only(nau8824->regmap, false); regcache_sync(nau8824->regmap); @@ -1531,7 +1538,10 @@ static int __maybe_unused nau8824_resume(struct snd_soc_component *component) /* Hold semaphore to postpone playback happening * until jack detection done. */ - nau8824_sema_acquire(nau8824, 0); + nau8824->resume_lock = true; + ret = nau8824_sema_acquire(nau8824, 0); + if (ret) + nau8824->resume_lock = false; enable_irq(nau8824->irq); } @@ -1940,6 +1950,7 @@ static int nau8824_i2c_probe(struct i2c_client *i2c) nau8824->regmap = devm_regmap_init_i2c(i2c, &nau8824_regmap_config); if (IS_ERR(nau8824->regmap)) return PTR_ERR(nau8824->regmap); + nau8824->resume_lock = false; nau8824->dev = dev; nau8824->irq = i2c->irq; sema_init(&nau8824->jd_sem, 1); diff --git a/sound/soc/codecs/nau8824.h b/sound/soc/codecs/nau8824.h index de4bae8281d0..5fcfc43dfc85 100644 --- a/sound/soc/codecs/nau8824.h +++ b/sound/soc/codecs/nau8824.h @@ -436,6 +436,7 @@ struct nau8824 { struct semaphore jd_sem; int fs; int irq; + int resume_lock; int micbias_voltage; int vref_impedance; int jkdet_polarity; -- 2.25.1

2 1

[PATCH] ASoC: Intel: sof_sdw: add support for Dell SKU 0AFF
by Pierre-Louis Bossart 20 Sep '22

20 Sep '22

Yet another SKU that needs a quirk for jack detection and four-speaker support. BugLink: https://github.com/thesofproject/linux/issues/3777 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- sound/soc/intel/boards/sof_sdw.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c index a49bfaab6b21f..2ff30b40a1e4c 100644 --- a/sound/soc/intel/boards/sof_sdw.c +++ b/sound/soc/intel/boards/sof_sdw.c @@ -266,6 +266,16 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = { .driver_data = (void *)(SOF_SDW_TGL_HDMI | SOF_SDW_FOUR_SPK), }, + { + .callback = sof_sdw_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"), + DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "0AFF") + }, + .driver_data = (void *)(SOF_SDW_TGL_HDMI | + RT711_JD2 | + SOF_SDW_FOUR_SPK), + }, { .callback = sof_sdw_quirk_cb, .matches = { -- 2.34.1

2 1

Alsa - has invalid interface number
by GitHub issues - edited 19 Sep '22

19 Sep '22

alsa-project/alsa-lib issue #271 was edited from smangels: hi, I'm running the latest ArchLinux installation using a Behringer Flow8 as my main audio interface. Today I'm running into an issue where the USB audio hardware can not be loaded successfully. ``` [ 1690.797522] usb 1-3.1.1.4: new high-speed USB device number 14 using xhci_hcd [ 1690.891936] usb 1-3.1.1.4: config 1 has an invalid interface number: 7 but max is 5 [ 1690.891940] usb 1-3.1.1.4: config 1 has no interface number 5 [ 1690.892620] usb 1-3.1.1.4: New USB device found, idVendor=1397, idProduct=050d, bcdDevice= 2.10 [ 1690.892624] usb 1-3.1.1.4: New USB device strings: Mfr=1, Product=2, SerialNumber=6 [ 1690.892627] usb 1-3.1.1.4: Product: FLOW 8 [ 1690.892628] usb 1-3.1.1.4: Manufacturer: Behringer [ 1690.892630] usb 1-3.1.1.4: SerialNumber: 18-04-ED-FB-BE-A0 ``` The following Alsa related packages have been upgraded. ``` [2022-09-19T18:22:14+0200] [ALPM] upgraded alsa-card-profiles (1:0.3.57-1 -> 1:0.3.58-1) [2022-09-19T18:22:15+0200] [ALPM] upgraded pipewire-alsa (1:0.3.57-1 -> 1:0.3.58-1) [2022-09-19T23:07:36+0200] [PACMAN] Running 'pacman -Sy alsa-tools' [2022-09-19T23:07:38+0200] [ALPM] installed alsa-tools (1.2.5-1) ``` Kernel and UDEV version `Linux archlinux 5.19.9-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 15 Sep 2022 16:08:26 +0000 x86_64 GNU/Linux` `udev version 251` Issue URL : https://github.com/alsa-project/alsa-lib/issues/271 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa - has invalid interface number
by GitHub issues - opened 19 Sep '22

19 Sep '22

alsa-project/alsa-lib issue #271 was opened from smangels: hi, I'm running the latest ArchLinux installation using a Behringer Flow8 as my main audio interface. Today I'm running into an issue where the USB audio hardware can not be loaded successfully. ``` [ 1690.797522] usb 1-3.1.1.4: new high-speed USB device number 14 using xhci_hcd [ 1690.891936] usb 1-3.1.1.4: config 1 has an invalid interface number: 7 but max is 5 [ 1690.891940] usb 1-3.1.1.4: config 1 has no interface number 5 [ 1690.892620] usb 1-3.1.1.4: New USB device found, idVendor=1397, idProduct=050d, bcdDevice= 2.10 [ 1690.892624] usb 1-3.1.1.4: New USB device strings: Mfr=1, Product=2, SerialNumber=6 [ 1690.892627] usb 1-3.1.1.4: Product: FLOW 8 [ 1690.892628] usb 1-3.1.1.4: Manufacturer: Behringer [ 1690.892630] usb 1-3.1.1.4: SerialNumber: 18-04-ED-FB-BE-A0 ``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/271 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v2 0/3] ASoC: ts3a227e control debounce times
by Astrid Rost 19 Sep '22

19 Sep '22

From: Astrid Rost <astridr(a)axis.com> PATCH 1 - convert ts3a227e bindings to yaml. PATCH 2 - add ts3a227e bindings to support debounce times. PATCH 3 - add ts3a227e driver to support debounce times. v1 -> v2 - Converted the devicetree-bindings to YAML. - The debounce-times are in ms. The closed match is used, if the given times do not match the register values. Signed-off-by: Astrid Rost <astrid.rost(a)axis.com>. Astrid Rost (3): dt-bindings: sound: ts3a227e: convert to yaml dt-bindings: sound: ts3a227e: add control of debounce times ASoC: ts3a227e: add parameters to control debounce times .../devicetree/bindings/sound/ts3a227e.txt | 30 ------ .../devicetree/bindings/sound/ts3a227e.yaml | 98 +++++++++++++++++++ sound/soc/codecs/ts3a227e.c | 58 +++++++++-- 3 files changed, 150 insertions(+), 36 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/ts3a227e.txt create mode 100644 Documentation/devicetree/bindings/sound/ts3a227e.yaml -- 2.20.1

3 6

[PATCH] ALSA: hda/hdmi: Fix the converter reuse for the silent stream
by Jaroslav Kysela 19 Sep '22

19 Sep '22

When the user space pcm stream uses the silent stream converter, it is no longer allocated for the silent stream. Clear the appropriate flag in the hdmi_pcm_open() function. The silent stream setup may be applied in hdmi_pcm_close() (and the error path - open fcn) again. If the flag is not cleared, the reuse conditions for the silent stream converter in hdmi_choose_cvt() may improperly share this converter. Cc: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/pci/hda/patch_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 6c209cd26c0c..22766810635b 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1267,6 +1267,7 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo, set_bit(pcm_idx, &spec->pcm_in_use); per_pin = get_pin(spec, pin_idx); per_pin->cvt_nid = per_cvt->cvt_nid; + per_pin->silent_stream = false; hinfo->nid = per_cvt->cvt_nid; /* flip stripe flag for the assigned stream if supported */ -- 2.35.3

3 3

[PATCH] ALSA: core: Fix double-free at snd_card_new()
by Takashi Iwai 19 Sep '22

19 Sep '22

During the code change to add the support for devres-managed card instance, we put an explicit kfree(card) call at the error path in snd_card_new(). This is needed for the early error path before the card is initialized with the device, but is rather superfluous and causes a double-free at the error path after the card instance is initialized, as the destructor of the card object already contains a kfree() call. This patch fixes the double-free situation by removing the superfluous kfree(). Meanwhile we need to call kfree() explicitly for the early error path, so it's added there instead. Fixes: e8ad415b7a55 ("ALSA: core: Add managed card creation") Reported-by: Rondreis <linhaoguo86(a)gmail.com> Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/CAB7eexL1zBnB636hwS27d-LdPYZ_R1-5fJS_h=ZbCWYU=UPW… Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/init.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/core/init.c b/sound/core/init.c index 193dae361fac..5377f94eb211 100644 --- a/sound/core/init.c +++ b/sound/core/init.c @@ -178,10 +178,8 @@ int snd_card_new(struct device *parent, int idx, const char *xid, return -ENOMEM; err = snd_card_init(card, parent, idx, xid, module, extra_size); - if (err < 0) { - kfree(card); - return err; - } + if (err < 0) + return err; /* card is freed by error handler */ *card_ret = card; return 0; @@ -233,7 +231,7 @@ int snd_devm_card_new(struct device *parent, int idx, const char *xid, card->managed = true; err = snd_card_init(card, parent, idx, xid, module, extra_size); if (err < 0) { - devres_free(card); + devres_free(card); /* in managed mode, we need to free manually */ return err; } @@ -297,6 +295,8 @@ static int snd_card_init(struct snd_card *card, struct device *parent, mutex_unlock(&snd_card_mutex); dev_err(parent, "cannot find the slot for index %d (range 0-%i), error: %d\n", idx, snd_ecards_limit - 1, err); + if (!card->managed) + kfree(card); /* manually free here, as no destructor called */ return err; } set_bit(idx, snd_cards_lock); /* lock it */ -- 2.35.3

1 0

KASAN: invalid-free in snd_card_new
by Rondreis 19 Sep '22

19 Sep '22

Hello, When fuzzing the Linux kernel driver v6.0-rc4, the following crash was triggered. HEAD commit: 7e18e42e4b280c85b76967a9106a13ca61c16179 git tree: upstream kernel config: https://pastebin.com/raw/xtrgsXP3 C reproducer: https://pastebin.com/raw/w2sdQWYj console output: https://pastebin.com/raw/Yyf7zw2d Basically, in the c reproducer, we use the gadget module to emulate attaching a USB device(vendor id: 0x1bc7, product id: 0x1206, with the midi function) and executing some simple sequence of system calls. To reproduce this crash, we utilize a third-party library to emulate the attaching process: https://github.com/linux-usb-gadgets/libusbgx. Just clone this repository, install it, and compile the c reproducer with ``` gcc crash.c -lusbgx -lconfig -o crash ``` will do the trick. I would appreciate it if you have any idea how to solve this bug. The crash report is as follows: ================================================================== BUG: KASAN: double-free in snd_card_new+0xf9/0x130 sound/core/init.c:182 CPU: 1 PID: 7476 Comm: syz-executor.2 Not tainted 6.0.0-rc4+ #20 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 print_address_description mm/kasan/report.c:317 [inline] print_report.cold+0xe5/0x66d mm/kasan/report.c:433 kasan_report_invalid_free+0x5b/0x160 mm/kasan/report.c:462 ____kasan_slab_free mm/kasan/common.c:356 [inline] __kasan_slab_free+0x179/0x1b0 mm/kasan/common.c:375 kasan_slab_free include/linux/kasan.h:200 [inline] slab_free_hook mm/slub.c:1754 [inline] slab_free_freelist_hook mm/slub.c:1780 [inline] slab_free mm/slub.c:3534 [inline] kfree+0xe9/0x650 mm/slub.c:4562 snd_card_new+0xf9/0x130 sound/core/init.c:182 snd_usb_audio_create sound/usb/card.c:621 [inline] usb_audio_probe+0x162a/0x2f10 sound/usb/card.c:797 usb_probe_interface+0x361/0x800 drivers/usb/core/driver.c:396 call_driver_probe drivers/base/dd.c:560 [inline] really_probe+0x249/0xa90 drivers/base/dd.c:639 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808 __device_attach_driver+0x1da/0x2d0 drivers/base/dd.c:936 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:427 __device_attach+0x283/0x480 drivers/base/dd.c:1008 proc_ioctl drivers/usb/core/devio.c:2356 [inline] proc_ioctl+0x5b4/0x6e0 drivers/usb/core/devio.c:2307 proc_ioctl_default drivers/usb/core/devio.c:2391 [inline] usbdev_do_ioctl drivers/usb/core/devio.c:2747 [inline] usbdev_ioctl+0x29a3/0x3340 drivers/usb/core/devio.c:2807 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f0dda8a80fd Code: 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f0ddaf63bf8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f0dda99c340 RCX: 00007f0dda8a80fd RDX: 0000000020000900 RSI: 00000000c0105512 RDI: 0000000000000003 RBP: 00007f0ddaf63c50 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000000d R13: 00007ffeb548e29f R14: 00007ffeb548e440 R15: 00007f0ddaf63d80 </TASK> Allocated by task 7476: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track mm/kasan/common.c:45 [inline] set_alloc_info mm/kasan/common.c:437 [inline] ____kasan_kmalloc mm/kasan/common.c:516 [inline] ____kasan_kmalloc mm/kasan/common.c:475 [inline] __kasan_kmalloc+0xa9/0xd0 mm/kasan/common.c:525 kasan_kmalloc include/linux/kasan.h:234 [inline] __kmalloc+0x1da/0x3f0 mm/slub.c:4424 kmalloc include/linux/slab.h:605 [inline] kzalloc include/linux/slab.h:733 [inline] snd_card_new+0x78/0x130 sound/core/init.c:176 snd_usb_audio_create sound/usb/card.c:621 [inline] usb_audio_probe+0x162a/0x2f10 sound/usb/card.c:797 usb_probe_interface+0x361/0x800 drivers/usb/core/driver.c:396 call_driver_probe drivers/base/dd.c:560 [inline] really_probe+0x249/0xa90 drivers/base/dd.c:639 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808 __device_attach_driver+0x1da/0x2d0 drivers/base/dd.c:936 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:427 __device_attach+0x283/0x480 drivers/base/dd.c:1008 proc_ioctl drivers/usb/core/devio.c:2356 [inline] proc_ioctl+0x5b4/0x6e0 drivers/usb/core/devio.c:2307 proc_ioctl_default drivers/usb/core/devio.c:2391 [inline] usbdev_do_ioctl drivers/usb/core/devio.c:2747 [inline] usbdev_ioctl+0x29a3/0x3340 drivers/usb/core/devio.c:2807 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Freed by task 7476: kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38 kasan_set_track+0x21/0x30 mm/kasan/common.c:45 kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:370 ____kasan_slab_free mm/kasan/common.c:367 [inline] ____kasan_slab_free mm/kasan/common.c:329 [inline] __kasan_slab_free+0x11d/0x1b0 mm/kasan/common.c:375 kasan_slab_free include/linux/kasan.h:200 [inline] slab_free_hook mm/slub.c:1754 [inline] slab_free_freelist_hook mm/slub.c:1780 [inline] slab_free mm/slub.c:3534 [inline] kfree+0xe9/0x650 mm/slub.c:4562 snd_card_do_free sound/core/init.c:605 [inline] release_card_device+0x1af/0x200 sound/core/init.c:145 device_release+0x9f/0x240 drivers/base/core.c:2330 kobject_cleanup lib/kobject.c:673 [inline] kobject_release lib/kobject.c:704 [inline] kref_put include/linux/kref.h:65 [inline] kobject_put+0x1be/0x4c0 lib/kobject.c:721 put_device+0x1b/0x30 drivers/base/core.c:3624 snd_card_init+0x973/0xbd0 sound/core/init.c:367 snd_card_new+0xa1/0x130 sound/core/init.c:180 snd_usb_audio_create sound/usb/card.c:621 [inline] usb_audio_probe+0x162a/0x2f10 sound/usb/card.c:797 usb_probe_interface+0x361/0x800 drivers/usb/core/driver.c:396 call_driver_probe drivers/base/dd.c:560 [inline] really_probe+0x249/0xa90 drivers/base/dd.c:639 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808 __device_attach_driver+0x1da/0x2d0 drivers/base/dd.c:936 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:427 __device_attach+0x283/0x480 drivers/base/dd.c:1008 proc_ioctl drivers/usb/core/devio.c:2356 [inline] proc_ioctl+0x5b4/0x6e0 drivers/usb/core/devio.c:2307 proc_ioctl_default drivers/usb/core/devio.c:2391 [inline] usbdev_do_ioctl drivers/usb/core/devio.c:2747 [inline] usbdev_ioctl+0x29a3/0x3340 drivers/usb/core/devio.c:2807 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd The buggy address belongs to the object at ffff888041f54000 which belongs to the cache kmalloc-8k of size 8192 The buggy address is located 0 bytes inside of 8192-byte region [ffff888041f54000, ffff888041f56000) The buggy address belongs to the physical page: page:ffffea000107d400 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x41f50 head:ffffea000107d400 order:3 compound_mapcount:0 compound_pincount:0 flags: 0x4fff00000010200(slab|head|node=1|zone=1|lastcpupid=0x7ff) raw: 04fff00000010200 ffffea0001092200 dead000000000004 ffff888011c42280 raw: 0000000000000000 0000000080020002 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 1, tgid 1 (swapper/0), ts 14941420612, free_ts 14728973666 set_page_owner include/linux/page_owner.h:31 [inline] post_alloc_hook mm/page_alloc.c:2525 [inline] prep_new_page+0x2c6/0x350 mm/page_alloc.c:2532 get_page_from_freelist+0xae9/0x3a80 mm/page_alloc.c:4283 __alloc_pages+0x321/0x710 mm/page_alloc.c:5515 alloc_page_interleave+0x1e/0x250 mm/mempolicy.c:2103 alloc_pages+0x25f/0x2f0 mm/mempolicy.c:2265 alloc_slab_page mm/slub.c:1824 [inline] allocate_slab mm/slub.c:1969 [inline] new_slab+0x246/0x3a0 mm/slub.c:2029 ___slab_alloc+0xa50/0x1060 mm/slub.c:3031 __slab_alloc.isra.0+0x4d/0xa0 mm/slub.c:3118 slab_alloc_node mm/slub.c:3209 [inline] slab_alloc mm/slub.c:3251 [inline] __kmalloc+0x388/0x3f0 mm/slub.c:4420 kmalloc_array include/linux/slab.h:640 [inline] fb_show_logo_line drivers/video/fbdev/core/fbmem.c:491 [inline] fb_show_logo+0x1398/0x23c0 drivers/video/fbdev/core/fbmem.c:695 fbcon_switch+0xef7/0x12a0 drivers/video/fbdev/core/fbcon.c:2183 redraw_screen+0x2b9/0x740 drivers/tty/vt/vt.c:1021 con2fb_init_display drivers/video/fbdev/core/fbcon.c:806 [inline] set_con2fb_map+0x798/0xec0 drivers/video/fbdev/core/fbcon.c:865 do_fb_registered drivers/video/fbdev/core/fbcon.c:3012 [inline] fbcon_fb_registered+0x208/0x460 drivers/video/fbdev/core/fbcon.c:3028 do_register_framebuffer drivers/video/fbdev/core/fbmem.c:1696 [inline] register_framebuffer+0x545/0x910 drivers/video/fbdev/core/fbmem.c:1865 __drm_fb_helper_initial_config_and_unlock+0xdc6/0x1350 drivers/gpu/drm/drm_fb_helper.c:1910 page last free stack trace: reset_page_owner include/linux/page_owner.h:24 [inline] free_pages_prepare mm/page_alloc.c:1449 [inline] free_pcp_prepare+0x5ab/0xd00 mm/page_alloc.c:1499 free_unref_page_prepare mm/page_alloc.c:3380 [inline] free_unref_page+0x19/0x410 mm/page_alloc.c:3476 __unfreeze_partials+0x3f3/0x410 mm/slub.c:2548 qlink_free mm/kasan/quarantine.c:168 [inline] qlist_free_all+0x6a/0x170 mm/kasan/quarantine.c:187 kasan_quarantine_reduce+0x13d/0x180 mm/kasan/quarantine.c:294 __kasan_slab_alloc+0xa2/0xc0 mm/kasan/common.c:447 kasan_slab_alloc include/linux/kasan.h:224 [inline] slab_post_alloc_hook+0x4d/0x4f0 mm/slab.h:727 slab_alloc_node mm/slub.c:3243 [inline] slab_alloc mm/slub.c:3251 [inline] __kmem_cache_alloc_lru mm/slub.c:3258 [inline] kmem_cache_alloc+0x151/0x360 mm/slub.c:3268 ptlock_alloc mm/memory.c:5774 [inline] ptlock_init include/linux/mm.h:2261 [inline] pmd_ptlock_init include/linux/mm.h:2347 [inline] pgtable_pmd_page_ctor include/linux/mm.h:2383 [inline] pmd_alloc_one include/asm-generic/pgalloc.h:129 [inline] __pmd_alloc+0xbf/0x5b0 mm/memory.c:5225 pmd_alloc include/linux/mm.h:2211 [inline] __handle_mm_fault+0x856/0x2e00 mm/memory.c:5013 handle_mm_fault+0x322/0xa80 mm/memory.c:5151 faultin_page mm/gup.c:990 [inline] __get_user_pages+0x5be/0x1250 mm/gup.c:1219 __get_user_pages_locked mm/gup.c:1423 [inline] __get_user_pages_remote mm/gup.c:2133 [inline] __get_user_pages_remote+0x196/0x810 mm/gup.c:2109 get_user_pages_remote+0x80/0xc0 mm/gup.c:2206 get_arg_page+0xe4/0x2a0 fs/exec.c:222 copy_string_kernel+0x16d/0x4f0 fs/exec.c:639 Memory state around the buggy address: ffff888041f53f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff888041f53f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff888041f54000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff888041f54080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff888041f54100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ==================================================================

2 4

[PATCH] ALSA: hda/realtek: Add a quirk for HP OMEN 16 (8902) mute LED
by Daniel Houldsworth 19 Sep '22

19 Sep '22

Similair to the HP OMEN 15, the HP OMEN 16 also needs ALC285_FIXUP_HP_MUTE_LED for the mute LED to work. Signed-off-by: Daniel Houldsworth <dhould3(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 38930cf5a..c7d07d6df 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9265,6 +9265,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED), + SND_PCI_QUIRK(0x103c, 0x8902, "HP OMEN 16", ALC285_FIXUP_HP_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED), -- 2.37.3

2 1

[PATCH v2 0/3] sound: realtek: add quirks for ASUS G513, G533Z, GA503R
by Luke D. Jones 19 Sep '22

19 Sep '22

This series adds quirks to fix pincfg for the ASUS ROG G513 and G533Z laptops, and adds a mapping for the ASUS ROG GA503R to use the previous G15/G14 quirks which fix the DAC mapping. Changelog: V2: - Use smallcaps in hex string - Chain the G533Z quirk with the G513 quirk as they use the same base pincfg - Add the quirk for GA503R series to use GA401 quirk Luke D. Jones (3): sound: realtek: Add pincfg for ASUS G513 HP jack sound: realtek: Add pincfg for ASUS G533Z HP jack sound: realtek: Add quirk for ASUS GA503R laptop sound/pci/hda/patch_realtek.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) -- 2.37.3

3 6

USB-Audio: Motu M4: no duplex profile
by GitHub issues - opened 18 Sep '22

18 Sep '22

alsa-project/alsa-ucm-conf issue #214 was opened from pisquaredover6: I have compiled alsa-ucm-conf v1.2.7.2 with the patches [3a6acaa5090a0c5a0d29c8a4906b6a60378774e2](https://github.com/alsa-project/a… and [ad1618cdd33f5c78ee1a0a9d3db362ffcb9f2596](https://github.com/alsa-project/a…. With this, I have simplex audio, but no duplex profiles any more. Is there any chance we can add a duplex profile, as it used to be the case before alsa-ucm-conf introduced the M4? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/214 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: amd: yc: Add ASUS UM5302TA into DMI table
by Xiaoyan Li 17 Sep '22

17 Sep '22

ASUS Zenbook S 13 OLED (UM5302TA) needs this quirk to get the built-in microphone working properly. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216270 Signed-off-by: Xiaoyan Li <lxy.lixiaoyan(a)gmail.com> --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index e0b24e1daef3..5eab3baf3573 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -171,6 +171,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "21J6"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "UM5302TA"), + } + }, {} }; -- 2.37.3

2 1

[PATCH -next 1/2] ALSA: mts64: Switch to use list_for_each_entry() helper
by Yang Yingliang 17 Sep '22

17 Sep '22

Use list_for_each_entry() helper instead of list_for_each() and list_entry() to simplify code a bit. No functional change. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/drivers/mts64.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/drivers/mts64.c b/sound/drivers/mts64.c index d3bc9e8c407d..746ac25a319e 100644 --- a/sound/drivers/mts64.c +++ b/sound/drivers/mts64.c @@ -752,7 +752,6 @@ static int snd_mts64_rawmidi_create(struct snd_card *card) struct mts64 *mts = card->private_data; struct snd_rawmidi *rmidi; struct snd_rawmidi_substream *substream; - struct list_head *list; int err; err = snd_rawmidi_new(card, CARD_NAME, 0, @@ -778,16 +777,16 @@ static int snd_mts64_rawmidi_create(struct snd_card *card) /* name substreams */ /* output */ - list_for_each(list, - &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams) { - substream = list_entry(list, struct snd_rawmidi_substream, list); + list_for_each_entry(substream, + &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams, + list) { sprintf(substream->name, "Miditerminal %d", substream->number+1); } /* input */ - list_for_each(list, - &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams) { - substream = list_entry(list, struct snd_rawmidi_substream, list); + list_for_each_entry(substream, + &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams, + list) { mts->midi_input_substream[substream->number] = substream; switch(substream->number) { case MTS64_SMPTE_SUBSTREAM: -- 2.25.1

1 1

[PATCH -next] ALSA: ppc: Switch to use for_each_child_of_node() macro
by Yang Yingliang 17 Sep '22

17 Sep '22

Use for_each_child_of_node() macro instead of open coding it. No functional change. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/ppc/tumbler.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c index c65e74d7cd0a..f3f8ad7c3df8 100644 --- a/sound/ppc/tumbler.c +++ b/sound/ppc/tumbler.c @@ -1060,8 +1060,7 @@ static struct device_node *find_audio_device(const char *name) if (! gpiop) return NULL; - for (np = of_get_next_child(gpiop, NULL); np; - np = of_get_next_child(gpiop, np)) { + for_each_child_of_node(gpiop, np) { const char *property = of_get_property(np, "audio-gpio", NULL); if (property && strcmp(property, name) == 0) break; @@ -1080,8 +1079,7 @@ static struct device_node *find_compatible_audio_device(const char *name) if (!gpiop) return NULL; - for (np = of_get_next_child(gpiop, NULL); np; - np = of_get_next_child(gpiop, np)) { + for_each_child_of_node(gpiop, np) { if (of_device_is_compatible(np, name)) break; } -- 2.25.1

2 1

[bug report] ASoC: rockchip: i2s: use regmap_read_poll_timeout to poll I2S_CLR
by Dan Carpenter 16 Sep '22

16 Sep '22

Hello Judy Hsiao, The patch fbb0ec656ee5: "ASoC: rockchip: i2s: use regmap_read_poll_timeout to poll I2S_CLR" from Sep 14, 2022, leads to the following Smatch static checker warning: sound/soc/rockchip/rockchip_i2s.c:165 rockchip_snd_txctrl() warn: sleeping in atomic context sound/soc/rockchip/rockchip_i2s.c 126 static int rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on) 127 { 128 unsigned int val = 0; 129 int ret = 0; 130 131 spin_lock(&i2s->lock); ^^^^^^^^^^^^^^^^^^^^^ Holding a spin lock. 132 if (on) { 133 ret = regmap_update_bits(i2s->regmap, I2S_DMACR, 134 I2S_DMACR_TDE_ENABLE, 135 I2S_DMACR_TDE_ENABLE); 136 if (ret < 0) 137 goto end; 138 ret = regmap_update_bits(i2s->regmap, I2S_XFER, 139 I2S_XFER_TXS_START | I2S_XFER_RXS_START, 140 I2S_XFER_TXS_START | I2S_XFER_RXS_START); 141 if (ret < 0) 142 goto end; 143 i2s->tx_start = true; 144 } else { 145 i2s->tx_start = false; 146 147 ret = regmap_update_bits(i2s->regmap, I2S_DMACR, 148 I2S_DMACR_TDE_ENABLE, 149 I2S_DMACR_TDE_DISABLE); 150 if (ret < 0) 151 goto end; 152 153 if (!i2s->rx_start) { 154 ret = regmap_update_bits(i2s->regmap, I2S_XFER, 155 I2S_XFER_TXS_START | I2S_XFER_RXS_START, 156 I2S_XFER_TXS_STOP | I2S_XFER_RXS_STOP); 157 if (ret < 0) 158 goto end; 159 udelay(150); 160 ret = regmap_update_bits(i2s->regmap, I2S_CLR, 161 I2S_CLR_TXC | I2S_CLR_RXC, 162 I2S_CLR_TXC | I2S_CLR_RXC); 163 if (ret < 0) 164 goto end; --> 165 ret = regmap_read_poll_timeout(i2s->regmap, 166 I2S_CLR, 167 val, 168 val != 0, 169 20, ^^ 170 200); ^^^ If the sleep_us or timeout_us values are non-zero then it can sleep so it's a sleeping in atomic bug. 171 if (ret < 0) 172 dev_warn(i2s->dev, "fail to clear: %d\n", ret); 173 } 174 } 175 end: 176 spin_unlock(&i2s->lock); 177 if (ret < 0) 178 dev_err(i2s->dev, "lrclk update failed\n"); 179 180 return ret; 181 } regards, dan carpenter

1 1

[PATCH] soundwire: qcom: update status from device id 1
by Srinivas Kandagatla 16 Sep '22

16 Sep '22

By default autoenumeration is enabled on QCom SoundWire controller which means the core should not be dealing with device 0 w.r.t enumeration. Currently device 0 status is also shared with SoundWire core which confuses the core sometimes and we endup adding 0:0:0:0 slave device. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- drivers/soundwire/qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index e21a3306bf01..871e4d8b32c7 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -428,7 +428,7 @@ static int qcom_swrm_get_alert_slave_dev_num(struct qcom_swrm_ctrl *ctrl) ctrl->reg_read(ctrl, SWRM_MCP_SLV_STATUS, &val); - for (dev_num = 0; dev_num <= SDW_MAX_DEVICES; dev_num++) { + for (dev_num = 1; dev_num <= SDW_MAX_DEVICES; dev_num++) { status = (val >> (dev_num * SWRM_MCP_SLV_STATUS_SZ)); if ((status & SWRM_MCP_SLV_STATUS_MASK) == SDW_SLAVE_ALERT) { @@ -448,7 +448,7 @@ static void qcom_swrm_get_device_status(struct qcom_swrm_ctrl *ctrl) ctrl->reg_read(ctrl, SWRM_MCP_SLV_STATUS, &val); ctrl->slave_status = val; - for (i = 0; i <= SDW_MAX_DEVICES; i++) { + for (i = 1; i <= SDW_MAX_DEVICES; i++) { u32 s; s = (val >> (i * 2)); -- 2.21.0

2 5

[PATCH] ASoC: fsl_spdif: add ALSA event on dpll locked
by robert.rosengren＠axis.com 16 Sep '22

16 Sep '22

From: Robert Rosengren <robert.rosengren(a)axis.com> Add an ALSA event on the RX Sample Rate controller upon the dpll locked interrupt, making it possible for audio applications to monitor changes in the hardware. Signed-off-by: Robert Rosengren <robert.rosengren(a)axis.com> --- sound/soc/fsl/fsl_spdif.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 7fc1c96929bb..1679a21ffdca 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -44,6 +44,8 @@ static u8 srpc_dpll_locked[] = { 0x0, 0x1, 0x2, 0x3, 0x4, 0xa, 0xb }; #define DEFAULT_RXCLK_SRC 1 +#define RX_SAMPLE_RATE_KCONTROL "RX Sample Rate" + /** * struct fsl_spdif_soc_data: soc specific data * @@ -122,6 +124,7 @@ struct fsl_spdif_priv { const struct fsl_spdif_soc_data *soc; struct spdif_mixer_control fsl_spdif_control; struct snd_soc_dai_driver cpu_dai_drv; + struct snd_soc_dai *dai; struct platform_device *pdev; struct regmap *regmap; bool dpll_locked; @@ -223,9 +226,19 @@ static void spdif_irq_dpll_lock(struct fsl_spdif_priv *spdif_priv) locked &= SRPC_DPLL_LOCKED; dev_dbg(&pdev->dev, "isr: Rx dpll %s \n", - locked ? "locked" : "loss lock"); + locked ? "locked" : "loss lock"); spdif_priv->dpll_locked = locked ? true : false; + + if (spdif_priv->dai) { + struct snd_soc_component *component = spdif_priv->dai->component; + struct snd_kcontrol *kctl = snd_soc_card_get_kcontrol(component->card, + RX_SAMPLE_RATE_KCONTROL); + + if (kctl) + snd_ctl_notify(component->card->snd_card, + SNDRV_CTL_EVENT_MASK_VALUE, &kctl->id); + } } /* Receiver found illegal symbol interrupt handler */ @@ -1197,7 +1210,7 @@ static struct snd_kcontrol_new fsl_spdif_ctrls[] = { /* DPLL lock info get controller */ { .iface = SNDRV_CTL_ELEM_IFACE_PCM, - .name = "RX Sample Rate", + .name = RX_SAMPLE_RATE_KCONTROL, .access = SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE, .info = fsl_spdif_rxrate_info, @@ -1241,6 +1254,7 @@ static struct snd_kcontrol_new fsl_spdif_ctrls_rcm[] = { static int fsl_spdif_dai_probe(struct snd_soc_dai *dai) { struct fsl_spdif_priv *spdif_private = snd_soc_dai_get_drvdata(dai); + spdif_private->dai = dai; snd_soc_dai_init_dma_data(dai, &spdif_private->dma_params_tx, &spdif_private->dma_params_rx); -- 2.30.2

4 5

[PATCH v4 0/4] ASoC: qcom: add support for sc8280xp machine
by Srinivas Kandagatla 15 Sep '22

15 Sep '22

This patchset adds support for SC8280XP SoC machine driver. First patch moves some of the commonly used code to common from sm8250 machine driver and the follow on code adds minimal support for sc8280xp. Currently this driver is only tested with SmartSpeakers and Headset on Lenovo Thinkpad X13s. Support for sm8450 is tested and I will post the patches soon. Thanks, Srini Changes since v3: - fixed few spellings in commit log - removed build dependency with APR Srinivas Kandagatla (4): ASoC: qcom: common: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL ASoC: dt-bindings: qcom,sm8250: add compatibles for sm8450 and sm8250 ASoC: qcom: sm8250: move some code to common ASoC: qcom: add machine driver for sc8280xp .../bindings/sound/qcom,sm8250.yaml | 2 + sound/soc/qcom/Kconfig | 12 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/common.c | 173 +++++++++++++++++- sound/soc/qcom/common.h | 35 ++++ sound/soc/qcom/sc8280xp.c | 157 ++++++++++++++++ sound/soc/qcom/sm8250.c | 152 +-------------- 7 files changed, 387 insertions(+), 146 deletions(-) create mode 100644 sound/soc/qcom/sc8280xp.c -- 2.21.0

2 6

[PATCH] ALSA: hda/realtek: Re-arrange quirk table entries
by Takashi Iwai 15 Sep '22

15 Sep '22

A few entries have been mistakenly inserted in wrong positions without considering the SSID ordering. Place them at right positions. Fixes: b7557267c233 ("ALSA: hda/realtek: Add quirk for ASUS GA402") Fixes: 94db9cc8f8fa ("ALSA: hda/realtek: Add quirk for ASUS GU603") Fixes: 739d0959fbed ("ALSA: hda: Add quirk for ASUS Flow x13") Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d309304cdc46..90fde53e6956 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9341,10 +9341,11 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), + SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), + SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", ALC295_FIXUP_ASUS_DACS), SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK), - SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), SND_PCI_QUIRK(0x1043, 0x1881, "ASUS Zephyrus S/M", ALC294_FIXUP_ASUS_GX502_PINS), SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC), SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC), @@ -9361,13 +9362,12 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x1bbd, "ASUS Z550MA", ALC255_FIXUP_ASUS_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1043, 0x1c23, "Asus X55U", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x1043, 0x1ccd, "ASUS X555UB", ALC256_FIXUP_ASUS_MIC), + SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE), SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502), SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS), SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401), - SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401), - SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2), SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x834a, "ASUS S101", ALC269_FIXUP_STEREO_DMIC), -- 2.35.3

1 0

[PATCH 1/1] ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5530 laptop
by Callum Osmotherly 15 Sep '22

15 Sep '22

Callum Osmotherly <callum.osmotherly(a)gmail.com> Just as with the 5570 (and the other Dell laptops), this enables the two subwoofer speakers on the Dell Precision 5530 together with the main ones, significantly increasing the audio quality. I've tested this myself on a 5530 and can confirm it's working as expected. Signed-off-by: Callum Osmotherly <callum.osmotherly(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 799f6bf266dd..bdef329adb10 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9114,6 +9114,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), + SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB), -- 2.37.3

2 1

[bug report] ASoC: SOF: compress: Add copy function for capture case
by Dan Carpenter 15 Sep '22

15 Sep '22

Hello Laurentiu Mihalcea, The patch 1a01e1927802: "ASoC: SOF: compress: Add copy function for capture case" from Aug 22, 2022, leads to the following Smatch static checker warning: sound/soc/sof/compress.c:315 sof_compr_copy_playback() warn: special assignment for copy_ function '+=' sound/soc/sof/compress.c 300 static int sof_compr_copy_playback(struct snd_compr_runtime *rtd, 301 char __user *buf, size_t count) 302 { 303 void *ptr; 304 unsigned int offset, n; 305 int ret; 306 307 div_u64_rem(rtd->total_bytes_available, rtd->buffer_size, &offset); 308 ptr = rtd->dma_area + offset; 309 n = rtd->buffer_size - offset; 310 311 if (count < n) { 312 ret = copy_from_user(ptr, buf, count); 313 } else { 314 ret = copy_from_user(ptr, buf, n); --> 315 ret += copy_from_user(rtd->dma_area, buf + n, count - n); This API is not ideal. The static checker warning is based on the theory that if you combine the number of bytes copied from the first copy with the number of bytes from the second copy, is that useful? "We copied 100 bytes. But not necessarily consecutive bytes, so you'll have to guess which they were!" Generally if we're copying from the user and the destination buffer is too small we return the number of bytes which were copied. But if the user memory is invalid we return -EFAULT. Here the user memory is invalid but we are returning a truncated number of bytes, so it suggests that the kernel buffer is too small which is kind of misleading. I guess user space kind of gets what they deserve for passing invalid memory... Also it looks like we can't really return -EFAULT because _soc_component_ret() is not able to accept that... 316 } 317 318 return count - ret; 319 } regards, dan carpenter

1 0

[PATCH 00/10] Support for CS42L83 on Apple machines
by Martin Povišer 15 Sep '22

15 Sep '22

Hi all, there's a CS42L83 headphone jack codec found in Apple computers (in the recent 'Apple Silicon' ones as well as in earlier models, one example [1]). The part isn't publicly documented, but it appears almost identical to CS42L42, for which we have a driver in kernel. This series adapts the CS42L42 driver to the new part, and makes one change in anticipation of a machine driver for the Apple computers. Patch 1 adds new compatible to the cs42l42 schema. Patches 2 to 7 are taken from Richard's recent series [2] adding soundwire support to cs42l42. They are useful refactorings to build on in later patches, and also this way our work doesn't diverge. I made one fix: I added a call of common_remove at the end of i2c_probe should the cs42l42_init call fail (both before and after the split to cs42l42-i2c.c). Also s/Soundwire/SoundWire/ in the changelogs. Patch 8 exports some regmap-related symbols from cs42l42.c so they can be used to create cs42l83 regmap in cs42l83-i2c.c later. Patch 9 is the cs42l83 support proper. Patch 10 implements 'set_bclk_ratio' on the cs42l42 core. This will be called by the upcoming ASoC machine driver for 'Apple Silicon' Macs. (We have touched on this change to be made in earlier discussion, see [3] and replies.) Best, Martin [1] https://www.ifixit.com/Teardown/MacBook+Pro+13-Inch+Touch+Bar+2018+Teardown… [2] https://lore.kernel.org/alsa-devel/20220819125230.42731-1-rf@opensource.cir… [3] https://lore.kernel.org/asahi/8961DDD2-93FF-4A18-BCA2-90FCE298F517@cutebit.… Martin Povišer (5): ASoC: dt-bindings: cs42l42: Add 'cs42l83' compatible ASoC: cs42l42: Split probe() and remove() into stages ASoC: cs42l42: Export regmap elements to the core namespace ASoC: cs42l83: Extend CS42L42 support to new part ASoC: cs42l42: Implement 'set_bclk_ratio' Richard Fitzgerald (5): ASoC: cs42l42: Add bitclock frequency argument to cs42l42_pll_config() ASoC: cs42l42: Use cs42l42->dev instead of &i2c_client->dev ASoC: cs42l42: Split cs42l42_resume into two functions ASoC: cs42l42: Pass component and dai defs into common probe ASoC: cs42l42: Split I2C identity into separate module .../bindings/sound/cirrus,cs42l42.yaml | 1 + MAINTAINERS | 1 + include/sound/cs42l42.h | 1 + sound/soc/codecs/Kconfig | 15 +- sound/soc/codecs/Makefile | 6 +- sound/soc/codecs/cs42l42-i2c.c | 112 ++++++++ sound/soc/codecs/cs42l42.c | 256 +++++++++--------- sound/soc/codecs/cs42l42.h | 24 +- sound/soc/codecs/cs42l83-i2c.c | 248 +++++++++++++++++ 9 files changed, 538 insertions(+), 126 deletions(-) create mode 100644 sound/soc/codecs/cs42l42-i2c.c create mode 100644 sound/soc/codecs/cs42l83-i2c.c -- 2.33.0

4 21

[PATCH] ALSA: usb-audio: Fix last interface check for registration
by Takashi Iwai 15 Sep '22

15 Sep '22

The recent fix in commit 6392dcd1d0c7 ("ALSA: usb-audio: Register card at the last interface") tried to delay the card registration until the last found interface is probed. It assumed that the probe callback gets called for those later interfaces, but it's not always true; as the driver loops over the descriptor and probes the matching ones, it's not separately called via multiple probe calls. This results in the missing card registration, i.e. no sound device. For addressing this problem, replace the check whether the last interface is processed with usb_interface_claimed() instead of the comparison with the probe interface number. Fixes: 6392dcd1d0c7 ("ALSA: usb-audio: Register card at the last interface") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/card.c b/sound/usb/card.c index 3aea241435fb..a5ed11ea1145 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -884,7 +884,7 @@ static int usb_audio_probe(struct usb_interface *intf, * one given via option */ if (check_delayed_register_option(chip) == ifnum || - chip->last_iface == ifnum) { + usb_interface_claimed(usb_ifnum_to_if(dev, chip->last_iface))) { err = snd_card_register(chip->card); if (err < 0) goto __error; -- 2.35.3

1 0

[PATCH v2 0/3] ASoC: dt-bindings: Add bindings for WCD9335 DAIs
by Yassine Oudjana 15 Sep '22

15 Sep '22

Add DT bindings for WCD9335 DAIs and use them in the driver as well as all device trees currently using WCD9335. Changes since v1: - Make header guard match path - Maintain the alphabetical order in msm8996-xiaomi-gemini includes Yassine Oudjana (3): ASoC: dt-bindings: Add bindings for WCD9335 DAIs ASoC: wcd9335: Use DT bindings instead of local DAI definitions arm64: dts: qcom: Use WCD9335 DT bindings MAINTAINERS | 1 + arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 5 +++-- .../arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 5 +++-- .../boot/dts/qcom/msm8996-xiaomi-scorpio.dts | 5 +++-- include/dt-bindings/sound/qcom,wcd9335.h | 15 +++++++++++++++ sound/soc/codecs/wcd9335.c | 13 ++----------- 6 files changed, 27 insertions(+), 17 deletions(-) create mode 100644 include/dt-bindings/sound/qcom,wcd9335.h -- 2.36.1

4 6

[PATCH 3/4] ASoC: sma1303: Add driver for Iron Device SMA1303 Amp
by Kiseok Jo 15 Sep '22

15 Sep '22

The Iron Device SMA1303 is a boosted Class-D audio amplifier. Signed-off-by: Kiseok Jo <kiseok.jo(a)irondevice.com> Reviewed-by: Gyuhwa Park <gyuhwa.park(a)irondevice.com> --- sound/soc/codecs/sma1303.c | 2781 ++++++++++-------------------------- sound/soc/codecs/sma1303.h | 7 +- 2 files changed, 762 insertions(+), 2026 deletions(-) diff --git a/sound/soc/codecs/sma1303.c b/sound/soc/codecs/sma1303.c index cbdfba1ed7cf..03c969a4891e 100644 --- a/sound/soc/codecs/sma1303.c +++ b/sound/soc/codecs/sma1303.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* sma1303.c -- sma1303 ALSA SoC Audio driver * - * Copyright 2019 Iron Device Corporation + * Copyright 2022 Iron Device Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -59,10 +59,15 @@ struct sma1303_pll_match { struct sma1303_priv { enum sma1303_type devtype; + struct device *dev; struct attribute_group *attr_grp; struct kobject *kobj; struct regmap *regmap; struct sma1303_pll_match *pll_matches; + struct mutex lock; + struct delayed_work check_fault_work; + bool amp_power_status; + bool usage_status; int num_of_pll_matches; unsigned int sys_clk_id; unsigned int init_vol; @@ -70,25 +75,15 @@ struct sma1303_priv { unsigned int tdm_slot_rx; unsigned int tdm_slot_tx; unsigned int tsdw_cnt; - unsigned int bst_vol_lvl_status; - unsigned int flt_vdd_gain_status; - bool sdo_bypass_flag; - bool amp_power_status; - bool force_amp_power_down; - bool stereo_two_chip; - bool impossible_bst_ctrl; - bool fault_reg_flag; - struct mutex lock; - struct delayed_work check_fault_work; - long check_fault_period; - long check_fault_status; unsigned int format; - struct device *dev; unsigned int rev_num; unsigned int last_over_temp; unsigned int last_ocp_val; unsigned int last_bclk; unsigned int frame_size; + unsigned int amp_mode; + long check_fault_period; + long check_fault_status; }; static struct sma1303_pll_match sma1303_pll_matches[] = { @@ -111,15 +106,15 @@ static const struct reg_default sma1303_reg_def[] = { { 0x03, 0x11 }, { 0x04, 0x17 }, { 0x09, 0x00 }, - { 0x0A, 0x58 }, - { 0x0B, 0xD8 }, - { 0x0C, 0x8C }, + { 0x0A, 0x31 }, + { 0x0B, 0x98 }, + { 0x0C, 0x84 }, { 0x0D, 0x07 }, - { 0x0E, 0xAF }, + { 0x0E, 0x3F }, { 0x10, 0x00 }, { 0x11, 0x00 }, { 0x12, 0x00 }, - { 0x14, 0x60 }, + { 0x14, 0x5C }, { 0x15, 0x01 }, { 0x16, 0x0F }, { 0x17, 0x0F }, @@ -132,38 +127,33 @@ static const struct reg_default sma1303_reg_def[] = { { 0x25, 0x00 }, { 0x26, 0x04 }, { 0x33, 0x00 }, - { 0x34, 0x0C }, { 0x36, 0x92 }, - { 0x37, 0x3F }, - { 0x38, 0x64 }, - { 0x3B, 0x00 }, - { 0x3C, 0x00 }, + { 0x37, 0x27 }, + { 0x3B, 0x5A }, + { 0x3C, 0x20 }, { 0x3D, 0x00 }, { 0x3E, 0x03 }, - { 0x3F, 0x00 }, + { 0x3F, 0x0C }, { 0x8B, 0x07 }, { 0x8C, 0x70 }, { 0x8D, 0x8B }, { 0x8E, 0x6F }, { 0x8F, 0x03 }, - { 0x90, 0x31 }, + { 0x90, 0x26 }, { 0x91, 0x42 }, - { 0x92, 0x80 }, + { 0x92, 0xE0 }, { 0x94, 0x35 }, - { 0x95, 0x44 }, + { 0x95, 0x0C }, { 0x96, 0x42 }, - { 0x97, 0x9A }, + { 0x97, 0x95 }, { 0xA0, 0x00 }, { 0xA1, 0x3B }, - { 0xA2, 0x48 }, + { 0xA2, 0xC8 }, { 0xA3, 0x28 }, { 0xA4, 0x40 }, { 0xA5, 0x01 }, { 0xA6, 0x41 }, { 0xA7, 0x00 }, - { 0xFA, 0xE0 }, - { 0xFB, 0x06 }, - { 0xFF, 0x10 }, }; static bool sma1303_readable_register(struct device *dev, unsigned int reg) @@ -210,8 +200,8 @@ static bool sma1303_writeable_register(struct device *dev, unsigned int reg) case SMA1303_10_SYSTEM_CTRL1 ... SMA1303_12_SYSTEM_CTRL3: case SMA1303_14_MODULATOR ... SMA1303_1B_BASS_SPK7: case SMA1303_23_COMP_LIM1 ... SMA1303_26_COMP_LIM4: - case SMA1303_33_SDM_CTRL ... SMA1303_34_OTP_DATA1: - case SMA1303_36_PROTECTION ... SMA1303_38_OTP_TRM0: + case SMA1303_33_SDM_CTRL: + case SMA1303_36_PROTECTION ... SMA1303_37_SLOPE_CTRL: case SMA1303_3B_TEST1 ... SMA1303_3F_ATEST2: case SMA1303_8B_PLL_POST_N ... SMA1303_92_FDPEC_CTRL: case SMA1303_94_BOOST_CTRL1 ... SMA1303_97_BOOST_CTRL4: @@ -243,6 +233,32 @@ static bool sma1303_volatile_register(struct device *dev, unsigned int reg) static const DECLARE_TLV_DB_SCALE(sma1303_spk_tlv, -6000, 50, 0); +static int sma1303_regmap_write(struct regmap *map, struct device *dev, + unsigned int reg, unsigned int val) +{ + int ret = 0; + + ret = regmap_write(map, reg, val); + if (ret < 0) { + dev_err(dev, "Failed to write, register: 0x%02X, ret: %d\n", + reg, ret); + } + return ret; +} + +static int sma1303_regmap_update_bits(struct regmap *map, struct device *dev, + unsigned int reg, unsigned int mask, unsigned int val) +{ + int ret = 0; + + ret = regmap_update_bits(map, reg, mask, val); + if (ret < 0) { + dev_err(dev, "Failed to write, register: 0x%02X, ret: %d\n", + reg, ret); + } + return ret; +} + static int bytes_ext_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol, int reg) { @@ -252,10 +268,25 @@ static int bytes_ext_get(struct snd_kcontrol *kcontrol, struct soc_bytes_ext *params = (void *)kcontrol->private_value; unsigned int i, reg_val; u8 *val; + int ret = -1; + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } val = (u8 *)ucontrol->value.bytes.data; for (i = 0; i < params->max; i++) { - regmap_read(sma1303->regmap, reg + i, &reg_val); + ret = regmap_read(sma1303->regmap, reg + i, &reg_val); + if (ret < 0) { + dev_err(component->dev, + "Failed to read, register: %x ret: %d\n", + reg + i, ret); + return ret; + } if (sizeof(reg_val) > 2) reg_val = cpu_to_le32(reg_val); else @@ -275,8 +306,16 @@ static int bytes_ext_put(struct snd_kcontrol *kcontrol, struct soc_bytes_ext *params = (void *)kcontrol->private_value; void *data; u8 *val; - int i, ret; + int i, ret = -1; + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } data = kmemdup(ucontrol->value.bytes.data, params->max, GFP_KERNEL | GFP_DMA); if (!data) @@ -284,11 +323,10 @@ static int bytes_ext_put(struct snd_kcontrol *kcontrol, val = (u8 *)data; for (i = 0; i < params->max; i++) { - ret = regmap_write(sma1303->regmap, reg + i, *(val + i)); - if (ret) { - dev_err(component->dev, - "configuration fail, register: %x ret: %d\n", - reg + i, ret); + ret = sma1303_regmap_write( + sma1303->regmap, component->dev, + reg + i, *(val + i)); + if (ret < 0) { kfree(data); return ret; } @@ -298,1831 +336,609 @@ static int bytes_ext_put(struct snd_kcontrol *kcontrol, return 0; } -static int power_up_down_control_get(struct snd_kcontrol *kcontrol, +static int amp_usage_status_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = -1; - ucontrol->value.integer.value[0] = sma1303->amp_power_status; - - return 0; -} - -static int power_up_down_control_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } + ucontrol->value.integer.value[0] = sma1303->usage_status; - if (sel && !(sma1303->force_amp_power_down)) - sma1303_startup(component); + if (sma1303->usage_status) + dev_info(component->dev, "Amplifier Power Control Enabled\n"); else - sma1303_shutdown(component); - - return 0; -} - -static int power_down_control_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - - ucontrol->value.integer.value[0] = sma1303->force_amp_power_down; + dev_info(component->dev, "Amplifier Power Control Disabled\n"); return 0; } -static int power_down_control_put(struct snd_kcontrol *kcontrol, +static int amp_usage_status_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = -1; - sma1303->force_amp_power_down = ucontrol->value.integer.value[0]; - - if (sma1303->force_amp_power_down) { - dev_info(component->dev, "%s\n", "Force AMP Power Down"); - sma1303_shutdown(component); + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; } - return 0; -} - -static int force_sdo_bypass_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - - ucontrol->value.integer.value[0] = sma1303->sdo_bypass_flag; - - return 0; -} - -static int force_sdo_bypass_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - sma1303->sdo_bypass_flag = (bool)sel; - - return 0; -} - -static const char * const sma1303_input_format_text[] = { - "I2S", "LJ", "Reserved", "Reserved", - "RJ_16", "RJ_18", "RJ_20", "RJ_24"}; - -static const struct soc_enum sma1303_input_format_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_input_format_text), - sma1303_input_format_text); - -static int sma1303_input_format_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, &val); - ucontrol->value.integer.value[0] = ((val & 0x70) >> 4); - - return 0; -} - -static int sma1303_input_format_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; + if ((sma1303->usage_status + != ucontrol->value.integer.value[0]) + && (!ucontrol->value.integer.value[0])) { + dev_info(component->dev, "%s\n", "Force AMP Power Down"); + ret = sma1303_shutdown(component); + if (ret < 0) { + ucontrol->value.integer.value[0] + = sma1303->usage_status; + return ret; + } - regmap_update_bits(sma1303->regmap, - SMA1303_01_INPUT1_CTRL1, 0x70, (sel << 4)); + } + sma1303->usage_status = ucontrol->value.integer.value[0]; return 0; } -static const char * const sma1303_in_audio_mode_text[] = { - "I2S mode", "PCM short", "PCM long", "Reserved"}; - -static const struct soc_enum sma1303_in_audio_mode_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_in_audio_mode_text), - sma1303_in_audio_mode_text); +static const char * const sma1303_amp_mode_text[] = { + "1 Chip", "Mono on 2 chips", "Left in 2 chips", "Right in 2chips"}; -static int sma1303_in_audio_mode_get(struct snd_kcontrol *kcontrol, +static const struct soc_enum sma1303_amp_mode_enum = + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_amp_mode_text), + sma1303_amp_mode_text); +static int sma1303_amp_mode_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; + int ret = -1; - regmap_read(sma1303->regmap, SMA1303_02_INPUT1_CTRL2, &val); - ucontrol->value.integer.value[0] = ((val & 0xC0) >> 6); + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } + ucontrol->value.integer.value[0] = sma1303->amp_mode; + switch (sma1303->amp_mode) { + case ONE_CHIP_SOLUTION: + dev_info(component->dev, "Amplifier 1 Chip Solution\n"); + break; + case MONO_TWO_CHIP_SOLUTION: + dev_info(component->dev, "Amplifier Mono 2 Chips Solution\n"); + break; + case LEFT_TWO_CHIP_SOLUTION: + dev_info(component->dev, "Amplifier Stereo(Left) 2 Chips Solution\n"); + break; + case RIGHT_TWO_CHIP_SOLUTION: + dev_info(component->dev, "Amplifier Stereo(Right) 2 Chips Solution\n"); + break; + default: + dev_err(component->dev, "Invalid Value"); + return ret; + } return 0; -} - -static int sma1303_in_audio_mode_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_02_INPUT1_CTRL2, 0xC0, (sel << 6)); - return 0; } -static const char * const sma1303_pcm_n_slot_text[] = { - "Slot_1", "Slot_2", "Slot_3", "Slot_4", "Slot_5", "Slot_6", - "Slot_7", "Slot_8", "Slot_9", "Slot_10", "Slot_11", "Slot_12", - "Slot_13", "Slot_14", "Slot_15", "Slot_16"}; - -static const struct soc_enum sma1303_pcm_n_slot_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_pcm_n_slot_text), - sma1303_pcm_n_slot_text); - -static int sma1303_pcm_n_slot_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) +static int sma1303_amp_mode_put(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_03_INPUT1_CTRL3, &val); - ucontrol->value.integer.value[0] = (val & 0x0F); + int ret = 0; - return 0; -} - -static int sma1303_pcm_n_slot_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return -1; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return -1; + } - regmap_update_bits(sma1303->regmap, - SMA1303_03_INPUT1_CTRL3, 0x0F, sel); + sma1303->amp_mode = ucontrol->value.integer.value[0]; + + switch (sma1303->amp_mode) { + case ONE_CHIP_SOLUTION: + case MONO_TWO_CHIP_SOLUTION: + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_11_SYSTEM_CTRL2, + MONOMIX_MASK, MONOMIX_ON); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_11_SYSTEM_CTRL2, + LR_DATA_SW_MASK, LR_DATA_SW_NORMAL); + break; + case LEFT_TWO_CHIP_SOLUTION: + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_11_SYSTEM_CTRL2, + MONOMIX_MASK, MONOMIX_OFF); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_11_SYSTEM_CTRL2, + LR_DATA_SW_MASK, LR_DATA_SW_NORMAL); + break; + case RIGHT_TWO_CHIP_SOLUTION: + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_11_SYSTEM_CTRL2, + MONOMIX_MASK, MONOMIX_OFF); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_11_SYSTEM_CTRL2, + LR_DATA_SW_MASK, LR_DATA_SW_SWAP); + break; + default: + dev_err(component->dev, "Invalid Value"); + ret += -1; + } - return 0; + return ret; } -static const char * const sma1303_pcm1_slot_text[] = { - "Slot_1", "Slot_2", "Slot_3", "Slot_4", "Slot_5", "Slot_6", - "Slot_7", "Slot_8", "Slot_9", "Slot_10", "Slot_11", "Slot_12", - "Slot_13", "Slot_14", "Slot_15", "Slot_16"}; - -static const struct soc_enum sma1303_pcm1_slot_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_pcm1_slot_text), - sma1303_pcm1_slot_text); - -static int sma1303_pcm1_slot_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_04_INPUT1_CTRL4, &val); - ucontrol->value.integer.value[0] = ((val & 0xF0) >> 4); +static const char * const sma1303_outport_config_text[] = { + "Enable", "Disable"}; - return 0; -} +static const struct soc_enum sma1303_outport_config_enum = + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_outport_config_text), + sma1303_outport_config_text); -static int sma1303_pcm1_slot_put(struct snd_kcontrol *kcontrol, +static int sma1303_outport_config_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_04_INPUT1_CTRL4, 0xF0, (sel << 4)); - - return 0; -} - -static const char * const sma1303_pcm2_slot_text[] = { - "Slot_1", "Slot_2", "Slot_3", "Slot_4", "Slot_5", "Slot_6", - "Slot_7", "Slot_8", "Slot_9", "Slot_10", "Slot_11", "Slot_12", - "Slot_13", "Slot_14", "Slot_15", "Slot_16"}; + int ret = -1, data, val; -static const struct soc_enum sma1303_pcm2_slot_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_pcm2_slot_text), - sma1303_pcm2_slot_text); + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } -static int sma1303_pcm2_slot_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; + ret = regmap_read(sma1303->regmap, SMA1303_09_OUTPUT_CTRL, &data); + if (ret < 0) { + dev_err(component->dev, + "Failed to read, register: %x ret: %d\n", + SMA1303_09_OUTPUT_CTRL, ret); + return ret; + } - regmap_read(sma1303->regmap, SMA1303_04_INPUT1_CTRL4, &val); - ucontrol->value.integer.value[0] = (val & 0x0F); + val = data & PORT_CONFIG_MASK; + switch (val) { + case INPUT_PORT_ONLY: + ucontrol->value.integer.value[0] = 1; + break; + case OUTPUT_PORT_ENABLE: + ucontrol->value.integer.value[0] = 0; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x value: %d\n", + SMA1303_09_OUTPUT_CTRL, val); + return ret; + } return 0; } -static int sma1303_pcm2_slot_put(struct snd_kcontrol *kcontrol, +static int sma1303_outport_config_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); int sel = (int)ucontrol->value.integer.value[0]; + int val, ret = -1; - regmap_update_bits(sma1303->regmap, - SMA1303_04_INPUT1_CTRL4, 0x0F, sel); - - return 0; -} - -static const char * const sma1303_port_config_text[] = { - "IN_Port", "Reserved", "OUT_Port", "Reserved"}; - -static const struct soc_enum sma1303_port_config_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_port_config_text), - sma1303_port_config_text); - -static int sma1303_port_config_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_09_OUTPUT_CTRL, &val); - ucontrol->value.integer.value[0] = ((val & 0x60) >> 5); - - return 0; -} - -static int sma1303_port_config_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } - regmap_update_bits(sma1303->regmap, - SMA1303_09_OUTPUT_CTRL, 0x60, (sel << 5)); + switch (sel) { + case 0: + val = OUTPUT_PORT_ENABLE; + break; + case 1: + val = INPUT_PORT_ONLY; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x\n", + SMA1303_09_OUTPUT_CTRL); + return ret; + } - return 0; + return sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_09_OUTPUT_CTRL, PORT_CONFIG_MASK, val); } +static const char * const sma1303_spkmute_text[] = { + "Unmute", "Mute"}; -static const char * const sma1303_port_out_sel_text[] = { - "Disable", "Format_C", "Mixer_out", "After_DSP", - "Postscaler", "Reserved", "Reserved", "Reserved"}; - -static const struct soc_enum sma1303_port_out_sel_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_port_out_sel_text), - sma1303_port_out_sel_text); - -static int sma1303_port_out_sel_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; +static const struct soc_enum sma1303_spkmute_enum = + SOC_ENUM_SINGLE(SMA1303_0E_MUTE_VOL_CTRL, 0, + ARRAY_SIZE(sma1303_spkmute_text), + sma1303_spkmute_text); - regmap_read(sma1303->regmap, SMA1303_09_OUTPUT_CTRL, &val); - ucontrol->value.integer.value[0] = (val & 0x07); +static const char * const sma1303_spkmode_text[] = { + "Off", "On"}; - return 0; -} +static const struct soc_enum sma1303_spkmode_enum = + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_spkmode_text), + sma1303_spkmode_text); -static int sma1303_port_out_sel_put(struct snd_kcontrol *kcontrol, +static int sma1303_spkmode_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_09_OUTPUT_CTRL, 0x07, sel); - - return 0; -} + int val, data, ret = -1; -static const char * const sma1303_bst_off_slope_text[] = { - "6.7ns", "4.8ns", "2.6ns", "1.2ns"}; + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } -static const struct soc_enum sma1303_bst_off_slope_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_bst_off_slope_text), - sma1303_bst_off_slope_text); + ret = regmap_read(sma1303->regmap, SMA1303_10_SYSTEM_CTRL1, &data); + if (ret < 0) { + dev_err(component->dev, + "Failed to read, register: %x ret: %d\n", + SMA1303_10_SYSTEM_CTRL1, ret); + return ret; + } -static int sma1303_bst_off_slope_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_0B_BST_TEST, &val); - ucontrol->value.integer.value[0] = ((val & 0xC0) >> 6); - - return 0; -} - -static int sma1303_bst_off_slope_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_0B_BST_TEST, 0xC0, (sel << 6)); - - return 0; -} - -static const char * const sma1303_set_ocp_h_text[] = { - "4.5", "3.2", "2.1", "0.9"}; - -static const struct soc_enum sma1303_set_ocp_h_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_set_ocp_h_text), - sma1303_set_ocp_h_text); - -static int sma1303_set_ocp_h_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_0C_BST_TEST1, &val); - ucontrol->value.integer.value[0] = ((val & 0xC0) >> 6); - - return 0; -} - -static int sma1303_set_ocp_h_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_0C_BST_TEST1, 0xC0, (sel << 6)); - - return 0; -} - -static const char * const sma1303_spk_off_slope_text[] = { - "00", "01", "10", "11"}; - -static const struct soc_enum sma1303_spk_off_slope_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_spk_off_slope_text), - sma1303_spk_off_slope_text); - -static int sma1303_spk_off_slope_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_0D_SPK_TEST, &val); - ucontrol->value.integer.value[0] = (val & 0x03); - - return 0; -} - -static int sma1303_spk_off_slope_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_0D_SPK_TEST, 0x03, sel); - - return 0; -} - -static const char * const sma1303_vol_slope_text[] = { - "Off", "Slow(1sec)", "Medium(0.5sec)", - "Fast(0.1sec)"}; - -static const struct soc_enum sma1303_vol_slope_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_vol_slope_text), - sma1303_vol_slope_text); - -static int sma1303_vol_slope_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_0E_MUTE_VOL_CTRL, &val); - ucontrol->value.integer.value[0] = ((val & 0xC0) >> 6); - - return 0; -} - -static int sma1303_vol_slope_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_0E_MUTE_VOL_CTRL, 0xC0, (sel << 6)); - - return 0; -} - -static const char * const sma1303_mute_slope_text[] = { - "Off", "Slow(200ms)", "Medium(50ms)", - "Fast(10ms)"}; - -static const struct soc_enum sma1303_mute_slope_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_mute_slope_text), - sma1303_mute_slope_text); - -static int sma1303_mute_slope_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_0E_MUTE_VOL_CTRL, &val); - ucontrol->value.integer.value[0] = ((val & 0x30) >> 4); - - return 0; -} - -static int sma1303_mute_slope_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_0E_MUTE_VOL_CTRL, 0x30, (sel << 4)); - - return 0; -} - -static const char * const sma1303_spkmode_text[] = { - "Off", "Mono", "Reserved", "Reserved", - "Stereo", "Reserved", "Reserved", "Reserved"}; - -static const struct soc_enum sma1303_spkmode_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_spkmode_text), - sma1303_spkmode_text); - -static int sma1303_spkmode_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_10_SYSTEM_CTRL1, &val); - ucontrol->value.integer.value[0] = ((val & 0x1C) >> 2); - - return 0; -} - -static int sma1303_spkmode_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_10_SYSTEM_CTRL1, 0x1C, (sel << 2)); - - if (sel == (SPK_MONO >> 2)) - sma1303->stereo_two_chip = false; - else if (sel == (SPK_STEREO >> 2)) - sma1303->stereo_two_chip = true; - - return 0; -} - -static const char * const sma1303_input_gain_text[] = { - "Gain_0dB", "Gain_M6dB", "Gain_M12dB", "Gain_MInf"}; - -static const struct soc_enum sma1303_input_gain_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_input_gain_text), - sma1303_input_gain_text); - -static int sma1303_input_gain_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_12_SYSTEM_CTRL3, &val); - ucontrol->value.integer.value[0] = ((val & 0xC0) >> 6); - - return 0; -} - -static int sma1303_input_gain_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_12_SYSTEM_CTRL3, 0xC0, (sel << 6)); - - return 0; -} - -static const char * const sma1303_input_r_gain_text[] = { - "Gain_0dB", "Gain_M6dB", "Gain_M12dB", "Gain_MInf"}; - -static const struct soc_enum sma1303_input_r_gain_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_input_r_gain_text), - sma1303_input_r_gain_text); - -static int sma1303_input_r_gain_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_12_SYSTEM_CTRL3, &val); - ucontrol->value.integer.value[0] = ((val & 0x30) >> 4); - - return 0; -} - -static int sma1303_input_r_gain_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_12_SYSTEM_CTRL3, 0x30, (sel << 4)); - - return 0; -} - -static const char * const sma1303_spk_hysfb_text[] = { - "f_625kHz", "f_414kHz", "f_297kHz", "f_226kHz"}; - -static const struct soc_enum sma1303_spk_hysfb_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_spk_hysfb_text), sma1303_spk_hysfb_text); - -static int sma1303_spk_hysfb_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_14_MODULATOR, &val); - ucontrol->value.integer.value[0] = ((val & 0xC0) >> 6); - - return 0; -} - -static int sma1303_spk_hysfb_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_14_MODULATOR, 0xC0, (sel << 6)); - - return 0; -} - -static int spk_bdelay_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_14_MODULATOR); -} - -static int spk_bdelay_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_14_MODULATOR); -} - -static int bass_spk_coeff_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_15_BASS_SPK1); -} - -static int bass_spk_coeff_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_15_BASS_SPK1); -} - -static int comp_lim_spk_coeff_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_23_COMP_LIM1); -} - -static int comp_lim_spk_coeff_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_23_COMP_LIM1); -} - -static const char * const sma1303_lr_delay_text[] = { - "Delay_00", "Delay_01", "Delay_10", "Delay_11"}; - -static const struct soc_enum sma1303_lr_delay_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_lr_delay_text), sma1303_lr_delay_text); - -static int sma1303_lr_delay_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_36_PROTECTION, &val); - ucontrol->value.integer.value[0] = ((val & 0x60) >> 5); - - return 0; -} - -static int sma1303_lr_delay_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_36_PROTECTION, 0x60, (sel << 5)); - - return 0; -} - -static const char * const sma1303_otp_mode_text[] = { - "Disable", "I_L1_S_L2", "R_L1_S_L2", "S_L1_S_L2"}; - -static const struct soc_enum sma1303_otp_mode_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_otp_mode_text), sma1303_otp_mode_text); - -static int sma1303_otp_mode_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_36_PROTECTION, &val); - ucontrol->value.integer.value[0] = (val & 0x03); - - return 0; -} - -static int sma1303_otp_mode_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, SMA1303_36_PROTECTION, 0x03, sel); - - return 0; -} - -static int slope_ctrl_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_37_SLOPE_CTRL); -} - -static int slope_ctrl_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_37_SLOPE_CTRL); -} - -static int test_mode_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_3B_TEST1); -} - -static int test_mode_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_3B_TEST1); -} - -static int pll_setting_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_8B_PLL_POST_N); -} - -static int pll_setting_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_8B_PLL_POST_N); -} - -static int pll_pd_ctrl_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_8E_PLL_CTRL); -} - -static int pll_pd_ctrl_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_8E_PLL_CTRL); -} - -static const char * const sma1303_trm_lvl_text[] = { - "On", "Off"}; - -static const struct soc_enum sma1303_trm_lvl_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_lvl_text), - sma1303_trm_lvl_text); - -static int sma1303_trm_lvl_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_8E_PLL_CTRL, &val); - ucontrol->value.integer.value[0] = ((val & 0x10) >> 4); - - return 0; -} - -static int sma1303_trm_lvl_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - int device_info, otp_data; - - regmap_read(sma1303->regmap, SMA1303_34_OTP_DATA1, &otp_data); - regmap_read(sma1303->regmap, SMA1303_FF_DEVICE_INDEX, &device_info); - - if (((device_info & 0x03) != REV_NUM_TV0) && (sel == 1)) - regmap_update_bits(sma1303->regmap, - SMA1303_8E_PLL_CTRL, 0x10, - (((otp_data & 0x20) >> 5) << 4)); - else - regmap_update_bits(sma1303->regmap, - SMA1303_8E_PLL_CTRL, 0x10, 0 << 4); - - return 0; -} - -static int postscaler_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_get(kcontrol, ucontrol, SMA1303_90_POSTSCALER); -} - -static int postscaler_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - return bytes_ext_put(kcontrol, ucontrol, SMA1303_90_POSTSCALER); -} - -static const char * const sma1303_attack_lvl_text[] = { - "BST_ON", "LVL_0.0625FS", "LVL_0.125FS", "LVL_0.1875FS", - "LVL_0.25FS", "LVL_0.3125FS", "LVL_0.375FS", "LVL_0.4375FS", - "LVL_0.5FS", "LVL_0.5625FS", "LVL_0.625FS", "LVL_0.6875FS", - "LVL_0.75FS", "LVL_0.8125FS", "LVL_0.875FS", "BST_OFF"}; - -static const struct soc_enum sma1303_attack_lvl_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_attack_lvl_text), - sma1303_attack_lvl_text); - -static int sma1303_attack_lvl_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_91_CLASS_G_CTRL, &val); - ucontrol->value.integer.value[0] = ((val & 0xF0) >> 4); - - return 0; -} - -static int sma1303_attack_lvl_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_91_CLASS_G_CTRL, 0xF0, (sel << 4)); - - return 0; -} - -static const char * const sma1303_release_time_text[] = { - "Time_0ms", "Time_20ms", "Time_40ms", "Time_60ms", - "Time_80ms", "Time_100ms", "Time_120ms", "Time_140ms", - "Time_160ms", "Time_180ms", "Time_200ms", "Time_220ms", - "Time_240ms", "Time_260ms", "Time_280ms", "Time_300ms"}; - -static const struct soc_enum sma1303_release_time_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_release_time_text), - sma1303_release_time_text); - -static int sma1303_release_time_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_91_CLASS_G_CTRL, &val); - ucontrol->value.integer.value[0] = (val & 0x0F); - - return 0; -} - -static int sma1303_release_time_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_91_CLASS_G_CTRL, 0x0F, sel); - - return 0; -} - -static const char * const sma1303_flt_vdd_gain_text[] = { - "VDD_2.4V", "VDD_2.45V", "VDD_2.5V", "VDD_2.55V", - "VDD_2.6V", "VDD_2.65V", "VDD_2.7V", "VDD_2.75V", - "VDD_2.8V", "VDD_2.85V", "VDD_2.9V", "VDD_2.95V", - "VDD_3.0V", "VDD_3.05V", "VDD_3.1V", "VDD_3.15V"}; - -static const struct soc_enum sma1303_flt_vdd_gain_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_flt_vdd_gain_text), - sma1303_flt_vdd_gain_text); - -static int sma1303_flt_vdd_gain_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_92_FDPEC_CTRL, &val); - ucontrol->value.integer.value[0] = ((val & 0xF0) >> 4); - - return 0; -} - -static int sma1303_flt_vdd_gain_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - sma1303->flt_vdd_gain_status = sel; - - regmap_update_bits(sma1303->regmap, - SMA1303_92_FDPEC_CTRL, 0xF0, (sel << 4)); - - return 0; -} - -static const char * const sma1303_trm_osc_text[] = { - "f_1.4MHz", "f_1.5MHz", "f_1.8MHz", "f_2.0MHz", - "f_2.2MHz", "f_2.5MHz", "f_2.7MHz", "f_3.1MHz"}; - -static const struct soc_enum sma1303_trm_osc_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_osc_text), sma1303_trm_osc_text); - -static int sma1303_trm_osc_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_94_BOOST_CTRL1, &val); - ucontrol->value.integer.value[0] = ((val & 0x70) >> 4); - - return 0; -} - -static int sma1303_trm_osc_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_94_BOOST_CTRL1, 0x70, (sel << 4)); - - return 0; -} - -static const char * const sma1303_trm_rmp_text[] = { - "RMP_0.49A/us", "RMP_0.98A/us", "RMP_1.47A/us", "RMP_1.96A/us", - "RMP_2.45A/us", "RMP_2.94A/us", "RMP_3.43A/us", "RMP_3.92A/us"}; - -static const struct soc_enum sma1303_trm_rmp_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_rmp_text), sma1303_trm_rmp_text); - -static int sma1303_trm_rmp_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_94_BOOST_CTRL1, &val); - ucontrol->value.integer.value[0] = (val & 0x07); - - return 0; -} - -static int sma1303_trm_rmp_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_94_BOOST_CTRL1, 0x07, sel); - - return 0; -} - -static const char * const sma1303_trm_ocl_text[] = { - "I_2.0A", "I_2.3A", "I_2.6A", "I_2.8A", - "I_3.1A", "I_3.4A", "I_3.7A", "I_3.9A"}; - -static const struct soc_enum sma1303_trm_ocl_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_ocl_text), sma1303_trm_ocl_text); - -static int sma1303_trm_ocl_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_95_BOOST_CTRL2, &val); - ucontrol->value.integer.value[0] = ((val & 0x70) >> 4); - - return 0; -} - -static int sma1303_trm_ocl_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_95_BOOST_CTRL2, 0x70, (sel << 4)); - - return 0; -} - -static const char * const sma1303_trm_comp_i_text[] = { - "IG_30pF", "IG_60pF", "IG_90pF", "IG_120pF"}; - -static const struct soc_enum sma1303_trm_comp_i_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_comp_i_text), - sma1303_trm_comp_i_text); - -static int sma1303_trm_comp_i_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_95_BOOST_CTRL2, &val); - ucontrol->value.integer.value[0] = ((val & 0x0C) >> 2); - - return 0; -} - -static int sma1303_trm_comp_i_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_95_BOOST_CTRL2, 0x0C, (sel << 2)); - - return 0; -} - -static const char * const sma1303_trm_comp_p_text[] = { - "PG_0.5Mohm", "PG_0.375Mohm", "PG_0.25Mohm", "PG_0.125Mohm"}; - -static const struct soc_enum sma1303_trm_comp_p_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_comp_p_text), - sma1303_trm_comp_p_text); - -static int sma1303_trm_comp_p_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_95_BOOST_CTRL2, &val); - ucontrol->value.integer.value[0] = (val & 0x03); - - return 0; -} - -static int sma1303_trm_comp_p_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_95_BOOST_CTRL2, 0x03, sel); - - return 0; -} - -static const char * const sma1303_trm_dt_text[] = { - "Time_16.0ns", "Time_14.0ns", "Time_12.0ns", "Time_11.0ns", - "Time_10.0ns", "Time_9.0ns", "Time_8.0ns", "Time_7.3ns", - "Time_6.7ns", "Time_6.2ns", "Time_5.8ns", "Time_5.4ns", - "Time_5.1ns", "Time_4.8ns", "Time_2.1ns", "Time_2.1ns"}; - -static const struct soc_enum sma1303_trm_dt_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_dt_text), sma1303_trm_dt_text); - -static int sma1303_trm_dt_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_96_BOOST_CTRL3, &val); - ucontrol->value.integer.value[0] = ((val & 0xF0) >> 4); - - return 0; -} - -static int sma1303_trm_dt_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_96_BOOST_CTRL3, 0xF0, (sel << 4)); - - return 0; -} - -static const char * const sma1303_trm_slw_text[] = { - "Time_6.7ns", "Time_4.8ns", "Time_2.6ns", "Time_1.2ns"}; - -static const struct soc_enum sma1303_trm_slw_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_slw_text), sma1303_trm_slw_text); - -static int sma1303_trm_slw_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_96_BOOST_CTRL3, &val); - ucontrol->value.integer.value[0] = (val & 0x03); - - return 0; -} - -static int sma1303_trm_slw_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_96_BOOST_CTRL3, 0x03, sel); - - return 0; -} - -static const char * const sma1303_trm_vbst_text[] = { - "BST_5.5V", "BST_5.6V", "BST_5.7V", "BST_5.8V", - "BST_5.9V", "BST_6.0V", "BST_6.1V", "BST_6.2V"}; - -static const struct soc_enum sma1303_trm_vbst_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_vbst_text), sma1303_trm_vbst_text); - -static int sma1303_trm_vbst_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_97_BOOST_CTRL4, &val); - ucontrol->value.integer.value[0] = ((val & 0x1C) >> 2); - - return 0; -} - -static int sma1303_trm_vbst_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - if (sma1303->impossible_bst_ctrl) - dev_info(component->dev, - "Trimming of boost voltage does not change on 'impossible-bst-ctrl' property\n"); - else { - sma1303->bst_vol_lvl_status = sel; - - regmap_update_bits(sma1303->regmap, - SMA1303_97_BOOST_CTRL4, 0x1C, (sel << 2)); - } - - return 0; -} - -static const char * const sma1303_trm_tmin_text[] = { - "Time_40ns", "Time_80ns", "Time_120ns", "Time_160ns"}; - -static const struct soc_enum sma1303_trm_tmin_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_trm_tmin_text), sma1303_trm_tmin_text); - -static int sma1303_trm_tmin_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_97_BOOST_CTRL4, &val); - ucontrol->value.integer.value[0] = (val & 0x03); - - return 0; -} - -static int sma1303_trm_tmin_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_97_BOOST_CTRL4, 0x03, sel); - - return 0; -} - -static const char * const sma1303_pll_div_text[] = { - "PLL_OUT", "PLL_OUT/2", "PLL_OUT/4", "PLL_OUT/8"}; - -static const struct soc_enum sma1303_pll_div_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_pll_div_text), sma1303_pll_div_text); - -static int sma1303_pll_div_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_A2_TOP_MAN1, &val); - ucontrol->value.integer.value[0] = ((val & 0x30) >> 4); - - return 0; -} - -static int sma1303_pll_div_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_A2_TOP_MAN1, 0x30, (sel << 4)); - - return 0; -} - -static const char * const sma1303_o_format_text[] = { - "Reserved", "LJ", "I2S", "Reserved", - "TDM", "Reserved", "Reserved", "Reserved"}; - -static const struct soc_enum sma1303_o_format_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_o_format_text), sma1303_o_format_text); - -static int sma1303_o_format_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_A4_TOP_MAN3, &val); - ucontrol->value.integer.value[0] = ((val & 0xE0) >> 5); - - return 0; -} - -static int sma1303_o_format_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_A4_TOP_MAN3, 0xE0, (sel << 5)); - - return 0; -} - -static const char * const sma1303_sck_rate_text[] = { - "fs_64", "fs_64", "fs_32", "fs_32"}; - -static const struct soc_enum sma1303_sck_rate_enum = -SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_sck_rate_text), sma1303_sck_rate_text); - -static int sma1303_sck_rate_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_A4_TOP_MAN3, &val); - ucontrol->value.integer.value[0] = ((val & 0x18) >> 3); - - return 0; -} - -static int sma1303_sck_rate_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_A4_TOP_MAN3, 0x18, (sel << 3)); - - return 0; -} - -static const char * const sma1303_tdm_slot1_rx_text[] = { - "0", "1", "2", "3", "4", "5", "6", "7"}; - -static const struct soc_enum sma1303_tdm_slot1_rx_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_tdm_slot1_rx_text), - sma1303_tdm_slot1_rx_text); - -static int sma1303_tdm_slot1_rx_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_A5_TDM1, &val); - ucontrol->value.integer.value[0] = ((val & 0x38) >> 3); - - return 0; -} - -static int sma1303_tdm_slot1_rx_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_A5_TDM1, 0x38, (sel << 3)); - - return 0; -} - -static const char * const sma1303_tdm_slot2_rx_text[] = { - "0", "1", "2", "3", "4", "5", "6", "7"}; - -static const struct soc_enum sma1303_tdm_slot2_rx_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_tdm_slot2_rx_text), - sma1303_tdm_slot2_rx_text); - -static int sma1303_tdm_slot2_rx_get(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; - - regmap_read(sma1303->regmap, SMA1303_A5_TDM1, &val); - ucontrol->value.integer.value[0] = ((val & 0x07) >> 0); - - return 0; -} - -static int sma1303_tdm_slot2_rx_put(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol) -{ - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_A5_TDM1, 0x07, (sel << 0)); + val = data & SPK_MODE_MASK; + if (sma1303->amp_mode == ONE_CHIP_SOLUTION) { + switch (val) { + case SPK_OFF: + ucontrol->value.integer.value[0] = 0; + break; + case SPK_MONO: + ucontrol->value.integer.value[0] = 1; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x\n", + SMA1303_10_SYSTEM_CTRL1); + return ret; + } + } else { + switch (val) { + case SPK_OFF: + ucontrol->value.integer.value[0] = 0; + break; + case SPK_STEREO: + ucontrol->value.integer.value[0] = 1; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x\n", + SMA1303_10_SYSTEM_CTRL1); + return ret; + } + } return 0; } -static const char * const sma1303_tdm_slot1_tx_text[] = { - "0", "1", "2", "3", "4", "5", "6", "7"}; - -static const struct soc_enum sma1303_tdm_slot1_tx_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_tdm_slot1_tx_text), - sma1303_tdm_slot1_tx_text); - -static int sma1303_tdm_slot1_tx_get(struct snd_kcontrol *kcontrol, +static int sma1303_spkmode_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; + int sel = (int)ucontrol->value.integer.value[0]; + int val, ret = -1; - regmap_read(sma1303->regmap, SMA1303_A6_TDM2, &val); - ucontrol->value.integer.value[0] = ((val & 0x38) >> 3); + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } - return 0; + switch (sel) { + case 0: + val = SPK_OFF; + break; + case 1: + if (sma1303->amp_mode == ONE_CHIP_SOLUTION) + val = SPK_MONO; + else + val = SPK_STEREO; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x\n", + SMA1303_10_SYSTEM_CTRL1); + return ret; + } + + return sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_10_SYSTEM_CTRL1, SPK_MODE_MASK, val); } -static int sma1303_tdm_slot1_tx_put(struct snd_kcontrol *kcontrol, +static int postscaler_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - struct snd_soc_component *component = - snd_soc_kcontrol_component(kcontrol); - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int sel = (int)ucontrol->value.integer.value[0]; - - regmap_update_bits(sma1303->regmap, - SMA1303_A6_TDM2, 0x38, (sel << 3)); + return bytes_ext_get(kcontrol, ucontrol, SMA1303_90_POSTSCALER); +} - return 0; +static int postscaler_put(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + return bytes_ext_put(kcontrol, ucontrol, SMA1303_90_POSTSCALER); } -static const char * const sma1303_tdm_slot2_tx_text[] = { - "0", "1", "2", "3", "4", "5", "6", "7"}; +static const char * const sma1303_postscaler_config_text[] = { + "Enable", "Disable"}; -static const struct soc_enum sma1303_tdm_slot2_tx_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_tdm_slot2_tx_text), - sma1303_tdm_slot2_tx_text); +static const struct soc_enum sma1303_postscaler_config_enum = + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_postscaler_config_text), + sma1303_postscaler_config_text); -static int sma1303_tdm_slot2_tx_get(struct snd_kcontrol *kcontrol, +static int sma1303_postscaler_config_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; + int ret = -1, data, val; - regmap_read(sma1303->regmap, SMA1303_A6_TDM2, &val); - ucontrol->value.integer.value[0] = ((val & 0x07) >> 0); + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } + + ret = regmap_read(sma1303->regmap, SMA1303_90_POSTSCALER, &data); + if (ret < 0) { + dev_err(component->dev, + "Failed to read, register: %x ret: %d\n", + SMA1303_90_POSTSCALER, ret); + return ret; + } + + val = data & BYP_POST_MASK; + switch (val) { + case BYP_POST_SCALER: + ucontrol->value.integer.value[0] = 1; + break; + case EN_POST_SCALER: + ucontrol->value.integer.value[0] = 0; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x value: %d\n", + SMA1303_90_POSTSCALER, val); + return ret; + } return 0; } -static int sma1303_tdm_slot2_tx_put(struct snd_kcontrol *kcontrol, +static int sma1303_postscaler_config_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); int sel = (int)ucontrol->value.integer.value[0]; + int val, ret = -1; + + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } - regmap_update_bits(sma1303->regmap, - SMA1303_A6_TDM2, 0x07, (sel << 0)); + switch (sel) { + case 0: + val = EN_POST_SCALER; + break; + case 1: + val = BYP_POST_SCALER; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x\n", + SMA1303_90_POSTSCALER); + return ret; + } - return 0; + return sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_90_POSTSCALER, BYP_POST_MASK, val); } -static const char * const sma1303_clk_mon_time_sel_text[] = { - "Time_80us", "Time_40us", "Time_20us", "Time_10us"}; +static const char * const sma1303_o_format_text[] = { + "LJ", "I2S", "TDM"}; -static const struct soc_enum sma1303_clk_mon_time_sel_enum = - SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_clk_mon_time_sel_text), - sma1303_clk_mon_time_sel_text); +static const struct soc_enum sma1303_o_format_enum = +SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_o_format_text), sma1303_o_format_text); -static int sma1303_clk_mon_time_sel_get(struct snd_kcontrol *kcontrol, +static int sma1303_o_format_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int val; + int val, data, ret = -1; + + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } - regmap_read(sma1303->regmap, SMA1303_A7_CLK_MON, &val); - ucontrol->value.integer.value[0] = ((val & 0xC0) >> 6); + ret = regmap_read(sma1303->regmap, SMA1303_A4_TOP_MAN3, &data); + val = data & O_FORMAT_MASK; + switch (val) { + case O_FMT_LJ: + ucontrol->value.integer.value[0] = 0; + break; + case O_FMT_I2S: + ucontrol->value.integer.value[0] = 1; + break; + case O_FMT_TDM: + ucontrol->value.integer.value[0] = 2; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x\n", + SMA1303_A4_TOP_MAN3); + return ret; + } return 0; } - -static int sma1303_clk_mon_time_sel_put(struct snd_kcontrol *kcontrol, +static int sma1303_o_format_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); int sel = (int)ucontrol->value.integer.value[0]; + int val, ret = -1; + + if (component == NULL) { + pr_err("%s:component is NULL\n", __func__); + return ret; + } + if (sma1303 == NULL) { + pr_err("%s:sma1303 is NULL\n", __func__); + return ret; + } - regmap_update_bits(sma1303->regmap, - SMA1303_A7_CLK_MON, 0xC0, (sel << 6)); + switch (sel) { + case 0: + val = O_FMT_LJ; + break; + case 1: + val = O_FMT_I2S; + break; + case 2: + val = O_FMT_TDM; + break; + default: + dev_err(component->dev, + "Invalid value, register: %x\n", + SMA1303_A4_TOP_MAN3); + return ret; + } - return 0; -} + return sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_A4_TOP_MAN3, O_FORMAT_MASK, val); +} + +static const char * const sma1303_sdo_source_texts[] = { + "Disable", "Format_C", "Mixer_Out", "After_DSP", "After_Post"}; +static const unsigned int sma1303_sdo_source_values[] = { + OUT_SEL_DISABLE, + FORMAT_CONVERTER, + MIXER_OUTPUT, + SPEAKER_PATH, + POSTSCALER_OUTPUT}; +static SOC_VALUE_ENUM_SINGLE_DECL(sma1303_sdo_source_enum, + SMA1303_09_OUTPUT_CTRL, + 0, PORT_OUT_SEL_MASK, + sma1303_sdo_source_texts, + sma1303_sdo_source_values); +static const struct snd_kcontrol_new sma1303_sdo_source_mux = + SOC_DAPM_ENUM("SDO Source", sma1303_sdo_source_enum); static const struct snd_kcontrol_new sma1303_snd_controls[] = { -SOC_SINGLE("I2C Reg Reset(1:reset_0:normal)", - SMA1303_00_SYSTEM_CTRL, 1, 1, 0), -SOC_SINGLE_EXT("Power Up(1:Up_0:Down)", SND_SOC_NOPM, 0, 1, 0, - power_up_down_control_get, power_up_down_control_put), -SOC_SINGLE_EXT("Force AMP Power Down", SND_SOC_NOPM, 0, 1, 0, - power_down_control_get, power_down_control_put), -SOC_SINGLE_EXT("Force SDO Bypass", SND_SOC_NOPM, 0, 1, 0, - force_sdo_bypass_get, force_sdo_bypass_put), -SOC_SINGLE("I2S/PCM Clock mode(1:M_2:S)", - SMA1303_01_INPUT1_CTRL1, 7, 1, 0), -SOC_ENUM_EXT("I2S input format(I2S_LJ_RJ)", sma1303_input_format_enum, - sma1303_input_format_get, sma1303_input_format_put), -SOC_SINGLE("First-channel pol I2S(1:H_0:L)", - SMA1303_01_INPUT1_CTRL1, 3, 1, 0), -SOC_SINGLE("Data written SCK edge(1:R_0:F)", - SMA1303_01_INPUT1_CTRL1, 2, 1, 0), -SOC_ENUM_EXT("Input audio mode", sma1303_in_audio_mode_enum, - sma1303_in_audio_mode_get, sma1303_in_audio_mode_put), -SOC_SINGLE("Data inversion(1:R_0:L)", - SMA1303_02_INPUT1_CTRL2, 5, 1, 0), -SOC_SINGLE("Decoding select(1:A_0:u)", - SMA1303_02_INPUT1_CTRL2, 4, 1, 0), -SOC_SINGLE("Companding PCM data(1:C_2:L)", - SMA1303_02_INPUT1_CTRL2, 3, 1, 0), -SOC_SINGLE("PCM sample freq(1:16kHz_0:8kHz)", - SMA1303_02_INPUT1_CTRL2, 2, 1, 0), -SOC_SINGLE("PCM stereo/mono(1:S_0:M)", - SMA1303_02_INPUT1_CTRL2, 1, 1, 0), -SOC_SINGLE("PCM data length(1:16_0:8)", - SMA1303_02_INPUT1_CTRL2, 0, 1, 0), -SOC_ENUM_EXT("Number of slots per sampling period(PCM)", - sma1303_pcm_n_slot_enum, sma1303_pcm_n_slot_get, - sma1303_pcm_n_slot_put), -SOC_ENUM_EXT("Position of the first sample at 8,16kHz", - sma1303_pcm1_slot_enum, sma1303_pcm1_slot_get, - sma1303_pcm1_slot_put), -SOC_ENUM_EXT("Position of the second sample at 16kHz", - sma1303_pcm2_slot_enum, sma1303_pcm2_slot_get, - sma1303_pcm2_slot_put), -SOC_ENUM_EXT("Port In/Out port config", sma1303_port_config_enum, - sma1303_port_config_get, sma1303_port_config_put), -SOC_ENUM_EXT("Port Output Source", sma1303_port_out_sel_enum, - sma1303_port_out_sel_get, sma1303_port_out_sel_put), +SOC_SINGLE_EXT("Amplifier Usage", SND_SOC_NOPM, 0, 1, 0, + amp_usage_status_get, amp_usage_status_put), +SOC_ENUM_EXT("Amplifier Mode", sma1303_amp_mode_enum, + sma1303_amp_mode_get, sma1303_amp_mode_put), +SOC_ENUM_EXT("Outport config", sma1303_outport_config_enum, + sma1303_outport_config_get, sma1303_outport_config_put), SOC_SINGLE_TLV("Speaker Volume", SMA1303_0A_SPK_VOL, 0, 167, 1, sma1303_spk_tlv), -SOC_ENUM_EXT("BST Turn-off slope", sma1303_bst_off_slope_enum, - sma1303_bst_off_slope_get, sma1303_bst_off_slope_put), -SOC_SINGLE("OCP Test(1:test_0:normal)", - SMA1303_0B_BST_TEST, 5, 1, 0), -SOC_SINGLE("LEB(1:long_0:short)", - SMA1303_0B_BST_TEST, 4, 1, 0), -SOC_SINGLE("P-Gain sel(1:normal_0:high)", - SMA1303_0B_BST_TEST, 3, 1, 0), -SOC_SINGLE("VCOMP Mon(1:mon_0:normal)", - SMA1303_0B_BST_TEST, 2, 1, 0), -SOC_SINGLE("PMOS Test(1:pmos_0:normal)", - SMA1303_0B_BST_TEST, 1, 1, 0), -SOC_SINGLE("NMOS Test(1:nmos_0:normal)", - SMA1303_0B_BST_TEST, 0, 1, 0), -SOC_ENUM_EXT("High Side OCP lvl", sma1303_set_ocp_h_enum, - sma1303_set_ocp_h_get, sma1303_set_ocp_h_put), -SOC_SINGLE("OCL Test(1:test_0:normal)", - SMA1303_0C_BST_TEST1, 5, 1, 0), -SOC_SINGLE("Loop Check(1:en_0:normal)", - SMA1303_0C_BST_TEST1, 4, 1, 0), -SOC_SINGLE("SH Protection(1:en_0:dis)", - SMA1303_0C_BST_TEST1, 3, 1, 0), -SOC_SINGLE("SPK OCP filter delay(1:Normal_0:Long)", - SMA1303_0D_SPK_TEST, 2, 1, 0), -SOC_ENUM_EXT("SPK turn off slope control", sma1303_spk_off_slope_enum, - sma1303_spk_off_slope_get, sma1303_spk_off_slope_put), -SOC_ENUM_EXT("Volume slope", sma1303_vol_slope_enum, - sma1303_vol_slope_get, sma1303_vol_slope_put), -SOC_ENUM_EXT("Mute slope", sma1303_mute_slope_enum, - sma1303_mute_slope_get, sma1303_mute_slope_put), -SOC_SINGLE("Speaker Mute Switch(1:muted_0:un)", - SMA1303_0E_MUTE_VOL_CTRL, 0, 1, 0), -SOC_ENUM_EXT("Speaker Mode", sma1303_spkmode_enum, +SOC_ENUM("Speaker Mute Switch", sma1303_spkmute_enum), +SOC_ENUM_EXT("Speaker Output", sma1303_spkmode_enum, sma1303_spkmode_get, sma1303_spkmode_put), -SOC_SINGLE("Speaker Bass(1:en_0:dis)", SMA1303_11_SYSTEM_CTRL2, 6, 1, 0), -SOC_SINGLE("Speaker Comp/Limiter(1:en_0:dis)", - SMA1303_11_SYSTEM_CTRL2, 5, 1, 0), -SOC_SINGLE("LR_DATA_SW(1:swap_0:normal)", SMA1303_11_SYSTEM_CTRL2, 4, 1, 0), -SOC_SINGLE("Mono Mix(1:en_0:dis)", SMA1303_11_SYSTEM_CTRL2, 0, 1, 0), -SOC_ENUM_EXT("Input gain", sma1303_input_gain_enum, - sma1303_input_gain_get, sma1303_input_gain_put), -SOC_ENUM_EXT("Input gain for right channel", sma1303_input_r_gain_enum, - sma1303_input_r_gain_get, sma1303_input_r_gain_put), -SOC_ENUM_EXT("Speaker HYSFB", sma1303_spk_hysfb_enum, - sma1303_spk_hysfb_get, sma1303_spk_hysfb_put), -SND_SOC_BYTES_EXT("Speaker BDELAY", 1, spk_bdelay_get, spk_bdelay_put), -SND_SOC_BYTES_EXT("Bass Boost SPK Coeff", 7, - bass_spk_coeff_get, bass_spk_coeff_put), -SND_SOC_BYTES_EXT("DRC SPK Coeff", 4, - comp_lim_spk_coeff_get, comp_lim_spk_coeff_put), -SOC_SINGLE("SPK modulator sync(1:1/8_0:1/4)", - SMA1303_33_SDM_CTRL, 2, 1, 0), -SOC_SINGLE("Edge displacement(1:dis_0:en)", - SMA1303_36_PROTECTION, 7, 1, 0), -SOC_ENUM_EXT("PWM LR delay", sma1303_lr_delay_enum, - sma1303_lr_delay_get, sma1303_lr_delay_put), -SOC_SINGLE("OCP spk output state(1:dis_0:en)", - SMA1303_36_PROTECTION, 3, 1, 0), -SOC_SINGLE("OCP mode(1:SD_0:AR)", - SMA1303_36_PROTECTION, 2, 1, 0), -SOC_ENUM_EXT("OTP mode", sma1303_otp_mode_enum, - sma1303_otp_mode_get, sma1303_otp_mode_put), -SND_SOC_BYTES_EXT("SlopeCTRL", 1, slope_ctrl_get, slope_ctrl_put), -SND_SOC_BYTES_EXT("Test mode(Test 1~3_ATEST 1~2)", - 5, test_mode_get, test_mode_put), -SND_SOC_BYTES_EXT("PLL Setting", 5, pll_setting_get, pll_setting_put), -SND_SOC_BYTES_EXT("PLL Power control", 1, pll_pd_ctrl_get, pll_pd_ctrl_put), -SOC_ENUM_EXT("Trimming of OTP Level(1:on_0:off)", sma1303_trm_lvl_enum, - sma1303_trm_lvl_get, sma1303_trm_lvl_put), -SOC_SINGLE("Low OCL mode(1:normal_0:low)", - SMA1303_8E_PLL_CTRL, 3, 1, 0), SND_SOC_BYTES_EXT("Postscaler Set", 1, postscaler_get, postscaler_put), -SOC_SINGLE("Postscaler(1:bypass_0:en)", - SMA1303_90_POSTSCALER, 0, 1, 0), -SOC_ENUM_EXT("Attack level control", sma1303_attack_lvl_enum, - sma1303_attack_lvl_get, sma1303_attack_lvl_put), -SOC_ENUM_EXT("Release time control", sma1303_release_time_enum, - sma1303_release_time_get, sma1303_release_time_put), -SOC_ENUM_EXT("Filtered VDD gain control", sma1303_flt_vdd_gain_enum, - sma1303_flt_vdd_gain_get, sma1303_flt_vdd_gain_put), -SOC_SINGLE("Fast charge(1:dis_0:en)", - SMA1303_92_FDPEC_CTRL, 2, 1, 0), -SOC_ENUM_EXT("Trimming of switching frequency", sma1303_trm_osc_enum, - sma1303_trm_osc_get, sma1303_trm_osc_put), -SOC_ENUM_EXT("Trimming of ramp compensation", sma1303_trm_rmp_enum, - sma1303_trm_rmp_get, sma1303_trm_rmp_put), -SOC_ENUM_EXT("Trimming of over current limit", sma1303_trm_ocl_enum, - sma1303_trm_ocl_get, sma1303_trm_ocl_put), -SOC_ENUM_EXT("Trimming of loop comp I gain", sma1303_trm_comp_i_enum, - sma1303_trm_comp_i_get, sma1303_trm_comp_i_put), -SOC_ENUM_EXT("Trimming of loop comp P gain", sma1303_trm_comp_p_enum, - sma1303_trm_comp_p_get, sma1303_trm_comp_p_put), -SOC_ENUM_EXT("Trimming of driver deadtime", sma1303_trm_dt_enum, - sma1303_trm_dt_get, sma1303_trm_dt_put), -SOC_ENUM_EXT("Trimming of switching slew", sma1303_trm_slw_enum, - sma1303_trm_slw_get, sma1303_trm_slw_put), -SOC_ENUM_EXT("Trimming of boost voltage", sma1303_trm_vbst_enum, - sma1303_trm_vbst_get, sma1303_trm_vbst_put), -SOC_ENUM_EXT("Trimming of minimum on-time", sma1303_trm_tmin_enum, - sma1303_trm_tmin_get, sma1303_trm_tmin_put), -SOC_SINGLE("PAD SDO(1:3mA_0:2mA)", - SMA1303_A0_PAD_CTRL0, 2, 1, 0), -SOC_SINGLE("PAD Input LRCK(1:on_0:off)", - SMA1303_A1_PAD_CTRL1, 5, 1, 0), -SOC_SINGLE("PAD Input SCK(1:on_0:off)", - SMA1303_A1_PAD_CTRL1, 4, 1, 0), -SOC_SINGLE("PAD Input SDI(1:on_0:off)", - SMA1303_A1_PAD_CTRL1, 3, 1, 0), -SOC_SINGLE("PAD Input SDO(1:on_0:off)", - SMA1303_A1_PAD_CTRL1, 2, 1, 0), -SOC_SINGLE("PAD Input SDA(1:on_0:off)", - SMA1303_A1_PAD_CTRL1, 1, 1, 0), -SOC_SINGLE("PAD Input SCL(1:on_0:off)", - SMA1303_A1_PAD_CTRL1, 0, 1, 0), -SOC_SINGLE("PLL Lock Skip Mode(1:dis_0:en)", - SMA1303_A2_TOP_MAN1, 7, 1, 0), -SOC_SINGLE("PLL Power Down(1:PD_0:oper)", - SMA1303_A2_TOP_MAN1, 6, 1, 0), -SOC_ENUM_EXT("PLL Test Divider at SDO", sma1303_pll_div_enum, - sma1303_pll_div_get, sma1303_pll_div_put), -SOC_SINGLE("PLL Ref Clk(1:SCK_0:PLL_REF_Clk1)", - SMA1303_A2_TOP_MAN1, 3, 1, 0), -SOC_SINGLE("DAC Down Conver(1:C_0:N)", - SMA1303_A2_TOP_MAN1, 2, 1, 0), -SOC_SINGLE("SDO Pad Output Ctrl(1:L_0:H)", - SMA1303_A2_TOP_MAN1, 1, 1, 0), -SOC_SINGLE("SDO_output2(1:only_0:normal)", - SMA1303_A2_TOP_MAN1, 0, 1, 0), -SOC_SINGLE("Monitoring at SDO(1:OSC_0:PLL)", - SMA1303_A3_TOP_MAN2, 7, 1, 0), -SOC_SINGLE("Test clk out en(1:Clk out_0:N)", - SMA1303_A3_TOP_MAN2, 6, 1, 0), -SOC_SINGLE("SDO output(1:H_0:N)", - SMA1303_A3_TOP_MAN2, 3, 1, 0), -SOC_SINGLE("Clk Monitor(1:Not_0:Mon)", - SMA1303_A3_TOP_MAN2, 1, 1, 0), -SOC_SINGLE("OSC PD(1:PD_0:N)", - SMA1303_A3_TOP_MAN2, 0, 1, 0), -SOC_ENUM_EXT("TOP Manager Output Format", sma1303_o_format_enum, +SOC_ENUM_EXT("Postscaler Config", sma1303_postscaler_config_enum, + sma1303_postscaler_config_get, sma1303_postscaler_config_put), +SOC_ENUM_EXT("Output Format", sma1303_o_format_enum, sma1303_o_format_get, sma1303_o_format_put), -SOC_ENUM_EXT("TOP Manager SCK rate", sma1303_sck_rate_enum, - sma1303_sck_rate_get, sma1303_sck_rate_put), -SOC_SINGLE("TOP Manager LRCK Pol(1:H_0:L)", - SMA1303_A4_TOP_MAN3, 0, 1, 0), -SOC_SINGLE("TDM clk pol(1:fall_0:rise)", - SMA1303_A5_TDM1, 7, 1, 0), -SOC_SINGLE("TDM Tx(1:stereo_0:mono)", - SMA1303_A5_TDM1, 6, 1, 0), -SOC_ENUM_EXT("TDM slot1 pos Rx", sma1303_tdm_slot1_rx_enum, - sma1303_tdm_slot1_rx_get, sma1303_tdm_slot1_rx_put), -SOC_ENUM_EXT("TDM slot2 pos Rx", sma1303_tdm_slot2_rx_enum, - sma1303_tdm_slot2_rx_get, sma1303_tdm_slot2_rx_put), -SOC_SINGLE("TDM Data Length(1:32_0:16)", - SMA1303_A6_TDM2, 7, 1, 0), -SOC_SINGLE("TDM n-slot(1:8_0:4)", - SMA1303_A6_TDM2, 6, 1, 0), -SOC_ENUM_EXT("TDM slot1 pos Tx", sma1303_tdm_slot1_tx_enum, - sma1303_tdm_slot1_tx_get, sma1303_tdm_slot1_tx_put), -SOC_ENUM_EXT("TDM slot2 pos Tx", sma1303_tdm_slot2_tx_enum, - sma1303_tdm_slot2_tx_get, sma1303_tdm_slot2_tx_put), -SOC_ENUM_EXT("Clk monitor time select", sma1303_clk_mon_time_sel_enum, - sma1303_clk_mon_time_sel_get, sma1303_clk_mon_time_sel_put), -SOC_SINGLE("Noise Gen mod(1:en_0:normal)", - SMA1303_A7_CLK_MON, 5, 1, 0), -SOC_SINGLE("Noise Gen post(1:en_0:normal)", - SMA1303_A7_CLK_MON, 4, 1, 0), -SOC_SINGLE("Limiter Oper Range(1:en_0:dis)", - SMA1303_A7_CLK_MON, 3, 1, 0), }; static int sma1303_startup(struct snd_soc_component *component) { struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = 0; if (sma1303->amp_power_status) { dev_info(component->dev, "%s : %s\n", __func__, "Already AMP Power on"); - return 0; + return ret; } - dev_info(component->dev, "%s : TRM_%s, FLT_%s\n", - __func__, sma1303_trm_vbst_text[sma1303->bst_vol_lvl_status], - sma1303_flt_vdd_gain_text[sma1303->flt_vdd_gain_status]); + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_8E_PLL_CTRL, PLL_PD2_MASK, PLL_OPERATION2); - regmap_update_bits(sma1303->regmap, SMA1303_8E_PLL_CTRL, - PLL_PD2_MASK, PLL_OPERATION2); + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_00_SYSTEM_CTRL, POWER_MASK, POWER_ON); - regmap_update_bits(sma1303->regmap, SMA1303_00_SYSTEM_CTRL, - POWER_MASK, POWER_ON); - - if (sma1303->stereo_two_chip == true) { - regmap_update_bits(sma1303->regmap, SMA1303_10_SYSTEM_CTRL1, - SPK_MODE_MASK, SPK_STEREO); - } else { - regmap_update_bits(sma1303->regmap, SMA1303_10_SYSTEM_CTRL1, - SPK_MODE_MASK, SPK_MONO); - } + if (sma1303->amp_mode == ONE_CHIP_SOLUTION) + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_10_SYSTEM_CTRL1, SPK_MODE_MASK, SPK_MONO); + else + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_10_SYSTEM_CTRL1, SPK_MODE_MASK, SPK_STEREO); if (sma1303->check_fault_status) { if (sma1303->check_fault_period > 0) @@ -2135,43 +951,44 @@ static int sma1303_startup(struct snd_soc_component *component) CHECK_PERIOD_TIME * HZ); } - regmap_update_bits(sma1303->regmap, SMA1303_0E_MUTE_VOL_CTRL, - SPK_MUTE_MASK, SPK_UNMUTE); + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_0E_MUTE_VOL_CTRL, SPK_MUTE_MASK, SPK_UNMUTE); sma1303->amp_power_status = true; - return 0; + return ret; } static int sma1303_shutdown(struct snd_soc_component *component) { struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = 0; if (!(sma1303->amp_power_status)) { dev_info(component->dev, "%s : %s\n", __func__, "Already AMP Shutdown"); - return 0; + return ret; } - regmap_update_bits(sma1303->regmap, SMA1303_0E_MUTE_VOL_CTRL, - SPK_MUTE_MASK, SPK_MUTE); + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_0E_MUTE_VOL_CTRL, SPK_MUTE_MASK, SPK_MUTE); cancel_delayed_work_sync(&sma1303->check_fault_work); msleep(55); - regmap_update_bits(sma1303->regmap, SMA1303_10_SYSTEM_CTRL1, - SPK_MODE_MASK, SPK_OFF); + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_10_SYSTEM_CTRL1, SPK_MODE_MASK, SPK_OFF); - regmap_update_bits(sma1303->regmap, SMA1303_00_SYSTEM_CTRL, - POWER_MASK, POWER_OFF); + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_00_SYSTEM_CTRL, POWER_MASK, POWER_OFF); - regmap_update_bits(sma1303->regmap, SMA1303_8E_PLL_CTRL, - PLL_PD2_MASK, PLL_PD2); + ret += sma1303_regmap_update_bits(sma1303->regmap, component->dev, + SMA1303_8E_PLL_CTRL, PLL_PD2_MASK, PLL_PD2); sma1303->amp_power_status = false; - return 0; + return ret; } static int sma1303_clk_supply_event(struct snd_soc_dapm_widget *w, @@ -2204,7 +1021,7 @@ static int sma1303_dac_event(struct snd_soc_dapm_widget *w, case SND_SOC_DAPM_PRE_PMU: dev_info(component->dev, "%s : PRE_PMU\n", __func__); - if (sma1303->force_amp_power_down == false) + if (sma1303->usage_status) sma1303_startup(component); break; @@ -2236,37 +1053,40 @@ static int sma1303_dac_feedback_event(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = 0; - if (!sma1303->sdo_bypass_flag) { - switch (event) { - case SND_SOC_DAPM_PRE_PMU: - dev_info(component->dev, - "%s : DAC feedback ON\n", __func__); - regmap_update_bits(sma1303->regmap, + switch (event) { + case SND_SOC_DAPM_PRE_PMU: + dev_info(component->dev, + "%s : DAC feedback ON\n", __func__); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, SMA1303_09_OUTPUT_CTRL, - PORT_CONFIG_MASK|PORT_OUT_SEL_MASK, - OUTPUT_PORT_ENABLE|SPEAKER_PATH); - regmap_update_bits(sma1303->regmap, - SMA1303_A3_TOP_MAN2, SDO_OUTPUT_MASK, - NORMAL_OUT); - break; + PORT_CONFIG_MASK|PORT_OUT_SEL_MASK, + OUTPUT_PORT_ENABLE|SPEAKER_PATH); - case SND_SOC_DAPM_PRE_PMD: - dev_info(component->dev, - "%s : DAC feedback OFF\n", __func__); - regmap_update_bits(sma1303->regmap, - SMA1303_09_OUTPUT_CTRL, PORT_OUT_SEL_MASK, - OUT_SEL_DISABLE); - regmap_update_bits(sma1303->regmap, - SMA1303_A3_TOP_MAN2, SDO_OUTPUT_MASK, - HIGH_Z_OUT); - break; - } - } else + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A3_TOP_MAN2, + SDO_OUTPUT_MASK, NORMAL_OUT); + break; + + case SND_SOC_DAPM_PRE_PMD: dev_info(component->dev, - "%s : Force SDO Setting Bypass\n", __func__); + "%s : DAC feedback OFF\n", __func__); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_09_OUTPUT_CTRL, + PORT_OUT_SEL_MASK, OUT_SEL_DISABLE); - return 0; + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A3_TOP_MAN2, SDO_OUTPUT_MASK, + HIGH_Z_OUT); + break; + } + + return ret; } static const struct snd_soc_dapm_widget sma1303_dapm_widgets[] = { @@ -2280,12 +1100,18 @@ SND_SOC_DAPM_ADC_E("DAC_FEEDBACK", "Capture", SND_SOC_NOPM, 0, 0, SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_PRE_PMD), SND_SOC_DAPM_OUTPUT("SPK"), SND_SOC_DAPM_INPUT("SDO"), +SND_SOC_DAPM_MUX("SDO Source", SND_SOC_NOPM, 0, 0, &sma1303_sdo_source_mux), }; static const struct snd_soc_dapm_route sma1303_audio_map[] = { {"DAC", NULL, "CLK_SUPPLY"}, {"SPK", NULL, "DAC"}, -{"DAC_FEEDBACK", NULL, "SDO"}, +{"SDO Source", "Disable", "SDO"}, +{"SDO Source", "Format_C", "SDO"}, +{"SDO Source", "Mixer_Out", "SDO"}, +{"SDO Source", "After_DSP", "SDO"}, +{"SDO Source", "After_Post", "SDO"}, +{"DAC_FEEDBACK", NULL, "SDO Source"}, }; static int sma1303_setup_pll(struct snd_soc_component *component, @@ -2293,7 +1119,7 @@ static int sma1303_setup_pll(struct snd_soc_component *component, { struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int i = 0; + int i = 0, ret = 0; dev_info(component->dev, "%s : BCLK = %dHz\n", __func__, bclk); @@ -2312,21 +1138,30 @@ static int sma1303_setup_pll(struct snd_soc_component *component, return -EINVAL; } - regmap_update_bits(sma1303->regmap, SMA1303_A2_TOP_MAN1, + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A2_TOP_MAN1, PLL_PD_MASK|PLL_REF_CLK_MASK, PLL_OPERATION|PLL_SCK); } - regmap_write(sma1303->regmap, SMA1303_8B_PLL_POST_N, + ret += sma1303_regmap_write(sma1303->regmap, component->dev, + SMA1303_8B_PLL_POST_N, sma1303->pll_matches[i].post_n); - regmap_write(sma1303->regmap, SMA1303_8C_PLL_N, + + ret += sma1303_regmap_write(sma1303->regmap, component->dev, + SMA1303_8C_PLL_N, sma1303->pll_matches[i].n); - regmap_write(sma1303->regmap, SMA1303_8D_PLL_A_SETTING, + + ret += sma1303_regmap_write(sma1303->regmap, component->dev, + SMA1303_8D_PLL_A_SETTING, sma1303->pll_matches[i].vco); - regmap_write(sma1303->regmap, SMA1303_8F_PLL_P_CP, + + ret += sma1303_regmap_write(sma1303->regmap, component->dev, + SMA1303_8F_PLL_P_CP, sma1303->pll_matches[i].p_cp); - return 0; + return ret; } static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, @@ -2336,6 +1171,7 @@ static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); unsigned int input_format = 0; unsigned int bclk = 0; + int ret = 0; if (sma1303->format == SND_SOC_DAIFMT_DSP_A) bclk = params_rate(params) * sma1303->frame_size; @@ -2350,7 +1186,7 @@ static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { - if (sma1303->force_amp_power_down == false && + if (sma1303->usage_status && (sma1303->sys_clk_id == SMA1303_PLL_CLKIN_MCLK || sma1303->sys_clk_id == SMA1303_PLL_CLKIN_BCLK)) { @@ -2375,16 +1211,26 @@ static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, case 44100: case 48000: case 96000: - regmap_update_bits(sma1303->regmap, SMA1303_A2_TOP_MAN1, + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A2_TOP_MAN1, DAC_DN_CONV_MASK, DAC_DN_CONV_DISABLE); - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, + + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, LEFTPOL_MASK, LOW_FIRST_CH); break; case 192000: - regmap_update_bits(sma1303->regmap, SMA1303_A2_TOP_MAN1, + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A2_TOP_MAN1, DAC_DN_CONV_MASK, DAC_DN_CONV_ENABLE); - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, + + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, LEFTPOL_MASK, HIGH_FIRST_CH); break; @@ -2392,7 +1238,7 @@ static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, dev_err(component->dev, "%s not support rate : %d\n", __func__, params_rate(params)); - return -EINVAL; + return -EINVAL; } } else { @@ -2403,14 +1249,30 @@ static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, dev_info(component->dev, "%s set format SNDRV_PCM_FORMAT_S16_LE\n", __func__); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A4_TOP_MAN3, + SCK_RATE_MASK, SCK_32FS); break; case SNDRV_PCM_FORMAT_S24_LE: dev_info(component->dev, "%s set format SNDRV_PCM_FORMAT_S24_LE\n", __func__); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A4_TOP_MAN3, + SCK_RATE_MASK, SCK_64FS); + break; + case SNDRV_PCM_FORMAT_S32_LE: + dev_info(component->dev, + "%s set format SNDRV_PCM_FORMAT_S32_LE\n", + __func__); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A4_TOP_MAN3, + SCK_RATE_MASK, SCK_64FS); break; - default: dev_err(component->dev, "%s not support data bit : %d\n", __func__, @@ -2434,6 +1296,7 @@ static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, } break; case 24: + case 32: switch (sma1303->format) { case SND_SOC_DAIFMT_I2S: input_format |= STANDARD_I2S; @@ -2454,10 +1317,11 @@ static int sma1303_dai_hw_params_amp(struct snd_pcm_substream *substream, return -EINVAL; } - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, - I2S_MODE_MASK, input_format); - - return 0; + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, + I2S_MODE_MASK, input_format); + return ret; } static int sma1303_dai_set_sysclk_amp(struct snd_soc_dai *dai, @@ -2487,29 +1351,34 @@ static int sma1303_dai_mute(struct snd_soc_dai *dai, int mute, int stream) { struct snd_soc_component *component = dai->component; struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = 0; if (stream == SNDRV_PCM_STREAM_CAPTURE) - return 0; + return ret; if (!(sma1303->amp_power_status)) { dev_info(component->dev, "%s : %s\n", __func__, "Already AMP Shutdown"); - return 0; + return ret; } if (mute) { dev_info(component->dev, "%s : %s\n", __func__, "MUTE"); - regmap_update_bits(sma1303->regmap, SMA1303_0E_MUTE_VOL_CTRL, - SPK_MUTE_MASK, SPK_MUTE); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_0E_MUTE_VOL_CTRL, + SPK_MUTE_MASK, SPK_MUTE); } else { dev_info(component->dev, "%s : %s\n", __func__, "UNMUTE"); - regmap_update_bits(sma1303->regmap, SMA1303_0E_MUTE_VOL_CTRL, - SPK_MUTE_MASK, SPK_UNMUTE); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_0E_MUTE_VOL_CTRL, + SPK_MUTE_MASK, SPK_UNMUTE); } - return 0; + return ret; } static int sma1303_dai_set_fmt_amp(struct snd_soc_dai *dai, @@ -2517,21 +1386,25 @@ static int sma1303_dai_set_fmt_amp(struct snd_soc_dai *dai, { struct snd_soc_component *component = dai->component; struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = 0; switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBS_CFS: dev_info(component->dev, "%s : %s\n", __func__, "I2S/TDM Device mode"); - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, CONTROLLER_DEVICE_MASK, DEVICE_MODE); - break; case SND_SOC_DAIFMT_CBM_CFM: dev_info(component->dev, "%s : %s\n", __func__, "I2S/TDM Controller mode"); - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, CONTROLLER_DEVICE_MASK, CONTROLLER_MODE); break; @@ -2561,21 +1434,27 @@ static int sma1303_dai_set_fmt_amp(struct snd_soc_dai *dai, case SND_SOC_DAIFMT_IB_NF: dev_info(component->dev, "%s : %s\n", __func__, "Invert BCLK + Normal Frame"); - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, - SCK_RISING_MASK, SCK_RISING_EDGE); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, + SCK_RISING_MASK, SCK_RISING_EDGE); break; case SND_SOC_DAIFMT_IB_IF: dev_info(component->dev, "%s : %s\n", __func__, "Invert BCLK + Invert Frame"); - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, - LEFTPOL_MASK|SCK_RISING_MASK, - HIGH_FIRST_CH|SCK_RISING_EDGE); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, + LEFTPOL_MASK|SCK_RISING_MASK, + HIGH_FIRST_CH|SCK_RISING_EDGE); break; case SND_SOC_DAIFMT_NB_IF: dev_info(component->dev, "%s : %s\n", __func__, "Normal BCLK + Invert Frame"); - regmap_update_bits(sma1303->regmap, SMA1303_01_INPUT1_CTRL1, - LEFTPOL_MASK, HIGH_FIRST_CH); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_01_INPUT1_CTRL1, + LEFTPOL_MASK, HIGH_FIRST_CH); break; case SND_SOC_DAIFMT_NB_NF: dev_info(component->dev, "%s : %s\n", @@ -2587,7 +1466,7 @@ static int sma1303_dai_set_fmt_amp(struct snd_soc_dai *dai, return -EINVAL; } - return 0; + return ret; } static int sma1303_dai_set_tdm_slot(struct snd_soc_dai *dai, @@ -2596,23 +1475,30 @@ static int sma1303_dai_set_tdm_slot(struct snd_soc_dai *dai, { struct snd_soc_component *component = dai->component; struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); + int ret = 0; dev_info(component->dev, "%s : slots = %d, slot_width - %d\n", __func__, slots, slot_width); sma1303->frame_size = slot_width * slots; - regmap_update_bits(sma1303->regmap, SMA1303_A4_TOP_MAN3, - O_FORMAT_MASK, O_FMT_TDM); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A4_TOP_MAN3, + O_FORMAT_MASK, O_FMT_TDM); switch (slot_width) { case 16: - regmap_update_bits(sma1303->regmap, SMA1303_A6_TDM2, - TDM_DL_MASK, TDM_DL_16); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A6_TDM2, + TDM_DL_MASK, TDM_DL_16); break; case 32: - regmap_update_bits(sma1303->regmap, SMA1303_A6_TDM2, - TDM_DL_MASK, TDM_DL_32); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A6_TDM2, + TDM_DL_MASK, TDM_DL_32); break; default: dev_err(component->dev, "%s not support TDM %d slot_width\n", @@ -2621,12 +1507,16 @@ static int sma1303_dai_set_tdm_slot(struct snd_soc_dai *dai, switch (slots) { case 4: - regmap_update_bits(sma1303->regmap, SMA1303_A6_TDM2, - TDM_N_SLOT_MASK, TDM_N_SLOT_4); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A6_TDM2, + TDM_N_SLOT_MASK, TDM_N_SLOT_4); break; case 8: - regmap_update_bits(sma1303->regmap, SMA1303_A6_TDM2, - TDM_N_SLOT_MASK, TDM_N_SLOT_8); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A6_TDM2, + TDM_N_SLOT_MASK, TDM_N_SLOT_8); break; default: dev_err(component->dev, "%s not support TDM %d slots\n", @@ -2634,26 +1524,34 @@ static int sma1303_dai_set_tdm_slot(struct snd_soc_dai *dai, } if (sma1303->tdm_slot_rx < slots) - regmap_update_bits(sma1303->regmap, - SMA1303_A5_TDM1, TDM_SLOT1_RX_POS_MASK, - (sma1303->tdm_slot_rx) << 3); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A5_TDM1, TDM_SLOT1_RX_POS_MASK, + (sma1303->tdm_slot_rx) << 3); else dev_err(component->dev, "%s Incorrect tdm-slot-rx %d set\n", __func__, sma1303->tdm_slot_rx); - regmap_update_bits(sma1303->regmap, SMA1303_A5_TDM1, - TDM_CLK_POL_MASK, TDM_CLK_POL_RISE); - regmap_update_bits(sma1303->regmap, SMA1303_A5_TDM1, - TDM_TX_MODE_MASK, TDM_TX_MONO); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A5_TDM1, + TDM_CLK_POL_MASK, TDM_CLK_POL_RISE); + + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A5_TDM1, + TDM_TX_MODE_MASK, TDM_TX_MONO); + if (sma1303->tdm_slot_tx < slots) - regmap_update_bits(sma1303->regmap, - SMA1303_A6_TDM2, TDM_SLOT1_TX_POS_MASK, - (sma1303->tdm_slot_tx) << 3); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_A6_TDM2, TDM_SLOT1_TX_POS_MASK, + (sma1303->tdm_slot_tx) << 3); else dev_err(component->dev, "%s Incorrect tdm-slot-tx %d set\n", __func__, sma1303->tdm_slot_tx); - return 0; + return ret; } static const struct snd_soc_dai_ops sma1303_dai_ops_amp = { @@ -2690,47 +1588,12 @@ static struct snd_soc_dai_driver sma1303_dai[] = { } }; -static int sma1303_set_bias_level(struct snd_soc_component *component, - enum snd_soc_bias_level level) -{ - switch (level) { - case SND_SOC_BIAS_ON: - - dev_info(component->dev, "%s\n", "SND_SOC_BIAS_ON"); - sma1303_startup(component); - - break; - - case SND_SOC_BIAS_PREPARE: - - dev_info(component->dev, "%s\n", "SND_SOC_BIAS_PREPARE"); - - break; - - case SND_SOC_BIAS_STANDBY: - - dev_info(component->dev, "%s\n", "SND_SOC_BIAS_STANDBY"); - - break; - - case SND_SOC_BIAS_OFF: - - dev_info(component->dev, "%s\n", "SND_SOC_BIAS_OFF"); - sma1303_shutdown(component); - - break; - } - - return 0; -} - static void sma1303_check_fault_worker(struct work_struct *work) { struct sma1303_priv *sma1303 = container_of(work, struct sma1303_priv, check_fault_work.work); - int ret; + int ret = 0; unsigned int over_temp, ocp_val, uvlo_val; - bool fault_val_flag = false; mutex_lock(&sma1303->lock); @@ -2777,14 +1640,15 @@ static void sma1303_check_fault_worker(struct work_struct *work) "%s : OT1(Over Temperature Level 1)\n", __func__); if ((sma1303->cur_vol + 6) <= 0xFF) - regmap_write(sma1303->regmap, + sma1303_regmap_write( + sma1303->regmap, sma1303->dev, SMA1303_0A_SPK_VOL, sma1303->cur_vol + 6); sma1303->tsdw_cnt++; - fault_val_flag = true; } else if (sma1303->tsdw_cnt) { - regmap_write(sma1303->regmap, - SMA1303_0A_SPK_VOL, sma1303->init_vol); + sma1303_regmap_write( + sma1303->regmap, sma1303->dev, + SMA1303_0A_SPK_VOL, sma1303->init_vol); sma1303->tsdw_cnt = 0; sma1303->cur_vol = sma1303->init_vol; } @@ -2792,27 +1656,22 @@ static void sma1303_check_fault_worker(struct work_struct *work) if (~over_temp & OT2_OK_STATUS) { dev_crit(sma1303->dev, "%s : OT2(Over Temperature Level 2)\n", __func__); - fault_val_flag = true; } if (ocp_val & OCP_SPK_STATUS) { dev_crit(sma1303->dev, "%s : OCP_SPK(Over Current Protect SPK)\n", __func__); - fault_val_flag = true; } if (ocp_val & OCP_BST_STATUS) { dev_crit(sma1303->dev, "%s : OCP_BST(Over Current Protect Boost)\n", __func__); - fault_val_flag = true; } if ((ocp_val & CLK_MON_STATUS) && (sma1303->amp_power_status)) { dev_crit(sma1303->dev, "%s : CLK_FAULT(No clock input)\n", __func__); - fault_val_flag = true; } if (uvlo_val & UVLO_BST_STATUS) { dev_crit(sma1303->dev, "%s : UVLO(Under Voltage Lock Out)\n", __func__); - fault_val_flag = true; } if ((over_temp != sma1303->last_over_temp) || @@ -2836,82 +1695,11 @@ static void sma1303_check_fault_worker(struct work_struct *work) CHECK_PERIOD_TIME * HZ); } - if (fault_val_flag && sma1303->fault_reg_flag) { - int i, j = 0; - char reg[256]; - char reg_str[12][50] = { }; - bool state; - - regmap_bulk_read(sma1303->regmap, - SMA1303_00_SYSTEM_CTRL, reg, ARRAY_SIZE(reg)); - dev_crit(sma1303->dev, "\n"); - dev_crit(sma1303->dev, "sma1303 register values\n"); - dev_crit(sma1303->dev, "\t 0\t1\t2\t3\t4\t5\t6\t7\t8\t9\tA\tB\tC\tD\tE\tF\n"); - dev_crit(sma1303->dev, "\t ---------------------------------------------------------------------------------------------------------\n"); - for (i = 0; i <= SMA1303_A7_CLK_MON; i++) { - switch (i) { - case SMA1303_00_SYSTEM_CTRL ... SMA1303_04_INPUT1_CTRL4: - case SMA1303_09_OUTPUT_CTRL - ... SMA1303_0E_MUTE_VOL_CTRL: - case SMA1303_10_SYSTEM_CTRL1 - ... SMA1303_12_SYSTEM_CTRL3: - case SMA1303_14_MODULATOR ... SMA1303_1B_BASS_SPK7: - case SMA1303_23_COMP_LIM1 ... SMA1303_26_COMP_LIM4: - case SMA1303_33_SDM_CTRL ... SMA1303_34_OTP_DATA1: - case SMA1303_36_PROTECTION ... SMA1303_38_OTP_TRM0: - case SMA1303_3B_TEST1 ... SMA1303_3F_ATEST2: - case SMA1303_8B_PLL_POST_N ... SMA1303_92_FDPEC_CTRL: - case SMA1303_94_BOOST_CTRL1 ... SMA1303_97_BOOST_CTRL4: - case SMA1303_A0_PAD_CTRL0 ... SMA1303_A7_CLK_MON: - state = true; - break; - default: - state = false; - } - if (state == false) - sprintf(reg_str[j], "%sX\t", reg_str[j]); - else - sprintf(reg_str[j], "%s%02X\t", - reg_str[j], reg[i]); - - if (i%16 == 15 || i == SMA1303_A7_CLK_MON) { - dev_crit(sma1303->dev, "%X |%s", - j, reg_str[j]); - j++; - } - } - - for (i = SMA1303_FA_STATUS1-10; - i <= SMA1303_FF_DEVICE_INDEX; i++) { - switch (i) { - case SMA1303_FA_STATUS1 ... SMA1303_FB_STATUS2: - case SMA1303_FF_DEVICE_INDEX: - state = true; - break; - default: - state = false; - } - if (state == false) - sprintf(reg_str[j], "%sX\t", reg_str[j]); - else - sprintf(reg_str[j], "%s%02X\t", - reg_str[j], reg[i]); - - if (i == SMA1303_FF_DEVICE_INDEX) { - dev_crit(sma1303->dev, "F |%s", reg_str[j]); - j++; - } - } - sma1303->fault_reg_flag = false; - } - if (!(~over_temp & OT1_OK_STATUS) && !(~over_temp & OT2_OK_STATUS) && !(ocp_val & OCP_SPK_STATUS) && !(ocp_val & OCP_BST_STATUS) && !(ocp_val & CLK_MON_STATUS) && !(uvlo_val & UVLO_BST_STATUS)) { - fault_val_flag = false; - sma1303->fault_reg_flag = true; } mutex_unlock(&sma1303->lock); @@ -2932,89 +1720,14 @@ static int sma1303_resume(struct snd_soc_component *component) #define sma1303_resume NULL #endif -static int sma1303_reset(struct snd_soc_component *component) -{ - struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); - int ret; - unsigned int status, otp_stat; - - regmap_update_bits(sma1303->regmap, - SMA1303_00_SYSTEM_CTRL, RESETBYI2C_MASK, RESETBYI2C_RESET); - - ret = regmap_read(sma1303->regmap, SMA1303_FF_DEVICE_INDEX, &status); - - if (ret != 0) - dev_err(sma1303->dev, - "failed to read SMA1303_FA_STATUS1 : %d\n", ret); - else - sma1303->rev_num = status & REV_NUM_STATUS; - - if (sma1303->rev_num == REV_NUM_TV0) - dev_info(component->dev, "SMA1303 Trimming Version 0\n"); - else if (sma1303->rev_num == REV_NUM_TV1) - dev_info(component->dev, "SMA1303 Trimming Version 1\n"); - - regmap_read(sma1303->regmap, SMA1303_FB_STATUS2, &otp_stat); - - if (((sma1303->rev_num == REV_NUM_TV0) && - ((otp_stat & 0x0E) == OTP_STAT_OK_0)) || - ((sma1303->rev_num != REV_NUM_TV0) && - ((otp_stat & 0x0C) == OTP_STAT_OK_1))) - dev_info(component->dev, "SMA1303 OTP Status Successful\n"); - else - dev_info(component->dev, "SMA1303 OTP Status Fail\n"); - - regmap_write(sma1303->regmap, SMA1303_00_SYSTEM_CTRL, 0x80); - regmap_write(sma1303->regmap, SMA1303_0A_SPK_VOL, sma1303->init_vol); - regmap_update_bits(sma1303->regmap, - SMA1303_0B_BST_TEST, BST_OFF_SLOPE_MASK, BST_OFF_SLOPE_2_6ns); - regmap_update_bits(sma1303->regmap, - SMA1303_0C_BST_TEST1, EN_SH_PRT_MASK, EN_SH_PRT_DISABLE); - regmap_write(sma1303->regmap, SMA1303_0E_MUTE_VOL_CTRL, 0x3F); - regmap_write(sma1303->regmap, SMA1303_10_SYSTEM_CTRL1, 0x04); - - if (sma1303->stereo_two_chip == true) { - regmap_update_bits(sma1303->regmap, - SMA1303_11_SYSTEM_CTRL2, MONOMIX_MASK, MONOMIX_OFF); - } else { - regmap_update_bits(sma1303->regmap, - SMA1303_11_SYSTEM_CTRL2, MONOMIX_MASK, MONOMIX_ON); - } - - regmap_write(sma1303->regmap, SMA1303_14_MODULATOR, 0x5c); - regmap_write(sma1303->regmap, SMA1303_3B_TEST1, 0x5A); - regmap_update_bits(sma1303->regmap, SMA1303_3C_TEST2, - SDM_SYNC_DIS_MASK, SDM_SYNC_DISABLE); - regmap_update_bits(sma1303->regmap, SMA1303_3F_ATEST2, - SPK_OUT_FREQ_MASK, SPK_OUT_FREQ_410K); - regmap_update_bits(sma1303->regmap, SMA1303_3F_ATEST2, - LOW_POWER_MODE_MASK, LOW_POWER_MODE_ENABLE); - regmap_write(sma1303->regmap, SMA1303_90_POSTSCALER, 0x26); - regmap_write(sma1303->regmap, SMA1303_91_CLASS_G_CTRL, 0x42); - regmap_write(sma1303->regmap, SMA1303_92_FDPEC_CTRL, 0xE0); - sma1303->flt_vdd_gain_status = (FLT_VDD_GAIN_3P10 >> 4); - regmap_write(sma1303->regmap, SMA1303_94_BOOST_CTRL1, 0x35); - regmap_write(sma1303->regmap, SMA1303_37_SLOPE_CTRL, 0x27); - regmap_write(sma1303->regmap, SMA1303_95_BOOST_CTRL2, 0x0C); - regmap_write(sma1303->regmap, SMA1303_97_BOOST_CTRL4, 0x95); - sma1303->bst_vol_lvl_status = (TRM_VBST_6P0 >> 2); - regmap_write(sma1303->regmap, SMA1303_96_BOOST_CTRL3, 0x42); - regmap_update_bits(sma1303->regmap, - SMA1303_A2_TOP_MAN1, PLL_LOCK_SKIP_MASK, - PLL_LOCK_DISABLE); - - dev_info(component->dev, - "%s init_vol is 0x%x\n", __func__, sma1303->init_vol); - - return 0; -} - static int sma1303_probe(struct snd_soc_component *component) { + struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component); char *dapm_widget_str = NULL; - int prefix_len = 0, str_max = 30; + int prefix_len = 0, str_max = 30, ret = 0, i = 0; + unsigned int status, otp_stat; if (component->name_prefix != NULL) { dev_info(component->dev, "%s : component name prefix - %s\n", @@ -3048,9 +1761,51 @@ static int sma1303_probe(struct snd_soc_component *component) snd_soc_dapm_sync(dapm); - sma1303_reset(component); + ret += sma1303_regmap_update_bits( + sma1303->regmap, component->dev, + SMA1303_00_SYSTEM_CTRL, + RESETBYI2C_MASK, RESETBYI2C_RESET); - return 0; + ret += regmap_read(sma1303->regmap, SMA1303_FF_DEVICE_INDEX, &status); + if (ret < 0) { + dev_err(sma1303->dev, + "failed to read, register: %02X, ret: %d\n", + SMA1303_FF_DEVICE_INDEX, ret); + return ret; + } + sma1303->rev_num = status & REV_NUM_STATUS; + if (sma1303->rev_num == REV_NUM_TV0) + dev_info(component->dev, "SMA1303 Trimming Version 0\n"); + else if (sma1303->rev_num == REV_NUM_TV1) + dev_info(component->dev, "SMA1303 Trimming Version 1\n"); + + ret += regmap_read(sma1303->regmap, SMA1303_FB_STATUS2, &otp_stat); + if (ret < 0) + dev_err(sma1303->dev, + "failed to read, register: %02X, ret: %d\n", + SMA1303_FF_DEVICE_INDEX, ret); + + if (((sma1303->rev_num == REV_NUM_TV0) && + ((otp_stat & 0x0E) == OTP_STAT_OK_0)) || + ((sma1303->rev_num != REV_NUM_TV0) && + ((otp_stat & 0x0C) == OTP_STAT_OK_1))) + dev_info(component->dev, "SMA1303 OTP Status Successful\n"); + else + dev_info(component->dev, "SMA1303 OTP Status Fail\n"); + + for (i = 0; i < (unsigned int)ARRAY_SIZE(sma1303_reg_def); i++) + ret += sma1303_regmap_write( + sma1303->regmap, component->dev, + sma1303_reg_def[i].reg, + sma1303_reg_def[i].def); + + ret += sma1303_regmap_write(sma1303->regmap, component->dev, + SMA1303_0A_SPK_VOL, sma1303->init_vol); + + dev_info(component->dev, + "%s init_vol is 0x%x\n", __func__, sma1303->init_vol); + + return ret; } static void sma1303_remove(struct snd_soc_component *component) @@ -3058,7 +1813,6 @@ static void sma1303_remove(struct snd_soc_component *component) struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); cancel_delayed_work_sync(&sma1303->check_fault_work); - sma1303_set_bias_level(component, SND_SOC_BIAS_OFF); } static const struct snd_soc_component_driver sma1303_component = { @@ -3195,29 +1949,6 @@ static int sma1303_i2c_probe(struct i2c_client *client, } if (np) { - if (!of_property_read_u32(np, "init-vol", &value)) { - dev_info(&client->dev, - "init_vol is 0x%x from DT\n", value); - sma1303->init_vol = value; - } else { - dev_info(&client->dev, - "init_vol is set with 0x31(-0.5dB)\n"); - sma1303->init_vol = 0x31; - } - if (of_property_read_bool(np, "stereo-two-chip")) { - dev_info(&client->dev, "Stereo for two chip solution\n"); - sma1303->stereo_two_chip = true; - } else { - dev_info(&client->dev, "Mono for one chip solution\n"); - sma1303->stereo_two_chip = false; - } - if (of_property_read_bool(np, "impossible-bst-ctrl")) { - dev_info(&client->dev, "Boost control setting is not possible\n"); - sma1303->impossible_bst_ctrl = true; - } else { - dev_info(&client->dev, "Boost control setting is possible\n"); - sma1303->impossible_bst_ctrl = false; - } if (!of_property_read_u32(np, "tdm-slot-rx", &value)) { dev_info(&client->dev, "tdm slot rx is '%d' from DT\n", value); @@ -3276,6 +2007,7 @@ static int sma1303_i2c_probe(struct i2c_client *client, sma1303->last_over_temp = 0xC0; sma1303->last_ocp_val = 0x0A; sma1303->tsdw_cnt = 0; + sma1303->init_vol = 0x31; sma1303->cur_vol = sma1303->init_vol; sma1303->last_bclk = 0; @@ -3291,11 +2023,10 @@ static int sma1303_i2c_probe(struct i2c_client *client, i2c_set_clientdata(client, sma1303); - sma1303->sdo_bypass_flag = false; - sma1303->force_amp_power_down = false; + sma1303->amp_mode = ONE_CHIP_SOLUTION; + sma1303->usage_status = true; sma1303->amp_power_status = false; sma1303->check_fault_status = true; - sma1303->fault_reg_flag = true; sma1303->pll_matches = sma1303_pll_matches; sma1303->num_of_pll_matches = ARRAY_SIZE(sma1303_pll_matches); diff --git a/sound/soc/codecs/sma1303.h b/sound/soc/codecs/sma1303.h index 377c8afbbed8..d1fa2acaba85 100644 --- a/sound/soc/codecs/sma1303.h +++ b/sound/soc/codecs/sma1303.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later * sma1303.h -- sma1303 ALSA SoC Audio driver * - * Copyright 2019 Silicon Mitus Corporation / Iron Device Corporation + * Copyright 2022 Iron Device Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -21,6 +21,11 @@ #define SMA1303_PLL_CLKIN_MCLK 0x02 #define SMA1303_PLL_CLKIN_BCLK 0x03 +#define ONE_CHIP_SOLUTION 0x00 +#define MONO_TWO_CHIP_SOLUTION 0x01 +#define LEFT_TWO_CHIP_SOLUTION 0x02 +#define RIGHT_TWO_CHIP_SOLUTION 0x03 + /* * SMA1303 Register Definition */ -- 2.30.2

3 4

[PATCH] ASoC: MAINTAINERS: add bindings and APR to Qualcomm Audio entry
by Krzysztof Kozlowski 15 Sep '22

15 Sep '22

Extend the Qualcomm Audio maintainer entry to include sound related bindings and the Qualcomm APR/GPR (Asynchronous/Generic Packet Router) IPC driver, which is tightly related to the Audio DSP. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0350effebe8f..453dc6fd0b80 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16710,6 +16710,9 @@ M: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> M: Banajit Goswami <bgoswami(a)quicinc.com> L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) S: Supported +F: Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml +F: Documentation/devicetree/bindings/sound/qcom,* +F: drivers/soc/qcom/apr.c F: include/dt-bindings/sound/qcom,wcd9335.h F: sound/soc/codecs/lpass-rx-macro.* F: sound/soc/codecs/lpass-tx-macro.* -- 2.34.1

2 1

[linux-next:master] BUILD REGRESSION f117c01187301a087412bd6697fcf5463cb427d8
by kernel test robot 14 Sep '22

14 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: f117c01187301a087412bd6697fcf5463cb427d8 Add linux-next specific files for 20220914 Error/Warning reports: https://lore.kernel.org/linux-mm/202209150141.WgbAKqmX-lkp@intel.com https://lore.kernel.org/llvm/202209141913.Nxzv3hwM-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) ERROR: modpost: "devm_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined! ERROR: modpost: "devm_memremap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_memunmap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/char/xillybus/xillybus_of.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/clk/xilinx/clk-xlnx-clock-wizard.ko] undefined! ERROR: modpost: "ioremap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/tty/ipwireless/ipwireless.ko] undefined! arch/parisc/lib/iomap.c:363:5: warning: no previous prototype for 'ioread64_lo_hi' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:373:5: warning: no previous prototype for 'ioread64_hi_lo' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:448:6: warning: no previous prototype for 'iowrite64_lo_hi' [-Wmissing-prototypes] arch/parisc/lib/iomap.c:454:6: warning: no previous prototype for 'iowrite64_hi_lo' [-Wmissing-prototypes] drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encoder_state() instead drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration] drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration] sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-allyesconfig | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-randconfig-r043-20220914 | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm-allyesconfig | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm-buildonly-randconfig-r003-20220914 | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm-defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arm64-allyesconfig | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm64-randconfig-r036-20220914 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-allyesconfig | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- i386-defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-randconfig-a003 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-randconfig-a012 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-randconfig-a014 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-randconfig-a016 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- ia64-allmodconfig | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | `-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast |-- ia64-randconfig-r013-20220914 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- loongarch-randconfig-r026-20220914 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- m68k-allmodconfig | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- m68k-allyesconfig clang_recent_errors |-- arm-randconfig-r032-20220914 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- arm64-randconfig-r021-20220914 | `-- arch-arm64-kernel-alternative.c:warning:no-previous-prototype-for-function-apply_alternatives_vdso |-- i386-randconfig-a002 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- i386-randconfig-a015 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- powerpc-randconfig-r022-20220914 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- riscv-randconfig-r042-20220914 | |-- arch-riscv-errata-thead-errata.c:error:use-of-undeclared-identifier-riscv_cbom_block_size | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- s390-randconfig-r044-20220914 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- x86_64-randconfig-a003 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- x86_64-randconfig-a012 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead `-- x86_64-randconfig-a016 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 726m configs tested: 62 configs skipped: 2 gcc tested configs: x86_64 defconfig x86_64 rhel-8.3 x86_64 allyesconfig i386 randconfig-a001 i386 randconfig-a003 x86_64 randconfig-a004 um i386_defconfig x86_64 randconfig-a002 i386 randconfig-a005 arc defconfig um x86_64_defconfig x86_64 randconfig-a006 s390 allmodconfig i386 defconfig powerpc allmodconfig alpha defconfig s390 defconfig mips allyesconfig s390 allyesconfig powerpc allnoconfig sh allmodconfig arc randconfig-r043-20220914 arm defconfig x86_64 randconfig-a013 x86_64 randconfig-a011 i386 randconfig-a014 x86_64 rhel-8.3-func x86_64 rhel-8.3-kunit i386 randconfig-a012 i386 allyesconfig x86_64 rhel-8.3-kvm i386 randconfig-a016 x86_64 randconfig-a015 x86_64 rhel-8.3-kselftests x86_64 rhel-8.3-syz arc allyesconfig alpha allyesconfig m68k allmodconfig m68k allyesconfig ia64 allmodconfig arm allyesconfig arm64 allyesconfig arc allnoconfig alpha allnoconfig riscv allnoconfig csky allnoconfig clang tested configs: i386 randconfig-a002 i386 randconfig-a004 x86_64 randconfig-a001 x86_64 randconfig-a003 i386 randconfig-a006 x86_64 randconfig-a005 riscv randconfig-r042-20220914 hexagon randconfig-r045-20220914 hexagon randconfig-r041-20220914 i386 randconfig-a013 x86_64 randconfig-a016 s390 randconfig-r044-20220914 i386 randconfig-a011 x86_64 randconfig-a012 i386 randconfig-a015 x86_64 randconfig-a014 -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[PATCH] ASoC: codecs: ak4458: only perform reset if any bits actually changed
by Martin Pietryka 14 Sep '22

14 Sep '22

This reduces the amount of small audio artifacts that happen when a reset is performed as documented in the data-sheet. Signed-off-by: Martin Pietryka <martin.pietryka(a)streamunlimited.com> --- sound/soc/codecs/ak4458.c | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index ea33cc83c86c..741c2b69d238 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -349,6 +349,7 @@ static int ak4458_hw_params(struct snd_pcm_substream *substream, int pcm_width = max(params_physical_width(params), ak4458->slot_width); u8 format, dsdsel0, dsdsel1, dchn; int nfs1, dsd_bclk, ret, channels, channels_max; + int needs_reset = 0; nfs1 = params_rate(params); ak4458->fs = nfs1; @@ -391,15 +392,16 @@ static int ak4458_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - snd_soc_component_update_bits(component, AK4458_06_DSD1, - AK4458_DSDSEL_MASK, dsdsel0); - snd_soc_component_update_bits(component, AK4458_09_DSD2, - AK4458_DSDSEL_MASK, dsdsel1); + needs_reset |= snd_soc_component_update_bits(component, AK4458_06_DSD1, + AK4458_DSDSEL_MASK, dsdsel0); + needs_reset |= snd_soc_component_update_bits(component, AK4458_09_DSD2, + AK4458_DSDSEL_MASK, dsdsel1); break; } /* Master Clock Frequency Auto Setting Mode Enable */ - snd_soc_component_update_bits(component, AK4458_00_CONTROL1, 0x80, 0x80); + needs_reset |= snd_soc_component_update_bits(component, AK4458_00_CONTROL1, + 0x80, 0x80); switch (pcm_width) { case 16: @@ -433,8 +435,8 @@ static int ak4458_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - snd_soc_component_update_bits(component, AK4458_00_CONTROL1, - AK4458_DIF_MASK, format); + needs_reset |= snd_soc_component_update_bits(component, AK4458_00_CONTROL1, + AK4458_DIF_MASK, format); /* * Enable/disable Daisy Chain if in TDM mode and the number of played @@ -444,16 +446,18 @@ static int ak4458_hw_params(struct snd_pcm_substream *substream, (ak4458->fmt == SND_SOC_DAIFMT_DSP_B) && (channels > channels_max) ? AK4458_DCHAIN_MASK : 0; - snd_soc_component_update_bits(component, AK4458_0B_CONTROL7, - AK4458_DCHAIN_MASK, dchn); + needs_reset |= snd_soc_component_update_bits(component, AK4458_0B_CONTROL7, + AK4458_DCHAIN_MASK, dchn); - ret = ak4458_rstn_control(component, 0); - if (ret) - return ret; + if (needs_reset) { + ret = ak4458_rstn_control(component, 0); + if (ret) + return ret; - ret = ak4458_rstn_control(component, 1); - if (ret) - return ret; + ret = ak4458_rstn_control(component, 1); + if (ret) + return ret; + } return 0; } -- 2.37.3

2 1

[PATCH -next 1/3] ASoC: bcm2835-i2s: Switch to use dev_err_probe() helper
by Yang Yingliang 14 Sep '22

14 Sep '22

dev_err/dev_dbg() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/bcm/bcm2835-i2s.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c index f4d84774dac7..85f705afcdbb 100644 --- a/sound/soc/bcm/bcm2835-i2s.c +++ b/sound/soc/bcm/bcm2835-i2s.c @@ -841,14 +841,9 @@ static int bcm2835_i2s_probe(struct platform_device *pdev) /* get the clock */ dev->clk_prepared = false; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - ret = PTR_ERR(dev->clk); - if (ret == -EPROBE_DEFER) - dev_dbg(&pdev->dev, "could not get clk: %d\n", ret); - else - dev_err(&pdev->dev, "could not get clk: %d\n", ret); - return ret; - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "could not get clk\n"); /* Request ioarea */ base = devm_platform_ioremap_resource(pdev, 0); -- 2.25.1

2 3

[PATCH] ASoC: eureka-tlv320: Hold reference returned from of_find_xxx API
by Liang He 14 Sep '22

14 Sep '22

In eukrea_tlv320_probe(), we need to hold the reference returned from of_find_compatible_node() which has increased the refcount and then call of_node_put() with it when done. Fixes: 66f232908de2 ("ASoC: eukrea-tlv320: Add DT support.") Co-authored-by: Kelin Wang <wangkelin2023(a)163.com> Signed-off-by: Liang He <windhl(a)126.com> --- sound/soc/fsl/eukrea-tlv320.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/eukrea-tlv320.c b/sound/soc/fsl/eukrea-tlv320.c index 8b61582753c8..9af4c4a35eb1 100644 --- a/sound/soc/fsl/eukrea-tlv320.c +++ b/sound/soc/fsl/eukrea-tlv320.c @@ -86,7 +86,7 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) int ret; int int_port = 0, ext_port; struct device_node *np = pdev->dev.of_node; - struct device_node *ssi_np = NULL, *codec_np = NULL; + struct device_node *ssi_np = NULL, *codec_np = NULL, *tmp_np = NULL; eukrea_tlv320.dev = &pdev->dev; if (np) { @@ -143,7 +143,7 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) } if (machine_is_eukrea_cpuimx27() || - of_find_compatible_node(NULL, NULL, "fsl,imx21-audmux")) { + (tmp_np = of_find_compatible_node(NULL, NULL, "fsl,imx21-audmux"))) { imx_audmux_v1_configure_port(MX27_AUDMUX_HPCR1_SSI0, IMX_AUDMUX_V1_PCR_SYN | IMX_AUDMUX_V1_PCR_TFSDIR | @@ -158,10 +158,11 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) IMX_AUDMUX_V1_PCR_SYN | IMX_AUDMUX_V1_PCR_RXDSEL(MX27_AUDMUX_HPCR1_SSI0) ); + of_node_put(tmp_np); } else if (machine_is_eukrea_cpuimx25sd() || machine_is_eukrea_cpuimx35sd() || machine_is_eukrea_cpuimx51sd() || - of_find_compatible_node(NULL, NULL, "fsl,imx31-audmux")) { + (tmp_np = of_find_compatible_node(NULL, NULL, "fsl,imx31-audmux"))) { if (!np) ext_port = machine_is_eukrea_cpuimx25sd() ? 4 : 3; @@ -178,6 +179,7 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) IMX_AUDMUX_V2_PTCR_SYN, IMX_AUDMUX_V2_PDCR_RXDSEL(int_port) ); + of_node_put(tmp_np); } else { if (np) { /* The eukrea,asoc-tlv320 driver was explicitly -- 2.25.1

2 1

[PATCH v3 0/5] soundwire: Fixes for spurious and missing UNATTACH
by Richard Fitzgerald 14 Sep '22

14 Sep '22

The bus and cadence code has several bugs that cause UNATTACH notifications to either be sent spuriously or to be missed. These can be seen occasionally with a single peripheral on the bus, but are much more frequent with multiple peripherals, where several peripherals could change state and report in consecutive PINGs. The root of all of these bugs seems to be a code design flaw that assumed every PING status change would be handled separately. However, PINGs are handled by a workqueue function and there is no guarantee when that function will be scheduled to run or how much CPU time it will receive. PINGs will continue while the work function is handling a snapshot of a previous PING so the code must take account that (a) status could change during the work function and (b) there can be a backlog of changes before the IRQ work function runs again. Tested with 4 peripherals on 1 bus, and 8 peripherals on 2 buses. CHANGES SINCE V2: #4 Add a comment explaining why INTMASK isn't cleared when going around the update_status loop. #5 Leave the existing error handling in sdw_program_device_num(), instead of suppressing the error return. Add a comment in sdw_handle_slave_status() explaining why the error is ignored. Re-word the explanation of why sdw_handle_slave_status() must only return early if it programmed a device ID. Richard Fitzgerald (4): soundwire: bus: Don't lose unattach notifications soundwire: bus: Don't re-enumerate before status is UNATTACHED soundwire: cadence: Fix lost ATTACHED interrupts when enumerating soundwire: bus: Don't exit early if no device IDs were programmed Simon Trimmer (1): soundwire: cadence: fix updating slave status when a bus has multiple peripherals drivers/soundwire/bus.c | 44 +++++++++++++--- drivers/soundwire/cadence_master.c | 80 ++++++++++++++++-------------- 2 files changed, 80 insertions(+), 44 deletions(-) -- 2.30.2

2 9

[PATCH v2] ASoC: rockchip: i2s: use regmap_read_poll_timeout to poll I2S_CLR
by Judy Hsiao 14 Sep '22

14 Sep '22

Use regmap_read_poll_timeout to poll I2S_CLR. It also fixes the 'rockchip-i2s ff070000.i2s; fail to clear' when the read of I2S_CLR exceeds the retry limit. Fixes: 0ff9f8b9f592 ("ASoC: rockchip: i2s: Fix error code when fail to read I2S_CLR") Signed-off-by: Judy Hsiao <judyhsiao(a)chromium.org> Reviewed-by: Brian Norris <briannorris(a)chromium.org> --- changes in v2: - Remove unused variables. - Refine debug messages. sound/soc/rockchip/rockchip_i2s.c | 41 ++++++++++++------------------- 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index f5f3540a9e18..28c86f5e435e 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -126,7 +126,6 @@ static inline struct rk_i2s_dev *to_info(struct snd_soc_dai *dai) static int rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on) { unsigned int val = 0; - int retry = 10; int ret = 0; spin_lock(&i2s->lock); @@ -163,18 +162,14 @@ static int rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on) I2S_CLR_TXC | I2S_CLR_RXC); if (ret < 0) goto end; - regmap_read(i2s->regmap, I2S_CLR, &val); - - /* Should wait for clear operation to finish */ - while (val) { - regmap_read(i2s->regmap, I2S_CLR, &val); - retry--; - if (!retry) { - dev_warn(i2s->dev, "fail to clear\n"); - ret = -EBUSY; - break; - } - } + ret = regmap_read_poll_timeout(i2s->regmap, + I2S_CLR, + val, + val != 0, + 20, + 200); + if (ret < 0) + dev_warn(i2s->dev, "fail to clear: %d\n", ret); } } end: @@ -188,7 +183,6 @@ static int rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on) static int rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) { unsigned int val = 0; - int retry = 10; int ret = 0; spin_lock(&i2s->lock); @@ -226,17 +220,14 @@ static int rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) I2S_CLR_TXC | I2S_CLR_RXC); if (ret < 0) goto end; - regmap_read(i2s->regmap, I2S_CLR, &val); - /* Should wait for clear operation to finish */ - while (val) { - regmap_read(i2s->regmap, I2S_CLR, &val); - retry--; - if (!retry) { - dev_warn(i2s->dev, "fail to clear\n"); - ret = -EBUSY; - break; - } - } + ret = regmap_read_poll_timeout(i2s->regmap, + I2S_CLR, + val, + val != 0, + 20, + 200); + if (ret < 0) + dev_warn(i2s->dev, "fail to clear: %d\n", ret); } } end: -- 2.37.2.789.g6183377224-goog

2 1

[PATCH] ASoC: tas2562: Propagate the error in tas2562_dac_event()
by Fabio Estevam 14 Sep '22

14 Sep '22

From: Fabio Estevam <festevam(a)denx.de> Since commit 2848d34c3ba1 ("ASoC: tas2562: Fix mute/unmute") the following build warning is seen: sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Fix the warning by returning the 'ret' variable. Fixes: 2848d34c3ba1 ("ASoC: tas2562: Fix mute/unmute") Signed-off-by: Fabio Estevam <festevam(a)denx.de> --- sound/soc/codecs/tas2562.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index 66149055aba9..b486d0bd86c9 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -439,7 +439,7 @@ static int tas2562_dac_event(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); struct tas2562_data *tas2562 = snd_soc_component_get_drvdata(component); - int ret; + int ret = 0; switch (event) { case SND_SOC_DAPM_POST_PMU: @@ -455,7 +455,7 @@ static int tas2562_dac_event(struct snd_soc_dapm_widget *w, return -EINVAL; } - return 0; + return ret; } static int tas2562_volume_control_get(struct snd_kcontrol *kcontrol, -- 2.25.1

3 2

[PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec
by Gaosheng Cui 14 Sep '22

14 Sep '22

In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n, gcc warns about an unused variable: sound/soc/intel/skylake/skl.c: In function ‘probe_codec’: sound/soc/intel/skylake/skl.c:729:18: error: unused variable ‘skl’ [-Werror=unused-variable] struct skl_dev *skl = bus_to_skl(bus); ^~~ cc1: all warnings being treated as errors Fixes: 3fd63658caed9 ("ASoC: Intel: Drop hdac_ext usage for codec device creation") Signed-off-by: Gaosheng Cui <cuigaosheng1(a)huawei.com> --- sound/soc/intel/skylake/skl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index c7c1cad2a753..52a041d6144c 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -726,8 +726,8 @@ static int probe_codec(struct hdac_bus *bus, int addr) unsigned int cmd = (addr << 28) | (AC_NODE_ROOT << 20) | (AC_VERB_PARAMETERS << 8) | AC_PAR_VENDOR_ID; unsigned int res = -1; - struct skl_dev *skl = bus_to_skl(bus); #if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC) + struct skl_dev *skl = bus_to_skl(bus); struct hdac_hda_priv *hda_codec; #endif struct hda_codec *codec; -- 2.25.1

4 6

[PATCH] ASoC: dt-bindings: qcom,q6afe: remove binding
by Krzysztof Kozlowski 14 Sep '22

14 Sep '22

qcom,q6afe is already documented in soc/qcom/qcom,apr.yaml. The version-based compatibles ("qcom,q6afe-v<MAJOR-NUMBER>.<MINOR-NUMBER>") are not used (neither in upstream nor in downstream DTS). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- .../devicetree/bindings/sound/qcom,q6afe.txt | 20 ------------------- 1 file changed, 20 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.txt diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt deleted file mode 100644 index bc6b5f1fe4f1..000000000000 --- a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt +++ /dev/null @@ -1,20 +0,0 @@ -Qualcomm Audio Front End (Q6AFE) binding - -AFE is one of the APR audio service on Q6DSP -Please refer to qcom,apr.txt for details of the common apr service bindings -used by all apr services. Must contain the following properties. - -- compatible: - Usage: required - Value type: <stringlist> - Definition: must be "qcom,q6afe-v<MAJOR-NUMBER>.<MINOR-NUMBER>" - Or "qcom,q6afe" where the version number can be queried - from DSP. - example "qcom,q6afe" - -= EXAMPLE - -apr-service@4 { - compatible = "qcom,q6afe"; - reg = <APR_SVC_AFE>; -}; -- 2.34.1

3 2

[PATCH 1/2] ASoC: nau8825: Add ADCOUT IO drive strength control
by David Lin 14 Sep '22

14 Sep '22

Add a property to control the driving of ADCOUT. Signed-off-by: David Lin <CTLIN0(a)nuvoton.com> --- sound/soc/codecs/nau8825.c | 6 ++++++ sound/soc/codecs/nau8825.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 8213273f501e..b3cdbe884c05 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1983,6 +1983,10 @@ static void nau8825_init_regs(struct nau8825 *nau8825) /* Disable short Frame Sync detection logic */ regmap_update_bits(regmap, NAU8825_REG_LEFT_TIME_SLOT, NAU8825_DIS_FS_SHORT_DET, NAU8825_DIS_FS_SHORT_DET); + /* ADCDAT IO drive strength control */ + regmap_update_bits(regmap, NAU8825_REG_CHARGE_PUMP, + NAU8825_ADCOUT_DS_MASK, + nau8825->adcout_ds << NAU8825_ADCOUT_DS_SFT); } static const struct regmap_config nau8825_regmap_config = { @@ -2521,6 +2525,7 @@ static void nau8825_print_device_properties(struct nau8825 *nau8825) nau8825->jack_eject_debounce); dev_dbg(dev, "crosstalk-enable: %d\n", nau8825->xtalk_enable); + dev_dbg(dev, "adcout-drive-strong: %d\n", nau8825->adcout_ds); } static int nau8825_read_device_properties(struct device *dev, @@ -2587,6 +2592,7 @@ static int nau8825_read_device_properties(struct device *dev, nau8825->jack_eject_debounce = 0; nau8825->xtalk_enable = device_property_read_bool(dev, "nuvoton,crosstalk-enable"); + nau8825->adcout_ds = device_property_read_bool(dev, "nuvoton,adcout-drive-strong"); nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) { diff --git a/sound/soc/codecs/nau8825.h b/sound/soc/codecs/nau8825.h index 887bbff03ec6..6d112b6145df 100644 --- a/sound/soc/codecs/nau8825.h +++ b/sound/soc/codecs/nau8825.h @@ -418,6 +418,8 @@ #define NAU8825_POWERUP_HP_DRV_L (1 << 0) /* CHARGE_PUMP (0x80) */ +#define NAU8825_ADCOUT_DS_SFT 12 +#define NAU8825_ADCOUT_DS_MASK (1 << NAU8825_ADCOUT_DS_SFT) #define NAU8825_JAMNODCLOW (1 << 10) #define NAU8825_POWER_DOWN_DACR (1 << 9) #define NAU8825_POWER_DOWN_DACL (1 << 8) @@ -477,6 +479,7 @@ struct nau8825 { int imp_rms[NAU8825_XTALK_IMM]; int xtalk_enable; bool xtalk_baktab_initialized; /* True if initialized. */ + bool adcout_ds; }; int nau8825_enable_jack_detect(struct snd_soc_component *component, -- 2.25.1

2 2

[PATCH v2] ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5570 laptop
by acheronfail 14 Sep '22

14 Sep '22

The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the previous Precision 5560. I replicated that patch onto this one, and can confirm that the audio is much better (the woofers are now working); I've tested it on my Dell Precision 5570. Signed-off-by: Callum Osmotherly <callum.osmotherly(a)gmail.com> --- Thanks to Takashi for helping me out with the right formatting! --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 799f6bf266dd..b0ad4856b877 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9130,6 +9130,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK), + SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), -- 2.37.3

2 1

[PATCH AUTOSEL 4.14 1/8] ASoC: nau8824: Fix semaphore unbalance at error paths
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 5628560e90395d3812800a8e44a01c32ffa429ec ] The semaphore of nau8824 wasn't properly unlocked at some error handling code paths, hence this may result in the unbalance (and potential lock-up). Fix them to handle the semaphore up properly. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Link: https://lore.kernel.org/r/20220823081000.2965-3-tiwai@suse.de Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/nau8824.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index e8ea51247b179..cc745374b8288 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1015,6 +1015,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, struct snd_soc_codec *codec = dai->codec; struct nau8824 *nau8824 = snd_soc_codec_get_drvdata(codec); unsigned int val_len = 0, osr, ctrl_val, bclk_fs, bclk_div; + int err = -EINVAL; nau8824_sema_acquire(nau8824, HZ); @@ -1031,7 +1032,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_DAC_OVERSAMPLE_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_DAC_SRC_MASK, osr_dac_sel[osr].clk_src << NAU8824_CLK_DAC_SRC_SFT); @@ -1041,7 +1042,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_ADC_SYNC_DOWN_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_ADC_SRC_MASK, osr_adc_sel[osr].clk_src << NAU8824_CLK_ADC_SRC_SFT); @@ -1062,7 +1063,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, else if (bclk_fs <= 256) bclk_div = 0; else - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_2, NAU8824_I2S_LRC_DIV_MASK | NAU8824_I2S_BLK_DIV_MASK, @@ -1083,15 +1084,17 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, val_len |= NAU8824_I2S_DL_32; break; default: - return -EINVAL; + goto error; } regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DL_MASK, val_len); + err = 0; + error: nau8824_sema_release(nau8824); - return 0; + return err; } static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1100,8 +1103,6 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) struct nau8824 *nau8824 = snd_soc_codec_get_drvdata(codec); unsigned int ctrl1_val = 0, ctrl2_val = 0; - nau8824_sema_acquire(nau8824, HZ); - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: ctrl2_val |= NAU8824_I2S_MS_MASTER; @@ -1143,6 +1144,8 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } + nau8824_sema_acquire(nau8824, HZ); + regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DF_MASK | NAU8824_I2S_BP_MASK | NAU8824_I2S_PCMB_EN, ctrl1_val); -- 2.35.1

1 2

[PATCH AUTOSEL 4.19 1/9] ASoC: nau8824: Fix semaphore unbalance at error paths
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 5628560e90395d3812800a8e44a01c32ffa429ec ] The semaphore of nau8824 wasn't properly unlocked at some error handling code paths, hence this may result in the unbalance (and potential lock-up). Fix them to handle the semaphore up properly. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Link: https://lore.kernel.org/r/20220823081000.2965-3-tiwai@suse.de Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/nau8824.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 4af87340b1655..4f18bb272e929 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1075,6 +1075,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int val_len = 0, osr, ctrl_val, bclk_fs, bclk_div; + int err = -EINVAL; nau8824_sema_acquire(nau8824, HZ); @@ -1091,7 +1092,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_DAC_OVERSAMPLE_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_DAC_SRC_MASK, osr_dac_sel[osr].clk_src << NAU8824_CLK_DAC_SRC_SFT); @@ -1101,7 +1102,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_ADC_SYNC_DOWN_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_ADC_SRC_MASK, osr_adc_sel[osr].clk_src << NAU8824_CLK_ADC_SRC_SFT); @@ -1122,7 +1123,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, else if (bclk_fs <= 256) bclk_div = 0; else - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_2, NAU8824_I2S_LRC_DIV_MASK | NAU8824_I2S_BLK_DIV_MASK, @@ -1143,15 +1144,17 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, val_len |= NAU8824_I2S_DL_32; break; default: - return -EINVAL; + goto error; } regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DL_MASK, val_len); + err = 0; + error: nau8824_sema_release(nau8824); - return 0; + return err; } static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1160,8 +1163,6 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int ctrl1_val = 0, ctrl2_val = 0; - nau8824_sema_acquire(nau8824, HZ); - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: ctrl2_val |= NAU8824_I2S_MS_MASTER; @@ -1203,6 +1204,8 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } + nau8824_sema_acquire(nau8824, HZ); + regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DF_MASK | NAU8824_I2S_BP_MASK | NAU8824_I2S_PCMB_EN, ctrl1_val); -- 2.35.1

1 2

[PATCH AUTOSEL 5.4 01/12] ASoC: nau8824: Fix semaphore unbalance at error paths
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 5628560e90395d3812800a8e44a01c32ffa429ec ] The semaphore of nau8824 wasn't properly unlocked at some error handling code paths, hence this may result in the unbalance (and potential lock-up). Fix them to handle the semaphore up properly. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Link: https://lore.kernel.org/r/20220823081000.2965-3-tiwai@suse.de Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/nau8824.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index c8ccfa2fff848..a95fe3fff1db8 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1072,6 +1072,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int val_len = 0, osr, ctrl_val, bclk_fs, bclk_div; + int err = -EINVAL; nau8824_sema_acquire(nau8824, HZ); @@ -1088,7 +1089,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_DAC_OVERSAMPLE_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_DAC_SRC_MASK, osr_dac_sel[osr].clk_src << NAU8824_CLK_DAC_SRC_SFT); @@ -1098,7 +1099,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_ADC_SYNC_DOWN_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_ADC_SRC_MASK, osr_adc_sel[osr].clk_src << NAU8824_CLK_ADC_SRC_SFT); @@ -1119,7 +1120,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, else if (bclk_fs <= 256) bclk_div = 0; else - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_2, NAU8824_I2S_LRC_DIV_MASK | NAU8824_I2S_BLK_DIV_MASK, @@ -1140,15 +1141,17 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, val_len |= NAU8824_I2S_DL_32; break; default: - return -EINVAL; + goto error; } regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DL_MASK, val_len); + err = 0; + error: nau8824_sema_release(nau8824); - return 0; + return err; } static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1157,8 +1160,6 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int ctrl1_val = 0, ctrl2_val = 0; - nau8824_sema_acquire(nau8824, HZ); - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: ctrl2_val |= NAU8824_I2S_MS_MASTER; @@ -1200,6 +1201,8 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } + nau8824_sema_acquire(nau8824, HZ); + regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DF_MASK | NAU8824_I2S_BP_MASK | NAU8824_I2S_PCMB_EN, ctrl1_val); -- 2.35.1

1 3

[PATCH AUTOSEL 5.10 01/13] ASoC: nau8824: Fix semaphore unbalance at error paths
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 5628560e90395d3812800a8e44a01c32ffa429ec ] The semaphore of nau8824 wasn't properly unlocked at some error handling code paths, hence this may result in the unbalance (and potential lock-up). Fix them to handle the semaphore up properly. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Link: https://lore.kernel.org/r/20220823081000.2965-3-tiwai@suse.de Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/nau8824.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index c8ccfa2fff848..a95fe3fff1db8 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1072,6 +1072,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int val_len = 0, osr, ctrl_val, bclk_fs, bclk_div; + int err = -EINVAL; nau8824_sema_acquire(nau8824, HZ); @@ -1088,7 +1089,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_DAC_OVERSAMPLE_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_DAC_SRC_MASK, osr_dac_sel[osr].clk_src << NAU8824_CLK_DAC_SRC_SFT); @@ -1098,7 +1099,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_ADC_SYNC_DOWN_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_ADC_SRC_MASK, osr_adc_sel[osr].clk_src << NAU8824_CLK_ADC_SRC_SFT); @@ -1119,7 +1120,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, else if (bclk_fs <= 256) bclk_div = 0; else - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_2, NAU8824_I2S_LRC_DIV_MASK | NAU8824_I2S_BLK_DIV_MASK, @@ -1140,15 +1141,17 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, val_len |= NAU8824_I2S_DL_32; break; default: - return -EINVAL; + goto error; } regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DL_MASK, val_len); + err = 0; + error: nau8824_sema_release(nau8824); - return 0; + return err; } static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1157,8 +1160,6 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int ctrl1_val = 0, ctrl2_val = 0; - nau8824_sema_acquire(nau8824, HZ); - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: ctrl2_val |= NAU8824_I2S_MS_MASTER; @@ -1200,6 +1201,8 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } + nau8824_sema_acquire(nau8824, HZ); + regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DF_MASK | NAU8824_I2S_BP_MASK | NAU8824_I2S_PCMB_EN, ctrl1_val); -- 2.35.1

1 3

[PATCH AUTOSEL 5.15 10/16] ALSA: usb-audio: Fix an out-of-bounds bug in __snd_usb_parse_audio_interface()
by Sasha Levin 14 Sep '22

14 Sep '22

From: Dongxiang Ke <kdx.glider(a)gmail.com> [ Upstream commit e53f47f6c1a56d2af728909f1cb894da6b43d9bf ] There may be a bad USB audio device with a USB ID of (0x04fa, 0x4201) and the number of it's interfaces less than 4, an out-of-bounds read bug occurs when parsing the interface descriptor for this device. Fix this by checking the number of interfaces. Signed-off-by: Dongxiang Ke <kdx.glider(a)gmail.com> Link: https://lore.kernel.org/r/20220906024928.10951-1-kdx.glider@gmail.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/usb/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/stream.c b/sound/usb/stream.c index ceb93d798182c..40ce8a1cb318a 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1105,7 +1105,7 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, * Dallas DS4201 workaround: It presents 5 altsettings, but the last * one misses syncpipe, and does not produce any sound. */ - if (chip->usb_id == USB_ID(0x04fa, 0x4201)) + if (chip->usb_id == USB_ID(0x04fa, 0x4201) && num >= 4) num = 4; for (i = 0; i < num; i++) { -- 2.35.1

1 0

[PATCH AUTOSEL 5.15 09/16] ALSA: hda/tegra: Align BDL entry to 4KB boundary
by Sasha Levin 14 Sep '22

14 Sep '22

From: Mohan Kumar <mkumard(a)nvidia.com> [ Upstream commit 8d44e6044a0e885acdd01813768a0b27906d64fd ] AZA HW may send a burst read/write request crossing 4K memory boundary. The 4KB boundary is not guaranteed by Tegra HDA HW. Make SW change to include the flag AZX_DCAPS_4K_BDLE_BOUNDARY to align BDLE to 4K boundary. Signed-off-by: Mohan Kumar <mkumard(a)nvidia.com> Link: https://lore.kernel.org/r/20220905172420.3801-1-mkumard@nvidia.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/pci/hda/hda_tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c index 773f4903550a0..f0e556f2ccf69 100644 --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -451,7 +451,8 @@ MODULE_DEVICE_TABLE(of, hda_tegra_match); static int hda_tegra_probe(struct platform_device *pdev) { const unsigned int driver_flags = AZX_DCAPS_CORBRP_SELF_CLEAR | - AZX_DCAPS_PM_RUNTIME; + AZX_DCAPS_PM_RUNTIME | + AZX_DCAPS_4K_BDLE_BOUNDARY; struct snd_card *card; struct azx *chip; struct hda_tegra *hda; -- 2.35.1

1 0

[PATCH AUTOSEL 5.15 08/16] ALSA: hda/sigmatel: Keep power up while beep is enabled
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 414d38ba871092aeac4ed097ac4ced89486646f7 ] It seems that the beep playback doesn't work well on IDT codec devices when the codec auto-pm is enabled. Keep the power on while the beep switch is enabled. Link: https://bugzilla.suse.com/show_bug.cgi?id=1200544 Link: https://lore.kernel.org/r/20220904072750.26164-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/pci/hda/patch_sigmatel.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 61df4d33c48ff..066bfccd25877 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -209,6 +209,7 @@ struct sigmatel_spec { /* beep widgets */ hda_nid_t anabeep_nid; + bool beep_power_on; /* SPDIF-out mux */ const char * const *spdif_labels; @@ -4443,6 +4444,26 @@ static int stac_suspend(struct hda_codec *codec) return 0; } + +static int stac_check_power_status(struct hda_codec *codec, hda_nid_t nid) +{ + struct sigmatel_spec *spec = codec->spec; + int ret = snd_hda_gen_check_power_status(codec, nid); + +#ifdef CONFIG_SND_HDA_INPUT_BEEP + if (nid == spec->gen.beep_nid && codec->beep) { + if (codec->beep->enabled != spec->beep_power_on) { + spec->beep_power_on = codec->beep->enabled; + if (spec->beep_power_on) + snd_hda_power_up_pm(codec); + else + snd_hda_power_down_pm(codec); + } + ret |= spec->beep_power_on; + } +#endif + return ret; +} #else #define stac_suspend NULL #endif /* CONFIG_PM */ @@ -4455,6 +4476,7 @@ static const struct hda_codec_ops stac_patch_ops = { .unsol_event = snd_hda_jack_unsol_event, #ifdef CONFIG_PM .suspend = stac_suspend, + .check_power_status = stac_check_power_status, #endif }; -- 2.35.1

1 0

[PATCH AUTOSEL 5.15 02/16] ASoC: nau8824: Fix semaphore unbalance at error paths
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 5628560e90395d3812800a8e44a01c32ffa429ec ] The semaphore of nau8824 wasn't properly unlocked at some error handling code paths, hence this may result in the unbalance (and potential lock-up). Fix them to handle the semaphore up properly. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Link: https://lore.kernel.org/r/20220823081000.2965-3-tiwai@suse.de Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/nau8824.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index f7018f2dd21fd..27589900f4fbf 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1042,6 +1042,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int val_len = 0, osr, ctrl_val, bclk_fs, bclk_div; + int err = -EINVAL; nau8824_sema_acquire(nau8824, HZ); @@ -1058,7 +1059,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_DAC_OVERSAMPLE_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_DAC_SRC_MASK, osr_dac_sel[osr].clk_src << NAU8824_CLK_DAC_SRC_SFT); @@ -1068,7 +1069,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_ADC_SYNC_DOWN_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_ADC_SRC_MASK, osr_adc_sel[osr].clk_src << NAU8824_CLK_ADC_SRC_SFT); @@ -1089,7 +1090,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, else if (bclk_fs <= 256) bclk_div = 0; else - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_2, NAU8824_I2S_LRC_DIV_MASK | NAU8824_I2S_BLK_DIV_MASK, @@ -1110,15 +1111,17 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, val_len |= NAU8824_I2S_DL_32; break; default: - return -EINVAL; + goto error; } regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DL_MASK, val_len); + err = 0; + error: nau8824_sema_release(nau8824); - return 0; + return err; } static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1127,8 +1130,6 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int ctrl1_val = 0, ctrl2_val = 0; - nau8824_sema_acquire(nau8824, HZ); - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: ctrl2_val |= NAU8824_I2S_MS_MASTER; @@ -1170,6 +1171,8 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } + nau8824_sema_acquire(nau8824, HZ); + regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DF_MASK | NAU8824_I2S_BP_MASK | NAU8824_I2S_PCMB_EN, ctrl1_val); -- 2.35.1

1 0

[PATCH AUTOSEL 5.19 14/22] ALSA: usb-audio: Fix an out-of-bounds bug in __snd_usb_parse_audio_interface()
by Sasha Levin 14 Sep '22

14 Sep '22

From: Dongxiang Ke <kdx.glider(a)gmail.com> [ Upstream commit e53f47f6c1a56d2af728909f1cb894da6b43d9bf ] There may be a bad USB audio device with a USB ID of (0x04fa, 0x4201) and the number of it's interfaces less than 4, an out-of-bounds read bug occurs when parsing the interface descriptor for this device. Fix this by checking the number of interfaces. Signed-off-by: Dongxiang Ke <kdx.glider(a)gmail.com> Link: https://lore.kernel.org/r/20220906024928.10951-1-kdx.glider@gmail.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/usb/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/stream.c b/sound/usb/stream.c index ceb93d798182c..40ce8a1cb318a 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1105,7 +1105,7 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, * Dallas DS4201 workaround: It presents 5 altsettings, but the last * one misses syncpipe, and does not produce any sound. */ - if (chip->usb_id == USB_ID(0x04fa, 0x4201)) + if (chip->usb_id == USB_ID(0x04fa, 0x4201) && num >= 4) num = 4; for (i = 0; i < num; i++) { -- 2.35.1

1 0

[PATCH AUTOSEL 5.19 13/22] ALSA: hda/tegra: Align BDL entry to 4KB boundary
by Sasha Levin 14 Sep '22

14 Sep '22

From: Mohan Kumar <mkumard(a)nvidia.com> [ Upstream commit 8d44e6044a0e885acdd01813768a0b27906d64fd ] AZA HW may send a burst read/write request crossing 4K memory boundary. The 4KB boundary is not guaranteed by Tegra HDA HW. Make SW change to include the flag AZX_DCAPS_4K_BDLE_BOUNDARY to align BDLE to 4K boundary. Signed-off-by: Mohan Kumar <mkumard(a)nvidia.com> Link: https://lore.kernel.org/r/20220905172420.3801-1-mkumard@nvidia.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/pci/hda/hda_tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c index 7debb2c76aa62..976a112c7d006 100644 --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -474,7 +474,8 @@ MODULE_DEVICE_TABLE(of, hda_tegra_match); static int hda_tegra_probe(struct platform_device *pdev) { const unsigned int driver_flags = AZX_DCAPS_CORBRP_SELF_CLEAR | - AZX_DCAPS_PM_RUNTIME; + AZX_DCAPS_PM_RUNTIME | + AZX_DCAPS_4K_BDLE_BOUNDARY; struct snd_card *card; struct azx *chip; struct hda_tegra *hda; -- 2.35.1

1 0

[PATCH AUTOSEL 5.19 11/22] ALSA: hda/sigmatel: Keep power up while beep is enabled
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 414d38ba871092aeac4ed097ac4ced89486646f7 ] It seems that the beep playback doesn't work well on IDT codec devices when the codec auto-pm is enabled. Keep the power on while the beep switch is enabled. Link: https://bugzilla.suse.com/show_bug.cgi?id=1200544 Link: https://lore.kernel.org/r/20220904072750.26164-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/pci/hda/patch_sigmatel.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 61df4d33c48ff..066bfccd25877 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -209,6 +209,7 @@ struct sigmatel_spec { /* beep widgets */ hda_nid_t anabeep_nid; + bool beep_power_on; /* SPDIF-out mux */ const char * const *spdif_labels; @@ -4443,6 +4444,26 @@ static int stac_suspend(struct hda_codec *codec) return 0; } + +static int stac_check_power_status(struct hda_codec *codec, hda_nid_t nid) +{ + struct sigmatel_spec *spec = codec->spec; + int ret = snd_hda_gen_check_power_status(codec, nid); + +#ifdef CONFIG_SND_HDA_INPUT_BEEP + if (nid == spec->gen.beep_nid && codec->beep) { + if (codec->beep->enabled != spec->beep_power_on) { + spec->beep_power_on = codec->beep->enabled; + if (spec->beep_power_on) + snd_hda_power_up_pm(codec); + else + snd_hda_power_down_pm(codec); + } + ret |= spec->beep_power_on; + } +#endif + return ret; +} #else #define stac_suspend NULL #endif /* CONFIG_PM */ @@ -4455,6 +4476,7 @@ static const struct hda_codec_ops stac_patch_ops = { .unsol_event = snd_hda_jack_unsol_event, #ifdef CONFIG_PM .suspend = stac_suspend, + .check_power_status = stac_check_power_status, #endif }; -- 2.35.1

1 0

[PATCH AUTOSEL 5.19 06/22] ASoC: fsl_aud2htx: Add error handler for pm_runtime_enable
by Sasha Levin 14 Sep '22

14 Sep '22

From: Shengjiu Wang <shengjiu.wang(a)nxp.com> [ Upstream commit b1cd3fd42db7593a2d24c06f1c53b8c886592080 ] Call pm_runtime_disable() when error happens in probe() Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Link: https://lore.kernel.org/r/1661430460-5234-2-git-send-email-shengjiu.wang@nx… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/fsl/fsl_aud2htx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_aud2htx.c b/sound/soc/fsl/fsl_aud2htx.c index e09015e7e3c7c..38f3863739f4d 100644 --- a/sound/soc/fsl/fsl_aud2htx.c +++ b/sound/soc/fsl/fsl_aud2htx.c @@ -240,6 +240,7 @@ static int fsl_aud2htx_probe(struct platform_device *pdev) ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); if (ret) { dev_err(&pdev->dev, "failed to pcm register\n"); + pm_runtime_disable(&pdev->dev); return ret; } @@ -248,6 +249,7 @@ static int fsl_aud2htx_probe(struct platform_device *pdev) &fsl_aud2htx_dai, 1); if (ret) { dev_err(&pdev->dev, "failed to register ASoC DAI\n"); + pm_runtime_disable(&pdev->dev); return ret; } -- 2.35.1

1 0

[PATCH AUTOSEL 5.19 05/22] ASoC: fsl_aud2htx: register platform component before registering cpu dai
by Sasha Levin 14 Sep '22

14 Sep '22

From: Shengjiu Wang <shengjiu.wang(a)nxp.com> [ Upstream commit ea532c29972df96fda20393d9bf057e898f5e965 ] There is no defer probe when adding platform component to snd_soc_pcm_runtime(rtd), the code is in snd_soc_add_pcm_runtime() snd_soc_register_card() -> snd_soc_bind_card() -> snd_soc_add_pcm_runtime() -> adding cpu dai -> adding codec dai -> adding platform component. So if the platform component is not ready at that time, then the sound card still registered successfully, but platform component is empty, the sound card can't be used. As there is defer probe checking for cpu dai component, then register platform component before cpu dai to avoid such issue. And the behavior of imx_pcm_dma_init() is same as common devm_snd_dmaengine_pcm_register(), so use devm_snd_dmaengine_pcm_register() instead Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Link: https://lore.kernel.org/r/1661430460-5234-1-git-send-email-shengjiu.wang@nx… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/fsl/fsl_aud2htx.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_aud2htx.c b/sound/soc/fsl/fsl_aud2htx.c index 422922146f2a5..e09015e7e3c7c 100644 --- a/sound/soc/fsl/fsl_aud2htx.c +++ b/sound/soc/fsl/fsl_aud2htx.c @@ -233,6 +233,16 @@ static int fsl_aud2htx_probe(struct platform_device *pdev) regcache_cache_only(aud2htx->regmap, true); + /* + * Register platform component before registering cpu dai for there + * is not defer probe for platform component in snd_soc_add_pcm_runtime(). + */ + ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); + if (ret) { + dev_err(&pdev->dev, "failed to pcm register\n"); + return ret; + } + ret = devm_snd_soc_register_component(&pdev->dev, &fsl_aud2htx_component, &fsl_aud2htx_dai, 1); @@ -241,10 +251,6 @@ static int fsl_aud2htx_probe(struct platform_device *pdev) return ret; } - ret = imx_pcm_dma_init(pdev); - if (ret) - dev_err(&pdev->dev, "failed to init imx pcm dma: %d\n", ret); - return ret; } -- 2.35.1

1 0

[PATCH AUTOSEL 5.19 03/22] ASoC: nau8824: Fix semaphore unbalance at error paths
by Sasha Levin 14 Sep '22

14 Sep '22

From: Takashi Iwai <tiwai(a)suse.de> [ Upstream commit 5628560e90395d3812800a8e44a01c32ffa429ec ] The semaphore of nau8824 wasn't properly unlocked at some error handling code paths, hence this may result in the unbalance (and potential lock-up). Fix them to handle the semaphore up properly. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Link: https://lore.kernel.org/r/20220823081000.2965-3-tiwai@suse.de Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/nau8824.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 2a7c935085353..c263858745ee2 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1043,6 +1043,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int val_len = 0, osr, ctrl_val, bclk_fs, bclk_div; + int err = -EINVAL; nau8824_sema_acquire(nau8824, HZ); @@ -1059,7 +1060,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_DAC_OVERSAMPLE_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_DAC_SRC_MASK, osr_dac_sel[osr].clk_src << NAU8824_CLK_DAC_SRC_SFT); @@ -1069,7 +1070,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, osr &= NAU8824_ADC_SYNC_DOWN_MASK; if (nau8824_clock_check(nau8824, substream->stream, nau8824->fs, osr)) - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_CLK_DIVIDER, NAU8824_CLK_ADC_SRC_MASK, osr_adc_sel[osr].clk_src << NAU8824_CLK_ADC_SRC_SFT); @@ -1090,7 +1091,7 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, else if (bclk_fs <= 256) bclk_div = 0; else - return -EINVAL; + goto error; regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_2, NAU8824_I2S_LRC_DIV_MASK | NAU8824_I2S_BLK_DIV_MASK, @@ -1111,15 +1112,17 @@ static int nau8824_hw_params(struct snd_pcm_substream *substream, val_len |= NAU8824_I2S_DL_32; break; default: - return -EINVAL; + goto error; } regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DL_MASK, val_len); + err = 0; + error: nau8824_sema_release(nau8824); - return 0; + return err; } static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1128,8 +1131,6 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); unsigned int ctrl1_val = 0, ctrl2_val = 0; - nau8824_sema_acquire(nau8824, HZ); - switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: ctrl2_val |= NAU8824_I2S_MS_MASTER; @@ -1171,6 +1172,8 @@ static int nau8824_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } + nau8824_sema_acquire(nau8824, HZ); + regmap_update_bits(nau8824->regmap, NAU8824_REG_PORT0_I2S_PCM_CTRL_1, NAU8824_I2S_DF_MASK | NAU8824_I2S_BP_MASK | NAU8824_I2S_PCMB_EN, ctrl1_val); -- 2.35.1

1 0

[PATCH linux-next] soundwire: intel: Remove unused parameter ret
by cgel.zte＠gmail.com 14 Sep '22

14 Sep '22

From: Jinpeng Cui <cui.jinpeng2(a)zte.com.cn> The parameter ret = 0 has not been used. Return 0 directly instead of returning ret. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: Jinpeng Cui <cui.jinpeng2(a)zte.com.cn> --- drivers/soundwire/intel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index b006ae6efcb0..26fdf3577454 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -395,7 +395,6 @@ static int intel_shim_init(struct sdw_intel *sdw, bool clock_stop) { void __iomem *shim = sdw->link_res->shim; unsigned int link_id = sdw->instance; - int ret = 0; u16 ioctl = 0, act = 0; mutex_lock(sdw->link_res->shim_lock); @@ -427,7 +426,7 @@ static int intel_shim_init(struct sdw_intel *sdw, bool clock_stop) mutex_unlock(sdw->link_res->shim_lock); - return ret; + return 0; } static void intel_shim_wake(struct sdw_intel *sdw, bool wake_enable) -- 2.25.1

2 1

[PATCH] ALSA: patch_realtek: Fix Dell Inspiron Plus 16
by Philipp Jungkamp 14 Sep '22

14 Sep '22

The Dell Inspiron Plus 16 has top speakers connected on NID 0x17, which the codec reports as unconnected. These speakers should be connected to the DAC on NID 0x03. --- I don't possess this Laptop myself. The owner of this Laptop reports that the speakers are now active, though there are still problem's. > There are still 2 small issues present: > 1. 0,5s delay before the top speakers turn on > 2. Popping sound from headphones 5s after the music stops playing > and afterwards when it starts playing again. This can be fixed by > disabling power save on the audio driver [...]. I've only written this patch because the issue seemed similar to that on my Lenovo Yoga 9 14IAP7. sound/pci/hda/patch_realtek.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 38930cf5aace..e6f229e418c3 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6896,6 +6896,32 @@ static void alc287_fixup_yoga9_14iap7_bass_spk_pin(struct hda_codec *codec, } } +static void alc295_fixup_dell_inspiron_top_speakers(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + static const struct hda_pintbl pincfgs[] = { + { 0x14, 0x90170151 }, + { 0x17, 0x90170150 }, + { } + }; + static const hda_nid_t conn[] = { 0x02, 0x03 }; + static const hda_nid_t preferred_pairs[] = { + 0x14, 0x02, + 0x17, 0x03, + 0x21, 0x02, + 0 + }; + struct alc_spec *spec = codec->spec; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + snd_hda_apply_pincfgs(codec, pincfgs); + snd_hda_override_conn_list(codec, 0x17, ARRAY_SIZE(conn), conn); + spec->gen.preferred_dacs = preferred_pairs; + break; + } +} + enum { ALC269_FIXUP_GPIO2, ALC269_FIXUP_SONY_VAIO, @@ -7137,6 +7163,7 @@ enum { ALC287_FIXUP_LEGION_16ITHG6, ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK, ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN, + ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS, }; /* A special fixup for Lenovo C940 and Yoga Duet 7; @@ -9066,6 +9093,12 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK, }, + [ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc295_fixup_dell_inspiron_top_speakers, + .chained = true, + .chain_id = ALC269_FIXUP_DELL4_MIC_NO_PRESENCE, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -9165,6 +9198,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK), + SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), -- 2.37.3

2 1

[PATCH] ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5560 laptop
by acheronfail 14 Sep '22

14 Sep '22

This is my first patch, so let me know if I need to do anything differently. :) The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the previous Precision 5560. I replicated that patch onto this one, and can confirm that the audio is much better (the woofers are now working); I've tested it on my Dell Precision 5570. --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 799f6bf266dd..b0ad4856b877 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9130,6 +9130,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK), + SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), -- 2.37.3

2 1

RE: [PATCH 1/2] ASoC: sma1303: Add driver for Iron Device SMA1303 Amp
by Ki-Seok Jo 14 Sep '22

14 Sep '22

Dear Mark Brown, Thanks for your detailed feedback. I'm so late in replying. COVID-19 is going around again in Korea. I also suffered from COVID-19 this time. Please take care of yourself from COVID-19. Anyway, I proceeded with the update again by referring to your review. And I added my opinion to the following. Please check the below. If there is anything wrong, please give me a feedback again. Thank you for your patience and cooperation. Best regards, Ki Seok Jo Iron Device Corporation Tel.: +82-2-541-2896 Mobile: +82-10-3320-0376 Email: kiseok.jo(a)irondevice.com The information in this email and any attachment is confidential and may be legally protected. It is intended solely for the addressee. Access to this email by anyone else is unauthorised. If you are not the intended recipient, any disclosure or actions taken as a result of the information in this email is prohibited and may be unlawful. If you are not the intended recipient, please notify us immediately and then delete this e-mail and any attachment. -----Original Message----- From: Mark Brown <broonie(a)kernel.org> Sent: Wednesday, August 17, 2022 9:09 PM To: Ki-Seok Jo <kiseok.jo(a)irondevice.com> Cc: Gyu-Hwa Park <gyuhwa.park(a)irondevice.com>; alsa-devel(a)alsa-project.org; Suk-Min Kang <sukmin.kang(a)irondevice.com> Subject: Re: [PATCH 1/2] ASoC: sma1303: Add driver for Iron Device SMA1303 Amp On Wed, Aug 17, 2022 at 12:29:37PM +0900, Kiseok Jo wrote: I got part way through reviewing this driver. The top level feedback here is that the driver appears to be exposing everything in the device to userspace as enumeration controls rather than using standard features like DAPM, or appropriate other control types where there's something that's a better fit than an enum. If there's a strong reason for the driver to do something so unusual then theere should be something in here which explains what's going on. # To solve the any issue by changing the value whenever there is a problem during use, we registered to control all functions. # Since the verification was completed by mass production with the corresponding setting, we removed the controls in the userspace except for a few things as you mentioned. > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* sma1303.c -- sma1303 ALSA SoC Audio driver > + * > + * Copyright 2019 Iron Device Corporation 2019? # I missed this point. Thank you! # Changed 2019 to 2022. Please make the entire block a C++ one so things look more intentional. # I have modified the code a bit. I'm sorry, but I couldn't figure out exactly what you were talking about. # If there is anything that needs to be corrected, please reply again. > +static int power_up_down_control_put(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) { > + struct snd_soc_component *component = > + snd_soc_kcontrol_component(kcontrol); > + struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); > + int sel = (int)ucontrol->value.integer.value[0]; > + > + if (sel && !(sma1303->force_amp_power_down)) > + sma1303_startup(component); > + else > + sma1303_shutdown(component); > + > + return 0; > +} This and all the other controls need to return 1 on change, please make sure a card with your driver your driver passes mixer-test cleanly - it will spot this and other problems. # Added the return value for checking error. # It's ok if the value is '0', and if a problem occurs, it returns to a value of less than 0. # I have one question. All return values have to match the Linux standard error code? However I wouldn't expect the power controls to exist at all, generally power is managed via DAPM rather than userspace. # Removed the mixer control to control power from userspace. # Automatically power control as DAC Event(DAPM), bias, set hw parameter and so on.. > +static int force_sdo_bypass_put(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) { > + struct snd_soc_component *component = > + snd_soc_kcontrol_component(kcontrol); > + struct sma1303_priv *sma1303 = snd_soc_component_get_drvdata(component); > + int sel = (int)ucontrol->value.integer.value[0]; > + > + sma1303->sdo_bypass_flag = (bool)sel; > + > + return 0; > +} What is this bypassing? # In chip, this is a function to set not to output on I2S. # The output will always be on. # So, We removed this. > +static const char * const sma1303_input_format_text[] = { > + "I2S", "LJ", "Reserved", "Reserved", > + "RJ_16", "RJ_18", "RJ_20", "RJ_24"}; > + > +static const struct soc_enum sma1303_input_format_enum = > +SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_input_format_text), > + sma1303_input_format_text); This should be controlled by the machine driver through set_dai_fmt() and hw_params(). # It's already included in that. # This mixer control is an additional control for debugging. # So, We removed this. > +static const char * const sma1303_pcm_n_slot_text[] = { > + "Slot_1", "Slot_2", "Slot_3", "Slot_4", "Slot_5", "Slot_6", > + "Slot_7", "Slot_8", "Slot_9", "Slot_10", "Slot_11", "Slot_12", > + "Slot_13", "Slot_14", "Slot_15", "Slot_16"}; > + > +static const struct soc_enum sma1303_pcm_n_slot_enum = > +SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_pcm_n_slot_text), > + sma1303_pcm_n_slot_text); set_tdm_slot() # It's already included in that. # This mixer control is also an additional control for debugging. # So, We removed this. > +static const char * const sma1303_port_config_text[] = { > + "IN_Port", "Reserved", "OUT_Port", "Reserved"}; This should be DT properties, possibly using the pinctrl schema depending on what's actually going on. # I'm sorry. I think I named it wrong. # This control is a feature that sets whether output is enabled or not. Output means SDO, that is, data exported from the chip. # So I modified this. > +static const char * const sma1303_port_out_sel_text[] = { > + "Disable", "Format_C", "Mixer_out", "After_DSP", > + "Postscaler", "Reserved", "Reserved", "Reserved"}; > + > +static const struct soc_enum sma1303_port_out_sel_enum = > + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_port_out_sel_text), > + sma1303_port_out_sel_text); This looks like it should be a DAPM routing control. # That's right. I added the control in route. > +static const char * const sma1303_spk_off_slope_text[] = { > + "00", "01", "10", "11"}; > + > +static const struct soc_enum sma1303_spk_off_slope_enum = > + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_spk_off_slope_text), > + sma1303_spk_off_slope_text); Why make this an enum and not just a numerical control with values 0-3? # Yes. I missed this value. # This function has been removed as users do not need to control it > +static const char * const sma1303_spkmode_text[] = { > + "Off", "Mono", "Reserved", "Reserved", > + "Stereo", "Reserved", "Reserved", "Reserved"}; > + > +static const struct soc_enum sma1303_spkmode_enum = > + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_spkmode_text), > + sma1303_spkmode_text); Use a value enum to eliminate the reserved values from user selection, however if this is controlling if the device has mono or stereo speakers it should be a DT property since that's unlikely to change at runtime. # This function also includes PWM on/off. # We have changed the enum. > +static const char * const sma1303_input_gain_text[] = { > + "Gain_0dB", "Gain_M6dB", "Gain_M12dB", "Gain_MInf"}; > + > +static const struct soc_enum sma1303_input_gain_enum = > +SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(sma1303_input_gain_text), > + sma1303_input_gain_text); This should just be a normal volume control. # We have other control for normal volume. # So, this control has been removed. I've stopped reviewing at this point. # Thanks for the detailed feedback.

1 0

[PATCH v1] ASoC: rockchip: i2s: use regmap_read_poll_timeout to poll I2S_CLR
by Judy Hsiao 14 Sep '22

14 Sep '22

Use regmap_read_poll_timeout to poll I2S_CLR. It also fixes the 'rockchip-i2s ff070000.i2s; fail to clear' and return -EBUSY when the read of I2S_CLR exceeds the retry limit. Fixes: 0ff9f8b9f592 ("ASoC: rockchip: i2s: Fix error code when fail to read I2S_CLR") Signed-off-by: Judy Hsiao <judyhsiao(a)chromium.org> --- sound/soc/rockchip/rockchip_i2s.c | 39 +++++++++++++------------------ 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index f5f3540a9e18..02905eec615e 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -163,18 +163,14 @@ static int rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on) I2S_CLR_TXC | I2S_CLR_RXC); if (ret < 0) goto end; - regmap_read(i2s->regmap, I2S_CLR, &val); - - /* Should wait for clear operation to finish */ - while (val) { - regmap_read(i2s->regmap, I2S_CLR, &val); - retry--; - if (!retry) { - dev_warn(i2s->dev, "fail to clear\n"); - ret = -EBUSY; - break; - } - } + ret = regmap_read_poll_timeout(i2s->regmap, + I2S_CLR, + val, + val != 0, + 20, + 200); + if (ret < 0) + dev_warn(i2s->dev, "fail to clear\n"); } } end: @@ -226,17 +222,14 @@ static int rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on) I2S_CLR_TXC | I2S_CLR_RXC); if (ret < 0) goto end; - regmap_read(i2s->regmap, I2S_CLR, &val); - /* Should wait for clear operation to finish */ - while (val) { - regmap_read(i2s->regmap, I2S_CLR, &val); - retry--; - if (!retry) { - dev_warn(i2s->dev, "fail to clear\n"); - ret = -EBUSY; - break; - } - } + ret = regmap_read_poll_timeout(i2s->regmap, + I2S_CLR, + val, + val != 0, + 20, + 200); + if (ret < 0) + dev_warn(i2s->dev, "fail to clear\n"); } } end: -- 2.37.2.789.g6183377224-goog

2 1

[PATCH] ASoC: meson: aiu-fifo.c: use devm_kzalloc(), and remove .remove function
by Kuninori Morimoto 14 Sep '22

14 Sep '22

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Current aiu-fifo.c is using kzalloc()/kfree(), but we can replace it by devm_kzalloc(), and remove kfree(). This patch do it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/meson/aiu-fifo.c | 10 +--------- sound/soc/meson/aiu-fifo.h | 1 - sound/soc/meson/aiu.c | 2 -- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/sound/soc/meson/aiu-fifo.c b/sound/soc/meson/aiu-fifo.c index d67ff4cdabd5..843e5067e07d 100644 --- a/sound/soc/meson/aiu-fifo.c +++ b/sound/soc/meson/aiu-fifo.c @@ -196,7 +196,7 @@ int aiu_fifo_dai_probe(struct snd_soc_dai *dai) { struct aiu_fifo *fifo; - fifo = kzalloc(sizeof(*fifo), GFP_KERNEL); + fifo = devm_kzalloc(dai->dev, sizeof(*fifo), GFP_KERNEL); if (!fifo) return -ENOMEM; @@ -204,11 +204,3 @@ int aiu_fifo_dai_probe(struct snd_soc_dai *dai) return 0; } - -int aiu_fifo_dai_remove(struct snd_soc_dai *dai) -{ - kfree(dai->playback_dma_data); - - return 0; -} - diff --git a/sound/soc/meson/aiu-fifo.h b/sound/soc/meson/aiu-fifo.h index 42ce266677cc..fb323a4385f7 100644 --- a/sound/soc/meson/aiu-fifo.h +++ b/sound/soc/meson/aiu-fifo.h @@ -26,7 +26,6 @@ struct aiu_fifo { }; int aiu_fifo_dai_probe(struct snd_soc_dai *dai); -int aiu_fifo_dai_remove(struct snd_soc_dai *dai); snd_pcm_uframes_t aiu_fifo_pointer(struct snd_soc_component *component, struct snd_pcm_substream *substream); diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c index 88e611e64d14..7e632aa31368 100644 --- a/sound/soc/meson/aiu.c +++ b/sound/soc/meson/aiu.c @@ -123,7 +123,6 @@ static struct snd_soc_dai_driver aiu_cpu_dai_drv[] = { .ops = &aiu_fifo_i2s_dai_ops, .pcm_new = aiu_fifo_pcm_new, .probe = aiu_fifo_i2s_dai_probe, - .remove = aiu_fifo_dai_remove, }, [CPU_SPDIF_FIFO] = { .name = "SPDIF FIFO", @@ -139,7 +138,6 @@ static struct snd_soc_dai_driver aiu_cpu_dai_drv[] = { .ops = &aiu_fifo_spdif_dai_ops, .pcm_new = aiu_fifo_pcm_new, .probe = aiu_fifo_spdif_dai_probe, - .remove = aiu_fifo_dai_remove, }, [CPU_I2S_ENCODER] = { .name = "I2S Encoder", -- 2.25.1

3 6

[linux-next:master] BUILD REGRESSION 0caac1da994900d12a9be6106edb8e98696712a3
by kernel test robot 14 Sep '22

14 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 0caac1da994900d12a9be6106edb8e98696712a3 Add linux-next specific files for 20220913 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.FQi69rLV-lkp@intel.com https://lore.kernel.org/linux-mm/202209060229.dVuyxjBv-lkp@intel.com https://lore.kernel.org/linux-mm/202209080718.y5QmlNKH-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) drivers/gpu/drm/amd/amdgpu/imu_v11_0_3.c:139:6: warning: no previous prototype for 'imu_v11_0_3_program_rlc_ram' [-Wmissing-prototypes] drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encoder_state() instead drivers/hwmon/emc2305.c:194 emc2305_set_cur_state() warn: impossible condition '(val > 255) => (0-255 > 255)' drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration] drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration] kernel/bpf/memalloc.c:499 bpf_mem_alloc_destroy() error: potentially dereferencing uninitialized 'c'. mm/damon/vaddr.c:158 __damon_va_three_regions() error: uninitialized symbol 'start'. net/mac80211/iface.c:251 ieee80211_can_powered_addr_change() warn: inconsistent returns '&local->mtx'. sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- alpha-buildonly-randconfig-r003-20220911 | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-buildonly-randconfig-r002-20220912 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r012-20220913 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r021-20220911 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r043-20220911 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r043-20220912 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-s052-20220911 | |-- kernel-bpf-hashtab.c:sparse:sparse:cast-removes-address-space-__percpu-of-expression | |-- kernel-bpf-hashtab.c:sparse:sparse:incorrect-type-in-assignment-(different-address-spaces)-expected-void-noderef-__percpu-assigned-pptr-got-void | |-- kernel-bpf-hashtab.c:sparse:sparse:incorrect-type-in-assignment-(different-address-spaces)-expected-void-ptr_to_pptr-got-void-noderef-__percpu-assigned-pptr | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__percpu-__pdata-got-void | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__percpu-__pdata-got-void-pptr | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-pptr-got-void-noderef-__percpu | `-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand |-- arm-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm-defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arm-randconfig-r001-20220911 | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm-randconfig-r006-20220911 | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- csky-buildonly-randconfig-r001-20220911 clang_recent_errors |-- i386-randconfig-a012-20220912 | `-- sound-soc-intel-skylake-skl.c:warning:unused-variable-skl |-- i386-randconfig-a015-20220912 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- powerpc-buildonly-randconfig-r006-20220912 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- powerpc-randconfig-r004-20220911 | `-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-function-imu_v11_0_3_program_rlc_ram `-- riscv-randconfig-r042-20220912 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 725m configs tested: 63 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig i386 randconfig-a001-20220912 i386 randconfig-a002-20220912 x86_64 defconfig i386 randconfig-a004-20220912 x86_64 rhel-8.3-kvm i386 randconfig-a003-20220912 x86_64 rhel-8.3-func i386 randconfig-a006-20220912 x86_64 rhel-8.3 x86_64 rhel-8.3-kunit i386 randconfig-a005-20220912 x86_64 rhel-8.3-kselftests m68k allmodconfig x86_64 rhel-8.3-syz arc allyesconfig x86_64 allyesconfig alpha allyesconfig i386 defconfig m68k allyesconfig powerpc allnoconfig powerpc allmodconfig arm defconfig mips allyesconfig x86_64 randconfig-a001-20220912 x86_64 randconfig-a006-20220912 sh allmodconfig x86_64 randconfig-a004-20220912 riscv randconfig-r042-20220911 x86_64 randconfig-a002-20220912 i386 allyesconfig arc randconfig-r043-20220912 x86_64 randconfig-a005-20220912 arm64 allyesconfig x86_64 randconfig-a003-20220912 arm allyesconfig arc randconfig-r043-20220911 s390 randconfig-r044-20220911 ia64 allmodconfig csky allnoconfig arc allnoconfig alpha allnoconfig riscv allnoconfig clang tested configs: i386 randconfig-a014-20220912 i386 randconfig-a013-20220912 x86_64 randconfig-a014-20220912 i386 randconfig-a011-20220912 x86_64 randconfig-a011-20220912 i386 randconfig-a015-20220912 x86_64 randconfig-a012-20220912 i386 randconfig-a012-20220912 x86_64 randconfig-a016-20220912 i386 randconfig-a016-20220912 x86_64 randconfig-a013-20220912 riscv randconfig-r042-20220912 x86_64 randconfig-a015-20220912 hexagon randconfig-r041-20220912 hexagon randconfig-r045-20220911 hexagon randconfig-r041-20220911 hexagon randconfig-r045-20220912 s390 randconfig-r044-20220912 x86_64 rhel-8.3-rust -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[PATCH v2 0/5] soundwire: Fixes for spurious and missing UNATTACH
by Richard Fitzgerald 13 Sep '22

13 Sep '22

The bus and cadence code has several bugs that cause UNATTACH notifications to either be sent spuriously or to be missed. These can be seen occasionally with a single peripheral on the bus, but are much more frequent with multiple peripherals, where several peripherals could change state and report in consecutive PINGs. The root of all of these bugs seems to be a code design flaw that assumed every PING status change would be handled separately. However, PINGs are handled by a workqueue function and there is no guarantee when that function will be scheduled to run or how much CPU time it will receive. PINGs will continue while the work function is handling a snapshot of a previous PING so the code must take account that (a) status could change during the work function and (b) there can be a backlog of changes before the IRQ work function runs again. Tested with 4 peripherals on 1 bus, and 8 peripherals on 2 buses. CHANGES SINCE V1: Patch #3 replaced with a better solution to the same bug. Patches #4 and #5 added to fix some more bugs that were found. Richard Fitzgerald (4): soundwire: bus: Don't lose unattach notifications soundwire: bus: Don't re-enumerate before status is UNATTACHED soundwire: cadence: Fix lost ATTACHED interrupts when enumerating soundwire: bus: Don't exit early if no device IDs were programmed Simon Trimmer (1): soundwire: cadence: fix updating slave status when a bus has multiple peripherals drivers/soundwire/bus.c | 40 +++++++++++----- drivers/soundwire/cadence_master.c | 75 ++++++++++++++++-------------- 2 files changed, 68 insertions(+), 47 deletions(-) -- 2.30.2

2 13

[PATCH 00/10] ASoC: mediatek: Set i2s clock sharing from machine drivers
by Nícolas F. R. A. Prado 13 Sep '22

13 Sep '22

The i2s ports on MediaTek SoCs only support a single data lane. In order to achieve full-duplex operation thus two i2s ports, one for input and one for output, need to be used together and sharing a single clock from one of the ports. This clock sharing setting was previously read by the sound platform driver from the devicetree, but given that the input/output pairing is closely related to which codecs are connected to which ports, the machine sound driver can infer and set it, so that no DT property is required. At this point only mt8183-kukui was using the DT property, but given that this property was never documented, and that the API introduced in this series makes it obsolete, the undocumented DT property can safely be removed. This series adds a function to allow setting the i2s shared clocks, makes use of it in the machine drivers as required, and removes the no longer required DT properties and support for them in the drivers, for all of mt8192, mt8183 and mt8186. Nícolas F. R. A. Prado (10): ASoC: mediatek: mt8192: Allow setting shared clocks from machine driver ASoC: mediatek: mt8192-mt6359: Make i2s9 share the clock from i2s8 ASoC: mediatek: mt8192: Remove clock share parsing from DT ASoC: mediatek: mt8183: Allow setting shared clocks from machine driver ASoC: mediatek: mt8183: Configure shared clocks ASoC: mediatek: mt8183: Remove clock share parsing from DT arm64: dts: mediatek: kukui: Remove i2s-share properties ASoC: mediatek: mt8186: Allow setting shared clocks from machine driver ASoC: mediatek: mt8186: Configure shared clocks ASoC: mediatek: mt8186: Remove clock share parsing from DT .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 5 -- sound/soc/mediatek/mt8183/mt8183-afe-common.h | 3 ++ .../mediatek/mt8183/mt8183-da7219-max98357.c | 33 +++++++++++++ sound/soc/mediatek/mt8183/mt8183-dai-i2s.c | 45 ++++++++--------- .../mt8183/mt8183-mt6358-ts3a227-max98357.c | 33 +++++++++++++ sound/soc/mediatek/mt8186/mt8186-afe-common.h | 3 ++ sound/soc/mediatek/mt8186/mt8186-dai-i2s.c | 44 ++++++++--------- .../mt8186/mt8186-mt6366-da7219-max98357.c | 18 +++++++ .../mt8186/mt8186-mt6366-rt1019-rt5682s.c | 18 +++++++ sound/soc/mediatek/mt8192/mt8192-afe-common.h | 3 ++ sound/soc/mediatek/mt8192/mt8192-dai-i2s.c | 49 ++++++++----------- .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 9 ++++ 12 files changed, 180 insertions(+), 83 deletions(-) -- 2.37.3

4 22

[PATCH] ASoC: ak4458: Add ak4458_reset in device probe and remove
by Shengjiu Wang 13 Sep '22

13 Sep '22

This patch fixup this warning when CONFIG_PM not defined linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined but\ not used [-Werror=unused-function] 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) | ^~~~~~~~~~~~ cc1: all warnings being treated as errors Fixes: e9e7df88996d64 ("ASoC: ak4458: Remove component probe() and remove()") Reported-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/codecs/ak4458.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index b534212096ee..626310859814 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -781,12 +781,16 @@ static int ak4458_i2c_probe(struct i2c_client *i2c) pm_runtime_enable(&i2c->dev); regcache_cache_only(ak4458->regmap, true); + ak4458_reset(ak4458, false); return 0; } static int ak4458_i2c_remove(struct i2c_client *i2c) { + struct ak4458_priv *ak4458 = i2c_get_clientdata(i2c); + + ak4458_reset(ak4458, true); pm_runtime_disable(&i2c->dev); return 0; -- 2.34.1

2 1

[PATCH v9 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller
by Ban Tao 13 Sep '22

13 Sep '22

DT binding documentation for this new ASoC driver. Signed-off-by: Ban Tao <fengzheng923(a)gmail.com> Reviewed-by: Rob Herring <robh(a)kernel.org> Reviewed-by: Maxime Ripard <maxime(a)cerno.tech> --- v1->v2: 1.Fix some build errors. v2->v3: 1.Fix some build errors. v3->v4: 1.None. v4->v5: 1.Add interrupt. 2.Keep clock and reset index. v5->v6: 1.None. v6->v7: 1.None. v7->v8: 1.Fix some build errors. v8->v9: 1.None. --- .../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 ++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml new file mode 100644 index 0000000..0cfc07f --- /dev/null +++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner H6 DMIC Device Tree Bindings + +maintainers: + - Ban Tao <fengzheng923(a)gmail.com> + +properties: + "#sound-dai-cells": + const: 0 + + compatible: + const: allwinner,sun50i-h6-dmic + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: Bus Clock + - description: Module Clock + + clock-names: + items: + - const: bus + - const: mod + + dmas: + items: + - description: RX DMA Channel + + dma-names: + items: + - const: rx + + resets: + maxItems: 1 + +required: + - "#sound-dai-cells" + - compatible + - reg + - interrupts + - clocks + - clock-names + - dmas + - dma-names + - resets + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + #include <dt-bindings/clock/sun50i-h6-ccu.h> + #include <dt-bindings/reset/sun50i-h6-ccu.h> + + dmic: dmic@5095000 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun50i-h6-dmic"; + reg = <0x05095000 0x400>; + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>; + clock-names = "bus", "mod"; + dmas = <&dma 7>; + dma-names = "rx"; + resets = <&ccu RST_BUS_DMIC>; + }; + +... -- 2.7.4

4 8

[-next] ASoC: Intel: fix compiler warning of function ‘probe_codec’
by Wang Yufen 13 Sep '22

13 Sep '22

Move the variable ‘skl’ define to CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC enabled, to fix the compiler warning: sound/soc/intel/skylake/skl.c: In function ‘probe_codec’: sound/soc/intel/skylake/skl.c:729:18: warning: unused variable ‘skl’ [-Wunused-variable] 729 | struct skl_dev *skl = bus_to_skl(bus); | ^~~ Signed-off-by: Wang Yufen <wangyufen(a)huawei.com> --- sound/soc/intel/skylake/skl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index c7c1cad..52a041d 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -726,8 +726,8 @@ static int probe_codec(struct hdac_bus *bus, int addr) unsigned int cmd = (addr << 28) | (AC_NODE_ROOT << 20) | (AC_VERB_PARAMETERS << 8) | AC_PAR_VENDOR_ID; unsigned int res = -1; - struct skl_dev *skl = bus_to_skl(bus); #if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC) + struct skl_dev *skl = bus_to_skl(bus); struct hdac_hda_priv *hda_codec; #endif struct hda_codec *codec; -- 1.8.3.1

2 1

[PATCH] ASoC: imx-card: Fix refcount issue with of_node_put
by Shengjiu Wang 13 Sep '22

13 Sep '22

imx_card_parse_of will search all the node with loop, if there is defer probe happen in the middle of loop, the previous released codec node will be released twice, then cause refcount issue. Here assign NULL to pointer of released nodes to fix the issue. Fixes: aa736700f42f ("ASoC: imx-card: Add imx-card machine driver") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/fsl/imx-card.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/imx-card.c b/sound/soc/fsl/imx-card.c index 14be29530fb5..3f128ced4180 100644 --- a/sound/soc/fsl/imx-card.c +++ b/sound/soc/fsl/imx-card.c @@ -698,6 +698,10 @@ static int imx_card_parse_of(struct imx_card_data *data) of_node_put(cpu); of_node_put(codec); of_node_put(platform); + + cpu = NULL; + codec = NULL; + platform = NULL; } return 0; -- 2.34.1

2 1

[PATCH 1/2] ASoC: nau8825: Add ADCOUT IO drive strength control
by David Lin 13 Sep '22

13 Sep '22

Add a property to control the driving of ADCOUT. Signed-off-by: David Lin <CTLIN0(a)nuvoton.com> --- sound/soc/codecs/nau8825.c | 6 ++++++ sound/soc/codecs/nau8825.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 8213273f501e..c41ac7b9217b 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1983,6 +1983,10 @@ static void nau8825_init_regs(struct nau8825 *nau8825) /* Disable short Frame Sync detection logic */ regmap_update_bits(regmap, NAU8825_REG_LEFT_TIME_SLOT, NAU8825_DIS_FS_SHORT_DET, NAU8825_DIS_FS_SHORT_DET); + /* ADCDAT IO drive strength control */ + regmap_update_bits(regmap, NAU8825_REG_CHARGE_PUMP, + NAU8825_ADCOUT_DS_MASK, + nau8825->adcout_ds << NAU8825_ADCOUT_DS_SFT); } static const struct regmap_config nau8825_regmap_config = { @@ -2521,6 +2525,7 @@ static void nau8825_print_device_properties(struct nau8825 *nau8825) nau8825->jack_eject_debounce); dev_dbg(dev, "crosstalk-enable: %d\n", nau8825->xtalk_enable); + dev_dbg(dev, "adcout-drive-str: %d\n", nau8825->adcout_ds); } static int nau8825_read_device_properties(struct device *dev, @@ -2587,6 +2592,7 @@ static int nau8825_read_device_properties(struct device *dev, nau8825->jack_eject_debounce = 0; nau8825->xtalk_enable = device_property_read_bool(dev, "nuvoton,crosstalk-enable"); + nau8825->adcout_ds = device_property_read_bool(dev, "nuvoton,adcout-drive-str"); nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) { diff --git a/sound/soc/codecs/nau8825.h b/sound/soc/codecs/nau8825.h index 887bbff03ec6..6d112b6145df 100644 --- a/sound/soc/codecs/nau8825.h +++ b/sound/soc/codecs/nau8825.h @@ -418,6 +418,8 @@ #define NAU8825_POWERUP_HP_DRV_L (1 << 0) /* CHARGE_PUMP (0x80) */ +#define NAU8825_ADCOUT_DS_SFT 12 +#define NAU8825_ADCOUT_DS_MASK (1 << NAU8825_ADCOUT_DS_SFT) #define NAU8825_JAMNODCLOW (1 << 10) #define NAU8825_POWER_DOWN_DACR (1 << 9) #define NAU8825_POWER_DOWN_DACL (1 << 8) @@ -477,6 +479,7 @@ struct nau8825 { int imp_rms[NAU8825_XTALK_IMM]; int xtalk_enable; bool xtalk_baktab_initialized; /* True if initialized. */ + bool adcout_ds; }; int nau8825_enable_jack_detect(struct snd_soc_component *component, -- 2.25.1

3 5

[PATCH 0/7] soundwire: Fix driver removal
by Richard Fitzgerald 13 Sep '22

13 Sep '22

Removal of child drivers and the bus driver was broken and would result in a slew of various errors. Most of these were caused by the code shutting down in the wrong order, shutting down the bus driver first. The bus driver should be shut down after the child drivers have been removed (compare with the I2C and SPI subsystem for example). These patches fix that. A secondary problem was over the cleanup of child drivers. The removal functions were not the opposite of the probe function, and the ownership of struct sdw_slave is tricky because it mixes two separate usages and currently has to be "owned" by the bus driver. Tested with 4 peripherals on 1 bus and 8 peripherals on 2 buses. Richard Fitzgerald (7): soundwire: bus: Do not forcibly disable child pm_runtime soundwire: intel_init: Separate shutdown and cleanup ASoC: SOF: Intel: Don't disable Soundwire interrupt before the bus has shut down soundwire: bus: Add remove callback to struct sdw_master_ops soundwire: intel: Don't disable interrupt until children are removed soundwire: intel: Don't disable pm_runtime until children are removed soundwire: bus: Fix premature removal of sdw_slave objects drivers/soundwire/bus.c | 37 ++++++++++++++++++++++++----- drivers/soundwire/intel.c | 13 ++++++++-- drivers/soundwire/intel_init.c | 25 +++++++++++++++---- drivers/soundwire/slave.c | 21 ++++++++++++---- include/linux/soundwire/sdw.h | 3 ++- include/linux/soundwire/sdw_intel.h | 2 ++ sound/soc/sof/intel/hda.c | 16 ++++++++++--- 7 files changed, 96 insertions(+), 21 deletions(-) -- 2.30.2

3 14

[PATCH] dt-bindings: sound: ts3a227e: add control of debounce times
by Astrid Rost 13 Sep '22

13 Sep '22

Add devicetree parameters to control the insertion, release and press debounce times. Signed-off-by: Astrid Rost <astrid.rost(a)axis.com> --- Documentation/devicetree/bindings/sound/ts3a227e.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/ts3a227e.txt b/Documentation/devicetree/bindings/sound/ts3a227e.txt index 21ab45bc7e8f..a4aa4154c54c 100644 --- a/Documentation/devicetree/bindings/sound/ts3a227e.txt +++ b/Documentation/devicetree/bindings/sound/ts3a227e.txt @@ -17,6 +17,15 @@ Optional properies: Select 0/1/2/3/4/5/6/7 to specify MICBIAS voltage 2.1V/2.2V/2.3V/2.4V/2.5V/2.6V/2.7V/2.8V Default value is "1" (2.2V). + - ti,debounce-release: key release debounce (datasheet section 9.6.7). + Select 0/1 to specify the release debounce time 0ms/20ms + Default value is "1" (20 ms). + - ti,debounce-press: key press debounce (datasheet section 9.6.7). + Select 0/1/2/3 to specify the press debounce time 2ms/40ms/80ms/120ms + Default value is "2" (80 ms). + - ti,debounce-insertion: headset insertion debounce (datasheet section 9.6.5). + Select 0/1/2/3/4/5/6/7 to specify the insertion debounce time 2ms/30ms/60ms/90ms/120ms/150ms/1s/2s + Default value is "3" (90 ms). Examples: -- 2.20.1

4 10

[PATCH v3 00/14] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes
by Krzysztof Kozlowski 13 Sep '22

13 Sep '22

Hi, Dependencies/merging ==================== 1. The DTS patches are independent. 2. The binding patches should come together, because of context changes. Could be one of: Qualcomm SoC, ASoC or DT tree. Changes since v2 ================ 1. Patch 9: rename and extend commit msg. 2. Add Rb tags. Changes since v1 ================ 1. Patch 9: New patch. 2. Patch 10: Correct also sound/qcom,q6apm-dai.yaml (Rob). 2. Patch 13: New patch. 3. Add Rb/Tb tags. Best regards, Krzysztof Krzysztof Kozlowski (14): arm64: dts: qcom: sdm630: align APR services node names with dtschema arm64: dts: qcom: sdm845: align APR services node names with dtschema arm64: dts: qcom: sm8250: align APR services node names with dtschema arm64: dts: qcom: msm8996: fix APR services nodes arm64: dts: qcom: sdm845: align dai node names with dtschema arm64: dts: qcom: msm8996: align dai node names with dtschema arm64: dts: qcom: qrb5165-rb5: align dai node names with dtschema arm64: dts: qcom: sm8250: use generic name for LPASS clock controller ASoC: dt-bindings:: qcom,q6asm: convert to dtschema dt-bindings: soc: qcom: apr: correct service children ASoC: dt-bindings: qcom,q6dsp-lpass-ports: cleanup example ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: cleanup example ASoC: dt-bindings: qcom,q6apm-dai: adjust indentation in example dt-bindings: soc: qcom: apr: add missing properties .../bindings/soc/qcom/qcom,apr.yaml | 111 +++++++++++++++-- .../bindings/sound/qcom,q6apm-dai.yaml | 21 ++-- .../bindings/sound/qcom,q6asm-dais.yaml | 112 ++++++++++++++++++ .../devicetree/bindings/sound/qcom,q6asm.txt | 70 ----------- .../sound/qcom,q6dsp-lpass-clocks.yaml | 36 +++--- .../sound/qcom,q6dsp-lpass-ports.yaml | 64 +++++----- arch/arm64/boot/dts/qcom/msm8996.dtsi | 10 +- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 +- arch/arm64/boot/dts/qcom/sdm630.dtsi | 8 +- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- .../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 2 +- .../boot/dts/qcom/sdm845-xiaomi-polaris.dts | 4 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 10 +- 14 files changed, 293 insertions(+), 169 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm-dais.yaml delete mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt -- 2.34.1

3 17

RE: Re: [PATCH 1/5] ASoC: dt-bindings: fsl_rpmsg: Add a property to assign platform driver name
by Chancel Liu 13 Sep '22

13 Sep '22

> > Add a string property to assign ASoC platform driver name. It also > > represents the rpmsg channel this sound card sits on. This property > > can be omitted if there is only one sound card and it sits on > > "rpmsg-audio-channel". > > > > Signed-off-by: Chancel Liu <chancel.liu(a)nxp.com> > > --- > > .../devicetree/bindings/sound/fsl,rpmsg.yaml | 34 +++++++++++++++++-- > > 1 file changed, 32 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > > index d370c98a62c7..35e3cb9f768b 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > > +++ b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > > @@ -11,8 +11,11 @@ maintainers: > > > > description: | > > fsl_rpmsg is a virtual audio device. Mapping to real hardware devices > > - are SAI, DMA controlled by Cortex M core. What we see from Linux > > - side is a device which provides audio service by rpmsg channel. > > + are SAI, MICFIL, DMA controlled by Cortex M core. What we see from > > + Linux side is a device which provides audio service by rpmsg channel. > > + We can create different sound cards which access different hardwares > > + such as SAI, MICFIL, .etc through building rpmsg channels between > > + Cortex-A and Cortex-M. > > > > properties: > > compatible: > > @@ -85,6 +88,14 @@ properties: > > This is a boolean property. If present, the receiving function > > will be enabled. > > > > + fsl,platform: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: | > > + A string property to assign ASoC platform driver name. > > No, this is not a property of hardware. Naming of some drivers in some > systems does not fit DTS and bindings. > This property aims to tell the ASoC driver which rpmsg channel the sound card depends on. If there are several sound cards sit on rpmsg, we should pass correct information in dts node to specify the name of rpmsg channel. That is why I meant to add this property. I just want to use a string property to distinguish different names of rpmsg channel. Actually this property is hardware-related. As we discussed before, this kind of sound card based on rpmsg works under this mechanism Cortex-A core tells the Cortex-M core configuration of the PCM parameters then Cortex-M controls real hardware devices. This property specifying rpmsg channel represents the real hardware audio controller. That's my idea adding this property. Do you have any better suggestion? > > It also > > + represents the rpmsg channel this sound card sits on. This property > > + can be omitted if there is only one sound card and it sits on > > + "rpmsg-audio-channel". > > + > > required: > > - compatible > > - model > > @@ -107,3 +118,22 @@ examples: > > <&clk IMX8MN_AUDIO_PLL2_OUT>; > > clock-names = "ipg", "mclk", "dma", "pll8k", "pll11k"; > > }; > > + > > + - | > > + #include <dt-bindings/clock/imx8mm-clock.h> > > + > > + rpmsg_micfil: rpmsg_micfil { > > Node names should be generic. > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevicetre > e-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basics.h > tml%23generic-names-recommendation&data=05%7C01%7Cchancel.liu% > 40nxp.com%7C8d5f4ca9669349c597b908da8a6a0311%7C686ea1d3bc2b4c6fa > 92cd99c5c301635%7C0%7C0%7C637974485190445475%7CUnknown%7CTWFp > bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > Mn0%3D%7C3000%7C%7C%7C&sdata=SgDveDWfYyVYhBrG9gpi2aPgGV4j > PwtqbQOtbaE%2FI2s%3D&reserved=0 > > Also: no underscores in node names. > > Best regards, > Krzysztof Thanks for your reminder. We will rename the node in patches for next version like: rpmsg_micfil: audio-controller { // property; }; Regards, Chancel Liu

2 1

[PATCH] ALSA: hda/hdmi: change type for the 'assigned' variable
by Jaroslav Kysela 13 Sep '22

13 Sep '22

This change converts the assigned value from int type to the bool type to retain consistency with other structure members like 'setup', 'non_pcm' etc. Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/pci/hda/patch_hdmi.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 22766810635b..4576af4cff90 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -53,7 +53,7 @@ MODULE_PARM_DESC(enable_all_pins, "Forcibly enable all pins"); struct hdmi_spec_per_cvt { hda_nid_t cvt_nid; - int assigned; + bool assigned; /* the stream has been assigned */ unsigned int channels_min; unsigned int channels_max; u32 rates; @@ -1193,7 +1193,7 @@ static int hdmi_pcm_open_no_pin(struct hda_pcm_stream *hinfo, return err; per_cvt = get_cvt(spec, cvt_idx); - per_cvt->assigned = 1; + per_cvt->assigned = true; hinfo->nid = per_cvt->cvt_nid; pin_cvt_fixup(codec, NULL, per_cvt->cvt_nid); @@ -1262,7 +1262,7 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo, per_cvt = get_cvt(spec, cvt_idx); /* Claim converter */ - per_cvt->assigned = 1; + per_cvt->assigned = true; set_bit(pcm_idx, &spec->pcm_in_use); per_pin = get_pin(spec, pin_idx); @@ -1297,7 +1297,7 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo, snd_hdmi_eld_update_pcm_info(&eld->info, hinfo); if (hinfo->channels_min > hinfo->channels_max || !hinfo->rates || !hinfo->formats) { - per_cvt->assigned = 0; + per_cvt->assigned = false; hinfo->nid = 0; snd_hda_spdif_ctls_unassign(codec, pcm_idx); err = -ENODEV; @@ -1756,7 +1756,7 @@ static void silent_stream_enable(struct hda_codec *codec, } per_cvt = get_cvt(spec, cvt_idx); - per_cvt->assigned = 1; + per_cvt->assigned = true; per_pin->cvt_nid = per_cvt->cvt_nid; per_pin->silent_stream = true; @@ -1816,7 +1816,7 @@ static void silent_stream_disable(struct hda_codec *codec, cvt_idx = cvt_nid_to_cvt_index(codec, per_pin->cvt_nid); if (cvt_idx >= 0 && cvt_idx < spec->num_cvts) { per_cvt = get_cvt(spec, cvt_idx); - per_cvt->assigned = 0; + per_cvt->assigned = false; } if (spec->silent_stream_type == SILENT_STREAM_I915) { @@ -2212,7 +2212,7 @@ static int hdmi_pcm_close(struct hda_pcm_stream *hinfo, goto unlock; } per_cvt = get_cvt(spec, cvt_idx); - per_cvt->assigned = 0; + per_cvt->assigned = false; hinfo->nid = 0; azx_stream(get_azx_dev(substream))->stripe = 0; -- 2.35.3

2 1

[v2] ALSA: hda: Fix Nvidia dp infoframe
by Mohan Kumar 13 Sep '22

13 Sep '22

Nvidia HDA HW expects infoframe data bytes order same for both HDMI and DP i.e infoframe data starts from 5th bytes offset. As dp infoframe structure has 4th byte as valid infoframe data, use hdmi infoframe structure for nvidia dp infoframe to match HW behvaior. Signed-off-by: Mohan Kumar <mkumard(a)nvidia.com> --- sound/pci/hda/patch_hdmi.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 6c209cd26c0c..9127dd1b1a9c 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -170,6 +170,8 @@ struct hdmi_spec { bool dyn_pcm_no_legacy; /* hdmi interrupt trigger control flag for Nvidia codec */ bool hdmi_intr_trig_ctrl; + bool nv_dp_workaround; /* workaround DP audio infoframe for Nvidia */ + bool intel_hsw_fixup; /* apply Intel platform-specific fixups */ /* * Non-generic VIA/NVIDIA specific @@ -679,15 +681,24 @@ static void hdmi_pin_setup_infoframe(struct hda_codec *codec, int ca, int active_channels, int conn_type) { + struct hdmi_spec *spec = codec->spec; union audio_infoframe ai; memset(&ai, 0, sizeof(ai)); - if (conn_type == 0) { /* HDMI */ + if ((conn_type == 0) || /* HDMI */ + /* Nvidia DisplayPort: Nvidia HW expects same layout as HDMI */ + (conn_type == 1 && spec->nv_dp_workaround)) { struct hdmi_audio_infoframe *hdmi_ai = &ai.hdmi; - hdmi_ai->type = 0x84; - hdmi_ai->ver = 0x01; - hdmi_ai->len = 0x0a; + if (conn_type == 0) { /* HDMI */ + hdmi_ai->type = 0x84; + hdmi_ai->ver = 0x01; + hdmi_ai->len = 0x0a; + } else {/* Nvidia DP */ + hdmi_ai->type = 0x84; + hdmi_ai->ver = 0x1b; + hdmi_ai->len = 0x11 << 2; + } hdmi_ai->CC02_CT47 = active_channels - 1; hdmi_ai->CA = ca; hdmi_checksum_audio_infoframe(hdmi_ai); @@ -3617,6 +3628,7 @@ static int patch_nvhdmi_2ch(struct hda_codec *codec) spec->pcm_playback.rates = SUPPORTED_RATES; spec->pcm_playback.maxbps = SUPPORTED_MAXBPS; spec->pcm_playback.formats = SUPPORTED_FORMATS; + spec->nv_dp_workaround = true; return 0; } @@ -3756,6 +3768,7 @@ static int patch_nvhdmi(struct hda_codec *codec) spec->chmap.ops.chmap_cea_alloc_validate_get_type = nvhdmi_chmap_cea_alloc_validate_get_type; spec->chmap.ops.chmap_validate = nvhdmi_chmap_validate; + spec->nv_dp_workaround = true; codec->link_down_at_suspend = 1; @@ -3779,6 +3792,7 @@ static int patch_nvhdmi_legacy(struct hda_codec *codec) spec->chmap.ops.chmap_cea_alloc_validate_get_type = nvhdmi_chmap_cea_alloc_validate_get_type; spec->chmap.ops.chmap_validate = nvhdmi_chmap_validate; + spec->nv_dp_workaround = true; codec->link_down_at_suspend = 1; @@ -3992,6 +4006,7 @@ static int tegra_hdmi_init(struct hda_codec *codec) spec->chmap.ops.chmap_cea_alloc_validate_get_type = nvhdmi_chmap_cea_alloc_validate_get_type; spec->chmap.ops.chmap_validate = nvhdmi_chmap_validate; + spec->nv_dp_workaround = true; return 0; } -- 2.17.1

3 3

[PATCH] ALSA: hda: Fix tegra hda dp infoframe struct
by Mohan Kumar 13 Sep '22

13 Sep '22

Tegra HDA HW expects infoframe data bytes order same for both HDMI and DP i.e infoframe data starts from 5th bytes offset. This hw behavior mandates to have dummy bytes for dp infoframe structure for Tegra. Signed-off-by: Mohan Kumar <mkumard(a)nvidia.com> --- sound/pci/hda/patch_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 6c209cd26c0c..a52e764db2e0 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -218,6 +218,9 @@ struct dp_audio_infoframe { u8 type; /* 0x84 */ u8 len; /* 0x1b */ u8 ver; /* 0x11 << 2 */ +#if IS_ENABLED(CONFIG_SND_HDA_TEGRA) + u8 checksum; /* Tegra HW expects infoframe bytes from 5th offset */ +#endif u8 CC02_CT47; /* match with HDMI infoframe from this on */ u8 SS01_SF24; -- 2.17.1

3 2

[PATCH] ALSA: hda/realtek: Add quirk for Huawei WRT-WX9
by huangwenhui 13 Sep '22

13 Sep '22

Fixes headphone and headset microphone detection on Huawei WRT-WX9. Signed-off-by: huangwenhui <huangwenhuia(a)uniontech.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 38930cf5aace..0996a8fd008c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9569,6 +9569,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), SND_PCI_QUIRK(0x1849, 0x1233, "ASRock NUC Box 1100", ALC233_FIXUP_NO_AUDIO_JACK), SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9", ALC256_FIXUP_HUAWEI_MACH_WX9_PINS), + SND_PCI_QUIRK(0x19e5, 0x320f, "Huawei WRT-WX9 ", ALC256_FIXUP_ASUS_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1b35, 0x1235, "CZC B20", ALC269_FIXUP_CZC_B20), SND_PCI_QUIRK(0x1b35, 0x1236, "CZC TMI", ALC269_FIXUP_CZC_TMI), SND_PCI_QUIRK(0x1b35, 0x1237, "CZC L101", ALC269_FIXUP_CZC_L101), -- 2.20.1

2 1

[PATCH] ALSA: hda/tegra: set depop delay for tegra
by Mohan Kumar 13 Sep '22

13 Sep '22

Reduce the suspend time by setting depop delay to 10ms for tegra. Signed-off-by: Mohan Kumar <mkumard(a)nvidia.com> --- sound/pci/hda/patch_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 6c209cd26c0c..acaf6b790ee1 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -3984,6 +3984,7 @@ static int tegra_hdmi_init(struct hda_codec *codec) generic_hdmi_init_per_pins(codec); + codec->depop_delay = 10; codec->patch_ops.build_pcms = tegra_hdmi_build_pcms; spec->chmap.ops.chmap_cea_alloc_validate_get_type = nvhdmi_chmap_cea_alloc_validate_get_type; -- 2.17.1

2 1

[PATCH] ALSA: hda: add Intel 5 Series / 3400 PCI DID
by Kai Vehmanen 13 Sep '22

13 Sep '22

Handle 0x3b57 variant with same AZX_DCAPS_INTEL_PCH_NOPM capabilities as 0x3b56. In practise this allow use of HDMI/DP display audio via i915. BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/2751 Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 7e605ce43f41..2a93bc64c2d8 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2543,6 +2543,8 @@ static const struct pci_device_id azx_ids[] = { /* 5 Series/3400 */ { PCI_DEVICE(0x8086, 0x3b56), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_NOPM }, + { PCI_DEVICE(0x8086, 0x3b57), + .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* Poulsbo */ { PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE }, base-commit: 0186f7325909dec0cb52814384062f6de3b87941 -- 2.37.3

2 1

Re: [PATCH] ASoC: ak4458.c: move ak4458_reset() under CONFIG_PM
by S.J. Wang 13 Sep '22

13 Sep '22

> Hi Mark > > > > This patch fixup this warning > > > > > > linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined > but\ > > > not used [-Werror=unused-function] > > > 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) > > > | ^~~~~~~~~~~~ > > > cc1: all warnings being treated as errors > > > > > > Fixes: e9e7df88996d64 ("ASoC: ak4458: Remove component probe() and > > > remove()") > > > > Is this the best fix, or should we be adding _reset() calls into the > > device level probe() and remove() functions? > > Hmm... I'm not familiar with ak4458.c. > Is your opinion for original patch ? or this patch ? > This patch is just trying to fix the compile issue. > > Thank you for your help !! > Thanks for catching this issue. Without or with _reset() in probe() and remove(), the driver can work in both case. Best regards Wang shengjiu

2 1

[PATCH] ASoC: ak4458.c: move ak4458_reset() under CONFIG_PM
by Kuninori Morimoto 13 Sep '22

13 Sep '22

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> This patch fixup this warning linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined but\ not used [-Werror=unused-function] 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) | ^~~~~~~~~~~~ cc1: all warnings being treated as errors Fixes: e9e7df88996d64 ("ASoC: ak4458: Remove component probe() and remove()") Cc: Shengjiu Wang <shengjiu.wang(a)nxp.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/codecs/ak4458.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index b534212096ee..4735aae3bfbd 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -628,6 +628,7 @@ static struct snd_soc_dai_driver ak4497_dai = { .ops = &ak4458_dai_ops, }; +#ifdef CONFIG_PM static void ak4458_reset(struct ak4458_priv *ak4458, bool active) { if (ak4458->reset_gpiod) { @@ -636,7 +637,6 @@ static void ak4458_reset(struct ak4458_priv *ak4458, bool active) } } -#ifdef CONFIG_PM static int __maybe_unused ak4458_runtime_suspend(struct device *dev) { struct ak4458_priv *ak4458 = dev_get_drvdata(dev); -- 2.25.1

2 2

[linux-next:master] BUILD REGRESSION 044b771be9c5de9d817dfafb829d2f049c71c3b4
by kernel test robot 13 Sep '22

13 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 044b771be9c5de9d817dfafb829d2f049c71c3b4 Add linux-next specific files for 20220912 Error/Warning reports: https://lore.kernel.org/linux-media/202209020437.eXEOdmfe-lkp@intel.com https://lore.kernel.org/linux-mm/202209042337.FQi69rLV-lkp@intel.com https://lore.kernel.org/linux-mm/202209060229.dVuyxjBv-lkp@intel.com https://lore.kernel.org/linux-mm/202209080718.y5QmlNKH-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) ERROR: modpost: "ioread64" [drivers/pci/switch/switchtec.ko] undefined! drivers/gpu/drm/amd/amdgpu/imu_v11_0_3.c:139:6: warning: no previous prototype for 'imu_v11_0_3_program_rlc_ram' [-Wmissing-prototypes] drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encoder_state() instead drivers/pinctrl/pinctrl-amd.c:288 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x9a' drivers/pinctrl/pinctrl-amd.c:288 amd_gpio_dbg_show() warn: format string contains non-ascii character '\xa1' drivers/pinctrl/pinctrl-amd.c:370 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x95' drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration] drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration] kernel/bpf/memalloc.c:499 bpf_mem_alloc_destroy() error: potentially dereferencing uninitialized 'c'. sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- alpha-randconfig-r005-20220911 | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- alpha-randconfig-r033-20220911 | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- alpha-randconfig-r035-20220911 | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-axs101_defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r016-20220912 | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r032-20220912 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r043-20220911 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r043-20220912 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arm-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm-defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arm-randconfig-c034-20220911 | `-- net-bluetooth-mgmt.c:WARNING:kzalloc-should-be-used-for-rp-instead-of-kmalloc-memset |-- arm-randconfig-r032-20220911 | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm64-buildonly-randconfig-r002-20220912 | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used clang_recent_errors |-- arm64-randconfig-r011-20220912 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- hexagon-allyesconfig | |-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead | `-- drivers-staging-media-deprecated-cpia2-cpia2_usb.c:warning:variable-frame_count-set-but-not-used |-- i386-randconfig-a012-20220912 | `-- sound-soc-intel-skylake-skl.c:warning:unused-variable-skl |-- i386-randconfig-a015-20220912 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- mips-randconfig-r021-20220911 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- powerpc-randconfig-r002-20220911 | `-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-function-imu_v11_0_3_program_rlc_ram |-- riscv-randconfig-r015-20220912 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead `-- riscv-randconfig-r042-20220912 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 724m configs tested: 82 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig x86_64 defconfig x86_64 randconfig-a001-20220912 arc axs101_defconfig x86_64 randconfig-a002-20220912 i386 randconfig-a001-20220912 x86_64 rhel-8.3 x86_64 randconfig-a003-20220912 x86_64 rhel-8.3-func arm stm32_defconfig alpha allyesconfig sh se7724_defconfig x86_64 allyesconfig arm defconfig alpha allnoconfig i386 randconfig-a002-20220912 x86_64 rhel-8.3-kunit riscv allnoconfig m68k allmodconfig x86_64 rhel-8.3-kvm x86_64 randconfig-a006-20220912 i386 randconfig-a004-20220912 x86_64 randconfig-a004-20220912 csky allnoconfig arc allnoconfig sh se7705_defconfig i386 defconfig i386 allyesconfig m68k q40_defconfig i386 randconfig-a003-20220912 arc allyesconfig x86_64 rhel-8.3-kselftests x86_64 rhel-8.3-syz arm iop32x_defconfig x86_64 randconfig-a005-20220912 powerpc allnoconfig m68k allyesconfig riscv randconfig-r042-20220911 arm trizeps4_defconfig i386 randconfig-a006-20220912 arc randconfig-r043-20220912 mips allyesconfig sparc64 defconfig i386 randconfig-a005-20220912 powerpc allmodconfig arm64 allyesconfig sh allmodconfig s390 debug_defconfig arm allyesconfig arc randconfig-r043-20220911 s390 randconfig-r044-20220911 ia64 allmodconfig sh sh2007_defconfig sh ecovec24_defconfig sh alldefconfig sh rsk7269_defconfig clang tested configs: x86_64 randconfig-a011-20220912 x86_64 randconfig-a012-20220912 i386 randconfig-a013-20220912 x86_64 randconfig-a013-20220912 i386 randconfig-a011-20220912 x86_64 randconfig-a014-20220912 mips rs90_defconfig arm pcm027_defconfig x86_64 randconfig-a016-20220912 i386 randconfig-a012-20220912 arm ixp4xx_defconfig x86_64 randconfig-a015-20220912 i386 randconfig-a014-20220912 arm vexpress_defconfig i386 randconfig-a015-20220912 riscv randconfig-r042-20220912 hexagon randconfig-r041-20220912 i386 randconfig-a016-20220912 hexagon randconfig-r045-20220911 hexagon randconfig-r041-20220911 hexagon randconfig-r045-20220912 s390 randconfig-r044-20220912 mips malta_qemu_32r6_defconfig powerpc gamecube_defconfig x86_64 rhel-8.3-rust -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[PATCH] soundwire: bus: conditionally recheck UNATTACHED status
by Bard Liao 12 Sep '22

12 Sep '22

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> In configurations with two amplifiers on the same link, the Intel CI reports occasional enumeration/initialization timeouts during suspend-resume stress tests, where one of the two amplifiers becomes UNATTACHED immediately after being enumerated. This problem was reported both with Maxim and Realtek codecs, which pointed initially to a problem with status handling on the Intel side. The Cadence IP integrated on Intel platforms throws an interrupt when the status changes, and the information is kept with sticky bits until cleared. We initially added more checks to make sure the edge detection did not miss any transition, but that did not improve the results significantly. With the recent addition of the read_ping_status() callback, we were able to show that the status in sticky bits is shown as UNATTACHED even though the PING frames show the problematic device as ATTACHED. That completely breaks the entire logic where we assumed that a peripheral would always re-attach as device0. The resume timeouts make sense in that in those cases, the enumeration/initialization never happens a second time. One possible explanation is that this problem typically happens when a bus clash is reported, so it could very well be that the detection is fooled by a transient electrical issue or conflict between two peripherals. This patch conditionally double-checks the status reported in the sticky bits with the actual PING frame status. If the peripheral reports as attached in PING frames, the early detection based on sticky bits is discarded. Note that this patch only corrects issues of false positives on the manager side. If the peripheral lost and regain sync, then it would report as attached on Device0. A peripheral that would not reset its dev_num would not be compliant with the MIPI specification. BugLink: https://github.com/thesofproject/linux/issues/3638 BugLink: https://github.com/thesofproject/linux/issues/3325 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- Hi Vinod, You will need the "ASoC/soundwire: log actual PING status on resume issues" series which is applied at ASoC tree before appling this patch. --- drivers/soundwire/bus.c | 19 +++++++++++++++++++ drivers/soundwire/intel.c | 1 + include/linux/soundwire/sdw.h | 3 +++ 3 files changed, 23 insertions(+) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 2772973eebb1..d0d486f07673 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1767,6 +1767,25 @@ int sdw_handle_slave_status(struct sdw_bus *bus, slave->status != SDW_SLAVE_UNATTACHED) { dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\n", i, slave->status); + + if (bus->recheck_unattached && bus->ops->read_ping_status) { + u32 ping_status; + + mutex_lock(&bus->msg_lock); + + ping_status = bus->ops->read_ping_status(bus); + + mutex_unlock(&bus->msg_lock); + + ping_status >>= (i * 2); + ping_status &= 0x3; + + if (ping_status != 0) { + dev_warn(&slave->dev, "Slave %d state in PING frame is %d, ignoring earlier detection\n", + i, ping_status); + continue; + } + } sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); } } diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 25ec9c272239..0c6e674dbf85 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1311,6 +1311,7 @@ static int intel_link_probe(struct auxiliary_device *auxdev, bus->link_id = auxdev->id; bus->dev_num_ida_min = INTEL_DEV_NUM_IDA_MIN; + bus->recheck_unattached = true; sdw_cdns_probe(cdns); diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h index a2b31d25ea27..51ac71984260 100644 --- a/include/linux/soundwire/sdw.h +++ b/include/linux/soundwire/sdw.h @@ -892,6 +892,8 @@ struct sdw_master_ops { * @dev_num_ida_min: if set, defines the minimum values for the IDA * used to allocate system-unique device numbers. This value needs to be * identical across all SoundWire bus in the system. + * @recheck_unattached: if set, double-check UNATTACHED status changes + * by reading PING frame status. */ struct sdw_bus { struct device *dev; @@ -917,6 +919,7 @@ struct sdw_bus { bool multi_link; int hw_sync_min_links; int dev_num_ida_min; + bool recheck_unattached; }; int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent, -- 2.25.1

3 2

[PATCH] ASoC: rt5640: Fix the issue of the abnormal JD2 status
by Oder Chiou 12 Sep '22

12 Sep '22

The patch fixes the issue of the abnormal JD2 status. Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> Reported-by: Sameer Pujar <spujar(a)nvidia.com> --- sound/soc/codecs/rt5640.c | 64 +++++++++++++++++++++++++++------------ sound/soc/codecs/rt5640.h | 14 +++++++++ 2 files changed, 59 insertions(+), 19 deletions(-) diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c index 5a844329800..0f8e6dd214b 100644 --- a/sound/soc/codecs/rt5640.c +++ b/sound/soc/codecs/rt5640.c @@ -2494,7 +2494,7 @@ static void rt5640_enable_jack_detect(struct snd_soc_component *component, /* Select JD-source */ snd_soc_component_update_bits(component, RT5640_JD_CTRL, - RT5640_JD_MASK, rt5640->jd_src); + RT5640_JD_MASK, rt5640->jd_src << RT5640_JD_SFT); /* Selecting GPIO01 as an interrupt */ snd_soc_component_update_bits(component, RT5640_GPIO_CTRL1, @@ -2504,12 +2504,8 @@ static void rt5640_enable_jack_detect(struct snd_soc_component *component, snd_soc_component_update_bits(component, RT5640_GPIO_CTRL3, RT5640_GP1_PF_MASK, RT5640_GP1_PF_OUT); - /* Enabling jd2 in general control 1 */ snd_soc_component_write(component, RT5640_DUMMY1, 0x3f41); - /* Enabling jd2 in general control 2 */ - snd_soc_component_write(component, RT5640_DUMMY2, 0x4001); - rt5640_set_ovcd_params(component); /* @@ -2518,12 +2514,25 @@ static void rt5640_enable_jack_detect(struct snd_soc_component *component, * pin 0/1 instead of it being stuck to 1. So we invert the JD polarity * on systems where the hardware does not already do this. */ - if (rt5640->jd_inverted) - snd_soc_component_write(component, RT5640_IRQ_CTRL1, - RT5640_IRQ_JD_NOR); - else - snd_soc_component_write(component, RT5640_IRQ_CTRL1, - RT5640_IRQ_JD_NOR | RT5640_JD_P_INV); + if (rt5640->jd_inverted) { + if (rt5640->jd_src == RT5640_JD_SRC_JD1_IN4P) + snd_soc_component_write(component, RT5640_IRQ_CTRL1, + RT5640_IRQ_JD_NOR); + else if (rt5640->jd_src == RT5640_JD_SRC_JD2_IN4N) + snd_soc_component_update_bits(component, RT5640_DUMMY2, + RT5640_IRQ_JD2_MASK | RT5640_JD2_MASK, + RT5640_IRQ_JD2_NOR | RT5640_JD2_EN); + } else { + if (rt5640->jd_src == RT5640_JD_SRC_JD1_IN4P) + snd_soc_component_write(component, RT5640_IRQ_CTRL1, + RT5640_IRQ_JD_NOR | RT5640_JD_P_INV); + else if (rt5640->jd_src == RT5640_JD_SRC_JD2_IN4N) + snd_soc_component_update_bits(component, RT5640_DUMMY2, + RT5640_IRQ_JD2_MASK | RT5640_JD2_P_MASK | + RT5640_JD2_MASK, + RT5640_IRQ_JD2_NOR | RT5640_JD2_P_INV | + RT5640_JD2_EN); + } rt5640->jack = jack; if (rt5640->jack->status & SND_JACK_MICROPHONE) { @@ -2725,10 +2734,8 @@ static int rt5640_probe(struct snd_soc_component *component) if (device_property_read_u32(component->dev, "realtek,jack-detect-source", &val) == 0) { - if (val <= RT5640_JD_SRC_GPIO4) - rt5640->jd_src = val << RT5640_JD_SFT; - else if (val == RT5640_JD_SRC_HDA_HEADER) - rt5640->jd_src = RT5640_JD_SRC_HDA_HEADER; + if (val <= RT5640_JD_SRC_HDA_HEADER) + rt5640->jd_src = val; else dev_warn(component->dev, "Warning: Invalid jack-detect-source value: %d, leaving jack-detect disabled\n", val); @@ -2809,12 +2816,31 @@ static int rt5640_resume(struct snd_soc_component *component) regcache_sync(rt5640->regmap); if (rt5640->jack) { - if (rt5640->jd_src == RT5640_JD_SRC_HDA_HEADER) + if (rt5640->jd_src == RT5640_JD_SRC_HDA_HEADER) { snd_soc_component_update_bits(component, RT5640_DUMMY2, 0x1100, 0x1100); - else - snd_soc_component_write(component, RT5640_DUMMY2, - 0x4001); + } else { + if (rt5640->jd_inverted) { + if (rt5640->jd_src == RT5640_JD_SRC_JD2_IN4N) + snd_soc_component_update_bits( + component, RT5640_DUMMY2, + RT5640_IRQ_JD2_MASK | + RT5640_JD2_MASK, + RT5640_IRQ_JD2_NOR | + RT5640_JD2_EN); + + } else { + if (rt5640->jd_src == RT5640_JD_SRC_JD2_IN4N) + snd_soc_component_update_bits( + component, RT5640_DUMMY2, + RT5640_IRQ_JD2_MASK | + RT5640_JD2_P_MASK | + RT5640_JD2_MASK, + RT5640_IRQ_JD2_NOR | + RT5640_JD2_P_INV | + RT5640_JD2_EN); + } + } queue_delayed_work(system_long_wq, &rt5640->jack_work, 0); } diff --git a/sound/soc/codecs/rt5640.h b/sound/soc/codecs/rt5640.h index 505c9351405..f58b88e3325 100644 --- a/sound/soc/codecs/rt5640.h +++ b/sound/soc/codecs/rt5640.h @@ -1984,6 +1984,20 @@ #define RT5640_M_MONO_ADC_R_SFT 12 #define RT5640_MCLK_DET (0x1 << 11) +/* General Control 1 (0xfb) */ +#define RT5640_IRQ_JD2_MASK (0x1 << 12) +#define RT5640_IRQ_JD2_SFT 12 +#define RT5640_IRQ_JD2_BP (0x0 << 12) +#define RT5640_IRQ_JD2_NOR (0x1 << 12) +#define RT5640_JD2_P_MASK (0x1 << 10) +#define RT5640_JD2_P_SFT 10 +#define RT5640_JD2_P_NOR (0x0 << 10) +#define RT5640_JD2_P_INV (0x1 << 10) +#define RT5640_JD2_MASK (0x1 << 8) +#define RT5640_JD2_SFT 8 +#define RT5640_JD2_DIS (0x0 << 8) +#define RT5640_JD2_EN (0x1 << 8) + /* Codec Private Register definition */ /* MIC Over current threshold scale factor (0x15) */ -- 2.34.1

2 2

[PATCH v2] ASoC: Intel: sof_rt5682: Add support for jsl_rt5682_rt1019
by Sean Hong 12 Sep '22

12 Sep '22

This patch adds the driver data for rt5682 support jsl_rt5682_rt1019. Signed-off-by: Sean Hong <sean.hong(a)quanta.corp-partner.google.com> --- sound/soc/intel/boards/sof_rt5682.c | 9 +++++++++ sound/soc/intel/common/soc-acpi-intel-jsl-match.c | 12 ++++++++++++ 2 files changed, 21 insertions(+) diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c index 045965312..3a840f3a9 100644 --- a/sound/soc/intel/boards/sof_rt5682.c +++ b/sound/soc/intel/boards/sof_rt5682.c @@ -1100,6 +1100,15 @@ static const struct platform_device_id board_ids[] = { SOF_RT5682_SSP_AMP(1) | SOF_RT5682_NUM_HDMIDEV(4)), }, + { + .name = "jsl_rt5682_rt1019", + .driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN | + SOF_RT5682_MCLK_24MHZ | + SOF_RT5682_SSP_CODEC(0) | + SOF_SPEAKER_AMP_PRESENT | + SOF_RT1019_SPEAKER_AMP_PRESENT | + SOF_RT5682_SSP_AMP(1)), + }, { } }; MODULE_DEVICE_TABLE(platform, board_ids); diff --git a/sound/soc/intel/common/soc-acpi-intel-jsl-match.c b/sound/soc/intel/common/soc-acpi-intel-jsl-match.c index b95c4b2cd..e374bf163 100644 --- a/sound/soc/intel/common/soc-acpi-intel-jsl-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-jsl-match.c @@ -29,6 +29,11 @@ static const struct snd_soc_acpi_codecs rt1015p_spk = { .codecs = {"RTL1015"} }; +static struct snd_soc_acpi_codecs rt1019p_spk = { + .num_codecs = 1, + .codecs = {"RTL1019"} +}; + static const struct snd_soc_acpi_codecs mx98360a_spk = { .num_codecs = 1, .codecs = {"MX98360A"} @@ -78,6 +83,13 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = { .quirk_data = &mx98360a_spk, .sof_tplg_filename = "sof-jsl-rt5682-mx98360a.tplg", }, + { + .comp_ids = &rt5682_rt5682s_hp, + .drv_name = "jsl_rt5682_rt1019", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &rt1019p_spk, + .sof_tplg_filename = "sof-jsl-rt5682-rt1019.tplg", + }, { .id = "10134242", .drv_name = "jsl_cs4242_mx98360a", -- 2.25.1

3 3

[PATCH] ASoC: wm8978: Support the recording function of codec
by Mengchen Li 12 Sep '22

12 Sep '22

If we want to use the microphone function of the wm8978 codec, we must enable the microphone bias circuit and power up the bias circuit,otherwise the microphone can not vibrate for sound source sampling.The bit that controls the output voltage of the bias circuit is the fourth bit of the WM8978_POWER_MANAGEMENT_1 register,so this bit must be set to 1.This patch can support the recording function of the wm8978 codec. Signed-off-by: Mengchen Li <mengchenli64(a)gmail.com> --- sound/soc/codecs/wm8978.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm8978.c b/sound/soc/codecs/wm8978.c index a682f80..fdd5429 100644 --- a/sound/soc/codecs/wm8978.c +++ b/sound/soc/codecs/wm8978.c @@ -822,7 +822,9 @@ static int wm8978_hw_params(struct snd_pcm_substream *substream, snd_soc_component_write(component, WM8978_AUDIO_INTERFACE, iface_ctl); snd_soc_component_write(component, WM8978_ADDITIONAL_CONTROL, add_ctl); - + /* Enable MICBEN */ + snd_soc_component_write(component, WM8978_POWER_MANAGEMENT_1, + snd_soc_component_read(component, WM8978_POWER_MANAGEMENT_1) | 0x10); if (wm8978->sysclk != current_clk_id) { if (wm8978->sysclk == WM8978_PLL) /* Run CODEC from PLL instead of MCLK */ -- 2.7.4

2 1

[PATCH v1] ALSA: dummy: Add customizable volume min/max.
by YJ Lee 12 Sep '22

12 Sep '22

Add module parameters to support customized min/max volume leveling, which will be useful to test devices with different volume granularity. Signed-off-by: YJ Lee <yunjunlee(a)chromium.org> --- sound/drivers/dummy.c | 34 ++++++++++++++++++++++++---------- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 2a7fc49c1a7c5..64fb2778f1e9a 100644 --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -42,6 +42,8 @@ MODULE_LICENSE("GPL"); #define USE_CHANNELS_MAX 2 #define USE_PERIODS_MIN 1 #define USE_PERIODS_MAX 1024 +#define USE_MIXER_VOLUME_LEVEL_MIN -50 +#define USE_MIXER_VOLUME_LEVEL_MAX 100 static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; /* Index 0-MAX */ static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; /* ID for this card */ @@ -50,6 +52,8 @@ static char *model[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = NULL}; static int pcm_devs[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 1}; static int pcm_substreams[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 8}; //static int midi_devs[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 2}; +static int mixer_volume_level_min = USE_MIXER_VOLUME_LEVEL_MIN; +static int mixer_volume_level_max = USE_MIXER_VOLUME_LEVEL_MAX; #ifdef CONFIG_HIGH_RES_TIMERS static bool hrtimer = 1; #endif @@ -69,6 +73,10 @@ module_param_array(pcm_substreams, int, NULL, 0444); MODULE_PARM_DESC(pcm_substreams, "PCM substreams # (1-128) for dummy driver."); //module_param_array(midi_devs, int, NULL, 0444); //MODULE_PARM_DESC(midi_devs, "MIDI devices # (0-2) for dummy driver."); +module_param(mixer_volume_level_min, int, 0444); +MODULE_PARM_DESC(mixer_volume_level_min, "Minimum mixer volume level for dummy driver. Default: -50"); +module_param(mixer_volume_level_max, int, 0444); +MODULE_PARM_DESC(mixer_volume_level_max, "Maximum mixer volume level for dummy driver. Default: 100"); module_param(fake_buffer, bool, 0444); MODULE_PARM_DESC(fake_buffer, "Fake buffer allocations."); #ifdef CONFIG_HIGH_RES_TIMERS @@ -713,8 +721,8 @@ static int snd_dummy_volume_info(struct snd_kcontrol *kcontrol, { uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; uinfo->count = 2; - uinfo->value.integer.min = -50; - uinfo->value.integer.max = 100; + uinfo->value.integer.min = mixer_volume_level_min; + uinfo->value.integer.max = mixer_volume_level_max; return 0; } @@ -739,15 +747,15 @@ static int snd_dummy_volume_put(struct snd_kcontrol *kcontrol, int left, right; left = ucontrol->value.integer.value[0]; - if (left < -50) - left = -50; - if (left > 100) - left = 100; + if (left < mixer_volume_level_min) + left = mixer_volume_level_min; + if (left > mixer_volume_level_max) + left = mixer_volume_level_max; right = ucontrol->value.integer.value[1]; - if (right < -50) - right = -50; - if (right > 100) - right = 100; + if (right < mixer_volume_level_min) + right = mixer_volume_level_min; + if (right > mixer_volume_level_max) + right = mixer_volume_level_max; spin_lock_irq(&dummy->mixer_lock); change = dummy->mixer_volume[addr][0] != left || dummy->mixer_volume[addr][1] != right; @@ -1076,6 +1084,12 @@ static int snd_dummy_probe(struct platform_device *devptr) dummy->pcm_hw.channels_max = m->channels_max; } + if (mixer_volume_level_min > mixer_volume_level_max) { + pr_warn("snd-dummy: Invalid mixer volume level: min=%d, max=%d. Fall back to default value.\n", + mixer_volume_level_min, mixer_volume_level_max); + mixer_volume_level_min = USE_MIXER_VOLUME_LEVEL_MIN; + mixer_volume_level_max = USE_MIXER_VOLUME_LEVEL_MAX; + } err = snd_card_dummy_new_mixer(dummy); if (err < 0) return err; -- 2.31.0

2 2

[PATCH v1] ALSA: dummy: Fix trailing whitespaces.
by YJ Lee 12 Sep '22

12 Sep '22

Fix checkpatch.pl ERROR: trailing whitespaces. Signed-off-by: YJ Lee <yunjunlee(a)chromium.org> --- sound/drivers/dummy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 2a7fc49c1a7c5..fcf1ee00bd214 100644 --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -296,7 +296,7 @@ static void dummy_systimer_callback(struct timer_list *t) struct dummy_systimer_pcm *dpcm = from_timer(dpcm, t, timer); unsigned long flags; int elapsed = 0; - + spin_lock_irqsave(&dpcm->lock, flags); dummy_systimer_update(dpcm); dummy_systimer_rearm(dpcm); @@ -717,7 +717,7 @@ static int snd_dummy_volume_info(struct snd_kcontrol *kcontrol, uinfo->value.integer.max = 100; return 0; } - + static int snd_dummy_volume_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { @@ -766,7 +766,7 @@ static const DECLARE_TLV_DB_SCALE(db_scale_dummy, -4500, 30, 0); .private_value = addr } #define snd_dummy_capsrc_info snd_ctl_boolean_stereo_info - + static int snd_dummy_capsrc_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { @@ -1100,7 +1100,7 @@ static int snd_dummy_suspend(struct device *pdev) snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); return 0; } - + static int snd_dummy_resume(struct device *pdev) { struct snd_card *card = dev_get_drvdata(pdev); -- 2.37.2.789.g6183377224-goog

2 2

[PATCH] ASoC: ts3a227e: allow enabling the jack detect in driver
by Astrid Rost 12 Sep '22

12 Sep '22

ti,jack-detect enables the jack detection input device Signed-off-by: Astrid Rost <astrid.rost(a)axis.com> --- sound/soc/codecs/Kconfig | 2 ++ sound/soc/codecs/ts3a227e.c | 62 ++++++++++++++++++++++++++++++++++++- 2 files changed, 63 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index d16b4efb88a7..cb86e52cd02f 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1671,6 +1671,8 @@ config SND_SOC_TLV320ADCX140 config SND_SOC_TS3A227E tristate "TI Headset/Mic detect and keypress chip" depends on I2C + select SND_JACK + select SND_JACK_INPUT_DEV config SND_SOC_TSCS42XX tristate "Tempo Semiconductor TSCS42xx CODEC" diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c index d8ab0810fceb..b5d0d32cafdb 100644 --- a/sound/soc/codecs/ts3a227e.c +++ b/sound/soc/codecs/ts3a227e.c @@ -38,6 +38,32 @@ static const int ts3a227e_buttons[] = { SND_JACK_BTN_3, }; +/* Headphones jack detection DAPM pin */ +static struct snd_soc_jack_pin ts3a227e_jack_pins[] = { + + { + .pin = "Headphone Jack", + .mask = SND_JACK_HEADPHONE, + }, + { + .pin = "Internal Speaker", + /* disable speaker when hp jack is inserted */ + .mask = SND_JACK_HEADPHONE, + .invert = 1, + }, + { + .pin = "Headset Mic", + .mask = SND_JACK_MICROPHONE, + }, + { + .pin = "Internal Mic", + /* disable microphone when microphone jack is inserted */ + .mask = SND_JACK_MICROPHONE, + .invert = 1, + }, + +}; + #define TS3A227E_NUM_BUTTONS 4 #define TS3A227E_JACK_MASK (SND_JACK_HEADPHONE | \ SND_JACK_MICROPHONE | \ @@ -250,7 +276,12 @@ int ts3a227e_enable_jack_detect(struct snd_soc_component *component, } EXPORT_SYMBOL_GPL(ts3a227e_enable_jack_detect); -static struct snd_soc_component_driver ts3a227e_soc_driver; +static int ts3a227e_probe(struct snd_soc_component *component); + +static const struct snd_soc_component_driver ts3a227e_soc_driver = { + .name = "Audio Accessory Detection ts3a227e", + .probe = ts3a227e_probe, +}; static const struct regmap_config ts3a227e_regmap_config = { .val_bits = 8, @@ -355,6 +386,35 @@ static int ts3a227e_resume(struct device *dev) } #endif +static int ts3a227e_probe(struct snd_soc_component *component) +{ + int ret = 0; + bool enable = 0; + struct snd_soc_card *card = component->card; + struct ts3a227e *ts3a227e = snd_soc_component_get_drvdata(component); + + enable = device_property_read_bool(component->dev, "ti,jack-detect"); + if (enable) { + /* Enable Headset and 4 Buttons Jack detection */ + ts3a227e->jack = devm_kzalloc(component->dev, + sizeof(struct snd_soc_jack), GFP_KERNEL); + + ret = snd_soc_card_jack_new_pins(card, "Headset Jack", + SND_JACK_HEADSET | + SND_JACK_BTN_0 | SND_JACK_BTN_1 | + SND_JACK_BTN_2 | SND_JACK_BTN_3, + ts3a227e->jack, + ts3a227e_jack_pins, + ARRAY_SIZE(ts3a227e_jack_pins)); + if (ret) + return ret; + + ret = ts3a227e_enable_jack_detect(component, ts3a227e->jack); + } + + return ret; +} + static const struct dev_pm_ops ts3a227e_pm = { SET_SYSTEM_SLEEP_PM_OPS(ts3a227e_suspend, ts3a227e_resume) }; -- 2.20.1

4 5

Buffers used in ASoC Intel Atom SST driver
by Takashi Iwai 11 Sep '22

11 Sep '22

Hi, while cleaning up / fixing the memory allocation code, I noticed that Intel SST driver is the only driver that currently uses the SNDRV_DMA_TYPE_CONTINUOUS pages for its PCM buffer. Is there any reason not to use the standard device buffer (SNDRV_DMA_TYPE_DEV)? i.e. the change like below. thanks, Takashi -- 8< -- From: Takashi Iwai <tiwai(a)suse.de> Subject: [PATCH] ASoC: Intel: sst: Switch to standard device pages Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c index a56dd48c045f..c75616a5fd0a 100644 --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -676,10 +676,9 @@ static int sst_soc_pcm_new(struct snd_soc_component *component, if (dai->driver->playback.channels_min || dai->driver->capture.channels_min) { - snd_pcm_set_managed_buffer_all(pcm, - SNDRV_DMA_TYPE_CONTINUOUS, - snd_dma_continuous_data(GFP_DMA), - SST_MIN_BUFFER, SST_MAX_BUFFER); + snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV, + pcm->card->dev, + SST_MIN_BUFFER, SST_MAX_BUFFER); } return 0; } -- 2.35.3

4 5

[PATCH] ASoC: nau8825: Add ADCOUT IO drive strength control
by David Lin 11 Sep '22

11 Sep '22

Add a property to control the driving of ADCOUT. Signed-off-by: David Lin <CTLIN0(a)nuvoton.com> --- Documentation/devicetree/bindings/sound/nau8825.txt | 2 ++ sound/soc/codecs/nau8825.c | 6 ++++++ sound/soc/codecs/nau8825.h | 3 +++ 3 files changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/nau8825.txt b/Documentation/devicetree/bindings/sound/nau8825.txt index 388a7bc60b1f..54972cc2ca1a 100644 --- a/Documentation/devicetree/bindings/sound/nau8825.txt +++ b/Documentation/devicetree/bindings/sound/nau8825.txt @@ -71,6 +71,8 @@ Optional properties: - nuvoton,crosstalk-enable: make crosstalk function enable if set. + - nuvoton,adcout-drive-str: ADCOUT IO drive strength. 0 - normal, 1 - stronger. + - clocks: list of phandle and clock specifier pairs according to common clock bindings for the clocks described in clock-names - clock-names: should include "mclk" for the MCLK master clock diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index 8213273f501e..fc00e600cf2c 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1983,6 +1983,10 @@ static void nau8825_init_regs(struct nau8825 *nau8825) /* Disable short Frame Sync detection logic */ regmap_update_bits(regmap, NAU8825_REG_LEFT_TIME_SLOT, NAU8825_DIS_FS_SHORT_DET, NAU8825_DIS_FS_SHORT_DET); + /* ADCDAT IO drive strength control */ + regmap_update_bits(remap, NAU8825_REG_CHARGE_PUMP, + NAU8825_ADCOUT_DS_MASK, + nau8825->adcout_ds << NAU8825_ADCOUT_DS_SFT); } static const struct regmap_config nau8825_regmap_config = { @@ -2521,6 +2525,7 @@ static void nau8825_print_device_properties(struct nau8825 *nau8825) nau8825->jack_eject_debounce); dev_dbg(dev, "crosstalk-enable: %d\n", nau8825->xtalk_enable); + dev_dbg(dev, "adcout-drive-str: %d\n", nau8825->adcout_ds); } static int nau8825_read_device_properties(struct device *dev, @@ -2587,6 +2592,7 @@ static int nau8825_read_device_properties(struct device *dev, nau8825->jack_eject_debounce = 0; nau8825->xtalk_enable = device_property_read_bool(dev, "nuvoton,crosstalk-enable"); + nau8825->adcout_ds = device_property_read_bool(dev, "nuvoton,adcout-drive-str"); nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) { diff --git a/sound/soc/codecs/nau8825.h b/sound/soc/codecs/nau8825.h index 887bbff03ec6..6d112b6145df 100644 --- a/sound/soc/codecs/nau8825.h +++ b/sound/soc/codecs/nau8825.h @@ -418,6 +418,8 @@ #define NAU8825_POWERUP_HP_DRV_L (1 << 0) /* CHARGE_PUMP (0x80) */ +#define NAU8825_ADCOUT_DS_SFT 12 +#define NAU8825_ADCOUT_DS_MASK (1 << NAU8825_ADCOUT_DS_SFT) #define NAU8825_JAMNODCLOW (1 << 10) #define NAU8825_POWER_DOWN_DACR (1 << 9) #define NAU8825_POWER_DOWN_DACL (1 << 8) @@ -477,6 +479,7 @@ struct nau8825 { int imp_rms[NAU8825_XTALK_IMM]; int xtalk_enable; bool xtalk_baktab_initialized; /* True if initialized. */ + bool adcout_ds; }; int nau8825_enable_jack_detect(struct snd_soc_component *component, -- 2.25.1

4 3

[PATCH] ASoC: wm8731: fix build when I2C is not enabled
by Randy Dunlap 11 Sep '22

11 Sep '22

Building wm8731-i2c.c has a kconfig warning and build errors when I2C is not enabled, so prevent that kconfig-uration. WARNING: unmet direct dependencies detected for SND_SOC_WM8731_I2C Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && I2C [=n] Selected by [m]: - SND_SOC_DB1200 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AU1XPSC [=m] and subsequent build errors: ../sound/soc/codecs/wm8731-i2c.c:64:1: warning: data definition has no type or storage class 64 | module_i2c_driver(wm8731_i2c_driver); ../sound/soc/codecs/wm8731-i2c.c:64:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] ../sound/soc/codecs/wm8731-i2c.c:64:1: warning: parameter names (without types) in function declaration ../sound/soc/codecs/wm8731-i2c.c:55:26: warning: 'wm8731_i2c_driver' defined but not used [-Wunused-variable] 55 | static struct i2c_driver wm8731_i2c_driver = { Fixes: 9dc15f81baf2 ("ASoC: wm8731: Factor out the I2C and SPI bus code into separate modules") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Mark Brown <broonie(a)kernel.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: alsa-devel(a)alsa-project.org Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai --- sound/soc/au1x/Kconfig | 1 + 1 file changed, 1 insertion(+) --- a/sound/soc/au1x/Kconfig +++ b/sound/soc/au1x/Kconfig @@ -54,6 +54,7 @@ config SND_SOC_DB1000 config SND_SOC_DB1200 tristate "DB1200/DB1300/DB1550 Audio support" depends on SND_SOC_AU1XPSC + depends on I2C select SND_SOC_AU1XPSC_AC97 select SND_SOC_AC97_CODEC select SND_SOC_WM9712

1 0

[PATCH] ALSA: hda: Fix hang at HD-audio codec unbinding due to refcount saturation
by Takashi Iwai 10 Sep '22

10 Sep '22

We fixed the potential deadlock at dynamic unbinding the HD-audio codec at the commit 7206998f578d ("ALSA: hda: Fix potential deadlock at codec unbinding"), but ironically, this caused another potential deadlock. The current code uses refcount_dec() and waits for the pending task with wait_event for dropping the refcount to 0. This works fine when PCMs are assigned and actually waiting for the refcount drop. Meanwhile, when there was no PCM assigned, the refcount_dec() call itself was supposed to drop to zero -- alas, it doesn't in reality; refcount_dec() complains, spews kernel warning and it saturates instead of dropping to 0, due to the nature of refcount_dec() implementation. This eventually blocks the wait_event() wakeup and the code get stuck there. For avoiding the problem, we call refcount_dec_and_test() and skips the sync-wait if it already reaches to zero. The patch does a slight code reshuffling to make sure to invoke other disconnect calls before the sync-wait, too. Fixes: 7206998f578d ("ALSA: hda: Fix potential deadlock at codec unbinding") Reported-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Tested-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/YxtflWQnslMHVlU7@intel.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/hda_bind.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_bind.c b/sound/pci/hda/hda_bind.c index cae9a975cbcc..1a868dd9dc4b 100644 --- a/sound/pci/hda/hda_bind.c +++ b/sound/pci/hda/hda_bind.c @@ -157,10 +157,10 @@ static int hda_codec_driver_remove(struct device *dev) return codec->bus->core.ext_ops->hdev_detach(&codec->core); } - refcount_dec(&codec->pcm_ref); snd_hda_codec_disconnect_pcms(codec); snd_hda_jack_tbl_disconnect(codec); - wait_event(codec->remove_sleep, !refcount_read(&codec->pcm_ref)); + if (!refcount_dec_and_test(&codec->pcm_ref)) + wait_event(codec->remove_sleep, !refcount_read(&codec->pcm_ref)); snd_power_sync_ref(codec->bus->card); if (codec->patch_ops.free) -- 2.35.3

1 0

hda codec unbind refcount hang
by Ville Syrjälä 10 Sep '22

10 Sep '22

Hi Takashi, commit 7206998f578d ("ALSA: hda: Fix potential deadlock at codec unbinding") introduced a problem on at least one of my older machines. The problem happens when hda_codec_driver_remove() encounters a codec without any pcms (and thus the refcount is 1) and tries to call refcount_dec(). Turns out refcount_dec() doesn't like to be used for dropping the refcount to 0, and instead if spews a warning and does its saturate thing. The subsequent wait_event() is then permanently stuck waiting on the saturated refcount. I've definitely seen the same kind of pattern used elsewhere in the kernel as well, so the fact that refcount_t can't be used to implement it is a bit of surprise to me. I guess most other places still use atomic_t instead. -- Ville Syrjälä Intel

2 4

aseqdump crashing after running for a bit
by GitHub issues - edited 10 Sep '22

10 Sep '22

alsa-project/alsa-utils issue #170 was edited from BlastBolt5: I have been working on a script to control pipewire sources and sinks using faders on my midi keyboard but aseqdump keeps erroring out with > Port unsubscribed 128:0 I don't have any other midi device to test it out and see if it's specific to this conrtoller but I'm using the Korg nanoKontrol2. If i need to provide anything else just let me know. Issue URL : https://github.com/alsa-project/alsa-utils/issues/170 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

aseqdump crashing after running for a bit
by GitHub issues - opened 10 Sep '22

10 Sep '22

alsa-project/alsa-utils issue #170 was opened from BlastBolt5: I have been working on a script to control pipewire sources and sinks using faders on my midi keyboard but it keeps erroring out with > Port unsubscribed 128:0 I don't have any other midi device to test it out and see if it's specific to this conrtoller but I'm using the Korg nanoKontrol2. If i need to provide anything else just let me know. Issue URL : https://github.com/alsa-project/alsa-utils/issues/170 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH 0/8] Add support for the internal RK3308 audio codec
by luca.ceresoli＠bootlin.com 10 Sep '22

10 Sep '22

From: Luca Ceresoli <luca.ceresoli(a)bootlin.com> This series of patches adds support to use the internal audio codec of the Rockchip RK3308 SoC. This codec is internally connected to the I2S peripherals on the same chip, and it has some peculiarities arising from that interconnection. For proper bidirectional operation with the internal codec, the I2S peripheral needs two clock sources (tx and rx), while connection with an external codec commonly needs only one. Since v5.16 there is a driver for the I2S in sound/soc/rockchip/rockchip_i2s_tdm.c, but it does not correctly handle receiving those two clocks via the .set_sysclk op. Patch 5 fixes that. However the simple-audio-card and audio-graph-card sound card drivers do not support calling .set_sysclk twice, thus patch 6 makes the .init op of struct asoc_simple_priv overridable by a driver in order to be able to call .set_sysclk twice and thus configure both clocks. Patch 7 adds the codec driver and patch 8 builds on top of all the above by implementing a simple RK3308-specific audio card, based on audio-graph-card. This card sets all the I2S input clocks. Patches 1-2 add DT bindings for the codec and the card. Patches 3-4 add to the SoC DT file two I2S controllers (those which are internally connected to the internal codec) and the codec itself. Luca Luca Ceresoli (8): ASoC: rockchip: rk3308: add internal audio codec bindings ASoC: rockchip: rk3308: add audio card bindings arm64: dts: rockchip: add i2s_8ch_2 and i2s_8ch_3 arm64: dts: rockchip: add the internal audio codec ASoC: rockchip: i2s-tdm: Fix clk_id usage in .set_sysclk() ASoC: audio-graph: let dai_link->init be overridable ASoC: codecs: Add RK3308 internal audio codec driver ASoC: rockchip: add new RK3308 sound card .../rockchip,rk3308-audio-graph-card.yaml | 50 + .../bindings/sound/rockchip,rk3308-codec.yaml | 102 + MAINTAINERS | 14 + arch/arm64/boot/dts/rockchip/rk3308.dtsi | 68 + .../dt-bindings/sound/rockchip,rk3308-codec.h | 15 + include/sound/simple_card_utils.h | 1 + sound/soc/codecs/Kconfig | 11 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/rk3308_codec.c | 2122 +++++++++++++++++ sound/soc/codecs/rk3308_codec.h | 648 +++++ sound/soc/generic/audio-graph-card.c | 2 + sound/soc/rockchip/Kconfig | 14 + sound/soc/rockchip/Makefile | 1 + sound/soc/rockchip/rockchip_i2s_tdm.c | 18 +- sound/soc/rockchip/rockchip_rk3308_card.c | 97 + 15 files changed, 3159 insertions(+), 6 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml create mode 100644 include/dt-bindings/sound/rockchip,rk3308-codec.h create mode 100644 sound/soc/codecs/rk3308_codec.c create mode 100644 sound/soc/codecs/rk3308_codec.h create mode 100644 sound/soc/rockchip/rockchip_rk3308_card.c -- 2.34.1

6 23

[PATCH] ASoC: hdmi-codec.c: use devm_kzalloc() for DMA data
by Kuninori Morimoto 10 Sep '22

10 Sep '22

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> hdmi-codec.c is using kzalloc(), but we can replace it to devm_kzalloc() and then, we can remove .remove callback. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/codecs/hdmi-codec.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index 863e679d2ac1..0b1cdb2d6049 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -823,7 +823,7 @@ static int hdmi_dai_probe(struct snd_soc_dai *dai) if (ret) return ret; - daifmt = kzalloc(sizeof(*daifmt), GFP_KERNEL); + daifmt = devm_kzalloc(dai->dev, sizeof(*daifmt), GFP_KERNEL); if (!daifmt) return -ENOMEM; @@ -890,17 +890,10 @@ static int hdmi_dai_spdif_probe(struct snd_soc_dai *dai) return 0; } -static int hdmi_codec_dai_remove(struct snd_soc_dai *dai) -{ - kfree(dai->playback_dma_data); - return 0; -} - static const struct snd_soc_dai_driver hdmi_i2s_dai = { .name = "i2s-hifi", .id = DAI_ID_I2S, .probe = hdmi_dai_probe, - .remove = hdmi_codec_dai_remove, .playback = { .stream_name = "I2S Playback", .channels_min = 2, @@ -925,7 +918,6 @@ static const struct snd_soc_dai_driver hdmi_spdif_dai = { .name = "spdif-hifi", .id = DAI_ID_SPDIF, .probe = hdmi_dai_spdif_probe, - .remove = hdmi_codec_dai_remove, .playback = { .stream_name = "SPDIF Playback", .channels_min = 2, -- 2.25.1

3 2

[PATCH v3] ASoC: fsl_asrc: Add initialization finishing check in runtime resume
by Shengjiu Wang 10 Sep '22

10 Sep '22

If the initialization is not finished, then filling input data to the FIFO may fail. So it is better to add initialization finishing check in the runtime resume for suspend & resume case. And consider the case of three instances working in parallel, increase the retry times to 50 for more initialization time. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Reviewed-by: Nicolin Chen <nicolinc(a)gmail.com> --- changes in v3: - update warning message. changes in v2: - update comments. sound/soc/fsl/fsl_asrc.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index aa5edf32d988..936aef5d2767 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -20,6 +20,7 @@ #define IDEAL_RATIO_DECIMAL_DEPTH 26 #define DIVIDER_NUM 64 +#define INIT_RETRY_NUM 50 #define pair_err(fmt, ...) \ dev_err(&asrc->pdev->dev, "Pair %c: " fmt, 'A' + index, ##__VA_ARGS__) @@ -27,6 +28,9 @@ #define pair_dbg(fmt, ...) \ dev_dbg(&asrc->pdev->dev, "Pair %c: " fmt, 'A' + index, ##__VA_ARGS__) +#define pair_warn(fmt, ...) \ + dev_warn(&asrc->pdev->dev, "Pair %c: " fmt, 'A' + index, ##__VA_ARGS__) + /* Corresponding to process_option */ static unsigned int supported_asrc_rate[] = { 5512, 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000, @@ -579,7 +583,7 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair) { struct fsl_asrc *asrc = pair->asrc; enum asrc_pair_index index = pair->index; - int reg, retry = 10, i; + int reg, retry = INIT_RETRY_NUM, i; /* Enable the current pair */ regmap_update_bits(asrc->regmap, REG_ASRCTR, @@ -592,6 +596,10 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair) reg &= ASRCFG_INIRQi_MASK(index); } while (!reg && --retry); + /* NOTE: Doesn't treat initialization timeout as an error */ + if (!retry) + pair_warn("initialization isn't finished\n"); + /* Make the input fifo to ASRC STALL level */ regmap_read(asrc->regmap, REG_ASRCNCR, &reg); for (i = 0; i < pair->channels * 4; i++) @@ -1257,6 +1265,7 @@ static int fsl_asrc_runtime_resume(struct device *dev) { struct fsl_asrc *asrc = dev_get_drvdata(dev); struct fsl_asrc_priv *asrc_priv = asrc->private; + int reg, retry = INIT_RETRY_NUM; int i, ret; u32 asrctr; @@ -1295,6 +1304,24 @@ static int fsl_asrc_runtime_resume(struct device *dev) regmap_update_bits(asrc->regmap, REG_ASRCTR, ASRCTR_ASRCEi_ALL_MASK, asrctr); + /* Wait for status of initialization for all enabled pairs */ + do { + udelay(5); + regmap_read(asrc->regmap, REG_ASRCFG, &reg); + reg = (reg >> ASRCFG_INIRQi_SHIFT(0)) & 0x7; + } while ((reg != ((asrctr >> ASRCTR_ASRCEi_SHIFT(0)) & 0x7)) && --retry); + + /* + * NOTE: Doesn't treat initialization timeout as an error + * Some of the pairs may success, then still can continue. + */ + if (!retry) { + for (i = ASRC_PAIR_A; i < ASRC_PAIR_MAX_NUM; i++) { + if ((asrctr & ASRCTR_ASRCEi_MASK(i)) && !(reg & (1 << i))) + dev_warn(dev, "Pair %c initialization isn't finished\n", 'A' + i); + } + } + return 0; disable_asrck_clk: -- 2.34.1

2 1

Re: [PATCH] ASoC: mediatek: mt6359: fix platform_get_irq error checking
by Mark Brown 09 Sep '22

09 Sep '22

On Fri, Sep 09, 2022 at 02:45:11PM +0800, Yu Zhe wrote: > The platform_get_irq() function returns negative error codes on error, > fix the checking. This doesn't apply against current code, please check and resend.

1 0

[PATCH 0/7] ASoC: SOF: ipc4: Add support for 'mtrace' log extraction
by Peter Ujfalusi 09 Sep '22

09 Sep '22

Hi, The traditional dtrace used by SOF IPC3 is not available with firmware built as IPC4. With the new IPC implementation we have a new log extraction infrastructure and 'mtrace' is one way to get the logs out from the firmware for debugging. The protocol is relatively simple: The shared sram's debug window is split up to 'slots' Each DSP core will get a dedicated slot assigned for log output. The function of a slots can be checked in a descriptor table. The slot used for logging has the following layout: u32 host_read_ptr; u32 dsp_write_ptr; u8 buffer[]; The two pointers are offsets within the buffer. The firmware manages the write pointer, the host updates the read pointer value and based on the two pointers the log entries can be extracted. The firmware also sends notification when new entries are available in the log slot. The user space tool to read the log entries can be found in the SOF repository: https://github.com/thesofproject/sof/blob/main/tools/mtrace/mtrace-reader.py Regards, Peter --- Peter Ujfalusi (7): ASoC: SOF: ipc4: Only print LOG BUFFER update message info if requested ASoC: SOF: ipc4: Add macro to get core ID from log buffer status message ASoC: SOF: ipc4: Add define for the outbox window index ASoC: SOF: ipc4: Configure the debug box offset ASoC: SOF: ipc4: Add support for mtrace log extraction ASoC: SOF: Intel: icl: Set IPC4-specific DSP ops ASoC: SOF: Intel: Add mtrace type information for IPC4 include/sound/sof/ipc4/header.h | 5 + sound/soc/sof/Makefile | 3 +- sound/soc/sof/intel/apl.c | 2 + sound/soc/sof/intel/cnl.c | 2 + sound/soc/sof/intel/icl.c | 30 +- sound/soc/sof/intel/mtl.c | 2 + sound/soc/sof/intel/tgl.c | 2 + sound/soc/sof/ipc4-loader.c | 2 + sound/soc/sof/ipc4-mtrace.c | 643 ++++++++++++++++++++++++++++++++ sound/soc/sof/ipc4-priv.h | 18 +- sound/soc/sof/ipc4.c | 22 +- 11 files changed, 724 insertions(+), 7 deletions(-) create mode 100644 sound/soc/sof/ipc4-mtrace.c -- 2.37.3

2 8

[linux-next:master] BUILD REGRESSION 9a82ccda91ed2b40619cb3c10d446ae1f97bab6e
by kernel test robot 09 Sep '22

09 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9a82ccda91ed2b40619cb3c10d446ae1f97bab6e Add linux-next specific files for 20220909 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.FQi69rLV-lkp@intel.com https://lore.kernel.org/linux-mm/202209080718.y5QmlNKH-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) ./drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encoder_state() instead ERROR: modpost: "__divdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! ERROR: modpost: "__udivdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! arm-linux-gnueabi-ld: vkms_formats.c:(.text+0x824): undefined reference to `__aeabi_ldivmod' drivers/base/regmap/regmap-mmio.c:222:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:225:17: error: implicit declaration of function 'writesw'; did you mean 'writew'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:228:17: error: implicit declaration of function 'writesl'; did you mean 'writel'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:358:17: error: implicit declaration of function 'readsb'; did you mean 'readb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:361:17: error: implicit declaration of function 'readsw'; did you mean 'readw'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:364:17: error: implicit declaration of function 'readsl'; did you mean 'readl'? [-Werror=implicit-function-declaration] drivers/gpu/drm/amd/amdgpu/imu_v11_0_3.c:139:6: warning: no previous prototype for 'imu_v11_0_3_program_rlc_ram' [-Wmissing-prototypes] drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encoder_state() instead drivers/gpu/drm/vkms/vkms_formats.c:259: undefined reference to `__divdi3' drivers/gpu/drm/vkms/vkms_plane.c:110 vkms_plane_atomic_update() warn: variable dereferenced before check 'fb' (see line 108) drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration] drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration] kernel/bpf/memalloc.c:499 bpf_mem_alloc_destroy() error: potentially dereferencing uninitialized 'c'. ld: drivers/gpu/drm/vkms/vkms_formats.c:260: undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x362): undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x3b2): undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x3ba): undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x47f): undefined reference to `__divdi3' microblaze-linux-ld: drivers/gpu/drm/vkms/vkms_formats.c:260: undefined reference to `__divdi3' mips-linux-ld: vkms_formats.c:(.text+0x8b8): undefined reference to `__divdi3' mips-linux-ld: vkms_formats.c:(.text.argb_u16_to_RGB565+0xd0): undefined reference to `__divdi3' sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] vkms_formats.c:(.text+0x266): undefined reference to `__divdi3' vkms_formats.c:(.text+0x338): undefined reference to `__divdi3' vkms_formats.c:(.text+0x388): undefined reference to `__divdi3' vkms_formats.c:(.text+0x390): undefined reference to `__divdi3' vkms_formats.c:(.text+0x455): undefined reference to `__divdi3' vkms_formats.c:(.text+0x804): undefined reference to `__aeabi_ldivmod' vkms_formats.c:(.text+0x89c): undefined reference to `__divdi3' vkms_formats.c:(.text.argb_u16_to_RGB565+0xb0): undefined reference to `__divdi3' Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-randconfig-r025-20220908 | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-randconfig-s033-20220907 | |-- kernel-bpf-hashtab.c:sparse:sparse:cast-removes-address-space-__percpu-of-expression | |-- kernel-bpf-hashtab.c:sparse:sparse:incorrect-type-in-assignment-(different-address-spaces)-expected-void-noderef-__percpu-assigned-pptr-got-void | |-- kernel-bpf-hashtab.c:sparse:sparse:incorrect-type-in-assignment-(different-address-spaces)-expected-void-ptr_to_pptr-got-void-noderef-__percpu-assigned-pptr | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__percpu-__pdata-got-void | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__percpu-__pdata-got-void-pptr | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-pptr-got-void-noderef-__percpu | `-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand |-- arm-allyesconfig | |-- arm-linux-gnueabi-ld:vkms_formats.c:(.text):undefined-reference-to-__aeabi_ldivmod | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used | `-- vkms_formats.c:(.text):undefined-reference-to-__aeabi_ldivmod |-- arm-defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arm64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm64-randconfig-r021-20220908 | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm64-randconfig-r034-20220909 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- ld:vkms_formats.c:(.text):undefined-reference-to-__divdi3 | |-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used | `-- vkms_formats.c:(.text):undefined-reference-to-__divdi3 |-- i386-defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-randconfig-a003 | |-- ERROR:__divdi3-drivers-gpu-drm-vkms-vkms.ko-undefined | |-- ERROR:__udivdi3-drivers-gpu-drm-vkms-vkms.ko-undefined | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- i386-randconfig-a012 clang_recent_errors |-- arm64-randconfig-r006-20220908 | `-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-function-imu_v11_0_3_program_rlc_ram |-- i386-randconfig-a002 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- i386-randconfig-a006 | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- i386-randconfig-a013 | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- i386-randconfig-a015 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- riscv-randconfig-r001-20220908 | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- riscv-randconfig-r013-20220907 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- x86_64-randconfig-a003 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- x86_64-randconfig-a012 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead `-- x86_64-randconfig-a016 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 729m configs tested: 75 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig i386 randconfig-a001 i386 randconfig-a003 x86_64 defconfig i386 defconfig i386 randconfig-a005 m68k allmodconfig arc allyesconfig i386 allyesconfig arm defconfig x86_64 randconfig-a004 alpha allyesconfig x86_64 randconfig-a002 x86_64 rhel-8.3 m68k allyesconfig powerpc allnoconfig x86_64 allyesconfig x86_64 randconfig-a015 arm allyesconfig x86_64 randconfig-a006 arm64 allyesconfig x86_64 randconfig-a013 powerpc allmodconfig x86_64 randconfig-a011 sh allmodconfig ia64 allmodconfig mips allyesconfig mips loongson3_defconfig arc randconfig-r043-20220907 x86_64 rhel-8.3-func parisc alldefconfig x86_64 rhel-8.3-kunit sh migor_defconfig powerpc ppc40x_defconfig x86_64 rhel-8.3-kvm openrisc defconfig sh apsh4a3a_defconfig x86_64 rhel-8.3-kselftests x86_64 rhel-8.3-syz i386 randconfig-a014 alpha allnoconfig i386 randconfig-a012 riscv allnoconfig sh edosk7705_defconfig csky allnoconfig i386 randconfig-a016 sh shx3_defconfig arc allnoconfig ia64 bigsur_defconfig s390 zfcpdump_defconfig sh rsk7201_defconfig powerpc bamboo_defconfig i386 randconfig-c001 clang tested configs: i386 randconfig-a002 i386 randconfig-a004 i386 randconfig-a006 x86_64 randconfig-a005 x86_64 randconfig-a001 x86_64 randconfig-a014 x86_64 randconfig-a003 hexagon randconfig-r041-20220907 riscv randconfig-r042-20220907 x86_64 randconfig-a016 x86_64 randconfig-a012 hexagon randconfig-r045-20220907 s390 randconfig-r044-20220907 i386 randconfig-a013 i386 randconfig-a015 i386 randconfig-a011 mips ip22_defconfig mips ath79_defconfig powerpc ppa8548_defconfig x86_64 rhel-8.3-rust x86_64 randconfig-k001 -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

build failure of next-20220909 due to e9e7df88996d ("ASoC: ak4458: Remove component probe() and remove()")
by Sudip Mukherjee (Codethink) 09 Sep '22

09 Sep '22

Hi All, The builds of loongarch, alpha, s390, csky and s390allmodconfig have failed to build next-20220909 with the error: sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined but not used [-Werror=unused-function] 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) | ^~~~~~~~~~~~ git bisect pointed to e9e7df88996d ("ASoC: ak4458: Remove component probe() and remove()") I will be happy to test any patch or provide any extra log if needed. -- Regards Sudip

1 0

[PATCH v2 1/3] slimbus: qcom-ngd: use correct error in message of pdr_add_lookup() failure
by Krzysztof Kozlowski 09 Sep '22

09 Sep '22

Use correct error code, instead of previous 'ret' value, when printing error from pdr_add_lookup() failure. Cc: <stable(a)vger.kernel.org> Fixes: e1ae85e1830e ("slimbus: qcom-ngd-ctrl: add Protection Domain Restart Support") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- Changes since v1: 1. Correct typo 2. Return 'ret' instead of again PTR_ERR --- drivers/slimbus/qcom-ngd-ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 0aa8408464ad..f4f330b9fa72 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1581,8 +1581,9 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) pds = pdr_add_lookup(ctrl->pdr, "avs/audio", "msm/adsp/audio_pd"); if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) { + ret = PTR_ERR(pds); dev_err(dev, "pdr add lookup failed: %d\n", ret); - return PTR_ERR(pds); + return ret; } platform_driver_register(&qcom_slim_ngd_driver); -- 2.34.1

2 3

po: Add Georgian translation
by GitHub pull_request - opened 09 Sep '22

09 Sep '22

alsa-project/alsa-utils pull request #169 was opened from NorwayFun: po: Add Georgian translation Request URL : https://github.com/alsa-project/alsa-utils/pull/169 Patch URL : https://github.com/alsa-project/alsa-utils/pull/169.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH] sound: oss: dmasound: remove software_input_volume declaration
by Gaosheng Cui 09 Sep '22

09 Sep '22

expand_read_bal has been removed since commit fc37449f7959 ("The next round of scheduled OSS code removal"). software_input_volume has been removed since commit 0a1b42db4bf9 ("sound: sound/oss/dmasound/: cleanups"). so remove the declare for them from header file. Signed-off-by: Gaosheng Cui <cuigaosheng1(a)huawei.com> --- sound/oss/dmasound/dmasound.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/oss/dmasound/dmasound.h b/sound/oss/dmasound/dmasound.h index ad8ce6a1c25c..f065840c0efb 100644 --- a/sound/oss/dmasound/dmasound.h +++ b/sound/oss/dmasound/dmasound.h @@ -250,7 +250,4 @@ extern int dmasound_catchRadius; #define SW_INPUT_VOLUME_SCALE 4 #define SW_INPUT_VOLUME_DEFAULT (128 / SW_INPUT_VOLUME_SCALE) -extern int expand_read_bal; /* Balance factor for reading */ -extern uint software_input_volume; /* software implemented recording volume! */ - #endif /* _dmasound_h_ */ -- 2.25.1

2 1

[PATCH 0/2] Remove unused declarations
by Gaosheng Cui 09 Sep '22

09 Sep '22

This series contains a few cleanup patches, to remove unused declarations which have been removed. Thanks! Gaosheng Cui (2): ALSA: line6: remove line6_set_raw declaration ALSA: memalloc: remove snd_dma_sg_ops declaration sound/core/memalloc_local.h | 4 ---- sound/usb/line6/driver.h | 2 -- 2 files changed, 6 deletions(-) -- 2.25.1

2 3

[PATCH v9 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver
by Ban Tao 09 Sep '22

09 Sep '22

The Allwinner H6 and later SoCs have an DMIC block which is capable of capture. Signed-off-by: Ban Tao <fengzheng923(a)gmail.com> Tested-by: Samuel Holland <samuel(a)sholland.org> --- v1->v2: 1.Fix some compilation errors. 2.Modify some code styles. v2->v3: None. v3->v4: 1.add sig_bits. v4->v5: None. v5->v6: 1.Modify RXFIFO_CTL_MODE to mode 1. v6->v7: 1.Modify dmic_rate_s to be a global variable. 2.Changed some macro names to make more sense. 3.Align code format. 4.Add a depends on PM to Kconfig entry. v7->v8: None. v8->v9: 1.Modified Kconfig. 2.Added a comment. --- MAINTAINERS | 7 + sound/soc/sunxi/Kconfig | 7 + sound/soc/sunxi/Makefile | 1 + sound/soc/sunxi/sun50i-dmic.c | 406 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 421 insertions(+) create mode 100644 sound/soc/sunxi/sun50i-dmic.c diff --git a/MAINTAINERS b/MAINTAINERS index e9d5b05..839f625 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -796,6 +796,13 @@ L: linux-media(a)vger.kernel.org S: Maintained F: drivers/staging/media/sunxi/cedrus/ +ALLWINNER DMIC DRIVERS +M: Ban Tao <fengzheng923(a)gmail.com> +L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml +F: sound/soc/sunxi/sun50i-dmic.c + ALPHA PORT M: Richard Henderson <rth(a)twiddle.net> M: Ivan Kokshaysky <ink(a)jurassic.park.msu.ru> diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig index ddcaaa9..1f18f01 100644 --- a/sound/soc/sunxi/Kconfig +++ b/sound/soc/sunxi/Kconfig @@ -56,6 +56,13 @@ config SND_SUN4I_SPDIF Say Y or M to add support for the S/PDIF audio block in the Allwinner A10 and affiliated SoCs. +config SND_SUN50I_DMIC + tristate "Allwinner H6 DMIC Support" + select SND_SOC_GENERIC_DMAENGINE_PCM + help + Say Y or M to add support for the DMIC audio block in the Allwinner + H6 and affiliated SoCs. + config SND_SUN8I_ADDA_PR_REGMAP tristate select REGMAP diff --git a/sound/soc/sunxi/Makefile b/sound/soc/sunxi/Makefile index a86be34..4483fe9 100644 --- a/sound/soc/sunxi/Makefile +++ b/sound/soc/sunxi/Makefile @@ -6,3 +6,4 @@ obj-$(CONFIG_SND_SUN8I_CODEC_ANALOG) += sun8i-codec-analog.o obj-$(CONFIG_SND_SUN50I_CODEC_ANALOG) += sun50i-codec-analog.o obj-$(CONFIG_SND_SUN8I_CODEC) += sun8i-codec.o obj-$(CONFIG_SND_SUN8I_ADDA_PR_REGMAP) += sun8i-adda-pr-regmap.o +obj-$(CONFIG_SND_SUN50I_DMIC) += sun50i-dmic.o diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c new file mode 100644 index 0000000..cd3c07f --- /dev/null +++ b/sound/soc/sunxi/sun50i-dmic.c @@ -0,0 +1,406 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +// +// This driver supports the DMIC in Allwinner's H6 SoCs. +// +// Copyright 2021 Ban Tao <fengzheng923(a)gmail.com> + +#include <linux/clk.h> +#include <linux/device.h> +#include <linux/of_device.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> +#include <linux/reset.h> +#include <sound/dmaengine_pcm.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> + +#define SUN50I_DMIC_EN_CTL (0x00) + #define SUN50I_DMIC_EN_CTL_GLOBE BIT(8) + #define SUN50I_DMIC_EN_CTL_CHAN(v) ((v) << 0) + #define SUN50I_DMIC_EN_CTL_CHAN_MASK GENMASK(7, 0) +#define SUN50I_DMIC_SR (0x04) + #define SUN50I_DMIC_SR_SAMPLE_RATE(v) ((v) << 0) + #define SUN50I_DMIC_SR_SAMPLE_RATE_MASK GENMASK(2, 0) +#define SUN50I_DMIC_CTL (0x08) + #define SUN50I_DMIC_CTL_OVERSAMPLE_RATE BIT(0) +#define SUN50I_DMIC_DATA (0x10) +#define SUN50I_DMIC_INTC (0x14) + #define SUN50I_DMIC_FIFO_DRQ_EN BIT(2) +#define SUN50I_DMIC_INT_STA (0x18) + #define SUN50I_DMIC_INT_STA_OVERRUN_IRQ_PENDING BIT(1) + #define SUN50I_DMIC_INT_STA_DATA_IRQ_PENDING BIT(0) +#define SUN50I_DMIC_RXFIFO_CTL (0x1c) + #define SUN50I_DMIC_RXFIFO_CTL_FLUSH BIT(31) + #define SUN50I_DMIC_RXFIFO_CTL_MODE_MASK BIT(9) + #define SUN50I_DMIC_RXFIFO_CTL_MODE_LSB (0 << 9) + #define SUN50I_DMIC_RXFIFO_CTL_MODE_MSB (1 << 9) + #define SUN50I_DMIC_RXFIFO_CTL_SAMPLE_MASK BIT(8) + #define SUN50I_DMIC_RXFIFO_CTL_SAMPLE_16 (0 << 8) + #define SUN50I_DMIC_RXFIFO_CTL_SAMPLE_24 (1 << 8) +#define SUN50I_DMIC_CH_NUM (0x24) + #define SUN50I_DMIC_CH_NUM_N(v) ((v) << 0) + #define SUN50I_DMIC_CH_NUM_N_MASK GENMASK(2, 0) +#define SUN50I_DMIC_CNT (0x2c) + #define SUN50I_DMIC_CNT_N (1 << 0) +#define SUN50I_DMIC_HPF_CTRL (0x38) +#define SUN50I_DMIC_VERSION (0x50) + +struct sun50i_dmic_dev { + struct clk *dmic_clk; + struct clk *bus_clk; + struct reset_control *rst; + struct regmap *regmap; + struct snd_dmaengine_dai_dma_data dma_params_rx; +}; + +struct dmic_rate { + unsigned int samplerate; + unsigned int rate_bit; +}; + +const static struct dmic_rate dmic_rate_s[] = { + {48000, 0x0}, + {44100, 0x0}, + {32000, 0x1}, + {24000, 0x2}, + {22050, 0x2}, + {16000, 0x3}, + {12000, 0x4}, + {11025, 0x4}, + {8000, 0x5}, +}; + +static int sun50i_dmic_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *cpu_dai) +{ + struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(asoc_rtd_to_cpu(rtd, 0)); + + /* only support capture */ + if (substream->stream != SNDRV_PCM_STREAM_CAPTURE) + return -EINVAL; + + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_FLUSH, + SUN50I_DMIC_RXFIFO_CTL_FLUSH); + regmap_write(host->regmap, SUN50I_DMIC_CNT, SUN50I_DMIC_CNT_N); + + return 0; +} + +static int sun50i_dmic_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct snd_soc_dai *cpu_dai) +{ + int i = 0; + unsigned long rate = params_rate(params); + unsigned int mclk = 0; + unsigned int channels = params_channels(params); + unsigned int chan_en = (1 << channels) - 1; + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(cpu_dai); + + /* DMIC num is N+1 */ + regmap_update_bits(host->regmap, SUN50I_DMIC_CH_NUM, + SUN50I_DMIC_CH_NUM_N_MASK, + SUN50I_DMIC_CH_NUM_N(channels - 1)); + regmap_write(host->regmap, SUN50I_DMIC_HPF_CTRL, chan_en); + regmap_update_bits(host->regmap, SUN50I_DMIC_EN_CTL, + SUN50I_DMIC_EN_CTL_CHAN_MASK, + SUN50I_DMIC_EN_CTL_CHAN(chan_en)); + + switch (params_format(params)) { + case SNDRV_PCM_FORMAT_S16_LE: + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_MASK, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_16); + break; + case SNDRV_PCM_FORMAT_S24_LE: + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_MASK, + SUN50I_DMIC_RXFIFO_CTL_SAMPLE_24); + break; + default: + dev_err(cpu_dai->dev, "Invalid format!\n"); + return -EINVAL; + } + /* The hardware supports FIFO mode 1 for 24-bit samples */ + regmap_update_bits(host->regmap, SUN50I_DMIC_RXFIFO_CTL, + SUN50I_DMIC_RXFIFO_CTL_MODE_MASK, + SUN50I_DMIC_RXFIFO_CTL_MODE_MSB); + + switch (rate) { + case 11025: + case 22050: + case 44100: + mclk = 22579200; + break; + case 8000: + case 12000: + case 16000: + case 24000: + case 32000: + case 48000: + mclk = 24576000; + break; + default: + dev_err(cpu_dai->dev, "Invalid rate!\n"); + return -EINVAL; + } + + if (clk_set_rate(host->dmic_clk, mclk)) { + dev_err(cpu_dai->dev, "mclk : %u not support\n", mclk); + return -EINVAL; + } + + for (i = 0; i < ARRAY_SIZE(dmic_rate_s); i++) { + if (dmic_rate_s[i].samplerate == rate) { + regmap_update_bits(host->regmap, SUN50I_DMIC_SR, + SUN50I_DMIC_SR_SAMPLE_RATE_MASK, + SUN50I_DMIC_SR_SAMPLE_RATE(dmic_rate_s[i].rate_bit)); + break; + } + } + + switch (params_physical_width(params)) { + case 16: + host->dma_params_rx.addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; + break; + case 32: + host->dma_params_rx.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; + break; + default: + dev_err(cpu_dai->dev, "Unsupported physical sample width: %d\n", + params_physical_width(params)); + return -EINVAL; + } + + /* oversamplerate adjust */ + if (params_rate(params) >= 24000) + regmap_update_bits(host->regmap, SUN50I_DMIC_CTL, + SUN50I_DMIC_CTL_OVERSAMPLE_RATE, + SUN50I_DMIC_CTL_OVERSAMPLE_RATE); + else + regmap_update_bits(host->regmap, SUN50I_DMIC_CTL, + SUN50I_DMIC_CTL_OVERSAMPLE_RATE, 0); + + return 0; +} + +static int sun50i_dmic_trigger(struct snd_pcm_substream *substream, int cmd, + struct snd_soc_dai *dai) +{ + int ret = 0; + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(dai); + + if (substream->stream != SNDRV_PCM_STREAM_CAPTURE) + return -EINVAL; + + switch (cmd) { + case SNDRV_PCM_TRIGGER_START: + case SNDRV_PCM_TRIGGER_RESUME: + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: + /* DRQ ENABLE */ + regmap_update_bits(host->regmap, SUN50I_DMIC_INTC, + SUN50I_DMIC_FIFO_DRQ_EN, + SUN50I_DMIC_FIFO_DRQ_EN); + /* Global enable */ + regmap_update_bits(host->regmap, SUN50I_DMIC_EN_CTL, + SUN50I_DMIC_EN_CTL_GLOBE, + SUN50I_DMIC_EN_CTL_GLOBE); + break; + case SNDRV_PCM_TRIGGER_STOP: + case SNDRV_PCM_TRIGGER_SUSPEND: + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: + /* DRQ DISABLE */ + regmap_update_bits(host->regmap, SUN50I_DMIC_INTC, + SUN50I_DMIC_FIFO_DRQ_EN, 0); + /* Global disable */ + regmap_update_bits(host->regmap, SUN50I_DMIC_EN_CTL, + SUN50I_DMIC_EN_CTL_GLOBE, 0); + break; + default: + ret = -EINVAL; + break; + } + return ret; +} + +static int sun50i_dmic_soc_dai_probe(struct snd_soc_dai *dai) +{ + struct sun50i_dmic_dev *host = snd_soc_dai_get_drvdata(dai); + + snd_soc_dai_init_dma_data(dai, NULL, &host->dma_params_rx); + + return 0; +} + +static const struct snd_soc_dai_ops sun50i_dmic_dai_ops = { + .startup = sun50i_dmic_startup, + .trigger = sun50i_dmic_trigger, + .hw_params = sun50i_dmic_hw_params, +}; + +static const struct regmap_config sun50i_dmic_regmap_config = { + .reg_bits = 32, + .reg_stride = 4, + .val_bits = 32, + .max_register = SUN50I_DMIC_VERSION, + .cache_type = REGCACHE_NONE, +}; + +#define SUN50I_DMIC_RATES (SNDRV_PCM_RATE_8000_48000) +#define SUN50I_DMIC_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE) + +static struct snd_soc_dai_driver sun50i_dmic_dai = { + .capture = { + .channels_min = 1, + .channels_max = 8, + .rates = SUN50I_DMIC_RATES, + .formats = SUN50I_DMIC_FORMATS, + .sig_bits = 21, + }, + .probe = sun50i_dmic_soc_dai_probe, + .ops = &sun50i_dmic_dai_ops, + .name = "dmic", +}; + +static const struct of_device_id sun50i_dmic_of_match[] = { + { + .compatible = "allwinner,sun50i-h6-dmic", + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, sun50i_dmic_of_match); + +static const struct snd_soc_component_driver sun50i_dmic_component = { + .name = "sun50i-dmic", +}; + +static int sun50i_dmic_runtime_suspend(struct device *dev) +{ + struct sun50i_dmic_dev *host = dev_get_drvdata(dev); + + clk_disable_unprepare(host->dmic_clk); + clk_disable_unprepare(host->bus_clk); + + return 0; +} + +static int sun50i_dmic_runtime_resume(struct device *dev) +{ + struct sun50i_dmic_dev *host = dev_get_drvdata(dev); + int ret; + + ret = clk_prepare_enable(host->dmic_clk); + if (ret) + return ret; + + ret = clk_prepare_enable(host->bus_clk); + if (ret) { + clk_disable_unprepare(host->dmic_clk); + return ret; + } + + return 0; +} + +static int sun50i_dmic_probe(struct platform_device *pdev) +{ + struct sun50i_dmic_dev *host; + struct resource *res; + int ret; + void __iomem *base; + + host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); + if (!host) + return -ENOMEM; + + /* Get the addresses */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(base)) + return dev_err_probe(&pdev->dev, PTR_ERR(base), + "get resource failed.\n"); + + host->regmap = devm_regmap_init_mmio(&pdev->dev, base, + &sun50i_dmic_regmap_config); + + /* Clocks */ + host->bus_clk = devm_clk_get(&pdev->dev, "bus"); + if (IS_ERR(host->bus_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->bus_clk), + "failed to get bus clock.\n"); + + host->dmic_clk = devm_clk_get(&pdev->dev, "mod"); + if (IS_ERR(host->dmic_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->dmic_clk), + "failed to get dmic clock.\n"); + + host->dma_params_rx.addr = res->start + SUN50I_DMIC_DATA; + host->dma_params_rx.maxburst = 8; + + platform_set_drvdata(pdev, host); + + host->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); + if (IS_ERR(host->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->rst), + "Failed to get reset.\n"); + reset_control_deassert(host->rst); + + ret = devm_snd_soc_register_component(&pdev->dev, &sun50i_dmic_component, + &sun50i_dmic_dai, 1); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "failed to register component.\n"); + + pm_runtime_enable(&pdev->dev); + if (!pm_runtime_enabled(&pdev->dev)) { + ret = sun50i_dmic_runtime_resume(&pdev->dev); + if (ret) + goto err_disable_runtime_pm; + } + + ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); + if (ret) + goto err_suspend; + + return 0; +err_suspend: + if (!pm_runtime_status_suspended(&pdev->dev)) + sun50i_dmic_runtime_suspend(&pdev->dev); +err_disable_runtime_pm: + pm_runtime_disable(&pdev->dev); + return ret; +} + +static int sun50i_dmic_remove(struct platform_device *pdev) +{ + pm_runtime_disable(&pdev->dev); + if (!pm_runtime_status_suspended(&pdev->dev)) + sun50i_dmic_runtime_suspend(&pdev->dev); + + return 0; +} + +static const struct dev_pm_ops sun50i_dmic_pm = { + SET_RUNTIME_PM_OPS(sun50i_dmic_runtime_suspend, + sun50i_dmic_runtime_resume, NULL) +}; + +static struct platform_driver sun50i_dmic_driver = { + .driver = { + .name = "sun50i-dmic", + .of_match_table = of_match_ptr(sun50i_dmic_of_match), + .pm = &sun50i_dmic_pm, + }, + .probe = sun50i_dmic_probe, + .remove = sun50i_dmic_remove, +}; + +module_platform_driver(sun50i_dmic_driver); + +MODULE_DESCRIPTION("Allwinner sun50i DMIC SoC Interface"); +MODULE_AUTHOR("Ban Tao <fengzheng923(a)gmail.com>"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:sun50i-dmic"); -- 2.7.4

2 1

[linux-next:master] BUILD REGRESSION 47c191411b68a771261be3dc0bd6f68394cef358
by kernel test robot 09 Sep '22

09 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 47c191411b68a771261be3dc0bd6f68394cef358 Add linux-next specific files for 20220908 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.FQi69rLV-lkp@intel.com https://lore.kernel.org/linux-mm/202209080718.y5QmlNKH-lkp@intel.com https://lore.kernel.org/llvm/202209090343.JPAFJt74-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) ERROR: modpost: "__divdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! ERROR: modpost: "__udivdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! arm-linux-gnueabi-ld: vkms_formats.c:(.text+0x824): undefined reference to `__aeabi_ldivmod' drivers/base/regmap/regmap-mmio.c:222:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:225:17: error: implicit declaration of function 'writesw'; did you mean 'writew'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:228:17: error: implicit declaration of function 'writesl'; did you mean 'writel'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:232:17: error: implicit declaration of function 'writesq'; did you mean 'writeq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:232:17: error: implicit declaration of function 'writesq'; did you mean 'writesl'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:358:17: error: implicit declaration of function 'readsb'; did you mean 'readb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:361:17: error: implicit declaration of function 'readsw'; did you mean 'readw'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:364:17: error: implicit declaration of function 'readsl'; did you mean 'readl'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readsl'? [-Werror=implicit-function-declaration] drivers/crypto/aspeed/aspeed-hace.c:133 aspeed_hace_probe() warn: platform_get_irq() does not return zero drivers/gpu/drm/amd/amdgpu/imu_v11_0_3.c:139:6: warning: no previous prototype for 'imu_v11_0_3_program_rlc_ram' [-Wmissing-prototypes] drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encoder_state() instead drivers/gpu/drm/vkms/vkms_formats.c:259: undefined reference to `__divdi3' drivers/pinctrl/pinctrl-amd.c:288 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x9a' drivers/pinctrl/pinctrl-amd.c:288 amd_gpio_dbg_show() warn: format string contains non-ascii character '\xa1' drivers/pinctrl/pinctrl-amd.c:370 amd_gpio_dbg_show() warn: format string contains non-ascii character '\x95' drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration] drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration] fs/btrfs/volumes.c:6549 __btrfs_map_block() error: we previously assumed 'mirror_num_ret' could be null (see line 6376) ld: drivers/gpu/drm/vkms/vkms_formats.c:260: undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x362): undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x3b2): undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x3ba): undefined reference to `__divdi3' ld: vkms_formats.c:(.text+0x47f): undefined reference to `__divdi3' mips-linux-ld: vkms_formats.c:(.text.argb_u16_to_RGB565+0xd0): undefined reference to `__divdi3' mm/kasan/kasan_test_module.c:90:26: sparse: struct kasan_rcu_info * mm/kasan/kasan_test_module.c:90:26: sparse: struct kasan_rcu_info [noderef] __rcu * sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] vkms_formats.c:(.text+0x266): undefined reference to `__divdi3' vkms_formats.c:(.text+0x338): undefined reference to `__divdi3' vkms_formats.c:(.text+0x388): undefined reference to `__divdi3' vkms_formats.c:(.text+0x390): undefined reference to `__divdi3' vkms_formats.c:(.text+0x455): undefined reference to `__divdi3' vkms_formats.c:(.text+0x804): undefined reference to `__aeabi_ldivmod' vkms_formats.c:(.text.argb_u16_to_RGB565+0xb0): undefined reference to `__divdi3' Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_get_by_name | |-- drivers-scsi-qla2xxx-qla_os.c:error:implicit-declaration-of-function-trace_array_put | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- alpha-randconfig-r013-20220907 | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw |-- alpha-randconfig-r034-20220907 | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw |-- arc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-randconfig-r003-20220907 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arc-randconfig-r026-20220907 | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-randconfig-s033-20220907 | |-- kernel-bpf-hashtab.c:sparse:sparse:cast-removes-address-space-__percpu-of-expression | |-- kernel-bpf-hashtab.c:sparse:sparse:incorrect-type-in-assignment-(different-address-spaces)-expected-void-noderef-__percpu-assigned-pptr-got-void | |-- kernel-bpf-hashtab.c:sparse:sparse:incorrect-type-in-assignment-(different-address-spaces)-expected-void-ptr_to_pptr-got-void-noderef-__percpu-assigned-pptr | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__percpu-__pdata-got-void | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-argument-(different-address-spaces)-expected-void-noderef-__percpu-__pdata-got-void-pptr | |-- kernel-bpf-memalloc.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-void-pptr-got-void-noderef-__percpu | `-- kernel-exit.c:sparse:sparse:incorrect-type-in-initializer-(different-address-spaces)-expected-struct-sighand_struct-sighand-got-struct-sighand_struct-noderef-__rcu-sighand clang_recent_errors |-- i386-randconfig-a002 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- i386-randconfig-a006 | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- i386-randconfig-a013 | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- i386-randconfig-a015 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- powerpc-randconfig-r021-20220907 | |-- arch-powerpc-math-emu-fre.c:warning:no-previous-prototype-for-function-fre | |-- arch-powerpc-math-emu-frsqrtes.c:warning:no-previous-prototype-for-function-frsqrtes | |-- arch-powerpc-math-emu-fsqrt.c:warning:no-previous-prototype-for-function-fsqrt | |-- arch-powerpc-math-emu-fsqrts.c:warning:no-previous-prototype-for-function-fsqrts | |-- arch-powerpc-math-emu-mtfsf.c:warning:no-previous-prototype-for-function-mtfsf | `-- arch-powerpc-math-emu-mtfsfi.c:warning:no-previous-prototype-for-function-mtfsfi |-- x86_64-randconfig-a003 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead |-- x86_64-randconfig-a012 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead `-- x86_64-randconfig-a016 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 734m configs tested: 75 configs skipped: 4 gcc tested configs: um i386_defconfig um x86_64_defconfig m68k allmodconfig x86_64 randconfig-a011 powerpc allnoconfig arc allyesconfig powerpc allmodconfig alpha allyesconfig mips allyesconfig m68k allyesconfig x86_64 randconfig-a015 i386 randconfig-a014 sh allmodconfig x86_64 randconfig-a002 x86_64 defconfig x86_64 randconfig-a013 i386 defconfig i386 randconfig-a001 x86_64 rhel-8.3-func i386 randconfig-a003 x86_64 randconfig-a006 arc randconfig-r043-20220908 x86_64 randconfig-a004 i386 randconfig-a005 arm defconfig i386 randconfig-a012 i386 randconfig-a016 x86_64 rhel-8.3-kunit x86_64 rhel-8.3-kvm arm allyesconfig x86_64 rhel-8.3-kselftests x86_64 rhel-8.3-syz x86_64 rhel-8.3 i386 allyesconfig arm64 allyesconfig arc randconfig-r043-20220907 i386 randconfig-c001 s390 randconfig-r044-20220908 riscv randconfig-r042-20220908 x86_64 allyesconfig ia64 allmodconfig csky allnoconfig arc allnoconfig alpha allnoconfig riscv allnoconfig m68k m5275evb_defconfig sh ap325rxa_defconfig arm cerfcube_defconfig powerpc wii_defconfig xtensa cadence_csp_defconfig arm mvebu_v7_defconfig clang tested configs: x86_64 randconfig-a012 i386 randconfig-a013 x86_64 randconfig-a014 x86_64 randconfig-a001 i386 randconfig-a002 x86_64 randconfig-a003 x86_64 randconfig-a016 i386 randconfig-a011 x86_64 randconfig-a005 hexagon randconfig-r041-20220907 i386 randconfig-a015 hexagon randconfig-r041-20220908 i386 randconfig-a006 i386 randconfig-a004 riscv randconfig-r042-20220907 hexagon randconfig-r045-20220908 hexagon randconfig-r045-20220907 s390 randconfig-r044-20220907 x86_64 rhel-8.3-rust powerpc icon_defconfig arm spear13xx_defconfig arm palmz72_defconfig powerpc mpc832x_rdb_defconfig x86_64 randconfig-k001 -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[PATCH v2] ASoC: fsl_asrc: Add initialization finishing check in runtime resume
by Shengjiu Wang 08 Sep '22

08 Sep '22

If the initialization is not finished, then filling input data to the FIFO may fail. So it is better to add initialization finishing check in the runtime resume for suspend & resume case. And consider the case of three instances working in parallel, increase the retry times to 50 for more initialization time. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- changes in v2: - update comments. sound/soc/fsl/fsl_asrc.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index aa5edf32d988..b394b762025d 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -20,6 +20,7 @@ #define IDEAL_RATIO_DECIMAL_DEPTH 26 #define DIVIDER_NUM 64 +#define INIT_TRY_NUM 50 #define pair_err(fmt, ...) \ dev_err(&asrc->pdev->dev, "Pair %c: " fmt, 'A' + index, ##__VA_ARGS__) @@ -579,7 +580,7 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair) { struct fsl_asrc *asrc = pair->asrc; enum asrc_pair_index index = pair->index; - int reg, retry = 10, i; + int reg, retry = INIT_TRY_NUM, i; /* Enable the current pair */ regmap_update_bits(asrc->regmap, REG_ASRCTR, @@ -592,6 +593,10 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair) reg &= ASRCFG_INIRQi_MASK(index); } while (!reg && --retry); + /* NOTE: Doesn't treat initialization timeout as error */ + if (!retry) + dev_warn(&asrc->pdev->dev, "initialization isn't finished\n"); + /* Make the input fifo to ASRC STALL level */ regmap_read(asrc->regmap, REG_ASRCNCR, &reg); for (i = 0; i < pair->channels * 4; i++) @@ -1257,6 +1262,7 @@ static int fsl_asrc_runtime_resume(struct device *dev) { struct fsl_asrc *asrc = dev_get_drvdata(dev); struct fsl_asrc_priv *asrc_priv = asrc->private; + int reg, retry = INIT_TRY_NUM; int i, ret; u32 asrctr; @@ -1295,6 +1301,20 @@ static int fsl_asrc_runtime_resume(struct device *dev) regmap_update_bits(asrc->regmap, REG_ASRCTR, ASRCTR_ASRCEi_ALL_MASK, asrctr); + /* Wait for status of initialization for every enabled pairs */ + do { + udelay(5); + regmap_read(asrc->regmap, REG_ASRCFG, &reg); + reg = (reg >> ASRCFG_INIRQi_SHIFT(0)) & 0x7; + } while ((reg != ((asrctr >> ASRCTR_ASRCEi_SHIFT(0)) & 0x7)) && --retry); + + /* + * NOTE: Doesn't treat initialization timeout as error + * Some of pair maybe success, then still can continue. + */ + if (!retry) + dev_warn(dev, "initialization isn't finished\n"); + return 0; disable_asrck_clk: -- 2.34.1

2 1

Re: [PATCH 09/12] ASoC: cs42l42: Split I2C identity into separate module
by Martin Povišer 08 Sep '22

08 Sep '22

> On 19. 8. 2022, at 14:52, Richard Fitzgerald <rf(a)opensource.cirrus.com> wrote: > > Split the I2C bus driver definition and probe()/remove() into a > separate module so that a Soundwire build of CS42L42 support does > not have a spurious dependency on I2C. > > Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> > --- > +static int cs42l42_i2c_probe(struct i2c_client *i2c_client) > +{ > + struct device *dev = &i2c_client->dev; > + struct cs42l42_private *cs42l42; > + struct regmap *regmap; > + int ret; > + > + cs42l42 = devm_kzalloc(dev, sizeof(*cs42l42), GFP_KERNEL); > + if (!cs42l42) > + return -ENOMEM; > + > + regmap = devm_regmap_init_i2c(i2c_client, &cs42l42_regmap); > + if (IS_ERR(regmap)) { > + ret = PTR_ERR(regmap); > + dev_err(&i2c_client->dev, "regmap_init() failed: %d\n", ret); > + return ret; > + } > + > + cs42l42->dev = dev; > + cs42l42->regmap = regmap; > + cs42l42->irq = i2c_client->irq; > + > + ret = cs42l42_common_probe(cs42l42, &cs42l42_soc_component, &cs42l42_dai); > + if (ret) > + return ret; > + > + return cs42l42_init(cs42l42); The common_remove should probably be called here if the init fails. Best, Martin > +} > + > +static int cs42l42_i2c_remove(struct i2c_client *i2c_client) > +{ > + struct cs42l42_private *cs42l42 = dev_get_drvdata(&i2c_client->dev); > + > + cs42l42_common_remove(cs42l42); > + > + return 0; > +}

1 0

[PATCH v3 0/4] ASoC: qcom: add support for sc8280xp machine
by Srinivas Kandagatla 08 Sep '22

08 Sep '22

This patchset adds support for SC8280XP SoC machine driver. First patch moves some of the commonly used code to common from sm8250 machine driver and the follow on code adds minimal support for sc8280xp. Currently this driver is only tested with SmartSpeakers and Headset on Lenovo Thinkpad X13s. Support for sm8450 is tested and I will post the patches soon. Thanks, Srini Changes since v2: - put SoundWire specific symbols under IS_ENABLED check as not all Qcom plaforms need SoundWire that use common.c Srinivas Kandagatla (4): ASoC: qcom: common: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL ASoC: dt-bindings: qcom,sm8250: add compatibles for sm8450 and sm8250 ASoC: qcom: sm8250: move some code to common ASoC: qcom: add machine driver for sc8280xp .../bindings/sound/qcom,sm8250.yaml | 2 + sound/soc/qcom/Kconfig | 11 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/common.c | 173 +++++++++++++++++- sound/soc/qcom/common.h | 35 ++++ sound/soc/qcom/sc8280xp.c | 157 ++++++++++++++++ sound/soc/qcom/sm8250.c | 152 +-------------- 7 files changed, 386 insertions(+), 146 deletions(-) create mode 100644 sound/soc/qcom/sc8280xp.c -- 2.21.0

2 9

[PATCH v2 0/4] ASoC: qcom: add support for sc8280xp machine
by Srinivas Kandagatla 08 Sep '22

08 Sep '22

This patchset adds support for SC8280XP SoC machine driver. First patch moves some of the commonly used code to common from sm8250 machine driver and the follow on code adds minimal support for sc8280xp. Currently this driver is only tested with SmartSpeakers and Headset on Lenovo Thinkpad X13s. Support for sm8450 is tested and I will post the patches soon. Thanks, Srini Changes since v1: - make all the exported symbol as EXPORT_SYMBOL_GPL Srinivas Kandagatla (4): ASoC: qcom: common: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL ASoC: dt-bindings: qcom,sm8250: add compatibles for sm8450 and sm8250 ASoC: qcom: sm8250: move some code to common ASoC: qcom: add machine driver for sc8280xp .../bindings/sound/qcom,sm8250.yaml | 2 + sound/soc/qcom/Kconfig | 11 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/common.c | 171 +++++++++++++++++- sound/soc/qcom/common.h | 12 ++ sound/soc/qcom/sc8280xp.c | 157 ++++++++++++++++ sound/soc/qcom/sm8250.c | 152 +--------------- 7 files changed, 361 insertions(+), 146 deletions(-) create mode 100644 sound/soc/qcom/sc8280xp.c -- 2.21.0

2 7

About ALSA dummy module: support customized mixer volume leveling
by YJ Lee 08 Sep '22

08 Sep '22

Hello Takashi (and the alsa community), This is YJ Lee from chromium.org. I'm thinking about extending the ALSA dummy module to support customized volume leveling. It will be very useful to test devices with different volume granularity. Currently this module is using hard-coded mixer volume leveling, from min=-50 to max=100. See L716: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/… My plan (A) is to expose 2 more additional module parameters and replace a few occurrences, from L742-750. Another plan (B) is to leverage the current existing module parameter:model, and make the dummy-module to be able to accept models with customized volume leveling. New dummy models can be provided as configuration files, and be used in the same way as how currently existing dummy models (L146-213) are used. However, it's a bit over-engineering from the original purpose. What do you think about these plans? Any insight you (and the alsa community) can provide will be greatly appreciated. Best, YJ

2 4

[PATCH 0/2] ASoC: soc-dapm.c: random cleanup retry
by Kuninori Morimoto 08 Sep '22

08 Sep '22

Hi Mark These are remains of my previous cleanup patch-set. [1/2] adds comment why kzalloc()/kfree() are needed on snd_soc_dai_link_event_pre_pmu(). [2/2] is adjusted to [1/1] patch. Link: https://lore.kernel.org/all/8735d59zt9.wl-kuninori.morimoto.gx@renesas.com/ Kuninori Morimoto (2): ASoC: soc-dapm.c: add comment for kzalloc()/kfree() on snd_soc_dai_link_event_pre_pmu() ASoC: soc-dapm.c: tidyup snd_soc_dai_link_event_pre_pmu() sound/soc/soc-dapm.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) -- 2.25.1

2 3

[PATCH] ASoC: ak4458: Remove component probe() and remove()
by Shengjiu Wang 08 Sep '22

08 Sep '22

Most function in ak4458_probe() and ak4458_remove() are duplicate with dai ops, so remove them and move dsd_path setting to dai ops. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/codecs/ak4458.c | 53 ++++++--------------------------------- 1 file changed, 7 insertions(+), 46 deletions(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index ea33cc83c86c..b534212096ee 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -447,6 +447,13 @@ static int ak4458_hw_params(struct snd_pcm_substream *substream, snd_soc_component_update_bits(component, AK4458_0B_CONTROL7, AK4458_DCHAIN_MASK, dchn); + if (ak4458->drvdata->type == AK4497) { + ret = snd_soc_component_update_bits(component, AK4458_09_DSD2, + 0x4, (ak4458->dsd_path << 2)); + if (ret < 0) + return ret; + } + ret = ak4458_rstn_control(component, 0); if (ret) return ret; @@ -629,48 +636,6 @@ static void ak4458_reset(struct ak4458_priv *ak4458, bool active) } } -static int ak4458_init(struct snd_soc_component *component) -{ - struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component); - int ret; - - /* External Mute ON */ - if (ak4458->mute_gpiod) - gpiod_set_value_cansleep(ak4458->mute_gpiod, 1); - - ak4458_reset(ak4458, false); - - ret = snd_soc_component_update_bits(component, AK4458_00_CONTROL1, - 0x80, 0x80); /* ACKS bit = 1; 10000000 */ - if (ret < 0) - return ret; - - if (ak4458->drvdata->type == AK4497) { - ret = snd_soc_component_update_bits(component, AK4458_09_DSD2, - 0x4, (ak4458->dsd_path << 2)); - if (ret < 0) - return ret; - } - - return ak4458_rstn_control(component, 1); -} - -static int ak4458_probe(struct snd_soc_component *component) -{ - struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component); - - ak4458->fs = 48000; - - return ak4458_init(component); -} - -static void ak4458_remove(struct snd_soc_component *component) -{ - struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component); - - ak4458_reset(ak4458, true); -} - #ifdef CONFIG_PM static int __maybe_unused ak4458_runtime_suspend(struct device *dev) { @@ -714,8 +679,6 @@ static int __maybe_unused ak4458_runtime_resume(struct device *dev) #endif /* CONFIG_PM */ static const struct snd_soc_component_driver soc_codec_dev_ak4458 = { - .probe = ak4458_probe, - .remove = ak4458_remove, .controls = ak4458_snd_controls, .num_controls = ARRAY_SIZE(ak4458_snd_controls), .dapm_widgets = ak4458_dapm_widgets, @@ -728,8 +691,6 @@ static const struct snd_soc_component_driver soc_codec_dev_ak4458 = { }; static const struct snd_soc_component_driver soc_codec_dev_ak4497 = { - .probe = ak4458_probe, - .remove = ak4458_remove, .controls = ak4497_snd_controls, .num_controls = ARRAY_SIZE(ak4497_snd_controls), .dapm_widgets = ak4497_dapm_widgets, -- 2.34.1

3 2

[v2] ASoC: max98390: Remove unnecessary amp on/off conrtol
by Steve Lee 08 Sep '22

08 Sep '22

The Amp is already control in userspace before trigger calibrate function. Remove unnecessary control in calibrate function and add condition to check calibration is ready. Signed-off-by: Steve Lee <steve.lee.analog(a)gmail.com> --- sound/soc/codecs/max98390.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index 91c0bf3d76fc..4b2ee70c29d7 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -635,10 +635,19 @@ static int max98390_dsm_calib_get(struct snd_kcontrol *kcontrol, static int max98390_dsm_calib_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { + unsigned int val; struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); + struct max98390_priv *max98390 = + snd_soc_component_get_drvdata(component); - max98390_dsm_calibrate(component); + regmap_read(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, &val); + if (val == 0x1) + max98390_dsm_calibrate(component); + else { + dev_err(component->dev, "AMP is not ready to run calibration\n"); + return -ECANCELED; + } return 0; } @@ -826,9 +835,6 @@ static int max98390_dsm_calibrate(struct snd_soc_component *component) struct max98390_priv *max98390 = snd_soc_component_get_drvdata(component); - regmap_write(max98390->regmap, MAX98390_R203A_AMP_EN, 0x81); - regmap_write(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, 0x01); - regmap_read(max98390->regmap, THERMAL_RDC_RD_BACK_BYTE1, &rdc); regmap_read(max98390->regmap, @@ -847,9 +853,6 @@ static int max98390_dsm_calibrate(struct snd_soc_component *component) dev_info(component->dev, "rdc resistance about %d.%02d ohm, reg=0x%X temp reg=0x%X\n", rdc_integer, rdc_factor, rdc_cal_result, temp); - regmap_write(max98390->regmap, MAX98390_R23FF_GLOBAL_EN, 0x00); - regmap_write(max98390->regmap, MAX98390_R203A_AMP_EN, 0x80); - return 0; } -- 2.17.1

2 1

[PATCH linux-next] ASoC: sti-sas: Remove the unneeded result variable
by cgel.zte＠gmail.com 08 Sep '22

08 Sep '22

From: ye xingchen <ye.xingchen(a)zte.com.cn> Return the value regmap_write() and sti_sas_init_sas_registers() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: ye xingchen <ye.xingchen(a)zte.com.cn> --- sound/soc/codecs/sti-sas.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/sti-sas.c b/sound/soc/codecs/sti-sas.c index f076878908ee..99545bcb2ba9 100644 --- a/sound/soc/codecs/sti-sas.c +++ b/sound/soc/codecs/sti-sas.c @@ -96,11 +96,8 @@ static int sti_sas_write_reg(void *context, unsigned int reg, unsigned int value) { struct sti_sas_data *drvdata = context; - int status; - - status = regmap_write(drvdata->dac.regmap, reg, value); - return status; + return regmap_write(drvdata->dac.regmap, reg, value); } static int sti_sas_init_sas_registers(struct snd_soc_component *component, @@ -385,11 +382,8 @@ static int sti_sas_resume(struct snd_soc_component *component) static int sti_sas_component_probe(struct snd_soc_component *component) { struct sti_sas_data *drvdata = dev_get_drvdata(component->dev); - int ret; - ret = sti_sas_init_sas_registers(component, drvdata); - - return ret; + return sti_sas_init_sas_registers(component, drvdata); } static struct snd_soc_component_driver sti_sas_driver = { -- 2.25.1

2 1

[GIT PULL] ASoC fixes for v6.0-rc4
by Mark Brown 08 Sep '22

08 Sep '22

The following changes since commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868: Linux 6.0-rc1 (2022-08-14 15:50:18 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.0-rc4 for you to fetch changes up to b1cd3fd42db7593a2d24c06f1c53b8c886592080: ASoC: fsl_aud2htx: Add error handler for pm_runtime_enable (2022-08-25 14:17:31 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.0 Quite a few fixes here, all driver specific and fairly small. ---------------------------------------------------------------- Bard Liao (1): ASoC: SOF: ipc4-topology: fix alh_group_ida max value Jiaxin Yu (1): ASoC: mediatek: mt8186: fix DMIC record noise Mark Brown (3): Merge remote-tracking branch 'asoc/for-5.20' into asoc-6.0 ASoC: SOF: Kconfig: Fix the dependency for client modules ASoC: nau8xxx: Implement hw constraint for rates Nathan Chancellor (1): ASoC: mchp-spdiftx: Fix clang -Wbitfield-constant-conversion Peter Ujfalusi (2): ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF ASoC: SOF: Kconfig: Make IPC_MESSAGE_INJECTOR depend on SND_SOC_SOF Pieterjan Camerlynck (1): ASoC: fsl_sai: fix incorrect mclk number in error message Richard Fitzgerald (1): ASoC: cs42l42: Only report button state if there was a button interrupt Shengjiu Wang (3): ASoC: fsl_mqs: Fix supported clock DAI format ASoC: fsl_aud2htx: register platform component before registering cpu dai ASoC: fsl_aud2htx: Add error handler for pm_runtime_enable Srinivas Kandagatla (1): ASoC: qcom: sm8250: add missing module owner Takashi Iwai (5): ASoC: nau8821: Implement hw constraint for rates ASoC: nau8824: Fix semaphore unbalance at error paths ASoC: nau8824: Implement hw constraint for rates ASoC: nau8825: Implement hw constraint for rates ASoC: nau8540: Implement hw constraint for rates Yang Yingliang (1): ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src() sound/soc/amd/yc/acp6x-mach.c | 28 +++++++++ sound/soc/atmel/mchp-spdiftx.c | 2 +- sound/soc/codecs/cs42l42.c | 13 ++-- sound/soc/codecs/nau8540.c | 40 ++++++++---- sound/soc/codecs/nau8821.c | 66 ++++++++++--------- sound/soc/codecs/nau8824.c | 80 +++++++++++++---------- sound/soc/codecs/nau8825.c | 83 +++++++++++++----------- sound/soc/codecs/rt5640.c | 5 +- sound/soc/codecs/tas2770.c | 98 +++++++++++++---------------- sound/soc/codecs/tas2770.h | 5 ++ sound/soc/codecs/tlv320aic32x4.c | 9 +++ sound/soc/fsl/fsl_aud2htx.c | 16 +++-- sound/soc/fsl/fsl_mqs.c | 2 +- sound/soc/fsl/fsl_sai.c | 2 +- sound/soc/intel/avs/pcm.c | 4 +- sound/soc/intel/boards/sof_es8336.c | 4 +- sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 3 - sound/soc/qcom/sm8250.c | 1 + sound/soc/sh/rz-ssi.c | 26 ++++---- sound/soc/soc-pcm.c | 3 + sound/soc/sof/Kconfig | 2 + sound/soc/sof/debug.c | 6 +- sound/soc/sof/intel/hda.c | 2 +- sound/soc/sof/ipc3-topology.c | 2 +- sound/soc/sof/ipc4-topology.c | 4 +- 25 files changed, 299 insertions(+), 207 deletions(-)

2 1

Alsaloop long-running session leads to CPU spikes and stalls
by GitHub issues - opened 08 Sep '22

08 Sep '22

alsa-project/alsa-utils issue #168 was opened from ebrodlic: We have a recurring issue on an embedded system where we use alsaloop to continually forward audio between: EC25E modem -> system speaker (output) system microphone (input) -> EC25E modem The two alsaloop processes run constantly in the background, and are in charge of enabling the GSM call audio functionality on our devices. What ends up happening is: - System boots up and starts the 2 processes - System usage is normal levels for 2-3 hours (very low CPU utilization) - After cca 3 hours of runtime, one alsaloop process will spike a single core of the CPU up to 100% continually - After a seemingly random amount of time of the single CPU core being fully utilized, the system may show reduced responsiveness, eventually showing recurring kernel warnings regarding CPU stalls ``` [Tue Aug 30 16:50:42 2022] rcu: INFO: rcu_preempt self-detected stall on CPU [Tue Aug 30 16:50:42 2022] rcu: 3-....: (5048 ticks this GP) idle=752/1/0x4000000000000002 softirq=1819133/1819133 fqs=2493 [Tue Aug 30 16:50:42 2022] (t=5250 jiffies g=3235733 q=26917) [Tue Aug 30 16:50:42 2022] Task dump for CPU 3: [Tue Aug 30 16:50:42 2022] alsaloop R running task 0 761 1 0x00000202 [Tue Aug 30 16:50:42 2022] Call trace: [Tue Aug 30 16:50:42 2022] dump_backtrace+0x0/0x140 [Tue Aug 30 16:50:42 2022] show_stack+0x14/0x20 [Tue Aug 30 16:50:42 2022] sched_show_task+0x110/0x138 [Tue Aug 30 16:50:42 2022] dump_cpu_task+0x40/0x4c [Tue Aug 30 16:50:42 2022] rcu_dump_cpu_stacks+0x94/0xd0 [Tue Aug 30 16:50:42 2022] rcu_sched_clock_irq+0x75c/0x9c8 [Tue Aug 30 16:50:42 2022] update_process_times+0x2c/0x68 [Tue Aug 30 16:50:42 2022] tick_sched_handle.isra.0+0x30/0x50 [Tue Aug 30 16:50:42 2022] tick_sched_timer+0x48/0x98 [Tue Aug 30 16:50:42 2022] __hrtimer_run_queues+0x110/0x1b0 [Tue Aug 30 16:50:42 2022] hrtimer_interrupt+0xe4/0x240 [Tue Aug 30 16:50:42 2022] arch_timer_handler_phys+0x30/0x40 [Tue Aug 30 16:50:42 2022] handle_percpu_devid_irq+0x80/0x140 [Tue Aug 30 16:50:42 2022] generic_handle_irq+0x24/0x38 [Tue Aug 30 16:50:42 2022] __handle_domain_irq+0x60/0xb8 [Tue Aug 30 16:50:42 2022] gic_handle_irq+0x5c/0x148 [Tue Aug 30 16:50:42 2022] el1_irq+0xb8/0x180 [Tue Aug 30 16:50:42 2022] snd_power_wait+0x0/0xe8 [Tue Aug 30 16:50:42 2022] snd_pcm_ioctl+0x2c/0x40 [Tue Aug 30 16:50:42 2022] do_vfs_ioctl+0x964/0xb48 [Tue Aug 30 16:50:42 2022] ksys_ioctl+0x78/0xa8 [Tue Aug 30 16:50:42 2022] __arm64_sys_ioctl+0x1c/0xb8 [Tue Aug 30 16:50:42 2022] el0_svc_common.constprop.0+0x68/0x160 [Tue Aug 30 16:50:42 2022] el0_svc_handler+0x20/0x80 [Tue Aug 30 16:50:42 2022] el0_svc+0x8/0x208 [Tue Aug 30 16:50:42 2022] retire_capture_urb: 307 callbacks suppressed ``` Commands used to start the two processes: `/usr/bin/alsaloop -P ec25 -C default -t 500000 -n -r 8000 -f S16_LE -c 1` `/usr/bin/alsaloop -C ec25 -P default -t 500000 -n -r 8000 -f S16_LE -c 1` Our current alsa .asoundrc conf file: ``` pcm.dmixer { type dmix ipc_key 1024 ipc_key_add_uid false # let multiple users share ipc_perm 0666 # IPC permissions for multi-user sharing (octal, default 0600) slave { pcm "hw:tas5722,0" } bindings { 0 0 1 1 } } pcm.dsnooped { type dsnoop ipc_key 1027 ipc_key_add_uid false # let multiple users share ipc_perm 0666 # IPC permissions for multi-user sharing (octal, default 0600) slave { pcm "hw:ics43432,0" channels 1 format S32_LE } } pcm.asymed { type asym playback.pcm "dmixer" capture.pcm "softvol" } pcm.!default { type plug slave.pcm "asymed" } pcm_slave.ec25 { pcm "hw:EC25E,0" format S16_LE channels 1 rate 8000 } pcm.ec25 { type plug slave ec25 } pcm.softvol { type softvol slave.pcm dsnooped control { name "Boost Capture Volume" card ics43432 } min_dB -3.0 max_dB 50.0 } ``` This one is not very easy to debug so it would be great if I could get some pointers in are we dealing with: - potential bugs - alsaloop misuse in approach - problems in existing configuration Any info would be appreciated! Issue URL : https://github.com/alsa-project/alsa-utils/issues/168 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

ucm2: Add support for MT8195 Cherry Tomato Chromebook with SOF
by GitHub pull_request - edited 08 Sep '22

08 Sep '22

alsa-project/alsa-ucm-conf pull request #213 was edited from kholk: Add support for the Acer Chromebook Spin 513 CP513-2H, powered by MediaTek Kompanio 1380 (MT8195) with a HiFi 4 Audio DSP running SoundOpenFirmware. This machine uses MT6359 PMIC, with RT1019 and RT5682 as headphones and speaker codecs/amps. This configuration has been successfully tested on Debian 11 with PipeWire 0.3.56 + wireplumber. `Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com>` Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/213 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/213.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ucm2: Add support for MT8195 Cherry Tomato Chromebook with SOF
by GitHub pull_request - opened 08 Sep '22

08 Sep '22

alsa-project/alsa-ucm-conf pull request #213 was opened from kholk: Add support for the Acer Chromebook Spin 513 CP513-2H, powered by MediaTek Kompanio 1380 (MT8195) with a HiFi 4 Audio DSP running SoundOpenFirmware. This machine uses MT6359 PMIC, with RT1019 and RT5682 as headphones and speaker codecs/amps. This configuration has been successfully tested on Debian 11 with PipeWire 0.3.56 + wireplumber. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno(a)collabora.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/213 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/213.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v2 00/14] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes
by Krzysztof Kozlowski 08 Sep '22

08 Sep '22

Hi, Dependencies/merging ==================== 1. The DTS patches are independent. 2. The binding patches should come together, because of context changes. Could be one of: Qualcomm SoC, ASoC or DT tree. Changes since v1 ================ 1. Patch 9: New patch. 2. Patch 10: Correct also sound/qcom,q6apm-dai.yaml (Rob). 2. Patch 13: New patch. 3. Add Rb/Tb tags. Best regards, Krzysztof Krzysztof Kozlowski (14): arm64: dts: qcom: sdm630: align APR services node names with dtschema arm64: dts: qcom: sdm845: align APR services node names with dtschema arm64: dts: qcom: sm8250: align APR services node names with dtschema arm64: dts: qcom: msm8996: fix APR services nodes arm64: dts: qcom: sdm845: align dai node names with dtschema arm64: dts: qcom: msm8996: align dai node names with dtschema arm64: dts: qcom: qrb5165-rb5: align dai node names with dtschema arm64: dts: qcom: sm8250: use generic name for LPASS clock controller ASoC: dt-bindings:: qcom,q6asm: convert to dtschema dt-bindings: soc: qcom: apr: correct service children ASoC: dt-bindings: qcom,q6dsp-lpass-ports: cleanup example ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: cleanup example ASoC: dt-bindings: qcom,q6apm-dai: adjust indentation in example dt-bindings: soc: qcom: apr: add missing properties .../bindings/soc/qcom/qcom,apr.yaml | 111 +++++++++++++++-- .../bindings/sound/qcom,q6apm-dai.yaml | 21 ++-- .../devicetree/bindings/sound/qcom,q6asm.txt | 70 ----------- .../devicetree/bindings/sound/qcom,q6asm.yaml | 112 ++++++++++++++++++ .../sound/qcom,q6dsp-lpass-clocks.yaml | 36 +++--- .../sound/qcom,q6dsp-lpass-ports.yaml | 64 +++++----- arch/arm64/boot/dts/qcom/msm8996.dtsi | 10 +- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 +- arch/arm64/boot/dts/qcom/sdm630.dtsi | 8 +- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- .../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 2 +- .../boot/dts/qcom/sdm845-xiaomi-polaris.dts | 4 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 10 +- 14 files changed, 293 insertions(+), 169 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml -- 2.34.1

2 17

[PATCH] slimbus: qcom-ngd-ctrl: allow compile testing without QCOM_RPROC_COMMON
by Krzysztof Kozlowski 08 Sep '22

08 Sep '22

The Qualcomm common remote-proc code (CONFIG_QCOM_RPROC_COMMON) has necessary stubs, so it is not needed for compile testing. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- drivers/slimbus/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig index 1235b7dc8496..2ed821f75816 100644 --- a/drivers/slimbus/Kconfig +++ b/drivers/slimbus/Kconfig @@ -22,7 +22,8 @@ config SLIM_QCOM_CTRL config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" - depends on HAS_IOMEM && DMA_ENGINE && NET && QCOM_RPROC_COMMON + depends on HAS_IOMEM && DMA_ENGINE && NET + depends on QCOM_RPROC_COMMON || COMPILE_TEST depends on ARCH_QCOM || COMPILE_TEST select QCOM_QMI_HELPERS select QCOM_PDR_HELPERS -- 2.34.1

2 1

[linux-next:master] BUILD REGRESSION 5957ac6635a1a12d4aa2661bbf04d3085a73372a
by kernel test robot 08 Sep '22

08 Sep '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 5957ac6635a1a12d4aa2661bbf04d3085a73372a Add linux-next specific files for 20220907 Error/Warning reports: https://lore.kernel.org/linux-mm/202209070728.o3stvgVt-lkp@intel.com https://lore.kernel.org/linux-mm/202209080545.qMIVj7YM-lkp@intel.com https://lore.kernel.org/linux-mm/202209080718.y5QmlNKH-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) ERROR: modpost: "__divdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! ERROR: modpost: "__udivdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! arm-linux-gnueabi-ld: vkms_formats.c:(.text+0x824): undefined reference to `__aeabi_ldivmod' arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt.o' being placed in section `.data.rel.ro.local' arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt_ro.o' being placed in section `.data.rel.ro.local' arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.data.rel.ro.local' arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt_wip.o' being placed in section `.data.rel.ro.local' arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from `arch/arm/boot/compressed/fdt.o' being placed in section `.printk_index' arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from `arch/arm/boot/compressed/fdt_ro.o' being placed in section `.printk_index' arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.printk_index' arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from `arch/arm/boot/compressed/fdt_wip.o' being placed in section `.printk_index' drivers/base/regmap/regmap-mmio.c:221:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:224:17: error: implicit declaration of function 'writesw'; did you mean 'writew'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:227:17: error: implicit declaration of function 'writesl'; did you mean 'writel'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:231:17: error: implicit declaration of function 'writesq'; did you mean 'writeq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:231:17: error: implicit declaration of function 'writesq'; did you mean 'writesl'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:358:17: error: implicit declaration of function 'readsb'; did you mean 'readb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:361:17: error: implicit declaration of function 'readsw'; did you mean 'readw'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:364:17: error: implicit declaration of function 'readsl'; did you mean 'readl'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readsl'? [-Werror=implicit-function-declaration] drivers/clk/xilinx/clk-xlnx-clock-wizard.c:431: undefined reference to `devm_platform_ioremap_resource' drivers/gpu/drm/amd/amdgpu/imu_v11_0_3.c:139:6: warning: no previous prototype for 'imu_v11_0_3_program_rlc_ram' [-Wmissing-prototypes] drivers/gpu/drm/drm_atomic_helper.c:802: warning: expecting prototype for drm_atomic_helper_check_wb_connector_state(). Prototype was for drm_atomic_helper_check_wb_encoder_state() instead drivers/gpu/drm/vkms/vkms_plane.c:110 vkms_plane_atomic_update() warn: variable dereferenced before check 'fb' (see line 108) drivers/scsi/qla2xxx/qla_os.c:2854:23: warning: assignment to 'struct trace_array *' from 'int' makes pointer from integer without a cast [-Wint-conversion] fs/btrfs/volumes.c:6549 __btrfs_map_block() error: we previously assumed 'mirror_num_ret' could be null (see line 6376) include/linux/string.h:303:42: warning: 'strnlen' specified bound 4 exceeds source size 3 [-Wstringop-overread] kernel/bpf/memalloc.c:499 bpf_mem_alloc_destroy() error: potentially dereferencing uninitialized 'c'. ld: vkms_formats.c:(.text+0x3ba): undefined reference to `__divdi3' microblaze-linux-ld: vkms_formats.o:(.text+0xc74): undefined reference to `__divdi3' mips-linux-ld: vkms_formats.c:(.text+0x384): undefined reference to `__divdi3' mips-linux-ld: vkms_formats.c:(.text.argb_u16_to_RGB565+0xd0): undefined reference to `__divdi3' sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] vkms_formats.c:(.text+0x266): undefined reference to `__divdi3' vkms_formats.c:(.text+0x364): undefined reference to `__divdi3' vkms_formats.c:(.text+0x390): undefined reference to `__divdi3' vkms_formats.c:(.text+0x804): undefined reference to `__aeabi_ldivmod' vkms_formats.c:(.text.argb_u16_to_RGB565+0xb0): undefined reference to `__divdi3' vkms_formats.o:(.text+0xb28): undefined reference to `__divdi3' xtensa-linux-ld: vkms_formats.c:(.text+0x560): undefined reference to `__divdi3' Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- drivers-scsi-qla2xxx-qla_os.c:warning:assignment-to-struct-trace_array-from-int-makes-pointer-from-integer-without-a-cast | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- alpha-randconfig-r015-20220907 | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw |-- arc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arc-randconfig-r001-20220907 | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arm-allyesconfig | |-- arm-linux-gnueabi-ld:vkms_formats.c:(.text):undefined-reference-to-__aeabi_ldivmod | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | |-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used | `-- vkms_formats.c:(.text):undefined-reference-to-__aeabi_ldivmod |-- arm-buildonly-randconfig-r006-20220907 | |-- arm-linux-gnueabi-ld:warning:orphan-section-data.rel.ro.local-from-arch-arm-boot-compressed-fdt.o-being-placed-in-section-.data.rel.ro.local | |-- arm-linux-gnueabi-ld:warning:orphan-section-data.rel.ro.local-from-arch-arm-boot-compressed-fdt_ro.o-being-placed-in-section-.data.rel.ro.local | |-- arm-linux-gnueabi-ld:warning:orphan-section-data.rel.ro.local-from-arch-arm-boot-compressed-fdt_rw.o-being-placed-in-section-.data.rel.ro.local | |-- arm-linux-gnueabi-ld:warning:orphan-section-data.rel.ro.local-from-arch-arm-boot-compressed-fdt_wip.o-being-placed-in-section-.data.rel.ro.local | |-- arm-linux-gnueabi-ld:warning:orphan-section-printk_index-from-arch-arm-boot-compressed-fdt.o-being-placed-in-section-.printk_index | |-- arm-linux-gnueabi-ld:warning:orphan-section-printk_index-from-arch-arm-boot-compressed-fdt_ro.o-being-placed-in-section-.printk_index | |-- arm-linux-gnueabi-ld:warning:orphan-section-printk_index-from-arch-arm-boot-compressed-fdt_rw.o-being-placed-in-section-.printk_index | `-- arm-linux-gnueabi-ld:warning:orphan-section-printk_index-from-arch-arm-boot-compressed-fdt_wip.o-being-placed-in-section-.printk_index |-- arm-defconfig | `-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead |-- arm64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-imu_v11_0_3.c:warning:no-previous-prototype-for-imu_v11_0_3_program_rlc_ram | |-- drivers-gpu-drm-drm_atomic_helper.c:warning:expecting-prototype-for-drm_atomic_helper_check_wb_connector_state().-Prototype-was-for-drm_atomic_helper_check_wb_encoder_state()-instead | `-- sound-soc-codecs-tas2562.c:warning:variable-ret-set-but-not-used |-- arm64-randconfig-r033-20220907 clang_recent_errors |-- i386-randconfig-a006 | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- i386-randconfig-a013 | `-- ld.lld:error:undefined-symbol:__udivdi3 |-- powerpc-randconfig-r013-20220907 | `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead `-- riscv-randconfig-r021-20220907 `-- drivers-extcon-extcon-usbc-tusb320.c:warning:expecting-prototype-for-drivers-extcon-extcon-tusb320c().-Prototype-was-for-TUSB320_REG8()-instead elapsed time: 723m configs tested: 35 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig i386 defconfig x86_64 rhel-8.3-kselftests x86_64 rhel-8.3-func x86_64 defconfig arc randconfig-r043-20220907 x86_64 rhel-8.3-kunit x86_64 rhel-8.3-kvm x86_64 rhel-8.3 x86_64 rhel-8.3-syz x86_64 randconfig-a013 x86_64 allyesconfig x86_64 randconfig-a011 x86_64 randconfig-a004 m68k allyesconfig arm defconfig m68k allmodconfig alpha allyesconfig powerpc allnoconfig arc allyesconfig ia64 allmodconfig arm allyesconfig arm64 allyesconfig sh allmodconfig mips allyesconfig powerpc allmodconfig i386 allyesconfig clang tested configs: hexagon randconfig-r041-20220907 riscv randconfig-r042-20220907 hexagon randconfig-r045-20220907 s390 randconfig-r044-20220907 i386 randconfig-a013 i386 randconfig-a006 x86_64 rhel-8.3-rust -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

Some Motu M4 have a different usb device ID
by GitHub issues - opened 07 Sep '22

07 Sep '22

alsa-project/alsa-ucm-conf issue #212 was opened from Big-FG: I just wanted to draw some attention regarding the Motu M4 UCM2 profie currently USB-Audio.conf has the M4 with usb id 07fd:000b ``` if.motu-m24 { Condition { Type String Haystack "${CardComponents}" Needle "USB07fd:000b" } True.If.M4 { Condition { Type String Haystack "${CardLongName}" Needle "MOTU M4" } True.Define.ProfileName "MOTU/M4" False.Define.ProfileName "MOTU/M2" } } ``` but mine is apparently different with 07fd:0008 `Bus 003 Device 002: ID 07fd:0008 Mark of the Unicorn M Series` after adjusting the USB-Audio.conf with my usb ID the profile loads and works correctly. Im not sure if mine is just a weird one or how many people this may be the case for. Im fine with modifying the conf myself for my card if this is just specific to me as my unit wasnt purchased new but was a used one so Im not sure what might be different. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/212 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 0/5] ASoC: Fixes for MT8195 SOF support
by AngeloGioacchino Del Regno 07 Sep '22

07 Sep '22

This series fixes Sound Open Firmware support for MT8195 by making sure that the sound card driver is actually able to probe and IPC can finally happen. It is now possible to get DSP support for audio. Tested on MT8195 Tomato - Acer Chromebook Spin 513 CP513-2H (Pipewire). AngeloGioacchino Del Regno (5): ASoC: mediatek: mt8195-mt6359: Properly register sound card for SOF ASoC: SOF: mediatek: mt8195: Import namespace SND_SOC_SOF_MTK_COMMON ASoC: SOF: mediatek: mt8195: Add mailbox generic callbacks for IPC ASoC: SOF: mediatek: mt8195: Add generic pcm_{open,close} callbacks ASoC: SOF: mediatek: mt8195: Add devicetree support to select topologies sound/soc/mediatek/mt8195/mt8195-mt6359.c | 6 +++++ sound/soc/sof/mediatek/mt8195/mt8195.c | 32 ++++++++++++++++------- 2 files changed, 29 insertions(+), 9 deletions(-) -- 2.37.2

2 6

[PATCH] ASoC: ts3a227e: add parameters to control debounce times
by Astrid Rost 07 Sep '22

07 Sep '22

Add devicetree parameters to control the insertion, release and press debounce times. Signed-off-by: Astrid Rost <astrid.rost(a)axis.com> --- sound/soc/codecs/ts3a227e.c | 48 +++++++++++++++++++++++++++++++------ 1 file changed, 41 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c index d8ab0810fceb..fea274a0a91b 100644 --- a/sound/soc/codecs/ts3a227e.c +++ b/sound/soc/codecs/ts3a227e.c @@ -78,12 +78,20 @@ static const int ts3a227e_buttons[] = { #define ADC_COMPLETE_INT_DISABLE 0x04 #define INTB_DISABLE 0x08 +/* TS3A227E_REG_SETTING_1 0x4 */ +#define DEBOUNCE_INSERTION_SETTING_SFT (0) +#define DEBOUNCE_INSERTION_SETTING_MASK (0x7 << DEBOUNCE_PRESS_SETTING_SFT) + /* TS3A227E_REG_SETTING_2 0x05 */ #define KP_ENABLE 0x04 /* TS3A227E_REG_SETTING_3 0x06 */ -#define MICBIAS_SETTING_SFT (3) +#define MICBIAS_SETTING_SFT 3 #define MICBIAS_SETTING_MASK (0x7 << MICBIAS_SETTING_SFT) +#define DEBOUNCE_RELEASE_SETTING_SFT 2 +#define DEBOUNCE_RELEASE_SETTING_MASK (0x1 << DEBOUNCE_RELEASE_SETTING_SFT) +#define DEBOUNCE_PRESS_SETTING_SFT 0 +#define DEBOUNCE_PRESS_SETTING_MASK (0x3 << DEBOUNCE_PRESS_SETTING_SFT) /* TS3A227E_REG_ACCESSORY_STATUS 0x0b */ #define TYPE_3_POLE 0x01 @@ -136,7 +144,7 @@ static bool ts3a227e_volatile_reg(struct device *dev, unsigned int reg) { switch (reg) { case TS3A227E_REG_INTERRUPT ... TS3A227E_REG_INTERRUPT_DISABLE: - case TS3A227E_REG_SETTING_2: + case TS3A227E_REG_SETTING_1 ... TS3A227E_REG_SETTING_2: case TS3A227E_REG_SWITCH_STATUS_1 ... TS3A227E_REG_ADC_OUTPUT: return true; default: @@ -269,16 +277,42 @@ static const struct regmap_config ts3a227e_regmap_config = { static int ts3a227e_parse_device_property(struct ts3a227e *ts3a227e, struct device *dev) { - u32 micbias; + u32 value; + u32 setting3_value = 0; + u32 setting3_mask = 0; int err; - err = device_property_read_u32(dev, "ti,micbias", &micbias); + err = device_property_read_u32(dev, "ti,micbias", &value); if (!err) { - regmap_update_bits(ts3a227e->regmap, TS3A227E_REG_SETTING_3, - MICBIAS_SETTING_MASK, - (micbias & 0x07) << MICBIAS_SETTING_SFT); + setting3_mask = MICBIAS_SETTING_MASK; + setting3_value = + (value << MICBIAS_SETTING_SFT) & MICBIAS_SETTING_MASK; + } + + err = device_property_read_u32(dev, "ti,debounce-release", &value); + if (!err) { + setting3_mask |= DEBOUNCE_RELEASE_SETTING_MASK; + setting3_value |= (value << DEBOUNCE_RELEASE_SETTING_SFT) & + DEBOUNCE_RELEASE_SETTING_MASK; } + err = device_property_read_u32(dev, "ti,debounce-press", &value); + if (!err) { + setting3_mask |= DEBOUNCE_PRESS_SETTING_MASK; + setting3_value |= (value << DEBOUNCE_PRESS_SETTING_SFT) & + DEBOUNCE_PRESS_SETTING_MASK; + } + + if (setting3_mask) + regmap_update_bits(ts3a227e->regmap, TS3A227E_REG_SETTING_3, + setting3_mask, setting3_value); + + err = device_property_read_u32(dev, "ti,debounce-insertion", &value); + if (!err) + regmap_update_bits(ts3a227e->regmap, TS3A227E_REG_SETTING_1, + DEBOUNCE_INSERTION_SETTING_MASK, (value << DEBOUNCE_INSERTION_SETTING_SFT) + & DEBOUNCE_INSERTION_SETTING_MASK); + return 0; } -- 2.20.1

1 0